Timeline
Dec 15, 2013:
- 10:53 PM Changeset in webkit [160631] by
-
- 4 edits2 adds in trunk
Add support for maction@toggle
https://bugs.webkit.org/show_bug.cgi?id=120059
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-12-15
Reviewed by Chris Fleizach.
Source/WebCore:
Test: mathml/presentation/maction-toggle.html
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedChildAndIndex):
(WebCore::MathMLSelectElement::updateSelectedChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents):
(WebCore::MathMLSelectElement::toggle):
- mathml/MathMLSelectElement.h:
LayoutTests:
- mathml/presentation/maction-toggle-expected.html: Added.
- mathml/presentation/maction-toggle.html: Added.
- 10:39 PM Changeset in webkit [160630] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Can't pinch in past the maximum scale
https://bugs.webkit.org/show_bug.cgi?id=125749
Reviewed by Anders Carlsson.
Pinching in past the maximum scale should result in the zoom resisting, but continuing.
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::resistanceForDelta):
Clean up the logic and apply resistance to pinching in past the maximum.
(WebKit::ViewGestureController::handleMagnificationGesture):
(WebKit::ViewGestureController::endMagnificationGesture):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
- 10:34 PM Changeset in webkit [160629] by
-
- 2 edits in trunk/Source/WebCore
More nullptr in RenderElement
https://bugs.webkit.org/show_bug.cgi?id=125764
Reviewed by Andreas Kling.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::destroyLeftoverChildren):
(WebCore::RenderElement::findNextLayer):
Use nullptr in a few more places.
- 9:56 PM Changeset in webkit [160628] by
-
- 20 edits17 adds1 delete in trunk
REGRESSION: 2x regression on Dromaeo DOM query tests
https://bugs.webkit.org/show_bug.cgi?id=125377
Reviewed by Filip Pizlo.
PerformanceTests:
Added a micro-benchmark for updating a named property on document.
- Bindings/update-name-getter.html: Added.
- Skipped:
Source/JavaScriptCore:
The bug was caused by JSC not JIT'ing property access on "document" due to its type info having
HasImpureGetOwnPropertySlot flag.
Fixed the bug by new type info flag NewImpurePropertyFiresWatchpoints, which allows the baseline
JIT to generate byte code for access properties on an object with named properties (a.k.a.
custom name getter) in DOM. When a new named property appears on the object, VM is notified via
VM::addImpureProperty and fires StructureStubClearingWatchpoint added during the repatch.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt): Take the slow path if we have any object with impure
properties in the prototype chain.
(JSC::GetByIdStatus::computeForChain): Ditto.
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess): Throw away the byte code when a new impure property is added on any
object in the prototype chain via StructureStubClearingWatchpoint.
(JSC::generateProtoChainAccessStub): Ditto.
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::tryRepatchIn): Ditto.
- runtime/JSTypeInfo.h: Added NewImpurePropertyFiresWatchpoints.
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints): Added.
- runtime/Operations.h:
(JSC::normalizePrototypeChainForChainAccess): Don't exit early if VM will be notified of new
impure property even if the object had impure properties.
- runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty): Added. Wraps hasImpureGetOwnPropertySlot and
asserts that newImpurePropertyFiresWatchpoints is true whenever hasImpureGetOwnPropertySlot is true.
- runtime/VM.cpp:
(JSC::VM::registerWatchpointForImpureProperty): Added.
(JSC::VM::addImpureProperty): Added. HTMLDocument calls it to notify JSC of a new impure property.
- runtime/VM.h:
Source/WebCore:
The bug was caused by JSC not JIT'ing property accesses on document because of its having
custom named getter (named properties). This resulted in resolution of methods on document
such as getElementById to happen inside the interpreter.
Fixed the bug by using the new JSC type info flag which tells JSC to JIT property access on
document, and then notifying JSC whenever a new named property appeared on document.
Tests: js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html
js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::addImpureProperty): Wraps VM::addImpureProperty.
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Added the support for NewImpurePropertyFiresWatchpoints.
- bindings/scripts/IDLAttributes.txt: Ditto.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem): Calls addImpureProperty.
- html/HTMLDocument.idl: Added NewImpurePropertyFiresWatchpoints.
LayoutTests:
Added more regression tests for throwing away byte code when a new named property appears.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected: Rebaselined.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Fixed the test to use dfgShouldBe.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
- js/dom/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
- 8:58 PM Changeset in webkit [160627] by
-
- 5 edits2 adds in trunk/Tools
Refactor option handling in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=123185
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-15
Reviewed by Darin Adler.
Option handling is refactored (according to the FIXME) that allows
to automatically generate the help message.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/Options.cpp: Added.
(WTR::Options::Options):
(WTR::handleOptionTimeout):
(WTR::handleOptionNoTimeout):
(WTR::handleOptionNoTimeoutAtAll):
(WTR::handleOptionVerbose):
(WTR::handleOptionGcBetweenTests):
(WTR::handleOptionPixelTests):
(WTR::handleOptionPrintSupportedFeatures):
(WTR::handleOptionComplexText):
(WTR::handleOptionAcceleratedDrawing):
(WTR::handleOptionRemoteLayerTree):
(WTR::handleOptionUnmatched):
(WTR::OptionsHandler::OptionsHandler):
(WTR::Option::Option):
(WTR::Option::matches):
(WTR::OptionsHandler::parse):
(WTR::OptionsHandler::printHelp):
- WebKitTestRunner/Options.h: Added.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 8:04 PM Changeset in webkit [160626] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Expose the certificate chain for the main frame
https://bugs.webkit.org/show_bug.cgi?id=125760
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared certificateChain property.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController certificateChain]): Added this getter, which calls through
to WebFrameProxy::certificateInfo.
- 7:28 PM Changeset in webkit [160625] by
-
- 2 edits in trunk/Source/WebCore
[WIn] Unreviewed build fix after r160599
- rendering/RenderMediaControls.cpp:
(WebCore::determineState): RenderObject::theme now returns
a reference.
- 6:28 PM Changeset in webkit [160624] by
-
- 3 edits2 deletes in trunk/Source
Source/WebCore: [Win] Unreviewed build fix
The build system continues to attempt to build QTMovieWin, even
though it is excluded from the build solution. I'm actually
removing the project files to prevent this.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Removed.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.filters: Removed.
Source/WebKit: [Win] Unreviewed build fix.
- WebKit.vcxproj/WebKit.sln: Remove reference to QTMovieWin,
which we do not wish to build.
- 2:34 PM Changeset in webkit [160623] by
-
- 5 edits in trunk
[CSS Shapes] shape-outside animation does not handle 'auto' well
https://bugs.webkit.org/show_bug.cgi?id=125700
Reviewed by Dirk Schulze.
Source/WebCore:
Handle the case where we are blending/animating with a null ShapeValue due to 'auto'.
Adapted LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html for testing this.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
LayoutTests:
Test a shape-outside animation where one keyframe uses 'auto'.
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
- fast/shapes/shape-outside-floats/shape-outside-animation.html:
- 1:13 PM Changeset in webkit [160622] by
-
- 57 edits in trunk/Source/WebKit/mac
[iOS] Upstream changes to WebKit Public and Private headers
https://bugs.webkit.org/show_bug.cgi?id=125745
Reviewed by Dan Bernstein.
- Configurations/WebKit.xcconfig: Ignore headers that are completely
excluded on iOS. This prevents empty headers from being installed into
the iOS SDK.
- DOM/WebDOMOperationsPrivate.h: Upstream iOS changes.
- History/WebBackForwardListPrivate.h: Ditto.
- History/WebHistoryItem.h: Ditto.
- History/WebHistoryItemPrivate.h: Ditto.
- Misc/WebCache.h: Ditto.
- Misc/WebIconDatabase.h: Ditto.
- Misc/WebIconDatabasePrivate.h: Ditto.
- Misc/WebKitNSStringExtras.h: Ditto.
- Misc/WebLocalizableStrings.h: Ditto.
- Misc/WebNSEventExtras.h: Ditto.
- Misc/WebNSFileManagerExtras.h: Ditto.
- Misc/WebNSPasteboardExtras.h: Ditto.
- Misc/WebNSURLExtras.h: Ditto.
- Misc/WebNSViewExtras.h: Ditto.
- Misc/WebNSWindowExtras.h: Ditto.
- Panels/WebPanelAuthenticationHandler.h: Ditto.
- Plugins/WebPlugin.h: Ditto.
- Plugins/WebPluginContainer.h: Ditto.
- Plugins/WebPluginContainerPrivate.h: Ditto.
- Plugins/WebPluginDatabase.h: Ditto.
- Plugins/WebPluginPrivate.h: Ditto.
- Plugins/WebPluginViewFactory.h: Ditto.
- Plugins/WebPluginsPrivate.h: Ditto.
- Storage/WebDatabaseManagerPrivate.h: Ditto.
- WebCoreSupport/WebApplicationCache.h: Ditto.
- WebCoreSupport/WebJavaScriptTextInputPanel.h: Ditto.
- WebCoreSupport/WebKeyGenerator.h: Ditto.
- WebCoreSupport/WebSecurityOriginPrivate.h: Ditto.
- WebView/WebDashboardRegion.h: Ditto.
- WebView/WebDataSource.h: Ditto.
- WebView/WebDataSourcePrivate.h: Ditto.
- WebView/WebDocument.h: Ditto.
- WebView/WebDocumentPrivate.h: Ditto.
- WebView/WebDynamicScrollBarsView.h: Ditto.
- WebView/WebEditingDelegate.h: Ditto.
- WebView/WebEditingDelegatePrivate.h: Ditto.
- WebView/WebFormDelegate.h: Ditto.
- WebView/WebFrameLoadDelegate.h: Ditto.
- WebView/WebFramePrivate.h: Ditto.
- WebView/WebFrameView.h: Ditto.
- WebView/WebFrameViewPrivate.h: Ditto.
- WebView/WebHTMLRepresentation.h: Ditto.
- WebView/WebHTMLView.h: Ditto.
- WebView/WebHTMLViewPrivate.h: Ditto.
- WebView/WebPolicyDelegate.h: Ditto.
- WebView/WebPreferenceKeysPrivate.h: Ditto.
- WebView/WebPreferences.h: Ditto.
- WebView/WebPreferencesPrivate.h: Ditto.
- WebView/WebRenderLayer.h: Ditto.
- WebView/WebResourceLoadDelegatePrivate.h: Ditto.
- WebView/WebResourcePrivate.h: Ditto.
- WebView/WebUIDelegate.h: Ditto.
- WebView/WebUIDelegatePrivate.h: Ditto.
- WebView/WebView.h: Ditto.
- WebView/WebViewPrivate.h: Ditto.
- 1:08 PM Changeset in webkit [160621] by
-
- 8 edits in trunk/Source
[iOS] Upstream changes to FeatureDefines.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=125742
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 10:27 AM Changeset in webkit [160620] by
-
- 3 edits in trunk/Tools
32-bit build fix.
- TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
- TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
- 10:16 AM Changeset in webkit [160619] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for 32-bit clients.
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
- 8:40 AM Changeset in webkit [160618] by
-
- 4 edits2 adds in trunk
Crash in CSSImageGeneratorValue and RenderScrollbar
https://bugs.webkit.org/show_bug.cgi?id=125702
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This crash had two causes at two different levels. The crash fixes both.
At the RenderScrollbar level, we were setting up a new renderer, a
RenderScrollbarPart, and never calling initializeStyle. This meant that
we did not do proper style setup, which meant we did not end up calling
CSSImageGeneratorValue::addClient and so had a removeClient that was not
properly balanced by an addClient. This is the primary bug.
At the CSSImageGeneratorValue level, the addClient and removeClient
functions were not properly handling possibly-mismatched calls. It was
easy to fix the functions to work even if the calls are not perfectly
matched up, which makes the consequences of a missed addClient call
much less dire, no longer messing up reference counting. Fixing this
mitigates the risk if we made this same mistake elsewhere, although I
could not find any other places with some quick searches.
Test: fast/css/scrollbar-image-crash.html
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient): Only call ref if this will
add the first client.
(WebCore::CSSImageGeneratorValue::removeClient): Only call deref if this
removes the last client. Also added an assertion that can fire if we call
removeClient without first calling addClient, which is illegal. However,
the function handles that case without over-deref'ing itself.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart): Simplify the logic for
needRenderer a bit. Use initializeStyle rather than setStyle when first
creating the RenderScrollbarPart. Also use add and take properly so we
don't do extra hash lookups the old code did with get/set and get/remove.
LayoutTests:
- fast/css/scrollbar-image-crash-expected.txt: Added.
- fast/css/scrollbar-image-crash.html: Added.
- 4:48 AM Changeset in webkit [160617] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r160608.
- UIProcess/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::guessesForWord):
Dec 14, 2013:
- 10:32 PM Changeset in webkit [160616] by
-
- 4 edits1 copy in trunk/Source/WebKit2
Add page load delegate for WebProcessPlugInBrowsingContextController.
https://bugs.webkit.org/show_bug.cgi?id=125697
Add page load delegate for WebProcessPlugInBrowsingContextController so that a
WebProcess injected bundle can listen to page load events.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-12-14
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Added.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didStartProvisionalLoadForFrame):
(didFinishLoadForFrame):
(globalObjectIsAvailableForFrame):
(setUpPageLoaderClient):
(-[WKWebProcessPlugInBrowserContextController loadDelegate]):
(-[WKWebProcessPlugInBrowserContextController setLoadDelegate:]):
- 10:20 PM Changeset in webkit [160615] by
-
- 12 edits in trunk/Source/WebCore
CTTE: SVGResourcesCache::cachedResourcesForRenderObject() should take a reference
https://bugs.webkit.org/show_bug.cgi?id=125743
Patch by Sam Weinig <sam@webkit.org> on 2013-12-14
Reviewed by Dan Bernstein.
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageChanged):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::requestPaintingResource):
(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
(WebCore::RenderSVGShape::markerRect):
(WebCore::RenderSVGShape::drawMarkers):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::invalidateResourcesOfChildren):
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources):
(WebCore::SVGRenderSupport::filtersForceContainerLayout):
(WebCore::SVGRenderSupport::pointInClippingArea):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject):
(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientDestroyed):
- rendering/svg/SVGResourcesCache.h:
- rendering/svg/SVGResourcesCycleSolver.cpp:
(WebCore::SVGResourcesCycleSolver::resourceContainsCycles):
- 9:56 PM Changeset in webkit [160614] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed build fix
QTMovieWin should not be build at the moment, but some builders
are continuing to attempt it. This change marks the project
file as excluded from building.
- WebKit.vcxproj/WebKit.sln: Mark QTMovieWin as excluded from build.
- 9:41 PM Changeset in webkit [160613] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should *really* know when things are flushed
https://bugs.webkit.org/show_bug.cgi?id=125747
Reviewed by Sam Weinig.
Fix more codegen badness. This makes V8v7's crypto am3() function run faster in the FTL
than in DFG. This means that even if we just compile those functions in V8v7 that don't
make calls, the FTL gives us a 2% speed-up over the DFG. That's pretty good considering
that we have still more optimizations to fix and we can make calls work.
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- 9:29 PM Changeset in webkit [160612] by
-
- 2 edits in trunk/LayoutTests
[Win] Disable media tests while we sort out QTSDK issues.
Unreviewed patch to get test bots green
- platform/win/TestExpectations
- 8:47 PM Changeset in webkit [160611] by
-
- 2 edits1 add in trunk/Tools
stylebot should warn when FeatureDefines differ
https://bugs.webkit.org/show_bug.cgi?id=125748
Reviewed by Dan Bernstein.
Add a stylebot checker that ensures that FeatureDefines.xcconfig files
are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
an unlikely occurrance, to add them to the list).
It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
but that is the most straightforward way to implement it (and we're at zero diffs right now).
- Scripts/webkitpy/style/checker.py:
(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):
- Scripts/webkitpy/style/checkers/featuredefines.py: Added.
(FeatureDefinesChecker):
(FeatureDefinesChecker.init):
(FeatureDefinesChecker.check):
- 7:08 PM Changeset in webkit [160610] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
FTL should *really* know when things are flushed
https://bugs.webkit.org/show_bug.cgi?id=125747
Not yet reviewed.
Fix more codegen badness. This makes V8v7's crypto am3() function run faster in the FTL
than in DFG. This means that even if we just compile those functions in V8v7 that don't
make calls, the FTL gives us a 2% speed-up over the DFG. That's pretty good considering
that we have still more optimizations to fix and we can make calls work.
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- 5:16 PM Changeset in webkit [160609] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Implement NetworkProcess::allowSpecificHTTPSCertificateForHost
https://bugs.webkit.org/show_bug.cgi?id=125744
Reviewed by Sam Weinig.
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost): Implemented by calling
+[NSURLRequest setAllowsSpecificHTTPSCertificate:forHost:].
- 5:09 PM Changeset in webkit [160608] by
-
- 43 edits1 move in trunk/Source/WebKit2
[WK2] Rename WebString to API::String
https://bugs.webkit.org/show_bug.cgi?id=125726
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
- Shared/API/c/WKPluginInformation.cpp:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/WKString.cpp:
- Shared/API/c/cf/WKStringCF.mm:
- Shared/APIArray.cpp:
- Shared/APIArray.h:
- Shared/APIString.h: Copied from Source/WebKit2/Shared/WebString.h.
- Shared/Cocoa/WKNSString.h:
- Shared/Cocoa/WKNSString.mm:
- Shared/ImmutableDictionary.cpp:
- Shared/Plugins/Netscape/PluginInformation.cpp:
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
- Shared/UserData.cpp:
- Shared/UserMessageCoders.h:
- Shared/WebArchiveResource.h:
- Shared/WebOpenPanelParameters.cpp:
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- Shared/WebString.h: Removed.
- UIProcess/API/C/WKCredential.cpp:
- UIProcess/API/C/WKDatabaseManager.cpp:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
- UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
- UIProcess/APINavigationData.h:
- UIProcess/Authentication/WebCredential.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
- UIProcess/WebContext.cpp:
- UIProcess/WebDatabaseManagerProxy.cpp:
- UIProcess/WebFormClient.cpp:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebUIClient.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
- 4:43 PM Changeset in webkit [160607] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Unreviewed, revert r156746, "FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check."
This introduces redundancies that LLVM can't handle. Reverting this change brings the
FTL up to being on-par with the DFG on V8v7/encrypt.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
- 4:21 PM Changeset in webkit [160606] by
-
- 2 edits in trunk/Source/WebCore
Clean up the project after r160487
- WebCore.xcodeproj/project.pbxproj: Moved reference to Security.framework from the top
level of the project to the Frameworks group, and made it SDK-relative.
- 4:11 PM Changeset in webkit [160605] by
-
- 6 edits in trunk/Source
Unify FeatureDefines.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=125741
Rubber-stamped by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Enable ENABLE_MEDIA_SOURCE.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Remove a stray space in
FEATURE_DEFINES.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Remove a space in
FEATURE_DEFINES and fix a typo in ENABLE_CSS3_TEXT_DECORATION.
- 3:57 PM Changeset in webkit [160604] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix.
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared
observedRenderingProgressEvents as nonatomic.
- 3:28 PM Changeset in webkit [160603] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Expose WebContext::allowSpecificHTTPSCertificateForHost
https://bugs.webkit.org/show_bug.cgi?id=125738
Reviewed by Mark Rowe.
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Added. Calls through to
WebContext::allowSpecificHTTPSCertificateForHost.
- UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Declared new method.
- 3:24 PM Changeset in webkit [160602] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Expose some layout milestones
https://bugs.webkit.org/show_bug.cgi?id=125721
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKBrowsingContextController.h:
(WKRenderingProgressEvents): Declared new enum.
(@interface WKBrowsingContextController): Declared new observedRenderingProgressEvents
property.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(layoutMilestones): Added helper to translate rendering progress events into layout
milestones.
(-[WKBrowsingContextController setObservedRenderingProgressEvents:]): Added this setter.
Sets the ivar and calls WebPageProxy::listenForLayoutMilestones.
(renderingProgressEvents): Added helper to translate layout milestones into rendering
progress events.
(didLayout): Implemented this WKPageLoaderClient callback by calling the load delegate.
(setUpPageLoaderClient): Set the above callback in the client structure.
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Declared new delegate method.
- 1:49 PM Changeset in webkit [160601] by
-
- 2 edits in trunk/Source/WebKit2
Clarify Owners’ role
https://bugs.webkit.org/show_bug.cgi?id=125739
Reviewed by Anders Carlsson.
- Owners: Clarify that a patch authored by an Owner does not have to be reviewed by one, as
decided during the 2013 WebKit Contributors Meeting.
- 1:38 PM Changeset in webkit [160600] by
-
- 31 edits in branches/jsCStack
cStack: Calling into FTL-generated code should be fast
https://bugs.webkit.org/show_bug.cgi?id=125649
Not yet reviewed.
- assembler/AbstractMacroAssembler.h:
- bytecode/StructureStubInfo.h:
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- ftl/FTLAbbreviations.h:
(JSC::FTL::arrayType):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::withVirtualRegister):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::initializeEntrypoint):
(JSC::FTL::JITCode::initializeAddressForCall):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(JSC::FTL::LowerDFGToLLVM::addressFor):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLOutput.h:
(JSC::FTL::Output::ptrToInt):
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h:
- ftl/FTLState.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h:
- heap/Heap.cpp:
(JSC::Heap::collectIfNecessaryOrDefer):
- heap/Heap.h:
(JSC::Heap::isDeferred):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlineCacheGenerator.h:
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
(JSC::emitPutTransitionStub):
- runtime/JSCJSValue.h:
- runtime/Options.h:
- 10:58 AM Changeset in webkit [160599] by
-
- 42 edits in trunk/Source
Page::theme() should return a reference.
<https://webkit.org/b/125737>
There's always a RenderTheme, and not a single call site was checking
for null pointers anyway. Updated RenderObject::theme() as well.
Reviewed by Antti Koivisto.
- 10:05 AM Changeset in webkit [160598] by
-
- 53 edits in trunk/Source/WebCore
CTTE: Convert Element and RenderObject iterator usage to use range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=125731
Reviewed by Andreas Kling.
Perform straight forward conversions. A few stragglers that do odd things remain.
- 9:53 AM Changeset in webkit [160597] by
-
- 4 edits in trunk/Source/WebCore
Small string improvements to JSInjectedScriptHost::type and other bindings
https://bugs.webkit.org/show_bug.cgi?id=125722
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-14
Reviewed by Timothy Hatcher.
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
Use SmallStrings, jsNontrivialString and ASCIILiteral.
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::type):
Use jsNontrivialString.
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::stringValue):
Use jsNontrivialString and ASCIILiteral.
- 4:40 AM Changeset in webkit [160596] by
-
- 4 edits in trunk/Source/WebCore
Move a couple of inlines from RenderObject to RenderElement.
<https://webkit.org/b/125734>
Take most of the inline functions on RenderObject that call style()
and move them over to RenderElement where style() is branchless.
Reviewed by Antti Koivisto.
- 4:39 AM Changeset in webkit [160595] by
-
- 6 edits in trunk/Source/WebCore
RenderElement::rendererForRootBackground() should return a reference.
<https://webkit.org/b/125735>
This function always finds a renderer to return.
Reviewed by Antti Koivisto.
- 2:13 AM Changeset in webkit [160594] by
-
- 4 edits in trunk/Source
Build fix after r160557.
Source/JavaScriptCore:
r160557 added the first generated header to JavaScriptCore that needs to be installed in to
the framework wrapper. Sadly JavaScriptCore's Derived Sources target was not set to generate
headers when invoked as part of the installhdrs action. This resulted in the build failing
due to Xcode being unable to find the header file to install. The fix for this is to configure
the Derived Sources target to use JavaScriptCore.xcconfig, which sets INSTALLHDRS_SCRIPT_PHASE
to YES and allows Xcode to generate derived sources during the installhdrs action.
Enabling INSTALLHDRS_SCRIPT_PHASE required tweaking the Generate Derived Sources script build
phase to skip running code related to offlineasm that depends on JSCLLIntOffsetExtractor
having been compiled, which isn't the case at installhdrs time.
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- Configurations/WebCore.xcconfig: Find JavaScriptCore.framework below SDKROOT so that we'll pick
up the built version in production builds rather than the system version.
- 1:03 AM Changeset in webkit [160593] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Use GMutexLocker instead of g_mutex_lock
https://bugs.webkit.org/show_bug.cgi?id=125588
Reviewed by Philippe Normand.
No new tests because this is just code simplification.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStart):
Dec 13, 2013:
- 11:53 PM Changeset in webkit [160592] by
-
- 8 edits in trunk
Some Set and Map prototype functions have incorrect function lengths
https://bugs.webkit.org/show_bug.cgi?id=125732
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-13
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
LayoutTests:
- js/basic-map-expected.txt:
- js/basic-set-expected.txt:
- js/script-tests/basic-map.js:
- js/script-tests/basic-set.js:
- 11:43 PM Changeset in webkit [160591] by
-
- 10 edits in branches/jsCStack/Source
CStack Branch: Remove WTF_USE_SEPARATE_C_AND_JS_STACK
https://bugs.webkit.org/show_bug.cgi?id=125733
Reviewed by Mark Lam.
WTF_USE_SEPARATE_C_AND_JS_STACK is only set for ENABLE(LLINT_C_LOOP) and is
therefore not needed. Replaced #if USE(SEPARATE_C_AND_JS_STACK) with
#if ENABLE(LLINT_C_LOOP) and eliminated WTF_USE_SEPARATE_C_AND_JS_STACK.
Source/JavaScriptCore:
- assembler/MaxFrameExtentForSlowPathCall.h:
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- interpreter/JSStack.cpp:
(JSC::JSStack::gatherConservativeRoots):
- interpreter/JSStackInlines.h:
(JSC::JSStack::updateStackLimit):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WTF:
- wtf/Platform.h:
- 11:29 PM Changeset in webkit [160590] by
-
- 5 edits in trunk/Source/WebCore
Move RenderObject::repaintAfterLayoutIfNeeded() to RenderElement.
<https://webkit.org/b/125712>
This function is only ever called on RenderElements, so move it there.
Removes some RenderObject::style() branchiness.
Reviewed by Darin Adler.
- 11:17 PM Changeset in webkit [160589] by
-
- 5 edits in branches/jsCStack/Source
cStack: Crypto crashes in GC
https://bugs.webkit.org/show_bug.cgi?id=125730
Reviewed by Filip Pizlo.
Need to disable visiting the JSStack when we are on the C stack.
Made visiting the JSStack conditional on USE(SEPARATE_C_AND_JS_STACK)
and then turned off WTF_USE_SEPARATE_C_AND_JS_STACK in platform.h.
Source/JavaScriptCore:
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- interpreter/JSStack.cpp:
(JSC::JSStack::gatherConservativeRoots):
Source/WTF:
- wtf/Platform.h:
- 10:50 PM Changeset in webkit [160588] by
-
- 26 edits2 moves1 add in trunk
Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=125707
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- inspector/protocol/Debugger.json: Renamed from Source/WebCore/inspector/protocol/Debugger.json.
- inspector/protocol/GenericTypes.json: Added.
- inspector/protocol/InspectorDomain.json: Renamed from Source/WebCore/inspector/protocol/InspectorDomain.json.
Add new files to inspector generation.
- inspector/scripts/CodeGeneratorInspector.py:
(Generator.go):
Only build TypeBuilder output if the domain only has types. Avoid
backend/frontend dispatchers and backend commands.
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(format_setter_value_expression):
(Generator.process_command):
(Generator.generate_send_method):
- inspector/scripts/CodeGeneratorInspectorStrings.py:
Export and name the get{JS,Web}EnumConstant function.
Source/WebCore:
- Switch TypeBuilder::Page::SearchMatch to TypeBuilder::GenericTypes::SearchMatch which comes from InspectorJSTypeBuilders.
- Remove domains that moved to JavaScriptCore.
No new tests, this only moves code around. There are no functional changes.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
Add new files.
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
- inspector/ContentSearchUtils.h:
- inspector/InspectorAgent.cpp:
- inspector/InspectorAgent.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResource):
- inspector/InspectorPageAgent.h:
- inspector/protocol/Page.json:
Update includes and type builder type names.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::breakpointActionTypeForString):
(WebCore::InspectorDebuggerAgent::searchInContent):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
Use the new getEnum function names.
Source/WebInspectorUI:
- UserInterface/InspectorJSBackendCommands.js:
- UserInterface/InspectorWebBackendCommands.js:
Regenerate now that domains have moved around.
LayoutTests:
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.checkForError):
Since having a protocol error is likely wrong, make the output
for it as detailed as possible.
- 10:33 PM Changeset in webkit [160587] by
-
- 32 edits in trunk/Source/JavaScriptCore
Get rid of forward exit on UInt32ToNumber by adding an op_unsigned bytecode instruction
https://bugs.webkit.org/show_bug.cgi?id=125553
Reviewed by Oliver Hunt.
UInt32ToNumber was a super complicated node because it had to do a speculation, but it
would do it after we already had computed the urshift. It couldn't just back to the
beginning of the urshift because the inputs to the urshift weren't necessarily live
anymore. We couldn't jump forward to the beginning of the next instruction because the
result of the urshift was not yet unsigned-converted.
For a while we solved this by forward-exiting in UInt32ToNumber. But that's really
gross and I want to get rid of all forward exits. They cause a lot of bugs.
We could also have turned UInt32ToNumber to a backwards exit by forcing the inputs to
the urshift to be live. I figure that this might be a bit too extreme.
So, I just created a new place that we can exit to: I split op_urshift into op_urshift
followed by op_unsigned. op_unsigned is an "unsigned cast" along the lines of what
UInt32ToNumber does. This allows me to get rid of all of the nastyness in the DFG for
forward exiting in UInt32ToNumber.
This patch enables massive code carnage in the DFG and FTL, and brings us closer to
eliminating one of the DFG's most confusing concepts. On the flipside, it does make the
bytecode slightly more complex (one new instruction). This is a profitable trade. We
want the DFG and FTL to trend towards simplicity, since they are both currently too
complicated.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/ValueRecovery.cpp:
(JSC::ValueRecovery::dumpInContext):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::gpr):
- bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
(JSC::emitReadModifyAssignment):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGNodeType.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
(JSC::DFG::StrengthReductionPhase::convertToIdentityOverChild):
(JSC::DFG::StrengthReductionPhase::convertToIdentityOverChild1):
(JSC::DFG::StrengthReductionPhase::convertToIdentityOverChild2):
- ftl/FTLFormattedValue.h:
(JSC::FTL::int32Value):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
- ftl/FTLValueFormat.cpp:
(JSC::FTL::reboxAccordingToFormat):
(WTF::printInternal):
- ftl/FTLValueFormat.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emitSlow_op_unsigned):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emitSlow_op_unsigned):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
- 10:25 PM Changeset in webkit [160586] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
cStack: Crypto doesn't work at all unless LLInt is disabled
https://bugs.webkit.org/show_bug.cgi?id=125729
Reviewed by Filip Pizlo.
At the end of the functionArityCheck() macro, updated the stack pointer with the
amount the frame moved. This change has already been made in the
arityFixup thunk generator.
- llint/LowLevelInterpreter64.asm:
- 8:55 PM Changeset in webkit [160585] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Exception: TypeError: undefined is not a function (evaluating 'marker.find()')
https://bugs.webkit.org/show_bug.cgi?id=125724
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-13
Reviewed by Darin Adler.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
The callback changed to returning WebInspector.TextMarkers, however
this class expected a raw CodeMirror marker. Since this class knows
about CodeMirror and expects to access these markers later go
directly to the CodeMirror marker.
- 8:42 PM Changeset in webkit [160584] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Fix the build and enable the NetworkProcess by default on iOS
https://bugs.webkit.org/show_bug.cgi?id=125723
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-13
Reviewed by Sam Weinig.
- Configurations/WebKit2.xcconfig:
Fix the list of excluded file to get the processes building.
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHosAt):
Update PlatformCertificateInfo->CertificateInfo match the new name after r159647.
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
Enable the NetworkProcess by default.
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::shouldUseXPC):
Use the right macro.
- WebKit2Prefix.h:
Eanble the flags NETWORK_PROCESS and CUSTOM_PROTOCOLS.
- 7:41 PM Changeset in webkit [160583] by
-
- 2 edits in trunk/Source/WebKit2
Demoted ActivityAssertion.h to a project header.
Rubber-stamped by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- 7:16 PM Changeset in webkit [160582] by
-
- 2 edits in trunk/Tools
Fix API tests.
- TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
(TestWebKitAPI::TEST_F):
- 7:14 PM Changeset in webkit [160581] by
-
- 10 edits in trunk
Source/WebCore: [Win] Remove pre-VS2013 support code.
https://bugs.webkit.org/show_bug.cgi?id=125693
Reviewed by Darin Adler.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota): Use C99 format arguments
- loader/FTPDirectoryParser.cpp:
(WebCore::parseOneFTPLine): Ditto
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::pruneUnretainedIcons): Ditto
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setMaximumSize): Ditto
Source/WTF: [Win] Remove Pre-VS2013 support code.
https://bugs.webkit.org/show_bug.cgi?id=125693
Reviewed by Darin Adler.
- wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::vprintf): Use va_copy, like a civilized person.
Tools: [Win] Remove Pre-VS2013 support code.
https://bugs.webkit.org/show_bug.cgi?id=125693
Reviewed by Darin Adler.
- DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
the math library.
- DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
- 6:53 PM Changeset in webkit [160580] by
-
- 2 edits in trunk/Source/WTF
Incorrect handling of non-ASCII characters in WTF::base64DecodeInternal
https://bugs.webkit.org/show_bug.cgi?id=125658
Reviewed by Alexey Proskuryakov.
- wtf/text/Base64.cpp:
(WTF::base64EncodeInternal): Use a reference to an array instead of a pointer
for the table argument type so we check the size of the array at the call site.
(WTF::base64DecodeInternal): Ditto. Also added an bounds check before using the
table so we don't load some random value for non-ASCII characters.
- 6:02 PM Changeset in webkit [160579] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Unreviewed build fix for VS2013
- win/lib32/WebKitSystemInterface.lib: Updated to use VS2013 _MSC_VER symbols
for linking.
- 5:53 PM Changeset in webkit [160578] by
-
- 2 edits in trunk/Source/WebCore
SVG bindings are improperly being generated with "fastGetAttribute"
https://bugs.webkit.org/show_bug.cgi?id=125670
Reviewed by Darin Adler.
A bug was introduced in r152845 that improperly called the
IsSVGAnimatedType using the $attribute hash, rather than the
expected $attribute->signature->type.
- bindings/scripts/CodeGenerator.pm:
(GetterExpression): Clean up attribute type confusion.
- 5:43 PM Changeset in webkit [160577] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r160548
- WebCore.vcxproj/WebCore.vcxproj: Exclude MediaPlayerPrivateQuickTimeVisualContext from
Windows build.
- platform/graphics/MediaPlayer.cpp: Don't use QuickTime as the PlatformMediaEngine.
- 5:23 PM Changeset in webkit [160576] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build correction after r160548.
- WebKit.vcxproj/WebKit/WebKitApple.props: Exclude linking with QTMoveWin, which does
not build with VS2013.
- 5:16 PM Changeset in webkit [160575] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build correction after r160548
- WebKit.vcxproj/WebKit.sln: Revise build order to avoid errors with ANGLE included.
- 5:01 PM Changeset in webkit [160574] by
-
- 9 edits in trunk/Source
[Win] Unreviewed build fix after r160548
Source/ThirdParty/ANGLE:
I missed the ANGLE files, since we aren't building these
on the Apple Windows port at the moment.
- ANGLE.vcxproj/libEGL.vcxproj: Update to VS2013
- ANGLE.vcxproj/libGLESv2.vcxproj: Ditto
- ANGLE.vcxproj/preprocessor.vcxproj: Ditto
- ANGLE.vcxproj/translator_common.vcxproj: Ditto
- ANGLE.vcxproj/translator_glsl.vcxproj: Ditto
- ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto
Source/WebKit:
- WebKit.vcxproj/WebKit.sln: Revised to build under VS2013.
- 4:39 PM Changeset in webkit [160573] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
Fix exception handling for the LLINT.
https://bugs.webkit.org/show_bug.cgi?id=125672.
Reviewed by Geoffrey Garen.
The baseline JIT exception handling is still broken.
- JavaScriptCore.order:
- llint/LLIntSlowPaths.cpp:
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- updated the 32bit file with some of the changes to keep track with the 64bit one though it doesn't build yet. The build failure will clearly tell us some of the things that need to be fixed later.
- llint/LowLevelInterpreter64.asm:
- Called restoreStackPointerAfterCall() in op_catch and nativeCallTrampoline to restore the appropriate stack pointer.
- Renamed the restoreStackPointerAfterJSCall() macro to restoreStackPointerAfterCall because we also need to call it after a call to a native / host function.
- Removed llint_throw_from_native_call because it no longer does anything useful.
- Moved call to functionEpilogue() in nativeCallTrampoline before the exception check because we should have returned from the native / host function already.
The Interpreter::unwind() code also relies on this. The VM will unwind and "pop"
JS frames, but will stop at host frames. The host frame should pop itself. Then,
we call Interpreter::unwind() again to continue for caller frames further up
the stack.
- Removed the check for the sentinel frame in handleUncaughtException because we're guaranteed to be at the frame above the sentinel frame.
- 3:59 PM Changeset in webkit [160572] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Start removing calls to String::characters()
https://bugs.webkit.org/show_bug.cgi?id=125699
Reviewed by Anders Carlsson.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::decodePlatformData):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
(WebKit::PluginInfoStore::findPlugin):
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::pluginsDirectories):
(WebKit::PluginInfoStore::pluginPathsInDirectory):
- UIProcess/cf/WebPreferencesCF.cpp:
(WebKit::makeKey):
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadStringImpl):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadAlternateHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::loadWebArchiveData):
- WebProcess/WebPage/WebPage.h:
- 3:57 PM Changeset in webkit [160571] by
-
- 3 edits in trunk/Source/JavaScriptCore
LLInt should not conditionally branch to to labels outside of its function
https://bugs.webkit.org/show_bug.cgi?id=125713
Reviewed by Geoffrey Garen.
Conditional branches are insufficient for jumping to out-of-function labels.
The fix is to use an unconditional jmp to the label combined with a conditional branch around the jmp.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 3:56 PM Changeset in webkit [160570] by
-
- 2 edits in trunk/Websites/webkit.org
Update build instructions for Windows following upgrade to VS2013.
- building/tools.html:
- 3:29 PM Changeset in webkit [160569] by
-
- 2 edits in trunk/Tools
Update Webkit bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:28 PM Changeset in webkit [160568] by
-
- 6 edits in trunk
[GTK] Remove Warnings in building about duplicate INSPECTOR variables
https://bugs.webkit.org/show_bug.cgi?id=125710
Reviewed by Tim Horton.
- GNUmakefile.am:
Source/JavaScriptCore:
- GNUmakefile.am:
Source/WebCore:
- GNUmakefile.am:
- 3:04 PM Changeset in webkit [160567] by
-
- 6 edits in trunk
[WebGL] Check for global variable precision mismatch between vertex and fragment shaders.
https://bugs.webkit.org/show_bug.cgi?id=125546.
<rdar://problem/15203364>
Reviewed by Brent Fulgham.
Covered Khronos conformances tests:
webgl/1.0.2/glsl/misc/shader-with-global-variable-precision-mismatch.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::linkProgram):
- platform/graphics/GraphicsContext3D.h: Rename areProgramSymbolsValid since it currently only serves one purpose.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::precisionsMatch):
- platform/mac/TestExpectations:
Unskip webgl/1.0.2/glsl/misc/shader-with-global-variable-precision-mismatch.html
- 2:09 PM Changeset in webkit [160566] by
-
- 13 edits in trunk/Source/WebKit2
WK2: Add support for inline candidates on iOS.
https://bugs.webkit.org/show_bug.cgi?id=125667
Reviewed by Benjamin Poulain.
The state required to support inline candidates is cached in the UI process.
Asynchronous messages are used to set and confirm the composition.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView textFirstRect]):
(-[WKInteractionView textLastRect]):
(-[WKInteractionView hasMarkedText]):
(-[WKInteractionView markedText]):
(-[WKInteractionView setMarkedText:selectedRange:]):
(-[WKInteractionView unmarkText]):
(-[WKInteractionView _selectionChanged]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::notifyRevealedSelection):
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::notifyRevealedSelectionByScrollingFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setComposition):
(WebKit::WebPage::confirmComposition):
- 1:57 PM Changeset in webkit [160565] by
-
- 2 edits in trunk/Source/JavaScriptCore
Cleanup CodeGeneratorInspectorStrings a bit
https://bugs.webkit.org/show_bug.cgi?id=125705
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-13
Reviewed by Timothy Hatcher.
- inspector/scripts/CodeGeneratorInspectorStrings.py:
Use ${foo} variable syntax and add an ASCIILiteral.
- 1:52 PM Changeset in webkit [160564] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed build fix after r160563
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Missed the Debug
target in my last patch.
- 1:49 PM Changeset in webkit [160563] by
-
- 10 edits in trunk
[Win] Unreviewed build fix after r160548
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Specify
that we are using the vs12_xp target for Makefile-based projects.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Ditto
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Ditto.
Source/WebCore:
- WebCore.vcxproj/WebCoreGenerated.vcxproj: Specify that we are
using the vs120_xp build target for Makefile-based projects.
Source/WTF:
- WTF.vcxproj/WTFGenerated.vcxproj: Specify that we are using
the vs12_xp target for Makefile-based projects.
Tools:
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
we are using vs12_xp target for Makefile-based projects.
- 1:36 PM Changeset in webkit [160562] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
jsCStack:REGRESSION: "print(“My object: “ + { });” crashes LLINT in op_call
https://bugs.webkit.org/show_bug.cgi?id=125694
Reviewed by Filip Pizlo.
We were clobbering the rbx value saved on the stack at the top of callToJavaScript
and callToNativeFunction. This is due to a difference between the JSStack's notion
of top of stack being the first usable location and the stack pointer register
pointing to the last used location. I changed the allocation of the sentinel frame
accordingly.
In the process I cleaned up the rounding of paddedArgsCount in ProtoCallFrame::init
to use WTF::roundUpToMultipleOf<> since the rounding had to change to keep the stack
pointer aligned.
- interpreter/ProtoCallFrame.cpp:
(JSC::ProtoCallFrame::init):
- llint/LowLevelInterpreter64.asm:
- 1:36 PM Changeset in webkit [160561] by
-
- 5 edits in trunk/Source/WTF
Require variadic templates to build WebKit
https://bugs.webkit.org/show_bug.cgi?id=125701
Reviewed by Andreas Kling.
- wtf/Compiler.h:
Add an #error if variadic templates are disabled.
- wtf/NeverDestroyed.h:
- wtf/PassRef.h:
- wtf/StdLibExtras.h:
Remove a bunch of COMPILER_SUPPORTS(CXX_VARIADIC_TEMPLATES) #ifdefs.
- 1:26 PM Changeset in webkit [160560] by
-
- 2 edits in trunk/Tools
Update Apple Webkit Bots
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:18 PM Changeset in webkit [160559] by
-
- 2 edits in trunk/Source/WebKit
Post-process exported WebKit headers based on PLATFORM_NAME
https://bugs.webkit.org/show_bug.cgi?id=125682
Reviewed by Dan Bernstein.
Added a build phase that calls unifdef(1) on each of WebKit's Public
and Private headers, defining TARGET_OS_EMBEDDED, TARGET_OS_IPHONE, and
TARGET_IPHONE_SIMULATOR based on the value of PLATFORM_NAME. This has
the effect of stripping out bits not needed by the SDK being built for.
- WebKit.xcodeproj/project.pbxproj:
- 1:08 PM Changeset in webkit [160558] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make inspector folder groups smarter in JavaScriptCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=125663
Reviewed by Darin Adler.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:07 PM Changeset in webkit [160557] by
-
- 78 edits7 moves6 adds in trunk
Web Inspector: Add Inspector Code Generation to JavaScriptCore for Runtime Domain
https://bugs.webkit.org/show_bug.cgi?id=125595
Reviewed by Timothy Hatcher.
- GNUmakefile.am:
Source/JavaScriptCore:
- Move CodeGeneration scripts from WebCore into JavaScriptCore/inspector/scripts
- For ports that build WebKit frameworks separately, export the scripts as PrivateHeaders
- Update CodeGeneratorInspector.py in a few ways:
- output dynamic filenames, so JavaScriptCore generates InspectorJSFoo.* and WebCore generates InspectorWebFoo.*
- take in more then one protocol JSON file. The first contains domains to generate, the others are dependencies that are generated elsewhere that we can depend on for Types.
- Add DerivedSources build step to generate the Inspector Interfaces
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/copy-files.cmd:
- JavaScriptCore.xcodeproj/project.pbxproj:
Add scripts and code generation.
- inspector/protocol/Runtime.json: Renamed from Source/WebCore/inspector/protocol/Runtime.json.
Move protocol file into JavaScriptCore so its types will be generated in JavaScriptCore.
- inspector/scripts/CodeGeneratorInspector.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspector.py.
Updates to the script as listed above.
- inspector/scripts/CodeGeneratorInspectorStrings.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspectorStrings.py.
- inspector/scripts/generate-combined-inspector-json.py: Renamed from Source/WebCore/inspector/Scripts/generate-combined-inspector-json.py.
Moved from WebCore into JavaScriptCore for code generation.
Source/WebCore:
- CodeGeneration changed to output Frontend and Backend dispatchers in namespace Inspector. So update all the agent's appropriately.
- Update Derived Sources code generation to use the Scripts that had moved to JavaScriptCore. Some ports just use JSC/inspector/scripts directly, but others have to use the Scripts exported by JSC in JavaScriptCore's PrivateHeaders.
- Add ForwardingHeaders for the files generated in JavaScriptCore.
- Update the names of Inspector DerivedSources files, since they were renamed to InspectorWeb*.
No new tests, this only moves code around. There are no functional changes.
- CMakeLists.txt:
- DerivedSources.make:
- ForwardingHeaders/inspector/InspectorJSBackendDispatchers.h: Added.
- ForwardingHeaders/inspector/InspectorJSFrontendDispatchers.h: Added.
- ForwardingHeaders/inspector/InspectorJSTypeBuilders.h: Added.
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/build-generated-files.sh:
- WebCore.xcodeproj/project.pbxproj:
Remove files, rename files, update code generation.
- make-generated-sources.sh:
Update this standalone developer script to fill in the new InspectorScripts variable.
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InspectorAgent.cpp:
- inspector/InspectorAgent.h:
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerAgent.h:
- inspector/PageRuntimeAgent.h:
- inspector/ScriptCallFrame.cpp:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerRuntimeAgent.h:
Updates header names and class namespace changes.
Source/WebInspectorUI:
- Scripts/copy-user-interface-resources.sh:
Copy all the different backend commands files.
- Scripts/update-InspectorBackendCommands.rb:
Update with respect to new script location and new file names.
- WebInspectorUI.xcodeproj/project.pbxproj:
Remove Inputs and Outputs of build phase, which were wrong.
Now this build phase always runs, and not by accident.
- UserInterface/InspectorJSBackendCommands.js: Added.
- UserInterface/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js.
- UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorBackendCommands.js.
- UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorBackendCommands.js.
- UserInterface/LoadInspectorBackendCommands.js:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
LayoutTests:
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.importInspectorScripts):
Update for the new backend commands files.
- 12:54 PM Changeset in webkit [160556] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after r160548.
- Scripts/webkitdirs.pm:
(setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
- 12:43 PM Changeset in webkit [160555] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
Work around a problem in Functional.h by making the DatabaseProcess destructor public.
- DatabaseProcess/DatabaseProcess.h:
- 12:15 PM Changeset in webkit [160554] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Handle pinch-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=125604
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView magnifyWithEvent:]):
(-[WKView endGestureWithEvent:]):
Forward the event up the chain if we're not going to handle it.
- 12:04 PM Changeset in webkit [160553] by
-
- 22 edits2 moves in trunk
Adding RTCPeerConnectionErrorCallback
https://bugs.webkit.org/show_bug.cgi?id=125574
Reviewed by Eric Carlson.
According to the spec there should be a RTCPeerConnectionErrorCallback function type for createOffer/Answer,
setLocal/RemoteDescription and updateIce function calls. This callback must handle a DOMError object.
Source/WebCore:
Existing tests were updated.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
- Modules/mediastream/RTCErrorCallback.h: Removed.
- Modules/mediastream/RTCErrorCallback.idl: Removed.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCPeerConnectionErrorCallback.h: Added.
- Modules/mediastream/RTCPeerConnectionErrorCallback.idl: Added.
- Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
- Modules/mediastream/RTCVoidRequestImpl.cpp:
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestFailed):
- Modules/mediastream/RTCVoidRequestImpl.h:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(WebCore::RTCPeerConnectionHandler::incompatibleConstraintsErrorName):
(WebCore::RTCPeerConnectionHandler::invalidSessionDescriptionErrorName):
(WebCore::RTCPeerConnectionHandler::incompatibleSessionDescriptionErrorName):
(WebCore::RTCPeerConnectionHandler::internalErrorName):
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mock/RTCNotifiersMock.cpp:
(WebCore::SessionRequestNotifier::SessionRequestNotifier):
(WebCore::SessionRequestNotifier::fire):
(WebCore::VoidRequestNotifier::VoidRequestNotifier):
(WebCore::VoidRequestNotifier::fire):
- platform/mock/RTCNotifiersMock.h:
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createOffer):
(WebCore::RTCPeerConnectionHandlerMock::createAnswer):
LayoutTests:
- fast/mediastream/RTCPeerConnection-createAnswer-expected.txt:
- fast/mediastream/RTCPeerConnection-createAnswer.html:
- fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- 11:32 AM Changeset in webkit [160552] by
-
- 7 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: provide an abstraction for CodeMirror's TextMarker
https://bugs.webkit.org/show_bug.cgi?id=125695
Reviewed by Timothy Hatcher.
Introduce a new WebInspector.TextMarker class which is used by code with CodeMirror knowledge
to return information related to text markers to objects that should have no direct knowledge
of CodeMirror. Start using this class in TextEditor and SourceCodeTextEditor to remove the
last remaining pieces of CodeMirror knowledge added to SourceCodeTextEditor to fix
https://webkit.org/b/124364.
- UserInterface/CodeMirrorAdditions.js:
Stop using markedColor to identify a color marker and instead use the type on the matching
WebInspector.TextMarker. Additionally, create a WebInspector.TextMarker with type
WebInspector.TextMarker.Type.Color in createColorMarkers().
- UserInterface/CodeMirrorColorEditingController.js:
(WebInspector.CodeMirrorColorEditingController):
Use a WebInspector.TextRange to track the edited range and obtain it directly from the
WebInspector.TextMaker used to instantiate the object. We also use the new "text" public
property to create the color.
(WebInspector.CodeMirrorColorEditingController.prototype.set color):
Simply assing the serialized color to the new "text" public property.
(WebInspector.CodeMirrorColorEditingController.prototype.get text):
(WebInspector.CodeMirrorColorEditingController.prototype.set text):
New public property to set get and set the text for the edited range, automatically updating
the range upon setting to a new text.
(WebInspector.CodeMirrorColorEditingController.prototype.presentHoverMenu):
Obtain the bounds directly from the WebInspector.TextMarker object.
- UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Since we're now tracking the hoveredMarker as a WebInspector.TextMarker, get the CodeMirror
TextMarker from that object to check if it's contained within the text markers at the
hovered position.
- UserInterface/Main.html:
Add the new TextMarker class source.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._hasColorMarkers):
Use the WebInspector.TextMarker type to identify a given text marker is marking a color.
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
Use the renamed markersAtPosition() method from TextEditor.
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
Use the WebInspector.TextMarker type to identify a given text marker is marking a color.
(WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidFinishEditing):
Since the CodeMirrorColorEditingController is now using a WebInspector.TextRange for its range,
update to use a WebInspector.TextRange API to get the range's start line.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.get markers):
Return WebInspector.TextMarker objects instead of CodeMirror TextRange objects.
(WebInspector.TextEditor.prototype.markersAtPosition):
Rename method to a better name instead of using the CodeMirror-influenced name. Also, return
WebInspector.TextMarker objects instead of CodeMirror TextRange objects.
- UserInterface/TextMarker.js: Added.
(WebInspector.TextMarker):
Create a WebInspector.TextMarker with a CodeMirror TextMarker and an optional type.
(WebInspector.TextMarker.textMarkerForCodeMirrorTextMarker):
Static method to either obtain the existing WebInspector.TextMarker for a given CodeMirror
TextMarker, or create a new WebInspector.TextMarker.
(WebInspector.TextMarker.prototype.get codeMirrorTextMarker):
Public property to access the CodeMirror TextMarker objects for classes that have direct
knowledge of CodeMirror.
(WebInspector.TextMarker.prototype.get type):
Public property to access the type used to create this text marker.
(WebInspector.TextMarker.prototype.get range):
(WebInspector.TextMarker.prototype.get bounds):
Public properties allowing easy access to generally useful information related to marked text.
(WebInspector.TextMarker.prototype.clear):
Wrapper for the CodeMirror TextMarker clear() method.
- 11:27 AM Changeset in webkit [160551] by
-
- 2 edits in trunk/Tools
Update Apple bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:24 AM Changeset in webkit [160550] by
-
- 6 edits in trunk/Source
Delete INTEL C compiler related code parts.
https://bugs.webkit.org/show_bug.cgi?id=125625
Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-12-13
Reviewed by Darin Adler.
Source/JavaScriptCore:
- jsc.cpp:
- testRegExp.cpp:
Source/WTF:
- wtf/Assertions.h:
- wtf/Compiler.h:
- 11:21 AM Changeset in webkit [160549] by
-
- 8 edits in trunk/Source/WebKit2
Put classes in the IPC directory in the IPC namespace
https://bugs.webkit.org/show_bug.cgi?id=125665
Reviewed by Sam Weinig.
Also add a hack to config.h that lets us use CoreIPC and IPC interchangeably.
- Platform/IPC/DataReference.cpp:
- Platform/IPC/DataReference.h:
- Platform/IPC/MessageSender.cpp:
- Platform/IPC/MessageSender.h:
- Platform/IPC/StringReference.cpp:
- Platform/IPC/StringReference.h:
- config.h:
- 11:17 AM Changeset in webkit [160548] by
-
- 34 edits in trunk
[Win] Switch WebKit solution to Visual Studio 2013
https://bugs.webkit.org/show_bug.cgi?id=125192
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Update for VS2013
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
Ditto
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto
Source/ThirdParty:
- gtest/msvc/gtest-md.vcxproj: Update for VS2013
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj: Update for VS2013
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- WebCore.vcxproj/WebCoreTestSupport.vcxproj: Ditto
Source/WebInspectorUI:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Update for VS2013
Source/WebKit:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update for VS2013
- WebKit.vcxproj/WebKit.sln: Ditto
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Ditto
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Ditto
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Ditto
Source/WTF:
- WTF.vcxproj/WTF.vcxproj: Update for VS2013
- WTF.vcxproj/WTF.vcxproj.filters: Ditto
Tools:
Project files must reference vs12_xp for 32-bit builds.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
Update for VS2013
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
Ditto
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
Ditto
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
Ditto
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
Ditto
- Scripts/webkitdirs.pm:
(visualStudioInstallDir): Specify VS2013
(visualStudioVersion): Ditto.
(setupAppleWinEnv): Use VS2013 in messages
(setupCygwinEnv): Ditto
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
Update for VS2013
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
Ditto
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
Ditto
- win/record-memory/record-memory.vcxproj:
Ditto
- 11:10 AM Changeset in webkit [160547] by
-
- 32 edits in trunk
WebCrypto Key.usages should be ordered alphabetically
https://bugs.webkit.org/show_bug.cgi?id=125696
Reviewed by Darin Adler.
Source/WebCore:
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::usages): Do it.
LayoutTests:
- crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
- crypto/subtle/aes-cbc-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-generate-key-expected.txt:
- crypto/subtle/aes-cbc-generate-key.html:
- crypto/subtle/aes-cbc-invalid-length-expected.txt:
- crypto/subtle/aes-cbc-invalid-length.html:
- crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
- crypto/subtle/aes-kw-wrap-unwrap-aes.html:
- crypto/subtle/aes-postMessage-expected.txt:
- crypto/subtle/aes-postMessage.html:
- crypto/subtle/hmac-postMessage-expected.txt:
- crypto/subtle/hmac-postMessage.html:
- crypto/subtle/jwk-import-use-values-expected.txt:
- crypto/subtle/jwk-import-use-values.html:
- crypto/subtle/postMessage-worker-expected.txt:
- crypto/subtle/postMessage-worker.html:
- crypto/subtle/resources/postMessage-worker.js:
(onmessage):
- crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
- crypto/subtle/rsa-oaep-key-manipulation.html:
- crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
- crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
- crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt:
- crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html:
- 8:27 AM Changeset in webkit [160546] by
-
- 2 edits in trunk/Source/WebCore
Make some optimizations for DOM bindings involving vectors
https://bugs.webkit.org/show_bug.cgi?id=125680
Reviewed by Andreas Kling.
- bindings/js/JSDOMBinding.h:
(WebCore::toJS): Removed unnecessary copying of vectors when converting them
to JavaScript values.
(WebCore::toRefPtrNativeArray): Use reserveInitialCapacity and uncheckedAppend.
(WebCore::toNativeArray): Ditto.
(WebCore::toNativeArguments): Ditto.
- 7:41 AM Changeset in webkit [160545] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r155784): [GTK] Some methods incorrectly removed in r155784 and deprecated in r158662
https://bugs.webkit.org/show_bug.cgi?id=125692
Reviewed by Martin Robinson.
In r155784 the build was fixed by skipping Console::profile() and
Console::profileEnd(), but the patch also skipped other methods
containing the profile method name. Those were incorrectly
deprecated in r158662 thinking that the property had been removed
in the idl.
- bindings/gobject/WebKitDOMDeprecated.cpp: Undeprecate
webkit_dom_html_head_element_get_profile and
webkit_dom_html_head_element_set_profile.
- bindings/gobject/WebKitDOMDeprecated.h: Ditto.
- bindings/gobject/WebKitDOMDeprecated.symbols: Ditto.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip webkit_dom_console_profile and
webkit_dom_console_profile_end.
- 6:13 AM Changeset in webkit [160544] by
-
- 5 edits2 adds in trunk
Clean up SVGScriptElement
https://bugs.webkit.org/show_bug.cgi?id=125527
Reviewed by Darin Adler.
Source/WebCore:
From the Blink port of this bug it becomes clear that svg/dom/SVGScriptElement/script-set-href.svg and
svg/dom/svg-element-attribute-js-null.xhtml still hit an assert in Debug because SVGNames::typeAttr can't
be used with fastGetAttribute in all cases, because it can be animatable. However for SVGScriptElement
it is not animatable, so make isAnimatableAttribute virtual (note Debug only method) and allow typeAttr
in the SVGScriptElement case to be useable for fastGetAttribute.
Test: svg/dom/SVGScriptElement/script-type-attribute.svg
- svg/SVGElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isAnimatableAttribute):
- svg/SVGScriptElement.h:
LayoutTests:
Add test to verify the new type getter/setter behavior on SVScriptElement.
Specifically, the old behavior was setting the JS type property did not reflect in
the actual content attribute being set, the new behavior is to do set the content
attribute when setting the JS type property.
- svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
- svg/dom/SVGScriptElement/script-type-attribute.svg: Added.
- 4:40 AM Changeset in webkit [160543] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Expose also webkit_dom_document_get_url
https://bugs.webkit.org/show_bug.cgi?id=125691
Reviewed by Martin Robinson.
For some reason we expose the URL property, so it can be accessed
with g_object_get(), but we have a special case to not provide a
public getter.
- bindings/gobject/webkitdom.symbols: Add new symbol.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunctions): Remove the special case of URL property.
- 4:36 AM Changeset in webkit [160542] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed EFL gardening
Remove wrong http baselines.
- platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Removed.
- platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 2:32 AM Changeset in webkit [160541] by
-
- 6 edits in trunk/Source/WebCore
CSSFilterImageValue constructor should require both image and filter.
<https://webkit.org/b/125056>
Make the CSSFilterImageValue::create() helper take both the image and
filter CSSValues by PassRef since they should never be null.
Tweaked ComputedStyleExtractor::valueForFilter() to return a PassRef
for this to work.
Reviewed by Anders Carlsson.
- 2:24 AM Changeset in webkit [160540] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Add a unit tests to WebKit2 to test node names
https://bugs.webkit.org/show_bug.cgi?id=125686
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/tests/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::runTest):
(registerTests):
- UIProcess/API/gtk/tests/TestDOMNode.cpp:
(testWebKitDOMNodeTagNames):
(beforeAll):
- 1:56 AM Changeset in webkit [160539] by
-
- 7 edits in trunk/Source/WebCore
StyleResolver::adjustRenderStyle() should take RenderStyle references.
<https://webkit.org/b/125623>
This function doesn't handle null styles being passed, so prevent
it at compile time.
Reviewed by Anders Carlsson.
- 1:41 AM Changeset in webkit [160538] by
-
- 2 edits in trunk
[GTK] Remove the -Wno-c++11-extensions compiler option for Clang builds
https://bugs.webkit.org/show_bug.cgi?id=125639
Reviewed by Anders Carlsson.
- Source/autotools/SetupCompilerFlags.m4: The -Wno-c++11-extensions compiler option was in use
when building with Clang. It is now removed as the C++11 standard is enabled throughout the project.
- 1:16 AM Changeset in webkit [160537] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Further GTK WK2 build fixes after r160504.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_snapshot):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):
- 1:14 AM Changeset in webkit [160536] by
-
- 7 edits in trunk/Source/WebCore
Eliminate awkward virtualComputedStyle construction
https://bugs.webkit.org/show_bug.cgi?id=125681
Reviewed by Andreas Kling.
- dom/Element.cpp:
(WebCore::Element::computedStyle): Tweak coding style a bit.
- dom/Element.h: Marked computedStyle virtual and got rid of virtualComputedStyle.
This fixes a bug that we would not call SVGElement::computedStyle if we called
it through an Element pointer or reference. Not sure how to get test coverage for this.
- dom/Node.cpp:
(WebCore::Node::computedStyle): Use a loop instead of recursive virtual calls.
- dom/Node.h: Made computedStyle virtual and got rid of virtualComputedStyle.
- svg/SVGElement.cpp:
(WebCore::SVGElement::computedStyle): Tweak coding style a bit.
- svg/SVGElement.h: Made computedStyle virtual (and FINAL) and got rid fo
virtualComputedStyle.
- 1:10 AM Changeset in webkit [160535] by
-
- 2 edits in trunk/Source/WebCore
Fix a couple stray uses of RefPtr that should release
https://bugs.webkit.org/show_bug.cgi?id=125679
Reviewed by Andreas Kling.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFilter): Add calls to release, in
one case rearranging the order of operations slightly so we
don't release the pointer before using it.
- 12:56 AM Changeset in webkit [160534] by
-
- 3 edits4 adds in trunk
WebCrypto wrapKey operation doesn't check key usage
https://bugs.webkit.org/show_bug.cgi?id=125675
Reviewed by Darin Adler.
Source/WebCore:
Tests: crypto/subtle/unwrapKey-check-usage.html
crypto/subtle/wrapKey-check-usage.html
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):
Added accidentally omitted code. Other operations are fine.
LayoutTests:
- crypto/subtle/unwrapKey-check-usage-expected.txt: Added.
- crypto/subtle/unwrapKey-check-usage.html: Added.
- crypto/subtle/wrapKey-check-usage-expected.txt: Added.
- crypto/subtle/wrapKey-check-usage.html: Added.
- 12:35 AM Changeset in webkit [160533] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r160509.
- GNUmakefile.list.am: MessageSender.(cpp|h) files were moved to Platform/IPC.
- 12:24 AM Changeset in webkit [160532] by
-
- 2 edits in trunk/Source/WebKit2
GTK buildfix after r160504.
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-13
Reviewed by Csaba Osztrogonác.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_prefetch_dns):
- 12:16 AM Changeset in webkit [160531] by
-
- 4 edits1 add in trunk
Adding a .ycm_extra_conf file for webkitGtk
https://bugs.webkit.org/show_bug.cgi?id=119618
Patch by Martin Robinson <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-12-11
Reviewed by Gustavo Noronha Silva.
Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
read the GTK+ build files to determine dynamically what flags to compile a source
file with. This allows Vim to provide auto-complete for C++/C language. See
https://github.com/Valloric/YouCompleteMe for how to use this file.
.:
- .gitignore: Ignore the YCM symlinks in the tree.
Tools:
- gtk/common.py:
(get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
- gtk/ycm_extra_conf.py: Added.
Dec 12, 2013:
- 11:22 PM Changeset in webkit [160530] by
-
- 3 edits13 adds in trunk/Source/WebKit2
Need ObjC APIs for some InjectedBundle classes.
https://bugs.webkit.org/show_bug.cgi?id=125600
Add ObjC API classes for WebFrame, InjectedBundleScriptWorld, InjectedBundleHitTestResult and InjectedBundleNodeHandle.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-12-12
Reviewed by Dan Bernstein.
- Shared/Cocoa/APIObject.mm: creates API wrapper for WebFrame, InjectedBundleScriptWorld, InjectedBundleHitTestResult
and InjectedBundleNodeHandle.
(API::Object::newObject):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: Added.
(-[WKWebProcessPlugInFrame dealloc]):
(-[WKWebProcessPlugInFrame jsContextForWorld:]): returns the JSContextRef for a ScriptWorld in frame.
(-[WKWebProcessPlugInFrame hitTest:]): returns hitTestResult (with API type) from a hitTest.
(-[WKWebProcessPlugInFrame jsWrapperForNodeHandle:inWorld:]):
(-[WKWebProcessPlugInFrame API::]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Added.
(WebKit::wrapper):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.h: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm: Added.
(-[WKWebProcessPlugInHitTestResult dealloc]):
(-[WKWebProcessPlugInHitTestResult nodeHandle]):
(-[WKWebProcessPlugInHitTestResult API::]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResultInternal.h: Added.
(WebKit::wrapper):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm: Added.
(-[WKWebProcessPlugInNodeHandle dealloc]):
(-[WKWebProcessPlugInNodeHandle API::]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandleInternal.h: Added.
(WebKit::wrapper):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm: Added.
(+[WKWebProcessPlugInScriptWorld world]): returns a new isolated world.
(+[WKWebProcessPlugInScriptWorld normalWorld]): returns the mainThread normal world.
(-[WKWebProcessPlugInScriptWorld dealloc]):
(-[WKWebProcessPlugInScriptWorld API::]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorldInternal.h: Added.
(WebKit::wrapper):
- 11:04 PM Changeset in webkit [160529] by
-
- 3 edits in trunk/Source/WebKit2
Fix unsafe memory load/store from the argument encoder/decoder affecting ARM
https://bugs.webkit.org/show_bug.cgi?id=125674
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-12
Reviewed by Darin Adler.
Depending on the CPU and CPU config, load and store may have to be aligned.
The argument buffer has no particular alignment which can cause problems.
In this case, on ARMv7, strd and ldrd can have alignment restriction on 16 bytes.
The code encoding double and 64 bits integers was causing bugs.
To avoid problems, the encoders/decoders are modified to just use memcpy. The compiler optimizes
it away for the right instructions (clang uses two ldr/str in the case of 64bits values on ARMv7).
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::decodeValueFromBuffer):
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::copyValueToBuffer):
(CoreIPC::ArgumentEncoder::encode):
- 10:52 PM Changeset in webkit [160528] by
-
- 11 edits in trunk/Source/WebCore
Make some improvements in CSSImageGeneratorValue code
https://bugs.webkit.org/show_bug.cgi?id=125676
Reviewed by Simon Fraser.
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque): Take a reference to the CSSValue, since
it's known not to be null. Used checked cast.
(WebCore::CSSCrossfadeValue::knownToBeOpaque): Updated to pass a reference.
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize): Use
make_unique instead of adoptPtr.
(WebCore::CSSImageGeneratorValue::subimageIsPending): Use checked cast.
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue): Ditto, also
use nullptr.
- css/CSSImageGeneratorValue.h: Removed unneeded includes, added some forward
declarations, used unique_ptr instead of OwnPtr, and used CSS_VALUE_TYPE_CASTS
macro to create cast functions.
- css/CSSValue.cpp: Removed unneeded include of CSSImageGeneratorValue.h.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear): Use nullptr instead of 0.
(WebCore::StyleResolver::applyProperty): Use checked cast and pass references
instead of pointers to StyleGeneratedImage::create.
(WebCore::StyleResolver::styleImage): Use checked cast and pass references
instead of pointers to generatedOrPendingFromValue.
(WebCore::StyleResolver::generatedOrPendingFromValue): Take the value as a
reference instead of a pointer.
(WebCore::StyleResolver::loadPendingImage): Pass a refernece instead of a
pointer to StyleGeneratedImage::create.
(WebCore::StyleResolver::loadPendingImages): Use auto for iteration instead of
a lot type name.
- css/StyleResolver.h: Changed generatedOrPendingFromValue to take the value
as a reference instead of a pointer.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFilter): Pass a reference insted of a pointer to
StyleGeneratedImage::create.
(WebCore::crossfadeBlend): Ditto.
(WebCore::blendFunc): Ditto. Also use references for local variables.
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::StyleGeneratedImage): Use PassRef instead of
PassRefPtr for the argument type.
(WebCore::StyleGeneratedImage::cssValue): Updated since m_imageGeneratorValue
is now a Ref instead of a RefPtr. Sadly this requires a const_cast that we can
come back and get rid of later.
(WebCore::StyleGeneratedImage::imageSize): Ditto.
(WebCore::StyleGeneratedImage::image): Ditto.
- rendering/style/StyleGeneratedImage.h: Changed create function and constructor
to take a PassRef. Made imageValue non-const since it returns a non-const value,
to be consistent with "conceptual const". Changed m_imageGeneratorValue to be a
Ref instead of a RefPtr.
- rendering/style/StyleImage.h: Made WrappedImagePtr be const void*, since it's
a pointer used only for equality checks. Not a great idiom, but fine to use a
const pointer instead of non-const, and avoids the const_cast we'd otherwise
need in StyleGeneratedImage::data.
- 9:51 PM Changeset in webkit [160527] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Use proper values for stack checks
https://bugs.webkit.org/show_bug.cgi?id=125677
Reviewed by Filip Pizlo.
For the LLInt using CodeBlock::m_numCalleeRegisters + maxFrameExtentForSlowPathCall.
For the baseline JIT using frameRegisterCountFor().
For the DFG using Graph::requiredRegisterCountForExecutionAndExit().
Using virtualRegisterForLocal().offset() to get the register offset given a count.
Note that for N registers, the value passed into virtualRegisterForLocal() needs
to be N-1, since we are trying to check to see if there is space for registers 0..N-1.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- llint/LowLevelInterpreter.asm:
- 8:59 PM Changeset in webkit [160526] by
-
- 5 edits in trunk/Source/WebCore
Improve the find word boundary performance
https://bugs.webkit.org/show_bug.cgi?id=125619
In endWordBoundary case, the textBreakPrevious call in findWordBoundary is unnecessary.
So use separate function for endWordBoundary can improve the performance.
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-12-12
Reviewed by Darin Adler.
No tests because no operation changes.
- editing/VisibleUnits.cpp: Use findEndWordBoundary in endWordBoundary
(WebCore::endWordBoundary):
- platform/text/TextBoundaries.cpp: Add findEndWordBoundary function
(WebCore::findEndWordBoundary):
- platform/text/TextBoundaries.h:
- platform/text/mac/TextBoundaries.mm: Add findEndWordBoundary function
(WebCore::findEndWordBoundary):
- 7:50 PM Changeset in webkit [160525] by
-
- 2 edits in trunk/Source/WebCore
Fix a silly mistake of r160467
https://bugs.webkit.org/show_bug.cgi?id=125657
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-12
Reviewed by Alexey Proskuryakov.
Fix a typo. The validity check was missing the logical not.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
- 6:41 PM Changeset in webkit [160524] by
-
- 1 copy in tags/Safari-537.74.1
New Tag.
- 6:19 PM Changeset in webkit [160523] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add a few more ASCIILiterals
https://bugs.webkit.org/show_bug.cgi?id=125662
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-12
Reviewed by Darin Adler.
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::InspectorBackendDispatcher::dispatch):
- 6:06 PM Changeset in webkit [160522] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Add equivalent values from MaxFrameExtentForSlowPathCall.h to lint files
https://bugs.webkit.org/show_bug.cgi?id=125669
Reviewed by Mark Lam.
Added platform specific value of maxFrameExtentForSlowPathCall to llint code.
Also added ASSERTs to check that we are using the save value in both places.
Per review comments, I also updated the CPU(ARM) ... in MaxFrameExtentForSlowPathCall.h to be just CPU(ARM) since it covers all ARM 32 bit variants.
- assembler/MaxFrameExtentForSlowPathCall.h:
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- 5:45 PM Changeset in webkit [160521] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for 32-bit.
There was no reason for these to be CGFloat.
- UIProcess/mac/ViewGestureController.cpp:
- 5:36 PM Changeset in webkit [160520] by
-
- 18 edits3 adds in trunk
[wk2] Handle pinch-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=125604
Reviewed by Simon Fraser.
Add the concept of a "transient" zoom to DrawingArea, which is a zoom
that affects the content, but does not cause repaint, as would be used
for a live pinch-zoom gesture.
Add ViewGestureController, which currently only handles magnification
gestures, and keeps track of the current gesture's scale and origin, and
forwards relevant events on to the DrawingArea via the transient zoom mechanism.
- DerivedSources.make:
Add ViewGestureController to the list of message receivers.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Add shouldHandleMagnificationGesture property, which controls whether WKView will
attempt to handle magnifyWithEvent:.
- UIProcess/API/mac/WKView.mm:
(-[WKView waitForAsyncDrawingAreaSizeUpdate]):
Fix a typo.
(-[WKView _ensureGestureController]):
Create our ViewGestureController if it doesn't already exist.
(-[WKView setAllowsMagnification:]):
(-[WKView allowsMagnification]):
SPI to enable/disable handling the magnification gesture.
(-[WKView setMagnification:centeredAtPoint:]):
(-[WKView setMagnification:]):
(-[WKView magnification]):
Adjust or retrieve the current page scale.
The variant of setMagnification that does not take an origin uses the view's center.
(-[WKView magnifyWithEvent:]):
(-[WKView endGestureWithEvent:]):
Forward gesture methods to ViewGestureController.
- UIProcess/mac/ViewGestureController.cpp: Added.
(WebKit::ViewGestureController::create):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::resistanceForDelta):
Compute a resistance factor, which makes it feel "hard" to zoom out past
scale=1, and accelerates scaling out before you hit scale=1.
(WebKit::ViewGestureController::scaledMagnificationOrigin):
Compute the origin of the magnification gesture with the transient zoom unapplied.
(WebKit::ViewGestureController::handleMagnificationGesture):
The first magnification gesture will send a message to the WebProcess
to retrieve the visible content rect. Subsequent gestures will
hand the new magnification and origin to the DrawingArea to apply.
(WebKit::ViewGestureController::didBeginTransientZoom):
Callback from the WebProcess, with the current visible content rect.
Subsequent magnification gestures will forward the scale and origin to the DrawingArea.
(WebKit::ViewGestureController::endMagnificationGesture):
Commit the current transient scale as the actual page scale, which will cause
a repaint and bring in all the tiles.
(WebKit::ViewGestureController::endActiveGesture):
If we have an active gesture, call its end function.
- UIProcess/mac/ViewGestureController.h: Added.
- UIProcess/mac/ViewGestureController.messages.in: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::beginTransientZoom):
Call back to ViewGestureController with the visibleContentRect.
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
Scale and translate the RenderView's PlatformCALayer.
Reaching into the layer tree like this is scary, we should consider
teaching RenderLayerCompositor about transient zoom.
Hide the content shadow layer for now.
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Clear our custom transform on the RenderView's layer, and
change the actual page scale, causing a repaint.
Un-hide the shadow layer.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::beginTransientZoom):
(WebKit::DrawingAreaProxy::adjustTransientZoom):
(WebKit::DrawingAreaProxy::commitTransientZoom):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::beginTransientZoom):
(WebKit::TiledCoreAnimationDrawingAreaProxy::adjustTransientZoom):
(WebKit::TiledCoreAnimationDrawingAreaProxy::commitTransientZoom):
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::beginTransientZoom):
(WebKit::DrawingArea::adjustTransientZoom):
(WebKit::DrawingArea::commitTransientZoom):
- WebProcess/WebPage/DrawingArea.messages.in:
Generic plumbing for {begin, adjust, end}TransientZoom.
- WebCore.exp.in:
Export some TransformationMatrix functions.
- WebCore.xcodeproj/project.pbxproj:
Make some headers private so that RenderLayerCompositor/Backing can be used from WebKit2.
- rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::layerForContentShadow):
Add a getter for the content shadow layer.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
- 5:32 PM Changeset in webkit [160519] by
-
- 5 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Add the new assembler/MaxFrameExtentForSlowPathCall.h to build files
https://bugs.webkit.org/show_bug.cgi?id=125668
Reviewed by Mark Lam.
Added assembler/MaxFrameExtentForSlowPathCall.h to Xcode, Visual Studio and
GNUmake build files.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 5:13 PM Changeset in webkit [160518] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 4:42 PM Changeset in webkit [160517] by
-
- 22 edits4 copies4 adds in trunk/Source
DatabaseProcess IndexedDB: Establish a metadata backing store on disk
https://bugs.webkit.org/show_bug.cgi?id=125258
Reviewed by Alexey Proskuryakov, Anders Carlsson, and Tim Horton.
Source/WebCore:
Teach CrossThreadCopier how to handle IDBDatabaseMetadata.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBDatabaseMetadata.cpp: Added.
(WebCore::IDBDatabaseMetadata::isolatedCopy):
(WebCore::IDBObjectStoreMetadata::isolatedCopy):
(WebCore::IDBIndexMetadata::isolatedCopy):
- Modules/indexeddb/IDBDatabaseMetadata.h:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::isolatedCopy):
- Modules/indexeddb/IDBKeyPath.h:
- platform/CrossThreadCopier.cpp:
(WebCore::::copy): Add an IDBDatabaseMetadata specialization.
- platform/CrossThreadCopier.h:
Source/WebKit2:
The DatabaseProcess already has an "Indexed Database path".
Each SecurityOrigin with indexed databases will have a subdirectory under the path.
Each indexed database will have a subdirectory under its SecurityOrigin's path.
Inside that directory will exist (1) metadata database, and 0-N ObjectStore databases.
This patch establishes the directory structure and the (1) metadata database.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::initializeDatabaseProcess): Asynchronously ensure the indexed database directory exists.
(WebKit::DatabaseProcess::ensureIndexedDatabaseRelativePathExists): Allow anyone to make necessary directories relative to
the indexed database directory.
(WebKit::DatabaseProcess::ensurePathExists):
(WebKit::DatabaseProcess::absoluteIndexedDatabasePathFromDatabaseRelativePath): Instead of exposing the indexed database directory,
give DatabaseProcess a method to allow others to compute a path relative to the indexed database directory.
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
- DatabaseProcess/DatabaseProcess.h:
(WebKit::DatabaseProcess::queue):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::filenameForDatabaseName):
(WebKit::UniqueIDBDatabase::databaseFilenameIdentifier):
(WebKit::UniqueIDBDatabase::canShareDatabases):
(WebKit::UniqueIDBDatabase::shutdown): Method to cleanly shutdown a database, emptying its task and request queues.
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata): To be run on the database work queue, establishes a backing store
and extracts metadata from it.
(WebKit::UniqueIDBDatabase::didOpenBackingStoreAndReadMetadata): Callback once metadata from the backing store is ready for use.
(WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):
(WebKit::UniqueIDBDatabase::postMainThreadTask): Add a main thread task for this database.
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask): Add a database queue task for this database.
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
Add a virtual backing store interface:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
(WebKit::UniqueIDBDatabaseBackingStore::~UniqueIDBDatabaseBackingStore):
Add a SQLite implementation of that interface:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp: Added.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openSQLiteDatabaseAtPath):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
Add a general purpose asynchronous task that does cross thread copying:
- Shared/AsyncTask.h: Added.
(WebKit::AsyncTask::~AsyncTask):
(WebKit::AsyncTask::AsyncTask):
(WebKit::createAsyncTask):
Add more isolated copiers and introduce WebKit CrossThreadCopier specializations:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp:
(WebKit::UniqueIDBDatabaseIdentifier::isolatedCopy):
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h:
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::isolatedCopy):
- Shared/SecurityOriginData.h:
- Shared/WebCrossThreadCopier.cpp:
(WebCore::::copy):
- Shared/WebCrossThreadCopier.h:
- WebKit2.xcodeproj/project.pbxproj:
Source/WTF:
- wtf/text/WTFString.h: Export toUInt64Strict().
- 4:30 PM Changeset in webkit [160516] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves
https://bugs.webkit.org/show_bug.cgi?id=125666
Not yet reviewed.
Eliminated "extraStack" arguments and related stack pointer manipulation for 64 bit platforms.
Both ARM64 and X86_64 already have aligned stacks. Eliminated some related commented out
code.
- llint/LowLevelInterpreter64.asm:
- 4:18 PM Changeset in webkit [160515] by
-
- 2 edits in trunk/Source/WebKit2
AX: HANG: virginamerica.com: Pressing the print button on the boarding pass page locks up VoiceOver and Safari.
https://bugs.webkit.org/show_bug.cgi?id=125603
Reviewed by Anders Carlsson.
Allow the print dialog to spin its run loop while accessibility is enabled so that VoiceOver does not hang on the WebProcess.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print):
- 4:18 PM Changeset in webkit [160514] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Eliminate unnecessary add/sub 16 to stack pointer
https://bugs.webkit.org/show_bug.cgi?id=125653
Reviewed by Geoffrey Garen.
Changes as a result of review.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount): Changed c-style cast to static_cast.
Changed rounding for stack alignment to use WTF::roundUpToMultipleOf
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Added assertion for JSStack::CallerFrameAndPCSize
- 4:10 PM Changeset in webkit [160513] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed CMake build fix after r160509
- CMakeLists.txt: Apply MessageSender's changes
- 3:49 PM Changeset in webkit [160512] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Let the load delegate know when the Web process crashes
https://bugs.webkit.org/show_bug.cgi?id=125660
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(processDidCrash): Implemented this WKPageLoaderClient callback by calling the load
delegate.
(setUpPageLoaderClient): Set the above callback in the client structure
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h: Declare new delegate method.
- 3:46 PM Changeset in webkit [160511] by
-
- 2 edits in trunk/Tools
Update hardware for Apple bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:41 PM Changeset in webkit [160510] by
-
- 2 edits in trunk/Tools
Remove unused Apple Bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:26 PM Changeset in webkit [160509] by
-
- 2 edits2 moves in trunk/Source/WebKit2
Move MessageSender to Platform/IPC.
Rubber-stamped by Andreas Kling.
- Platform/IPC/MessageSender.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/MessageSender.cpp.
- Platform/IPC/MessageSender.h: Renamed from Source/WebKit2/Platform/CoreIPC/MessageSender.h.
- WebKit2.xcodeproj/project.pbxproj:
- 3:12 PM Changeset in webkit [160508] by
-
- 7 edits in trunk/Source/WebKit2
WebPageProxy should be a MessageSender
https://bugs.webkit.org/show_bug.cgi?id=125654
Reviewed by Sam Weinig.
- Platform/CoreIPC/MessageSender.cpp:
(CoreIPC::MessageSender::sendMessage):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Shared/ChildProcessProxy.h:
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::sendMessage):
(WebKit::WebPageProxy::messageSenderConnection):
(WebKit::WebPageProxy::messageSenderDestinationID):
- UIProcess/WebPageProxy.h:
- 2:55 PM Changeset in webkit [160507] by
-
- 2 edits in trunk/Tools
committer
- 2:54 PM Changeset in webkit [160506] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Eliminate unnecessary add/sub 16 to stack pointer
https://bugs.webkit.org/show_bug.cgi?id=125653
Not yet reviewed.
Changed the DFG stack frame to include outgoing space for at least the two
pointers for returnPC and callerFrame. Changed the setting of the stack
pointer to not include the space for the outgoing returnPC and callerFrame.
Eliminated the add/sub 16 around calls in the DFG.
Adjusted the LLInt and baseline JIT calculation of the stack pointer for calls.
In both cases, the frame is set up with temp that points to the base of the callee
frame. The space for the outgoing returnPC and callerFrame is added to the temp
to create the stack pointer for the call.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/JSStack.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- 1:48 PM WebKitGTK/2.2.x edited by
- (diff)
- 1:25 PM Changeset in webkit [160505] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Fix handling of uncaught exceptions.
https://bugs.webkit.org/show_bug.cgi?id=125648.
Reviewed by Geoffrey Garen.
- llint/LowLevelInterpreter64.asm:
- handleUncaughtException should load the "catch" callFrame instead of assuming that the current one is appropriate. This is now fixed.
- 12:28 PM Changeset in webkit [160504] by
-
- 16 edits in trunk/Source/WebKit2
Clean up dictionary handling a little
https://bugs.webkit.org/show_bug.cgi?id=125644
Reviewed by Dan Bernstein.
Add a WKDictionaryCreate function as a first step towards eliminating WKMutableDictionaryRef,
(in the same way we've eliminated WKMutableArrayRef). Also, rename adopt to create and make it take a Map by value
so we can use std::move where appropriate.
- Shared/API/c/WKDictionary.cpp:
(WKDictionaryCreate):
- Shared/API/c/WKDictionary.h:
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]):
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::create):
(WebKit::ImmutableDictionary::ImmutableDictionary):
- Shared/ImmutableDictionary.h:
- Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::MutableDictionary):
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::createPluginInformationDictionary):
- Shared/UserData.cpp:
(WebKit::UserData::transform):
(WebKit::UserData::decode):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::createNewPage):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
- 12:18 PM Changeset in webkit [160503] by
-
- 2 edits in trunk/Source/WebCore
Add support for RSAES-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=125647
Build fix.
- crypto/CommonCryptoUtilities.h: Declare a newly used private constant.
- 12:12 PM Changeset in webkit [160502] by
-
- 8 edits7 adds in trunk
Add support for RSAES-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=125647
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html
crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html
- crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
- crypto/algorithms/CryptoAlgorithmAES_KW.h:
Removed meaningless parameters arguments from private functions. The base arguments
class is always empty.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: Added.
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::CryptoAlgorithmRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::~CryptoAlgorithmRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::create):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::identifier):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: Added.
- crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: Added.
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Added support for this algorithm.
LayoutTests:
- crypto/subtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Added.
- crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html: Added.
- crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Added.
- crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Added.
- 11:57 AM Changeset in webkit [160501] by
-
- 17 edits2 adds in branches/safari-537.74-branch
Merged patch from <rdar://problems/15474133>. This patch is a port of r157821.
- 11:52 AM Changeset in webkit [160500] by
-
- 18 edits in trunk/Source/WebInspectorUI
Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of
https://bugs.webkit.org/show_bug.cgi?id=122868
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-12
Reviewed by Timothy Hatcher.
Update to CodeMirror 3.20 including javascript ES6 updates.
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js: Minor local change due to error from jsmin.py
- Tools/PrettyPrinting/css.js:
- Tools/PrettyPrinting/javascript.js:
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js: Minor local change due to error from jsmin.py
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/htmlmixed.js:
- UserInterface/External/CodeMirror/javascript.js:
- UserInterface/External/CodeMirror/less.js:
- UserInterface/External/CodeMirror/matchbrackets.js:
- UserInterface/External/CodeMirror/placeholder.js:
- UserInterface/External/CodeMirror/runmode.js:
- UserInterface/External/CodeMirror/searchcursor.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
- 11:37 AM Changeset in webkit [160499] by
-
- 5 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Change the disabling of DFG OSR entry to be based on an option
https://bugs.webkit.org/show_bug.cgi?id=125645
Rubber stamped by Filip Pizlo.
Added a new enableOSREntryToDFG option and set the default value to false.
If the option is false, prepareOSREntry() will return 0 which disables OSR
entry, as the return value is the address to jump to or 0 if we can't OSR enter.
Restored the code in emitEnterOptimizationCheck() and emitSlow_op_loop_hint()
that checks the exit value from operationOptimize().
Per a discussion with Filip, removed the enableOSREntryInLoops option and
associated use. All OSR entry to the DFG is now controlled with the new option.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- runtime/Options.h:
- 11:22 AM Changeset in webkit [160498] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Stop not caching HTTP resources with "Vary" header in response.
<https://webkit.org/b/125483>
<rdar://problem/11781097>
Remove the workaround preventing resources with the "Vary" header
from going into cache, as the CFNetwork cache has supported this
for quite a while now.
31.5 MB progression on Membuster3, because we can now mmap those
resources from disk once they are in the cache.
We keep the workaround on PLATFORM(WIN) for now.
Reviewed by Antti Koivisto.
- 11:21 AM Changeset in webkit [160497] by
-
- 12 edits in branches/jsCStack/Source/JavaScriptCore
Rename returnFromJavaScript to handleUncaughtException.
https://bugs.webkit.org/show_bug.cgi?id=125613.
Reviewed by Filip Pizlo.
Also did a few minor fixes to get the C Loop LLINT offline asm stage
to build properly, and also some trivial changes to minimize the
compile errors for LowLevelInterpreter.cpp. It doesn't build completely
and run yet since we'll need to update it for CStack changes that have
not been implemented for the C Loop LLINT yet.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITStubs.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsX86.h:
- llint/LLIntOpcode.h:
- llint/LLIntThunks.h:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- 10:42 AM Changeset in webkit [160496] by
-
- 3 edits2 adds in trunk
Source/WebCore: Replace uses of WTF::BitArray with std::bitset
https://bugs.webkit.org/show_bug.cgi?id=125642
Patch by Sam Weinig <sam@webkit.org> on 2013-12-12
Reviewed by Anders Carlsson.
- css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStyleProperties):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
LayoutTests: Public key in a generated KeyPair should always be extractable
https://bugs.webkit.org/show_bug.cgi?id=125643
Reviewed by Sam Weinig.
- crypto/subtle/rsa-oaep-generate-non-extractable-key-expected.txt: Added.
- crypto/subtle/rsa-oaep-generate-non-extractable-key.html: Added.
- 10:41 AM Changeset in webkit [160495] by
-
- 11 edits1 add in trunk/Source/WebKit2
[Cocoa] Navigation action information for policy decisions is missing the original request
https://bugs.webkit.org/show_bug.cgi?id=125612
Reviewed by Anders Carlsson.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Added template with additional message parameter.
- UIProcess/API/C/WKPagePolicyClientInternal.h: Added. Defines a new version of the client
interface with a new version of the policy decision callback.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(setUpPagePolicyClient): Use the new internal version of the client. Pass the original
request in the action information dictionary under a new key.
- UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Declared new action information
key.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Added originalRequest parameter,
which is passed to the policy client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added originalRequest parameter in
DecidePolicyForNavigationAction.
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction): Pass the original request to
the client.
- UIProcess/WebPolicyClient.h:
- WebKit2.xcodeproj/project.pbxproj: Added reference to new file.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the original
request from the navigation action to the UI process.
- 10:41 AM Changeset in webkit [160494] by
-
- 7 edits in trunk
Test new JSContext name APIs
https://bugs.webkit.org/show_bug.cgi?id=125607
Source/JavaScriptCore:
Reviewed by Darin Adler.
- API/JSContext.h:
- API/JSContextRef.h:
Fix whitespace issues.
- API/tests/testapi.c:
(globalContextNameTest):
(main):
- API/tests/testapi.mm:
Add tests for JSContext set/get name APIs.
Tools:
- Scripts/run-javascriptcore-tests:
Remove trailing whitespace.
- 10:38 AM Changeset in webkit [160493] by
-
- 7 edits in trunk/Source/JavaScriptCore
ARM64: Hang running pdfjs test, suspect DFG generated code for "in"
https://bugs.webkit.org/show_bug.cgi?id=124727
<rdar://problem/15566923>
Reviewed by Michael Saboff.
Get rid of In's hackish use of StructureStubInfo. Previously it was using hotPathBegin,
and it was the only IC that used that field, which was wasteful. Moreover, it used it
to store two separate locations: the label for patching the jump and the label right
after the jump. The code was relying on those two being the same label, which is true
on X86 and some other platforms, but it isn't true on ARM64.
This gets rid of hotPathBegin and makes In express those two locations as offsets from
the callReturnLocation, which is analogous to what the other IC's do.
This fixes a bug where any successful In patching would result in a trivially infinite
loop - and hence a hang - on ARM64.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::InRecord::InRecord):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::finalize):
- jit/Repatch.cpp:
(JSC::replaceWithJump):
(JSC::patchJumpToGetByIdStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- 10:31 AM Changeset in webkit [160492] by
-
- 9 edits1 delete in trunk/Source
Replace uses of WTF::BitArray with std::bitset
https://bugs.webkit.org/show_bug.cgi?id=125642
Reviewed by Anders Carlsson.
../WebCore:
- css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStyleProperties):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
../WTF:
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/BitArray.h: Removed.
- wtf/CMakeLists.txt:
- 10:21 AM Changeset in webkit [160491] by
-
- 65 edits in trunk
Make algorithm.name return registered name, not normalized one
https://bugs.webkit.org/show_bug.cgi?id=125641
Reviewed by Anders Carlsson.
Source/WebCore:
Currently, WebCrypto editor's draft stipulates that algorithm name is lowercased
as part of normalization.
But it makes little sense to register algorithms as mixed (mostly upper) case, yet
return the name lowercased. Other implementations don't bother respecting this,
and signs are that the spec will change.
I'd like to match other implementations here, because sticking to the spec only
makes us fail 3rd party test suites for no good reason.
Updated many existing tests.
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- crypto/CryptoAlgorithmRegistry.h:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
- crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
- crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
- crypto/algorithms/CryptoAlgorithmSHA1.cpp:
- crypto/algorithms/CryptoAlgorithmSHA224.cpp:
- crypto/algorithms/CryptoAlgorithmSHA256.cpp:
- crypto/algorithms/CryptoAlgorithmSHA384.cpp:
- crypto/algorithms/CryptoAlgorithmSHA512.cpp:
LayoutTests:
- crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
- crypto/subtle/aes-cbc-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-generate-key-expected.txt:
- crypto/subtle/aes-cbc-generate-key.html:
- crypto/subtle/aes-cbc-import-jwk-expected.txt:
- crypto/subtle/aes-cbc-import-jwk.html:
- crypto/subtle/aes-cbc-invalid-length-expected.txt:
- crypto/subtle/aes-cbc-invalid-length.html:
- crypto/subtle/aes-cbc-unwrap-failure-expected.txt:
- crypto/subtle/aes-cbc-unwrap-failure.html:
- crypto/subtle/aes-cbc-unwrap-rsa-expected.txt:
- crypto/subtle/aes-cbc-unwrap-rsa.html:
- crypto/subtle/aes-cbc-wrap-rsa-expected.txt:
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt:
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html:
- crypto/subtle/aes-cbc-wrap-rsa.html:
- crypto/subtle/aes-kw-key-manipulation-expected.txt:
- crypto/subtle/aes-kw-key-manipulation.html:
- crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
- crypto/subtle/aes-kw-wrap-unwrap-aes.html:
- crypto/subtle/aes-postMessage-expected.txt:
- crypto/subtle/aes-postMessage.html:
- crypto/subtle/hmac-generate-key-expected.txt:
- crypto/subtle/hmac-generate-key.html:
- crypto/subtle/hmac-import-jwk-expected.txt:
- crypto/subtle/hmac-import-jwk.html:
- crypto/subtle/hmac-postMessage-expected.txt:
- crypto/subtle/hmac-postMessage.html:
- crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
- crypto/subtle/hmac-sign-verify-empty-key.html:
- crypto/subtle/hmac-sign-verify-expected.txt:
- crypto/subtle/hmac-sign-verify.html:
- crypto/subtle/postMessage-worker-expected.txt:
- crypto/subtle/postMessage-worker.html:
- crypto/subtle/resources/postMessage-worker.js:
- crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
- crypto/subtle/rsa-oaep-key-manipulation.html:
- crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
- crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
- crypto/subtle/rsa-postMessage-expected.txt:
- crypto/subtle/rsa-postMessage.html:
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
- 9:21 AM Changeset in webkit [160490] by
-
- 4 edits in trunk
[Autotools] Prepend the WebCore layer archives' names with 'lib'
https://bugs.webkit.org/show_bug.cgi?id=125627
Reviewed by Martin Robinson.
Source/WebKit2:
- GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended with 'lib'
when they are used during linking, so the prefix is now added to avoid such issues.
Tools:
- TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
- 9:03 AM Changeset in webkit [160489] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Rebaseline fast/table/empty-cells.html after r160410.
- platform/efl/fast/table/empty-cells-expected.png:
- platform/efl/fast/table/empty-cells-expected.txt:
- 6:02 AM Changeset in webkit [160488] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing compositing tests.
- platform/efl-wk2/TestExpectations:
- 4:30 AM Changeset in webkit [160487] by
-
- 41 edits1 copy3 moves1 delete in trunk/Source
Move CertificateInfo to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124720
Reviewed by Darin Adler.
Based on the patch by Kwang Yul Seo <skyul@company100.net>
Source/WebCore:
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/CertificateInfo.h.
(WebCore::CertificateInfo::setCertificateChain): Added, because WebCoreArgumentCoders needs it.
- platform/network/mac/CertificateInfoMac.mm: Renamed from Source/WebKit2/Shared/mac/CertificateInfo.mm.
(WebCore::CertificateInfo::CertificateInfo): Moved encode() and decode() to WebCoreArgumentCodersMac.mm.
- platform/network/soup/CertificateInfo.cpp: Copied from Source/WebKit2/Shared/WebCertificateInfo.h.
(WebCore::CertificateInfo::CertificateInfo): Moved encode() and decode() to WebCoreArgumentCodersSoup.cpp.
- platform/network/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/CertificateInfo.h.
(WebCore::CertificateInfo::setCertificate): Added, because WebCoreArgumentCoders needs it.
(WebCore::CertificateInfo::setTLSErrors): Added, because WebCoreArgumentCoders needs it.
Source/WebKit2:
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::ArgumentCoder<CertificateInfo>::encode):
(CoreIPC::ArgumentCoder<CertificateInfo>::decode):
- Shared/soup/CertificateInfo.cpp: Removed.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::ArgumentCoder<CertificateInfo>::encode):
(CoreIPC::ArgumentCoder<CertificateInfo>::decode):
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
- 4:21 AM Changeset in webkit [160486] by
-
- 4 edits in trunk
Unreviewed, rolling out r160446.
http://trac.webkit.org/changeset/160446
https://bugs.webkit.org/show_bug.cgi?id=125630
The upower-glib-based implementation is using API that was
recently removed (Requested by zdobersek1 on #webkit).
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/gtk/TestExpectations:
- 4:04 AM Changeset in webkit [160485] by
-
- 13 edits2 deletes in trunk
Unreviewed, rolling out r160417.
http://trac.webkit.org/changeset/160417
https://bugs.webkit.org/show_bug.cgi?id=125629
The patch is causing crashes (Requested by zdobersek1 on
#webkit).
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::detachWrapper):
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::detachWrapper):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::detachWrapper):
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::detachWrapper):
Tools:
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
LayoutTests:
- accessibility/children-changed-sends-notification-expected.txt: Removed.
- accessibility/children-changed-sends-notification.html: Removed.
- accessibility/loading-iframe-sends-notification.html:
- platform/mac/TestExpectations:
- 3:54 AM Changeset in webkit [160484] by
-
- 3 edits in trunk/Source/WebCore
Remove a few more guards mistakenly added in r160367
Reviewed by Carlos Garcia Campos
r160367 was too liberal in hiding APIs from the GObject DOM bindings.
We should expose the BatteryManager and the text and audio tracks.
- Modules/battery/BatteryManager.idl:
- html/HTMLMediaElement.idl:
- 2:17 AM Changeset in webkit [160483] by
-
- 10 edits3 adds in trunk/Source/WebInspectorUI
Web Inspector: allow editing of colors in CSS resources
https://bugs.webkit.org/show_bug.cgi?id=124364
Reviewed by Timothy Hatcher.
Identify colors in CSS and HTML resources so that hovering these colors shows a HoverMenu
allowing a ColorPicker hosted in a Popover to be shown to edit the hovered color.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
Remove the code that goes through the lines of the CodeMirror editor to look for
color strings and replace it with a call to the .createColorMarkers() CodeMirror
extension in which the code was refactored. The callback passed to
.createColorMarkers() handles the CSSStyleDeclarationTextEditor-specific creation
of color swatches to show the popover, keeping the existing behavior of the Styles
sidebar panel.
- UserInterface/CodeMirrorAdditions.js:
Refactor existing code into two new CodeMirror extensions: .boundsForRange(), which
was previously defined on the CodeMirrorTokenTrackingController but was also needed
in the new CodeMirrorColorEditingController, and .createColorMarkers(), discussed above.
- UserInterface/CodeMirrorColorEditingController.js: Added.
(WebInspector.CodeMirrorColorEditingController):
New class used by SourceCodeTextEditor to coordinate the editing of a color in a CodeMirror
TextMarker by a ColorPicker hosted in a Popover shown by the activation of a HoverMenu. This
controller automatically gets the color set by the user using the ColorPicker and updates
the CodeMirror text editor with the new value. When the user presses the Esc. key while the
popover is shown, it's automatically dismissed and the original color is reset in the editor.
(WebInspector.CodeMirrorColorEditingController.prototype.get marker):
(WebInspector.CodeMirrorColorEditingController.prototype.get range):
(WebInspector.CodeMirrorColorEditingController.prototype.get delegate):
(WebInspector.CodeMirrorColorEditingController.prototype.set delegate):
Getters and setters for public properties.
(WebInspector.CodeMirrorColorEditingController.prototype.get color):
(WebInspector.CodeMirrorColorEditingController.prototype.set color):
Get and set the color for the edited color marker, replacing the text in the marker's range
upon setting.
(WebInspector.CodeMirrorColorEditingController.prototype.presentHoverMenu):
Public API allowing for a HoverMenu to be shown around the bounds of the TextMarker passed
in the constructor. This method is called from SourceCodeTextEditor when the
CodeMirrorTokenTrackingController identifies that a token that is part of a TextMarker is
hovered and that token is a color.
(WebInspector.CodeMirrorColorEditingController.prototype.dismissHoverMenu):
Public API allowing for the HoverMenu to be dismissed. This method is called when the
CodeMirrorTokenTrackingController identifies that its "hoveredMarker" is no longer being
hovered as well as when we identify that editing of the color has completed.
(WebInspector.CodeMirrorColorEditingController.prototype.handleEvent):
Event handler for the "keydown" event that are being listened to when the HoverMenu
is activated such that the Esc. key can be used to dimiss the popover and reset the
original color before any edits.
(WebInspector.CodeMirrorColorEditingController.prototype.hoverMenuButtonWasPressed):
Implementation of the HoverMenu delegation method used to show a Popover containing a
ColorPicker upon clicking on the color wheel attached to the HoverMenu. We also remember
the color set on the marker so that it may be restored when Esc. is pressed and used to
set the original state of the ColorPicker. The delegation method
colorEditingControllerDidStartEditing() is also called at this point, which the
SourceCodeTextEditor implements.
(WebInspector.CodeMirrorColorEditingController.prototype.didDismissPopover):
Implementation of the Popover delegation method used to identify that color editing has
completed. The delegation method colorEditingControllerDidFinishEditing() is called
at this point, which the SourceCodeTextEditor implements.
(WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
Apply the color set in the color picker to the CodeMirror text editor.
- UserInterface/CodeMirrorTokenTrackingController.js:
Add two new modes to CodeMirrorTokenTrackingController. The first mode is "None" and is
the default, incurring no specific token handling behavior. The second mode is "MarkedTokens"
which identifies hover of a token contained in a CodeMirror TextMarker range. The new
"MarkedTokens" mode is used by SourceCodeTextEditor to identify when a marked color is being
hovered to display a HoverMenu.
(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set mode):
Make "None" the new default mode for CodeMirrorTokenTrackingController.
(WebInspector.CodeMirrorTokenTrackingController.prototype.get hoveredMarker):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set hoveredMarker):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Check, when we have a "hoveredMarker" set on the CodeMirrorTokenTrackingController,
whether the "hoveredMarker" is still being hovered when there is no token at the current
mouse position. We can then determine when we're mousing out of the "hoveredMarker" and
notify the delegate via the new tokenTrackingControllerMouseOutOfHoveredMarker delegate
method. The SourceCodeTextEditor uses this method to dismiss its CodeMirrorColorEditingController.
(WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
Add support for the new "MarkedTokens" mode.
(WebInspector.CodeMirrorTokenTrackingController.prototype._processMarkedToken):
For the moment, use the same behavior as the existing "MarkedTokens" mode.
- UserInterface/Color.js:
(WebInspector.Color):
Add a new "valid" property to identify whether a color has any invalid (NaN) component. This property
is used by SourceCodeTextEditor to establish whether a hovered color marker is indeed set to a
valid color still.
(WebInspector.Color.prototype.copy):
New method to create an exact copy of a Color instance, used by CodeMirrorColorEditingController
to duplicate the edited color in case we need to revert it.
- UserInterface/HoverMenu.js:
(WebInspector.HoverMenu.prototype._handleClickEvent):
Rename hoverMenuWasActivated to hoverMenuButtonWasPressed per review feedback.
- UserInterface/Images/ColorIcon.png: Added.
- UserInterface/Images/ColorIcon@2x.png: Added.
New color wheel icon used to customize the HoverMenu shown by a CodeMirrorColorEditingController.
- UserInterface/Main.html:
Link to the new CodeMirrorColorEditingController.js file.
- UserInterface/SourceCodeTextEditor.css:
(.hover-menu.color):
(.hover-menu.color > img):
Customize the HoverMenu shown by a CodeMirrorColorEditingController to use the new ColorIcon asset.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
Add a new "_ignoreContentDidChange" ivar that increments and decrements to track when handling
of CodeMirror content changes should be disabled.
(WebInspector.SourceCodeTextEditor.prototype.close):
Adopt the new ._updateTokenTrackingControllerState() method to update the state of the
CodeMirrorTokenTrackingController.
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
Override the new TextEditor public API called when content in the CodeMirror text editor is changed.
We use this method to process any newly added line to create any newly added color marker.
(WebInspector.SourceCodeTextEditor.prototype._contentDidPopulate):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._sourceCodeSourceMapAdded):
Adopt the new ._updateTokenTrackingControllerState() method to update the state of the
CodeMirrorTokenTrackingController.
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
New method acting as the only point where we check the state of the text editor and set the right
mode and settings on the CodeMirrorTokenTrackingController, including setting the new "MarkedTokens"
mode when we have color markers, as determined by ._hasColorMarkers().
(WebInspector.SourceCodeTextEditor.prototype._hasColorMarkers):
Check whether any of the TextMarkers set on the CodeMirror text editor were created for a color.
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
Check the CodeMirrorTokenTrackingController mode rather than the removed "_jumpToSymbolTrackingModeEnabled"
ivar to identify we're in the "NonSymbolTokens" mode.
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
Refactor method to use the CodeMirrorTokenTrackingController mode to branch into mode-specific code
and add a new branch for the new "MarkedTokens" mode where we check if the newly hovered token
is part of a color TextMarker range.
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerMouseOutOfHoveredMarker):
Implement this new CodeMirrorTokenTrackingController delegation method to dismiss the
CodeMirrorColorEditingController as we identify we're no longer hovering over the TextMarker
for which the CodeMirrorColorEditingController was created.
(WebInspector.SourceCodeTextEditor.prototype._showPopover):
Adopt the new TextEditor boundsForRange() method.
(WebInspector.SourceCodeTextEditor.prototype._updateColorMarkers):
Harness the new TextEditor createColorMarkers() method to create new TextMarkers for the provided
line, or the entire text editor content if none provided. We then immediately call _updateTokenTrackingControllerState()
so that the new "MarkedTokens" mode is entered in case color TextMarkers were created for the first
time for this text editor.
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
Called when we've identified the CodeMirrorTokenTrackingController highlighted a TextMarker. We check
if any of the hovered TextMarkers are for a color, and in this case create a CodeMirrorColorEditingController
to coordinate the display of a ColorPicker in a Popover to edit the hovered color token. We also check
whether the hovered marker still contains a valid color, clearing the marker in case it was edited to
no longer contain a color.
(WebInspector.SourceCodeTextEditor.prototype._dismissCodeMirrorColorEditingController):
Used to dismiss the CodeMirrorColorEditingController, if previously presented, and reset some internal state.
(WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidStartEditing):
Implement this CodeMirrorColorEditingController delegation method to temporarily disable the
CodeMirrorTokenTrackingController while we edit the color with the ColorPicker, remove
the TextMarker for the edited color and instruct that content changes should be ignored
such that we act on the complete set of color edits upon completion.
(WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidFinishEditing):
Update color markers for the edited line such that any color edits are correctly updated for
the future and so that, as a side-effect, the CodeMirrorColorEditingController is reset to the
appropriate mode depending on whether color TextMarkers are indeed available, resetting states
that may have been altered by colorEditingControllerDidStartEditing().
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.contentDidChange):
New public method meant to be overriden by subclasses, added for the use of SourceCodeTextEditor, exposing
the list of TextRanges affected by the content change, both in the context of the old content and new content.
(WebInspector.TextEditor.prototype.boundsForRange):
(WebInspector.TextEditor.prototype.get markers):
(WebInspector.TextEditor.prototype.findMarkersAtPosition):
(WebInspector.TextEditor.prototype.createColorMarkers):
(WebInspector.TextEditor.prototype.colorEditingControllerForMarker):
New public methods calling into the CodeMirror private ivar for the benefit of SourceCodeTextEditor.
(WebInspector.TextEditor.prototype._contentChanged):
Call the new contentDidChange() method.
- 2:10 AM Changeset in webkit [160482] by
-
- 6 edits in trunk
Use of ar T option not supported by older binutils
https://bugs.webkit.org/show_bug.cgi?id=118732
Reviewed by Gustavo Noronha Silva.
.:
- Source/autotools/SetupLibtool.m4: Make the AR_FLAGS value usable inside makefiles as an Automake variable.
Source/WebKit2:
- GNUmakefile.am: To support non-thin archives when generating the WebCoreLayerGtk2 archive,
switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
new archive. Non-thin archives also pose the problem as their members are only noted by the basename
of the member's object file, and not the full path to it. To work around that, all the object files
under the build directory are listed by their relative paths. The members of various archives then have
the basenames of their paths grepped against that list, with the found path correlating to the member
finally added as the new member of the WebCoreLayerGtk2 archive.
Tools:
- TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
new archive. Non-thin archives also pose the problem as their members are only noted by the basename
of the member's object file, and not the full path to it. To work around that, all the object files
under the build directory are listed by their relative paths. The members of various archives then have
the basenames of their paths grepped against that list, with the found path correlating to the member
finally added as the new member of the WebCoreLayer archive.
- 1:17 AM Changeset in webkit [160481] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebProcess tests are failing with newer glib
https://bugs.webkit.org/show_bug.cgi?id=125621
Reviewed by Martin Robinson.
Newer versions of glib unset the DISPLAY env variable in
g_test_dbus_up(). The WebProcess needs the DISPLAY variable to
work, and it's important to keep its value when running the tests
under Xvfb.
- UIProcess/API/gtk/tests/WebProcessTestRunner.cpp:
(WebProcessTestRunner::WebProcessTestRunner): Restore the DISPLAY
env variable after calling g_test_dbus_up().
- 1:12 AM Changeset in webkit [160480] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Make sure unit tests don't use GVFS and dconf
https://bugs.webkit.org/show_bug.cgi?id=125620
Reviewed by Martin Robinson.
They should use the local vfs and the gsettings memory backend.
- UIProcess/API/gtk/tests/TestMain.cpp:
(main):
- 12:58 AM Changeset in webkit [160479] by
-
- 9 edits2 adds in trunk
StylePendingImage needs to correctly manage the CSSValue pointer lifetime
https://bugs.webkit.org/show_bug.cgi?id=125468
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/css/pending-image-crash.xhtml
Disconnect the reference counted StylePendingImage from the CSSValue that owns
it when it's not needed any more, otherwise we could end up using a pointer
that might no longer be valid.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::detachPendingImage): Added. Calls detachFromCSSValue
on the current image if it is a StylePendingImage.
(WebCore::CSSCursorImageValue::~CSSCursorImageValue): Call detachPendingImage.
(WebCore::CSSCursorImageValue::cachedImage): Call detachPendingImage before changing
m_image to a new value.
(WebCore::CSSCursorImageValue::clearCachedImage): Ditto.
- css/CSSCursorImageValue.h: Added detachPendingImage.
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::detachPendingImage): Added. Calls detachFromCSSValue
on the current image set if it is a StylePendingImage.
(WebCore::CSSImageSetValue::~CSSImageSetValue): Call detachPendingImage.
(WebCore::CSSImageSetValue::cachedImageSet): Call detachPendingImage before changing
m_imageSet to a new value.
- css/CSSImageSetValue.h: Added detachPendingImage.
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::detachPendingImage): Added. Calls detachFromCSSValue on the
current image if it is a StylePendingImage.
(WebCore::CSSImageValue::~CSSImageValue): Call detachPendingImage.
(WebCore::CSSImageValue::cachedImage): Call detachPendingImage before changing m_image
to a new value.
- css/CSSImageValue.h: Added detachPendingImage.
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageValue): Added a null check.
(WebCore::StylePendingImage::cssImageGeneratorValue): Added a null check.
(WebCore::StylePendingImage::cssCursorImageValue): Added a null check.
(WebCore::StylePendingImage::cssImageSetValue): Added a null check.
(WebCore::StylePendingImage::detachFromCSSValue): Added. Sets m_value to null since
the style is no longer using this StylePendingImage.
(WebCore::StylePendingImage::data): Changed to use the "this" pointer since all we
need is some arbitrary pointer uniquely identifying the image. Before loading the image,
we have no suitable weak identifier, so it suffices to use the unique pointer to each
StylePendingImage object. This function is used only in a limited way; it would be nice
to find a way to make the code less strange long term.
LayoutTests:
- fast/css/pending-image-crash-expected.txt: Added.
- fast/css/pending-image-crash.xhtml: Added.
- 12:44 AM Changeset in webkit [160478] by
-
- 5 edits in trunk/Source/WebCore
Remove some unneeded code noticed while looking at StylePendingImage
https://bugs.webkit.org/show_bug.cgi?id=125618
Reviewed by Andreas Kling.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage): Removed redundant function calls.
- rendering/RenderImageResource.cpp: Removed unneeded nullImage and
usesImageContainerSize member functions.
(WebCore::RenderImageResource::image): Use Image::nullImage directly instead of
through RenderImageResourceImage::nullImage.
- rendering/RenderImageResource.h: Removed unneeded usesImageContainerSize
and nullImage functions. Also removed unneeded includes.
- rendering/RenderImageResourceStyleImage.h: Removed unneeded
usesImageContainerSize override. Nobody was calling it.
Dec 11, 2013:
- 10:38 PM Changeset in webkit [160477] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Set stack pointer in OSR exit handler
https://bugs.webkit.org/show_bug.cgi?id=125617
Not yet reviewed.
Set the stack pointer off of the callFrameRegister just like at the top of the function.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget):
- 8:01 PM Changeset in webkit [160476] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Build fix after r160464
https://bugs.webkit.org/show_bug.cgi?id=125615
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-12-11
Reviewed by Gyuyoung Kim.
Modify the 2nd parameter for calling WebContext::addMessageReceiver from "this" to "*this"
because the parameter type is modified from CoreIPC::MessageReceiver* to CoreIPC::MessageReceiver&
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
- UIProcess/WebBatteryManagerProxy.cpp:
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
- UIProcess/WebNetworkInfoManagerProxy.cpp:
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):
- UIProcess/WebVibrationProxy.cpp:
(WebKit::WebVibrationProxy::WebVibrationProxy):
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::WebBatteryManager):
- WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::WebSoupRequestManager):
- 7:20 PM Changeset in webkit [160475] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merged r156290. <rdar://problem/15498810>
- 7:08 PM Changeset in webkit [160474] by
-
- 24 edits in branches/safari-537.74-branch
Merged r154513. <rdar://problem/15498763>
- 6:47 PM Changeset in webkit [160473] by
-
- 5 edits in trunk/Source
Versioning.
- 6:44 PM Changeset in webkit [160472] by
-
- 1 copy in tags/Safari-538.9
New Tag.
- 6:35 PM Changeset in webkit [160471] by
-
- 15 edits2 deletes in branches/safari-537.74-branch
Rolled out r160469.
- 6:23 PM Changeset in webkit [160470] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Introducing MaxFrameExtentForSlowPathCall.h.
https://bugs.webkit.org/show_bug.cgi?id=125609.
Reviewed by Mark Hahnenberg.
- assembler/MaxFrameExtentForSlowPath.h: Added.
- defines a constant for the max amount of stack space that we need to allocate (per JS frame) for holding the outgoing args for slow path calls from JS to C functions.
- 5:59 PM Changeset in webkit [160469] by
-
- 15 edits2 adds in branches/safari-537.74-branch
Merged r157821. <rdar://problem/15474133>
- 5:57 PM Changeset in webkit [160468] by
-
- 17 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: enable use of DFG for simple JavaScript
https://bugs.webkit.org/show_bug.cgi?id=125599
Not yet reviewed.
Added code to set up the stack pointer on entry and for call for the DFG. Changed the
SpeculativeJIT::calleeFrame*() helpers to use the stack pointer instead of the call frame
register to build the callee frame relative to the stack.
Disabled JSStack::sanitizeStack(). Removed some calls to checkStackPointerAlignment() used
for earlier debugging.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
(JSC::DFG::SpeculativeJIT::calleeFrameSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentSlot):
(JSC::DFG::SpeculativeJIT::calleeFrameTagSlot):
(JSC::DFG::SpeculativeJIT::calleeFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentTagSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::calleeFrameCallerFrame):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):
- interpreter/JSStack.cpp:
(JSC::JSStack::sanitizeStack):
- interpreter/JSStack.h:
- interpreter/ProtoCallFrame.cpp:
(JSC::ProtoCallFrame::init):
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/Repatch.cpp:
(JSC::linkClosureCall):
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- 5:56 PM Changeset in webkit [160467] by
-
- 12 edits2 adds in trunk/Source/WebCore
Add the CFNetwork implementation of the asynchronous ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=124440
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-11
Reviewed by Alexey Proskuryakov.
Add a second subclass of ResourceHandleCFURLConnectionDelegate: ResourceHandleCFURLConnectionDelegateWithOperationQueue.
The difference is those objects handle the network callback on a different queue.
Some common code has been refactored in ResourceHandleCFURLConnectionDelegate to reduce duplicated code.
The initialization of the request and connection is moved to the subclass to clean up initialization.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::willCacheResponseAsync):
- platform/network/ResourceHandleClient.h:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp: Added.
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::~ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::connectionWasCancelled):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupConnectionScheduling):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueWillSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueDidReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueShouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueWillCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueCanAuthenticateAgainstProtectionSpace):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h: Copied from Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::shouldUseCredentialStorage):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegate::releaseHandle):
(WebCore::ResourceHandleCFURLConnectionDelegate::synthesizeRedirectResponseIfNecessary):
(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::setupRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::setupConnectionScheduling):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueWillSendRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueDidReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueShouldUseCredentialStorage):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueWillCacheResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueCanAuthenticateAgainstProtectionSpace):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
- 5:26 PM Changeset in webkit [160466] by
-
- 3 edits in trunk/Tools
check-webkit-style shouldn't check spacing in #if preprocessor lines
https://bugs.webkit.org/show_bug.cgi?id=125534
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-11
Reviewed by Ryosuke Niwa.
Preprocessor lines that start with #if shouldn't have to adhere to
the same spacing requirements that regular code does
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
(WebKitStyleTest.test_line_breaking):
- 3:38 PM Changeset in webkit [160465] by
-
- 2 edits in trunk/Source/WebKit
[Win] Build fix after r159768.
https://bugs.webkit.org/show_bug.cgi?id=125467
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-11
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKit/WebKitVersion.cmd:
Set PATH environment variable to include cygwin bin directory.
- 3:36 PM Changeset in webkit [160464] by
-
- 38 edits in trunk/Source/WebKit2
MessageReceiverMap should take MessageReceiver objects by reference
https://bugs.webkit.org/show_bug.cgi?id=125605
Reviewed by Tim Horton.
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::addMessageReceiver):
- Platform/CoreIPC/MessageReceiverMap.h:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::addMessageReceiver):
- Shared/ChildProcess.h:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::addMessageReceiver):
- Shared/ChildProcessProxy.h:
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
- UIProcess/WebContext.h:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::WebOriginDataManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::WebCookieManager):
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::WebGeolocationManager):
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
- WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::WebMediaCacheManager):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::WebNotificationManager):
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::WebOriginDataManager):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::WebResourceCacheManager):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
- WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::WebDatabaseManager):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 3:17 PM Changeset in webkit [160463] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed link fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbols.
- 3:15 PM Changeset in webkit [160462] by
-
- 7 edits in trunk/Source
Define m_hasBadParent in InlineBox if defined(ADDRESS_SANITIZER)
<http://webkit.org/b/125329>
Reviewed by Darin Adler.
Source/WebCore:
No tests since this is a build fix for:
$ ./Tools/Scripts/build-webkit --release OTHER_CFLAGS="$inherited -DADDRESS_SANITIZER=1"
- rendering/InlineBox.cpp:
- rendering/InlineBox.h:
- Replace ASSERT_DISABLED use with ASSERT_WITH_SECURITY_IMPLICATION_DISABLED for m_hasBadParent.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::~InlineFlowBox):
- Use !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED instead of #ifndef NDEBUG since this calls setHasBadParent().
(WebCore::InlineFlowBox::checkConsistency):
- Move ASSERT(!m_hasBadChildList) outside of #if CHECK_CONSISTENCY and change to ASSERT_WITH_SECURITY_IMPLICATION(!m_hasBadChildList).
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::setHasBadChildList):
- Change #ifndef NDEBUG to #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED for code using m_hasBadChildList.
Source/WTF:
- wtf/Assertions.h: Define macro
ASSERT_WITH_SECURITY_IMPLICATION_DISABLED based on whether
ASSERT_WITH_SECURITY_IMPLICATION() is enabled.
- 3:05 PM Changeset in webkit [160461] by
-
- 3 edits in trunk/Tools
check-webkit-style can't determine if a comma is part of an initialization list
https://bugs.webkit.org/show_bug.cgi?id=125537
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-11
Reviewed by Darin Adler.
The original check to make sure that initialization list lines start with
a comma didn't distinguish between commas that belong to the initialization
list and commas that are part of function calls. Because we don't want to
match parentheses with regular expressions, we should weaken this check to
only check for commas at the end of initialization list lines.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_member_initialization_list):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_member_initialization_list):
- 3:00 PM Changeset in webkit [160460] by
-
- 2 edits in trunk/Source/WTF
Type punning error in MD5.cpp
https://bugs.webkit.org/show_bug.cgi?id=125412
Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-11
Reviewed by Darin Adler.
- wtf/MD5.cpp:
(WTF::toLittleEndian): Renamed, and use memcpy instead of casting.
(WTF::MD5::addBytes): Renamed reverseBytes to toLittleEndian.
(WTF::MD5::checksum): Same, and use memcpy instead of casting to prevent type punning error.
- 2:47 PM Changeset in webkit [160459] by
-
- 9 edits1 add in trunk/Tools
Make it possible to compare layout test results between various configurations of WebKit
https://bugs.webkit.org/show_bug.cgi?id=125212
<rdar://problem/15199108>
Reviewed by Darin Adler.
- Scripts/compare-webkit-configurations: Added.
Add a script that allows comparison between the "normal" WebKit configuration
used for testing and a different configuration (e.g. with accelerated drawing
turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
This script runs the tests once in the default configuration, ignoring
all test expectations, writing the results out to a temporary directory.
It then runs the tests again in the modified configuration, against the
just-written temporary results.
Ref tests are treated as pixel tests, with their pixel output dumped to disk.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
(initializeGlobalsFromCommandLineOptions):
Enable accelerated drawing if requested.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Add --accelerated-drawing and --remote-layer-tree feature switches, which
are forwarded on to the test drivers.
Move those two and --complex-text into their own "feature switches" section.
Drive-by change "Mac OS X" to "OS X".
Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
as traditional pixel tests (with PNGs dumped on disk), and
ignores e.g. -expected.html files.
- Scripts/webkitpy/port/base.py:
(Port.reference_files):
Pretend that there are no ref tests.
Since is_reference_html_file is intact, our mechanism to ignore
the expected files will continue working in this case.
- Scripts/webkitpy/port/driver.py:
(Driver.cmd_line):
Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetPreferencesToConsistentValues):
- WebKitTestRunner/TestController.h:
(WTR::TestController::shouldUseRemoteLayerTree):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::updateThreadedScrollingForCurrentTest):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Parse and implement the three feature switches.
- 2:46 PM Changeset in webkit [160458] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] Fix build on GL ES 2.0 targets after r160119
https://bugs.webkit.org/show_bug.cgi?id=125541
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-12-11
Reviewed by Brent Fulgham.
GL ES 2.0 doesn't define GL_HALF_FLOAT_ARB, so pass through HALF_FLOAT_OES (which is defined for GL ES 2.0).
This change also reverts r160324 which incorrectly defined GL_HALF_FLOAT_ARB for the Windows ANGLE target.
No new tests, no change in functionality.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::texSubImage2D):
- 2:40 PM Changeset in webkit [160457] by
-
- 209 edits4 copies12 moves11 adds1 delete in trunk/Source
Web Inspector: Push More Inspector Required Classes Down into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=125324
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/copy-files.cmd:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/ScriptFunctionCall.cpp: Renamed from Source/WebCore/bindings/js/ScriptFunctionCall.cpp.
- bindings/ScriptFunctionCall.h: Renamed from Source/WebCore/bindings/js/ScriptFunctionCall.h.
- bindings/ScriptObject.cpp: Copied from Source/WebCore/inspector/WorkerConsoleAgent.cpp.
- bindings/ScriptObject.h: Renamed from Source/WebCore/inspector/InspectorBaseAgent.h.
- bindings/ScriptValue.cpp: Renamed from Source/WebCore/bindings/js/ScriptValue.cpp.
- bindings/ScriptValue.h: Renamed from Source/WebCore/bindings/js/ScriptValue.h.
- inspector/InspectorAgentBase.h: Copied from Source/WebCore/inspector/InspectorAgentRegistry.h.
- inspector/InspectorAgentRegistry.cpp: Renamed from Source/WebCore/inspector/InspectorAgentRegistry.cpp.
- inspector/InspectorBackendDispatcher.h: Renamed from Source/WebCore/inspector/InspectorBackendDispatcher.h.
(Inspector::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
(Inspector::InspectorSupplementalBackendDispatcher::~InspectorSupplementalBackendDispatcher):
- inspector/InspectorValues.cpp: Renamed from Source/WebCore/inspector/InspectorValues.cpp.
- inspector/InspectorValues.h: Renamed from Source/WebCore/inspector/InspectorValues.h.
Source/WebCore:
Part 1: Push down core inspector classes.
- Move InspectAgentBase, InspectorAgentRegistry, InspectorBackendDispatcher, InspectorValues down to JavaScriptCore and into the Inspector namespace.
- Add forwarding headers for JavaScriptCore/inspector files.
- Use the Inspector namespace where appropriate.
- Rename InspectorBaseAgent to InspectorAgentBase for clarity.
Part 2: Push Script wrapper classes down into JavaScriptCore/bindings.
- Move ScriptObject and ScriptValue into JavaScriptCore but namespace Deprecated
- Add forwarding headers
- Use Deprecated::ScriptObject and Deprecated::ScriptValue everywhere.
Part 3: Push Down ScriptFunctionCall
- Move ScriptFunctionCall to JavaScriptCore/bindings into namespace Deprecated.
- Give constructor a function to all for a different JSC::call, because WebCore ScriptFunctionCall's use JSMainThreadExecState when isMainThread.
- Prefer Deprecated::ScriptFunctionCall everywhere it is used in WebCore.
Part 4: Extract InspectorTypeBuilder helper functions
- There is a chunk of InspectorTypeBuilder that never changes. Extract it into its own file, InspectorTypeBuilder.h in JSC/inspector, Inspector namespace.
- This moves TypeBuilder from namespace WebCore to namespace Inspector
- Rename the WebCore generated InspectorTypeBuilder to InspectorWebTypeBuilders, eventually the CodeGenerator script will do this for more then TypeBuilders and there will be "JS" TypeBuilders and "Web" TypeBuilders files.
No new tests. No change in functionality, just moving things around.
- CMakeLists.txt:
- ForwardingHeaders/bindings/ScriptFunctionCall.h: Added.
- ForwardingHeaders/bindings/ScriptObject.h: Added.
- ForwardingHeaders/bindings/ScriptValue.h: Added.
- ForwardingHeaders/inspector/InspectorAgentBase.h: Added.
- ForwardingHeaders/inspector/InspectorAgentRegistry.h: Added.
- ForwardingHeaders/inspector/InspectorBackendDispatcher.h: Added.
- ForwardingHeaders/inspector/InspectorTypeBuilder.h: Added.
- ForwardingHeaders/inspector/InspectorValues.h: Added.
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBAny.cpp:
(WebCore::IDBAny::scriptValue):
(WebCore::IDBAny::IDBAny):
- Modules/indexeddb/IDBAny.h:
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::cmp):
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::lowerValue):
(WebCore::IDBKeyRange::upperValue):
(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
- Modules/indexeddb/IDBKeyRange.h:
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessInternal):
- Modules/indexeddb/IDBRequest.h:
- Modules/mediastream/CapabilityRange.cpp:
(WebCore::scriptValue):
(WebCore::CapabilityRange::min):
(WebCore::CapabilityRange::max):
- Modules/mediastream/CapabilityRange.h:
- Modules/mediastream/MediaTrackConstraint.h:
- Modules/mediastream/RTCIceCandidate.cpp:
- Modules/plugins/QuickTimePluginReplacement.cpp:
- Modules/plugins/QuickTimePluginReplacement.h:
- UseJSC.cmake:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/Dictionary.h:
(WebCore::Dictionary::getEventListener):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValue):
(WebCore::deserializeIDBValueBuffer):
(WebCore::idbKeyToScriptValue):
(WebCore::scriptValueToIDBKey):
- bindings/js/IDBBindingUtilities.h:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::JSInjectedScriptHost::inspectedObject):
(WebCore::JSInjectedScriptHost::inspect):
- bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
- bindings/js/JSMainThreadExecState.cpp:
(WebCore::functionCallHandlerFromAnyThread):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::currentState):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
- bindings/js/ScheduledAction.cpp:
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptArguments):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/js/ScriptController.h:
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::updateCallStack):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::runScript):
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptGlobalObject.cpp: Renamed from Source/WebCore/bindings/js/ScriptObject.cpp.
(WebCore::handleException):
(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):
- bindings/js/ScriptGlobalObject.h: Copied from Source/WebCore/inspector/ScriptCallStack.h.
(WebCore::ScriptGlobalObject::ScriptGlobalObject):
- bindings/js/ScriptObject.h: Removed.
- bindings/js/ScriptProfile.cpp:
(WebCore::buildInspectorObjectFor):
(WebCore::ScriptProfile::buildInspectorObjectForHead):
(WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
- bindings/js/ScriptProfile.h:
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore::ScriptProfiler::getHeapObjectId):
- bindings/js/ScriptProfiler.h:
- bindings/js/ScriptState.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore::SerializedScriptValue::serialize):
(WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
- bindings/js/WorkerScriptController.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjAnyAttribute):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
- dom/CustomEvent.h:
(WebCore::CustomEvent::detail):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
- dom/MessageEvent.h:
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsScriptValue):
- dom/PopStateEvent.h:
(WebCore::PopStateEvent::state):
- dom/ScriptElement.cpp:
- html/HTMLMediaElement.cpp:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.get_raw_validator_call_text):
(RawTypes.Object.get_array_item_raw_c_type_text):
(RawTypes.Any.get_array_item_raw_c_type_text):
(RawTypes.Array.get_array_item_raw_c_type_text):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(TypeModel.ExactlyInt.get_input_param_type_text):
(TypeModel.ExactlyInt.get_opt_output_type_):
(TypeModel.init_class):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Inspector):
(ArrayBinding.get_array_item_c_type_text):
(Generator.go):
(Generator.process_command):
- inspector/CodeGeneratorInspectorStrings.py:
(void):
(InspectorFrontend_h):
(InspectorBackendDispatchers_h):
- inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):
- inspector/ConsoleMessage.h:
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
- inspector/ContentSearchUtils.h:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::getInternalProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapTable):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::initialize):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
(WebCore::InjectedScriptCanvasModule::resourceInfo):
(WebCore::InjectedScriptCanvasModule::resourceState):
- inspector/InjectedScriptCanvasModule.h:
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::InspectableObject::get):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
(WebCore::InjectedScriptModule::ensureInjected):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::inspect):
- inspector/InspectorAgent.h:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModule):
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
- inspector/InspectorClient.cpp:
- inspector/InspectorClient.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectableHeapObject::get):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::didCommitLoad):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::breakpointActionTypeForString):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::scriptToInspectorObject):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::clear):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorForwarding.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(WebCore::InspectorFrontendHost::showContextMenu):
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::createSnapshotHeader):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
(WebCore::InspectorHeapProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::getHeapObjectId):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::InspectorInputAgent):
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
- inspector/InspectorInputAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::buildObjectForIntRect):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorOverlay.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getCPUProfile):
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorProfilerAgent::getHeapObjectId):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::buildErrorRangeObject):
(WebCore::InspectorRuntimeAgent::parse):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::buildSourceRangeObject):
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId):
(WebCore::InspectorStyleSheet::canBind):
- inspector/InspectorStyleTextEditor.cpp:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::sendEvent):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
- inspector/InspectorWebAgentBase.h: Renamed from Source/WebCore/inspector/InspectorAgentRegistry.h.
(WebCore::InspectorAgentBase::InspectorAgentBase):
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
- inspector/InspectorWorkerAgent.h:
- inspector/InstrumentingAgents.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/PageConsoleAgent.cpp:
(WebCore::InspectableNode::get):
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
- inspector/PageRuntimeAgent.h:
- inspector/ScriptArguments.cpp:
(WebCore::ScriptArguments::create):
(WebCore::ScriptArguments::ScriptArguments):
(WebCore::ScriptArguments::argumentAt):
(WebCore::ScriptArguments::getFirstArgumentAsString):
- inspector/ScriptArguments.h:
- inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::buildInspectorObject):
- inspector/ScriptCallFrame.h:
- inspector/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::buildInspectorArray):
- inspector/ScriptCallStack.h:
- inspector/ScriptDebugListener.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/TimelineRecordFactory.h:
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):
- inspector/WorkerConsoleAgent.cpp:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
- inspector/WorkerRuntimeAgent.h:
- page/Console.cpp:
- page/ContentSecurityPolicy.cpp:
- page/Frame.cpp:
- page/PageConsole.cpp:
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest):
- testing/Internals.cpp:
(WebCore::Internals::parserMetaData):
- testing/Internals.h:
- workers/SharedWorkerGlobalScope.cpp:
(WebCore::createConnectEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
- workers/WorkerThread.cpp:
- xml/XMLTreeViewer.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/blackberry:
- Api/WebPage.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebView/WebFrame.mm:
- WebView/WebView.mm:
Source/WebKit/win:
- WebFrame.cpp:
- WebView.cpp:
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebPage.cpp:
- 2:31 PM Changeset in webkit [160456] by
-
- 9 edits in trunk/Source
Store SHA1 hash in std::array
https://bugs.webkit.org/show_bug.cgi?id=125446
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-11
Reviewed by Darin Adler.
Change Vector to std::array and use typedef.
Source/JavaScriptCore:
- bytecode/CodeBlockHash.cpp:
(JSC::CodeBlockHash::CodeBlockHash):
Source/WebCore:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::createDigest):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::HostTLSCertificateSet::computeCertificateHash):
Source/WTF:
- wtf/SHA1.cpp:
(WTF::SHA1::computeHash):
(WTF::SHA1::hexDigest):
(WTF::SHA1::computeHexDigest):
- wtf/SHA1.h:
- 2:13 PM Changeset in webkit [160455] by
-
- 13 edits9 adds in trunk
WebCrypto keys should support structured clone
https://bugs.webkit.org/show_bug.cgi?id=125590
Reviewed by Oliver Hunt.
Source/WebCore:
Tests: crypto/subtle/aes-postMessage.html
crypto/subtle/hmac-postMessage.html
crypto/subtle/postMessage-worker.html
crypto/subtle/rsa-postMessage.html
- crypto/CryptoAlgorithmIdentifier.h:
(WebCore::CryptoAlgorithmIdentifier):
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
AES_KW was added to WebCrypto spec editor's draft yesterday night. Now that we're
adding a matching enum for structired clone serialization, it's as good a time as
any to update the order of values to match.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::countUsages):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
(WebCore::CloneDeserializer::readHMACKey):
(WebCore::CloneDeserializer::readAESKey):
(WebCore::CloneDeserializer::readRSAKey):
(WebCore::CloneDeserializer::readCryptoKey):
(WebCore::CloneDeserializer::readTerminal):
Added serialization/deserialization for CryptoKey. This doesn't update version
number, because we don't currently store structured clones in persistent storage -
and even if we did, we wouldn't want to invalidate everything users already stored.
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::CryptoAlgorithmRegistry::shared):
(WebCore::registryMutex):
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- crypto/CryptoKey.idl:
With structured clone, it is now possible to send a Key to a web worker. That's
of no practical use because the crypto API is not exposed in workers, but we
shouldn't crash anyway.
- crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::CryptoKeyAES):
(WebCore::CryptoKeyAES::isValidAESAlgorithm):
- crypto/keys/CryptoKeyAES.h:
Exposed isValidAESAlgorithm, so that a caller could know whether the constructor
will assert.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/WebCoreCommon.props:
Added crypto/keys to search paths to avoid build breakage.
LayoutTests:
- crypto/subtle/aes-postMessage-expected.txt: Added.
- crypto/subtle/aes-postMessage.html: Added.
- crypto/subtle/hmac-postMessage-expected.txt: Added.
- crypto/subtle/hmac-postMessage.html: Added.
- crypto/subtle/postMessage-worker-expected.txt: Added.
- crypto/subtle/postMessage-worker.html: Added.
- crypto/subtle/rsa-postMessage-expected.txt: Added.
- crypto/subtle/rsa-postMessage.html: Added.
- crypto/subtle/resources/postMessage-worker.js: Added.
- 2:13 PM Changeset in webkit [160454] by
-
- 9 edits in trunk/Source/JavaScriptCore
<https://webkit.org/b/125141> Modernize the JavaScriptCore API headers
<rdar://problem/15540121>
This consists of three main changes:
1) Converting the return type of initializer methods to instancetype.
2) Declaring properties rather than getters and setters.
3) Tagging C API methods with information about their memory management semantics.
Changing the declarations from getters and setters to properties also required
updating the headerdoc in a number of places.
Reviewed by Anders Carlsson.
- API/JSContext.h:
- API/JSContext.mm:
- API/JSManagedValue.h:
- API/JSManagedValue.mm:
- API/JSStringRefCF.h:
- API/JSValue.h:
- API/JSVirtualMachine.h:
- API/JSVirtualMachine.mm:
- 2:06 PM Changeset in webkit [160453] by
-
- 2 edits in trunk/Source/WTF
Give Unique StringImpls a meaningful data pointer
https://bugs.webkit.org/show_bug.cgi?id=125598
Reviewed by Michael Saboff.
Found by code inspection. If there is a collision in an Identifier
table when comparing to a string literal we attempt to use the data
pointer (essentially this ends up being a null termination check).
Previously unique pointers just used the literal 1 as the data address
but this obviously fails when dereferenced. Instead we now make the
data pointer point to the location of the buffer pointer itself. As
the buffer pointer is initialised to 0, this satisfies the requirement
that the 0-length unique string is null terminated.
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
- 2:06 PM Changeset in webkit [160452] by
-
- 6 edits in trunk/Source/JavaScriptCore
<https://webkit.org/b/125559> Move JavaScriptCore off the legacy WebKit availability macros
The legacy WebKit availability macros are verbose, confusing, and provide no benefit over
using the system availability macros directly. The original vision was that they'd serve
a cross-platform purpose but that never came to be.
Map from WebKit version to OS X version based on the mapping in WebKitAvailability.h.
All iOS versions are specified as 7.0 as that is when the JavaScriptCore C API was made
public.
Part of <rdar://problem/15512304>.
Reviewed by Anders Carlsson.
- API/JSBasePrivate.h:
- API/JSContextRef.h:
- API/JSContextRefPrivate.h:
- API/JSObjectRef.h:
- API/JSValueRef.h:
- 1:33 PM Changeset in webkit [160451] by
-
- 14 edits2 adds in trunk
Web Inspector: [CSS Shapes] Highlight margin-shape for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=125175
Reviewed by Darin Adler.
Source/WebCore:
In addition to highlighting the shape, also highlight the shape created
by shape-margin with a slightly more transparent color. This patch modifies
the shape info passed to the Inspector Overlay to include a path for both
the raw shape and the shape with margin.
Test: inspector-protocol/model/highlight-shape-outside-margin.html
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForShapeOutside): Call Shape::buildDisplayPaths rather than
Shape::buildPath, and pass along any relevant paths to the Inspector overlay.
- inspector/InspectorOverlayPage.js:
(_drawShapeHighlight): Draw the margin shape in addition to the raw shape.
- rendering/shapes/BoxShape.cpp:
(WebCore::addRoundedRect): Add a rounded rect to the path.
(WebCore::BoxShape::buildDisplayPaths): Create the applicable [margin/padding/raw] shapes.
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::addPolygon): Add a set of vertices as a polygon to the path.
(WebCore::PolygonShape::buildDisplayPaths): Create the applicable [margin/padding/raw] shapes.
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.h:
(WebCore::RasterShape::buildDisplayPaths): Ditto.
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::buildDisplayPaths): Ditto.
- rendering/shapes/RectangleShape.h:
- rendering/shapes/Shape.h:
LayoutTests:
Test that the shape and margin-shape are properly passed to the Inspector Overlay.
Arcs for rounded rectangles, circles, and ellipses are approximated using the same
bezier curve method present in Path.cpp.
- inspector-protocol/model/highlight-shape-outside-margin.html: Added.
- inspector-protocol/model/highlight-shape-outside.html: Updating shape-outside info model.
- inspector-protocol/resources/shape-info-helper.js: Adding utilities to compare alternate path formats.
- 12:18 PM WebKitGTK/Debugging edited by
- Fix typo (diff)
- 12:16 PM WebKitGTK/Debugging edited by
- How to debug the web and network processes in WebKitGTK+ (diff)
- 11:49 AM Changeset in webkit [160450] by
-
- 9 edits in trunk
[ATK] Expose accessibility objects WAI-ARIA landmark roles
https://bugs.webkit.org/show_bug.cgi?id=125584
Reviewed by Chris Fleizach.
Source/WebCore:
Exposed accessibility objects with landmark roles with the proper
AtkRole, to be provided by the next stable release of ATK.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(atkRole):
Tools:
Add mappings to DRT & WKTR for landmark roles.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::role):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::role):
- gtk/jhbuild.modules:
LayoutTests:
Update test to unskip landmark elements and update expectations.
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
- 11:18 AM Changeset in webkit [160449] by
-
- 9 edits2 deletes in trunk/Source/WebKit2
Remove platform specific gunk from WebURLRequest and WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=125589
Reviewed by Andreas Kling.
- Shared/API/c/WKURLRequest.cpp:
(WKURLRequestCopyURL):
- Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCopyNSURLRequest):
- Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCopyNSURLResponse):
- Shared/WebURLRequest.cpp:
- Shared/WebURLRequest.h:
- Shared/WebURLResponse.h:
- Shared/mac/WebURLRequestMac.mm: Removed.
- Shared/mac/WebURLResponseMac.mm: Removed.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage):
- WebKit2.xcodeproj/project.pbxproj:
- 11:03 AM Changeset in webkit [160448] by
-
- 2 edits in trunk/Tools
[GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
https://bugs.webkit.org/show_bug.cgi?id=125441
Patch by Alejandro G. Castro <alex@igalia.com> on 2013-12-11
Reviewed by Martin Robinson.
Just avoid the double quotations when building the parameter
because some versions of valgrind are not handling it correctly.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- 10:58 AM Changeset in webkit [160447] by
-
- 1 edit2 adds in trunk/LayoutTests
[ATK] Add new layout test to check ATK roles in a central place
https://bugs.webkit.org/show_bug.cgi?id=125525
Reviewed by Chris Fleizach.
New test added, with some skipped tests already present in
platform/mac/accessibility/role-subrole-roledescription.html (this
test is based in that one) as well as some issues specific to ATK
that have been reported in bugs, for traceability.
- platform/gtk/accessibility/roles-exposed-expected.txt: Added.
- platform/gtk/accessibility/roles-exposed.html: Added.
- 10:25 AM Changeset in webkit [160446] by
-
- 4 edits in trunk
[GTK] Enable Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=125453
Reviewed by Martin Robinson.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
LayoutTests:
- platform/gtk/TestExpectations: Remove expectations for the Battery Status API layout tests
since all the tests pass now that the feature is enabled.
- 10:23 AM Changeset in webkit [160445] by
-
- 5 edits2 adds in trunk
[GTK][WK2] Add the WebKitBatteryProvider class
https://bugs.webkit.org/show_bug.cgi?id=115720
Reviewed by Martin Robinson.
Source/WebKit2:
This patch adds the WebKitBatteryProvider class which sets up a BatteryProviderUPower instance,
controlling the provider's activity when instrumented to do so by the WebBatteryManagerProxy
and relaying the battery status updates from the battery provider to the battery manager.
- GNUmakefile.list.am: Add the build targets for the new source files.
- UIProcess/API/gtk/WebKitBatteryProvider.cpp: Added.
(toBatteryProvider): A helper inline method that casts the client info to the battery provider instance.
(startUpdatingCallback): Relays the instruction to the WebKitBattery instance.
(stopUpdatingCallback): Ditto.
(WebKitBatteryProvider::create):
(WebKitBatteryProvider::WebKitBatteryProvider): Set up a WKBatteryProvider and set it to the passed-in battery manager.
(WebKitBatteryProvider::~WebKitBatteryProvider): Force the BatteryProviderUPower to stop updating.
(WebKitBatteryProvider::startUpdating): Relays the instruction to the BatteryProviderUPower instance.
(WebKitBatteryProvider::stopUpdating): Ditto.
(WebKitBatteryProvider::notifyBatteryStatusUnavailable): Update the battery manager with the new status that
has the default values that are to be used when the implementation cannot determine the battery status (as per
the Battery Status API specification).
(WebKitBatteryProvider::notifyBatteryStatusUpdated): Update the battery status.
- UIProcess/API/gtk/WebKitBatteryProvider.h: Added.
(WebKitBatteryProvider): Define the WebKitBatteryProvider reference-counted interface that also inherits from the
BatteryProviderUPowerClient interface.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a WebKitBatteryProvider member variable to the struct.
(createDefaultWebContext): Create a new battery provider when initializing the default web context.
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
- 10:16 AM Changeset in webkit [160444] by
-
- 8 edits4 adds in trunk/Source
[GTK] Add a UPower-based BatteryProvider
https://bugs.webkit.org/show_bug.cgi?id=115719
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Add the Source/WebCore/platform/glib directory to the list of directories searched
for header inclusion. Add the upower-glib dependency CFLAGS to the list of libPlatform's CPPFLAGS.
Source/WebCore:
Introduce the BatteryProviderUPower, a provider of the system's battery status that produces the information
using the upower-glib library.
The BatteryProviderUPower creates a new UPower client when the provider should start emitting updates and hooks
up to device alteration signals. These only fire recalculation of the battery status when a battery device is altered.
When recalculating, every battery device is taken into account, accumulating the energy capacities when both empty
and full, the current rate of energy charging/discharging, and the battery status (whether the device is charging or
discharging). This gives a set of data that covers the overall battery status of the system.
This data is then used to calculate the battery status as perceived by the WebCore implementation. Charging is determined
by examining the integral sign of the current combined energy rate. Charging and discharging times are calculated, when
appropriate, by dividing the chargable/dischargable capacity with the current combined energy rate. The battery level is
calculated by dividing the current energy capacity with the full energy capacity (i.e. the combined capacity of all
the batteries that the system possesses). The status is (indirectly) passed onto BatteryManager by invoking the
updateBatteryStatus method on the client, with the first parameter representing the battery charging/discharging state,
the second parameter representing the time left until the battery is fully charged (when charging) or fully
depleted (when discharging), and the third parameter representing the current battery level.
Whenever the implementation cannot provide any information about the battery status of the system, the client's
updateBatteryStatus method is invoked with the first parameter reporting the unavailability of any information
about the battery status. The other two parameters can be omitted as they default to 0 when not given and are neither
available nor useful in such circumstances. The client should handle such an update by reporting the 'default' battery
status - charging, the battery level being at 1.0 and both the charging and discharging time having the value of
the positive infinity (as per the Battery Status API specification).
The implementation is heavily inspired by a similar approach to calculating battery status in GNOME Settings Daemon.
No new tests - no new functionality. The feature is not yet enabled. When enabled, the relevant tests pass.
- GNUmakefile.list.am: Add the BatteryProviderUPower(Client) build targets.
- platform/glib/BatteryProviderUPower.cpp: Added.
(powerDeviceAlterationCallback):
(BatteryProviderUPower::BatteryProviderUPower):
(BatteryProviderUPower::startUpdating):
(BatteryProviderUPower::stopUpdating):
(BatteryProviderUPower::updateBatteryStatus):
- platform/glib/BatteryProviderUPower.h: Added.
(WebCore):
(BatteryProviderUPower):
- platform/glib/BatteryProviderUPowerClient.h: Added.
(WebCore):
(BatteryProviderUPowerClient):
Source/WebKit/gtk:
- GNUmakefile.am: Link the libwebkigtk library against the upower-glib library.
Source/WebKit2:
- GNUmakefile.am: Link the libwebkit2gtk library against the upower-glib library.
- 10:05 AM Changeset in webkit [160443] by
-
- 1 edit in branches/safari-537.74-branch/Tools/Scripts/webkitdirs.pm
Merge 157303: <rdar://problem/15498872>.
- 10:01 AM Changeset in webkit [160442] by
-
- 2 edits in branches/safari-537.74-branch/Source/JavaScriptCore
Merge 156934: <rdar://problem/15498872>.
- 9:53 AM Changeset in webkit [160441] by
-
- 4 edits in trunk
Arithmetic overflow when computing max-height CSS property with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=119273
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-12-11
Reviewed by Martin Robinson.
Enabled SATURATED_LAYOUT_ARITHMETIC for the gtk+ port.
.:
- Source/autotools/SetupWebKitFeatures.m4:
LayoutTests:
- platform/gtk/TestExpectations: Removed failure expectation for autoheight-correct-region-for-lines-2.html
- 9:53 AM Changeset in webkit [160440] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merge 154368: <rdar://problem/15498872>.
- 9:49 AM Changeset in webkit [160439] by
-
- 4 edits1 delete in trunk/Tools
<https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
to build and maintain this custom Perl module.
Reviewed by Anders Carlsson.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
- DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
- DumpRenderTree/mac/PerlSupport/Makefile: Removed.
- Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
build DumpRenderTree.
(dumpToolDidCrash): Stop importing and using the module.
- Scripts/webkitpy/port/base.py:
(Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
- 9:47 AM Changeset in webkit [160438] by
-
- 2 edits in trunk/Source/WebKit
<https://webkit.org/b/125562> Remove a Leopard-specific check from WebKit.xcodeproj
Reviewed by Anders Carlsson.
- WebKit.xcodeproj/project.pbxproj:
- 8:46 AM Changeset in webkit [160437] by
-
- 3 edits2 adds in trunk/Source/WebKit/gtk
[GTK][WK1] Add an empty BatteryClientGtk
https://bugs.webkit.org/show_bug.cgi?id=115628
Reviewed by Martin Robinson.
Add an empty BatteryClientGtk, implementing the WebCore's BatteryClient interface.
The implementation is left empty intentionally as the WebKit1 port is now in maintenance
mode and there's no desire to support new features under it. It's still required as the
WebCore implementation of the Battery Status API expects an existing BatteryClient, even
if the latter does not set up a provider that would then serve information about the battery
state.
- GNUmakefile.am: Add the BatteryClientGtk source files to the build.
- WebCoreSupport/BatteryClientGtk.cpp: Added.
(WebKit):
(WebKit::BatteryClientGtk::BatteryClientGtk):
(WebKit::BatteryClientGtk::startUpdating):
(WebKit::BatteryClientGtk::stopUpdating):
(WebKit::BatteryClientGtk::batteryControllerDestroyed):
- WebCoreSupport/BatteryClientGtk.h: Added.
(WebKit):
(BatteryClientGtk):
- webkit/webkitwebview.cpp:
(webkit_web_view_init): Set up the BatteryClientGtk for the new WebCore::Page object.
- 8:43 AM Changeset in webkit [160436] by
-
- 7 edits in trunk
Improving createOffer and createAnswer LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=125568
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-11
Reviewed by Philippe Normand.
The constraints parameter should be optional in both. Also adding tests to check if we already have a local SDP
when creating an answer.
Source/WebCore:
Existing tests were updated.
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createOffer):
LayoutTests:
- fast/mediastream/RTCPeerConnection-createAnswer-expected.txt:
- fast/mediastream/RTCPeerConnection-createAnswer.html:
- fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- 8:40 AM Changeset in webkit [160435] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Support right-side attachment of the inspector
https://bugs.webkit.org/show_bug.cgi?id=124126
Reviewed by Carlos Garcia Campos.
- UIProcess/API/C/gtk/WKInspectorClientGtk.h: add changed attached width callback.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseAddWebInspector): take attachment side parameter into account when adding the
inspector view.
(webkitWebViewBaseContainerRemove): renamed inspectorViewHeight to inspectorViewSize.
(resizeWebKitWebViewBaseFromAllocation): take attachment side into account when allocating the
sizes for the inspector view and the inspected view.
(webkitWebViewBaseSetInspectorViewSize): renamed from webkitWebViewBaseSetInspectorViewHeight.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/gtk/WebInspectorClientGtk.cpp:
(WebKit::WebInspectorClientGtk::didChangeAttachedWidth): notify client that view width has changed.
- UIProcess/gtk/WebInspectorClientGtk.h:
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformAttach): use attachment side for setting the default size
for the inspector view.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): use the new generic SetInspectorViewSize.
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth): allow setting the inspector view width.
- 8:28 AM Changeset in webkit [160434] by
-
- 13 edits in trunk
[GTK] Add "enable-mediasource" property to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=125566
Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-11
Reviewed by Philippe Normand.
Source/WebKit/gtk:
- tests/testwebsettings.c:
(test_webkit_web_settings_copy):
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Source/WebKit2:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_mediasource):
(webkit_settings_set_enable_mediasource):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
- 8:16 AM Changeset in webkit [160433] by
-
- 2 edits in trunk/Tools
[Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
https://bugs.webkit.org/show_bug.cgi?id=125579
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
activeURL property changes, update the URL field with its value.
(-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
(-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
(-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
Ditto.
(-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
(-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
- 8:10 AM Changeset in webkit [160432] by
-
- 8 edits in trunk/Source
Source/WebCore: [EFL] Fix build with CONTEXT_MENUS flag set OFF
https://bugs.webkit.org/show_bug.cgi?id=125572
Reviewed by Gyuyoung Kim.
dispatchEventAsContextMenuEvent is called regardless of CONTEXT_MENUS flag setting,
thus its definition in InspectorFrontendHost should not be guarded by this flag.
No new tests, no behaviour change.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Source/WebKit2: [EFL] Fix build with CONTEXT_MENUS flag set OFF
https:///bugs.webkit.org/show_bug.cgi?id=125572
Reviewed by Gyuyoung Kim.
Fix EFL build by adding necessary guard, also UNUSED_PARAM macros where added.
- Shared/API/c/WKContextMenuItem.cpp: Added UNUSED_PARAM macros.
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
- UIProcess/API/C/WKPage.cpp: Ditto.
(WKPageSetPageContextMenuClient):
(WKPageSelectContextMenuItem):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Ditto.
(WKBundlePageSetContextMenuClient):
(WKBundlePageClickMenuItem):
(WKBundlePageCopyContextMenuItems):
(WKBundlePageCopyContextMenuAtPointInWindow)
- UIProcess/efl/WebViewEfl.cpp: Guard createContextMenuProxy method.
- UIProcess/efl/WebViewEfl.h: Ditto.
- 7:42 AM Changeset in webkit [160431] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing ref-tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:34 AM Changeset in webkit [160430] by
-
- 2 edits in trunk/Source/WebCore
[CURL] Build fails after r160386.
https://bugs.webkit.org/show_bug.cgi?id=125571
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-11
Reviewed by Zoltan Herczeg.
Need no new tests.
Fix a typo in commit r160386 that prevents building with curl.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::generateBaseFilename):
- 5:38 AM Changeset in webkit [160429] by
-
- 6 edits in trunk
[CSS Shapes] Take into account fill-rule for polygon interpolation
https://bugs.webkit.org/show_bug.cgi?id=125508
Reviewed by Dirk Schulze.
Source/WebCore:
Implement the polygon fill-rule part of http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation.
Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html.
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
LayoutTests:
Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html so it also tests polygon animation
when using different fill rules.
- animations/resources/animation-test-helpers.js:
(parseBasicShape): also allow evenodd when parsing the polygon
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
- fast/shapes/shape-outside-floats/shape-outside-animation.html:
- 4:42 AM Changeset in webkit [160428] by
-
- 3 edits in branches/safari-537.74-branch/Source/WebKit2
Merged r160197. <rdar://problem/15614679>
- 4:29 AM Changeset in webkit [160427] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebKit/win
Merged r160184. <rdar://problem/15611608>
- 4:26 AM Changeset in webkit [160426] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebKit
Merged r160118. <rdar://problem/15566844>
- 4:22 AM Changeset in webkit [160425] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebKit
Merged r160017. <rdar://problem/15566844>
- 4:14 AM Changeset in webkit [160424] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebCore
Merged r159691. <rdar://problem/15560410>
- 4:12 AM Changeset in webkit [160423] by
-
- 14 edits2 copies in branches/safari-537.74-branch
Merged r159460. <rdar://problem/15517467>
- 4:00 AM Changeset in webkit [160422] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merged r159328. <rdar://problem/15560414>
- 3:58 AM Changeset in webkit [160421] by
-
- 5 edits in branches/safari-537.74-branch/Source/WebKit2
Merged r159173. <rdar://problem/15474120>
- 3:34 AM Changeset in webkit [160420] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebKit/mac
Merged r157279. <rdar://problem/15560450>
- 2:54 AM Changeset in webkit [160419] by
-
- 2 edits in trunk/Tools
Fixed test-wepkitpy logging for buildslaves
https://bugs.webkit.org/show_bug.cgi?id=125445
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-11
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunPythonTests):
- 2:51 AM Changeset in webkit [160418] by
-
- 3 edits in trunk/LayoutTests
Test results of postMessage-clone-port-error.html test are broken
https://bugs.webkit.org/show_bug.cgi?id=125487
Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-11
Reviewed by Alexey Proskuryakov.
Improved Layout test checks correctness of value thrown by postMessage:
- fast/dom/Window/postMessage-clone-port-error-expected.txt:
- fast/dom/Window/postMessage-clone-port-error.html:
- 2:28 AM Changeset in webkit [160417] by
-
- 13 edits2 adds in trunk
Programmatically-inserted children lack accessibility events
https://bugs.webkit.org/show_bug.cgi?id=100275
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/children-changed-sends-notification.html
Emit children-changed::add and children-changed::remove whenever
an object has been added/removed to the accessibility hierarchy,
that is, when a new AtkObject is being attached/detached.
- accessibility/AXObjectCache.h: Added new enumeration to know
when we are detaching a wrapper because of the cache or the
element is being destroyed, so we can use that information.
(WebCore::AXObjectCache::detachWrapper): Added a new parameter and
updated all the prototypes in different ports.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache): Call detachWrapper()
specifying that we do it because the cache is being destroyed.
(WebCore::AXObjectCache::remove): Call detachWrapper() specifying
that we do it because an accessible element is being destroyed.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Emit the children-changed
signal when needed. We rely on the cached reference to the parent
AtkObject (using the implementation of atk_object_get_parent from
the AtkObject class) to find the right object to emit the signal
from here, since the accessibility hierarchy from WebCore will no
longer be accessible at this point.
(WebCore::AXObjectCache::attachWrapper): Emit the children-change
signal from here unless we are in the middle of a layout update,
trying to provide as much information (e.g. the offset) as possible.
(WebCore::AXObjectCache::postPlatformNotification): Make sure we
update (touch) the subtree under an accessibility object whenever
we receive AXChildrenChanded from WebCore, to ensure that those
objects will also be visible rightaway to ATs, and that those get
properly notified of the event at that very same moment.
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::detachWrapper): Updated function signature.
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::detachWrapper): Ditto.
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::detachWrapper): Ditto.
Tools:
Update DRT and WebKitTestRunner to handle the children-changed
signal properly, considering the detail and optional parameters.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
(axObjectEventListener):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
LayoutTests:
Add new test to chack that children-changed signals are properly
emitted when adding/removing elements in the accessibility hierarchy.
- accessibility/children-changed-sends-notification-expected.txt: Added.
- accessibility/children-changed-sends-notification.html: Added.
Update test to filter out unrelated non-loading events.
- accessibility/loading-iframe-sends-notification.html: Updated.
Skip the test on the Mac as it does not expose these kind of
notifications when children are being added or removed.
- platform/mac/TestExpectations: Skip newly added test.
- 2:00 AM Changeset in webkit [160416] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Soup] Implement NetworkProcess::allowSpecificHTTPSCertificateForHost
https://bugs.webkit.org/show_bug.cgi?id=125557
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-12-11
Reviewed by Carlos Garcia Campos.
Do what WebProcess::allowSpecificHTTPSCertificateForHost does.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- 1:45 AM Changeset in webkit [160415] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r160389): SVG test assertion extravaganza.
Unreviewed. Use getAttribute() instead of fastGetAttribute() for
the "type" attribute since it's animatable on SVG elements.
- 1:27 AM Changeset in webkit [160414] by
-
- 26 edits in trunk
<https://webkit.org/b/125139> Modernize the WebKit API headers
<rdar://problem/15540175>
Source/WebKit/mac:
This consists of three main changes:
1) Converting the return type of initializer methods to instancetype.
2) Declaring properties rather than getters and setters.
3) Declaring explicitly sized enums.
Changing the declarations from getters and setters to properties also required
updating the headerdoc in a number of places.
Reviewed by Anders Carlsson.
- DOM/WebDOMOperations.h:
- History/WebBackForwardList.h:
- History/WebHistory.h:
- History/WebHistoryItem.h:
- History/WebHistoryItem.mm:
- Plugins/WebPlugin.h:
- Plugins/WebPluginContainer.h:
- WebView/WebArchive.h:
- WebView/WebArchive.mm:
- WebView/WebDataSource.h:
- WebView/WebDataSource.mm:
- WebView/WebEditingDelegate.h:
- WebView/WebFrame.h:
- WebView/WebFrame.mm:
- WebView/WebFrameView.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm:
(-[WebPreferences cacheModel]): Cast to the enum.
- WebView/WebResource.h:
- WebView/WebResource.mm:
- WebView/WebUIDelegate.h:
- WebView/WebView.h:
- WebView/WebView.mm:
(+[WebView _didSetCacheModel]): Fix the return type.
Tools:
Reviewed by Anders Carlsson.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setCacheModel): Cast to the enum type.
- 12:31 AM Changeset in webkit [160413] by
-
- 3 edits in trunk/Source/WebCore
Set m_nextBreakablePosition as private in InlineIterator, and use it.
https://bugs.webkit.org/show_bug.cgi?id=125482
Reviewed by Andreas Kling.
InlineIterator has been exported m_nextBreakablePosition as public though it is member variable.
This patch set it as private, and add getter/setter functions for it.
No new tests, no behavior changes.
- rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::nextBreakablePosition):
(WebCore::InlineIterator::setNextBreakablePosition):
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText):
