Timeline



Jun 16, 2014:

10:45 PM Changeset in webkit [170047] by mihnea@adobe.com
  • 5 edits
    76 moves
    1 add in trunk/LayoutTests

[CSS Regions] Move the overflow tests to a separate folder
​https://bugs.webkit.org/show_bug.cgi?id=130089

Reviewed by Andrei Bucur.

Move the overflow tests inside fast/regions/overflow folder.
Adjust tests paths and TestExpectations files accordingly.

  • fast/regions/overflow/overflow-3dtransformed-region-expected.txt: Renamed from LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt.
  • fast/regions/overflow/overflow-3dtransformed-region.html: Renamed from LayoutTests/fast/regions/overflow-3dtransformed-region.html.
  • fast/regions/overflow/overflow-auto-after-float-expected.html: Renamed from LayoutTests/fast/regions/overflow-auto-after-float-expected.html.
  • fast/regions/overflow/overflow-auto-after-float.html: Renamed from LayoutTests/fast/regions/overflow-auto-after-float.html.
  • fast/regions/overflow/overflow-content-transform-rotate-expected.html: Renamed from LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html.
  • fast/regions/overflow/overflow-content-transform-rotate.html: Renamed from LayoutTests/fast/regions/overflow-content-transform-rotate.html.
  • fast/regions/overflow/overflow-content-zero-height-region-expected.html: Renamed from LayoutTests/fast/regions/overflow-content-zero-height-region-expected.html.
  • fast/regions/overflow/overflow-content-zero-height-region.html: Renamed from LayoutTests/fast/regions/overflow-content-zero-height-region.html.
  • fast/regions/overflow/overflow-first-and-last-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-expected.html.
  • fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden-expected.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html.
  • fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-in-container-hidden.html.
  • fast/regions/overflow/overflow-first-and-last-regions.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions.html.
  • fast/regions/overflow/overflow-in-uniform-regions-dynamic-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-dynamic-expected.html.
  • fast/regions/overflow/overflow-in-uniform-regions-dynamic.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-dynamic.html.
  • fast/regions/overflow/overflow-in-uniform-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-expected.html.
  • fast/regions/overflow/overflow-in-uniform-regions.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-bt-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-bt-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-bt.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-continuation-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-continuation.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-lr-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-lr-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-lr.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-lr.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-rl-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-rl-expected.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-rl.html.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline.html.
  • fast/regions/overflow/overflow-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions.html.
  • fast/regions/overflow/overflow-last-region-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-horiz-bt-expected.html.
  • fast/regions/overflow/overflow-last-region-horiz-bt.html: Renamed from LayoutTests/fast/regions/overflow-last-region-horiz-bt.html.
  • fast/regions/overflow/overflow-last-region-vert-lr-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-lr-expected.html.
  • fast/regions/overflow/overflow-last-region-vert-lr.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-lr.html.
  • fast/regions/overflow/overflow-last-region-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-rl-expected.html.
  • fast/regions/overflow/overflow-last-region-vert-rl.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-rl.html.
  • fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.html.
  • fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-moving-below-floats-in-variable-width-regions.html.
  • fast/regions/overflow/overflow-nested-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-nested-regions-expected.html.
  • fast/regions/overflow/overflow-nested-regions.html: Renamed from LayoutTests/fast/regions/overflow-nested-regions.html.
  • fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.html.
  • fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html.
  • fast/regions/overflow/overflow-region-float-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-float-expected.html.
  • fast/regions/overflow/overflow-region-float.html: Renamed from LayoutTests/fast/regions/overflow-region-float.html.
  • fast/regions/overflow/overflow-region-inline-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-inline-expected.html.
  • fast/regions/overflow/overflow-region-inline.html: Renamed from LayoutTests/fast/regions/overflow-region-inline.html.
  • fast/regions/overflow/overflow-region-transform-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-transform-expected.html.
  • fast/regions/overflow/overflow-region-transform.html: Renamed from LayoutTests/fast/regions/overflow-region-transform.html.
  • fast/regions/overflow/overflow-rtl-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-rtl-in-variable-width-regions-expected.html.
  • fast/regions/overflow/overflow-rtl-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-rtl-in-variable-width-regions.html.
  • fast/regions/overflow/overflow-scrollable-1-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-1-expected.html.
  • fast/regions/overflow/overflow-scrollable-1.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-1.html.
  • fast/regions/overflow/overflow-scrollable-2-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-2-expected.html.
  • fast/regions/overflow/overflow-scrollable-2.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-2.html.
  • fast/regions/overflow/overflow-scrollable-3-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-3-expected.html.
  • fast/regions/overflow/overflow-scrollable-3.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-3.html.
  • fast/regions/overflow/overflow-scrollable-fit-complex-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-complex-expected.html.
  • fast/regions/overflow/overflow-scrollable-fit-complex.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-complex.html.
  • fast/regions/overflow/overflow-scrollable-fit-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-expected.html.
  • fast/regions/overflow/overflow-scrollable-fit.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit.html.
  • fast/regions/overflow/overflow-scrollable-nested-expected.txt: Renamed from LayoutTests/fast/regions/overflow-scrollable-nested-expected.txt.
  • fast/regions/overflow/overflow-scrollable-nested.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-nested.html.
  • fast/regions/overflow/overflow-scrollable-rel-pos-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html.
  • fast/regions/overflow/overflow-scrollable-rel-pos-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html.
  • fast/regions/overflow/overflow-scrollable-rotated-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html.
  • fast/regions/overflow/overflow-scrollable-rotated-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html.
  • fast/regions/overflow/overflow-scrollable-unsplittable-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html.
  • fast/regions/overflow/overflow-scrollable-unsplittable-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html.
  • fast/regions/overflow/overflow-scrollable-varying-width-1-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-1-expected.html.
  • fast/regions/overflow/overflow-scrollable-varying-width-1.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-1.html.
  • fast/regions/overflow/overflow-scrollable-varying-width-2-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-2-expected.html.
  • fast/regions/overflow/overflow-scrollable-varying-width-2.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-2.html.
  • fast/regions/overflow/overflow-size-change-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-in-variable-width-regions-expected.html.
  • fast/regions/overflow/overflow-size-change-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-size-change-in-variable-width-regions.html.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-expected.html.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-rtl-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl.html.
  • fast/regions/overflow/overflow-size-change-with-stacking-context.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context.html.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
10:39 PM Changeset in webkit [170046] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix when MHTML is enabled after r170041

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetContentsAsMHTMLData):

10:35 PM Changeset in webkit [170045] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Region with border radius and overflow:hidden does not clip content
​https://bugs.webkit.org/show_bug.cgi?id=133476

Reviewed by Andrei Bucur.

Source/WebCore:
When setting the clip before painting the named flow content,
use the region's foreground rect to take the region's border radius
into account if needed.

Test: fast/regions/region-border-radius-overflow-clip.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):

LayoutTests:

  • fast/regions/region-border-radius-overflow-clip-expected.html: Added.
  • fast/regions/region-border-radius-overflow-clip.html: Added.
9:59 PM Changeset in webkit [170044] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Extract prototype declaration generation into a helper function
​https://bugs.webkit.org/show_bug.cgi?id=133969

Reviewed by Dan Bernstein.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePrototypeDeclaration):

9:43 PM Changeset in webkit [170043] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL][WK2] Remove workaround for icon display bug in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=133962

Reviewed by Gyuyoung Kim.

Since we bumped EFL to 1.9, this workaround is unnecessary.

  • MiniBrowser/efl/main.c:

(update_view_favicon):

8:55 PM Changeset in webkit [170042] by weinig@apple.com
  • 46 edits in trunk/Source

Move forward declaration of bindings static functions into their implementation files
​https://bugs.webkit.org/show_bug.cgi?id=133943

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Add a few identifiers that are needed by the DOM.

Source/WebCore:

  • Moves the forward declaration of static functions for generated files to the implementation.
  • Adds a new extended attribute, ForwardDeclareInHeader, for functions that still need a forward declaration in the header.
  • bindings/js/JSDOMBinding.h:

(WebCore::nonCachingStaticFunctionGetter):
Move this helper here from JSDOMWindowCustom.cpp.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers.

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::putDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
Move forward declaration creation to the implementation file where possible.

  • bindings/scripts/IDLAttributes.txt:

Add ForwardDeclareInHeader.

  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:

Add ForwardDeclareInHeader where necessary.

8:52 PM Changeset in webkit [170041] by mitz@apple.com
  • 11 edits in trunk/Source/WebKit2

Part 2 of: Change GenericCallback<> function parameters into std::function<>
​https://bugs.webkit.org/show_bug.cgi?id=133927

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSelectionAsWebArchiveData):
(WKPageValidateCommand):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
(-[WKView startSpeaking:]):
(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::clearSiteData):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _define:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView requestDictationContext:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateSelectionWithTouches):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::applyAutocorrection):
(WebKit::WebPageProxy::requestDictationContext):
(WebKit::WebPageProxy::requestAutocorrectionContext):

7:26 PM Changeset in webkit [170040] by yoon@igalia.com
  • 5 edits in trunk/Tools

[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=131472

Reviewed by Martin Robinson.

This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.

  • Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
when running WebKitTestRunner with the Xvfb driver.

  • gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
  • gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not

installed.

  • gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows

how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
deal.

7:17 PM Changeset in webkit [170039] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
​https://bugs.webkit.org/show_bug.cgi?id=133792

Patch by Tanay C <​tanay.c@samsung.com> on 2014-06-16
Reviewed by Gyuyoung Kim.

  • MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones

(show_file_entry_dialog):
(window_create):

6:23 PM Changeset in webkit [170038] by ljaehun.lim@samsung.com
  • 6 edits in trunk/Source

Unreviewed build fix after r170029

Use String() instead of AtomicString().

Source/WebCore:

  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageHeaders):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

Source/WebKit2:

  • UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHeaders):

4:56 PM Changeset in webkit [170037] by Brent Fulgham
  • 19 edits in trunk/Source

[Win] Use TileController on Windows
​https://bugs.webkit.org/show_bug.cgi?id=133895

Reviewed by Tim Horton.

../WebCore:

  • WebCore.vcxproj/WebCore.vcxproj: Add Tiled Drawing files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • platform/graphics/TiledBacking.h: No longer Cocoa-only.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Windows
now uses the same layer type as Mac.

  • platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::takeLayerWithSize): Use nullptr
rather than nil for C++ code.

  • platform/graphics/ca/PlatformCALayer.cpp:
  • platform/graphics/ca/PlatformCALayer.h: Expose necessary

drawing functions for Windows port.

  • platform/graphics/ca/TileController.cpp: Remove unneeded

header include for WebLayer.

  • platform/graphics/ca/TileCoverageMap.cpp: Correct #includes.
  • platform/graphics/ca/TileGrid.h: Not just for Cococa.
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: Remove

extra whitespace.

  • platform/graphics/ca/mac/PlatformCALayerMac.h: Remove

unneeded overload.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::collectRectsToPaint): Added stub.
(PlatformCALayer::drawLayerContents): Added.
(PlatformCALayer::frameForLayer): Added.
(PlatformCALayerWin::PlatformCALayerWin): Remove unneeded
assert now that we support these types. Add TileController
support.
(PlatformCALayerWin::setEdgeAntialiasingMask): Added.
(printLayer): Add newly-supported tile types.
(PlatformCALayerWin::tiledBacking): Added.

  • platform/graphics/ca/win/PlatformCALayerWin.h: Update to

support Tiled Drawing.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::PlatformCALayerWinInternal): Update to
recognize newly-supported layer types.
(PlatformCALayerWinInternal::setNeedsDisplay): Ditto.
(PlatformCALayerWinInternal::setSublayers): Ditto.
(PlatformCALayerWinInternal::getSublayers): Ditto.
(PlatformCALayerWinInternal::removeAllSublayers): Ditto.
(PlatformCALayerWinInternal::insertSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerCount): Ditto.
(PlatformCALayerWinInternal::indexOfSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerAtIndex): Ditto.
(PlatformCALayerWinInternal::setBounds): Ditto.
(PlatformCALayerWinInternal::setFrame): Ditto.
(PlatformCALayerWinInternal::drawTile): Ditto.
(PlatformCALayerWinInternal::createTileController): Ditto.
(PlatformCALayerWinInternal::tiledBacking): Ditto.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.h: Update to use

TileController.

../WebKit2:

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h: Remove

unneeded overload.

4:48 PM Changeset in webkit [170036] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS][wk2] Swipe snapshots are removed too quickly if there is no saved render tree size
​https://bugs.webkit.org/show_bug.cgi?id=133891

Reviewed by Simon Fraser.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
If we don't know the target render tree size, wait until the first layer tree commit
that comes in, instead of removing the snapshot when the gesture ends.

4:45 PM Changeset in webkit [170035] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebKit2

[iOS][wk2] Swiping back briefly shows the previous page before loading the new one
​https://bugs.webkit.org/show_bug.cgi?id=133885

Reviewed by Simon Fraser.

Remove a race between the UI and Web processes when removing the swipe snapshot.
Previously, it was possible to get a commit from the Web process with layer content
(and render tree size) from the previous page *after* sending the navigation request
to the page, because of the asynchronicity of layer tree commits. This could cause
the snapshot to be removed early (if the previous fully-loaded page had a sufficiently
large render tree size), revealing the old tiles underneath the snapshot.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::transactionID):
(WebKit::RemoteLayerTreeTransaction::setTransactionID):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::lastVisibleTransactionID):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Keep track of an ever-increasing transaction ID in RemoteLayerTreeDrawingArea(Proxy).
It increments in the UI process at didUpdate time, because the Web process cannot
have started on a new layer tree commit until didUpdate is sent.
It increments in the Web process at commit time.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):

  • UIProcess/mac/ViewGestureController.h:

Adopt transaction IDs; don't remove the snapshot until the commit
that includes the navigation arrives.

4:19 PM Changeset in webkit [170034] by mark.lam@apple.com
  • 9 edits in trunk

Parser statementDepth accounting needs to account for when a function body excludes its braces.
<​https://webkit.org/b/133832>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:
In some cases (e.g. when a Function object is instantiated from a string), the
function body source may not include its braces. The parser needs to account
for this when calculating its statementDepth.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):

  • bytecode/UnlinkedCodeBlock.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):

  • Also fixed the error message for declaring nested functions in strict mode to be more accurate.
  • parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse):

  • runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
    • Added cases for declaring functions in strict mode.
    • Added caught error to the test result logging if it's not a SyntaxError. This helps catch the issue in this bug which was erroneously throwing RangeErrors.
3:57 PM Changeset in webkit [170033] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary style invalidation in RenderTextControl::styleDidChange().
<​https://webkit.org/b/133949>

This explicit invalidation of the text control's inner text element
was hacked in to fix an editing test back in 2011, long before lazy
render tree construction.

It should be safe to remove, since doing so doesn't affect any tests.

Reviewed by Antti Koivisto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

3:57 PM Changeset in webkit [170032] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/17327707> [Cocoa] Expose WebPreferences::storageBlockingPolicy
​https://bugs.webkit.org/show_bug.cgi?id=133958

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(toStorageBlockingPolicy): Added this helper conversion function.
(toAPI): Ditto.
(-[WKPreferences _storageBlockingPolicy]): Added this getter.
(-[WKPreferences _setStorageBlockingPolicy:]): Added this setter.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h: Declared new _storageBlockingPolicy property

and _WKStorageBlockingPolicy enum.

3:46 PM Changeset in webkit [170031] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

3:42 PM Changeset in webkit [170030] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Accept-Ranges is not specific to GStreamer.

  • platform/network/HTTPHeaderNames.in:
3:28 PM Changeset in webkit [170029] by andersca@apple.com
  • 22 edits in trunk/Source

Don't use AtomicString in HTTPHeaderMap
​https://bugs.webkit.org/show_bug.cgi?id=133957
<rdar://problem/15256572>

Reviewed by Andreas Kling.

Source/WebCore:
Use the string data that comes from the generated HTTPHeaderNames.cpp file
for sharing header name data instead. In the future we can do something more fancy where
we'll hash the HTTPHeaderName enum directly, but this is good enough for now.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders):

  • WebCore.exp.in:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::parseHeader):

  • loader/cache/CachedResource.cpp:

(WebCore::shouldUpdateHeaderAfterRevalidation):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::internHTTPHeaderNameString):
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
(WebCore::CaseFoldingCStringTranslator::hash): Deleted.
(WebCore::CaseFoldingCStringTranslator::equal): Deleted.
(WebCore::CaseFoldingCStringTranslator::translate): Deleted.

  • platform/network/HTTPHeaderMap.h:
  • platform/network/HTTPHeaderNames.in:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • platform/network/HTTPParsers.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderField):

  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):

  • platform/network/ResourceResponseBase.h:
  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::platformLazyInit):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getRequestHeader):
(WebCore::XMLHttpRequest::getResponseHeader):

  • xml/XMLHttpRequest.h:

Source/WebKit2:
Update for WebCore changes.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<HTTPHeaderMap>::decode):

2:44 PM Changeset in webkit [170028] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: Safari crashed once in WebCore::AccessibilityObject::ariaIsHidden
​https://bugs.webkit.org/show_bug.cgi?id=133825

Reviewed by Enrica Casucci.

Sometimes asking accessibilityIsIgnored() will cause a newObject to be detached immediately after its created.
The creation function holds a reference with RefPtr as long as it lives, but when that method returns, the object goes away.

With that out of the way, I saw the same backtrace lead to updateLayoutIgnorePendingStylesheets being called while still inLayout.

I tried my best but could not create a reproducible layout test.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

2:22 PM Changeset in webkit [170027] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Add more GStreamer-specific header names that are required
after changes in r170021, fixing the build for ports using GStreamer.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived):

  • platform/network/HTTPHeaderNames.in:
2:01 PM Changeset in webkit [170026] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Crash at WebCore::AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=133873

Reviewed by Enrica Casucci.

This looks like a very similar problem to
​https://bugs.webkit.org/show_bug.cgi?id=133825

The object is being created and deallocated almost right away because calling accessibilityIsIgnored triggers
a deferred layout that invalidates the associated render element.

Despite my best efforts, I could not come up with a way to reproduce this in a layout test.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

1:33 PM Changeset in webkit [170025] by andersca@apple.com
  • 14 edits in trunk/Source

Change ResourceRequestBase::addHTTPHeaderFields to setHTTPHeaderFields instead
​https://bugs.webkit.org/show_bug.cgi?id=133925

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setHTTPHeaderFields):
(WebCore::ResourceRequestBase::addHTTPHeaderFields): Deleted.

  • platform/network/ResourceRequestBase.h:
  • plugins/PluginView.cpp:

(WebCore::PluginView::handlePost):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.h:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceRequest>::decode):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_PostURL):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

  • WebProcess/Plugins/PluginView.h:
12:52 PM Changeset in webkit [170024] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlock in RenderObject::enclosingBox().
​https://bugs.webkit.org/show_bug.cgi?id=133902

Patch by Jeongeun Kim <​je_julie.kim@samsung.com> on 2014-06-16
Reviewed by Andreas Kling.

Just a straightforward conversion from pointers to references.

No new tests, no behavior change.

  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMHTMLElement structuralComplexityContribution]):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRendererFragments):

  • page/EventHandler.cpp:

(WebCore::scrollNode):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computedRegionRangeForBox):
(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion):
(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingBox): Removed FIXME comment

  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::owningRenderer):

12:46 PM Changeset in webkit [170023] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Use HTTPHeaderName in more places
​https://bugs.webkit.org/show_bug.cgi?id=133948

Reviewed by Andreas Kling.

  • loader/cache/CachedRawResource.cpp:

(WebCore::shouldIgnoreHeaderForCacheReuse):

  • platform/network/HTTPHeaderNames.in:
  • xml/XMLHttpRequest.cpp:

(WebCore::isSetCookieHeader):
(WebCore::isForbiddenRequestHeader):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Deleted.
(WebCore::staticData): Deleted.

12:27 PM Changeset in webkit [170022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Change the order of the alias analysis passes to align with the opt pipeline of LLVM
​https://bugs.webkit.org/show_bug.cgi?id=133753

Patch by Juergen Ributzka <​juergen@apple.com> on 2014-06-16
Reviewed by Geoffrey Garen.

The order in which the alias analysis passes are added affects also the
order in which they are utilized. Change the order to align with the
one use by LLVM itself. The last alias analysis pass added will be
evaluated first. With this change we first perform a basic alias
analysis and then use the type-based alias analysis (if required).

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

12:26 PM Changeset in webkit [170021] by andersca@apple.com
  • 19 edits in trunk/Source

Add HTTPHeaderName overloads on ResourceResponseBase
​https://bugs.webkit.org/show_bug.cgi?id=133946

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::lastModified):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::parse):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::didBeginDocument):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::canUseSheet):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeType):

  • platform/network/HTTPHeaderNames.in:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):

  • platform/network/ResourceResponseBase.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
(WebCore::XMLHttpRequest::responseMIMEType):
(WebCore::XMLHttpRequest::didReceiveResponse):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):

12:26 PM Changeset in webkit [170020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the arguments passed to the LLVM dylib
​https://bugs.webkit.org/show_bug.cgi?id=133757

Patch by Juergen Ributzka <​juergen@apple.com> on 2014-06-16
Reviewed by Geoffrey Garen.

The LLVM command line argument parser assumes that the first argument
is the program name. We need to add a fake program name, otherwise the
first argument will be parsed as program name and ignored.

  • llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

12:04 PM Changeset in webkit [170019] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a typo in the last change.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):

12:00 PM Changeset in webkit [170018] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Remove WKPreferences persistence in user defaults
​https://bugs.webkit.org/show_bug.cgi?id=133945

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and

initializer with userDefaultsKeyPrefix parameter.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
means that it won’t persist to user defaults.
(-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
(-[WKPreferences userDefaultsKeyPrefix]): Deleted.

11:20 AM Changeset in webkit [170017] by fpizlo@apple.com
  • 4 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Remove the DFG optimization fixpoint and remove some obvious reasons why we previously benefited from it
​https://bugs.webkit.org/show_bug.cgi?id=133931

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Trigger constant-folding for GetMyArgumentByVal (which means turning it into GetLocalUnlinked) and correct the handling of Upsilon so we don't fold them away.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): Implement constant-folding for GetMyArgumentByVal.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl): Remove the fixpoint.

11:03 AM Changeset in webkit [170016] by fpizlo@apple.com
  • 11 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] DFG OSR entry should have a crystal-clear story for when it's safe to enter at a block with a set of values
​https://bugs.webkit.org/show_bug.cgi?id=133935

Reviewed by Oliver Hunt.

  • bytecode/Operands.h:

(JSC::Operands::Operands):
(JSC::Operands::ensureLocals):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::filter): Now we can compute intersections of abstract values!

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::makeFullTop): Completeness.
(JSC::DFG::AbstractValue::bytecodeTop): Completeness.
(JSC::DFG::AbstractValue::fullTop): Completeness. We end up using this one.

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):

  • dfg/DFGBasicBlock.h: Remember the intersection of all things ever proven.
  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run): Compute the intersection.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): No need for the weirdo merge check since this fixes the root of the problem.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpBlockHeader): Better dumping.
(JSC::DFG::Graph::dump): Better dumping.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry): Use the intersected abstract value.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock): Assert if the intersected state indicates the block shouldn't execute.

10:41 AM Changeset in webkit [170015] by tonikitoo@webkit.org
  • 6 edits in trunk/Source/WebCore

"nullable" sequence support is incomplete (i.e. sequence<NativeType>?) ​https://bugs.webkit.org/show_bug.cgi?id=131240

eeviewed by Darin Adler.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

Nullable sequences are not fully supported in WebKit's
code generator machinery. Although the generated code
does add "is nullable" check to the evaluation condition

(i.e. if (arg.isNull()
...)), when the JSValue

that holds a "null" JSObject is actually to be "converted"
to a native Vector<T>, it fails.

The reason for the failure is in JSDOMBindings::toNativeArray.
This method verifies that JSValue does not hold a "non-null"
object, and it bails out.
Analogly, the "ref ptr" variant of this method (toRefPtrNativeArray)
does support nullables.

Patch fixes it be checking for a "null" JSValue check before hand.

Tests: Binding tests updated.

  • bindings/js/JSDOMBinding.h:

(WebCore::toNativeArray):

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • Modules/websocket/WebSocket.idl:

Removed one overload ctor now that
we can use nullable sequences.

10:23 AM Changeset in webkit [170014] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

[MSE][Mac] Occasional image corruption after seeking
​https://bugs.webkit.org/show_bug.cgi?id=133879

Reviewed by Eric Carlson.

Change the order of operations for seeks: change the current time of the AVSampleBufferRenderSynchronizer
before flushing and appending non-displaying samples.

Rather than having a single function which retrieves the fast seek time and then seeks, split this out
into two functions: one which gets the fast seek time, and one which seeks. (The later of course already
exists: seekToTime()).

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::fastSeekTimeForMediaTime): Renamed from seekToTime()
(WebCore::MediaSourcePrivateAVFObjC::seekToTime): Deleted.

9:45 AM Changeset in webkit [170013] by zandobersek@gmail.com
  • 27 edits in trunk/Source/WebCore

Have ScriptExecutionContext::Task functions take in a ScriptExecutionContext reference
​https://bugs.webkit.org/show_bug.cgi?id=133795

Reviewed by Andreas Kling.

The pointer to the ScriptExecutionContext object that is passed to the C++11 lambdas or
helper functions wrapped in ScriptExecutionContext::Task is never null, so that parameter
should be a reference instead.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::~Database):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionCallback):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): Dereference the
member variable that holds a never-null pointer to the ScriptExecutionContext. This should
similarly be a reference.
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmountCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerGlobalScopeDidSend):
(WebCore::workerGlobalScopeDidGetBufferedAmount):
(WebCore::workerGlobalScopeDidConnect):
(WebCore::workerGlobalScopeDidReceiveMessage):
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::workerGlobalScopeDidUpdateBufferedAmount):
(WebCore::workerGlobalScopeDidStartClosingHandshake):
(WebCore::workerGlobalScopeDidClose):
(WebCore::workerGlobalScopeDidReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSend):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadFail):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadResume):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

  • bindings/js/JSDOMGlobalObjectTask.cpp:

(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):

  • dom/Document.cpp:

(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

  • dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

  • fileapi/FileReader.cpp:

(WebCore::delayedAbort):
(WebCore::FileReader::abort):
(WebCore::FileReader::doAbort): Deleted.

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel):
(WebCore::workerGlobalScopeDidSendData):
(WebCore::workerGlobalScopeDidReceiveResponse):
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::workerGlobalScopeDidFinishLoading):
(WebCore::workerGlobalScopeDidFail):
(WebCore::workerGlobalScopeDidFailAccessControlCheck):
(WebCore::workerGlobalScopeDidFailRedirectCheck):

  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::postListenerTask):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::crossThreadRemoveRequestFromCache):
(WebCore::MemoryCache::crossThreadRemoveRequestFromSessionCaches):

  • loader/cache/MemoryCache.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::Task::performTask):

  • workers/WorkerScriptLoader.cpp:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

9:42 AM Changeset in webkit [170012] by zandobersek@gmail.com
  • 6 edits in trunk/Source

Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer
​https://bugs.webkit.org/show_bug.cgi?id=133677

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in: Update the changed symbol.
  • page/Page.cpp:

(WebCore::Page::findStringMatchingRanges): The method expects the matchRanges parameter to be non-null,
so it should take in that parameter by reference instead of pointer.

  • page/Page.h:

Source/WebKit2:

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString): Update the call to Page::findStringMatchingRanges() to pass
in a Vector<RefPtr<Range>> reference instead of a pointer.
(WebKit::FindController::findStringMatches): Ditto.

9:40 AM Changeset in webkit [170011] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Convert ASSERT in inlineFunctionForCapabilityLevel to early return
​https://bugs.webkit.org/show_bug.cgi?id=133903

Reviewed by Mark Hahnenberg.

Hardened code by Converting ASSERT to return CannotCompile.

  • dfg/DFGCapabilities.h:

(JSC::DFG::inlineFunctionForCapabilityLevel):

9:33 AM Changeset in webkit [170010] by stavila@adobe.com
  • 3 edits
    2 adds in trunk

REGRESSION (r168046): Incorrect layout for multicol spanners when moving from one thread to another
​https://bugs.webkit.org/show_bug.cgi?id=133589

Reviewed by Antti Koivisto.

Source/WebCore:
When a spanner is moved from a multicol thread to another, its placeholder
must be properly repositioned.

Test: fast/multicol/newmulticol/spanner-crash.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):

LayoutTests:

  • fast/multicol/newmulticol/spanner-crash-expected.txt: Added.
  • fast/multicol/newmulticol/spanner-crash.html: Added.
9:20 AM Changeset in webkit [170009] by svillar@igalia.com
  • 5 edits in releases/WebKitGTK/webkit-2.4

[Gtk] [Stable] Fix the "Safari" part of the UA
​https://bugs.webkit.org/show_bug.cgi?id=133855

Reviewed by Martin Robinson.

Source/WebCore:

We claim to be Safari (among others) to ensure maximum
compatibility with existing web sites. Since Safari 3.0 valid
Safari UA strings look like this "Version/X Safari/Y" while in our
UA it's "Safari/Y Version/6.0".

This is wrong and is causing "unsupported browser" issues in
many important sites as live.com our icloud.com.

Apart from that I'm bumping the Safari Version in the UA to 8.0 as
we're already claiming to be "Safari/538.15" which should be
pretty equivalent to Safari 8 in terms of features.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

Tools:

Added a couple of tests to verify that the Safari part of our UA
looks like "Version/X Safari/Y" instead of "Safari/Y Version/X"
which is causing "unsupported browser" issues.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

  • TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:

(test_webkit_web_settings_user_agent):

8:01 AM Changeset in webkit [170008] by mario.prada@samsung.com
  • 9 edits
    2 adds
    2 deletes in trunk

[ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
​https://bugs.webkit.org/show_bug.cgi?id=133512

Reviewed by Chris Fleizach.

Source/WebCore:
Make sure that AccessibilityMenuList objects update their active
option when it changes, which will send a platform-dependent
accessibility-related notification when needed.

Test: accessibility/combo-box-collapsed-selection-changed.html

  • rendering/RenderMenuList.cpp:

(RenderMenuList::didUpdateActiveOption): Keep the out-of-bounds
check for the index passed but don't avoid updating the option for
the associated AccessibilityMenuList object if the selected list
item does not have a renderer, because that could be the case for
cases where the popup (and its elements) would be rendered in the
UI Process (e.g. GTK+ port uses GtkMenu and GtkMenuItem for that).

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption): Ensure
that the AccessibilityMenuListPopup object for a given menu list
has accessibility children before updating its active option.

Tools:
Added support for connecting to AtkSelection's 'selection-changed'
signal, and print it out as AXSelectedChildrenChanged in the tests.

Also removed some dead code, that became useless after r169487.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.

LayoutTests:
Re-implemented test for combo boxes in terms of addNotificationListener()
instead of using the (already deprecated) logAccessibilityEvents method,
and made the test cross platform (as the fix is not platform specific).

  • accessibility/combo-box-collapsed-selection-changed.html:

Implemented based on the former gtk-only test, and made it cross-platform.

  • accessibility/combo-box-collapsed-selection-changed-expected.txt: New.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.

Updated expectation for test that checks that a notification is
sent when navigating through a multiselection list box, now that
we are actually printing such a notification.

  • accessibility/multiselect-list-reports-active-option-expected.txt: Updated.

Removed two expected failures from TestExpectations for tests that
are now passing, one for the combo box test mentioned above and
another one for a test that is passing as well now, after applying
this fix: accessibility/menu-list-sends-change-notification.html

  • platform/gtk/TestExpectations: Removed two 'failure' expectations.
  • platform/mac/TestExpectations: Skip accessiblity test timing out, probably because

those kind of notifications while navigating a combo box are not needed in the Mac.

5:17 AM Changeset in webkit [170007] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

Unreviewed, rolling out r170003.
​https://bugs.webkit.org/show_bug.cgi?id=133938

This patch broke GTK build (Requested by kczech on #webkit).

Reverted changeset:

"[EFL] Platform support for WebSpeech feature."
​https://bugs.webkit.org/show_bug.cgi?id=116438
​http://trac.webkit.org/changeset/170003

4:31 AM Changeset in webkit [170006] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Draw radicals with glyphs for better rendering.
​https://bugs.webkit.org/show_bug.cgi?id=119038

Unreviewed ASSERT fix.

  • rendering/mathml/RenderMathMLRoot.h:
3:07 AM Changeset in webkit [170005] by fred.wang@free.fr
  • 20 edits
    10 adds in trunk

Draw radicals with glyphs for better rendering
​https://bugs.webkit.org/show_bug.cgi?id=119038

Reviewed by Chris Fleizach.

Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.

Tests: mathml/opentype/roots-LatinModern.html

mathml/presentation/mroot-transform.html

  • CMakeLists.txt: add files to build system.
  • WebCore.vcxproj/WebCore.vcxproj: ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto
  • css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.

(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.

  • rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.

(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):

  • rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.

isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):

  • rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
  • rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.

(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):

  • rendering/mathml/RenderMathMLRadicalOperator.h: Added.
  • rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.

(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.

  • rendering/mathml/RenderMathMLRoot.h: Rewritten.

(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):

LayoutTests:
We update the reference for some tests with radicals and update the expectation of tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.

  • TestExpectations: enable the tests for addition/removal of children.
  • mathml/opentype/roots-LatinModern.html: Added.
  • mathml/presentation/mroot-transform-expected.html: Added.
  • mathml/presentation/mroot-transform.html: Added.
  • platform/efl/TestExpectations: mark failures for bad references.
  • platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
  • platform/gtk/mathml/presentation/roots-expected.png: update reference.
  • platform/gtk/mathml/presentation/roots-expected.txt: update reference.
  • platform/mac/TestExpectations: mark failures for bad references.
  • platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/win/TestExpectations: mark failures for bad references.
  • platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
2:23 AM EFLHistoryApiTutorial edited by aleks.a.kozlov@gmail.com
(diff)
2:09 AM Changeset in webkit [170004] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Change expectations for three failing or flaky layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=133861

Unreviewed EFL gardening.

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-06-16

  • platform/efl/TestExpectations:
1:25 AM Changeset in webkit [170003] by k.czech@samsung.com
  • 7 edits
    3 adds in trunk

[EFL] Platform support for WebSpeech feature.
​https://bugs.webkit.org/show_bug.cgi?id=116438

Reviewed by Gyuyoung Kim.

.:
Add ENABLE_SPEECH_SYNTHESIS flag to have Speech Synthesis in EFL.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:
It's a first step of adding support for Speech Synthesis in EFL port.
Just stub out required API and support for compilation.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • platform/PlatformSpeechSynthesizer.h:
  • platform/efl/PlatformSpeechSynthesisProviderEfl.cpp: Added.

(WebCore::PlatformSpeechSynthesisProviderEfl::PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::~PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::initializeVoiceList):
(WebCore::PlatformSpeechSynthesisProviderEfl::pause):
(WebCore::PlatformSpeechSynthesisProviderEfl::resume):
(WebCore::PlatformSpeechSynthesisProviderEfl::speak):
(WebCore::PlatformSpeechSynthesisProviderEfl::cancel):

  • platform/efl/PlatformSpeechSynthesisProviderEfl.h: Added.
  • platform/efl/PlatformSpeechSynthesizerEfl.cpp: Added.

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::cancel):

12:25 AM Changeset in webkit [170002] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed build fixes for the EFL and GTK+ ports after r169994 and 170000.

  • UIProcess/API/C/WKPluginSiteDataManager.cpp: Undefine the None macro under X11.
  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkit_cookie_manager_get_accept_policy): Remove unnecessary ::create() wrappings.
(webkit_cookie_manager_get_domains_with_cookies): Ditto.

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_get_data): Ditto.

Jun 15, 2014:

11:54 PM Changeset in webkit [170001] by benjamin@webkit.org
  • 8 edits
    8 adds in trunk

CSS JIT: add support for the :lang() pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=133913

Reviewed by Andreas Kling.

Source/WebCore:
The selector is already very expensive to begin with, just implement it with
a function call.

It is also done after every other filter since it is so inefficient.

Tests: fast/selectors/lang-conflict.html

fast/selectors/lang-empty.html
fast/selectors/lang-specificity-xml.xhtml
fast/selectors/lang-specificity.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):

  • dom/ElementData.cpp:

(WebCore::ElementData::findLanguageAttribute):

  • dom/ElementData.h:

LayoutTests:

  • fast/selectors/lang-conflict-expected.txt: Added.
  • fast/selectors/lang-conflict.html: Added.
  • fast/selectors/lang-empty-expected.txt: Added.
  • fast/selectors/lang-empty.html: Added.
  • fast/selectors/lang-specificity-expected.txt: Added.
  • fast/selectors/lang-specificity-xml-expected.txt: Added.
  • fast/selectors/lang-specificity-xml.xhtml: Added.
  • fast/selectors/lang-specificity.html: Added.
9:09 PM Changeset in webkit [170000] by mitz@apple.com
  • 38 edits in trunk/Source/WebKit2

Part 1 of Change GenericCallback<> function parameters into std::function<>
​https://bugs.webkit.org/show_bug.cgi?id=133927

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetApplicationCacheOrigins):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerGetHTTPCookieAcceptPolicy):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(WKFrameGetWebArchive):

  • UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):

  • UIProcess/API/C/WKMediaCacheManager.cpp:

(WKMediaCacheManagerGetHostnamesWithMediaCache):

  • UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerGetOrigins):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetSitesWithData):

  • UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetCacheOrigins):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView attributedSubstringForProposedRange:completionHandler:]):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::getSitesWithData):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getWebArchive):
(WebKit::WebFrameProxy::getMainResourceData):
(WebKit::WebFrameProxy::getResourceData):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):

  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):

  • UIProcess/WebMediaCacheManagerProxy.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::getOrigins):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::selectWithTwoTouches):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):

9:08 PM Changeset in webkit [169999] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

iOS build fix after r169995.

  • wtf/RetainPtr.h:
8:23 PM Changeset in webkit [169998] by mitz@apple.com
  • 7 edits in trunk/Source/WebKit2

<rdar://problem/17291697> [Cocoa] Can’t tell at policy decision time whether WebKit can handle the request
​https://bugs.webkit.org/show_bug.cgi?id=133930

Reviewed by Sam Weinig.

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::NavigationActionData): Initialize new member canHandleRequest
to false.
(WebKit::NavigationActionData::encode): Encode canHandleRequest.
(WebKit::NavigationActionData::decode): Decode it.

  • Shared/NavigationActionData.h: Declared new boolean member canHandleRequest.
  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction _initWithNavigationActionData:]): Set new ivar _canHandleRequest from
the action data.
(-[WKNavigationAction _canHandleRequest]): Added this getter.

  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h: Declared new property _canHandleRequest.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow): Set canHandleRequest in the NavigationActionData.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto.
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.

6:45 PM Changeset in webkit [169997] by ryuan.choi@samsung.com
  • 10 edits in trunk

[EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
​https://bugs.webkit.org/show_bug.cgi?id=133841

Reviewed by Gyuyoung Kim.

Source/WebKit2:
Ewk_Settings object is a member of Ewk_Page_Group.
So, Ewk_Page_Group is better place for the getter of Ewk_Settings.

  • UIProcess/API/efl/ewk_page_group.cpp:

(ewk_page_group_settings_get): Added instead of ewk_view_settings_get.

  • UIProcess/API/efl/ewk_page_group.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_settings_get): Deleted.

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_page_group.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F): Deleted.

Tools:

  • MiniBrowser/efl/main.c:

(window_create):

4:38 PM Changeset in webkit [169996] by mitz@apple.com
  • 2 edits in trunk/Tools

Set the svn:ignore property on an Xcode project to ignore user and workspace data.

  • jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
4:16 PM Changeset in webkit [169995] by andersca@apple.com
  • 14 edits in trunk/Source

Add an autorelease() member function to RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=133929

Reviewed by Dan Bernstein.

Source/WebCore:

  • bindings/objc/DOM.mm:

(-[DOMNode renderedImage]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):

  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMHTMLImageElement dataRepresentation:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

Source/WebKit/mac:

  • WebView/WebDataSource.mm:

(-[WebDataSource data]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):

  • WebView/WebResource.mm:

(-[WebResource data]):

Source/WebKit2:

  • Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:

(-[_WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView navigationDelegate]):
(-[WKWebView UIDelegate]):
(-[WKWebView loadRequest:]):
(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _historyDelegate]):

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(WebKit::animationValueFromKeyframeValue):

Source/WTF:

  • wtf/RetainPtr.h:
1:50 PM Changeset in webkit [169994] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Get rid of VoidAPICallback
​https://bugs.webkit.org/show_bug.cgi?id=133928

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(WKPageForceRepaint): Wrap the API callback in a generic callback here.

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData): Ditto.
(WKPluginSiteDataManagerClearAllSiteData): Ditto.

  • UIProcess/GenericCallback.h:

(WebKit::GenericCallback::performCallback): Added this helper for 0-argument callbacks.
(WebKit::VoidCallback::create): Deleted.
(WebKit::VoidCallback::~VoidCallback): Deleted.
(WebKit::VoidCallback::performCallback): Deleted.
(WebKit::VoidCallback::invalidate): Deleted.
(WebKit::VoidCallback::VoidCallback): Deleted.
(WebKit::VoidAPICallback::create): Deleted.

  • UIProcess/mac/WKFullScreenWindowController.h:
12:35 PM Changeset in webkit [169993] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK+ port after r169990.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState): Pass the error value to
the rest of invalidateCallbackMap calls.

12:12 PM Changeset in webkit [169992] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix build.

  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:

(callRunJavaScriptBlockAndRelease):
(runJavaScriptInMainFrame):
(TEST_F):

11:23 AM Changeset in webkit [169991] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove WKPageRunJavaScriptInMainFrame_b
​https://bugs.webkit.org/show_bug.cgi?id=133926

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(callRunJavaScriptBlockAndRelease): Deleted.
(WKPageRunJavaScriptInMainFrame_b): Deleted.

  • UIProcess/API/C/WKPage.h:
11:07 AM Changeset in webkit [169990] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

invalidateCallbackMap doesn’t pass the error parameter on to invalidate(), so script completion handler is passed the wrong error
​https://bugs.webkit.org/show_bug.cgi?id=133921
<rdar://problem/17316653>

Reviewed by Dan Bernstein.

  • UIProcess/GenericCallback.h:

(WebKit::VoidCallback::performCallback):
(WebKit::VoidCallback::invalidate):
(WebKit::VoidAPICallback::create):
(WebKit::invalidateCallbackMap):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::clearSiteData):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):

  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::contextDestroyed):
(WebKit::WebOriginDataManagerProxy::processDidClose):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController dealloc]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

9:33 AM Changeset in webkit [169989] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Adopt HTTPHeaderName in ResourceResponseBase
​https://bugs.webkit.org/show_bug.cgi?id=133919

Reviewed by Sam Weinig.

  • platform/network/HTTPHeaderNames.in:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::updateHeaderParsedState):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::parseDateValueInHeader):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):

  • platform/network/ResourceResponseBase.h:
4:04 AM Changeset in webkit [169988] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK+ port after r169987.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_can_execute_editing_command): The first passed-in parameter
is now a reference to a const String object.

Jun 14, 2014:

7:10 PM Changeset in webkit [169987] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Replace StringImpl* callback parameters with const String&
​https://bugs.webkit.org/show_bug.cgi?id=133922

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(toGenericCallbackFunction): Added this helper function to wrap a WKStringRef-returning
API callback in a generic const String&-returning callback.
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageValidateCommand):

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
(-[WKView startSpeaking:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _define:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):

5:07 PM Changeset in webkit [169986] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Additional iOS build fix.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _define:]):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):

4:32 PM Changeset in webkit [169985] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

4:11 PM Changeset in webkit [169984] by mitz@apple.com
  • 14 edits in trunk/Source/WebKit2

Get rid of GenericAPICallback
​https://bugs.webkit.org/show_bug.cgi?id=133909

Reviewed by Sam Weinig.

In preparation for passing callbacks as functions, replace GenericAPICallback::create, which
returned a GenericCallback, with a function template that returns an appropriate callback
function.

  • UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetApplicationCacheOrigins):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerGetHTTPCookieAcceptPolicy):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(WKFrameGetWebArchive):

  • UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):

  • UIProcess/API/C/WKMediaCacheManager.cpp:

(WKMediaCacheManagerGetHostnamesWithMediaCache):

  • UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerGetOrigins):

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSelectionAsWebArchiveData):
(WKPageGetContentsAsMHTMLData):
(WKPageDrawPagesToPDF):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetSitesWithData):

  • UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetCacheOrigins):

  • UIProcess/GenericCallback.h:

(WebKit::toGenericCallbackFunction): Added. Given a C SPI callback function, returns a generic
callback function that wraps it.

3:44 PM Changeset in webkit [169983] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverted the last change, which broken the Mac build.

  • UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):

2:59 PM Changeset in webkit [169982] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Tried to fix the GTK build.

  • UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):

2:35 PM Changeset in webkit [169981] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify ResourceRequest constructors
​https://bugs.webkit.org/show_bug.cgi?id=133911

Reviewed by Sam Weinig.

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

1:57 PM Changeset in webkit [169980] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the ARM64 build

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):

1:38 PM Changeset in webkit [169979] by weinig@apple.com
  • 12 edits in trunk/Source

Store DOM constants directly in the JS object rather than jumping through a custom accessor
​https://bugs.webkit.org/show_bug.cgi?id=133898

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/Lookup.h:

(JSC::HashTableValue::attributes):
Switch attributes to be stored as an unsigned rather than an unsigned char, since there is no difference in memory use
and will make adding more flags possibles.

(JSC::HashTableValue::propertyGetter):
(JSC::HashTableValue::propertyPutter):
Change assertion to use BuiltinOrFunctionOrConstant.

(JSC::HashTableValue::constantInteger):
Added.

(JSC::getStaticPropertySlot):
(JSC::getStaticValueSlot):
Use PropertySlot::setValue() for constants during static lookup.

(JSC::reifyStaticProperties):
Put the constant directly on the object when eagerly reifying.

  • runtime/PropertySlot.h:

Add ConstantInteger flag and BuiltinOrFunctionOrConstant helper.

Source/WebCore:
Instead of implementing constants as custom accessors that just happen to return a value,
we now store the constant directly in the HashTableValue array (where the GetValueFunc used
to be).

  • For the case where the constant is accessed via the static table (still in use for instances and some prototypes), the static lookup function will set the value on the property slot, instead of passing a function pointer.
  • For the case where the constant is eagerly reified (most prototypes and all constructors) the constant is put directly in the object.

In micro benchmarks this looks to be around a 4x speedup on the use of DOM constants.

This also removes support for constant strings in IDL, which we had no uses of.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Remove code to generate forward declaration of constant accessor functions.

(GenerateImplementation):
Remove code to generate implementation of constant accessor functions.

(GenerateHashTableValueArray):
Plant the constant directly in the value array.

  • bindings/scripts/IDLParser.pm:

(parseConstValue):
Remove support for constant strings.

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/TestObj.idl:

Update test results.

1:33 PM Changeset in webkit [169978] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Simplify Document::processHttpEquiv
​https://bugs.webkit.org/show_bug.cgi?id=133910

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • platform/network/HTTPHeaderNames.in:
12:39 PM Changeset in webkit [169977] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

GCController should return FastMalloc memory to the system.
<​https://webkit.org/b/133884>

Reviewed by Anders Carlsson.

Speculative test fix; I'm kinda suspecting that some tests are reporting
more memory used because we did a GC but didn't get around to returning
free pages to the system yet.

  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow):

12:13 PM Changeset in webkit [169976] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Generate HTTP header names that are required by WebKitWebSrc
​https://bugs.webkit.org/show_bug.cgi?id=133906

Reviewed by Anders Carlsson.

WebKitWebSrc implementation sets icy-metadata and transferMode.dlna HTTP headers
on ResourceRequest objects. The two headers are added to HTTPHeaderNames.in, and
a small tweak is added to the generator script to avoid the dot in the second
header's name (which would otherwise generate invalid C++).

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/HTTPHeaderNames.in:
  • platform/network/create-http-header-name-table:
12:10 PM Changeset in webkit [169975] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Replace some uses of ResourceRequestBase::addHTTPHeaderField with setHTTPHeaderField
​https://bugs.webkit.org/show_bug.cgi?id=133907

Reviewed by Andreas Kling.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest):

  • platform/network/HTTPHeaderNames.in:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader):

10:49 AM Changeset in webkit [169974] by andersca@apple.com
  • 15 edits in trunk/Source/WebCore

Add a ResourceRequestBase::setHTTPHeaderField overload that takes a HTTPHeaderName
​https://bugs.webkit.org/show_bug.cgi?id=133881

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/EventSource.cpp:

(WebCore::EventSource::connect):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::doStart):

  • platform/network/HTTPHeaderNames.in:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):

  • platform/network/ResourceRequestBase.h:
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest):

10:43 AM Changeset in webkit [169973] by msaboff@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

operationCreateArguments could cause a GC during OSR exit
​https://bugs.webkit.org/show_bug.cgi?id=133905

Reviewed by Filip Pizlo.

Defer GC via new wrapper functions for operationCreateArguments and operationCreateInlinedArguments
for use by OSR exit stubs.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::ArgumentsRecoveryGenerator::generateFor):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
10:40 AM Changeset in webkit [169972] by Simon Fraser
  • 5 edits
    6 adds in trunk

Masks disappear when layers become tiled
​https://bugs.webkit.org/show_bug.cgi?id=133892
<rdar://problem/17309793>

Reviewed by Tim Horton.

Source/WebCore:
There were several problems with tiled mask layers.

First, when a layer became tiled it failed to re-apply the platform layer
for its mask; fixed by adding MaskLayerChanged to the set of flags in
swapFromOrToTiledLayer().

Secondly, in CA, a mask layer's superlayer is the layer which is it masking,
so the if (oldLayer->superlayer())... code in swapFromOrToTiledLayer() would
erroneously try to swap out a sublayer on the superlayer with the mask.

Thirdly, the mask layer is updated after its host layer, but when the mask layer
become tiled, there was no code that updated the mask platform layer on its
host layer. Fix by:

  1. setting a bit on a layer to note that it's being used as a mask.
  2. setting the parent of such a layer to its host layer (mimicking CA)
  3. when the mask becomes tiled, dirtying the MaskLayerChanged bit on its parent and adding a clause to commitLayerChangesAfterSublayers() to update the mask layer.

Finally, ASSERTION FAILED: owningGraphicsLayer()->isCommittingChanges() would
fire because we failed to set the m_isCommittingChanges flag while committing
the mask layer. Fix by moving the TemporaryChange<bool> that sets this flag
into commitLayerChangesBeforeSublayers() and commitLayerChangesAfterSublayers().

Also used safe casts in more places in GraphicsLayerCA.

Tests: compositing/masks/become-tiled-mask.html

compositing/masks/cease-tiled-mask.html
compositing/masks/tiled-mask.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::removeFromParent):
(WebCore::GraphicsLayer::setMaskLayer):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setIsMaskLayer):
(WebCore::GraphicsLayer::isMaskLayer):
(WebCore::GraphicsLayer::setMaskLayer): Deleted.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::removeFromParent):
(WebCore::GraphicsLayerCA::setMaskLayer):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

LayoutTests:
Tests for masking as they go into and out of tiled mode.

  • compositing/masks/become-tiled-mask-expected.html: Added.
  • compositing/masks/become-tiled-mask.html: Added.
  • compositing/masks/cease-tiled-mask-expected.html: Added.
  • compositing/masks/cease-tiled-mask.html: Added.
  • compositing/masks/tiled-mask-expected.html: Added.
  • compositing/masks/tiled-mask.html: Added.
10:12 AM Changeset in webkit [169971] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView attributedSubstringForProposedRange:completionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):

9:06 AM Changeset in webkit [169970] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Compile errors related to http headers.
​https://bugs.webkit.org/show_bug.cgi?id=133901

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-06-14
Reviewed by Brent Fulgham.

Http headers should now be specified with an enum, not a string.

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::parseResponseHeaders):

  • platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveResponse):

8:53 AM Changeset in webkit [169969] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK+ port.
Fixing the callback lambda parameters after r169962.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationPrintPagesForFrame):

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_get_data):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_can_execute_editing_command):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_save):
(webkit_web_view_save_to_file):

8:43 AM Changeset in webkit [169968] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r169960.

  • platform/graphics/ca/PlatformCALayer.cpp: Add missing include

for snprintf on Windows.

3:18 AM Changeset in webkit [169967] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

[EFL] Remove duplicated compiler flag
​https://bugs.webkit.org/show_bug.cgi?id=133838

Reviewed by Anders Carlsson.

In r169798, literal-suffix was added for EFL port in order to fix build break. However,
it added to common compiler options. So, it is duplicated.

  • Source/cmake/WebKitHelpers.cmake:
2:04 AM Changeset in webkit [169966] by Csaba Osztrogonác
  • 6 edits in trunk/Source

Source/WebCore: URTBF after r169943 and r169946.

  • platform/network/HTTPHeaderMap.h: Removed maybe accidental deletion of the only one add function.
  • platform/network/HTTPHeaderNames.in: Added Sec-WebSocket-Key.

Source/WebKit2: URTBF after r169943 and r169946, use the format of set/get.

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::readHTTPMessage):
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):

1:01 AM Changeset in webkit [169965] by fred.wang@free.fr
  • 20 edits
    10 deletes in trunk

Unreviewed, rolling out r169963.
​https://bugs.webkit.org/show_bug.cgi?id=133899

Assertion in mathml/roots-removeChild.html (Requested by fredw
on #webkit).

Reverted changeset:

"Draw radicals with glyphs for better rendering"
​https://bugs.webkit.org/show_bug.cgi?id=119038
​http://trac.webkit.org/changeset/169963

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-06-14

Jun 13, 2014:

11:31 PM Changeset in webkit [169964] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r167635): Reference leak in NetworkResourceLoader while loads are being deferred.
<​https://webkit.org/b/133894>
<rdar://problem/17312299>

Don't self-ref() in start() until we actually start; if page loads are being
deferred, start() will be called again once deferral stops.

This was causing us to leak the entire NetworkResourceLoader object graph.

Reviewed by Brady Eidson.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

11:18 PM Changeset in webkit [169963] by fred.wang@free.fr
  • 20 edits
    10 adds in trunk

Draw radicals with glyphs for better rendering
​https://bugs.webkit.org/show_bug.cgi?id=119038

Reviewed by Chris Fleizach.

Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.

Tests: mathml/opentype/roots-LatinModern.html

mathml/presentation/mroot-transform.html

  • CMakeLists.txt: add files to build system.
  • WebCore.vcxproj/WebCore.vcxproj: ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto
  • css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.

(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.

  • rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.

(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):

  • rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.

isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):

  • rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
  • rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.

(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):

  • rendering/mathml/RenderMathMLRadicalOperator.h: Added.
  • rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.

(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.

  • rendering/mathml/RenderMathMLRoot.h: Rewritten.

(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):

LayoutTests:
We update the reference for some tests with radicals and enable the tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.

  • TestExpectations: enable the tests for addition/removal of children.
  • mathml/opentype/roots-LatinModern.html: Added.
  • mathml/presentation/mroot-transform-expected.html: Added.
  • mathml/presentation/mroot-transform.html: Added.
  • platform/efl/TestExpectations: mark failures for bad references.
  • platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
  • platform/gtk/mathml/presentation/roots-expected.png: update reference.
  • platform/gtk/mathml/presentation/roots-expected.txt: update reference.
  • platform/mac/TestExpectations: mark failures for bad references.
  • platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/win/TestExpectations: mark failures for bad references.
  • platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
10:32 PM Changeset in webkit [169962] by mitz@apple.com
  • 10 edits in trunk/Source/WebKit2

Make GenericCallback variadic
​https://bugs.webkit.org/show_bug.cgi?id=133897

Reviewed by Sam Weinig.

Also eliminated legacy callback functions and all CallbackBase derived classes outside of
GenericCallback.h.

  • UIProcess/API/C/WKPage.cpp:

(WKPageValidateCommand): Changed legacy callback (with leading bool parameter) into modern
callback (with trailing error parameter).
(WKPageComputePagesForPrinting): Ditto.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getWebArchiveDataWithCompletionHandler:]): Ditto.
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Ditto.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView _requestSnapshotIfNeeded]): Ditto.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Ditto.
(-[WKView startSpeaking:]): Ditto.

  • UIProcess/AutoCorrectionCallback.h: Replaced CallbackBase derived classes with

GenericCallback specializations.

  • UIProcess/GenericCallback.h:
  • Made GenericCallback variadic:

(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericAPICallback::create):

  • Replaced CallbackBase derived classes with GenericCallback specializations:

(WebKit::GenericCallback::create): Deleted.
(WebKit::ComputedPagesCallback::create): Deleted.
(WebKit::ComputedPagesCallback::~ComputedPagesCallback): Deleted.
(WebKit::ComputedPagesCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ComputedPagesCallback::invalidate): Deleted.
(WebKit::ComputedPagesCallback::ComputedPagesCallback): Deleted.
(WebKit::ImageCallback::create): Deleted.
(WebKit::ImageCallback::~ImageCallback): Deleted.
(WebKit::ImageCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ImageCallback::invalidate): Deleted.
(WebKit::ImageCallback::ImageCallback): Deleted.

  • UIProcess/WebPageProxy.h: Replaced CallbackBase derived classes with GenericCallback

specializations.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]): Changed
legacy callback (with leading bool parameter) into modern callback (with trailing error
parameter).
(-[WKContentView requestDictationContext:]): Ditto.
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]): Ditto.

  • UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ditto.
(-[WKPrintingView _askPageToComputePageRects]): Ditto.
(-[WKPrintingView _drawPreview:]): Ditto.

10:09 PM Changeset in webkit [169961] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed; fix the build.

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

7:59 PM Changeset in webkit [169960] by Brent Fulgham
  • 9 edits in trunk/Source/WebCore

Move utility functions from WebLayer to PlatformCALayer
​https://bugs.webkit.org/show_bug.cgi?id=133887
<rdar://problem/17309622>

Reviewed by Simon Fraser.

Move some utility functions from WebLayer.h/.mm to PlatformCALayer.
Provide ObjC implementation in PlatformCALayerMac. A future patch will
provide corresponding Windows versions.

  • WebCore.exp.in:
  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawRepaintIndicator):

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::blankPixelCountForTiles):

  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::collectRectsToPaint):
(PlatformCALayer::drawLayerContents):
(PlatformCALayer::frameForLayer):

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(WebCore::collectRectsToPaint): Deleted.
(WebCore::drawLayerContents): Deleted.
(WebCore::drawRepaintIndicator): Deleted.
(WebCore::frameForLayer): Deleted.

5:35 PM Changeset in webkit [169959] by achristensen@apple.com
  • 4 edits in trunk/Source

Unreviewed disabling css jit on armv7. It's not quite ready yet.

Source/WebCore:

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Removed extra comma.

Source/WTF:

  • wtf/Platform.h:

Disable css jit on armv7.

5:18 PM Changeset in webkit [169958] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Enable css jit for armv7 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=133890
<rdar://problem/17310631>

Reviewed by Andreas Kling.

  • wtf/Platform.h:

Enable css jit for ARM thumb on iOS.

5:04 PM Changeset in webkit [169957] by mhock@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up layers in RemoteLayerTreeHost::clearLayers().
​https://bugs.webkit.org/show_bug.cgi?id=133888

Reviewed by Tim Horton.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::clearLayers):

4:37 PM CommitterTips edited by akling@apple.com
(diff)
4:37 PM Changeset in webkit [169956] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Make css jit compile on armv7.
​https://bugs.webkit.org/show_bug.cgi?id=133889

Reviewed by Benjamin Poulain.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::moduloHelper):
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implement modulo using a function call for now.

4:01 PM Changeset in webkit [169955] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Use the callOnMainThread version that takes an std::function in BlobResourceHandle::start()
​https://bugs.webkit.org/show_bug.cgi?id=133886

Reviewed by Andreas Kling.

Also replace a couple of NSAutoreleasePools with @autoreleasepool and an OwnPtr with an std::unique_ptr.

  • page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::threadRunLoopSourceCallback):

  • platform/mac/SharedTimerMac.mm:

(WebCore::PowerObserver::PowerObserver):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::PowerObserver::create): Deleted.
(WebCore::PowerObserver::didReceiveSystemPowerNotification): Deleted.

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::start):
(WebCore::delayedStartBlobResourceHandle): Deleted.

  • platform/network/BlobResourceHandle.h:
3:52 PM Changeset in webkit [169954] by weinig@apple.com
  • 36 edits in trunk/Source/WebCore

Constructors should eagerly reify their properties too
​https://bugs.webkit.org/show_bug.cgi?id=133822

Reviewed by Andreas Kling.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
Constructors should never need to use the lazy property HashTable, so we can just
remove its getOwnPropertySlot completely.

(ConstructorHasProperties):
Add helper to determine if we need to reify any properties.

(GenerateConstructorHelperMethods):
Reify if needed, and remove the implementation of getOwnPropertySlot.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:
  • bindings/scripts/test/JS/JSTestNondeterministic.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.cpp:
  • bindings/scripts/test/JS/JSreadonly.h:

Update tests.

3:26 PM Changeset in webkit [169953] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make css jit allocator smarter.
​https://bugs.webkit.org/show_bug.cgi?id=133834

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.

  • cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::allocateRegister):
(WebCore::RegisterAllocator::deallocateRegister):
(WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
(WebCore::LocalRegister::LocalRegister):
(WebCore::RegisterAllocator::RegisterAllocator):
Use a Deque for the registers. Allocate from the front and deallocate to the back to cycle the register usage.
(WebCore::RegisterAllocator::allocateRegisterWithPreference):
(WebCore::LocalRegisterWithPreference::LocalRegisterWithPreference):
Added the ability to specify that we prefer a certain register if it is available while allocating.
These functions always return a register. It is just a different register than preferred if the preferred register is not available.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueExactMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Whenever we are allocating a register for the second argument, we should specify that we
prefer to have argumentGPR1 to reduce register swapping when preparing for a function call.
This cannot be done for argumentGPR0 because elementAddressRegister is argumentGPR0 and it is always allocated.

3:24 PM Changeset in webkit [169952] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

set setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode
​https://bugs.webkit.org/show_bug.cgi?id=133829

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-06-13
Reviewed by Eric Carlson.

When playing inline and external screen is active, don't use external playback.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

declare updateDisableExternalPlayback()

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
call updateDisableExternalPlayback when player is created
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
call updateDisableExternalPlayback when fullscreen mode changes
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateDisableExternalPlayback):
update setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode

3:18 PM Changeset in webkit [169951] by mhahnenberg@apple.com
  • 4 edits in trunk/Source

OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit
​https://bugs.webkit.org/show_bug.cgi?id=133880

Reviewed by Filip Pizlo.

Source/JavaScriptCore:
We could have exited due to a value received from an inlined block that's no longer on
the stack, so we should just barrier all InlineCallFrames.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

Source/WTF:

  • wtf/Bag.h:

(WTF::Bag::iterator::operator!=): Add != to the Bag iterator so we can use it in range-based iteration.

2:49 PM Changeset in webkit [169950] by fpizlo@apple.com
  • 20 edits
    8 adds
    2 deletes in branches/ftlopt

[ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
​https://bugs.webkit.org/show_bug.cgi?id=133821

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This allows us to efficiently cache accesses that differ only in the prototypes on the path
from the base to the prototype that has the field.

It also simplifies a bunch of code - IntendedStructureChain is now just an intermediate
data structure.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/ConstantStructureCheck.cpp: Added.

(JSC::ConstantStructureCheck::dumpInContext):
(JSC::ConstantStructureCheck::dump):
(JSC::structureFor):
(JSC::areCompatible):
(JSC::mergeInto):

  • bytecode/ConstantStructureCheck.h: Added.

(JSC::ConstantStructureCheck::ConstantStructureCheck):
(JSC::ConstantStructureCheck::operator!):
(JSC::ConstantStructureCheck::constant):
(JSC::ConstantStructureCheck::structure):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):

  • bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::constantChecks):
(JSC::GetByIdVariant::alternateBase):
(JSC::GetByIdVariant::GetByIdVariant): Deleted.
(JSC::GetByIdVariant::chain): Deleted.

  • bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::dumpInContext):

  • bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::constantChecks):
(JSC::PutByIdVariant::structureChain): Deleted.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::emitChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::cellConstantWithStructureCheck): Deleted.
(JSC::DFG::ByteCodeParser::structureChainIsStillValid): Deleted.
(JSC::DFG::ByteCodeParser::emitPrototypeChecks): Deleted.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

  • dfg/DFGDesiredStructureChains.cpp: Removed.
  • dfg/DFGDesiredStructureChains.h: Removed.
  • dfg/DFGGraph.h:

(JSC::DFG::Graph::watchpoints):
(JSC::DFG::Graph::chains): Deleted.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isStillValid):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::cancel):

  • dfg/DFGPlan.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::gatherChecks):

  • runtime/IntendedStructureChain.h:

(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):

LayoutTests:

  • js/regress/poly-chain-access-different-prototypes-expected.txt: Added.
  • js/regress/poly-chain-access-different-prototypes-simple-expected.txt: Added.
  • js/regress/poly-chain-access-different-prototypes-simple.html: Added.
  • js/regress/poly-chain-access-different-prototypes.html: Added.
  • js/regress/script-tests/poly-chain-access-different-prototypes-simple.js: Added.
  • js/regress/script-tests/poly-chain-access-different-prototypes.js: Added.
2:30 PM Changeset in webkit [169949] by fpizlo@apple.com
  • 8 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Constant folding and strength reduction should work in SSA
​https://bugs.webkit.org/show_bug.cgi?id=133839

Reviewed by Oliver Hunt.

  • dfg/DFGAtTailAbstractState.cpp:

(JSC::DFG::AtTailAbstractState::AtTailAbstractState):
(JSC::DFG::AtTailAbstractState::forNode):

  • dfg/DFGAtTailAbstractState.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::rangeKeyAndAddend): Fix an unrelated regression that this uncovered.

  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::LICMPhase):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

2:13 PM Changeset in webkit [169948] by Brent Fulgham
  • 2 edits
    4 moves in trunk/Source/WebCore

Convert LayerPool and TileCoverageMap from ObjC to C++
​https://bugs.webkit.org/show_bug.cgi?id=133862
<rdar://problem/17302883>

Reviewed by Simon Fraser.

This just moves two ObjC files from the mac subdirectory to the parent and
revises the project to build them as C++.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/LayerPool.cpp: Copied from platform/graphics/ca/mac/LayerPool.mm.
  • platform/graphics/ca/LayerPool.h: Copied from platform/graphics/ca/mac/LayerPool.h.
  • platform/graphics/ca/TileCoverageMap.cpp: Copied from platform/graphics/ca/mac/TileCoverageMap.mm.
  • platform/graphics/ca/TileCoverageMap.h: Copied from platform/graphics/ca/mac/TileCoverageMap.h.
  • platform/graphics/ca/mac/LayerPool.h: Removed.
  • platform/graphics/ca/mac/LayerPool.mm: Removed.
  • platform/graphics/ca/mac/TileCoverageMap.h: Removed.
  • platform/graphics/ca/mac/TileCoverageMap.mm: Removed.
1:43 PM Changeset in webkit [169947] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Make css jit compile for armv7.
​https://bugs.webkit.org/show_bug.cgi?id=133596

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • assembler/MacroAssembler.h:

Use branchPtr on ARM_THUMB2.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::addPtrNoFlags):
(JSC::MacroAssemblerARMv7::or32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::branch):
(JSC::MacroAssemblerARMv7::branchPtr):
Added macros necessary for css jit.

Source/WebCore:

  • cssjit/FunctionCall.h:

(WebCore::FunctionCall::swapArguments):
Implemented for ARM_THUMB2 and removed allocator hack.

  • cssjit/RegisterAllocator.h:

Added list of ARM_THUMB2 general purpose registers.
(WebCore::RegisterAllocator::isValidRegister):
Added ARM register range and corrected ARM64 register range now that r15 is tempRegister.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
Return CannotCompile if compiling fails because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
Implemented for ARM_THUMB2.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Return false if the selector cannot be compiled because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Added code using 32-bit operations and used macro assembler for 64-bit operations.
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implemented for APPLE_ARMV7S, where sdiv is not a template in the assembler.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
Use addPtr instead of add64.

1:37 PM Changeset in webkit [169946] by andersca@apple.com
  • 9 edits in trunk/Source

Add a HTTPHeaderMap::get overload that takes an HTTPHeaderName
​https://bugs.webkit.org/show_bug.cgi?id=133877

Reviewed by Andreas Kling.

Source/WebCore:

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::serverWebSocketProtocol):
(WebCore::WebSocketHandshake::serverSetCookie):
(WebCore::WebSocketHandshake::serverSetCookie2):
(WebCore::WebSocketHandshake::serverUpgrade):
(WebCore::WebSocketHandshake::serverConnection):
(WebCore::WebSocketHandshake::serverWebSocketAccept):

  • WebCore.exp.in:
  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::get):

  • platform/network/HTTPHeaderMap.h:
  • platform/network/HTTPHeaderNames.in:
  • plugins/PluginView.cpp:

(WebCore::PluginView::handlePost):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

1:34 PM Changeset in webkit [169945] by fred.wang@free.fr
  • 20 edits
    10 deletes in trunk

Unreviewed, rolling out r169939.
​https://bugs.webkit.org/show_bug.cgi?id=133878

This patch raises assertions on mac (Requested by fredw on
#webkit).

Reverted changeset:

"Draw radicals with glyphs for better rendering"
​https://bugs.webkit.org/show_bug.cgi?id=119038
​http://trac.webkit.org/changeset/169939

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-06-13

12:54 PM Changeset in webkit [169944] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix ARMv7.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::abortWithReason):

12:35 PM Changeset in webkit [169943] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName
​https://bugs.webkit.org/show_bug.cgi?id=133874

Reviewed by Tim Horton.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::set):

  • platform/network/HTTPHeaderMap.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

11:56 AM Changeset in webkit [169942] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Even better diagnostics from DFG traps
​https://bugs.webkit.org/show_bug.cgi?id=133836

Reviewed by Oliver Hunt.

We now stuff the DFG::NodeType into a register before bailing. Also made the
DFGBailed abort reason a bit more specific. As planned, the new abort reasons use
different numbers than any previous abort reasons.

  • assembler/AbortReason.h:
  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::abortWithReason):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::abortWithReason):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::abortWithReason):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::abortWithReason):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::bail):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT.h:
11:56 AM Changeset in webkit [169941] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Add a HTTPHeaderMap::find overload that takes a HTTPHeaderName
​https://bugs.webkit.org/show_bug.cgi?id=133872

Reviewed by Andreas Kling.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::find):

  • platform/network/HTTPHeaderMap.h:
  • platform/network/HTTPHeaderNames.in:
11:48 AM Changeset in webkit [169940] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Added some flaky and failing tests to TestExpectations.

Patch by Enrique Ocaña González <​eocanha@igalia.com> on 2014-06-13

  • platform/gtk/TestExpectations:
11:14 AM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com
(diff)
11:08 AM Changeset in webkit [169939] by fred.wang@free.fr
  • 20 edits
    10 adds in trunk

Draw radicals with glyphs for better rendering
​https://bugs.webkit.org/show_bug.cgi?id=119038

Reviewed by Chris Fleizach.

Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.

Tests: mathml/opentype/roots-LatinModern.html

mathml/presentation/mroot-transform.html

  • CMakeLists.txt: add files to build system.
  • WebCore.vcxproj/WebCore.vcxproj: ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto
  • css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.

(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.

  • rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.

(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):

  • rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.

isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):

  • rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
  • rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.

(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):

  • rendering/mathml/RenderMathMLRadicalOperator.h: Added.
  • rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.

(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.

  • rendering/mathml/RenderMathMLRoot.h: Rewritten.

(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):

LayoutTests:
We update the reference for some tests with radicals and enable the tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.

  • TestExpectations: enable the tests for addition/removal of children.
  • mathml/opentype/roots-LatinModern.html: Added.
  • mathml/presentation/mroot-transform-expected.html: Added.
  • mathml/presentation/mroot-transform.html: Added.
  • platform/efl/TestExpectations: mark failures for bad references.
  • platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
  • platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
  • platform/gtk/mathml/presentation/roots-expected.png: update reference.
  • platform/gtk/mathml/presentation/roots-expected.txt: update reference.
  • platform/mac/TestExpectations: mark failures for bad references.
  • platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
  • platform/win/TestExpectations: mark failures for bad references.
  • platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
11:04 AM Changeset in webkit [169938] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[iOS] Networking process always decodes keys
​https://bugs.webkit.org/show_bug.cgi?id=133863

Reviewed by Anders Carlsson.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer): Call checkEntitlements on iOS, too.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements): On iOS, allow decoding keys
if the application has the appropriate keychain access group.

  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::setAllowsDecodingSecKeyRef): Added. Sets static bool.
(IPC::decode): Check the secKeyRefDecodingAllowed bool before decoding a key.

  • Shared/cf/ArgumentCodersCF.h:
10:33 AM Changeset in webkit [169937] by andersca@apple.com
  • 10 edits in trunk/Source

Add overloads of HTTPHeaderMap::find and remove that take enums
​https://bugs.webkit.org/show_bug.cgi?id=133823

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:

Update symbols.

  • WebCore.xcodeproj/project.pbxproj:

Make HTTPHeaderNames.h private.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::contains):
Convert the enum value to a string and call the contains overload that takes a string.

(WebCore::HTTPHeaderMap::remove):
Convert the enum value to a string and call the remove overload that takes a string.

  • platform/network/HTTPHeaderMap.h:

Add new overloads taking HTTPHeaderName and mark the versions taking string literals as deleted.

  • platform/network/HTTPHeaderNames.in:

Add new header names.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPContentType):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::clearHTTPUserAgent):
(WebCore::ResourceRequestBase::clearHTTPAccept):
Update functions to use HTTPHeaderName enums.

(WebCore::ResourceRequestBase::isConditional):
(WebCore::ResourceRequestBase::makeUnconditional):
Simplify these.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Update for WebCore changes.

10:32 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
9:35 AM WebKitGTK/2.4.x edited by sergio@webkit.org
UA bug: replaced link for trunk by link for stable (diff)
9:12 AM Changeset in webkit [169936] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
​https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.

LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
​https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

  • platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
  • platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.
7:25 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com
point to the changesets rather than the bugs (diff)
6:33 AM Changeset in webkit [169935] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] GLContextEGL.cpp: conflicting declaration 'typedef ptrdiff_t GLintptr'
​https://bugs.webkit.org/show_bug.cgi?id=133550

Reviewed by Gustavo Noronha Silva.

Cairo includes some definitions from GLX that conflict with the
ones provided by our GLES2 headers (GLintptr, GLsizeiptr).

Since GLContextEGL doesn't use any GLX functions we can safely
disable the inclusion of those functions in that source file.

  • platform/graphics/egl/GLContextEGL.cpp:
6:09 AM Changeset in webkit [169934] by Manuel Rego Casasnovas
  • 12 edits
    2 adds in trunk/Source/WebCore

[CSS Grid Layout] Introduce an explicit type for resolved grid positions
​https://bugs.webkit.org/show_bug.cgi?id=131732

Reviewed by Sergio Villar Senin.

We were using simple size_t integers to represent resolved grid
positions in our internal data structures. This change allows us to
clarify the code, avoid potential off by one mistakes, and move the
resolving code to a central place.

A new class GridResolvedPosition has been created and the related
methods have been moved there from RenderGrid.
GridSpan is now defined by two GridResolvedPosition, so all the code
using it has been modified to adapt it to GridResolvedPosition.

No new tests as it is already covered by current tests
(fast/css-grid-layout/).

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGridTemplateAreasValue.cpp:

(WebCore::stringForPosition):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

  • css/StyleResolver.cpp:

(WebCore::createImplicitNamedGridLinesFromGridArea):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::explicitGridColumnCount): Deleted.
(WebCore::RenderGrid::explicitGridRowCount): Deleted.
(WebCore::isColumnSide): Deleted.
(WebCore::isStartSide): Deleted.
(WebCore::RenderGrid::explicitGridSizeForSide): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Deleted.
(WebCore::gridLinesForSide): Deleted.
(WebCore::implicitNamedGridLineForSide): Deleted.
(WebCore::isNonExistentNamedLineOrArea): Deleted.
(WebCore::RenderGrid::adjustGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::firstNamedGridLineBeforePosition): Deleted.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Deleted.

  • rendering/RenderGrid.h:
  • rendering/style/GridCoordinate.h:

(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):

  • rendering/style/GridPosition.h:

(WebCore::GridPosition::adjustGridPositionForRowEndColumnEndSide): Deleted.
(WebCore::GridPosition::adjustGridPositionForSide): Deleted.

  • rendering/style/GridResolvedPosition.cpp: Added.

(WebCore::isColumnSide):
(WebCore::isStartSide):
(WebCore::explicitGridSizeForSide):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::gridLinesForSide):
(WebCore::implicitNamedGridLineForSide):
(WebCore::isNonExistentNamedLineOrArea):
(WebCore::GridResolvedPosition::adjustGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):

  • rendering/style/GridResolvedPosition.h: Added.

(WebCore::GridResolvedPosition::adjustGridPositionForRowEndColumnEndSide):
(WebCore::GridResolvedPosition::adjustGridPositionForSide):
(WebCore::GridResolvedPosition::GridResolvedPosition):
(WebCore::GridResolvedPosition::operator++):
(WebCore::GridResolvedPosition::operator==):
(WebCore::GridResolvedPosition::operator<):
(WebCore::GridResolvedPosition::operator>):
(WebCore::GridResolvedPosition::operator<=):
(WebCore::GridResolvedPosition::operator>=):
(WebCore::GridResolvedPosition::toInt):
(WebCore::GridResolvedPosition::next):

5:58 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
4:53 AM WebKitGTK/2.4.x edited by sergio@webkit.org
added 133403 (diff)
3:16 AM Changeset in webkit [169933] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Change expectations for two failing layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=133805

Unreviewed EFL gradening.

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-06-13

  • platform/efl/TestExpectations:
  • platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
2:01 AM Changeset in webkit [169932] by calvaris@igalia.com
  • 2 edits in trunk/Tools

Create MSE and EME watchlist
​https://bugs.webkit.org/show_bug.cgi?id=133810

Reviewed by Eric Carlson.

  • Scripts/webkitpy/common/config/watchlist: Create MSEEME

definition and add Eric Carlson and myself to it.

Jun 12, 2014:

11:40 PM Changeset in webkit [169931] by Carlos Garcia Campos
  • 10 edits
    3 deletes in trunk

[GTK] Remove all deprecated API from GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=133728

Reviewed by Martin Robinson.

Source/WebCore:
Remove all deprecated symbols from the GObject DOM bindings,
keeping the deprecation infraestructure for future API breaks.

  • PlatformGTK.cmake: Remove WebKitDOMDeprecated files from the

build.

  • bindings/gobject/WebKitDOMDeprecated.cpp: Removed.
  • bindings/gobject/WebKitDOMDeprecated.h: Removed.
  • bindings/gobject/WebKitDOMDeprecated.symbols: Removed.
  • bindings/gobject/webkitdom.symbols: Updated to the current API.
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Remove exceptions for deprecated API.
(GetFunctionDeprecationInformation): Ditto.
(GetEffectiveFunctionName): Ditto.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event): Deleted.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols:
  • dom/Element.idl: Remove GObject exception.

Tools:

  • gtk/webkitdom.py:

(WebKitDOMDocGenerator): Remove all deleted classes from the list.
(WebKitDOMDocGeneratorSections.init): Fix a typo in member initialization.

9:56 PM Changeset in webkit [169930] by Simon Fraser
  • 2 edits in trunk/Source/JavaScriptCore

Fix assertions under JSC::setNeverInline() when running js tests in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=133840

Reviewed by Filip Pizlo.

Fix ASSERT(exec->vm().currentThreadIsHoldingAPILock()); under JSC::setNeverInline()
when running DFG tests.

  • API/JSCTestRunnerUtils.cpp:

(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):

9:20 PM Changeset in webkit [169929] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Do not update the viewport configuration on load until the first viewport arguments is received
​https://bugs.webkit.org/show_bug.cgi?id=133719
<rdar://problem/17008149>

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-06-12
Reviewed by Simon Fraser.

When pages are loaded from the page cache, we were updating the viewport to the initial values
in WebPage::dynamicViewportSizeUpdate(), then update the viewport again when the page's viewport argument
are received.

The problem is that was messing up with text autosizing. The page would relayout with the default viewport
configuration, adopt the text autosizing parameters from that size, then remain in that state when
the actual viewport configuration would be set.

With this patch, the viewport configuration is updated from the values in WebCore instead of with default values.
For new documents, this is strictly equivalent. For documents coming from the page cache, the values are from
the previous state of the page, which ensure we do not restart negotiating a viewport configuration from scratch.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

8:58 PM Changeset in webkit [169928] by Alan Bujtas
  • 17 edits in trunk

Subpixel rendering: Make <input type=> and <button> elements' decoration subpixel aware.
​https://bugs.webkit.org/show_bug.cgi?id=133812
<rdar://problem/17286309>

Reviewed by Simon Fraser.

Enable <input type=> and <button> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.

Source/WebCore:
Not testable.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::boundingBoxForQuads): Keep integral snapping for now.

  • platform/Theme.h:

(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm:

(WebCore::inflateRect):
(WebCore::configureToggleButton):
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
(WebCore::paintToggleButton):
(WebCore::setUpButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::paintStepper):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addVisualOverflowFromTheme): Keep integral snapping for now.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme): Keep integral snapping for now.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustRepaintRect):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):

LayoutTests:

  • platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt:
  • platform/mac/compositing/contents-opaque/control-layer-expected.txt:
6:53 PM Changeset in webkit [169927] by Brent Fulgham
  • 4 edits in trunk/Source

[Win] Avoid fork bomb during build
​https://bugs.webkit.org/show_bug.cgi?id=133837
<rdar://problem/17296034>

Reviewed by Tim Horton.

../JavaScriptCore:

reasonable default value when the 'num-cpus' script is not available.

../WebCore:

  • WebCore.vcxproj/build-generated-files.sh: Use a reasonable

default value when the 'num-cpus' script is not available.

6:49 PM Changeset in webkit [169926] by barraclough@apple.com
  • 13 edits in trunk/Source

Add support for thread/WorkQueue QoS
​https://bugs.webkit.org/show_bug.cgi?id=130688

Reviewed by Anders Carlson & Simon Fraser.

Source/WebCore:
WebCore's ScrollingThread should be UserInteractive.

  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::threadCallback):

  • ScrollingThread should be UserInteractive

Source/WebKit2:
The EventDispatcher's WorkQueue should be UserInteractive.

  • Platform/WorkQueue.cpp:

(WorkQueue::create):

  • pass QOS to constructor.

(WorkQueue::WorkQueue):

  • pass QOS to platformInitialize.
  • Platform/WorkQueue.h:
    • added enum, arguments.
  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::platformInitialize):

  • has extra argument.
  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::platformInitialize):

  • has extra argument.
  • Platform/mac/WorkQueueMac.cpp:

(platformQOS):

  • map from enum to platform type.

(WorkQueue::platformInitialize):

  • set the QoS of the dispatch queue.
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::EventDispatcher):

  • EventDispatcher's WorkQueue should be UserInteractive.
  • config.h:
    • added HAVE_QOS_CLASSES

Source/WTF:
Add the ability to mark threads as UserInteractive.

  • wtf/Threading.cpp:

(WTF::setCurrentThreadIsUserInteractive):

  • added method to set QoS of current thread to UserInteractive.
  • wtf/Threading.h:
    • added declaration.
5:55 PM Changeset in webkit [169925] by Simon Fraser
  • 2 edits in trunk/Tools

[iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
​https://bugs.webkit.org/show_bug.cgi?id=133835

Reviewed by Tim Horton.

Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(-[WebKitTestRunnerWindow initWithFrame:]):
(-[WebKitTestRunnerWindow setFrame:]):

5:55 PM Changeset in webkit [169924] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

[iOS] Tiny hack to fix WebKitTestRunner view visibility
​https://bugs.webkit.org/show_bug.cgi?id=133833

Reviewed by Tim Horton.

PageClientImplIOS in WebKitTestRunner has a null m_webView, so isViewInWindow
was returning false, which confused things.

Fix by falling back to a check on the content view if the m_webView is nil.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):

5:27 PM Changeset in webkit [169923] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Mac] Build fix after r169919.

  • WebCore.xcodeproj/project.pbxproj: The 'TileController.h' file must be a private header.
5:07 PM Changeset in webkit [169922] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Speculative build fix after r169921.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):

4:49 PM Changeset in webkit [169921] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] Stop observing the sample buffer renderers when destroying them.
​https://bugs.webkit.org/show_bug.cgi?id=133831

Reviewed by Beth Dakin.

Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):

4:30 PM Changeset in webkit [169920] by mark.lam@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Remove some dead / unused code.
<​https://webkit.org/b/133828>

Reviewed by Filip Pizlo.

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createBuiltinExecutable):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::create):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

  • parser/Parser.h:

(JSC::DepthManager::DepthManager): Deleted.
(JSC::DepthManager::~DepthManager): Deleted.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

4:10 PM Changeset in webkit [169919] by Brent Fulgham
  • 2 edits
    4 moves in trunk/Source/WebCore

Correct file locations after r169914. These should have been
in platform/graphics/ca.

Rubberstamped by Tim Horton.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.cpp.
  • platform/graphics/ca/TileController.h: Copied from platform/graphics/ca/mac/TileController.h.
  • platform/graphics/ca/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.cpp.
  • platform/graphics/ca/TileGrid.h: Copied from platform/graphics/ca/mac/TileGrid.h.
  • platform/graphics/ca/mac/TileController.cpp: Removed.
  • platform/graphics/ca/mac/TileController.h: Removed.
  • platform/graphics/ca/mac/TileGrid.cpp: Removed.
  • platform/graphics/ca/mac/TileGrid.h: Removed.
3:48 PM Changeset in webkit [169918] by Lucas Forschler
  • 2 edits in tags/Safari-538.40/Source/WebCore

Merged r169917.

3:44 PM Changeset in webkit [169917] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build after r169913.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

3:41 PM Changeset in webkit [169916] by bshafiei@apple.com
  • 3 edits in tags/Safari-538.40/Source/WebCore

Merged r169913. <rdar://problem/17032752>

3:36 PM Changeset in webkit [169915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Collect correct web timing data from CFNetwork.
​https://bugs.webkit.org/show_bug.cgi?id=133824
<rdar://problem/17273654>

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-06-12
Reviewed by Simon Fraser.

Covered by existing web timing tests.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData):
Use _kCFNTimingDataFetchStart as the reference start time key.

3:34 PM Changeset in webkit [169914] by Brent Fulgham
  • 5 edits
    2 moves in trunk/Source/WebCore

Convert TileController and TileGrid from ObjC to C++
​https://bugs.webkit.org/show_bug.cgi?id=133819
<rdar://problem/17291841>

Reviewed by Tim Horton.

Convert TileGrid.mm and TileController.mm into C++ implementations. This required creating a 'frameForLayer'
wrapper to call the 'frame' method of the CALayer object.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/mac/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.mm.

(WebCore::TileController::blankPixelCountForTiles):

  • platform/graphics/ca/mac/TileController.mm: Removed.
  • platform/graphics/ca/mac/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.mm.
  • platform/graphics/ca/mac/TileGrid.h:
  • platform/graphics/ca/mac/TileGrid.mm: Removed.
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:

(WebCore::frameForLayer): Wrapper function to hide ObjC call from C++ compilation unit.

3:24 PM Changeset in webkit [169913] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

[iOS WK2] Fix crash on back/foward swipe
​https://bugs.webkit.org/show_bug.cgi?id=133826
<rdar://problem/17032752>

Reviewed by Tim Horton.

AsyncScrollingCoordinator::frameViewForScrollingNode() would crash with a null root
state node, because HistoryController::restoreScrollPositionAndViewState() tried
to restore scroll position (via restoreViewState()) before hooking up the scrolling
coordinator.

Fix by doing the scrollingCoordinator->frameViewRootLayerDidChange() before
calling restoreViewState().

Also add a defensive null-check on the root state node in updateScrollPositionAfterAsyncScrollTimerFired().

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewForScrollingNode):

2:21 PM Changeset in webkit [169912] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

Add SPI for image controls and service controls preferences.
<rdar://problem/17292209> and ​https://bugs.webkit.org/show_bug.cgi?id=133820

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetServiceControlsEnabled):
(WKPreferencesGetServiceControlsEnabled):
(WKPreferencesSetImageControlsEnabled):
(WKPreferencesGetImageControlsEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
1:54 PM Changeset in webkit [169911] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add a space after the comma.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::add):

1:40 PM Changeset in webkit [169910] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Allow reading com.apple.universalaccess preferences
​https://bugs.webkit.org/show_bug.cgi?id=133817
<rdar://problem/17028261>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb.in:
1:34 PM Changeset in webkit [169909] by Brent Fulgham
  • 5 edits in trunk/Source/WebKit/win

[Win] Avoid crashes in code that converted CFDictionaries to HashMap
​https://bugs.webkit.org/show_bug.cgi?id=133813
<rdar://problem/17291647>

Reviewed by Tim Horton.

  • WebHistory.cpp: Add empty string checks to avoid crashes in

hash function.
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::itemForURL):
(WebHistory::removeItemForURLString):
(WebHistory::itemForURLString):

  • WebPreferences.cpp: Ditto.

(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):

  • WebView.cpp: Ditto. Also convert OwnPtr uses in this file

to std::unique_ptr.
(WebView::close):
(WebView::handleMouseEvent):
(WebView::registerEmbeddedViewMIMEType):
(WebView::shouldUseEmbeddedView):
(WebView::enterFullscreenForNode):
(WebView::fullScreenController):

  • WebView.h:
1:23 PM Changeset in webkit [169908] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
(CoreIPC::ArgumentCoder<ResourceRequest>::decode):

12:56 PM Changeset in webkit [169907] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-06-12

  • platform/gtk/TestExpectations: Report and mark new failures and

timeouts.

  • platform/gtk/fast/forms/placeholder-position-expected.txt:

Rebaseline test after r169780.

12:50 PM Changeset in webkit [169906] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Move header value merging to HTTPHeaderMap
​https://bugs.webkit.org/show_bug.cgi?id=133815

Reviewed by Andreas Kling.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):

  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::addHTTPHeaderField):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):

12:07 PM Changeset in webkit [169905] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a harmless error message when rewrite-availability-macros.sh is run in a clean build.

Rubber-stamped by Anders Carlsson.

  • mac/rewrite-availability-macros.sh:
11:50 AM Changeset in webkit [169904] by andersca@apple.com
  • 12 edits
    1 add in trunk/Source/WebCore

Add ShapeValue.cpp and move ShapeValue::isImageValid() there
​https://bugs.webkit.org/show_bug.cgi?id=133809

Reviewed by Antti Koivisto.

This gets rid of CachedImage.h (and ResourceRequest and friends) from RenderStyle.h.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue):

  • css/CSSCrossfadeValue.cpp:
  • css/CSSFilterImageValue.cpp:
  • css/StyleResolver.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

  • rendering/ShapeValue.cpp: Added.

(WebCore::ShapeValue::isImageValid):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::referenceBox):
(WebCore::ShapeOutsideInfo::computedShape):
(WebCore::ShapeOutsideInfo::isEnabledFor):

  • rendering/style/ShapeValue.h:

(WebCore::ShapeValue::type):
(WebCore::ShapeValue::setImage):
(WebCore::ShapeValue::ShapeValue):
(WebCore::ShapeValue::isImageValid): Deleted.

11:38 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
11:37 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
11:22 AM Changeset in webkit [169903] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Move structureHasRareData out of TypeInfo
​https://bugs.webkit.org/show_bug.cgi?id=133800

Reviewed by Andreas Kling.

StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.

  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::newImpurePropertyFiresWatchpoints):
(JSC::TypeInfo::structureHasRareData): Deleted.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::allocateRareData):
(JSC::Structure::cloneRareDataFrom):

  • runtime/Structure.h:

(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):

  • runtime/StructureInlines.h:

(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):

10:42 AM Changeset in webkit [169902] by fpizlo@apple.com
  • 9 edits
    6 adds in branches/ftlopt

[ftlopt] DFG get_by_id should inline chain accesses with a slightly polymorphic base
​https://bugs.webkit.org/show_bug.cgi?id=133751

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::appendVariant):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::attemptToMerge):

  • bytecode/GetByIdVariant.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):
(JSC::IntendedStructureChain::operator==):
(JSC::IntendedStructureChain::visitChildren):
(JSC::IntendedStructureChain::dumpInContext):
(JSC::IntendedStructureChain::chain): Deleted.

  • runtime/IntendedStructureChain.h:

(JSC::IntendedStructureChain::prototype):
(JSC::IntendedStructureChain::operator!=):
(JSC::IntendedStructureChain::head): Deleted.

LayoutTests:

  • js/regress/poly-chain-access-expected.txt: Added.
  • js/regress/poly-chain-access-simpler-expected.txt: Added.
  • js/regress/poly-chain-access-simpler.html: Added.
  • js/regress/poly-chain-access.html: Added.
  • js/regress/script-tests/poly-chain-access-simpler.js: Added.
  • js/regress/script-tests/poly-chain-access.js: Added.
10:33 AM Changeset in webkit [169901] by Lucas Forschler
  • 2 edits in tags/Safari-538.40/Source/WTF

Merged r169900.

9:35 AM Changeset in webkit [169900] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Fix Mac after r169880.

This revision added a C++ comment to Platform.h, which breaks sandbox profile
preprocessing.

Also, I do not believe that this comment was entirely accurate - we've always used
this technique with GCC, so there has to be more to it. So, I just removed the comment.

  • wtf/Platform.h:
9:13 AM Changeset in webkit [169899] by Brent Fulgham
  • 6 edits in branches/safari-537.60-branch/Source

Unreviewed build fix. (Merge r167685)

Source/JavaScriptCore:

  • DerivedSources.make: Specify path to Perl/Python to avoid

build failures under Python 2.7+.

Source/WebCore:

  • DerivedSources.make: Specify path to Perl/Python to avoid

build failures under Python 2.7+.

Source/WTF:

  • WTF.vcxproj/WTFGenerated.make: Specify path to Perl/Python

to avoid build failures under Python 2.7+.

7:53 AM Changeset in webkit [169898] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

Subpixel rendering: Make <select> element's decoration subpixel aware.
​https://bugs.webkit.org/show_bug.cgi?id=133781
<rdar://problem/17272083>

Reviewed by Simon Fraser.

Enable <select> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.

Not testable.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMenuList):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::inflateRect):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::progressBarRectForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::inflateRect): Deleted.

7:09 AM Changeset in webkit [169897] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] Crash in MediaSourcePrivateAVFObjC::naturalSize()
​https://bugs.webkit.org/show_bug.cgi?id=133789

Reviewed by Eric Carlson.

Add null-check to proctect against being queried for the naturalSize before we have a
m_mediaSourcePrivate.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):

7:07 AM Changeset in webkit [169896] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] fails to build with --disable-webgl --disable-accelerated-compositing
​https://bugs.webkit.org/show_bug.cgi?id=131267

Reviewed by Philippe Normand.

Add missing headers needed for Float32Array::create().

  • Modules/webaudio/AudioBuffer.cpp:
7:06 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
7:04 AM Changeset in webkit [169895] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

7:03 AM Changeset in webkit [169894] by Lucas Forschler
  • 1 copy in tags/Safari-538.40

New Tag.

6:25 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com
changed bug id to trac changset (diff)
5:53 AM Changeset in webkit [169893] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Performance tests should be always ran with WKTR.
​https://bugs.webkit.org/show_bug.cgi?id=133780

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-06-12
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init): Enable webkit_test_runner when port
is GTK.

5:47 AM Changeset in webkit [169892] by svillar@igalia.com
  • 4 edits in trunk

[GTK] REGRESSION: application name is not correctly appended to the UA
​https://bugs.webkit.org/show_bug.cgi?id=133793

Reviewed by Carlos Garcia Campos.

Source/WebCore:
We must use a blank to separate the default UA provided by WebKitGtk
from the application name coming from the public API.

Added an extra test case to the API tests to catch regressions.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

5:41 AM Changeset in webkit [169891] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

WorkerRunLoop::Task::performTask should take in WorkerGlobalScope* to avoid downcasting
​https://bugs.webkit.org/show_bug.cgi?id=133616

Reviewed by Andreas Kling.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::Task::performTask): Demand the context parameter to be a pointer
to WorkerGlobalScope instead of ScriptExecutionContext, avoiding an unnecessary downcast.
In the future this complete code path should use a reference to WorkerGlobalScope instead
of a pointer.

  • workers/WorkerRunLoop.h:
5:03 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
4:39 AM Changeset in webkit [169890] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Change expectations for three failing js/dom layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=133743

Unreviewed EFL gardening.

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-06-12

  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt:
3:10 AM Changeset in webkit [169889] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/Source/JavaScriptCore

Allow enum guards to be generated from the replay json files
​https://bugs.webkit.org/show_bug.cgi?id=133399

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-06-12
Reviewed by Csaba Osztrogonác.

  • replay/scripts/CodeGeneratorReplayInputs.py:

(Type.init):
(InputsModel.parse_type_with_framework_name):
(Generator.generate_header):
(Generator.generate_implementation):

  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp: Added.

(Test::HandleWheelEvent::HandleWheelEvent):
(Test::HandleWheelEvent::~HandleWheelEvent):
(JSC::InputTraits<Test::HandleWheelEvent>::type):
(JSC::InputTraits<Test::HandleWheelEvent>::encode):
(JSC::InputTraits<Test::HandleWheelEvent>::decode):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::encodeValue):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::decodeValue):

  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h: Added.

(JSC::InputTraits<Test::HandleWheelEvent>::queue):
(Test::HandleWheelEvent::platformEvent):

  • replay/scripts/tests/generate-enum-with-guard.json: Added.
2:41 AM Changeset in webkit [169888] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Change expectations for three failing layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=133738

Unreviewed EFL layout tests gardening.

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-06-12

  • platform/efl/TestExpectations:
2:25 AM Changeset in webkit [169887] by svillar@igalia.com
  • 4 edits in trunk

[GTK] Unsupported browser in www.icloud.com
​https://bugs.webkit.org/show_bug.cgi?id=133403

Reviewed by Martin Robinson.

Source/WebCore:
We claim to be Safari (among others) to ensure maximum
compatibility with existing web sites. Valid Safari UA strings do
always (since Safari 3.0) contain the string "Version/X" before
the "Safari/X" part. We were wrongly only adding it in very
specific cases and we were placing it at the wrong position as it
must precede the "Safari/X" part.

From now on we unconditionally prepend the "Version/X" string to
the "Safari/X" part as we always claim to be Safari. This makes
the NeedsSafariVersion6 quirk invalid. This not only fixes
"unsupported browser" issues in icloud.com, but also in
globalforestwatch.com and live.com among many others.

Apart from that I'm bumping the Safari Version in the UA to 8.0 as
we're already claiming to be "Safari/538.35"" which corresponds to
Safari 8 beta.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::buildUserAgentString):
(WebCore::standardUserAgentForURL):

Tools:

  • TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
quirk that was removed.

1:50 AM Changeset in webkit [169886] by Carlos Garcia Campos
  • 13 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix GTK+ build after r169823.

Include StructureInlines.h in a few more files to fix linking
issues due to JSC::Structure::get undefined symbol.

  • runtime/ArrayIteratorConstructor.cpp:
  • runtime/ArrayIteratorPrototype.cpp:
  • runtime/JSConsole.cpp:
  • runtime/JSMapIterator.cpp:
  • runtime/JSSet.cpp:
  • runtime/JSSetIterator.cpp:
  • runtime/JSWeakMap.cpp:
  • runtime/MapIteratorPrototype.cpp:
  • runtime/MapPrototype.cpp:
  • runtime/SetIteratorPrototype.cpp:
  • runtime/SetPrototype.cpp:
  • runtime/WeakMapPrototype.cpp:
1:01 AM Changeset in webkit [169885] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] One more URTBF after r169823 to make ARM64 build happy too.

  • runtime/JSMap.cpp:
12:37 AM Changeset in webkit [169884] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Remove view mode API
​https://bugs.webkit.org/show_bug.cgi?id=133725

Reviewed by Martin Robinson.

It currently does nothing because support for view source mode was
removed from WebCore.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_set_view_mode): Deleted.
(webkit_web_view_get_view_mode): Deleted.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
12:25 AM Changeset in webkit [169883] by psolanki@apple.com
  • 5 edits in trunk/Source

Avoid creating a CFData when checking if a resource is file backed
​https://bugs.webkit.org/show_bug.cgi?id=133783

Reviewed by Andreas Kling.

Source/WebCore:
Export SharedBuffer::hasPlatformData().

No new tests because no functional changes.

  • WebCore.exp.in:
  • platform/SharedBuffer.h:

Source/WebKit2:
When a resource is file backed, we have it as a single CFDataRef in SharedBuffer. Add an
early return in tryGetShareableHandleFromSharedBuffer() so we don't end up creating a new
CFDataRef if we don't already have one in SharedBuffer. If we had to create a CFDataRef, the
it can't have been a file backed resource.

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

Note: See TracTimeline for information about the timeline view.