Timeline
Aug 2, 2014:
- 5:03 PM Changeset in webkit [171973] by
-
- 12 edits in trunk/Source
Support both window and view based video fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=135525
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-08-02
Reviewed by Simon Fraser.
Source/WebCore:
Presenting in a separate window gives greater flexibility for rotation separately from the app.
Presenting in the same window works better if the interface is rehosted in another process.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:]): Use clientRect instead of screenRect.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add m_window and m_parentView.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer setBounds:]): Parent view might not be fullscreen; use window instead.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Conditionally create UIWindow and UIViewController for fullscreen.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Video, not the container should have black background.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Conditionally translate finalRect.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): Clean up UIWindow and force status bar to correct orientation.
(WebVideoFullscreenInterfaceAVKit::invalidate): Clean up UIWindow.
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): Hide window and exit without animation.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setVideoFullscreenLayer): Apply frame, because it may have been set before the layer.
Source/WebKit/mac:
Parenting in the view instead of the window gives the fullscreen implementation more latitude
in how it implements the animation.
- WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:]): Use view instead of window.
Source/WebKit2:
Parenting in the view instead of the window gives the fullscreen implementation more latitude
in how it implements the animation.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Use view instead of window.
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::clientRectForNode): Use client rect instead of screen rect.
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): ditto
(WebKit::WebVideoFullscreenManager::exitFullscreenForNode): ditto
(WebKit::screenRectForNode): Deleted.
- 1:51 PM Changeset in webkit [171972] by
-
- 8 edits in trunk/Source/WebCore
Update the SearchFieldResultsButtonElement shadow Pseudo Id when HTMLInputElement's maxResults change
https://bugs.webkit.org/show_bug.cgi?id=135491
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-02
Reviewed by Ryosuke Niwa.
Replace the shadowPseudoId() override + manual style invalidation by the generic pseudo ID update.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/InputType.cpp:
(WebCore::InputType::maxResultsAttributeChanged):
- html/InputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::updateResultButtonPseudoType):
(WebCore::SearchInputType::maxResultsAttributeChanged):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):
- html/SearchInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId): Deleted.
- html/shadow/TextControlInnerElements.h:
- 1:47 PM Changeset in webkit [171971] by
-
- 3 edits in trunk/Source/WebCore
Add warnings for the buggy implementations of shadowPseudoId()
https://bugs.webkit.org/show_bug.cgi?id=135477
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-02
Reviewed by Ryosuke Niwa.
Dean is going to look into fixing media element styling.
In the meantime, add warnings to prevent this from spreading.
- dom/Element.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
- 11:35 AM Changeset in webkit [171970] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[Win] Unreviewed build fix.
- src/libGLESv2/renderer/d3d11/BufferStorage11.cpp:
(rx::BufferStorage11::copyData): Help compiler make
decision about types.
- 11:04 AM Changeset in webkit [171969] by
-
- 5 edits in trunk/Tools
build-webkittestrunner doesn't build the app target for iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=135433
Reviewed by Dan Bernstein.
- Scripts/build-dumprendertree: Build the app target on iOS.
- Scripts/build-webkittestrunner: Build the app target on iOS.
- Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
(buildXCodeProject):
- Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
(IOSSimulatorPort._build_driver_flags):
- 11:03 AM Changeset in webkit [171968] by
-
- 2 edits1 delete in trunk/Tools
Remove iOS Perl DumpRenderTree support target
https://bugs.webkit.org/show_bug.cgi?id=135271
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
- DumpRenderTree/ios/PerlSupport/Makefile: Removed.
- 11:01 AM Changeset in webkit [171967] by
-
- 1 edit1 delete in trunk/Tools
Remove old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=135374
Reviewed by Csaba Osztrogonác.
- Scripts/old-run-webkit-tests: Removed.
- 10:34 AM Changeset in webkit [171966] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
https://bugs.webkit.org/show_bug.cgi?id=135542
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
findChangeLogs.
(findChangeLogs): Don’t require a ChangeLog file to exist if unless the
requireChangeLogToExist argument is true.
Aug 1, 2014:
- 11:06 PM Changeset in webkit [171965] by
-
- 4 edits in trunk/Source
<rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
https://bugs.webkit.org/show_bug.cgi?id=135536
Reviewed by Tim Horton.
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
OTHER_LDFLAGS_iphoneos.
Source/WebKit2:
- Configurations/WebKit.xcconfig: Removed -lassertion_extension and -framework MobileAsset
from FRAMEWORK_AND_LIBRARY_LDFLAGS_iphonesimulator.
- 10:10 PM Changeset in webkit [171964] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r171957.
https://bugs.webkit.org/show_bug.cgi?id=135538
Caused GTK assertions and test failures (Requested by smfr on
#webkit).
Reverted changeset:
"Clean up image subsampling code, make it less iOS-specific"
https://bugs.webkit.org/show_bug.cgi?id=134916
http://trac.webkit.org/changeset/171957
- 9:13 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:00 PM Changeset in webkit [171963] by
-
- 3 edits2 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures and flaky tests after 171341, r171591, r171567 and others.
- platform/gtk/fast/css/viewport-units-dynamic-expected.txt: Added. Rebaseline after r171567.
- platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Added. Rebaseline after r171609.
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Rebaseline after 171341.
- 5:46 PM Changeset in webkit [171962] by
-
- 2 edits in trunk/Source
[CMake] Allow CMake to find GLib on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=132530
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-08-01
Reviewed by Gustavo Noronha Silva.
On FreeBSD, glibconfig.h is at /usr/local/include/glib-2.0/glibconfig.h.
- Source/cmake/FindGLIB.cmake:
- 5:10 PM Changeset in webkit [171961] by
-
- 4 edits in trunk/Source
REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
https://bugs.webkit.org/show_bug.cgi?id=135522
Reviewed by Martin Robinson.
Source/JavaScriptCore:
- CMakeLists.txt: Output the inspector headers inside inspector
subdirectory.
Source/WebCore:
No new tests required, no new functionality.
- CMakeLists.txt: Add missing include to the inspector headers
and fix the path to InspectorJSTypeBuilders.h
- 5:00 PM Changeset in webkit [171960] by
-
- 2 edits in trunk/Source/WebCore
Fix resource leak in FillLayersPropertyWrapper object member
https://bugs.webkit.org/show_bug.cgi?id=135462
Reviewed by Andreas Kling.
Fix leak of m_fillLayerPropertyWrapper by using unique_ptr<>.
Based on patch by Przemyslaw Kuczynski.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
- 4:57 PM Changeset in webkit [171959] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Add extension read permission to network sandbox profile
<rdar://problem/17671574>
Reviewed by Alexey Proskuryakov and Oliver Hunt.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 4:55 PM Changeset in webkit [171958] by
-
- 2 edits in trunk/LayoutTests
Unreviewed post-review test fixup
- editing/pasteboard/img-srcset-copy-paste-canonicalization.html:
- 4:22 PM Changeset in webkit [171957] by
-
- 20 edits in trunk/Source/WebCore
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916
Reviewed by Dean Jackson.
Compile the image subsampling code on both Mac and iOS, and make it more platform
neutral in general. Add a setting to allow it to be enabled on Mac for testing.
The most significant changes are in ImageSourceCG and BitmapImageCG. CG's ImageSource
is no longer stateful with respect to subsampling; its functions take a SubsamplingLevel
when appropriate. CG's BitmapImage now determines which level of subsampling to use
for a given frame, storing the subsampling level in the frame data. It can replace
an aggressively subsampled frame with a less subsampled frame if necessary.
To reduce the chances of subsampling affecting rendering, BitmapImage::size() now
always returns the non-subsampled size; subsampling is strictly internal to BitmapImage.
BitmapImage::draw() takes care of scaling the srcRect for subsampled images.
iOS had a code path that enabled caching of frame metadata in BitmapImage without
actually decoding the frame; make this cross-platform.
- WebCore.exp.in: Changed signature for GraphicsContext::drawNativeImage().
- WebCore.xcodeproj/project.pbxproj: Added ImageSource.cpp, which is not built
for Cocoa but useful for reference.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer): Remove iOS-specific subsampling code.
(WebCore::CachedImage::createImage): Call setAllowSubsampling() on the image if we
can get to Settings (m_loader is null for image documents).
(WebCore::CachedImage::currentFrameKnownToBeOpaque): This forced decode always
caused creation of the non-subsampled image, so remove it. There's no reason to
eagerly decode the frame here.
- loader/cache/CachedImage.h: Fix comment.
- page/Settings.cpp: Add defaultImageSubsamplingEnabled, true for iOS and false for Mac.
- page/Settings.in: Added imageSubsamplingEnabled.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Init some more things. Default m_allowSubsampling to
true for iOS to catch images created in code paths where we can't get to Settings.
(WebCore::BitmapImage::haveFrameAtIndex): Handy helper.
(WebCore::BitmapImage::cacheFrame): Now takes the subsampling level and whether to cache
just metadata, or also the frame.
(WebCore::BitmapImage::didDecodeProperties): No need to store originalSize.
(WebCore::BitmapImage::updateSize): When we get the size for the first time, call
determineMinimumSubsamplingLevel() to choose a reasonable subsampling level which takes
platform-specific limits into account.
(WebCore::BitmapImage::dataChanged): Comment.
(WebCore::BitmapImage::ensureFrameIsCached): Take ImageFrameCaching into account.
(WebCore::BitmapImage::frameAtIndex): Choose a subsampling level given the scale,
then determine if we can use the currently cached frame, or whether we should resample.
(WebCore::BitmapImage::frameIsCompleteAtIndex): Caching m_isComplete is now done when caching
frame metadata.
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex): The 'true' return is the safe return value.
(WebCore::BitmapImage::frameOrientationAtIndex): Caching m_orientation is now done when caching
frame metadata.
(WebCore::BitmapImage::cacheFrameInfo): Deleted.
(WebCore::BitmapImage::originalSize): Deleted.
(WebCore::BitmapImage::originalSizeRespectingOrientation): Deleted.
(WebCore::BitmapImage::currentFrameSize): Deleted.
(WebCore::BitmapImage::ensureFrameInfoIsCached): Deleted.
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/GraphicsContext.h: No need to pass a scale param now.
- platform/graphics/ImageSource.cpp: Non-Cocoa changes.
(WebCore::ImageSource::subsamplingLevelForScale):
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex):
(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
- platform/graphics/ImageSource.h: No longer stores subsampling state.
(WebCore::ImageSource::isSubsampled): Deleted.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage): Init more members.
(WebCore::BitmapImage::determineMinimumSubsamplingLevel): Choose a minimum subsampling
level for the platform (subsample until the image area falls under a threshold).
(WebCore::BitmapImage::checkForSolidColor): Don't bother decoding frames if the image
is not 1x1. Also take care not to decode a non-subsampled image.
(WebCore::BitmapImage::draw): The actual bug fix is here; remove logic that
computed srcRectForCurrentFrame from m_size and m_originalSize; for some callers
srcRect was computed using the pre-subsampled size, and for others it was the subsampled size.
Instead, scale srcRect by mapping between the non-subsampled size, and the size of the CGImageRef
which is affected by subsampling.
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Remove #ifdeffed code.
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): No more weird scaling!
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::createImageSourceOptions): Helper that always returns a new CFDictionaryRef.
(WebCore::imageSourceOptions): If not subsampling, return the cached CFDictionaryRef, otherwise
make a new options dict and return it.
(WebCore::ImageSource::subsamplingLevelForScale): Helper that returns a subsampling level
between 0 and 3 given a scale.
(WebCore::ImageSource::isSizeAvailable): SkipMetadata is a default value for the param now.
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex): We turn off subsampling for progressive
JPEGs because of a bug, so need this to know if a frame should be subsampled.
(WebCore::ImageSource::frameSizeAtIndex): The looping to find a subsampling level is now in BitmapImageCG.
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::size): Always use a subsampling level of 0 for size().
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex): The caller mapped a scale to a level.
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::imageSourceOptions): Deleted.
(WebCore::ImageSource::originalSize): Deleted.
- platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::invalidatePlatformData): 0 -> nullptr
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- 4:20 PM Changeset in webkit [171956] by
-
- 7 edits in trunk/Source/WebCore
Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.
<https://webkit.org/b/135519>
Don't set this structure flag unless the object actually has an override
for getOwnPropertySlotByIndex().
Reviewed by Geoffrey Garen.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- 4:14 PM Changeset in webkit [171955] by
-
- 3 edits in trunk/Source/WebCore
SVG Font kerning can take an early out if the font has no kerning information
https://bugs.webkit.org/show_bug.cgi?id=135524
Reviewed by Dean Jackson.
Rather than calling SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs() again
and again, skip the iteration entirely if every call would return 0.
No new tests because there is no behavior change.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
- svg/SVGFontElement.h:
- 4:10 PM Changeset in webkit [171954] by
-
- 3 edits in trunk/Tools
commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=135527
Reviewed by Tim Horton.
- Scripts/commit-log-editor:
In the case of a git repository when there are no changed ChangeLog files, changed to pass
the --delimiters option to prepare-ChangeLog, then process each entry in the output using
commitMessageFromChangeLogEntry.
(commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
(sortKey): Factored out from createCommitMessage.
(createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
subroutines.
- Scripts/prepare-ChangeLog:
(main): Parse new --delimiters option.
(generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
the label before each change log entry, and a "~" delimiter on a new line after each entry.
- 3:49 PM Changeset in webkit [171953] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add some structure related assertions.
<https://webkit.org/b/135523>
Reviewed by Geoffrey Garen.
Adding 2 assertions:
- assert that we don't index pass the end of the StructureIDTable. This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in.
- assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID. This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
- runtime/StructureIDTable.h:
(JSC::StructureIDTable::get):
- 3:47 PM Changeset in webkit [171952] by
-
- 2 edits in trunk/Source/WebCore
Inspector highlights clipped at the bottom on the page in WK1 views with
contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480
-and corresponding-
<rdar://problem/17850323>
Forgot to commit this one very critical part with
http://trac.webkit.org/changeset/171951
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
- 3:39 PM Changeset in webkit [171951] by
-
- 7 edits in trunk/Source/WebCore
Inspector highlights clipped at the bottom on the page in WK1 views with
contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480
-and corresponding-
<rdar://problem/17850323>
Reviewed by Simon Fraser.
unscaledTotalVisibleContentSize() was the main function on Mac that was expected
to return the rect representing ALL visible content, including content that might
be in an inset area and obscured by UI elements. This patch re-names that function
to unscaledVisibleContentSizeIncludingObscuredArea(), and that patch makes that
function return the right thing in the platformWidget() case.
Re-name.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
Return platformVisibleContentSizeIncludingObscuredArea() for the platformWidget()
case and re-name.
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
This was just wrong. It was returning the big rectangle instead of the small one
for platformWidget().
(WebCore::ScrollView::unscaledUnobscuredVisibleContentSize):
New platform functions.
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
(WebCore::ScrollView::unscaledTotalVisibleContentSize): Deleted.
- platform/ScrollView.h:
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
Re-name.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootLayer):
- 3:33 PM Changeset in webkit [171950] by
-
- 2 edits in trunk/Source/WebCore
SVGGlyph wastes space due to padding
https://bugs.webkit.org/show_bug.cgi?id=135520
Reviewed by Dean Jackson.
Rearrange members in SVGGlyph so there is no wasted padding space.
No new tests because there is no behavior change.
- platform/graphics/SVGGlyph.h:
(WebCore::SVGGlyph::SVGGlyph):
- 1:58 PM Changeset in webkit [171949] by
-
- 2 edits in trunk/Source/JavaScriptCore
URTBF after r171946 to fix non-Apple builds.
- bytecode/InlineCallFrameSet.cpp:
- 1:46 PM Changeset in webkit [171948] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r171891): platform/mac/fast/scrolling/scroll-select-bottom-test.html
failing
https://bugs.webkit.org/show_bug.cgi?id=135485
Now that WK1 really tests contentInset, this test no longer works on platforms
that do not support the real contentInset
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 1:43 PM Changeset in webkit [171947] by
-
- 8 edits in trunk
[Feature Queries] Enable Feature Queries on EFL/GTK
https://bugs.webkit.org/show_bug.cgi?id=134902
Reviewed by Benjamin Poulain.
.:
Enable CSS Feature Queries by default on the EFL and GTK
platforms.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Tools:
Turn the feature on by default for the build script.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Resume running the CSS Feature Query tests on the EFL and GTK platforms.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 1:17 PM Changeset in webkit [171946] by
-
- 5 edits in trunk/Source/JavaScriptCore
CodeBlock fails to visit the Executables of its InlineCallFrames
https://bugs.webkit.org/show_bug.cgi?id=135471
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2014-08-01
Reviewed by Geoffrey Garen.
CodeBlock needs to visit its InlineCallFrames' owner Executables. If it doesn't, they
can be prematurely collected and cause crashes.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::visitAggregate):
- bytecode/InlineCallFrameSet.cpp:
(JSC::InlineCallFrameSet::visitAggregate):
- bytecode/InlineCallFrameSet.h:
- 1:01 PM Changeset in webkit [171945] by
-
- 3 edits in trunk/Tools
Build fix for 32-bit after r171926.
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
- 12:42 PM Changeset in webkit [171944] by
-
- 2 edits in trunk/Source/WebCore
[Media iOS] Ensure there is a nice default fallback for missing wireless target names
https://bugs.webkit.org/show_bug.cgi?id=135488
<rdar://problem/17879156>
Reviewed by Eric Carlson.
We occasionally run into cases where this.host.externalDeviceDisplayName
is empty or null, creating a pretty ugly/confusing string in the
wireless playback status screen.
If this happens, we should default to using "Apple TV".
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Check if the externalDeviceDisplayName
is empty or null, and fall back to "Apple TV" if so.
- 12:19 PM Changeset in webkit [171943] by
-
- 9 edits in trunk/Source/WebKit2
Various frameworks may want to use the container temp directory, so our current restrictions are too tight
https://bugs.webkit.org/show_bug.cgi?id=135518
<rdar://17869279>
Reviewed by Anders Carlsson.
We don't (and can't) have complete knowledge of what different frameworks
will want to use the container temporary directory for, and so our
current attempt to heavily restrict access is simply too tight.
This patch recognises this by simply giving read-write access to the
entire NSTemporary() directory (e.g. $container/tmp in the general case),
rather than the single sub directory we wishfully thought that we would
be able to get away with.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::mediaCacheDirectory): Deleted.
- UIProcess/WebContext.h:
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 12:19 PM Changeset in webkit [171942] by
-
- 11 edits2 adds in trunk
Progress towards cmake on Windows.
https://bugs.webkit.org/show_bug.cgi?id=135484
Reviewed by Martin Robinson.
.:
- CMakeLists.txt:
Added Mac to list of ports, even though it is not done yet.
Changed minimum bison version to version installed on Macs.
- Source/cmake/OptionsAppleWin.cmake:
Added some definitions.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Set WTF_LIBRARY_TYPE to STATIC to not change WTF linking on EFL or GTK ports.
- Source/cmake/OptionsMac.cmake: Added blank for now.
- Source/cmake/OptionsWinCairo.cmake:
- Source/cmake/OptionsWindows.cmake:
Added some definitions.
Removed /WX (warnings treated as error while compiling).
Copied warnings to ignore from WebKitLibraries/win/tools/vsprops/common.props.
Source/JavaScriptCore:
- CMakeLists.txt:
Generate code directly to inspector directory to avoid using the cp command
which is not available on Windows.
- PlatformWin.cmake: Added.
Source/WTF:
- wtf/CMakeLists.txt:
Added WTF_LIBRARY_TYPE because Windows needs WTF to be a shared library.
- 12:08 PM Changeset in webkit [171941] by
-
- 9 edits3 adds in trunk
URLs in srcset attributes are not made absolute upon copy and paste
https://bugs.webkit.org/show_bug.cgi?id=135448
Reviewed by Ryosuke Niwa.
Source/WebCore:
When pasting, canonicalize URLs in srcset the same way we do with src.
Test: editing/pasteboard/img-srcset-copy-paste-canonicalization.html
- dom/Element.cpp:
(WebCore::Element::completeURLsInAttributeValue): Initial implemention, moved from markup.cpp.
- dom/Element.h:
(WebCore::Element::attributeContainsURL): New function for completeURLs to call.
(WebCore::Element::completeURLsInAttributeValue): Only called if attributeContainsURL returns
true. Default implementation simply calls isURLAttribute().
- editing/markup.cpp:
(WebCore::completeURLs): Call attributeContainsURL() and completeURLsInAttributeValue() to
complete the URL, so nodes can perform their own behavior.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attributeContainsURL): Return true for srcset.
(WebCore::HTMLImageElement::completeUrlAttributeValue): Use our existing srcset parser to
parse the srcset attribute, then use its output to canonicalize URLs, and build it back up
into a string.
- html/HTMLImageElement.h:
(WebCore::HTMLImageElement::attributeContainsURL):
(WebCore::HTMLImageElement::completeUrlAttributeValue):
- html/parser/HTMLSrcsetParser.cpp: Make parseImageCandidatesFromSrcsetAttribute() public
and change its signature to return its result.
(WebCore::parseImageCandidatesFromSrcsetAttribute):
- html/parser/HTMLSrcsetParser.h: Ditto.
LayoutTests:
Copy and paste a srcset image with relative URLs, and make sure that the
pasted srcset attribute doesn't match what it was before. I can't actually
dump the new srcset because it will include a full path of the file on the
user's system, and would therefore be machine-specific.
- editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt:
- editing/pasteboard/img-srcset-copy-paste-canonicalization.html: Paste and check.
- editing/pasteboard/resources/img-srcset-copy-paste-canonicalization-iframe.html:
This has to be an iframe because we don't perform any url canonicalization if we
are copying and pasting from a document into itself.
- 12:06 PM Changeset in webkit [171940] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline header height doesn't match style updates.
https://bugs.webkit.org/show_bug.cgi?id=135516
Reviewed by Timothy Hatcher.
Update the timeline header height to match the updates
to the navigation bars in other panels made in
https://bugs.webkit.org/show_bug.cgi?id=135445. Also
update the shadows on some of the search bars.
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):
- UserInterface/Views/FindBanner.css:
(.find-banner > input[type="search"]):
(body.mac-platform.legacy .find-banner > input[type="search"]):
- UserInterface/Views/LogContentView.css:
(.search-bar.log-search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]):
Remove inset shadows on search bars.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder):
Update the height of the timeline status bar.
- 11:57 AM Changeset in webkit [171939] by
-
- 87 edits in trunk/Source
Remove the JSC::OverridesVisitChildren flag.
<https://webkit.org/b/135489>
Source/JavaScriptCore:
Except for 3 special classes, the visitChildren() call is always
dispatched through the method table (see SlotVisitor.cpp.)
The OverridesVisitChildren flag doesn't actually do anything.
It could be used to implement a non-virtual direct call to
JSCell::visitChildren, bypassing the method table for some objects,
but such a micro-optimization seems like a weak trade for all this
code complexity. Instead, just remove the flag.
This change frees up an inline flag bit in JSCell.
Reviewed by Geoffrey Garen.
- API/JSAPIWrapperObject.h:
- API/JSAPIWrapperObject.mm:
(JSC::JSAPIWrapperObject::visitChildren):
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedCodeBlock::visitChildren):
(JSC::UnlinkedProgramCodeBlock::visitChildren):
- bytecode/UnlinkedCodeBlock.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::visitChildren):
- debugger/DebuggerScope.h:
- jsc.cpp:
- runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
- runtime/Arguments.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
- runtime/Executable.h:
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
- runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::visitChildren):
- runtime/JSArrayIterator.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildren):
- runtime/JSBoundFunction.h:
- runtime/JSCellInlines.h:
(JSC::JSCell::setStructure):
- runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
- runtime/JSMap.h:
- runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::visitChildren):
- runtime/JSMapIterator.h:
- runtime/JSNameScope.cpp:
(JSC::JSNameScope::visitChildren):
- runtime/JSNameScope.h:
- runtime/JSPromise.cpp:
(JSC::JSPromise::visitChildren):
- runtime/JSPromise.h:
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::visitChildren):
- runtime/JSPromiseDeferred.h:
- runtime/JSPromiseReaction.cpp:
(JSC::JSPromiseReaction::visitChildren):
- runtime/JSPromiseReaction.h:
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
- runtime/JSPropertyNameIterator.h:
- runtime/JSProxy.cpp:
(JSC::JSProxy::visitChildren):
- runtime/JSProxy.h:
- runtime/JSScope.cpp:
(JSC::JSScope::visitChildren):
- runtime/JSScope.h:
- runtime/JSSegmentedVariableObject.cpp:
(JSC::JSSegmentedVariableObject::visitChildren):
- runtime/JSSegmentedVariableObject.h:
- runtime/JSSet.h:
- runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::visitChildren):
- runtime/JSSetIterator.h:
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::visitChildren):
- runtime/JSSymbolTableObject.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesVisitChildren): Deleted.
- runtime/JSWeakMap.h:
- runtime/JSWithScope.cpp:
(JSC::JSWithScope::visitChildren):
- runtime/JSWithScope.h:
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
- runtime/JSWrapperObject.h:
- runtime/MapData.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
- runtime/NativeErrorConstructor.h:
- runtime/PropertyMapHashTable.h:
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::visitChildren):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::visitChildren):
- runtime/RegExpConstructor.h:
- runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::visitChildren):
- runtime/RegExpMatchesArray.h:
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h:
- runtime/SparseArrayValueMap.h:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::visitChildren):
- runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
- runtime/StructureChain.h:
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h:
- runtime/WeakMapData.h:
Source/WebCore:
Tweak the bindings code generator to stop spitting out the flag.
Reviewed by Geoffrey Garen.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- 11:54 AM Changeset in webkit [171938] by
-
- 1 delete in tags/Safari-600.1.2.5/Safari-600.1.2.4
Remove extraneous tag.
- 11:53 AM Changeset in webkit [171937] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Volume is not remembered between items in a YouTube playlist
https://bugs.webkit.org/show_bug.cgi?id=135479
Reviewed by Eric Carlson.
When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted
properties with the current values from the HTMLMediaElement.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
- 11:50 AM Changeset in webkit [171936] by
-
- 3 edits1 copy in tags/Safari-600.1.2.5
Merge r171903. <rdar://problem/17877481>
- 11:44 AM Changeset in webkit [171935] by
-
- 4 edits in trunk/Tools
Confusing build fix after r171926.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
- MiniBrowser/mac/SettingsController.m:
- 11:33 AM Changeset in webkit [171934] by
-
- 2 edits in tags/Safari-600.1.4.3/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:32 AM Changeset in webkit [171933] by
-
- 2 edits in tags/Safari-600.1.4.3/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:30 AM Changeset in webkit [171932] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after r171891
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
- 11:29 AM Changeset in webkit [171931] by
-
- 15 edits in trunk/Source/WebCore
Remove EventNames.h include from header files
https://bugs.webkit.org/show_bug.cgi?id=135486
Reviewed by Alexey Proskuryakov.
No new tests because no functional changes.
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
- Modules/gamepad/GamepadEvent.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediastream/RTCStatsResponse.h:
- Modules/websockets/WebSocket.h:
- css/FontLoader.h:
- dom/SecurityPolicyViolationEvent.h:
- loader/appcache/DOMApplicationCache.h:
- workers/AbstractWorker.h:
- workers/Worker.h:
- workers/WorkerGlobalScope.h:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEvent.h:
- 11:28 AM Changeset in webkit [171930] by
-
- 5 edits in tags/Safari-600.1.4.3/Source
Versioning.
- 11:26 AM Changeset in webkit [171929] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:22 AM Changeset in webkit [171928] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/17862013> REGRESSION (r169357): Disabling "allow plug-ins" doesn't stick on quit/relaunch
https://bugs.webkit.org/show_bug.cgi?id=135511
Reviewed by Alexey Proskuryakov.
Since the values map in the preferences store doesn’t include values that are equal to the
defaults, we need to update it when a new default is registered.
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::createWithLegacyDefaults): Changed to use new member functions
for registering defaults.
(WebKit::WebPreferences::registerDefaultBoolValueForKey): Added. Sets an override default
in the store, and sets the user default, if there is one, on top of it.
(WebKit::WebPreferences::registerDefaultUInt32ValueForKey): Ditto.
- UIProcess/WebPreferences.h: Declared new member functions for getting the user default
value for a key.
- UIProcess/efl/WebPreferencesEfl.cpp:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Added an implementation that
returns false, because the EFL port doesn’t support persistent user defaults.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Ditto for the GTK port.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Added. Replaces
setStringValueIfInUserDefaults, on which it is based.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Similarly for booleans.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Similarly for integers.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Similarly for doubles.
(WebKit::WebPreferences::platformInitializeStore): Changed to use the above functions.
- 11:21 AM Changeset in webkit [171927] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:21 AM Changeset in webkit [171926] by
-
- 8 edits2 adds in trunk/Tools
Make it easer to add switches to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=135499
Reviewed by Simon Fraser.
Add a single class to manage a set of persistent, global settings for MiniBrowser.
Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
Add SettingsController.{m, h}.
- MiniBrowser/mac/AppDelegate.h:
Move _browserWindowControllers to the implementation.
Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
of that; instead, we'll receive didChangeSettings.
- MiniBrowser/mac/AppDelegate.m:
Move the default URL, default URL preference key, and use-WebKit2-by-default
preference key into SettingsController.
(-[BrowserAppDelegate awakeFromNib]):
Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
(-[BrowserAppDelegate newWindow:]):
Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
SettingsController now takes care of reading the default URL preference.
WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
(-[BrowserAppDelegate didChangeSettings]):
When settings change, update the key equivalents for the new-window menu items, as they
might have changed (as use-WebKit2-by-default is one of the settings).
Dispatch settings change notifications to all live BrowserControllers.
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
(-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
(-[BrowserAppDelegate validateMenuItem:]): Deleted.
All menu item validation for settings is moved into SettingsController.
- MiniBrowser/mac/BrowserWindowController.h:
Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
- MiniBrowser/mac/MainMenu.xib:
Remove the settings menu items from the "Debug" menu.
- MiniBrowser/mac/SettingsController.h: Added.
- MiniBrowser/mac/SettingsController.m: Added.
(+[SettingsController shared]):
(-[SettingsController menu]):
(-[SettingsController _addItemWithTitle:action:indented:]):
(-[SettingsController _addHeaderWithTitle:]):
NSMenuItem-creating helpers.
(-[SettingsController _populateMenu]):
Build the menu. Ideally this and the validation step would eventually be made more dynamic.
(-[SettingsController validateMenuItem:]):
Validate menu items; since they can be used to toggle the default state of a setting,
we'll always return YES. However, we will use this opportunity to set the 'checked' state
of each item.
(-[SettingsController _toggleBooleanDefault:]):
Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
(-[SettingsController toggleUseWebKit2ByDefault:]):
(-[SettingsController useWebKit2ByDefault]):
(-[SettingsController toggleUseTransparentWindows:]):
(-[SettingsController useTransparentWindows]):
(-[SettingsController toggleUsePaginatedMode:]):
(-[SettingsController usePaginatedMode]):
(-[SettingsController toggleUseUISideCompositing:]):
(-[SettingsController useUISideCompositing]):
(-[SettingsController toggleShowLayerBorders:]):
(-[SettingsController layerBordersVisible]):
(-[SettingsController toggleShowTiledScrollingIndicator:]):
(-[SettingsController tiledScrollingIndicatorVisible]):
(-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
(-[SettingsController subPixelCSSOMMetricsEnabled]):
(-[SettingsController defaultURL]):
Toggle or return the current state of each preference.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController didChangeSettings]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
(-[WK1BrowserWindowController isPaginated]): Deleted.
(-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
(-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
(-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
(-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
(-[WK1BrowserWindowController layerBordersVisible]): Deleted.
(-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController forceRepaint:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController didChangeSettings]):
(-[WK2BrowserWindowController isPaginated]): Deleted.
(-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
(-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
(-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
(-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
(-[WK2BrowserWindowController layerBordersVisible]): Deleted.
(-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
(-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
(-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
- 11:20 AM Changeset in webkit [171925] by
-
- 2 edits in trunk/Source/WebCore
nullptr goodness in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=135512
Reviewed by Brent Fulgham.
Use nullptr in RenderLayer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects):
- 11:19 AM Changeset in webkit [171924] by
-
- 3 edits in trunk/Tools
MiniBrowser doesn't support data URLs
https://bugs.webkit.org/show_bug.cgi?id=135492
Reviewed by Simon Fraser.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController addProtocolIfNecessary:]):
Don't add http:// to data: URLs.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
Percent-escape the contents of the address field before trying to make a URL.
Percent-unescape the URL when displaying it in the address field.
This is not great, but trivial and good-enough-for-Minibrowser.
- 11:16 AM Changeset in webkit [171923] by
-
- 2 edits in trunk/Source/WebCore
Build fix for iOS
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
We use CGImageRef instead of NSImage here on iOS.
- 11:13 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:46 AM Changeset in webkit [171922] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 10:44 AM Changeset in webkit [171921] by
-
- 1 copy in tags/Safari-600.1.4.3
New Tag.
- 10:38 AM Changeset in webkit [171920] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Fullscreen mode for some applications shows only a black screen.
https://bugs.webkit.org/show_bug.cgi?id=135493
<rdar://problem/17628212>
Reviewed by Jer Noble.
In some applications, the window hosting the WKView is an InProcess layer hosting mode.
The fullscreen window created by the WKFullScreenWindowController defaults to an
OutOfProcess mode.
When this kind of mismatch is encountered, the WK2 layer in the UI process is supposed
to send a message back to the WebProcess indicating that the layer hosting mode of the
containing window is different, so that the WebProcess can adjust its logic accordingly.
Unfortunately, the notification that this had happened was not getting sent to the
WebProcess due to an optimization in window state change logic (see Bug 135509 for
details).
The fix is to check layer hosting mode state when a WKView is added to a window, and
notify the WebProcess when it needs to change state to match.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): When moving to a new window, always call
'layerHostingModeDidChange' to pick up any changes in the layer hosting mode.
- 10:32 AM Changeset in webkit [171919] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171895. <rdar://problem/17835345>
- 10:02 AM Changeset in webkit [171918] by
-
- 1 copy in tags/Safari-600.1.2.5/Safari-600.1.2.4
New Tag.
- 9:15 AM Changeset in webkit [171917] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=134970
Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-01
Reviewed by Zalan Bujtas.
Removed an unnecessary assert, because the null return value of enclosingList() is
handled properly after this assert.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateListMarkerNumbers):
- 6:42 AM Changeset in webkit [171916] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests. Remove flaky test expectations that are
no longer correct.
- platform/efl/TestExpectations:
- platform/efl/fast/text/khmer-lao-font-expected.txt: Update expected result.
- svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Update after r171046.
- 6:34 AM Changeset in webkit [171915] by
-
- 7 edits in trunk
[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
https://bugs.webkit.org/show_bug.cgi?id=135501
Reviewed by Gyuyoung Kim.
Use PROJECT_VERSION_MICRO instead.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitHelpers.cmake:
Source/WebKit2:
- UIProcess/API/efl/EWebKit2.h.in:
- UIProcess/API/gtk/WebKitVersion.h.in:
- 3:48 AM Changeset in webkit [171914] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Add missing sections to documentation.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitUserContent and WebKitUserContentManager sections to the
documentation.
- 2:59 AM Changeset in webkit [171913] by
-
- 1 copy in releases/WebKitGTK/webkit-2.5.1
WebKitGTK+ 2.5.1
- 1:14 AM Changeset in webkit [171912] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Update test expectations for crashing webgl tests.
- platform/efl/TestExpectations:
- 12:26 AM Changeset in webkit [171911] by
-
- 2 edits in trunk/Source/WebCore
Replace DEPRECATED_DEFINE_STATIC_LOCAL with NeverDestroyed<T> in NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=135494
Reviewed by Andrei Bucur.
Use static NeverDestroyed<T> variables instead of the DEPRECATED_DEFINE_STATIC_LOCAL macro.
No new tests, no behavior changes.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::customHandlersStateString):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
- 12:24 AM Changeset in webkit [171910] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unable to do make install since r171901
https://bugs.webkit.org/show_bug.cgi?id=135497
Reviewed by Gyuyoung Kim.
- PlatformEfl.cmake: Removed ewk_defins.h from the installation list.
Jul 31, 2014:
- 10:02 PM EFLWebKit edited by
- (diff)
- 10:00 PM Changeset in webkit [171909] by
-
- 2 edits in trunk
[EFL] Bump ewebkit version to 1.11
https://bugs.webkit.org/show_bug.cgi?id=135487
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsEfl.cmake: Bump version numbers.
- 9:07 PM Changeset in webkit [171908] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
https://bugs.webkit.org/show_bug.cgi?id=135490
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.stopCapturing):
Immediately stop the recording without waiting for an event from the backend.
This makes the Web Inspector UI feel responsive to the user stopping the recording.
This also matches behavior before r171195.
- 8:42 PM Changeset in webkit [171907] by
-
- 6 edits in trunk/Source/WebCore
Remove shadowPseudoId() override from the shadow media controls
https://bugs.webkit.org/show_bug.cgi?id=135474
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-31
Reviewed by Eric Carlson.
Small cleanup.
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlPanelVolumeSliderElement::MediaControlPanelVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlPanelElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsTrackListElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Deleted.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls):
(WebCore::MediaControls::shadowPseudoId): Deleted.
- html/shadow/MediaControls.h:
- 7:20 PM Changeset in webkit [171906] by
-
- 4 edits in trunk
[EFL][WK2] MiniBrower comes to crash when combo box is pressed
https://bugs.webkit.org/show_bug.cgi?id=135378
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Added doxygen comment of popup_menu_show/popup_menu_hide not to confuse the usage.
- UIProcess/API/efl/ewk_view.h:
Tools:
"clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
and removes Ewk_Popup_Menu instance.
- MiniBrowser/efl/main.c:
(on_popup_menu_show):
(on_popup_menu_discarded): Deleted.
- 6:26 PM Changeset in webkit [171905] by
-
- 2 edits in trunk/Source/WebCore
Build fix for platforms where we should have automaticallyAdjustsContentInsets but it isn't public yet
- platform/mac/ScrollViewMac.mm:
- 6:26 PM Changeset in webkit [171904] by
-
- 4 edits in trunk
[EFL] Add support for building with Geoclue2.
https://bugs.webkit.org/show_bug.cgi?id=135455
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsEfl.cmake: Add gio-unix if ENABLE_GEOLOCATION
is set.
Source/WebCore:
No new tests required, no new functionality.
- PlatformEfl.cmake: Generate derived sources for Geoclue2Interface
and include gio-unix path.
- 6:15 PM Changeset in webkit [171903] by
-
- 3 edits1 add in trunk
[Win] Use RC_PROJECTBUILDVERSION as build portion of version
https://bugs.webkit.org/show_bug.cgi?id=135478
Reviewed by David Kilzer.
Tools:
Add new test suite for the version-stamp program.
- Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
WebKitLibraries:
- win/tools/scripts/version-stamp.pl: Check environment for
RC_PROJECTBUILDVERSION, and use it for the build portion of
the file version resource. Otherwise, use the VERSION_BUILD
value we calculated from the version string.
- 6:01 PM Changeset in webkit [171902] by
-
- 3 edits in trunk/Tools
Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
which loads HTTPS content without calling the delegate.
Rubber-stamped by Alexey Proskuryakov.
- WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
- 5:53 PM Changeset in webkit [171901] by
-
- 3 edits1 delete in trunk/Source/WebKit2
[EFL] remove ewk_defines.h
https://bugs.webkit.org/show_bug.cgi?id=135456
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/ewk_context_menu.h:
- UIProcess/API/efl/ewk_context_menu_item.h: Moved the declaration from ewk_defines.h
- UIProcess/API/efl/ewk_defines.h: Removed.
- 5:50 PM Changeset in webkit [171900] by
-
- 2 edits in trunk/Tools
Unreviewed typo correction (and build fix).
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]): Use correct
property name (_fullScreenIsEnabled -> _fullScreenEnabled)
- 5:39 PM Changeset in webkit [171899] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed typo correction.
https://bugs.webkit.org/show_bug.cgi?id=135482
Rename '_fullScreenIsEnabled' -> '_fullScreenEnabled'
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _fullScreenEnabled]): Added
(-[WKPreferences _fullScreenIsEnabled]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 5:26 PM Changeset in webkit [171898] by
-
- 2 edits in trunk/LayoutTests
platform/mac/fast/scrolling/scroll-select-bottom-test.html failing on Mavericks
(after 171891?)
https://bugs.webkit.org/show_bug.cgi?id=135485
Skipping this test for now to allow some time to investigate the failure.
- platform/mac/TestExpectations:
- 5:15 PM Changeset in webkit [171897] by
-
- 5 edits in trunk
MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
https://bugs.webkit.org/show_bug.cgi?id=135482
Reviewed by Simon Fraser.
Source/WebKit2:
Add accessors for the missing Fullscreen API so that MiniBrowser
can use them.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _fullScreenIsEnabled]): Added.
(-[WKPreferences _setFullScreenEnabled:]): Added.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for
Fullscreen mode.
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
feature.
- 4:55 PM Changeset in webkit [171896] by
-
- 5 edits in trunk/Source/WebCore
Subpixel rendering: Region painting needs to take subpixel accumulation into account.
https://bugs.webkit.org/show_bug.cgi?id=135469
Similar to non-region painting, when the context is translated, we need to propagate
the subpixel difference so that renderers get snapped to the same position as if they
were not part of a region.
Reviewed by Simon Fraser.
Covered by existing tests/not testable (webkit.org/b/135470)
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- 4:52 PM Changeset in webkit [171895] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Video in an <embed> has a bad aspect ratio when in fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=135481
Reviewed by Simon Fraser.
Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity
is controlled by setVideoFullscreenGravity(), and should not be affected by style changes.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
- 4:17 PM Changeset in webkit [171894] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline recording is not working inspecting iOS 7 and earlier
https://bugs.webkit.org/show_bug.cgi?id=135466
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.
Start / stop capturing for older backends that won't emit start / stop events.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Agent.prototype.hasEvent):
Provide a way to check if an event is supported.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.stopCapturing):
Fallback to starting and stopping capturing manually if the backend
does not provide the events.
- 3:56 PM Changeset in webkit [171893] by
-
- 3 edits in trunk/Tools
[Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
https://bugs.webkit.org/show_bug.cgi?id=135472
Reviewed by Dan Bernstein.
We now handle server trust challenges, and don't need such hacks.
- WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
- 3:45 PM Changeset in webkit [171892] by
-
- 1 edit1 add in trunk/LayoutTests
Test failure fix. I accidentally removed this file that is still used by another
test in the directory.
- platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Added.
- 3:32 PM Changeset in webkit [171891] by
-
- 15 edits5 moves1 add in trunk
Hit-testing broken in WebKit 1 views with AppKit's contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135434
-and corresponding-
<rdar://problem/17850323>
Reviewed by Benjamin Poulain.
Source/WebCore:
AppKit's contentInsets are factored into scroll positions and mouse positions, but
in WebCore, we generally want all of those things to be factored out so that, for
example, the scroll position of a document pinned to the top is the same whether
or not there is a contentInset. So to fix hit-testing in WebKit 1 views with
contentInsets, this patch factors the inset out or into of all coordinate
conversion methods just like we do for the WebKit2 contentInset.
This patch also adds the ability to test WK1 platformContentInsets with
window.internals, and it re-names convertFromRenderer to
convertFromRendererToContainingView and also re-names convertToRenderer to
convertFromContainingViewToRenderer.
ScrollView::topContentInset() takes an optional parameter indicating whether the
caller wants the WebCore::Page contentInset or the platform content inset. It’s
necessary to distinguish between these cases because there is a lot of code that
only wants the WebCore::Page contentInset since that feature is actually
implemented in WebCore as opposed to being implemented at the platform level.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::topContentInset):
For layout test purposes, set the platforTopContentInset here if there is a
platformWidget().
(WebCore::FrameView::topContentInsetDidChange):
Re-named functions, also all coordinate conversion functions call
topContentInset(ManualOrPlatformContentInset)
(WebCore::FrameView::convertFromContainingViewToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::convertFromRenderer): Deleted.
(WebCore::FrameView::convertToRenderer): Deleted.
- page/FrameView.h:
- page/Page.cpp:
(WebCore::Page::setTopContentInset):
- platform/ScrollView.cpp:
(WebCore::ScrollView::documentScrollOffsetRelativeToViewOrigin):
(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin):
(WebCore::ScrollView::contentsToRootView):
(WebCore::ScrollView::rootViewToTotalContents):
(WebCore::ScrollView::contentsToWindow):
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
- platform/ScrollView.h:
(WebCore::ScrollView::topContentInset):
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
Implement new platform inset-related functions using AppKit's implementation.
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
When we set the scroll position for the documentView, we have to factor the inset
back into the WebCore scroll position.
(WebCore::ScrollView::platformSetScrollPosition):
Re-named functions.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertFromScrollbarToContainingView):
(WebCore::RenderLayer::convertFromContainingViewToScrollbar):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):
Source/WebKit2:
Re-named functions.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::convertFromScrollbarToContainingView):
(WebKit::PDFPlugin::convertFromContainingViewToScrollbar):
LayoutTests:
These hit-testing related contentInset tests will now work for mac on wk1 on
Yosemite and wk2.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html: Removed.
- platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html: Removed.
- platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Removed.
- platform/mac/fast/events/content-inset-hit-testing-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt.
- platform/mac/fast/events/content-inset-hit-testing-in-frame-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt.
- platform/mac/fast/events/content-inset-hit-testing-in-frame.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html.
- platform/mac/fast/events/content-inset-hit-testing.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html.
- platform/mac/fast/events/resources: Added.
- platform/mac/fast/events/resources/iframe-to-hit-test.html: Copied from platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html.
- 3:07 PM Changeset in webkit [171890] by
-
- 6 edits in trunk/Source/WebCore
Default buttons do not pulse in OS X 10.10
https://bugs.webkit.org/show_bug.cgi?id=135447
<rdar://problem/17875896>
Reviewed by Dan Bernstein.
OS X Yosemite does not have the animated pulsing default
buttons seen in previous releases. We don't need to have
a timer in RenderButton constantly triggering repaints.
- platform/mac/ThemeMac.mm:
(WebCore::paintButton): No need to advance the animation.
- rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange): Ask the theme if it
should advance the animation.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::defaultButtonHasAnimation): Virtual function
indicating if the button needs to repaint.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::defaultButtonHasAnimation): Provide platform
specific result on Yosemite and above.
- 3:06 PM Changeset in webkit [171889] by
-
- 2 edits in trunk/Source/WebCore
DOM::renderedImageForcingBlackText returns an image with the wrong logical size on 2x displays
https://bugs.webkit.org/show_bug.cgi?id=135442
<rdar://problem/17614632>
Reviewed by Simon Fraser.
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Scale the NSImage size by the device scale factor,
similar to what we did for drag images in r167403.
Ideally this scaling would happen in the code that
generates the images, but this is a much larger change
with much more regression potential.
- 2:56 PM Changeset in webkit [171888] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSCell::classInfo() belongs in JSCellInlines.h.
<https://webkit.org/b/135475>
Reviewed by Mark Hahnenberg.
- runtime/JSCellInlines.h:
(JSC::JSCell::classInfo):
- runtime/JSDestructibleObject.h:
(JSC::JSCell::classInfo): Deleted.
- 2:48 PM Changeset in webkit [171887] by
-
- 2 edits in trunk/Source/WebKit2
Various SSO services need the networking process to be able to spoof its bundle id
https://bugs.webkit.org/show_bug.cgi?id=135468
<rdar://problem/17864139>
Reviewed by Alexey Proskuryakov.
Just add the entitlement required to allow the sandbox to let this happen.
- Configurations/Network-iOS.entitlements:
- 2:38 PM Changeset in webkit [171886] by
-
- 18 edits in trunk
[CSS Font Loading] Rename document.fontloader to document.fonts
https://bugs.webkit.org/show_bug.cgi?id=135393
Reviewed by Bem Jones-Bey.
Source/WebCore:
The most recent version of the specification has renamed
document.fontloader to document.fonts. This change updates the
names in WebCore and LayoutTests.
Fixed up existing tests under LayoutTests/fast/css/fontloader-*
and LayoutTests/http/webfont/fontloader-*
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::notifyFontLoader):
(WebCore::CSSFontFace::notifyLoadingDone):
- dom/Document.cpp:
(WebCore::Document::fonts):
(WebCore::Document::fontloader): Deleted.
- dom/Document.h:
- dom/Document.idl:
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
LayoutTests:
Update tests to use the new document.fonts name.
- fast/css/fontloader-download-error.html:
- fast/css/fontloader-events.html:
- fast/css/fontloader-loadingdone.html:
- fast/css/fontloader-multiple-faces-download-error-expected.txt:
- fast/css/fontloader-multiple-faces-download-error.html:
- fast/css/fontloader-multiple-faces-expected.txt:
- fast/css/fontloader-multiple-faces.html:
- fast/css/fontloader-multiple-families-expected.txt:
- fast/css/fontloader-multiple-families.html:
- http/tests/webfont/fontloader-loading-attribute-expected.txt:
- http/tests/webfont/fontloader-loading-attribute.html:
- 2:00 PM Changeset in webkit [171885] by
-
- 15 edits in trunk/Source/WebInspectorUI
Web Inspector: Sync button look and feel with Xcode updates.
https://bugs.webkit.org/show_bug.cgi?id=135445
Reviewed by Timothy Hatcher.
Update styles to match recent changes to Xcode text-only
buttons, the navigation bar, and search fields. Include
older style rules for older Mac platforms.
- UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.text-only):
(body.mac-platform.legacy .navigation-bar .item.button.text-only):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .navigation-bar):
(.sidebar > .panel.details.css-style > .content):
(body.mac-platform.legacy .sidebar > .panel.details.css-style > .content):
- UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content):
- UserInterface/Views/DividerNavigationItem.css:
(.navigation-bar .item.divider):
(body.mac-platform.legacy .navigation-bar .item.divider):
- UserInterface/Views/FilterBar.css:
(.filter-bar):
(body.mac-platform.legacy .filter-bar):
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):
- UserInterface/Views/LogContentView.css:
(.search-bar.log-search-bar > input[type="search"]):
(@media reader):
(.log-search-bar > input): Deleted.
- UserInterface/Views/Main.css:
(#split-content-browser > .navigation-bar):
(body.mac-platform.legacy #split-content-browser > .navigation-bar):
- UserInterface/Views/NavigationBar.css:
(.navigation-bar):
(body.mac-platform.legacy .navigation-bar):
(.navigation-bar .item):
(body.mac-platform.legacy .navigation-bar .item):
- UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation > .content):
- UserInterface/Views/QuickConsole.css:
(.quick-console):
(body.mac-platform.legacy .quick-console):
- UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only:hover):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover):
(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):
(.navigation-bar .item.radio.button.text-only:active):
(.navigation-bar .item.radio.button.text-only.selected:active):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active):
- UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
- UserInterface/Views/ScopeBar.css:
(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li:hover):
(body.mac-platform.legacy .scope-bar > li:hover):
(.scope-bar > li.selected):
(.scope-bar > li:active):
(body.mac-platform.legacy .scope-bar > li:active):
(.scope-bar > li.selected:active):
(body.mac-platform.legacy .scope-bar > li.selected:active):
- UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):
Update styles and apply older styles to legacy Mac platforms.
- 1:22 PM Changeset in webkit [171884] by
-
- 7 copies in branches/safari-537.78-branch/LayoutTests
Merge in missing LayoutTests from merge of r169475 -> r171377.
- 1:19 PM Changeset in webkit [171883] by
-
- 2 edits in branches/safari-600.1-branch/WebKitLibraries
Merge r171870. <rdar://problem/17872507>
- 12:50 PM Changeset in webkit [171882] by
-
- 4 edits2 adds in trunk
REGRESSION: Search highlight is broken in RTL multicolumn content
https://bugs.webkit.org/show_bug.cgi?id=135452
Reviewed by Simon Fraser.
Source/WebCore:
The offsets for elements inside RTL multi-column elements are incorrectly computed because
the columns don't calculate their left position according to the writing direction.
The patch extracts the column position computation in two helper functions (for top and left)
so they can be used when needed in different parts of the code. In our case, the |columnLogicalLeft|
function should be used inside |columnTranslationForOffset|.
Test: fast/multicol/content-bounding-box-rtl.html
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnLogicalLeft): Return the logical left of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnLogicalTop): Return the logical top of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnRectAt): Split the code between columnLogicalLeft and columnLogicalTop.
(WebCore::RenderMultiColumnSet::collectLayerFragments): Make code clearer by adding a new line.
(WebCore::RenderMultiColumnSet::columnTranslationForOffset): Use columnLogicalLeft instead of duplicating logic.
- rendering/RenderMultiColumnSet.h:
LayoutTests:
A test that verifies the bounding boxes for content inside a RTL multi-column element are correctly computed:
- for static elements
- for relative positioned elements
- for absolutely positioned elements
- fast/multicol/content-bounding-box-rtl-expected.txt: Added.
- fast/multicol/content-bounding-box-rtl.html: Added.
- 12:47 PM Changeset in webkit [171881] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: MessageDispatcher should not synchronously dispatch all backend messages
https://bugs.webkit.org/show_bug.cgi?id=135427
Reviewed by Timothy Hatcher.
The frontend dispatches all queued messages from the backend synchronously, even if there are
hundreds of messages, or even if some of the messages take a long time (>10ms) to process.
This patch adds a time limit to the frontend's message dispatcher. If the time limit is exceeded
when processing the message queue, unhandled messages remain in the queue and the dispatcher goes
to sleep until the next run loop (obtained by a new setTimeout).
This has the effect of removing stutters when the message queue has hundreds of small messages.
The outliers are still the same since some single messages can take over 200ms to be handled.
This patch also improves performance logging in InspectorBackend so that it is easier to see
message handling times and their distribution among run loop turns.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass): Add a new diagnostic flag that warns about slow message handling.
(InspectorBackendClass.prototype._dispatchCallback.get if): Improve logging.
(InspectorBackendClass.prototype._dispatchCallback): Improve logging.
(InspectorBackendClass.prototype._dispatchEvent): Improve logging.
- UserInterface/Protocol/MessageDispatcher.js:
(WebInspector.dispatchNextQueuedMessageFromBackend): Keep track of a time limit for message
dispatching, and set a new timeout if we exceed the time limit.
- 12:21 PM Changeset in webkit [171880] by
-
- 4 edits in trunk/Tools
media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
https://bugs.webkit.org/show_bug.cgi?id=135418
Reviewed by Anders Carlsson.
This was only happening in shared web process mode, because WKBundlePostMessage
has different behavior then. When there is no process, the message is dropped on
the floor in multiple process mode, but it's stored to be delivered after launch
in shared process mode.
So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
that was delivered immediately after launch, when there was nothing to reset.
We don't actually need to reset anything at this point, as the previous call has
already reset everything UI process side, and web process is brand new. All we need
is to reattach the page to a process, as invoke() expects one to exist.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
- 12:21 PM Changeset in webkit [171879] by
-
- 5 edits in tags/Safari-600.1.4.2/Source
Merge r171866. <rdar://problem/17872676>
- 12:17 PM Changeset in webkit [171878] by
-
- 2 edits in tags/Safari-600.1.2.5/WebKitLibraries
Merge r171870. <rdar://problem/17872507>
- 12:17 PM Changeset in webkit [171877] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Merge r171866. <rdar://problem/17872676>
- 12:13 PM Changeset in webkit [171876] by
-
- 5 edits in tags/Safari-600.1.2.5/Source
Versioning.
- 12:08 PM Changeset in webkit [171875] by
-
- 1 copy in tags/Safari-600.1.2.5
New Tag.
- 12:03 PM Changeset in webkit [171874] by
-
- 1 copy in tags/Safari-600.1.4.2
New Tag.
- 11:59 AM Changeset in webkit [171873] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merge r171829. <rdar://problem/17824833>
- 11:53 AM Changeset in webkit [171872] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171851. <rdar://problem/17719026>
- 11:20 AM Changeset in webkit [171871] by
-
- 7 edits in trunk/Source/WebCore
Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength
https://bugs.webkit.org/show_bug.cgi?id=135377
Reviewed by Darin Adler.
The FractionConversion argument in CSSPrimitiveValue::convertToLength
doesn't seem to actually have a purpose. It is for converting numbers
into Length(x * 100, Percent), but this case shouldn't be reachable.
The original patch introducing it doesn't shed any light either:
[https://bugs.webkit.org/show_bug.cgi?id=74913
This patch removes the now unused FractionConversion argument. Note
that we can probably also merge the two Fixed conversions, as the
two only differ in clamping large numbers (probably unintended).
No new tests.
- css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
- css/CSSParser.cpp:
(WebCore::parseTransformTranslateArguments):
(WebCore::parseTranslateTransformValue):
(WebCore::parseTransformArguments): Deleted.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):
- css/TransformFunctions.cpp:
(WebCore::convertToFloatLength):
- 11:00 AM Changeset in webkit [171870] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Fix build failure when using 5-tuple build versions.
https://bugs.webkit.org/show_bug.cgi?id=135464
<rdar://problem/17872507>
Reviewed by David Kilzer.
- win/tools/scripts/version-stamp.pl: Modify the environment for
the VersionStamper sub-process to work around bug in that tool.
- 10:42 AM Changeset in webkit [171869] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Right edge of Timeline Record button does not work
https://bugs.webkit.org/show_bug.cgi?id=135444
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.
When hovering the record button we would show the status text, however
because the left edge of the status text box would overlap the right
edge of the record button causing completely unexpected behavior.
Position the status text correctly so that it never overlaps the record
button. 5px to match the left margin of the record button, and another
2px for some padding between the button and text.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
- 10:40 AM Changeset in webkit [171868] by
-
- 2 edits in trunk/Source/WebKit2
Fix uninitialized scalar variable
https://bugs.webkit.org/show_bug.cgi?id=135461
Patch by Przemyslaw Kuczynski <p.kuczynski@samsung.com> on 2014-07-31
Reviewed by Alexey Proskuryakov.
If fopen fails, returned ApplicationMemoryStats structure will be uninitialized
- Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::sampleMemoryAllocatedForApplication): Initialized applicationStats.
- 10:37 AM Changeset in webkit [171867] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
https://bugs.webkit.org/show_bug.cgi?id=135414
Patch by Tanay C <tanay.c@samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::putToScopeCommon):removed unused parameter from function definition
- 10:34 AM Changeset in webkit [171866] by
-
- 6 edits in trunk/Source
Web Inspector: console.profile missing profile information
https://bugs.webkit.org/show_bug.cgi?id=135432
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.
Source/WebCore:
By switching console.profile to start/stop the timeline we would
not have a chance to recompile JS functions with profiling information.
This used to work because whenever the inspector was open we would
have profiling information enabled. Go back to that behavior.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::profilerEnabled):
Instead of checking if the timeline agent has started, check if the
timeline agent has been created. Going back to the normal behavior
of always having profiling information when the inspector is open.
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
Recompile initializing the timeline agent to include profiling information.
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
Recompile destrying the timeline agent, only if needed.
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
Using a boolean to track nested calls would not give expected
behavior when un-nesting. Switch to a counter to ensure that
as we start profiling in the outermost level we then stop
profiling at that same level and not inside an inner nesting.
Source/WebInspectorUI:
- UserInterface/Models/ScriptTimelineRecord.js:
Delete the payload information as soon as it has been processed.
It is no longer needed anymore and can be garbage collected.
- 10:24 AM Changeset in webkit [171865] by
-
- 9 edits in trunk/LayoutTests
[CSS Font Loading] Test expectations should show success
https://bugs.webkit.org/show_bug.cgi?id=135420
Reviewed by Bem Jones-Bey.
Modify the expected files to represent success, and skip
the tests until the feature is enabled.
- TestExpectations: Skip the tests.
- fast/css/fontloader-download-error-expected.txt:
- fast/css/fontloader-events-expected.txt:
- fast/css/fontloader-loadingdone-expected.txt:
- fast/css/fontloader-multiple-faces-download-error-expected.txt:
- fast/css/fontloader-multiple-faces-expected.txt:
- fast/css/fontloader-multiple-families-expected.txt:
- http/tests/webfont/fontloader-loading-attribute-expected.txt:
- 10:20 AM Changeset in webkit [171864] by
-
- 7 edits in tags/Safari-600.1.3.3/Source
Roll out r171647. <rdar://problem/17315168>
- 10:18 AM Changeset in webkit [171863] by
-
- 5 edits9 deletes in tags/Safari-600.1.3.3
Roll out r171661. <rdar://problem/17315237>
- 10:16 AM Changeset in webkit [171862] by
-
- 6 edits in trunk/Source/WebCore
Refactor EventHandler to call ScrollAnimator::handleWheelEvent for overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=135195
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-07-31
Reviewed by Beth Dakin.
ScrollableArea::handleWheelEvent is not currently being used to handle wheel events for overflow scrolling; it instead directly invokes ScrollableArea::scroll.
In order to expose wheel phases on Mac, the PlatformWheelEvent itself should propagate down to ScrollableArea, not just the scroll granularity, direction and
multiplier required by ScrollableArea::scroll. With this patch, PlatformWheelEvent will be "shipped" along with the WheelEvent.
No new tests, since behavior should not have changed.
- page/EventHandler.cpp:
(WebCore::didScrollInScrollableAreaForSingleAxis): Calls ScrollableArea::scroll directly using WheelEvent's data. Used to handle programmatic WheelEvents, e.g. from JavaScript.
(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): Finds the correct ScrollableArea and attempts to scroll it using the information contained in the WheelEvent via ScrollableArea::handleWheelEvent
(WebCore::EventHandler::defaultWheelEventHandler): Updated to use handleWheelEventInAppropriateEnclosingBoxForSingleAxis instead of scrollNode.
(WebCore::scrollNode): Deleted.
- rendering/RenderListBox.h: Made RenderListBox::scroll public so it can be invoked from EventHandler::handleWheelEventInAppropriateEnclosingBoxForSingleAxis.
- rendering/RenderNamedFlowThread.cpp: Refactored to let EventHandler update nextScrollBlock in the case of isRenderNamedFlowThread().
(WebCore::RenderNamedFlowThread::fragmentFromRenderBoxAsRenderBlock):
- rendering/RenderNamedFlowThread.h:
- 10:15 AM Changeset in webkit [171861] by
-
- 2 edits in trunk/Source/WebKit2
Clean up the WebKit build from unused parameter warning in Webkit2/WebProcess module
https://bugs.webkit.org/show_bug.cgi?id=135413
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-07-31
Reviewed by Darin Adler.
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):
- 10:11 AM Changeset in webkit [171860] by
-
- 7 edits in trunk/Source/WebKit2
AX: iOS: Crash accessing m_page in WKAccessibilityPageObject
https://bugs.webkit.org/show_bug.cgi?id=134617
Reviewed by Darin Adler.
Provide a way to detach a WK2 WebPage object so that it can uninitialize other pointers, like the accessibility object.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::platformDetach):
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformDetach):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformDetach):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformDetach):
- 9:45 AM Changeset in webkit [171859] by
-
- 4 edits in trunk
[WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
https://bugs.webkit.org/show_bug.cgi?id=115282
Reviewed by Sam Weinig.
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
local host server trust protection space.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
credential to server trust challenges.
LayoutTests:
- platform/mac-wk2/TestExpectations: Removed the exceptions listed under this bug.
- 9:43 AM Changeset in webkit [171858] by
-
- 5 edits in trunk/Source
Source/WebCore: WebCore part of: Server trust authentication challenges aren’t sent to the navigation delegate
https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::receivedCredential): Don’t try to change the persistence of
credentials used for server trust, because the platform doesn’t support persistence values
other than Session for server trust.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::receivedCredential): Ditto.
Source/WebKit2: WebKit part of: Server trust authentication challenges aren’t sent to the navigation delegate
https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
Return true for server trust protection spaces if the delegate implements
-webView:didReceiveAuthenticationChallenge:completionHandler:.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Removed
an assertion that is no longer true due to the above.
- 9:41 AM Changeset in webkit [171857] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::toCredentialPersistence):
- 9:24 AM Changeset in webkit [171856] by
-
- 3 edits in trunk/Tools
[webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
https://bugs.webkit.org/show_bug.cgi?id=135381
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/port/base.py:
(Port.diff_text):
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_diff_text):
- 9:16 AM Changeset in webkit [171855] by
-
- 2 edits in trunk/Source/WebCore
Reverted r171854, because it broke building with the OS X 10.8 SDK.
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::toCredentialPersistence):
- 9:07 AM Changeset in webkit [171854] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::toCredentialPersistence):
- 8:58 AM Changeset in webkit [171853] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Update test expectations for crashing tests.
- platform/efl/TestExpectations:
- 8:21 AM Changeset in webkit [171852] by
-
- 1 edit1 add in trunk/Source/JavaScriptCore
NewFunctionExpression and NewFunctionNoCheck should setHaveStructures(true)
https://bugs.webkit.org/show_bug.cgi?id=135430
Reviewed by Mark Hahnenberg.
We already handled this correctly after the ftlopt merge, but it's useful to have the test.
- tests/stress/new-function-expression-has-structures.js: Added.
(foo.f):
(foo.f.prototype.f):
(foo):
- 8:08 AM Changeset in webkit [171851] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(??): [iOS] Disabling MediaPlaybackRequiresUserGesture does not remove user gesture requirement for entering full screen.
https://bugs.webkit.org/show_bug.cgi?id=135443
Reviewed by Dean Jackson.
Allow full screen mode to be entered without a user gesture if the gesture requirement for media playback
has been unset.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- 7:05 AM Changeset in webkit [171850] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.1 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.5.1.
- 6:43 AM Changeset in webkit [171849] by
-
- 3 edits6 adds in trunk
2014-07-31 Andrei Bucur <abucur@adobe.com>
[CSS Multicolumn] Clear the lines when switching to multi-column layout
https://bugs.webkit.org/show_bug.cgi?id=135127
Reviewed by Alexandru Chiculita.
Source/WebCore:
When switching an element to multi-column layout it becomes a container of block
children. When this happens the existing line boxes must be deleted in addition
to clearing the hasInlineChildren flag.
Tests: fast/multicol/inline-container-to-multicol.html
fast/multicol/inline-container-to-multicol-float.html
fast/multicol/inline-container-to-multicol-positioned.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createMultiColumnFlowThread):
LayoutTests:
Tests that verifies lines are correctly cleared when an element is switched to
multi-column layout.
- fast/multicol/inline-container-to-multicol-expected.txt: Added.
- fast/multicol/inline-container-to-multicol.html: Added.
- fast/multicol/inline-container-to-multicol-float-expected.txt: Added.
- fast/multicol/inline-container-to-multicol-float.html: Added.
- fast/multicol/inline-container-to-multicol-positioned-expected.txt: Added.
- fast/multicol/inline-container-to-multicol-positioned.html: Added.
- 6:18 AM Changeset in webkit [171848] by
-
- 5 edits in trunk
Unreviewed. Fix GTK+ make distcheck.
Source/WebKit2:
- Shared/InteractionInformationAtPosition.h: Only include
WebCore/SelectionRect.h for IOS.
Tools:
- gtk/make-dist.py:
(ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
version to find the pkg-config file.
- gtk/manifest.txt: Add missing resource to the tarball.
- 5:27 AM Changeset in webkit [171847] by
-
- 2 edits in trunk/Tools
[GTK] make distcheck is building from sources dir instead of dist dir
https://bugs.webkit.org/show_bug.cgi?id=135457
Reviewed by Philippe Normand.
- gtk/make-dist.py:
(Distcheck.configure): Use dist_dir as source dir.
(Distcheck.check): Pass dist_dir to configure().
- 2:16 AM Changeset in webkit [171846] by
-
- 4 edits in trunk
[GTK] Bump binary version for 2.6
https://bugs.webkit.org/show_bug.cgi?id=133724
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsGTK.cmake: Bump binary version to 4.0 and
update library version numbers.
Source/WebKit2:
- PlatformGTK.cmake: Fix JavaScriptCore dependency on
instrospection commands and make them depend on GTK+-3.0.
- 1:41 AM Changeset in webkit [171845] by
-
- 2 edits in trunk/Tools
[GTK] Do not include files that are not in git in the tarball
https://bugs.webkit.org/show_bug.cgi?id=134804
Reviewed by Philippe Normand.
Skip all files in the source tree that are not under version control
except for files added from the build dir like the documentation.
- gtk/make-dist.py:
(Directory.init): Initialize the list of files under control version.
(Directory.list_cms_files): Helper function to list all files
under the control version for the current source root.
(Directory.should_skip_file): Return True for files that are not
under control version only when the source root is also under
control version.
(Directory.get_files): Filter the files also using should_skip_file().
- 12:36 AM Changeset in webkit [171844] by
-
- 2 edits in trunk/Source/WebKit
Speculative Windows build fixery, part II.
This seems to indicate that adding the globalObjectTable to the exports file
was the wrong idea:
1>WebKit.exp : error LNK2001: unresolved external symbol "struct JSC::HashTable const JSC::globalObjectTable" (?globalObjectTable@JSC@@3UHashTable@1@B)
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Jul 30, 2014:
- 11:51 PM Changeset in webkit [171843] by
-
- 3 edits in trunk/Source/JavaScriptCore
Speculative Windows build fix.
Try to dllimport the dllexported global object HashTable.
- jsc.cpp:
- testRegExp.cpp:
- 11:17 PM Changeset in webkit [171842] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 11:06 PM Changeset in webkit [171841] by
-
- 1 copy in tags/Safari-600.1.6
New Tag.
- 10:49 PM Changeset in webkit [171840] by
-
- 10 edits2 copies in branches/safari-600.1-branch
Merged r171825.
- 10:40 PM Changeset in webkit [171839] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171802. <rdar://problem/17199364>
- 10:38 PM Changeset in webkit [171838] by
-
- 10 edits in trunk/Source
PropertyName's internal string is always atomic.
<https://webkit.org/b/135451>
Source/JavaScriptCore:
Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
we know that any string that's an Identifier is guaranteed to be atomic.
A PropertyName can be either an Identifier or a PrivateName, and the
private names are also guaranteed to be atomic internally.
Make PropertyName vend AtomicStringImpl* instead of StringImpl*.
Reviewed by Benjamin Poulain.
- runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
Source/WebCore:
Use PropertyName::publicName() directly instead of taking the slow route
through AtomicString::findStringWithHash().
These strings are always atomic, and findStringWithHash() would trudge
through a full hash lookup just to discover that indeed, they are!
Reviewed by Benjamin Poulain.
- bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString): Deleted.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
Source/WTF:
Remove AtomicString::findStringWithHash() since nobody uses it anymore.
Reviewed by Benjamin Poulain.
- wtf/text/AtomicString.cpp:
(WTF::findString): Deleted.
(WTF::AtomicString::findStringWithHash): Deleted.
- wtf/text/AtomicString.h:
- 8:36 PM Changeset in webkit [171837] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171829. <rdar://problem/17824833>
- 8:19 PM Changeset in webkit [171836] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a layout test for Geolocation's request queueing for hidden pages
https://bugs.webkit.org/show_bug.cgi?id=135402
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Zalan Bujtas.
Sam added the queueing feature in r171188. This patch adds a layout test
for the simplest case.
- fast/dom/Geolocation/requestQueuingForHiddenPage-expected.txt: Added.
- fast/dom/Geolocation/requestQueuingForHiddenPage.html: Added.
- 8:18 PM Changeset in webkit [171835] by
-
- 2 edits in trunk/Source/WebCore
ElementRuleCollector: group the shadow tree code
https://bugs.webkit.org/show_bug.cgi?id=135410
Reviewed by Andreas Kling.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
Little cleanup: group the shadow tree rule collection in the same block.
- 8:17 PM Changeset in webkit [171834] by
-
- 3 edits in trunk/Source/WebCore
Cleanup DetailsMarkerControl
https://bugs.webkit.org/show_bug.cgi?id=135429
Reviewed by Andreas Kling.
Remove the override of shadowPseudoId(). This is a simple type of shadowId,
it should use the generic pseudo() path.
Move DetailsMarkerControl::create() out-of-line. One could justify inlining the constructor,
inlining the ::create() function has little value.
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::create):
(WebCore::DetailsMarkerControl::DetailsMarkerControl):
(WebCore::DetailsMarkerControl::rendererIsNeeded):
(WebCore::DetailsMarkerControl::shadowPseudoId): Deleted.
(WebCore::DetailsMarkerControl::summaryElement): Deleted.
- html/shadow/DetailsMarkerControl.h:
(WebCore::DetailsMarkerControl::create): Deleted.
- 8:16 PM Changeset in webkit [171833] by
-
- 3 edits in trunk/Source/WebCore
Remove UploadButtonElement::shadowPseudoId()
https://bugs.webkit.org/show_bug.cgi?id=135435
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.
Use the generic pseudo() path instead of a custom shadowPseudoId().
- html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::UploadButtonElement):
Set the type in the common constructor instead of the call sites.
(WebCore::UploadButtonElement::shadowPseudoId): Deleted.
- html/FileInputType.h:
- 8:16 PM Changeset in webkit [171832] by
-
- 3 edits in trunk/Source/WebCore
Remove SpinButtonElement::shadowPseudoId
https://bugs.webkit.org/show_bug.cgi?id=135436
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.
Use the generic pseudo.
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::shadowPseudoId): Deleted.
- html/shadow/SpinButtonElement.h:
- 8:15 PM Changeset in webkit [171831] by
-
- 3 edits in trunk/Source/WebCore
Clean up YouTubeEmbedShadowElement
https://bugs.webkit.org/show_bug.cgi?id=135437
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.
- html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.
- html/shadow/YouTubeEmbedShadowElement.h:
- 8:14 PM Changeset in webkit [171830] by
-
- 3 edits in trunk/Source/WebCore
Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
https://bugs.webkit.org/show_bug.cgi?id=135438
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.
Use the generic path.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId): Deleted.
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId): Deleted.
- html/shadow/TextControlInnerElements.h:
- 7:19 PM Changeset in webkit [171829] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=135449
<rdar://problem/17824833>
Reviewed by Benjamin Poulain.
The WebProcess sends the notification that the gesture modified the phrase boundary,
but the flag was not being converted properly, therefore we failed to notify
the text input system that a change had occurred.
- UIProcess/ios/WKContentViewInteraction.mm:
(toUIWKSelectionFlags):
- 6:48 PM Changeset in webkit [171828] by
-
- 5 edits in tags/Safari-600.1.3.41/Source
Versioning.
- 6:46 PM Changeset in webkit [171827] by
-
- 1 copy in tags/Safari-600.1.3.41
New tag.
- 6:13 PM Changeset in webkit [171826] by
-
- 25 edits in trunk/Source
USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
https://bugs.webkit.org/show_bug.cgi?id=135439
Reviewed by Tim Horton.
We now support two different platform content filters, and will soon support a mock content filter (as part of
webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
library. ENABLE() is the correct macro to use for such a feature.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::dataReceived):
- loader/DocumentLoader.h:
- loader/FrameLoaderClient.h:
- platform/ContentFilter.h:
- platform/ios/ContentFilterIOS.mm:
- platform/mac/ContentFilterMac.mm:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Source/WTF:
- wtf/Platform.h:
- 3:54 PM Changeset in webkit [171825] by
-
- 10 edits1 copy2 adds in tags/Safari-600.1.2.4
Merge r171798. <rdar://problem/17849033>
- 3:26 PM Changeset in webkit [171824] by
-
- 226 edits2 deletes in trunk/Source
Static hash tables no longer need to be coupled with a VM.
<https://webkit.org/b/135421>
Source/JavaScriptCore:
Now that the static hash tables are using char instead of StringImpl,
it's no longer necessary to make them per-VM.
This patch removes the hook in ClassInfo for providing your own static
hash table getter. Everyone now uses ClassInfo::staticPropHashTable.
Most of this patch is tweaking ClassInfo construction sites to pass one
less null pointer.
Also simplified Lookup.h to stop requiring ExecState/VM to access the
static hash tables.
Reviewed by Geoffrey Garen.
- API/JSAPIWrapperObject.mm:
- API/JSCallbackConstructor.cpp:
- API/JSCallbackFunction.cpp:
- API/JSCallbackObject.cpp:
- API/ObjCCallbackFunction.mm:
- bytecode/UnlinkedCodeBlock.cpp:
- create_hash_table:
- debugger/DebuggerScope.cpp:
- inspector/JSInjectedScriptHost.cpp:
- inspector/JSInjectedScriptHostPrototype.cpp:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/JSJavaScriptCallFramePrototype.cpp:
- interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable): Deleted.
(JSC::ExecState::arrayPrototypeTable): Deleted.
(JSC::ExecState::booleanPrototypeTable): Deleted.
(JSC::ExecState::dataViewTable): Deleted.
(JSC::ExecState::dateTable): Deleted.
(JSC::ExecState::dateConstructorTable): Deleted.
(JSC::ExecState::errorPrototypeTable): Deleted.
(JSC::ExecState::globalObjectTable): Deleted.
(JSC::ExecState::jsonTable): Deleted.
(JSC::ExecState::numberConstructorTable): Deleted.
(JSC::ExecState::numberPrototypeTable): Deleted.
(JSC::ExecState::objectConstructorTable): Deleted.
(JSC::ExecState::privateNamePrototypeTable): Deleted.
(JSC::ExecState::regExpTable): Deleted.
(JSC::ExecState::regExpConstructorTable): Deleted.
(JSC::ExecState::regExpPrototypeTable): Deleted.
(JSC::ExecState::stringConstructorTable): Deleted.
(JSC::ExecState::promisePrototypeTable): Deleted.
(JSC::ExecState::promiseConstructorTable): Deleted.
- jsc.cpp:
- parser/Lexer.h:
(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
- runtime/Arguments.cpp:
- runtime/ArgumentsIteratorConstructor.cpp:
- runtime/ArgumentsIteratorPrototype.cpp:
- runtime/ArrayBufferNeuteringWatchpoint.cpp:
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertySlot):
- runtime/ArrayIteratorConstructor.cpp:
- runtime/ArrayIteratorPrototype.cpp:
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
- runtime/BooleanConstructor.cpp:
- runtime/BooleanObject.cpp:
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
- runtime/ClassInfo.h:
(JSC::ClassInfo::hasStaticProperties):
(JSC::ClassInfo::propHashTable): Deleted.
- runtime/ConsolePrototype.cpp:
- runtime/CustomGetterSetter.cpp:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
- runtime/Error.cpp:
- runtime/ErrorConstructor.cpp:
- runtime/ErrorInstance.cpp:
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
- runtime/ExceptionHelpers.cpp:
- runtime/Executable.cpp:
- runtime/FunctionConstructor.cpp:
- runtime/FunctionPrototype.cpp:
- runtime/GetterSetter.cpp:
- runtime/InternalFunction.cpp:
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSActivation.cpp:
- runtime/JSArgumentsIterator.cpp:
- runtime/JSArray.cpp:
- runtime/JSArrayBuffer.cpp:
- runtime/JSArrayBufferConstructor.cpp:
- runtime/JSArrayBufferPrototype.cpp:
- runtime/JSArrayBufferView.cpp:
- runtime/JSArrayIterator.cpp:
- runtime/JSBoundFunction.cpp:
- runtime/JSConsole.cpp:
- runtime/JSDataView.cpp:
- runtime/JSDataViewPrototype.cpp:
(JSC::JSDataViewPrototype::getOwnPropertySlot):
- runtime/JSFunction.cpp:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertySlot):
- runtime/JSMap.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSNameScope.cpp:
- runtime/JSNotAnObject.cpp:
- runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::reifyStaticFunctionsForDelete):
- runtime/JSObject.h:
- runtime/JSPromise.cpp:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::getOwnPropertySlot):
- runtime/JSPromiseDeferred.cpp:
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::getOwnPropertySlot):
- runtime/JSPromiseReaction.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSProxy.cpp:
- runtime/JSSet.cpp:
- runtime/JSSetIterator.cpp:
- runtime/JSString.cpp:
- runtime/JSTypedArrayConstructors.cpp:
- runtime/JSTypedArrayPrototypes.cpp:
- runtime/JSTypedArrays.cpp:
- runtime/JSVariableObject.cpp:
- runtime/JSWeakMap.cpp:
- runtime/JSWithScope.cpp:
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
- runtime/Lookup.h:
(JSC::HashTable::initializeIfNeeded):
(JSC::HashTable::entry):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
(JSC::lookupPut):
- runtime/MapConstructor.cpp:
- runtime/MapData.cpp:
- runtime/MapIteratorConstructor.cpp:
- runtime/MapIteratorPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/MathObject.cpp:
- runtime/NameConstructor.cpp:
- runtime/NameInstance.cpp:
- runtime/NamePrototype.cpp:
(JSC::NamePrototype::getOwnPropertySlot):
- runtime/NativeErrorConstructor.cpp:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
- runtime/NumberObject.cpp:
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
- runtime/ObjectPrototype.cpp:
- runtime/PropertyTable.cpp:
- runtime/RegExp.cpp:
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
- runtime/RegExpMatchesArray.cpp:
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
- runtime/SetConstructor.cpp:
- runtime/SetIteratorConstructor.cpp:
- runtime/SetIteratorPrototype.cpp:
- runtime/SetPrototype.cpp:
- runtime/SparseArrayValueMap.cpp:
- runtime/StrictEvalActivation.cpp:
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
- runtime/StringObject.cpp:
- runtime/StringPrototype.cpp:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):
- runtime/StructureChain.cpp:
- runtime/StructureRareData.cpp:
- runtime/SymbolTable.cpp:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h:
- runtime/WeakMapConstructor.cpp:
- runtime/WeakMapData.cpp:
- runtime/WeakMapPrototype.cpp:
- testRegExp.cpp:
Source/WebCore:
Update for JSC::ClassInfo changes.
Remove the JSNoStaticTables mode for IDL code generation, which was used to
ensure that each VM had its own unique copy of certain static tables.
This was used for interfaces that could be used in workers, and now there's
no need to manually annotate these things anymore.
Also remove the DOMObjectHashTableMap class that was only used for this.
Reviewed by Geoffrey Garen.
- Modules/indexeddb/IDBAny.idl:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBCursorWithValue.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBOpenDBRequest.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/DatabaseSync.idl:
- Modules/webdatabase/SQLError.idl:
- Modules/webdatabase/SQLException.idl:
- Modules/webdatabase/SQLResultSet.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- Modules/websockets/CloseEvent.idl:
- Modules/websockets/WebSocket.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMObjectHashTableMap.cpp: Removed.
- bindings/js/DOMObjectHashTableMap.h: Removed.
- bindings/js/JSDOMBinding.cpp:
(WebCore::getHashTableForGlobalData): Deleted.
- bindings/js/JSDOMBinding.h:
(WebCore::getStaticValueSlotEntryWithoutCaching):
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::putDelegate):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
- bindings/js/WebCoreJSClientData.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
(hashTableAccessor): Deleted.
(prototypeHashTableAccessor): Deleted.
(constructorHashTableAccessor): Deleted.
- bindings/scripts/IDLAttributes.txt:
- bridge/c/CRuntimeObject.cpp:
- bridge/c/c_instance.cpp:
- bridge/objc/ObjCRuntimeObject.mm:
- bridge/objc/objc_instance.mm:
- bridge/objc/objc_runtime.mm:
- bridge/runtime_array.cpp:
- bridge/runtime_method.cpp:
- bridge/runtime_object.cpp:
- crypto/CryptoKey.idl:
- css/CSSFontFaceLoadEvent.idl:
- dom/DOMCoreException.idl:
- dom/DOMStringList.idl:
- dom/ErrorEvent.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/EventListener.idl:
- dom/MessageChannel.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/ProgressEvent.idl:
- fileapi/Blob.idl:
- fileapi/File.idl:
- fileapi/FileError.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- html/DOMURL.idl:
- page/EventSource.idl:
- page/WorkerNavigator.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestProgressEvent.idl:
- xml/XMLHttpRequestUpload.idl:
Source/WebKit/mac:
Reviewed by Geoffrey Garen.
- Plugins/Hosted/ProxyInstance.mm:
- Plugins/Hosted/ProxyRuntimeObject.mm:
Source/WebKit2:
Reviewed by Geoffrey Garen.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- 3:20 PM Changeset in webkit [171823] by
-
- 5 edits in branches/safari-537.78-branch/Source
Versioning.
- 3:19 PM Changeset in webkit [171822] by
-
- 1 copy in tags/Safari-537.78.2
New Tag.
- 3:05 PM Changeset in webkit [171821] by
-
- 5 edits in tags/Safari-600.1.2.4/Source
Versioning.
- 2:53 PM Changeset in webkit [171820] by
-
- 1 copy in tags/Safari-600.1.2.4
New Tag.
- 2:46 PM Changeset in webkit [171819] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: ProbeSetDetailsSection should not create live location links for unresolved breakpoints
https://bugs.webkit.org/show_bug.cgi?id=135367
Reviewed by Timothy Hatcher.
Regenerate the source code link whenever the breakpoint resolved status changes. If it is
resolved, then we can create a live location link that respects source maps.
- UserInterface/Views/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement): Added.
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink): Deleted.
- 2:34 PM Changeset in webkit [171818] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Merging platforms mixes baselines and targets into reported data
https://bugs.webkit.org/show_bug.cgi?id=135260
Reviewed by Geoffrey Garen.
Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
- public/admin/platforms.php:
- 2:28 PM Changeset in webkit [171817] by
-
- 1 edit2 moves in trunk/LayoutTests
Move iphone-simulator test results landed in r171094 to the correct directory.
- platform/ios-sim/fast/events/ontouchstart-active-selector-expected.txt: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt.
- platform/ios-sim/fast/events/ontouchstart-active-selector.html: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector.html.
- 2:03 PM Changeset in webkit [171816] by
-
- 5 edits2 deletes in trunk/Source/WebKit2
Get rid of the WKNSURLProtectionSpace wrapper
https://bugs.webkit.org/show_bug.cgi?id=135425
Reviewed by Sam Weinig.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Don’t allocate WKNSURLProtectionSpace wrappers.
- Shared/Cocoa/WKNSURLProtectionSpace.h: Removed.
- Shared/Cocoa/WKNSURLProtectionSpace.mm: Removed.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(canAuthenticateAgainstProtectionSpaceInFrame): Get the NSURLProtectionSpace from the
WebCore::ProtectionSpace in the WebProtectionSpace.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): Ditto.
- WebKit2.xcodeproj/project.pbxproj: Removed references to removed files.
- 1:55 PM Changeset in webkit [171815] by
-
- 5 edits in branches/safari-537.78-branch/Source
Fix Versioning.
- 1:45 PM Changeset in webkit [171814] by
-
- 7 edits1 copy in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171790. <rdar://problem/17848962>
- 1:44 PM Changeset in webkit [171813] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171787. <rdar://problem/17852395>
- 1:40 PM Changeset in webkit [171812] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171786. <rdar://problem/17852407>
- 1:36 PM Changeset in webkit [171811] by
-
- 3 edits2 copies in branches/safari-600.1-branch
Merged r171785. <rdar://problem/17851910>
- 1:33 PM Changeset in webkit [171810] by
-
- 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171783. <rdar://problem/17848773>
- 1:31 PM Changeset in webkit [171809] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171766. <rdar://problem/17824645>
- 1:29 PM Changeset in webkit [171808] by
-
- 11 edits in branches/safari-600.1-branch/Source
Merged r171749. <rdar://problem/15917314>
- 1:26 PM Changeset in webkit [171807] by
-
- 8 edits2 copies in branches/safari-600.1-branch
Merged r171718. <rdar://problem/17824793>
- 1:15 PM Changeset in webkit [171806] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 1:13 PM Changeset in webkit [171805] by
-
- 1 copy in tags/Safari-600.1.4.1
New Tag.
- 12:56 PM Changeset in webkit [171804] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171766. <rdar://problem/17824645>
- 12:50 PM Changeset in webkit [171803] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171702. <rdar://problem/16828238>
- 12:40 PM Changeset in webkit [171802] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/17199364> [Mac] Popup button arrows appear on the left, underlapping text, when the UI layout direction is right-to-left
https://bugs.webkit.org/show_bug.cgi?id=135426
Reviewed by Dean Jackson.
No test, because the UI layout direction in the test harness is always left-to-right.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::popupButton): Forced the user interface layout direction of the
NSPopUpButtonCell to left-to-right. Added a FIXME about how we could make this vary based on
the direction of the <select>, though that would require additional changes elsewhere.
- 11:56 AM Changeset in webkit [171801] by
-
- 25 edits in trunk/Source
Source/WebCore: Made Credential hold onto an NSURLCredential when needed.
Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
No change in functionality.
- WebCore.exp.in: Updated.
- platform/network/Credential.h: Removed definition of CERTIFICATE_CREDENTIALS_SUPPORTED,
which is not used anymore.
- platform/network/CredentialBase.h:
(WebCore::CredentialBase::encodingRequiresPlatformData): Added a base implementation that
returns false.
- platform/network/cf/AuthenticationCF.cpp:
Changed to use the Credential constructor that takes an CFURLCredential, and the new
cfCredential member function. Made the createCF and core functions Windows-only and
therefore removed the CERTIFICATE_CREDENTIALS_SUPPORTED code from them.
- platform/network/cf/AuthenticationCF.h:
- platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage): Changed to construct a Credential
from a CFURLCredential.
(WebCore::CredentialStorage::saveToPersistentStorage): Changed to use the new cfCredential
member function.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto to both.
(WebCore::ResourceHandle::receivedCredential): Ditto.
- platform/network/cocoa/CredentialCocoa.h:
Replaced the m_identity, m_certificates and m_type member variables with an m_nsCredential
one holding onto an NSURLCredential. Declared constructors from and getters for
NSURLCredential and CFURLCredentialRef.
(WebCore::Credential::encodingRequiresPlatformData): Override that checks the
NSURLCredential if necessary.
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::toNSURLCredentialPersistence): New helper function.
(WebCore::toCredentialPersistence): Ditto.
(WebCore::Credential::Credential): Defined constructors to create or take an
NSURLCredential.
(WebCore::Credential::cfCredential): Added.
(WebCore::Credential::nsCredential): Added. Returns nil for the empty credential.
(WebCore::Credential::isEmpty): Changed to check m_nsCredential.
(WebCore::Credential::platformCompare): Changed to compare m_nsCredential if needed.
(WebCore::Credential::encodingRequiresPlatformData): Returns true if the credential is not
a user and a password.
- platform/network/mac/AuthenticationMac.h: Removed mac and core functions for Credential.
- platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender useCredential:forAuthenticationChallenge:]):
Changed to use Credential constructor that takes an NSURLCredential.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Ditto. Also use the
nsCredential getter.
- platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::getFromPersistentStorage): Use new Credential constructor.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto. Also use the
nsCredential getter.
(WebCore::ResourceHandle::receivedCredential): Ditto.
Source/WebKit/mac: Updated for changes to the WebCore::Credential API.
Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
- Misc/WebDownload.mm:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
getter.
- Plugins/WebBaseNetscapePluginView.mm:
(WebKit::getAuthenticationInfo): Ditto.
Source/WebKit2: Updated for changes to the WebCore::Credential API.
Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
- Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::receivedCredential):Use new Credential::nsCredential getter.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Credential>::encode): If encoding the credential requires encoding the
platform data, do that.
(IPC::ArgumentCoder<Credential>::decode): If platform data was encoded, decode it.
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<Credential>::encodePlatformData): Archive the NSURLCredential.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Unarchive it.
- UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Use
Credential constructor that takes an NSURLCredential.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Ditto.
- 9:49 AM Changeset in webkit [171800] by
-
- 1 edit15 adds in trunk/Tools
iOS Simulator LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=135269
Reviewed by David Kilzer.
- LayoutTestRelay/Configurations/Base.xcconfig: Added.
- LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
- LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
- LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
- LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
(-[LTPipeRelay inPipePath]):
(-[LTPipeRelay outPipePath]):
(-[LTPipeRelay errorPipePath]):
(-[LTPipeRelay outputStream]):
(-[LTPipeRelay initWithPrefix:]):
(-[LTPipeRelay setup]):
(-[LTPipeRelay tearDown]):
(-[LTPipeRelay connect]):
(-[LTPipeRelay disconnect]):
(-[LTPipeRelay createFIFOs]):
(-[LTPipeRelay destroyFIFOs]):
(-[LTPipeRelay relayStream:]):
(-[LTPipeRelay stream:handleEvent:]):
- LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
(-[LTRelayController uniqueAppPath]):
(-[LTRelayController uniqueAppURL]):
(-[LTRelayController uniqueAppIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController readFileHandle:]):
(-[LTRelayController receivedStandardOutputData:]):
(-[LTRelayController receivedStandardErrorData:]):
(-[LTRelayController disconnected]):
(-[LTRelayController connected]):
(-[LTRelayController crashWithMessage:]):
(-[LTRelayController launchSimulator]):
(-[LTRelayController bootDevice]):
(-[LTRelayController createUniqueApp]):
(-[LTRelayController killApp]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):
- LayoutTestRelay/LayoutTestRelay/main.m: Added.
(usage):
(getTestingSimDevice):
(getRequiredStringArgument):
(getRemainderArguments):
(main):
- LayoutTestRelay/Makefile: Added.
- Tools/Scripts/build-layouttestrelay: Added.
- 9:35 AM Changeset in webkit [171799] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Build depends on OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=135289
Reviewed by Martin Robinson.
Guard the OpenGL ES code with USE(OPENGL_ES_2).
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
- platform/graphics/opengl/Extensions3DOpenGLES.h:
- 9:35 AM Changeset in webkit [171798] by
-
- 11 edits1 add in trunk
[Win] Modify version numbering scheme to support 5-tuple versions
https://bugs.webkit.org/show_bug.cgi?id=135400
<rdar://problem/17849033>
Reviewed by David Kilzer.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCorePostBuild.cmd: Use the
new version-stamp.pl script to version JavaScriptCore.dll.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Use the new
version-stamp.pl script to version JavaScriptCore.dll.
Source/WTF:
- WTF.vcxproj/WTFPostBuild.cmd: Use new version-stamp.pl script
to version WTF.dll.
- WTF.vcxproj/WTFPreBuild.cmd: Make sure we have created the
appropriate version resource during builds.
Tools:
Update test cases to recognize that we can only support Major
values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
Micro values from 0-64, and Nano values from 0-999.
- Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
test expectations for physical limits.
WebKitLibraries:
Revise the auto-version.pl script so that it generates a set of packed
version tuples that allow us to map 5-tuple versions into something
that will work with Windows' 3-tuple version structure.
- win/tools/scripts/auto-version.pl:
(packTwoValues): Added,
(splitVersion): Revised to return packed combination of minor-tiny and
micro-nano to be used as "MINOR" and "TINY" portion of version.
(splitBuildMajorVersion): Deleted.
- win/tools/scripts/version-stamp.pl: Added.
- 9:23 AM Changeset in webkit [171797] by
-
- 4 edits in trunk/Source/WebCore
Member name collision in RenderView and SelectionSubtreeRoot
https://bugs.webkit.org/show_bug.cgi?id=135233
Reviewed by Mihnea Ovidenie.
The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.
No new tests required, no new functionality.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::getSelection):
- rendering/RenderView.h:
- 3:52 AM Changeset in webkit [171796] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] REGRESSION(r171742): Test /webkit2/WebKitWebView/disallow-modal-dialogs fails
https://bugs.webkit.org/show_bug.cgi?id=135412
Reviewed by Philippe Normand.
The problem is that WebPageProxy::setUIClient() calls
setCanRunModal() with the value of m_uiClient->canRunModal() which
is always true for us. We override that manually by calling
setCanRunModal() depending on the WebKitSettings. In r171742,
webkitWebViewUpdateSettings(), the method that overrides
setCanRunModal(), was moved before attachUIClientToView(), so the
value set by WebPageProxy::setUIClient() is the last one and takes
precedence. We need to make sure webkitWebViewUpdateSettings() is
always called after attachUIClientToView().
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Move webkitWebViewUpdateSettings()
call after attachUIClientToView() and add a comment to not forget
about it again.
- 12:47 AM Changeset in webkit [171795] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
https://bugs.webkit.org/show_bug.cgi?id=135384
Reviewed by Martin Robinson.
Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().
TextureMapperLayer::rootLayer() now also returns a reference.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer): Deleted.
(WebCore::TextureMapperLayer::textureMapper): Deleted.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::textureMapper):
(WebCore::TextureMapperLayer::rootLayer):
- 12:47 AM Changeset in webkit [171794] by
-
- 2 edits in trunk/Tools
[GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
https://bugs.webkit.org/show_bug.cgi?id=135411
Reviewed by Sergio Villar Senin.
Recent versions of GTK+ now warn at runtime when a deprecated
property or signal is used. A diagnostic mode was added that is
enabled by default, but that can be disabled by setting
G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
failures by gtester, so we need to run the tests with the
diganostic mode disabled.
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
(main):
- 12:45 AM Changeset in webkit [171793] by
-
- 2 edits in trunk
[CMake] Bump the minimum required version
https://bugs.webkit.org/show_bug.cgi?id=135382
Reviewed by Gyuyoung Kim.
- CMakeLists.txt: Bump the minimum required version to 2.8.11 after
we introduced usage of target_include_directories().
- 12:06 AM Changeset in webkit [171792] by
-
- 11 edits3 deletes in trunk
[GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=134830
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
It was added to make the API more convenient but it has ended up
making it more complicated. WebKitWebView::load-failed-with-tls-errors
now receives a GTlsCertificate + GTlsCertificateFlags and
webkit_web_context_allow_tls_certificate_for_host() receives a GTlsCertificate
since the errors are not actually needed. This makes the API more
consistent with the existing method webkit_web_view_get_tls_info().
- PlatformGTK.cmake: Remove files from compilation.
- UIProcess/API/gtk/WebKitCertificateInfo.cpp: Removed.
- UIProcess/API/gtk/WebKitCertificateInfo.h: Removed.
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Removed.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_allow_tls_certificate_for_host):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/webkit2.h:
Tools:
Update the SSL test for the API changes.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(testLoadFailedWithTLSErrors):
Jul 29, 2014:
- 11:16 PM Changeset in webkit [171791] by
-
- 10 edits in trunk/LayoutTests
[EFL] Unreviewed EFL gardening. Rebaseline tests after r170418.
- platform/efl/mathml/opentype/horizontal-expected.txt:
- platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
- platform/efl/mathml/opentype/large-operators-expected.txt:
- platform/efl/mathml/opentype/vertical-expected.txt:
- platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.png:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/roots-expected.png:
- platform/efl/mathml/presentation/roots-expected.txt:
- 10:42 PM Changeset in webkit [171790] by
-
- 7 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes
https://bugs.webkit.org/show_bug.cgi?id=135399
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.
Profiling the inspector while recording a timeline, a significant amount of
time was spent creating SourceCodeLocation objects for profiling information
and call frames. A lot of this data was eagerly being processed, even though
it would not immediately be presentable to the user.
This makes two significant changes. We create a LazySourceCodeLocation class
which does as little as possible until display information is requested. We
also lazily convert the profiler payload data to a Profile object, so the
processing is only done if you drill into the Script specific timeline.
This results in a significant performance improvement in the overview view.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype._callFramesFromPayload.createCallFrame):
(WebInspector.TimelineManager.prototype._callFramesFromPayload):
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeCallFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload): Deleted.
Do not eagerly process profile payloads. Instead pass the payload to ScriptTimelineRecords.
Likewise create callframes with lazy source code locations to do the minimum amount of work.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
Only when the profile is asked do we process the profiler payload information.
This defer the processing until at least the user drills into the Script timeline.
- UserInterface/Main.html:
Add the new class and ensure SourceCodeLocation is available beforehand.
- UserInterface/Models/LazySourceCodeLocation.js: Added.
(WebInspector.LazySourceCodeLocation):
(WebInspector.LazySourceCodeLocation.prototype.isEqual):
(WebInspector.LazySourceCodeLocation.prototype.get sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.set sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.get formattedLineNumber):
(WebInspector.LazySourceCodeLocation.prototype.get formattedColumnNumber):
(WebInspector.LazySourceCodeLocation.prototype.formattedPosition):
(WebInspector.LazySourceCodeLocation.prototype.hasFormattedLocation):
(WebInspector.LazySourceCodeLocation.prototype.hasDifferentDisplayLocation):
(WebInspector.LazySourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.LazySourceCodeLocation.prototype._lazyInitialization):
Only when display information is requested will we perform extra processing.
For basic information we do not need to check for formatted (pretty-printed) info.
- UserInterface/Models/SourceCode.js:
(WebInspector.SourceCode.prototype.createLazySourceCodeLocation):
Provide an explict create function for lazy source codes.
- UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype.set sourceCode):
(WebInspector.SourceCodeLocation.prototype.get displaySourceCode):
(WebInspector.SourceCodeLocation.prototype.get displayLineNumber):
(WebInspector.SourceCodeLocation.prototype.get displayColumnNumber):
(WebInspector.SourceCodeLocation.prototype.hasMappedLocation):
(WebInspector.SourceCodeLocation.prototype.setSourceCode):
(WebInspector.SourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.SourceCodeLocation.prototype._makeChangeAndDispatchChangeEventIfNeeded):
(WebInspector.SourceCodeLocation.prototype._resolveMappedLocation): Deleted.
Include two protected functions which LazySourceCodeLocation overrides.
- 9:49 PM Changeset in webkit [171789] by
-
- 5 edits1 add in trunk/Tools
Add knowledge of the iOS Simulator to webkitpy
http://bugs.webkit.org/show_bug.cgi?id=133963
Reviewed by Simon Fraser.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration): Add --ios-sim*
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
--runtime and --device-type args added.
- Scripts/webkitpy/port/base.py:
- Scripts/webkitpy/port/driver.py: Add simulator driver.
(IOSSimulatorDriver): Added.
- Scripts/webkitpy/port/factory.py: Add simulator platform.
- Scripts/webkitpy/port/ios.py: Added.
- 9:26 PM Changeset in webkit [171788] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Do not initialize g_type system explicitly in the ewk_init()
https://bugs.webkit.org/show_bug.cgi?id=135407
Reviewed by Gyuyoung Kim.
EFL build requires glib version 2.38 but g_type_init() has been deprecated
since version 2.36. As the type system is initialized automatically since
version 2.36, we do not need to call g_type_init() in the ewk_init().
https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#g-type-init
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
- 9:17 PM Changeset in webkit [171787] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler
https://bugs.webkit.org/show_bug.cgi?id=135406
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.
Full ProfileNode times are only used by the Legacy Profiler. The new profile
information in the Scripts Timelines currently never uses the pass. We should
avoid calculating it if we never use it.
- UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
(WebInspector.ProfileNode.prototype.get selfTime):
(WebInspector.ProfileNode.prototype.get totalTime):
(WebInspector.ProfileNode.prototype.establishRelationships):
(WebInspector.ProfileNode.prototype._computeTotalTimes):
- 9:00 PM Changeset in webkit [171786] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce forced layouts in TimelineOverview
https://bugs.webkit.org/show_bug.cgi?id=135405
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.
Remove another forced layout. The scroll container won't
change size unless the ContentView itself resized. Make the
distinction between a layout update due to a resize and
normal events (scale changes, etc) and only calculate
element sizes then.
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype.updateLayout):
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.updateLayoutForResize):
- 8:51 PM Changeset in webkit [171785] by
-
- 3 edits2 adds in trunk
Crash when using 'em' units to specify font-size inside animation keyframe.
<https://webkit.org/b/135395>
<rdar://problem/17851910>
Source/WebCore:
We'd forgotten to initialize the "parent style" when resolving keyframe
styles, and this led to a crash in length conversion where the code
assumes a parent style will be present.
To keep this fix minimal, simply make the "parent style" a clone of the
base element style.
Reviewed by Simon Fraser.
Test: fast/animation/keyframe-with-font-size-in-em-units.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
LayoutTests:
Add a reduced test case to cover this bug.
Reviewed by Simon Fraser.
- fast/animation/keyframe-with-font-size-in-em-units-expected.txt: Added.
- fast/animation/keyframe-with-font-size-in-em-units.html: Added.
- 8:48 PM Changeset in webkit [171784] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: breakpoints are always speculatively resolved when restored from local storage
https://bugs.webkit.org/show_bug.cgi?id=135396
Reviewed by Timothy Hatcher.
A longstanding quirk/optimization in the frontend is that we immediately set a breakpoint
as resolved if the breakpoint was successfully set in the backend. This ensures that clicking in
the gutter immediately produces a resolved breakpoint with only one round-trip.
However, not all breakpoints should be speculatively resolved, because the corresponding resource
may not be loaded yet. This situation causes problems for code that assumes a resolved breakpoint
also has a valid sourceCodeLocation.sourceCode.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.restoreBreakpointsSoon): Don't leak the variable to global scope.
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.speculativelyResolveBreakpoint):
(WebInspector.DebuggerManager.prototype.addBreakpoint): Speculatively resolve here if requested
using the success callback passed to _setBreakpoint.
(WebInspector.DebuggerManager.prototype.didSetBreakpoint): Emit simulated
Debugger.breakpointResolved events since they are only sent by the backend when a script is parsed.
(WebInspector.DebuggerManager.prototype._setBreakpoint):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded): Request speculative resolve.
- 5:30 PM Changeset in webkit [171783] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Eliminate more forced layouts during timeline recordings
https://bugs.webkit.org/show_bug.cgi?id=135397
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.
Instead of computing the secondsPerPixel in each overview graph,
we can ask the overview view itself which has a cached value.
The computation used to force a layout, now it doesn't need to.
- UserInterface/Views/LayoutTimelineOverviewGraph.js:
- UserInterface/Views/NetworkTimelineOverviewGraph.js:
- UserInterface/Views/ScriptTimelineOverviewGraph.js:
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.get timelineOverview):
(WebInspector.TimelineOverviewGraph.prototype.set timelineOverview):
- 5:17 PM Changeset in webkit [171782] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION [WebKit2 iOS]: Cannot add shortcut to user dictionary from non editable content.
https://bugs.webkit.org/show_bug.cgi?id=135392
<rdar://problem/17760073>
Reviewed by Benjamin Poulain.
Adding a shortcut to the user dictionary needs to be available in non editable content too.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _addShortcut:]):
- 5:15 PM Changeset in webkit [171781] by
-
- 5 edits in tags/Safari-600.1.3.40/Source
Versioning.
- 5:11 PM Changeset in webkit [171780] by
-
- 1 copy in tags/Safari-600.1.3.40
New Tag.
- 4:23 PM Changeset in webkit [171779] by
-
- 5 edits9 copies in tags/Safari-600.1.3.3
Merged r171661. <rdar://problem/17315237>
- 4:16 PM Changeset in webkit [171778] by
-
- 7 edits in tags/Safari-600.1.3.3/Source
Merged r171647. <rdar://problem/17315168>
- 4:08 PM Changeset in webkit [171777] by
-
- 5 edits in tags/Safari-600.1.3.3/Source
Versioning.
- 4:05 PM Changeset in webkit [171776] by
-
- 1 copy in tags/Safari-600.1.3.3
New tag.
- 4:01 PM Changeset in webkit [171775] by
-
- 2 edits in trunk/Source/WebKit2
WKPDFView paints rotated pages squished
https://bugs.webkit.org/show_bug.cgi?id=135401
<rdar://problem/17173916>
Reviewed by Simon Fraser.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _computePageAndDocumentFrames]):
[page size] returns the crop box's size, ignoring rotation.
[page cropBoxAccountForRotation] respects rotation, but otherwise returns the same size.
UIPDFPageView will respect rotation when painting, so we
should make sure that it is given an aspect ratio that also
respects rotation, so that the page isn't squished.
- 3:52 PM Changeset in webkit [171774] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 3:46 PM Changeset in webkit [171773] by
-
- 3 edits4 deletes in branches/safari-600.1.4-branch
r171675. <rdar://problem/17826572>
- 3:41 PM Changeset in webkit [171772] by
-
- 5 edits in trunk
fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
https://bugs.webkit.org/show_bug.cgi?id=135398
Reviewed by Zalan Bujtas.
Tools:
- WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
- DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.
LayoutTests:
- platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
the actual reason for it to appear failing?
- 3:41 PM Changeset in webkit [171771] by
-
- 1 copy in tags/Safari-600.1.5
New Tag.
- 3:40 PM Changeset in webkit [171770] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Rollout r171702. <rdar://problem/16828238>
- 3:38 PM Changeset in webkit [171769] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Rollout r171703. <rdar://problem/17833422>
- 3:35 PM Changeset in webkit [171768] by
-
- 5 edits in branches/safari-600.1.4-branch/Source/WebCore
Rollout r171708. <rdar://problem/17844894>
- 2:49 PM Changeset in webkit [171767] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Added SkipTopScope coverage to FTL
- 2:41 PM Changeset in webkit [171766] by
-
- 2 edits in trunk/Source/WebCore
[iOS] REGRESSION(r171526): PDF documents fail to load in WebKit1 with disk image caching enabled
https://bugs.webkit.org/show_bug.cgi?id=135359
<rdar://problem/17824645>
Reviewed by Darin Adler.
r171526 broke the case where we have a memory mapped file from the DiskImageCache in the
SharedBuffer. In such a case, m_buffer is empty and createCFData() returned an
WebCoreSharedBufferData with an empty buffer.
Fix this by taking the easy route of bringing back the old code for the disk image cache
file backed case. In the long run we probably want to remove the iOS specific disk image
cache anyway.
Review also uncovered another bug in r171526 where we were balancing an Objective-C alloc
with a CFRelease which is incorrect when running under GC. Fix that by using adoptNS along
with adoptCF which is what the code did before.
No new tests because the bug only occurs on device and we can't run tests on device yet.
- platform/mac/SharedBufferMac.mm:
(-[WebCoreSharedBufferData initWithDiskImageSharedBuffer:]):
(-[WebCoreSharedBufferData length]):
(-[WebCoreSharedBufferData bytes]):
(WebCore::SharedBuffer::createCFData):
- 2:25 PM Changeset in webkit [171765] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171748. <rdar://problem/17356958>
- 2:03 PM Changeset in webkit [171764] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171711. <rdar://problem/17756281>
- 2:03 PM Changeset in webkit [171763] by
-
- 7 edits in branches/ftlopt/Source/JavaScriptCore
Support for-in in the FTL
https://bugs.webkit.org/show_bug.cgi?id=134140
Reviewed by Filip Pizlo.
- dfg/DFGSSALoweringPhase.cpp:
(JSC::DFG::SSALoweringPhase::handleNode):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileHasIndexedProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasGenericProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasStructureProperty):
(JSC::FTL::LowerDFGToLLVM::compileGetDirectPname):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumerableLength):
(JSC::FTL::LowerDFGToLLVM::compileGetStructurePropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetGenericPropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumeratorPname):
(JSC::FTL::LowerDFGToLLVM::compileToIndexString):
- 2:00 PM Changeset in webkit [171762] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merge r171709. rdar://problem/16988887>
- 1:59 PM Changeset in webkit [171761] by
-
- 5 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171708. <rdar://problem/17844894>
- 1:57 PM Changeset in webkit [171760] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171703. <rdar://problem/17833422>
- 1:56 PM Changeset in webkit [171759] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171702. <rdar://problem/16828238>
- 1:54 PM Changeset in webkit [171758] by
-
- 5 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171700. <rdar://problem/17844901>
- 1:36 PM Changeset in webkit [171757] by
-
- 2 edits2 copies in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merge r171689. <rdar://problem/17844890>
- 1:33 PM Changeset in webkit [171756] by
-
- 2 edits in trunk/Tools
PPT: run-webkit-tests doesn't upload crash logs to bots
https://bugs.webkit.org/show_bug.cgi?id=135391
Reviewed by Joseph Pecoraro.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
Not a fix to be proud of, but better than not having it work at all.
- 1:32 PM Changeset in webkit [171755] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merge r171688. <rdar://problem/17364180>
- 1:26 PM Changeset in webkit [171754] by
-
- 3 edits4 copies in branches/safari-600.1.4-branch
Merge r171675. <rdar://problem/17826572>
- 1:08 PM Changeset in webkit [171753] by
-
- 2 edits in trunk/Source/WebKit2
URTBF for !ENABLE(DATABASE_PROCESS) platforms.
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):
- 12:34 PM Changeset in webkit [171752] by
-
- 3 edits in trunk/Source/WebCore
VisitedLinkState::determineLinkState should take a reference
https://bugs.webkit.org/show_bug.cgi?id=135375
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-29
Reviewed by Sam Weinig.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initElement):
- dom/VisitedLinkState.h:
(WebCore::VisitedLinkState::determineLinkState):
- 12:00 PM Changeset in webkit [171751] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 11:57 AM Changeset in webkit [171750] by
-
- 1 copy in branches/safari-600.1.4-branch
New Branch.
- 10:37 AM Changeset in webkit [171749] by
-
- 11 edits in trunk/Source
Make WKOriginDataManager actually operate on IndexedDatabases.
https://bugs.webkit.org/show_bug.cgi?id=135346
Reviewed by Sam Weinig (and David Kilzer and Alex Christensen)
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::getIndexedDatabaseOrigins):
(WebKit::DatabaseProcess::doGetIndexedDatabaseOrigins):
(WebKit::removeAllDatabasesForOriginPath): Utility to delete all database files for the given origin path
that have been modified between the given dates.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllIndexedDatabaseEntries):
(WebKit::DatabaseProcess::doDeleteAllIndexedDatabaseEntries):
- DatabaseProcess/DatabaseProcess.h:
- Shared/WebCrossThreadCopier.cpp:
(WebCore::SecurityOriginData>::copy):
- Shared/WebCrossThreadCopier.h:
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::getOrigins):
(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerProxy::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManagerProxy::deleteAllEntries):
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::getOrigins): Pipe IDB requests through to the DatabaseProcess.
(WebKit::WebOriginDataManager::deleteEntriesForOrigin): Ditto.
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates): Ditto.
(WebKit::WebOriginDataManager::deleteAllEntries): Ditto.
- 10:23 AM Changeset in webkit [171748] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed, rolling out r171704.
https://bugs.webkit.org/show_bug.cgi?id=135389
Broke two IndexedDB tests (Requested by ap on #webkit).
Reverted changeset:
"IDB transactions never reset if the Web Process ends before
cleaning up"
https://bugs.webkit.org/show_bug.cgi?id=135218
http://trac.webkit.org/changeset/171704
- 9:40 AM Changeset in webkit [171747] by
-
- 7 edits2 adds in trunk/Source/WebCore
Moved the Cocoa-specific parts of CredentialBase into a Cocoa-specific Credential class.
Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
Reviewed by Alexey Proskuryakov.
No change in functionality.
- WebCore.exp.in: Updated for functions moved in the class hierarchy.
- WebCore.xcodeproj/project.pbxproj: Added CredentialCocoa.{h,mm}.
- platform/network/Credential.h: For Cocoa, include CredentialCocoa.h instead of the generic
class.
(WebCore::Credential::Credential): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED code.
- platform/network/CredentialBase.cpp:
(WebCore::CredentialBase::CredentialBase): Changed to use emptyString instead of "", removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code.
(WebCore::CredentialBase::isEmpty): Ditto.
(WebCore::CredentialBase::compare): Renamed operator== to this, removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code, but changed the end to call platformCompare.
(WebCore::CredentialBase::identity): Deleted.
(WebCore::CredentialBase::certificates): Deleted.
(WebCore::CredentialBase::type): Deleted.
- platform/network/CredentialBase.h: Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED members.
(WebCore::CredentialBase::platformCompare): Added a base implementation that returns true.
(WebCore::operator==): Changed to use CredentialBase::compare.
- platform/network/cocoa/CredentialCocoa.h: Added.
(WebCore::Credential::Credential):
- platform/network/cocoa/CredentialCocoa.mm: Added.
(WebCore::Credential::Credential): Moved the constructor that takes an identity and
certificates here.
(WebCore::Credential::isEmpty): Moved here.
(WebCore::Credential::identity): Ditto.
(WebCore::Credential::certificates): Ditto.
(WebCore::Credential::type): Ditto.
(WebCore::Credential::platformCompare): Moved the code that compares client-certificate
credentials here.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED guards in this Cocoa-only
file.
(WebCore::core): Ditto.
- 8:47 AM Changeset in webkit [171746] by
-
- 11 edits in trunk/Source
Use WTF::move() instead of std::move() to help ensure move semantics
https://bugs.webkit.org/show_bug.cgi?id=135351
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
Source/WebCore:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
Source/WebKit2:
- UIProcess/API/Cocoa/_WKSessionState.mm:
(-[_WKSessionState _initWithSessionState:]):
- UIProcess/API/gtk/WebKitUserContent.cpp:
(toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::mouseEvent):
Source/WTF:
- wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):
- 8:11 AM Changeset in webkit [171745] by
-
- 3 edits2 adds in trunk
[CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
https://bugs.webkit.org/show_bug.cgi?id=135385
Reviewed by Andrei Bucur.
Source/WebCore:
When a region-based multicolumn element is displayed and hit tested in a region,
we have to disable the named flow region information not only for painting,
but also for hit-testing. This is a follow-up for https://bugs.webkit.org/show_bug.cgi?id=132121,
which provided the fix for painting.
Test: fast/regions/assert-hit-test-multicol-in-region.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
LayoutTests:
- fast/regions/assert-hit-test-multicol-in-region-expected.txt: Added.
- fast/regions/assert-hit-test-multicol-in-region.html: Added.
- 7:51 AM Changeset in webkit [171744] by
-
- 8 edits1 add in trunk/Source/WebCore
Cleanup RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo.
https://bugs.webkit.org/show_bug.cgi?id=135326
Reviewed by Darin Adler.
- Move implementation to RenderSelectInfo.cpp
- RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo take Render* reference.
- Remove unused functions.
- Add RenderSelectionInfoBase::repaintRectangle()
No change in behavior.
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderSelectionInfo.cpp: Added.
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
(WebCore::RenderSelectionInfoBase::repaintRectangle):
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
(WebCore::RenderBlockSelectionInfo::repaint):
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::collectedSelectionRects):
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase): Deleted.
(WebCore::RenderSelectionInfoBase::object): Deleted.
(WebCore::RenderSelectionInfo::RenderSelectionInfo): Deleted.
(WebCore::RenderSelectionInfo::repaint): Deleted.
(WebCore::RenderSelectionInfo::rects): Deleted.
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo): Deleted.
(WebCore::RenderBlockSelectionInfo::repaint): Deleted.
(WebCore::RenderBlockSelectionInfo::block): Deleted.
- rendering/RenderView.cpp:
(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):
- 7:35 AM Changeset in webkit [171743] by
-
- 20 edits in trunk/Source
Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
https://bugs.webkit.org/show_bug.cgi?id=131782
Original patch by Tim Horton.
Reviewed by Darin Adler.
Source/WebCore:
No new tests because no functional changes.
- Modules/indexeddb/IDBCallbacks.h:
- Modules/indexeddb/IDBCursorBackend.h:
- loader/ios/DiskImageCacheIOS.h:
Forward declare SharedBuffer in headers.
- Modules/indexeddb/IDBRequest.cpp:
- loader/cache/CachedImage.cpp:
- loader/icon/IconLoader.cpp:
- loader/ios/DiskImageCacheIOS.mm:
- loader/cache/MemoryCache.cpp:
- loader/mac/ResourceBuffer.mm:
Include SharedBuffer.h in implementation files.
- Modules/notifications/Notification.h:
- loader/appcache/ApplicationCacheGroup.h:
Remove unnecessary includes.
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::adoptSharedBuffer):
- loader/ResourceBuffer.h:
Out-of-line adoptSharedBuffer so that the PassRefPtr doesn't require including SharedBuffer.h.
- platform/graphics/opentype/OpenTypeMathData.cpp:
- platform/graphics/opentype/OpenTypeMathData.h:
Out-of-line destructor to avoid requiring SharedBuffer.h for the RefPtr.
Forward-declare SharedBuffer in the header, include in implementation.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
- WebProcess/Network/NetworkProcessConnection.cpp:
Include SharedBuffer.h in implementation files.
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
Un-indent namespace and remove SharedBuffer forward-declaration.
- 5:42 AM Changeset in webkit [171742] by
-
- 18 edits4 deletes in trunk
[GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=133729
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-07-29
Reviewed by Carlos Garcia Campos.
Removes WebKitWebViewGroup, effectively reverting the changes
introduced by r149117. The motivation for WebKitWebViewGroup
was using the user style sheet injection API, which has been
moved into WebKitUserContentManager, rendering it unneeded.
Source/WebKit2:
- PlatformGTK.cmake: Remove WebKitWebViewGroup source files
from the build.
- UIProcess/API/C/gtk/WKView.cpp:
(WKViewCreate): Accomodate for changes in the signature of
webkitWebViewBaseCreate().
- UIProcess/API/gtk/WebKitSettings.cpp: Update API documentation.
- UIProcess/API/gtk/WebKitWebContext.cpp: Remove the default web
view group from WebKitWebContext.
(webkitWebContextCreatePageForWebView): Allow passing a
WebPreferences object at construction.
(webkitWebContextGetDefaultWebViewGroup): Deleted.
- UIProcess/API/gtk/WebKitWebContextPrivate.h: Ditto.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewUpdateSettings): Use WebPageProxy::setPreferences()
directly. Handle the case when webkit_web_view_set_settings()
is called on construction by doing an early-return.
(webkitWebViewConstructed): Call webkitWebViewUpdateSettings()
after creating the internal WebPageProxy object.
(webkitWebViewSetProperty): Removed "group" property, added
"settings" property.
(webkitWebViewGetProperty): Ditto.
(webkitWebViewDispose): Do not disconnect signal handler for
the (now unexistant) WebKitWebViewGroup.
(webkit_web_view_class_init): Removed "group" property, added
"settings" property.
(webkitWebViewHandleAuthenticationChallenge): Access the
WebKitWebSettings directly.
(webkit_web_view_new_with_related_view): Make new views share
settings with their related view.
(webkit_web_view_new_with_settings): Added.
(webkit_web_view_set_settings): Access the settings directly in
the WebKitWebView.
(webkit_web_view_get_settings): Ditto.
(webkit_web_view_set_zoom_level): Ditto.
(webkit_web_view_get_zoom_level): Ditto.
(webkitWebViewSettingsChanged): Deleted.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Deleted.
(webkit_web_view_new_with_group): Deleted.
(webkit_web_view_get_group): Deleted.
- UIProcess/API/gtk/WebKitWebView.h: Removed API methods related
to WebKitWebViewGroup.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreate): Allow passing a WebPreferences object
for constructing the WebPageProxy.
(webkitWebViewBaseUpdatePreferences): Instead of going through
the page group, use WebPageProxy::preferences() directly.
(webkitWebViewBaseCreateWebPage): Allow passing a WebPreferences
object for constructing the WebPageProxy.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Update the
prototypes of the internal functions.
- UIProcess/API/gtk/WebKitWebViewGroup.cpp: Removed.
- UIProcess/API/gtk/WebKitWebViewGroup.h: Removed.
- UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Removed.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Change public API
bits in the documentation.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
- UIProcess/API/gtk/docs/webkit2gtk.types: Ditto.
- UIProcess/API/gtk/webkit2.h: Removed WebKitWebViewGroup.h header.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Accomodate for changes in the signature of
webkitWebViewBaseCreate().
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
for WebKitWebViewGroup.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewSettings):
Restore the assertions that check that settings objects are
released. Add test for webkit_web_view_new_with_settings().
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
- 4:41 AM Changeset in webkit [171741] by
-
- 3 edits in trunk
[EFL][GTK] Remove ACCELERATED_COMPOSITING compile flag
https://bugs.webkit.org/show_bug.cgi?id=135376
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-29
Reviewed by Gyuyoung Kim.
ACCELERATED_COMPOSITING was changed to the mandatory code after r163079.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 4:35 AM Changeset in webkit [171740] by
-
- 12 edits in trunk
Implement webkit_web_view_load_string() in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=134735
Reviewed by Sergio Villar Senin.
Source/WebKit2:
Add webkit_web_view_load_bytes() that receives a GBytes to load
random data in the web view using the given MIME-Type, encoding
and base URL.
- UIProcess/API/gtk/WebKitWebView.cpp:
(releaseGBytes):
(webkit_web_view_load_bytes):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
Tools:
Add /webkit2/WebKitWebView/load-bytes test case and simplify
TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
instead of a soup server just to sent the Content-type header.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(serverCallback): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(testLoadBytes):
(beforeAll):
- TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
(LoadTrackingTest::loadBytes):
- TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::loadBytes):
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
- 1:52 AM Changeset in webkit [171739] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171721. <rdar://problem/17836658>
- 1:50 AM Changeset in webkit [171738] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171720. <rdar://problem/17838230>
- 1:49 AM Changeset in webkit [171737] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r171716. <rdar://problem/17835401>
- 1:47 AM Changeset in webkit [171736] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171711. <rdar://problem/17756281>
- 1:45 AM Changeset in webkit [171735] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171709. <rdar://problem/16988887>
- 1:41 AM Changeset in webkit [171734] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171708. <rdar://problem/17768371>
- 1:38 AM Changeset in webkit [171733] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171706. <rdar://problem/17295639>
- 1:36 AM Changeset in webkit [171732] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171704. <rdar://problem/17356958>
- 1:34 AM Changeset in webkit [171731] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171703. <rdar://problem/17833422>
- 1:32 AM Changeset in webkit [171730] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171702. <rdar://problem/16828238>
- 1:29 AM Changeset in webkit [171729] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebCore
Merged r171700. <rdar://problem/15317278>
- 1:27 AM Changeset in webkit [171728] by
-
- 2 edits2 copies in branches/safari-600.1-branch/Source/JavaScriptCore
Merged r171689. <rdar://problem/17509889>
- 1:23 AM Changeset in webkit [171727] by
-
- 2 edits in branches/safari-600.1-branch/Source/JavaScriptCore
Merged r171688. <rdar://problem/17364180>
- 1:18 AM Changeset in webkit [171726] by
-
- 3 edits4 copies in branches/safari-600.1-branch
Merged r171675. <rdar://problem/17826572>
- 1:12 AM Changeset in webkit [171725] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
https://bugs.webkit.org/show_bug.cgi?id=135237
Reviewed by Martin Robinson.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h: The boxSize parameter of the
addAnimation() method must be of the same type as the parameter in the base class
declaration -- a const FloatSize reference. Only then is the base virtual method
actually overriden.
- 12:52 AM Changeset in webkit [171724] by
-
- 4 edits in trunk/Source/WebKit2
[EFL] Alpha value of ewk_view_bg_color_set is not working
https://bugs.webkit.org/show_bug.cgi?id=135333
Reviewed by Gyuyoung Kim.
evas_object_image_alpha_set should be called for the transparent evas object.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::handleEvasObjectColorSet):
(EwkView::setBackgroundColor): Checked the alpha value of object and called evas_object_image_alpha_set.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_bg_color_set): Moved the logic to EwkView.
