Context Navigation

← Previous Period
Next Period →

Timeline

Oct 29, 2014:

10:02 PM Changeset in webkit [175367] by commit-queue@webkit.org

4 edits in trunk/Tools

CommitQueue and EWS should reject any patches that result in consistent test
failures that aren't present on the tree.
https://bugs.webkit.org/show_bug.cgi?id=138184

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-10-29
Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/layout_tests/models/test_results.py:

Adds a simple hashing function to allow for set operations to handle
TestResult objects properly.
(TestResult.hash):

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

Adds one unit test, and modifies others to agree with the notion that
patches that introduce new test failures (but also have flakyness)
should be rejected rather than spin.
(MockCommitQueue.report_flaky_tests):
(CommitQueueTaskTest._run_and_expect_patch_analysis_result):
(test_double_flaky_test_failure):
(test_two_flaky_tests):
(test_very_flaky_patch):
(test_very_flaky_patch_with_some_tree_redness):
(test_different_test_failures):
(test_different_test_failures_with_some_tree_redness):
(test_different_test_failures_with_some_tree_redness_and_some_fixes):
(test_mildly_flaky_patch):
(test_mildly_flaky_patch_with_some_tree_redness):

Scripts/webkitpy/tool/bot/patchanalysistask.py:

Makes PatchAnalysisTask reject said patches.
(PatchAnalysisTask._test_patch):

9:53 PM Changeset in webkit [175366] by commit-queue@webkit.org

2 edits in trunk/Tools

WinCairoRequirements.zip cannot be downloaded from dropbox
https://bugs.webkit.org/show_bug.cgi?id=138113

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-10-29
Reviewed by Alexey Proskuryakov.

Scripts/update-webkit-dependency: Removing --sslv3 option from curl

8:54 PM Changeset in webkit [175365] by akling@apple.com

11 edits in trunk/Source/JavaScriptCore

Use plain JSArray for RegExp matches instead of a lazily populated custom object.
<https://webkit.org/b/138191>

Reviewed by Geoffrey Garen.

We're already offering two RegExp matching APIs, one that collects subpattern
matches (exec), and one that simply tests for a match (test).
Given that, it was pretty overkill to lazily populate the resulting array of
matches, since the user could simply use test() if they didn't need them.

This allows the JIT to generate better code for RegExp match arrays, and also
enables some fast paths in the JSC runtime that check if an object isJSArray().

Looks like ~1.5% improvement on Octane/regexp according to run-jsc-benchmarks.

jit/Repatch.cpp:

(JSC::tryCacheGetByID):

runtime/JSArray.h:

(JSC::createArrayButterflyWithExactLength): Deleted.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/RegExpCachedResult.cpp:

(JSC::RegExpCachedResult::visitChildren):
(JSC::RegExpCachedResult::lastResult):
(JSC::RegExpCachedResult::leftContext):
(JSC::RegExpCachedResult::rightContext):

runtime/RegExpCachedResult.h:

(JSC::RegExpCachedResult::RegExpCachedResult):
(JSC::RegExpCachedResult::record):
(JSC::RegExpCachedResult::input):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):

runtime/RegExpMatchesArray.cpp:

(JSC::createRegExpMatchesArray):
(JSC::RegExpMatchesArray::RegExpMatchesArray): Deleted.
(JSC::RegExpMatchesArray::create): Deleted.
(JSC::RegExpMatchesArray::finishCreation): Deleted.
(JSC::RegExpMatchesArray::visitChildren): Deleted.
(JSC::RegExpMatchesArray::reifyAllProperties): Deleted.
(JSC::RegExpMatchesArray::reifyMatchProperty): Deleted.
(JSC::RegExpMatchesArray::leftContext): Deleted.
(JSC::RegExpMatchesArray::rightContext): Deleted.

runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::createStructure): Deleted.
(JSC::RegExpMatchesArray::reifyAllPropertiesIfNecessary): Deleted.
(JSC::RegExpMatchesArray::reifyMatchPropertyIfNecessary): Deleted.
(JSC::RegExpMatchesArray::getOwnPropertySlot): Deleted.
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex): Deleted.
(JSC::RegExpMatchesArray::put): Deleted.
(JSC::RegExpMatchesArray::putByIndex): Deleted.
(JSC::RegExpMatchesArray::deleteProperty): Deleted.
(JSC::RegExpMatchesArray::deletePropertyByIndex): Deleted.
(JSC::RegExpMatchesArray::getOwnPropertyNames): Deleted.
(JSC::RegExpMatchesArray::defineOwnProperty): Deleted.
(JSC::isRegExpMatchesArray): Deleted.

runtime/RegExpObject.cpp:

(JSC::RegExpObject::exec):

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):

8:36 PM Changeset in webkit [175364] by dburkart@apple.com

5 edits in branches/safari-600.3-branch/Source

Bump versioning.

8:27 PM Changeset in webkit [175363] by commit-queue@webkit.org

3 edits
2 adds in trunk

ASSERTION NOT REACHED because RenderStyle::setWordSpacing() does not handle a Length value of type 'Calculated'.
https://bugs.webkit.org/show_bug.cgi?id=138054.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-29
Reviewed by Zalan Bujtas.

Source/WebCore:

A Length of type 'Calculated' can be generated from blending two lengths of
different types. Setting the wordSpacing of the render style should be handled
correctly when the type of the new value is 'Calculated'.

Tests: css3/calculated-word-spacing.html.

Add a case for setting the render style wordSpacing to a <length> of type 'Calculated'.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setWordSpacing):

LayoutTests:

Ensure the render style's wordSpacing can be set correctly when the type of
the new value is 'Calculated'. The 'Calculated' Length value can result from
blending two Length values of different types. And these two Length values
are defined in two consecutive css animation key frames.

css3/calculated-word-spacing-expected.txt: Added.
css3/calculated-word-spacing.html: Added.

7:29 PM Changeset in webkit [175362] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Web Inspector: Fix Type Dependency Issues
https://bugs.webkit.org/show_bug.cgi?id=125664

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-29
Reviewed by Brian Burg.

Now that all JSON protocol files are processed together again
in r174892, we can remove the duplicated types which were only
needed when the domains were split.

inspector/protocol/Console.json:
inspector/protocol/Runtime.json:

6:18 PM Changeset in webkit [175361] by commit-queue@webkit.org

9 edits in trunk/Source

[CoordinatedGraphics] Use modern for-loops
https://bugs.webkit.org/show_bug.cgi?id=138168

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-10-29
Reviewed by Andreas Kling.

No new tests as there is no change in functionality.

Source/WebCore:

platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Use a modern for loop.

(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::paintToSurface):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: Use a modern for loop.

(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers):
(WebCore::CoordinatedGraphicsLayer::findFirstDescendantWithContentsRecursively):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayers):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp: Use a modern for loop.

(WebCore::CoordinatedImageBacking::updateVisibilityIfNeeded):

Source/WebKit2:

UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp: Use a modern for loop.

(WebCore::CoordinatedBackingStore::texture):
(WebCore::CoordinatedBackingStore::paintTilesToTextureMapper):

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp: Use a modern for loop.

(WebKit::CoordinatedDrawingAreaProxy::incorporateUpdate):

UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: Use a modern for loop.

(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::createLayers): changed the name of argument to be equal with deleteLayer().
(WebCore::CoordinatedGraphicsScene::deleteLayers):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncUpdateAtlases):
(WebCore::CoordinatedGraphicsScene::syncImageBackings):
(WebCore::CoordinatedGraphicsScene::commitSceneState):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp: Use a modern for loop.

(WebKit::shouldPaintBoundsRect):
(WebKit::CoordinatedDrawingArea::display):

6:06 PM Changeset in webkit [175360] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r175349.

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem): Use PLATFORM(COCOA) for setSnapshot().

5:49 PM Changeset in webkit [175359] by dburkart@apple.com

1 copy in tags/Safari-600.3.2

Tagging Safari-600.3.2

5:16 PM Changeset in webkit [175358] by Chris Dumez

2 edits in trunk/Source/WebCore

Final-ize more of TextFieldInputType's virtual functions
https://bugs.webkit.org/show_bug.cgi?id=138194

Reviewed by Andreas Kling.

Final-ize more of TextFieldInputType's virtual functions for
performance.

No new tests, no behavior change.

html/TextFieldInputType.h:

5:13 PM Changeset in webkit [175357] by matthew_hanson@apple.com

2 edits in trunk/Tools

bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
https://bugs.webkit.org/show_bug.cgi?id=138193

This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)

It also does a bit of refactoring, including distinguishing between versions and version strings and
saving versions to local variables instead of using eval in each conditional.

Reviewed by David Kilzer.

Scripts/bisect-builds:

(makeNightlyList):
Restrict the set of nightlies to r174650 and above when running Yosemite.
Restrict the set of nightlies to r157846 and above when running Mavericks.
Restrict the set of nightlies to r122421 and above when running Mountain Lion.

4:33 PM Changeset in webkit [175356] by Simon Fraser

2 edits in trunk/LayoutTests

Skip compositing/regions/propagate-region-box-shadow-border-padding-for-video.html which
asserts in Debug.

platform/mac/TestExpectations:

4:28 PM Changeset in webkit [175355] by Chris Dumez

18 edits in trunk/Source/WebCore

Clean up virtual functions in inspector/
https://bugs.webkit.org/show_bug.cgi?id=138190

Reviewed by Andreas Kling.

Clean up virtual functions in inspector/ by:

Making virtual functions final when possible
Making classes final when possible
Explicitly marking functions / destructors as virtual when they are inherently virtual
Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks

No new tests, no behavior change.

inspector/InspectorApplicationCacheAgent.h:

(WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): Deleted.

inspector/InspectorCSSAgent.h:
inspector/InspectorDOMAgent.h:
inspector/InspectorDOMDebuggerAgent.h:
inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.h:
inspector/InspectorFrontendClientLocal.h:
inspector/InspectorIndexedDBAgent.h:
inspector/InspectorLayerTreeAgent.h:
inspector/InspectorPageAgent.h:
inspector/InspectorReplayAgent.h:
inspector/InspectorResourceAgent.h:
inspector/InspectorStyleSheet.h:
inspector/InspectorTimelineAgent.h:
inspector/InspectorWorkerAgent.h:
inspector/PageConsoleAgent.h:
inspector/WorkerInspectorController.h:

4:18 PM Changeset in webkit [175354] by matthew_hanson@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r175353. rdar://problem/18817803

4:13 PM Changeset in webkit [175353] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Null deref under performActionMenuHitTestAtLocation
https://bugs.webkit.org/show_bug.cgi?id=138197
<rdar://problem/18817803>

Reviewed by Beth Dakin.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scanForDataDetectedItems):
Null-check the expanded range.

4:02 PM Changeset in webkit [175352] by akling@apple.com

7 edits in trunk/Source/WebCore

Generalize dirtying of parent's line boxes when taking a renderer out of tree.
<https://webkit.org/b/138152>

Reviewed by Antti Koivisto.

Instead of calling dirtyLinesFromChangedChild() when certain types of renderers
are about to be destroyed, always do this in RenderElement::willBeRemovedFromTree().

This is part of an effort to make render tree teardown less incomprehensible.

We still don't bother at all if we're in the process of tearing down the entire
render tree, since that would be a waste of time.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeRemovedFromTree):

rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::willBeDestroyed): Deleted.

rendering/RenderReplaced.h:

3:59 PM Changeset in webkit [175351] by adachan@apple.com

11 edits in trunk/Source

Implement WKPageSetMuted(bool).
https://bugs.webkit.org/show_bug.cgi?id=138158

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:
page/Page.h:

Source/WebKit2:

UIProcess/API/C/WKPage.cpp:

(WKPageSetMuted):

UIProcess/API/C/WKPagePrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMuted):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setMuted):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

3:43 PM Changeset in webkit [175350] by matthew_hanson@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Add a missing symbol to fix the build after the merge of r175335. rdar://problem/18709436

3:34 PM Changeset in webkit [175349] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Clear ViewSnapshots when back/forward list items are removed from their list
https://bugs.webkit.org/show_bug.cgi?id=138188
<rdar://problem/18817001>

Reviewed by Tim Horton.

Ideally we should remove the WebBackForwardListItem objects as well, but this is a somewhat safer fix.

Change all the "remove item" codepaths to call WebBackForwardList::didRemoveItem and have it clear out the snapshot.

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::removeAllItems):
(WebKit::WebBackForwardList::clear):
(WebKit::WebBackForwardList::didRemoveItem):

UIProcess/WebBackForwardList.h:

3:01 PM Changeset in webkit [175348] by Antti Koivisto

7 edits
2 adds in trunk/Source/WebCore

Notify Settings object when its Page object goes away.
https://bugs.webkit.org/show_bug.cgi?id=138183
rdar://problem/18786900

Patch by Alexey Proskuryakov <ap@apple.com> on 2014-10-29
Reviewed by Andreas Kling.

I could not make a test for this issue.

page/Page.cpp:

(WebCore::Page::~Page):

page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setTextAutosizingEnabled):
(WebCore::Settings::setTextAutosizingWindowSizeOverride):
(WebCore::Settings::setTextAutosizingFontScaleFactor):
(WebCore::Settings::setMediaTypeOverride):
(WebCore::Settings::setScriptEnabled):
(WebCore::Settings::setUserStyleSheetLocation):
(WebCore::Settings::setMinDOMTimerInterval):
(WebCore::Settings::minDOMTimerInterval):
(WebCore::Settings::domTimerAlignmentInterval):
(WebCore::Settings::setUsesPageCache):
(WebCore::Settings::setScreenFontSubstitutionEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setDNSPrefetchingEnabled):
(WebCore::Settings::setStorageBlockingPolicy):
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):
(WebCore::Settings::setScrollingPerformanceLoggingEnabled):
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled):
(WebCore::Settings::setFontFallbackPrefersPictographs):

page/Settings.h:

(WebCore::Settings::pageDestroyed):

2:59 PM Changeset in webkit [175347] by ap@apple.com

4 edits in trunk/Source/WebCore

Notify Settings object when its Page object goes away.
https://bugs.webkit.org/show_bug.cgi?id=138183
rdar://problem/18786900

Reviewed by Andreas Kling.

I could not make a test for this issue.

page/Page.cpp:

(WebCore::Page::~Page):

page/Settings.cpp:

page/Settings.h:

(WebCore::Settings::pageDestroyed):

2:32 PM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com

(diff)

2:32 PM Changeset in webkit [175346] by commit-queue@webkit.org

129 edits
2 adds in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Rebaseline after 175259.

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-10-29

platform/gtk/css1/basic/containment-expected.txt:
platform/gtk/css1/basic/contextual_selectors-expected.txt:
platform/gtk/css1/basic/grouping-expected.txt:
platform/gtk/css1/basic/id_as_selector-expected.txt:
platform/gtk/css1/basic/inheritance-expected.txt:
platform/gtk/css1/box_properties/border-expected.txt:
platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
platform/gtk/css1/box_properties/border_color-expected.txt:
platform/gtk/css1/box_properties/border_color_inline-expected.txt:
platform/gtk/css1/box_properties/border_inline-expected.txt:
platform/gtk/css1/box_properties/border_left-expected.txt:
platform/gtk/css1/box_properties/border_left_inline-expected.txt:
platform/gtk/css1/box_properties/border_left_width-expected.txt:
platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
platform/gtk/css1/box_properties/border_right-expected.txt:
platform/gtk/css1/box_properties/border_right_inline-expected.txt:
platform/gtk/css1/box_properties/border_right_width-expected.txt:
platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
platform/gtk/css1/box_properties/border_style-expected.txt:
platform/gtk/css1/box_properties/border_style_inline-expected.txt:
platform/gtk/css1/box_properties/border_top_inline-expected.txt:
platform/gtk/css1/box_properties/border_top_width-expected.txt:
platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
platform/gtk/css1/box_properties/border_width-expected.txt:
platform/gtk/css1/box_properties/border_width_inline-expected.txt:
platform/gtk/css1/box_properties/clear-expected.txt:
platform/gtk/css1/box_properties/clear_float-expected.txt:
platform/gtk/css1/box_properties/float-expected.txt:
platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
platform/gtk/css1/box_properties/float_margin-expected.txt:
platform/gtk/css1/box_properties/height-expected.txt:
platform/gtk/css1/box_properties/margin-expected.txt:
platform/gtk/css1/box_properties/margin_bottom-expected.txt:
platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
platform/gtk/css1/box_properties/margin_inline-expected.txt:
platform/gtk/css1/box_properties/margin_left-expected.txt:
platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
platform/gtk/css1/box_properties/margin_right-expected.txt:
platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
platform/gtk/css1/box_properties/margin_top-expected.txt:
platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
platform/gtk/css1/box_properties/padding-expected.txt:
platform/gtk/css1/box_properties/padding_bottom-expected.txt:
platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
platform/gtk/css1/box_properties/padding_inline-expected.txt:
platform/gtk/css1/box_properties/padding_left-expected.txt:
platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
platform/gtk/css1/box_properties/padding_right-expected.txt:
platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
platform/gtk/css1/box_properties/padding_top-expected.txt:
platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
platform/gtk/css1/box_properties/width-expected.txt:
platform/gtk/css1/cascade/cascade_order-expected.txt:
platform/gtk/css1/cascade/important-expected.txt:
platform/gtk/css1/classification/display-expected.txt:
platform/gtk/css1/classification/list_style-expected.txt:
platform/gtk/css1/classification/list_style_image-expected.txt:
platform/gtk/css1/classification/list_style_position-expected.txt:
platform/gtk/css1/classification/list_style_type-expected.txt:
platform/gtk/css1/classification/white_space-expected.txt:
platform/gtk/css1/color_and_background/background-expected.txt:
platform/gtk/css1/color_and_background/background_attachment-expected.txt:
platform/gtk/css1/color_and_background/background_color-expected.txt:
platform/gtk/css1/color_and_background/background_image-expected.txt:
platform/gtk/css1/color_and_background/background_position-expected.txt:
platform/gtk/css1/color_and_background/background_repeat-expected.txt:
platform/gtk/css1/color_and_background/color-expected.txt:
platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
platform/gtk/css1/font_properties/font-expected.txt:
platform/gtk/css1/font_properties/font_family-expected.txt:
platform/gtk/css1/font_properties/font_size-expected.txt:
platform/gtk/css1/font_properties/font_style-expected.txt:
platform/gtk/css1/font_properties/font_variant-expected.txt:
platform/gtk/css1/font_properties/font_weight-expected.txt:
platform/gtk/css1/formatting_model/canvas-expected.txt:
platform/gtk/css1/formatting_model/floating_elements-expected.txt:
platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
platform/gtk/css1/pseudo/anchor-expected.txt:
platform/gtk/css1/pseudo/firstletter-expected.txt:
platform/gtk/css1/pseudo/firstline-expected.txt:
platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/gtk/css1/text_properties/letter_spacing-expected.txt:
platform/gtk/css1/text_properties/line_height-expected.txt:
platform/gtk/css1/text_properties/text_align-expected.txt:
platform/gtk/css1/text_properties/text_decoration-expected.txt:
platform/gtk/css1/text_properties/text_indent-expected.txt:
platform/gtk/css1/text_properties/text_transform-expected.txt:
platform/gtk/css1/text_properties/vertical_align-expected.txt:
platform/gtk/css1/text_properties/word_spacing-expected.txt:
platform/gtk/css1/units/color_units-expected.txt:
platform/gtk/css1/units/length_units-expected.txt:
platform/gtk/css1/units/percentage_units-expected.txt:
platform/gtk/css1/units/urls-expected.txt:
platform/gtk/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
platform/gtk/fast/css/empty-pseudo-class-expected.txt:
platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
platform/gtk/fast/html/listing-expected.txt:
platform/gtk/fast/invalid/junk-data-expected.txt:
platform/gtk/fast/invalid/missing-end-tag-expected.txt:
platform/gtk/fast/loader/text-document-wrapping-expected.txt:
platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/gtk/fast/parser/xhtml-alternate-entities-expected.txt:
platform/gtk/fast/table/border-collapsing/004-expected.txt:
platform/gtk/fast/text/whitespace/001-expected.txt: Added.
platform/gtk/fast/text/whitespace/013-expected.txt:
platform/gtk/fast/text/whitespace/014-expected.txt:
platform/gtk/fast/text/whitespace/022-expected.txt: Added.
platform/gtk/fast/text/whitespace/024-expected.txt:
platform/gtk/fast/text/whitespace/030-expected.txt:
platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
platform/gtk/svg/custom/junk-data-expected.txt:
platform/gtk/svg/custom/missing-xlink-expected.txt:
platform/gtk/svg/custom/use-font-face-crash-expected.txt:
platform/gtk/svg/hixie/error/012-expected.txt:
platform/gtk/tables/mozilla/bugs/45621-expected.txt:
platform/gtk/tables/mozilla/bugs/bug139524-2-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:

2:13 PM Changeset in webkit [175345] by Alan Bujtas

4 edits
2 adds in trunk

Remove invalid float from RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=137707

Reviewed by Antti Koivisto.

In certain cases, floating boxes get attached to the last (root) inline box.
When this particular floating box gets destroyed, it also needs to be detached
from the last inline box.
Source/WebCore:

Introduce RootInlineBox::removeFloat() (vs. RootInlineBox::appendFloat())
Ensure that it is called when the floating box is being destroyed.

Test: fast/inline/crash-when-inline-box-has-invalid-float.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout): During style recalc, while
tearing down the render tree, we can get to a state where a block element has both inline and block children.
It happens when the style change on an element makes sibling anonymous block wrappers detached.
In that case the markAllDescendantsWithFloatsForLayout() call does not get propagated down on the
block child elements as we return early at the childrenInline() check.

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::removeFloat):

LayoutTests:

fast/inline/crash-when-inline-box-has-invalid-float-expected.txt: Added.
fast/inline/crash-when-inline-box-has-invalid-float.html: Added.

2:04 PM Changeset in webkit [175344] by rakuco@webkit.org

2 edits in trunk

[GTK] Bump libsoup's minimum version to 2.42.0.
https://bugs.webkit.org/show_bug.cgi?id=138086

Reviewed by Martin Robinson.

The SOUP_CHECK_VERSION macro was added in libsoup 2.41.1, and the
soup-version.h header was added to soup.h in 2.41.4, which then becomes
the minimum version required to build the port these days.

In addition, since the autotools build system required 2.42.0 before
being retired, require the same version here. Version 2.42.0 was also
recommended in
https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html.

Source/cmake/OptionsGTK.cmake:

2:00 PM Changeset in webkit [175343] by Antti Koivisto

7 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r175342.

a file ended up in a wrong directory

Reverted changeset:

"Factor cache validity computation functions out of
CachedResource"
https://bugs.webkit.org/show_bug.cgi?id=138156
http://trac.webkit.org/changeset/175342

1:54 PM Changeset in webkit [175342] by Antti Koivisto

7 edits
2 adds in trunk/Source/WebCore

Factor cache validity computation functions out of CachedResource
https://bugs.webkit.org/show_bug.cgi?id=138156

Reviewed by Andreas Kling.

These can be used to implement cache logic on WebKit level.

CMakeLists.txt:
WebCore.exp.in:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
loader/CacheValidation.cpp: Added.

(WebCore::computeCurrentAge):
(WebCore::computeFreshnessLifetimeForHTTPFamily):
(WebCore::updateRedirectChainStatus):
(WebCore::redirectChainAllowsReuse):

loader/CacheValidation.h: Added.

(WebCore::RedirectChainCacheStatus::RedirectChainCacheStatus):

loader/cache/CachedResource.cpp:

(WebCore::updateResponseHeadersAfterRevalidation):
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::isExpired):
(WebCore::CachedResource::freshnessLifetime):
(WebCore::CachedResource::willSendRequest):
(WebCore::CachedResource::updateResponseAfterRevalidation):
(WebCore::CachedResource::redirectChainAllowsReuse):
(WebCore::currentAge): Deleted.

loader/cache/CachedResource.h:

1:48 PM Changeset in webkit [175341] by matthew_hanson@apple.com

13 edits in branches/safari-600.3-branch/Source/WebKit2

Rollout r174369. <rdar://problem/18640842>

1:26 PM Changeset in webkit [175340] by matthew_hanson@apple.com

16 edits
2 copies
1 delete in branches/safari-600.3-branch

Merge r175335. rdar://problem/18709436

1:24 PM Changeset in webkit [175339] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Hide the 'Add to Photos' item if it isn't available
https://bugs.webkit.org/show_bug.cgi?id=138182
<rdar://problem/18814999>

Reviewed by Beth Dakin.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForImage]):
(-[WKActionMenuController _canAddImageToPhotos]):
(-[WKActionMenuController _addImageToPhotos:]):
Factor _canAddImageToPhotos out of _addImageToPhotos:, and use it in
_defaultMenuItemsForImage to avoid including the menu item in the first place.

12:53 PM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com

(diff)

12:08 PM Changeset in webkit [175338] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

Rename WebPageProxy::activeActionMenuHitTestResult to lastMouseMoveHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=138137
<rdar://problem/18798257>

Reviewed by Anders Carlsson.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::mouseDidMoveOverElement):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::lastMouseMoveHitTestResult):
(WebKit::WebPageProxy::activeActionMenuHitTestResult): Deleted.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForLink]):
(-[WKActionMenuController _openURLFromActionMenu:]):
(-[WKActionMenuController _addToReadingListFromActionMenu:]):
(-[WKActionMenuController _quickLookURLFromActionMenu:]):
(-[WKActionMenuController _saveImageToDownloads:]):
(imageForResource:name::if):
(-[WKActionMenuController _updateActionMenuItems]):
Rename to the more accurate and general name.

12:01 PM Changeset in webkit [175337] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Fix the branch pre-Yosemite build by moving an #if to encompass the whole file.

Misc/WebSharingServicePickerController.mm:

11:56 AM Changeset in webkit [175336] by adachan@apple.com

6 edits in trunk/Source/WebCore

Add API to mute/unmute a page.
https://bugs.webkit.org/show_bug.cgi?id=138150

Reviewed by Eric Carlson.

No new tests, since it's difficult to test whether the Page has indeed been muted.

dom/Document.cpp:

(WebCore::Document::setMuted):
Go through each AudioProducer and call setMuted() on it.

dom/Document.h:
page/AudioProducer.h:

Add setMuted(bool). HTMLMediaElement, the only derived class of AudioProducer so far,
has already implemented setMuted().

page/Page.cpp:

(WebCore::Page::setMuted):
Go through all its frames and call setMuted() on each frame's Document.

page/Page.h:

11:48 AM Changeset in webkit [175335] by timothy_horton@apple.com

19 edits
2 adds
1 delete in trunk

Implement action menus for data detected items
https://bugs.webkit.org/show_bug.cgi?id=138178
<rdar://problem/18709436>

Reviewed by Anders Carlsson.

WebCore.exp.in:

Export a symbol from Position that we need.

WebCore.xcodeproj/project.pbxproj:
platform/spi/mac/DataDetectorsSPI.h:

Add a combined SPI header for all of the random bits of DataDetectors that we use.

Shared/API/c/WKActionMenuTypes.h:

Add a new type.

Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

Shared/WebHitTestResult.h:

(WebKit::WebHitTestResult::isTextNode):
Determine, store, encode, and decode whether or not the hit node is a text node.

Shared/mac/ActionMenuHitTestResult.h:
Shared/mac/ActionMenuHitTestResult.mm: Renamed from Source/WebKit2/Shared/mac/ActionMenuHitTestResult.cpp.

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Make ActionMenuHitTestResult an Obj-C++ file.
Store, encode, and decode (securely!) a DDActionContext and FloatRect
representing the bounding box of the data detected item, if any.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:webView:]):
(-[WKView willOpenMenu:withEvent:]): Deleted.
Stop using willOpenMenu; we'll use NSMenuDelegate's menuNeedsUpdate: instead.
Hook up WKActionMenuController as our action menu's delegate.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController prepareForMenu:withEvent:]):
Call _updateActionMenuItems *after* we've adjusted _state, so that it
can depend on the value being correct.

(-[WKActionMenuController willOpenMenu:withEvent:]):
(-[WKActionMenuController didPerformActionMenuHitTest:]):
Move menu updating to menuNeedsUpdate for more accurate timing.

(_updateActionMenuItems):
When building the menu, if we have a text node that is not a link,
and hit a data detected item, retrieve the menu from the DDActionContext.
If we have nothing, make sure to reset _type, and if the final hit-test
is still pending, build a menu with a dummy item.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performActionMenuHitTestAtLocation): Moved to WebPageMac.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::rangeExpandedAroundPosition):
Factor this out of performDictionaryLookupAtLocation.

(WebKit::WebPage::performDictionaryLookupAtLocation):
Make use of rangeExpandedAroundPosition.

(WebKit::scanForDataDetectedItems):
Expand to four lines of context around the hit point.
Convert that range to plain text, and feed it to DataDetectors.
Find the result that intersects the hit point, and make a DDActionContext
for it. Also, store the bounding box of the first quad of the detected
text, to provide to Data Detectors as a hint for UI placement.

(WebKit::WebPage::performActionMenuHitTestAtLocation):
If the hit node is a text node, call scanForDataDetectedItems and
store the resultant DDActionContext and bounding rect on our
ActionMenuHitTestResult for transfer to the UI process.

WebKitSystemInterface.h:
libWebKitSystemInterfaceMavericks.a:
libWebKitSystemInterfaceMountainLion.a:
libWebKitSystemInterfaceYosemite.a:

Update WebKitSystemInterface.

11:22 AM Changeset in webkit [175334] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

[iOS] iPad: Occasional <select> crashes attempting to scroll to non-existing row 0 in viewWillAppear
https://bugs.webkit.org/show_bug.cgi?id=138165

Reviewed by David Kilzer.

This is a speculative fix for a crash attempting to scroll to a row in a
select picker on iPad. In these cases we are trying to scroll to the first
row of the first section, but no such row appears to exist. I was unable
to reproduce the issue, but if it is happening we should be able to protect
safely protect against crashing.

UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectTableViewController viewWillAppear:]):
Protect against trying to scroll to a section/row that does not exist
by pre-checking that the section/row is valid.

10:53 AM Changeset in webkit [175333] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[EME] NULL-dereference crash in MediaKeys::setMediaElement().
https://bugs.webkit.org/show_bug.cgi?id=138177

Reviewed by Eric Carlson.

NULL-check m_mediaElement->player() before using. It may have been cleared if the HTMLMediaElement
has previously had stop() called.

Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::setMediaElement):

10:53 AM Changeset in webkit [175332] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[EME] MediaKeySession resources persist across page reloads
https://bugs.webkit.org/show_bug.cgi?id=138176

Reviewed by Eric Carlson.

MediaKeySession is an ActiveDOMObject, so when told to stop() by our execution context,
close() the session, releasing all our resources.

Modules/encryptedmedia/MediaKeySession.h:

10:53 AM Changeset in webkit [175331] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[EME][Mac] MediaKeySession type "keyrelease" is ignored.
https://bugs.webkit.org/show_bug.cgi?id=138175

Reviewed by Eric Carlson.

To indicate that they would like to recevie expired session confirmation messages, clients
will create a MediaKeySession with a type parameter of "keyrelease". The code which validates
this type needs to be updated to recognize "keyrelease" as a valid type.

Also, the code which validates update() requests needs to allow updates containing the string
"acknowledged", so that clients can request the confirmation messages be discarded.

platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsMIMEType):

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::update):

10:41 AM Changeset in webkit [175330] by adachan@apple.com

7 edits in trunk/Source/WebCore

Remove MediaSessionClient::hasMediaCharacteristics() and MediaSessionClient::mediaStateDidChange().
https://bugs.webkit.org/show_bug.cgi?id=138153

Reviewed by Jer Noble.

After http://trac.webkit.org/changeset/175273, Document no longer keeps a set of MediaSessions
and it doesn't need to query each MediaSession for its characteristics and play state.
MediaSessionClient::hasMediaCharacteristics() is no longer needed and MediaSessionClient::mediaStateDidChange()
can be removed if HTMLMediaElement calls Document::updateIsPlayingAudio() after m_playing has changed.

No new tests, no behavior change.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState):
Call setPlaying() rather than setting m_playing directly.
(WebCore::HTMLMediaElement::setPlaying):
Update m_playing. If it has changed, call Document::updateIsPlayingAudio().
(WebCore::HTMLMediaElement::setPausedInternal):
Call setPlaying() rather than setting m_playing directly.
(WebCore::HTMLMediaElement::isPlayingAudio):
Call isPlaying() directly rather than checking the MediaSession's state.

html/HTMLMediaElement.h:
platform/audio/MediaSession.cpp:

(WebCore::MediaSession::setState):
MediaSessionClient::mediaStateDidChange() has been removed.
(WebCore::MediaSession::hasMediaCharacteristics): Deleted.

platform/audio/MediaSession.h:

(WebCore::MediaSessionClient::mediaStateDidChange): Deleted.

platform/audio/ios/AudioDestinationIOS.h:
platform/audio/mac/AudioDestinationMac.h:

10:16 AM Changeset in webkit [175329] by ap@apple.com

2 edits in trunk/LayoutTests

Update Mavericks results after https://bugs.webkit.org/show_bug.cgi?id=137275
(Speed up line parsing for simple line layout)

platform/mac-mavericks/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

8:09 AM Changeset in webkit [175328] by Chris Dumez

100 edits in trunk/Source/WebCore

Clean up virtual functions in html/
https://bugs.webkit.org/show_bug.cgi?id=138166

Reviewed by Andreas Kling.

Clean up virtual functions in html/ by:

Making virtual functions final when possible
Making classes final when possible
Using 'override' when appropriate
Explicitly marking functions / destructors as virtual when they are inherently virtual
Dropping virtual destructors when the class does not have subclasses and mark the class as final, to get rid of unnecessary vtables
Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks
De-virtualizing some functions that do not need to be virtual
Dropping final for virtual functions in classes already marked as final

No new tests, no behavior change.

html/ButtonInputType.h:
html/CheckboxInputType.h:
html/ColorInputType.h:
html/DOMSettableTokenList.h:
html/DateInputType.h:
html/DateTimeInputType.h:
html/DateTimeLocalInputType.h:
html/EmailInputType.h:
html/FTPDirectoryDocument.h:
html/HTMLAnchorElement.h:
html/HTMLDetailsElement.cpp:
html/HTMLFormControlElement.h:
html/HTMLFormControlsCollection.h:
html/HTMLFrameElement.h:
html/HTMLFrameElementBase.h:
html/HTMLFrameOwnerElement.h:
html/HTMLInputElement.h:
html/HTMLMarqueeElement.h:
html/HTMLMediaElement.h:
html/HTMLMediaSession.h:

(WebCore::HTMLMediaSession::requiresPlaybackTargetRouteMonitoring): Deleted.

html/HTMLMeterElement.h:
html/HTMLNameCollection.h:
html/HTMLObjectElement.h:
html/HTMLOptGroupElement.h:
html/HTMLOptionElement.h:
html/HTMLSpanElement.h:
html/HTMLStyleElement.h:
html/HTMLSummaryElement.cpp:
html/HTMLSummaryElement.h:
html/HTMLUnknownElement.h:
html/HTMLVideoElement.h:
html/HiddenInputType.h:
html/ImageInputType.h:
html/MediaKeyEvent.h:
html/MonthInputType.h:
html/NumberInputType.h:
html/PasswordInputType.h:
html/PublicURLManager.h:
html/RadioInputType.h:
html/ResetInputType.h:
html/SubmitInputType.h:
html/TelephoneInputType.h:
html/TextInputType.h:
html/TimeInputType.h:
html/URLInputType.h:
html/WeekInputType.h:
html/canvas/ANGLEInstancedArrays.h:
html/canvas/CanvasRenderingContext2D.h:
html/canvas/DOMPath.h:
html/canvas/EXTShaderTextureLOD.h:
html/canvas/EXTTextureFilterAnisotropic.h:
html/canvas/OESElementIndexUint.h:
html/canvas/OESStandardDerivatives.h:
html/canvas/OESTextureFloat.h:
html/canvas/OESTextureFloatLinear.h:
html/canvas/OESTextureHalfFloat.h:
html/canvas/OESTextureHalfFloatLinear.h:
html/canvas/OESVertexArrayObject.h:
html/canvas/WebGLBuffer.h:
html/canvas/WebGLCompressedTextureATC.h:
html/canvas/WebGLCompressedTexturePVRTC.h:
html/canvas/WebGLCompressedTextureS3TC.h:
html/canvas/WebGLContextAttributes.h:
html/canvas/WebGLContextEvent.h:
html/canvas/WebGLDebugRendererInfo.h:
html/canvas/WebGLDebugShaders.h:
html/canvas/WebGLDepthTexture.h:
html/canvas/WebGLDrawBuffers.h:
html/canvas/WebGLFramebuffer.h:

(WebCore::WebGLFramebuffer::isFramebuffer): Deleted.

html/canvas/WebGLLoseContext.h:
html/canvas/WebGLProgram.h:
html/canvas/WebGLRenderbuffer.h:
html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLShader.h:
html/canvas/WebGLSharedObject.h:

(WebCore::WebGLSharedObject::isFramebuffer): Deleted.

html/canvas/WebGLTexture.h:
html/canvas/WebGLVertexArrayObjectOES.h:

(WebCore::WebGLVertexArrayObjectOES::isVertexArray): Deleted.

html/shadow/ImageControlsRootElement.h:
html/shadow/InsertionPoint.h:
html/shadow/MediaControlElementTypes.h:
html/shadow/MediaControlElements.h:
html/shadow/MediaControls.h:
html/shadow/MediaControlsApple.h:
html/shadow/SpinButtonElement.h:
html/track/AudioTrack.h:
html/track/AudioTrackList.h:
html/track/DataCue.h:

(WebCore::DataCue::cueType): Deleted.

html/track/InbandDataTextTrack.h:
html/track/InbandGenericTextTrack.h:
html/track/InbandTextTrack.h:
html/track/InbandWebVTTTextTrack.h:
html/track/LoadableTextTrack.h:
html/track/TextTrackList.h:
html/track/TrackEvent.h:
html/track/VTTCue.h:

(WebCore::VTTCueBox::setFontSizeFromCaptionUserPrefs):

html/track/VTTRegion.h:
html/track/VideoTrack.h:
html/track/VideoTrackList.h:
html/track/WebVTTParser.h:

(WebCore::WebVTTCueData::~WebVTTCueData): Deleted.

3:45 AM Changeset in webkit [175327] by Csaba Osztrogonác

2 edits in trunk/Tools

[EFL] build-webkit should try harder to avoid re-running cmake
https://bugs.webkit.org/show_bug.cgi?id=137949

Reviewed by Martin Robinson.

Scripts/webkitdirs.pm:

(shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
(generateBuildSystemFromCMakeProject): Comment fix after r174681.

1:59 AM Changeset in webkit [175326] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175256. rdar://problem/18798121

1:57 AM Changeset in webkit [175325] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175238. rdar://problem/18797743

1:54 AM Changeset in webkit [175324] by Lucas Forschler

4 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r175229. rdar://problem/18451638

1:51 AM Changeset in webkit [175323] by Lucas Forschler

6 edits
1 copy in branches/safari-600.3-branch/Source/WebKit2

Merged r175193. rdar://problem/18451638

1:49 AM Changeset in webkit [175322] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175190. <rdar://problem/18767397>

1:47 AM Changeset in webkit [175321] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175187. rdar://problem/18767859

1:44 AM Changeset in webkit [175320] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175185. rdar://problem/18758758

1:42 AM Changeset in webkit [175319] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175184. rdar://problem/18758758

1:40 AM Changeset in webkit [175318] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175181. rdar://problem/18758758

1:37 AM Changeset in webkit [175317] by Lucas Forschler

3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175180. rdar://problem/18758758

1:33 AM Changeset in webkit [175316] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r175179. rdar://problem/18758758

1:30 AM Changeset in webkit [175315] by Lucas Forschler

3 edits
2 copies in branches/safari-600.3-branch/Source/WebKit2

Merged r175178. rdar://problem/18758758

1:30 AM Changeset in webkit [175314] by svillar@igalia.com

3 edits
2 adds in trunk

ASSERTION FAILED: growthShare > 0 in WebCore::RenderGrid::distributeSpaceToTracks
https://bugs.webkit.org/show_bug.cgi?id=137772

Reviewed by Andreas Kling.

Source/WebCore:

We're hitting the ASSERTION because if the number of tracks an
item spans does greatly exceed the available logical space, then
the result of the division availableLogicalSpace/numberOfTracks is
truncated to 0. So the ASSERTION was theoretically right because
the result has to be always >0 (as the dividend > 0) but the fact
that the result is a LayoutUnit forces us to accept 0 as a valid
outcome of the operation.

Test: fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::distributeSpaceToTracks):

LayoutTests:

fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash-expected.txt: Added.
fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash.html: Added.

1:00 AM Changeset in webkit [175313] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WTF

Partial merge of r172749. rdar://problem/18757166

12:58 AM Changeset in webkit [175312] by Chris Dumez

3 edits
2 adds in trunk

Crash in CachedRawResource::canReuse() when reloading http://dnd.wizards.com/dungeons-and-dragons/story
https://bugs.webkit.org/show_bug.cgi?id=138164

Reviewed by Andreas Kling.

Source/WebCore:

This patch fixes a crash when reloading the following URL:
http://dnd.wizards.com/dungeons-and-dragons/story

We were crashing in CachedRawResource::canReuse() because header.key
would sometimes be a null String and we would call
HashMap::get(nullString).

The real issue was that header.key was null in the first place, which
means that even though the HTTPHeaderMap iterator is valid, it->key
is a null String, which should never happen. There was a bug in the
HTTPHeaderMapConstIterator() constructor that would cause the
iterator key/value pair to not get initialized if the HTTPHeaderMap
contained *only* uncommon HTTP headers. This patch updates the
constructor so that we fall back to updating the key/value from the
uncommon header map, if we failed to initialized from the common
header map (because it was empty).

Test: http/tests/cache/xhr-uncommon-header.html

platform/network/HTTPHeaderMap.h:

(WebCore::HTTPHeaderMap::HTTPHeaderMapConstIterator::HTTPHeaderMapConstIterator):

LayoutTests:

Add a layout test that does XHR loads from cache with only uncommon
HTTP headers to reproduce a crash in CachedRawResource::canReuse()
when iterating over a HTTPHeaderMap that had uncommon HTTP headers
but no common ones.

http/tests/cache/xhr-uncommon-header-expected.txt: Added.
http/tests/cache/xhr-uncommon-header.html: Added.

12:54 AM Changeset in webkit [175311] by Lucas Forschler

12 edits
3 copies
1 add in branches/safari-600.3-branch/Source

Merged r175147. rdar://problem/18757166

12:18 AM Changeset in webkit [175310] by Lucas Forschler

9 edits in branches/safari-600.3-branch

Merged r172542. rdar://problem/18757166

Oct 28, 2014:

11:33 PM Changeset in webkit [175309] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

11:28 PM Changeset in webkit [175308] by bshafiei@apple.com

1 copy in tags/Safari-601.1.6

New tag.

9:58 PM Changeset in webkit [175307] by Lucas Forschler

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merged r175183. rdar://problem/18451638

9:55 PM Changeset in webkit [175306] by Lucas Forschler

6 edits
3 copies in branches/safari-600.3-branch/Source/WebKit

Merged r175182. rdar://problem/18451638

9:34 PM Changeset in webkit [175305] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r175132. <rdar://problem/18753175>

9:32 PM Changeset in webkit [175304] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r174841. <rdar://problem/18753175>

9:28 PM Changeset in webkit [175303] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r174837. <rdar://problem/18753175>

9:24 PM Changeset in webkit [175302] by dburkart@apple.com

21 edits
2 copies in branches/safari-600.3-branch/Source

Merge r174791. <rdar://problem/18753175>

9:21 PM Changeset in webkit [175301] by benjamin@webkit.org

19 edits
6 adds in trunk

CSS4 Selectors: Add the pseudo class :any-link
https://bugs.webkit.org/show_bug.cgi?id=138128

Reviewed by Andreas Kling.

Source/WebCore:

Defined here: http://dev.w3.org/csswg/selectors4/#the-any-link-pseudo

After :link and :-webkit-any-link were fixed, :any-link behaves
exactly like :-webkit-any-link. All I had left to do here was
make them synonyms when evaluating selectors.

Defined here: http://dev.w3.org/csswg/selectors4/#the-any-link-pseudo

After :link and :-webkit-any-link were fixed, :any-link behaves
exactly like :-webkit-any-link. All I had left to do here was
make them synonyms when evaluating selectors.

Tests: fast/selectors/any-link-basics-2.html

fast/selectors/any-link-basics.html
fast/selectors/any-link-styling.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:
css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):

LayoutTests:

Story time: I implement only half of the patch and run
fast/selectors/webkit-any-link.html to make sure it fails...
and the test happily PASS.

I look into it and sure enough, a last minute change in
html-link-type-tests.js made it test nothing but :link.

I update html-link-type-tests.js to actually test the desired selector,
run the test again: PASS.

I debug a bit and I find why my code is not tested: html-link-type-tests.js
uses Element.matches() and that does not use the CSS JIT.

Fair enough, I add a querySelectorAll("#target' + selector + '") to run
through the JIT: PASS.

Since that selector is simple-#id + simple selector, we go through a fast
path for ids and skip the JIT. Arrrrg!

Finally, I added querySelectorAll(".target' + selector + '"), which covers
the CSS JIT.

The nice thing is: all those cases are tested now :)

fast/css/css-selector-text-expected.txt:
fast/css/css-selector-text.html:
fast/css/css-set-selector-text-expected.txt:
fast/css/css-set-selector-text.html:
fast/selectors/any-link-basics-2-expected.txt: Added.
fast/selectors/any-link-basics-2.html: Added.
fast/selectors/any-link-basics-expected.txt: Added.
fast/selectors/any-link-basics.html: Added.
fast/selectors/any-link-styling-expected.html: Added.
fast/selectors/any-link-styling.html: Added.
fast/selectors/images-with-usemap-should-not-match-link-expected.txt:
fast/selectors/images-with-usemap-should-not-match-link.html:
fast/selectors/link-basics-expected.txt:
fast/selectors/link-basics-xhtml-expected.txt:
fast/selectors/resources/html-link-type-tests.js:

(testHTMLElement):
(testHTMLTagsForLink):

fast/selectors/webkit-any-link-basics-expected.txt:

9:11 PM Changeset in webkit [175300] by dburkart@apple.com

7 edits in branches/safari-600.3-branch

Merge r174525. <rdar://problem/18640876>

9:04 PM Changeset in webkit [175299] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Cast std::chrono::duration.count() to int64_t in ArgumentCoder
https://bugs.webkit.org/show_bug.cgi?id=136981

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-10-28
Reviewed by Alexey Proskuryakov.

Explicitly cast the return value of std::chrono::duration.count() to
a fixed-size interger type, which prevents compilation error when
the return value type matches neither int32_t nor int64_t.

Platform/IPC/ArgumentCoders.h:

8:39 PM Changeset in webkit [175298] by dburkart@apple.com

2 deletes in branches/safari-600.3-branch/Source/WebKit2/WebProcess/WebPage

Forgot to delete a couple files from merging r174524 (rdar://problem/18640868)

8:34 PM Changeset in webkit [175297] by dburkart@apple.com

21 edits
2 copies in branches/safari-600.3-branch/Source

Merge r174524. <rdar://problem/18640868>

7:26 PM Changeset in webkit [175296] by dburkart@apple.com

54 edits
6 copies
4 deletes in branches/safari-600.3-branch/Source

Merged r174231. rdar://problem/18640833

6:28 PM Changeset in webkit [175295] by dbates@webkit.org

2 edits in trunk/Tools

Unify logic in RunTests.run() to run the Python unit tests
https://bugs.webkit.org/show_bug.cgi?id=138160

Reviewed by Martin Robinson.

Unify the interactive and non-interactive code path for running the Python unit tests
in step RunTests so as to remove duplicate code to compute the the path to the script
test-webkitpy and log an informative message ("Running Python unit tests") to the console.

No new tests since no functionality was changed.

Scripts/webkitpy/port/base.py:

(Port.python_unittest_results_directory):

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

5:58 PM Changeset in webkit [175294] by commit-queue@webkit.org

3 edits in trunk/Tools

Make runtest.py call test-webkitpy with the --json flag when in
non-interactive mode.
https://bugs.webkit.org/show_bug.cgi?id=137667

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-10-28
Reviewed by Daniel Bates.

Scripts/webkitpy/port/base.py:

Adds the python_unittest_results_directory method.
(Port.python_unittest_results_directory):

Scripts/webkitpy/tool/steps/runtests.py:

Changes RunTests to call test-webkitpy with the --json flag if the
--non-interactive flag is set.
(RunTests):
(RunTests.run):

5:53 PM Changeset in webkit [175293] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174541. <rdar://problem/18753175>

5:32 PM Changeset in webkit [175292] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174516. <rdar://problem/18640864>

5:29 PM Changeset in webkit [175291] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174457. <rdar://problem/18640864>

5:27 PM Changeset in webkit [175290] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebCore

Merge r174456. <rdar://problem/18640864>

5:22 PM Changeset in webkit [175289] by dburkart@apple.com

13 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r174369. <rdar://problem/18640842>

5:18 PM Changeset in webkit [175288] by jer.noble@apple.com

22 edits
2 adds in trunk/Source/WebKit2

[EME] Pass location for media key storage through from WebKit/WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=137120

Reviewed by Anders Carlsson.

Allow the location for media key storage to be passed into the WebProcess from the UIProcess
through the WebContextConfiguraiton struct.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Add mediaKeysStorageDirectory.
(WebKit::WebProcessCreationParameters::decode): Ditto.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyMediaKeysStorageDirectory): Added getter.
(WKContextConfigurationSetMediaKeysStorageDirectory): Added setter.

UIProcess/API/C/WKContextConfigurationRef.h:
UIProcess/API/C/WKOriginDataManager.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]): Provide a default location.

UIProcess/APIContextConfiguration.cpp:

(API::ContextConfiguration::webContextConfiguration): Set mediaKeysStorageDirectory.

UIProcess/APIContextConfiguration.h:

(API::ContextConfiguration::mediaKeysStorageDirectory): Added getter.
(API::ContextConfiguration::setMediaKeysStorageDirectory): Added setter.

UIProcess/WebContext.cpp:

(WebKit::WebContext::applyPlatformSpecificConfigurationDefaults): Apply mediaKeysStorageDirectory.
(WebKit::WebContext::WebContext): Initialize m_mediaKeysStorageDirectory.
(WebKit::WebContext::createNewWebProcess): Create a sandbox extension handle for mediaKeysStorageDirectory.

UIProcess/WebContext.h:
UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Return a default location.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Ditto.

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Return an overridable default location.

WebProcess/MediaCache/WebMediaKeyStorageManager.cpp: Added.

(WebKit::WebMediaKeyStorageManager::initialize): Pull the mediaKeysStorageDirectory out of configuration.
(WebKit::WebMediaKeyStorageManager::supplementName): Return a configuration name.
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectoryForOrigin): Return the

correct storage directory based on the SecureOrigin.

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins): Return the origins within the

storage directory.

(WebKit::removeAllMediaKeyStorageForOriginPath): Static, remove contents and directory at path.
(WebKit::WebMediaKeyStorageManager::deleteMediaKeyEntriesForOrigin): Use

removeAllMediaKeyStorageForOriginPath to remove origin data.

(WebKit::WebMediaKeyStorageManager::deleteMediaKeyEntriesModifiedBetweenDates): Ditto.
(WebKit::WebMediaKeyStorageManager::deleteAllMediaKeyEntries): Ditto.

WebProcess/MediaCache/WebMediaKeyStorageManager.h: Added.

(WebKit::WebMediaKeyStorageManager::WebMediaKeyStorageManager): Default constructor.
(WebKit::WebMediaKeyStorageManager::~WebMediaKeyStorageManager): Default virtual destructor.
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectory): Simple accessor.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add WebMediaKeyStorageManager as a supplement.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Create a sandbox extension from the sandbox extension handle.

Add new source files to project(s).

PlatformEfl.cmake:
PlatformGTK.cmake:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins):
(WebKit::removeAllMediaKeyStorageForOriginPath):

Drive-by fix: references to VoidCallback are ambiguous, since the same name is re-used in multiple namespaces.
Make references to WebCore::VoidCallback explicit where the entire WebCore (and other) namespaces are pulled in.

WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::requestPermission):

5:13 PM Changeset in webkit [175287] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174368. <rdar://problem/18753175>

4:54 PM Changeset in webkit [175286] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174321. <rdar://problem/18753175>

4:51 PM Changeset in webkit [175285] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit

Merge r174320. <rdar://problem/18753175>

4:51 PM Changeset in webkit [175284] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[EME][Mac] Adopt new AVStreamSession API: pass storageDirectoryAtURL at creation-time
https://bugs.webkit.org/show_bug.cgi?id=138149

Reviewed by Brent Fulgham.

AVStreamSession now requires its storage location at creation-time, rather than post-creation. This requires
us to move storage location code from CDMSessionMediaSourceAVFObjC to MediaPlayerPrivateMediaSourceAVFObjC.

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]): Renamed.
(WebCore::CDMSessionMediaSourceAVFObjC::update):
(WebCore::sessionStorageDirectory): Deleted.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::sessionStorageDirectory):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

4:50 PM Changeset in webkit [175283] by ggaren@apple.com

2 edits in trunk/Source/WebCore

All networking crashes on Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=138157

Reviewed by Andy Estes.

NEFilterSource content filtering is not available on 32bit, so
soft-linking fails at runtime. The simplest solution is just to disable
it at compile time.

platform/ContentFilter.h:

4:49 PM Changeset in webkit [175282] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.12-branch/Source

Versioning.

4:38 PM Changeset in webkit [175281] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r174257. <rdar://problem/18753175>

4:28 PM Changeset in webkit [175280] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.12.3

New tag.

4:14 PM Changeset in webkit [175279] by commit-queue@webkit.org

26 edits in trunk/Source

Add optimized fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=138044

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-10-28
Source/WebCore:

Reviewed by Jer Noble.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
Add gesture for alternate fullscreen.

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::enterFullscreenOptimized): added

Modules/mediacontrols/MediaControlsHost.h: added enterFullscreenOptimized
Modules/mediacontrols/MediaControlsHost.idl: added enterFullscreenOptimized
Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handleBaseGestureChange): recognize alternate gesture

WebCore.exp.in: added parameter to setupFullscreen
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFrom) : replace m_isInVideoFullscreen with m_videoFullscreenType
(WebCore::HTMLMediaElement::stop) : ditto
(WebCore::HTMLMediaElement::isFullscreen) : ditto
(WebCore::HTMLMediaElement::enterFullscreen): add parameter to enterVideoFullscreenForVideoElement
(WebCore::HTMLMediaElement::exitFullscreen): replace m_isInVideoFullscreen with m_videoFullscreenType
(WebCore::HTMLMediaElement::enterFullscreenOptimized): added

html/HTMLMediaElement.h: added enterFullscreenOptimized
page/ChromeClient.h:

(WebCore::ChromeClient::enterVideoFullscreenForVideoElement): added parameter

platform/ios/WebVideoFullscreenControllerAVKit.h: add parameter
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController enterFullscreen:type:]): add parameter
(-[WebVideoFullscreenController enterFullscreen:]): Deleted.

platform/ios/WebVideoFullscreenInterfaceAVKit.h: reorder protected to after public
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController player]): this stub is now required
(-[WebAVPlayerController layoutSublayersOfLayer:]): this is a better way to update video frames
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): implement optimized fullscreen interface
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto

Source/WebKit/mac:

Reviewed by Jer Noble.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.

WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::enterVideoFullscreenForVideoElement): ditto

WebView/WebView.mm:

(-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
(-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.

WebView/WebViewInternal.h: ditto

Source/WebKit2:

Reviewed by Anders Carlsson.

Enable different types of fullscreen video behavior.
Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.

UIProcess/ios/WebVideoFullscreenManagerProxy.h: Add fullscreenType parameter
UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: ditto
UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): ditto

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::enterVideoFullscreenForVideoElement): ditto

WebProcess/WebCoreSupport/WebChromeClient.h: ditto
WebProcess/ios/WebVideoFullscreenManager.h: ditto
WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): ditto
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen): ditto

3:42 PM Changeset in webkit [175278] by Chris Dumez

27 edits in trunk/Source/WebCore

Clean up virtual functions in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=138148

Reviewed by Chris Fleizach.

Clean up virtual functions in accessibility/ by:

Marking classes as final when suitable
Marking virtual functions as final when suitable
Dropping final on virtual functions in classes that are already final
Make isXXX() virtual type checking functions in XXX classes to avoid useless type checks

No new tests, no behavior change.

accessibility/AccessibilityARIAGrid.h:
accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityARIAGridRow.h:
accessibility/AccessibilityImageMapLink.h:
accessibility/AccessibilityList.h:
accessibility/AccessibilityListBox.h:
accessibility/AccessibilityListBoxOption.h:
accessibility/AccessibilityMediaControls.h:
accessibility/AccessibilityMenuList.h:
accessibility/AccessibilityMenuListOption.h:
accessibility/AccessibilityMenuListPopup.h:
accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::setParent):

accessibility/AccessibilityNodeObject.h:
accessibility/AccessibilityProgressIndicator.h:
accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilitySVGRoot.h:
accessibility/AccessibilityScrollView.h:
accessibility/AccessibilityScrollbar.h:
accessibility/AccessibilitySearchFieldButtons.h:
accessibility/AccessibilitySlider.h:
accessibility/AccessibilitySpinButton.h:
accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.h:
accessibility/AccessibilityTableColumn.h:
accessibility/AccessibilityTableHeaderContainer.h:
accessibility/AccessibilityTableRow.h:

3:38 PM Changeset in webkit [175277] by jpfau@apple.com

2 edits in trunk/Source/WebCore

FrameProgressTracker expects Page to not have detached
https://bugs.webkit.org/show_bug.cgi?id=138061

Reviewed by Alexey Proskuryakov.

In some cases, a Page may be detached from a Frame before its
FrameLoader is torn down, causing FrameProgressTracker's destructor
to hit a null pointer.

No new tests; it is impossible to reliably simulate the null pointer
case without intrusive code changes.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):

3:36 PM Changeset in webkit [175276] by dburkart@apple.com

8 edits
2 copies in branches/safari-600.3-branch

Merge r174190. <rdar://problem/18640846>

3:15 PM Changeset in webkit [175275] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Added a Radar reference to a comment.

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData):

3:14 PM Changeset in webkit [175274] by dburkart@apple.com

3 edits
4 copies in branches/safari-600.3-branch

Merge r173184. <rdar://problem/18428699>

3:00 PM Changeset in webkit [175273] by adachan@apple.com

8 edits
1 add in trunk/Source/WebCore

Introduce a new abstract class called AudioProducer and keep a set of AudioProducers
rather than the active MediaSessions in Document
https://bugs.webkit.org/show_bug.cgi?id=138107

Reviewed by Eric Carlson.

No new tests, no behavior change.

WebCore.xcodeproj/project.pbxproj:

Add AudioProducer.h to the project.

dom/Document.cpp:

(WebCore::Document::addAudioProducer):
(WebCore::Document::removeAudioProducer):
(WebCore::Document::updateIsPlayingAudio):
Go through the set of AudioProducers and see if any is playing audio.
Now that this method no longer refers to MediaSessions directly, this code
does not need to be guarded by #if ENABLE(VIDEO).
(WebCore::Document::registerMediaSession): Deleted.
(WebCore::Document::unregisterMediaSession): Deleted.

dom/Document.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::isPlayingAudio):
Return whether this element is playing audio.

html/HTMLMediaElement.h:
page/AudioProducer.h: Added.

(WebCore::AudioProducer::~AudioProducer):

page/Page.cpp:

(WebCore::Page::updateIsPlayingAudio):
This is no longer guarded with #if ENABLE(VIDEO) since the Document methods it calls
are no longer guarded.

page/Page.h:

2:42 PM Changeset in webkit [175272] by dburkart@apple.com

4 edits
2 copies in branches/safari-600.3-branch

Merge r173181. rdar://problem/18428697

1:12 PM Changeset in webkit [175271] by ap@apple.com

2 edits in trunk/LayoutTests

fast/multicol/multicol-crazy-nesting.html sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=138145

TestExpectations: Skipping for now.

1:01 PM Changeset in webkit [175270] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] REGERESSION (r171801): Client certificate authentication is failing
https://bugs.webkit.org/show_bug.cgi?id=138144

Reviewed by Alexey Proskuryakov.

NSURLCredential’s implementation of NSSecureCoding fails to encode identity-based
credentials properly. Work around that by encoding the identity, certificate, and
persistence individually.

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::decodePlatformData):

12:57 PM Changeset in webkit [175269] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed comment fix from r175267.

Fix namespace name in comment.

css/StyleBuilderCustom.h:

12:37 PM Changeset in webkit [175268] by jer.noble@apple.com

39 edits
2 copies in trunk

REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) backing store
https://bugs.webkit.org/show_bug.cgi?id=137757

Reviewed by Eric Carlson.

Source/WebCore:

In r171593, a <div> was added to the media controls which is only ever used on iOS. Instead
of creating and adding this <div> in mediaControlsApple.js (which is used on OS X), this
<div> should be created and added in mediaControlsiOS.js, which requires overloading
Controller.addControls.

Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel.hidden): Drive-by fix: allow the panel itself to be hidden.
(video::-webkit-media-controls-panel-composited-parent): Deleted.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls): Remove the composited parent.
(Controller.prototype.addControls): Ditto.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.createControls): Create the composited parent.
(ControllerIOS.prototype.addControls): Copied from (previous) apple.js.

LayoutTests:

platform/mac-mavericks/media/audio-controls-rendering-expected.png:
platform/mac-mavericks/media/audio-controls-rendering-expected.txt:
platform/mac-mavericks/media/controls-strict-expected.txt:
platform/mac-mavericks/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.txt.
platform/mac-mavericks/media/video-controls-rendering-expected.txt:
platform/mac-mavericks/media/video-display-toggle-expected.txt:
platform/mac-mavericks/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
platform/mac-mavericks/media/video-no-audio-expected.png:
platform/mac-mavericks/media/video-no-audio-expected.txt:
platform/mac-mavericks/media/video-volume-slider-expected.txt:
platform/mac-mavericks/media/video-zoom-controls-expected.png:
platform/mac-mavericks/media/video-zoom-controls-expected.txt:
platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
platform/mac/fast/layers/video-layer-expected.txt:
platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/controls-without-preload-expected.png:
platform/mac/media/controls-without-preload-expected.txt:
platform/mac/media/media-controls-clone-expected.png:
platform/mac/media/media-controls-clone-expected.txt:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-empty-source-expected.png:
platform/mac/media/video-empty-source-expected.txt:
platform/mac/media/video-no-audio-expected.png:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-volume-slider-expected.png:
platform/mac/media/video-volume-slider-expected.txt:
platform/mac/media/video-zoom-controls-expected.png:
platform/mac/media/video-zoom-controls-expected.txt:

12:12 PM Changeset in webkit [175267] by Chris Dumez

6 edits
1 add in trunk/Source/WebCore

Move "Number" CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138125

Reviewed by Antti Koivisto.

Move "Number" CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder:
-webkit-hyphenate-limit-after
-webkit-hyphenate-limit-before
-webkit-shape-image-threshold
-webkit-hyphenate-limit-lines

They are now generated from CSSPropertyNames.in

For -webkit-hyphenate-limit-lines, I used custom code instead of
the Number converter as it required special handling for the id
value. This patch thus adds support for [Custom=Value] to
CSSPropertyNames.in and the custom code goes into
css/StyleBuilderCustom.h.

No new tests, no behavior change.

WebCore.xcodeproj/project.pbxproj:
css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyNumber::setValue): Deleted.
(WebCore::ApplyPropertyNumber::applyValue): Deleted.
(WebCore::ApplyPropertyNumber::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertNumber):

css/StyleBuilderCustom.h: Added.

(WebCore::StyleBuilderFunctions::applyValueWebkitHyphenateLimitLines):

css/makeprop.pl:

12:05 PM Changeset in webkit [175266] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

[iOS] iPhone should not allow selecting <optgroup> in <select multiple>
https://bugs.webkit.org/show_bug.cgi?id=137991

Reviewed by Darin Adler.

We seem to be getting the delegate when we are not supposed to.
Workaround the issue as best we can by reseting the styles
for the group's content view and not changing selections.

UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker pickerView:row:column:checked:]):

11:46 AM Changeset in webkit [175265] by zandobersek@gmail.com

7 edits in trunk/Source/WebCore

[WebCore] Remove uses of WTF::bind() in the Media Stream module
https://bugs.webkit.org/show_bug.cgi?id=138016

Reviewed by Eric Carlson.

Replace uses of WTF::bind() in the Media Stream module with C++11 lambdas.
Internal helper methods are removed in favor of inlining the code directly
into the lambdas. Range-based for-loops are deployed where appropriate.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::scheduleEventDispatch):
(WebCore::MediaStreamTrack::dispatchQueuedEvents): Deleted.

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/MediaStreamTrackSourcesRequest.cpp:

(WebCore::MediaStreamTrackSourcesRequest::didCompleteRequest):
(WebCore::MediaStreamTrackSourcesRequest::callCompletionHandler): Deleted.

Modules/mediastream/MediaStreamTrackSourcesRequest.h:
Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::userMediaAccessGranted):
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError):
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError):
(WebCore::UserMediaRequest::requestPermission): Deleted.
(WebCore::UserMediaRequest::createMediaStream): Deleted.
(WebCore::UserMediaRequest::callSuccessHandler): Deleted.
(WebCore::UserMediaRequest::callErrorHandler): Deleted.

Modules/mediastream/UserMediaRequest.h:

11:35 AM Changeset in webkit [175264] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

text-combine needs to center glyphs within the vertical area.
https://bugs.webkit.org/show_bug.cgi?id=138056

Adding pre-Yosemite test results.

platform/mac-mavericks/fast/text/tatechuyoko-expected.png: Added.
platform/mac-mavericks/fast/text/tatechuyoko-expected.txt: Added.

11:05 AM Changeset in webkit [175263] by commit-queue@webkit.org

3 edits
2 adds in trunk

Abandoned select option is reselected when shift selecting new options
https://bugs.webkit.org/show_bug.cgi?id=137553

Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-10-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Previous active selection is wrongly recorded by HTMLSelectElement after selecting a new item using
typeAhead. Fixed by clearing previously selected options before starting a new active selection.

Test: fast/forms/listbox-selection-after-typeahead.html

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption): Code re-ordering

LayoutTests:

Test checking a combination of mouse and keyboard selection events
on select-multiple element

fast/forms/listbox-selection-after-typeahead-expected.txt: Added.
fast/forms/listbox-selection-after-typeahead.html: Added.

11:01 AM Changeset in webkit [175262] by rniwa@webkit.org

4 edits in trunk/Websites/perf.webkit.org

Remove App.PaneController.bugsChangeCount in the new perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=138111

Reviewed by Darin Adler.

public/v2/app.js:

(App.PaneController.bugsChangeCount): Removed.
(App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
(App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
Finds the list of current run's points that are associated with bugs.
(App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.

public/v2/chart-pane.css:

(.chart .marked): Renamed from .hasBugs.

public/v2/index.html: Specify chartPointRadius and markedPoints.

11:00 AM Changeset in webkit [175261] by commit-queue@webkit.org

6 edits in trunk/Source

Use constants from wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=137967

Patch by Milan Crha <mcrha@redhat.com> on 2014-10-28
Reviewed by Darin Adler.

Source/WebCore:

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::rotateCairoMatrixForVerticalOrientation):

rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator):

Source/WTF:

wtf/MathExtras.h:

10:58 AM Changeset in webkit [175260] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Selection gap painting is ugly for ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=138136

Reviewed by Dean Jackson.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGaps):
For ruby bases don't fill to the end of the block (in the block direction),
since ideographic baselines push that end below the text baseline.

(WebCore::RenderBlock::blockSelectionGaps):

rendering/RenderBlockFlow.cpp:

Skip ruby bases for block selection gap filling.

10:57 AM Changeset in webkit [175259] by Alan Bujtas

142 edits
4 adds in trunk

Speed up line parsing for simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=137275

Reviewed by Antti Koivisto.
Source/WebCore:

This patch speeds up the line parsing for simple line layout by
reducing the number of text measurement calls.
The parsing logic hasn't changed. We simply walk over
the whitespace/non-whitespace fragments and measure them to
figure out whether they fit.
The performance gain mainly comes from the more efficient line wrapping
so that we don't re-measure the fragment when it is pushed to
the next line.

No change in behaviour. (except the empty line-break run removal.)

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::skipWhitespace):
(WebCore::SimpleLineLayout::computeLineLeft):
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::TextFragment::isEmpty):
(WebCore::SimpleLineLayout::LineState::LineState):
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): adds uncommitted text to the line and creates a run out of it.
(WebCore::SimpleLineLayout::LineState::addUncommitted): appends fragment to the uncommitted text.
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace): appends whitespace to the uncommitted text.
(WebCore::SimpleLineLayout::LineState::jumpTo): moves line's current position without committing text.
(WebCore::SimpleLineLayout::LineState::width): current width of the line including committed and uncommitted text.
(WebCore::SimpleLineLayout::LineState::fits): checks if committed + uncommitted text fits the line.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace): post processing the trailing whitespace.
(WebCore::SimpleLineLayout::initializeLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine): breaks the fragments into 2 so that the first (sub)fragment fits the line.
(WebCore::SimpleLineLayout::nextFragment): returns the next valid fragment of the text.
(WebCore::SimpleLineLayout::createLineRuns): creates runs for the current line and returns when we can't fit more text on the line.
(WebCore::SimpleLineLayout::updateLineConstrains): updates left/right constrains for the current line.
(WebCore::SimpleLineLayout::createTextRuns): creates runs for the whole text.
(WebCore::SimpleLineLayout::isWhitespace): Deleted.
(WebCore::SimpleLineLayout::skipWhitespaces): Deleted.
(WebCore::SimpleLineLayout::measureWord): Deleted.
(WebCore::SimpleLineLayout::adjustRunOffsets): Deleted.

rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Run::Run):

LayoutTests:

This patch removes empty line-break runs. Rebaseline.

platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/css1/basic/containment-expected.txt:
platform/mac/css1/basic/contextual_selectors-expected.txt:
platform/mac/css1/basic/grouping-expected.txt:
platform/mac/css1/basic/id_as_selector-expected.txt:
platform/mac/css1/basic/inheritance-expected.txt:
platform/mac/css1/box_properties/border-expected.txt:
platform/mac/css1/box_properties/border_bottom-expected.txt:
platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
platform/mac/css1/box_properties/border_bottom_width-expected.txt:
platform/mac/css1/box_properties/border_bottom_width_inline-expected.txt:
platform/mac/css1/box_properties/border_color-expected.txt:
platform/mac/css1/box_properties/border_color_inline-expected.txt:
platform/mac/css1/box_properties/border_inline-expected.txt:
platform/mac/css1/box_properties/border_left-expected.txt:
platform/mac/css1/box_properties/border_left_inline-expected.txt:
platform/mac/css1/box_properties/border_left_width-expected.txt:
platform/mac/css1/box_properties/border_left_width_inline-expected.txt:
platform/mac/css1/box_properties/border_right-expected.txt:
platform/mac/css1/box_properties/border_right_inline-expected.txt:
platform/mac/css1/box_properties/border_right_width-expected.txt:
platform/mac/css1/box_properties/border_right_width_inline-expected.txt:
platform/mac/css1/box_properties/border_style-expected.txt:
platform/mac/css1/box_properties/border_style_inline-expected.txt:
platform/mac/css1/box_properties/border_top-expected.txt:
platform/mac/css1/box_properties/border_top_inline-expected.txt:
platform/mac/css1/box_properties/border_top_width-expected.txt:
platform/mac/css1/box_properties/border_top_width_inline-expected.txt:
platform/mac/css1/box_properties/border_width-expected.txt:
platform/mac/css1/box_properties/border_width_inline-expected.txt:
platform/mac/css1/box_properties/clear-expected.txt:
platform/mac/css1/box_properties/clear_float-expected.txt:
platform/mac/css1/box_properties/float-expected.txt:
platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
platform/mac/css1/box_properties/float_margin-expected.txt:
platform/mac/css1/box_properties/height-expected.txt:
platform/mac/css1/box_properties/margin-expected.txt:
platform/mac/css1/box_properties/margin_bottom-expected.txt:
platform/mac/css1/box_properties/margin_bottom_inline-expected.txt:
platform/mac/css1/box_properties/margin_inline-expected.txt:
platform/mac/css1/box_properties/margin_left-expected.txt:
platform/mac/css1/box_properties/margin_left_inline-expected.txt:
platform/mac/css1/box_properties/margin_right-expected.txt:
platform/mac/css1/box_properties/margin_right_inline-expected.txt:
platform/mac/css1/box_properties/margin_top-expected.txt:
platform/mac/css1/box_properties/margin_top_inline-expected.txt:
platform/mac/css1/box_properties/padding-expected.txt:
platform/mac/css1/box_properties/padding_bottom-expected.txt:
platform/mac/css1/box_properties/padding_bottom_inline-expected.txt:
platform/mac/css1/box_properties/padding_inline-expected.txt:
platform/mac/css1/box_properties/padding_left-expected.txt:
platform/mac/css1/box_properties/padding_left_inline-expected.txt:
platform/mac/css1/box_properties/padding_right-expected.txt:
platform/mac/css1/box_properties/padding_right_inline-expected.txt:
platform/mac/css1/box_properties/padding_top-expected.txt:
platform/mac/css1/box_properties/padding_top_inline-expected.txt:
platform/mac/css1/box_properties/width-expected.txt:
platform/mac/css1/cascade/cascade_order-expected.txt:
platform/mac/css1/cascade/important-expected.txt:
platform/mac/css1/classification/display-expected.txt:
platform/mac/css1/classification/list_style-expected.txt:
platform/mac/css1/classification/list_style_image-expected.txt:
platform/mac/css1/classification/list_style_position-expected.txt:
platform/mac/css1/classification/list_style_type-expected.txt:
platform/mac/css1/classification/white_space-expected.txt:
platform/mac/css1/color_and_background/background-expected.txt:
platform/mac/css1/color_and_background/background_attachment-expected.txt:
platform/mac/css1/color_and_background/background_color-expected.txt:
platform/mac/css1/color_and_background/background_image-expected.txt:
platform/mac/css1/color_and_background/background_position-expected.txt:
platform/mac/css1/color_and_background/background_repeat-expected.txt:
platform/mac/css1/color_and_background/color-expected.txt:
platform/mac/css1/conformance/forward_compatible_parsing-expected.txt:
platform/mac/css1/font_properties/font-expected.txt:
platform/mac/css1/font_properties/font_family-expected.txt:
platform/mac/css1/font_properties/font_size-expected.txt:
platform/mac/css1/font_properties/font_style-expected.txt:
platform/mac/css1/font_properties/font_variant-expected.txt:
platform/mac/css1/font_properties/font_weight-expected.txt:
platform/mac/css1/formatting_model/canvas-expected.txt:
platform/mac/css1/formatting_model/floating_elements-expected.txt:
platform/mac/css1/formatting_model/height_of_lines-expected.txt:
platform/mac/css1/formatting_model/inline_elements-expected.txt:
platform/mac/css1/formatting_model/replaced_elements-expected.txt:
platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
platform/mac/css1/pseudo/anchor-expected.txt:
platform/mac/css1/pseudo/firstletter-expected.txt:
platform/mac/css1/pseudo/firstline-expected.txt:
platform/mac/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
platform/mac/css1/text_properties/letter_spacing-expected.txt:
platform/mac/css1/text_properties/line_height-expected.txt:
platform/mac/css1/text_properties/text_align-expected.txt:
platform/mac/css1/text_properties/text_decoration-expected.txt:
platform/mac/css1/text_properties/text_indent-expected.txt:
platform/mac/css1/text_properties/text_transform-expected.txt:
platform/mac/css1/text_properties/vertical_align-expected.txt:
platform/mac/css1/text_properties/word_spacing-expected.txt:
platform/mac/css1/units/color_units-expected.txt:
platform/mac/css1/units/length_units-expected.txt:
platform/mac/css1/units/percentage_units-expected.txt:
platform/mac/css1/units/urls-expected.txt:
platform/mac/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
platform/mac/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
platform/mac/editing/selection/designmode-no-caret-expected.txt:
platform/mac/fast/css/empty-pseudo-class-expected.txt:
platform/mac/fast/css/first-child-pseudo-class-expected.txt:
platform/mac/fast/css/last-child-pseudo-class-expected.txt:
platform/mac/fast/css/only-child-pseudo-class-expected.txt:
platform/mac/fast/forms/targeted-frame-submission-expected.txt:
platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
platform/mac/fast/html/listing-expected.txt:
platform/mac/fast/invalid/junk-data-expected.txt:
platform/mac/fast/invalid/missing-end-tag-expected.txt:
platform/mac/fast/loader/text-document-wrapping-expected.txt:
platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
platform/mac/fast/table/border-collapsing/004-expected.txt:
platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
platform/mac/fast/text/whitespace/001-expected.txt: Added.
platform/mac/fast/text/whitespace/013-expected.txt: Added.
platform/mac/fast/text/whitespace/014-expected.txt: Added.
platform/mac/fast/text/whitespace/022-expected.txt: Added.
platform/mac/fast/text/whitespace/024-expected.txt:
platform/mac/fast/text/whitespace/030-expected.txt:
platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
platform/mac/http/tests/misc/acid3-expected.txt:
platform/mac/svg/custom/bug45331-expected.txt:
platform/mac/svg/custom/junk-data-expected.txt:
platform/mac/svg/custom/missing-xlink-expected.txt:
platform/mac/svg/custom/path-bad-data-expected.txt:
platform/mac/svg/custom/use-font-face-crash-expected.txt:
platform/mac/svg/hixie/error/012-expected.txt:
platform/mac/tables/mozilla/bugs/45621-expected.txt:
platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:

10:55 AM Changeset in webkit [175258] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r175249.
https://bugs.webkit.org/show_bug.cgi?id=138138

Appears to be failing some JS tests (Requested by mlam_ on
#webkit).

Reverted changeset:

"Holes are not copied properly when Arrays change shape to
ArrayStorage type."
https://bugs.webkit.org/show_bug.cgi?id=138118
http://trac.webkit.org/changeset/175249

10:52 AM Changeset in webkit [175257] by commit-queue@webkit.org

2 edits in trunk/Tools

import-w3c-tests should use re.escape() wherever it's handling file paths
https://bugs.webkit.org/show_bug.cgi?id=137934

This patch adds re.escape() to a few places where we're doing string
conversions. This prevents errors when attribute values coincidentally
have character sequences that can be interpreted as regular expressions.

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-10-28
Reviewed by Bem Jones-Bey.

Scripts/webkitpy/w3c/test_converter.py:

(_W3CTestConverter.convert_attributes_if_needed):

10:37 AM Changeset in webkit [175256] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remove an inaccurate comment in WKActionMenuController
https://bugs.webkit.org/show_bug.cgi?id=138135

Reviewed by Anders Carlsson.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForLink]):
The comment is wrong; the separator is there for spacing, not just as a workaround.

10:17 AM Changeset in webkit [175255] by commit-queue@webkit.org

39 edits
1 copy
17 adds in trunk/LayoutTests

Update CSS shapes suite import
https://bugs.webkit.org/show_bug.cgi?id=138045

This patch is a full re-import of the CSS Shapes test suite from the W3C
test repo and an updated TestExpectations file to match the current
results.

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-10-28
Reviewed by Benjamin Poulain.

TestExpectations:
css3/shapes/shape-outside/shape-box/w3c-import.log:
css3/shapes/shape-outside/shape-image/gradients/w3c-import.log:
css3/shapes/shape-outside/shape-image/shape-image-000-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-001-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-002-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-002.html:
css3/shapes/shape-outside/shape-image/shape-image-003-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-003.html:
css3/shapes/shape-outside/shape-image/shape-image-004-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-005-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-005.html:
css3/shapes/shape-outside/shape-image/shape-image-006-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-006.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-007-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-007.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-008-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-008.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-009-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-009.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-010-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-010.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-011-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-011.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-013-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-013.html:
css3/shapes/shape-outside/shape-image/shape-image-014-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-014.html:
css3/shapes/shape-outside/shape-image/shape-image-015-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-015.html:
css3/shapes/shape-outside/shape-image/shape-image-016-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-016.html:
css3/shapes/shape-outside/shape-image/shape-image-017-expected.html:
css3/shapes/shape-outside/shape-image/shape-image-017.html:
css3/shapes/shape-outside/shape-image/shape-image-024-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-024.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-025-expected.html: Added.
css3/shapes/shape-outside/shape-image/shape-image-025.html: Added.
css3/shapes/shape-outside/shape-image/support/animated.gif: Added.
css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png:
css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png:
css3/shapes/shape-outside/shape-image/support/w3c-import.log:
css3/shapes/shape-outside/shape-image/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html:
css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log:
css3/shapes/shape-outside/supported-shapes/support/w3c-import.log: Copied from LayoutTests/css3/shapes/shape-outside/values/support/w3c-import.log.
css3/shapes/shape-outside/values/shape-image-threshold-001.html:
css3/shapes/shape-outside/values/support/w3c-import.log:
css3/shapes/shape-outside/values/w3c-import.log:
css3/shapes/spec-examples/shape-outside-019-expected.html:
css3/shapes/spec-examples/support/w3c-import.log:
css3/shapes/spec-examples/w3c-import.log:
css3/shapes/w3c-import.log:

9:44 AM Changeset in webkit [175254] by ap@apple.com

2 edits in trunk/Source/WebCore

Windows build fix.

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession): Use a WTF function
for getting current process ID instead of getpid().

9:30 AM Changeset in webkit [175253] by commit-queue@webkit.org

4 edits in trunk

[EFL] Remove unnecessary defines from OptionsEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=138132

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-10-28
Reviewed by Csaba Osztrogonác.

Source/cmake/OptionsEfl.cmake:

Source/WTF:

wtf/Platform.h:

9:05 AM Changeset in webkit [175252] by mihnea@adobe.com

6 edits in trunk/Source/WebCore

Clean up subtrees selection code
https://bugs.webkit.org/show_bug.cgi?id=137740

Reviewed by David Hyatt.

Clean up subtrees selection code. Add a new class SelectionSubtreeData
that keeps only the selection data. Have SelectionSubtreeRoot class embed
a SelectionSubtreeData member and keep the business logic methods.
No functionality changed therefore no new layout tests.

rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionStartEnd):

rendering/RenderView.cpp:

(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):

rendering/RenderView.h:
rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot):
(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):

rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStart):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEnd):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionClear):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStart):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEnd):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection):
(WebCore::SelectionSubtreeRoot::selectionData):
(WebCore::SelectionSubtreeRoot::setSelectionData):
(WebCore::SelectionSubtreeRoot::selectionStart): Deleted.
(WebCore::SelectionSubtreeRoot::selectionStartPos): Deleted.
(WebCore::SelectionSubtreeRoot::selectionEnd): Deleted.
(WebCore::SelectionSubtreeRoot::selectionEndPos): Deleted.
(WebCore::SelectionSubtreeRoot::selectionStartEndPositions): Deleted.
(WebCore::SelectionSubtreeRoot::selectionClear): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionStart): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionStartPos): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionEnd): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionEndPos): Deleted.

9:04 AM Changeset in webkit [175251] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] The first software paint of a <video> element takes up to 2.5s.
https://bugs.webkit.org/show_bug.cgi?id=137754

Reviewed by Brent Fulgham.

It turns out that, if you pass nil to -[AVPlayerItemVideoOutput initWithPixelBufferAttributes:]
the video output will not attempt to conform the resulting pixel buffers into a particular format.
This means that adding such a video output to a AVPlayerItem should have almost no performance
penalty, since the video output does not even copy the resulting buffers, but rather just retains
and returns the ones from the AVPlayerLayer.

Create and attach an AVPlayerItemVideoOutput after creating the AVPlayerItem, but before attaching
the player item to the AVPlayer. This eliminates the reconfigure step which occurs after attaching
a video output to an already attached AVPlayerItem.

When creating the AVPlayerItemVideoOutput, pass in nil for the pixelBufferAttributes parameter.

Instead of blocking waiting for output from the AVPlayerItemVideoOutput during creating, block and
whait when asked to paint with the video output.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

8:35 AM Changeset in webkit [175250] by Chris Dumez

4 edits in trunk/Source/WebCore

Move text decoration CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138121

Reviewed by Antti Koivisto.

Move text decoration CSS properties from DeprecatedStyleBuilder to the
new StyleBuilder so that they are generated from CSSPropertyNames.in.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyTextDecoration::applyValue): Deleted.
(WebCore::ApplyPropertyTextDecoration::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextDecoration):

8:29 AM Changeset in webkit [175249] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Holes are not copied properly when Arrays change shape to ArrayStorage type.
<https://webkit.org/b/138118>

Reviewed by Mark Hahnenberg.

When we convert non-ArrayStorage typed arrays into ArrayStorage typed arrays,
we skipped the holes. As a result, the slots in the ArrayStorage vector that
corresponds to those holes are uninitialize. This is now fixed.

runtime/JSObject.cpp:

(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

7:14 AM Changeset in webkit [175248] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=138130

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-10-28
Reviewed by Csaba Osztrogonác.

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

6:53 AM Changeset in webkit [175247] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.7.1

WebKitGTK+ 2.7.1

6:52 AM Changeset in webkit [175246] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.7.1.

5:49 AM Changeset in webkit [175245] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Remove GDK dependency from SharedTimerGtk
https://bugs.webkit.org/show_bug.cgi?id=138092

Reviewed by Martin Robinson.

It depends on GDK just to use GDK_PRIORITY_REDRAW constant, we can
use its value directly instead.

PlatformGTK.cmake:
platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

12:05 AM Changeset in webkit [175244] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Mac] OS X Mavericks build broken with public SDK
https://bugs.webkit.org/show_bug.cgi?id=138108

Reviewed by Mark Rowe.

Shared/API/Cocoa/WKFoundation.h: Only define the NSEventModifierFlags type when using a

version of the OS X SDK that doesn’t define it.

Oct 27, 2014:

10:46 PM Changeset in webkit [175243] by mark.lam@apple.com

3 edits
6 adds in trunk

Crash when attempting to perform array iteration on a non-array with numeric keys not initialized.
<https://webkit.org/b/137814>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The arrayIteratorNextThunkGenerator() thunk was not checking for the case where
the butterfly may be NULL. This was the source of the crash, and is now fixed.

In addition, it is also not checking for the case where a property named "length"
may have been set on the iterated object. The thunk only checks the butterfly's
publicLength for its iteration operation. Array objects will work fine with this
because it always updates its butterfly's publicLength when its length changes.
In the case of iterable non-Array objects, the "length" property will require a
look up outside of the scope of this thunk. The fix is simply to limit the fast
case checks in this thunk to Array objects.

jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

LayoutTests:

js/array-length-shortening-expected.txt: Added.
js/array-length-shortening.html: Added.
js/for-of-crash-expected.txt: Added.
js/for-of-crash.html: Added.
js/script-tests/array-length-shortening.js: Added.

(testLengthShortening):
(denseInt32Elements):
(denseDoubleElements):
(denseObjectElements):
(holeyInt32Elements):
(holeyDoubleElements):
(holeyObjectElements):
(arrayStorageInt32Elements):
(arrayStorageDoubleElements):
(arrayStorageObjectElements):
(sparseInt32Elements):
(sparseDoubleElements):
(sparseObjectElements):

js/script-tests/for-of-crash.js: Added.

(foo):

10:39 PM Changeset in webkit [175242] by akling@apple.com

6 edits in trunk/Source/WebCore

Move RenderBlock::beingDestroyed() to RenderObject.
<https://webkit.org/b/138116>

Reviewed by Antti Koivisto.

Make "is being destroyed" a RenderObject concept instead of restricting
it to RenderBlocks. I'm guessing that this was specific to blocks due to
lack of bitfield space in RenderObject, and that's no longer an issue.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):

rendering/RenderBlock.h:

(WebCore::RenderBlock::beingDestroyed): Deleted.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):

rendering/RenderObject.h:

(WebCore::RenderObject::beingDestroyed):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

10:38 PM Changeset in webkit [175241] by Chris Fleizach

3 edits
2 adds in trunk

AX: input type=hidden is being exposed when aria-hidden=false
https://bugs.webkit.org/show_bug.cgi?id=138106

Reviewed by Benjamin Poulain.

Source/WebCore:

If an input type=hidden was inside an aria-hidden=false, it would appear because
the lack of a RenderObject behind that object was not blocking its adoption into the AX tree.
We should explicity check for whether the type is hidden and then return an appropriate role.

Test: accessibility/input-type-hidden-in-aria-hidden-false.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

LayoutTests:

accessibility/input-type-hidden-in-aria-hidden-false-expected.txt: Added.
accessibility/input-type-hidden-in-aria-hidden-false.html: Added.

10:05 PM Changeset in webkit [175240] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Simplified some JSObject methods for converting arrays to ArrayStorage shape.
<https://webkit.org/b/138119>

Reviewed by Filip Pizlo.

Currently, for each Undecided, Int32, Double, and Contiguous array shapes,
there are 3 JSObject methods to convert them to ArrayStorage shape:

ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength);
ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition);
ArrayStorage* convert<shape>ToArrayStorage(VM&);

However, the neededLength that is passed is always m_butterfly->vectorLength().
Hence, the method that takes a neededLength is really not needed. This patch
removes this unneeded verbosity.

runtime/JSObject.cpp:

(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):

Also reordered the placement of the DeferGC statement so this Int32 function will look more similar to the others.

(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

runtime/JSObject.h:

8:46 PM Changeset in webkit [175239] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175235. rdar://problem/18787412

8:05 PM Changeset in webkit [175238] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

NSSharingService protocol conformance should be internal to WKActionMenuController
https://bugs.webkit.org/show_bug.cgi?id=138112

Patch by Conrad Shultz <Conrad Shultz> on 2014-10-27
Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.h:
UIProcess/mac/WKActionMenuController.mm:

Move protocol conformance from the interface to a class extension.

7:49 PM Changeset in webkit [175237] by ap@apple.com

2 edits in trunk/Source/WebCore

https://trac.webkit.org/changeset/175233 broke many tests, fixing an incorrect '!'.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

6:00 PM Changeset in webkit [175236] by hyatt@apple.com

4 edits
3 adds in trunk

text-combine needs to center text within the vertical space using glyph bounds
https://bugs.webkit.org/show_bug.cgi?id=138056
<rdar://problem/15403667>

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/text/tatechuyoko.html

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::combineText):

rendering/RenderCombineText.h:

LayoutTests:

fast/text/tatechuyoko.html: Added.
platform/mac/fast/text/tatechuyoko-expected.png: Added.
platform/mac/fast/text/tatechuyoko-expected.txt: Added.

5:36 PM Changeset in webkit [175235] by enrica@apple.com

2 edits in trunk/Source/WebKit2

WebContent crash in WebKit::WebPage::expandedRangeFromHandle.
https://bugs.webkit.org/show_bug.cgi?id=138023
rdar://problem/18787412

Reviewed by Ryosuke Niwa.

We must change that we have a valid currentRange before trying
to expand or contract.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::changeBlockSelection):

4:13 PM Changeset in webkit [175234] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

REGRESSION: commit logs are not shown sometimes on the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=138099

Reviewed by Benjamin Poulain.

The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
_showDetails inverting the order of the current and old measurements.

public/v2/app.js:

(App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
(App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
current (latest) measurement and the first point is the oldest measurement.
(App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.

3:55 PM Changeset in webkit [175233] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Cleanup after r175213: fastGetAttribute().isNull() should be fastHasAttribute()

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Darin spotted this mistake.

2:59 PM Changeset in webkit [175232] by ap@apple.com

7 edits in trunk

http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots
https://bugs.webkit.org/show_bug.cgi?id=138098

Reviewed by Anders Carlsson.

Source/WebCore:

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):
Create a separate session for each WKTR/DRT process when testing.

Source/WebKit2:

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

Update for the new name of testing session. Memory regions are now of the form
"WebKit Test-<pid>-0".

LayoutTests:

platform/mac-wk1/TestExpectations: Removed the test from expectations. It's still

skipped on WK2, because we don't yet implement the necessary WKTR functionality.

2:08 PM Changeset in webkit [175231] by Chris Dumez

13 edits in trunk/Source

Use separate HashMaps for common and uncommon headers in HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=138079

Reviewed by Anders Carlsson.

Source/WebCore:

Use separate HashMaps for common and uncommon headers in HTTPHeaderMap:

a (faster) HashMap<HTTPHeaderMap, String> for common HTTP headers
a HashMap<String, String, CaseFoldingHash> for uncommon ones

This avoids having to construct Strings from HTTPHeaderMap values for
storing. This also means we have less isolated String copies to do when
creating cross-thread data. The common headers HashMap should also be
a bit more efficient due to faster hashing and faster key comparison in
case of collision.

Some calls sites can also benefit from having direct access to common
headers of the request in HTTPHeaderName type.

This patch adds a new HTTPHeaderMapConstIterator iterator type for
HTTPHeaderMap so that call sites that do not need / want to distinguish
common / uncommon headers still do not need to. They can keep using
modern C++ loops over HTTPHeaderMap objects and get <String, String>
key/value pairs.

No new tests, no behavior change.

loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.

(WebCore::isSimpleCrossOriginAccessRequest):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.

loader/CrossOriginAccessControl.h:

Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.

loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):
Call httpHeaderFields().commonHeaders().find() instead of
httpHeaderFields().find() as we are looking for a common header.
HTTPHeaderMap::find(HTTPHeaderName) was removed now that we have a
HashMap dedicated to common headers.

loader/cache/CachedRawResource.cpp:

(WebCore::shouldIgnoreHeaderForCacheReuse):
Update argument type to be a HTTPHeaderName instead of a String as
only common HTTP headers can be ignored for cache reuse. The
implementation already dealt with HTTPHeaderName type and had to
call findHTTPHeaderName(). This is no longer needed now that the
call site now has direct access to common headers in HTTPHeaderName
type.

(WebCore::CachedRawResource::canReuse):

Only call shouldIgnoreHeaderForCacheReuse() for common HTTP headers.
Slightly optimize the second loop (the one over oldHeaderMap) to only check that the key is present in newHeaderMap, without actually comparing the String values. If the String values were different, the first loop would have seen it already and we would have returned early.

Source/WebKit2:

Update the WK2 IPC HTTPHeaderMap serialization / deserialization code
to leverage the fact that HTTPHeaderMap now stores common HTTP headers
and uncommon one in separate HashMaps. This speeds up deserialization
as we no longer need to call findHTTPHeaderName() for every decoded
header. We already know if the header is a common one or not, and if
it is then we already have a HTTPHeaderName type instead of a String.

I see that we spend ~40% less time in HTTPHeaderMap decoding when
loading http://flickr.com/explore, while the encoding takes about
the same amount of time as before.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<HTTPHeaderMap>::encode):
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):

Source/WTF:

Add HashTraits for C++11 strong enum types. Using integer HashTraits for
strong enums would be inconvenient as it would require casting between
integer and strong enum types.

wtf/HashTraits.h:

(WTF::StrongEnumHashTraits::emptyValue):
(WTF::StrongEnumHashTraits::constructDeletedValue):
(WTF::StrongEnumHashTraits::isDeletedValue):

1:42 PM Changeset in webkit [175230] by akling@apple.com

4 edits in trunk/Source/WebCore

Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
<https://webkit.org/b/138096>

Reviewed by Chris Dumez.

This function is only ever called on a renderer after we've checked
that it's a RenderDeprecatedFlexibleBox, so make it non-virtual.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

rendering/RenderDeprecatedFlexibleBox.h:
rendering/RenderObject.h:

1:08 PM Changeset in webkit [175229] by Beth Dakin

4 edits in trunk/Source/WebKit/mac

Provide a way for WebKit1 clients to override default action menu items
https://bugs.webkit.org/show_bug.cgi?id=138066
-and corresponding-
rdar://problem/18451638

Reviewed by Anders Carlsson.

WebActionMenuController now has an ivar for the WebActionMenuType so that it can
send that along to clients customizing the menu.

WebView/WebActionMenuController.h:
WebView/WebActionMenuController.mm:

(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):

New enum and new SPI to customize menus.

WebView/WebUIDelegatePrivate.h:

1:06 PM Changeset in webkit [175228] by Chris Dumez

2 edits in trunk/Source/WebCore

Reintroduce null check removed in r175222
https://bugs.webkit.org/show_bug.cgi?id=138087

Reviewed by Andreas Kling.

Reintroduce null check removed in r175222 as several layout tests are
crashing on the bots without them. At least the Pair pointer can be
null according to the assertion hits on the bots.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRadius):

12:43 PM Changeset in webkit [175227] by ap@apple.com

2 edits in trunk/LayoutTests

Add [ Yosemite ] modifier to a couple of tests in section 7.

These two tests fail with PPT, so they are expected to pass on 10.8. Our current
approach is a have separate sections for Mavericks and Yosemite, even for PPT
specific failures that affect both.

platform/mac-wk2/TestExpectations:

12:31 PM Changeset in webkit [175226] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebCore

Merged r175158. rdar://problem/18571212

12:03 PM Changeset in webkit [175225] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175157. rdar://problem/18739335

12:01 PM Changeset in webkit [175224] by bshafiei@apple.com

4 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175153. rdar://problem/18739335

11:31 AM Changeset in webkit [175223] by Stephanie Lewis

2 edits in trunk/LayoutTests

http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots.
https://bugs.webkit.org/show_bug.cgi?id=138098.

Updated Expectations.

platform/mac-wk1/TestExpectations:

11:26 AM Changeset in webkit [175222] by Chris Dumez

4 edits in trunk/Source/WebCore

Move radius CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138087

Reviewed by Andreas Kling.

Move radius CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder so that they are now generated from CSSPropertyNames.in.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyBorderRadius::setValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::applyValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRadius):

11:06 AM Changeset in webkit [175221] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

Shrink MathMLOperatorDictionary::dictionary table
https://bugs.webkit.org/show_bug.cgi?id=137914

Reviewed by Darin Adler.

Improve packing of the Entry structure that's used for elements
of the MathMLOperatorDictionary::dictionary table. This drops the
size of the struct from 16 bytes to just 4 bytes, and shrinks the
size of the dictionary table from rougly 16 kB down to 4 kB.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::MathMLOperatorDictionary::ExtractKey):
(WebCore::RenderMathMLOperator::setOperatorProperties):

rendering/mathml/RenderMathMLOperator.h:

10:33 AM Changeset in webkit [175220] by commit-queue@webkit.org

1 edit
54 deletes in trunk/LayoutTests

Some test for multicol were redundant.
https://bugs.webkit.org/show_bug.cgi?id=133084

Patch by Piotr Grad <p.grad@samsung.com> on 2014-10-27
Reviewed by Andreas Kling.

fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html: Removed.
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash-expected.txt: Removed.
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash.html: Removed.

10:20 AM Changeset in webkit [175219] by akling@apple.com

3 edits in trunk/Source/WebCore

Move canContainFixedPositionObjects() to RenderElement.
<https://webkit.org/b/138088>

Reviewed by Mihnea Ovidenie.

Only RenderElement can contain other renderers, so it's not really
natural to answer this question on RenderObject anyway.

Moving it to RenderElement lets it access more efficient getters
that don't have to handle the RenderText case.

rendering/RenderElement.h:

(WebCore::RenderElement::canContainFixedPositionObjects):

rendering/RenderObject.h:

(WebCore::RenderObject::canContainFixedPositionObjects): Deleted.

10:08 AM Changeset in webkit [175218] by ap@apple.com

2 edits in trunk/LayoutTests

media/track/audio-track.html is flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=137882

platform/mac/TestExpectations: Marking it as such.

9:31 AM Changeset in webkit [175217] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175145. rdar://problem/18376333

1:09 AM Changeset in webkit [175216] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2

Merged r175143. rdar://problem/18692335

Oct 26, 2014:

11:51 PM Changeset in webkit [175215] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6

Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
https://bugs.webkit.org/show_bug.cgi?id=137142

Reviewed by Alejandro G. Castro.

This is required by the inspector to show some of the icons that
has a HiDPI variant.

Source/cmake/OptionsGTK.cmake:

11:29 PM Changeset in webkit [175214] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.12-branch/Source

Versioning.

9:28 PM Changeset in webkit [175213] by benjamin@webkit.org

9 edits
2 adds in trunk

Images with usemap should not have a link state
https://bugs.webkit.org/show_bug.cgi?id=138071

Reviewed by Andreas Kling.

Source/WebCore:

Image tags were incorrectly getting a link state if a usemap is defined.
The <area> of the usemap is supposed to get the link state, but never the image.

Unfortunately, the Accessibility code was relying on the wrong behavior
to set the ImageMapRole, most of the patch is updating that code to get
the correct role without the link state.

Test: fast/selectors/images-with-usemap-should-not-match-link.html

The accessibility code is covered by a few tests in accessibility/.
The test accessibility/aria-used-on-image-maps.html ensure the <area>
elements also get the correct role.

dom/Node.h:

(WebCore::Node::setIsLink):
(WebCore::Node::clearIsLink): Deleted.
Unused code.

(WebCore::Node::isLink):
Move with its setter for clarity.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
This is the bug.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Here the branches for the role ImageMap where behind isLink() which would
never be valid after the fix.

My fix here was to use the same definition previously set by HTMLImageElement::parseAttribute(),
any usemap attribute qualifies the node for ImageMapRole.

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::linkedUIElements):
(WebCore::AccessibilityRenderObject::url):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAnchor): Deleted.
Something funny I discovered is the Accessibility code worked around the bug
by defining isAnchor() that exclude images from isLink().

Since isLink() will no longer be true for images, the hack can be removed.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::isAnchor): Deleted.

accessibility/AccessibilityNodeObject.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

fast/selectors/images-with-usemap-should-not-match-link-expected.txt: Added.
fast/selectors/images-with-usemap-should-not-match-link.html: Added.

9:20 PM Changeset in webkit [175212] by benjamin@webkit.org

11 edits in trunk/Source/WebCore

Replace Element::didAffectSelector() by setNeedsStyleRecalc()
https://bugs.webkit.org/show_bug.cgi?id=138080

Reviewed by Andreas Kling.

Element::didAffectSelector() was probably an optimization at some point,
with the current code is does nothing more than setNeedsStyleRecalc().

dom/Document.cpp:

(WebCore::Document::setCSSTarget):

dom/Element.cpp:

(WebCore::Element::didAffectSelector): Deleted.

dom/Element.h:
html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::disabledStateChanged):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setIndeterminate):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::parseAttribute):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::setSelectedState):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::didElementStateChange):

3:25 PM Changeset in webkit [175211] by akling@apple.com

10 edits in trunk/Source/WebCore

Move some RenderObject member functions to RenderElement.
<https://webkit.org/b/138085>

Reviewed by Chris Dumez.

Move these two functions to RenderElement:

handleDynamicFloatPositionChange()
removeAnonymousWrappersForInlinesIfNecessary()

Also make childBecameNonInline() take a RenderElement& since
that's all we ever pass to it.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childBecameNonInline):

rendering/RenderBlock.h:
rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::childBecameNonInline):

rendering/RenderElement.cpp:

(WebCore::RenderElement::handleDynamicFloatPositionChange):
(WebCore::RenderElement::removeAnonymousWrappersForInlinesIfNecessary):

rendering/RenderElement.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::childBecameNonInline):

rendering/RenderInline.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::handleDynamicFloatPositionChange): Deleted.
(WebCore::RenderObject::removeAnonymousWrappersForInlinesIfNecessary): Deleted.

rendering/RenderObject.h:

1:20 PM Changeset in webkit [175210] by akling@apple.com

7 edits in trunk/Source/WebCore

Move continuation teardown from subclasses to RenderBoxModelObject.
<https://webkit.org/b/138081>

Reviewed by Antti Koivisto.

Let RenderBoxModelObject::willBeDestroyed() tear down any continuation
instead of having every subclass do this themselves.

Also added a RenderElement bit tracking whether the renderer has a
continuation. This avoids a hash lookup every time we destroy a
RenderBoxModelObject that didn't have a continuation.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

rendering/RenderBoxModelObject.cpp:

(WebCore::continuationMap):
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::continuation):
(WebCore::RenderBoxModelObject::setContinuation):

rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

rendering/RenderElement.h:

(WebCore::RenderElement::setHasContinuation):
(WebCore::RenderElement::hasContinuation):

rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

Oct 25, 2014:

10:47 PM Changeset in webkit [175209] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Remove a useless variable from SelectorCodeGenerator::generateElementMatchesSelectorList()
https://bugs.webkit.org/show_bug.cgi?id=138076

Reviewed by Alexey Proskuryakov.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
The variable elementAddressRegisterIndex was just needed for debugging, it is useless now.

9:47 PM WebKitGTK/KeepingTheTreeGreen edited by yoon@igalia.com

(diff)

9:44 PM Changeset in webkit [175208] by yoon@igalia.com

2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening after r174685.

platform/gtk/TestExpectations: Report new failures and update expectations.

9:12 PM Changeset in webkit [175207] by commit-queue@webkit.org

2 edits in trunk/Tools

Fix link to Arch Linux Wiki
https://bugs.webkit.org/show_bug.cgi?id=138010

Patch by Raniere Silva <raniere@ime.unicamp.br> on 2014-10-25
Reviewed by Benjamin Poulain.

gtk/install-dependencies:

8:52 PM Changeset in webkit [175206] by Brian Burg

4 edits in trunk/Source

Web Inspector: timelines should not count time elapsed while paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351

Unreviewed, follow-up fix after r175203. The debugger agent should not assume
that the inspector environment's stopwatch has already been started.

Source/JavaScriptCore:

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didPause): Check if the stopwatch isActive() before stopping.

Source/WTF:

wtf/Stopwatch.h:

(WTF::Stopwatch::isActive): Added. Allow peeking at the stopwatch state.

8:25 PM Changeset in webkit [175205] by ap@apple.com

7 edits
6 copies
6 adds in trunk/LayoutTests

Land Yosemite results for six editing/selection/vertical* tests.

These failures used to be mostly hidden because of bug 138070, now they are visible.
The change is due to different fonts.

platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt.
platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt.
platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt.
platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt.
platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt.
platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:

4:29 PM Changeset in webkit [175204] by ap@apple.com

5 edits in trunk/Tools

Test regressions are not detected when image result is missing
https://bugs.webkit.org/show_bug.cgi?id=138070

Reviewed by Simon Fraser.

Scripts/webkitpy/layout_tests/models/test_run_results.py:
Scripts/webkitpy/layout_tests/views/buildbot_results.py:

Count these as regressions, not as flaky tests.

Scripts/webkitpy/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Test it.

3:05 PM Changeset in webkit [175203] by Brian Burg

39 edits
1 add in trunk/Source

Web Inspector: timelines should not count time elapsed while paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Now that we have a stopwatch to provide pause-aware timing data, we can remove the
profiler's handling of debugger pause/continue callbacks. The debugger agent accounts
for suspended execution by pausing and resuming the stopwatch.

API/JSProfilerPrivate.cpp:

(JSStartProfiling): Use a fresh stopwatch when profiling from the JSC API.

inspector/InspectorEnvironment.h:
inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::executionStopwatch):

inspector/JSGlobalObjectInspectorController.h:
inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::handlePause):

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::didContinue):

inspector/agents/InspectorDebuggerAgent.h:
profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::profiler): Use nullptr.
(JSC::LegacyProfiler::startProfiling): Hand off a stopwatch to the profile generator.
(JSC::LegacyProfiler::stopProfiling): Use nullptr.
(JSC::LegacyProfiler::didPause): Deleted.
(JSC::LegacyProfiler::didContinue): Deleted.

profiler/LegacyProfiler.h:
profiler/Profile.cpp: The root node should always have a start time of 0.0.

(JSC::Profile::Profile):

profiler/ProfileGenerator.cpp: Remove debugger pause/continue callbacks and the

timestamp member that was used to track time elapsed by the debugger. Just use the
stopwatch's elapsed times to generate start/elapsed times for function calls.

(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::AddParentForConsoleStartFunctor::operator()): The parent node of |console.profile|
should have a start time of 0.0, since it represents the starting node of profiling.

(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

profiler/ProfileGenerator.h:

Source/WebCore:

To avoid counting time elapsed while the debugger is paused, timeline records should
keep track of time elapsed since the start of timeline capturing, rather than wall clock
timestamps. We can easily compute elapsed time by sharing a Stopwatch instance through the
inspector environment. The stopwatch runs with timelines and is paused with the debugger,
so subsequent time measurements will not include time elapsed while the debugger is paused.

This refactoring is safe because start and end times are only used to graph records; the
timestamp's actual value is irrelevant and is not displayed in the user interface. Date
timestamps are still included with network-related records as part of their header data.

No new tests, because we cannot reliably test timing changes induced by debugger pauses.
It is possible for records to accrue time before the debugger pauses or after it resumes.

inspector/InspectorCSSAgent.cpp: Remove unnecessary include.
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::executionStopwatch): Add a shared stopwatch.

inspector/InspectorController.h:
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):

inspector/InspectorPageAgent.h:
inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):

inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart): Start and stop the stopwatch with timelines.
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::startProfiling):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::TimelineTimeConverter::reset): Deleted.

inspector/InspectorTimelineAgent.h:

(WebCore::TimelineTimeConverter::TimelineTimeConverter): Deleted.
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime): Deleted.
(WebCore::InspectorTimelineAgent::timeConverter): Deleted.

inspector/TimelineRecordFactory.cpp:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::executionStopwatch): Add a shared stopwatch.

inspector/WorkerInspectorController.h:

Source/WebInspectorUI:

Don't update the timeline's current time when the debugger is paused.

Start and end times for timeline records are now in seconds elapsed since timeline
recording started, rather than milliseconds since the epoch. Also convert code that
tracks page/resource load timings to use elapsed times rather than timestamps.

Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
in multiple agents to elapsed times.

UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):

UserInterface/Controllers/ProbeManager.js:
UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype.pageDidLoad):
(WebInspector.TimelineManager.prototype._loadNewRecording):

UserInterface/Models/Probe.js:

(WebInspector.ProbeSample):

UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.updateForRedirectResponse):
(WebInspector.Resource.prototype.updateForResponse):
(WebInspector.Resource.prototype.increaseSize):
(WebInspector.Resource.prototype.markAsFinished):
(WebInspector.Resource.prototype.markAsFailed):
(WebInspector.Resource.prototype.revertMarkAsFinished):

UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.computeElapsedTime):

UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._debuggerPaused):
(WebInspector.TimelineContentView.prototype._debuggerResumed):

Source/WTF:

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Stopwatch.h: Added. This implements a refcounted monotonic stopwatch.

(WTF::Stopwatch::create):
(WTF::Stopwatch::Stopwatch):
(WTF::Stopwatch::reset):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):
(WTF::Stopwatch::elapsedTime):

12:58 PM Changeset in webkit [175202] by ap@apple.com

1 edit
1 add in trunk/LayoutTests

Add Mavericks results for platform/mac/editing/spelling/delete-autocorrected-word-2.html, too.

Yosemite, Mavericks and Mountain Lion all have different results.

platform/mac-mavericks/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.

12:25 PM Changeset in webkit [175201] by ap@apple.com

3 edits in trunk/LayoutTests

Update Yosemite results for platform/mac/editing/spelling/delete-autocorrected-word-2.html.

Looks like this got confused during Yosemite tests landing.

This test is currently marked as failing on WK2, but it passed for me, so maybe we
can mark it as passing there too. Tracked as bug 105616.

platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png:
platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt:

12:21 PM Changeset in webkit [175200] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fix builds using the public SDK.

platform/spi/cocoa/NSExtensionSPI.h:

12:10 PM Changeset in webkit [175199] by ap@apple.com

2 edits
1 copy
2 deletes in trunk/LayoutTests

Update results for compositing/rtl/rtl-fixed-overflow-scrolled.html.

Prior to Yosemite results landing, this test was marked as failing on WK2, and its
results matched WK1. It got changed several times during the merge, so it ended
up being marked as failing on WK1, but with WK1 results landed.

Let's land WK2 results and keep testing on WK2. Also, Mavericks results were no different
from Yosemite.

platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png.
platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:

2:42 AM WebKitGTK/KeepingTheTreeGreen edited by yoon@igalia.com

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed