Timeline



Nov 25, 2014:

4:27 PM Changeset in webkit [176545] by commit-queue@webkit.org
  • 15 edits in trunk

Add parsing for :dir()
​https://bugs.webkit.org/show_bug.cgi?id=138932

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-25
Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

  • css/CSSSelector.cpp:

(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/selectors/invalid-functional-pseudo-class-expected.txt:
  • fast/selectors/invalid-functional-pseudo-class.html:
11:50 AM Changeset in webkit [176544] by andersca@apple.com
  • 11 edits in trunk/Source

Remove user content handling from PageGroup
​https://bugs.webkit.org/show_bug.cgi?id=139051

Reviewed by Antti Koivisto.

Source/WebCore:

Remove m_userContentController from PageGroup and the related functions and symbol exports.

  • WebCore.exp.in:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.

  • page/PageGroup.h:

Source/WebKit/mac:

Use the user content controller in the web view group.

  • WebView/WebView.mm:

(-[WebView _injectOutlookQuirksScript]):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.

(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.

  • WebProcess/WebPage/WebPageGroupProxy.h:

Add an m_userContentController member.

10:05 AM Changeset in webkit [176543] by alex
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, upload two missing test files in the commit r174677.

  • mathml/presentation/mo-stretch-update-expected.html: Added.
  • mathml/presentation/mo-stretch-update.html: Added.
8:16 AM Changeset in webkit [176542] by andersca@apple.com
  • 7 edits in trunk/Source

Add a user content controller to WebViewGroup and use it for user content
​https://bugs.webkit.org/show_bug.cgi?id=139043

Reviewed by Antti Koivisto.

Source/WebCore:

  • WebCore.exp.in:

Export symbols.

  • page/Page.cpp:

(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.

Source/WebKit/mac:

This is another tiny step towards getting rid of user content handling inside PageGroup.

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::userContentController):
Add a UserContentController member and getter.

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).

(WebViewGroup::WebViewGroup):
Create a user content controller.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.

(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.

6:49 AM Changeset in webkit [176541] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] gstmpegts is not initialized
​https://bugs.webkit.org/show_bug.cgi?id=139039

Reviewed by Carlos Garcia Campos.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer): Initialize the gstmpegts library.

6:29 AM Changeset in webkit [176540] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
​https://bugs.webkit.org/show_bug.cgi?id=138833

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-25
Reviewed by Carlos Garcia Campos.

This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.

  • PlatformGTK.cmake:
5:48 AM Changeset in webkit [176539] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
​https://bugs.webkit.org/show_bug.cgi?id=138090

Patch by Tanay C <​tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.

  • MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll

(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.

1:59 AM Changeset in webkit [176538] by Csaba Osztrogonác
  • 5 edits in trunk

[EFL] REGRESSION(r176514): It made performance tests fail
​https://bugs.webkit.org/show_bug.cgi?id=139037

Reviewed by Gyuyoung Kim.

Source/WebKit2:

  • WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.

Tools:

  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.

  • efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so

only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.

Nov 24, 2014:

11:41 PM Changeset in webkit [176537] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

Fix unused variable warning in Biquad.cpp
​https://bugs.webkit.org/show_bug.cgi?id=139031

Reviewed by Andreas Kling.

No new tests needed.

  • platform/audio/Biquad.cpp:
11:39 PM Changeset in webkit [176536] by evab.u-szeged@partner.samsung.com
  • 4 edits
    4 deletes in trunk/Source

Remove Qt cruft related to tap higlighting
​https://bugs.webkit.org/show_bug.cgi?id=139030

Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • CMakeLists.txt:
  • page/GestureTapHighlighter.cpp: Removed.
  • page/GestureTapHighlighter.h: Removed.

Source/WebKit2:

  • CMakeLists.txt:
  • WebProcess/WebPage/TapHighlightController.cpp: Removed.
  • WebProcess/WebPage/TapHighlightController.h: Removed.
9:26 PM Changeset in webkit [176535] by commit-queue@webkit.org
  • 5 edits in trunk

Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
​https://bugs.webkit.org/show_bug.cgi?id=139013

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-11-24
Reviewed by Benjamin Poulain.

Source/WebCore:

Fix the parsing and re-serialization of :lang pseudo class selector when
it has multiple arguments with same value e.g. :lang(en, en, en). Previously,
given :lang(en, en, en) selector, it was parsed and reserialized
as :lang(enenen) instead of :lang(en, en, en)

Related test on parsing and re-serialization of css selectors is updated.

  • css/CSSSelector.cpp:

(WebCore::appendArgumentList):

LayoutTests:

Updated tests to verify the parsing and serialization of :lang pseudo class
selector when it has multiple arguments with same value.

  • fast/css/css-selector-text-expected.txt: Updated to cover fix.
  • fast/css/css-selector-text.html: Updated to cover fix.
7:47 PM Changeset in webkit [176534] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Fix r176527. Iterate through the text renderers.
​https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:40 PM Changeset in webkit [176533] by gyuyoung.kim@samsung.com
  • 14 edits in trunk/Source/JavaScriptCore

Clean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
​https://bugs.webkit.org/show_bug.cgi?id=139022

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

  • bytecode/DFGExitProfile.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::JITFinalizer):

  • dfg/DFGJITFinalizer.h:
  • heap/IncrementalSweeper.h:
  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::enableSampler):

  • interpreter/Interpreter.h:
  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::ExecutableAllocator):

  • jit/ExecutableAllocator.h:
5:37 PM Changeset in webkit [176532] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r176530.

  • UIProcess/CoordinatedGraphics/WebView.cpp: Replace pointer with reference.

(WebKit::WebView::processDidExit):

5:00 PM Changeset in webkit [176531] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
​https://bugs.webkit.org/show_bug.cgi?id=139035

Reviewed by Antti Koivisto.

Move new line logic to FlowContents class.
This is in preparation to support <br>.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isNewline):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.

4:26 PM Changeset in webkit [176530] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Remove some bad stuff from WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=138896

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-24
Reviewed by Sam Weinig.

The state loadStateAtProcessExit does not seem to be used anywhere.

The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::processDidExit):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.

4:20 PM Changeset in webkit [176529] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Move :placeholder-shown out of experimental
​https://bugs.webkit.org/show_bug.cgi?id=138998

Reviewed by Andreas Kling.

The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
the sidebar.

The implementation has been stable for a while, we can move it to stable.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):

4:15 PM Changeset in webkit [176528] by Antti Koivisto
  • 4 edits
    2 adds in trunk

Avoid String concatenation with line break iterator
​https://bugs.webkit.org/show_bug.cgi?id=139034

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/text/simple-lines-multiple-renderers-break.html

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments):

Include String too so it doesn't need to be fetched from the renderer.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):

Make this iterative instead of recursive.
Uset setPriorContext to provide previous characters instead of concatenating
the string from all the previous segments.

(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):

Search using segments instead of the concatenated string.

(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::characterAt):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

LayoutTests:

Test that there is no implicit break point between Text nodes.

  • fast/text/simple-lines-multiple-renderers-break-expected.html: Added.
  • fast/text/simple-lines-multiple-renderers-break.html: Added.
4:10 PM Changeset in webkit [176527] by Alan Bujtas
  • 3 edits
    4 adds in trunk

SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
​https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html

fast/text/simple-line-layout-multiple-renderers-with-float.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

LayoutTests:

  • fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-with-float.html: Added.
4:05 PM Changeset in webkit [176526] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] update-webkitgtk-libs fails to build fontconfig
​https://bugs.webkit.org/show_bug.cgi?id=139032

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-24
Reviewed by Martin Robinson.

On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
fontconfig will try to generate documentation and fail.

  • gtk/install-dependencies:
3:56 PM Changeset in webkit [176525] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

Simple line layout: fast/text/simple-lines-multiple-renderers test has the wrong content.
​https://bugs.webkit.org/show_bug.cgi?id=139036

Swap simple-lines-multiple-renderers.html and simple-lines-multiple-renderers-expected.html

  • fast/text/simple-lines-multiple-renderers-expected.html:
  • fast/text/simple-lines-multiple-renderers.html:
2:12 PM Changeset in webkit [176524] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139008

Reviewed by Anders Carlsson.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertReflection):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

2:09 PM Changeset in webkit [176523] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Stub out user content WebView member functions on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139033

Reviewed by Sam Weinig.

These functions aren't used by any clients and hinder getting rid of PageGroup.
If it turns out they're still needed we can copy the user content controller code from Mac Legacy WebKit.

  • WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
(toStringVector): Deleted.

12:48 PM Changeset in webkit [176522] by ryuan.choi@navercorp.com
  • 2 edits in trunk/Source/WebKit2

[EFL] REGRESSION(176066): It made all performance tests fail
​https://bugs.webkit.org/show_bug.cgi?id=138865

Reviewed by Csaba Osztrogonác.

Since r176066, there are crash because evas_gl_surface is destroyed with
invalid evas_gl instance after evas_gl is destroyed.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::~EwkView):

10:07 AM Changeset in webkit [176521] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Remove unused Style struct from SimpleLineLayout.cpp
​https://bugs.webkit.org/show_bug.cgi?id=139027

Reviewed by Sam Weinig.

It was moved to FlowContents.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::Style::Style): Deleted.

9:02 AM Changeset in webkit [176520] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Compile error in ResourceHandleManager.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=139026

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-11-24
Reviewed by Brent Fulgham.

The parameter types of the constructor of the Timer class has changed.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::downloadTimerCallback):

  • platform/network/curl/ResourceHandleManager.h:
6:49 AM Changeset in webkit [176519] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

Webkit2 doesnt build on powerpc 32 bits
​https://bugs.webkit.org/show_bug.cgi?id=130837

Reviewed by Carlos Garcia Campos.

Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.

  • PlatformGTK.cmake:
6:13 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
4:50 AM Changeset in webkit [176518] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.7.2

WebKitGTK+ 2.7.2

4:45 AM Changeset in webkit [176517] by Carlos Garcia Campos
  • 4 edits in trunk

.:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.2 release.

  • gtk/NEWS: Add release notes for 2.7.2.
4:12 AM Changeset in webkit [176516] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

  • gtk/manifest.txt: Remove deleted files.
4:05 AM Changeset in webkit [176515] by jdiggs@igalia.com
  • 6 edits in trunk

AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
​https://bugs.webkit.org/show_bug.cgi?id=139016

Reviewed by Chris Fleizach.

Source/WebCore:

There was one test that could not be unskipped without making a change
for that one to pass: mapping DocumentRegionRole to ATK_ROLE_PANEL. The
rest of the "fix" is just unskipping tests for ATK and updating the test
expectations.

No new tests needed.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

  • accessibility/roles-exposed.html: Unskipped a bunch of tests.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
3:30 AM Changeset in webkit [176514] by k.czech@samsung.com
  • 4 edits
    1 add in trunk

[EFL] Utilize Eail library to support accessibility in EFL
​https://bugs.webkit.org/show_bug.cgi?id=137742

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Initialize EAIL module so that all the listeners and atk-bridge started properly.
Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
(eail):

Tools:

Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.

  • efl/jhbuild-optional.modules: Added.
  • efl/jhbuild.modules:
3:18 AM Changeset in webkit [176513] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
​https://bugs.webkit.org/show_bug.cgi?id=139023

Reviewed by Sergio Villar Senin.

Source/WebKit2:

The WebKitWebContext is a construct only property, so it's always
set to the default value when not provided, during the
construction. When a related-view is used to create a new web view
we should ensure that the same web context is used for the new web
view, instead of the default. We should also ignore any web
context given as construct parameter if a related view is alos provided.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Do not set the context to the default
one when not given during construction.
(webkitWebViewSetProperty): Only use the default web context when
not provided as construct parameter and there isn't a related view.

Tools:

Rename WebKitWebView/default-context as WebKitWebView/web-context
and check we are always using the right context for new web views.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewWebContext):
(beforeAll):
(testWebViewDefaultContext): Deleted.

Nov 23, 2014:

11:24 PM Changeset in webkit [176512] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Add API to override the default local storage directory
​https://bugs.webkit.org/show_bug.cgi?id=138828

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebContext:local-storage-directory construct-only
property. If not provided the default will be used.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):

Tools:

Add test to check that the local storage directory is created at
the path given on construction.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextConfiguration):
(beforeAll):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::Test):
(Test::~Test): Deleted.

9:21 PM Changeset in webkit [176511] by Conrad Shultz
  • 4 edits in trunk/Source/WebKit2

Page previews should have titles
​https://bugs.webkit.org/show_bug.cgi?id=139020

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_titleForPreviewOfURL:.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _titleForPreviewOfURL:]):
Stub implementation.

  • UIProcess/mac/WKActionMenuController.mm:

(+[WKPagePreviewViewController previewPadding]):
Account for the title height.
(-[WKPagePreviewViewController loadView]):
Set correct autoresize masks on some views; create and configure a title view that is
horizontally and vertically centered.
(-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].

10:46 AM Changeset in webkit [176510] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use segment vector for FlowContents
​https://bugs.webkit.org/show_bug.cgi?id=139015

Reviewed by Zalan Bujtas.

And FlowContents::Segment struct and use it.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):

Use segments.
If there is only one segment there is nothing to do. Bail out.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments):

Move initialization to a function so m_segments can be const.
Don't add empty end segment, handle the end case in code.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::textWidth):

Simplify and use segments.

(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):

Replace hand-rolled binary search with std::lower_bounds.

(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
(WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::isEnd):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.

Renamed.

(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

Inline the fast path.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

10:00 AM Changeset in webkit [176509] by Simon Fraser
  • 12 edits in trunk/Source

Extend WKRenderObject and WKRenderLayer with some more useful data
​https://bugs.webkit.org/show_bug.cgi?id=139006

Reviewed by Sam Weinig.
Source/WebCore:

Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.

  • WebCore.exp.in:

Source/WebKit2:

Implement WKRenderLayerGetBackingStoreMemoryEstimate,
WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
RenderLayer and RenderTree display in clients of the C SPI.

  • Shared/API/c/WKRenderLayer.cpp:

(WKRenderLayerGetBackingStoreMemoryEstimate):

  • Shared/API/c/WKRenderLayer.h:
  • Shared/API/c/WKRenderObject.cpp:

(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):

  • Shared/API/c/WKRenderObject.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::backingStoreMemoryEstimate):

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:

(WebKit::WebRenderObject::textSnippet):
(WebKit::WebRenderObject::textLength):

Nov 22, 2014:

8:37 PM Changeset in webkit [176508] by gyuyoung.kim@samsung.com
  • 14 edits in trunk/Source/JavaScriptCore

Clean up OwnPtr and PassOwnPtr in some of JS classes
​https://bugs.webkit.org/show_bug.cgi?id=138724

Reviewed by Filip Pizlo.

As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.

  • builtins/BuiltinExecutables.h:

(JSC::BuiltinExecutables::create): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::createRareDataIfNecessary):

  • bytecode/StructureStubInfo.h:
  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

  • runtime/CodeCache.h:

(JSC::CodeCache::create): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::createRareDataIfNeeded):

  • runtime/RegExpConstructor.h:
  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):

  • runtime/SmallStrings.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
11:37 AM Changeset in webkit [176507] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Make locale part of the SimpleLineLayout::FlowContent::Style
​https://bugs.webkit.org/show_bug.cgi?id=139004

Reviewed by Zalan Bujtas.

That's the only part of style not extracted out of RenderStyle in the constructor.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):

  • rendering/SimpleLineLayoutFlowContents.h:

Also remove RenderBlockFlow member since it is now unused.

(WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.

Move to cpp.

11:07 AM Changeset in webkit [176506] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

r176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
​https://bugs.webkit.org/show_bug.cgi?id=139000

Reviewed by Darin Adler.

Check that the chainCount is non-zero before using a StructureChain.

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

10:18 AM Changeset in webkit [176505] by jdiggs@igalia.com
  • 12 edits
    6 adds in trunk

AX: [ATK] Accessible names missing for imagemap images and links
​https://bugs.webkit.org/show_bug.cgi?id=127288

Source/WebCore:

Reviewed by Chris Fleizach.

Return the alt text, if present, for the accessible name for image maps
and image map links for ATK. Also expose the accessible element with
ATK_ROLE_IMAGE_MAP instead of ATK_ROLE_IMAGE.

Test: accessibility/image-with-alt-and-map.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isImageMap):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName):
(atkRole):

LayoutTests:

New and updated tests to reflect the expected role, accessible hierarchy,
and exposure of the alternative text for each platform.

Reviewed by Chris Fleizach.

  • accessibility/image-with-alt-and-map.html: Added.
  • accessibility/roles-exposed.html: Added some more elements to the test.
  • platform/efl/accessibility/image-map1-expected.txt: Added.
  • platform/efl/accessibility/image-map2-expected.txt: Updated to reflect fix.
  • platform/efl/accessibility/image-with-alt-and-map-expected.txt: Added.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated for added elements.
  • platform/gtk/accessibility/image-map1-expected.txt: Added.
  • platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect fix.
  • platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Added.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated for added elements.
  • platform/mac/accessibility/image-with-alt-and-map-expected.txt: Added.
  • platform/mac/accessibility/roles-exposed-expected.txt: Updated for added elements.
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for added elements.
  • platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for added elements.
2:11 AM Changeset in webkit [176504] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unused Document::ignoreAutofocus().
<​https://webkit.org/b/139002>

Reviewed by Antti Koivisto.

No one ever actually changes this flag, so let's remove it.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

1:44 AM Changeset in webkit [176503] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r176459 to fix GTK build.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):

  • platform/ScrollAnimatorNone.h:
1:12 AM Changeset in webkit [176502] by akling@apple.com
  • 207 edits in trunk/Source

Convert PassRefPtr return types to RefPtr.
<​https://webkit.org/b/138995>

Reviewed by Anders Carlsson.

Convert an assortment of DOM and HTML related functions
to return RefPtr instead of PassRefPtr.

Nov 21, 2014:

11:50 PM Changeset in webkit [176501] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix; move new symbols out of Mac-only exports.

  • WebCore.exp.in:
10:38 PM Changeset in webkit [176500] by timothy_horton@apple.com
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove a file that r176499 presumably did not mean to add.

  • WebCore.exp.in.orig: Removed.
9:27 PM Changeset in webkit [176499] by jer.noble@apple.com
  • 30 edits
    2 copies
    4 adds in trunk/Source

Support multiple signatures of diagnostic logging.
​https://bugs.webkit.org/show_bug.cgi?id=138690

Reviewed by Anders Carlsson.

Source/WebCore:

Pull logDiagnosticMessage() out of ChromeClient and make a new client interface,
DiagnosticLoggingClient, which supports multiple kinds of diagnostic logging,
namely: simple logging without a parameter, logging with a success parameter, and
logging with a generic string value parameter.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Use DiagnosticLoggingClient.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.

  • loader/SubframeLoader.cpp:

(WebCore::logPluginRequest): Ditto.

  • page/ChromeClient.h:

(WebCore::ChromeClient::logDiagnosticMessage): Deleted.

  • page/DiagnosticLoggingClient.h:

(WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Added.
(WebCore::DiagnosticLoggingClient::~DiagnosticLoggingClient): Empty destructor.

Rename Page::PageClient to PageConfiguration, and pass that configuration from
Page into MainFrame upon construction.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage): Use PageConfiguration instead of PageClients.

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients): Ditto.

  • loader/EmptyClients.h:
  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Pass loaderClientForMainFrame through to the

Frame constructor.

(WebCore::MainFrame::create): Takes a PageConfiguration.

  • page/MainFrame.h:

(WebCore::MainFrame::diagnosticLoggingClient): Simple accessor.

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients): Deleted.
(WebCore::Page::PageClients::~PageClients): Deleted.

  • page/Page.h:
  • page/PageConfiguration.cpp: Added.

(WebCore::PageConfiguration::PageConfiguration): Renamed from PageClients().
(WebCore::PageConfiguration::~PageConfiguration): Renamed from ~PageClients().

  • page/PageConfiguration.h: Added.
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): Use PageConfiguration instead of PageClients.

Add new files and symbols to the project.

  • CMakeLists.txt:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Page::PageClients has been renamed PageConfiguration.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit/win:

Page::PageClients has been renamed PageConfiguration.

  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

Extend the existing WKBundlePageDiagnosticLoggingClient interface by deprecating
the original logDiagnosticMessage client method in V1 and adding three new,
explicit client methods.

  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageDeprecated):

Renamed from logDiagnosticMessage().

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Pass to the client.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::logDiagnosticMessage): Deleted.

  • WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp: Added.

(WebKit::WebDiagnosticLoggingClient::WebDiagnosticLoggingClient): Simple constructor.
(WebKit::WebDiagnosticLoggingClient::~WebDiagnosticLoggingClient): Simple destructor.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage): Pass to the injected bundle.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.

  • WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize the new client.

8:25 PM Changeset in webkit [176498] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Unreviewed. Fixed syntax errors.

  • init-database.sql:
  • public/api/commits.php:
7:42 PM Changeset in webkit [176497] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

The dashboard on new perf monitor should be configurable
​https://bugs.webkit.org/show_bug.cgi?id=138994

Reviewed by Benjamin Poulain.

For now, make it configurable via config.json. We should eventually make it configurable via
an administrative page but this will do for now.

  • config.json: Added the empty dashboard configuration.
  • public/include/manifest.php: Include the dashboard configuration in the manifest file.
  • public/v2/app.js:

(App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
(App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
Also obtain the default configuration from App.Manifest.
(App.IndexController._normalizeTable): Moved to App.Dashboard.

  • public/v2/manifest.js:

(App.Repository.urlForRevision): Fixed the position of the open curly bracket.
(App.Repository.urlForRevisionRange): Ditto.
(App.Dashboard): Added.
(App.Dashboard.table): Extracted from App.IndexController.gridChanged.
(App.Dashboard.rows): Ditto.
(App.Dashboard.headerColumns): Ditto.
(App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
(App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
Since there is exactly one dashboard object per app, it's okay to hard code an id here.
(App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.

7:29 PM Changeset in webkit [176496] by Chris Dumez
  • 10 edits
    1 move
    1 add in trunk

Throttled DOMTimers can prevent their document from being garbage collected
​https://bugs.webkit.org/show_bug.cgi?id=138915

Reviewed by Andreas Kling.

Source/WebCore:

Throttled DOMTimers whose interval depend on viewport changes would
keep a Vector of elements outside viewport causing them to be throttled
so that we could check later on (upon scroll or layout) if those
elements are still outside viewport. The issue is that these elements
could potentially be removed from the document (and destroyed) after
the timer has fired. To handle this, DOMTimer was ref'ing the
elements. Unfortunately, this was causing us to leak the document
as the elements in the Vector would keep the document alive.

To handle this issue, this patch updates the DOMTimer Vector to use
weak pointers. The WeakPtrFactory is stored in ElementRareData to
avoid wasting memory for all kinds of Elements (it is a fair assumption
that the number of elements whose style is animated via timers is low).

Test: fast/dom/throttled-timer-running-on-document-destruction.html

  • dom/Element.cpp:

(WebCore::Element::createWeakPtr):

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::weakPtrFactory):

  • page/DOMTimer.cpp:

(WebCore::DOMTimerFireState::elementsChangedOutsideViewport):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):

  • page/DOMTimer.h:

LayoutTests:

Improve fast/dom/throttled-timer-running-on-document-destruction.html
layout test to cover the case where the throttled timer is changing the
style of an element on the *same* document when the document is
destroyed.

  • fast/dom/resources/frame-with-throttled-timer-animating-element-other-document.html: Renamed from LayoutTests/fast/dom/resources/frame-with-throttled-timer.html.
  • fast/dom/resources/frame-with-throttled-timer-animating-element-same-document.html: Added.
  • fast/dom/throttled-timer-running-on-document-destruction.html:
7:27 PM Changeset in webkit [176495] by gyuyoung.kim@samsung.com
  • 28 edits in trunk/Source

Unreviewed, EFL build fix since r176459.

r176459 removed Timer parameter in timer callbacks only for Mac port.
So this patch applies it to remaining classes for EFL port.

Source/WebCore:

No new tests, fix build break.

  • Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::RTCDTMFSender):

  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::RTCDataChannel):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::Vibration):
(WebCore::Vibration::timerFired):

  • Modules/vibration/Vibration.h:
  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):

  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::timerFired):

  • platform/efl/BatteryProviderEfl.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
(WebCore::CoordinatedImageBacking::clearContentsTimerFired):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
  • platform/mock/DeviceMotionClientMock.cpp:

(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::timerFired):

  • platform/mock/DeviceMotionClientMock.h:
  • platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::TimerEvent):
(WebCore::TimerEvent::timerFired):

Source/WebKit2:

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::TextCheckerClientEfl):
(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):

  • UIProcess/efl/TextCheckerClientEfl.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
6:06 PM Changeset in webkit [176494] by benjamin@webkit.org
  • 20 edits in trunk/Source

Start using the new :not() and :matches() in the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=138978

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-21
Reviewed by Joseph Pecoraro.

Source/WebCore:

There are only minor pending issues on :not() and :matches(). The feedback
has only been positive so far. It is time to move them out the experimental
flag.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

  • css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):
(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
(WebCore::appendSelectorList):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::determineLinkMatchType):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

Source/WebInspectorUI:

Start simpifying some definitions by using modern CSS.

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
(.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
(.style-declaration-section.selector-locked > .header > .selector): Deleted.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.

  • UserInterface/Views/ControlToolbarItem.css:

(.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
(.toolbar.icon-only .item.control): Deleted.

  • UserInterface/Views/DOMStorageContentView.css:
  • UserInterface/Views/DashboardContainerView.css:

(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
(.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.

  • UserInterface/Views/DataGrid.css:

(.data-grid :matches(th, td):not(:last-child)):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid :matches(th, td) > div):
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid tr:matches(.selected, :hover) .go-to-arrow):
(.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
(.data-grid :-webkit-any(th, td) > div): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.

  • UserInterface/Views/DebuggerDashboardView.css:

(.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
(.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.

  • UserInterface/Views/DefaultDashboardView.css:

(body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
(body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
(body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
(body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.

  • UserInterface/Views/DetailsSection.css:

(.details-section > .header > :matches(.node-link, .go-to-arrow)):
(.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
(body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
(.details-section > .header > .go-to-arrow): Deleted.
(.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
(.details-section > .content > .group > .row.text): Deleted.
(body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.

  • UserInterface/Views/FindBanner.css:

(:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
(.supports-find-banner.no-find-banner-transition): Deleted.

  • UserInterface/Views/FlexibleSpaceNavigationItem.css:

(:matches(.navigation-bar, .toolbar) .item.flexible-space):
(.toolbar .item.flexible-space): Deleted.

6:06 PM Changeset in webkit [176493] by rniwa@webkit.org
  • 10 edits in trunk/Websites/perf.webkit.org

There should be a way to associate bugs with analysis tasks
​https://bugs.webkit.org/show_bug.cgi?id=138977

Reviewed by Benjamin Poulain.

Updated associate-bug.php to match the new database schema.

  • public/include/json-header.php:

(require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
already camel-cased in require_existence_of. This makes the function usable elsewhere.

  • public/privileged-api/associate-bug.php:

(main): Changed the API to take run, bugTracker, and number to match the new database schema.
Also verify that those values are integers using require_format.

  • public/v2/analysis.js:

(App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
(App.Bug.label): Added.
(App.BugAdapter): Added.
(App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
(App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.

  • public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table

containing the bug information.

  • public/v2/app.js:

(App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
(App.AnalysisTaskRoute):
(App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
(App.AnalysisTaskController._fetchedManifest): Added.
(App.AnalysisTaskController.actions.associateBug): Added.

  • public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
  • public/v2/data.js:

(Measurement.prototype.associateBug): Deleted.

  • public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.

Added a table show the bug information. Also hide the chart until chartData is available.

  • public/v2/manifest.js:

(App.Model): Added.

5:43 PM Changeset in webkit [176492] by Chris Dumez
  • 4 edits in trunk/Source

Unreviewed, iOS build fix after r176462.

Source/WebCore:

Export a few extra symbols.

  • WebCore.exp.in:

Source/WebKit2:

Fix include path to TextIndicator.h to include WebCore/
as it was moved.

  • UIProcess/ios/PageClientImplIOS.mm:
5:26 PM Changeset in webkit [176491] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Properties in CSSPropertyNames.in should use the new StyleBuilder by default
​https://bugs.webkit.org/show_bug.cgi?id=138983

Reviewed by Andreas Kling.

This patch makes using the new StyleBuilder the default and drops the
[NewStyleBuilder] option as a result. A new [LegacyStyleBuilder] option
is introduced for CSS properties that are not generated in the new
StyleBuilder yet.

  • css/CSSPropertyNames.in:
  • css/SVGCSSPropertyNames.in:
  • css/makeprop.pl:
5:22 PM Changeset in webkit [176490] by Chris Dumez
  • 4 edits
    3 adds in trunk

[iOS] Regression(r176202): line-height is wrong on marco.org
​https://bugs.webkit.org/show_bug.cgi?id=138970

Reviewed by Simon Fraser.

Source/WebCore:

After r176202, on iOS with IOS_TEXT_AUTOSIZING enabled, we would
multiply the lineHeight by RenderStyle::textSizeAdjust()::multiplier()
unconditionally. However, we're only supposed to do so if
RenderStyle::textSizeAdjust()::isPercentage() returns true. This
patch reintroduces the textSizeAdjust().isPercentage() check that was
inadvertently dropped when refactoring the code to be shared between
iOS and OS X.

Additionally, the multiplier is only supposed the be applied if the
input CSSPrimitiveValue is a Length or a Number. However, after
r176202, we would apply the multiplier if the CSSPrimitiveValue is
a Percentage or a Number. This patch updates the code to match the
behavior prior to r176202.

Test: fast/css/line-height-text-autosizing.html

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::convertLineHeight):
(WebCore::StyleBuilderFunctions::applyValueLineHeight):

LayoutTests:

Add layout test to cover line-height CSS property and its interaction
with -webkit-text-size-adjust.

  • fast/css/line-height-text-autosizing-expected.txt: Added.
  • fast/css/line-height-text-autosizing.html: Added.
  • platform/ios-simulator/fast/css/line-height-text-autosizing-expected.txt: Added.
5:09 PM Changeset in webkit [176489] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, iOS build fix after r176452.

dencodeFixedLengthData() now only takes 2 arguments instead of
3.

  • Shared/ios/QuickLookDocumentData.cpp:

(WebKit::QuickLookDocumentData::decode):

4:59 PM Changeset in webkit [176488] by Alan Bujtas
  • 14 edits in trunk

Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=138981

Reviewed by Simon Fraser.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
(-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _simpleLineLayoutDebugBordersEnabled]):
(-[WKPreferences _setSimpleLineLayoutDebugBordersEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Tools:

  • MiniBrowser/mac/SettingsController.h:
  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
(-[SettingsController simpleLineLayoutDebugBordersEnabled]):

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

4:55 PM Changeset in webkit [176487] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

WebVideoFullscreenManagerProxy must clear pointers when invalidated
​https://bugs.webkit.org/show_bug.cgi?id=138982

Reviewed by Jer Noble.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
(WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and

WebVideoFullscreenChangeObserver to NULL.

4:51 PM Changeset in webkit [176486] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):

4:19 PM Changeset in webkit [176485] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

The preview action menu item should not have a title
​https://bugs.webkit.org/show_bug.cgi?id=138989
-and corresponding-
rdar://problem/19061959

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _createActionMenuItemForTag:]):

4:11 PM Changeset in webkit [176484] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
​https://bugs.webkit.org/show_bug.cgi?id=138905

Reviewed by Mario Sanchez Prada.

The crash log indicates that m_renderer is null at the time we ask ancestorsOfType().
This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.

Unable to determine cause of crash or how to reproduce on demand.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

4:07 PM Changeset in webkit [176483] by Conrad Shultz
  • 2 edits in trunk/Source/WebKit2

Page previews should have a margin.
​https://bugs.webkit.org/show_bug.cgi?id=138990

Reviewed by Beth Dakin.

Enclose the WKWebView (or client-supplied preview view) in a container slightly larger
than the preview view. Adjust sizing code to accommodate the margin.

  • UIProcess/mac/WKActionMenuController.mm:

(+[WKPagePreviewViewController previewPadding]):
Return the total amount of fixed padding surrounding the preview
(-[WKPagePreviewViewController loadView]):
Store the actual previewView in an ivar so that clients can distinguish it from the container
view; wrap the preview in a container view; set frames appropriately.
(-[WKActionMenuController _createPreviewPopover]):
Update to reflect method rename; supplement the popover size with the fixed padding.
(-[WKActionMenuController _preferredPopoverSizeWithPreviewPadding:]):
Renamed from -_preferredPopoverSize; account for the fixed padding when computing the preferred size.
(-[WKActionMenuController _clearPreviewPopover]):
Use the previewView ivar instead of the view controller's view.
(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
Ditto.
(-[WKActionMenuController _preferredPopoverSize]): Deleted.

4:04 PM Changeset in webkit [176482] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[EME][Mac] Check the underlying error if the one returned by AVFoundation is AVErrorUnknown.
​https://bugs.webkit.org/show_bug.cgi?id=138986

Reviewed by Eric Carlson.

When we recieve an error with the code AVErrorUnknown, look for an underlying error from CoreMedia (or another
lower-level framework) with a (presumably) more informative error code, and return that code instead.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::systemCodeForError):
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):

4:02 PM Changeset in webkit [176481] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
​https://bugs.webkit.org/show_bug.cgi?id=138904

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Add an attribute that marks when a text field is auto-filled.

Test: accessibility/auto-filled-value.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isValueAutofilled):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • accessibility/auto-filled-value.html: Added.
  • platform/mac/accessibility/auto-filled-value-expected.txt: Added.
3:53 PM Changeset in webkit [176480] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (r176415): Can get stuck, unable to invoke any DataDetectors popovers
​https://bugs.webkit.org/show_bug.cgi?id=138955
<rdar://problem/19056442>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):

  • UIProcess/mac/WKActionMenuController.h:
  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController menuNeedsUpdate:]):
Keep track of whether we have called shouldUseActionsWithContext: on a
DDActionContext; if we get a mouseDown without having seen didCloseMenu:
(and thus don't properly pair the shouldUseActionsWithContext: with a didUseActions),
tear down the old DDActionContext before proceeding.

3:41 PM Changeset in webkit [176479] by msaboff@apple.com
  • 23 edits
    2 adds in trunk

Allocate local ScopeChain register
​https://bugs.webkit.org/show_bug.cgi?id=138793

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Now we allocate the scope register as a local. The allocated register is stored in the
CodeBlock for use by other components. Update the DFG to work with a local scope register.
Changed usage of JSStack::ScopeChain access to the CallFrame header to use the allocated
local register.

  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
Updated to properly represent the operand inputs and bytecode result.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::setScopeRegister):
(JSC::UnlinkedCodeBlock::scopeRegister):
Added scope register member and accessors.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::allocateAndEmitScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::scopeRegister):
Change m_scopeRegister to an allocated register. Added allocateAndEmitScope helper to
allocate the scope register, set the CodeBlock with its value and emit op_get_scope.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::scope): Changed to access the scope using the new convention.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
Changed op_create_lexical_environment to set the scope VirtualRegister operand.
Filled out op_get_scope processing to emit a GetScope node putting the result in
the scope VirtualRegister result operand.
Added Phantoms where appropriate to keep the Scope register alive in places where
it use is optimized away, but where the baseline JIT would need to use its value.
Eliminated uses of JSStack::ScopeChain.

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):
Make sure that the scope register stack location is allocated using the same place
that the codeBlock expects.

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):
Allow strength reduction of Flush to skip of GetScope nodes looking for a prior
corresponding SetLocal.

  • interpreter/CallFrame.h:

(JSC::ExecState::scope):
(JSC::ExecState::setScope):
Added new scope() and setScope() helpers that take a VirtualRegister offset.

  • interpreter/Interpreter.cpp:

(JSC::eval):
Changed eval() to get the scope from the caller's scope register instead of from the
temporary frame created for eval.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):
Changed unwind() to manipulate the scope n the allocated register instead of from the
call frame slot.

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):

  • interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::callee):
(JSC::StackVisitor::Frame::scope): Deleted.
Eliminated the scope member as it needed to change and no StackVisitor users use it.

  • jit/JITOperations.cpp:

(JSC::operationPushNameScope):
(JSC::operationPushWithScope):

  • runtime/JSNameScope.h:

(JSC::JSNameScope::create):

  • runtime/JSWithScope.h:

(JSC::JSWithScope::create): Deleted.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
Deleted JSNameScope::create() and JSWithScope::create() flavors tht used the ScopeChain slot
in the CallFrame header. Changed the only user of these function, op_push_name_scope and
op_push_with_scope helpers, to use the remaining create variants that require explicit scope.
Those operations get the scope from the register pointed to by their scope operands.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Changed resolveScope to use the allocated register.

LayoutTests:

New test that sets a breakpoint in a callee of a DFG caller. While stopped in the
breakpoint, it modifies a global via the scope chain of the DFG caller as well as
a local of the DFG caller.

  • inspector-protocol/debugger/resources/breakpoint.js:

(notInlineable3):
(dfgWithoutInline3):

  • inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
  • inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html: Added.
3:39 PM Changeset in webkit [176478] by akling@apple.com
  • 27 edits in trunk/Source/WebCore

RenderElement::removeChild() doesn't need a return value.
<​https://webkit.org/b/138985>

Reviewed by Pantti Koivisto.

Nobody uses the return value from RenderElement::removeChild().
Change it to return void and remove all the unnecessary plumbing.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::removeChild):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::removeChild):

  • rendering/RenderButton.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::removeChild):
(WebCore::RenderElement::removeChildInternal):

  • rendering/RenderElement.h:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::removeChild):

  • rendering/RenderMenuList.h:
  • rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::removeChild):

  • rendering/RenderRuby.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

  • rendering/RenderRubyRun.h:
  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):

  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::removeChild):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChild):

  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::removeChild):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::removeChild):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::removeChild):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::removeChild):

  • rendering/svg/RenderSVGText.h:
3:38 PM Changeset in webkit [176477] by timothy_horton@apple.com
  • 6 edits in trunk/Source

REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
​​https://bugs.webkit.org/show_bug.cgi?id=138960
<rdar://problem/19056715>

Reviewed by Anders Carlsson.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
(-[WKActionMenuController _defaultMenuItemsForMailtoLink]): Deleted.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
Use DataDetectors SPI instead of an explicit blacklist.

  • platform/spi/mac/DataDetectorsSPI.h:

Add some DataDetectors SPI.

3:29 PM Changeset in webkit [176476] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Random crashes inside media libraries when creating then destroying media quickly.
​https://bugs.webkit.org/show_bug.cgi?id=138980

Reviewed by Eric Carlson.

Speculative fix for random crashes in the layout tests which occur randomly but regularly. The theory is
that creating-then-destroying our media objects too quickly triggers crashes deep within the media frameworks
when their initialization threads don't have a chance to complete before the main player object is destroyed.
Test out this theory by delaying the destruction of the AVPlayer object for 1s after its owner is destroyed.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):

3:24 PM Changeset in webkit [176475] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Delay of 1-2s after the first paint of a video frame.
​https://bugs.webkit.org/show_bug.cgi?id=138979

Reviewed by Eric Carlson.

Only bother waiting for a signal that a new image is ready when the image isn't ready in the first place.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

3:10 PM Changeset in webkit [176474] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Crashes while encoding a TextIndicator with no contentImageWithHighlight
​https://bugs.webkit.org/show_bug.cgi?id=138984
<rdar://problem/19063717>

Reviewed by Sam Weinig.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
encodeImage doesn't deal with null images, so handle that case gracefully.

2:33 PM Changeset in webkit [176473] by mmaxfield@apple.com
  • 13 edits in trunk

Source/WebCore:
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
​https://bugs.webkit.org/show_bug.cgi?id=89235

Reviewed by Eric Seidel and Dave Hyatt.

This patch adds semantic support for the CSS3 line-break property (qua -webkit-line-break),
and enables testing on (apple) mac ports. Follow on patches will enable these tests on
other ports as they are incrementally verified.

See also wiki documentation at:
[1] ​http://trac.webkit.org/wiki/LineBreaking
[2] ​http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Tests: css3/line-break/line-break-auto-centered.html

css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html

These tests were previously added in ​http://trac.webkit.org/changeset/143378, but skipped
in generic TestExpectations. In this patch, they are marked as Pass for the (apple) mac ports.

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(LineBreakIteratorPool):
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore):
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.

Note that this function only calls ubrk_openRules() when the author has opted-in via
using the -webkit-line-break CSS property. Eventually, we would like to be able to
customize the rules that ICU's line breaking algorithm uses (especially for CJK text);
however, ubrk_openRules() currently parses its input string to create a DFA and is
therefore very slow. In fact, it's so slow that increasing our cache size in
LineBreakIteratorPool doesn't actually help enough. Also note that the default value
for the line-break CSS property is 'auto'.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

  • rendering/RenderText.cpp:

(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore):
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

  • rendering/RenderText.h:

(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

  • rendering/break_lines.cpp:

(WebCore):
Introduce (local) enum NBSPBehavior for expanding template on nextBreakablePosition.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Use enum NBSP behavior template parameter rather than boolean.
(WebCore::nextBreakablePositionNonLoosely):
Extend name to distinguish from loose flavor of this function.
(WebCore::nextBreakablePositionLoosely):
Add loose flavor of NBP invoked only when loose mode applies, in which case ASCII shortcut
table cannot be used.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use (renamed) non-loose flavor of NBP.
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
Introduce loose flavor of NBP template expansions.

  • rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests:
CSS3: line-break property support
​https://bugs.webkit.org/show_bug.cgi?id=89235

Reviewed by Eric Seidel and Dave Hyatt.

  • platform/mac/TestExpectations: Mark css3/line-break tests as passing.
1:34 PM Changeset in webkit [176472] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

More build fixes.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):

1:22 PM Changeset in webkit [176471] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] allocate volume view on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=138971
rdar://problem/18016958

Reviewed by Jer Noble.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper allocateVolumeView]): New, dispatch to the main thread if necessary before allocating

the volume view.

(-[WebMediaSessionHelper initWithCallback:]): Call allocateVolumeView.

1:08 PM Changeset in webkit [176470] by Alan Bujtas
  • 3 edits
    2 adds in trunk

REGRESSION(r175259) Simple line layout text measuring behavior changed.
​https://bugs.webkit.org/show_bug.cgi?id=138947
rdar://problem/19050653

Reviewed by Antti Koivisto.

In certain cases, when block flow needs to compute the preferred width of a particular text
renderer, we use the non-simple line layout text measuring.
However, the same text renderer might end up at simple line layout later.
Complex line layout measures text including the trailing space and it subtracts
(the constant value of) space width afterwards, while simple line layout measures
runs without the extra space.
In such cases, this may result different word widths and produce unexpected line breaking. (preferred width != final width)
In long term, any text renderer qualified for simple line layout should go through the simple
text measuring code path. (​https://bugs.webkit.org/show_bug.cgi?id=138973)
For now, just copy complex line layout behaviour. This also matches the previous simple line layout line breaking implementation.

Source/WebCore:

Test: fast/text/simple-line-text-measuring-with-trailing-space.html

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::textWidth):

LayoutTests:

  • fast/text/simple-line-text-measuring-with-trailing-space-expected.html: Added.
  • fast/text/simple-line-text-measuring-with-trailing-space.html: Added.
1:01 PM Changeset in webkit [176469] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit

Add a new symbol.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
12:57 PM Changeset in webkit [176468] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit

Remove a symbol that's gone.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
12:51 PM Changeset in webkit [176467] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another Windows build fix.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::FullscreenVideoController):

12:44 PM Changeset in webkit [176466] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

More Windows build fixes.

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
  • platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::controllerTimerFired):

  • platform/mock/GeolocationClientMock.h:
12:42 PM Changeset in webkit [176465] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

RenderMathMLScripts isPrescript() helper should take a reference.
<​https://webkit.org/b/138975>

Reviewed by Antti Koivisto.

Tidy this up a bit, since it's never called with a null pointer.

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::isPrescript):
(WebCore::RenderMathMLScripts::fixAnonymousStyles):
(WebCore::RenderMathMLScripts::addChildInternal):
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::layout):
(WebCore::RenderMathMLScriptsWrapper::addChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):

12:37 PM Changeset in webkit [176464] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Windows build fixes.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired):
(WebCore::PluginPackage::PluginPackage):

  • plugins/PluginPackage.h:
  • plugins/PluginStream.cpp:

(WebCore::PluginStream::PluginStream):
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::deliverData): Deleted.

  • plugins/PluginStream.h:
  • plugins/PluginView.cpp:

(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::lifeSupportTimerFired):
(WebCore::PluginView::performRequest): Deleted.
(WebCore::PluginView::setValue): Deleted.
(WebCore::PluginView::setParameters): Deleted.
(WebCore::PluginView::userAgent): Deleted.

  • plugins/PluginView.h:
  • plugins/win/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

  • plugins/win/PluginMessageThrottlerWin.h:
12:28 PM Changeset in webkit [176463] by timothy_horton@apple.com
  • 6 edits in trunk/Source

REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
​https://bugs.webkit.org/show_bug.cgi?id=138960
<rdar://problem/19056715>

Reviewed by Beth Dakin.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
Blacklist contact results, because they don't have useful menus. If we
bail before setting up _currentActionContext, we'll still allow fallthrough
to ordinary text actions, avoiding mysterious failure when a contact is detected.

This doesn't break the case that r176351 was intended to fix,
because in that case we were detecting e.g. addresses.

  • platform/spi/mac/DataDetectorsSPI.h:

Softlink some SPI.

12:18 PM Changeset in webkit [176462] by timothy_horton@apple.com
  • 33 edits
    4 adds
    4 deletes in trunk/Source

Move TextIndicator{Window} to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=138954
<rdar://problem/18992185>

Some adjustments by Csaba Osztrogonác.
Reviewed by Anders Carlsson.

Move TextIndicator and TextIndicatorWindow to WebCore so that both
WebKits can share the implementation.

  • CMakeLists.txt:

Remove TextIndicator.cpp.

  • Scripts/webkit/messages.py:

(struct_or_class):
(headers_for_type):
Tell messages.py that TextIndicatorData is a struct, and comes from TextIndicator.h.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
Add argument coders for TextIndicatorData.

  • Shared/DictionaryPopupInfo.h:
  • Shared/mac/ActionMenuHitTestResult.h:
  • Shared/mac/ActionMenuHitTestResult.mm:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/WKContentView.h:
  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:
  • UIProcess/mac/WKActionMenuController.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:

Adjust to TextIndicator and TextIndicatorWindow's new home.

  • CMakeLists.txt:

Build TextIndicator.

  • WebCore.exp.in:

Export TextIndicator{Window} symbols for the WebKits.

  • WebCore.xcodeproj/project.pbxproj:
  • page/TextIndicator.cpp: Renamed from Source/WebKit2/Shared/TextIndicator.cpp.
  • page/TextIndicator.h: Renamed from Source/WebKit2/Shared/TextIndicator.h.

Straighforward move of TextIndicator from WebKit2, except:

Move TextIndicator::Data and TextIndicator::PresentationTransition out directly
into the WebCore namespace to allow for implementation of WebKit2 argument coders.

Use Image instead of ShareableBitmap internally.

Move the TextIndicatorData encode/decode to WebCoreArgumentCoders.

  • page/mac/TextIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.h.
  • page/mac/TextIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.mm.

Straighforward move of TextIndicatorWindow from WebKit2.

12:13 PM Changeset in webkit [176461] by andersca@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Remove a duplicate ChangeLog entry.

12:11 PM Changeset in webkit [176460] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r176238): Mailto links are getting preloaded, which results in a compose window
​https://bugs.webkit.org/show_bug.cgi?id=138972

Reviewed by Beth Dakin.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController willOpenMenu:withEvent:]):
Only preload links.

12:10 PM Changeset in webkit [176459] by andersca@apple.com
  • 242 edits in trunk/Source

Remove the Timer parameters from timer callbacks
​https://bugs.webkit.org/show_bug.cgi?id=138974

Reviewed by Antti Koivisto.

Source/WebCore:

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::GeoNotifier):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::resumeTimerFired):

  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::removeTimerFired):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::RTCDTMFSender):
(WebCore::RTCDTMFSender::scheduledEventTimerFired):

  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::scheduledEventTimerFired):

  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::taskTimerFired):

  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationRequestCallback::NotificationRequestCallback):
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):

  • Modules/notifications/NotificationCenter.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::closingTimerFired):

  • Modules/websockets/WebSocketChannel.h:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AXObjectCache.h:
  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):
(WebCore::GCController::gcTimerFired):

  • bindings/js/GCController.h:
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::beginLoadTimerFired):

  • css/CSSFontSelector.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):

  • css/StyleResolver.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
(WebCore::Document::domCookieCacheExpiryTimerFired):

  • dom/Document.h:
  • dom/EventSender.h:

(WebCore::EventSender::timerFired):
(WebCore::EventSender<T>::EventSender):

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::ScriptRunner):
(WebCore::ScriptRunner::timerFired):

  • dom/ScriptRunner.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::animationTimerFired):

  • dom/ScriptedAnimationController.h:
  • dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::timerFired):

  • editing/AlternativeTextController.h:
  • editing/Editor.cpp:

(WebCore::Editor::Editor):
(WebCore::Editor::updateEditorUINowIfScheduled):
(WebCore::Editor::editorUIUpdateTimerFired):
(WebCore::Editor::scanSelectionForTelephoneNumbers): Deleted.

  • editing/Editor.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::caretBlinkTimerFired):

  • editing/FrameSelection.h:
  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

  • editing/SpellChecker.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocompleteTimerFired):

  • html/HTMLFormElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement):
(WebCore::HTMLPlugInElement::swapRendererTimerFired):

  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::HTMLSourceElement):
(WebCore::HTMLSourceElement::errorEventTimerFired):

  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::loadTimerFired):

  • html/HTMLTrackElement.h:
  • html/MediaController.cpp:

(MediaController::MediaController):
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):

  • html/MediaController.h:
  • html/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/MediaDocument.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::searchEventTimerFired):

  • html/SearchInputType.h:
  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::requestToHideMessage):
(WebCore::ValidationMessage::deleteBubbleTree):

  • html/ValidationMessage.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):

  • html/parser/HTMLParserScheduler.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::MediaControls):
(WebCore::MediaControls::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControls.h:
  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • html/shadow/SpinButtonElement.h:
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):
(WebCore::LoadableTextTrack::loadTimerFired):

  • html/track/LoadableTextTrack.h:
  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::VTTRegion):
(WebCore::VTTRegion::scrollTimerFired):

  • html/track/VTTRegion.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::timerFired):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::timerFired):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::timerFired):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::updatePaintRectsTimerFired):

  • inspector/InspectorOverlay.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::handleSubstituteDataLoadSoon):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::checkTimerFired):

  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::timerFired):

  • loader/ImageLoader.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::LinkLoader):
(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):

  • loader/LinkLoader.h:
  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::timerFired):

  • loader/NavigationScheduler.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::PingLoader):

  • loader/PingLoader.h:

(WebCore::PingLoader::timeoutTimerFired):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):

  • loader/ProgressTracker.h:
  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::requestTimerFired):

  • loader/ResourceLoadScheduler.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::TextTrackLoader):
(WebCore::TextTrackLoader::cueLoadTimerFired):

  • loader/TextTrackLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::Callback::Callback):
(WebCore::CachedResource::Callback::timerFired):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::syncTimerFired):

  • loader/icon/IconDatabase.h:
  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::autoscrollTimerFired):

  • page/AutoscrollController.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::CaptionUserPreferences):
(WebCore::CaptionUserPreferences::timerFired):

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF):
(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired):

  • page/CaptionUserPreferencesMediaAF.h:
  • page/DeviceController.cpp:

(WebCore::DeviceController::DeviceController):
(WebCore::DeviceController::fireDeviceEvent):

  • page/DeviceController.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::recognizeLongMousePress):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):

  • page/EventHandler.h:
  • page/EventSource.cpp:

(WebCore::EventSource::EventSource):
(WebCore::EventSource::connectTimerFired):

  • page/EventSource.h:
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::focusRepaintTimerFired):

  • page/FocusController.h:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::overflowAutoScrollTimerFired):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::delayedScrollEventTimerFired):
(WebCore::FrameView::speculativeTilingEnableTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::postLayoutTimerFired):

  • page/FrameView.h:
  • page/PageOverlay.cpp:

(WebCore::PageOverlay::PageOverlay):
(WebCore::PageOverlay::fadeAnimationTimerFired):

  • page/PageOverlay.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::imageLoadingSettingsTimerFired):

  • page/Settings.h:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):

  • page/animation/AnimationControllerPrivate.h:
  • page/mac/ServicesOverlayController.h:
  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::ServicesOverlayController):
(WebCore::ServicesOverlayController::determineActiveHighlightTimerFired):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired):

  • platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::HysteresisActivity):
(WebCore::HysteresisActivity::hysteresisTimerFired):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

  • platform/ScrollAnimator.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::autoscrollTimerFired):

  • platform/Scrollbar.h:
  • platform/Timer.h:

(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
(WebCore::Timer::Timer): Deleted.

  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::MediaSession):
(WebCore::MediaSession::clientDataBufferingTimerFired):

  • platform/audio/MediaSession.h:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::reloadTimerFired):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::timerFired):

  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired):

  • platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::LayerPool):
(WebCore::LayerPool::pruneTimerFired):

  • platform/graphics/ca/LayerPool.h:
  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::TileController):
(WebCore::TileController::tileRevalidationTimerFired):

  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::TileGrid):
(WebCore::TileGrid::cohortRemovalTimerFired):

  • platform/graphics/ca/TileGrid.h:
  • platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::IOSurfacePool):
(WebCore::IOSurfacePool::collectionTimerFired):

  • platform/graphics/cg/IOSurfacePool.h:
  • platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):

  • platform/ios/LegacyTileCache.h:
  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::LegacyTileCache):
(WebCore::LegacyTileCache::tileCreationTimerFired):

  • platform/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):

  • platform/mac/HIDGamepadProvider.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

  • platform/mock/DeviceOrientationClientMock.cpp:

(WebCore::DeviceOrientationClientMock::DeviceOrientationClientMock):
(WebCore::DeviceOrientationClientMock::timerFired):

  • platform/mock/DeviceOrientationClientMock.h:
  • platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):

  • platform/mock/PlatformSpeechSynthesizerMock.h:
  • platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::timerFired):

  • platform/network/DNSResolveQueue.h:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::failureTimerFired):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::highQualityRepaintTimerFired):

  • rendering/ImageQualityController.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::timerFired):

  • rendering/RenderButton.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::RenderMarquee):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMarquee.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::animationTimerFired):

  • rendering/RenderProgress.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::lazyRepaintTimerFired):

  • rendering/RenderView.h:
  • replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):
(WebCore::EventLoopInputDispatcher::timerFired):

  • replay/EventLoopInputDispatcher.h:
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::closeDatabaseTimerFired):
(WebCore::StorageAreaImpl::closeDatabaseIfIdle):

  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::scheduleSync):

  • storage/StorageAreaSync.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::svgLoadEventTimerFired):

  • svg/SVGElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::SVGScriptElement):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::SVGStyleElement):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::timerFired):

  • svg/animation/SMILTimeContainer.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

  • xml/XMLHttpRequestProgressEventThrottle.h:

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
(WebKit::NetscapePluginInstanceProxy::requestTimerFired):

  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverDataTimerFired):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(FullscreenVideoController::timerFired):

  • FullscreenVideoController.h:

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::bufferingTimerFired):

  • NetworkProcess/NetworkResourceLoader.h:
  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):

  • Shared/WebMemorySampler.h:
  • Shared/mac/RemoteLayerBackingStoreCollection.h:
  • Shared/mac/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::RemoteLayerBackingStoreCollection):
(WebKit::RemoteLayerBackingStoreCollection::volatilityTimerFired):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::processSuspensionCleanupTimerFired):
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):

  • WebProcess/WebProcess.h:

Source/WTF:

  • wtf/RunLoopTimer.h:

(WTF::RunLoopTimer::RunLoopTimer):
(WTF::RunLoopTimer::fired):

11:48 AM Changeset in webkit [176458] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash when setting 'transition-delay' CSS property to a calculated value
​https://bugs.webkit.org/show_bug.cgi?id=138784

Reviewed by Sam Weinig.

Source/WebCore:

Update CSSPrimitiveValue::computeTime() to use primitiveType() instead
of m_primitiveUnitType so that it properly handles calculated values.
Without this, we would hit the ASSERT_NOT_REACHED() assertion in
computeTime() for calculated values.

Test: fast/css/transition-delay-calculated-value.html

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::computeTime):

LayoutTests:

Add a layout test to check that setting the 'transition-delay' CSS
property to a calculated value does not crash and works as intended.

  • fast/css/transition-delay-calculated-value-expected.txt: Added.
  • fast/css/transition-delay-calculated-value.html: Added.
11:46 AM Changeset in webkit [176457] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Fix iOS build.

  • Shared/ios/QuickLookDocumentData.cpp:

(WebKit::QuickLookDocumentData::encode):

11:32 AM Changeset in webkit [176456] by roger_fong@apple.com
  • 5 edits
    1 add in trunk/LayoutTests

Two WebGL tests try to use an external resource.
​https://bugs.webkit.org/show_bug.cgi?id=138936.
Reviewed by Alexey Proskuryakov.

  • http/tests/resources/square128.png: Added.
  • http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html:
  • http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html:
  • http/tests/webgl/1.0.2/texImage2DHTML-expected.txt:
  • http/tests/webgl/1.0.2/texSubImage2DHTML-expected.txt:
11:01 AM Changeset in webkit [176455] by Chris Dumez
  • 3 edits
    3 adds in trunk

Regression(r175381): -webkit-mask-box-image is broken
​https://bugs.webkit.org/show_bug.cgi?id=138969
<rdar://problem/19054471>

Reviewed by Simon Fraser.

Source/WebCore:

After r175381, the StyleBuilder would call NinePieceImage::setMaskDefaults()
*after* calling CSSToStyleMap::mapNinePieceImage(), instead of *before*, for
-webkit-mask-box-image CSS property. This was causing the mask defaults to
overwrite what was set by mapNinePieceImage().

Test: fast/css/webkit-mask-box-image.html

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertBorderMask):

LayoutTests:

Add a layout test to add basic coverage for -webkit-mask-box-image
CSS property.

  • fast/css/resources/mask.png: Added.
  • fast/css/webkit-mask-box-image.html: Added.
  • fast/css/webkit-mask-box-image-expected.html: Added
11:00 AM Changeset in webkit [176454] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash when setting 'font' CSS property to 'calc(2 * 3)'
​https://bugs.webkit.org/show_bug.cgi?id=138933

Reviewed by Darin Adler.

Source/WebCore:

The CSS Parser was not handling calculated values when parsing the font
weight. This would lead us to hit an assertion when parsing a font
property whose weight is set to a calculated value.

This patch updates parseFontWeight() to properly handle calculated
values.

Test: fast/css/font-calculated-value.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontWeight):

LayoutTests:

Add a layout test to cover the case where the 'font' CSS property is
set to a value whose weight is a calculated value, to make sure it
does not crash and behaves as intended.

  • fast/css/font-calculated-value-expected.txt: Added.
  • fast/css/font-calculated-value.html: Added.
10:43 AM Changeset in webkit [176453] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[CSS Font Loading] Switch to dispatching events asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=138755

Patch by Bear Travis <​betravis@gmail.com> on 2014-11-21
Reviewed by Simon Fraser.

Source/WebCore:

Moving FontLoader to dispatch events and notify callbacks similarly
to EventSender or the GenericEventQueue. Several bugs have popped
up in the past because FontLoader has been sending events during
layout, and there is no need for that to be the case.

Covered by existing font loader event tests. Added an additional
test for the svg case, fontloader-svg-select.

  • css/FontLoader.cpp:

(WebCore::FontLoader::didLayout):
(WebCore::FontLoader::timerFired): Adding asynchronous callback.
(WebCore::FontLoader::scheduleEvent): Add an event to the dispatch
queue.
(WebCore::FontLoader::firePendingEvents): Modified to handle the
loading done event and callbacks.
(WebCore::FontLoader::loadingDone): Modified to spin up the timer
rather than immediately dispatching events.

  • css/FontLoader.h:

LayoutTests:

Refactoring tests to check for all events only after the FontLoader
itself has completed. Tests were previously checking after a specific font
had loaded, at which point some of the events may have yet to fire.

  • fast/css/fontloader-multiple-faces-download-error-expected.txt:
  • fast/css/fontloader-multiple-faces-download-error.html:
  • fast/css/fontloader-multiple-faces-expected.txt:
  • fast/css/fontloader-multiple-faces.html:
  • fast/css/fontloader-multiple-families-expected.txt:
  • fast/css/fontloader-multiple-families.html:
  • fast/css/fontloader-svg-select-expected.txt: Added
  • fast/css/fontloader-svg-select.svg: Added
9:40 AM Changeset in webkit [176452] by Antti Koivisto
  • 11 edits in trunk/Source/WebKit2

Remove alignment code from IPC coders
​https://bugs.webkit.org/show_bug.cgi?id=138963

Reviewed by Anders Carlsson.

Alignment code achieves nothing except making the messages somewhat bigger.

  • Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<CString>::encode):
(IPC::ArgumentCoder<CString>::decode):
(IPC::ArgumentCoder<String>::encode):
(IPC::decodeStringText):

  • Platform/IPC/ArgumentCoders.h:

(IPC::SimpleArgumentCoder::encode):
(IPC::SimpleArgumentCoder::decode):

  • Platform/IPC/ArgumentDecoder.cpp:

(IPC::ArgumentDecoder::initialize):
(IPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
(IPC::ArgumentDecoder::decodeFixedLengthData):
(IPC::ArgumentDecoder::decodeVariableLengthByteArray):
(IPC::ArgumentDecoder::decodeNumber):
(IPC::ArgumentDecoder::decode):
(IPC::roundUpToAlignment): Deleted.
(IPC::alignedBufferIsLargeEnoughToContain): Deleted.
(IPC::ArgumentDecoder::alignBufferPosition): Deleted.
(IPC::decodeValueFromBuffer): Deleted.

  • Platform/IPC/ArgumentDecoder.h:

(IPC::ArgumentDecoder::isInvalid):
(IPC::ArgumentDecoder::markInvalid):
(IPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • Platform/IPC/ArgumentEncoder.cpp:

(IPC::ArgumentEncoder::ArgumentEncoder):
(IPC::ArgumentEncoder::grow):
(IPC::ArgumentEncoder::encodeFixedLengthData):
(IPC::ArgumentEncoder::encodeVariableLengthByteArray):
(IPC::ArgumentEncoder::encode):

  • Platform/IPC/ArgumentEncoder.h:

(IPC::ArgumentEncoder::buffer):
(IPC::ArgumentEncoder::mutableBuffer):

  • Platform/IPC/DataReference.cpp:

(IPC::SharedBufferDataReference::encode):

  • Platform/IPC/MessageEncoder.cpp:

(IPC::MessageEncoder::setIsSyncMessage):
(IPC::MessageEncoder::setShouldDispatchMessageWhenWaitingForSyncReply):

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendOutgoingMessage):

9:05 AM Changeset in webkit [176451] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the internal Apple Mavericks build after <​https://trac.webkit.org/changeset/176448>
(​https://bugs.webkit.org/show_bug.cgi?id=138930)

Declare NSCachedURLResponse SPI when building without the Apple Internal SDK and with the Apple
Internal SDK when building for OS X Mavericks or earlier.

  • platform/spi/cf/CFNetworkSPI.h:
9:04 AM Changeset in webkit [176450] by andersca@apple.com
  • 28 edits in trunk/Source

Make memoryCache() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=138939

Reviewed by Antti Koivisto.

Source/WebCore:

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

  • loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::finishLoading):

  • loader/cache/CachedResource.cpp:

(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):

  • loader/cache/MemoryCache.h:
  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::resourceBecameFileBacked):

  • page/FrameView.cpp:

(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):

Source/WebKit/mac:

  • Misc/WebCache.mm:

(+[WebCache statistics]):
(+[WebCache emptyInMemoryResources]):
(+[WebCache sizeOfDeadResources:]):
(+[WebCache addImageToCache:forURL:forFrame:]):
(+[WebCache removeImageFromCacheForURL:forFrame:]):
(+[WebCache imageForURL:]):
(+[WebCache setDisabled:]):
(+[WebCache isDisabled]):

  • WebView/WebView.mm:

(+[WebView _setCacheModel:]):

Source/WebKit/win:

  • WebCache.cpp:

(WebCache::statistics):
(WebCache::empty):
(WebCache::setDisabled):
(WebCache::disabled):

  • WebView.cpp:

(WebView::setCacheModel):

Source/WebKit2:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didCacheResource):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::clearResourceCaches):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setMemoryCacheDisabled):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformSetCacheModel):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):

8:44 AM Changeset in webkit [176449] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Remove http lock code from webkitperl
​https://bugs.webkit.org/show_bug.cgi?id=138959

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitperl/httpd.pm:

(cleanUp):
(extractLockNumber): Deleted.
(getLockFiles): Deleted.
(getNextAvailableLockNumber): Deleted.
(getLockNumberForCurrentRunning): Deleted.
(waitForHTTPDLock): Deleted.
(scheduleHttpTesting): Deleted.
(getWaitTime): Deleted.

8:40 AM Changeset in webkit [176448] by dbates@webkit.org
  • 16 edits
    1 move in trunk/Source

[iOS] WebKit2 fails to build with public SDK due to missing SPI from CFNetwork, QuartzCore, MediaPlayer, XPC
​https://bugs.webkit.org/show_bug.cgi?id=138930

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Rename header MPAVRoutingControllerSPI.h to MediaPlayerSPI.h.
  • loader/cocoa/SubresourceLoaderCocoa.mm: Move NSCachedURLResponse forward declarations to file

CFNetworkSPI.h and include header CFNetworkSPI.h.

  • loader/mac/ResourceLoaderMac.mm: Ditto.
  • platform/audio/ios/MediaSessionManagerIOS.mm: Substitute MediaPlayerSPI.h for MPAVRoutingControllerSPI.h.
  • platform/spi/cf/CFNetworkSPI.h: Add more SPI.
  • platform/spi/cg/CoreGraphicsSPI.h: Ditto.
  • platform/spi/cocoa/QuartzCoreSPI.h: Ditto.
  • platform/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MPAVRoutingControllerSPI.h.

Source/WebKit2:

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm: Remove forward declaration for NSCachedURLResponse

methods as this functionality was incorporated into CFNetworkSPI.h, which is included by this file.

  • Platform/mac/LayerHostingContext.mm: Moved QuartzCore forward declarations from this file to file

QuartzCoreSPI.h and included header QuartzCoreSPI.h.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h: Include header XPCSPI.h.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm: Remove forward declarations of

XPC SPI since these declarations are part of XCPSPI.h, which is included by header XPCServiceEntryPoint.h.

  • UIProcess/API/Cocoa/WKWebView.mm: Remove unnecessary include of header QuartzCore/CARenderServer.h

as it will be included by header QuartzCoreSPI.h.

  • UIProcess/Network/NetworkProcessProxy.cpp: Include header XPCSPI.h when building for iOS with

USE(XPC_SERVICES) enabled.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm: Include header MediaPlayerSPI.h instead of including

MediaPlayer private headers directly. Also sort the list of #import directives.

7:55 AM Changeset in webkit [176447] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: MathML expressions are misread by VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=138948

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The logic for deciding what's the radicand and an index was too tied to children placement.
We should instead pull directly from the source.

Test: platform/mac/accessibility/mathml-root.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):

  • rendering/mathml/RenderMathMLRoot.h:

LayoutTests:

  • platform/mac/accessibility/mathml-root-expected.txt: Added.
  • platform/mac/accessibility/mathml-root.html: Added.
7:26 AM Changeset in webkit [176446] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Disable verifyHeap
​https://bugs.webkit.org/show_bug.cgi?id=138962

Reviewed by Mark Lam.

  • runtime/Options.h:
Note: See TracTimeline for information about the timeline view.