Context Navigation

← Previous Period
Next Period →

Timeline

Mar 21, 2015:

9:55 PM Changeset in webkit [181832] by dino@apple.com

37 edits
1 copy
4 adds in trunk

Remove the prefix for CSS Transforms
https://bugs.webkit.org/show_bug.cgi?id=142927
<rdar://problem/11568151>

Reviewed by Simon Fraser.

Source/WebCore:

Support the bare form of:

transform
transform-style
transform-origin
perspective
perspective-origin

For transform-style, we also still differentiate the prefixed property
because we may want to use that as an indicator of legacy content.

This is mostly a find and replace, but with some related naming
changes. The DOM interface for WebKitCSSTransformValue remains
unchanged.

Tests: transforms/2d/transform-2d-prefixed.html

transforms/3d/general/prefixed-3dtransform-values.html

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::propertyChangeMayRepaintNonDescendants):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):

css/CSSPropertyNames.in:
css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::computeExtentOfAnimation):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::computeExtentOfTransformAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::computeExtentOfTransformAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation):
(WebCore::KeyframeAnimation::validateTransformFunctionList):

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::validateTransformOperations):

platform/graphics/GraphicsLayerClient.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::isRunningTransformAnimation):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimation::applyInternal):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncAnimations):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHasActiveTransformAnimation):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
(WebCore::CoordinatedGraphicsLayer::addAnimation):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation):

svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):

Source/WebKit2:

Rename AnimatedPropertyWebkitTransform to AnimatedPropertyTransform.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<TextureMapperAnimation>::encode):

LayoutTests:

Convert the helper functions for transforms to use the unprefixed
form, and copy some tests to make sure the prefixed form still works.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:
transforms/2d/computed-style-origin-expected.txt:
transforms/2d/computed-style-origin.html:
transforms/2d/resources/prefixed-transform-test-utils.js: Copied from LayoutTests/transforms/2d/resources/transform-test-utils.js.

(floatingPointEqual):
(compareMatrices):
(testTransforms):

transforms/2d/resources/transform-test-utils.js:

(testTransforms):

transforms/2d/transform-2d-prefixed-expected.txt: Added.
transforms/2d/transform-2d-prefixed.html: Added.
transforms/3d/general/prefixed-3dtransform-values-expected.txt: Added.
transforms/3d/general/prefixed-3dtransform-values.html: Added.
transitions/transition-end-event-multiple-04-expected.txt:
transitions/transition-end-event-multiple-04.html:
transitions/transition-end-event-transform-expected.txt:
transitions/transition-end-event-transform.html:

9:08 PM Changeset in webkit [181831] by commit-queue@webkit.org

11 edits in trunk

Fix a typo in Parser error message
https://bugs.webkit.org/show_bug.cgi?id=142942

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-21
Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
Fix a common identifier typo.

LayoutTests:

js/class-syntax-declaration-expected.txt:
js/class-syntax-expression-expected.txt:
js/class-syntax-super-expected.txt:
js/script-tests/class-syntax-declaration.js:
js/script-tests/class-syntax-expression.js:
js/script-tests/class-syntax-super.js:

8:47 PM Changeset in webkit [181830] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Try to get debug bots green.

platform/win/TestExpectations:

8:14 PM Changeset in webkit [181829] by Joseph Pecoraro

7 edits in trunk

Computed Property names should allow only AssignmentExpressions not any Expression
https://bugs.webkit.org/show_bug.cgi?id=142902

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseProperty):
Limit computed expressions to just assignment expressions instead of
any expression (which allowed comma expressions).

LayoutTests:

js/basic-computed-property-name-expected.txt:
js/object-literal-computed-methods-expected.txt:
js/script-tests/basic-computed-property-name.js:

(runTest.runTest.runTest.runTest.runTest.runTest.runTest.runTestThrow):

js/script-tests/object-literal-computed-methods.js:

Test that comma expressions are not allowed in computed property/method names.

5:07 PM Changeset in webkit [181828] by akling@apple.com

3 edits in trunk/Source/JavaScriptCore

Make UnlinkedFunctionExecutable fit in a 128-byte cell.
<https://webkit.org/b/142939>

Reviewed by Mark Hahnenberg.

Re-arrange the members of UnlinkedFunctionExecutable so it can fit inside
a 128-byte heap cell instead of requiring a 256-byte one.

Threw in a static_assert to catch anyone pushing it over the limit again.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::functionMode):

12:34 PM Changeset in webkit [181827] by benjamin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Import the blink test fast/css/currentcolor-strict-mode.html
https://bugs.webkit.org/show_bug.cgi?id=142838

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-03-21
Reviewed by Darin Adler.

fast/css/currentcolor-strict-mode-expected.html: Added.
fast/css/currentcolor-strict-mode.html: Added.

8:48 AM Changeset in webkit [181826] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[EFL][GTK] Make WebKit2's generate-forwarding-headers.pl less verbose
https://bugs.webkit.org/show_bug.cgi?id=142908

Reviewed by Žan Doberšek.

Scripts/generate-forwarding-headers.pl:

(createForwardingHeadersForFramework):

12:37 AM Changeset in webkit [181825] by commit-queue@webkit.org

37 edits
5 deletes in trunk

Unreviewed, rolling out r181824.
https://bugs.webkit.org/show_bug.cgi?id=142935

Broke Windows build (Requested by ap on #webkit).

Reverted changeset:

"Remove the prefix for CSS Transforms"
https://bugs.webkit.org/show_bug.cgi?id=142927
http://trac.webkit.org/changeset/181824

Mar 20, 2015:

11:54 PM Changeset in webkit [181824] by dino@apple.com

37 edits
1 copy
4 adds in trunk

Remove the prefix for CSS Transforms
https://bugs.webkit.org/show_bug.cgi?id=142927
<rdar://problem/11568151>

Reviewed by Simon Fraser.

Source/WebCore:

Support the bare form of:

transform
transform-style
transform-origin
perspective
perspective-origin

For transform-style, we also still differentiate the prefixed property
because we may want to use that as an indicator of legacy content.

This is mostly a find and replace, but with some related naming
changes. The DOM interface for WebKitCSSTransformValue remains
unchanged.

Tests: transforms/2d/transform-2d-prefixed.html

transforms/3d/general/prefixed-3dtransform-values.html

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::propertyChangeMayRepaintNonDescendants):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

css/CSSPropertyNames.in:
css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::computeExtentOfAnimation):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::computeExtentOfTransformAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::computeExtentOfTransformAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation):
(WebCore::KeyframeAnimation::validateTransformFunctionList):

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::validateTransformOperations):

platform/graphics/GraphicsLayerClient.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimation::applyInternal):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncAnimations):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

rendering/RenderLayerBacking.cpp:

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation):

svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):

Source/WebKit2:

Rename AnimatedPropertyWebkitTransform to AnimatedPropertyTransform.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<TextureMapperAnimation>::encode):

LayoutTests:

Convert the helper functions for transforms to use the unprefixed
form, and copy some tests to make sure the prefixed form still works.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:
transforms/2d/computed-style-origin-expected.txt:
transforms/2d/computed-style-origin.html:
transforms/2d/resources/prefixed-transform-test-utils.js: Copied from LayoutTests/transforms/2d/resources/transform-test-utils.js.

(floatingPointEqual):
(compareMatrices):
(testTransforms):

transforms/2d/resources/transform-test-utils.js:

(testTransforms):

transforms/2d/transform-2d-prefixed-expected.txt: Added.
transforms/2d/transform-2d-prefixed.html: Added.
transforms/3d/general/prefixed-3dtransform-values-expected.txt: Added.
transforms/3d/general/prefixed-3dtransform-values.html: Added.
transitions/transition-end-event-multiple-04-expected.txt:
transitions/transition-end-event-multiple-04.html:
transitions/transition-end-event-transform-expected.txt:
transitions/transition-end-event-transform.html:

9:20 PM Changeset in webkit [181823] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Additional debug assertion documentation.

platform/win/TestExpectations:

8:09 PM Changeset in webkit [181822] by Brent Fulgham

4 edits in branches/safari-600.5-branch/LayoutTests

Test gardening. Results are as expected based on code changes
on this branch.

css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

7:02 PM Changeset in webkit [181821] by mhahnenb@gmail.com

3 edits
1 add in trunk

GCTimer should know keep track of nested GC phases
https://bugs.webkit.org/show_bug.cgi?id=142675

Reviewed by Darin Adler.

Source/JavaScriptCore:

This improves the GC phase timing output in Heap.cpp by linking
phases nested inside other phases together, allowing tools
to compute how much time we're spending in various nested phases.

heap/Heap.cpp:

Tools:

Adds a tool to aid in parsing the GC phase timing output into a
tree-like structure based on the parent-child relationships
of nested GC phases.

Scripts/parse-gc-phase-timings: Added.

(Timing):
(Timing.init):
(Timing.unicode):
(Timing.str):
(Timing.repr):
(parse_input):
(print_timing_node):
(print_timing_tree):
(link_parents):
(main):

5:07 PM Changeset in webkit [181820] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] More debug assertions. Almost there!

platform/win/TestExpectations:

4:38 PM Changeset in webkit [181819] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fast typing lags in the Styles sidebar or Console
https://bugs.webkit.org/show_bug.cgi?id=142919

Asynchronous autocomplete causes a race condition in CodeMirror,
which results in skipped characters in while typing. Completing immediately
fixes the issues.

Reviewed by Timothy Hatcher.

UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
(WebInspector.CodeMirrorCompletionController.prototype.):

4:37 PM Changeset in webkit [181818] by ggaren@apple.com

7 edits in trunk/Source/JavaScriptCore

FunctionBodyNode should known where its parameters started
https://bugs.webkit.org/show_bug.cgi?id=142926

Reviewed by Ryosuke Niwa.

This will allow us to re-parse parameters instead of keeping the
parameters piece of the AST around forever.

I also took the opportunity to initialize most FunctionBodyNode data
members at construction time, to help clarify that they are set right.

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionExpr): No need to pass
functionKeywordStart here; we now provide it at FunctionBodyNode
creation time.

(JSC::ASTBuilder::createFunctionBody): Require everything we need at
construction time, including the start of our parameters.

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement): No need to pass
functionKeywordStart here; we now provide it at FunctionBodyNode
creation time.

(JSC::ASTBuilder::setFunctionNameStart): Deleted.

parser/Nodes.cpp:

(JSC::FunctionBodyNode::FunctionBodyNode): Initialize everything at
construction time.

parser/Nodes.h: Added a field for the location of our parameters.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parsePrimaryExpression):

parser/Parser.h: Refactored to match above interface changes.

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty): Refactored to match
above interface changes.

(JSC::SyntaxChecker::setFunctionNameStart): Deleted.

4:26 PM Changeset in webkit [181817] by fpizlo@apple.com

5 edits
2 adds in trunk/Source/JavaScriptCore

Observably effectful nodes in DFG IR should come last in their bytecode instruction (i.e. forExit section), except for Hint nodes
https://bugs.webkit.org/show_bug.cgi?id=142920

Reviewed by Oliver Hunt, Geoffrey Garen, and Mark Lam.

Observably effectful, n.: If we reexecute the bytecode instruction after this node has
executed, then something other than the bytecode instruction's specified outcome will
happen.

We almost never had observably effectful nodes except at the end of the bytecode
instruction. The exception is a lowered transitioning PutById:

PutStructure(@o, S1 -> S2)
PutByOffset(@o, @o, @v)

The PutStructure is observably effectful: if you try to reexecute the bytecode after
doing the PutStructure, then we'll most likely crash. The generic PutById handling means
first checking what the old structure of the object is; but if we reexecute, the old
structure will seem to be the new structure. But the property ensured by the new
structure hasn't been stored yet, so any attempt to load it or scan it will crash.

Intriguingly, however, none of the other operations involved in the PutById are
observably effectful. Consider this example:

PutByOffset(@o, @o, @v)
PutStructure(@o, S1 -> S2)

Note that the PutStructure node doesn't reallocate property storage; see further below
for an example that does that. Because no property storage is happening, we know that we
already had room for the new property. This means that the PutByOffset is no observable
until the PutStructure executes and "reveals" the property. Hence, PutByOffset is not
observably effectful.

Now consider this:

b: AllocatePropertyStorage(@o)
PutByOffset(@b, @o, @v)
PutStructure(@o, S1 -> S2)

Surprisingly, this is also safe, because the AllocatePropertyStorage is not observably
effectful. It *does* reallocate the property storage and the new property storage pointer
is stored into the object. But until the PutStructure occurs, the world will just think
that the reallocation didn't happen, in the sense that we'll think that the property
storage is using less memory than what we just allocated. That's harmless.

The AllocatePropertyStorage is safe in other ways, too. Even if we GC'd after the
AllocatePropertyStorage but before the PutByOffset (or before the PutStructure),
everything could be expected to be fine, so long as all of @o, @v and @b are on the
stack. If they are all on the stack, then the GC will leave the property storage alone
(so the extra memory we just allocated would be safe). The GC will not scan the part of
the property storage that contains @v, but that's fine, so long as @v is on the stack.

The better long-term solution is probably bug 142921.

But for now, this:

Fixes an object materialization bug, exemplified by the two tests, that previously crashed 100% of the time with FTL enabled and concurrent JIT disabled.

Allows us to remove the workaround introduced in r174856.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handlePutById):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::insertCheck):
(JSC::DFG::FixupPhase::indexOfNode): Deleted.
(JSC::DFG::FixupPhase::indexOfFirstNodeOfExitOrigin): Deleted.

dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::insertOutOfOrder): Deleted.
(JSC::DFG::InsertionSet::insertOutOfOrderNode): Deleted.

tests/stress/materialize-past-butterfly-allocation.js: Added.

(bar):
(foo0):
(foo1):
(foo2):
(foo3):
(foo4):

tests/stress/materialize-past-put-structure.js: Added.

(foo):

4:09 PM Changeset in webkit [181816] by Chris Dumez

3 edits in trunk/Source/WebKit2

[WK2] NetworkCache retrievals sometimes fail on browser startup
https://bugs.webkit.org/show_bug.cgi?id=142925
<rdar://problem/20245368>

Reviewed by Antti Koivisto.

NetworkCache retrievals sometimes fail on browser startup for resources
that are actually cached. The reason is that we are using a bloom filter
for performance reasons to avoid unnecessary disk I/O and this bloom
filter is populated on start up in a background thread by traversing the
cache files on disk. However, when restoring the tabs on start-up we
sometimes query this bloom filter before it is completely populated and
we thus fail to retrieve cached entries because we think they don't
exist and don't check the disk.

This patch adds an "isPopulatingContentsFilter" flag that is turned ON
on start up while we are populating the bloon filter. We then bypass
the bloom filter and send queries directly to disk on start up if this
flag is ON.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::initialize):
(WebKit::NetworkCache::Storage::retrieve):
(WebKit::NetworkCache::Storage::dispatchPendingWriteOperations):
(WebKit::NetworkCache::Storage::dispatchHeaderWriteOperation):

NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::cacheMayContain):

3:45 PM Changeset in webkit [181815] by Chris Dumez

6 edits in trunk/Source/WebKit2

[WK2] Allow stale content when restoring the browser's session state
https://bugs.webkit.org/show_bug.cgi?id=142916
<rdar://problem/20243493>

Reviewed by Darin Adler.

Allow stale content when restoring the browser's session state
(restoring all tabs from previous session), e.g.

Via History > Reopen All windows from previous session on Safari
Happens on startup for MobileSafari

I have verified that using "Open in tabs" on a bookmarks folder
still does fresh loads (rdar://problem/8131355) as it is not using
the restoreFromSessionState() code path.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::restoreFromSessionState):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goToBackForwardItem):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

2:35 PM Changeset in webkit [181814] by Yusuke Suzuki

17 edits in trunk/Source

REGRESSION (r179429): Potential Use after free in JavaScriptCore`WTF::StringImpl::ref + 83
https://bugs.webkit.org/show_bug.cgi?id=142410

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Before this patch, added function JSValue::toPropertyKey returns PropertyName.
Since PropertyName doesn't have AtomicStringImpl ownership,
if Identifier is implicitly converted to PropertyName and Identifier is destructed,
PropertyName may refer freed AtomicStringImpl*.

This patch changes the result type of JSValue::toPropertyName from PropertyName to Identifier,
to keep AtomicStringImpl* ownership after the toPropertyName call is done.
And receive the result value as Identifier type to keep ownership in the caller side.

To catch the result of toPropertyKey as is, we catch the result of toPropertyName as auto.

However, now we don't need to have both Identifier and PropertyName.
So we'll merge PropertyName to Identifier in the subsequent patch.

dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

jit/JITOperations.cpp:

(JSC::getByVal):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::JSValue::toPropertyKey):

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorDefineProperty):

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncPropertyIsEnumerable):

Source/WebCore:

The same issues are found in the existing code; PropertyName does not have ownership.
This patch rewrite the point that should have ownership to Identifier.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::putByIndex):

bindings/js/ReadableStreamJSSource.cpp:

(WebCore::getInternalSlotFromObject):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::putByIndex):

2:32 PM Changeset in webkit [181813] by Simon Fraser

3 edits in trunk/Source/WebCore

Log the slow-scrolling reasons (if any) on first commit of a ScrollingTreeFrameScrollingNodeMac
https://bugs.webkit.org/show_bug.cgi?id=142917

Reviewed by Beth Dakin.

The scrollperf test would fail to detect transitions between slow and fast scrolling
for new pages, because there was no logging when slow-scrolling scrolling tree was
torn down, and a new fast-scrolling tree constructed.

Fix by always logging the slow-scrolling reasons in the first update of the
ScrollingTreeFrameScrollingNodeMac, even when the slow-scrolling reasons haven't
changed.

page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):

2:23 PM Changeset in webkit [181812] by Beth Dakin

2 edits in trunk/Source/WebKit2

[Immediate Actions] Should re-enable immediate actions for iBooks
https://bugs.webkit.org/show_bug.cgi?id=142915
-and corresponding-
rdar://problem/19585689

Reviewed by Tim Horton.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processPool:configuration:webView:]):

2:16 PM Changeset in webkit [181811] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Attempting to get EWS green.

platform/win/TestExpectations:

1:12 PM Changeset in webkit [181810] by ggaren@apple.com

45 edits
3 deletes in trunk

Function.prototype.toString should not decompile the AST
https://bugs.webkit.org/show_bug.cgi?id=142853

Reviewed by Sam Weinig.

Source/JavaScriptCore:

To recover the function parameter string, Function.prototype.toString
decompiles the function parameters from the AST. This is bad for a few
reasons:

(1) It requires us to keep pieces of the AST live forever. This is an
awkward design and a waste of memory.

(2) It doesn't match Firefox or Chrome (because it changes whitespace
and ES6 destructuring expressions).

(3) It doesn't scale to ES6 default argument parameters, which require
arbitrarily complex decompilation.

(4) It can counterfeit all the line numbers in a function (because
whitespace can include newlines).

(5) It's expensive, and we've seen cases where websites invoke
Function.prototype.toString a lot by accident.

The fix is to do what we do for the rest of the function: Just quote the
original source text.

Since this change inevitably changes some function stringification, I
took the opportunity to make our stringification match Firefox's and
Chrome's.

API/tests/testapi.c:

(assertEqualsAsUTF8String): Be more informative when this fails.

(main): Updated to match new stringification rules.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString): Deleted. Yay!

bytecode/UnlinkedCodeBlock.h:

parser/Nodes.h:

(JSC::StatementNode::isFuncDeclNode): New helper for constructing
anonymous functions.

parser/SourceCode.h:

(JSC::SourceCode::SourceCode): Allow zero because WebCore wants it.

runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Updated for use
of function declaration over function expression.

runtime/Executable.cpp:

(JSC::FunctionExecutable::paramString): Deleted. Yay!

runtime/Executable.h:

(JSC::FunctionExecutable::parameterCount):

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck): Added a newline after
the opening brace to match Firefox and Chrome, and a space after the comma
to match Firefox and WebKit coding style. Added the function name to
the text of the function so it would look right when stringify-ing. Switched
from parentheses to braces to produce a function declaration instead of
a function expression because we are required to exclude the function's
name from its scope, and that's what a function declaration does.

runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString): Removed an old workaround because the
library it worked around doesn't really exist anymore, and the behavior
doesn't match Firefox or Chrome. Use type profiling offsets instead of
function body offsets because we want to include the function name and
the parameter string, rather than stitching them in manually by
decompiling the AST.

(JSC::insertSemicolonIfNeeded): Deleted.

tests/mozilla/js1_2/function/tostring-1.js:
tests/mozilla/js1_5/Scope/regress-185485.js:

(with.g): Updated these test results for formatting changes.

Source/WebCore:

bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction): Adjust the line
number of attribute event listeners to account for the leading newline
now added by JavaScriptCore.

This solution is not perfect, but there are a lot of pre-existing problems
with line and column reporting for attribute event listeners, and this
preserves existing behavior with reasonable reliability.

LayoutTests:

Updated test results to match new rules for Function.prototype.toString.

fast/dom/TreeWalker/acceptNode-filter-expected.txt: Removed a space

because it was not in the original source.

fast/events/window-onerror2-expected.txt: Column number changed because

the event listener body starts on its own line now. This was a bit wrong
before and is still a bit wrong now in a different way.

fast/profiler/dead-time-expected.txt:
fast/profiler/inline-event-handler-expected.txt:
fast/profiler/stop-profiling-after-setTimeout-expected.txt: Line number

changed because WebCore shifts line nubmers on attribute event listeners
by one.

js/class-syntax-default-constructor-expected.txt: Constructor name

is not present now because it is not present in the source text. This
test failed before and it still fails now in a slightly different way.

js/destructuring-assignment-expected.txt: Destructuring arguments now

match their source text faithfully.

js/dfg-redundant-load-of-captured-variable-proven-constant-expected.txt:

Removed a space because it was not present in the original source text.

js/dfg-resolve-global-specific-dictionary-expected.txt: Ditto.

js/function-toString-semicolon-insertion-expected.txt: Removed.
js/script-tests/function-toString-semicolon-insertion.js: Removed.
js/function-toString-semicolon-insertion.html: Removed. This test checked

for a work-around that I have removed.

js/object-literal-computed-methods-expected.txt:
js/object-literal-methods-expected.txt: These tests fail because object

literal methods do not register their function names appropriately. This
was a pre-existing failure that is now more explicit.

js/dom/JSON-parse-expected.txt:
js/dom/JSON-stringify-expected.txt: Whitespace removed because it was

not present in the original.

js/dom/dfg-strcat-over-objects-then-exit-on-it-expected.txt: Ditto.

js/dom/function-prototype-expected.txt:
js/dom/function-prototype.html: Ditto.

js/dom/parse-error-external-script-in-new-Function-expected.txt: Line

changed by one due to new extra newline.

js/dom/script-start-end-locations-expected.txt: Lines and columns

changed due to new extra newline.

js/dom/toString-and-valueOf-override-expected.txt: Whitespace removed

because it was not present in the original.

js/dom/script-tests/dfg-strcat-over-objects-then-exit-on-it.js: Ditto.

js/kde/lval-exceptions-expected.txt: Ditto.

js/script-tests/dfg-redundant-load-of-captured-variable-proven-constant.js: Ditto.

js/script-tests/dfg-resolve-global-specific-dictionary.js: Ditto.

platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt: Ditto.

storage/domstorage/localstorage/string-conversion-expected.txt: Ditto.

storage/domstorage/sessionstorage/string-conversion-expected.txt: Ditto.

userscripts/window-onerror-for-isolated-world-1-expected.txt:
userscripts/window-onerror-for-isolated-world-2-expected.txt: Line numbers

changed because of new anonymous function formatting. These line numbers
were wrong before and they are still wrong now.

12:14 PM Changeset in webkit [181809] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Add some skips to support EWS use.

platform/win/TestExpectations:

11:18 AM Changeset in webkit [181808] by achristensen@apple.com

9 edits
1 add in trunk/Source

Progress towards CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=136003

Reviewed by Chris Dumez.

Source/WebCore:

PlatformMac.cmake:

Added some directories to create forwarding headers from.
Generate ObjC bindings.

Source/WebKit:

CMakeLists.txt:
PlatformMac.cmake: Added.

Source/WebKit2:

PlatformMac.cmake:

Add include directories and forwarding headers.

Shared/API/APIObject.h:

(API::ObjectImpl::operator new):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange):

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

Fix some unused parameter warnings.

11:10 AM Changeset in webkit [181807] by commit-queue@webkit.org

5 edits in trunk

SyntaxChecker assertion is trapped with computed property name and getter
https://bugs.webkit.org/show_bug.cgi?id=142863

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-20
Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::getName):
Remove invalid assert. Computed properties will not have a name
and the calling code is checking for null expecting it. The
AST path (non-CheckingPath) already does this without the assert
so it is well tested.

LayoutTests:

js/basic-computed-property-name-expected.txt:
js/script-tests/basic-computed-property-name.js:

(a.string_appeared_here.runTest):
Add tests that wrap the expression in a function, this
will test the syntax checker.

11:08 AM Changeset in webkit [181806] by mark.lam@apple.com

9 edits
2 adds in trunk/Source/JavaScriptCore

JSCallbackObject<JSGlobalObject> should not destroy its JSCallbackObjectData before all its finalizers have been called.
<https://webkit.org/b/142846>

Reviewed by Geoffrey Garen.

Currently, JSCallbackObject<JSGlobalObject> registers weak finalizers via 2 mechanisms:

JSCallbackObject<Parent>::init() registers a weak finalizer for all JSClassRef that a JSCallbackObject references.
JSCallbackObject<JSGlobalObject>::create() registers a finalizer via vm.heap.addFinalizer() which destroys the JSCallbackObject.

The first finalizer is implemented as a virtual function of a JSCallbackObjectData
instance that will be destructed if the 2nd finalizer is called. Hence, if the
2nd finalizer if called first, the later invocation of the 1st finalizer will
result in a crash.

This patch fixes the issue by eliminating the finalizer registration in init().
Instead, we'll have the JSCallbackObject destructor call all the JSClassRef finalizers
if needed. This ensures that these finalizers are called before the JSCallbackObject
is destructor.

Also added assertions to a few Heap functions because JSCell::classInfo() expects
all objects that are allocated from MarkedBlock::Normal blocks to be derived from
JSDestructibleObject. These assertions will help us catch violations of this
expectation earlier.

API/JSCallbackObject.cpp:

(JSC::JSCallbackObjectData::finalize): Deleted.

API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::~JSCallbackObjectData):

API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::~JSCallbackObject):
(JSC::JSCallbackObject<Parent>::init):

API/tests/GlobalContextWithFinalizerTest.cpp: Added.

(finalize):
(testGlobalContextWithFinalizer):

API/tests/GlobalContextWithFinalizerTest.h: Added.
API/tests/testapi.c:

(main):

JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
JavaScriptCore.vcxproj/testapi/testapi.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/HeapInlines.h:

(JSC::Heap::allocateObjectOfType):
(JSC::Heap::subspaceForObjectOfType):
(JSC::Heap::allocatorForObjectOfType):

10:53 AM Changeset in webkit [181805] by peavo@outlook.com

3 edits in trunk/Source/WebCore

[WinCairo] Crash when leaving page while video is playing.
https://bugs.webkit.org/show_bug.cgi?id=142578

Reviewed by Alex Christensen.

This can happen when there is an asynchronous event invoked from a video worker
thread, accessing the media player object after it has been deleted.
This is solved by resetting the media player pointer in the event object,
when the media player is deleted.

platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::addListener):
(WebCore::MediaPlayerPrivateMediaFoundation::removeListener):
(WebCore::MediaPlayerPrivateMediaFoundation::notifyDeleted):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::AsyncCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::~AsyncCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Invoke):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::onMediaPlayerDeleted):

platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerListener::MediaPlayerListener):
(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerListener::~MediaPlayerListener):
(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerListener::onMediaPlayerDeleted):

10:18 AM Changeset in webkit [181804] by Chris Dumez

2 edits in trunk/Source/WebCore

Regression(r181782): Caused WebKit2.RestoreSessionStateContainingFormData API test to crash
https://bugs.webkit.org/show_bug.cgi?id=142911

Reviewed by Antti Koivisto.

Drop the isBackForwardLoadType(m_loadType) assertion in
FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad(). This assertion
used to hold true when goToBackForwardItem() was only called with
history navigation load types. However, after r181782, we use a Standard
load in the cases where we do not wish to display stale content (e.g.
restoring session state).

The assertion comment says "We only use cache-only loads to avoid
resubmitting forms". However, we then call loadDifferentDocumentItem()
which already takes care of using the ReturnCacheDataElseLoad cache
policy as the HistoryItem has form data and we pass
MayNotAttemptCacheOnlyLoadForFormSubmissionItem as parameter.

No new tests, covered by WebKit2.RestoreSessionStateContainingFormData
API test.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):

10:07 AM Changeset in webkit [181803] by ap@apple.com

3 edits in trunk/LayoutTests

platform/mac/fast/loader/file-url-mimetypes-3.html fails when MS Office is installed
https://bugs.webkit.org/show_bug.cgi?id=142884

Reviewed by Tim Horton.

Disable a test for .xls until rdar://problem/20232251 is fixed. It is not particularly
relevant to a web browser which MIME type local Excel files get anyway.

platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
platform/mac/fast/loader/file-url-mimetypes-3.html:

9:47 AM Changeset in webkit [181802] by ap@apple.com

1 edit
1 add
9 deletes in trunk/LayoutTests

[Mac] svg/text/non-bmp-positioning-lists.svg fails when MS Office is installed
https://bugs.webkit.org/show_bug.cgi?id=142861

Reviewed by Tim Horton.

Converted into a reftest. It would be nice to make tests not depend on installed
fonts in general, but that doesn't seem very feasible (rdar://problem/20000350).

platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Removed.
platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
platform/gtk/svg/text/non-bmp-positioning-lists-expected.png: Removed.
platform/gtk/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
platform/ios-sim-deprecated/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
platform/ios-simulator/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
platform/mac/svg/text/non-bmp-positioning-lists-expected.png: Removed.
platform/mac/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
platform/win/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
svg/text/non-bmp-positioning-lists-expected.svg: Added.

8:57 AM Changeset in webkit [181801] by Brent Fulgham

2 edits in trunk/Tools

[Win] Temporarily turn of EWS Windows tests while I debug the test failure.

Scripts/webkitpy/common/config/ews.json:

4:26 AM Changeset in webkit [181800] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebKit2

[CMake] Remove duplicated cmake function calls in WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=142901

Reviewed by Csaba Osztrogonác.

add_depencencies(), install() can support multiple targets or location.
We don't need to call it twice.

CMakeLists.txt: Additionaly move -DBUILDING_WEBKIT to PlatformGTK.cmake,

because it is only used by GTK port.

4:06 AM Changeset in webkit [181799] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181798 - [GTK] Disable accelerated compositing on Wayland
https://bugs.webkit.org/show_bug.cgi?id=142877

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage): As was done in the past, we should disable
accelerated compositing on Wayland until the proper support for it lands.

3:38 AM Changeset in webkit [181798] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK] Disable accelerated compositing on Wayland
https://bugs.webkit.org/show_bug.cgi?id=142877

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage): As was done in the past, we should disable
accelerated compositing on Wayland until the proper support for it lands.

3:09 AM Changeset in webkit [181797] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Update attachment-foo tests to failure.
https://bugs.webkit.org/show_bug.cgi?id=142653

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-03-20

platform/efl/TestExpectations:

2:40 AM Changeset in webkit [181796] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Remove duplicate or ambiguous entry lines.
https://bugs.webkit.org/show_bug.cgi?id=142775

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-03-20

platform/efl/TestExpectations:

2:36 AM Changeset in webkit [181795] by aestes@apple.com

3 edits in trunk/Source/WebCore

[Content Filtering] Adopt NEFilterSource unblock handling
https://bugs.webkit.org/show_bug.cgi?id=142904

Reviewed by Andreas Kling.

platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::unblockHandler):
Returned an unblock handler that calls -[NEFilterSource remediateWithDecisionHandler:].

platform/cocoa/ParentalControlsContentFilter.mm:

(WebCore::ParentalControlsContentFilter::unblockHandler): Used ASCIILiteral.

2:26 AM Changeset in webkit [181794] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8

Merge r181793 - [GTK] Search for the Wayland dependency when enabling Wayland target
https://bugs.webkit.org/show_bug.cgi?id=142876

Reviewed by Carlos Garcia Campos.

Source/cmake/OptionsGTK.cmake: The Wayland dependency isn't a public

requirement of either the GTK+ or GDK pkg-config files, so we have to
search for it ourselves when WebKitGTK+ has been configured to support
the Wayland windowing target.

2:23 AM Changeset in webkit [181793] by zandobersek@gmail.com

2 edits in trunk

[GTK] Search for the Wayland dependency when enabling Wayland target
https://bugs.webkit.org/show_bug.cgi?id=142876

Reviewed by Carlos Garcia Campos.

Source/cmake/OptionsGTK.cmake: The Wayland dependency isn't a public

requirement of either the GTK+ or GDK pkg-config files, so we have to
search for it ourselves when WebKitGTK+ has been configured to support
the Wayland windowing target.

2:00 AM Changeset in webkit [181792] by Philippe Normand

2 edits in trunk/Tools

[GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
https://bugs.webkit.org/show_bug.cgi?id=142867

Rubber-stamped by Csaba Osztrogon.

gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use

a fixed revision for the openwebrtc-gst-plugins.

1:42 AM Changeset in webkit [181791] by aestes@apple.com

30 edits
4 adds in trunk

[Content Filtering] Add tests for unblock requests
https://bugs.webkit.org/show_bug.cgi?id=142900

Reviewed by Andreas Kling.

Source/WebCore:

Currently the iOS Parental Controls content filter has a mechanism for requesting that a page be unblocked.
WebKit implements this by listening for navigations originating from the filter's error page to a special URL,
and requesting the page be unblocked via platform API, which might cause UI to be displayed. If the unblock is
successful then we schedule a reload of the frame in order to display the unblocked document.

NetworkExtension also supports unblock requests, so in preparation for adopting its API, this patch allows
content filters to specify their own unblock request method, teaches MockContentFilter to provide such a method,
and writes tests to cover both allowed and denied unblock requests.

The content filter that blocks a load creates a ContentFilterUnblockHandler, passing it a lambda that is executed
when a navigation matches the filter's special unblock URL. Filters can also specify that a script be executed in
the context of its error page if the unblock is denied.

All platform content filters can handle unblock requests like this with the exception of iOS Parental Controls in WebKit2.
Since UI can be displayed by the system in this case, the request must be made from within the UI process. Therefore the
existing method is retained of serializing a WebFilterEvaluator and intercepting navigation policy calls in the UI process.

Tests: contentfiltering/allow-after-unblock-request.html

contentfiltering/block-after-unblock-request.html

bindings/js/JSMockContentFilterSettingsCustom.cpp:

(WebCore::JSMockContentFilterSettings::decisionPoint): Added some using statements for clarity.
(WebCore::JSMockContentFilterSettings::setDecisionPoint): Ditto.
(WebCore::toJSValue): Returns a JSValue from a Decision.
(WebCore::toDecision): Returns a Decision from a JSValue.
(WebCore::JSMockContentFilterSettings::decision): Used toJSValue.
(WebCore::JSMockContentFilterSettings::setDecision): Used toDecision.
(WebCore::JSMockContentFilterSettings::unblockRequestDecision): Used toJSValue.
(WebCore::JSMockContentFilterSettings::setUnblockRequestDecision): Used toDecision.

loader/ContentFilter.cpp:

(WebCore::ContentFilter::createIfNeeded): Passed a reference to the owning DocumentLoader.
(WebCore::ContentFilter::ContentFilter): Ditto.
(WebCore::ContentFilter::unblockHandler): If the unblockHandler requests that a script be executed when an
unblock request is denied, create a wrapper unblockHandler that executes that script in m_documentLoader's frame.

loader/ContentFilter.h:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived): Passed this to ContentFilter::createIfNeeded.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart): Called PolicyChecker::prepareForLoadStart.

loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::prepareForLoadStart): Reset m_contentFilterUnblockHandler.
(WebCore::PolicyChecker::checkNavigationPolicy): Moved logic to here from WebKit1's WebFrameLoaderClient.
Placing it here allows it to be shared between WebKit1 and WebKit2 (when the unblock handler does not need to
be called in the UI process).

loader/PolicyChecker.h:

(WebCore::PolicyChecker::setContentFilterUnblockHandler): Added.

page/Frame.h: Made Frame ThreadSafeRefCounted, since RefPtr<Frames> are captured in lambdas that can be

copied by background threads managed by the underlying platform.

platform/ContentFilterUnblockHandler.h:

(WebCore::ContentFilterUnblockHandler::unblockURLScheme): Returned the Apple content filter scheme.
(WebCore::ContentFilterUnblockHandler::unblockURLHost): Returned the unblock URL host.
(WebCore::ContentFilterUnblockHandler::clear): Deleted.

platform/PlatformContentFilter.h:

(WebCore::PlatformContentFilter::unblockRequestDeniedScript): Returned the unblock request denied script.

platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:

(WebCore::ContentFilterUnblockHandler::ContentFilterUnblockHandler): Added a constructor that takes an
unblockURLHost and a UnblockRequesterFunction. Added an alternate constructor for iOS Parental Controls on
WebKit2 that takes an unblockURLHost and a WebFilterEvaluator.
(WebCore::ContentFilterUnblockHandler::needsUIProcess): Returned true if m_webFilterEvaluator is non-null.
(WebCore::ContentFilterUnblockHandler::encode): Encoded m_unblockURLHost in addition to m_webFilterEvaluator.
(WebCore::ContentFilterUnblockHandler::decode): Decoded m_unblockURLHost in addition to m_webFilterEvaluator.
(WebCore::ContentFilterUnblockHandler::canHandleRequest): Returned true if there is a either a m_unblockRequester
or a m_webFilterEvaluator and the request's host and scheme match those of the unblock request URL.
(WebCore::dispatchToMainThread): Added a helper to dispatch a block to the main thread. Then if the web thread
is enabled on iOS, dispatch it there.
(WebCore::ContentFilterUnblockHandler::requestUnblockAsync): Renamed from handleUnblockRequestAndDispatchIfSuccessful.
Requested an unblock using either m_unblockRequester or m_webFilterEvaluator, then called decisionHandler with the response.
(WebCore::scheme): Moved to ContentFilterUnblockHandler::unblockURLScheme.
(WebCore::ContentFilterUnblockHandler::handleUnblockRequestAndDispatchIfSuccessful): Renamed to requestUnblockAsync.

platform/cocoa/ParentalControlsContentFilter.mm:

(WebCore::ParentalControlsContentFilter::unblockHandler): Returned an unblock handler using the WebFilterEvaluator constructor.

testing/MockContentFilter.cpp: Added using statments for clarity.

(WebCore::settings): Added a helper to get MockContentFilterSettings::singleton().
(WebCore::MockContentFilter::canHandleResponse): Used the helper.
(WebCore::MockContentFilter::MockContentFilter): Took advantage of the using statements.
(WebCore::MockContentFilter::addData): Ditto.
(WebCore::MockContentFilter::finishedAddingData): Ditto.
(WebCore::MockContentFilter::unblockHandler): Returned a ContentFilterUnblockHandler that checks settings() for its decision.
(WebCore::MockContentFilter::unblockRequestDeniedScript): Returned the script to execute in MockContentFilter's
error page when an unblock request is denied.
(WebCore::MockContentFilter::maybeDetermineStatus): Took advantage of settings() and using statements.

testing/MockContentFilterSettings.cpp:

(WebCore::MockContentFilterSettings::unblockRequestURL): Constructed a static unblock URL and returned it.

testing/MockContentFilterSettings.h:

(WebCore::MockContentFilterSettings::unblockURLHost): Returned the filter's unblock URL host.
(WebCore::MockContentFilterSettings::unblockRequestDecision): Returns the decision to make for an unblock request.
(WebCore::MockContentFilterSettings::setUnblockRequestDecision): Sets the decision to make for an unblock request.

testing/MockContentFilterSettings.idl: Added the unblockRequestDecision and unblockRequestURL attributes.

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.

WebView/WebFrame.mm:

(-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.

WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.

Source/WebKit2:

UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::contentFilterDidBlockLoadForFrame): Called WebFrameProxy::contentFilterDidBlockLoad.

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad): Assigned a default-constructed ContentFilterUnblockHandler instead of calling clear().
(WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation): Renamed from contentFilterDidHandleNavigationAction.
Updated to use ContentFilterUnblockHandler's new API.
(WebKit::WebFrameProxy::contentFilterDidHandleNavigationAction): Deleted.

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::contentFilterDidBlockLoad): Renamed from setContentFilterUnblockHandler.
(WebKit::WebFrameProxy::setContentFilterUnblockHandler): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction): Called WebFrameProxy::didHandleContentFilterUnblockNavigation.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::contentFilterDidBlockLoad): If the unblock handler needs the UI process,
send WebPageProxy::ContentFilterDidBlockLoadForFrame. Oterwise, call PolicyChecker::setContentFilterUnblockHandler.

LayoutTests:

Taught contentfiltering.js how to perform an unblock request test, and added tests for both allowed and blocked requests.

contentfiltering/allow-after-unblock-request-expected.html: Added.
contentfiltering/allow-after-unblock-request.html: Added.
contentfiltering/block-after-unblock-request-expected.html: Added.
contentfiltering/block-after-unblock-request.html: Added.
contentfiltering/resources/contentfiltering.js:

(testContentFiltering): Added an argument specifying if the decision applies to the initial load or the unblock request.
(_doTest): When testing unblock handling, navigate the test iframe to settings.unblockRequestURL when the error page is displayed.
If the unblock is denied, the test harness will call window.unblockRequestDenied(). If the unblock is successful,
the iframe will reload, which we detect by listening for its load event.

1:35 AM Changeset in webkit [181790] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181789 - [GTK] Properly guard X11-specific code in BackingStore::createBackend()
https://bugs.webkit.org/show_bug.cgi?id=142875

Reviewed by Martin Robinson.

UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend): Guard the GTK- and X11-specific
bit of code with PLATFORM(GTK) and PLATFORM(X11). Testing GDK_WINDOWING_X11
ensures that the GTK+ dependency has X11 support, but does not ensure
that WebKitGTK+ has been configured to build for X11 environments (which
is what PLATFORM(X11) ensures).

1:24 AM Changeset in webkit [181789] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK] Properly guard X11-specific code in BackingStore::createBackend()
https://bugs.webkit.org/show_bug.cgi?id=142875

Reviewed by Martin Robinson.

UIProcess/cairo/BackingStoreCairo.cpp:

1:07 AM Changeset in webkit [181788] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181787 - [GTK] Crash due to empty drag image during drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=142671

Reviewed by Philippe Normand.

Return early from ImageBuffer constructor if an empty size is
given. This is a speculative fix for a crash while starting a drag
and drop operation, that I haven't been able to reproduce.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

1:04 AM Changeset in webkit [181787] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Crash due to empty drag image during drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=142671

Reviewed by Philippe Normand.

Return early from ImageBuffer constructor if an empty size is
given. This is a speculative fix for a crash while starting a drag
and drop operation, that I haven't been able to reproduce.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

1:02 AM Changeset in webkit [181786] by Csaba Osztrogonác

3 edits in trunk

Unreviewed, kick the GTK bots to regenerate makefile.
https://bugs.webkit.org/show_bug.cgi?id=137394

Source/cmake/OptionsEfl.cmake: Revert my last accidenatal change.
Source/cmake/OptionsGTK.cmake: Really kick the GTK bots.

12:52 AM Changeset in webkit [181785] by Csaba Osztrogonác

2 edits in trunk

Unreviewed, kick the GTK bots to regenerate makefile.
https://bugs.webkit.org/show_bug.cgi?id=137394

Source/cmake/OptionsEfl.cmake:

Mar 19, 2015:

11:01 PM Changeset in webkit [181784] by aestes@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Fixed a ChangeLog misspelling pointed out by Andreas.

10:58 PM Changeset in webkit [181783] by aestes@apple.com

8 edits
2 adds in trunk/LayoutTests

[Content Filtering] Give contentfiltering tests a JavaScript harness
https://bugs.webkit.org/show_bug.cgi?id=142899

Reviewed by Andreas Kling.

Create a JavaScript function to run the contentfiltering/ tests. This consolodates shared logic and will make
it easier to write new tests.

TestExpectations: Skipped a test that times out with the new harness (but it also failed before).
contentfiltering/allow-after-add-data.html: Called testContentFiltering().
contentfiltering/allow-after-finished-adding-data.html: Ditto.
contentfiltering/allow-after-response.html: Ditto.
contentfiltering/block-after-add-data.html: Ditto.
contentfiltering/block-after-finished-adding-data.html: Ditto.
contentfiltering/block-after-response.html: Ditto.
contentfiltering/resources/contentfiltering.js: Added.

10:45 PM Changeset in webkit [181782] by Chris Dumez

8 edits in trunk/Source

[WK2] We should allow stale content when restoring a killed / crashed WebProcess
https://bugs.webkit.org/show_bug.cgi?id=142893
<rdar://problem/19633737>
<rdar://problem/19869257>

Reviewed by Antti Koivisto.

Source/WebCore:

Always use ReturnCacheDataElseLoad cache policy for history navigations.
Previously, we would use the default protocol cache policy for history
navigations if m_stateMachine.committedFirstRealDocumentLoad() returned
false so that we do not display stale content when restoring the session
state of Safari statup (rdar://problem/8131355). This is now handled
before reaching this method by no longer using "IndexedBackForward"
FrameLoadType when restoring session tabs, and using "Standard" load
type instead.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem):

Source/WebKit2:

Allow stale content when restoring a killed / crashed WebProcess
(similarly to a history navigation). This is actually what was intended
as we call WebPage::goToBackForwardItem() in this case, which uses
IndexedBackForward load type. However, this value was then ignored in
FrameLoader::loadDifferentDocumentItem().

This patch gets rid of the special casing in
FrameLoader::loadDifferentDocumentItem() and makes it clear at call
sites when calling goToBackForwardItem() if we should allow stale
content or not. If goToBackForwardItem() is called with the
allowStaleContent flag off, we'll keep using the IndexedBackForward
frame load type. However, if the flag is on, we'll use the Standard
frame load type and do a fresh load.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessForReload):
Set allowStaleContent flag to true as we want to allow stale content
when reloading a WebProcess after it crashed or was killed (behavior
change).

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
Add allowStaleContent parameter so that call sites can decide which
policy to use.

(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
Set allowStaleContent flag to true as this is our policy for history
navigations.

(WebKit::WebPageProxy::goToBackForwardItem):
Add allowStaleContent parameter so that the call site can let us know
what to do. This is useful as this is called not only for indexed
back / forward navigations (allowing stale content) but also for
restoring session state (forbidding state content:
<rdar://problem/8131355>).

(WebKit::WebPageProxy::restoreFromSessionState):
Call goToBackForwardItem() with allowStaleContent flag set to false
as users expect fresh contents in this case. This method is called
when:

Tabs are restored on Safari / MobileSafari startup
Tabs are restored via "History > Reopen All windows from last session"

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goToBackForwardItem):
Add allowStaleContent parameter and use "Standard" frame load type
instead of "IndexedBackForward" if it is false. This is needed as
"IndexedBackForward" frame load type allows using stale content.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Add allowStaleContent flag to GoToBackForwardItem message.

10:22 PM Changeset in webkit [181781] by aestes@apple.com

6 edits
1 copy
2 moves in trunk/Source/WebCore

[Content Filtering] Move ContentFilter to from platform/ to loader/
https://bugs.webkit.org/show_bug.cgi?id=142897

Reviewed by Dan Bernstein.

ContentFilterCollection never contained any platform code, so it doesn't make sense for it to be in platform.
Move it to loader/, since ContentFilters are owned by DocumentLoaders, and just call it ContentFilter. Extract
the abstract part of ContentFilter into a new base class called PlatformContentFilter that each of the
individual filters inherit from.

WebCore.xcodeproj/project.pbxproj:
loader/ContentFilter.cpp: Renamed from Source/WebCore/platform/ContentFilter.cpp.

(WebCore::ContentFilter::types): Moved from ContentFilterCollection.
(WebCore::ContentFilter::createIfNeeded): Ditto.
(WebCore::ContentFilter::ContentFilter): Ditto.
(WebCore::ContentFilter::addData): Ditto.
(WebCore::ContentFilter::finishedAddingData): Ditto.
(WebCore::ContentFilter::needsMoreData): Ditto.
(WebCore::ContentFilter::didBlockData): Ditto.
(WebCore::ContentFilter::getReplacementData): Ditto.
(WebCore::ContentFilter::unblockHandler): Ditto.

loader/ContentFilter.h: Copied from Source/WebCore/platform/ContentFilter.h.

(WebCore::ContentFilter::type): Replaced a use of ContentFilterCollection.

platform/PlatformContentFilter.h: Renamed from Source/WebCore/platform/ContentFilter.h.
platform/cocoa/NetworkExtensionContentFilter.h: Inherited from PlatformContentFilter.
platform/cocoa/ParentalControlsContentFilter.h: Ditto.
testing/MockContentFilter.h: Ditto.

10:06 PM Changeset in webkit [181780] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Try to get the Debug bots green.

platform/win/TestExpectations:

10:02 PM Changeset in webkit [181779] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Skip an <attachment> test that times out on Windows.

Also mark two flakes I noticed on the test bots.

platform/win/TestExpectations:

9:47 PM Changeset in webkit [181778] by dino@apple.com

12 edits
4 adds in trunk

CSS Animations with triggers should map scroll position to duration
https://bugs.webkit.org/show_bug.cgi?id=142870
<rdar://problem/20227244>

Reviewed by Simon Fraser.

Source/WebCore:

Expose a prototype implementation of what will eventually be called
animation-timebase, mapping the scroll location to the duration of an
animation. This only applies if the animation has a start and end
trigger.

Test: animations/trigger-container-scroll-boundaries.html
Test: animations/trigger-container-scroll-empty.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::createAnimationTriggerValue): Change to downcast.

css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger): Fix a bug where I wasn't
telling the ScrollAnimationTrigger object whether or not it had
an end value. This wasn't visible before because we were not using
the end value.

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fireAnimationEventsIfNeeded): Add a comment and
change to using a downcast.
(WebCore::AnimationBase::timeToNextService): Change to downcast.
(WebCore::AnimationBase::freezeAtTime): Whitespace cleanup.
(WebCore::AnimationBase::getElapsedTime): Calculate the elapsedTime based
on the scroll position relative to the start and end trigger spots.

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations): Since this
can potentially call into beginAnimationUpdateTime, it should have
an update blocker. This fixes the assert we were seeing in tests.
(WebCore::AnimationControllerPrivate::scrollWasUpdated): Keep track of the scroll
position so we don't need to ask for it all the time.

page/animation/AnimationControllerPrivate.h:

(WebCore::AnimationControllerPrivate::scrollPosition): New accessor.

platform/animation/AnimationTrigger.h: Add downcast macros.

(WebCore::ScrollAnimationTrigger::create): Calculate hasEndValue from the passed
parameters rather than a separate value.
(WebCore::ScrollAnimationTrigger::hasEndValue):
(WebCore::ScrollAnimationTrigger::ScrollAnimationTrigger):
(WebCore::ScrollAnimationTrigger::setHasEndValue): Deleted.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationCanBeAccelerated): If we have an
animation of this sort, we can't use a CAAnimation.

LayoutTests:

Add a new test that exercises an animation trigger over a scroll
region, and a test of the boundary condition. Also, unskip a test that
was failing due to a bug fixed in this patch.

animations/trigger-container-scroll-boundaries-expected.txt: Added.
animations/trigger-container-scroll-boundaries.html: Added.
animations/trigger-container-scroll-empty-expected.txt: Added.
animations/trigger-container-scroll-empty.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

8:51 PM Changeset in webkit [181777] by eric.carlson@apple.com

9 edits
4 moves in trunk/Source

[Mac] Move MediaPlaybackTargetPicker
https://bugs.webkit.org/show_bug.cgi?id=142889

Source/WebCore:

Move WebMediaPlaybackTargetPickerProxy from WK2 and rename as MediaPlaybackTargetPicker so it
can be used by both WK2 and WK1.

Reviewed by Tim Horton.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/MediaPlaybackTargetPicker.cpp: Copied from Source/WebKit2/UIProcess/WebMediaPlaybackTargetPickerProxy.cpp.
platform/graphics/MediaPlaybackTargetPicker.h: Copied from Source/WebKit2/UIProcess/WebMediaPlaybackTargetPickerProxy.h.
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h: Copied from Source/WebKit2/UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.h.
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm: Copied from Source/WebKit2/UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.mm.

Source/WebKit2:

Move WebMediaPlaybackTargetPickerProxy to WebCore so it can be used by
both WK2 and WK1.

Reviewed by Tim Horton.

UIProcess/PageClient.h:
UIProcess/WebMediaPlaybackTargetPickerProxy.cpp: Removed.
UIProcess/WebMediaPlaybackTargetPickerProxy.h: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::devicePickerProxy):

UIProcess/WebPageProxy.h:
UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPlaybackTargetPicker):

UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.h: Removed.
UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.mm: Removed.
WebKit2.xcodeproj/project.pbxproj:

6:52 PM Changeset in webkit [181776] by jberlin@webkit.org

2 edits in trunk/Source/WebKit2

32-bit build fix after r181770.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:webView:]):

6:37 PM Changeset in webkit [181775] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Add support for deleting individual cache entries
https://bugs.webkit.org/show_bug.cgi?id=142886

Reviewed by Antti Koivisto.

NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
Remove an unnecessary call to cfURLCacheOrigins().

(WebKit::clearDiskCacheEntries):
Helper function for clearing disk cache entries. This handles both the old and new cache implementations.

(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Call clearDiskCacheEntries if needed.

5:53 PM Changeset in webkit [181774] by rniwa@webkit.org

2 edits in trunk/Tools

Unreviewed build fix. Don't try to report stats for all benchmarks.
Just report the geometric mean of preferred means.

Scripts/run-jsc-benchmarks:

5:47 PM Changeset in webkit [181773] by enrica@apple.com

3 edits
2 adds in trunk

Source/WebCore:
REGRESSION (r109593): Clicking after last inline element could cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=142880
rdar://problem/17222294

Reviewed by Ryosuke Niwa.

Test: editing/selection/click-after-last-inline-crash.html

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):

LayoutTests:
Web Inspector: Adopt ES6 Class Syntax for all Model Objects
https://bugs.webkit.org/show_bug.cgi?id=142858

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-19
Reviewed by Timothy Hatcher.

inspector/model/parse-script-syntax-tree.html:

This test was calling a constructor without "new". Class
syntax enforces "new" and threw an exception.

5:44 PM Changeset in webkit [181772] by enrica@apple.com

2 edits in trunk/Source/WebCore

One more build fix after r181760.

page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

5:38 PM Changeset in webkit [181771] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Build fix after r181760.

rendering/RenderAttachment.h:

5:20 PM Changeset in webkit [181770] by jer.noble@apple.com

6 edits in trunk/Source

[WK2][Mac] Fullscreen animations with mismatched aspect ratios are "squished".
https://bugs.webkit.org/show_bug.cgi?id=142132

Reviewed by Tim Horton.

Source/WebCore:

Add a new utility method to calculate a rect with a specific aspect ratio wrapping a smaller one.

platform/graphics/GeometryUtilities.cpp:

(WebCore::smallestRectWithAspectRatioAroundRect):

platform/graphics/GeometryUtilities.h:

Source/WebKit2:

Use CALayer animations for the transition into and out of fullscreen.

The fullscreen transition consists of three separate animations:

An opacity animation for the black backdrop behind the fullscreen content
A scale/translation animation from fullscreen element's initial screen to its final one.
A clip animation from the fullscreen element's initial aspect ratio to its final one.

The opacity animation will apply to the fullscreen window's content view's layer's
background color. To separately animate the transform and mask of the web view's content, a
layer-backed subview is added to the content view, and the scale/translation & clip
animations are applied to its transform property and mask layer respectively.

Utility methods to create each animation have been added, and each includes a parameter for
the direction of the animation, so that the same methods can be used for entering and
exiting fullscreen transitions.

The user-visible changes to this new transition are when the aspect ratios of the initial
and final screen locations are different: previously the transition would use a scale
transform to "squish" the fullscreen content into the initial aspect ratio. The new
transition instead "clips" the fullscreen content to the initial aspect ratio. For common
operations such a <video> element with a different aspect ratio than the screen, this makes
the black letterbox "grow" during the transition, and makes the transition overall much
smoother.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:webView:]): Create and initialze the clipping view.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): _backgroundWindow was removed.
(-[WKFullScreenWindowController enterFullScreen:]): Add the webView to the _clipView, not the contentView.
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): _backgroundWindow,

_fadeAnimation, and _scaleAnimation are all removed.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Ditto.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Ditto. Hide the contentView's

layer. Pause visibility updates.

(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Resume visibility updates.
(-[WKFullScreenWindowController close]): _fadeAnimation and _scaleAnimation are removed.
(-[WKFullScreenWindowController customWindowsToEnterFullScreenForWindow:]): Return only the fullscreen

window.

(-[WKFullScreenWindowController customWindowsToExitFullScreenForWindow:]): Ditto.
(zoomAnimation): Added.
(maskAnimation): Added.
(fadeAnimation): Added.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Use the utility

methods above to set up the animation.

(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Ditto.
(createBackgroundFullscreenWindow): Deleted.
(windowFrameFromApparentFrames): Deleted.

5:18 PM Changeset in webkit [181769] by Joseph Pecoraro

182 edits in trunk

Web Inspector: Adopt ES6 Class Syntax for all Model Objects
https://bugs.webkit.org/show_bug.cgi?id=142858

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

Convert WebInspector.Object to a class
Convert all UserInterface/Models objects to classes
Convert constructor functions to constructor methods
Convert "constructor.method" to class static methods where possible
Convert all methods to method syntax, eliminate commas between methods
Convert all superclass calls in classes to use "super"
Workaround <https://webkit.org/b/142862> and add empty constructors
Added "deprecated" prefix to addConstructorFunctions, since it is not needed with classes
Added many missing calls to super in constructors
Added FIXME to WebInspector.Object subclasses not yet moved to classes.
Cleaned up SourceMap global properties, moved to constructor instead of prototype
Cleaned up Timeline factory constructor to static "create" factory method
Fixed any style issues noticed in the mass edit
Fixed strict mode issues now that classes enforce strict mode
- RunLoopTimelineRecord.js was missing a var for a local variable
- "const" is not allowed, converted to "var"
- "arguments.callee" is not allowed in strict mode

UserInterface//*.js:

Many files modified mostly mechanically.

LayoutTests:

inspector/model/parse-script-syntax-tree.html:

This test was calling a constructor without "new". Class
syntax enforces "new" and threw an exception.

4:52 PM Changeset in webkit [181768] by jonowells@apple.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause
https://bugs.webkit.org/show_bug.cgi?id=142847

Reviewed by Timothy Hatcher.

Add a paused class on the debugger sidebar panel. Use that class to adjust the sidebar styles so that, when
the debugger is not paused: there is no header for the scripts section, there is no border beneath the scripts
section, and the scripts section cannot be collapsed (which could be done while the debugger is paused). The
header has changed to say "Scripts" instead of "Breakpoints" when it is showing.

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .details-section.scripts):
(.sidebar > .panel.navigation.debugger .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content):
Adjust styles to hide header and border.

UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
Add a paused class to the debugger sidebar when it is paused.

4:33 PM Changeset in webkit [181767] by matthew_hanson@apple.com

2 edits in tags/Safari-601.1.23.3/Source/WebCore

Merge r181662. rdar://problem/20144648

4:26 PM Changeset in webkit [181766] by Chris Dumez

5 edits in trunk/Source/WebCore

Get rid of "CachePolicyCache" cache policy
https://bugs.webkit.org/show_bug.cgi?id=142881

Reviewed by Antti Koivisto.

Get rid of "CachePolicyCache" cache policy as it is unused.

loader/cache/CachePolicy.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey): Deleted.

page/DiagnosticLoggingKeys.h:

4:01 PM Changeset in webkit [181765] by akling@apple.com

3 edits in trunk/Source/JavaScriptCore

JSCallee unnecessarily overrides a bunch of things in the method table.
<https://webkit.org/b/142855>

Reviewed by Geoffrey Garen.

Remove JSCallee method table overrides that simply call to base class.
This makes JSFunction property slot lookups slightly more efficient since
they can take the fast path when passing over JSCallee in the base class chain.

runtime/JSCallee.cpp:

(JSC::JSCallee::getOwnPropertySlot): Deleted.
(JSC::JSCallee::getOwnNonIndexPropertyNames): Deleted.
(JSC::JSCallee::put): Deleted.
(JSC::JSCallee::deleteProperty): Deleted.
(JSC::JSCallee::defineOwnProperty): Deleted.

runtime/JSCallee.h:

3:46 PM Changeset in webkit [181764] by rniwa@webkit.org

2 edits in trunk/Tools

run-jsc-benchmarks should only report preferred mean
https://bugs.webkit.org/show_bug.cgi?id=142874

Reviewed by Geoffrey Garen.

Just collect statistics for the preferred mean.

Scripts/run-jsc-benchmarks:

3:39 PM Changeset in webkit [181763] by enrica@apple.com

2 edits in trunk/Source/WebCore

[Content Extensions] Test regular expression parse failures.
https://bugs.webkit.org/show_bug.cgi?id=142872

Patch by Alex Christensen <achristensen@webkit.org> on 2015-03-19
Reviewed by Benjamin Poulain.

contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::GraphBuilder::finalize):
(WebCore::ContentExtensions::GraphBuilder::quantifyAtom):
(WebCore::ContentExtensions::URLFilterParser::addPattern):
(WebCore::ContentExtensions::URLFilterParser::statusString):

contentextensions/URLFilterParser.h:

Changed failures that can never happen to assertions.

3:37 PM Changeset in webkit [181762] by achristensen@apple.com

5 edits in trunk

[Content Extensions] Test regular expression parse failures.
https://bugs.webkit.org/show_bug.cgi?id=142872

Reviewed by Benjamin Poulain.

Source/WebCore:

contentextensions/URLFilterParser.cpp:

contentextensions/URLFilterParser.h:

Changed failures that can never happen to assertions.

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testPatternStatus):
(TestWebKitAPI::TEST_F):
Added tests for each parsing status.

3:36 PM Changeset in webkit [181761] by rniwa@webkit.org

5 edits in trunk/Websites/perf.webkit.org

Unreviewed build fixes.

public/include/manifest.php:

(Manifest::generate): These should be {} instead of [] when they're empty.

public/v2/data.js:

(Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.

public/v2/manifest.js:

(App.Metric.fullName): Fixed the typo.

tests/admin-regenerate-manifest.js: Fixed the test.

2:59 PM Changeset in webkit [181760] by enrica@apple.com

32 edits
2 adds in trunk

<attachment> should put URLs on the pasteboard so that Finder can accept drops.
https://bugs.webkit.org/show_bug.cgi?id=142801
rdar://problem/19982527

Reviewed by Tim Horton.

Source/WebCore:

Test: editing/pasteboard/drag-and-drop-attachment-contenteditable.html

This patch adds all the necessary support to write attachment elements into
the pasteboard, including the promised type.

WebCore.xcodeproj/project.pbxproj:
page/DragActions.h:
page/DragClient.h:

(WebCore::DragClient::declareAndWriteAttachment):

page/DragController.cpp:

(WebCore::DragController::draggableElement):
(WebCore::DragController::startDrag):

page/DragController.h:

(WebCore::DragController::draggingAttachmentURL):

page/EventHandler.cpp:

(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):

page/mac/DragControllerMac.mm:

(WebCore::DragController::declareAndWriteAttachment):

page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteAttachment):

platform/URL.cpp:

(WebCore::URL::fileURLWithFileSystemPath):

platform/URL.h:
rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteAttachmentURL):

rendering/HitTestResult.h:

Source/WebKit/mac:

This patch adds all the necessary support to write attachment elements into
the pasteboard, including the promised type in WK1.

Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

WebCoreSupport/WebDragClient.h:
WebCoreSupport/WebDragClient.mm:

(WebDragClient::declareAndWriteAttachment):

WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

WebView/WebUIDelegate.h:

Source/WebKit2:

This patch adds all the necessary support to write attachment elements into
the pasteboard, including the promised type in WK2.

UIProcess/API/mac/WKView.mm:

(-[WKView _setPromisedDataForImage:withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:forPasteboard:]):
(-[WKView _setPromisedDataForAttachment:withExtension:withTitle:withURL:withVisibleURL:forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView _setPromisedData:withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:forPasteboard:]): Deleted.

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPromisedDataForImage):
(WebKit::PageClientImpl::setPromisedDataForAttachment):
(WebKit::PageClientImpl::setPromisedData): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedDataForImage):
(WebKit::WebPageProxy::setPromisedDataForAttachment):
(WebKit::WebPageProxy::setPromisedData): Deleted.

WebProcess/WebCoreSupport/WebDragClient.h:
WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteAttachment):
(WebKit::WebDragClient::declareAndWriteDragImage):

LayoutTests:

editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt: Added.
editing/pasteboard/drag-and-drop-attachment-contenteditable.html: Added.
platform/mac-wk2/TestExpectations: Skipping new test on WK2 since it uses eventSender.

2:44 PM Changeset in webkit [181759] by jonowells@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources
https://bugs.webkit.org/show_bug.cgi?id=142777

Reviewed by Brian Burg.

Typing into the text input on the filter bar for the debugger sidebar no longer incorrectly hides the
breakpoints for scripts that match the text input.

UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.get filterableData): Added.

2:19 PM Changeset in webkit [181758] by akling@apple.com

10 edits
2 deletes in trunk/Source

DFGAllocator should use bmalloc's aligned allocator.
<https://webkit.org/b/142871>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Switch DFGAllocator to using bmalloc through fastAlignedMalloc().

dfg/DFGAllocator.h:

(JSC::DFG::Allocator<T>::allocateSlow):
(JSC::DFG::Allocator<T>::freeRegionsStartingAt):

heap/CopiedSpace.h:
heap/MarkedBlock.h:
heap/MarkedSpace.h:

Source/WTF:

Remove PageAllocationAligned since it has no more clients.

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/PageAllocationAligned.cpp: Removed.
wtf/PageAllocationAligned.h: Removed.

2:17 PM Changeset in webkit [181757] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, fix linking error after r181753.

Drop WEBCORE_EXPORT for Settings::minimumDOMTimerInterval() as it is
now inlined.

page/Settings.h:

(WebCore::Settings::minimumDOMTimerInterval):

2:16 PM Changeset in webkit [181756] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Cache::remove should take a Key instead of an entry
https://bugs.webkit.org/show_bug.cgi?id=142878

Reviewed by Antti Koivisto.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::remove):

NetworkProcess/cache/NetworkCache.h:

1:50 PM Changeset in webkit [181755] by achristensen@apple.com

2 edits in trunk/Tools

Fix API tests after r181754.

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testRequest):

12:36 PM Changeset in webkit [181754] by beidson@apple.com

11 edits in trunk

Part of content extensions should apply css selectors
https://bugs.webkit.org/show_bug.cgi?id=142604

Reviewed by Alex Christensen.

Source/WebCore:

Add a new action for applying the cached global stylesheet.

contentextensions/CompiledContentExtension.cpp:

(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):

contentextensions/ContentExtensionActions.h:

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):

contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::Action::deserialize):

contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Action::Action):
(WebCore::ContentExtensions::Action::operator==):
(WebCore::ContentExtensions::Action::stringArgument):
(WebCore::ContentExtensions::Action::cssSelector): Deleted.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(WebCore::ContentExtensions::operator<<):

12:22 PM Changeset in webkit [181753] by Chris Dumez

15 edits in trunk/Source

Clean up DOMTimer related settings
https://bugs.webkit.org/show_bug.cgi?id=142837

Reviewed by Darin Adler.

Source/WebCore:

Clean up DOMTimer related settings:

Make default minimum timer interval 4ms instead of 10ms as all ports were setting it to 4ms and the specifications says 4ms.
Get rid of setters for default DOMTimer interval values as they are not set anymore.
Move default DOMTimer interval values from Settings to DOMTimer as those are global (not per-page) and not really settings.
Stop using abbreviations in the names (e.g. min -> minimum).
Move DOMTimer settings members from Page to Settings. There is no reason for those to be stored on the Page. The getters were private so call-sites had to go via Settings anyway. Also, call-sites already had to do a null check on the page to get the settings. It seems unfortunate for the settings to do another null-check on the page for retrieving the setting value from the page.
Inline the DOMTimer settings getters as these are trivial.

dom/Document.cpp:

(WebCore::Document::minimumTimerInterval):
(WebCore::Document::timerAlignmentInterval):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::minimumTimerInterval):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

page/DOMTimer.h:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setTimerThrottlingEnabled):
(WebCore::Page::setMinimumTimerInterval): Deleted.
(WebCore::Page::minimumTimerInterval): Deleted.

page/Page.h:

(WebCore::Page::timerAlignmentInterval): Deleted.

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setMinimumDOMTimerInterval):
(WebCore::Settings::setDOMTimerAlignmentInterval):
(WebCore::Settings::setHiddenPageDOMTimerAlignmentInterval): Deleted.
(WebCore::Settings::hiddenPageDOMTimerAlignmentInterval): Deleted.
(WebCore::Settings::setDefaultMinDOMTimerInterval): Deleted.
(WebCore::Settings::defaultMinDOMTimerInterval): Deleted.
(WebCore::Settings::setMinDOMTimerInterval): Deleted.
(WebCore::Settings::minDOMTimerInterval): Deleted.
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval): Deleted.
(WebCore::Settings::defaultDOMTimerAlignmentInterval): Deleted.
(WebCore::Settings::domTimerAlignmentInterval): Deleted.

page/Settings.h:

(WebCore::Settings::minimumDOMTimerInterval):
(WebCore::Settings::domTimerAlignmentInterval):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMinimumTimerInterval):

Source/WebKit/mac:

Stop setting the DOMTimers' default minimum interval to 4ms as this
is now the default.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/win:

Stop setting the DOMTimers' default minimum interval to 4ms as this
is now the default.

WebView.cpp:

(WebView::initWithFrame):
(WebView::defaultMinimumTimerInterval):

Source/WebKit2:

Stop setting the DOMTimers' default minimum interval to 4ms as this
is now the default.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

11:13 AM Changeset in webkit [181752] by Lucas Forschler

5 edits in branches/safari-600.1.17-branch/Source

Versioning.

11:11 AM Changeset in webkit [181751] by Lucas Forschler

1 copy in tags/Safari-600.1.17.10

New Tag.

10:52 AM Changeset in webkit [181750] by msaboff@apple.com

7 edits in branches/safari-600.1.17-branch/Source

Merged r181628. <rdar://problem/19804738>

2015-03-16 Michael Saboff <msaboff@apple.com>

Windows X86-64 should use the fixed executable allocator
https://bugs.webkit.org/show_bug.cgi?id=142749

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added jit/ExecutableAllocatorFixedVMPool.cpp to Windows build.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
jit/ExecutableAllocatorFixedVMPool.cpp: Don't include unistd.h on Windows.

Source/WTF:

Set ENABLE_EXECUTABLE_ALLOCATOR_FIXED for Windows.
Needed to export MetaAllocator::currentStatistics() for use in JavaScriptCore.

wtf/MetaAllocator.h:
wtf/Platform.h:

10:14 AM Changeset in webkit [181749] by dino@apple.com

2 edits in trunk/LayoutTests

http://webkit.org/b/142790

Temporarily skip animations/trigger-container-scroll-simple.html
while it is crashing.

platform/mac/TestExpectations:

9:42 AM Changeset in webkit [181748] by Brent Fulgham

2 edits in trunk/Tools

[Win] Activate tests on EWS
https://bugs.webkit.org/show_bug.cgi?id=142850

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/common/config/ews.json: Add me as

the EWS bot watcher, and activate tests.

9:40 AM Changeset in webkit [181747] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Test gardening.

platform/win/TestExpectations:

6:25 AM Changeset in webkit [181746] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Skip Legacy WebNotifications test
https://bugs.webkit.org/show_bug.cgi?id=141962

The revision r177073 skips all legacy tests for notifications except from
http/tests/notifications/legacy/notification-request-permission-then-navigate.html
which was failing. We skip this test now too.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-19
Reviewed by Carlos Garcia Campos.

platform/gtk/TestExpectations:

3:40 AM Changeset in webkit [181745] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181744 - [GTK] Scrollbars look bad with GTK+ 3.16
https://bugs.webkit.org/show_bug.cgi?id=140800

Reviewed by Sergio Villar Senin.

Take margin into account when rendering scrollbars. This fixes the
huge scrollbars rendered with GTK+ 3.16. We don't need to check
the GTK+ version because in previous versions the marging were 0,
so the same code just works.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::adjustRectAccordingToMargin):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):

3:24 AM Changeset in webkit [181744] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Scrollbars look bad with GTK+ 3.16
https://bugs.webkit.org/show_bug.cgi?id=140800

Reviewed by Sergio Villar Senin.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::adjustRectAccordingToMargin):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):

2:01 AM Changeset in webkit [181743] by bshafiei@apple.com

4 edits in tags/Safari-601.1.23.3/Source

Merged r181679. rdar://problem/20032670

1:58 AM Changeset in webkit [181742] by bshafiei@apple.com

2 edits in tags/Safari-601.1.23.3/Source/WebKit/mac

Merged r181674. rdar://problem/20032670

1:57 AM Changeset in webkit [181741] by bshafiei@apple.com

6 edits in tags/Safari-601.1.23.3/Source

Merged r181668. rdar://problem/20032670

1:55 AM Changeset in webkit [181740] by bshafiei@apple.com

3 edits in tags/Safari-601.1.23.3/Source/WebCore

Merged r181703. rdar://problem/19446938

1:53 AM Changeset in webkit [181739] by bshafiei@apple.com

2 edits in tags/Safari-601.1.23.3/Source/WebCore

Merged r181666. rdar://problem/19445803

1:51 AM Changeset in webkit [181738] by bshafiei@apple.com

2 edits in tags/Safari-601.1.23.3/Source/WebCore

Merged r181616. rdar://problem/20184456

1:49 AM Changeset in webkit [181737] by bshafiei@apple.com

7 edits
4 copies in tags/Safari-601.1.23.3

Merged r181608. rdar://problem/20184456

1:27 AM Changeset in webkit [181736] by youenn.fablet@crf.canon.fr

8 edits in trunk

[Streams API] Update ReadableStream API according new version of the specification
https://bugs.webkit.org/show_bug.cgi?id=142822

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch updates the IDL of ReadableStream according the new version of the spec, which splits functionality between ReadableStream and ReadableStreamReader.
In particular, this patch removes read(), ready, closed and state from ReadableStream and it adds the getReader method.

Covered by updated readablestream-constructor.html test.

Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::ReadableStream):
(WebCore::ReadableStream::state): Deleted.
(WebCore::ReadableStream::closed): Deleted.
(WebCore::ReadableStream::ready): Deleted.

Modules/streams/ReadableStream.h:

(WebCore::ReadableStream::internalState): Added to make mac build system happy, to be used by ReadableStreamReader.

Modules/streams/ReadableStream.idl:
bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::cancel):
(WebCore::JSReadableStream::getReader):
(WebCore::JSReadableStream::read): Deleted.
(WebCore::getOrCreatePromiseDeferredFromObject): Deleted.
(WebCore::readyPromiseSlotName): Deleted.
(WebCore::JSReadableStream::ready): Deleted.
(WebCore::closedPromiseSlotName): Deleted.
(WebCore::JSReadableStream::closed): Deleted.

LayoutTests:

Removing tests checking ready and closed.
Removing assertions checking read(), ready, closed and state.
Adding assertions to test getReader() and parameters of remaining methods.

streams/readablestream-constructor-expected.txt:
streams/readablestream-constructor.html:

1:19 AM Changeset in webkit [181735] by Csaba Osztrogonác

4 edits in trunk

[GTK] Fix inspector userinterface related incremental build issue
https://bugs.webkit.org/show_bug.cgi?id=142849

Reviewed by Carlos Garcia Campos.

Source/cmake/OptionsGTK.cmake: Revert r181733.

Tools:

Scripts/webkitdirs.pm:

(shouldRemoveCMakeCache):

12:54 AM Changeset in webkit [181734] by Chris Dumez

4 edits in trunk

The network cache should ignore "cache-control: no-cache, must-revalidate" on history navigation
https://bugs.webkit.org/show_bug.cgi?id=142831
<rdar://problem/20209957>

Reviewed by Antti Koivisto.

Source/WebKit2:

The network cache should ignore "no-cache" and "must-revalidate" as
Cache-Control policy for history navigations to avoid unnecessary
revalidation in this case. Our memory cache already behaves this way.

On history navigation, our disk cache implementation currently
revalidates unconditionally resources if "cache-control: no-cache" is
used. It also revalidates expired resources if "cache-control:
must-revalidate" is used. This is sub-optimal.

RFC 7234 does not require us to do so [1]:
"""

User agents often have history mechanisms, such as "Back" buttons and
history lists, that can be used to redisplay a representation
retrieved earlier in a session.

The freshness model (Section 4.2) does not necessarily apply to
history mechanisms. That is, a history mechanism can display a
previous representation even if it has expired.

"""

Chrome and IE9+ [2] already ignore "cache-control: must-revalidate" on history navigation.

[1] https://tools.ietf.org/html/rfc7234#page-32
[2] http://blogs.msdn.com/b/ie/archive/2010/07/14/caching-improvements-in-internet-explorer-9.aspx

Test: http/tests/cache/disk-cache-validation-back-navigation-policy.html

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::decodeStorageEntry):

LayoutTests:

Rebaseline disk-cache-validation-back-navigation-policy.html test now
that we ignore "cache-control: no-cache, must-revalidate" on history
navigation. This is a progression.

http/tests/cache/disk-cache-validation-back-navigation-policy-expected.txt:

Mar 18, 2015:

11:30 PM Changeset in webkit [181733] by Csaba Osztrogonác

2 edits in trunk

Unreviewed, kick the GTK bots to regenerate makefile.

Source/cmake/OptionsGTK.cmake:

11:22 PM Changeset in webkit [181732] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Windows gardening for debug bots.

platform/win/TestExpectations:

11:14 PM Changeset in webkit [181731] by bshafiei@apple.com

5 edits in tags/Safari-601.1.23.3/Source

Versioning.

11:10 PM Changeset in webkit [181730] by bshafiei@apple.com

1 copy in tags/Safari-601.1.23.3

New tag.

11:09 PM Changeset in webkit [181729] by Manuel Rego Casasnovas

2 edits in trunk/Source/WebCore

Unreviewed. GTK build fix after r181720.

rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):

10:21 PM Changeset in webkit [181728] by Antti Koivisto

10 edits
2 adds in trunk

Test disk cache behavior when using back navigation cache policy
https://bugs.webkit.org/show_bug.cgi?id=142848

Reviewed by Chris Dumez.

Source/WebCore:

Add a way to override the normal cache policy so we can test reload behavior of cache without actually reloading.

Test: http/tests/cache/disk-cache-validation-back-navigation-policy.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):

loader/FrameLoader.h:

(WebCore::FrameLoader::setOverrideCachePolicyForTesting):

testing/Internals.cpp:

(WebCore::Internals::setOverrideCachePolicy):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

http/tests/cache/disk-cache-validation-back-navigation-policy-expected.txt: Added.
http/tests/cache/disk-cache-validation-back-navigation-policy.html: Added.

Test permutations of cache headers on reload including Cache-control: must-revalidate.

platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

10:16 PM Changeset in webkit [181727] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

TextFragment#start() is always >= 0 since its type is unsigned
https://bugs.webkit.org/show_bug.cgi?id=142860

Reviewed by Andreas Kling.

Since TextFragment::m_start is unsigned, the result of
TextFragment::start() is always >= 0 and assertion is not effective.
This patch removes this assertion to suppress warnings.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::revertToFragment):

9:57 PM Changeset in webkit [181726] by commit-queue@webkit.org

13 edits in trunk

[ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
https://bugs.webkit.org/show_bug.cgi?id=142799

Patch by Alex Christensen <achristensen@webkit.org> on 2015-03-18
Reviewed by Brady Eidson.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Make private headers to use with API tests.

contentextensions/CompiledContentExtension.cpp:

(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):

contentextensions/CompiledContentExtension.h:

Added method to get only the selectors from the root of the DFA, which apply to all URLs.

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):
Added checking if the trigger will match everything.
These actions can be put directly on the root of the DFA without adding extra epsilon transitions to the NFA.

contentextensions/DFA.h:

(WebCore::ContentExtensions::DFA::nodeAt):

contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):

contentextensions/DFABytecodeInterpreter.h:
contentextensions/NFA.h:
contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::Term::quantifier):
Sink terms to a vector then add nodes to NFA when finalizing after checking for regexes that match everything.
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder):
(WebCore::ContentExtensions::GraphBuilder::finalize):
(WebCore::ContentExtensions::GraphBuilder::parseStatus):
(WebCore::ContentExtensions::GraphBuilder::atomPatternCharacter):
(WebCore::ContentExtensions::GraphBuilder::atomBuiltInCharacterClass):
(WebCore::ContentExtensions::GraphBuilder::quantifyAtom):
(WebCore::ContentExtensions::GraphBuilder::atomBackReference):
(WebCore::ContentExtensions::GraphBuilder::assertionBOL):
(WebCore::ContentExtensions::GraphBuilder::assertionWordBoundary):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassAtom):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassRange):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassBuiltIn):
(WebCore::ContentExtensions::GraphBuilder::atomParentheticalAssertionBegin):
(WebCore::ContentExtensions::GraphBuilder::disjunction):
(WebCore::ContentExtensions::GraphBuilder::hasError):
(WebCore::ContentExtensions::GraphBuilder::fail):
(WebCore::ContentExtensions::GraphBuilder::sinkFloatingTermIfNecessary):
(WebCore::ContentExtensions::URLFilterParser::addPattern):
(WebCore::ContentExtensions::URLFilterParser::statusString):
(WebCore::ContentExtensions::GraphBuilder::errorMessage): Deleted.

contentextensions/URLFilterParser.h:

Use an enum instead of strings for the status to avoid checking strings when we have a regex that matches everything.

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testPattern):
(TestWebKitAPI::TEST_F):
Start testing regex failures.

9:05 PM Changeset in webkit [181725] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

Fix build failure due to FALLTHROUGH in unreachable code
https://bugs.webkit.org/show_bug.cgi?id=142703

Reviewed by Benjamin Poulain.

FALLTHROUGH should not exist in unreachable code marked by
ASSERT_NOT_REACHABLE.

When !ENABLE(CSS_SELECTOR_JIT) and Debug mode is enabled,
both ASSERT_NOT_REACHED and FALLTHROUGH are instantiated
and it cause build failure.

Here, since CompiledSingle/CompiledSingleWithRootFilter are
not set when !ENABLE(CSS_SELECTOR_JIT). So dropping FALLTHROUGH
and leave ASSERT_NOT_REACHED.
And since ASSERT_NOT_ReACHED is stripped when Release build,
I've inserted FALLTHROUGH() if ASSERT_DISABLED.
This fix is the same to r162906.

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute):

8:27 PM Changeset in webkit [181724] by Joseph Pecoraro

5 edits in trunk

ES6 Classes: Extends should accept an expression without parenthesis
https://bugs.webkit.org/show_bug.cgi?id=142840

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
"extends" allows a LeftHandExpression (new expression / call expression,
which includes a member expression), not a primary expression. Our
parseMemberExpression does all of these.

LayoutTests:

js/class-syntax-extends-expected.txt:
js/script-tests/class-syntax-extends.js:

Extend the test to test cases of extends with different types of expressions.

8:26 PM Changeset in webkit [181723] by Joseph Pecoraro

7 edits
1 delete in trunk/Source/WebInspectorUI

Web Inspector: Replace last use of ObjectPropertiesSection with ObjectTreeView
https://bugs.webkit.org/show_bug.cgi?id=142834

Reviewed by Timothy Hatcher.

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Use properties only ObjectTreeView instead of ObjectPropertiesSection.
This doesn't fix the functionality issues, but fixes the appearance.

UserInterface/Views/DetailsSection.css:

(.details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
(body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
(.details-section > .content > .group > .row.properties:not(.empty)): Deleted.
(body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)): Deleted.
Re-add back the small padding at the top of sections. This actually
broke padding in a few sections (Event Listeners) at the expense
of eliminating a few pixels of whitespace at the top of other sections.
We should focus on addressing the extra whitespace separately.

UserInterface/Main.html:
UserInterface/Views/ObjectPropertiesSection.js: Removed.
UserInterface/Views/TypePropertiesSection.js:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Remove new unused class.

8:26 PM Changeset in webkit [181722] by Joseph Pecoraro

7 edits in trunk/Source

Web Inspector: Debugger Popovers and Probes should use FormattedValue/ObjectTreeView instead of Custom/ObjectPropertiesSection
https://bugs.webkit.org/show_bug.cgi?id=142830

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
Give Probe Samples object previews.

Source/WebInspectorUI:

UserInterface/Views/ProbeSetDataGrid.css:

(.details-section.probe-set .data-grid .object-tree > :matches(.title, .object-preview)::before):
Another line-height fix for object tree disclosure triangles.

UserInterface/Views/ProbeSetDataGridNode.js:

(WebInspector.ProbeSetDataGridNode.prototype.createCellContent):
Create an ObjectTree / FormattedValue for the RemoteObject.

UserInterface/Views/SourceCodeTextEditor.css:

(.popover .debugger-popover-content > .title):
(.popover .debugger-popover-content > .body):
(.popover .debugger-popover-content.function > .body):
Be more specific and don't accidentally style ".title" within the body.

UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
Show a properties only ObjectTree instead of an ObjectPropertiesSection.

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForString): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForRegExp): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForNumber): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForBoolean): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForNull): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForUndefined): Deleted.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverWithFormattedValue):
Reduce most of these to a single popover for formatted values.

7:16 PM Changeset in webkit [181721] by Simon Fraser

2 edits in trunk/Source/WebKit2

Don't paint PDFs on every scroll
https://bugs.webkit.org/show_bug.cgi?id=142857
rdar://problem/20130207

Reviewed by Tim Horton.

Don't push a scale factor onto the PDF layer controller if it hasn't
changed, since doing so causes a repaint.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):

7:15 PM Changeset in webkit [181720] by commit-queue@webkit.org

5 edits
2 adds in trunk

Switching between two SVG images with no intrinsic sizes causes them to get the default SVG size instead of the container size.
https://bugs.webkit.org/show_bug.cgi?id=142805.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-03-18
Reviewed by Darin Adler.
Source/WebCore:

The bug happens due to wrong logic in RenderImage::imageDimensionsChanged().
This function decides to setNeedsLayout() if the intrinsic size of the image
changes. If the size does not change, it only repaints the image rectangle.
When switching the src of the an image between two SVG images and both of
them have no intrinsic size, we do not updateInnerContentRect() and this
means an SVGImageForContainer is not going to be created for this image.
When the image is drawn, it is drawn directly from the SVGImage. And this
means the drawing has to be scaled by container_size / SVG_default_intrinsic_size

After figuring out that I need to updateInnerContentRect() to fix this bug,
I found out Blink has already changed this code to do the same thing. But
they also did more clean-up in this function. Here is the link
https://codereview.chromium.org/114323004. I think their change seems correct
although they did not say what exactly they were trying to fix.

The plan for repaintOrMarkForLayout(), which is the new name of this function,
is the following:

-- setNeedLayout() if the intrinsic size changes and it affects the size

of the image.

-- updateInnerContentRect() if the intrinsic size did not change but the

image has exiting layout.

-- repaint the image rectangle if layout is not needed.

This change also removes the call to computeLogicalWidthInRegion(), which is
almost running a layout for the image. This call figures out whether the image
needs to setNeedsLayout(). This call is unnecessary; the image needs to run a
layout if the intrinsic size has changed and it affects the size of the image.

Test: svg/as-image/svg-no-intrinsic-size-switching.html

rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange): Change the function call.
(WebCore::RenderImage::imageChanged): Rename local variable and change the
function call.

(WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Simplify this function.
Call setIntrinsicSize() with the new size unless the image is in error state.

(WebCore::RenderImage::repaintOrMarkForLayout): This a better name for this
function since it is called even if the intrinsic size was not changed.
(WebCore::RenderImage::imageDimensionsChanged): Deleted.

rendering/RenderImage.h: Rename imageDimensionsChanged() and change the

updateIntrinsicSizeIfNeeded() to return void.

rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint): Code cleanup. This function can
only handle the paint phases PaintPhaseForeground and PaintPhaseSelection.
Use this information to simplify the logic and order of painting there.

LayoutTests:

svg/as-image/svg-no-intrinsic-size-switching-expected.html: Added.
svg/as-image/svg-no-intrinsic-size-switching.html: Added.

Ensure that switching the source of an <img> element between two SVG images,
which have no intrinsic sizes, gets the image the size of the container and
not the default SVG intrinsic size which is 300x150 pixels.

6:28 PM Changeset in webkit [181719] by bshafiei@apple.com

2 edits in tags/Safari-601.1.23.2/Source/WebCore

Merged r181713. rdar://problem/20178504

6:25 PM Changeset in webkit [181718] by bshafiei@apple.com

5 edits in tags/Safari-601.1.23.2/Source

Versioning.

6:10 PM Changeset in webkit [181717] by diorahman@rockybars.com

4 edits in trunk

Source/WTF:
Fix StringView misplaced implementations after r181525 and r181558
https://bugs.webkit.org/show_bug.cgi?id=142772

Reviewed by Darin Adler.

Fix misplaced implementations in StringView::startsWithIgnoringASCIICase and
StringView::endsWith.

Add some tests in [1] to cover the StringView::startsWith,
StringView::startsWithIgnoringASCIICase, StringView::endsWith and
StringView::endsWithIgnoringASCIICase implementations.

[1] Tools/TestWebKitAPI/Tests/WTF/StringView.cpp.

wtf/text/StringView.cpp:

(WTF::StringView::startsWithIgnoringASCIICase):
(WTF::StringView::endsWith):
(WTF::StringView::endsWithIgnoringASCIICase):

Tools:
Fix StringView typos after r181525 and r181558
https://bugs.webkit.org/show_bug.cgi?id=142772

Reviewed by Darin Adler.

Add some tests in [1] to cover the StringView::startsWith,
StringView::startsWithIgnoringASCIICase, StringView::endsWith and
StringView::endsWithIgnoringASCIICase implementations.

TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

5:49 PM Changeset in webkit [181716] by bshafiei@apple.com

1 copy in tags/Safari-601.1.23.2

New tag.

5:14 PM Changeset in webkit [181715] by dburkart@apple.com

2 edits in trunk/Tools

Remove extraneous import to fix the build.

Unreviewed.

5:01 PM Changeset in webkit [181714] by dburkart@apple.com

2 edits in trunk/Tools

ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
https://bugs.webkit.org/show_bug.cgi?id=142547

Reviewed by Alexey Proskuryakov.

4:35 PM Changeset in webkit [181713] by jeremyj-wk@apple.com

2 edits in trunk/Source/WebCore

Fix typo in playerViewControllerWillCancelOptimizedFullscree.
https://bugs.webkit.org/show_bug.cgi?id=142745

Reviewed by Darin Adler.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController playerViewControllerWillCancelOptimizedFullscreen:]):
(-[WebAVPlayerController playerViewControllerWillCancelOptimizedFullscree:]): Deleted.

4:29 PM Changeset in webkit [181712] by ap@apple.com

2 edits in trunk/LayoutTests

webaudio/convolution-mono-mono.html fails on some machines
rdar://problem/19996807

Rubber-stampted by Jer Noble.

webaudio/resources/convolution-testing.js: (checkTriangularPulse): Slightly increase

the tolerance. It's still extremely low.

3:39 PM Changeset in webkit [181711] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Use && instead of & when deciding if the network cache should be cleared
https://bugs.webkit.org/show_bug.cgi?id=142845

Reviewed by Antti Koivisto.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteData):

3:17 PM Changeset in webkit [181710] by Simon Fraser

5 edits
2 adds in trunk

Avoid repaints when changing transform on an element with multiple background images
https://bugs.webkit.org/show_bug.cgi?id=142841

Reviewed by Zalan Bujtas.

Source/WebCore:

Replace the cheap test for changed images in RenderElement::updateFillImages()
with an exhaustive test that walks the entire list of background images,
since any ensuing repaint is way more expensive than a slightly more expensive check here.

Test: fast/repaint/multiple-backgrounds-style-change.html

rendering/RenderElement.cpp:

(WebCore::RenderElement::updateFillImages):

rendering/style/FillLayer.cpp:

(WebCore::layerImagesIdentical): See if both images are the same (either none
or both mask images, and same image pointer).
(WebCore::FillLayer::imagesIdentical): Walk the two FillLayer lists, checking the images
on each one. Returns false if we reach the end of one list before the other, or the images
are different.

rendering/style/FillLayer.h: New static function; static because

it compares two FillLayer lists, and I think that makes more sense than
a member function.

LayoutTests:

Test that changes transform on a composited element with 2 background images,
and tests for no repaints.

fast/repaint/multiple-backgrounds-style-change-expected.txt: Added.
fast/repaint/multiple-backgrounds-style-change.html: Added.

2:06 PM Changeset in webkit [181709] by andersca@apple.com

2 edits in trunk/Source/WebCore

Pass cookies by reference in CookieHash functions
https://bugs.webkit.org/show_bug.cgi?id=142839

Reviewed by Sam Weinig.

platform/Cookie.h:

(WebCore::CookieHash::hash):
(WebCore::CookieHash::equal):

1:42 PM Changeset in webkit [181708] by ap@apple.com

2 edits in trunk/Tools

Tweak how AppleSystemFontOSSubversion default is added
https://bugs.webkit.org/show_bug.cgi?id=142835

Reviewed by Dan Bernstein.

DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting):

12:54 PM Changeset in webkit [181707] by andersca@apple.com

11 edits
2 copies in trunk/Source/WebKit2

Add WKContextGetWebsiteDataStore API
https://bugs.webkit.org/show_bug.cgi?id=142832
rdar://problem/16544715

Reviewed by Sam Weinig.

Also add WKWebsiteDataStoreRef which is toll-free bridged to _WKWebsiteDataStore.

Shared/API/c/WKBase.h:

Add new declaration.

UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::create):

UIProcess/API/APIWebsiteDataStore.h:

Add a new function that takes a configuration.

UIProcess/API/C/WKAPICast.h:

Add cast.

UIProcess/API/C/WKContext.cpp:

(WKContextGetWebsiteDataStore):
Return the context's website data store.

UIProcess/API/C/WKContext.h:

Add new declaration.

UIProcess/API/C/WKWebsiteDataStoreRef.cpp: Added.
UIProcess/API/C/WKWebsiteDataStoreRef.h: Added.

Add new files.

UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
Update now that WebProcessPool holds on to an API::WebsiteDataStore.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::createWebPage):

UIProcess/WebProcessPool.h:

WebProcessPool should hold on to an API::WebsiteDataStore instead of a WebKit::WebsiteDataStore.

WebKit2.xcodeproj/project.pbxproj:

Add new files.

12:07 PM Changeset in webkit [181706] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Temporarily fix the !ENABLE(CSS_SELECTOR_JIT) and assertions-enabled build

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute):

11:40 AM Changeset in webkit [181705] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Cannot invoke action menus anymore
https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

UIProcess/API/mac/WKView.mm:

Need one more respondsToSelector check.

11:30 AM Changeset in webkit [181704] by Joseph Pecoraro

8 edits
1 delete in trunk/Source/WebInspectorUI

Web Inspector: Scopes sidebar should use new ObjectTreeView and not ObjectPropertiesSection
https://bugs.webkit.org/show_bug.cgi?id=142808

Reviewed by Timothy Hatcher.

UserInterface/Models/PropertyPath.js:

(WebInspector.PropertyPath):
(WebInspector.PropertyPath.emptyPropertyPathForScope):
Allow a special property empty path for "Scopes". This way for a
"<scopeObject>.property" we can show just the tooltip "property".

UserInterface/Views/ObjectTreeView.css:

(.object-tree.properties-only > :matches(.title, .object-preview)):
(.object-tree.properties-only .object-tree-outline):
(.object-tree.properties-only .object-tree-property .property-name):
Tweak styles for only properties view, which won't have a top-level
preview and doesn't fade out enumerable properties.

UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype.get treeOutline):
Access the TreeOutline.

(WebInspector.ObjectTreeView.prototype.showOnlyProperties):
Properties only view modifies the display slightly.

(WebInspector.ObjectTreeView.prototype.appendExtraPropertyDescriptor):
(WebInspector.ObjectTreeView.prototype._updateProperties):
Allow the client to add its own property descriptors to display
as a property in this ObjectTreeView.

UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
Switch to using an ObjectTreeView.

(WebInspector.ScopeChainDetailsSidebarPanel.prototype._propertyPathIdentifierForTreeElement):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._objectTreeAddHandler):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._objectTreeExpandHandler):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._objectTreeCollapseHandler):
Keep track of what properties were expanded so we can auto-expand
them again when the sidebar refreshes.

UserInterface/Main.html:
UserInterface/Views/ScopeVariableTreeElement.js: Removed.
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Remove the now unused ScopeVariableTreeElement.js.

11:12 AM Changeset in webkit [181703] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

Call CTFontSetRenderingParameters before rendering text
https://bugs.webkit.org/show_bug.cgi?id=142816

Reviewed by Darin Adler.

No new tests.

platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showGlyphsWithAdvances):

platform/spi/cocoa/CoreTextSPI.h:

10:50 AM Changeset in webkit [181702] by Chris Dumez

5 edits in trunk/Source

[WK2] Log the number of network cache requests that we have never seen before
https://bugs.webkit.org/show_bug.cgi?id=142828
<rdar://problem/19632130>

Reviewed by Antti Koivisto.

Source/WebCore:

Add diagnostic logging key for network cache efficacy logging.

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
(WebCore::DiagnosticLoggingKeys::requestKey):

page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Log the number of network cache requests that we have never seen before
using diagnostic logging.

NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm:

(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):

10:40 AM Changeset in webkit [181701] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed GTK Gardening 18th March
https://bugs.webkit.org/show_bug.cgi?id=142824

Unreviewed.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-18

platform/gtk/TestExpectations:

10:40 AM Changeset in webkit [181700] by Antti Koivisto

6 edits in trunk/Source/WebKit2

Prune least valuable cache entries first
https://bugs.webkit.org/show_bug.cgi?id=142810
rdar://problem/19632130

Reviewed by Darin Adler.

When pruning the cache estimate relative value of each entry using formula

age = current time - creation time
accessAge = last access time - creation time
value = accessAge / age

That is, we value entries that have been accessed recently and survived in the cache longest.

The most valuable entries don't get deleted at all while the deletion probablity ramps up for
lower value entries.

NetworkProcess/cache/NetworkCacheFileSystemPosix.h:

(WebKit::NetworkCache::fileTimes):

Get the creation time and access time for a file.

(WebKit::NetworkCache::updateFileAccessTimeIfNeeded):

Update access time manually if the file system doesn't do it automatically.

NetworkProcess/cache/NetworkCacheIOChannel.h:

(WebKit::NetworkCache::IOChannel::path):
(WebKit::NetworkCache::IOChannel::type):

NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:

(WebKit::NetworkCache::IOChannel::IOChannel):
(WebKit::NetworkCache::IOChannel::open):

Remember the file path and move most of the work to constructor.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::updateFileAccessTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::deletionProbability):

Compute the probability based on entry age and access time.

(WebKit::NetworkCache::Storage::shrinkIfNeeded):

NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::serialBackgroundIOQueue):
(WebKit::NetworkCache::Storage::deleteQueue): Deleted.

More generic name.

10:27 AM Changeset in webkit [181699] by Yusuke Suzuki

4 edits
4 adds in trunk

Use filterRootId in SelectorQuery even if CSS JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=142703

Reviewed by Benjamin Poulain.

Source/WebCore:

filterRootId pruning path is not inherently related to CSS JIT.
This patch enables filterRootId even in the environment
where CSS JIT is not enabled.

dom/SelectorQuery.cpp:

(WebCore::filterRootById):
(WebCore::SelectorDataList::executeSingleSelectorData):
(WebCore::SelectorDataList::execute):

dom/SelectorQuery.h:

LayoutTests:

This is covered by the following layout-tests.
CompilableSingleWithRootFilter and CompilableSingle are covered by them.

fast/selectors/filter-root-node-with-selector-contains-adjacents.html
fast/selectors/querySelector-id-filtering.html
fast/selectors/querySelector-scope-filtered-root.html

And add tests to cover the following cases.

Failures on selectorForIdLookup()'s rootNode.inDocument().
Failures on selectorForIdLookup()'s rootNode.document().inQuirksMode().

fast/selectors/querySelector-with-id-for-detached-element-expected.txt: Added.
fast/selectors/querySelector-with-id-for-detached-element.html: Added.
fast/selectors/querySelector-with-id-in-quirks-mode-expected.txt: Added.
fast/selectors/querySelector-with-id-in-quirks-mode.html: Added.

9:51 AM Changeset in webkit [181698] by Alan Bujtas

3 edits in trunk/Source/WebCore

Simple line layout: Use Vector<>::const_iterator instead of custom FlowContents::Iterator.
https://bugs.webkit.org/show_bug.cgi?id=142809

Reviewed by Antti Koivisto.

FlowContents::Iterator simply iterates on a vector<>. No need to custom implement it.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::begin):
(WebCore::SimpleLineLayout::FlowContents::end):
(WebCore::SimpleLineLayout::FlowContents::Iterator::Iterator): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator++): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator--): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator==): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator!=): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator->): Deleted.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

9:47 AM Changeset in webkit [181697] by Alan Bujtas

4 edits in trunk/Source/WebCore

Simple line layout: Change FlowContents::segmentForPosition() to segmentForRun().
https://bugs.webkit.org/show_bug.cgi?id=142785

Reviewed by Antti Koivisto.

This is in transition to support <br>. A particular position could point to multiple
segments when <br> is directly followed by text.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::segmentIndexForRunSlow):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow): Deleted.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::segmentForRun):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition): Deleted.
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition): Deleted.

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

9:27 AM Changeset in webkit [181696] by mitz@apple.com

2 edits in trunk/Tools

prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
https://bugs.webkit.org/show_bug.cgi?id=142815

Reviewed by Darin Adler.

Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
quotation mark, use new variable $quotation_mark to remember what we are looking for, and
keep consuming the quoted text until the matching quotation mark is reached. Emit the
warning only if a line ends without a backslash before the matching quotation mark was found.

9:22 AM Changeset in webkit [181695] by Simon Fraser

2 edits in trunk/Source/WebCore

Skip trying to paint overlay scrollbars when there are none or they are clipped out
https://bugs.webkit.org/show_bug.cgi?id=142811
rdar://problem/20200725

Reviewed by Darin Adler.

In some content with lots of layers and overflow:scroll, we could spend 20% of
the time under paintOverflowControlsForFragments() setting up an (empty) clip,
and then trying to draw scrollbars that we don't have.

Avoid calling paintOverflowControlsForFragments() if there are no scrollbars,
and don't both setting up an empty clip just to paint nothing.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintOverflowControlsForFragments):

9:15 AM Changeset in webkit [181694] by peavo@outlook.com

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build fix after r181665.

platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::setSize):

8:56 AM Changeset in webkit [181693] by commit-queue@webkit.org

5 edits in trunk

Remove unused "preprocessor" parameter to sub-CodeGenerators
https://bugs.webkit.org/show_bug.cgi?id=142793

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-18
Reviewed by Darin Adler.

Source/WebCore:

bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

bindings/scripts/CodeGeneratorObjC.pm:

Tools:

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):

7:48 AM Changeset in webkit [181692] by Alan Bujtas

7 edits
2 adds in trunk

Simple line layout: Split fragments on renderer boundary on the fly.
https://bugs.webkit.org/show_bug.cgi?id=142579

Reviewed by Antti Koivisto.

Fragment splitting at renderers' boundary at the end of the line is no longer needed.
This patch ensures that TextFragmentIterator::nextTextFragment() does not concatenate
fragments across renderer boundary.

Source/WebCore:

Test: fast/text/simple-line-with-multiple-renderers.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::revertRuns):
(WebCore::SimpleLineLayout::LineState::isEmpty):
(WebCore::SimpleLineLayout::LineState::appendFragmentAndCreateRunIfNeeded): Check if fragments need a new run and
whether neighboring fragments need collapsing.
(WebCore::SimpleLineLayout::LineState::revertUncommitted): Revert fragments over multiple renderers if they form
a fragment continuation.
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::forceFragmentToLine): Ensure that if a fragment has continuation across multiple renderers,
they all get added to the current line.
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::LineState::appendFragment): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::FragmentForwardIterator): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator++): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator!=): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator*): Deleted.
(WebCore::SimpleLineLayout::begin): Deleted.
(WebCore::SimpleLineLayout::end): Deleted.
(WebCore::SimpleLineLayout::preWrap): Deleted.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::updateLineConstrains): Deleted.
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary): Deleted.
(WebCore::SimpleLineLayout::createTextRuns): Deleted.
(WebCore::SimpleLineLayout::create): Deleted.
(WebCore::SimpleLineLayout::Layout::create): Deleted.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::Iterator::operator+):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator->):

rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Unrelated fix on non-collapsed tab position.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):
(WebCore::SimpleLineLayout::TextFragmentIterator::nextTextFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::revertToFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::overlapsToNextRenderer):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::isCollapsible):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::operator==):
(WebCore::SimpleLineLayout::TextFragmentIterator::isLineBreak):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split): Deleted.

LayoutTests:

fast/text/simple-line-with-multiple-renderers-expected.html: Added.
fast/text/simple-line-with-multiple-renderers.html: Added.

6:47 AM Changeset in webkit [181691] by Manuel Rego Casasnovas

11 edits
4 adds in trunk

Flex and grid items should be painted as inline-blocks
https://bugs.webkit.org/show_bug.cgi?id=142266

Reviewed by Darin Adler.

Source/WebCore:

Based on Blink r157004 by <cbiesinger@chromium.org>.
https://src.chromium.org/viewvc/blink?revision=157004&view=revision

Both flexbox and grid specs define that the painting order of flex/grid
items is the same as inline blocks. See
http://dev.w3.org/csswg/css-flexbox/#painting and
http://dev.w3.org/csswg/css-grid/#z-order.

Extracted inline blocks painting code from InlineElementBox and moved to
a helper method that will be reused for flexboxes and grids.

Tests: css3/flexbox/flex-item-text-background-not-interleaved.html

fast/css-grid-layout/grid-item-text-background-not-interleaved.html

rendering/InlineElementBox.cpp:

(WebCore::InlineElementBox::paint): Move code to
RenderElement::paintAsInlineBlock().

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChild): Add new argument to paint children
as inline blocks.

rendering/RenderBlock.h: Define PaintType enmu and modify paintChild()

signature to add the new argument.

rendering/RenderElement.cpp:

(WebCore::paintPhase): Paint element in a phase.
(WebCore::RenderElement::paintAsInlineBlock): Code extracted from
InlineElementBox::paint().

rendering/RenderElement.h: Add new method signature.
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::paintChildren): Call
RenderBlock::paintChild() with the new argument.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::paintChildren): Ditto.

LayoutTests:

css3/flexbox/flex-item-text-background-not-interleaved-expected.html: Added.
css3/flexbox/flex-item-text-background-not-interleaved.html: Added.
fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html:

Add some vertical space to avoid issues with backgrounds.

fast/css-grid-layout/float-not-protruding-into-next-grid-item.html:

Ditto.

fast/css-grid-layout/grid-item-text-background-not-interleaved-expected.html: Added.
fast/css-grid-layout/grid-item-text-background-not-interleaved.html: Added.

6:21 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

3:47 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

2:32 AM Changeset in webkit [181690] by Csaba Osztrogonác

3 edits
1 add
1 delete in trunk/Tools

[EFL] Bump gstreamer version to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=142782

Reviewed by Philippe Normand.

efl/jhbuild.modules:
efl/patches/gst-libav.patch:
efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.

2:31 AM March 2015 Meeting edited by jfernandez@igalia.com

(diff)

1:51 AM March 2015 Meeting edited by adam.bergkvist@ericsson.com

(diff)

1:48 AM webrtc_in_webkit_2015.pdf attached to March 2015 Meeting by adam.bergkvist@ericsson.com

Slides from the WebRTC session at the 2015 WebKit contributors meeting

12:27 AM Changeset in webkit [181689] by Chris Dumez

7 edits in trunk/Source

[WK2] Log total number of network cache queries using diagnostic logging
https://bugs.webkit.org/show_bug.cgi?id=142803
<rdar://problem/19632130>

Reviewed by Antti Koivisto.

Source/WebCore:

Add diagnostic logging key needed for network efficacy logging.

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::retrievalRequestKey):

page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Log total number of network cache queries using diagnostic logging.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):

NetworkProcess/cache/NetworkCacheStatistics.h:
NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm:

(WebKit::NetworkCache::Statistics::recordCacheRetrievalRequest):

12:26 AM Changeset in webkit [181688] by Chris Dumez

5 edits in trunk/Source/WebKit2

[WK2] We should not even try the network cache for non-HTTP protocol requests
https://bugs.webkit.org/show_bug.cgi?id=142802
<rdar://problem/19632130>

Reviewed by Antti Koivisto.

We should not even try the network cache for non-HTTP protocol requests
and the network cache cannot handle those.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canRetrieve):
(WebKit::NetworkCache::Cache::retrieve):

NetworkProcess/cache/NetworkCache.h:
NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm:

(WebKit::NetworkCache::retrieveDecisionToDiagnosticKey):

12:19 AM Changeset in webkit [181687] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Fix the build after r181660

page/EventHandler.cpp:

(WebCore::EventHandler::setImmediateActionStage):

page/EventHandler.h:

(WebCore::EventHandler::setImmediateActionStage):
Un-inline setImmediateActionStage, because it is exported to WebCore, and
exporting inline thing causes random weak symbol errors on some platforms.

12:05 AM Changeset in webkit [181686] by Conrad Shultz

6 edits in trunk/Source

Ignore some deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=142813

Reviewed by Mark Rowe.

Fixing the deprecations is tracked by: <rdar://problem/20201450>

Source/WebCore:

editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

Source/WebKit/mac:

WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

Source/WebKit2:

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):

Mar 17, 2015:

11:09 PM Changeset in webkit [181685] by commit-queue@webkit.org

9 edits
2 deletes in trunk

Unreviewed, rolling out r181667, r181682, and r181683.
https://bugs.webkit.org/show_bug.cgi?id=142812

Broke multiple tests with ASan, plus dependent commits
(Requested by ap on #webkit).

Reverted changesets:

"Simple line layout: Split fragments on renderer boundary on
the fly."
https://bugs.webkit.org/show_bug.cgi?id=142579
http://trac.webkit.org/changeset/181667

"Simple line layout: Change FlowContents::segmentForPosition()
to segmentForRun()."
https://bugs.webkit.org/show_bug.cgi?id=142785
http://trac.webkit.org/changeset/181682

"Simple line layout: Use Vector<>::const_iterator instead of
custom FlowContents::Iterator."
https://bugs.webkit.org/show_bug.cgi?id=142809
http://trac.webkit.org/changeset/181683

10:38 PM Changeset in webkit [181684] by ap@apple.com

3 edits in trunk/LayoutTests

fast/images/animated-png.html is crashing / failing on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=142726

Further tweaked test expectations.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

9:00 PM Changeset in webkit [181683] by Alan Bujtas

3 edits in trunk/Source/WebCore

Simple line layout: Use Vector<>::const_iterator instead of custom FlowContents::Iterator.
https://bugs.webkit.org/show_bug.cgi?id=142809

Reviewed by Antti Koivisto.

FlowContents::Iterator simply iterates on a vector<>. No need to custom implement it.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.h:

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

8:40 PM Changeset in webkit [181682] by Alan Bujtas

4 edits in trunk/Source/WebCore

Simple line layout: Change FlowContents::segmentForPosition() to segmentForRun().
https://bugs.webkit.org/show_bug.cgi?id=142785

Reviewed by Antti Koivisto.

This is in transition to support <br>. A particular position could point to multiple
segments when <br> is directly followed by text.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::segmentIndexForRunSlow):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow): Deleted.

rendering/SimpleLineLayoutFlowContents.h:

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

7:42 PM Changeset in webkit [181681] by ryuan.choi@navercorp.com

12 edits
1 copy
3 adds in trunk

[EFL] Expose JavaScript binding interface through ewk_extension
https://bugs.webkit.org/show_bug.cgi?id=142033

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake: Added HEADER_INSTALL_DIR variable.

Source/JavaScriptCore:

PlatformEfl.cmake: Install Javascript APIs.

Source/WebKit2:

PlatformEfl.cmake:
UIProcess/API/efl/tests/extensions/extension_sample.cpp: Registered test object for new test case.
UIProcess/API/efl/tests/test_ewk2_javascript_binding.cpp: Added simple binding API test case.

(EWK2ContextTestWithExtension::messageReceivedCallback):
(EWK2ContextTestWithExtension::EWK2ContextTestWithExtension):
(TEST_F):

WebProcess/InjectedBundle/API/efl/EWebKit_Extension.h:
WebProcess/InjectedBundle/API/efl/ewk_extension.cpp:

(EwkExtension::didCreatePage):
(EwkExtension::willDestroyPage):

WebProcess/InjectedBundle/API/efl/ewk_extension.h:
WebProcess/InjectedBundle/API/efl/ewk_extension_private.h:
WebProcess/InjectedBundle/API/efl/ewk_page.cpp: Added.

(toEwkPage):
(EwkPage::EwkPage):
(EwkPage::append):
(EwkPage::remove):
(EwkPage::didFinishDocumentLoadForFrame):
(ewk_page_js_global_context_get):
(ewk_page_client_register):
(ewk_page_client_unregister):

WebProcess/InjectedBundle/API/efl/ewk_page.h: Added.
WebProcess/InjectedBundle/API/efl/ewk_page_private.h: Added.

(EwkPage::page):

efl/ewebkit2-extension.pc.in:

6:50 PM Changeset in webkit [181680] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Tracked down the tests that were leaving the page cache in a bad state.
By skipping those tests, we can run all the others. These bugs are being
investigated in Bug 140871.

platform/win/TestExpectations:

6:34 PM Changeset in webkit [181679] by timothy_horton@apple.com

4 edits in trunk/Source

Cannot invoke action menus anymore
https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

UIProcess/API/mac/WKView.mm:

Need a respondsToSelector check.

WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
Need a respondsToSelector check.

6:32 PM Changeset in webkit [181678] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Versioning.

6:21 PM Changeset in webkit [181677] by timothy_horton@apple.com

2 edits in trunk/Tools

Fix the iOS build.

WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

6:21 PM Changeset in webkit [181676] by bshafiei@apple.com

1 copy in tags/Safari-600.5.15

New tag.

6:13 PM Changeset in webkit [181675] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger Sidebar Icons Misaligned
https://bugs.webkit.org/show_bug.cgi?id=142654

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Timothy Hatcher.

The debugger sidebar content was accidentally 1px too small. The
TreeOutline being inside of a .detail-section was getting a smaller
font-size. We should just have the normal font-size for the
debugger navigation sidebar. This matches the Resources sidebar
in the TreeOutline, and icons line up better.

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .details-section):

5:41 PM Changeset in webkit [181674] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

Fix the iOS build

WebView/WebHTMLView.mm:

5:07 PM Changeset in webkit [181673] by ggaren@apple.com

17 edits in trunk

Function bodies should always include braces
https://bugs.webkit.org/show_bug.cgi?id=142795

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Having a mode for excluding the opening and closing braces from a function
body was unnecessary and confusing.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Adopt the new one true linking function.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::codeBlockFor): No need to pass through
a boolean: there is only one kind of function now.

(JSC::UnlinkedFunctionExecutable::linkInsideExecutable): Deleted.
(JSC::UnlinkedFunctionExecutable::linkGlobalCode): Deleted. Let's only
have one way to do things. This removes the old mode that would pretend
that a function always started at column 1. That pretense was not true:
an attribute event listener does not necessarily start at column 1.

bytecode/UnlinkedCodeBlock.h:
generate-js-builtins: Adopt the new one true linking function.

parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse): needsReparsingAdjustment is always true now, so I removed it.

runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):
(JSC::FunctionExecutable::fromGlobalCode):

runtime/Executable.h:

(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::bodyIncludesBraces): Deleted. Removed unused stuff.

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck): Always provide a
leading space because that's what this function's comment says is required
for web compatibility. We used to fake this up after the fact when
stringifying, based on the bodyIncludesBraces flag, but that flag is gone now.

runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString): No need to add braces and/or a space
after the fact -- we always have them now.

LayoutTests:

Updated these test results to reflect the fact that JavaScriptCore now
honors the source code text positions provided by WebCore, even for
attribute event handlers.

Unfortunately, the column numbers we used to report were wrong, and they
are still wrong now. The old column numbers were wrong because we would
always pretend that they started on column 1. The new column numbers
are wrong because WebCore records the column number after it finishes
parsing the element, rather than while it is parsing the event listener
attribute.

fast/events/window-onerror2-expected.txt:
fast/profiler/dead-time-expected.txt:
fast/profiler/inline-event-handler-expected.txt:
fast/profiler/stop-profiling-after-setTimeout-expected.txt:
js/dom/script-start-end-locations-expected.txt:

5:03 PM Changeset in webkit [181672] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Removal of multiline completion hint broken in Details sidebar
https://bugs.webkit.org/show_bug.cgi?id=142796

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-03-17
Reviewed by Joseph Pecoraro.

Prioritize CodeMirrorCompletionController over CSSStyleDeclarationTextEditor.
Both classes control the current CodeMirror instance of the Details Sidebar.
This change prevents possible race conditions during complete or delete-complete phases,
especially during operations on multiple styles in one line.

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor):

4:42 PM Changeset in webkit [181671] by Chris Dumez

7 edits
1 copy
1 move
1 add
1 delete in trunk/Source/WebCore

[Mac][iOS] setSharedTimerFireInterval() / stopSharedTimer() are expensive
https://bugs.webkit.org/show_bug.cgi?id=142752
<rdar://problem/20176731>

Reviewed by Antti Koivisto.

setSharedTimerFireInterval() / stopSharedTimer() are expensive on Mac
and iOS on pages using a lot of timers.

For example, on bing.com / iOS, ~15.4% of the CPU time is spent in
setSharedTimerFireInterval() and ~14.7% of the CPU time is spent in
stopSharedTimer(). The expensive calls are CFRunLoopAddTimer (11.4%),
CFRunLoopTimerInvalidate (14.1%), CFRunLoopTimerCreate (3.3%).

The issue is that we keep creating, adding to run loop modes, and then
destroying the sharedTimer for each firing event. This is very
expensive. In such case, the CFRunLoopTimerRef documentation advises to
"""
... create a repeating timer with an initial firing time in the distant
future (or the initial firing time) and a very large repeat interval—on
the order of decades or more—and add it to all the necessary run loop
modes. Then, when you know when the timer should fire next, you reset
the firing time with CFRunLoopTimerSetNextFireDate, perhaps from the
timer’s own callback function. This technique effectively produces a
reusable, asynchronous timer.
""" [1].

Doing so greatly decreases CPU time spend in:

setSharedTimerFireInterval(): 15.4% -> 4.6%
stopSharedTimer(): 14.6% -> 8.6%

Overall CPU time spent on bing.com in timerFired() goes down from
~61.2% to ~49.5%.

This patch also refactors the SharedTimer code to share as much as
possible between Mac and iOS.

This patch is based in part on the following patch:
http://trac.webkit.org/changeset/143210

[1] https://developer.apple.com/library/prerelease/ios/documentation/CoreFoundation/Reference/CFRunLoopTimerRef/index.html#//apple_ref/c/func/CFRunLoopTimerSetNextFireDate

WebCore.xcodeproj/project.pbxproj:
platform/SharedTimer.h:

(WebCore::SharedTimer::invalidate):
(WebCore::MainThreadSharedTimer::setFiredFunction): Deleted.
(WebCore::MainThreadSharedTimer::setFireInterval): Deleted.
(WebCore::MainThreadSharedTimer::stop): Deleted.

platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::fireTimersInNestedEventLoop):

platform/cf/SharedTimerCF.mm: Added.

(WebCore::applicationDidBecomeActive):
(WebCore::setupPowerObserver):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::restartSharedTimer):
(WebCore::invalidateSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

platform/efl/SharedTimerEfl.cpp:

(WebCore::invalidateSharedTimer):

platform/gtk/SharedTimerGtk.cpp:

(WebCore::invalidateSharedTimer):

platform/ios/SharedTimerIOS.mm: Removed.
platform/mac/PowerObserverMac.h: Copied from Source/WebCore/platform/efl/SharedTimerEfl.cpp.
platform/mac/PowerObserverMac.mm: Renamed from Source/WebCore/platform/mac/SharedTimerMac.mm.

(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):

platform/win/SharedTimerWin.cpp:

(WebCore::removeSharedTimer):

4:06 PM Changeset in webkit [181670] by mark.lam@apple.com

3 edits
2 adds in trunk/Source/JavaScriptCore

Refactor execution time limit tests out of testapi.c.
<https://webkit.org/b/142798>

Rubber stamped by Michael Saboff.

These tests were sometimes failing to time out on C loop builds. Let's
refactor them out of the big monolith that is testapi.c so that we can
reason more easily about them and make adjustments if needed.

API/tests/ExecutionTimeLimitTest.cpp: Added.

(currentCPUTime):
(currentCPUTimeAsJSFunctionCallback):
(shouldTerminateCallback):
(cancelTerminateCallback):
(extendTerminateCallback):
(testExecutionTimeLimit):

API/tests/ExecutionTimeLimitTest.h: Added.
API/tests/testapi.c:

(main):
(currentCPUTime): Deleted.
(currentCPUTime_callAsFunction): Deleted.
(shouldTerminateCallback): Deleted.
(cancelTerminateCallback): Deleted.
(extendTerminateCallback): Deleted.

JavaScriptCore.xcodeproj/project.pbxproj:

3:57 PM Changeset in webkit [181669] by dino@apple.com

3 edits in trunk/Tools

check-webkit-style should allow "bool a : 1"
https://bugs.webkit.org/show_bug.cgi?id=142794

Reviewed by Brent Fulgham.

We should allow member bitfields of the form:

bool m_var : 1;

It seems that Visual Studio 8 was the last compiler that
wasn't happy about not using unsigned here. We already have
about 500 cases (in WebCore) where people were ignoring this rule.

Scripts/webkitpy/style/checkers/cpp.py:

(check_language): Allow "bool".

Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.

(CppStyleTest.test_enum_bitfields):
(CppStyleTest.test_plain_integral_bitfields):

3:48 PM Changeset in webkit [181668] by timothy_horton@apple.com

6 edits in trunk/Source

Cannot invoke action menus anymore
https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

Reviewed by Beth Dakin.

UIProcess/API/mac/WKView.mm:

Don't process mouse events that would make an action menu; call super
and let AppKit take care of it. We have to duplicate the macro so that
we can avoid calling super for the internal-only methods.
Also, otherMouseMoved is simply not a thing, so remove it.

WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
Don't override otherMouseDown: if the event would make an action menu.

platform/spi/mac/NSMenuSPI.h:

Add additional NSMenu SPI.

3:20 PM Changeset in webkit [181667] by Alan Bujtas

7 edits
2 adds in trunk

Simple line layout: Split fragments on renderer boundary on the fly.
https://bugs.webkit.org/show_bug.cgi?id=142579

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/text/simple-line-with-multiple-renderers.html

rendering/SimpleLineLayout.cpp:

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::Iterator::operator+):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator->):

rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Unrelated fix on non-collapsed tab position.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

rendering/SimpleLineLayoutTextFragmentIterator.h:

LayoutTests:

fast/text/simple-line-with-multiple-renderers-expected.html: Added.
fast/text/simple-line-with-multiple-renderers.html: Added.

3:12 PM Changeset in webkit [181666] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

When tab hides, pause fullscreen and exit normally.
https://bugs.webkit.org/show_bug.cgi?id=142685

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-03-17
Reviewed by Eric Carlson.

Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):

2:29 PM Changeset in webkit [181665] by peavo@outlook.com

2 edits in trunk/Source/WebCore

[WinCairo] Video position is incorrect when located inside a frame.
https://bugs.webkit.org/show_bug.cgi?id=142784

Reviewed by Brent Fulgham.

We need to take the enclosing frame's position into account, when finding the video position.

platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::setSize):

2:15 PM Changeset in webkit [181664] by ggaren@apple.com

16 edits in trunk/Source/JavaScriptCore

Built-in functions should know that they use strict mode
https://bugs.webkit.org/show_bug.cgi?id=142788

Reviewed by Mark Lam.

Even though all of our builtin functions use strict mode, the parser
thinks that they don't. This is because Executable::toStrictness treats
builtin-ness and strict-ness as mutually exclusive.

The fix is to disambiguate builtin-ness from strict-ness.

This bug is currently unobservable because of some other parser bugs. But
it causes lots of test failures once those other bugs are fixed.

API/JSScriptRef.cpp:

(parseScript):

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createBuiltinExecutable): Adopt the new API
for a separate value to indicate builtin-ness vs strict-ness.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor): Ditto.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::toStrictness): Deleted. This function
was misleading since it pretended that no builtin function was ever
strict, which is the opposite of true.

parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer):

parser/Lexer.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):

parser/Parser.h:

(JSC::parse): Adopt the new API.

parser/ParserModes.h: Added JSParserBuiltinMode, and tried to give

existing modes clearer names.

runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Adopt the new API.

runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey): Be sure to treat strict-ness and
bulitin-ness as separate pieces of the code cache key. We would not want
a user function to match a built-in function in the cache, even if they
agreed about strictness, since builtin functions have different lexing
rules.

runtime/Completion.cpp:

(JSC::checkSyntax):

runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::checkSyntax):

runtime/Executable.h:

(JSC::FunctionExecutable::create):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock): Adopt the new API.

1:47 PM Changeset in webkit [181663] by benjamin@webkit.org

9 edits in trunk

Compile character ranges targeting the same state as range check in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=142759

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-03-17
Reviewed by Alex Christensen.

Source/WebCore:

Previously, character ranges would be compiled as many individual character checks.
For example, a transition on "[a-z]" would do 26 character checks + jump, which leads
to enormous matchines.

With this patch, we find the ranges at lowering time and generate a single instruction
for them: "CheckValueRange". This helps making the machine denser when the input
use character sets.

The second part of this patch goes further in the case where the transitions out of
a state cover the entire alphabet. In that case, we create a fallback transition
on the fly and remove all the ranges made useless.
That case is common when ranges are used with inverse character set (e.g. [^a]+a).

contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValueRange):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNodeTransitions):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileCheckForRange):

contentextensions/DFABytecodeCompiler.h:

Extend the compiler to detect ranges and lower them as CheckValueRange.

contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Range checks in the interpreter.

contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::setFinal):
This assertion does not make sense with the current codebase. Actions are "compressed",
it is possible to have two patterns with the same action.

contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::simplifyTransitions):
A very simple DFA optimization function: it only reduce the strength of ranges.

(WebCore::ContentExtensions::NFAToDFA::convert):

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

1:28 PM Changeset in webkit [181662] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
https://bugs.webkit.org/show_bug.cgi?id=142787

Reviewed by Eric Carlson.

Null check m_player before derefencing.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

1:22 PM Changeset in webkit [181661] by youenn.fablet@crf.canon.fr

6 edits in trunk/Tools

W3C test parser and converter should use test importer host
https://bugs.webkit.org/show_bug.cgi?id=142729

Reviewed by Bem Jones-Bey.

When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
This enables adding more TestImporter unit testing.
This patch also ensures that the git object instantiated by TestDownloader is using the
same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.copytree): Fixes implementation as it creates a runtime error.

Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
(TestDownloader.checkout_test_repository): Making use of the new git function.

Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests): Adding host as parameter to the parser.
(TestImporter.import_tests): Adding host as parameter to the converter.

Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
(TestImporterTest):
(TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.

Scripts/webkitpy/w3c/test_parser.py:

(TestParser.init): Adding host as parameter constructor.

1:20 PM Changeset in webkit [181660] by Beth Dakin

12 edits in trunk/Source

DOM mouse events have weird timing for force clickable elements in Safari 8.0.3 on
10.10.2
https://bugs.webkit.org/show_bug.cgi?id=142700
-and corresponding-
rdar://problem/20165168

Reviewed by Tim Horton.

Source/WebCore:

This patch adds a new enum and member variable so that EventHandler can keep track
of the current immediate action state.

page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):

A new mouse press even is starting. We can re-set m_immediateActionStage to none
unless a Hit Test has already been performed.
(WebCore::EventHandler::handleMousePressEvent):

If an immediate action was completed, then send mouse to the DOM and return early.
This will prevent us from doing our own normal mouseup behaviors such as
navigating to a link that was clicked — we only want to do that if the click was
not used to perform an immediate action.
(WebCore::EventHandler::handleMouseReleaseEvent):

page/EventHandler.h:

(WebCore::EventHandler::setImmediateActionStage):

Source/WebKit2:

No need to tell the WKImmediateActionController about mouse down any more since we
are expecting it at the beginning of an immediate action interaction.

UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):

Set the delaysPrimaryMouseButtonEvents to NO for the
_immediateActionGestureRecognizer. This will cause AppKit to send up the mouse
events at the expected time.
(-[WKView initWithFrame:processPool:configuration:webView:]):

WebCore::EventHandler now needs to know if an immediate action cancelled or
completed. This plumbs that information down.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::immediateActionDidCancel):
(WebKit::WebPageProxy::immediateActionDidComplete):

UIProcess/WebPageProxy.h:
UIProcess/mac/WKImmediateActionController.h:
UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WKImmediateActionController wkView:willHandleMouseDown:]): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Call EventHandler::setImmediateActionStage() with the appropriate stage.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::immediateActionDidCancel):
(WebKit::WebPage::immediateActionDidComplete):

1:11 PM Changeset in webkit [181659] by dino@apple.com

5 edits in trunk/LayoutTests

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Unreviewed attempt to make the test reproducible.

animations/trigger-container-scroll-simple.html: Add a step-start timing

function so the animation instantly moves to the end position.

12:58 PM Changeset in webkit [181658] by dino@apple.com

2 edits in trunk/Source/WebCore

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Attempt to fix the build.

css/CSSComputedStyleDeclaration.cpp: Add an #if ENABLE guard.

12:39 PM Changeset in webkit [181657] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Use a better parameter name for Document.getElementsByClassName
https://bugs.webkit.org/show_bug.cgi?id=142771

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Chris Dumez.

bindings/objc/PublicDOMInterfaces.h:
dom/Document.idl:

12:15 PM Changeset in webkit [181656] by timothy_horton@apple.com

17 edits
2 adds in trunk

Reproducible null deref under ScriptedAnimationController::createDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=142776
<rdar://problem/18921338>

Reviewed by Alexey Proskuryakov.

Test: fast/animation/request-animation-frame-unparented-iframe-crash.html

In some cases (like the new test), we can end up trying to start
requestAnimationFrame on a Document that has no Page. Most paths null-checked
the Page and did the right thing, but one failed to do so. In addition,
the current fallback (when Page is null) can result in us constructing
the wrong kind of DisplayRefreshMonitor, which could lead to trouble
down the road when it's reused. Instead, just completely avoid making a
DisplayRefreshMonitor in the null-page case.

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor):
If the page is null, bail.

dom/ScriptedAnimationController.h:
platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::create):
Use Optional<> to make it easy to distinguish between ChromeClient
being unreachable (because we don't have a Page for some reason) and
ChromeClient declaring that it doesn't want to override the type of
DisplayRefreshMonitor that is created.

If ChromeClient was unreachable for some reason, we'll get back an engaged
nullptr and return it (instead of creating a DisplayRefreshMonitor based
on the platform). This avoids creating the wrong type of DisplayRefreshMonitor
in the rare case where we can't reach the ChromeClient (e.g. a freshly unparented
IFrame).

If instead the client returns a disengaged Nullopt, we'll interpret that as
"construct the default type", which falls back on the platform #ifdefs to
decide what to make.

platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
Silently handle the case where we failed to make a DisplayRefreshMonitor.

platform/graphics/DisplayRefreshMonitor.h:
platform/graphics/DisplayRefreshMonitorClient.h:
platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::createDisplayRefreshMonitor):

platform/graphics/GraphicsLayerUpdater.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor):

rendering/RenderLayerCompositor.h:

Adjust to the new signature of createDisplayRefreshMonitor, and return
an engaged (nullptr) Optional if we can't get to ChromeClient for any reason.

page/ChromeClient.h:

Return Nullopt (indicating a lack of override) by default.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDisplayRefreshMonitor):

WebProcess/WebCoreSupport/WebChromeClient.h:

Adjust to the new signature.

fast/animation/request-animation-frame-unparented-iframe-crash-expected.txt: Added.
fast/animation/request-animation-frame-unparented-iframe-crash.html: Added.

Add a test that ensures that calling requestAnimationFrame on a recently-unparented
frame doesn't crash.

12:01 PM Changeset in webkit [181655] by dino@apple.com

11 edits
2 adds in trunk

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Reviewed by Simon Fraser.

Source/WebCore:

Test: animations/trigger-container-scroll-simple.html

Basic implementation of container-scroll. It only checks
the page scroll position for trigger values (not the scrolling
container in an overflow).

css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyWebkitAnimationTrigger

so that this property will appear in the inspector.

page/FrameView.cpp:

(WebCore::FrameView::sendScrollEvent): If the page has scrolled, let the animation
controller know about it.

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine): Whitespace fix.
(WebCore::AnimationBase::fireAnimationEventsIfNeeded): If there is a trigger,
and the scroll position is past it, then tell the state machine that
we should start.
(WebCore::AnimationBase::timeToNextService): Use the scroll position as
an input to the update timer if a trigger is involved.

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation): Add whitespace.
(WebCore::AnimationControllerPrivate::scrollWasUpdated): Call updateAnimations.
(WebCore::AnimationController::scrollWasUpdated): Call into AnimationControllerPrivate.

page/animation/AnimationController.h:
page/animation/AnimationControllerPrivate.h:

page/animation/CompositeAnimation.cpp: Keep a record of whether we have a scroll

triggered animation.
(WebCore::CompositeAnimation::CompositeAnimation):
(WebCore::CompositeAnimation::updateKeyframeAnimations):

page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::hasScrollTriggeredAnimation):

platform/animation/Animation.cpp:

(WebCore::Animation::operator=):

LayoutTests:

Test that checks if an animation only triggers when the page
is scrolled.

animations/trigger-container-scroll-simple-expected.txt: Added.
animations/trigger-container-scroll-simple.html: Added.

11:58 AM Changeset in webkit [181654] by Simon Fraser

7 edits in trunk/Source/WebCore

Move some code from LogicalSelectionOffsetCaches into RenderElement
https://bugs.webkit.org/show_bug.cgi?id=142758

Reviewed by Myles C. Maxfield.

LogicalSelectionOffsetCaches had some useful code regarding containing blocks etc
that should be used in more places, so move it into RenderElement.

No behavior change.

rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Deleted.
(WebCore::isNonRenderBlockInline): Deleted.
(WebCore::containingBlockForFixedPosition): Deleted.
(WebCore::containingBlockForAbsolutePosition): Deleted.
(WebCore::containingBlockForObjectInFlow): Deleted.

rendering/RenderBlock.cpp: No need to initialize static data.

(WebCore::RenderBlock::positionedObjects): nullptr

rendering/RenderElement.cpp:

(WebCore::RenderElement::containingBlockForFixedPosition):
(WebCore::RenderElement::containingBlockForAbsolutePosition):
(WebCore::isNonRenderBlockInline):
(WebCore::RenderElement::containingBlockForObjectInFlow):

rendering/RenderElement.h:

(WebCore::RenderElement::canContainAbsolutelyPositionedObjects):

rendering/RenderLayer.cpp:

(WebCore::isContainerForPositioned):

rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

11:54 AM March 2015 Meeting edited by Antti Koivisto

(diff)

11:47 AM Disk cache.pdf attached to March 2015 Meeting by Antti Koivisto

Disk cache slides

11:02 AM Changeset in webkit [181653] by achristensen@apple.com

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build fix after r181640.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Tell Windows how to find ShaderLang.h.

10:50 AM Changeset in webkit [181652] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Skip some IndexDB tests that don't apply on Windows.

platform/win/TestExpectations:

9:09 AM Changeset in webkit [181651] by Antti Koivisto

5 edits
2 adds in trunk

Disk cache should support Vary: Cookie
https://bugs.webkit.org/show_bug.cgi?id=142770
Source/WebKit2:

rdar://problem/19764945

Reviewed by Anders Carlsson.

Cookies are not part of the original request but are added by the networking layer when submitting the request.
Fetch them explicitly when resolving Vary: Cookie.

The implementation is not perfect as it fetches the cookie for the cache entry when saving a Vary:Cookie response,
not when making the request. In principle the cookie may have changed in-between. This should be enough to handle
reasonable cases though. Fetching cookies for every request might be too expensive for this rarely used feature.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::headerValueForVary):
(WebKit::NetworkCache::encodeStorageEntry):
(WebKit::NetworkCache::verifyVaryingRequestHeaders):

LayoutTests:

Reviewed by Anders Carlsson.

http/tests/cache/disk-cache-vary-cookie-expected.txt: Added.
http/tests/cache/disk-cache-vary-cookie.html: Added.

8:50 AM Changeset in webkit [181650] by fpizlo@apple.com

22 edits in trunk/Source/JavaScriptCore

DFG IR shouldn't have a separate node for every kind of put hint that could be described using PromotedLocationDescriptor
https://bugs.webkit.org/show_bug.cgi?id=142769

Reviewed by Michael Saboff.

When we sink an object allocation, we need to have some way of tracking what stores would
have happened had the allocation not been sunk, so that we know how to rematerialize the
object on OSR exit. Prior to this change, trunk had two ways of describing such a "put
hint":

The PutStrutureHint and PutByOffsetHint node types.
The PromotedLocationDescriptor class, which has an enum with cases StructurePLoc and NamedPropertyPLoc.

We also had ways of converting from a Node with those two node types to a
PromotedLocationDescriptor, and we had a way of converting a PromotedLocationDescriptor to
a Node.

This change removes the redundancy. We now have just one node type that corresponds to a
put hint, and it's called PutHint. It has a PromotedLocationDescriptor as metadata.
Converting between a PutHint node and a PromotedLocationDescriptor and vice-versa is now
trivial.

This means that if we add new kinds of sunken objects, we'll have less pro-forma to write
for the put hints to those objects. This is mainly to simplify the implementation of
arguments elimination in bug 141174.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::mergeRelevantToOSR):

dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

dfg/DFGNode.cpp:

(JSC::DFG::Node::convertToPutHint):
(JSC::DFG::Node::convertToPutStructureHint):
(JSC::DFG::Node::convertToPutByOffsetHint):
(JSC::DFG::Node::promotedLocationDescriptor):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasPromotedLocationDescriptor):
(JSC::DFG::Node::convertToPutByOffsetHint): Deleted.
(JSC::DFG::Node::convertToPutStructureHint): Deleted.

dfg/DFGNodeType.h:
dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::run):
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGPromoteHeapAccess.h:

(JSC::DFG::promoteHeapAccess):

dfg/DFGPromotedHeapLocation.cpp:

(JSC::DFG::PromotedHeapLocation::createHint):

dfg/DFGPromotedHeapLocation.h:

(JSC::DFG::PromotedLocationDescriptor::imm1):
(JSC::DFG::PromotedLocationDescriptor::imm2):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

8:48 AM Changeset in webkit [181649] by Chris Dumez

2 edits in trunk/Source/WebCore

'pageLoaded' diagnostic logging is too verbose
https://bugs.webkit.org/show_bug.cgi?id=142727
<rdar://problem/18937048>

Reviewed by Eric Carlson.

Make 'pageLoaded' diagnostic logging less verbose:

Log once per main frame instead of once for subframe
Apply sampling

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

6:37 AM Changeset in webkit [181648] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.7.92

WebKitGTK+ 2.7.92

6:08 AM Changeset in webkit [181647] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.92 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.7.92.

5:39 AM Changeset in webkit [181646] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/po

Merge r181645 - [l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142781

Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2015-03-17
Reviewed by Carlos Garcia Campos.

he.po:

5:38 AM Changeset in webkit [181645] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142781

Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2015-03-17
Reviewed by Carlos Garcia Campos.

he.po:

5:23 AM Changeset in webkit [181644] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181643 - [GTK] Wrong transfer annotations used in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=142780

Reviewed by Gustavo Noronha Silva.

We are using transfer none for all methods returning a GObject DOM
Object. That's not true. Only objects derived from Node are
automatically released by the DOM object cache and can be transfer
none. All other objects are added to the cache only to avoid
creating the same wrapper twice for the same core object, but
caller should release the returned reference.

bindings/gobject/WebKitDOMCustomUnstable.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GetTransferTypeForReturnType):
(GenerateFunction):

5:22 AM Changeset in webkit [181643] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Wrong transfer annotations used in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=142780

Reviewed by Gustavo Noronha Silva.

bindings/gobject/WebKitDOMCustomUnstable.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GetTransferTypeForReturnType):
(GenerateFunction):

5:20 AM WebKitGTK/2.8.x edited by Carlos Garcia Campos

(diff)

5:18 AM Changeset in webkit [181642] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/po

Merge r181639 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142306

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2015-03-17
Reviewed by Carlos Garcia Campos.

pl.po:

5:16 AM Changeset in webkit [181641] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.8

Merge r181631 - [GTK] WebKitDOM objects leaking
https://bugs.webkit.org/show_bug.cgi?id=118788

Reviewed by Darin Adler and Sergio Villar Senin.

Source/WebCore:

Use a DOMwindowObserver class, derived from DOMWindowProperty to
be notified when the window object is detached from the frame to
clear the DOM objects associated to that frame in that case too.

bindings/gobject/DOMObjectCache.cpp:

Tools:

Update DOMObjectCache unit test to check that DOM objects are also
released when new contents are loaded in the web view, and the old
document is detached from the frame.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMObjectCache):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(runTest):

5:14 AM Changeset in webkit [181640] by Carlos Garcia Campos

7 edits
2 adds in releases/WebKitGTK/webkit-2.8/Source

Merge r181629 - [CMake] Use a forwarding header for ANGLE's ShaderLang.h to avoid picking up ANGLE's EGL headers
https://bugs.webkit.org/show_bug.cgi?id=142530

Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE/ShaderLang.h: Added. Includes include/GLSLANG/ShaderLang.h. Used in WebCore

so we can avoid using ANGLE's EGL headers and use the system-default headers instead.

Source/WebCore:

Include the ANGLE's ShaderLang.h through the new forwarding header. This allows
us to not list Source/ThirdParty/ANGLE/include in the list of inclusion directories
and thus avoid ANGLE's EGL and GLES2/GLES3 headers, defaulting to the system-provided
headers instead.

Source/ThirdParty/ANGLE/include/KHR is still used because ANGLE's khrplatform.h is
required by the ShaderLang.h header. Source/ThirdParty/ANGLE/src is not used for the
whole WebCore library anymore, only the ANGLESupport library.

CMakeLists.txt:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Source/WebKit2:

CMakeLists.txt: Replace the Source/ThirdParty/ANGLE/include/GLSLANG entry

in the list of inclusion directories for WebKit2 with Source/ThirdParty/ANGLE,
possible due to the new forwarding header for ANGLE's ShaderLang.h.

4:57 AM Changeset in webkit [181639] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142306

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2015-03-17
Reviewed by Carlos Garcia Campos.

pl.po:

4:48 AM Changeset in webkit [181638] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181620 - REGRESSION(r180924): Unable to build WebKitGTK+ with threaded compositor

Unreviewed build fix.

WebProcess/WebPage/LayerTreeHost.h:

Remove duplicated declaration of setNativeSurfaceHandleForCompositing.

4:47 AM Changeset in webkit [181637] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.8

Merge r181600 - AX: Crash viewing http://www.last.fm/
https://bugs.webkit.org/show_bug.cgi?id=142309

Reviewed by Chris Fleizach.

Source/WebCore:

The crash occurs when a not-yet-rendered object emits a children-changed
signal. If an assistive technology is listening, AT-SPI2 will attempt to
create and cache the state set for the child being added and the creation
of the state set assumes a rendered object.

Test: platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper):

LayoutTests:

This test doesn't verify the absence of the crash because the crash seems
to require that an assistive technology is listening for events, and that
AT-SPI2 is caching the tree for that assistive technology -- something we
cannot count on being the case on our bots. (I suspect that the reason non-
assistive technology users of Epiphany were getting hit by this is because
Caribou was listening for events in the background, thus they were AT users
without realizing it. That Caribou issue is in theory now resolved.) What
this test does verify is the absence of children-changed:add accessibility
signals for non-rendered objects, which is the source of the crash given
the aforementioned environment.

platform/gtk/accessibility/no-notification-for-unrendered-iframe-children-expected.txt: Added.
platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html: Added.

4:46 AM Changeset in webkit [181636] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181599 - ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
https://bugs.webkit.org/show_bug.cgi?id=142637

Reviewed by Dean Jackson.

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginSnapshotTimerFired):

m_plugin can be legitimately null.

4:44 AM Changeset in webkit [181635] by Carlos Garcia Campos

8 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r181570 - [ARM] Enable generating idiv instructions if it is supported
https://bugs.webkit.org/show_bug.cgi?id=142725

Reviewed by Michael Saboff.

Source/JavaScriptCore:

assembler/ARMAssembler.h: Added sdiv and udiv implementation for ARM Traditional instruction set.

(JSC::ARMAssembler::sdiv):
(JSC::ARMAssembler::udiv):

assembler/ARMv7Assembler.h: Use HAVE(ARM_IDIV_INSTRUCTIONS) instead of CPU(APPLE_ARMV7S).
assembler/AbstractMacroAssembler.h:

(JSC::isARMv7IDIVSupported):
(JSC::optimizeForARMv7IDIVSupported):
(JSC::isARMv7s): Renamed to isARMv7IDIVSupported().
(JSC::optimizeForARMv7s): Renamed to optimizeForARMv7IDIVSupported().

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):

Source/WTF:

wtf/Platform.h: Set HAVE_ARM_IDIV_INSTRUCTIONS based on GCC macro too.

4:43 AM Changeset in webkit [181634] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181565 - URLs visited during private browsing show up in WebpageIcons.db
rdar://problem/11254910 and https://bugs.webkit.org/show_bug.cgi?id=142733

Patch by Sam Weinig. Reviewed by Brady Eidson.

loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Bail early here if the page is using an ephemeral session.
(WebCore::IconController::continueLoadWithDecision): Instead of here.

4:38 AM Changeset in webkit [181633] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181555 - Unreviewed. Add new Notification classes to GTK+ API documentation.

Add WebKitNotification and WebKitNotificationPermissionRequest to
the documentation and fix some other typos causing warnings when
generating HTML documentation.

UIProcess/API/gtk/WebKitUserContent.cpp:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

4:38 AM Changeset in webkit [181632] by Carlos Garcia Campos

7 edits
26 adds in releases/WebKitGTK/webkit-2.8

Merge r181553 - Add APNG support
https://bugs.webkit.org/show_bug.cgi?id=17022

Patch by Max Stepin <maxstepin@gmail.com> on 2015-03-16
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Test: fast/images/animated-png.html

platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::divide255):
(WebCore::ImageFrame::overRGBA):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::frameHeader):
(WebCore::readChunks):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::readChunks):
(WebCore::PNGImageDecoder::frameHeader):
(WebCore::PNGImageDecoder::init):
(WebCore::PNGImageDecoder::clearFrameBufferCache):
(WebCore::PNGImageDecoder::initFrameBuffer):
(WebCore::PNGImageDecoder::frameComplete):
(WebCore::PNGImageDecoder::processingStart):
(WebCore::PNGImageDecoder::processingFinish):
(WebCore::PNGImageDecoder::fallbackNotAnimated):

platform/image-decoders/png/PNGImageDecoder.h:

(WebCore::PNGImageDecoder::frameCount):
(WebCore::PNGImageDecoder::repetitionCount):
(WebCore::PNGImageDecoder::isComplete):

Source/WTF:

wtf/FeatureDefines.h:

LayoutTests:

fast/images/animated-png-expected.html: Added.
fast/images/animated-png.html: Added.
fast/images/resources/apng00-ref.png: Added.
fast/images/resources/apng00.png: Added.
fast/images/resources/apng01-ref.png: Added.
fast/images/resources/apng01.png: Added.
fast/images/resources/apng02-ref.png: Added.
fast/images/resources/apng02.png: Added.
fast/images/resources/apng04-ref.png: Added.
fast/images/resources/apng04.png: Added.
fast/images/resources/apng08-ref.png: Added.
fast/images/resources/apng08.png: Added.
fast/images/resources/apng10-ref.png: Added.
fast/images/resources/apng10.png: Added.
fast/images/resources/apng11-ref.png: Added.
fast/images/resources/apng11.png: Added.
fast/images/resources/apng12-ref.png: Added.
fast/images/resources/apng12.png: Added.
fast/images/resources/apng14-ref.png: Added.
fast/images/resources/apng14.png: Added.
fast/images/resources/apng18-ref.png: Added.
fast/images/resources/apng18.png: Added.
fast/images/resources/apng24-ref.png: Added.
fast/images/resources/apng24.png: Added.
fast/images/resources/apng26-ref.png: Added.
fast/images/resources/apng26.png: Added.
platform/mac/TestExpectations:

4:10 AM Changeset in webkit [181631] by Carlos Garcia Campos

5 edits in trunk

[GTK] WebKitDOM objects leaking
https://bugs.webkit.org/show_bug.cgi?id=118788

Reviewed by Darin Adler and Sergio Villar Senin.

Source/WebCore:

Use a DOMwindowObserver class, derived from DOMWindowProperty to
be notified when the window object is detached from the frame to
clear the DOM objects associated to that frame in that case too.

bindings/gobject/DOMObjectCache.cpp:

Tools:

Update DOMObjectCache unit test to check that DOM objects are also
released when new contents are loaded in the web view, and the old
document is detached from the frame.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMObjectCache):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(runTest):

3:04 AM Changeset in webkit [181630] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit2

[WK2] Use C++ lambdas in IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=138018

Reviewed by Anders Carlsson.

Replace uses of WTF::bind() in the IPC::Connection class with C++ lambdas.

Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::invalidate):
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage): Simplify the error messages so we
don't have to format strings on-the-fly, removing the issues of cross-thread
string copying altogether.
(IPC::Connection::dispatchDidReceiveInvalidMessage): The parameters are now
of the StringReference type.
(IPC::Connection::enqueueIncomingMessage):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::receiveSourceEventHandler):

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::open):

2:45 AM Changeset in webkit [181629] by zandobersek@gmail.com

7 edits
2 adds in trunk/Source

[CMake] Use a forwarding header for ANGLE's ShaderLang.h to avoid picking up ANGLE's EGL headers
https://bugs.webkit.org/show_bug.cgi?id=142530

Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE/ShaderLang.h: Added. Includes include/GLSLANG/ShaderLang.h. Used in WebCore

so we can avoid using ANGLE's EGL headers and use the system-default headers instead.

Source/WebCore:

CMakeLists.txt:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Source/WebKit2:

CMakeLists.txt: Replace the Source/ThirdParty/ANGLE/include/GLSLANG entry

in the list of inclusion directories for WebKit2 with Source/ThirdParty/ANGLE,
possible due to the new forwarding header for ANGLE's ShaderLang.h.

2:33 AM Changeset in webkit [181628] by msaboff@apple.com

7 edits in trunk/Source

Windows X86-64 should use the fixed executable allocator
https://bugs.webkit.org/show_bug.cgi?id=142749

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added jit/ExecutableAllocatorFixedVMPool.cpp to Windows build.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
jit/ExecutableAllocatorFixedVMPool.cpp: Don't include unistd.h on Windows.

Source/WTF:

Set ENABLE_EXECUTABLE_ALLOCATOR_FIXED for Windows.
Needed to export MetaAllocator::currentStatistics() for use in JavaScriptCore.

wtf/MetaAllocator.h:
wtf/Platform.h:

2:03 AM Changeset in webkit [181627] by youenn.fablet@crf.canon.fr

2 edits in trunk/Tools

W3C test importer default import folder should be LayoutTests/imported/w3c
https://bugs.webkit.org/show_bug.cgi?id=142728

Reviewed by Bem Jones-Bey.

Scripts/webkitpy/w3c/test_importer.py:

(parse_args): Updating the default destination option value to 'imported/w3c'.

1:43 AM Changeset in webkit [181626] by commit-queue@webkit.org

14 edits
9 adds in trunk/Source/WebInspectorUI

Web Inspector: Show rendering frames (and FPS) in Layout and Rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=142029

Patch by Matt Baker <Matt Baker> on 2015-03-17
Reviewed by Timothy Hatcher.

Add UI for showing runloop records and their child records as a frame histogram,
with the recording time on the x-axis and the frame duration on the y-axis. Each frame
is comprised of colored regions representing the time spent in various activities (script,
layout, etc).

Eventually the Frames timeline will replace the Layout & Rendering timeline. Until the views
for the new timeline are finalized the Layout & Rendering timeline will remain in place.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:

New string and files.

UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype.pageDidLoad):
(WebInspector.TimelineManager.prototype._processNestedRecords):
(WebInspector.TimelineManager.prototype._processRecord):
(WebInspector.TimelineManager.prototype._processEvent):
(WebInspector.TimelineManager.prototype._loadNewRecording):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Deleted.
Added support for new runloop record type and nested record handling.

UserInterface/Images/Frames.png: Added.
UserInterface/Images/Frames@2x.png: Added.
UserInterface/Images/FramesLarge.png: Added.
UserInterface/Images/FramesLarge@2x.png: Added.

New images for runloop timeline overview graph and runloop tree records.

UserInterface/Models/RunLoopTimelineRecord.js: Added.

(WebInspector.RunLoopTimelineRecord):
(WebInspector.RunLoopTimelineRecord.prototype.get children):
(WebInspector.RunLoopTimelineRecord.prototype.get durationRemainder):
(WebInspector.RunLoopTimelineRecord.prototype.durationForRecords.get var):
Extends TimelineRecord to add child records and subframe duration details.

UserInterface/Models/Timeline.js:

(WebInspector.Timeline.prototype.get displayName):
(WebInspector.Timeline.prototype.get iconClassName):
New UI strings and icons.

UserInterface/Models/TimelineRecord.js:
UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):

UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
Added support for new runloop record type.

UserInterface/Views/RunLoopTimelineOverviewGraph.css: Added.

(.timeline-overview-graph.runloop > .divider):
(.timeline-overview-graph.runloop > .divider > span):
New styles for runloop timeline graph.

UserInterface/Views/RunLoopTimelineOverviewGraph.js: Added.

(WebInspector.RunLoopTimelineOverviewGraph):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.updateLayout.createFrame):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.get graphHeightSeconds.this):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.get graphHeightSeconds):
(WebInspector.RunLoopTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
New overview graph for displaying TimelineRecordFrames and horizontal frame budget dividers.

UserInterface/Views/TimelineIcons.css:

(.runloop-icon .icon):
(.runloop-icon.large .icon):
(.runloop-record .icon):

UserInterface/Views/TimelineSidebarPanel.js:

New runloop icon styles.

UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):
Updated factory to support creation of the new overview graph.

UserInterface/Views/TimelineRecordFrame.css: Added.

(.timeline-record-frame):
(.timeline-record-frame > .frame):
(.timeline-record-frame > .dropped):
(.timeline-record-frame > .frame > .duration):
(.timeline-record-frame > .frame > .duration:first-child):
(.timeline-record-frame > .frame > .duration:last-child):
(.timeline-record-frame > .frame > .duration.timeline-record-type-network):
(.timeline-record-frame > .frame > .duration.timeline-record-type-layout):
(.timeline-record-frame > .frame > .duration.timeline-record-type-script):
New styles for frame bars in the runloop timeline graph.

UserInterface/Views/TimelineRecordFrame.js: Added.

(WebInspector.TimelineRecordFrame):
(WebInspector.TimelineRecordFrame.createCombinedFrames):
(WebInspector.TimelineRecordFrame.prototype.get element):
(WebInspector.TimelineRecordFrame.prototype.get duration):
(WebInspector.TimelineRecordFrame.prototype.get records):
(WebInspector.TimelineRecordFrame.prototype.set records):
(WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
New view representing a single frame within the runloop overview graph.

WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

New files.

1:41 AM Changeset in webkit [181625] by commit-queue@webkit.org

7 edits in trunk/Source

Web Inspector: Show rendering frames (and FPS) in Layout and Rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=142029

Patch by Matt Baker <Matt Baker> on 2015-03-17
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/protocol/Timeline.json:

Added new event type for runloop timeline records.

Source/WebCore:

Add new functionality to the Inspector timelines backend to add runloop data to timeline recordings.

inspector/InspectorTimelineAgent.cpp:

(WebCore::currentRunLoop):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Install observers for the begining and end of the runloop when recording begins. All other
instrumented timeline events get added as children of the current runloop record, which is
sent to the frontend once the runloop completes.