Context Navigation

script.text shouldn't include text from non-direct children of the script element
https://bugs.webkit.org/show_bug.cgi?id=148851
<rdar://problem/22587759>

Patch by Keith Rollin <Keith Rollin> on 2015-10-07
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline several W3C HTML tests now that new checks are passing.

web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-xhtml-expected.txt:

Source/WebCore:

Don't include text from non-direct children in script.text. Per:
https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
Chrome and Firefox behavior match the spec.

Test: fast/dom/script-subtext-in-script-elements.html

dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

LayoutTests:

script-getElementById-during-insertion removed because it no longer
runs correctly with this change.

fast/dom/script-getElementById-during-insertion-expected.txt: Removed.
fast/dom/script-getElementById-during-insertion.html: Removed.
fast/dom/script-subtext-in-script-elements-expected.txt: Added.
fast/dom/script-subtext-in-script-elements.html: Added.

7:06 PM Changeset in webkit [190702] by rniwa@webkit.org

1 edit
1 add in trunk/Websites/perf.webkit.org

Add a page that cycles through v2 dashboards
https://bugs.webkit.org/show_bug.cgi?id=149907

Reviewed by Chris Dumez.

Add cycler.html that goes through each dashboard on v2 UI.

This allows the dashboards to be cycled through on a TV screen.

public/cycler.html: Added.

(loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
at the end of body. We don't immediately show the new iframe since it might take a while to load.
(showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
charts are still in progress to be shown.

7:06 PM Changeset in webkit [190701] by Chris Dumez

2 edits in trunk/Source/WebCore

Partial revert of r187626 as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898

Reviewed by Myles C. Maxfield.

Do a partial revert of r187626 as it caused a regression on PLT.

platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.

5:55 PM Changeset in webkit [190700] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776

Unreviewed follow up to r190697.

css3/font-variant-all-webfont-expected.html:
css3/font-variant-all-webfont.html:

5:47 PM Changeset in webkit [190699] by mark.lam@apple.com

8 edits in trunk/Source/JavaScriptCore

[Follow up 2] Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Rubber stamped by Saam Barati.

Also need to surpress JSC tail call tests.

tests/es6.yaml:
tests/stress/dfg-tail-calls.js:

(nonInlinedTailCall.callee):

tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

tests/stress/tail-call-in-inline-cache.js:

(tail):

tests/stress/tail-call-no-stack-overflow.js:

(shouldThrow):

tests/stress/tail-call-recognize.js:

(callerMustBeRun):

tests/stress/tail-call-varargs-no-stack-overflow.js:

(shouldThrow):

5:35 PM Changeset in webkit [190698] by Brent Fulgham

6 edits in trunk/Tools

[Win] Support 64-bit Build and Testing
https://bugs.webkit.org/show_bug.cgi?id=149904

Reviewed by Daniel Bates.

Extend our existing scripts to support 64-bit build and test operations on
Windows.

Scripts/build-dumprendertree: We don't need to build DRT on its own;

Windows always builds the whole stack.

Scripts/webkit-build-directory: Add an option to return the location of

the executable files produced by a specific configuration. This change is
actually useful for Gtk and EFL, too.

Scripts/webkitdirs.pm:

(executableProductDir): Added. This function appends the proper binary
path to the productDir. This is useful for Windows, Gtk, and EFL ports.
(jscProductDir): Use the new 'executableProductDir' method.
(setPathForRunningWebKitApp): Ditto.
(runSafari): Ditto.
(runMiniBrowser): Ditto.

Scripts/webkitpy/port/factory.py:

(configuration_options): Add a 64-bit option, used on Windows to specify
which binary target should be used for testing.

Scripts/webkitpy/port/win.py:

(WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
processes when needed.
(WinPort._build_path): Add the correct binary target path to _build_path.
(WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
64-bit paths for 64-bit tests.
(WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
NTSD debugger does not understand this argument.

5:33 PM Changeset in webkit [190697] by mmaxfield@apple.com

8 edits
1 add in trunk

Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776

Reviewed by Simon Fraser.

Tools:

This test extends our existing FontWithFeatures project to be able to generate a
TrueType font. This font is conceptually similar as the existing OpenType font,
except the feature -> character mapping is different.

The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.
The letter "A" always is a check mark.
The letter "B" always is an X.
Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when
"kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
mark.

Here are the mappings of font features to letters:
kLigaturesType / kCommonLigaturesOnSelector: C
kLigaturesType / kContextualLigaturesOnSelector: D
kLigaturesType / kRareLigaturesOnSelector: G
kLigaturesType / kHistoricalLigaturesOnSelector: I
kContextualAlternatesType / kContextualAlternatesOnSelector: L
kVerticalPositionType / kInferiorsSelector: O
kVerticalPositionType / kSuperiorsSelector: P
kLowerCaseType / kLowerCaseSmallCapsSelector: S
kUpperCaseType / kUpperCaseSmallCapsSelector: V
kLowerCaseType / kLowerCasePetiteCapsSelector: T
kUpperCaseType / kUpperCasePetiteCapsSelector: W
kLetterCaseType / 14: Y
kStyleOptionsType / kTitlingCapsSelector: a
kNumberCaseType / kUpperCaseNumbersSelector: c
kNumberCaseType / kLowerCaseNumbersSelector: d
kNumberSpacingType / kProportionalNumbersSelector: f
kNumberSpacingType / kMonospacedNumbersSelector: g
kFractionsType / kDiagonalFractionsSelector: i
kFractionsType / kVerticalFractionsSelector: j
kVerticalPositionType / kOrdinalsSelector: Q
kTypographicExtrasType / kSlashedZeroOnSelector: k
kLigaturesType / kHistoricalLigaturesOnSelector: K
kCharacterShapeType / kJIS1978CharactersSelector: m
kCharacterShapeType / kJIS1983CharactersSelector: n
kCharacterShapeType / kJIS1990CharactersSelector: o
kCharacterShapeType / kJIS2004CharactersSelector: p
kCharacterShapeType / kSimplifiedCharactersSelector: q
kCharacterShapeType / kTraditionalCharactersSelector: r
kTextSpacingType / kMonospacedTextSelector: t
kTextSpacingType / kProportionalTextSelector: u
kRubyKanaType / kRubyKanaOnSelector: v

FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
FontWithFeatures/FontWithFeatures/FontCreator.cpp:

(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(GLYFBuilder::GLYFBuilder):
(GLYFBuilder::takeResult):
(GLYFBuilder::moveTo):
(GLYFBuilder::lineTo):
(GLYFBuilder::closePath):
(GLYFBuilder::writePoint):
(GLYFBuilder::append16):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(itemForGlyph):
(Generator::generate):
(Generator::insertSelector):
(Generator::insertFeature):
(Generator::generateFeatureDescription):
(Generator::appendCFFTable):
(Generator::appendGLYFTable):
(Generator::appendLOCATable):
(Generator::appendFEATTable):
(Generator::appendMetamorphosisChain):
(Generator::appendMORXTable):
(Generator::appendHEADTable):
(Generator::appendHMTXTable):
(Generator::appendNameSubtable):
(Generator::append2ByteASCIIString):
(Generator::appendNAMETable):
(generateFont):
(CFFBuilder::curveToCubic): Deleted.
(charStringForGlyph): Deleted.

FontWithFeatures/FontWithFeatures/FontCreator.h:
FontWithFeatures/FontWithFeatures/main.cpp:

(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
(drawTextWithFeature): Deleted.

LayoutTests:

css3/font-feature-settings-rendering-2-expected.html:
css3/font-feature-settings-rendering-2.html:
css3/resources/FontWithFeatures.ttf: Added.

5:17 PM Changeset in webkit [190696] by rniwa@webkit.org

4 edits in trunk/Websites/perf.webkit.org

Allow custom revisions to be specified in A/B testing
https://bugs.webkit.org/show_bug.cgi?id=149905

Reviewed by Chris Dumez.

Allow custom revision number on each "repository" when creating a test group.

public/v2/app.css:

(form .analysis-group [name=customValue]): Added.

public/v2/app.js:

(App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
Also added point labels such as (point 3) on "None" for when some points are missing revision info.
(App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
(App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
revision option is selected.

public/v2/index.html: Added a text field for specifying a custom revision number.

4:34 PM Changeset in webkit [190695] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Reviewed by Saam Barati.

Updating the expected test result because we disabled tail calls.

js/caller-property-expected.txt:

4:10 PM Changeset in webkit [190694] by ggaren@apple.com

57 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

This time for sure?

The cause of the leak was an invalidated compilation.

There was vestigial manual memory management code that eagerly removed
a CodeBlock from the set of CodeBlocks if compilation was invalidated.
That's not cool since we rely on the set of CodeBlocks when we run
destructors.

The fix is to remove the vestigial code.

I ran the leaks, correctness, and performance tests locally and did not
see any problems.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

3:56 PM Changeset in webkit [190693] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add API for getting a group identifier from a bundle page
https://bugs.webkit.org/show_bug.cgi?id=149902

Reviewed by Tim Horton.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyGroupIdentifier):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:

3:09 PM Changeset in webkit [190692] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Reviewed by Saam Barati.

This is until we fix whatever the breakage is.

runtime/Options.h:

3:05 PM Changeset in webkit [190691] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

URTBF after r190678 to fix GTK and EFL builds.

WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::setBundleParameters):

WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WebKit::InjectedBundle::setBundleParameters):

2:57 PM Changeset in webkit [190690] by Sukolsak Sakshuwong

5 edits
1 add in trunk/Source/JavaScriptCore

Add an LLVM IR generator for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149486

Reviewed by Mark Lam.

This patch adds initial support for an LLVM IR generator in WebAssembly
(polyfill-prototype-1 format). All the methods will be implemented in
subsequent patches.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
wasm/WASMFunctionLLVMIRGenerator.h: Added.

(JSC::WASMFunctionLLVMIRGenerator::MemoryAddress::MemoryAddress):
(JSC::WASMFunctionLLVMIRGenerator::startFunction):
(JSC::WASMFunctionLLVMIRGenerator::endFunction):
(JSC::WASMFunctionLLVMIRGenerator::buildSetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildSetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildReturn):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateI32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF64):
(JSC::WASMFunctionLLVMIRGenerator::buildGetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildGetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildConvertType):
(JSC::WASMFunctionLLVMIRGenerator::buildLoad):
(JSC::WASMFunctionLLVMIRGenerator::buildStore):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalI32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF64):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxI32):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxF64):
(JSC::WASMFunctionLLVMIRGenerator::buildCallInternal):
(JSC::WASMFunctionLLVMIRGenerator::buildCallIndirect):
(JSC::WASMFunctionLLVMIRGenerator::buildCallImport):
(JSC::WASMFunctionLLVMIRGenerator::appendExpressionList):
(JSC::WASMFunctionLLVMIRGenerator::discard):
(JSC::WASMFunctionLLVMIRGenerator::linkTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTargetIf):
(JSC::WASMFunctionLLVMIRGenerator::startLoop):
(JSC::WASMFunctionLLVMIRGenerator::endLoop):
(JSC::WASMFunctionLLVMIRGenerator::startSwitch):
(JSC::WASMFunctionLLVMIRGenerator::endSwitch):
(JSC::WASMFunctionLLVMIRGenerator::startLabel):
(JSC::WASMFunctionLLVMIRGenerator::endLabel):
(JSC::WASMFunctionLLVMIRGenerator::breakTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueTarget):
(JSC::WASMFunctionLLVMIRGenerator::breakLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::buildSwitch):

wasm/WASMFunctionParser.cpp:

2:34 PM Changeset in webkit [190689] by commit-queue@webkit.org

9 edits
1 delete in trunk

Unreviewed, rolling out r190572, r190593, r190594, and
r190639.
https://bugs.webkit.org/show_bug.cgi?id=149897

Breaks Mavericks build (Requested by litherum on #webkit).

Reverted changesets:

"Allow WKRetainPtrs to be used as keys in hashing data
structures"
https://bugs.webkit.org/show_bug.cgi?id=149762
http://trac.webkit.org/changeset/190572

"REGRESSION(189668?): http/tests/notifications/events.html
flakily asserts or times out"
https://bugs.webkit.org/show_bug.cgi?id=149218
http://trac.webkit.org/changeset/190593

"Prospective Mavericks build fix."
http://trac.webkit.org/changeset/190594

"Post-review cleanup after r190572."
http://trac.webkit.org/changeset/190639

2:25 PM Changeset in webkit [190688] by BJ Burg

3 edits in trunk/LayoutTests

Unreviewed, more Mac test gardening after r190629.

platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

2:24 PM Changeset in webkit [190687] by rniwa@webkit.org

6 edits in trunk/Websites/perf.webkit.org

Make the site name configurable in perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=149894

Reviewed by Chris Dumez.

Added "siteTitle" as a new configuration key to specify the site name.

public/include/db.php:

(config): Now takes the default value as an argument.

public/include/manifest.php:

(ManifestGenerator::generate): Include siteTitle in the manifest.

public/index.html: Update the title and the heading when the manifest is loaded.
public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
public/v2/manifest.js:

(App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.

2:19 PM Changeset in webkit [190686] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Provide a way to get a WKFrameInfoRef from a WKFrameRef
https://bugs.webkit.org/show_bug.cgi?id=149896
rdar://problem/23016081

Reviewed by Dan Bernstein.

UIProcess/API/C/WKFrame.cpp:

(WKFrameCreateFrameInfo):

UIProcess/API/C/WKFrame.h:

2:14 PM Changeset in webkit [190685] by Alan Bujtas

26 edits in trunk/Source/WebCore

RenderObject::computeRectForRepaint/computeFloatRectForRepaint should return the computed rectangle.
https://bugs.webkit.org/show_bug.cgi?id=149883

Reviewed by Simon Fraser.

Reduces code complexity at the calling sites.

No change in functionality.

rendering/RenderBox.cpp:

(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):

rendering/RenderBox.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

rendering/RenderInline.h:
rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):

rendering/RenderObject.h:

(WebCore::RenderObject::computeAbsoluteRepaintRect):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):

rendering/RenderTableCell.h:
rendering/RenderText.cpp:

(WebCore::RenderText::collectSelectionRectsForLineBoxes):

rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

rendering/RenderView.h:
rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

rendering/svg/RenderSVGForeignObject.h:
rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::computeFloatRectForRepaint):

rendering/svg/RenderSVGInline.h:
rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):

rendering/svg/RenderSVGModelObject.h:
rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

rendering/svg/RenderSVGRoot.h:
rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):

rendering/svg/RenderSVGText.h:
rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):

rendering/svg/SVGRenderSupport.h:

2:12 PM Changeset in webkit [190684] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Get rid of LLInt inline/out-of-line storage helpers, they are unused
https://bugs.webkit.org/show_bug.cgi?id=149892

Reviewed by Mark Lam.

Just killing dead code.

llint/LowLevelInterpreter.asm:

1:46 PM Changeset in webkit [190683] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add unreachable URL to _WKObservablePageState
https://bugs.webkit.org/show_bug.cgi?id=149893
<rdar://problem/23017235>

Reviewed by Dan Bernstein.

UIProcess/API/C/mac/WKPagePrivateMac.h:
UIProcess/API/C/mac/WKPagePrivateMac.mm:

(-[WKObservablePageState unreachableURL]):

1:27 PM Changeset in webkit [190682] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Don't setOutOfBounds in JIT code for PutByVal, since the C++ slow path already does it
https://bugs.webkit.org/show_bug.cgi?id=149885

Reviewed by Geoffrey Garen.

This simplifies the slow path code, which will make it easier to put read barriers on all of
the butterflies.

jit/JITOperations.cpp:

(JSC::getByVal):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_put_by_val):

1:25 PM Changeset in webkit [190681] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Get rid of JIT::compilePutDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=149884

Reviewed by Andreas Kling.

I'm finding more dead code.

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::compilePutDirectOffset): Deleted.

12:59 PM Changeset in webkit [190680] by Antti Koivisto

13 edits in trunk

Implement :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=149440
Source/WebCore:

rdar://problem/22731953

Reviewed by Ryosuke Niwa.

This implements the basic non-function :host syntax.

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:
css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchUserRules):

css/ElementRuleCollector.h:
css/RuleSet.cpp:

(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):

css/RuleSet.h:

(WebCore::RuleSet::cuePseudoRules):
(WebCore::RuleSet::hostPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

Reviewed by Ryosuke Niwa.

fast/shadow-dom/css-scoping-shadow-host-rule.html:

Fix and expand the test case.

platform/mac/TestExpectations:

12:41 PM Changeset in webkit [190679] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Heap::isWriteBarrierEnabled is unused
https://bugs.webkit.org/show_bug.cgi?id=149881

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-07
Reviewed by Geoffrey Garen.

heap/Heap.h:
heap/HeapInlines.h:

(JSC::Heap::isWriteBarrierEnabled): Deleted.

12:40 PM Changeset in webkit [190678] by andersca@apple.com

10 edits in trunk/Source/WebKit2

Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
https://bugs.webkit.org/show_bug.cgi?id=149887

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]):
Copy the dictionary, archive it, and set the values on the UI side bundle parameter data struct.

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Add new SPI.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:

(-[WKWebProcessBundleParameters setParameter:forKey:]):
We can just call setValue:forKey: on the dictionary; it will do the right thing if value is nil.

(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Enumerate the dictionary and call setValue:forKey: on each key/value pair.

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::setBundleParameter):
If we fail to unarchive a parameter, don't set it to null.

(WebKit::InjectedBundle::setBundleParameters):
Unarchive the dictionary and update the bundle parameters.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setInjectedBundleParameters):
Call the injected bundle.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

Add new message.

12:28 PM Changeset in webkit [190677] by BJ Burg

2 edits in trunk/LayoutTests

Unreviewed, more Mac test gardening after r190629.

platform/mac-wk1/TestExpectations:

11:38 AM Changeset in webkit [190676] by rniwa@webkit.org

5 edits in trunk/Websites/perf.webkit.org

Perf dashboard doesn't show analysis tasks anchored at outliers
https://bugs.webkit.org/show_bug.cgi?id=149870

Reviewed by Chris Dumez.

The bug was caused by the computation of start and end times of analysis tasks being dependent on
time series provided to the interactive chart component even though they are already filtered.

Since the interactive chart component shouldn't be messing with the underlying data models, moved
the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
the unfiltered time series newly exposed on ChartData.

Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.

public/admin/fetch-from-remote.php:

(.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
and Ember can start hanging browsers (took me three hours to debug this).

public/v2/app.js:

(App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
(App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
Filter the results manually instead.
(App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
(App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
need to call a private method on it.
(App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
This will cause chartData to be modified so just exit early and wait for getting called again.

public/v2/interactive-chart.js:

(App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
to App.Pane.ranges.

public/v2/manifest.js:

(App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
to compute the end points of analysis tasks when their end points are outliers.

11:26 AM Changeset in webkit [190675] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
https://bugs.webkit.org/show_bug.cgi?id=149879

Reviewed by Saam Barati.

To simplify my work to insert barriers on loads of the butterfly, I want to reduce the amount
of abstraction we have around code that loads the butterfly.

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.

jit/JITPropertyAccess32_64.cpp:

11:17 AM Changeset in webkit [190674] by n_wang@apple.com

6 edits in trunk

AX: ARIA 1.1 @aria-placeholder
https://bugs.webkit.org/show_bug.cgi?id=148970

Reviewed by Chris Fleizach.

Source/WebCore:

Added support for aria-placeholder attribute.

Modified accessibility/placeholder.html test.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::placeholderValue):

html/HTMLAttributeNames.in:

LayoutTests:

accessibility/placeholder-expected.txt:
accessibility/placeholder.html:

11:04 AM Changeset in webkit [190673] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

JIT::compileGetDirectOffset is useless
https://bugs.webkit.org/show_bug.cgi?id=149878

Reviewed by Mark Lam.

Two of the overloads of this method were never called. The other was called only from one
place, in a manner that rendered most of its code dead. This change removes the dead code and
folds the method into its one caller.

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.

10:28 AM Changeset in webkit [190672] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

Inline caches should handle out-of-line offsets out-of-line
https://bugs.webkit.org/show_bug.cgi?id=149869

Reviewed by Saam Barati.

If we want to have a concurrent copying GC, then we need a read barrier on copied space
pointers. That makes the convertible load portion of the get_by_id/put_by_id inline caches
rather challenging. Currently we have a load instruction that we can turn into an add
instruction - the add case is when we have an inline offset, and the load case is when we
have an out-of-line offset and we need to load a copied space pointer. But if the load from
copied space requires a barrier, then there is no easy way to convert that back to the inline
case.

This patch removes the convertible load. The inline path of get_by_id/put_by_id only handles
the inline offsets. Out-of-line offsets are now handled using out-of-line stubs.

bytecode/StructureStubInfo.h:
ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):

jit/JITInlineCacheGenerator.h:
jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):

runtime/JSObject.h:

(JSC::JSObject::butterflyTotalSize):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
(JSC::maxOffsetRelativeToBase):
(JSC::makeIdentifier):
(JSC::offsetRelativeToPatchedStorage): Deleted.
(JSC::maxOffsetRelativeToPatchedStorage): Deleted.

9:41 AM Changeset in webkit [190671] by andersca@apple.com

1 edit in trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolPrivate.h

Oops, did not mean to commit this.

9:39 AM Changeset in webkit [190670] by andersca@apple.com

5 edits
2 copies in trunk/Source/WebKit2

Expose the bundle parameter object on WKBundleRef
https://bugs.webkit.org/show_bug.cgi?id=149860

Reviewed by Tim Horton.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:

(-[WKWebProcessBundleParameters description]):
Add a description that includes the parameters.

WebProcess/InjectedBundle/API/c/mac/WKBundleMac.h:
WebProcess/InjectedBundle/API/c/mac/WKBundleMac.mm:

(WKBundleGetParameters):
Add getter.

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize):
Make sure to decode the bundle parameters before calling out to the bundle.

9:29 AM Changeset in webkit [190669] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

9:11 AM Changeset in webkit [190668] by commit-queue@webkit.org

18 edits
1 delete in trunk/Source

Unreviewed, rolling out r190664.
https://bugs.webkit.org/show_bug.cgi?id=149877

mac build is sometimes borken due to missing generated header
file (Requested by youenn on #webkit).

Reverted changeset:

"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190664

8:09 AM Changeset in webkit [190667] by Simon Fraser

10 edits
2 copies in trunk

will-change should trigger stacking context based purely on properties
https://bugs.webkit.org/show_bug.cgi?id=148068

Reviewed by Zalan Bujtas.
Source/WebCore:

Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).

Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.

Test: fast/css/will-change/will-change-creates-stacking-context-inline.html

rendering/RenderInline.cpp:

(WebCore::inFlowPositionedInlineAncestor):

rendering/RenderInline.h:

(WebCore::RenderInline::willChangeCreatesStackingContext):

rendering/style/WillChangeData.cpp:

(WebCore::propertyCreatesStackingContext):
(WebCore::WillChangeData::addFeature):
(WebCore::propertyCreatesStackingContextOnBoxesOnly): Deleted.

rendering/style/WillChangeData.h:

(WebCore::WillChangeData::canCreateStackingContextOnInline): Deleted.

LayoutTests:

Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.

platform/mac/TestExpectations: Fails on Mavericks because no backdrop-filter there.
fast/css/will-change/resources/will-change-stacking-helper.js:

(makeStackingInline):

fast/css/will-change/will-change-creates-stacking-context-inline-expected.html: Added.
fast/css/will-change/will-change-creates-stacking-context-inline.html: Added.

7:59 AM Changeset in webkit [190666] by commit-queue@webkit.org

1 edit
1 add in trunk/LayoutTests

[EFL] fast/repaint/block-inputrange-repaint.html is failed.
https://bugs.webkit.org/show_bug.cgi?id=149517

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-07
Reviewed by Zalan Bujtas.

EFL thumb size is different with mac port, it causes the difference of repaintRect.
So rebaseline the test with failure result.

platform/efl/fast/repaint/block-inputrange-repaint-expected.txt: Added.

6:14 AM Changeset in webkit [190665] by jfernandez@igalia.com

5 edits in trunk

[CSS Grid Layout] Modify grid item height doesn't work
https://bugs.webkit.org/show_bug.cgi?id=149840

Reviewed by Sergio Villar Senin.

Source/WebCore:

When computing the logical height of content-sized grid tracks we
need to clear grid item's override height if it needs to be laid
out again.

Currently we are doing so only in the case of percentage heights
or when the grid track's width has changed; these situations would
obviously mark grid items as needing layout.

However, there are other situations, like the one defined in this
bug, which would imply a new layout of the grid items; hence we
need to clear its override value if we want the layout logic to be
computed correctly.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):

LayoutTests:

Added new tests cases to verify content-sized grid tracks are resized
appropriately whenever grid item's height is changed.

fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt: Added new test cases.
fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html: Added new test cases.

5:52 AM Changeset in webkit [190664] by youenn.fablet@crf.canon.fr

18 edits
1 add in trunk/Source

Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Source/JavaScriptCore:

generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins. Renamed WebCoreJSClientData to JSClientData.
Added auto generation of PrivateWebCoreJSBuiltins that is a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.

The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.

Covered by existing tests.

CMakeLists.txt:
DerivedSources.make:
Modules/streams/ByteLengthQueuingStrategy.js:
Modules/streams/CountQueuingStrategy.js:
Modules/streams/ReadableStream.js:
Modules/streams/ReadableStreamInternals.js:
WebCore.order:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):

bindings/js/JSDOMWindowBase.h:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds):

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

bindings/js/WebCoreJSClientData.h:

(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.

generate-js-builtins-allinone: Added.

(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):

2:40 AM Changeset in webkit [190663] by svillar@igalia.com

21 edits
9 adds in trunk

[css-grid] Implement grid gutters
https://bugs.webkit.org/show_bug.cgi?id=149800

Reviewed by Darin Adler.

Source/WebCore:

Authors can now specify the gutters between grid lines, i.e.,
the space between two consecutive grid lines. This can be done
using the new '-webkit-grid-column-gap 'and
'-webkit-grid-row-gap' properties (or the '-webkit-grid-gap'
shorthand).

From the track sizing algorithm POV, gutters are treated as
fixed size columns. The primary consequence is that grids are
enlarged (depending on the number of tracks). Gutters also
affect the sizing of content-sized tracks and fr tracks as
long as the grid have spanning items. Those tracks will become
smaller as gutters will consume part of the item's size, so
the tracks won't need to grow as much as they used to.

Tests: fast/css-grid-layout/grid-gutters-and-alignment.html

fast/css-grid-layout/grid-gutters-and-flex-content.html
fast/css-grid-layout/grid-gutters-and-tracks.html
fast/css-grid-layout/grid-gutters-get-set.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridGapShorthand):

css/CSSParser.h:
css/CSSPropertyNames.in:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):

rendering/RenderGrid.h:
rendering/style/RenderStyle.h:
rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

Added several new test cases to verify that gutters are
properly considered when sizing and also to check that they do
not modify the current behavior. As many existing tests were
reused I took the chance to refactor some testing code related
to alignment so that it could be reused by many different
tests.

fast/css-grid-layout/grid-align-content.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
fast/css-grid-layout/grid-align.html:
fast/css-grid-layout/grid-gutters-and-alignment-expected.txt: Added.
fast/css-grid-layout/grid-gutters-and-alignment.html: Added.
fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt: Added.
fast/css-grid-layout/grid-gutters-and-flex-content.html: Added.
fast/css-grid-layout/grid-gutters-and-tracks-expected.txt: Added.
fast/css-grid-layout/grid-gutters-and-tracks.html: Added.
fast/css-grid-layout/grid-gutters-get-set-expected.txt: Added.
fast/css-grid-layout/grid-gutters-get-set.html: Added.
fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:
fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:
fast/css-grid-layout/grid-justify-content.html:
fast/css-grid-layout/resources/grid-alignment.css: Added.

(.alignSelfAuto):
(.alignSelfStretch):
(.alignSelfStart):
(.alignSelfEnd):
(.alignSelfCenter):
(.alignSelfRight):
(.alignSelfLeft):
(.alignSelfFlexStart):
(.alignSelfFlexEnd):
(.alignSelfSelfStart):
(.alignSelfSelfEnd):
(.alignItemsCenter):
(.alignContentBaseline):
(.alignContentLastBaseline):
(.alignContentStart):
(.alignContentEnd):
(.alignContentCenter):
(.alignContentLeft):
(.alignContentRight):
(.alignContentFlexStart):
(.alignContentFlexEnd):
(.justifyContentBaseline):
(.justifyContentLastBaseline):
(.justifyContentStart):
(.justifyContentEnd):
(.justifyContentCenter):
(.justifyContentLeft):
(.justifyContentRight):
(.justifyContentFlexStart):
(.justifyContentFlexEnd):
(.justifyContentSpaceBetween):
(.justifyContentSpaceAround):
(.justifyContentSpaceEvenly):
(.justifyContentStretch):
(.itemsCenter):
(.itemsEnd):
(.itemsLeft):
(.itemsRight):
(.itemsSelfStart):
(.itemsSelfEnd):

fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridGapDefinitionsValues):

fast/css-grid-layout/resources/grid.css:

(.firstRowThirdColumn):
(.secondRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowFourthColumn):

12:32 AM Changeset in webkit [190662] by ChangSeok Oh

3 edits
5 adds in trunk

[GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.

Test: fast/dom/HTMLProgressElement/native-progress-bar.html

rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintProgressBar):

LayoutTests:

fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.

12:11 AM Changeset in webkit [190661] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Unreviewed. Fix a typo in r190645.

public/include/db.php:

Oct 6, 2015:

9:08 PM Changeset in webkit [190660] by Michael Catanzaro

9 edits
4 adds in trunk

[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588

Reviewed by Darin Adler.

Source/WebCore:

PlatformGTK.cmake:
bindings/scripts/gobject-generate-headers.pl:

Source/WebKit2:

PlatformGTK.cmake:
UIProcess/API/gtk/WebKitAutocleanups.h: Added.
UIProcess/API/gtk/webkit2.h:
WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.

(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.

(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):

8:35 PM Changeset in webkit [190659] by jhoneycutt@apple.com

3 edits in trunk/LayoutTests

Unreviewed iOS test gardening after r190629.

platform/ios-simulator/TestExpectations:
platform/ios-simulator-wk1/TestExpectations:

7:51 PM Changeset in webkit [190658] by Alan Bujtas

6 edits
2 adds in trunk

Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920

Reviewed by Simon Fraser.

When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.

When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.

Source/WebCore:

Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html

rendering/RenderLayer.h:
rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

LayoutTests:

css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.

7:11 PM Changeset in webkit [190657] by jhoneycutt@apple.com

2 edits in trunk/LayoutTests

More unreviewed Windows test gardening after r190629.

platform/win/TestExpectations:

7:07 PM Changeset in webkit [190656] by jhoneycutt@apple.com

2 edits in trunk/LayoutTests

Unreviewed Windows test gardening after r190629.

platform/win/TestExpectations:

6:24 PM Changeset in webkit [190655] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
https://bugs.webkit.org/show_bug.cgi?id=149845

Reviewed by Darin Adler.

When converting from time-as-double to MediaTime, a regression was introduced
when checking whether m_seekTo was set to a valid value or not. The clause
time != -1 should be translated to time.isValid(), not !time.isValid().

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::timeChanged):

6:12 PM Changeset in webkit [190654] by jhoneycutt@apple.com

3 edits in trunk/LayoutTests

Unreviewed Mac test gardening after r190629.

platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

5:06 PM Changeset in webkit [190653] by beidson@apple.com

10 edits
2 moves in trunk/Source/WebCore

Rename IDBRequestIdentifier to IDBResourceIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=149861

Reviewed by Alex Christensen.

No new tests (No change in behavior).

Turns out having an object representing a (connection ID + unique ID pair) is useful for more than just IDBRequests.

CMakeLists.txt:
Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):

Modules/indexeddb/client/IDBConnectionToServer.h:
Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::IDBRequest):

Modules/indexeddb/client/IDBRequestImpl.h:

(WebCore::IDBClient::IDBRequest::resourceIdentifier):
(WebCore::IDBClient::IDBRequest::requestIdentifier): Deleted.

Modules/indexeddb/shared/IDBRequestData.h:

(WebCore::IDBRequestData::requestIdentifier):

Modules/indexeddb/shared/IDBResourceIdentifier.cpp: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.cpp.

(WebCore::nextResourceNumber):
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue):

Modules/indexeddb/shared/IDBResourceIdentifier.h: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h.

(WebCore::IDBResourceIdentifier::isEmpty):
(WebCore::IDBResourceIdentifier::hash):
(WebCore::IDBResourceIdentifier::operator==):
(WebCore::IDBResourceIdentifier::connectionIdentifier):
(WebCore::IDBResourceIdentifierHash::hash):
(WebCore::IDBResourceIdentifierHash::equal):
(WebCore::IDBResourceIdentifierHashTraits::emptyValue):
(WebCore::IDBResourceIdentifierHashTraits::isEmptyValue):
(WebCore::IDBResourceIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBResourceIdentifierHashTraits::isDeletedValue):

Modules/indexeddb/shared/IDBResultData.cpp:

(WebCore::IDBResultData::IDBResultData):

Modules/indexeddb/shared/IDBResultData.h:

(WebCore::IDBResultData::requestIdentifier):

WebCore.xcodeproj/project.pbxproj:

5:05 PM Changeset in webkit [190652] by BJ Burg

2 edits in trunk/Tools

Unreviewed, try to fix the iOS 8 build after r190368.

On older versions, IOHIDEventCreateForceEvent is not available.

WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.

4:22 PM Changeset in webkit [190651] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
https://bugs.webkit.org/show_bug.cgi?id=149405

lineNumber should be a number type but it was a string.

Reviewed by Timothy Hatcher.

UserInterface/Base/Main.js:

(WebInspector.openURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
Keep lineNumber undefined when it isn't present in the string.
WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
when it wasn't found in the parsed string.

3:40 PM Changeset in webkit [190650] by keith_miller@apple.com

2 edits in trunk/Tools

Add gmalloc option to run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=149858

Reviewed by Geoffrey Garen.

run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.

Scripts/run-javascriptcore-tests:

3:29 PM Changeset in webkit [190649] by mark.lam@apple.com

7 edits
1 add in trunk/Source/JavaScriptCore

Factoring out op_sub baseline code generation into JITSubGenerator.
https://bugs.webkit.org/show_bug.cgi?id=149600

Reviewed by Geoffrey Garen.

We're going to factor out baseline code generation into snippet generators so
that we can later use them in the DFG and FTL to emit code for to perform the
JS operations where the operand types are predicted to be polymorphic.
We are starting in this patch with the implementation of op_sub.

What was done in this patch:

Created JITSubGenerator based on the baseline implementation of op_sub as expressed in compileBinaryArithOp() and compileBinaryArithOpSlowCase(). I did not attempt to do write a more optimal version of op_sub. I'll leave that to a later patch.

Convert the 32-bit op_sub baseline implementation to use the same JITSubGenerator which was based on the 64-bit implementation. The pre-existing 32-bit baseline op_sub had handling for more optimization cases. However, a benchmark run shows that simply going with the 64-bit version (foregoing those extra optimizations) did not change the performance.

Also, previously, the 32-bit version was able to move double results directly
into the result location on the stack directly. By using JITSubGenerator,
we now always move that result into a pair of GPRs before storing it into
the stack location.

Add some needed emitters to AssemblyHelpers that play nice with JSValueRegs.

JavaScriptCore.xcodeproj/project.pbxproj:
jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::boxDouble):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::boxBooleanPayload):

jit/JIT.h:

(JSC::JIT::linkDummySlowCase):

jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):

jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_sub): Deleted.
(JSC::JIT::emitSub32Constant): Deleted.
(JSC::JIT::emitSlow_op_sub): Deleted.

jit/JITInlines.h:

(JSC::JIT::linkSlowCaseIfNotJSCell):
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
(JSC::JIT::addSlowCase):
(JSC::JIT::emitLoad):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):

jit/JITSubGenerator.h: Added.

(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::generateFastPath):
(JSC::JITSubGenerator::slowPathJumpList):

2:46 PM Changeset in webkit [190648] by n_wang@apple.com

8 edits
2 adds in trunk

AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
https://bugs.webkit.org/show_bug.cgi?id=132177

Reviewed by Chris Fleizach.

Source/WebCore:

Added role-specific defaults and changed general default to undefined.
Also added more elements to support aria-orientation on Mac.

Test: accessibility/mac/aria-orientation.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::isDescendantOfObject):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isColorWell):
(WebCore::AccessibilityObject::isSplitter):
(WebCore::AccessibilityObject::isToolbar):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::orientation):

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::scrollBar):

accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

accessibility/mac/aria-orientation-expected.txt: Added.
accessibility/mac/aria-orientation.html: Added.

2:41 PM Changeset in webkit [190647] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

V2 UI shouldn't sort dashboards lexicologically
https://bugs.webkit.org/show_bug.cgi?id=149856

Reviewed by Chris Dumez.

Don't sort the dashboards by name in App.Manifest.

public/v2/app.js:

(App.IndexRoute.beforeModel): Don't transition to "undefined" (string) dashboard.

public/v2/manifest.js:

(App.Manifest.._fetchedManifest):

2:21 PM Changeset in webkit [190646] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

V2 UI fails to show the data for the very first point in charts
https://bugs.webkit.org/show_bug.cgi?id=149857

Reviewed by Chris Dumez.

The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
Explicitly check the type of this property instead.

public/v2/data.js:

(TimeSeries.prototype.seriesBetweenPoints):

2:04 PM Changeset in webkit [190645] by rniwa@webkit.org

4 edits
3 adds in trunk/Websites/perf.webkit.org

Perf dashboard should have the capability to test local UI with production data
https://bugs.webkit.org/show_bug.cgi?id=149834

Reviewed by Chris Dumez.

Added tools/run-with-remote-server.py which runs a local httpd server and pulls data from a remote server.

Install.md: Added the instruction on how to use the script. Also updated the remaining instructions

for El Capitan.

config.json: Added remote server configurations.
public/admin/fetch-from-remote.php: Added. This script fetches JSON from the remote server specified in

config.json and caches the results in the location specified as "cacheDirectory" in config.json.
(main):
(fetch_remote):

public/include/db.php:

(config_path): Extracted from generate_data_file.
(generate_data_file):

tools/remote-server-relay.conf: Added. Apache 2.4 configuration file for a local http server launched by

run-with-remote-server.py.

tools/run-with-remote-server.py: Added. Launches Apache with the right set of directives.

(main):
(abspath_from_root):

1:57 PM Changeset in webkit [190644] by Simon Fraser

2 edits in trunk/LayoutTests

Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
on iOS WK2.

platform/ios-simulator-wk2/TestExpectations:

1:45 PM Changeset in webkit [190643] by peavo@outlook.com

8 edits in trunk/Source/WebCore

[WinCairo] GStreamer compile errors.
https://bugs.webkit.org/show_bug.cgi?id=149839

Reviewed by Alex Christensen.

Help MSVC to resolve ambiguous calls.

platform/graphics/MediaPlayer.h:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):

platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):

1:43 PM Changeset in webkit [190642] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

Take 2 on marking compositing/video/video-poster.html as flaky due to crashes.
https://bugs.webkit.org/show_bug.cgi?id=149819

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-06
Reviewed by Alexey Proskuryakov.

platform/mac-elcapitan/TestExpectations: Removed.
platform/mac/TestExpectations:

1:40 PM Changeset in webkit [190641] by Chris Dumez

2 edits in trunk/Source/WebCore

Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847

Reviewed by Antti Koivisto.

Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,

We only process the charset parameter if the tag is a link or a script.
We only process the sizes / srcset attributes if the tag is an img.

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.

1:28 PM Changeset in webkit [190640] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix spacing of FindBanner prev/next buttons
https://bugs.webkit.org/show_bug.cgi?id=149717

Patch by Devin Rousso <Devin Rousso> on 2015-10-06
Reviewed by Darin Adler.

The sizing and spacing of the previous and next buttons in the FindBanner
is slightly off and should be readjusted to ensure that both buttons are
the same size and have the same spacing.

UserInterface/Views/FindBanner.css:

(.find-banner > button.segmented.right > .glyph):
(.find-banner > button.segmented):
(.find-banner > button.segmented > .glyph):
(.find-banner > button.segmented.left): Deleted.
(.find-banner > button.segmented.left > .glyph): Deleted.
(.find-banner > button.segmented.right): Deleted.

1:26 PM Changeset in webkit [190639] by mmaxfield@apple.com

2 edits in trunk/Tools

Post-review cleanup after r190572.

Unreviewed.

TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:

1:26 PM Changeset in webkit [190638] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

UIProcess/API/C/mac/WKPagePrivateMac.mm:

1:14 PM Changeset in webkit [190637] by youenn.fablet@crf.canon.fr

23 edits in trunk/Source/WebCore

Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838

Reviewed by Darin Adler.

Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.

Covered by rebased binding tests.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):

bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):

bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):

bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):

bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):

bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):

1:08 PM Changeset in webkit [190636] by Brent Fulgham

2 edits in trunk/Tools

[Win] Unreviewed build correction.

TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most

are soft-linked at runtime.

1:01 PM Changeset in webkit [190635] by benjamin@webkit.org

4 edits in branches/safari-601-branch/LayoutTests

We can't use let in JS on the safari-601 branch

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-10-06

fast/css/indirect-adjacent-style-invalidation-1.html:
fast/css/indirect-adjacent-style-invalidation-2.html:
fast/css/indirect-adjacent-style-invalidation-3.html:

12:48 PM Changeset in webkit [190634] by commit-queue@webkit.org

3 edits
4 adds in trunk

Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/22747046>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003

Test: editing/style/apply-style-crash2.html

editing/style/apply-style-crash3.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.

Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.

This CL also adds a few more assertions to catch similar issues
more easily in the future.

LayoutTests:

editing/style/apply-style-crash2-expected.txt: Added.
editing/style/apply-style-crash2.html: Added.
editing/style/apply-style-crash3-expected.txt: Added.
editing/style/apply-style-crash3.html: Added.

12:23 PM Changeset in webkit [190633] by jfernandez@igalia.com

3 edits
2 deletes in trunk

[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
https://bugs.webkit.org/show_bug.cgi?id=149764

Reviewed by Darin Adler.

Source/WebCore:

This patch implements a refactoring of the auto-margin alignment code for grid
items so it uses start/end and before/after margin logic terms.

I addition, it avoids resetting the auto-margin values, which requires an extra
layout, before applying the alignment logic.

No new tests because there is no behavior change.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeMarginLogicalHeightForChild): Computing margins if child needs layout.
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded): Using start/end logical margins.
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded): Using before/after logical margins.
(WebCore::RenderGrid::columnAxisOffsetForChild): Just added comment.
(WebCore::RenderGrid::rowAxisOffsetForChild): Just added comment.

LayoutTests:

Removed a duplicated layout tests.

fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt: Removed.
fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html: Removed.

12:13 PM Changeset in webkit [190632] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify TimelineRecordBar a bit
https://bugs.webkit.org/show_bug.cgi?id=149733

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-06
Reviewed by Timothy Hatcher.

UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.prototype.set records):

12:11 PM Changeset in webkit [190631] by andersca@apple.com

4 edits
1 move
1 add in trunk/Source/WebKit2

WKPage needs to expose a KVO-compliant object, similar to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=149851
rdar://problem/22382022

Reviewed by Dan Bernstein.

Move the PageLoadStateObserver object from WKBrowsingContextController out into a separate file and make it
work with any Objective-C object. Use it in WKObservablePageState and add a WKPageCreateObservableState function.

UIProcess/API/C/mac/WKPagePrivateMac.h:
UIProcess/API/C/mac/WKPagePrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp.

(-[WKObservablePageState initWithPage:]):
(-[WKObservablePageState dealloc]):
(-[WKObservablePageState isLoading]):
(-[WKObservablePageState title]):
(-[WKObservablePageState URL]):
(-[WKObservablePageState hasOnlySecureContent]):
(-[WKObservablePageState estimatedProgress]):
(WKPageCreateObservableState):
(WKPageGetProcessIdentifier):
(WKPageIsURLKnownHSTSHost):

UIProcess/API/Cocoa/PageLoadStateObserver.h: Added.

(WebKit::PageLoadStateObserver::PageLoadStateObserver):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(PageLoadStateObserver::PageLoadStateObserver): Deleted.

WebKit2.xcodeproj/project.pbxproj:

11:45 AM Changeset in webkit [190630] by keith_miller@apple.com

3 edits in trunk/Tools

Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
https://bugs.webkit.org/show_bug.cgi?id=149815

Reviewed by Filip Pizlo.

Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
so should just use one test runner.

Scripts/run-javascriptcore-tests:

(runJSCStressTests):
(runMozillaTests): Deleted.
(defaultJsDriverArgsForMozillaTests): Deleted.

Scripts/run-jsc-stress-tests:

11:39 AM Changeset in webkit [190629] by jhoneycutt@apple.com

3 edits
2919 adds
1 delete in trunk/LayoutTests

Import some Blink layout tests.
https://bugs.webkit.org/show_bug.cgi?id=149768

These are a subset of tests that don't time out and whose expected
results in Blink match the results in WebKit when run under DRT and
WKTR.

Reviewed by Andy Estes.

11:20 AM Changeset in webkit [190628] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Tile map shows a green rect when threaded scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=149716

Reviewed by Darin Adler.

Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.

platform/graphics/TiledBacking.h:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::TileController):

platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.

11:06 AM Changeset in webkit [190627] by Alan Bujtas

6 edits in trunk/Source/WebCore

Remove redundant isComposited() function and replace
hasLayer() && layer()->isComposited() with RenderObject::isComposited().
https://bugs.webkit.org/show_bug.cgi?id=149846

Reviewed by Simon Fraser.

No change in functionality.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):

rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

rendering/RenderView.cpp:

(WebCore::rendererObscuresBackground):
(WebCore::isComposited): Deleted.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

10:36 AM Changeset in webkit [190626] by commit-queue@webkit.org

23 edits in trunk/Source/WebCore

Unreviewed, rolling out r190619.
https://bugs.webkit.org/show_bug.cgi?id=149849

borke the binding tests on iOS at least (Requested by youenn
on #webkit).

Reverted changeset:

"Binding generator XXConstructor::finishCreation should take
references as parameters"
https://bugs.webkit.org/show_bug.cgi?id=149838
http://trac.webkit.org/changeset/190619

10:35 AM Changeset in webkit [190625] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

10:33 AM Changeset in webkit [190624] by bshafiei@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

10:28 AM Changeset in webkit [190623] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Slider knobs should scale when rendering while zoomed
https://bugs.webkit.org/show_bug.cgi?id=149835
<rdar://problem/22897080>

Reviewed by Darin Adler.

Make slider knobs follow suit with the rest of the unscaled form controls
by rendering to an offscreen buffer when the page is zoomed or scaled and
then rendering a scaled version of the offscreen buffer onto the page.

platform/mac/ThemeMac.mm:

(WebCore::drawCellOrFocusRingIntoRectWithView): Helper function for drawing

cells and/or focus rings.

(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext): Refactored to

handle drawing slider knobs as well.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb): Use scaled rendering when necessary.

10:21 AM Changeset in webkit [190622] by commit-queue@webkit.org

3 edits in trunk/Tools

[GTK] Make update-webkitgtk-libs work behind firewall

update-webkitgtk-libs can work behind a firewall with changes to
a few packages. Where outbound git and active FTP connections
fail, using http protocol succeeds. Most packages are
already accessed using http.

https://bugs.webkit.org/show_bug.cgi?id=148941

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2015-10-06
Reviewed by Martin Robinson.

Tools

gtk/jhbuild.modules:

Replace git URLs with http. Remove no longer used ftp repositories.
Update argument for libxml2's autogen.sh script (--without-python
is ignored; --with-python=no is correct).

jhbuild/jhbuild-wrapper:

Instead of connecting to git://git.gnome.org/jhbuild, connect to
http://git.gnome.org/browse/jhbuild.

10:20 AM Changeset in webkit [190621] by Chris Dumez

7 edits
2 adds in trunk

[Web IDL] 'length' property is wrong for variadic operations
https://bugs.webkit.org/show_bug.cgi?id=149714

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test as our behavior changed. The new failures are
temporary and are due to the test being wrong. The test will be fixed
via Bug 149645 and we will pass those checks again.

web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

The value of the 'length' property was wrong for variadic operations:

https://heycam.github.io/webidl/#dfn-optional-argument

The final argument of a variadic operation is considered to be an
optional argument. Therefore, we should not account for it when
computing the value of the 'length' property. This patch fixes WebKit's
behavior to match the specification.

Test: fast/dom/variadic-operations-length.html

bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionLength):

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):

LayoutTests:

Add a layout test to check that the value for the 'length' property of
variadic operations is correct.

fast/dom/variadic-operations-length-expected.txt: Added.
fast/dom/variadic-operations-length.html: Added.

9:50 AM Changeset in webkit [190620] by youenn.fablet@crf.canon.fr

6 edits in trunk/Source/WebCore

Binding generator should add builtin header for JSBuiltin attributes
https://bugs.webkit.org/show_bug.cgi?id=149837

Reviewed by Darin Adler.

Ensured XXBuiltins.h header is included for builtin attributes.
Renamed AddIncludesForJSBuiltinMethods as AddJSBuiltinIncludesIfNeeded.
Test loop is done through all functions and attributes to handle conditional correctly.

Covered by existing and added binding tests.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(AddJSBuiltinIncludesIfNeeded):

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:

9:37 AM Changeset in webkit [190619] by youenn.fablet@crf.canon.fr

23 edits in trunk/Source/WebCore

Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838

Reviewed by Darin Adler.

Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.

Covered by rebased binding tests.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):

bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):

bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):

bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):

bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):

bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):

9:35 AM Changeset in webkit [190618] by commit-queue@webkit.org

3 edits
2 adds in trunk

[Cairo] fast/canvas/canvas-imageSmoothingFoo tests failed after r190383.
https://bugs.webkit.org/show_bug.cgi?id=149752

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-06
Reviewed by Carlos Garcia Campos.

CG's low interpolation quality setting is equivalent to most other browsers default or high settings.

Source/WebCore:

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):

LayoutTests:

platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.

9:33 AM Changeset in webkit [190617] by dbates@webkit.org

12 edits in trunk

Enable XSLT when building WebKit for iOS using the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149827

Patch by Daniel Bates <dbates@webkit.org> on 2015-10-06
Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
run this script before building WebKit for iOS or the build will fail because one or more XSLT
headers cannot be found.

Scripts/configure-xcode-for-ios-development:

(copyMissingXSLTHeadersToSDKIfNeeded): Added.

9:28 AM Changeset in webkit [190616] by Brent Fulgham

4 edits in trunk/Source/WebCore

[Win] Correct positioning error introduced in r190235
https://bugs.webkit.org/show_bug.cgi?id=149631
<rdar://problem/22635080>

Reviewed by Simon Fraser.

Covered by existing compositing tests:

css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
transforms/2d/preserve3d-not-fixed-container.html

platform/graphics/ca/TileGrid.cpp:

(TileGrid::platformCALayerPaintContents): No need to do this extra flipping step
on Windows.

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback): We should always flip the
coordinate system when drawing these layers on Windows.
(shouldInvertBeforeDrawingContent): Deleted.

platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:

(WebTiledBackingLayerWin::displayCallback): We do not need to flip coordinates
for these tiled layers; that's already accounted for in common tile drawing code.

9:21 AM Changeset in webkit [190615] by commit-queue@webkit.org

20 edits in trunk

Fix ENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=146511

Patch by Emanuele Aina <Emanuele Aina> on 2015-10-06
Reviewed by Darin Adler.

Source/cmake/OptionsGTK.cmake: Make ENABLE_WAYLAND_TARGET depend on

ENABLE_OPENGL due to EGL usage.

Source/WebCore:

platform/graphics/texmap/BitmapTextureGL.h:
platform/graphics/texmap/BitmapTextureGL.cpp:
platform/graphics/texmap/TextureMapperGL.h:
platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/texmap/TextureMapperShaderProgram.h:
platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Fix TEXTURE_MAPPER_GL vs. TEXTURE_MAPPER guards to make sure that
ENABLE_OPENGL=OFF only disables the GL-related parts.

Source/WebKit2:

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseDidRelaunchWebProcess):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
webkitWebViewRenderAcceleratedCompositingResults()

UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/DrawingAreaProxyImpl.h:
WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::DrawingArea):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/LayerTreeHost.h:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().

UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):
Default to no AC if no GL support has been built.

WebProcess/WebPage/DrawingArea.messages.in:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
SetNativeSurfaceHandleForCompositing.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
Force setAcceleratedCompositingEnabled() only if a LayerTreeHost
implementation is available, to avoid crashing when building without
any GL support.

7:23 AM Changeset in webkit [190614] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build after r190611.

PlatformWin.cmake:

Forward headers from contentextensions.

6:31 AM Changeset in webkit [190613] by commit-queue@webkit.org

40 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/html.
https://bugs.webkit.org/show_bug.cgi?id=149662

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-06
Reviewed by Darin Adler.

No new tests because there is no behavior change.

html/DOMFormData.cpp:

(WebCore::DOMFormData::DOMFormData):

html/EmailInputType.cpp:

(WebCore::EmailInputType::typeMismatchFor):

html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles):

html/FormController.cpp:

(WebCore::FormControlState::serializeTo):
(WebCore::FormControlState::deserialize):
(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::restoreControlStateIn):
(WebCore::FormController::getReferencedFilePaths):

html/HTMLAnchorElement.cpp:

(WebCore::hasNonEmptyBox):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):

html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::length):

html/HTMLFormControlsCollection.cpp:

(WebCore::firstNamedItem):

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::formWouldHaveSecureSubmission):
(WebCore::HTMLFormElement::removedFrom):
(WebCore::HTMLFormElement::length):
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::removeFromPastNamesMap):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):

html/HTMLInputElement.cpp:

(WebCore::parseAcceptAttribute):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMediaGroup):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::index):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setDefaultValue):

html/InputType.cpp:

(WebCore::populateInputTypeFactoryMap):

html/MediaController.cpp:

(MediaController::duration):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(playbackStateWaiting):
(MediaController::updateMediaElements):
(MediaController::bringElementUpToSpeed):
(MediaController::isBlocked):
(MediaController::hasEnded):
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasCurrentSrc):
(MediaController::returnToRealtime):

html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseTimeFragment):

html/PublicURLManager.cpp:

(WebCore::PublicURLManager::revoke):
(WebCore::PublicURLManager::stop):

html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
(WebCore::WebGLBuffer::setTarget):

html/canvas/WebGLContextGroup.cpp:

(WebCore::WebGLContextGroup::loseContextGroup):

html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):

html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):
(WebCore::WebGLFramebuffer::drawBuffers):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::deleteTexture):

html/canvas/WebGLVertexArrayObject.cpp:

(WebCore::WebGLVertexArrayObject::deleteObjectImpl):

html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::initializeAttributes):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):

html/parser/XSSAuditor.cpp:

(WebCore::semicolonSeparatedValueContainsJavaScriptURL):

html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):

html/track/AudioTrackList.cpp:

(AudioTrackList::getTrackById):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::activeCues):

html/track/TextTrackList.cpp:

(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::invalidateTrackIndexesAfterTrack):

html/track/TrackListBase.cpp:

(TrackListBase::isAnyTrackEnabled):

html/track/VideoTrackList.cpp:

(VideoTrackList::getTrackById):

2:41 AM Changeset in webkit [190612] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

URTBF after r190611.

CMakeLists.txt:

1:18 AM Changeset in webkit [190611] by commit-queue@webkit.org

36 edits
3 adds in trunk

Report error when main resource is blocked by content blocker
https://bugs.webkit.org/show_bug.cgi?id=149719
rdar://problem/21970595

Patch by Alex Christensen <achristensen@webkit.org> on 2015-10-06
Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/contentextensions/main-resource.html

English.lproj/Localizable.strings:
contentextensions/ContentExtensionActions.h:
contentextensions/ContentExtensionError.h:

(WebCore::ContentExtensions::make_error_code):

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
Instead of nulling out the ResourceRequest, processContentExtensionRulesForLoad
now returns a status indicating whether the request should be blocked.
This is needed because the DocumentLoader needs a CachedResource with an error representing the blocking
(WebCore::ContentExtensions::ContentExtensionsBackend::displayNoneCSSRule):

contentextensions/ContentExtensionsBackend.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):
Dispatch an error if the resource is blocked by a content blocker.

loader/EmptyClients.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::cancelledError):
(WebCore::FrameLoader::blockedByContentBlockerError):
(WebCore::FrameLoader::connectionProperties):

loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

page/UserContentController.cpp:

(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):

page/UserContentController.h:
platform/efl/ErrorsEfl.cpp:

(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):

platform/efl/ErrorsEfl.h:
platform/gtk/ErrorsGtk.cpp:

(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):

platform/gtk/ErrorsGtk.h:

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::blockedError):
(WebFrameLoaderClient::blockedByContentBlockerError):
(WebFrameLoaderClient::cannotShowURLError):
Add blockedByContentBlockerError so WebFrameLoaderClient is not an abstract class,
but it should be unused because content blockers are not enabled on WK1.

Source/WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::blockedError):
(WebFrameLoaderClient::blockedByContentBlockerError):
(WebFrameLoaderClient::cannotShowURLError):

WebCoreSupport/WebFrameLoaderClient.h:

Added stub that should never be used.

Source/WebKit2:

Shared/API/c/WKErrorRef.h:
WebProcess/WebCoreSupport/WebErrors.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::blockedError):
(WebKit::WebFrameLoaderClient::blockedByContentBlockerError):
(WebKit::WebFrameLoaderClient::cannotShowURLError):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):

WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):

WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):
Make a new error type for loads that were blocked by a content blocker.

LayoutTests:

http/tests/contentextensions/main-resource-expected.txt: Added.
http/tests/contentextensions/main-resource.html: Added.
http/tests/contentextensions/main-resource.html.json: Added.

1:02 AM Changeset in webkit [190610] by calvaris@igalia.com

3 edits in trunk/Source/WebCore

JSBuiltinConstructor must always add builtin header
https://bugs.webkit.org/show_bug.cgi?id=149759

Reviewed by Darin Adler.

Covered by TestJSBuiltinConstructor.idl.

bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.

bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.

Oct 5, 2015:

11:54 PM Changeset in webkit [190609] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed EFL Gardening
https://bugs.webkit.org/show_bug.cgi?id=149830

Remove "--lint-test-files warnings".

Patch by Byung Jun Kim <bj1987.kim@samsung.com> on 2015-10-05

platform/efl/TestExpectations:

11:20 PM Changeset in webkit [190608] by youenn.fablet@crf.canon.fr

20 edits
1 copy
5 adds
8 deletes in trunk

Migrate streams API to JS Builtins
https://bugs.webkit.org/show_bug.cgi?id=147092

Reviewed by Darin Adler.

Source/WebCore:

Moved ReadableStream implementation from C++ to JS Builtins.
Created specific private constructors for ReadableStreamReader and ReadableStreamController.
Added these constructors to JSDOMWindowBase.
Constructors are based on a template found in JSDOMConstructor which might serve to webidl-generated classes as well.

Covered by existing tests.

CMakeLists.txt:
DerivedSources.make:
Modules/streams/ReadableStream.cpp: Removed.
Modules/streams/ReadableStream.h: Removed.
Modules/streams/ReadableStream.idl:
Modules/streams/ReadableStream.js:

(strategy.size):
(initializeReadableStream):
(cancel):
(getReader):
(pipeTo):
(tee):
(locked):

Modules/streams/ReadableStreamController.h:
Modules/streams/ReadableStreamController.idl:
Modules/streams/ReadableStreamController.js: Added.

(enqueue):
(error):
(close):
(desiredSize):

Modules/streams/ReadableStreamInternals.js:

(privateInitializeReadableStreamReader):
(privateInitializeReadableStreamController):
(isReadableStream):
(isReadableStreamReader):
(isReadableStreamController):
(errorReadableStream):
(requestReadableStreamPull):
(getReadableStreamDesiredSize):
(releaseReadableStreamReader):
(cancelReadableStream):
(finishClosingReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader):
(invokeOrNoop):
(promiseInvokeOrNoop):

Modules/streams/ReadableStreamReader.cpp: Removed.
Modules/streams/ReadableStreamReader.h:
Modules/streams/ReadableStreamReader.idl:
Modules/streams/ReadableStreamReader.js: Copied from Source/WebCore/Modules/streams/ReadableStream.js.

(cancel):
(read):
(releaseLock):
(closed):

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMConstructor.h: Added.

(WebCore::JSBuiltinConstructor::create):
(WebCore::JSBuiltinConstructor::createStructure):
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
(WebCore::JSBuiltinConstructor::initializeProperties):
(WebCore::JSBuiltinConstructor<JSClass>::finishCreation):
(WebCore::JSBuiltinConstructor<JSClass>::construct):
(WebCore::JSBuiltinConstructor<JSClass>::getConstructData):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):

bindings/js/JSReadableStreamControllerCustom.cpp: Removed.
bindings/js/JSReadableStreamCustom.cpp: Removed.
bindings/js/JSReadableStreamPrivateConstructors.cpp: Added.

(WebCore::constructJSReadableStreamController):
(WebCore::constructJSReadableStreamReader):
(WebCore::JSBuiltinConstructor<JSReadableStreamReader>::createJSObject):
(WebCore::JSBuiltinConstructor<JSReadableStreamController>::createJSObject):
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createInitializeFunction):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createInitializeFunction):
(WebCore::createReadableStreamReaderPrivateConstructor):
(WebCore::createReadableStreamControllerPrivateConstructor):

bindings/js/JSReadableStreamPrivateConstructors.h: Added.
bindings/js/JSReadableStreamReaderCustom.cpp: Removed.
bindings/js/ReadableJSStream.cpp: Removed.
bindings/js/ReadableJSStream.h: Removed.
bindings/js/WebCoreBuiltinNames.h: Added.

(WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):

bindings/js/WebCoreJSBuiltins.cpp:
bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::builtinNames):
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins):
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins):

LayoutTests:

Rebasing some tests, one subtest passing, two others still failing but with different reasons.

streams/reference-implementation/brand-checks-expected.txt:
streams/reference-implementation/readable-stream-reader-expected.txt:

11:15 PM Changeset in webkit [190607] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190599.
https://bugs.webkit.org/show_bug.cgi?id=149836

Made perf tests randomly crash (Requested by ap on #webkit).

Reverted changeset:

"GC shouldn't cancel every FTL compilation"
https://bugs.webkit.org/show_bug.cgi?id=149821
http://trac.webkit.org/changeset/190599

10:51 PM Changeset in webkit [190606] by commit-queue@webkit.org

57 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190589.
https://bugs.webkit.org/show_bug.cgi?id=149833

Caused lots of leaks, and possibly crashes (Requested by ap on
#webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190589

10:43 PM Changeset in webkit [190605] by Chris Dumez

3 edits
2 adds in trunk

data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.

Test: fast/preloader/image-data-url.html

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

LayoutTests:

Add layout test to make sure that images with a data: URL do not
get preloaded.

fast/preloader/image-data-url-expected.txt: Added.
fast/preloader/image-data-url.html: Added.

9:13 PM Changeset in webkit [190604] by jer.noble@apple.com

19 edits in trunk

[iOS] REGRESSION(r190434): Media continues to play when locking screen
https://bugs.webkit.org/show_bug.cgi?id=149822

Reviewed by Brent Fulgham.

Source/WebCore:

In MediaSessionManagerIOS.mm, both -applicationWillEnterForeground: and
-applicationDidBecomeActive: called
PlatformMediaSessionManager::applicationWillEnterForeground(), leading to the
PlatformMediaSession's m_interruptionCount becoming increasingly unbalanced.

Rename PlatformMediaSessionManager::applicationWillEnterForeground() to
applicationDidEnterForeground() to more correctly reflect when this notification will be
called. Add a new method, MediaSessionManagerIOS::applicationWillEnterForeground(bool),
whose paramater is whether the screen was locked. This allows the beginInterruption() and
endInterruption() methods to be correctly balanced.

Drive-by fix: remove the unimplemented declarations for application{will,did}Enter{Fore,Back}ground()
from PlatformMediaSession.h.

platform/audio/PlatformMediaSession.h:
platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidEnterForeground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted.

platform/audio/PlatformMediaSessionManager.h:
platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::applicationDidEnterBackground):
(WebCore::MediaSessionManageriOS::applicationWillEnterForeground):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):

testing/Internals.cpp:

(WebCore::Internals::applicationDidEnterForeground):
(WebCore::Internals::applicationWillEnterForeground): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

Pass through isSuspendedUnderLock when notifying the WebPage that the
applicationWillEnterForeground, and pass that boolean in the userInfo of the
WebUIApplicationWillEnterForegroundNotification.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationWillEnterForeground):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillEnterForeground):

LayoutTests:

applicationWillEnterForeground() -> applicationDidEnterForeground().

media/video-background-playback-expected.txt:
media/video-background-playback.html:
media/video-background-tab-playback-expected.txt:
media/video-background-tab-playback.html:

8:00 PM Changeset in webkit [190603] by Nikita Vasilyev

2 edits in trunk/Websites/webkit.org

Modify the image to fit the width of the blog.

blog-files/web-inspector-keyboard-shortcuts/debugger-shortcuts.png:

7:47 PM Changeset in webkit [190602] by achristensen@apple.com

3 edits
3 adds in trunk

Invalid CSS Selector for Content Blockers invalidates others
https://bugs.webkit.org/show_bug.cgi?id=148446
rdar://problem/22918235

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: http/tests/contentextensions/invalid-selector.html

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::isValidSelector):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
Add a check to see if a selector is valid before adding it.

LayoutTests:

http/tests/contentextensions/invalid-selector-expected.txt: Added.
http/tests/contentextensions/invalid-selector.html: Added.
http/tests/contentextensions/invalid-selector.html.json: Added.

6:59 PM Changeset in webkit [190601] by ggaren@apple.com

9 edits in trunk/Source/JavaScriptCore

Remove a few includes from JSGlobalObject.h
https://bugs.webkit.org/show_bug.cgi?id=148004

Reviewed by Saam Barati.

parser/VariableEnvironment.cpp:
parser/VariableEnvironment.h:
runtime/JSGlobalObject.h:
runtime/JSString.cpp:

(JSC::JSString::createStructure):
(JSC::JSRopeString::RopeBuilder::expand):

runtime/JSString.h:

(JSC::JSString::canGetIndex):
(JSC::JSString::offsetOfLength):
(JSC::JSString::offsetOfFlags):
(JSC::JSString::createStructure): Deleted.

runtime/Structure.h:
runtime/StructureInlines.h:
runtime/StructureRareDataInlines.h:

6:57 PM Changeset in webkit [190600] by Nikita Vasilyev

1 edit
6 adds in trunk/Websites/webkit.org

Add more assets for Web Inspector Keyboard Shortcuts blog post.

blog-files/web-inspector-keyboard-shortcuts/icon-disable.png: Added.
blog-files/web-inspector-keyboard-shortcuts/icon-play.png: Added.
blog-files/web-inspector-keyboard-shortcuts/icon-step-in.png: Added.
blog-files/web-inspector-keyboard-shortcuts/icon-step-out.png: Added.
blog-files/web-inspector-keyboard-shortcuts/icon-step-over.png: Added.
blog-files/web-inspector-keyboard-shortcuts/search.png: Added.

6:33 PM Changeset in webkit [190599] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

GC shouldn't cancel every FTL compilation
https://bugs.webkit.org/show_bug.cgi?id=149821

Reviewed by Saam Barati.

During one of the CodeBlock GC refactorings, we messed up the GC's compilation cancellation
code. The GC should be able to cancel compilation plans if it determines that the plan will
be DOA. But, prior to this fix, that code was killing every FTL compilation. This happened
because the meaning of CodeBlock::isKnownToBeLiveDuringGC() changed.

It's funny that this didn't show up as a bigger slow-down. Basically, those benchmarks that
GC a lot usually don't rely on good compilation, while those benchmarks that do rely on good
compilation usually don't GC a lot. That's probably why this wasn't super obvious when we
broke it.

This change just changes the cancellation logic so that it only cancels plans if the owning
executable is dead. This is safe; in fact the relevant method would be correct even if it
always returned true. It would also be correct if it always returned false. So, compared to
what we had before we changed isKnownToBeLiveDuringGC(), this new code will cancel fewer
compilations. But, that's better than cancelling every compilation. I've filed a bug and
written a FIXME for investigating ways to resurrect the old behavior:
https://bugs.webkit.org/show_bug.cgi?id=149823

Nonetheless, this change looks like it might be a 1% speed-up on Octane. It improves earley
and gbemu.

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isKnownToBeLiveDuringGC):

6:31 PM Changeset in webkit [190598] by Nikita Vasilyev

1 edit
8 adds in trunk/Websites/webkit.org

Add assets for Web Inspector Keyboard Shortcuts blog post.

blog-files/web-inspector-keyboard-shortcuts/clear-console.png: Added.
blog-files/web-inspector-keyboard-shortcuts/console-filters.m4v: Added.
blog-files/web-inspector-keyboard-shortcuts/debugger-shortcuts.png: Added.
blog-files/web-inspector-keyboard-shortcuts/hide-element.m4v: Added.
blog-files/web-inspector-keyboard-shortcuts/select-next-and-previous-tabs.m4v: Added.
blog-files/web-inspector-keyboard-shortcuts/toggle-split-console.m4v: Added.
blog-files/web-inspector-keyboard-shortcuts/tooltips.gif: Added.

6:22 PM Changeset in webkit [190597] by commit-queue@webkit.org

3 edits
2 adds in trunk

CSSGradientValue should check whether gradientLength is zero or not.
https://bugs.webkit.org/show_bug.cgi?id=149373
<rdar://problem/22771418>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Darin Adler.

Source/WebCore:

This is a merge of Blink r158220,
https://chromiumcodereview.appspot.com/24350008

Test: fast/gradients/css3-repeating-radial-gradients-crash.html

css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
Check whether gradientLength > 0 before using it as denominator.

LayoutTests:

fast/gradients/css3-repeating-radial-gradients-crash-expected.txt: Added.
fast/gradients/css3-repeating-radial-gradients-crash.html: Added.

6:09 PM Changeset in webkit [190596] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Get rid of some dead code
https://bugs.webkit.org/show_bug.cgi?id=149825

Reviewed by Tim Horton.

UIProcess/API/APIUIClient.h:

(API::UIClient::didDraw): Deleted.

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDraw): Deleted.

UIProcess/WebPageProxy.h:

6:05 PM Changeset in webkit [190595] by dino@apple.com

4 edits
2 adds in trunk

EXT_texture_filter_anisotropic extension exposed with WEBKIT_ prefix
https://bugs.webkit.org/show_bug.cgi?id=149765
<rdar://problem/22983722>

Reviewed by Beth Dakin.

Source/WebCore:

We can now remove the WEBKIT_ prefix from this extension.

Test: fast/canvas/webgl/unprefixed-anisotropic-extension.html

html/canvas/WebGL2RenderingContext.cpp: Support the prefixed and unprefixed form.

(WebCore::WebGL2RenderingContext::getExtension):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

LayoutTests:

Simple test that the unprefixed form exists. The actual functionality
is exercised in the WebGL conformance tests.

fast/canvas/webgl/unprefixed-anisotropic-extension-expected.txt: Added.
fast/canvas/webgl/unprefixed-anisotropic-extension.html: Added.

5:27 PM Changeset in webkit [190594] by mmaxfield@apple.com

2 edits in trunk/Source/WebKit2

Prospective Mavericks build fix.

Unreviewed.

UIProcess/API/cpp/WKRetainPtr.h:

4:45 PM Changeset in webkit [190593] by mmaxfield@apple.com

5 edits in trunk

REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
https://bugs.webkit.org/show_bug.cgi?id=149218

Reviewed by Alexey Proskuryakov.

Tools:

Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
when the TestOptions change. Previously, WebNotificationProvider only could handle a single
WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
WebNotificationProvider must be updated to appropriately handle multiple
WKNotificationManagerRefs in flight at the same time.

WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::~WebNotificationProvider):
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::addNotificationManager):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):

WebKitTestRunner/WebNotificationProvider.h:

LayoutTests:

TestExpectations:

4:43 PM Changeset in webkit [190592] by dino@apple.com

3 edits
2 adds in trunk

Reference cycles during SVG dependency invalidation
https://bugs.webkit.org/show_bug.cgi?id=149824
<rdar://problem/22771412>

Reviewed by Tim Horton.

Source/WebCore:

Detect any reference cycles as we are invalidating.

This is mostly a merge of the following Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

Test: svg/custom/reference-cycle.svg

rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies): Keep around a hash
table of dependencies, so that we can detect if an element is already
present before marking it.

LayoutTests:

Adding a test that has a cycle between feImage resources.

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

svg/custom/reference-cycle-expected.txt: Added.
svg/custom/reference-cycle.svg: Added.

4:36 PM Changeset in webkit [190591] by Sukolsak Sakshuwong

6 edits in trunk/Source/JavaScriptCore

[Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=149807

Reviewed by Benjamin Poulain.

From ECMA-402, 9.2.1, the abstract operation CanonicalizeLocaleList
returns a List of Strings. From the spec, we never modify the result
from CanonicalizeLocaleList(). We never expose it to the user either.
This patch changes the return type of canonicalizeLocaleList() from
JSArray* to Vector<String>. This should ease the workload of the GC and
make the code a bit easier to read.

runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):

runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):

runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):

runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::lookupSupportedLocales):
(JSC::bestFitSupportedLocales):
(JSC::supportedLocales):

runtime/IntlObject.h:

4:36 PM Changeset in webkit [190590] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Marking compositing/video/video-poster.html as flaky for El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=149819
<rdar://problem/16622896> ASSERT(!needsLayout()) at com.apple.WebCore: WebCore::RenderView::paint

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-05
Reviewed by Simon Fraser.

platform/mac-elcapitan/TestExpectations: Added.

4:31 PM Changeset in webkit [190589] by ggaren@apple.com

57 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the leak was VM shutdown, which happens in workers.

The fix is for CodeBlockSet to participate in lastChanceToFinalize,
since it's responsible for running CodeBlock destructors.

I ran the leaks tests locally and did not see any CodeBlock-related leaks.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

4:28 PM Changeset in webkit [190588] by commit-queue@webkit.org

7 edits
3 adds in trunk

Fix null pointer dereference in WebSocket::connect()
https://bugs.webkit.org/show_bug.cgi?id=149311
<rdar://problem/22748858>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r187441,
https://codereview.chromium.org/785933005

Test: http/tests/websocket/construct-in-detached-frame.html

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
Call function implemented below instead of duplicating the code.

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy):

page/ContentSecurityPolicy.h:

Factor the logic to check shouldBypassMainWorldContentSecurityPolicy into
a function in this class. Check Frame pointers are not null before getting
shouldBypassMainWorldContentSecurityPolicy via those pointers.

page/EventSource.cpp:

(WebCore::EventSource::create):
This got fixed as a bonus.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
This got fixed as a bonus too.

LayoutTests:

http/tests/websocket/construct-in-detached-frame-expected.txt: Added.
http/tests/websocket/construct-in-detached-frame.html: Added.
http/tests/websocket/resources/construct-in-detached-frame.html: Added.

4:17 PM Changeset in webkit [190587] by Beth Dakin

4 edits in trunk/Source/WebCore

WebCore::IOSurface should ask the IOSurface for the pixel format instead of
caching it
https://bugs.webkit.org/show_bug.cgi?id=149820
-and corresponding-
rdar://problem/22976230

Reviewed by Tim Horton.

Also there is no reason to make YUV be iOS only, so this patch removes those
PLATFORM checks.

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(IOSurface::IOSurface):
(IOSurface::format):

platform/spi/cocoa/IOSurfaceSPI.h:

4:13 PM Changeset in webkit [190586] by ap@apple.com

2 edits
1 copy in trunk/LayoutTests

Revert LayoutTests parts of r190579, which were incorrect.

svg/custom/invalid-xslt-crash-expected.txt: Copied from LayoutTests/svg/custom/invalid-xslt-crash-expected.txt.
svg/custom/invalid-xslt-crash.svg:

3:49 PM Changeset in webkit [190585] by rniwa@webkit.org

3 edits
2 adds in trunk

ShadowRoot with leading or trailing white space cause a crash
https://bugs.webkit.org/show_bug.cgi?id=149782

Reviewed by Chris Dumez.

Source/WebCore:

Fixed the crash by adding a null pointer check since a TextNode that appears as a direct child
of a ShadowRoot doesn't have a parent element.

Test: fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html

style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::previousSiblingRenderer):

LayoutTests:

Added a regression test.

fast/shadow-dom/shadow-root-with-child-whitespace-text-crash-expected.txt: Added.
fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html: Added.

3:35 PM Changeset in webkit [190584] by dbates@webkit.org

2 edits in trunk/Tools

Disable Bitcode when building for iOS device
https://bugs.webkit.org/show_bug.cgi?id=149818

Reviewed by Alexey Proskuryakov.

Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
when building for iOS device.

Scripts/webkitdirs.pm:

(XcodeOptions):

3:30 PM Changeset in webkit [190583] by dbates@webkit.org

2 edits in trunk/Tools

[iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
https://bugs.webkit.org/show_bug.cgi?id=140828
<rdar://problem/19520599>

Reviewed by Alexey Proskuryakov.

Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
to build-webkit.

Scripts/webkitdirs.pm:

(XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
(hasIOSDevelopmentCertificate): Added.

3:16 PM Changeset in webkit [190582] by Beth Dakin

2 edits in trunk/Source/WebCore

Build fix.

platform/spi/cocoa/IOSurfaceSPI.h:

3:13 PM Changeset in webkit [190581] by Beth Dakin

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/spi/cocoa/IOSurfaceSPI.h:

2:29 PM Changeset in webkit [190580] by beidson@apple.com

5 edits in trunk/Source/WebCore

Modernize IDBRequest::ReadyState into an enum class.
https://bugs.webkit.org/show_bug.cgi?id=149817

Reviewed by Alex Christensen.

No new tests (Refactor, no behavior change).

Modules/indexeddb/IDBRequest.h:

Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp:

(WebCore::LegacyOpenDBRequest::shouldEnqueueEvent):

Modules/indexeddb/legacy/LegacyRequest.cpp:

(WebCore::LegacyRequest::LegacyRequest):
(WebCore::LegacyRequest::result):
(WebCore::LegacyRequest::error):
(WebCore::LegacyRequest::errorCode):
(WebCore::LegacyRequest::readyState):
(WebCore::LegacyRequest::markEarlyDeath):
(WebCore::LegacyRequest::abort):
(WebCore::LegacyRequest::setCursorDetails):
(WebCore::LegacyRequest::setPendingCursor):
(WebCore::LegacyRequest::setResultCursor):
(WebCore::LegacyRequest::finishCursor):
(WebCore::LegacyRequest::shouldEnqueueEvent):
(WebCore::LegacyRequest::stop):
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::transactionDidFinishAndDispatch):
(WebCore::LegacyRequest::enqueueEvent):

Modules/indexeddb/legacy/LegacyRequest.h:

2:21 PM Changeset in webkit [190579] by commit-queue@webkit.org

5 edits
1 delete in trunk

Cleaning up after revision 190339
https://bugs.webkit.org/show_bug.cgi?id=149732

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Myles C. Maxfield.

Source/WebCore:

xml/XSLStyleSheet.h:
xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):

LayoutTests:

svg/custom/invalid-xslt-crash.svg:
svg/custom/invalid-xslt-crash-expected.txt:

Replace render tree dump test with text dump.
Pass if no crash.

1:57 PM Changeset in webkit [190578] by dbates@webkit.org

4 edits in trunk

DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
https://bugs.webkit.org/show_bug.cgi?id=149766

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

Assert that we have a non-null pointer to a cookie storage.

WebView/WebPreferences.mm:

(+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):

Tools:

Create network storage testing session on iOS.

Currently we do not create a network storage testing session on iOS. A network storage testing session always
has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.

As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
returns a non-null pointer to a cookie store.

DumpRenderTree/mac/DumpRenderTree.mm:

(prepareConsistentTestingEnvironment):

1:52 PM Changeset in webkit [190577] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Rebaseline test for iOS

platform/ios-simulator/fast/text/mark-matches-overflow-clip-expected.txt:

1:46 PM Changeset in webkit [190576] by Beth Dakin

2 edits in trunk/Source/WebCore

Errant space!!

platform/graphics/cocoa/IOSurface.mm:

(IOSurface::releaseGraphicsContext):
(IOSurface::convertToFormat):

1:38 PM Changeset in webkit [190575] by commit-queue@webkit.org

3 edits
45 adds in trunk/PerformanceTests

Add a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149053
<rdar://problem/18984169>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-05
Reviewed by Dean Jackson.

Instead of measuring the FPS of the animation, this benchmark measures the
test complexity when rendering at a set-point FPS which should be lower
than 60 FPS. This benchmark tries to stay at the set-point FPS by using
a closed loop control system PID function. The gain of the system is passed
as a parameter when running the test. Measuring the FPS faithfully results
very fluctuating values. A Kalman filter is used to give a better estimate
for the current FPS.

The animation of the tests is done manually. requestAnimationFrame() is
called with a callback. Inside this callback, the test is animating by
changing the positions of the elements inside the page. The test complexity
may change also if the current FPS is not equal to the desired FPS.

In this patch, the benchmark and the tests are included. The shared code
and the tests runner are included in separate patches.

Animometer/runner/animometer.html:
Animometer/runner/resources/animometer.js:

Add two new examples for more complex animation techniques.
Add an option to show/hide the test running results which is off by default.

Animometer/runner/resources/tests.js: Added.

(suiteFromName): Returns a suite given its name.
(testFromName): Returns a test given its suite and name.

Animometer/tests: Added.

This directory includes all the test suites to be run by the benchmark.
runner. All the tests should try to run on three stages: CSS, canvas and
SVG.

Animometer/tests/bouncing-particles: Added.
Animometer/tests/bouncing-particles/resources: Added.

The bouncing particles test is an example of a simple animation technique.

Animometer/tests/bouncing-particles/bouncing-canvas-images.html: Added.
Animometer/tests/bouncing-particles/bouncing-canvas-shapes.html: Added.
Animometer/tests/bouncing-particles/bouncing-css-images.html: Added.
Animometer/tests/bouncing-particles/bouncing-css-shapes.html: Added.
Animometer/tests/bouncing-particles/bouncing-svg-images.html: Added.
Animometer/tests/bouncing-particles/bouncing-svg-shapes.html: Added.

Bouncing particles test pages.

Animometer/tests/bouncing-particles/resources/bouncing-particles.js: Added.

(BouncingParticle): Base class for a bouncing particle.
(BouncingParticle.prototype.center): Returns the center point or the particle.
(BouncingParticle.prototype.animate): Moves the particle based on its current position, angle and velocity.

(BouncingParticlesAnimator): A sub class of Animator.

(BouncingParticlesStage): Represents the container of all the bouncing particles.
(BouncingParticlesStage.prototype.parseShapeParamters): Gets the shape parameters for shape animating tests.
(BouncingParticlesStage.prototype.randomRotater): Creates a rotater for the particles.
(BouncingParticlesStage.prototype.animate): Animates all the particles.
(BouncingParticlesStage.prototype.tune): Changes the test by adding or removing particles.

(BouncingParticlesBenchmark): Runs the benchmark for bouncing particles test.
(BouncingParticlesBenchmark.prototype.createAnimator): Creates an animator of type BouncingParticlesAnimator.

Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js: Added.

(BouncingCssShape): A sub class of BouncingParticle for animating CSS shapes.
(BouncingCssShape.prototype._createSpan): Creates a <span> element and takes the shape and clipping classes into consideration.
(BouncingCssShape.prototype._move): Moves the particle to a new location. Apply transform since it does not require layout.
(BouncingCssShape.prototype.animate): Rotates and moves the shape to a new location.

(BouncingCssShapesStage): A sub class of BouncingParticlesStage for animating CSS shapes.
(BouncingCssShapesStage.prototype.createParticle): Creates a particle of type BouncingCssShape.
(BouncingCssShapesStage.prototype.particleWillBeRemoved): Removes the corresponding element form the parent children list.

(BouncingCssShapesBenchmark): A sub class of BouncingParticlesBenchmark for animating CSS shapes.
(BouncingCssShapesBenchmark.prototype.createStage): Creates a stage of type BouncingCssShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCssShapesBenchmark.

Animometer/tests/bouncing-particles/resources/bouncing-css-images.js: Added.

(BouncingCssImage): A sub class of BouncingParticle for animating CSS images.
(BouncingCssImage.prototype._move): Move the particle to a new location. Apply transform since it does not require layout.
(BouncingCssImage.prototype.animate): Rotates and moves the shape to a new location.

(BouncingCssImagesStage): A sub class of BouncingParticlesStage for animating CSS images.
(BouncingCssImagesStage.prototype.createParticle): Creates a particle of type BouncingCssImage.
(BouncingCssImagesStage.prototype.particleWillBeRemoved): Removes the corresponding element form the parent children list.

(BouncingCssImagesBenchmark): A sub class of BouncingParticlesBenchmark for animating CSS images.
(BouncingCssImagesBenchmark.prototype.createStage): Creates a stage of type BouncingCssImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCssImagesBenchmark.

Animometer/tests/bouncing-particles/resources/bouncing-canvas-particles.js: Added.

(BouncingCanvasParticle): A base sub-class of BouncingParticle for animating canvas particles.
(BouncingCanvasParticle.prototype._applyRotation): Apply the particle rotation-around-center transform to the canvas context.
(BouncingCanvasParticle.prototype._applyClipping): Apply the particle clipping to the canvas context.
(BouncingCanvasParticle.prototype._draw): A non-implemented version of the drawing function.
(BouncingCanvasParticle.prototype.animate): Carries out all the steps to redraw the canvas particle.

(BouncingCanvasParticlesStage): A base sub-class of BouncingParticlesStage for animating canvas particles.

(BouncingCanvasParticlesAnimator): A concrete sub-class of BouncingParticlesAnimator for animating canvas particles.
(BouncingCanvasParticlesAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(BouncingCanvasParticlesBenchmark): A base sub-class of StageBenchmark for animating canvas particles.
(BouncingCanvasParticlesBenchmark.prototype.createAnimator): Creates the canvas particles animator.

Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js: Added.

(BouncingCanvasShape): A concrete sub-class of BouncingCanvasParticle for animating canvas shapes.
(BouncingCanvasShape.prototype._applyFill): Sets the fillStyle in the canvas context.
(BouncingCanvasShape.prototype._drawShape): Carries out the actual drawing.
(BouncingCanvasShape.prototype._draw): Carries out all the steps to draw the shape.

(BouncingCanvasShapesStage): A concrete sub-class of BouncingCanvasParticle for animating canvas shapes.
(BouncingCanvasShapesStage.prototype.createParticle): Creates a particle of type BouncingCanvasShape.

(BouncingCanvasShapesBenchmark): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas shapes.
(BouncingCanvasShapesBenchmark.prototype.createStage): Creates a stage of type BouncingCanvasShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCanvasShapesBenchmark.

Animometer/tests/bouncing-particles/resources/bouncing-canvas-images.js: Added.

(BouncingCanvasImage): A concrete sub-class of BouncingCanvasParticle for animating canvas images.
(BouncingCanvasImage.prototype._draw): Draws an image on the context of a canvas.

(BouncingCanvasImagesStage): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas images.
(BouncingCanvasImagesStage.prototype.createParticle): Creates a particle of type BouncingCanvasImage.

(BouncingCanvasImagesBenchmark): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas images.
(BouncingCanvasImagesBenchmark.prototype.createStage): Creates a stage of type BouncingCanvasImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCanvasImagesBenchmark.

Animometer/tests/bouncing-particles/resources/bouncing-svg-particles.js: Added.

(BouncingSvgParticle): A base sub-class of BouncingParticle for animating SVG particles.
(BouncingSvgParticle.prototype._applyClipping): Apply the particle clipping by setting the 'clip-path' attribute of the SVGElement.
(BouncingSvgParticle.prototype._move): Moves the particle to a new location. Apply transform since it does not require layout.
(BouncingSvgParticle.prototype.animate): Rotates and moves the shape to a new location.
(BouncingSvgParticlesStage): A sub class of BouncingParticlesStage for animating SVGElements.
(BouncingSvgParticlesStage.prototype._createDefs): Creates an SVGDefsElement.
(BouncingSvgParticlesStage.prototype._ensureDefsIsCreated): Ensures there is only one SVGDefsElement is created.
(BouncingSvgParticlesStage.prototype._createClipStar): Creates an SVGClipPathElement and sets its 'd' attribute to a star like shape.
(BouncingSvgParticlesStage.prototype.ensureClipStarIsCreated): Ensure there is only one star SVGClipPathElement is created.
(BouncingSvgParticlesStage.prototype.particleWillBeRemoved): Remove the corresponding element form the parent children list.

Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js: Added.

(BouncingSvgShape): A concrete sub-class of BouncingSVGParticle for animating SVG shapes.
(BouncingSvgShape.prototype._createShape): Creates an SVG shape.
(BouncingSvgShape.prototype._applyFill): Applies the selected fill style to the SVG shape.

(BouncingSvgShapesStage): A concrete sub-class of BouncingSvgParticlesStage for animating SVG shapes.
(BouncingSvgShapesStage.prototype.createGradient): Creates an SVGLinearGradientElement.
(BouncingSvgShapesStage.prototype.createParticle): Creates a particle of type BouncingSvgShape.
(BouncingSvgShapesStage.prototype.particleWillBeRemoved): Ensures the attached SVGLinearGradientElement is removed from the SVGDefsElement.

(BouncingSvgShapesBenchmark): A concrete sub-class of BouncingParticlesBenchmark for animating SVG images.
(BouncingSvgShapesBenchmark.prototype.createStage): Creates a stage of type BouncingSvgShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingSvgShapesBenchmark.

Animometer/tests/bouncing-particles/resources/bouncing-svg-images.js: Added.

(BouncingSvgImage): A concrete sub-class of BouncingSVGParticle for animating SVG images.

(BouncingSvgImagesStage): A concrete sub-class of BouncingSVGParticlesBenchmark for animating SVG images.
(BouncingSvgImagesStage.prototype.createParticle): Creates a particle of type BouncingSvgImage.

(BouncingSvgImagesBenchmark): A concrete sub-class of BouncingParticlesBenchmark for animating SVG images.
(BouncingSvgImagesBenchmark.prototype.createStage): Creates a stage of type BouncingSvgImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingSvgImagesBenchmark.

Animometer/tests/examples: Added.
Animometer/tests/examples/canvas-electrons.html: Added.
Animometer/tests/examples/canvas-stars.html: Added.

Examples test pages.

Animometer/tests/examples/resources: Added.
Animometer/tests/examples/resources/canvas-electrons.js: Added.

(CanvasElectron): An object which draws and animate a electron object on a canvas stage.
(CanvasElectron.prototype._draw): Draws the electron object.
(CanvasElectron.prototype.animate): Animates the electron object.

(CanvasElectronsStage): A concrete sub-class of Stage for animating electrons.
(CanvasElectronsStage.prototype.tune): Changes the test by adding or removing elements.
(CanvasElectronsStage.prototype.animate): Animates the test elements.

(CanvasElectronsAnimator): A concrete sub-class of StageAnimator for animating canvas electrons.
(CanvasElectronsAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(CanvasElectronsBenchmark): A concrete sub-class of StageBenchmark for animating electrons.
(CanvasElectronsBenchmark.prototype.createStage): Creates a stage of CanvasElectronsStage.
(CanvasElectronsBenchmark.prototype.createAnimator): Creates an animator of type CanvasElectronsAnimator.
(window.benchmarkClient.create): Creates a benchmark of type CanvasElectronsBenchmark.

Animometer/tests/examples/resources/canvas-stars.js: Added.

(CanvasStar): An object which draws and animate a star object on a canvas stage.
(CanvasStar.prototype._draw): Draws the star object.
(CanvasStar.prototype.animate): Animates the star object.

(CanvasStarsStage): A concrete sub-class of Stage for animating stars.
(CanvasStarsStage.prototype.tune): Changes the test by adding or removing elements.
(CanvasStarsStage.prototype.animate): Animates the test elements.

(CanvasStarsAnimator): A concrete sub-class of StageAnimator for animating canvas stars.
(CanvasStarsAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(CanvasStarsBenchmark): A concrete sub-class of Benchmark for animating stars.
(CanvasStarsBenchmark.prototype.createStage): Creates a stage of CanvasStarsStage.
(CanvasStarsBenchmark.prototype.createAnimator): Creates an animator of type CanvasStarsAnimator.
(window.benchmarkClient.create): Creates a benchmark of type CanvasStarsBenchmark.

Animometer/tests/resources: Added.

This directory includes the script which is required to run an adaptive
graphics benchmark. From an empty test page, the set of classes in this
directory are responsible for measuring the current frame rate and
changing the test to reach a desired FPS. It keeps asking the test page
to tune itself by a certain value to increase or decrease the frame rate.
It's also responsible for sampling the test state and the corresponding
frame rate.

Animometer/tests/resources/main.js: Added.

(BenchmarkState): Tracks the state of the benchmark test.
(BenchmarkState.prototype._timeOffset): Returns the timeOffset of a stage.
(BenchmarkState.prototype._message): Returns the message of a stage.
(BenchmarkState.prototype.update): Sets the currentTimeOffset to a new value.
(BenchmarkState.prototype.samplingTimeOffset): Returns the timeOffset of the sampling stage.
(BenchmarkState.prototype.currentStage): Returns the current stage of the benchmark.
(BenchmarkState.prototype.currentMessage): Returns the message of the current stage and timeOffset.
(BenchmarkState.prototype.currentProgress): Returns a percentage of how much the benchmark is running.

(Animator): Manages animating the test.
(Animator.prototype.start): Called if animating using setInterval is requested.
(Animator.prototype.timeDelta): Returns the current timeDelta
(Animator.prototype.animate): Manages the test animation.
(Animator.prototype.animateLoop): Called if animating using requestAnimationFrame is requested.

(Benchmark): Manages running the test benchmark and recording the sampled data.
(Benchmark.prototype.start): Starts the benchmark.
(Benchmark.prototype.update): Called from the animator.animate() to change the complexity of the test.
(Benchmark.prototype.record): Shows the current (not final) results of the benchmark.
(Benchmark.prototype.resolveWhenFinished): Spins until the benchmark is finished and returns its results.
(Benchmark.prototype.run): Starts the test, runs it, waits until it is finished and return its results.
(window.runBenchmark): Called from the benchmark runner through the suite controller run-callback.

Animometer/tests/resources/math.js: Added.

(Matrix): A matrix object.
(Vector3): A vector of size 3 object.
(Matrix3): A matrix of size 3x3 object.

(PIDController): Closed-loop controller for a set-point y.
(PIDController.prototype._sat): Limits the output to a certain range.
(PIDController.prototype.tune): Given the current output of a system, it produces a new pid value for tuning it.

(KalmanEstimator): Implement Kalman filter to get an estimate for a sampled data point.
(KalmanEstimator.prototype.estimate): Returns an estimate for for a sampled data point.

Animometer/tests/resources/utilities.js: Added.

(window.Utilities._parse): Given a separator character, it pareses a string to a set of <key, value> pairs.
(window.Utilities.parseParameters): Parses a test parameters.
(window.Utilities.parseArguments): Parses a tag arguments.
(window.Utilities.extendObject): Adds the attributes and their values of an object to another object.
(window.Utilities.copyObject): Copies the attributes and their values of an object to a new object.
(window.Utilities.mergeObjects): Copies the attributes and their values of two objects to a new object.
(window.Utilities.createSvgElement): Creates an SVGElement given its name and its attributes.

Animometer/tests/resources/stage.css: Added.
Animometer/tests/resources/stage.js: Added.

(Rotater): Manages rotating an angle within a fixed time interval.
(Rotater.prototype.get interval): Returns the time interval which is required to rotate 360 degrees.
(Rotater.prototype.next): Moves the current time by a delta.
(Rotater.prototype.degree): Returns the current rotating degree.
(Rotater.prototype.rotateZ): Returns CSS formatted transform rotateZ() string for the current degree.
(Rotater.prototype.rotate): Returns SVG formatted transform rotate() string for the current degree.

(Stage): A base class for managing the test complexity and test animation.
(Stage.prototype.get size): Returns the size of the stage excluding the CSS padding.
(Stage.prototype.random): Returns a random float.
(Stage.prototype.randomInt): Returns a random integer.
(Stage.prototype.randomPosition): Returns a random position.
(Stage.prototype.randomSquareSize): Returns a square size.
(Stage.prototype.randomVelocity): Returns a random velocity.
(Stage.prototype.randomAngle): Returns a random angle.
(Stage.prototype.randomColor): Returns a random color not too dark and not too light.
(Stage.prototype.randomRotater): Creates a random rotater. Its velocity depends on choosing a random rotation time interval.
(Stage.prototype.tune): A not-implemented version of this function.
(Stage.prototype.animate): A not-implemented version of this function.
(Stage.prototype.clear): Clears the stage from all its animation elements.

(StageAnimator): A base class for the stage-based animators.
(StageAnimator.prototype.animate): Calls Animator.animate() which updates the test page and then calls Stage.animate() to force redraw.

(StageBenchmark): A base class for the stage-based benchmarks.
(StageBenchmark.prototype.createStage): Creates the default stage.
(StageBenchmark.prototype.createAnimator): Creates the default animator.
(StageBenchmark.prototype.tune): Delegates the call to stage.
(StageBenchmark.prototype.clear): Delegates the call to stage.
(StageBenchmark.prototype.showResults): Shows the results/progress through its recordTable and progressBar.

Animometer/tests/resources/yin-yang.png: Added.
Animometer/tests/resources/yin-yang.svg: Added.

These images are shared among all the tests.

Animometer/tests/template: Added.
Animometer/tests/template/resources: Added.

This directory includes template tests which do nothing. They can be used
to author new tests. Animated items can be created, moved and redrawn by
removing the TODO comments in the script files and writing actual code.

Animometer/tests/template/template-css.html: Added.
Animometer/tests/template/template-canvas.html: Added.
Animometer/tests/template/template-svg.html: Added.

Template test pages. They can be used as they are. CSS attributes or hidden
elements can be added to these derived test pages if needed.

Animometer/tests/template/resources/template-css.js: Added.

(TemplateCssStage): A stage to create and animate HTMLElements.
(TemplateCssStage.prototype.tune): Changes the test by adding or removing elements.
(TemplateCssStage.prototype.animate): Animates the test elements.
(TemplateCssBenchmark):
(TemplateCssBenchmark.prototype.createStage): Creates the test stage.
(window.benchmarkClient.create): Creates a benchmark of type TemplateCssBenchmark.

Animometer/tests/template/resources/template-canvas.js: Added.

(TemplateCanvasObject):
(TemplateCanvasObject.prototype._draw): Draws the objects on the canvas context.
(TemplateCanvasObject.prototype.animate): Moves and redraws the object.
(TemplateCanvasStage): A stage to create and animate drawing elements.
(TemplateCanvasStage.prototype.tune): hanges the test by adding or removing elements.
(TemplateCanvasStage.prototype.animate): Animates the test elements.
(TemplateCanvasAnimator.prototype.animate): Starts the animation every frame.
(TemplateCanvasBenchmark):
(TemplateCanvasBenchmark.prototype.createStage): Creates a stage of type TemplateCanvasStage.
(TemplateCanvasBenchmark.prototype.createAnimator): Creates a animator of type TemplateCanvasAnimator.
(window.benchmarkClient.create): Creates a benchmark of type TemplateCanvasBenchmark.

Animometer/tests/template/resources/template-svg.js: Added.

(TemplateSvgStage): A stage to create and animate SVGElements.
(TemplateSvgStage.prototype.tune): Changes the test by adding or removing elements.
(TemplateSvgStage.prototype.animate): Animates the test elements.
(TemplateSvgBenchmark.prototype.createStage): Creates a stage of type TemplateSvgStage.
(window.benchmarkClient.create): Creates a benchmark of type TemplateSvgBenchmark.

Animometer/tests/text: Added.
Animometer/tests/text/resources: Added.

This directory includes the text animating tests which currently runs
on CSS stage only.

Animometer/tests/text/layering-text.html: Added.

Text test page.

Animometer/tests/text/resources/layering-text.js: Added.

(LayeringTextStage): Represents the container of all the stacked text layers.
(LayeringTextStage.parseTextItem): Parses a textItem which may be an opening tag, a closing tag or a self-closing tag.
(LayeringTextStage.isOpeningTextItem): Returns true if the textItem is an opening tag e.g. '<ol>'.
(LayeringTextStage.isClosingTextItem): Returns true if the textItem is an closing tag e.g. '</ol>.
(LayeringTextStage.textItemsFlags.LayeringTextStage.textItems.map): Calculates and stores isOpening and isClosing flags for each textItem.
(LayeringTextStage.isColorableTextItem): Returns true if the textItem is self-closing tag e.g. '<p>...</p>'.
(LayeringTextStage.isInsertableTextItem): Returns true if the textItems causes a new element to be added to the text layers.
(LayeringTextStage.colorableTextItems.LayeringTextStage.textItemsFlags.filter): Number of colorable textItems.
(LayeringTextStage.insertableTextItems.LayeringTextStage.textItemsFlags.filter): Number of insertable textItems.
(LayeringTextStage.colorIndexToTextElementIndex): Maps from colorIndex [0..colorableTextItems-1] to textElementIndex [0..insertableTextItems-1].
(LayeringTextStage.prototype._nextTextItem): Moves the _textItemIndex one step forward in a loop [0..LayeringTextStage.textItems.length-1].
(LayeringTextStage.prototype._previousTextItem): Moves the _textItemIndex one step backward in a loop.
(LayeringTextStage.prototype._pushTextElement): Creates a new textItemElement and adds it to the topmost container <div>.
(LayeringTextStage.prototype._popTextElement): Removes the last textItemElement from the topmost container <div>.
(LayeringTextStage.prototype._colorTextItem): Changes the background color of a single colorable textElement. The index advances in a circle [0..colorableTextItems-1].
(LayeringTextStage.prototype.animate): Changes the background color and the text color of the textElements such that a redraw is enforced.
(LayeringTextStage.prototype.tune): Adds or removes textElements to the stage.

(LayeringTextBenchmark): Runs the benchmark for the layering text test.
(LayeringTextBenchmark.prototype.createStage): Creates a stage of type LayeringTextStage.
(window.benchmarkClient.create): Creates a benchmark of type LayeringTextBenchmark.

1:35 PM Changeset in webkit [190574] by Beth Dakin

7 edits in trunk/Source

Compress snapshots on iOS
https://bugs.webkit.org/show_bug.cgi?id=149814
-and corresponding-
rdar://problem/22976230

Reviewed by Simon Fraser.

Source/WebCore:

Though the default is still RGBA, it is now possible to create an IOSurface
that uses the YUV422 pixel format.

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(IOSurface::surfaceFromPool):
(IOSurface::create):
(IOSurface::createFromImage):
(IOSurface::IOSurface):
(IOSurface::releaseGraphicsContext):

In order to have a YUV IOSurface, we actually have to create an RGBA surface
first and then convert it to YUV, so this class method will handle that.
(IOSurface::convertToFormat):

Necessary SPI.

platform/spi/cocoa/IOSurfaceSPI.h:

Source/WebKit2:

Compress the snapshot.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

Since the snapshots are converted to YUV asynchronously, it is possible to
get here and have a snapshot that does not yet have an image, so we have to
relax this constraint.

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):

1:33 PM Changeset in webkit [190573] by Simon Fraser

2 edits in trunk/Tools

Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
available.

WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):

1:31 PM Changeset in webkit [190572] by mmaxfield@apple.com

5 edits
1 add in trunk

Allow WKRetainPtrs to be used as keys in hashing data structures
https://bugs.webkit.org/show_bug.cgi?id=149762

Reviewed by Anders Carlsson.

Source/WebKit2:

Use RefPtr as a model.

UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
(WebKit::WKRetainPtr::isHashTableDeletedValue):
(WebKit::WKRetainPtr::hashTableDeletedValue):
(WTF::HashTraits<WKRetainPtr<P>>::emptyValue):
(WTF::HashTraits<WKRetainPtr<P>>::peek):

Tools:

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.

(TestWebKitAPI::TEST):

1:00 PM Changeset in webkit [190571] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Error displayed as an object when passed as a second argument to console.log
https://bugs.webkit.org/show_bug.cgi?id=149799

Reviewed by Joseph Pecoraro.

UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
Don't format errors as objects.

(WebInspector.ConsoleMessageView.prototype._formatParameter):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsError):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
Replace an unnecessary span element with a document fragment.

UserInterface/Views/ErrorObjectView.css:

(.error-object):
Display an error object on the same line as a list bullet.

12:55 PM Changeset in webkit [190570] by Alan Bujtas

3 edits
2 adds in trunk

Mark the line dirty when RenderQuote's text changes.
https://bugs.webkit.org/show_bug.cgi?id=149784
rdar://problem/22558169

Reviewed by Antti Koivisto.

When quotation mark changes ( " -> ' or empty string), we
need to mark the line dirty to ensure its content gets laid out properly.

Source/WebCore:

Test: fast/inline/quotation-text-changes-dynamically.html

rendering/RenderQuote.cpp:

(WebCore::quoteTextRenderer):
(WebCore::RenderQuote::updateText):
(WebCore::fragmentChild): Deleted.

LayoutTests:

fast/inline/quotation-text-changes-dynamically-expected.txt: Added.
fast/inline/quotation-text-changes-dynamically.html: Added.

12:35 PM Changeset in webkit [190569] by fpizlo@apple.com

31 edits
2 adds in trunk/Source

Allow an object's marking state to track The Three Colors
https://bugs.webkit.org/show_bug.cgi?id=149654

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

I want to make GC marking concurrent (see https://bugs.webkit.org/show_bug.cgi?id=149432).
Concurrent GC require barriers to be executed during certain heap operations. We already have a
generational GC. Generational GCs also need barriers, and we already have those. The generational
GC barrier that we use is the "sticky mark bit" barrier. Ordinarily, mark bits get reset after a
collection. In our collector, there is a secondary mark bit that "sticks" - i.e. it does not get
reset. If the sticky mark bit is set in between two collections, then we know that the object is in
old space. This is sufficient to determine when to put things into remembered sets. Additionally,
the sticky mark bit is actually a tri-state that can also tell us if the object has been placed on
a remembered set.

This is awfully similar to what you want in a concurrent GC. Concurrent GCs typically want writes
to the heap that change the object graph to do different things depending on an object's marking
state, which is usually referred to as its color. White means that the object has never been seen
by the collector. All white objects are presumed dead at the flip. Grey objects are those that are
known to the collector but have not been scanned. Black objects are those that have been scanned,
and will not be scanned again. White is exactly just "not being marked", and both grey and black
mean "marked" - with "black" meaning "marked but not on any worklist". That's quite a bit like the
current "Marked" and "MarkedAndRemembered" states that we have for generational GC.
"MarkedAndRemembered" is a lot like "grey", and "Marked" is a lot like "black".

I want to make a concurrent GC that unifies the generational and concurrent barriers into a single
fast path check. Even better if the two barriers are entirely identical. You can do this using
Pirinen's technique #2 [1], originally due to Guy Steele [2]: when doing o.f=v where o is black and
v is white, turn o grey again. This is like remembering an object, in the sense that our gen GC
"rememberes" o when o is old and v is new. It remembers objects by putting them on the mark stack,
setting the generational state to MarkedAndRemembered, and doing nothing to the primary mark bit.

This makes our concurrent GC approach pretty obvious. We want to use one barrier for concurrent and
generational, and we want to basically keep our current barriers unchanged. The only things missing
are just some small changes to allow the concurrent GC to know precisely when an object is black,
and to know during object visiting if we are visiting the object for the first time during a
collection or a subsequent time due to barrier re-greying (concurrent GC) or barrier remembering
(generational GC). So, this patch does the following:

Changes the terminology used for the gcData header byte in JSCell. This changes the name of this to cellState, and introduces a new enumeration called CellState. This new enumeration behaves a lot like the old GCData did. It has the following members, with the following correspondence to the old GCData:

OldBlack: this is like Marked, with the exception that we ensure that an object becomes OldBlack

as soon as the object starts to be scanned. Previously, an object might be
MarkedAndRemembered during scanning and we'd turn all MarkedAndRemembered objects into Marked
objects during a post-processing step at the end of GC. This patch gets rid of that
post-processing. The act of visiting an object unconditionally makes it OldBlack. Note that
our definition of "black" is not that the object is done being scanned, but that it is either
being scanned right now or it has already been scanned. This is like a combination of
Siebert's anthracite and black states [3].

NewWhite: this is exactly NotMarked. It's the state that objects get when they are allocated.

It's impossible for an object to return to this state.

OldGrey: the object is on the mark stack and will be scanned at some point in the future. This

also means that this isn't the first time in this cycle that the object has been grey. In an
eden collection, an old object that has been remembered is thought of as being OldGrey, even
if this is the first time during this eden collection that it is grey. That's because an eden
collection must behave "as if" the grey->black transition for old objects magically happened
at the start of GC. Remembered objects are like old objects that underwent a concurrent
barrier re-greying just after the magical old object grey->black transition at the start of
GC. This state is almost exactly like MarkedAndRemembered, except that an object now
transitions from OldGrey to OldBlack at the beginning of visiting, rather than how previously
we transitioned from MarkedAndRemembered to Marked at the bitter end of GC.

NewGray: the object is on the mark stack and will be scanned at some point in the future. This

state has no clear relative in the old state system. It means that the object became grey due
to ordinary marking. Previously, ordinary marking would make the object Marked.

Removal of the post-processing phase that "clears" the remembered set by moving all remembered objects to the Marked state. This now happens magically during visiting, as described above.

SlotVisitor now remembers the state that the object did have just before visiting. While visiting that object, it's possible to query what the state was. This is used for copy space decisions and for extra memory usage accounting. We don't want to put the backing store on the copy worklist, and we don't want to count extra memory usage, if the object was OldGrey at the start of visiting. Previously, we would be able to just ask if the object was MarkedAndRemembered since that state wouldn't get cleared until after all marking finished. This change also simplifies some APIs, because there is no need to pass the JSCell* pointer, since these SlotVisitor methods no longer ask the cell for its state - instead they use the saved pre-visiting state.

Removal of a bunch of helpers and abstractions. Previously we had various methods for asking if an object was "marked" and if an object was "remembered". We had helpers for adjusting these states, and those helpers would assert that they were being used the right way. This is not very useful for concurrent GC, since now the set of possible state transitions is much larger. Also, the previous use of the word "marked" was pretty bad - for example in Heap, "marked" refers to the primary mark bit (that gets cleared at the flip), while in JSCell, "marked" refers to the sticky mark bit (that does not get cleared, ever). This change gets rid of a lot of those helpers and inlines their logic. This actually makes the code easier and more fun to read, since you can now look at the marking and barrier code and see how that code uses the four CellStates. For example, it's fun to see that the barrier gets fired for o.f=v exactly when o is OldBlack and v is NewWhite.

This change shouldn't have any effect on performance or GC behavior. It does put our code in a
weird state where we now have states and comments referencing a concurrent GC that doesn't exist
yet.

Finally, some thoughts about the concurrent GC barrier and its implications for performance. This
barrier exhibits very poor guarantees about collector progress, but maximizes throughput by just
reusing the existing barrier code we already emit and optimize. I believe that even our epoch-based
barrier insertion DFG phase is correct for the concurrent interpretation of our existing barrier.
But, the barrier can regress the progress that the collector has made for two reasons:

Incremental update: you don't want to use this barrier with a black stack, since that would mean
that heap loads of white objects will have to explicitly re-grey the stack. The way you implement
this kind of collector is that collector termination will rescan the stack. Termination is reached
only if the at-termination re-scan greys no objects. This means that the collector is a fixpoint.
Luckily, our collector is already a fixpoint because of opaque roots and structure transitions.

Marking ain't monotonic: normally, once an object is black, it stays that way. In this collector,
black objects may become grey again. I don't have personal experience with such concurrent GCs, but
I suspect that this will basically be fine. Concurrent collections finish pretty quickly, and the
mutator usually touches only a subset of the heap. Only that subset of the heap that the mutator is
touching could be re-greyed. Probably, the GC will have to be hybrid incremental and concurrent,
and towards the end of GC when we do the termination stack re-scan, we can ensure that the
collector does some minimal amount of marking. If the minimal amount of marking done by the
collector is large enough, we can ensure that we reach termination before the mutator can regress
progress. The barrier cannot un-terminate the collector; if the collector reaches termination and
the barrier re-greys an object then it's actually doing a generational remembering rather than a
concurrent re-greying.

That's sort of the cute thing about the barrier - it is exactly a re-greying barrier during GC and
it is exactly a remembering barrier in between GCs.

[1] http://www.cs.utexas.edu/ftp/garbage/submit/readable/ppirinen11.ps
[2] http://dl.acm.org/citation.cfm?id=361005
[3] http://www.aicas.com/papers/ISMM132-siebert.pdf

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitChildren):

ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::DFG::LowerDFGToLLVM::loadCellState):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::loadMarkByte): Deleted.

heap/CellState.h: Added.
heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):

heap/CopiedBlock.h:
heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):
(JSC::CopiedBlock::shouldReportLiveBytes): Deleted.

heap/GCLogging.cpp:

(JSC::LoggingFunctor::reviveCells):

heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::clearRememberedSet): Deleted.

heap/Heap.h:
heap/HeapInlines.h:

(JSC::Heap::isLive):
(JSC::Heap::isMarked):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):
(JSC::Heap::isRemembered): Deleted.

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::visitChildren): Deleted.

heap/SlotVisitor.h:

(JSC::SlotVisitor::childCount):
(JSC::SlotVisitor::incrementChildCount):
(JSC::SlotVisitor::dataBeforeVisitingCurrentObject):

heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryVisited):
(JSC::SlotVisitor::heap):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::jumpIfIsRememberedOrInEden):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSCell.h:

(JSC::JSCell::cellState):
(JSC::JSCell::setCellState):
(JSC::JSCell::structureIDOffset):
(JSC::JSCell::indexingTypeOffset):
(JSC::JSCell::cellStateOffset):
(JSC::JSCell::setMarked): Deleted.
(JSC::JSCell::setRemembered): Deleted.
(JSC::JSCell::isMarked): Deleted.
(JSC::JSCell::isRemembered): Deleted.
(JSC::JSCell::gcDataOffset): Deleted.

runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

runtime/JSObject.cpp:

(JSC::JSObject::copyBackingStore):

runtime/JSString.cpp:

(JSC::JSString::visitChildren):

runtime/StructureIDBlob.h:

(JSC::StructureIDBlob::StructureIDBlob):
(JSC::StructureIDBlob::operator=):

runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):
(JSC::WeakMapData::set):

tests/stress/basic-eden-gc-test.js: Added.

Hilariously, an earlier version of this patch that didn't have the NewGrey/OldGrey distinction
would only crash super-big tests that GCd twice but it didn't crash any small focused test. All
it took to show the need for the NewGrey/OldGrey distinction was this super simple test.

Source/WebCore:

No new tests because no new behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

11:49 AM Changeset in webkit [190568] by enrica@apple.com

7 edits in trunk/Source/WebKit2

Cannot select certain text on Wikipedia homepage even when zoomed in.
https://bugs.webkit.org/show_bug.cgi?id=149758
rdar://problem/22407947

Reviewed by Dan Bernstein.

Several functions that handle gestures for text selection are used for both
editable and non editable content. When used on editable content, the point
where the gesture occurs needs to be constrained within the boundaries of the
editable element. In the WebProcess we decide whether to constrain the point or not only based
on the presence of the assisted node.
That unfortunately does not guarantee that the user is actually editing the element,
but only that the element is focused. Since the knowledge about the interaction exists reliably
in the UI process, this patch adds a parameter to each gesture handler that tries to clip
the point, to indicate whether the user is actually interacting with the element so that
in the WebProcess the assisted node information can be used to constrain the point.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::deviceOrientation):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _isInteractingWithAssistedNode]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPointAndBoundary):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::rangeForGranularityAtPoint):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::updateSelectionWithExtentPoint):

11:31 AM Changeset in webkit [190567] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Update setImageSmoothingQuality for additional reviews.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):

11:13 AM Changeset in webkit [190566] by akling@apple.com

6 edits in trunk/Source

Remove unused HistoryItem::targetItem()
<https://webkit.org/b/149803>

Reviewed by Anders Carlsson.

Source/WebCore:

This is ancient code with no remaining clients since 2010 (r53650)

history/HistoryItem.cpp:

(WebCore::HistoryItem::findTargetItem): Deleted.
(WebCore::HistoryItem::targetItem): Deleted.

history/HistoryItem.h:

Source/WebKit/mac:

Remove the only (unused) client of HistoryItem::targetItem().

History/WebHistoryItem.mm:
History/WebHistoryItemPrivate.h:

10:58 AM Changeset in webkit [190565] by Simon Fraser

3 edits in trunk/Tools

Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
available, and tidy up the #ifdefs in the UIKitSPI header.

WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _sendHIDEvent:]):

WebKitTestRunner/ios/UIKitSPI.h:

10:27 AM Changeset in webkit [190564] by mmaxfield@apple.com

19 edits in trunk

Unprefix -webkit-font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=149722

Reviewed by Sam Weinig.

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFontFeatureSettings):

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInheritFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInitialWebkitFontFeatureSettings): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitFontFeatureSettings): Deleted.

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

css3/font-feature-settings-parsing.html:
css3/font-feature-settings-preinstalled-fonts.html:
css3/font-feature-settings-rendering-2.html:
css3/font-feature-settings-rendering.html:
fast/css/inherited-properties-rare-text-expected.txt:
fast/css/inherited-properties-rare-text.html:
fast/text/shaping/shaping-script-order.html:
fast/text/shaping/shaping-selection-rect.html:
fonts/unicode-character-font-crash.html:
scrollbars/scrollbar-scrollbarparts-repaint-crash.html:

10:22 AM Changeset in webkit [190563] by ggaren@apple.com

15 edits in trunk/Source/JavaScriptCore

JSC::SlotVisitor should not be a hot mess
https://bugs.webkit.org/show_bug.cgi?id=149798

Reviewed by Andreas Kling.

I had to debug JSC::SlotVisitor the other day. It was hard to follow.
Let's make it easy to follow.

heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAndSweep):

heap/Heap.h: Deleted the string hash-consing code. It

was dead code.

Since no benchmark noticed the commit that broke this feature, perhaps
it's not worth having.

Either way, the best thing to do with dead code is to delete it.
It's still there in svn if we ever want to pick it up again.

heap/HeapRootVisitor.h:

(JSC::HeapRootVisitor::visit):
(JSC::HeapRootVisitor::visitor): Removed the private append functions
for unsafe pointers and switched HeapRootVisitor over to the public
specially named functions for unsafe pointers.

In future, we should either remove the public specially named functions
or remove HeapRootVisitor, since they serve the same purpose. At least
for now we don't have pairs of functions on SlotVisitor that do the
exact same thing.

heap/SlotVisitor.cpp:

(JSC::validate): Moved this static function to the top of the file.

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset): More hash cons removal.

(JSC::SlotVisitor::append):

(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack): Renamed these functions to
distinguish them from the up-front helper functions that just do type
conversions. These are the functions that actually do stuff.

Moved these functions out of line to make it easier to set breakpoints,
and to enable code changes for debugging, like printf and synchronous
marking, without recompiling the world.

setMarkedAndAppendToMarkStack is roughly 258 bytes long (not including
function prologue and epilogue), so inlining it was probably not a
great idea in the first place.

(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared): Removed some stack probing code.
It was also dead.

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable):
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):
(JSC::SlotVisitor::dump): Moved more code out-of-line. These code paths
are not hot and/or not small, so we need more evidence before we inline
them. The SlotVisitor headers are included everywhere, so we should
make them include less.

Removed "internal" from all function names because it wasn't applied in
any consistent way that would mean anything.

(JSC::JSString::tryHashConsLock): Deleted.
(JSC::JSString::releaseHashConsLock): Deleted.
(JSC::JSString::shouldTryHashCons): Deleted.
(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::validate): Deleted.

heap/SlotVisitor.h:

(JSC::SlotVisitor::resetChildCount): Deleted.
(JSC::SlotVisitor::childCount): Deleted.
(JSC::SlotVisitor::incrementChildCount): Deleted. Removed this child
count thing. It was dead code.

heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarrieredPointer):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer):
(JSC::SlotVisitor::appendUnbarrieredValue):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue): Some renaming and un-inlining.

(JSC::SlotVisitor::appendUnbarrieredWeak): Don't null check our input.
The one true place where null checking happens is our out-of-line
code. All inline functions do only type conversions.

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendValues):
(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::reportExtraMemoryVisited): Some renaming and un-inlining.

(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::unconditionallyAppend): Deleted.
(JSC::SlotVisitor::addOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRootTriState): Deleted.
(JSC::SlotVisitor::opaqueRootCount): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable): Deleted.
(JSC::SlotVisitor::donate): Deleted.
(JSC::SlotVisitor::donateAndDrain): Deleted.
(JSC::SlotVisitor::copyLater): Deleted.

runtime/JSString.h:

(JSC::JSString::finishCreation):
(JSC::JSString::setIs8Bit):
(JSC::JSString::isHashConsSingleton): Deleted.
(JSC::JSString::clearHashConsSingleton): Deleted.
(JSC::JSString::setHashConsSingleton): Deleted. More hash cons removal.

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::currentThreadIsHoldingAPILock):
(JSC::VM::apiLock):
(JSC::VM::haveEnoughNewStringsToHashCons): Deleted.
(JSC::VM::resetNewStringsSinceLastHashCons): Deleted. More hash cons removal.

10:18 AM Changeset in webkit [190562] by zandobersek@gmail.com

10 edits in trunk/Source/WebCore

[GStreamer] Replace uses of std::bind() with lambdas
https://bugs.webkit.org/show_bug.cgi?id=149802

Reviewed by Carlos Garcia Campos.

Instead of std::bind(), use C++ lambdas to create std::function<>
wrappers in GStreamer-related class implementations.

Ref-counted classes are protected by capturing a RefPtr object.
GstObject-derived objects are protected by capturing a GRefPtr object.
Necessary specializations for WebKitVideoSink and WebKitWebSrc are added.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<WebKitVideoSink>):
(WTF::derefGPtr<WebKitVideoSink>):
(WTF::refGPtr<WebKitWebSrc>):
(WTF::derefGPtr<WebKitWebSrc>):

platform/graphics/gstreamer/GRefPtrGStreamer.h:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):

platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):

10:05 AM Changeset in webkit [190561] by fpizlo@apple.com

15 edits in trunk/Source

Inline cache repatching should be throttled if it happens a lot
https://bugs.webkit.org/show_bug.cgi?id=149796
rdar://problem/22674436

Reviewed by Saam Barati.

Source/JavaScriptCore:

We noticed a slight PLT regression from http://trac.webkit.org/changeset/189586. It's because
some pages do things that our inline caches mishandle, in the sense that some ICs end up
repatching themselves very frequently. The cost of repatching outweighs the speed-up on those
pages. There are probably super smart things we could do to tune the IC heuristics to make the
ICs do the right thing on those pages. But more fundamentally, we should ensure that our ICs
back off from continuous repatching if they repatch a lot. That's what this change does.

With this change, StructureStubInfo counts the number of repatchings. If that exceeds a
threshold, we put the IC into a cool-down mode, where some number of future repatch events do
nothing but decrement the cool-down counter. The duration of cool-down increases exponentially
every time we have to do it.

This change also outlines a lot of code. The fact that StructureStubInfo had a lot of inline
methods was starting to get on my nerves. Now it only has inline methods for things that need
to be inlined. Also, I changed StructureStubInfo to be a class rather than a struct. Maybe
with enough such incremental changes, eventually StructureStubInfo will actually behave like a
proper class.

This has no effect on JSC benchmarks. It progresses one of the pages that was hit by the
regression by 15%. It's hard to see if this totally fixes the entire PLT regression since the
geomean regression was very close to noise.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):

bytecode/CodeBlock.h:
bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):

bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

bytecode/PolymorphicAccess.h:
bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

bytecode/StructureStubClearingWatchpoint.h:
bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::~StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initStub):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::addAccessCase):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::considerCaching):
(JSC::StructureStubInfo::willRepatch):
(JSC::StructureStubInfo::willCoolDown):
(JSC::getStructureStubInfoCodeOrigin):
(JSC::StructureStubInfo::StructureStubInfo): Deleted.
(JSC::StructureStubInfo::initGetByIdSelf): Deleted.
(JSC::StructureStubInfo::initPutByIdReplace): Deleted.
(JSC::StructureStubInfo::initStub): Deleted.
(JSC::StructureStubInfo::seenOnce): Deleted.
(JSC::StructureStubInfo::setSeen): Deleted.

jit/JIT.h:
jit/JITOperations.cpp:
jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):

runtime/Options.h:

Source/WTF:

Add some helpers for saturated math.

wtf/MathExtras.h:

(WTF::incrementWithSaturation):
(WTF::leftShiftWithSaturation):

8:12 AM Changeset in webkit [190560] by Antti Koivisto

4 edits in trunk/Source/WebKit2

Remove CancelResourceLoader message
https://bugs.webkit.org/show_bug.cgi?id=149801

Reviewed by Andreas Kling.

It has no clients.

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::messageSenderDestinationID):
(WebKit::WebResourceLoader::detachFromCoreLoader):
(WebKit::WebResourceLoader::cancelResourceLoader): Deleted.

WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.messages.in:

7:38 AM Changeset in webkit [190559] by akling@apple.com

7 edits in trunk/Source

Remove unused HistoryItem::parent
<https://webkit.org/b/149803>

Reviewed by Anders Carlsson.

Source/WebCore:

Remove the effectively-unused "parent" field from HistoryItem.
This also allows us to get rid of a HistoryItem constructor.

history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem): Deleted.
(WebCore::HistoryItem::reset): Deleted.
(WebCore::HistoryItem::parent): Deleted.
(WebCore::HistoryItem::setParent): Deleted.

history/HistoryItem.h:

(WebCore::HistoryItem::create): Deleted.

loader/HistoryController.cpp:

(WebCore::HistoryController::initializeItem): Deleted.

Source/WebKit/mac:

Remove the only (unused) client of HistoryItem's with-parent constructor.

History/WebHistoryItem.mm:

(-[WebHistoryItem initWithURL:target:parent:title:]): Deleted.

History/WebHistoryItemInternal.h:

7:22 AM WebInspector edited by Csaba Osztrogonác

(diff)

7:20 AM BadContent edited by Csaba Osztrogonác

add more spammer (diff)

12:13 AM Changeset in webkit [190558] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794

Reviewed by Martin Robinson.

Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.

GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.

The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.

The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).

platform/graphics/GLContext.h:
platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext):

platform/graphics/egl/GLContextEGL.h:
platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::createSharingGLContext):

12:04 AM Changeset in webkit [190557] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793

Reviewed by Carlos Garcia Campos.

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.

Oct 4, 2015:

10:55 PM Changeset in webkit [190556] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
https://bugs.webkit.org/show_bug.cgi?id=149792

Reviewed by Martin Robinson.

WebKitTestRunner/PlatformGTK.cmake: Don't list build targets

for WebKitTestRunner multiple times.

4:25 PM Changeset in webkit [190555] by fpizlo@apple.com

14 edits
1 delete in trunk/Source/JavaScriptCore

CodeBlock.h shouldn't be included from everywhere
https://bugs.webkit.org/show_bug.cgi?id=149785

Reviewed by Andreas Kling.

JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
dfg/DFGAdaptiveStructureWatchpoint.cpp:
interpreter/CallFrame.cpp:

(JSC::CallFrame::callSiteBitsAreBytecodeOffset):
(JSC::CallFrame::callSiteBitsAreCodeOriginIndex):
(JSC::CallFrame::callSiteAsRawBits):
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::hasActivation):
(JSC::CallFrame::uncheckedActivation):
(JSC::CallFrame::stack):

interpreter/CallFrameInlines.h: Removed.
interpreter/Interpreter.cpp:
interpreter/StackVisitor.cpp:
runtime/DirectArguments.cpp:
runtime/ErrorInstance.cpp:
runtime/JSArray.cpp:
runtime/JSCInlines.h:
runtime/LiteralParser.cpp:
runtime/NullSetterFunction.cpp:
tools/JSDollarVMPrototype.cpp:

3:30 PM Changeset in webkit [190554] by dbates@webkit.org

2 edits in trunk/Tools

Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, support calling build-layouttestrelay without --ios-simulator so long
as we are building on a Mac.

Scripts/build-layouttestrelay:

1:49 PM Changeset in webkit [190553] by ap@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Fix a typo in ChangeLog.

1:47 PM Changeset in webkit [190552] by ap@apple.com

2 edits in trunk/LayoutTests

Mark tests as flay for
https://bugs.webkit.org/show_bug.cgi?id=148890

http/tests/contentfiltering/load-substitute-data-from-appcache.html and
http/tests/appcache/decide-navigation-policy-after-delay.html crash
in DocumentLoader::dataReceived sometimes

platform/wk2/TestExpectations:

11:33 AM Changeset in webkit [190551] by Nikita Vasilyev

4 edits in trunk

Web Inspector: Wrong column numbers in error object views
https://bugs.webkit.org/show_bug.cgi?id=149795

Source/WebInspectorUI:

Convert columnNumber and lineNumber properties from strings to numbers
to prevent accidental string concatenations.

Reviewed by Timothy Hatcher.

UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace._parseStackTrace):

LayoutTests:

Reviewed by Timothy Hatcher.

inspector/debugger/js-stacktrace-expected.txt:

10:49 AM Changeset in webkit [190550] by ap@apple.com

2 edits in trunk/Tools

Support Trac 1.0.x XML timeline link format
https://bugs.webkit.org/show_bug.cgi?id=149786

Reviewed by Lucas Forschler.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject):

10:01 AM Changeset in webkit [190549] by ap@apple.com

2 edits in trunk/Tools

Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789

Reviewed by Lucas Forschler.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.

9:57 AM Changeset in webkit [190548] by ap@apple.com

2 edits in trunk/Tools

Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791

Reviewed by Lucas Forschler.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):

Oct 3, 2015:

7:38 PM Changeset in webkit [190547] by commit-queue@webkit.org

5 edits in trunk/Source

"Plug-in is blocked" message doesn't draw correctly
https://bugs.webkit.org/show_bug.cgi?id=149741
<rdar://problem/22920949>

Patch by Conrad Shultz and Ricky Mondello.

Patch by Ricky Mondello <Ricky Mondello> on 2015-10-03
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests are added.

Add PluginData API to check whether a MIME type is supported, regardless of plug-in visibility.

plugins/PluginData.cpp:

(WebCore::PluginData::getWebVisibleMimesAndPluginIndices): Adopt getMimesAndPluginIndiciesForPlugins.
(WebCore::PluginData::getMimesAndPluginIndices): Added.
(WebCore::PluginData::getMimesAndPluginIndiciesForPlugins): Essentially factored out of

getWebVisibleMimesAndPluginIndices.

(WebCore::PluginData::supportsMimeType): Added. Somewhat similar to preexisting supportsWebVisibleMimeType.

plugins/PluginData.h: Declare supportsMimeType.

Source/WebKit2:

If a WebKit client sets plug-in X to not be visible to the web, that doesn't mean we shouldn't consult
that plug-in when determining what kind of object type an object is. Properly classifying a non-web-visible
Netscape plug-in as such allows its bounds to properly measured, allowing it to be drawn properly.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType): Use PluginData's supportsMimeType, rather than its

supportsWebVisibleMimeType, when determining the ObjectContentType for a MIME type on a url.

6:45 PM Changeset in webkit [190546] by commit-queue@webkit.org

56 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190522.
https://bugs.webkit.org/show_bug.cgi?id=149787

Caused a lot of leaks (Requested by ap on #webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190522

5:43 PM Changeset in webkit [190545] by ap@apple.com

2 edits in trunk/LayoutTests

fast/events/overflow-scroll-fake-mouse-move.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=138697

Reviewed by Brent Fulgham.

fast/events/overflow-scroll-fake-mouse-move.html:

3:13 AM Changeset in webkit [190544] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Make the test added in r190530 not time out on the ports that don't enable shadow DOM.

Call waitUntilDone after calling attachShadow so that an exception thrown by calling attachShadow
will prevent waitUntilDone from getting called on those ports.

fast/shadow-dom/insert-child-to-assigned-node.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed