Context Navigation

← Previous Period
Next Period →

Timeline

Mar 21, 2016:

8:48 PM Changeset in webkit [198519] by Joseph Pecoraro

2 edits in trunk/LayoutTests

Skip HeapSnapshot test on WebKit1. Shared VM skews the data.

Rubber-stamped by Timothy Hatcher.

In this case, snapshots with snapshots with snapshots in the same VM
causes the test to run out of memory. This does not happen in WebKit2.

platform/mac-wk1/TestExpectations:

7:58 PM Changeset in webkit [198518] by rniwa@webkit.org

4 edits in trunk/Websites/perf.webkit.org

Commit log viewer repaints too frequently after r198499
https://bugs.webkit.org/show_bug.cgi?id=155732

Reviewed by Joseph Pecoraro.

The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
and avoiding work in the commit log viewer when the requested repository and the revision range were
the same as those of the last request.

public/v3/components/commit-log-viewer.js:

(CommitLogViewer):
(CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
identical to the one we already have to avoid repaints and issuing multiple network requests.

public/v3/components/interactive-time-series-chart.js:

(InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
indicator hadn't changed.

public/v3/pages/chart-pane.js:

(ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
the URL. We need to check whether the lock state had changed. The old condition was also redundant
since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.

6:53 PM Changeset in webkit [198517] by matthew_hanson@apple.com

5 edits in tags/Safari-601.6.12/Source

Versioning

6:47 PM Changeset in webkit [198516] by matthew_hanson@apple.com

5 edits in tags/Safari-601.1.46.122/Source

Versioning.

6:39 PM Changeset in webkit [198515] by matthew_hanson@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

6:36 PM Changeset in webkit [198514] by matthew_hanson@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

6:35 PM Changeset in webkit [198513] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[JSC] Clean up Math.floor thunk and use SSE round instruction
https://bugs.webkit.org/show_bug.cgi?id=155705

Reviewed by Geoffrey Garen.

SSE now allow us to use round instruction to implement Math.floor.
MacroAssembler's floorDouble is now only used in ARM64, but it can be allowed in x86 SSE.

jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):

6:21 PM Changeset in webkit [198512] by matthew_hanson@apple.com

1 copy in tags/Safari-601.1.46.122

New Tag.

5:51 PM Changeset in webkit [198511] by Matt Baker

3 edits
1 add in trunk/Source/WebInspectorUI

Web Inspector: New icon for Heap Allocations timeline
https://bugs.webkit.org/show_bug.cgi?id=155731
<rdar://problem/25275494>

Reviewed by Joseph Pecoraro and Timothy Hatcher.

UserInterface/Images/HeapAllocationsInstrument.svg: Added.

New artwork from Jon Davis.

UserInterface/Views/TimelineIcons.css:

(.heap-allocations-icon .icon):
(body:not(.mac-platform, .windows-platform) .memory-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon):
New icon styles/fallbacks for GTK.

UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Add new icon class to UI helper method.

5:51 PM Changeset in webkit [198510] by matthew_hanson@apple.com

1 copy in tags/Safari-601.6.12

New Tag.

5:30 PM Changeset in webkit [198509] by jonlee@apple.com

14 edits
2 copies
2 deletes in trunk/PerformanceTests

Update benchmark tests
https://bugs.webkit.org/show_bug.cgi?id=155723

Reviewed by Darin Adler.
Provisionally reviewed by Said Abou-Hallawa.

Add quadratic and bezier segments to the canvas path test.

Animometer/resources/runner/tests.js: Some of the query strings are unnecessary.

Rename the test.

Animometer/tests/master/resources/canvas-stage.js:

(tune): Update to be able to take an array of possible constructors. Choose one randomly.

Animometer/tests/master/resources/canvas-tests.js:

(CanvasLinePoint.Utilities.createClass): Move the point selection out to a separate
function called randomPoint() for reuse. Move X_LOOPS, Y_LOOPS, and offsets into the
class definition.
(randomPoint): Scale the grid down a little bit so that the lines along the edge of the
canvas are not cut off when the stroke size is thick.
(CanvasQuadraticSegment): Added.
(CanvasBezierSegment): Added.
(SimpleCanvasStage): Pass in an array of the different segment types. Since line segments
are short compared to the curved ones, make it twice as likely to render a line segment.
(SimpleCanvasStage.animate): Update the drawing code so that we render all line segments.

Add a helper method that selects a random element from an array.

Animometer/tests/resources/main.js:

(Stage.randomElementInArray): Select a random element from the provided array.

Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js: Refactor.
Animometer/tests/dom/resources/leaves.js: Ditto.
Animometer/tests/master/resources/dom-particles.js: Ditto.
Animometer/tests/master/resources/image-data.js: Ditto.
Animometer/tests/master/resources/leaves.js: Ditto.
Animometer/tests/simple/resources/simple-canvas-paths.js: Ditto.

Add canvas tests that includes all stroke and fill paths. This makes it possible to avoid having to
include the full simple canvas suite for perf testing.

Animometer/resources/debug-runner/tests.js: Add new tests. Move the canvas test into the Canvas

suite.

Animometer/tests/simple/resources/simple-canvas-paths.js: Add a CanvasStroke and CanvasFill particle

that random selects an object to render.

Animometer/resources/debug-runner/tests.js: Move 3D suite before basic canvas suite.

When updating the perf bot script, we will include the suites up to this one, but exclude
the basic canvas suite.

Move compositing transforms test to HTML suite and remove the empty Miscellaneous suite.

Animometer/resources/debug-runner/tests.js:
Animometer/tests/dom/compositing-transforms.html: Renamed from PerformanceTests/Animometer/tests/misc/compositing-transforms.html.
Animometer/tests/dom/resources/compositing-transforms.js: Renamed from PerformanceTests/Animometer/tests/misc/resources/compositing-transforms.js.

Clean up miscellaneous test suite. Add a canvas ellipse test, and remove the other
canvas tests.

Animometer/resources/debug-runner/tests.js: Add ellipse tests to the simple suite.
Animometer/tests/misc/canvas-electrons.html: Removed.
Animometer/tests/misc/canvas-stars.html: Removed.
Animometer/tests/misc/resources/canvas-electrons.js: Removed.
Animometer/tests/misc/resources/canvas-stars.js: Removed.
Animometer/tests/simple/resources/simple-canvas-paths.js: Add ellipse primitives.

Merge text tests together into one.

Animometer/resources/runner/tests.js: Remove international.html.
Animometer/tests/master/international.html: Removed.
Animometer/tests/master/resources/text.js:

(animate): Update styling. Manually calculate gradients for the shadow particles.
Reduce the step size for y direction to avoid cutting text off at the margins. Increase
step for x since there will be a little more room.

Animometer/tests/master/text.html: Add more translations and lay it out in a table.

5:22 PM Changeset in webkit [198508] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Fix A/B testing after r198503.

public/include/build-requests-fetcher.php:

5:06 PM Changeset in webkit [198507] by Brent Fulgham

4 edits in trunk

Improve SharedBuffer testing
https://bugs.webkit.org/show_bug.cgi?id=93078
<rdar://problem/25277829>

Reviewed by Ryosuke Niwa.

Source/WebCore:

platform/SharedBuffer.h: Mark a few methods as WEBCORE_EXPORT so they

can be used by TestWebKitAPI.

Tools:

Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
<https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
and a Blink patch by <tyoshino@chromium.org>
<https://src.chromium.org/viewvc/blink?view=rev&revision=151617>

Add three test cases from the Blink project that cover various append,
copy, and createArrayBuffer calls.

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

4:29 PM Changeset in webkit [198506] by Alan Bujtas

3 edits
2 adds in trunk

WebCore::RenderTableCell::setCol should put a cap on the column value.
https://bugs.webkit.org/show_bug.cgi?id=155642
<rdar://problem/15895201>

Reviewed by Simon Fraser.

This patch ensures that we don't crash when the column number is large enough.
see webkit.org/b/71135 for more information.

Source/WebCore:

Test: tables/colspan-with-large-value-crash.html

rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setCol):

LayoutTests:

tables/colspan-with-large-value-crash-expected.txt: Added.
tables/colspan-with-large-value-crash.html: Added.

4:05 PM Changeset in webkit [198505] by matthew_hanson@apple.com

8 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r197967. rdar://problem/25271137

3:57 PM Changeset in webkit [198504] by beidson@apple.com

5 edits in trunk/LayoutTests

storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=154748

Reviewed by Alex Christensen.

platform/mac/TestExpectations:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:

3:27 PM Changeset in webkit [198503] by rniwa@webkit.org

6 edits in trunk/Websites/perf.webkit.org

Analysis task page is broken after r198479
https://bugs.webkit.org/show_bug.cgi?id=155735

Rubber-stamped by Chris Dumez.

public/api/measurement-set.php:

(AnalysisResultsFetcher::fetch_commits): We need to emit the commit ID as done for regular data.

public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::fetch_roots_for_set_if_needed): Ditto. Don't use a fake ID after r198479.

public/v3/models/commit-log.js:

(CommitLog): Assert that all commit log IDs are integers to catch regressions like this in future.

public/v3/models/root-set.js:

(RootSet): Don't resolve Repository here as doing so would modify the shared "root" entry in the JSON
we fetched, and subsequent construction of RootSet would fail since this line would blow up trying to
find the repository with "[object]" as the ID.

public/v3/models/test-group.js:

(TestGroup._createModelsFromFetchedTestGroups): Resolve Repository here.

3:25 PM Changeset in webkit [198502] by Simon Fraser

7 edits
3 adds in trunk

[iOS WK2] Use larger tiles when possible to reduce per-tile painting overhead
https://bugs.webkit.org/show_bug.cgi?id=155734
rdar://problem/24968144

Reviewed by Tim Horton.

Source/WebCore:

The existing tile size logic is wired to adjustScrollbars, which doesn't fire
when scrolling is delegated. For iOS WK2, key off of a new unobscuredContentSizeChanged()
function that runs when the UI process tells told WebCore that the unobscured size
has changed. In addition, contentsResized() is used to update scrollability when
page changes size.

page/FrameView.cpp:

(WebCore::FrameView::contentsResized):
(WebCore::FrameView::addedOrRemovedScrollbar):
(WebCore::FrameView::adjustTiledBackingScrollability): Handle both delegated and non-delegated
scrolling; the former looks at the visible size (based on the unobscuredVisibleContentRect),
the latter at the presence of scrollbars.
(WebCore::FrameView::unobscuredContentSizeChanged):

page/FrameView.h:
platform/ScrollView.h:

(WebCore::ScrollView::unobscuredContentSizeChanged):

platform/graphics/ca/TileController.cpp:

(WebCore::TileController::adjustTileCoverageRect): Use kDefaultTileSize rather than the
tile size, to retain the old amount of overdraw.
(WebCore::TileController::tileSize): There was a bug in the not-scrollable case; we need
to scale.

platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::setUnobscuredContentSize):

LayoutTests:

New results with larger page tiles in WK2.

platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
platform/ios-simulator-wk2/compositing/tiling/transform-origin-tiled-expected.txt: Added.

3:22 PM Changeset in webkit [198501] by Brent Fulgham

8 edits
2 adds in trunk

Source/WebKit/win:
[Win] Connect layoutTestController.findString() to support testing
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2016-03-21
Reviewed by Alex Christensen.

Implement WebView::findString to support testing efforts.

Interfaces/IWebViewPrivate.idl: Add API declaration.
WebView.cpp:
WebView.h:

Tools:
[Win] Connect layoutTestController.findString() to support testing
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2016-03-21
Reviewed by Alex Christensen.

Implement TestRunner::findString().

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::findString):

LayoutTests:
[Win] Connect layoutTestController.findString() to support testing
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2016-03-21
Reviewed by Alex Christensen.

platform/win/TestExpectations: Unskip test.
platform/win/editing/text-iterator/findString-expected.txt: Added.

3:07 PM Changeset in webkit [198500] by Chris Dumez

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r197552.

May have caused a ~2% PLT regression on iOS

Reverted changeset:

"Drop DocumentSharedObjectPool immediately when going into
PageCache."
https://bugs.webkit.org/show_bug.cgi?id=154986
http://trac.webkit.org/changeset/197552

1:54 PM Changeset in webkit [198499] by rniwa@webkit.org

11 edits in trunk/Websites/perf.webkit.org

v3 UI sometimes don't update the list of revisions on the commit log viewer
https://bugs.webkit.org/show_bug.cgi?id=155729

Rubber-stamped by Chris Dumez.

Fixed multiple bugs that were affecting the list of blame range and commit logs for the range weren't
updated in some cases on v3 UI. Also, the commit log viewer state is now a part of the URL state so
opening and closing the commit log viewer will persist across page loads.

Also fixed a regression from r198479 that Test object can't be created for a top level test.

public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype.configure):
(ChartPaneBase.prototype._mainSelectionDidChange): Fixed the bug that the list of blame range nor the
commit log viewer don't get updated when the selected range changes.
(ChartPaneBase.prototype._indicatorDidChange):
(ChartPaneBase.prototype._didFetchData):
(ChartPaneBase.prototype._updateStatus): Extracted from _indicatorDidChange and _didFetchData.
(ChartPaneBase.prototype._requestOpeningCommitViewer): Renamed from _openCommitViewer.

public/v3/components/chart-status-view.js:

(ChartStatusView.prototype.updateStatusIfNeeded): Fixed the bug that the blame range doesn't get set
on the initial page load when the selection range is set but the chart data hadn't been fetched yet.

public/v3/components/commit-log-viewer.js:

(CommitLogViewer.prototype.view): Fixed the bug that we don't clear out the old list of commits while
loading the next set of commits to show as it looked as if the list was never updated.
(CommitLogViewer.prototype.render): Fixed the bug that the view always show the last repository name
even if there were nothing being fetched or commits to show.

public/v3/components/pane-selector.js:

(PaneSelector.prototype.focus): Removed superfluous call to console.log.

public/v3/models/data-model.js:

(DataModelObject.listForStaticMap): Generalized the code for all to fix the bug in Test.
(DataModelObject.all):

public/v3/models/test.js:

(Test): Fixed the bug that this code was relying on the static map to be an array.
(Test.topLevelTests): Use newly added listForStaticMap to convert the dictionary to an array.

public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView): Always initialize _usedRevisionRange as a triple to simplify code elsewhere.
(ChartPaneStatusView.prototype.render): Invoke _revisionCallback when user clicks on a repository
expansion mark (>>). Also fixed click handler from the row since this made selecting revision range
on the view cumbersome. Now user has to explicitly click on the expansion mark (>>).
(ChartPaneStatusView.prototype._setRevisionRange): Now takes shouldNotify, from, and to as arguments
as this function must not invoke_revisionCallback inside _updateRevisionListForNewCurrentRepository.
(ChartPaneStatusView.prototype.moveRepositoryWithNotification): Use newly added setCurrentRepository
instead of manually invoking setCurrentRepository and updateRevisionListWithNotification.
(ChartPaneStatusView.prototype.setCurrentRepository): Fixed the bug that we weren't updating the
blame list here.
(ChartPaneStatusView.prototype.updateRevisionList): Renamed from updateRevisionListWithNotification
since we no longer call _revisionCallback. In general, callbacks are only meant to communicate user
initiated actions, and not program induced updates like this API so this was a bad pattern anyway.
ChartPane now explicitly updates the commit log viewer instead of relying on this function calling
_requestOpeningCommitViewer implicitly.
(ChartPaneStatusView.prototype._updateRevisionListForNewCurrentRepository): Extracted from
updateRevisionListWithNotification so that setCurrentRepository can also call this function.

public/v3/pages/chart-pane.js:

(ChartPane.prototype._requestOpeningCommitViewer): Overrides ChartPaneBase's method. Open the same
repository in other panes via ChartsPage.setOpenRepository.
(ChartPane.prototype.setOpenRepository): This method is called when the user selected a repository in
another pane. Open the same repository in this pane if it wasn't already open.

public/v3/pages/charts-page.js:

(ChartsPage): Added this._currentRepositoryId.
(ChartsPage.prototype.serializeState): Serialize _currentRepositoryId.
(ChartsPage.prototype.updateFromSerializedState): Set the commit log viewer's
(ChartsPage.prototype.setOpenRepository): Added.

tests/api-measurement-set.js: Fixed a test after r198479.

1:23 PM Changeset in webkit [198498] by Simon Fraser

4 edits in trunk/Source/WebCore

Very flashy scrolling on http://quellish.tumblr.com page
https://bugs.webkit.org/show_bug.cgi?id=155728
rdar://problem/22299375

Reviewed by Zalan Bujtas.

http://quellish.tumblr.com/post/126712999812/how-on-earth-the-facebook-ios-application-is-so
has many elements that are nested inside elements with non-equal corner radius clipping.
This requires building bezier paths for the rounded-rect clip which is expensive.

For many rows of the table, we can avoid the rounded-rect clipping because the intersection
of the paintDirtyRect and the clip is actually rectangular.

platform/graphics/FloatRoundedRect.cpp:

(WebCore::FloatRoundedRect::intersectionIsRectangular):

platform/graphics/FloatRoundedRect.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

1:13 PM Changeset in webkit [198497] by Alan Bujtas

21 edits in trunk

Web Inspector search icon does not fit when zoomed in.
https://bugs.webkit.org/show_bug.cgi?id=155708

Reviewed by Simon Fraser.

Adjusts the paint rect for the magnifier icon so that it fits even when zoomed in.

Source/WebCore:

Covered by existing tests.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

LayoutTests:

fast/forms/search/search-padding-cancel-results-buttons-expected.txt:
platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt:
platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/forms/box-shadow-override-expected.txt:
platform/mac/fast/forms/control-restrict-line-height-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/placeholder-position-expected.txt:
platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
platform/mac/fast/forms/search-rtl-expected.txt:
platform/mac/fast/forms/search-styled-expected.txt:
platform/mac/fast/forms/search-vertical-alignment-expected.txt:
platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
platform/mac/fast/forms/searchfield-heights-expected.txt:
platform/mac/fast/repaint/search-field-cancel-expected.txt:
platform/mac/fast/replaced/width100percent-searchfield-expected.txt:

12:28 PM Changeset in webkit [198496] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Enable preview of images as attachments.
https://bugs.webkit.org/show_bug.cgi?id=155674
rdar://problem/25242656

Reviewed by Darin Adler.

If the client cannot handle image preview, but can handle attachments,
let them handle images as attachments.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _dataForPreviewItemController:atPosition:type:]):

12:22 PM Changeset in webkit [198495] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

V3 Perf Dashboard should automatically select initial range when creating a new task
https://bugs.webkit.org/show_bug.cgi?id=155677

Reviewed by Joseph Pecoraro.

Select the entire range of points for which the analysis task is created by default so that creating
a test group to confirm the regression / progression is easy.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
the analysis task if the user had never modified selection.
(AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
modified the selection so set _selectionWasModifiedByUser true here unconditionally.

11:09 AM Changeset in webkit [198494] by jonlee@apple.com

3 edits in trunk/PerformanceTests

Add a link to show debug data
https://bugs.webkit.org/show_bug.cgi?id=155724

Reviewed by Simon Fraser.

Animometer/developer.html: Attach the onclick handler to the score.
Animometer/index.html: Ditto.

10:54 AM Changeset in webkit [198493] by peavo@outlook.com

2 edits in trunk/Source/WebCore

[WinCairo][MediaFoundation] Crash when media player is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=155716

Reviewed by Alex Christensen.

Increase the reference count on the video presenter object in the ActivateObject method
to avoid referencing a deleted object when the media player is destroyed.

platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::ActivateObject):

10:52 AM Changeset in webkit [198492] by eric.carlson@apple.com

119 edits in trunk

Add a WebRTC specific compile flag
https://bugs.webkit.org/show_bug.cgi?id=155663

Reviewed by Jer Noble.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsGTK.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Guard WebRTC-only files with ENABLE(WEB_RTC) rather than ENABLE(MEDIA_STREAM).

Reviewed by Jer Noble.

Modules/mediastream/MediaEndpointPeerConnection.cpp:
Modules/mediastream/MediaEndpointPeerConnection.h:
Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/PeerConnectionStates.h:
Modules/mediastream/RTCConfiguration.cpp:
Modules/mediastream/RTCConfiguration.h:
Modules/mediastream/RTCConfiguration.idl:
Modules/mediastream/RTCDTMFSender.cpp:
Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDTMFSender.idl:
Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
Modules/mediastream/RTCDTMFToneChangeEvent.h:
Modules/mediastream/RTCDTMFToneChangeEvent.idl:
Modules/mediastream/RTCDataChannel.cpp:
Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCDataChannel.idl:
Modules/mediastream/RTCDataChannelEvent.cpp:
Modules/mediastream/RTCDataChannelEvent.h:
Modules/mediastream/RTCDataChannelEvent.idl:
Modules/mediastream/RTCIceCandidate.cpp:
Modules/mediastream/RTCIceCandidate.h:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCIceCandidateEvent.cpp:
Modules/mediastream/RTCIceCandidateEvent.h:
Modules/mediastream/RTCIceCandidateEvent.idl:
Modules/mediastream/RTCIceServer.h:
Modules/mediastream/RTCIceServer.idl:
Modules/mediastream/RTCOfferAnswerOptions.cpp:
Modules/mediastream/RTCOfferAnswerOptions.h:
Modules/mediastream/RTCPeerConnection.cpp:
Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/RTCPeerConnection.js:

(createOffer):

Modules/mediastream/RTCPeerConnectionInternals.js:
Modules/mediastream/RTCRtpReceiver.cpp:
Modules/mediastream/RTCRtpReceiver.h:
Modules/mediastream/RTCRtpReceiver.idl:
Modules/mediastream/RTCRtpSender.cpp:
Modules/mediastream/RTCRtpSender.h:
Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpSenderReceiverBase.h:
Modules/mediastream/RTCSessionDescription.cpp:
Modules/mediastream/RTCSessionDescription.h:
Modules/mediastream/RTCSessionDescription.idl:
Modules/mediastream/RTCStatsReport.cpp:
Modules/mediastream/RTCStatsReport.idl:
Modules/mediastream/RTCStatsResponse.cpp:
Modules/mediastream/RTCStatsResponse.idl:
Modules/mediastream/RTCTrackEvent.cpp:
Modules/mediastream/RTCTrackEvent.h:
Modules/mediastream/RTCTrackEvent.idl:
Modules/mediastream/SDPProcessor.cpp:
Modules/mediastream/SDPProcessor.h:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSDictionary.h:
bindings/js/JSRTCIceCandidateCustom.cpp:
bindings/js/JSRTCPeerConnectionCustom.cpp:
bindings/js/JSRTCSessionDescriptionCustom.cpp:
bindings/js/JSRTCStatsResponseCustom.cpp:
bindings/js/WebCoreJSBuiltinInternals.cpp:

(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::initialize):

bindings/js/WebCoreJSBuiltinInternals.h:

(WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals):

bindings/js/WebCoreJSBuiltins.h:

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::mediaDevicesBuiltins):
(WebCore::JSBuiltinFunctions::navigatorUserMediaBuiltins):
(WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins):
(WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins):

dom/EventNames.in:
dom/EventTargetFactory.in:
loader/FrameLoaderClient.h:
platform/mediastream/IceCandidate.h:
platform/mediastream/MediaEndpoint.cpp:
platform/mediastream/MediaEndpoint.h:
platform/mediastream/MediaEndpointConfiguration.cpp:
platform/mediastream/MediaEndpointConfiguration.h:
platform/mediastream/MediaEndpointSessionConfiguration.h:
platform/mediastream/MediaPayload.h:
platform/mediastream/PeerMediaDescription.h:
platform/mediastream/RTCConfigurationPrivate.h:
platform/mediastream/RTCDTMFSenderHandler.h:
platform/mediastream/RTCDTMFSenderHandlerClient.h:
platform/mediastream/RTCDataChannelHandler.h:
platform/mediastream/RTCDataChannelHandlerClient.h:
platform/mediastream/RTCIceCandidateDescriptor.cpp:
platform/mediastream/RTCIceCandidateDescriptor.h:
platform/mediastream/RTCIceServerPrivate.h:
platform/mediastream/RTCPeerConnectionHandler.cpp:
platform/mediastream/RTCPeerConnectionHandler.h:
platform/mediastream/RTCPeerConnectionHandlerClient.h:
platform/mediastream/RTCSessionDescriptionDescriptor.cpp:
platform/mediastream/RTCSessionDescriptionDescriptor.h:
platform/mediastream/RTCSessionDescriptionRequest.h:
platform/mediastream/RTCStatsRequest.h:
platform/mediastream/RTCStatsResponseBase.h:
platform/mediastream/RTCVoidRequest.h:
platform/mediastream/SDPProcessorScriptResource.cpp:
platform/mediastream/SDPProcessorScriptResource.h:
platform/mock/MockMediaEndpoint.cpp:
platform/mock/MockMediaEndpoint.h:
platform/mock/RTCDTMFSenderHandlerMock.cpp:
platform/mock/RTCDTMFSenderHandlerMock.h:
platform/mock/RTCDataChannelHandlerMock.cpp:
platform/mock/RTCDataChannelHandlerMock.h:
platform/mock/RTCNotifiersMock.cpp:
platform/mock/RTCNotifiersMock.h:
platform/mock/RTCPeerConnectionHandlerMock.cpp:
platform/mock/RTCPeerConnectionHandlerMock.h:
platform/mock/TimerEventBasedMock.h:

(WebCore::RenderLayerBacking::paintIntoLayer):

testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::enableMockSpeechSynthesizer):
(WebCore::Internals::enableMockMediaEndpoint):
(WebCore::Internals::enableMockRTCPeerConnectionHandler):
(WebCore::Internals::setMockMediaCaptureDevicesEnabled):

testing/Internals.h:

LayoutTests:

Reviewed by Jer Noble.

platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:

10:47 AM Changeset in webkit [198491] by Ryan Haddad

1 edit
1 move in trunk/LayoutTests

Moving the -expected.txt file for accessibility/radio-button-group-members.html

Unreviewed test gardening.

accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/mac/radio-button-group-members-expected.txt.

10:17 AM Changeset in webkit [198490] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fixed compilation with GCC 4.8.
https://bugs.webkit.org/show_bug.cgi?id=155698

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-03-21
Reviewed by Alexey Proskuryakov.

GCC 4.8 does not allow aggregate initialization for type with deleted
constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.

dfg/DFGCSEPhase.cpp: Added ctor for ImpureDataSlot.

10:10 AM Changeset in webkit [198489] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking two inspector tests as flaky timeouts on Mac.
https://bugs.webkit.org/show_bug.cgi?id=155607

Unreviewed test gardening.

platform/mac/TestExpectations:

8:59 AM Changeset in webkit [198488] by jh718.park@samsung.com

17 edits in trunk/Source

[JSC] Add ArrayBuffer::tryCreate and change the callsites where it is needed
https://bugs.webkit.org/show_bug.cgi?id=155328

Reviewed by Darin Adler.

Source/JavaScriptCore:

API/JSTypedArray.cpp:

(JSObjectMakeTypedArray):
(JSObjectMakeArrayBufferWithBytesNoCopy):

runtime/ArrayBuffer.h:

(JSC::ArrayBuffer::create):
(JSC::ArrayBuffer::tryCreate):
(JSC::ArrayBuffer::createUninitialized):
(JSC::ArrayBuffer::tryCreateUninitialized):
(JSC::ArrayBuffer::createInternal):

runtime/GenericTypedArrayViewInlines.h:

(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):

runtime/JSArrayBufferConstructor.cpp:

(JSC::constructArrayBuffer):

Source/WebCore:

No new tests, no new behaviours.

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::consumeText):

Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::didFinishLoading):

bindings/js/JSDOMPromise.h:

(WebCore::char>>):

dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

dom/MessageEvent.h:
fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didReceiveResponse):
(WebCore::FileReaderLoader::didReceiveData):
(WebCore::FileReaderLoader::arrayBufferResult):

html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::associateBufferDataImpl):

html/track/DataCue.cpp:

(WebCore::DataCue::DataCue):
(WebCore::DataCue::data):
(WebCore::DataCue::setData):
(WebCore::DataCue::cueContentsMatch):

html/track/DataCue.h:
html/track/InbandDataTextTrack.cpp:

(WebCore::InbandDataTextTrack::addDataCue):
(WebCore::InbandDataTextTrack::removeCue):

platform/mac/SerializedPlatformRepresentationMac.mm:

(WebCore::jsValueWithDataInContext):

5:58 AM Changeset in webkit [198487] by youenn.fablet@crf.canon.fr

1 edit in trunk/LayoutTests/platform/mac/TestExpectations

Unreviewed.
Marking imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-2.html as flaky (Pass, Crash)

3:42 AM Changeset in webkit [198486] by svillar@igalia.com

7 edits in trunk

[css-grid] Fix percentage tracks' size computation in grids with gutters
https://bugs.webkit.org/show_bug.cgi?id=153825

Reviewed by Darin Adler.

Source/WebCore:

The track sizing algorithm is passed an available size
(freeSpace in the code) where to size the tracks. The total size of the grid
gutters was pre-removed from that available size because we cannot use it to size
the tracks. However that available size is also used to compute the size of
percentage tracks. As we're removing the size of the gutters, the base size for
percentage computations is smaller than it should be.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):

LayoutTests:

fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt:
fast/css-grid-layout/grid-gutters-and-flex-content.html:
fast/css-grid-layout/grid-gutters-and-tracks-expected.txt:
fast/css-grid-layout/grid-gutters-and-tracks.html:

2:46 AM Changeset in webkit [198485] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r198484 - [GTK] scrollbar thumb clipped in 2.11.92
https://bugs.webkit.org/show_bug.cgi?id=155586

Reviewed by Michael Catanzaro.

In the current version of Adwaita, the scrollbar itself also has a
one pixel border that we are not taking into account.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
in indicator mode, instead of only the thumb size, to correctly
position the thumb in indicator mode.

2:18 AM Changeset in webkit [198484] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] scrollbar thumb clipped in 2.11.92
https://bugs.webkit.org/show_bug.cgi?id=155586

Reviewed by Michael Catanzaro.

In the current version of Adwaita, the scrollbar itself also has a
one pixel border that we are not taking into account.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
in indicator mode, instead of only the thumb size, to correctly
position the thumb in indicator mode.

Mar 20, 2016:

11:05 PM Changeset in webkit [198483] by Gyuyoung Kim

14 edits in trunk/Source/WebCore

Reduce uses of PassRefPtr in WebCore/dom - 6
https://bugs.webkit.org/show_bug.cgi?id=155579

Reviewed by Darin Adler.

dom/MessagePortChannel.h:
dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::EventData::EventData):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::EventData::message):

10:28 PM Changeset in webkit [198482] by commit-queue@webkit.org

7 edits in trunk

The setter of binaryType attribute in WebSocket should raise the exception.
https://bugs.webkit.org/show_bug.cgi?id=135874

Patch by Jinwoo Jeong <jw00.jeong@samsung.com> on 2016-03-20
Reviewed by Antonio Gomes.

Source/WebCore:

According to W3C WebSocket Specification, <https://www.w3.org/TR/2012/CR-websockets-20120920/>
when an invalid value is set on binaryType of WebSocket, a SyntaxError should be raised.

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::setBinaryType): Add a parameter to set an exception.

Modules/websockets/WebSocket.h: Ditto.
Modules/websockets/WebSocket.idl: Update that setter of binaryType could raise an exception.

LayoutTests:

According to W3C WebSocket Specification, <https://www.w3.org/TR/2012/CR-websockets-20120920/>,
when an invalid value is set on binaryType of WebSocket, a SyntaxError should be raised.

http/tests/websocket/tests/hybi/binary-type.html: Catch a syntax exception when binary type is set with invalid values.

10:11 PM Changeset in webkit [198481] by mitz@apple.com

39 edits in trunk

[Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
https://bugs.webkit.org/show_bug.cgi?id=155707
<rdar://problem/24980691>

Reviewed by Darin Adler.

Source/bmalloc:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/JavaScriptCore:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/WebCore:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/WebInspectorUI:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/WebKit/mac:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/WebKit2:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Source/WTF:

Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Tools:

ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last component of MACOSX_DEPLOYMENT_TARGET.
ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.

Similarly for these projects:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
LayoutTestRelay/Configurations/Base.xcconfig:
LayoutTestRelay/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
WebEditingTester/Configurations/Base.xcconfig:
WebEditingTester/Configurations/DebugRelease.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:

6:26 PM Changeset in webkit [198480] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Added implementations of AXObjectCache methods for !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=155697

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-03-20
Reviewed by Darin Adler.

No new tests needed.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets):
(WebCore::AXObjectCache::absoluteCaretBoundsForCharacterOffset):
(WebCore::AXObjectCache::characterOffsetForIndex):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::endCharacterOffsetOfLine):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::previousCharacterOffset):

5:57 PM Changeset in webkit [198479] by rniwa@webkit.org

13 edits
4 adds in trunk/Websites/perf.webkit.org

Associated commits don't immediately show up on an analysis task page
https://bugs.webkit.org/show_bug.cgi?id=155692

Reviewed by Darin Adler.

The bug was caused by resolveCommits in AnalysisTask._constructAnalysisTasksFromRawData not being
able to find the matching commit log if the commit log had been created by the charts which don't
set the remote identifiers on each CommitLog objects.

Fixed the bug by modifying /api/measurement-set to include the commit ID, and making CommitLog
use the real database ID as its ID instead of a fake ID we create from repository and revision.

Also added a bunch of Mocha unit tests for AnalysisTask.fetchAll.

public/api/measurement-set.php:

(MeasurementSetFetcher::execute_query): Fetch commit_id.
(MeasurementSetFetcher::format_run): Use pass-by-reference to avoid making a copy of the row.
(MeasurementSetFetcher::parse_revisions_array): Include commit_id as the first item in the result.

public/v3/instrumentation.js:
public/v3/models/analysis-task.js:

(AnalysisTask): Fixed a bug that _buildRequestCount and _finishedBuildRequestCount could be kept
as strings and hasPendingRequests() could return a wrong result because it would perform string
inequality instead of numerical inequality.
(AnalysisTask.prototype.updateSingleton): Ditto.
(AnalysisTask.prototype.dissociateCommit):
(AnalysisTask._constructAnalysisTasksFromRawData):
(AnalysisTask._constructAnalysisTasksFromRawData.resolveCommits): Use findById now that CommitLog
objects all use the same id as the database id.

public/v3/models/commit-log.js:

(CommitLog):
(CommitLog.prototype.remoteId): Deleted since we no longer create a fake id for commit logs for
measurement sets.
(CommitLog.findByRemoteId): Deleted.
(CommitLog.ensureSingleton): Deleted.
(CommitLog.fetchBetweenRevisions):

public/v3/models/data-model.js:

(DataModelObject.clearStaticMap): Added to aid unit testing.
(DataModelObject.ensureNamedStaticMap): Fixed a typo. Each map is a dictionary, not an array.

public/v3/models/metric.js:
public/v3/models/platform.js:
public/v3/models/root-set.js:

(RootSet): Updated per the interface change in CommitLog.ensureSingleton.
(MeasurementRootSet): Updated per /api/measurement-set change. Use the first value as the id.

public/v3/models/test.js:
unit-tests/analysis-task-tests.js: Added.

(sampleAnalysisTask):
(measurementCluster):

unit-tests/checkconfig.js: Added some assertion message to help aid diagnosing the failure.
unit-tests/measurement-adaptor-tests.js: Updated the sample data per the API change in

/api/measurement-set and also added assertions for commit log ids.

unit-tests/measurement-set-tests.js:

(beforeEach):

unit-tests/resources: Added.
unit-tests/resources/mock-remote-api.js: Added. Extracted from measurement-set-tests.js to be

used in analysis-task-tests.js.
(assert.notReached.assert.notReached):
(global.RemoteAPI.getJSON):
(global.RemoteAPI.getJSONWithStatus):
(beforeEach):

unit-tests/resources/v3-models.js: Added. Extracted from measurement-set-tests.js to be used in

analysis-task-tests.js and added more imports as needed.
(importFromV3):
(beforeEach):

4:08 PM Changeset in webkit [198478] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Crash in stress/regexp-matches-array-slow-put.js due to stomping on memory when having bad time
https://bugs.webkit.org/show_bug.cgi?id=155679

Reviewed by Saam Barati.

Allocate out of line storage based on what the structure says it needs
in JSArray::tryCreateUninitialized.

runtime/JSArray.h:

(JSC::JSArray::tryCreateUninitialized):

3:42 PM Changeset in webkit [198477] by Joseph Pecoraro

2 edits in trunk/Source/JavaScriptCore

Crash on DFG::WorkList thread in JSC::Heap::isCollecting for destroyed Web Worker
https://bugs.webkit.org/show_bug.cgi?id=155678
<rdar://problem/25251439>

Reviewed by Filip Pizlo.

This fixes a crash that we saw with GuardMalloc. If the Plan was
Cancelled it may not be safe to access the VM. If the Plan was
cancelled we are just going to bail anyways, so keep the ASSERT but
short-circuit if the plan was Cancelled.

dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::runThread):

1:08 PM Changeset in webkit [198476] by Darin Adler

22 edits in trunk/Source

Disable Caches in Safari's Develop menu does not disable caches.
https://bugs.webkit.org/show_bug.cgi?id=64483

Reviewed by Antti Koivisto.

Source/WebCore:

Moved feature from Settings to Page.

history/PageCache.cpp:

(WebCore::canCachePage): Use function on Page instead of Settings.
(WebCore::PageCache::take): Ditto.
(WebCore::PageCache::get): Ditto.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::subresourceCachePolicy): Ditto.
(WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::cachePolicy): Ditto.

page/Page.h:

(WebCore::Page::isResourceCachingDisabled): Added.
(WebCore::Page::setResourceCachingDisabled): Added.

page/Settings.in: Removed resourceCachingDisabled.

Source/WebKit/mac:

Removed unneeded WebPreferences property; we don't need this for Legacy WebKit.

WebView/WebPreferenceKeysPrivate.h: Removed

WebKitResourceCachingDisabledPreferenceKey.

WebView/WebPreferences.mm:

(-[WebPreferences isResourceCachingDisabled]): Deleted.
(-[WebPreferences setResourceCachingDisabled:]): Deleted.

WebView/WebPreferencesPrivate.h: Removed resourceCachingDisabled property.
WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Removed code to update resourceCachingDisabled.

Source/WebKit2:

Moved functions from WKPreferences to WKPage.

Shared/WebPreferencesDefinitions.h: Removed ResourceCachingDisabled.

UIProcess/API/C/WKPage.cpp:

(WKPageGetResourceCachingDisabled): Added.
(WKPageSetResourceCachingDisabled): Added.

UIProcess/API/C/WKPagePrivate.h: Added above functions.
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetResourceCachingDisabled): Deleted.
(WKPreferencesGetResourceCachingDisabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h: Deleted above functions.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setResourceCachingDisabled): Added.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isResourceCachingDisabled): Added.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Removed code to set the setting
for resourceCachingDisabled..
(WebKit::WebPage::setResourceCachingDisabled): Added.

WebProcess/WebPage/WebPage.h: Declared setResourceCachingDisabled.
WebProcess/WebPage/WebPage.messages.in: Added SetResourceCachingDisabled.

10:20 AM Changeset in webkit [198475] by mitz@apple.com

35 edits in trunk

Update build settings

Rubber-stamped by Andy Estes.

Source/bmalloc:

Configurations/DebugRelease.xcconfig:

Source/JavaScriptCore:

Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebInspectorUI:

Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit/mac:

Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit2:

Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WTF:

Configurations/DebugRelease.xcconfig:

Tools:

ContentExtensionTester/Configurations/DebugRelease.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
LayoutTestRelay/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
WebEditingTester/Configurations/DebugRelease.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:
asan/asan.xcconfig:

8:21 AM Changeset in webkit [198474] by Chris Fleizach

5 edits
1 move in trunk

AX: Radio button members are not identified together in all cases
https://bugs.webkit.org/show_bug.cgi?id=155604
<rdar://problem/21186992>

Reviewed by Darin Adler.

Source/WebCore:

Allow aria radio buttons to be grouped together as linked ui elements even if they're not input types of radio button.

Modified test: accessibility/radio-button-group-members.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::speakProperty):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupChildren):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):

accessibility/AccessibilityRenderObject.h:

LayoutTests:

accessibility/mac/radio-button-group-members-expected.txt: Added.
accessibility/radio-button-group-members.html:
platform/mac/accessibility/radio-button-group-members-expected.txt: Removed.

Mar 19, 2016:

6:57 PM Changeset in webkit [198473] by jh718.park@samsung.com

10 edits in trunk/Source/WebCore

Purge PassRefPtr from WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=155681

Reviewed by Darin Adler.

No new tests, no new behaviours.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::updateImageControls):
(WebCore::HTMLImageElement::tryCreateImageControls):
(WebCore::HTMLImageElement::createImageControls): Deleted.

html/HTMLImageElement.h:
html/shadow/ImageControlsRootElement.h:
html/shadow/MediaControls.h:
html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControls::tryCreate):
(WebCore::MediaControlsApple::tryCreateControls):
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
(WebCore::MediaControlsApple::eventListener):
(WebCore::MediaControls::create): Deleted.
(WebCore::MediaControlsApple::createControls): Deleted.

html/shadow/MediaControlsApple.h:
html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::tryCreate):
(WebCore::ImageControlsButtonElementMac::maybeCreate): Deleted.

html/shadow/mac/ImageControlsButtonElementMac.h:
html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::ImageControlsRootElement::tryCreate):
(WebCore::ImageControlsRootElement::maybeCreate): Deleted.

2:16 PM Changeset in webkit [198472] by gskachkov@gmail.com

10 edits in trunk

[ES6] Arrow function syntax. Update syntax error text 'super is only valid inside functions' to more suitable
https://bugs.webkit.org/show_bug.cgi?id=155491

Reviewed by Saam Barati.

Source/JavaScriptCore:

Current message 'super is only valid inside of funcitons' is not correct
after patch for https://bugs.webkit.org/show_bug.cgi?id=153864 because
it is allow to use 'super' in eval. Current patch replace old message by
'Super is only valid inside functions or 'eval' inside a function' and
fix tests that rely on this message.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

tests/stress/generator-with-super.js:

(shouldThrow):

tests/stress/modules-syntax-error.js:
tests/stress/super-in-lexical-scope.js:
tests/stress/tagged-templates-syntax.js:

LayoutTests:

js/class-syntax-super-expected.txt:
js/script-tests/class-syntax-super.js:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:

11:54 AM Changeset in webkit [198471] by Antti Koivisto

2 edits in trunk/Source/WebCore

Data URL DecodeTask may get deleted outside main thread
https://bugs.webkit.org/show_bug.cgi?id=155584
rdar://problem/24492104

Reviewed by David Kilzer.

Follow-up: fix a possible null pointer crash.

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::DecodingResultDispatcher::startTimer):

If timer fires under startOneShot m_decodeTask may become zero before schedule() is called.
Fix by copying schedule context to a local before calling startOneShot.

11:46 AM Changeset in webkit [198470] by Chris Dumez

7 edits in trunk/Source/WebKit2

Add a setting to let the client toggle support for network cache speculative validation
https://bugs.webkit.org/show_bug.cgi?id=155622
<rdar://problem/25233209>

Reviewed by Darin Adler.

Add SPI to toggle support for network cache speculative validation.
Enable network cache speculative validation by default for now, until
I have a chance to update the clients to use the new SPI.

UIProcess/API/APIProcessPoolConfiguration.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetDiskCacheSpeculativeValidationEnabled):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration diskCacheSpeculativeValidationEnabled]):
(-[_WKProcessPoolConfiguration setDiskCacheSpeculativeValidationEnabled:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

11:13 AM Changeset in webkit [198469] by mark.lam@apple.com

14 edits in trunk

ES6 spec requires that ErrorPrototype not be an Error object.
https://bugs.webkit.org/show_bug.cgi?id=155680

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The ES6 spec states that Error.prototype should not be an instance of Error:
https://tc39.github.io/ecma262/#sec-properties-of-the-error-prototype-object

"The Error prototype object is an ordinary object. It is not an Error instance
and does not have an ErrorData internal slot."

This patch changes ErrorPrototype to conform to the above specification.

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
(JSC::ErrorPrototype::getOwnPropertySlot):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::finishCreation):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

updated to no longer need a JSGlobalObject argument.

tests/es6/miscellaneous_built-in_prototypes_are_not_instances.js:
updated to match the kangax version of this test.

LayoutTests:

Updated the appropriate tests to expect the toString() value of Error.prototype
to now be "[object Object]" instead of "[object Error]". Also rebased the test
results accordingly.

fast/dom/DOMException/prototype-object-expected.txt:
fast/dom/DOMException/prototype-object.html:
js/dom/native-error-prototype-expected.txt:
js/dom/script-tests/native-error-prototype.js:
sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.4/S15.11.4_A2.html:

12:17 AM Changeset in webkit [198468] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=155664
Consider to cap the size of session history data.

In iOS, if the total history entries data exceeds a threshold (2MB at the moment), don't
accumulate more data into the session state blob.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2016-03-19
Reviewed by Darin Adler.

UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::encodeSessionHistory): Stop encoding further history entries data into session state

if the total size exceed 2MB in iOS.

Mar 18, 2016:

10:05 PM Changeset in webkit [198467] by dbates@webkit.org

3 edits
2 adds in trunk/LayoutTests

Update AutoFill button in input fields
https://bugs.webkit.org/show_bug.cgi?id=155619

Update expected results for Windows and GTK ports. Add expected result for the EFL port.

platform/efl/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
platform/gtk/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

9:06 PM Changeset in webkit [198466] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r198464.

public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):

8:33 PM pywebsocket: a WebSocket server for layout tests edited by citizenJ@yopmail.com

(diff)

8:33 PM Changeset in webkit [198465] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Build fix after r198234.

public/api/commits.php:

(main): Typo: fetch_latest_reported -> fetch_last_reported.

public/include/commit-log-fetcher.php:

(CommitLogFetcher::format_single_commit): commits should be an array.

8:29 PM Changeset in webkit [198464] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Perf Dashboard v3 confuses better and worse on A/B task page
https://bugs.webkit.org/show_bug.cgi?id=155675
<rdar://problem/25208723>

Reviewed by Joseph Pecoraro.

The analysis results viewer on v3 UI sometimes treats regressions as progressions and vice versa when
the first set (i.e. set A) of the revisions used in an A/B testing never appears in the original graph,
and its latest commit time matches that of the second set, which appears in the original graph.

Because the analysis results viewer compares results in the increasing row number, this results in
B to be compared to A instead of A to be compared to B. Fixed the bug by preventing the wrong ordering
to occur in _buildRowsForPointsAndTestGroups by always inserting a root set A before B when B appears
and A doesn't appear in the original graph.

public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype._collectRootSetsInTestGroups): Remember the succeeding root set B
when creating an entry for root set A.
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Fixed the bug. Also un-duplicated
the code to create a new row.
(AnalysisResultsViewer.RootSetInTestGroup): Now takes a succeeding root set. e.g. it's B for A and
undefined for B in A/B testing.
(AnalysisResultsViewer.RootSetInTestGroup.prototype.succeedingRootSet): Added.

public/v3/components/time-series-chart.js:

(TimeSeriesChart.computeTimeGrid): Fixed the bug that we would end up showing 0 AM instead of dates
when both dates and months change.

7:50 PM Changeset in webkit [198463] by rniwa@webkit.org

1 edit
2 adds in trunk/Websites/perf.webkit.org

Add unit tests for measurement-set.js and measurement-adapter.js
https://bugs.webkit.org/show_bug.cgi?id=155673

Reviewed by Daniel Bates.

Add tests which were supposed to be added in r198462.

unit-tests/measurement-adaptor-tests.js: Added.
unit-tests/measurement-set-tests.js: Added.

(assert.notReached): Added.
(global.RemoteAPI.getJSON): Added.
(global.RemoteAPI.getJSONWithStatus): Added. A mock.

7:17 PM Changeset in webkit [198462] by rniwa@webkit.org

15 edits
1 add in trunk/Websites/perf.webkit.org

Add unit tests for measurement-set.js and measurement-adapter.js
https://bugs.webkit.org/show_bug.cgi?id=155673

Reviewed by Darin Adler.

Added mocha unit tests for MeasurementSet and MeasurementAdapter classes along with the necessary
refactoring to run these tests in node.

getJSON and getJSONStatus are now under RemoteAPI so that unit tests can mock them.

Removed the dependency on v2 UI's TimeSeries and Measurement class by adding a new implementation
of TimeSeries in v3 and removing the dependency on Measurement in chart-pane-status-view.js with
new helper methods on Build and CommitLog.

Many js files now use 'use strict' (node doesn't support class syntax in non-strict mode) and
module.exports to export symbols in node's require function.

public/v3/index.html:
public/v3/main.js:
public/v3/models/analysis-results.js:

(AnalysisResults.fetch):

public/v3/models/analysis-task.js:

(AnalysisTask.fetchAll):

public/v3/models/builder.js:

(Build):
(Build.prototype.builder): Added. Used by ChartPaneStatusView.
(Build.prototype.buildNumber): Ditto.
(Build.prototype.buildTime): Ditto.

public/v3/models/commit-log.js:

(CommitLog.prototype.diff): Ditto.
(CommitLog.fetchBetweenRevisions):

public/v3/models/data-model.js:

(DataModelObject.cachedFetch):

public/v3/models/measurement-adaptor.js:

(MeasurementAdaptor.prototype.applyToAnalysisResults): Renamed from adoptToAnalysisResults.
(MeasurementAdaptor.prototype.applyTo): Renamed from adoptToSeries. Now shares a lot more
code with applyToAnalysisResults. The code to set 'series' and 'seriesIndex' has been moved
to TimeSeries.append. 'measurement' is no longer needed as this patch removes its only use
in ChartPaneStatusView.

public/v3/models/measurement-cluster.js:

(MeasurementCluster.prototype.addToSeries): Use TimeSeries.append instead of directly mutating
series._series.

public/v3/models/measurement-set.js:

(Array.prototype.includes): Added a polyfill for node.
(MeasurementSet.prototype._fetchSecondaryClusters): Removed a bogus assertion. When fetchBetween
is called with a mixture of clusters that have been fetched and not fetched, this assertion fails.
(MeasurementSet.prototype._fetch):
(TimeSeries.prototype.findById): Moved to time-series.js.
(TimeSeries.prototype.dataBetweenPoints): Ditto.
(TimeSeries.prototype.firstPoint): Ditto.
(TimeSeries.prototype.fetchedTimeSeries): Moved the code to extend the last point to TimeSeries'
extendToFuture.

public/v3/models/repository.js:
public/v3/models/root-set.js:

(MeasurementRootSet): Ignore repositories that had not been defined (e.g. it could be added after
manifest.json had been downloaded but before a given root set is created for an A/B testing).

public/v3/models/time-series.js:

(TimeSeries): Added.
(TimeSeries.prototype.append): Added.
(TimeSeries.prototype.extendToFuture): Added.
(TimeSeries.prototype.firstPoint): Moved from measurement-set.js.
(TimeSeries.prototype.lastPoint): Added.
(TimeSeries.prototype.previousPoint): Added.
(TimeSeries.prototype.nextPoint): Added.
(TimeSeries.prototype.findPointByIndex): Added.
(TimeSeries.prototype.findById): Moved from measurement-set.js.
(TimeSeries.prototype.findPointAfterTime): Added.
(TimeSeries.prototype.dataBetweenPoints): Moved from measurement-set.js.

public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype.render): Use newly added helper functions on Build.
(ChartPaneStatusView.prototype._formatTime): Added.
(ChartPaneStatusView.prototype.setCurrentRepository):
(ChartPaneStatusView.prototype.computeChartStatusLabels): Rewrote the code using RootSet object on
currentPoint and previousPoint instead of Measurement class from v2 UI. Also sort the results using
sortByNamePreferringOnesWithURL.

public/v3/remote.js:

(RemoteAPI.getJSON): Moved under RemoteAPI.
(RemoteAPI.getJSONWithStatus): Ditto.
(PrivilegedAPI):
(PrivilegedAPI.requestCSRFToken):

6:37 PM Changeset in webkit [198461] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Bullet misaligned when expanding console log message
https://bugs.webkit.org/show_bug.cgi?id=155669
<rdar://problem/25250721>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/ObjectTreeView.css:

(.object-tree):
(.object-tree .object-tree): Deleted.
Make object tree's inline-block again.

UserInterface/Views/ConsoleMessageView.css:

(.console-top-level-message .object-tree):
(.console-top-level-message .object-tree .object-tree):
Since the Console is the only place that requires a non-inline-block
object-tree, and only at the top level, have the console override
the styles of object trees as it needs.

6:31 PM Changeset in webkit [198460] by commit-queue@webkit.org

5 edits in trunk

Update AutoFill button in input fields.
https://bugs.webkit.org/show_bug.cgi?id=155619.
rdar://problem/24486939.

Patch by Zhuo Li <zachli@apple.com> on 2016-03-18
Reviewed by Daniel Bates.

Source/WebCore:

css/html.css:

(input::-webkit-contacts-auto-fill-button):
Use the new AutoFill button.

LayoutTests:

fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

Update the test results.

platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

Ditto.

5:55 PM Changeset in webkit [198459] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode')
https://bugs.webkit.org/show_bug.cgi?id=155671
<rdar://problem/25249401>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._sort):

5:42 PM Changeset in webkit [198458] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Limit DFG's Validate symbols to its compilation unit
https://bugs.webkit.org/show_bug.cgi?id=155670

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-03-18
Reviewed by Filip Pizlo.

dfg/DFGValidate.cpp:

5:05 PM Changeset in webkit [198457] by achristensen@apple.com

13 edits in trunk/Source

Give NSURLSessionConfiguration information about parent process
https://bugs.webkit.org/show_bug.cgi?id=155661
Source/WebCore:

Reviewed by Anders Carlsson.

platform/spi/cf/CFNetworkSPI.h:

Add newly-used SPI declarations.

Source/WebKit2:

rdar://problem/25225850

Reviewed by Anders Carlsson.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::sessionID):

NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::partitionName):
(WebKit::NetworkProcess::sourceApplicationAuditData):
(WebKit::NetworkProcess::cfURLCacheOrigins):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::globalCustomProtocolManager):
(WebKit::globalSourceApplicationAuditTokenData):
(WebKit::NetworkSession::setCustomProtocolManager):
(WebKit::NetworkSession::setSourceApplicationAuditTokenData):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
Tell the NSURLSessionConfiguration what the source application bundle identifier
and audit token data are so we can correctly keep track of which application is using data.
This also gives CFNetwork enough information to determine if the application is allowed to
use cell data in Settings, so it seems like we do not need to explicitly set allowsCellularAccess.

NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):
(WebKit::RemoteNetworkingContext::sourceApplicationIdentifier):

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::sourceApplicationIdentifier):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformTerminate):
(WebKit::WebProcess::sourceApplicationAuditData):
(WebKit::WebProcess::initializeSandbox):
I moved the calls to getAuditToken from RemoteNetworkingContext.mm and WebFrameNetworkingContext.mm
to NetworkProcessCocoa.mm and WebProcessCocoa.mm, respectively, to share with NetworkSession code,
which does not use NetworkingContexts.

5:04 PM Changeset in webkit [198456] by Simon Fraser

2 edits in trunk/Source/WebKit2

Build fix after r198455.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::layerTreeCommitComplete):

5:00 PM Changeset in webkit [198455] by Simon Fraser

16 edits
2 adds in trunk

Sideways-scrollable RTL document has wrong initial and reload offset in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=155660
Source/WebCore:

rdar://problem/22212662

Reviewed by Tim Horton.

There were two problems with the scroll position of RTL documents on initial and reload
in WKWebView.

First, in the delegatesScrolling() code path, ScrollView::updateScrollbars() needs to
tell someone that the scroll origin changed, to trigger a scroll to the page origin.

Secondly, WKWebView had scrollPosition/scrollOffset confusion in various places.

Test: fast/scrolling/rtl-initial-scroll-position.html

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

Source/WebKit2:

Reviewed by Tim Horton.

There were two problems with the scroll position of RTL documents on initial and reload
in WKWebView.

First, in the delegatesScrolling() code path, ScrollView::updateScrollbars() needs to
tell someone that the scroll origin changed, to trigger a scroll to the page origin.

Secondly, WKWebView had scrollPosition/scrollOffset confusion in various places. In
the restorePageState() code path, WebCore passes an exposedRect; this patch makes
it explicit that it's an exposedContentRect, and passes scrollOrigin so that it can
be mapped into scrollOffset-relative coordinates that the UIScrollView wants.

When reloading an RTL page, there was an additional issue; restorePageState()
restored the exposedRect, but then we'd see the origin change as a programmatic scroll
to 0,0, clobbering the exposedRect. Fix by using a "_commitDidRestoreExposedRect" flag
on the WKWebView that is used to ignore the programmatic scroll in that case.

Ideally these changes would fix fast/scrolling/scroll-position-on-reload-rtl.html, but the
test still fails because of timing differences between OS X and iOS.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _layerTreeCommitComplete]):
(-[WKWebView _restorePageStateToExposedRect:scrollOrigin:scale:]):
(-[WKWebView _scrollToContentScrollPosition:scrollOrigin:]):
(-[WKWebView _restorePageStateToExposedRect:scale:]): Deleted.
(-[WKWebView _scrollToContentOffset:scrollOrigin:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestScroll):
(WebKit::PageClientImpl::layerTreeCommitComplete):
(WebKit::PageClientImpl::restorePageState):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _layerTreeCommitComplete]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::layerTreeCommitComplete):
(WebKit::WebPageProxy::restorePageState):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::restorePageState):

LayoutTests:

Reviewed by Tim Horton.

Test for initial scroll position in an RTL page.

fast/scrolling/rtl-initial-scroll-position-expected.html: Added.
fast/scrolling/rtl-initial-scroll-position.html: Added.

4:59 PM Changeset in webkit [198454] by Ryan Haddad

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r198443.

This change caused API test failures on El Capitan

Reverted changeset:

"CRASH in WebCore::MediaResourceLoader::requestResource + 698"
https://bugs.webkit.org/show_bug.cgi?id=155651
http://trac.webkit.org/changeset/198443

4:53 PM Changeset in webkit [198453] by beidson@apple.com

2 edits in trunk/Source/WebKit2

NSURLSession: Set download resume data when a download fails due to an error.
https://bugs.webkit.org/show_bug.cgi?id=155665

Reviewed by Alex Christensen.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]): Save the resume data from the

NSError userInfo if it exists.

4:50 PM Changeset in webkit [198452] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix ObjectTree Map styling, key/value look cramped
https://bugs.webkit.org/show_bug.cgi?id=155668

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.tree-outline .item.object-tree-array-index):

UserInterface/Views/ObjectTreeMapEntryTreeElement.css:

(.tree-outline .item.object-tree-map-entry):
When creating generic tree outline styles generic object tree
styles were getting overriden by generic tree outline styles
with higher specificity.

4:45 PM Changeset in webkit [198451] by Darin Adler

3 edits
2 adds in trunk

ASSERTION FAILED: m_isValid == valid() in WebCore::HTMLFormControlElement::isValidFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=139481

Reviewed by Daniel Bates.

Source/WebCore:

Test: fast/forms/validity-assertion-inserting-into-datalist.html

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto): Set the flags that will cause
"will validate" to be recomputed *before* calling willValidate().

LayoutTests:

fast/forms/validity-assertion-inserting-into-datalist-expected.txt: Added.
fast/forms/validity-assertion-inserting-into-datalist.html: Added.

4:23 PM Changeset in webkit [198450] by Chris Dumez

7 edits
6 adds in trunk

Speculative revalidation requests do not have their HTTP user-agent set
https://bugs.webkit.org/show_bug.cgi?id=155620
<rdar://problem/24657567>

Reviewed by Brady Eidson.

Source/WebCore:

Export a couple of symbols so they can be used from WebKit2.

Test: http/tests/cache/disk-cache/speculative-validation/validation-request.html

platform/network/ResourceRequestBase.h:

Source/WebKit2:

Speculative revalidation requests do not have their HTTP user-agent set
which could lead to different content getting returned by the server.

To address the problem, we save the original request's 'user-agent' in
the disk cache and re-use it later on for speculative validation
requests.

NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::constructRevalidationRequest):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):

NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:

(WebKit::NetworkCache::SubresourceInfo::encode):
(WebKit::NetworkCache::SubresourceInfo::decode):
(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):
(WebKit::NetworkCache::SubresourceInfo::operator=):
(WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry):
(WebKit::NetworkCache::SubresourcesEntry::updateSubresourceLoads):
(WebKit::NetworkCache::SubresourcesEntry::decodeStorageRecord): Deleted.

NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:

(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):

LayoutTests:

Add layout test coverage.

http/tests/cache/disk-cache/speculative-validation/resources/request-headers-script.php: Added.
http/tests/cache/disk-cache/speculative-validation/resources/validation-request-frame.php: Added.
http/tests/cache/disk-cache/speculative-validation/validation-request-expected.txt: Added.
http/tests/cache/disk-cache/speculative-validation/validation-request.html: Added.

4:22 PM Changeset in webkit [198449] by matthew_hanson@apple.com

1 copy in tags/Safari-601.1.46.121

New Tag.

4:22 PM Changeset in webkit [198448] by matthew_hanson@apple.com

1 copy in tags/Safari-601.6.11

New Tag.

4:14 PM Changeset in webkit [198447] by mark.lam@apple.com

28 edits in trunk

ES6 spec requires that RegExpPrototype not be a RegExp object.
https://bugs.webkit.org/show_bug.cgi?id=155654

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ES6 spec states that RegExp.prototype should not be an instance of RegExp:
https://tc39.github.io/ecma262/#sec-properties-of-the-regexp-prototype-object

"The RegExp prototype object is an ordinary object. It is not a RegExp instance
and does not have a RegExpMatcher internal slot or any of the other internal
slots of RegExp instance objects."

This patch changes RegExpPrototype to conform to the above specifications.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::finishCreation):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::visitChildren):
(JSC::regExpProtoFuncTest):

runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::create):
(JSC::RegExpPrototype::createStructure):
(JSC::RegExpPrototype::emptyRegExp):

tests/es6.yaml:
This patch makes the es6/miscellaneous_built-in_prototypes_are_not_instances.js test now pass. However, the kangax version of this test still fails because it also checks Error objects (which will be fixed in a subsequent patch).

tests/mozilla/ecma_2/shell.js:

(stringify):
(test):
(getFailedCases):
(err):

tests/stress/static-getter-in-names.js:

(shouldBe):

LayoutTests:

Rebase all the test results.

fast/regex/script-tests/toString.js:
fast/regex/toString-expected.txt:
ietestcenter/Javascript/15.10.6-expected.txt:
ietestcenter/Javascript/15.10.7.1-1-expected.txt:
ietestcenter/Javascript/15.10.7.2-1-expected.txt:
ietestcenter/Javascript/15.10.7.3-1-expected.txt:
ietestcenter/Javascript/15.10.7.4-1-expected.txt:
ietestcenter/Javascript/15.10.7.5-1-expected.txt:
ietestcenter/Javascript/TestCases/15.10.6.js: