Timeline



Jun 23, 2016:

11:07 PM Changeset in webkit [202418] by Simon Fraser
  • 3 edits in trunk/Tools

Fix Windows build.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
10:20 PM Changeset in webkit [202417] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit/win

[Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=159057

Reviewed by Brent Fulgham.

The test expects the label to have a static text role, but currently it has a
group role.

  • AccessibleBase.cpp:

(MSAARole): Change the role of labels to static text.

9:51 PM Changeset in webkit [202416] by Gyuyoung Kim
  • 2 edits in trunk/Tools

[EFL] Change download path of libxslt

Unreviewed EFL build fix.

In Korea current download path can't be accessed. Change it.

  • efl/jhbuild.modules:
9:39 PM Changeset in webkit [202415] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk

OOM Assertion failure in Array.prototype.toString
​https://bugs.webkit.org/show_bug.cgi?id=158793

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-23
Reviewed by Saam Barati.

Source/JavaScriptCore:

JSString::create() taking a StringImpl was using a signed integer
for the length of the string.
The problem is StringImpl uses an unsigned integer. When a large string
was passed to JSString, the signed integer would be negative and crash
JSString.

  • runtime/JSString.h:

(JSC::JSString::create):

LayoutTests:

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Added.

(string_appeared_here.createStrings):

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Added.

(string_appeared_here.createRegexp):
(catch):

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Added.

(string_appeared_here.createStrings):
(catch):

  • js/stringimpl-to-jsstring-on-large-strings-1-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-1.html: Added.
  • js/stringimpl-to-jsstring-on-large-strings-2-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-2.html: Added.
  • js/stringimpl-to-jsstring-on-large-strings-3-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-3.html: Added.
9:08 PM Changeset in webkit [202414] by beidson@apple.com
  • 14 edits
    7 adds in trunk

Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)
​https://bugs.webkit.org/show_bug.cgi?id=158991

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-cursor.html

  • platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications): Deleted.

Source/WebKit2:

  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:
  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::getSandboxExtensionsForBlobFiles):
(WebKit::DatabaseProcess::didGetSandboxExtensionsForBlobFiles):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::handleGetResult): Handle creation of sandbox extensions

for any result that might contain blob values.

(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didOpenCursor):
(WebKit::WebIDBConnectionToClient::didIterateCursor):

  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
  • Shared/Databases/IndexedDB/WebIDBResult.cpp: Added.

(WebKit::WebIDBResult::encode):
(WebKit::WebIDBResult::decode):

  • Shared/Databases/IndexedDB/WebIDBResult.h: Added.

(WebKit::WebIDBResult::WebIDBResult):
(WebKit::WebIDBResult::resultData):
(WebKit::WebIDBResult::handles):

  • Shared/SandboxExtension.h: Make SandboxExtension handles moveable.
  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::preregisterSandboxExtensionsIfNecessary): Register sandbox extensions with the

Networking process for any result that might contain blob values.

(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
(WebKit::WebIDBConnectionToServer::didGetRecordWithSandboxExtensions): Deleted.

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:

LayoutTests:

  • storage/indexeddb/modern/blob-cursor-expected.txt: Added.
  • storage/indexeddb/modern/blob-cursor.html: Added.
  • storage/indexeddb/modern/resources/blob-cursor.js: Added.
  • storage/indexeddb/modern/resources/blob-cursor1.html: Added.
  • storage/indexeddb/modern/resources/blob-cursor2.html: Added.
8:41 PM Changeset in webkit [202413] by Yusuke Suzuki
  • 44 edits
    1 copy
    47 adds in trunk

[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber accept non number values
​https://bugs.webkit.org/show_bug.cgi?id=154022

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We aim at optimizing @toInteger operation.
While it still has an unoptimized part[1], this patch should be a first step.

We introduce the @toNumber builtin intrinsic operation.
This converts the given value to the JS number by emitting op_to_number bytecode.
Previously @toInteger called C++ @Number constructor for that purpose.

And in DFG, op_to_number is converted to DFG ToNumber node.
During DFG, we attempt to convert this to edge filtering and Identity, but if we fail,
we just fall back to calling the C++ function.

To utilize ToNumber in user-land side, we add a path attempting to convert Number constructor calls
to ToNumber DFG nodes. This conversion is useful because Number(value) is used to convert a value to a number in JS.

Before this patch, we emit simple edge filtering (NumberUse) instead of emitting DFG node like ToNumber for op_to_number.
But emitting ToNumber is useful, because in the case of Number(value), considering value may not be a number is reasonable.

By leveraging @toNumber operation, we rewrite Number.{isFinite, isNaN}, global.{isFinite, isNaN} and @toInteger.

ToNumber DFG node has a value profiling. This profiling is leveraged to determine the result number type of the ToNumber operation.
This value profiling is provided from either NumberConstructor's call operation or op_to_number.

The results (with the added performance tests) show that, while existing cases are performance neutral, the newly added cases gain the performance benefit.
And ASMBench/n-body.c also shows stable ~2% progression.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=153738

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/BuiltinNames.h:
  • builtins/GlobalObject.js:

(globalPrivate.isFinite):
(globalPrivate.isNaN):
(globalPrivate.toInteger): Deleted.
(globalPrivate.toLength): Deleted.
(globalPrivate.isDictionary): Deleted.
(globalPrivate.speciesGetter): Deleted.
(globalPrivate.speciesConstructor): Deleted.

  • builtins/GlobalOperations.js: Copied from Source/JavaScriptCore/builtins/GlobalObject.js.

(globalPrivate.toInteger):
(globalPrivate.toLength):
(globalPrivate.isDictionary):
(globalPrivate.speciesGetter):
(globalPrivate.speciesConstructor):

  • builtins/NumberConstructor.js: Added.

(isFinite):
(isNaN):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitUnaryOpProfiled):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_toNumber):
(JSC::UnaryPlusNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
We use getPrediction() to retrieve the heap prediction from the to_number bytecode.
According to the benchmark results, choosing getPredictionWithoutOSRExit() causes performance regression (1.5%) in kraken stanford-crypto-aes.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumber):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

Alway rely on the heap prediction.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
As of 64bit version, we carefully manage the register reuse. The largest difference between 32bit and 64bit is
branchIfNotNumber() requires the temporary register. We should not use the result registers for that since
it may be reuse the argument registers and it can break the argument registers before using them to call the operation.
Currently, we allocate the additional temporary register for that scratch register.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
Reuse the argument register for the result if possible. And manually decrement the use count in the middle of the node.
This is similar technique used in ToPrimitive. Typically, the child of ToNumber is only used by this ToNumber node since
we would like to perform the type conversion onto this child node here. So this careful register reuse effectively removes
the spills to call the operation. The example of the actually emitted code is the following.

76:<!2:loc11> ToNumber(Untyped:@68, JS|MustGen|UseAsOther, DoubleimpurenanTopEmpty, R:World, W:Heap, Exits, ClobbersExit, bc#48) predicting DoubleimpurenanTopEmpty

0x7f986d5fe693: test %rax, %r14
0x7f986d5fe696: jz 0x7f986d5fe6a1
0x7f986d5fe69c: jmp 0x7f986d5fe6d1
0x7f986d5fe6a1: mov %rax, %rsi
0x7f986d5fe6a4: mov %rbp, %rdi
0x7f986d5fe6a7: mov $0x2, 0x24(%rbp)
0x7f986d5fe6ae: mov $0x7f98711ea5f0, %r11
0x7f986d5fe6b8: call *%r11
0x7f986d5fe6bb: mov $0x7f982d3f72d0, %r11
0x7f986d5fe6c5: mov (%r11), %r11
0x7f986d5fe6c8: test %r11, %r11
0x7f986d5fe6cb: jnz 0x7f986d5fe88c

It effectively removes the unnecessary spill to call the operation!

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/Nodes.h:

(JSC::UnaryOpNode::opcodeID):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN): Deleted.
(JSC::globalFuncIsFinite): Deleted.

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathCommon.h:

(JSC::maxSafeInteger):
(JSC::minSafeInteger):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):
(JSC::numberConstructorFuncIsFinite): Deleted.
(JSC::numberConstructorFuncIsNaN): Deleted.

  • runtime/NumberConstructor.h:
  • tests/stress/Number-isNaN-basics.js: Added.

(numberIsNaNOnInteger):
(testNumberIsNaNOnIntegers):
(verifyNumberIsNaNOnIntegerWithOtherTypes):
(numberIsNaNOnDouble):
(testNumberIsNaNOnDoubles):
(verifyNumberIsNaNOnDoublesWithOtherTypes):
(numberIsNaNNoArguments):
(numberIsNaNTooManyArguments):
(testNumberIsNaNOnConstants):
(numberIsNaNStructTransition):
(Number.isNaN):

  • tests/stress/global-is-finite.js: Added.

(shouldBe):

  • tests/stress/global-is-nan.js: Added.

(shouldBe):

  • tests/stress/global-isNaN-basics.js: Added.

(isNaNOnInteger):
(testIsNaNOnIntegers):
(verifyIsNaNOnIntegerWithOtherTypes):
(isNaNOnDouble):
(testIsNaNOnDoubles):
(verifyIsNaNOnDoublesWithOtherTypes):
(verifyIsNaNOnCoercedTypes):
(isNaNNoArguments):
(isNaNTooManyArguments):
(testIsNaNOnConstants):
(isNaNTypeCoercionSideEffects):
(i.value.isNaNTypeCoercionSideEffects.valueOf):
(isNaNStructTransition):
(isNaN):

  • tests/stress/number-is-finite.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/number-is-nan.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/to-number-basics.js: Added.

(shouldBe):

  • tests/stress/to-number-convert-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-convert-to-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-intrinsic-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object.js: Added.

(shouldBe):
(test12):
(object1.valueOf):
(test2):
(test22):
(object2.valueOf):
(test3):
(test32):
(object3.valueOf):

  • tests/stress/to-number-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

LayoutTests:

  • js/regress/Number-isNaN-expected.txt: Added.
  • js/regress/Number-isNaN.html: Added.
  • js/regress/global-isNaN-expected.txt: Added.
  • js/regress/global-isNaN.html: Added.
  • js/regress/script-tests/Number-isNaN.js: Added.
  • js/regress/script-tests/global-isNaN.js: Added.
  • js/regress/script-tests/many-foreach-calls.js:

(i.4.forEach):
(i.array.forEach): Deleted.

  • js/regress/script-tests/to-number-constructor-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-string-number-string-number.js: Added.

(test):

  • js/regress/script-tests/to-number-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-string-number-string-number.js: Added.

(test):

  • js/regress/to-number-constructor-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-constructor-number-string-number-string.html: Added.
  • js/regress/to-number-constructor-only-number-expected.txt: Added.
  • js/regress/to-number-constructor-only-number.html: Added.
  • js/regress/to-number-constructor-only-string-expected.txt: Added.
  • js/regress/to-number-constructor-only-string.html: Added.
  • js/regress/to-number-constructor-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-constructor-string-number-string-number.html: Added.
  • js/regress/to-number-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-number-string-number-string.html: Added.
  • js/regress/to-number-only-number-expected.txt: Added.
  • js/regress/to-number-only-number.html: Added.
  • js/regress/to-number-only-string-expected.txt: Added.
  • js/regress/to-number-only-string.html: Added.
  • js/regress/to-number-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-string-number-string-number.html: Added.
8:34 PM Changeset in webkit [202412] by Simon Fraser
  • 4 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=159077

Tools:

Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
snapshot the final state of the test in release builds.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

LayoutTests:

Mark fast/harness/snapshot-captures-compositing.html as an image failure.

  • platform/ios-simulator-wk2/TestExpectations:
7:50 PM Changeset in webkit [202411] by Simon Fraser
  • 3 edits in trunk/Tools

Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

7:47 PM Changeset in webkit [202410] by achristensen@apple.com
  • 30 edits in trunk/Source

Remove unused didCancelAuthenticationChallenge
​https://bugs.webkit.org/show_bug.cgi?id=158819

Reviewed by David Kilzer.

Source/WebCore:

No change in behavior. This callback was deprecated in Yosemite. It is never called.

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): Deleted.

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didCancelAuthenticationChallenge): Deleted.

  • loader/ResourceLoader.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): Deleted.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didCancelAuthenticationChallenge): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

  • platform/spi/cocoa/NSURLDownloadSPI.h:

Source/WebKit/ios:

  • DefaultDelegates/WebDefaultResourceLoadDelegate.m:

(-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]): Deleted.

Source/WebKit/mac:

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebView.mm:

(-[WebView _cacheResourceLoadDelegateImplementations]):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

  • NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didCancelAuthenticationChallenge:]): Deleted.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didCancelAuthenticationChallenge): Deleted.

  • NetworkProcess/NetworkLoad.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
7:44 PM Changeset in webkit [202409] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add "shippingType" to the list of valid payment request properties
​https://bugs.webkit.org/show_bug.cgi?id=159079
<rdar://problem/26988429>

Reviewed by Dean Jackson.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::isValidPaymentRequestPropertyName):

7:38 PM Changeset in webkit [202408] by benjamin@webkit.org
  • 29 edits
    14 adds in trunk

Specialize synchronous event tracking per event type
​https://bugs.webkit.org/show_bug.cgi?id=158826

Reviewed by Simon Fraser.

Source/WebCore:

First, kudos to Rick Byers for all his helps on passive event dispatch.
The specs are pretty damn good and his help reviewing patches is very useful.

This patch change synchronous event dispatch to happen per event
instead of per sequence touchstart->touchend.

The big advantage of this is we can dispatch more events asynchronously.
For example, to handle a tap programmatically, you can limit the active listener
to the touchend event. The touchstart and touchmove are now dispatched asynchronously.

The implementation is a simple extension to EventTrackingRegions.
Instead of a single synchronous region, we have one region per event type.
When processing the events, we only need to send the events synchronously
if that particular event type has a synchronous region.

Note that EventDispatcher's touch event support already supports
mixing synchronous and asynchronous events. The events are always processed
in order even if asynchronous events are pending when a synchronous dispatch
happens.

Tests: fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html

fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html
fast/events/touch/ios/tap-with-active-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html
fast/events/touch/ios/tap-with-passive-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveTouchEventListeners): Deleted.

  • dom/EventTarget.h:
  • page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):

  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):

  • page/scrolling/ScrollingTree.h:
  • platform/EventTrackingRegions.cpp: Added.

(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::EventTrackingRegions::isEmpty):
(WebCore::EventTrackingRegions::translate):
(WebCore::EventTrackingRegions::uniteSynchronousRegion):
(WebCore::EventTrackingRegions::unite):
(WebCore::operator==):

  • platform/EventTrackingRegions.h:

(WebCore::EventTrackingRegions::isEmpty): Deleted.
(WebCore::EventTrackingRegions::trackingTypeForPoint): Deleted.
(WebCore::operator==): Deleted.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::mergeTrackingTypes):
(WebKit::WebPageProxy::updateTouchEventTracking):
(WebKit::WebPageProxy::touchEventTrackingType):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEventAsynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::TouchEventTracking::isTrackingAnything):
(WebKit::WebPageProxy::TouchEventTracking::reset):

LayoutTests:

  • fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html: Added.
  • fast/events/touch/ios/tap-with-active-touch-end-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-touch-end-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-end-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-end-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html: Added.
5:59 PM Changeset in webkit [202407] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

More attempting to fix external iOS builds.

  • platform/spi/cocoa/QuartzCoreSPI.h:
5:25 PM Changeset in webkit [202406] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update TestExpectations for a couple video track tests.

  • platform/mac/TestExpectations:
5:12 PM Changeset in webkit [202405] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Try to fix the non-internal builds by defining CARenderServerBufferRef.

  • platform/spi/cocoa/QuartzCoreSPI.h:
5:08 PM Changeset in webkit [202404] by Simon Fraser
  • 12 edits
    2 adds in trunk

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
​https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebCore:

Add CARenderServer SPIs.

Test: fast/harness/snapshot-captures-compositing.html

  • platform/spi/cocoa/QuartzCoreSPI.h:

Tools:

Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
This allows them to capture compositing layers in snapshots, rather than doing a software paint,
thus enabling testing of more things.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(createBitmapContext): Moved to this file to share it.

  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):
(BitmapContext::createFromUIImage): Deleted.
(BitmapContext::pixelData): Deleted.
(BitmapContext::BitmapContext): Deleted.
(computeMD5HashStringForBitmapContext): Deleted.
(dumpBitmap): Deleted.

  • DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):
(createBitmapContext): Deleted.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Deleted.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

Test that fails if snapshotting doesn't correctly snapshot 3D transforms.

  • fast/harness/snapshot-captures-compositing-expected.html: Added.
  • fast/harness/snapshot-captures-compositing.html: Added.
5:00 PM Changeset in webkit [202403] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

4:28 PM Changeset in webkit [202402] by sbarati@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

DFGSpeculativeJIT's m_slowPathLambdas should restore the current node field and DFG OSR entry functions should use DeferGCForAWhile instead of DeferGC
​https://bugs.webkit.org/show_bug.cgi?id=159064
<rdar://problem/26599119>

Reviewed by Filip Pizlo.

The DFG has a list of m_slowPathLambdas that are code generators it emits
amongst its slow paths. These lambdas, however, did not update the m_currentNode field.
This caused us to use whatever Node happened to be used as the currentNode at the time
we call the slowPathLambda. This means the wrong CallSiteIndex was stored into the call
frame when we made a call. This may lead to a crash if the CallSiteIndex corresponds to
the wrong CodeOrigin. For example, the wrong CodeOrigin could have an InlineCallFrame with
a calleeRecovery that will not be in sync with the current stack state. Trying
to recover that callee will often lead to a crash. The solution is to update
m_currentNode to the DFG::Node* it corresponds to when emitting these slowPathLambdas.

I found this bug because we were inside this bad state when calling an operation
that happened to have a DeferGC. When this DeferGC actually GCed, it would
take a StackTrace, which would lead to a crash because we were updating
ShadowChicken with vm.topCallFrame. It just so happened that the CallSiteIndex
in the call frame in this program corresponded to an InlineCallFrame with a calleeRecover.
However, this CallSiteIndex didn't correspond to the actual state of execution
of the program. I'm adding new options to make reproducing DeferGC related
bugs easier by making DeferGC force a GC according to some probability. To
always have DeferGC force a GC, you can set that probability to 1.

There is a second bug that I discovered after solving the above bug. We were
using DeferGC instead of DeferGCForAWhile in the OSR entry related functions
in the DFG. This would cause us to take a stack trace when the call frame was
in an inconsistent state. For example, the operation would call FTL::prepareOSREntry,
which would replace the DFG CodeBlock in the call frame with the FTL CodeBlock.
However, we wouldn't update the CallSiteIndex to correspond to an FTL CallSiteIndex.
This would lead to a crash when taking a stack trace. The solution is to prevent
stack traces from being taken when the program is in this state by using
DeferGCForAWhie instead of DeferGC.

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):

  • dfg/DFGSpeculativeJIT.h:
  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::collectAccordingToDeferGCProbability):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::markListSet):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

  • runtime/Options.h:
  • tests/stress/slow-path-generator-updating-current-node-dfg.js: Added.

(foo):
(bar):

4:22 PM Changeset in webkit [202401] by BJ Burg
  • 3 edits in trunk/Source/WebCore

Web Inspector: add assertions to catch dangling frontends that persist between tests
​https://bugs.webkit.org/show_bug.cgi?id=159073

Reviewed by Joseph Pecoraro.

Based on the analysis in ​https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setIsUnderTest):

  • inspector/InspectorController.h:
3:52 PM Changeset in webkit [202400] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r202380): iOS 9.x internal builds are broken

Follow-up fix for: Enable window.open() for existing versions of Secret Society
<​https://webkit.org/b/159049>
<rdar://problem/26528349>

  • wtf/spi/darwin/dyldSPI.h: Define DYLD_IOS_VERSION_10_0 when

building on internal SDKs older than iOS 10.

3:46 PM Changeset in webkit [202399] by commit-queue@webkit.org
  • 26 edits
    4 adds in trunk

requestFrameAnimation() callback timestamp should be very close to Performance.now()
​https://bugs.webkit.org/show_bug.cgi?id=159038

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Pass the Performance.now() to requestFrameAnimation() callback. Do not add
the timeUntilOutput which is the difference between outputTime and now since
this addition makes us report a timestamp ahead in the future by almost 33ms.

A new function named "nowTimestamp()" is added to the DOMWindow class. It
calls Performance.now() if WEB_TIMING is enabled, otherwise it calls
monotonicallyIncreasingTime(). The returned timestamp is seconds and it is
relative to the document loading time.

The timestamp passing will be removed all the down till the callers of
ScriptedAnimationController::serviceScriptedAnimations(). The callers will
getting the now timestamp by calling DOMWindow::nowTimestamp().

Tests: animations/animation-callback-timestamp.html

animations/animation-multiple-callbacks-timestamp.html

  • dom/Document.cpp:

(WebCore::Document::monotonicTimestamp):
(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • dom/ScriptedAnimationController.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

  • loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::referenceWallTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::nowTimestamp):

  • page/DOMWindow.h:
  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime): Deleted.

  • platform/graphics/DisplayRefreshMonitorClient.cpp:

(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):

  • platform/graphics/DisplayRefreshMonitorClient.h:
  • platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::displayRefreshFired):

  • platform/graphics/GraphicsLayerUpdater.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler handleDisplayLink:]):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
(WebCore::mediaTimeToCurrentTime): Deleted.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::displayLinkCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):

Source/WebKit2:

  • WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers):

LayoutTests:

  • animations/animation-callback-timestamp-expected.txt: Added.
  • animations/animation-callback-timestamp.html: Added.
  • animations/animation-multiple-callbacks-timestamp-expected.txt: Added.
  • animations/animation-multiple-callbacks-timestamp.html: Added.
2:28 PM Changeset in webkit [202398] by ddkilzer@apple.com
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove unused HarfBuzzFaceCoreText.cpp
<​https://webkit.org/b/159065>

Reviewed by Myles C. Maxfield.

  • platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Removed.
1:55 PM Changeset in webkit [202397] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Failing baseline JIT compilation of a code block and then trying to compile it from OSR from DFG/FTL will corrupt the CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=158806

Reviewed by Saam Barati.

If we try to compile a CodeBlock that we already tried compiling in the past then we need
to clean up the data structures that were partly filled in by the failed compile. That
causes some races, since the DFG may be trying to parse those data structures while we are
clearing them. This patch introduces such a clean-up (CodeBlock::resetJITData()) and fixes
the races.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::getCallLinkInfoMap):
(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetJITData):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::setSteppingMode):
(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::ensureResultProfile):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getFromAllValueProfiles):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::numberOfResultProfiles):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addRareCaseProfile): Deleted.
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset): Deleted.
(JSC::CodeBlock::couldTakeSpecialFastCase): Deleted.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • jit/JIT.cpp:

(JSC::JIT::link):

  • jit/JITWorklist.cpp:

(JSC::JITWorklist::compileNow):

1:21 PM Changeset in webkit [202396] by bshafiei@apple.com
  • 2 edits in branches/safari-602.1.38-branch/Source/WebKit2

Merged r202393. rdar://problem/17665473

1:16 PM Changeset in webkit [202395] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/26952627.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:05 PM Changeset in webkit [202394] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Web Inspector: Memory Timeline sometimes shows impossible value for bmalloc size (underflowed)
​https://bugs.webkit.org/show_bug.cgi?id=158110
<rdar://problem/26498584>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::externalMemorySize):

  • heap/HeapInlines.h:

(JSC::Heap::reportExternalMemoryVisited):
Keep count of external memory we visit.

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExternalMemoryVisited):
Report external memory visited like we do extra memory, since
it will be some subset of extra memory that is external.

Source/WebCore:

IOSurface memory backing Canvas element buffers should be classified as "GC Owned",
but should not be considered a part of bmalloc. In fact, the actual memory cost is
external to the Web Content Process. The majority of extra memory reporters tend
to report extra memory that is also allocated in bmalloc. However, some report
non-bmalloc memory, such as the IOSurfaces here.

Continue to report the memory cost without changes to inform the Heap for garbage
collection. However, also keep better accounting of GCOwned memory that is external
to the process for better accounting for the Resource Usage overlay and Web Inspector
Memory timeline.

This is a bit of a game where we want to display the best possible number for
"GCOwned memory" in the tools, but some of that memory shows up in the other
regions (bmalloc, system malloc, etc). Already many sizes are estimates
(ReportExtraMemory, reportExtraMemory ignores small allocations), so we just focus
on getting the largest sources of allocations, such as Canvas IOSurfaces here,
into the right bucket. ResourceUsageThreadCocoa continues to subtract the "extra"
memory from bmalloc. So, we should address other large sources of "extra memory"
not in bmalloc. A likely candidate is HTMLMediaElement which uses the deprecated
reporting right now.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:

Add a way to report External memory, dependent on reporting Extra memory.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::externalMemoryCost):

  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:

Report external memory cost just like extra memory.

  • page/ResourceUsageData.cpp:

(WebCore::ResourceUsageData::ResourceUsageData):

  • page/ResourceUsageData.h:

(WebCore::MemoryCategoryInfo::totalSize):

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::RingBuffer::at):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformDraw):

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Do not count the GCOwned External memory as dirty memory.
Include External memory output in the overlay.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):
When sizing the JavaScript portion, include both the GC Owned
category's dirty and external memory. Ultimately we will
want this everywhere in case things change.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::memoryCost):
(WebCore::externalMemoryCost):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::memoryCost):
(WebCore::ImageBuffer::externalMemoryCost):
Report IOSurface total bytes as extra memory and external memory
so that it can be tracked as GC Owned memory that is separate from
regular (bmalloc/other) in process memory.

12:58 PM Changeset in webkit [202393] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion
​https://bugs.webkit.org/show_bug.cgi?id=159068
<rdar://problem/17665473>

Reviewed by Tim Horton.

A WebPageProxy in closed state should not be allowed to hold a process assertion. It
currently happens that WebPageProxy::close() gets called but that the WebPageProxy is
kept alive by Safari (e.g. In case of top-hit preloading). In such cases, we fail to
release the foreground process assertion that the WebPageProxy holds.

We should clear the foreground process assertion that the WebPageProxy holds as soon
as WebPageProxy::close() is called.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

12:24 PM Changeset in webkit [202392] by Konstantin Tokarev
  • 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
​https://bugs.webkit.org/show_bug.cgi?id=159034

Unreviewed, followup for r202373.

  • efl/install-dependencies: Removed libxslt
  • gtk/install-dependencies: Ditto.
12:20 PM Changeset in webkit [202391] by bshafiei@apple.com
  • 12 edits in branches/safari-602.1.38-branch/Source

Merge patch for rdar://problem/26831566.

12:17 PM Changeset in webkit [202390] by ap@apple.com
  • 4 edits in trunk

Handle (0, 0) ranges from Lookup
​https://bugs.webkit.org/show_bug.cgi?id=159062
rdar://problem/26960385

Reviewed by Tim Horton.

Source/WebCore:

  • editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):

Paper over <​https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
to fix now.

LayoutTests:

  • platform/mac/TestExpectations: Unmark the test that was broken due to this.
12:16 PM Changeset in webkit [202389] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit2

[OS X][WK2] Expand sandbox for new mach endpoints
​https://bugs.webkit.org/show_bug.cgi?id=159040
<rdar://problem/25238336>

Reviewed by Alexey Proskuryakov.

Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
12:12 PM Changeset in webkit [202388] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:11 PM Changeset in webkit [202387] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:07 PM Changeset in webkit [202386] by bshafiei@apple.com
  • 1 copy in branches/safari-602.1.38-branch

New Branch.

12:07 PM Changeset in webkit [202385] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38

New tag.

11:52 AM Changeset in webkit [202384] by Joseph Pecoraro
  • 12 edits in trunk/Source

Web Inspector: first heap snapshot taken when a page is reloaded happens before the reload navigation
​https://bugs.webkit.org/show_bug.cgi?id=158995
<rdar://problem/26923778>

Reviewed by Brian Burg.

Source/WebCore:

When the "Heap" instrument is included in the Timeline list
of instruments, defer starting it in an auto-capture scenario
until after the page does its first navigation.

AutoCapture on the backend happens when it is enabled at
the main resource starts loading. In that case it proceeds
through the following phases:

No Auto Capture:

None

Auto Capture:

BeforeLoad -> FirstNavigation -> AfterFirstNavigation

When toggling instruments for backend initiated capture
most instruments do not care and will just start/stop.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the TimelineAgent that the main frame navigated.
Do this after informing the HeapAgent (so any potential
snapshot does not get cleared) and PageAgent (so the
frontend knows the page navigated before the agent starts).

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::mainFrameNavigated):
Update the auto capture phase transitions.

(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
Only start the heap agent during the None phase (console.profile)
or with the first navigation (auto capture page navigation).

Source/WebInspectorUI:

Let instruments decide to do work or not based on programmatic
(backend initiated) starts and stop.

Programmatic start can happen due to Auto Capture or console.profile.
Programmatic stop can happen due to console.profileEnd.

For example, this allows the frontend to avoid sending agents start/stop
messages when the backend would have already started/stopped the agents.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.capturingStopped):
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
Call Recording.start/stop with a programmatic flag so the frontend
instruments can perform a more informed start/stop.

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.start):
(WebInspector.TimelineRecording.prototype.stop):
Let the instruments decide to do work based on the start/stop
being initiated by the backend or not.

  • UserInterface/Models/HeapAllocationsInstrument.js:

(WebInspector.HeapAllocationsInstrument.prototype.startInstrumentation):
(WebInspector.HeapAllocationsInstrument.prototype.stopInstrumentation):

  • UserInterface/Models/Instrument.js:

(WebInspector.Instrument.startLegacyTimelineAgent):
(WebInspector.Instrument.prototype.startInstrumentation):
(WebInspector.Instrument.prototype.stopInstrumentation):
(WebInspector.Instrument):

  • UserInterface/Models/MemoryInstrument.js:

(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
(WebInspector.MemoryInstrument):

  • UserInterface/Models/NetworkInstrument.js:
  • UserInterface/Models/ScriptInstrument.js:

(WebInspector.ScriptInstrument.prototype.startInstrumentation):
(WebInspector.ScriptInstrument.prototype.stopInstrumentation):
(WebInspector.ScriptInstrument):
Avoid sending start/stop tracking messages when programmatic.
This still allows the instruments to do their own frontend tracking,
such as the Heap agent triggering periodic snapshots.

11:52 AM Changeset in webkit [202383] by Joseph Pecoraro
  • 24 edits
    3 copies in trunk/Source

Web Inspector: Snapshots should be cleared at some point
​https://bugs.webkit.org/show_bug.cgi?id=157907
<rdar://problem/26373610>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.h:
  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::resetNextAvailableObjectIdentifier):
Provide a way to reset the object identifier counter.

  • inspector/agents/InspectorHeapAgent.h:
  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::clearHeapSnapshots):
Make clearHeapSnapshots protected, so it can be called from a
a PageHeapAgent on page navigations.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:

New specialized agent.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Construct a specialized HeapAgent.

  • inspector/PageHeapAgent.h:
  • inspector/PageHeapAgent.cpp:

(WebCore::PageHeapAgent::PageHeapAgent):
(WebCore::PageHeapAgent::enable):
(WebCore::PageHeapAgent::disable):
(WebCore::PageHeapAgent::mainFrameNavigated):
Clear backend snapshots on page navigations.
Set the PageHeapAgent instrumenting agent on enable/disable.

  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::pageHeapAgent):
(WebCore::InstrumentingAgents::setPageHeapAgent):
Active PageHeapAgent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the PageHeapAgent when the mainframe navigates.

Source/WebInspectorUI:

Invalidate HeapSnapshotProxy objects when the page navigates.
This allows us to clear our frontend data for the snapshots.
When a snapshot is invalidated, it is disabled in the UI.
This means you cannot select the snapshot or see content
views for the snapshot. If you are in a snapshot when it is
invalidated, you are taken out to the snapshot list.

  • UserInterface/Main.html:

New files.

  • UserInterface/Proxies/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.invalidateSnapshotProxies):
(WebInspector.HeapSnapshotProxy.prototype.get invalid):
(WebInspector.HeapSnapshotProxy.prototype._invalidate):
Keep track of valid snapshots, and provide a static method to invalidate them.

(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

  • UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WebInspector.HeapSnapshotDiffProxy.prototype.get invalid):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotDiffProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

  • UserInterface/Proxies/HeapSnapshotWorkerProxy.js:

(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Invalidate and discard snapshots when the main frame navigates.

(WebInspector.HeapSnapshotWorkerProxy.prototype._handleMessage):
(WebInspector.HeapSnapshotWorkerProxy):

  • UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:

(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype._handleMessage):
(HeapSnapshotWorker):
A message may come in for a snapshot before it has been cleared.
If that is the case, the object may not exist. Return an error so
that the callback can be deleted on the calling side.

  • UserInterface/Views/HeapAllocationsTimelineDataGridNodePathComponent.js:

(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get previousSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get nextSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent):
Don't show invalid snapshots in page component picker.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:

(.timeline-overview-graph.heap-allocations > img.snapshot.invalid):

  • UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCells):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotInvalidated):
Give invalid snapshots an invalidated appearance in the snapshot list.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):

  • UserInterface/Views/HeapAllocationsTimelineView.css:

(.timeline-view.heap-allocations > .data-grid tr.invalid):
(.timeline-view.heap-allocations > .data-grid:not(:focus, .force-focus) tr.selected.invalid):
Give invalid snapshots an invalidated appearance in the overview graph.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotInvalidated):
(WebInspector.HeapAllocationsTimelineView.prototype._updateCompareHeapSnapshotButton):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Handle interactions when snapshots in the list are invalidated.

11:43 AM Changeset in webkit [202382] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
​https://bugs.webkit.org/show_bug.cgi?id=159053
<rdar://problem/26638119>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/custom-property-computed-style-length-update.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::length):

LayoutTests:

  • fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
  • fast/css/variables/custom-property-computed-style-length-update.html: Added.
9:56 AM Changeset in webkit [202381] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r201194.
​https://bugs.webkit.org/show_bug.cgi?id=159059

Not needed for iOS (Requested by bfulgham on #webkit).

Reverted changeset:

"[OS X][WK2] Expand sandbox for new mach endpoints"
​https://bugs.webkit.org/show_bug.cgi?id=157919
​http://trac.webkit.org/changeset/201194

9:35 AM Changeset in webkit [202380] by wilander@apple.com
  • 9 edits in trunk/Source

Source/WebCore:
Enable window.open() for existing versions of Secret Society
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

No new tests. Tested manually in the app.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

Now checks with Settings whether it should allow a popup even though it is
not processing a user gesture.

  • page/Settings.in:

Added setting allowWindowOpenWithoutUserGesture.

  • platform/RuntimeApplicationChecks.h:
  • platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):

Added.

Source/WebKit/mac:
Enable window.open() for existing versions of Secret Society app
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

  • WebView/WebView.mm:

(shouldAllowWindowOpenWithoutUserGesture):

Added.

(shouldConvertInvalidURLsToBlank):

Changed hex number to constant DYLD_IOS_VERSION_10_0.

Source/WTF:
Enable window.open() for existing versions of Secret Society
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

  • wtf/spi/darwin/dyldSPI.h:

Added DYLD_IOS_VERSION_10_0.

9:03 AM Changeset in webkit [202379] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Only call sqlite3_initialize() when a SQLite database is actually being opened
​https://bugs.webkit.org/show_bug.cgi?id=159033

Reviewed by Brady Eidson.

Only call sqlite3_initialize() when a SQLite database is actually being opened
instead of doing it unconditionally. sqlite3_initialize() was previously called
in the SQLiteDatabase constructor which gets called on WebContent process
initialization because a DatabaseTracker is constructed on initialization and
DatabaseTracker has a SQLiteDatabase data member.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::initializeSQLiteIfNecessary):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::SQLiteDatabase): Deleted.

  • platform/sql/SQLiteDatabase.h:
8:10 AM Changeset in webkit [202378] by adam.bergkvist@ericsson.com
  • 2 edits in trunk/Source/WebCore

WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
​https://bugs.webkit.org/show_bug.cgi?id=159054

Reviewed by Eric Carlson.

Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
and 'update ICE gathering state' routines as described in [1].

[1] ​https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state

No change in current behavior.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):

8:05 AM Changeset in webkit [202377] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[EFL] Bump gstreamer version from 1.6.3 to 1.8.0
​https://bugs.webkit.org/show_bug.cgi?id=159050

Patch by Gyuyoung Kim <​gyuyoung.kim@samsung.com> on 2016-06-23
Reviewed by Antonio Gomes.

To be sync with GTK port, this patch bumps gstreamer version for EFL port.

  • efl/jhbuild.modules:
  • efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
  • efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
6:52 AM Changeset in webkit [202376] by adam.bergkvist@ericsson.com
  • 12 edits
    2 adds in trunk

WebRTC: Add support for RTCPeerConnection legacy MediaStream-based API
​https://bugs.webkit.org/show_bug.cgi?id=158940

Reviewed by Eric Carlson.

Source/WebCore:

Implement the legacy MediaStream-based RTCPeerConnection API as JS built-ins. The
getRemoteStreams() function and the 'addstream' event are partly implemented with native
code.

Test: fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::getRemoteStreams):
The getRemoteStreams() function and the 'addstream' event is backed up by native code.

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnection.js:

(initializeRTCPeerConnection):
(getLocalStreams):
(getRemoteStreams):
(getStreamById):
(addStream):
(removeStream):
Legacy API implemented as JS built-ins.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Add test for RTCPeerConnection legacy MediaStream-based API.

  • fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html: Added.
  • platform/mac/TestExpectations:

Skip test for mac port (not building with WEB_RTC yet)

3:08 AM Changeset in webkit [202375] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations for passing accessibility tests after r202149,
and fix style issues in test expectations file.

  • platform/win/TestExpectations:
3:08 AM Changeset in webkit [202374] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.13.2

WebKitGTK+ 2.13.2

2:51 AM Changeset in webkit [202373] by Konstantin Tokarev
  • 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
​https://bugs.webkit.org/show_bug.cgi?id=159034

Reviewed by Michael Catanzaro.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:16 AM Changeset in webkit [202372] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.13.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.13.2.
1:50 AM Changeset in webkit [202371] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix the build with CSS Shapes disabled.

  • css/StyleBuilderConverter.h:
12:23 AM Changeset in webkit [202370] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[Soup] Clean up SocketStreamHandle soup implementation
​https://bugs.webkit.org/show_bug.cgi?id=159024

Reviewed by Žan Doberšek.

Stop using a global HashMap to "acivate"/"deactivate" handles, and just take a reference of the handle and
pass the ownership to the callbacks, using a GCancellable to cancel all async operations.

  • platform/network/soup/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::id): Deleted.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::connectedCallback):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::readReadyCallback):
(WebCore::SocketStreamHandle::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandle::writeReadyCallback):
(WebCore::getHandleFromId): Deleted.
(WebCore::deactivateHandle): Deleted.
(WebCore::activateHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::connectedCallback): Deleted.
(WebCore::readReadyCallback): Deleted.
(WebCore::writeReadyCallback): Deleted.

Jun 22, 2016:

11:44 PM Changeset in webkit [202369] by pvollan@apple.com
  • 3 edits in trunk/Tools

[Win] Use Windows api function to find top level parent.
​https://bugs.webkit.org/show_bug.cgi?id=159021

Reviewed by Brent Fulgham.

Delete findTopLevelParent function, and use Win32 function GetAncestor instead.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runModal):
(findTopLevelParent): Deleted.

  • MiniBrowser/win/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::runModal):
(findTopLevelParent): Deleted.

11:33 PM Changeset in webkit [202368] by pvollan@apple.com
  • 6 edits in trunk

[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
​https://bugs.webkit.org/show_bug.cgi?id=158934

Reviewed by Brent Fulgham.

Source/WebKit/win:

Add a method to delete all indexed databases.

  • Interfaces/IWebDatabaseManager.idl:
  • WebDatabaseManager.cpp:

(WebDatabaseManager::QueryInterface):
(WebDatabaseManager::deleteAllIndexedDatabases):

  • WebDatabaseManager.h:

Tools:

DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::clearAllDatabases):

11:10 PM Changeset in webkit [202367] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r201880): WebSockets based remote inspector is broken since r201880
​https://bugs.webkit.org/show_bug.cgi?id=158613

Reviewed by Michael Catanzaro.

In r201880 SocketStreamHandleClient was modified to receive references instead of
pointers. WebSocketServerConnection also implements SocketStreamHandleClient but since it's doesn't use
override, it was unnoticed and not updated, so we ended up using the default empty implementation instead of
the WebSocketServerConnection one.

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::setSocketHandle):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
(WebKit::WebSocketServerConnection::didUpdateBufferedAmount):
(WebKit::WebSocketServerConnection::didFailSocketStream): Deleted.

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
10:46 PM Changeset in webkit [202366] by sbarati@apple.com
  • 2 edits in trunk/Tools

run-javascriptcore-tests should have some environment variables for commonly used settings
​https://bugs.webkit.org/show_bug.cgi?id=159047

Reviewed by Keith Miller.

This patch adds three environment variables that run-javascriptcore-tests
consults:

  • RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It determines if we should run the api tests or not.
  • RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It determines if we will perform a build or not before running the tests. to set the default should-build setting.
  • RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to a yaml file. If set, we will run the extra tests it refers to.

All the values in these environment variables will be overridden if an
option is explicitly passed in. For example, the following will run
the api tests:
RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi

  • Scripts/run-javascriptcore-tests:
9:01 PM Changeset in webkit [202365] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Expand sandbox to read voice services preferences
​https://bugs.webkit.org/show_bug.cgi?id=159046
<rdar://problem/26926722>

Reviewed by Alexey Proskuryakov.

Expand the sandbox to permit read-only access to voice services preferences.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
8:24 PM Changeset in webkit [202364] by sbarati@apple.com
  • 9 edits
    2 adds in trunk

TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
​https://bugs.webkit.org/show_bug.cgi?id=159037
<rdar://problem/26935349>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

The primary focus of this patch is to make the concurrent
baseline JIT work with the type profiler. We were clearing
the type profiler log on the background baseline compiler
thread which lead to bad things happening. This patch fixes
this by processing the log before we launch the compile on
a background thread.

Secondly, I audited the type profiler code inside the DFG,
and found that we were doing some racy things. I haven't
seen any crashes because of these things, but it is possible
that they exist. We were grabbing a RefPtr to a TypeSet,
even though TypeSet was RefCounted and not ThreadSafeRefCounted.
This patch makes TypeSet ThreadSafeRefCounted. We were
also copying a StructureSet while the execution thread could
be augmenting the StructureSet. This patch puts changes to
TypeSet's StructureSet behind a ConcurrentJITLock.

I've also added two more large running tests that run with the
type profiler enabled. These are here just to catch any major bugs
in the type profiler implementation.

  • jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
(JSC::JIT::doMainThreadPreparationBeforeCompile):
(JSC::JIT::frameRegisterCountFor):

  • jit/JIT.h:

(JSC::JIT::compile):

  • jit/JITWorklist.cpp:

(JSC::JITWorklist::Plan::Plan):
(JSC::JITWorklist::Plan::compileInThread):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):

  • runtime/TypeSet.h:

(JSC::TypeSet::create):
(JSC::TypeSet::isEmpty):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::structureSet):

  • tests/typeProfiler/deltablue-for-of.js: Added.
  • tests/typeProfiler/getter-richards.js: Added.

Tools:

Run typeProfiler.yaml tests under an additional CJIT enabled mode.

  • Scripts/run-jsc-stress-tests:
6:39 PM Changeset in webkit [202363] by keith_miller@apple.com
  • 20 edits
    1 add in trunk/Source/JavaScriptCore

We should have a DFG intrinsic that checks if a value is a TypedArrayView
​https://bugs.webkit.org/show_bug.cgi?id=159048

Reviewed by Saam Barati.

This patch adds a new DFG Intrinsic that checks if a value is a TypedArrayView.
The intrinsic, IsTypedArrayView, works in the same way that the other Is<insert-type>
DFG nodes work. Additionally, a new builtin function isTypedArrayView has been added.
These changes are needed to fix regressions in %TypedArray%.prototype.subarray.

  • builtins/BuiltinNames.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIsTypedArrayView):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsTypedArrayView):
(JSC::FTL::DFG::LowerDFGToB3::isTypedArrayView):

  • runtime/Intrinsic.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewPrivateFuncIsTypedArrayView):

  • runtime/JSTypedArrayViewPrototype.h:
  • tests/stress/istypedarrayview-intrinsic.js: Added.

(makeFn):
(typedArrays.forEach):
(let.test):
(test):

6:13 PM Changeset in webkit [202362] by aakash_jain@apple.com
  • 88 edits in trunk/Tools

Fix style issues in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=159019

Reviewed by Daniel Bates.

Fixed the formatting issues as reported by check-webkit-style in webkitpy.
There is no functionality change.
Only affected file names retained below for brevity.

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
  • Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
  • Scripts/webkitpy/benchmark_runner/utils.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_mock.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
  • Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/common/config/irc.py:
  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/common/system/path_unittest.py:
  • Scripts/webkitpy/common/system/platforminfo.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/common/system/user_unittest.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/common/thread/threadedmessagequeue.py:
  • Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_failures.py:
  • Scripts/webkitpy/layout_tests/models/test_run_results.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/views/printing.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
  • Scripts/webkitpy/port/base_unittest.py:
  • Scripts/webkitpy/port/driver.py:
  • Scripts/webkitpy/port/driver_unittest.py:
  • Scripts/webkitpy/port/factory.py:
  • Scripts/webkitpy/port/gtk.py:
  • Scripts/webkitpy/port/server_process_unittest.py:
  • Scripts/webkitpy/port/test.py:
  • Scripts/webkitpy/port/win.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/common_unittest.py:
  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
  • Scripts/webkitpy/style/checkers/js.py:
  • Scripts/webkitpy/style/checkers/jsonchecker.py:
  • Scripts/webkitpy/style/checkers/png.py:
  • Scripts/webkitpy/style/checkers/text.py:
  • Scripts/webkitpy/style/checkers/text_unittest.py:
  • Scripts/webkitpy/style/error_handlers.py:
  • Scripts/webkitpy/style/filter.py:
  • Scripts/webkitpy/style/filter_unittest.py:
  • Scripts/webkitpy/style/optparser.py:
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/test/main.py:
  • Scripts/webkitpy/w3c/test_converter.py:
  • Scripts/webkitpy/w3c/test_converter_unittest.py:
  • Scripts/webkitpy/w3c/test_importer_unittest.py:
  • Scripts/webkitpy/xcode/simulator.py:
5:19 PM Changeset in webkit [202361] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Add SPI to allow creating a WKCertificateInfoRef from a SecTrustRef
​https://bugs.webkit.org/show_bug.cgi?id=159025

Patch by Sam Weinig <​sam@webkit.org> on 2016-06-22
Reviewed by Tim Horton.

  • Shared/API/c/mac/WKCertificateInfoMac.h:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithServerTrust):

5:14 PM Changeset in webkit [202360] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectations gardening for rdar://problem/26960385

  • platform/mac/TestExpectations:
4:46 PM Changeset in webkit [202359] by beidson@apple.com
  • 12 edits
    1 add in trunk

DatabaseProcess doesn't handle WebProcesses going away uncleanly.
​https://bugs.webkit.org/show_bug.cgi?id=158894

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by additions to existing API test).

  • Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::registerDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::unregisterDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::connectionToClientClosed):

  • Modules/indexeddb/server/IDBConnectionToClient.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::unregisterConnection): Call connectionToClientClosed() on

the connection, which cleans up after it in the server.

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):

Source/WebKit2:

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didClose):

  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess): Actually unregister this connection

from the IDBServer so it can clean up.

(WebKit::WebIDBConnectionToClient::~WebIDBConnectionToClient):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4:35 PM Changeset in webkit [202358] by commit-queue@webkit.org
  • 21 edits
    12 adds in trunk

AX: Add support for CSS4 :focus-within pseudo
​https://bugs.webkit.org/show_bug.cgi?id=140144

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-22
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/css/pseudo-focus-within-basics.html

fast/css/pseudo-focus-within-inside-shadow-dom.html
fast/css/pseudo-focus-within-style-sharing-1.html
fast/css/pseudo-focus-within-style-sharing-2.html
fast/selectors/focus-within-style-update.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasFocusWithin):

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::setFocus):
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::setIsNamedFlowContentElement):
(WebCore::Element::clearIsNamedFlowContentElement):
(WebCore::Element::setStyleAffectedByFocusWithin):
(WebCore::Element::rareDataStyleAffectedByFocusWithin):
(WebCore::Element::rareDataIsNamedFlowContentElement):

  • dom/Element.h:

(WebCore::Element::hasFocusWithin):
(WebCore::Element::styleAffectedByFocusWithin):
(WebCore::Element::isNamedFlowContentElement):
(WebCore::Element::setHasFocusWithin):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::styleAffectedByFocusWithin):
(WebCore::ElementRareData::setStyleAffectedByFocusWithin):
(WebCore::ElementRareData::isNamedFlowContentElement):
(WebCore::ElementRareData::setIsNamedFlowContentElement):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetComputedStyle):

  • dom/Node.h:

(WebCore::Node::flagHasFocusWithin):
(WebCore::Node::isNamedFlowContentNode): Deleted.
(WebCore::Node::setIsNamedFlowContentNode): Deleted.
(WebCore::Node::clearIsNamedFlowContentNode): Deleted.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::nextNodeInsideContentElement):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):

  • style/StyleRelations.cpp:

(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):

  • style/StyleRelations.h:
  • style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/pseudo-focus-within-basics-expected.html: Added.
  • fast/css/pseudo-focus-within-basics.html: Added.
  • fast/css/pseudo-focus-within-inside-shadow-dom-expected.html: Added.
  • fast/css/pseudo-focus-within-inside-shadow-dom.html: Added.
  • fast/css/pseudo-focus-within-style-sharing-1-expected.html: Added.
  • fast/css/pseudo-focus-within-style-sharing-1.html: Added.
  • fast/css/pseudo-focus-within-style-sharing-2-expected.html: Added.
  • fast/css/pseudo-focus-within-style-sharing-2.html: Added.
  • fast/selectors/focus-within-style-update-expected.txt: Added.
  • fast/selectors/focus-within-style-update.html: Added.
4:31 PM Changeset in webkit [202357] by Chris Dumez
  • 5 edits in trunk/Source/WebKit2

Stop using PassRefPtr in ShareableResource
​https://bugs.webkit.org/show_bug.cgi?id=159043

Reviewed by Alex Christensen.

Stop using PassRefPtr in ShareableResource.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::store):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):

  • Shared/ShareableResource.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::ShareableResource::wrapInSharedBuffer):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::create):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::ShareableResource):

  • Shared/ShareableResource.h:
4:23 PM Changeset in webkit [202356] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Integrate WebKit's CFURLConnection with App Transport Security
​https://bugs.webkit.org/show_bug.cgi?id=159039
<rdar://problem/26953685>

Reviewed by Alex Christensen.

Pass additional options to NSURLConnect initialiser to identify that
this connection is for WebKit content loading.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

3:56 PM Changeset in webkit [202355] by jonlee@apple.com
  • 2 edits in trunk/Tools

Update animometer.plan
​https://bugs.webkit.org/show_bug.cgi?id=159012

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3:52 PM Changeset in webkit [202354] by dino@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION: Double tap to zoom does not work on yahoo finance
​https://bugs.webkit.org/show_bug.cgi?id=158886
<rdar://problem/24917760>

Reviewed by Simon Fraser.

Source/WebKit2:

We shouldn't enable fast click on pages that have
had to shrink to fit. In other words, we should enable
double-tap-to-zoom if the page has already zoomed.

Test: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsDoubleTapGestures]):

LayoutTests:

  • fast/events/ios/viewport-shrink-to-fit-allows-double-tap-expected.txt: Added.
  • fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html: Added.
3:19 PM Changeset in webkit [202353] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: don't start auto capturing if the Inspector window is not visible
​https://bugs.webkit.org/show_bug.cgi?id=159014

Reviewed by Joseph Pecoraro.
<rdar://problem/26931269>

Followup, add a missing super.closed() call mentioned in review comments.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.closed):

3:05 PM Changeset in webkit [202352] by BJ Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: don't start auto capturing if the Inspector window is not visible
​https://bugs.webkit.org/show_bug.cgi?id=159014
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

TimelineTabContentView should not tell the timeline manager to enable
auto-capturing unless the Web Inspector UI is visible. If it is preloaded
but not shown to the user, then auto-capturing may inadvertently disable
the debugger, causing it to miss debugger statements and not bring the
inspector to front.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
Bail out if nothing changed. Coerce to a boolean since the backend requires a boolean.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView): Listen for UI visibility changes.
(WebInspector.TimelineTabContentView.prototype.shown):
Enable auto-capturing if the UI is visible.

(WebInspector.TimelineTabContentView.prototype.closed): Added.
Remove listeners on global objects so this tab doesn't leak.

(WebInspector.TimelineTabContentView.prototype._inspectorVisibilityChanged):
Update the auto-capturing setting if the UI became visible or not visible.

2:41 PM Changeset in webkit [202351] by BJ Burg
  • 4 edits in trunk/Source/WebKit2

Web Automation: Automation.inspectBrowsingContext should have an option to enable timeline auto-capturing
​https://bugs.webkit.org/show_bug.cgi?id=159004
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

Automation.inspectBrowsingContext was added to make it easier to hit breakpoints inside of
code evaluated using Automation.evaluateJavaScriptFunction. I recently changed the behavior
of this command to automatically start profiling the page as soon as the inspector attached
so that a full timeline recording could be obtained. However, starting a timeline recording
turns off the debugger, so this command is not so useful for debugging right now.

Add a new option, enableAutoCapturing, to the inspectBrowsingContext command. Don't toggle
profiling automatically unless this optional flag is present and set to true.

  • UIProcess/Automation/Automation.json:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::inspectBrowsingContext):
(WebKit::WebAutomationSession::inspectorFrontendLoaded): Deleted.

  • UIProcess/Automation/WebAutomationSession.h:
2:17 PM Changeset in webkit [202350] by jeremyj-wk@apple.com
  • 8 edits in trunk/Source/WebCore

Adopt commitPriority to get rid of the 2 AVPL solution for PiP
​https://bugs.webkit.org/show_bug.cgi?id=158949
rdar://problem/26867866

Reviewed by Simon Fraser.

No new tests because there is no behavior change. This reverts changes from
​https://bugs.webkit.org/show_bug.cgi?id=158148 and instead uses -[CAContext commitPriority:]
to prevent flicker when moving a layer between contexts.
commitPriority allows the layer to be added to the destination context before it is
removed from the source context.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: remove m_secondaryVideoLayer.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): ditto

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers):ditto

  • platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: ditto
  • platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: ditto

(WebCore::VideoFullscreenLayerManager::setVideoLayer): ditto
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): ditto and adopt commitPriority.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Deleted.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): remove m_secondaryVideoLayer.

  • platform/spi/cocoa/QuartzCoreSPI.h: Add commitPriority.
2:06 PM Changeset in webkit [202349] by mmaxfield@apple.com
  • 68 edits
    20 copies
    22 adds
    1 delete in trunk/LayoutTests

Test gardening for css3/line-break-language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=159017

Unreviewed.

Some reftests had content which ended up outside of the viewport. This patch
splits that extra content out into separate tests.

In addition, this test migrates these tests to using a web font, so the results
of this test are not sensitive to platform-specific font fallback.

Because of the migration to the web font, css3/line-break-language-sensitive is
no longer needed.

  • TestExpectations:
  • css3/line-break-language-sensitive/line-break-auto-centered-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-centered.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-half-kana-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-half-kana.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-hyphens.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-inseparables-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-inseparables.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-iteration-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-iteration-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-postfixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-prefixes-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-prefixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-sound-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-auto-sound-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-centered.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-half-kana-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-half-kana.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-hyphens.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-inseparables-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-inseparables.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-iteration-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-postfixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-prefixes-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-prefixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-sound-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-loose-sound-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-centered-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-centered.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-half-kana-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-half-kana.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-hyphens-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-hyphens.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-inseparables-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-inseparables.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-iteration-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-postfixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-prefixes-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-prefixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-sound-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-normal-sound-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-centered-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-centered.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-half-kana-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-half-kana.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-hyphens.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-inseparables-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-inseparables.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-iteration-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-iteration-marks.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-postfixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-prefixes-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-prefixes.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-sound-marks-expected.html: Removed.
  • css3/line-break-language-sensitive/line-break-strict-sound-marks.html: Removed.
  • css3/line-break/line-break-auto-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-hyphens-expected.html.
  • css3/line-break/line-break-auto-centered-2.html: Added.
  • css3/line-break/line-break-auto-centered-expected.html:
  • css3/line-break/line-break-auto-centered.html:
  • css3/line-break/line-break-auto-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-auto-half-kana-2.html: Added.
  • css3/line-break/line-break-auto-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-auto-half-kana-3.html: Added.
  • css3/line-break/line-break-auto-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
  • css3/line-break/line-break-auto-half-kana-4.html: Added.
  • css3/line-break/line-break-auto-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-postfixes-expected.html.
  • css3/line-break/line-break-auto-half-kana-5.html: Added.
  • css3/line-break/line-break-auto-half-kana-expected.html:
  • css3/line-break/line-break-auto-half-kana.html:
  • css3/line-break/line-break-auto-hyphens-expected.html:
  • css3/line-break/line-break-auto-hyphens.html:
  • css3/line-break/line-break-auto-inseparables-expected.html:
  • css3/line-break/line-break-auto-inseparables.html:
  • css3/line-break/line-break-auto-iteration-marks-expected.html:
  • css3/line-break/line-break-auto-iteration-marks.html:
  • css3/line-break/line-break-auto-postfixes-expected.html:
  • css3/line-break/line-break-auto-postfixes.html:
  • css3/line-break/line-break-auto-prefixes-expected.html:
  • css3/line-break/line-break-auto-prefixes.html:
  • css3/line-break/line-break-auto-sound-marks-expected.html:
  • css3/line-break/line-break-auto-sound-marks.html:
  • css3/line-break/line-break-loose-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-hyphens-expected.html.
  • css3/line-break/line-break-loose-centered-2.html: Added.
  • css3/line-break/line-break-loose-centered-expected.html:
  • css3/line-break/line-break-loose-centered.html:
  • css3/line-break/line-break-loose-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-loose-half-kana-2.html: Added.
  • css3/line-break/line-break-loose-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-loose-half-kana-3.html: Added.
  • css3/line-break/line-break-loose-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-centered-expected.html.
  • css3/line-break/line-break-loose-half-kana-4.html: Added.
  • css3/line-break/line-break-loose-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-iteration-marks-expected.html.
  • css3/line-break/line-break-loose-half-kana-5.html: Added.
  • css3/line-break/line-break-loose-half-kana-expected.html:
  • css3/line-break/line-break-loose-half-kana.html:
  • css3/line-break/line-break-loose-hyphens-expected.html:
  • css3/line-break/line-break-loose-hyphens.html:
  • css3/line-break/line-break-loose-inseparables-expected.html:
  • css3/line-break/line-break-loose-inseparables.html:
  • css3/line-break/line-break-loose-iteration-marks-expected.html:
  • css3/line-break/line-break-loose-iteration-marks.html:
  • css3/line-break/line-break-loose-postfixes-expected.html:
  • css3/line-break/line-break-loose-postfixes.html:
  • css3/line-break/line-break-loose-prefixes-expected.html:
  • css3/line-break/line-break-loose-prefixes.html:
  • css3/line-break/line-break-loose-sound-marks-expected.html:
  • css3/line-break/line-break-loose-sound-marks.html:
  • css3/line-break/line-break-normal-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-iteration-marks-expected.html.
  • css3/line-break/line-break-normal-centered-2.html: Added.
  • css3/line-break/line-break-normal-centered-expected.html:
  • css3/line-break/line-break-normal-centered.html:
  • css3/line-break/line-break-normal-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-normal-half-kana-2.html: Added.
  • css3/line-break/line-break-normal-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-normal-half-kana-3.html: Added.
  • css3/line-break/line-break-normal-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-normal-half-kana-4.html: Added.
  • css3/line-break/line-break-normal-half-kana-5-expected.html: Copied from LayoutTests/css3/line-break/line-break-loose-postfixes-expected.html.
  • css3/line-break/line-break-normal-half-kana-5.html: Added.
  • css3/line-break/line-break-normal-half-kana-expected.html:
  • css3/line-break/line-break-normal-half-kana.html:
  • css3/line-break/line-break-normal-hyphens-expected.html:
  • css3/line-break/line-break-normal-hyphens.html:
  • css3/line-break/line-break-normal-inseparables-expected.html:
  • css3/line-break/line-break-normal-inseparables.html:
  • css3/line-break/line-break-normal-iteration-marks-expected.html:
  • css3/line-break/line-break-normal-iteration-marks.html:
  • css3/line-break/line-break-normal-postfixes-expected.html:
  • css3/line-break/line-break-normal-postfixes.html:
  • css3/line-break/line-break-normal-prefixes-expected.html:
  • css3/line-break/line-break-normal-prefixes.html:
  • css3/line-break/line-break-normal-sound-marks-expected.html:
  • css3/line-break/line-break-normal-sound-marks.html:
  • css3/line-break/line-break-strict-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-hyphens-expected.html.
  • css3/line-break/line-break-strict-centered-2.html: Added.
  • css3/line-break/line-break-strict-centered-expected.html:
  • css3/line-break/line-break-strict-centered.html:
  • css3/line-break/line-break-strict-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
  • css3/line-break/line-break-strict-half-kana-2.html: Added.
  • css3/line-break/line-break-strict-half-kana-3-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
  • css3/line-break/line-break-strict-half-kana-3.html: Added.
  • css3/line-break/line-break-strict-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
  • css3/line-break/line-break-strict-half-kana-4.html: Added.
  • css3/line-break/line-break-strict-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
  • css3/line-break/line-break-strict-half-kana-5.html: Added.
  • css3/line-break/line-break-strict-half-kana-expected.html:
  • css3/line-break/line-break-strict-half-kana.html:
  • css3/line-break/line-break-strict-hyphens-expected.html:
  • css3/line-break/line-break-strict-hyphens.html:
  • css3/line-break/line-break-strict-inseparables-expected.html:
  • css3/line-break/line-break-strict-inseparables.html:
  • css3/line-break/line-break-strict-iteration-marks-expected.html:
  • css3/line-break/line-break-strict-iteration-marks.html:
  • css3/line-break/line-break-strict-postfixes-expected.html:
  • css3/line-break/line-break-strict-postfixes.html:
  • css3/line-break/line-break-strict-prefixes-expected.html:
  • css3/line-break/line-break-strict-prefixes.html:
  • css3/line-break/line-break-strict-sound-marks-expected.html:
  • css3/line-break/line-break-strict-sound-marks.html:
  • css3/line-break/resources/AllAhem.svg: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
1:44 PM Changeset in webkit [202348] by Simon Fraser
  • 6 edits
    2 adds in trunk

REGRESSION (r201629): Weird button glitching on github.com
​https://bugs.webkit.org/show_bug.cgi?id=159031
rdar://problem/26880332

Reviewed by Tim Horton.

Source/WebCore:

r201629 changed the logic slightly when creating an image buffer for a scaled context;
it set the buffer context's scale to the scale in the source context, but this failed
to take into account the rounding up of the buffer size, which the old code did.

Fix by reverting to the old behavior.

Since buffer sizes can only be integral, changed compatibleBufferSize() to return
an IntSize.

Test: fast/backgrounds/scaled-gradient-background.html

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::compatibleBufferSize):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/IntRect.h:

(WebCore::IntRect::area):

  • platform/graphics/IntSize.h:

(WebCore::IntSize::area): Make this return an unsigned.

LayoutTests:

  • fast/backgrounds/scaled-gradient-background-expected.html: Added.
  • fast/backgrounds/scaled-gradient-background.html: Added.
1:39 PM Changeset in webkit [202347] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebKit2

Mail snapshot has black webview in multitasking switcher
​https://bugs.webkit.org/show_bug.cgi?id=159036
<rdar://problem/25972938>

Reviewed by Simon Fraser.

There is a window of time between an application going into the background
and SpringBoard's snapshotting mechanism completing where it is possible
(though difficult, timing-wise) for RemoteLayerBackingStoreCollection to
make still-needed surfaces volatile (and, even worse, for them to get emptied).

UIKit suggested instead waiting for the window context teardown notification,
which does indeed seem to fire after the snapshotting is complete.
This may have the convenient side effect of making the volatility timer
repeat fewer times in general, because it is now started closer to the
last time that the surfaces will be in-use.

  • UIProcess/ApplicationStateTracker.h:
  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView didMoveToWindow]):
(-[WKContentView _applicationDidFinishSnapshottingAfterEnteringBackground]):

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView didMoveToWindow]):
(-[WKPDFView _applicationDidFinishSnapshottingAfterEnteringBackground]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationDidEnterBackground):
(WebKit::WebPage::applicationDidFinishSnapshottingAfterEnteringBackground):

1:38 PM Changeset in webkit [202346] by andersca@apple.com
  • 4 edits
    2 adds
    1 delete in trunk/Source/WebKit

Move the WebKitLegacy Apple Pay code to the open source repository
​https://bugs.webkit.org/show_bug.cgi?id=159035

Reviewed by Tim Horton.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
  • WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.

(WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::supportsVersion):
(WebPaymentCoordinatorClient::canMakePayments):
(WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
(WebPaymentCoordinatorClient::showPaymentUI):
(WebPaymentCoordinatorClient::completeMerchantValidation):
(WebPaymentCoordinatorClient::completeShippingMethodSelection):
(WebPaymentCoordinatorClient::completeShippingContactSelection):
(WebPaymentCoordinatorClient::completePaymentMethodSelection):
(WebPaymentCoordinatorClient::completePaymentSession):
(WebPaymentCoordinatorClient::abortPaymentSession):
(WebPaymentCoordinatorClient::mainFrameDestroyed):

  • WebKitAdditions.mm: Removed.
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

1:00 PM Changeset in webkit [202345] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Inline the last of the Apple Pay WebCore code
​https://bugs.webkit.org/show_bug.cgi?id=159032

Reviewed by Tim Horton.

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

  • page/MainFrame.h:
  • page/PageConfiguration.h:
  • platform/cocoa/ThemeCocoa.mm:

(WebCore::passKitBundle):
(WebCore::loadPassKitPDFPage):
(WebCore::applePayButtonLogoBlack):
(WebCore::applePayButtonLogoWhite):
(WebCore::drawApplePayButton):
(WebCore::ThemeCocoa::drawNamedImage):

12:36 PM Changeset in webkit [202344] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectation gardening for rdar://problem/26950065

  • platform/mac/TestExpectations:
12:25 PM Changeset in webkit [202343] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectation gardening.

  • platform/mac/TestExpectations:
12:10 PM Changeset in webkit [202342] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Exception is not thrown when shipping method is an invalid amount
​https://bugs.webkit.org/show_bug.cgi?id=159030
rdar://problem/26700413

Reviewed by Tim Horton.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::createShippingMethods):
Bail if createShippingMethod returns Nullopt.

(WebCore::createPaymentRequest):
Bail if createShippingMethods returns Nullopt.

11:43 AM Changeset in webkit [202341] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Exception is not thrown when shipping method is an invalid amount
​https://bugs.webkit.org/show_bug.cgi?id=159029
rdar://problem/26700413

Reviewed by Tim Horton.

  • Modules/applepay/PaymentRequest.h:

Change ShippingMethod::amount to be a signed 64-bit integer.

  • Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
Call validateShippingMethods.

(WebCore::PaymentRequestValidator::validateShippingMethods):
Validate all the shipping methods.

(WebCore::PaymentRequestValidator::validateShippingMethod):
Check that the amount is >= 0.

  • Modules/applepay/PaymentRequestValidator.h:

Add new members.

11:20 AM Changeset in webkit [202340] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

W3C test importer should generate files to ignore by WebKit SCM
​https://bugs.webkit.org/show_bug.cgi?id=142743

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2016-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • resources/TestRepositories: Added the option to generate .gitignore and init.py for wpt repo.
  • web-platform-tests/.gitignore: Regeneration changes the order of the ignored files and removes the init.py which is now committed to WebKit trunk.
  • web-platform-tests/init.py: Added.

Tools:

TestDownloader generates the .gitignore file according submodules git repository information.
TestImporter requests the generation of .gitignore and the main init.py according LayoutTests/imported/w3c/resources/TestRepositories options.

  • Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.generate_gitignore): Generating .gitignore according submodules description.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/init.py if the repo has the right option.
(TestImporter):
(TestImporter.write_init_py): Writing not empty init.py files.
(TestImporter.import_tests): Using of write_init_py.

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_git_ignore_generation): Added .gitignore test.
(TestImporterTest):
(TestImporterTest.test_initpy_generation): Added init.py test.

11:15 AM Changeset in webkit [202339] by adam.bergkvist@ericsson.com
  • 9 edits
    2 adds in trunk

WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=158985

Source/WebCore:

Reviewed by Eric Carlson.

Implement MediaEndpointPeerConnection's isNegotiationNeeded, markAsNeedingNegotiation and
clearNegotiationNeededState functions. The calls to these functions are already up-to-date.

Test: fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::markAsNeedingNegotiation):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

Add tests for the RTCPeerConnection negotiationneeded event.

Reviewed by Eric Carlson.

  • fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.

Verify that a negotiationneeded event is fired when not all local media can be included in
an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)

  • fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

Verify that a negotiationneeded event is fired when tracks are added and removed from an
RTCPeerConnection.

  • platform/gtk/TestExpectations:

Unskip fast/mediastream/RTCPeerConnection-onnegotiationneeded.html.

  • platform/mac/TestExpectations:

The mac port does not build with WEB_RTC enabled yet.

11:14 AM Changeset in webkit [202338] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests/imported/w3c

imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=155760

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-22
Reviewed by Alexey Proskuryakov.

Making test more predictable.
Upstreamed to w3c repository as ​https://github.com/w3c/web-platform-tests/pull/3203.

  • web-platform-tests/streams/readable-streams/general.js:

(promise_test):

11:12 AM Changeset in webkit [202337] by adam.bergkvist@ericsson.com
  • 7 edits
    1 delete in trunk/Source/WebCore

WebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor
​https://bugs.webkit.org/show_bug.cgi?id=158832

Reviewed by Eric Carlson and Youenn Fablet.

Use a JS built-in constructor instead of a custom constructor. This makes it easier to
initialize private fields for functions implemented as JS built-ins. The constructor
behavior is in need of updating, but that is left to a follow-up change [1].

[1] ​http://webkit.org/b/158936
No change in behavior.

  • CMakeLists.txt:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::initializeWith):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnection.js:

(initializeRTCPeerConnection):
Add JS built-in constructor function.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRTCPeerConnectionCustom.cpp: Removed.

(WebCore::constructJSRTCPeerConnection): Deleted.

11:11 AM Changeset in webkit [202336] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CrossOriginPreflightChecker should call DocumentThreadableLoader preflightFailure instead of didFailLoading
​https://bugs.webkit.org/show_bug.cgi?id=158984

Patch by Youenn Fablet <​youenn@apple.com> on 2016-06-22
Reviewed by Darin Adler.

No change of behavior.

Calling DocumentThreadableLoader preflightFailure instead of didFailLoading for any preflight error case.

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::notifyFinished): Directly calling preflightFailure callback.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.
(WebCore::CrossOriginPreflightChecker::handleLoadingFailure): Deleted.
(WebCore::CrossOriginPreflightChecker::redirectReceived): Deleted (should have been removed as part of
​https://bugs.webkit.org/show_bug.cgi?id=111008).

  • loader/CrossOriginPreflightChecker.h:
11:10 AM Changeset in webkit [202335] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify CSS rule for ContentBrowser navigation bar items
​https://bugs.webkit.org/show_bug.cgi?id=159000

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ContentBrowser.css:

(.content-browser > .navigation-bar > .item):
Both these values result in 28px, but 100% is simplier.

10:50 AM Changeset in webkit [202334] by Chris Dumez
  • 5 edits in trunk

JSDOMIterator forEach should support second optional parameter
​https://bugs.webkit.org/show_bug.cgi?id=159020

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-22
Reviewed by Chris Dumez.

Source/WebCore:

Covered by beefed up test.

  • bindings/js/JSDOMIterator.h:

(WebCore::iteratorForEach): Setting callback thisValue to the second argument passed to forEach.

LayoutTests:

  • fast/dom/nodeListIterator-expected.txt:
  • fast/dom/nodeListIterator.html: Adding 'thisValue' various checks.
10:16 AM Changeset in webkit [202333] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Media controls stop working after exiting PiP
​https://bugs.webkit.org/show_bug.cgi?id=159026
<rdar://problem/26753579>

Reviewed by Eric Carlson.

Do not slave setting WebVideoFullscreenModelVideoElement::setVideoElement() to
WebPlaybackSessionModelVideoElement::setMediaElement(). After all, someone else
(i.e., the media controls) may still be using it.

  • platform/cocoa/WebVideoFullscreenModelVideoElement.mm:

(WebVideoFullscreenModelVideoElement::setVideoElement): Deleted.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(WebVideoFullscreenControllerContext::didCleanupFullscreen):
(WebVideoFullscreenControllerContext::setUpFullscreen):

10:14 AM Changeset in webkit [202332] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Update document's isPlayingMedia() state whenever media element's media state changes
​https://bugs.webkit.org/show_bug.cgi?id=159018
<rdar://problem/26586630>

Reviewed by Beth Dakin.

The Document can end up with a stale m_mediaState if its own value isn't updated when
its constituent HTMLMediaElement's m_mediaStates change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateMediaState):

10:00 AM Changeset in webkit [202331] by Chris Dumez
  • 6 edits in trunk/Source/WebKit2

Add logging related to process assertions to help debug process suspension issues
​https://bugs.webkit.org/show_bug.cgi?id=159001

Reviewed by Antti Koivisto.

Add logging related to process assertions to help debug process suspension issues.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityToken):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setIsHoldingLockedFiles):

9:58 AM Changeset in webkit [202330] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Crash under GraphicsLayerCA::recursiveCommitChanges() with deep layer trees
​https://bugs.webkit.org/show_bug.cgi?id=159023
rdar://problem/25377842

Reviewed by Tim Horton.

Having an on-stack DisplayList::Recorder increased the stack frame size significantly,
causing stack exhaustion with deep layer trees, despite the existing depth check.

Make the Recorder heap-allocated to fix this.

Tested by LayoutTests/compositinglayer-creation/deep-tree.html.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

9:55 AM Changeset in webkit [202329] by weinig@apple.com
  • 4 edits
    1 add in trunk

WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110>
​https://bugs.webkit.org/show_bug.cgi?id=158997

Reviewed by Dan Bernstein.

Source/WebKit2:

API Test:

WKWebView.DefaultNavigationDelegate

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
When initializing the WKWebView, set a default navigation client.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.

Add a new test that shows that we have a default navigation delegate by swizzling
-[NSWorkspace openURL:]. This will only be called if there is a default client.

1:59 AM Changeset in webkit [202328] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GTK] Add support for variadic parameters to GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=158942

Reviewed by Michael Catanzaro.

Generate code for functions having variadic parameters.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):
(SkipFunction):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_variadic_string_method):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
1:47 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
1:35 AM Changeset in webkit [202327] by pvollan@apple.com
  • 3 edits in trunk/Tools

[Win] Implement modal dialog support in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=158976

Reviewed by Brent Fulgham.

  • MiniBrowser/win/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::createWebViewWithRequest):
(getHandleFromWebView):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(findTopLevelParent):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::createModalDialog):

  • MiniBrowser/win/PrintWebUIDelegate.h:

(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::runModal):

12:48 AM Changeset in webkit [202326] by pvollan@apple.com
  • 5 edits in trunk

window.showModalDialog doesn't work in DumpRenderTree on Windows
​https://bugs.webkit.org/show_bug.cgi?id=53675

Reviewed by Brent Fulgham.

Tools:

Implement modal dialog support in DumpRenderTree.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::canRunModal):
(getHandleFromWebView):
(UIDelegate::createModalDialog):
(findTopLevelParent):
(UIDelegate::runModal):
(UIDelegate::webViewClose):

  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Update test expectations for modal dialog tests.

  • platform/win/TestExpectations:

Jun 21, 2016:

10:52 PM Changeset in webkit [202325] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/26422051.

  • platform/mac-wk1/TestExpectations:
10:52 PM Changeset in webkit [202324] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

:hover CSS pseudo-class sometimes keeps matching ever after mouse has left the element
​https://bugs.webkit.org/show_bug.cgi?id=158340

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-21
Reviewed by Simon Fraser.

Source/WebCore:

When removing a hovered subtree from the document, we were getting
into an inconsistent state where m_hoveredElement is in the detached
subtree and we have no way of clearing the existing IsHovered flags.

What happens is:
-The root "a" has an child "b" that is hovered.
-"a" starts being removed from the tree, its renderer is destroyed.
-RenderTreeUpdater::tearDownRenderers() pushes "a" on the teardownStack

and calls hoveredElementDidDetach().

-hoveredElementDidDetach() is called with "a". "a" is not the hovered

element, the function does nothing.

-RenderTreeUpdater::tearDownRenderers() pushes "b" on the teardownStack

and calls hoveredElementDidDetach().

-hoveredElementDidDetach() is called with "b". The next parent with a renderer

is "a", m_hoveredElement is set to "a".

-"a"'s parent is set to nullptr.

-> We have a m_hoveredElement on the root of a detached tree, making

it impossible to clear the real dirty tree.

This patch changes the order in which we clear the flags.
It is done in the order in which we clear the renderers to ensure
the last element with a dead renderer is the last to update m_hoveredElement.

Tests: fast/css/ancestor-of-hovered-element-detached.html

fast/css/ancestor-of-hovered-element-removed.html

  • Source/WebCore/style/RenderTreeUpdater.cpp:

LayoutTests:

  • fast/css/ancestor-of-hovered-element-detached-expected.txt: Added.
  • fast/css/ancestor-of-hovered-element-detached.html: Added.
  • fast/css/ancestor-of-hovered-element-removed-expected.txt: Added.
  • fast/css/ancestor-of-hovered-element-removed.html: Added.
10:47 PM Changeset in webkit [202323] by commit-queue@webkit.org
  • 13 edits in trunk

[Fetch API] Rename 'origin-only' referrer policy to 'origin'
​https://bugs.webkit.org/show_bug.cgi?id=158982

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Renaming origin-only to origin.

  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
  • web-platform-tests/fetch/api/request/request-clone.sub.html:
  • web-platform-tests/fetch/api/request/request-idl.html:
  • web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
  • web-platform-tests/fetch/api/request/request-init-001.sub.html:
  • web-platform-tests/fetch/api/request/request-init-003.sub.html:

Source/WebCore:

Covered by updated tests.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Renaming origin-only to origin.

  • Modules/fetch/FetchRequest.idl: Ditto.
  • loader/FetchOptions.h: Ditto.
10:42 PM Changeset in webkit [202322] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectations gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
10:00 PM Changeset in webkit [202321] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Let the compiler generate the move constructor and assignment operator for ScriptExecutionContext::Task
​https://bugs.webkit.org/show_bug.cgi?id=159013

Reviewed by Brady Eidson.

Let the compiler generate the move constructor and assignment operator for
ScriptExecutionContext::Task. We previously manually defined the move
constructor but there is no need as it doesn't do anything special.

  • dom/ScriptExecutionContext.h:
8:53 PM Changeset in webkit [202320] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

DumpRenderTree crashed in com.apple.WebCore: WebCore::HTMLSelectElement::updateSelectedState
​https://bugs.webkit.org/show_bug.cgi?id=159009
<rdar://problem/23454623>

Reviewed by Jon Lee.

It seems we can get bogus indices from UIKit's implementation
of UIWebSelectMultiplePicker. Guard against this situation.

Covered by running the existing tests in WebKit1 with Guard Malloc,
such as fast/spatial-navigation/snav-multiple-select-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::updateSelectedState): Early return
if we get an index out of range.

8:34 PM Changeset in webkit [202319] by aakash_jain@apple.com
  • 57 edits in trunk/Tools

Fix formatting issues reported by check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=159008

Reviewed by Alexey Proskuryakov.

Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
There is no functionality change.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Restart.execute):
(Rollout):

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_exception_during_command):
(IRCBotTest.test_exception_during_command.CommandWithException):
(IRCBotTest.test_exception_during_command.CommandWithException.execute):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(test_missing_unit_test_results_path):
(test_layout_test_results):

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand):
(AbstractSequencedCommand.init):

  • Scripts/webkitpy/tool/commands/download.py:

(Land):

  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/openbugs_unittest.py:

(OpenBugsTest):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToCommitQueue._needs_commit_queue):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_platform):
(PrintBaselinesTest):
(PrintBaselinesTest.setUp):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue):
(AbstractQueue.init):
(AbstractQueue.execute):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(test_auto_retry):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._rebaseline):

  • Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone):

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload.py:

(PostCommits._comment_text_for_commit):
(PostCommits):
(PostCommits.execute):
(MarkBugFixed):
(MarkBugFixed.init):

  • Scripts/webkitpy/tool/commands/upload_unittest.py:

(UploadCommandsTest):
(UploadCommandsTest.test_commit_message_for_current_diff):

  • Scripts/webkitpy/tool/grammar_unittest.py:

(GrammarTest):
(GrammarTest.test_join_with_separators):

  • Scripts/webkitpy/tool/multicommandtool.py:

(HelpCommand.init):
(HelpCommand):
(HelpCommand._help_epilog):
(HelpCommand._remove_help_options):
(MultiCommandTool):
(MultiCommandTool.init):
(MultiCommandTool.main):

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(TrivialCommand):
(TrivialCommand.init):
(MultiCommandToolTest):
(MultiCommandToolTest._assert_tool_main_outputs):
(MultiCommandToolTest.test_retry):
(test_command_help):

  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:

(ApplyPatchWithLocalCommit):
(ApplyPatchWithLocalCommit.options):

  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle):
(CheckStyle.options):

  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest):
(CloseBugForLandDiffTest.test_empty_state):

  • Scripts/webkitpy/tool/steps/closepatch.py:
  • Scripts/webkitpy/tool/steps/commit.py:

(Commit.run):

  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/metastep.py:

(MetaStep):
(MetaStep.init):
(MetaStep.run):

  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/options.py:

(Options):

  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest):
(PrepareChangeLogTest.test_resolve_existing_entry):

  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/promptforbugortitle.py:
  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
  • Scripts/webkitpy/tool/steps/revertrevision.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest):
(StepsTest._step_options):

  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:

(UpdateChangeLogsWithReviewerTest):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):

  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
8:26 PM Changeset in webkit [202318] by jonlee@apple.com
  • 3 edits in trunk/PerformanceTests

Update canvas size when benchmark begins
​https://bugs.webkit.org/show_bug.cgi?id=159010

Reviewed by Dean Jackson.

Previously we would evaluate the media queries and assign the canvas size to the test
on body.onload. Instead, do it once the user starts the benchmark.

  • Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()

to benchmarkController._startBenchmark.

  • Animometer/resources/runner/animometer.js: Ditto.
8:26 PM Changeset in webkit [202317] by jonlee@apple.com
  • 3 edits in trunk/PerformanceTests

Add new timestamp option
​https://bugs.webkit.org/show_bug.cgi?id=159006

Reviewed by Dean Jackson.

Add a new option to take timestamps from the rAF callback.

  • Animometer/developer.html: Added option.
  • Animometer/tests/resources/main.js:

(Benchmark): Fall back to using the rAF timestamp if performance.now()
is not available.
(Benchmark._animateLoop): Update how timestamp is set. Prefer to use
local var instead of accessing private var.

8:16 PM Changeset in webkit [202316] by Chris Dumez
  • 5 edits
    1 delete in trunk

Unreviewed, rolling out r202296.

Broke basic browsing in Safari

Reverted changeset:

"WKWebView with no WKNavigationDelegate does not follow
universal links"
​https://bugs.webkit.org/show_bug.cgi?id=158997
​http://trac.webkit.org/changeset/202296

8:12 PM Changeset in webkit [202315] by jonlee@apple.com
  • 5 edits in trunk/PerformanceTests

Improvements to Animometer benchmark
​https://bugs.webkit.org/show_bug.cgi?id=157738

Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.

Update tests.

  • Animometer/tests/master/text.html: Ensure only three text sizes for

the three canvases.

  • Animometer/tests/master/focus.html: Reduce the text size to fit with smaller

particle sizes.

  • Animometer/tests/master/resources/focus.js: Remove the quadratic distribution for

particle sizes, and make it linear. Reduce the size variance. Shuffle the math to
reduce some calculations per frame. Fix the placement of the particles which might
otherwise be culled.

  • Animometer/tests/master/resources/image-data.js: Reduce the particle size

to encourage larger scores.

8:11 PM Changeset in webkit [202314] by jonlee@apple.com
  • 16 edits in trunk/PerformanceTests

Improvements to Animometer benchmark
​https://bugs.webkit.org/show_bug.cgi?id=157738

Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.

Include confidence interval for the final score, and store the canvas
size in the serialization so that it is accurately shown in results.

  • Animometer/developer.html: Add a "confidence" div.
  • Animometer/index.html: Ditto. Convert "mean" to "confidence".
  • Animometer/resources/debug-runner/animometer.js: Look at options, and

if the configuration is included, update the body class based on it
(similar to what we do when we first load the page). That way, if you
drag-and-drop previous results in, that configuration is reflected in
the dashboard. Show the full confidence interval.

  • Animometer/resources/debug-runner/animometer.css:
  • Animometer/resources/debug-runner/animometer.js: Style update.
  • Animometer/resources/runner/animometer.css:
  • Animometer/resources/runner/animometer.js:

(_processData): Propagate the confidence interval values out and calculate
the lower and upper bounds. For now, shortcut the aggregate calculation,
since we only go through one iteration.
(this._processData.calculateScore): Propagate the confidence interval out
to be next to the score. Depending on the controller these values are
calculated differently.
(this._processData._getResultsProperty): Convenience function.
(this._processData.get score): Refactor.
(this._processData.get scoreLowerBound): Get the aggregate lower bound.
(this._processData.get scoreUpperBound): Get the aggregate upper bound.
(window.sectionsManager.setSectionScore):
(window.benchmarkController._startBenchmark): When the benchmark starts, note
the canvas size and add it to options. That way it will be automatically be
serialized.
(window.benchmarkController.showResults): Include the maximum deviation
percentage.

  • Animometer/resources/runner/lines.svg: Make the background line up with the

skew.

  • Animometer/resources/runner/tests.js:

(Headers.details.text): Refactor.

  • Animometer/resources/statistics.js:

(Statistics.largestDeviationPercentage): Convenience function to calculate
the deviation percentage on either end and return the largest deviation.

  • Animometer/resources/strings.js:

Allow specifying a regression profile to use instead of taking the one
with the lowest error.

Address an issue in the focus test when the regression calculated ends
up overestimating the change point, causing a cascade of tougher
ramps. The reason behind this is that at max complexity of an initial
ramp, the frame length is very high, and it influences the second
segment of the piecewise regression strongly, causing it to be very
steep. As a result, the first segment, expected to be flat, ends up
covering a higher range of complexity. That makes the change point
much higher than it should be. To avoid this, we will add a sanity
check on the maximum value of the ramp. If the regression's projected
value at the maximum complexity of the current ramp is very slow (less
than 20 fps), 1) reduce the maximum complexity by 20%, and 2) do not
include the regression's change point in the change point estimator.
That estimator is used as the midpoint of the next ramp, and including
the change point from a poor regression can bake in the error. The
controller already knows how to adjust for ramps that are too easy for
the system.

  • Animometer/resources/runner/animometer.js:

(this._processData.findRegression): Takes a preferred profile and gives that to
Regression.
(this._processData.calculateScore): With the ramp controller, take the profile
of the ramp that was used the most when calculating the ramp's regression. That
profile is what is used for the test's score.

  • Animometer/resources/statistics.js:

(Regression.Utilities.createClass): Update to take an options object which can
specify a profile to calculate with. Otherwise it will continue to use both and
select the one with the lower error.
(_calculateRegression): Fix an issue where we claim 0 error if the regression
calculation fails due to divide-by-zero. Instead reject that regression calculation
by giving it Number.MAX_VALUE.

  • Animometer/resources/strings.js: New strings for marking a regression as flat

or slope.

  • Animometer/tests/resources/main.js:

(RampController): Rename the thresholds for clarity. Add a threshold that, if
exceeded, will lower the maximum complexity of the next ramp.
(tune): Relax the cdf check to consider whether the interval definitely falls in
the desired frame length threshold.
(processSamples): Include the profile in the ramp.

Update ramp controller test. Increase the length of the test to 30 seconds, and extend
the interval to 120 ms during sampling. Improve the estimation of the ramp parameters.

  • Animometer/developer.html: Change default to 30 seconds, and don't show the progress bar

by default.

  • Animometer/resources/runner/animometer.js: Change default to 30 seconds.
  • Animometer/tests/resources/main.js: A number of improvements to the ramp controller, in

the order in which they appear in the patch:

  • With a longer test length use longer ramps with longer intervals to get more data at each

complexity. Keep the 100 ms interval length during the ramp up phase since we don't need to
spend more time there to find the right order of magnitude, but increase it during the
ramps to 120 ms.

  • The ramp linearly interpolates the complexity to render based on its timestamp, but it would

never sample the minimum complexity. Instead of lerping max to min complexity from time
0 to t where t is the ramp length, instead lerp from 0 to (t - intervalSampleLength) so that
we can have at least one interval sample at the min complexity for that ramp.

  • Some regression calculations only come out with one line segment rather than the two

we expect. This could be due to a noisy ramp or the ramp's range is too narrow. If that's the
case, influence the minimum complexity of the next ramp towards the lowest bound of 1, so that
we ensure that at least part of the ramp is covering a complexity range that the system can
handle at full 60.

  • Remove an assignment to interpolatedFrameLength since that is never subsequently used.

Update the format used to serialize the results for analysis.

Each data point used to have named properties for fields like complexity and frame rate.
In addition the serialized numbers had rounding errors that took up many characters.
Update the format by introducing a new data container called SampleData, which contains a
field map. The map maps a string to an array index. Each data point is an array, so, to
get a stat, use the field map to get the array index into the data point. This allows future
versions to track other data, and reduces the size of the output string by two-thirds.

  • Animometer/resources/extensions.js:

(Utilities.toFixedNumber): Add convenience function that truncates the number to a fixed
precision, and converts it back to a number.
(SampleData): New class that contains sample data and a field map that maps properties to
an array index.
(get length): Number of data points.
(addField): Add a field to the field map.
(push): Add a data point.
(sort): Sort the data.
(slice): Return new SampleData object with sliced data.
(forEach): Iterate over the data with provided function.
(createDatum):
(getFieldInDatum): Returns the data point associated with the field name by looking it up
in the field map in the datum provided, which can be the datum object itself (an array) or
an index into the data member variable.
(setFieldInDatum): Sets the data point associated with the field name.
(at): Returns the data point at the provided index.
(toArray): Serializes the data where the field map serves as property names for each point.

  • Animometer/resources/debug-runner/graph.js:

(updateGraphData): Remove unused _testData. Convert the data to the old array format for the
graph to use, since the old format was much easier to work with when displaying the graphs.
(onGraphTypeChanged): For some controllers, no alternative score or mean is provided.

  • Animometer/resources/runner/animometer.css:
  • Animometer/resources/runner/animometer.js: Refactor to use SampleData. Update JSON output

to only go to 3 digits of precision for purposes of reducing the data size.

  • Animometer/resources/strings.js: Add new strings to put into the field maps.
  • Animometer/tests/resources/main.js: Refactor to use SampleData.
  • Animometer/developer.html:
  • Animometer/index.html: Restructure results table for both pages. Add charset attribute to

tests.js include.

  • Animometer/resources/debug-runner/animometer.css: Clear out styles from release runner.
  • Animometer/resources/debug-runner/graph.js:

(onGraphTypeChanged): Update score and mean if bootstrap results are available from the
controller, since not all controllers do bootstrapping.

  • Animometer/resources/debug-runner/tests.js: Update header text.
  • Animometer/resources/runner/animometer.css: Include confidence interval in results.
  • Animometer/resources/runner/animometer.js:

(ResultsTable._addHeader): Header contents can be HTML, so use innerHTML instead.
(ResultsTable._addBody): Add tbody element.
(ResultsTable._addTest): Allow a data cell to invoke a JS function to get its contents.
(window.benchmarkController.showResults): Add table that includes tests' confidence intervals.

  • Animometer/resources/runner/tests.js:

(Headers.details.text): Add new details table that includes bootstrap confidence interval.
The interval can be asymmetric, but for simplicity, report the maximum deviation percentage
on either side of the bootstrap median.

  • Animometer/resources/statistics.js:

(bootstrap): Include the confidence percentage in the return object.

Report canvas size in results.

  • Animometer/developer.html: Add markup to indicate whether a small, medium, or large

canvas was used.

  • Animometer/index.html: Ditto.
  • Animometer/resources/debug-runner/animometer.js: Call determineCanvasSize().
  • Animometer/resources/runner/animometer.css: Update styles to set the canvas based on the

body class size.

  • Animometer/resources/runner/animometer.js:

(window.benchmarkController.initialize): Update styles to set the canvas based on the
body class size.
(window.benchmarkController.determineCanvasSize): Run various media queries and set the body
class based on the size of the device.

  • Animometer/developer.html: Refactor to include the main CSS file, and redo

the layout so that it doesn't rely on flexbox.

  • Animometer/resources/debug-runner/animometer.css:
  • Animometer/resources/debug-runner/animometer.js:

(updateDisplay): Since various parts of the script alter the body class, we can't
replace the className directly. Instead, remove all display-based values and then add
the one that was selected.

  • Animometer/resources/debug-runner/graph.js:

(updateGraphData): To set the size of the graph, use window.innerHeight.

  • Animometer/resources/runner/animometer.js:

(window.sectionsManager.showSection): Since various parts of the script alter the body
class, we can't replace the className directly. Remove all of the section classes
individually and then add the one desired.

  • Animometer/tests/resources/stage.css: Remove -apple-system as a font to use in the

stage.

8:06 PM Changeset in webkit [202313] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Pass ScriptExecutionContext::Task as rvalue reference
​https://bugs.webkit.org/show_bug.cgi?id=159007

Reviewed by Anders Carlsson.

Pass ScriptExecutionContext::Task as rvalue reference since its non-copyable
and has to be moved in.

  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerRunLoop.h:
7:52 PM Changeset in webkit [202312] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Include IdentifierInlines.h.

  • bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:
7:02 PM Changeset in webkit [202311] by andersca@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

Add PaymentHeaders.h file.

  • Modules/applepay/PaymentHeaders.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
6:36 PM Changeset in webkit [202310] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make a bunch of Apple Pay headers private instead of project.

  • WebCore.xcodeproj/project.pbxproj:
6:05 PM Changeset in webkit [202309] by andersca@apple.com
  • 6 edits
    1 copy
    31 adds in trunk/Source/WebCore

Move the last Apple Pay WebCore files to the open source repository
​https://bugs.webkit.org/show_bug.cgi?id=159005

Reviewed by Tim Horton.

  • DerivedSources.make:
  • Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp: Added.
  • Modules/applepay/ApplePayPaymentAuthorizedEvent.h: Added.
  • Modules/applepay/ApplePayPaymentAuthorizedEvent.idl: Added.
  • Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp: Added.
  • Modules/applepay/ApplePayPaymentMethodSelectedEvent.h: Added.
  • Modules/applepay/ApplePayPaymentMethodSelectedEvent.idl: Added.
  • Modules/applepay/ApplePaySession.cpp: Added.
  • Modules/applepay/ApplePaySession.h: Added.
  • Modules/applepay/ApplePaySession.idl: Added.
  • Modules/applepay/ApplePayShippingContactSelectedEvent.cpp: Added.
  • Modules/applepay/ApplePayShippingContactSelectedEvent.h: Added.
  • Modules/applepay/ApplePayShippingContactSelectedEvent.idl: Added.
  • Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp: Added.
  • Modules/applepay/ApplePayShippingMethodSelectedEvent.h: Added.
  • Modules/applepay/ApplePayShippingMethodSelectedEvent.idl: Added.
  • Modules/applepay/ApplePayValidateMerchantEvent.cpp: Added.
  • Modules/applepay/ApplePayValidateMerchantEvent.h: Added.
  • Modules/applepay/ApplePayValidateMerchantEvent.idl: Added.
  • Modules/applepay/Payment.h: Added.
  • Modules/applepay/PaymentAuthorizationStatus.h: Added.
  • Modules/applepay/PaymentContact.h: Added.
  • Modules/applepay/PaymentMerchantSession.h: Added.
  • Modules/applepay/PaymentMethod.h: Added.
  • Modules/applepay/PaymentRequestValidator.cpp: Added.
  • Modules/applepay/PaymentRequestValidator.h: Added.
  • Modules/applepay/cocoa/PaymentContactCocoa.mm: Added.
  • Modules/applepay/cocoa/PaymentMethodCocoa.mm: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp: Added.
  • bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp: Added.
  • bindings/js/JSApplePaySessionCustom.cpp: Added.
  • bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp: Added.
  • bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp: Added.
  • dom/EventNames.in:
  • dom/EventTargetFactory.in:
5:08 PM Changeset in webkit [202308] by andersca@apple.com
  • 10 edits in trunk

Fix build.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5:04 PM Changeset in webkit [202307] by jiewen_tan@apple.com
  • 17 edits
    2 adds in trunk

Unreviewed, rolling out r202302, r202303, r202305, and
r202306.

Roll out the rollouts because of breaking the build.

Reverted changesets:

"Unreviewed, rolling out r200678."
​https://bugs.webkit.org/show_bug.cgi?id=157453
​http://trac.webkit.org/changeset/202302

"Unreviewed, rolling out r200619."
​https://bugs.webkit.org/show_bug.cgi?id=131443
​http://trac.webkit.org/changeset/202303

"Unreviewed, attempt to fix the build after r202303."
​http://trac.webkit.org/changeset/202305

"Unreviewed, attempt to fix the build after r202303."
​http://trac.webkit.org/changeset/202306

4:52 PM Changeset in webkit [202306] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix the build after r202303.

  • bindings/js/JSDOMIterator.h:

(WebCore::IteratorInspector::decltype):
(WebCore::IteratorInspector::test):

4:47 PM Changeset in webkit [202305] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix the build after r202303.

  • bindings/js/JSDOMIterator.h:

(WebCore::toJS):

4:32 PM Changeset in webkit [202304] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

LayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=158320

Reviewed by Simon Fraser.

This test case is flaky because:

  1. There are multiple mouseScrollByWithWheelAndMomentumPhases() event bundles and they all need their own

callbacks. (see additional eventSender.callAfterScrollingCompletes()) -> fail

  1. When the test fails, the testFailed() function is called with undefined variables. -> timeout
  • platform/mac-wk2/TestExpectations:
  • tiled-drawing/scrolling/latched-div-with-scroll-snap.html:
4:24 PM Changeset in webkit [202303] by jiewen_tan@apple.com
  • 17 edits
    2 deletes in trunk

Unreviewed, rolling out r200619.

This incompleted feature broke ​http://m.yahoo.co.jp. Roll it
out together with r200678.

Reverted changeset:

"NodeList should be iterable"
​https://bugs.webkit.org/show_bug.cgi?id=131443
​http://trac.webkit.org/changeset/200619

4:21 PM Changeset in webkit [202302] by jiewen_tan@apple.com
  • 5 edits in trunk

Unreviewed, rolling out r200678.

This incompleted feature broke ​http://m.yahoo.co.jp. Roll it
out together with r200619.

Reverted changeset:

"Ensure DOM iterators remain done"
​https://bugs.webkit.org/show_bug.cgi?id=157453
​http://trac.webkit.org/changeset/200678

4:09 PM Changeset in webkit [202301] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Skip HeapSnapshot test on WebKit1. Shared VM skews the data.

Unreviewed gardening.

In this case, snapshots with snapshots with snapshots in the same VM
causes the test to run out of memory. This does not happen in WebKit2.

  • platform/mac-wk1/TestExpectations:
4:07 PM Changeset in webkit [202300] by mmaxfield@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Test gardening for platform-specific font-fallback on macOS Sierra
​https://bugs.webkit.org/show_bug.cgi?id=159003
<rdar://problem/25807529>

Unreviewed.

  • fast/text/font-cursive-italic-cjk-2-expected.html: Added.
  • fast/text/font-cursive-italic-cjk-2.html: Added.
  • platform/mac/TestExpectations:
4:06 PM Changeset in webkit [202299] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Options::useImmortalObjects is not safe for conservative GC
​https://bugs.webkit.org/show_bug.cgi?id=158999

Reviewed by Geoffrey Garen.

useImmortalObjects set the mark bit to keep an object from being
reallocated. This had the negative side-effect of convincing the
conservative marker that the object was a valid and live cell, which
would cause us to visit garbage.

  • heap/Heap.cpp:

(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):
(JSC::Heap::setFullActivityCallback):
(JSC::Heap::markDeadObjects): Deleted.

  • heap/Heap.h: Don't set the mark bit on a dead object. That's a bug in

a conservative GC.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::retire): New helper.

(JSC::MarkedAllocator::reset): Automatically retire old blocks when
we're doing the immortal objects thing. This has the effect of
preserving memory for debugging because we never recycle a previously
allocated block.

3:46 PM Changeset in webkit [202298] by andersca@apple.com
  • 13 edits
    8 adds in trunk

Begin moving the Apple Pay code to the open source repository
​https://bugs.webkit.org/show_bug.cgi?id=158998

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_APPLE_PAY.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_APPLE_PAY.

  • Modules/applepay/PaymentCoordinator.cpp: Added.
  • Modules/applepay/PaymentCoordinator.h: Added.
  • Modules/applepay/PaymentCoordinatorClient.h: Added.
  • Modules/applepay/PaymentRequest.cpp: Added.
  • Modules/applepay/PaymentRequest.h: Added.
  • Modules/applepay/cocoa/PaymentCocoa.mm: Added.
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • dom/EventNames.h:

Add new event names.

  • page/MainFrame.h:

Use a forward declaration.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_APPLE_PAY.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_APPLE_PAY.

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Add ENABLE_APPLE_PAY.

3:29 PM Changeset in webkit [202297] by commit-queue@webkit.org
  • 12 edits in trunk

Add system tracing points for requestAnimationFrame() workflow
​https://bugs.webkit.org/show_bug.cgi?id=158723

Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-21
Reviewed by Simon Fraser.

Source/WebCore:

Add trace points for requestAnimationFrame().

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::requestAnimationFrameEnabled):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):

  • dom/ScriptedAnimationController.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):

Source/WebKit2:

Add trace points for requestAnimationFrame().

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::buildTransaction):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):

Source/WTF:

Define new trace score codes for requestAnimationFrame().

  • wtf/SystemTracing.h:

(WTF::TracePoint):
(WTF::TraceScope::TraceScope):
(WTF::TraceScope::~TraceScope):

Tools:

Add new plist entries to be used by kdebug_trace() viewing tools.

  • Tracing/SystemTracePoints.plist:
3:26 PM Changeset in webkit [202296] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110>
​https://bugs.webkit.org/show_bug.cgi?id=158997

Patch by Sam Weinig <​sam@webkit.org> on 2016-06-21
Reviewed by Dan Bernstein.

Source/WebKit2:

API Test:

WKWebView.DefaultNavigationDelegate

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
When initializing the WKWebView, set a default navigation client.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setLoaderClient):
Be sure to clear out a navigation client, if present, when setting a loader client,
as they are mutually exclusive.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.

Add a new test that shows that we have a default navigation delegate by swizzling
-[NSWorkspace openURL:]. This will only be called if there is a default client.

3:19 PM Changeset in webkit [202295] by Simon Fraser
  • 3 edits
    2 adds in trunk

[iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry)
​https://bugs.webkit.org/show_bug.cgi?id=158970

Reviewed by Ryosuke Niwa.

Source/WebCore:

insertTextWithoutSendingTextEvent() should only reveal the selection up to the main frame on iOS,
since the UI process can zoom and scroll the view to the text input.

Test: fast/forms/ios/typing-in-input-in-iframe.html

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):

LayoutTests:

Test that focuses an input in a frame and then types a character, then checks for scrolling.

  • fast/forms/ios/typing-in-input-in-iframe-expected.txt: Added.
  • fast/forms/ios/typing-in-input-in-iframe.html: Added.
2:11 PM Changeset in webkit [202294] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r201177): Web Inspector: ContentBrowser navigation bar should fit on a single line
​https://bugs.webkit.org/show_bug.cgi?id=158700
<rdar://problem/26772058>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ContentBrowser.css:

(.content-browser > .navigation-bar > .item):
Set the height to 28px, as it was before r201177.
Make it one pixel shorter than the navigation bar for better vertical alignment.

1:58 PM Changeset in webkit [202293] by adam.bergkvist@ericsson.com
  • 4 edits in trunk/Source/WebCore

WebRTC: Remove unused MediaEndpointClient::gotRemoteSource function
​https://bugs.webkit.org/show_bug.cgi?id=158986

Reviewed by Eric Carlson.

Remote sources are explicitly created with MediaEndpoint::createMutedRemoteSource so the
MediaEndpointClient::gotRemoteSource can be removed.

No change in behavior.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::gotRemoteSource): Deleted.

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • platform/mediastream/MediaEndpoint.h:
1:57 PM Changeset in webkit [202292] by Simon Fraser
  • 25 edits
    1 copy
    15 adds in trunk

Focus event dispatched in iframe causes parent document to scroll incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=158629
rdar://problem/26521616

Reviewed by Tim Horton.
Source/WebCore:

When focussing elements in iframes, the page could scroll to an incorrect location.
This happened because code in Element::focus() tried to disable scrolling on focus,
but did so only for the current frame, so ancestor frames got programmatically scrolled.
On iOS we handle the scrolling in the UI process, so never want the web process to
do programmatic scrolling.

Fix by changing the focus and cache restore code to use SelectionRevealMode::DoNotReveal,
rather than manually prohibiting frame scrolling. Pass SelectionRevealMode through various callers,
and use RevealUpToMainFrame for iOS, allowing the UI process to do the zoomToRect: for the main frame.

Tests: fast/forms/ios/focus-input-in-iframe.html

fast/forms/ios/programmatic-focus-input-in-iframe.html

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::scrollIntoViewIfNotVisible):
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearance):

  • dom/Element.h:
  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::findStringAndScrollToVisible):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::FrameSelection): Deleted.

  • editing/FrameSelection.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::autoscroll):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::scrollRectToVisible):

  • rendering/RenderObject.h:

Source/WebKit/mac:

Pass SelectionRevealMode::Reveal in existing code.

  • WebView/WebFrame.mm:

(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):
(-[WebFrame revealSelectionAtExtent:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

Source/WebKit2:

Pass SelectionRevealMode::Reveal in existing code.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea):

LayoutTests:

  • fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
  • fast/forms/ios/focus-input-in-iframe.html: Added.
  • fast/forms/ios/programmatic-focus-input-in-iframe-expected.txt: Added.
  • fast/forms/ios/programmatic-focus-input-in-iframe.html: Added.
1:53 PM Changeset in webkit [202291] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[iOS][WK2] When an animation frame is missed, the UI process should immediately notify the Web process once a frame is committed
​https://bugs.webkit.org/show_bug.cgi?id=158933

Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-21
Reviewed by Simon Fraser.

When a frame is committed, the UI process schedules a CADisplayLink and waits until
the next didRefreshDisplay event is fired. This causes more delay in the scenario
where there are frames are dropped. didRefreshDisplay() should be called immediately
when commitLayerTree message is received and the last frame was dropped.

The fix is to have the CADisplayLink active all the times. It should be paused
only when we detect at least one frame is dropped. In this case we should not
send a message to the UI process since it has not sent the last requested LayerTree.
Also we should not waste the CPU time by scheduling a new CADisplayLink since we
have not processed the last event. We should resume CADisplayLink timer once a
commitLayerTree message is received.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[WKOneShotDisplayLinkHandler pause]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(-[WKOneShotDisplayLinkHandler displayLinkFired:]):

1:47 PM Changeset in webkit [202290] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Add an expectation for another copy of fast/canvas/webgl/premultiplyalpha-test.html

  • platform/mac/TestExpectations:
1:18 PM Changeset in webkit [202289] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update Sierra test expectations for fast/canvas/webgl/premultiplyalpha-test.html

  • platform/mac/TestExpectations:
1:14 PM Changeset in webkit [202288] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock::shrinkToFit is racy
​https://bugs.webkit.org/show_bug.cgi?id=158994
<rdar://problem/26920212>

Reviewed by Filip Pizlo.

To see why this is racy, consider the following scenario:

  • CodeBlock A is link()ing its baseline compile.
  • CodeBlock B is inlining A, and asks A for a result profile in DFGBytecodeParser.
  • The race occurs when the link() step of the baseline compile calls shrinkToFit on its m_resultProfiles field without grabbing a lock. This leads to a bad time because the DFG compile will be reading from that vector as it's getting changed by the baseline link() method.

This race has always existed, though the move to a concurrent baseline
JIT has made it more likely to occur. The solution is to have CodeBlock::shrinkToFit
grab its lock before shrinking the vector.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

12:06 PM Changeset in webkit [202287] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Migrate testair & testb3 settings from Xcode project to ToolExecutable.xcconfig
<​https://webkit.org/b/158989>

Reviewed by Andy Estes.

  • Configurations/ToolExecutable.xcconfig:

(CODE_SIGN_ENTITLEMENTS_ios_testair): Add from Xcode project.

(CODE_SIGN_ENTITLEMENTS_ios_testair): Move to
ToolExecutable.xcconfig.
(PRODUCT_NAME): Remove. This variable is already set for both
testair and testb3 since those build configurations use
ToolExecutable.xcconfig as a base.

12:03 PM Changeset in webkit [202286] by sbarati@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

LLInt doesn't throw stack exception overflow from parent frame
​https://bugs.webkit.org/show_bug.cgi?id=158962
<rdar://problem/26902188>

Reviewed by Filip Pizlo.

All JIT tiers will throw stack overflow exceptions from the parent frame.
The LLInt, on the other hand, did not use to. I've changed the LLInt to be
consistent with the JITs. The reason I found this bug is because we had a
test that would give different results depending on if the function was compiled
in the baseline or the LLInt. Since Filip recently landed the concurrent baseline
JIT patch, this otherwise deterministic test became dependent on it being compiled
in the LLInt or one of the JIT tiers. I've added a new test that is deterministic
because it runs the test with --useJIT=false.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • tests/stress/llint-stack-overflow-location.js: Added.

(stackTraceDescription):
(foo):
(catch):

11:54 AM Changeset in webkit [202285] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CODE_SIGN_ENTITLEMENTS should be applied to iOS Simulator builds
<​https://webkit.org/b/158990>
<rdar://problem/26906273>

Reviewed by Dan Bernstein.

  • Configurations/JSC.xcconfig:

(CODE_SIGN_ENTITLEMENTS): Change [sdk=iphoneos*] to
[sdk=iphone*] to apply setting to iOS Simulator as well.

  • Configurations/ToolExecutable.xcconfig:

(CODE_SIGN_ENTITLEMENTS): Ditto.

11:36 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
11:34 AM Changeset in webkit [202284] by fred.wang@free.fr
  • 19 edits in trunk

Implement RenderMathMLOperator::layoutBlock
​https://bugs.webkit.org/show_bug.cgi?id=157521

Patch by Frederic Wang <​fwang@igalia.com> on 2016-06-21
Reviewed by Brent Fulgham.

Source/WebCore:

No new tests, already covered by existing tests.

Add an initial implementation of RenderMathMLOperator::layoutBlock, which will perform
special layout when the MathOperator is used. We also improved how the logical height is
calculated and avoid updating the style when stretchTo is called.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::layoutBlock):
(WebCore::RenderMathMLOperator::computeLogicalHeight): Deleted.

  • rendering/mathml/RenderMathMLOperator.h:

LayoutTests:

Update some tests to take into account improved width computation and how the anonymous text
node of operators using MathOperator is layout.

  • platform/gtk/mathml/opentype/horizontal-expected.txt:
  • platform/gtk/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/gtk/mathml/opentype/large-operators-expected.txt:
  • platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:
  • platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/gtk/mathml/opentype/vertical-expected.png:
  • platform/gtk/mathml/opentype/vertical-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/opentype/large-operators-expected.txt:
  • platform/mac/mathml/opentype/opentype-stretchy-expected.txt:
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/mac/mathml/opentype/vertical-expected.txt:
  • platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt:
11:26 AM Changeset in webkit [202283] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

run-javascriptcore-tests should have flag to skip mozilla tests
​https://bugs.webkit.org/show_bug.cgi?id=158963
rdar://problem/25838924

Reviewed by Alexey Proskuryakov.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests): Added flag to skip mozilla tests.

11:15 AM Changeset in webkit [202282] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r202277.
​https://bugs.webkit.org/show_bug.cgi?id=158992

imported/w3c/web-platform-tests/tools actually does exist, so
documentation files got executed as tests (Requested by ap on
#webkit).

Reverted changeset:

"Unskip non-existing imported/w3c/web-platform-tests/tools."
​http://trac.webkit.org/changeset/202277

10:57 AM Changeset in webkit [202281] by Chris Dumez
  • 24 edits in trunk/Source/WebCore

Unreviewed, roll out r202268 as it looks like it was a ~50% regression on Dromaeo DOM Core

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GeneratePrototypeDeclaration):

  • bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceNamePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectPrototype::finishCreation):
(WebCore::JSTestActiveDOMObject::createPrototype): Deleted.
(WebCore::JSTestActiveDOMObject::prototype): Deleted.

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterPrototype::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter): Deleted.
(WebCore::JSTestCustomNamedGetter::createPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorPrototype::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype): Deleted.
(WebCore::JSTestEventConstructor::prototype): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetPrototype::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget): Deleted.
(WebCore::JSTestEventTarget::createPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfacePrototype::finishCreation):
(WebCore::jsTestInterfaceImplementsStr2): Deleted.

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor): Deleted.
(WebCore::JSTestJSBuiltinConstructor::createPrototype): Deleted.
(WebCore::JSTestJSBuiltinConstructor::destroy): Deleted.
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): Deleted.
(WebCore::JSTestMediaQueryListListener::createPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::JSTestNode::JSTestNode): Deleted.
(WebCore::JSTestNode::prototype): Deleted.
(WebCore::jsTestNodeName): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicPrototype::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic): Deleted.
(WebCore::JSTestNondeterministic::prototype): Deleted.
(WebCore::JSTestNondeterministic::destroy): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::JSTestObj::JSTestObj): Deleted.
(WebCore::JSTestObj::createPrototype): Deleted.
(WebCore::JSTestObj::prototype): Deleted.
(WebCore::JSTestObj::destroy): Deleted.
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.
(WebCore::JSTestObj::getOwnPropertySlotByIndex): Deleted.
(WebCore::jsTestObjReadOnlyLongAttr): Deleted.
(WebCore::jsTestObjReadOnlyStringAttr): Deleted.
(WebCore::jsTestObjReadOnlyTestObjAttr): Deleted.
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr): Deleted.
(WebCore::jsTestObjConstructorStaticStringAttr): Deleted.
(WebCore::jsTestObjConstructorTestSubObj): Deleted.
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor): Deleted.
(WebCore::jsTestObjEnumAttr): Deleted.
(WebCore::jsTestObjByteAttr): Deleted.
(WebCore::jsTestObjOctetAttr): Deleted.
(WebCore::jsTestObjShortAttr): Deleted.
(WebCore::jsTestObjClampedShortAttr): Deleted.
(WebCore::jsTestObjEnforceRangeShortAttr): Deleted.
(WebCore::jsTestObjUnsignedShortAttr): Deleted.
(WebCore::jsTestObjLongAttr): Deleted.
(WebCore::jsTestObjLongLongAttr): Deleted.
(WebCore::jsTestObjReflectedCustomBooleanAttr): Deleted.
(WebCore::jsTestObjReflectedCustomURLAttr): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins): Deleted.
(WebCore::JSTestOverrideBuiltins::createPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): Deleted.
(WebCore::JSTestSerializedScriptValueInterface::prototype): Deleted.
(WebCore::JSTestSerializedScriptValueInterface::destroy): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsPrototype::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs): Deleted.
(WebCore::JSTestTypedefs::createPrototype): Deleted.
(WebCore::JSTestTypedefs::prototype): Deleted.
(WebCore::JSTestTypedefs::destroy): Deleted.
(WebCore::jsTestTypedefsUnsignedLongLongAttr): Deleted.
(WebCore::jsTestTypedefsImmutableSerializedScriptValue): Deleted.
(WebCore::jsTestTypedefsAttrWithGetterException): Deleted.

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributePrototype::finishCreation):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyPrototype::finishCreation):

10:54 AM Changeset in webkit [202280] by keith_miller@apple.com
  • 59 edits
    2 deletes in trunk/Source

It should be easy to add a private global helper function for builtins
​https://bugs.webkit.org/show_bug.cgi?id=158893

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch does two things. First it moves all the builtin names
out of CommonIdentifiers and into BuiltinNames. This means that
adding a new function to the Builtins does not require rebuilding
all of JavaScriptCore. This patch also adds a new decorator to our
builtins @privateGlobal that will automatically put the function
on the global object. The name of the property will be the same as
the private name of the function.

This patch, also, removes the JSArrayIterator.h/.cpp files
as they no longer appear to be used in any real way. Finally,
the builtins tests have been rebaselined. It appears this has
not been done for a while so the expected files contain other
changes.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Scripts/builtins/builtins_generate_combined_header.py:

(BuiltinsCombinedHeaderGenerator.generate_output):
(generate_section_for_code_name_macro):
(generate_section_for_global_private_code_name_macro):

  • Scripts/builtins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
  • builtins/ArrayIteratorPrototype.js:
  • builtins/ArrayPrototype.js:
  • builtins/BuiltinNames.h:
  • builtins/GeneratorPrototype.js:
  • builtins/GlobalObject.js:
  • builtins/PromiseOperations.js:
  • builtins/RegExpPrototype.js:
  • builtins/StringPrototype.js:
  • bytecode/BytecodeIntrinsicRegistry.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC::BytecodeGenerator::emitGetTemplateObject):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitGeneratorStateChange):

  • bytecompiler/NodesCodegen.cpp:

(JSC::emitHomeObjectForCallee):
(JSC::emitPutHomeObject):
(JSC::FunctionNode::emitBytecode):

  • dfg/DFGOperations.cpp:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties): Deleted.

  • parser/Lexer.cpp:

(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::createGeneratorParameters):
(JSC::Parser<LexerType>::parseExportDeclaration):

  • runtime/ArrayIteratorPrototype.cpp:
  • runtime/ArrayIteratorPrototype.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.

  • runtime/CommonIdentifiers.h:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/IntlDateTimeFormat.cpp:
  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

  • runtime/IntlObjectInlines.h:

(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):

  • runtime/JSArrayIterator.cpp: Removed.

(JSC::JSArrayIterator::finishCreation): Deleted.
(JSC::JSArrayIterator::kind): Deleted.
(JSC::JSArrayIterator::iteratedValue): Deleted.

  • runtime/JSArrayIterator.h: Removed.

(JSC::JSArrayIterator::createStructure): Deleted.
(JSC::JSArrayIterator::create): Deleted.
(JSC::JSArrayIterator::JSArrayIterator): Deleted.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSInternalPromise.cpp:
  • runtime/JSInternalPromiseDeferred.cpp:

(JSC::JSInternalPromiseDeferred::create):

  • runtime/JSPromise.cpp:

(JSC::JSPromise::finishCreation):
(JSC::JSPromise::result):

  • runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::create):

  • runtime/JSStringIterator.cpp:

(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::iteratedValue):
(JSC::JSStringIterator::clone):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

  • runtime/ReflectObject.cpp:

(JSC::ReflectObject::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • runtime/TypedArrayInlines.h:

Source/WebCore:

Add JSCJSValueInlines.h to fix build issues.

  • platform/mock/mediasource/MockBox.cpp:
10:20 AM Changeset in webkit [202279] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
​https://bugs.webkit.org/show_bug.cgi?id=158967

Patch by Amir Alavi <​aalavi@apple.com> on 2016-06-21
Reviewed by Brent Fulgham.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/CookieJarMac.mm:

(WebCore::httpCookiesForURL): Upstreamed from WebKitSystemInterface.
(WebCore::cookiesForURL): Changed to call httpCookiesForURL.
(WebCore::deleteCookie): Ditto.

  • platform/spi/cf/CFNetworkSPI.h:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

10:05 AM Changeset in webkit [202278] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r202231.

Seems to have regressed PLT on both iOS and Mac (very obvious
on iOS Warm PLT)

Reverted changeset:

"When navigating, discard decoded image data that is only live
due to page cache."
​https://bugs.webkit.org/show_bug.cgi?id=158941
​http://trac.webkit.org/changeset/202231

9:43 AM Changeset in webkit [202277] by Konstantin Tokarev
  • 2 edits in trunk/LayoutTests

Unskip non-existing imported/w3c/web-platform-tests/tools.

Unreviewed fix after r191043.

9:21 AM Changeset in webkit [202276] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Correct which test is marked as flaky, copy/paste mistake.

  • platform/mac-wk2/TestExpectations:
8:44 AM Changeset in webkit [202275] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

Add bindings generator support to add a native JS function to both a 'name' and a private '@name' slot
​https://bugs.webkit.org/show_bug.cgi?id=158777

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-21
Reviewed by Eric Carlson.

Adding a new PublicIdentifier keyword to cover the case of the same function exposed publicly and privately.
Renaming Private keyword to PrivateIdentifier.
Functions exposed both publicly and privately should set both keywords.
By default, functions are publically exposed.

Updated binding generator to generate public exposure except if PrivateIdentifer is set and PublicIdentifier is
not set.

Keeping skipping of ObjC/GObject binding for PrivateIdentifier-only functions.

Covered by rebased binding tests.

  • Modules/fetch/FetchHeaders.idl:
  • Modules/fetch/FetchResponse.idl:
  • Modules/mediastream/MediaDevices.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

  • bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_private_also_method):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionPrivateMethod):
(WebCore::jsTestObjPrototypeFunctionPrivateAlsoMethod):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj privateAlsoMethod:]):

  • bindings/scripts/test/TestObj.idl:
8:44 AM WebKitGTK/2.12.x edited by Michael Catanzaro
Propose change requested by Konstantin (diff)
6:15 AM Changeset in webkit [202274] by mitz@apple.com
  • 18 edits
    1 add in trunk/Source

Inlined some picture-in-picture code.
​https://bugs.webkit.org/show_bug.cgi?id=158977

Reviewed by Eric Carlsson.

This code was written primarily by Ada Chan, and originally reviewed by Alex Christensen,
Anders Carlsson, Conrad Shultz, Dan Bernstein, Eric Carlson, Jer Noble, Jeremy Jones,
Jon Lee, Remy Demarest, and Zach Li.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.
  • Modules/mediacontrols/mediaControlsApple.css:

(video:-webkit-full-screen::-webkit-media-controls-panel .picture-in-picture-button):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.configureFullScreenControls):

  • WebCore.xcodeproj/project.pbxproj: Added PIPSPI.h.
  • html/HTMLMediaElement.cpp: Inlined code from HTMLMediaElementAdditions.cpp.
  • html/HTMLVideoElement.cpp: Inlined code from HTMLVideoElementSupportsFullscreenAdditions.cpp.
  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagEnterVideoEnhancedFullscreen): Brought in from ContextMenuLocalizedStringsAdditions.cpp.
(WebCore::contextMenuItemTagExitVideoEnhancedFullscreen): Ditto.
(WebCore::AXARIAContentGroupText): Made updates that should have been part of r198543.

  • platform/mac/WebVideoFullscreenInterfaceMac.h: Removed USE(APPLE_INTERNAL_SDK) guards.
  • platform/mac/WebVideoFullscreenInterfaceMac.mm: Inlined WebVideoFullscreenInterfaceMacAdditions.mm.
  • platform/spi/mac/PIPSPI.h: Added.
  • rendering/HitTestResult.cpp: Inlined HitTestResultAdditions.cpp.
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsStyleSheet): Removed include of

RenderThemeMacMediaControlsStyleSheetAdditions.mm now that the content is in
mediaControlsApple.css.

(WebCore::RenderThemeMac::mediaControlsScript): Removed include of

RenderThemeMacMediaControlsScriptAdditions.mm now that the content is in mediaControlsApple.js.

Source/WebKit2:

  • Shared/WebPreferencesStoreDefaultsAdditions.cpp: Define and use DEFAULT_ALLOWS_PICTURE_IN_PICTURE_MEDIA_PLAYBACK.
  • Shared/WebPreferencesStore.cpp:

(WebKit::defaults): Removed include of WebPreferencesStoreDefaultsAdditions.cpp now that the

default is defined correctly in WebPreferencesStoreDefaultsAdditions.cpp.

  • UIProcess/API/C/WKPreferences.cpp: Inlined WKPreferencesAdditions.cpp.
  • UIProcess/API/C/WKPreferencesRefPrivate.h: Ditto.
  • WebProcess/cocoa/WebVideoFullscreenManager.mm: Inlined WebVideoFullscreenManagerSupportsVideoFullscreenMac.mm.
4:04 AM Changeset in webkit [202273] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Web view is not redrawn when reparented in force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=158689

Reviewed by Žan Doberšek.

When the web view is reparented in accelerated compositing mode, the UI process always exits the accelerated
mode when the view is unrealized, because the native surface handle for compositing is destroyed, but it doesn't
enter again when the view is realized and a new native surface handle for compositing is used. This happens
because the UI and Web processes are not in sync regarding whether the page is in accelerated compositing or
not. The Web process never exits accelerated mode when compositing mode is forced, but the UI process doesn't
check that setting at all.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseResizeRedirectedWindow): Helper function to ensure the redirected window size is properly updated.
(webkitWebViewBaseRealize): Resize the redirected window if the view is already in AC mode when realized.
(webkitWebViewRenderAcceleratedCompositingResults): Use webkitWebViewBaseResizeRedirectedWindow().
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseWillEnterAcceleratedCompositingMode): Ditto.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::alwaysUseCompositing): Return true in force compositing mode.
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): Update assert.
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Do not exit AC mode compositing mode is always enabled.

  • UIProcess/DrawingAreaProxyImpl.h:

(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Return true also in force compositing mode.

  • UIProcess/gtk/RedirectedXCompositeWindow.cpp:

(WebKit::RedirectedXCompositeWindow::surface): Ensure we never return an uninitialized surface to prevent
rendering artifacts in in force compositing mode when waiting for the first update on the redirected window.

2:56 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
1:54 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
1:32 AM Changeset in webkit [202272] by commit-queue@webkit.org
  • 9 edits
    6 adds in trunk

[GStreamer] video orientation support
​https://bugs.webkit.org/show_bug.cgi?id=148524

Patch by Miguel Gomez <​magomez@igalia.com> on 2016-06-21
Reviewed by Philippe Normand.

Source/WebCore:

Rotate video frames to follow the orientation metadata in the video file.
When accelerated compositing is disabled, the rotation is performed by a videoflip element added
to the playbin.
When accelerated compositing is enabled, the rotation is peformed by the TextureMapper in response
to a rotation flag set on the frame buffers.

Test: media/video-orientation.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Handle the GST_MESSAGE_TAG message from the bin.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Add the videflip element to the bin when accelerated compositing is disabled.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
Receive and use extra flags for the TextureMapper.
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
When using accelerated compositing, transpose the video size if the rotation is 90 or 270 degrees.
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
Add rotation flag to frame holder and layer buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Use rotation flag when requesting the TextureMapper to draw.
(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceRotation):
Function to store the video rotation.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Add bits to store the video rotation.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
Modify the patternTransform according to the rotation flag passed.

  • platform/graphics/texmap/TextureMapperGL.h:

Add new flags to handle the video souce rotation.

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:

(WebCore::TextureMapperPlatformLayerBuffer::paintToTextureMapper):
Change the drawTexture method used so custom flags can be passed.

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

(WebCore::TextureMapperPlatformLayerBuffer::setExtraFlags):
New method to set TextureMapper flags.

LayoutTests:

Test whether the video is properly being displayed by checking the video
element size.

  • media/content/no-rotation.mp4: Added.
  • media/content/rotation-180.mp4: Added.
  • media/content/rotation-270.mp4: Added.
  • media/content/rotation-90.mp4: Added.
  • media/video-orientation-expected.txt: Added.
  • media/video-orientation.html: Added.
12:11 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)

Jun 20, 2016:

11:28 PM Changeset in webkit [202271] by fred.wang@free.fr
  • 12 edits in trunk

Use the MathOperator to handle some non-stretchy operators
​https://bugs.webkit.org/show_bug.cgi?id=157519

Patch by Frederic Wang <​fwang@igalia.com> on 2016-06-20
Reviewed by Brent Fulgham.

Source/WebCore:

To prepare for the removal of anonymous text node from the render classes of token elements
we use MathOperator to handle two cases where the actual text to display may not be
available in the DOM: mfenced and minus operators. This change removes support for the
case of mfenced operators with multiple characters since that it is not supported by
MathOperator. It is a edge case that is not used in practice since fences and separators are
only made of a single character. However, it would still be possible to duplicate some
code/logic to add it back if that turns out to be necessary.

No new tests, already covered by existing tests.

  • rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::MathOperator): Rename UndefinedOperator.
(WebCore::RenderMathMLOperator::firstLineBaseline): Improve rounding of ascent so that mfenced operators are correctly aligned.

  • rendering/mathml/MathOperator.h: Rename UndefinedOperator, since it can now be used to draw non-stretchy operators.

(WebCore::MathOperator::isStretched): Deleted. This function is no longer used by RenderMathMLOperator.
(WebCore::MathOperator::unstretch): Deleted. This function is no longer used by RenderMathMLOperator.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use useMathOperator.
(WebCore::RenderMathMLOperator::rebuildTokenContent): Set the MathOperator when useMathOperator() is true.
When the operator is not likely to stretch we just leave its type as NormalOperator.
(WebCore::RenderMathMLOperator::useMathOperator): Helper function to determine when MathOperator should be used.
(WebCore::RenderMathMLOperator::firstLineBaseline): Use useMathOperator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Ditto.
(WebCore::RenderMathMLOperator::paint): Ditto.
(WebCore::RenderMathMLOperator::paintChildren): Ditto.

  • rendering/mathml/RenderMathMLOperator.h: Declare useMathOperator.

LayoutTests:

We adjust fenced-mi.html to handle one edge case that we no longer support.
We also update some test references on Mac and iOS.

  • mathml/presentation/fenced-mi-expected.html: Indicate that this is no longer supported.
  • mathml/presentation/fenced-mi.html: Adjust the reference since no text is shown.
  • platform/mac/mathml/opentype/large-operators-expected.txt: Update reference.
  • platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
  • platform/mac/mathml/opentype/vertical-expected.txt: Ditto.
  • platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Ditto.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
11:16 PM Changeset in webkit [202270] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectation update for media/click-placeholder-not-pausing.html

  • platform/mac-wk2/TestExpectations:
11:08 PM Changeset in webkit [202269] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectation update for
​https://bugs.webkit.org/show_bug.cgi?id=158320
REGRESSION (r201476?): LayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky

  • platform/mac-wk2/TestExpectations:
9:56 PM Changeset in webkit [202268] by barraclough@apple.com
  • 24 edits in trunk/Source/WebCore

Don't eagerly reify DOM Prototype properties
​https://bugs.webkit.org/show_bug.cgi?id=158557

Reviewed by Andreas Kling.

We were eagerly reifying these properties to avoid virtualizing getOwnPropertySlot,
but since bug #158059 this does not require a method table call in any case.
Eagerly reifying these values likely has some CPU and memory cost on page load.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • should generate compressed index for hashtable, prototype object ClassInfo should contain static table, don't reifyStaticProperties for prototype objects.

(GeneratePrototypeDeclaration):

  • Set HasStaticPropertyTable for DOM prototype objects.
  • bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceNamePrototype::JSInterfaceNamePrototype):
(WebCore::JSInterfaceNamePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectPrototype::JSTestActiveDOMObjectPrototype):
(WebCore::JSTestActiveDOMObjectPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::JSTestClassWithJSBuiltinConstructorPrototype):
(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::JSTestCustomConstructorWithNoInterfaceObjectPrototype):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetPrototype::JSTestEventTargetPrototype):
(WebCore::JSTestEventTargetPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachablePrototype::JSTestGenerateIsReachablePrototype):
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
(WebCore::JSTestInterfacePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorPrototype::JSTestJSBuiltinConstructorPrototype):
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::JSTestNodePrototype):
(WebCore::JSTestNodePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicPrototype::JSTestNondeterministicPrototype):
(WebCore::JSTestNondeterministicPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::JSTestObjPrototype):
(WebCore::JSTestObjPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsPrototype::JSTestOverrideBuiltinsPrototype):
(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
(WebCore::JSTestTypedefsPrototype::finishCreation):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributePrototype::JSattributePrototype):
(WebCore::JSattributePrototype::finishCreation):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyPrototype::JSreadonlyPrototype):
(WebCore::JSreadonlyPrototype::finishCreation):

9:51 PM Changeset in webkit [202267] by adam.bergkvist@ericsson.com
  • 5 edits in trunk

WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly
​https://bugs.webkit.org/show_bug.cgi?id=158873

Reviewed by Alejandro G. Castro.

Source/WebCore:

Prevent explicit null and undefined values from being converted to "null" and "undefined"
strings.

Test: Extended fast/mediastream/RTCIceCandidate.html

  • Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

LayoutTests:

Updated test to verify that explicit null and undefined values, passed to the
RTCIceCandidate init dictionary, are handled correctly.

  • fast/mediastream/RTCIceCandidate-expected.txt:
  • fast/mediastream/RTCIceCandidate.html:
8:48 PM Changeset in webkit [202266] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: UncaughtExceptionReporter should handle null event.error
​https://bugs.webkit.org/show_bug.cgi?id=158971

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-20
Reviewed by Brian Burg.

  • UserInterface/Debug/UncaughtExceptionReporter.js:

Since typeof null === "object" handle uncaught exceptions where the
Error object itself is null.

8:26 PM Changeset in webkit [202265] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r202252.
​https://bugs.webkit.org/show_bug.cgi?id=158974

See rdar://problem/26867866 for details (Requested by ap on
#webkit).

Reverted changeset:

"Adopt commitPriority to get rid of the 2 AVPL solution for
PiP"
​https://bugs.webkit.org/show_bug.cgi?id=158949
​http://trac.webkit.org/changeset/202252

8:22 PM Changeset in webkit [202264] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

REGRESSION(r202253): Broke inspector/unit-tests/heap-snapshot-collection-event.html
​https://bugs.webkit.org/show_bug.cgi?id=158973

Unreviewed fix after r202253.

  • inspector/unit-tests/heap-snapshot-collection-event-expected.txt:
  • inspector/unit-tests/heap-snapshot-collection-event.html:

Update the method name.

8:07 PM Changeset in webkit [202263] by commit-queue@webkit.org
  • 21 edits
    4 deletes in trunk

Unreviewed, rolling out r202243.
​https://bugs.webkit.org/show_bug.cgi?id=158972

Broke Windows build and iOS tests (Requested by ap on
#webkit).

Reverted changeset:

"Focus event dispatched in iframe causes parent document to
scroll incorrectly"
​https://bugs.webkit.org/show_bug.cgi?id=158629
​http://trac.webkit.org/changeset/202243

8:01 PM Changeset in webkit [202262] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Simplify / Optimize DataDetector's searchForLinkRemovingExistingDDLinks()
​https://bugs.webkit.org/show_bug.cgi?id=158968

Reviewed by Ryosuke Niwa.

Simplify / Optimize DataDetector's searchForLinkRemovingExistingDDLinks():

  • Use modern ancestorsOfType<HTMLAnchorElement>() to traverse anchor ancestors instead of traversing by hand.
  • Use NodeTraversal::next() to traverse the tree until we find endNode and use a for loop instead of a while loop. Previously, the logic the determine the next node was at the end of the loop and was identical behavior-wise to NodeTraversal::next(). However, the previous code for a lot less efficient because it was calling Node::childNodes() to get a NodeList of the children, then calling length() on it to check if we had children and finally use the first item in the list as next node. This was very inefficient because NodeList::length() would need to traverse all children to figure out the length and would cache all the children in a Vector in CollectionIndexCache.
  • dom/ElementAncestorIterator.h:

(WebCore::ancestorsOfType):

  • dom/ElementIterator.h:

(WebCore::findElementAncestorOfType):
(WebCore::findElementAncestorOfType<Element>):
Update ancestorsOfType() to take a Node instead of an Element. There are no
performance benefits to taking an Element here and it is a valid use case to
want an Element ancestor of a non-Element node.

  • editing/cocoa/DataDetection.mm:

(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::dataDetectorTypeForCategory): Deleted.

6:48 PM Changeset in webkit [202261] by Yusuke Suzuki
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Use bytecode intrinsic to expose Module's loading status to builtin JS
​https://bugs.webkit.org/show_bug.cgi?id=158871

Reviewed by Sam Weinig.

Now JSC has bytecode intrinsic system. Use it instead of exposing status values through the loader's properties.

  • builtins/ModuleLoaderObject.js:

(newRegistryEntry):
(fulfillFetch):
(fulfillTranslate):
(commitInstantiated):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestResolveDependencies.):
(requestResolveDependencies):
(requestLink):
(link):
(provide):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • runtime/ModuleLoaderObject.cpp:

(JSC::ModuleLoaderObject::finishCreation): Deleted.

5:49 PM Changeset in webkit [202260] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.37.0.1/Source/WebKit2

Merged r202229. rdar://problem/26903312

5:48 PM Changeset in webkit [202259] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.37.0.1/Source/WebKit2

Merged r202224. rdar://problem/26903312

5:47 PM Changeset in webkit [202258] by bshafiei@apple.com
  • 6 edits in tags/Safari-602.1.37.0.1/Source

Merged r202142. rdar://problem/26903312

5:45 PM Changeset in webkit [202257] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.37.0.1/Source

Versioning.

5:32 PM Changeset in webkit [202256] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.37.0.1

New tag.

5:26 PM Changeset in webkit [202255] by commit-queue@webkit.org
  • 58 edits
    2 copies in trunk/Source

Unreviewed, rolling out r202248.
​https://bugs.webkit.org/show_bug.cgi?id=158960

breaks builds on the simulator (Requested by keith_mi_ on
#webkit).

Reverted changeset:

"It should be easy to add a private global helper function for
builtins"
​https://bugs.webkit.org/show_bug.cgi?id=158893
​http://trac.webkit.org/changeset/202248

5:24 PM Changeset in webkit [202254] by rniwa@webkit.org
  • 12 edits in trunk

Unreviewed, rolling out r202136.
​https://bugs.webkit.org/show_bug.cgi?id=158932

JSBench wasn't regressed by r202002 and r202111 on iOS after
all (Requested by rniwa_ on #webkit).

Reverted changeset:

"Unreviewed, rolling out r202002 and r202111."
​https://bugs.webkit.org/show_bug.cgi?id=158638
​http://trac.webkit.org/changeset/202136

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-06-20

5:01 PM Changeset in webkit [202253] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Snapshot List should show the total size and the total live size
​https://bugs.webkit.org/show_bug.cgi?id=157904
<rdar://problem/26372833>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-20
Reviewed by Brian Burg.

Include the live size of a snapshot in the snapshot list.

  • Localizations/en.lproj/localizedStrings.js:

New "Live Size" string.

  • UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:

(HeapSnapshot):
(HeapSnapshot.updateCategoriesAndMetadata):
(HeapSnapshot.prototype.update):
(HeapSnapshot.prototype.serialize):
(HeapSnapshotDiff):
(HeapSnapshotDiff.prototype.update):
(HeapSnapshot.buildCategories): Deleted.
(HeapSnapshot.prototype.updateCategories): Deleted.
(HeapSnapshotDiff.prototype.updateCategories): Deleted.

  • UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateCategories): Deleted.

  • UserInterface/Proxies/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.deserialize):
(WebInspector.HeapSnapshotProxy.prototype.get liveSize):
(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.updateCategories): Deleted.
Rename "updateCategories" to "update" and update both categories
and metadata, like the liveSize.

  • UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotCollectedNodes):
Update live size after collection.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
Include a live size column in the DataGrid.
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
Cleanup listeners appropriately.

4:26 PM Changeset in webkit [202252] by jeremyj-wk@apple.com
  • 8 edits in trunk/Source/WebCore

Adopt commitPriority to get rid of the 2 AVPL solution for PiP
​https://bugs.webkit.org/show_bug.cgi?id=158949
rdar://problem/26867866

Reviewed by Simon Fraser.

No new tests because there is no behavior change. This reverts changes from
​https://bugs.webkit.org/show_bug.cgi?id=158148 and instead uses -[CAContext commitPriority:]
to prevent flicker when moving a layer between contexts.
commitPriority allows the layer to be added to the destination context before it is
removed from the source context.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: remove m_secondaryVideoLayer.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): ditto

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers):ditto

  • platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: ditto
  • platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: ditto

(WebCore::VideoFullscreenLayerManager::setVideoLayer): ditto
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): ditto and adopt commitPriority.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Deleted.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): remove m_secondaryVideoLayer.

  • platform/spi/cocoa/QuartzCoreSPI.h: Add commitPriority.
4:24 PM Changeset in webkit [202251] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Set the end position on the placeholder BidiRun properly.
​https://bugs.webkit.org/show_bug.cgi?id=158958

Reviewed by Myles C. Maxfield.
rdar://problem/26609266

The second paramenter for BidiRun indicates the end position and not the length of the run.
This was regressed at r102875 where only the start position was changed from 0 to pos.

Source/WebCore:

Test: fast/text/international/bidi-style-in-isolate-crash.html

  • rendering/InlineIterator.h:

(WebCore::addPlaceholderRunForIsolatedInline):

LayoutTests:

  • fast/text/international/bidi-style-in-isolate-crash-expected.txt: Added.
  • fast/text/international/bidi-style-in-isolate-crash.html: Added.
4:23 PM Changeset in webkit [202250] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

A composition underline is placed to wrong position in RTL
​https://bugs.webkit.org/show_bug.cgi?id=158602

Patch by Fujii Hironori <Fujii Hironori> on 2016-06-20
Reviewed by Myles C. Maxfield.

Source/WebCore:

InlineTextBox::paintCompositionUnderline does not take RTL into
account. The position of composition underline should be
mirrored in RTL.

Test: editing/input/composition-underline-rtl.html

  • rendering/InlineTextBox.cpp:

(WebCore::mirrorRTLSegment): New helper function to convert RTL start position to LTR.
(WebCore::InlineTextBox::paintDecoration): Use mirrorRTLSegment.
(WebCore::InlineTextBox::paintCompositionUnderline): Ditto.

LayoutTests:

  • editing/input/composition-underline-rtl-expected.html: Added.
  • editing/input/composition-underline-rtl.html: Added.
3:41 PM Changeset in webkit [202249] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit2

Allow Spotlight suggestions to be read by any process
​https://bugs.webkit.org/show_bug.cgi?id=158950
<rdar://problem/26865374>

Reviewed by Alexey Proskuryakov.

Extend sandbox to allow all web processes to read Spotlight results.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
3:38 PM Changeset in webkit [202248] by keith_miller@apple.com
  • 58 edits
    2 deletes in trunk/Source

It should be easy to add a private global helper function for builtins
​https://bugs.webkit.org/show_bug.cgi?id=158893

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch does two things. First it moves all the builtin names
out of CommonIdentifiers and into BuiltinNames. This means that
adding a new function to the Builtins does not require rebuilding
all of JavaScriptCore. This patch also adds a new decorator to our
builtins @privateGlobal that will automatically put the function
on the global object. The name of the property will be the same as
the private name of the function.

This patch, also, removes the JSArrayIterator.h/.cpp files
as they no longer appear to be used in any real way. Finally,
the builtins tests have been rebaselined. It appears this has
not been done for a while so the expected files contain other
changes.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Scripts/builtins/builtins_generate_combined_header.py:

(BuiltinsCombinedHeaderGenerator.generate_output):
(generate_section_for_code_name_macro):
(generate_section_for_global_private_code_name_macro):

  • Scripts/builtins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
  • builtins/ArrayIteratorPrototype.js:
  • builtins/ArrayPrototype.js:
  • builtins/BuiltinNames.h:
  • builtins/GeneratorPrototype.js:
  • builtins/GlobalObject.js:
  • builtins/PromiseOperations.js:
  • builtins/RegExpPrototype.js:
  • builtins/StringPrototype.js:
  • bytecode/BytecodeIntrinsicRegistry.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC::BytecodeGenerator::emitGetTemplateObject):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitGeneratorStateChange):

  • bytecompiler/NodesCodegen.cpp:

(JSC::emitHomeObjectForCallee):
(JSC::emitPutHomeObject):
(JSC::FunctionNode::emitBytecode):

  • dfg/DFGOperations.cpp:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties): Deleted.

  • parser/Lexer.cpp:

(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::createGeneratorParameters):
(JSC::Parser<LexerType>::parseExportDeclaration):

  • runtime/ArrayIteratorPrototype.cpp:
  • runtime/ArrayIteratorPrototype.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.

  • runtime/CommonIdentifiers.h:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/IntlDateTimeFormat.cpp:
  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

  • runtime/IntlObjectInlines.h:

(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):

  • runtime/JSArrayIterator.cpp: Removed.

(JSC::JSArrayIterator::finishCreation): Deleted.
(JSC::JSArrayIterator::kind): Deleted.
(JSC::JSArrayIterator::iteratedValue): Deleted.

  • runtime/JSArrayIterator.h: Removed.

(JSC::JSArrayIterator::createStructure): Deleted.
(JSC::JSArrayIterator::create): Deleted.
(JSC::JSArrayIterator::JSArrayIterator): Deleted.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSInternalPromise.cpp:
  • runtime/JSInternalPromiseDeferred.cpp:

(JSC::JSInternalPromiseDeferred::create):

  • runtime/JSPromise.cpp:

(JSC::JSPromise::finishCreation):
(JSC::JSPromise::result):

  • runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::create):

  • runtime/JSStringIterator.cpp:

(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::iteratedValue):
(JSC::JSStringIterator::clone):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

  • runtime/ReflectObject.cpp:

(JSC::ReflectObject::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • runtime/TypedArrayInlines.h:

Source/WebCore:

Add JSCJSValueInlines.h to fix build issues.

  • platform/mock/mediasource/MockBox.cpp:
3:30 PM Changeset in webkit [202247] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test expectations gardening for
​https://bugs.webkit.org/show_bug.cgi?id=155196

  • platform/mac-wk1/TestExpectations:
2:37 PM Changeset in webkit [202246] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Test result gardening.

  • platform/mac-wk2/TestExpectations:
2:30 PM Changeset in webkit [202245] by benjamin@webkit.org
  • 20 edits
    4 adds in trunk

:default CSS pseudo-class should match checkboxes+radios with a checked attribute
​https://bugs.webkit.org/show_bug.cgi?id=156230

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:

Source/WebCore:

This patch update the :default pseudo class matching to be closer to the spec:
​https://html.spec.whatwg.org/multipage/scripting.html#selector-default

The main remaining difference with the spec is the definition of "default button".
This is an unrelated problem that should be addressed separately.

The implementation was missing support for:
-input elements of type "checkbox" or "radio" with the "checked" attribute defined.
-option elements with the "selected" attribute defined.

The existing support for default button was pretty bad, I fixed that too.
The owner form now has a resetDefaultButton() API. When a Form Associated Element
becomes a submit button or loses that property, the element calls its form
to update the style as needed.

Whenever the submit button changes, 2 elements needs to have their style invalidated:
-The former default button.
-The new default button.
To invalidate the former button, FormElement now caches the computed
default button. When the default button changes, the cached value is invalidated
in addition to the new value.

Computing the new default button takes linear time in the number of form associated element.
To mitigate that, resetDefaultButton() is only called when changes are related
to submit buttons. Since those changes are rare, I don't expect the invalidation
to be a problem.

Tests: fast/css/pseudo-default-basics.html

fast/selectors/default-style-update.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesDefaultPseudoClass):
(WebCore::isDefaultButtonForForm): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

  • dom/Element.cpp:

(WebCore::Element::matchesValidPseudoClass):
(WebCore::Element::matchesInvalidPseudoClass):
(WebCore::Element::matchesDefaultPseudoClass):

  • dom/Element.h:

(WebCore::Element::matchesValidPseudoClass): Deleted.
(WebCore::Element::matchesInvalidPseudoClass): Deleted.
(WebCore::Element::isDefaultButtonForForm): Deleted.

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::parseAttribute):
(WebCore::HTMLButtonElement::matchesDefaultPseudoClass):

  • html/HTMLButtonElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isDefaultButtonForForm): Deleted.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::registerFormElement):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::resetDefaultButton):

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::matchesDefaultPseudoClass):

  • html/HTMLInputElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::matchesDefaultPseudoClass):
(WebCore::HTMLOptionElement::parseAttribute):

  • html/HTMLOptionElement.h:
  • style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::canShareStyleWithControl): Deleted.

LayoutTests:

  • fast/css/pseudo-default-basics-expected.html: Added.
  • fast/css/pseudo-default-basics.html: Added.
  • fast/selectors/default-style-update-expected.txt: Added.
  • fast/selectors/default-style-update.html: Added.
2:25 PM Changeset in webkit [202244] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

LLInt64 Float64 get_by_val doesn't purify NaN
​https://bugs.webkit.org/show_bug.cgi?id=158956

Reviewed by Michael Saboff.

  • llint/LowLevelInterpreter64.asm: Fix the bug.
  • tests/stress/float64-array-nan-inlined.js: Make this test also run in LLInt-only mode to catch this bug.
2:22 PM Changeset in webkit [202243] by Simon Fraser
  • 21 edits
    4 adds in trunk

Focus event dispatched in iframe causes parent document to scroll incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=158629
rdar://problem/26521616

Reviewed by Tim Horton.
Source/WebCore:

When focussing elements in iframes, the page could scroll to an incorrect location.
This happened because code in Element::focus() tried to disable scrolling on focus,
but did so only for the current frame, so ancestor frames got programmatically scrolled.
On iOS we handle the scrolling in the UI process, so never want the web process to
do programmatic scrolling.

Fix by changing the focus and cache restore code to use SelectionRevealMode::DoNotReveal,
rather than manually prohibiting frame scrolling. Pass SelectionRevealMode through various callers,
and use RevealUpToMainFrame for iOS, allowing the UI process to do the zoomToRect: for the main frame.

Tests: fast/forms/ios/focus-input-in-iframe.html

fast/forms/ios/programmatic-focus-input-in-iframe.html

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::scrollIntoViewIfNotVisible):
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearance):

  • dom/Element.h:
  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::findStringAndScrollToVisible):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::FrameSelection): Deleted.

  • editing/FrameSelection.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::autoscroll):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::scrollRectToVisible):

  • rendering/RenderObject.h:

Source/WebKit/mac:

Pass SelectionRevealMode::Reveal in existing code.

  • WebView/WebFrame.mm:

(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):
(-[WebFrame revealSelectionAtExtent:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

Source/WebKit2:

Pass SelectionRevealMode::Reveal in existing code.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea):

LayoutTests:

  • fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
  • fast/forms/ios/focus-input-in-iframe.html: Added.
  • fast/forms/ios/programmatic-focus-input-in-iframe-expected.txt: Added.
  • fast/forms/ios/programmatic-focus-input-in-iframe.html: Added.
1:52 PM Changeset in webkit [202242] by Keith Rollin
  • 205 edits in trunk

Remove RefPtr::release() and change calls sites to use WTFMove()
​https://bugs.webkit.org/show_bug.cgi?id=158369

Reviewed by Chris Dumez.

RefPtr::release() releases its managed pointer awkwardly. It's more
direct and clearer to use WTFMove to transfer ownership of the managed
pointer.

As part of this cleanup, also change a lot of explicit data types to
'auto'.

Source/JavaScriptCore:

  • API/JSObjectRef.cpp:

(JSClassCreate):

  • API/JSScriptRef.cpp:
  • API/JSValueRef.cpp:

(JSValueToStringCopy):

  • bytecompiler/StaticPropertyAnalyzer.h:

(JSC::StaticPropertyAnalyzer::newObject):
(JSC::StaticPropertyAnalyzer::mov):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::invalidate):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • inspector/InspectorValues.cpp:

(Inspector::InspectorValue::parseJSON):

  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomain):
(Inspector::InspectorAgent::activateExtraDomains):

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::breakpointActionProbe):

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::receivedSetupMessage):

  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • runtime/GenericTypedArrayViewInlines.h:

(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):

  • runtime/JSArrayBufferConstructor.cpp:

(JSC::constructArrayBuffer):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::releaseData):

  • runtime/Structure.cpp:

(JSC::Structure::toStructureShape):

  • runtime/TypeSet.cpp:

(JSC::StructureShape::merge):

  • tools/FunctionOverrides.cpp:

(JSC::initializeOverrideInfo):

Source/WebCore:

No new tests: there's no new functionality, just a refactoring of
existing code.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::provideMediaData):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertShapeValue):

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::copyPropertiesInSet):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImages):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::clearSheet):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeChildrenInRange):
(WebCore::CompositeEditCommand::removeNodeAndPruneAncestors):
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::replaceSelectedTextInNode):
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

  • editing/Editor.cpp:

(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/EditorCommand.cpp:

(WebCore::executeInsertNode):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::insertTab):

  • editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeNodePreservingChildren):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareForSubmission):

  • html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):
(WebCore::leakGroupBorderStyle):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):

  • html/track/InbandDataTextTrack.cpp:

(WebCore::InbandDataTextTrack::addDataCue):

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::newCuesParsed):

  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed):

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getInlineStylesForNode):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):

  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::loadResource):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForSelectorList):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::finalProgressComplete):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::loadCache):

  • loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::popSubframeArchive):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::extract):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::createImage):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::createOverlayIfNeeded):
(WebCore::ServicesOverlayController::determineActiveHighlight):

  • page/scrolling/AsyncScrollingCoordinator.h:

(WebCore::AsyncScrollingCoordinator::releaseScrollingTree):

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndReset):

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):

  • platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForSystemFallback):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):

  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::updateOptions):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):

  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::createCompatibleLayerOrTakeFromPool):

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):

  • platform/graphics/mac/ImageMac.mm:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::createForCurrentGLContext):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):

  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::formCreate):

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::copyStackRemovingUnicodeEmbeddingContexts):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::createScrollbar):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::createScrollbar):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::createScrollbar):

  • replay/ReplayController.cpp:

(WebCore::ReplayController::unloadSegment):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::internalAbort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

Source/WebKit:

  • Storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::create):
(WebKit::NetscapePluginInstanceProxy::loadRequest):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(-[WebFramePolicyListener receivedPolicyDecision:]):

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin initWithURL:]):

  • WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive initWithData:]):

  • WebView/WebDataSource.mm:

(-[WebDataSource mainResource]):

  • WebView/WebFrame.mm:

(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::allocate):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::map):

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeToObjectStream):

  • Shared/API/c/WKImage.cpp:

(WKImageCreate):

  • Shared/API/c/WKNumber.cpp:

(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):

  • Shared/API/c/WKSecurityOriginRef.cpp:

(WKSecurityOriginCreate):

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueCreate):
(WKSerializedScriptValueCreateWithInternalRepresentation):

  • Shared/API/c/cairo/WKImageCairo.cpp:

(WKImageCreateFromCairoSurface):

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):

  • Shared/API/c/mac/WKObjCTypeWrapperRef.mm:

(WKObjCTypeWrapperCreate):

  • Shared/API/c/mac/WKWebArchive.cpp:

(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):

  • Shared/API/c/mac/WKWebArchiveResource.cpp:

(WKWebArchiveResourceCreate):

  • Shared/APIWebArchive.mm:

(API::WebArchive::WebArchive):

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::getOrCreate):

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::map):

  • Shared/gtk/ArgumentCodersGtk.cpp:

(IPC::ArgumentCoder<DragData>::decode):

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewCreate):

  • UIProcess/API/C/WKBatteryStatus.cpp:

(WKBatteryStatusCreate):

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate_b):

  • UIProcess/API/C/WKGrammarDetail.cpp:

(WKGrammarDetailCreate):

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopySessionState):

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupCreateWithIdentifier):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
(WKPreferencesCreateCopy):

  • UIProcess/API/C/WKSessionRef.cpp:

(WKSessionCreate):

  • UIProcess/API/C/WKSessionStateRef.cpp:

(WKSessionStateCopyData):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _sessionStateData]):
(-[WKWebView _restoreSessionState:andNavigate:]):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(EwkDatabaseManager::createOriginList):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(EwkStorageManager::createOriginList):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateNewPage):
(webkitWebViewPrintFrame):
(getContentsAsMHTMLDataCallback):

  • UIProcess/Cocoa/SessionStateCoding.mm:

(WebKit::encodeSessionState):

  • UIProcess/GenericCallback.h:

(WebKit::CallbackMap::take):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::createRequest):

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getOrCreatePluginProcess):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::createLocalStorageMap):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::clear):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::installViewStateChangeCompletionHandler):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::copy):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::~WebProcessPool):

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _webHitTestResult]):

  • UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _askPageToComputePageRects]):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setDragImage):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame hitTest:]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:

(-[WKWebProcessPlugInHitTestResult nodeHandle]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]):
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:

(+[WKWebProcessPlugInScriptWorld world]):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp:

(WKBundleDOMWindowExtensionCreate):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyNodeHandle):
(WKBundleHitTestResultCopyURLElementHandle):

  • WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp:

(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopySnapshotWithOptions):
(WKBundleNodeHandleCopyVisibleRange):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotWithOptions):
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
(WKBundlePageCreateScaledSnapshotInDocumentCoordinates):
(WKBundlePagePostSynchronousMessageForTesting):

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:

(WKBundleRangeHandleCreate):
(WKBundleRangeHandleCopySnapshotWithOptions):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldCreateWorld):

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode _copyBundleNodeHandleRef]):

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange _copyBundleRangeHandleRef]):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp:

(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):
(WebKit::InjectedBundleNodeHandle::renderedImage):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::create):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):

  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::createScrollbar):

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::applyChange):

  • WebProcess/WebCoreSupport/SessionStateConversion.cpp:

(WebKit::toFormData):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::getOrCreate):
(WebKit::VisitedLinkTableController::setVisitedLinkTable):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::createSelectionSnapshot):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
(WebKit::WebPage::willPerformLoadDragDestinationAction):
(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::drawRectToImage):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::create):

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::Properties::decode):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::create):
(WebKit::PlatformCALayerRemote::clone):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::create):
(WebKit::PlatformCALayerRemoteCustom::clone):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::createDisplayRefreshMonitor):

Tools:

  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createBitmapContextFromWebView):
(createPagedBitmapContext):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPosition):

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

1:48 PM Changeset in webkit [202241] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.145

New tag.

1:47 PM Changeset in webkit [202240] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.7.5

New tag.

1:40 PM Changeset in webkit [202239] by ap@apple.com
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r202179.
​https://bugs.webkit.org/show_bug.cgi?id=158946

The test either fails or times out 100% of the time (Requested
by ap on #webkit).

Reverted changeset:

"REGRESSION: Double tap to zoom does not work on yahoo
finance"
​https://bugs.webkit.org/show_bug.cgi?id=158886
​http://trac.webkit.org/changeset/202179

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-06-20

1:38 PM Changeset in webkit [202238] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in PlatformMediaSession::clientWillPausePlayback
​https://bugs.webkit.org/show_bug.cgi?id=158953
<rdar://problem/26121125>

Reviewed by Jer Noble.

No new tests, I have not been able to reproduce this in a test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop): Ref the element before calling stopWithoutDestroyingMediaPlayer

because updatePlaybackControlsManager can release the last reference and cause the
destructor to be called.

(WebCore::HTMLMediaElement::suspend): Ditto.

1:35 PM Changeset in webkit [202237] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Fix a run-webkit-tests --lint warning.

  • platform/mac/TestExpectations:
1:34 PM Changeset in webkit [202236] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up ResourceResponseBase after r201943
​https://bugs.webkit.org/show_bug.cgi?id=158706

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-06-20
Reviewed by Michael Catanzaro.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::asResourceResponse): Deleted.

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::platformCompare):

1:30 PM Changeset in webkit [202235] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectations gardening for
​https://bugs.webkit.org/show_bug.cgi?id=155196

Marked the tests as flaky instead of skipping, to make the results visible on the
flakiness dashboard. Also added video-with-data-url-allowed-by-media-src-star.html,
which is very flaky too.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
12:12 PM Changeset in webkit [202234] by Joseph Pecoraro
  • 22 edits
    2 adds in trunk

Web Inspector: console.profile should use the new Sampling Profiler
​https://bugs.webkit.org/show_bug.cgi?id=153499
<rdar://problem/24352431>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Currently console.profile/profileEnd behave slightly differently
between JSContext and Web inspection. Unifying will be part of:
<​https://webkit.org/b/158753> Generalize the concept of Instruments on the backend

Both JSContext and Web inspection keep track of active
profiles started and stopped via console.profile/profileEnd.

JSContext inspection sends its programmatic start/stop
via the ScriptProfiler domain.

Web inspection sends its programmatic start/stop
via the Timeline domain, and also will start/stop backend
list of Instruments.

The functional differences between these is that for JSContext
inspection, console.profile only starts/stops the ScriptProfiler
domain, and does not auto-start other instruments. This isn't really
a problem right now given the instruments available for JSContext
inspection; but it will be nice to unify as we add more instruments.
Also, JSContext inspection won't have "Profile (name)" records in
its Events view, since those are currently generated only by the
Web's Timeline domain.

  • inspector/protocol/ScriptProfiler.json:
  • inspector/protocol/Timeline.json:

Events to inform the frontend of programmatic start/stop.

  • debugger/Debugger.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::breakpointsActive):
(Inspector::InspectorDebuggerAgent::isPaused):

  • inspector/agents/InspectorDebuggerAgent.h:

Expose breakpoints active state, since programmatic recording
will temporarily disabled breakpoints if needed.

  • inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::JSGlobalObjectConsoleClient):
(Inspector::JSGlobalObjectConsoleClient::profile):
(Inspector::JSGlobalObjectConsoleClient::profileEnd):
(Inspector::JSGlobalObjectConsoleClient::startConsoleProfile):
(Inspector::JSGlobalObjectConsoleClient::stopConsoleProfile):

  • inspector/JSGlobalObjectConsoleClient.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

  • inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::programmaticCaptureStarted):
(Inspector::InspectorScriptProfilerAgent::programmaticCaptureStopped):

  • inspector/agents/InspectorScriptProfilerAgent.h:

JSContext implementation of console.profile/profileEnd.

Source/WebCore:

Test: inspector/timeline/setInstruments-programmatic-capture.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::startProgrammaticCapture):
(WebCore::InspectorTimelineAgent::stopProgrammaticCapture):
(WebCore::InspectorTimelineAgent::toggleInstruments):
(WebCore::InspectorTimelineAgent::toggleScriptProfilerInstrument):
(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
(WebCore::InspectorTimelineAgent::toggleMemoryInstrument):
(WebCore::InspectorTimelineAgent::toggleTimelineInstrument):

  • inspector/InspectorTimelineAgent.h:

Web implementation of console.profile/profileEnd.
Make helpers for startings / stopping instruments.

Source/WebInspectorUI:

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStopped):
(WebInspector.TimelineManager.prototype.scriptProfilerProgrammaticCaptureStarted):
(WebInspector.TimelineManager.prototype.scriptProfilerProgrammaticCaptureStopped):
For programmatic captures, automatically show the Script Timeline, since
that is guarenteed to have been started by the backend. Start capturing
without creating a new recording.

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.stop):
(WebInspector.TimelineRecording.prototype.addScriptInstrumentForProgrammaticCapture):
When stopping for programmatic capture we don't need to disable
instruments, the backend would have already done this.

  • UserInterface/Protocol/ScriptProfilerObserver.js:

(WebInspector.ScriptProfilerObserver.prototype.programmaticCaptureStarted):
(WebInspector.ScriptProfilerObserver.prototype.programmaticCaptureStopped):
(WebInspector.ScriptProfilerObserver):

  • UserInterface/Protocol/TimelineObserver.js:

(WebInspector.TimelineObserver.prototype.programmaticCaptureStarted):
(WebInspector.TimelineObserver.prototype.programmaticCaptureStopped):
(WebInspector.TimelineObserver):
Pass through Web and JSContext programmatic capture events.

LayoutTests:

  • inspector/timeline/setInstruments-programmatic-capture-expected.txt: Added.
  • inspector/timeline/setInstruments-programmatic-capture.html: Added.

New test that the backend auto-starts instruments during programmatic capture.

12:10 PM Changeset in webkit [202233] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline test now that TouchEvent has a constructor.

  • fast/events/touch/document-create-touch-list-ios-expected.txt:
11:52 AM Changeset in webkit [202232] by timothy_horton@apple.com
  • 2 edits
    1 add in trunk/Tools

Add a API test for *DeferringViewInWindowChanges as fixed in r202230
​https://bugs.webkit.org/show_bug.cgi?id=158947

Reviewed by Simon Fraser.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
Add a test ensuring that in-window state changes are deferred when using
the SPI for deferring them, as fixed in r202230.

10:23 AM Changeset in webkit [202231] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

When navigating, discard decoded image data that is only live due to page cache.
<​https://webkit.org/b/158941>

Reviewed by Antti Koivisto.

A resource is "live" if it's currently in use by a web page, and "dead" if it's
only kept alive by the memory cache.

This patch adds a mechanism that looks at CachedImage resources to see if all the
clients that make them appear "live" are actually pages in the page cache.

If so, we let the "jettison expensive objects on top-level navigation" mechanism
discard the decoded data for such half-live images. This can reduce the peak
memory usage during navigations quite a bit.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Move the call to MemoryPressureHandler
before we add the outgoing page to the page cache. This allows the jettisoning code
to make decisions based on which pages were cached *before* the navigation.

  • loader/cache/CachedImageClient.h:

(WebCore::CachedImageClient::inPageCache):

  • loader/ImageLoader.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::inPageCache):

  • rendering/RenderObject.h:

(WebCore::RenderObject::inPageCache): Added a CachedImageClient::inPageCache() virtual
to determine which clients are currently in page cache (answered by their Document.)

  • loader/cache/CachedImage.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::areAllClientsInPageCache): Walks all CachedImageClient clients
and returns true if all of them are inPageCache().

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::jettisonExpensiveObjectsOnTopLevelNavigation):
Walk all the known CachedImages and nuke decoded data for those that have some but
are only considered live due to clients in the page cache.

10:13 AM Changeset in webkit [202230] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r191499): Tab content "jumps" down when focusing tabs that load in the background
​https://bugs.webkit.org/show_bug.cgi?id=158904
<rdar://problem/26025831>

Reviewed by Sam Weinig.

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::viewDidMoveToWindow):
During the large refactor that was r191499, we somehow ended up with two
different members for the same thing - one that got written, and one that
got read. We should only have one.

10:10 AM Changeset in webkit [202229] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the iOS build after r202142 and r202224.

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):

10:02 AM Nightly Builds edited by rniwa@webkit.org
Add the link to El Capitan workarounds (diff)
9:10 AM Changeset in webkit [202228] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix post-landing review comment from Darin on r202188.

  • platform/network/CacheValidation.cpp:

(WebCore::parseCacheHeader):

1:52 AM Changeset in webkit [202227] by Antti Koivisto
  • 5 edits
    2 adds in trunk

Updating class name of a shadow host does not update the style applied by :host()
​https://bugs.webkit.org/show_bug.cgi?id=158900
<rdar://problem/26883707>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/shadow-dom/shadow-host-style-update.html

Teach style invalidation optimization code about :host.

  • style/AttributeChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::computeClassChange):
(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/IdChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::IdChangeInvalidation::invalidateStyle):

LayoutTests:

  • fast/shadow-dom/shadow-host-style-update-expected.html: Added.
  • fast/shadow-dom/shadow-host-style-update.html: Added.
12:07 AM Changeset in webkit [202226] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
​https://bugs.webkit.org/show_bug.cgi?id=158931

Patch by Fujii Hironori <Fujii Hironori> on 2016-06-20
Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.

Jun 19, 2016:

11:56 PM Changeset in webkit [202225] by fred.wang@free.fr
  • 10 edits in trunk/Source/ThirdParty

Update Brotli to version 0.4.0
​https://bugs.webkit.org/show_bug.cgi?id=158907

Reviewed by Michael Catanzaro.

  • brotli/README.webkit:
  • brotli/dec/bit_reader.h:
  • brotli/dec/decode.c:
  • brotli/dec/decode.h:
  • brotli/dec/huffman.c:
  • brotli/dec/huffman.h:
  • brotli/dec/port.h:

(BrotliDump):

  • brotli/dec/state.c:
  • brotli/dec/state.h:
10:53 PM Changeset in webkit [202224] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix erroneously commented line added in r202142.

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):

8:57 PM Changeset in webkit [202223] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectation gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
7:35 PM Changeset in webkit [202222] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectation gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
6:59 PM Changeset in webkit [202221] by Gyuyoung Kim
  • 2 edits in trunk/LayoutTests

[EFL] Mark shadow-dom tests to pass because it was enabled by r202091
​https://bugs.webkit.org/show_bug.cgi?id=158930

Unreviewed EFL gardening.

  • platform/efl/TestExpectations:
6:22 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
6:19 PM Changeset in webkit [202220] by Michael Catanzaro
  • 2 edits
    2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening

  • fast/forms/select-non-native-rendering-direction-expected.txt: Added.
  • fast/text/hyphenate-avoid-orphaned-word-expected.txt: Added.
  • platform/gtk/TestExpectations:
5:17 PM Changeset in webkit [202219] by ap@apple.com
  • 36 edits
    27 copies
    3 moves
    38 adds
    3 deletes in trunk

Add test expectations for macOS Sierra
​https://bugs.webkit.org/show_bug.cgi?id=158903

Reviewed by Alex Christensen.

Tools:

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Sierra@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

Added dashboard support.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

Trigger the right build queues on check-in.

  • Scripts/webkitpy/common/system/platforminfo.py:
  • Scripts/webkitpy/common/system/platforminfo_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/port/mac.py:
  • Scripts/webkitpy/port/mac_unittest.py:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

Added cases for Sierra, and updated tests for new baseline search paths.

LayoutTests:

  • TestExpectations:
  • media/click-placeholder-not-pausing-expected.txt: Added.
  • media/click-placeholder-not-pausing.html: Added.
  • media/controls/picture-in-picture-expected.txt: Added.
  • media/controls/picture-in-picture.html: Added.
  • media/element-containing-pip-video-going-into-fullscreen-expected.txt: Added.
  • media/element-containing-pip-video-going-into-fullscreen.html: Added.
  • media/fullscreen-api-enabled-media-with-presentation-mode-expected.txt: Added.
  • media/fullscreen-api-enabled-media-with-presentation-mode.html: Added.
  • media/fullscreen-video-going-into-pip-expected.txt: Added.
  • media/fullscreen-video-going-into-pip.html: Added.
  • media/navigate-with-pip-should-not-crash-expected.txt: Added.
  • media/navigate-with-pip-should-not-crash.html: Added.
  • media/pip-video-going-into-fullscreen-expected.txt: Added.
  • media/pip-video-going-into-fullscreen.html: Added.
  • media/video-contained-in-fullscreen-element-going-into-pip-expected.txt: Added.
  • media/video-contained-in-fullscreen-element-going-into-pip.html: Added.
  • platform/mac-elcapitan: Added.
  • platform/mac-elcapitan/compositing: Added.
  • platform/mac-elcapitan/compositing/rtl: Added.
  • platform/mac-elcapitan/compositing/rtl/rtl-overflow-scrolling-expected.txt: Copied from LayoutTests/platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt.
  • platform/mac-elcapitan/fast: Added.
  • platform/mac-elcapitan/fast/block: Added.
  • platform/mac-elcapitan/fast/block/float: Added.
  • platform/mac-elcapitan/fast/block/float/026-expected.png: Copied from LayoutTests/platform/mac/fast/block/float/026-expected.png.
  • platform/mac-elcapitan/fast/block/float/026-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/026-expected.txt.
  • platform/mac-elcapitan/fast/block/float/028-expected.png: Copied from LayoutTests/platform/mac/fast/block/float/028-expected.png.
  • platform/mac-elcapitan/fast/block/float/028-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/028-expected.txt.
  • platform/mac-elcapitan/fast/overflow: Added.
  • platform/mac-elcapitan/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png.
  • platform/mac-elcapitan/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt.
  • platform/mac-elcapitan/fast/ruby: Added.
  • platform/mac-elcapitan/fast/ruby/bopomofo-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-expected.png.
  • platform/mac-elcapitan/fast/ruby/bopomofo-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-expected.txt.
  • platform/mac-elcapitan/fast/ruby/bopomofo-letter-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-letter-spacing-expected.png.
  • platform/mac-elcapitan/fast/ruby/bopomofo-letter-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt.
  • platform/mac-elcapitan/fast/ruby/bopomofo-rl-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-rl-expected.png.
  • platform/mac-elcapitan/fast/ruby/bopomofo-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-rl-expected.txt.
  • platform/mac-elcapitan/fast/text: Added.
  • platform/mac-elcapitan/fast/text/crash-complex-text-surrogate-expected.txt: Copied from LayoutTests/platform/mac/fast/text/crash-complex-text-surrogate-expected.txt.
  • platform/mac-elcapitan/fast/text/justify-ideograph-complex-expected.png: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-complex-expected.png.
  • platform/mac-elcapitan/fast/text/justify-ideograph-complex-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-complex-expected.txt.
  • platform/mac-elcapitan/fast/text/line-initial-and-final-swashes-expected.png: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.png.
  • platform/mac-elcapitan/fast/text/line-initial-and-final-swashes-expected.txt: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt.
  • platform/mac-elcapitan/http: Added.
  • platform/mac-elcapitan/http/tests: Added.
  • platform/mac-elcapitan/http/tests/cookies: Added.
  • platform/mac-elcapitan/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Copied from LayoutTests/http/tests/cookies/third-party-cookie-relaxing-expected.txt.
  • platform/mac-elcapitan/http/tests/security: Added.
  • platform/mac-elcapitan/http/tests/security/mixedContent: Added.
  • platform/mac-elcapitan/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/mac/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt.
  • platform/mac-elcapitan/media: Added.
  • platform/mac-elcapitan/media/controls-strict-expected.png: Copied from LayoutTests/platform/mac/media/controls-strict-expected.png.
  • platform/mac-elcapitan/media/controls-strict-expected.txt: Copied from LayoutTests/platform/mac/media/controls-strict-expected.txt.
  • platform/mac-elcapitan/media/controls-without-preload-expected.png: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.png.
  • platform/mac-elcapitan/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.txt.
  • platform/mac-elcapitan/media/track: Added.
  • platform/mac-elcapitan/media/track/video-track-alternate-groups-expected.txt: Copied from LayoutTests/platform/mac/media/track/video-track-alternate-groups-expected.txt.
  • platform/mac-elcapitan/media/video-controls-rendering-expected.txt: Copied from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
  • platform/mac-elcapitan/media/video-display-toggle-expected.png: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.png.
  • platform/mac-elcapitan/media/video-display-toggle-expected.txt: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.txt.
  • platform/mac-elcapitan/media/video-no-audio-expected.txt: Copied from LayoutTests/platform/mac/media/video-no-audio-expected.txt.
  • platform/mac-elcapitan/media/video-volume-slider-expected.txt: Copied from LayoutTests/platform/mac/media/video-volume-slider-expected.txt.
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/fast/scrolling: Added.
  • platform/mac-wk2/fast/scrolling/rtl-scrollbars-animation-property-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
  • platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt:
  • platform/mac/fast/block/float/026-expected.png:
  • platform/mac/fast/block/float/026-expected.txt:
  • platform/mac/fast/block/float/028-expected.png:
  • platform/mac/fast/block/float/028-expected.txt:
  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/mac/fast/ruby/bopomofo-expected.png:
  • platform/mac/fast/ruby/bopomofo-expected.txt:
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.png:
  • platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
  • platform/mac/fast/ruby/bopomofo-rl-expected.png:
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt:
  • platform/mac/fast/text/crash-complex-text-surrogate-expected.txt:
  • platform/mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/mac/fast/text/justify-ideograph-complex-expected.txt:
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
  • platform/mac/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
  • platform/mac/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
  • platform/mac/media/controls-strict-expected.png: Removed.
  • platform/mac/media/controls-without-preload-expected.png: Removed.
  • platform/mac/media/track/video-track-alternate-groups-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.png: Removed.
  • platform/mac/media/video-display-toggle-expected.png: Removed.
  • platform/mac/media/video-no-audio-expected.png: Removed.
  • platform/mac/media/video-volume-slider-expected.png: Removed.
5:03 PM Changeset in webkit [202218] by barraclough@apple.com
  • 25 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 5: done!)
​https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • remove hasStaticPropertyTable.
  • bindings/scripts/test/JS/JSInterfaceName.h:

(WebCore::JSInterfaceName::create):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::create):

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:

(WebCore::JSTestClassWithJSBuiltinConstructor::create):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::create):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::create):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::create):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::create):

  • bindings/scripts/test/JS/JSTestGlobalObject.h:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::create):

  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministic::create):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::create):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::create):

  • bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattribute::create):

  • bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonly::create):

3:19 PM Changeset in webkit [202217] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Sidebar z-index:0 workaround for scrollbars and position:sticky section headers
​https://bugs.webkit.org/show_bug.cgi?id=158882

Reviewed by Darin Adler.

The z-index:0 workaround is no longer needed as it doesn't change anything.

  • UserInterface/Views/Sidebar.css:

(.sidebar > .panel): Deleted.

1:49 PM Changeset in webkit [202216] by ap@apple.com
  • 2 edits in trunk/Tools

Another buid fix for master.cfg.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

1:35 PM Changeset in webkit [202215] by ap@apple.com
  • 2 edits in trunk/Tools

Another buid fix for master.cfg.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

12:42 PM Changeset in webkit [202214] by sbarati@apple.com
  • 26 edits
    2 adds in trunk/Source/JavaScriptCore

We should be able to generate more types of ICs inline
​https://bugs.webkit.org/show_bug.cgi?id=158719
<rdar://problem/26825641>

Reviewed by Filip Pizlo.

This patch changes how we emit code for *byId ICs inline.
We no longer keep data labels to patch structure checks, etc.
Instead, we just regenerate the entire IC into a designated
region of code that the Baseline/DFG/FTL JIT will emit inline.
This makes it much simpler to patch inline ICs. All that's
needed to patch an inline IC is to memcpy the code from
a macro assembler inline using LinkBuffer. This architecture
will be easy to extend into other forms of ICs, such as one
for add, in the future.

To support this change, I've reworked the fields inside
StructureStubInfo. It now has one field that is the CodeLocationLabel
of the start of the inline IC. Then it has a few ints that track deltas
to other locations in the IC such as the slow path start, slow path call, the
ICs 'done' location. We used to perform math on these ints in a bunch of different
places. I've consolidated that math into methods inside StructureStubInfo.

To generate inline ICs, I've implemented a new class called InlineAccess.
InlineAccess is stateless: it just has a bunch of static methods for
generating code into the inline region specified by StructureStubInfo.
Repatch will now decide when it wants to generate such an inline
IC, and it will ask InlineAccess to do so.

I've implemented three types of inline ICs to begin with (extending
this in the future should be easy):

  • Self property loads (both inline and out of line offsets).
  • Self property replace (both inline and out of line offsets).
  • Array length on specific array types.

(An easy extension would be to implement JSString length.)

To know how much inline space to reserve, I've implemented a
method that stubs out the various inline cache shapes and
dumps their size. This is used to determine how much space
to save inline. When InlineAccess ends up generating more
code than can fit inline, we will fall back to generating
code with PolymorphicAccess instead.

To make generating code into already allocated executable memory
efficient, I've made AssemblerData have 128 bytes of inline storage.
This saves us a malloc when splatting code into the inline region.

This patch also tidies up LinkBuffer's API for generating
into already allocated executable memory. Now, when generating
code that has less size than the already allocated space, LinkBuffer
will fill the extra space with nops. Also, if branch compaction shrinks
the code, LinkBuffer will add a nop sled at the end of the shrunken
code to take up the entire allocated size.

This looks like it could be a 1% octane progression.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::nop):
(JSC::ARM64Assembler::fillNops):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::nopPseudo16):
(JSC::ARMv7Assembler::nopPseudo32):
(JSC::ARMv7Assembler::fillNops):
(JSC::ARMv7Assembler::dmbSY):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::addLinkTask):
(JSC::AbstractMacroAssembler::emitNops):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::operator=):
(JSC::AssemblerData::~AssemblerData):
(JSC::AssemblerData::buffer):
(JSC::AssemblerData::grow):
(JSC::AssemblerData::isInlineBuffer):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::setCodeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::releaseAssemblerData):

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::shrink): Deleted.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::debugAddress):
(JSC::LinkBuffer::size):
(JSC::LinkBuffer::wasAlreadyDisassembled):
(JSC::LinkBuffer::didAlreadyDisassemble):
(JSC::LinkBuffer::applyOffset):
(JSC::LinkBuffer::code):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::patchableBranch32):
(JSC::MacroAssemblerARM64::patchableBranch64):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::patchableBranch32):
(JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::nop):
(JSC::X86Assembler::fillNops):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):

  • bytecode/InlineAccess.cpp: Added.

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::linkCodeInline):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):
(JSC::hasFreeRegister):
(JSC::InlineAccess::canGenerateSelfPropertyReplace):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::isCacheableArrayLength):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::rewireStubAsJump):

  • bytecode/InlineAccess.h: Added.

(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initArrayLength):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::propagateTransitions):
(JSC::StructureStubInfo::containsPC):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::considerCaching):
(JSC::StructureStubInfo::slowPathCallLocation):
(JSC::StructureStubInfo::doneLocation):
(JSC::StructureStubInfo::slowPathStartLocation):
(JSC::StructureStubInfo::patchableJumpForIn):
(JSC::StructureStubInfo::valueRegs):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getById):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastCommon):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::slowPathFunction):
(JSC::JITByIdGenerator::generateFastPathChecks): Deleted.

  • jit/JITInlineCacheGenerator.h:

(JSC::JITByIdGenerator::reportSlowPathCall):
(JSC::JITByIdGenerator::slowPathBegin):
(JSC::JITByIdGenerator::slowPathJump):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id):

  • jit/Repatch.cpp:

(JSC::repatchCall):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::appropriateGenericPutByIdFunction):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::linkSlowFor):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
(JSC::repatchByIdSelfAccess): Deleted.
(JSC::resetGetByIDCheckAndLoad): Deleted.
(JSC::resetPutByIDCheckAndLoad): Deleted.
(JSC::replaceWithJump): Deleted.

11:26 AM Changeset in webkit [202213] by Lucas Forschler
  • 2 edits in trunk/Tools

Fix master.cfg

Unreviewed build fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

11:02 AM Changeset in webkit [202212] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test another commit.

Unreviewed.

10:51 AM Changeset in webkit [202211] by youenn.fablet@crf.canon.fr
  • 4 edits in trunk/Source/WebCore

The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
​https://bugs.webkit.org/show_bug.cgi?id=158834

Reviewed by Eric Carlson.

No change of behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Explicitly setting DOMWrapped type definition from
JSXX class deriving from another JSYY class.

  • bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
  • bindings/scripts/test/JS/JSTestNode.h: Ditto.
10:48 AM Changeset in webkit [202210] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit.

Unreviewed.

10:35 AM Changeset in webkit [202209] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test another commit.

Unreviewed.

10:31 AM Changeset in webkit [202208] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit.

Unreviewed.

10:19 AM Changeset in webkit [202207] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test yet another commit.

Unreviewed.

10:01 AM Changeset in webkit [202206] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test another commit.

Unreviewed.

9:42 AM Changeset in webkit [202205] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(concurrent baseline JIT): Kraken/ai-astar runs 20% slower
​https://bugs.webkit.org/show_bug.cgi?id=158906

Reviewed by Benjamin Poulain.

The concurrent baseline JIT was a 2-3% progression on JSBench, possibly a 1% progression
on PLT3, but a 2-5% regression on Kraken. This patch fixes the Kraken regression without
affecting the other tests.

The problem is that Kraken/ai-astar's initialization code had a ginormous piece of init
code that took about 16ms to compile in baseline. There's no good way to avoid letting it
tier-up into baseline since it has a compute loop. The time it takes to run this code is
never measured. The concurrent baseline JIT caused us to schedule the compilation of this
huge code rather than doing it eagerly. This meant that after initialization was done and
we started actually running real stuff, all of the real stuff's compiles would be convoyed
behind this super-expensive baseline compile. Note that DFG and FTL compiles convoy behind
baseline compiles, since you can't schedule a DFG compile for a code block until that code
block is in baseline.

This uses the simplest fix: if we are thinking about scheduling some compile and the
thread is busy, do the compile on the main thread instead. This doesn't completely
eliminate the ai-astar regression (we still have a 4% regression on that test) but it now
results in concurrent baseline JIT being an overall progression on Kraken as a whole (1%
on my machine). This is because concurrent baseline appears to help on other tests.

In the future, we could fix this even better by allowing the JITWorklist to spawn more
threads or by being smarter about baseline compilation. I think it's nasty that if a giant
piece of initialization code ends in a compute loop, we compile all of the code instead of
just the loop. It's also gross that a constant-like object creation expression will result
in so much code. It would result in less code if we allowed ourselves to do a bit more
static reasoning about object literals.

But for now, I think that this is a great way to recover the Kraken regression while still
keeping the other progressions from concurrent baseline.

  • jit/JITWorklist.cpp:

(JSC::JITWorklist::Plan::Plan):
(JSC::JITWorklist::Plan::compileInThread):
(JSC::JITWorklist::Plan::finalize):
(JSC::JITWorklist::Plan::codeBlock):
(JSC::JITWorklist::Plan::isFinishedCompiling):
(JSC::JITWorklist::Plan::compileNow):
(JSC::JITWorklist::JITWorklist):
(JSC::JITWorklist::compileLater):
(JSC::JITWorklist::compileNow):
(JSC::JITWorklist::runThread):
(JSC::JITWorklist::Plan::isFinalized): Deleted.

  • jit/JITWorklist.h:
9:28 AM Changeset in webkit [202204] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit.

Unreviewed.

8:54 AM Changeset in webkit [202203] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test post-commit after apache restart.

Unreviewed.

8:22 AM Changeset in webkit [202202] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Testing yet another fix for trac-mirror.

Unreviewed.

8:16 AM Changeset in webkit [202201] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Testing another fix for trac-mirror.

Unreviewed.

8:10 AM Changeset in webkit [202200] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Testing fix for trac-mirror.

Unreviewed.

7:53 AM Changeset in webkit [202199] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test a commit against the SVN 1.9 server upgrade.

Unreviewed.

Note: See TracTimeline for information about the timeline view.