Timeline
Jul 1, 2016:
- 8:03 PM Changeset in webkit [202773] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Many layout tests are timeout after r202532.
https://bugs.webkit.org/show_bug.cgi?id=159337
Reviewed by Gyuyoung Kim.
WebPageProxy::forceRepaint() wait for the next commit from the web process
after r202532, but WebPageProxy::callAfterNextPresentationUpdate() is not
implemented in CoordinatedDrawingAreaProxy.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
(WebKit::CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::CoordinatedDrawingAreaProxy::sizeDidChange):
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
(WebKit::CoordinatedDrawingAreaProxy::page):
- 7:53 PM Changeset in webkit [202772] by
-
- 12 edits in trunk
REGRESSION(r189668): Notification tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=159375
<rdar://problem/22760990>
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Implement WKNotificationManagerGetLocalID(). For more information, see the entry in Tools/ChangeLog.
- UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerGetLocalID):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::notificationLocalIDForTesting):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
Tools:
Notifications are objects which must exist in both the UI Process and the Web Process. Each process
identifies a notification object by a unique ID. When the Web Process sends a message regarding a
notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
(Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
global notification ID mapping, causing the wrong notification to be investigated.
The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
manually perform this same mapping. Luckily, this object already receives callbacks every time a
notification is created or destroyed. However, because this object is implemented outside WebKit,
it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
WebNotificationProvider can properly map between the different IDs.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::simulateWebNotificationClick):
- WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::showWebNotification):
(WTR::removeGlobalIDFromIDMap):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):
- WebKitTestRunner/WebNotificationProvider.h:
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 7:32 PM Changeset in webkit [202771] by
-
- 3 edits1 delete in trunk
Unreviewed, rolling out r202766.
https://bugs.webkit.org/show_bug.cgi?id=159382
The new test asserts every time (Requested by ap on #webkit).
Reverted changeset:
"Web Inspector: Sending XHR with UTF8 encoded data shows
garbled data in Resource sidebar"
https://bugs.webkit.org/show_bug.cgi?id=159358
http://trac.webkit.org/changeset/202766
- 7:20 PM Changeset in webkit [202770] by
-
- 5 edits in trunk
[JSC] RegExp.compile is not returning the regexp when it succeed
https://bugs.webkit.org/show_bug.cgi?id=159381
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.
Source/JavaScriptCore:
Spec:
-https://tc39.github.io/ecma262/#sec-regexp.prototype.compile
-https://tc39.github.io/ecma262/#sec-regexpinitialize
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
LayoutTests:
- js/regexp-compile-expected.txt:
- js/script-tests/regexp-compile.js:
- 6:15 PM Changeset in webkit [202769] by
-
- 5 edits3 adds in trunk
prepareForDestruction() always needs to be called before destroying the Document object.
https://bugs.webkit.org/show_bug.cgi?id=159372
rdar://problem/26788150
Reviewed by Antti Koivisto.
We should never start destroying the Document object without calling prepareForDestruction() first.
It ensures that render tree gets nuked before we start tearing down the node tree.
Source/WebCore:
Test: fast/history/page-cache-destroy-document.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
LayoutTests:
- fast/history/page-cache-destroy-document-expected.txt: Added.
- fast/history/page-cache-destroy-document.html: Added.
- fast/history/resources/page-cache-destroy-helper.html: Added.
- 5:59 PM Changeset in webkit [202768] by
-
- 6 edits1 add in trunk
fix "ASSERTION FAILED: currentOffset() >= currentLineStartOffset()"
https://bugs.webkit.org/show_bug.cgi?id=158572
<rdar://problem/26884092>
Reviewed by Mark Lam.
Source/JavaScriptCore:
There is a bug in our lexer when we notice the pattern:
<return|continue|break|...etc> // some comment here
Our code will say that the token for the comment is a semicolon.
This is the correct semantics, however, it would give the semicolon
a start offset of the comment, but it will give its line start offset
the newline after the comment. This breaks the invariant in the lexer/parser
that the offset for the current line starting point must be less than or equal to
than the start offset of any token on that line. This invariant was broken because
the line start offset was greater than the token start offset. To maintain this
invariant, we claim that the semicolon token is located where the comment starts,
and that its line start offset is the line start offset for the line with the
comment on it. There are other solutions that maintain this invariant, but this
solution provides the best error messages.
- parser/Lexer.cpp:
(JSC::Lexer<T>::lex):
- parser/Parser.h:
(JSC::Parser::internalSaveLexerState):
- tests/stress/obscure-error-message-dont-crash.js: Added.
(try.eval.or.catch):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
(invalid.or.break.catch):
(catch): Deleted.
- 5:56 PM Changeset in webkit [202767] by
-
- 2 edits in trunk/LayoutTests
Marking fast/history/page-cache-webdatabase-pending-transaction.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=159379
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:55 PM Changeset in webkit [202766] by
-
- 3 edits3 adds in trunk
Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
https://bugs.webkit.org/show_bug.cgi?id=159358
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-07-01
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: http/tests/inspector/network/xhr-request-data-encoded-correctly.html
- inspector/InspectorNetworkAgent.cpp:
(WebCore::buildObjectForResourceRequest):
LayoutTests:
Based on Chromium patch:
<https://chromium.googlesource.com/chromium/src/+/bcbb663864624ab38b36731eb2edc839a90f9e65%5E%21/#F2>
- http/tests/inspector/network/xhr-request-data-encoded-correctly-expected.txt:
- http/tests/inspector/network/xhr-request-data-encoded-correctly.html:
- 5:22 PM Changeset in webkit [202765] by
-
- 10 edits2 adds in trunk
"image-src" support is missing. We only support "-webkit-image-src"
https://bugs.webkit.org/show_bug.cgi?id=159373
<rdar://problem/27140443>
Patch by Brent Fulgham and Dean Jackson.
Reviewed by Dean Jackson and Brent Fulgham.
Source/WebCore:
Support unprefixed image-set.
Test: fast/css/image-set-unprefixed.html
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::customCSSText):
- css/CSSParser.cpp:
(WebCore::isImageSetFunctionValue): New helper function
that checks prefixed and unprefixed form.
(WebCore::CSSParser::parseValue): Use the helper.
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
LayoutTests:
Convert some existing tests to use the unprefixed form,
and add a test that checks we are compatible with
the prefixed form.
- cssom/cssvalue-comparison-expected.txt:
- cssom/cssvalue-comparison.html:
- fast/css/cursor-parsing-image-set-expected.txt:
- fast/css/cursor-parsing-image-set.html:
- fast/css/image-set-setting-expected.txt:
- fast/css/image-set-unprefixed-expected.txt: Added.
- fast/css/image-set-unprefixed.html: Added.
- fast/css/script-tests/image-set-setting.js:
(testImageSetRule):
- 4:58 PM Changeset in webkit [202764] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/27141291.
- platform/mac/TestExpectations:
- 4:41 PM Changeset in webkit [202763] by
-
- 7 edits in trunk/Source/WebKit2
REGRESSION(r201405): Fullscreen video no longer enters low-power mode
https://bugs.webkit.org/show_bug.cgi?id=159220
<rdar://problem/26701056>
Reviewed by Beth Dakin.
In r201405, we removed the call to setTopContentInset(0) to avoid a flash
during repainting where the WebProcess still thought it had an inset and
the UIProcess did not, but the >0 inset breaks low power video playback
in fullscreen. So, instead, fix the repaint issue by setting a CALayer
fence which makes sure both the UIProcess and WebProcess paint simultaneously
after resizing and changing the top content inset.
This requires a new message from WebPageProxy -> WebPage: setTopContentInsetFenced().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setTopContentInset):
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTopContentInsetFenced):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:25 PM Changeset in webkit [202762] by
-
- 2 edits in trunk/Source/WebCore
Possible null Range dereference under AXObjectCache::visiblePositionFromCharacterOffset()
https://bugs.webkit.org/show_bug.cgi?id=159330
<rdar://problem/27123752>
Reviewed by Benjamin Poulain.
rangeForUnorderedCharacterOffsets() can return a null Range but we failed
to do a null check before dereferencing it.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
- 4:22 PM Changeset in webkit [202761] by
-
- 16 edits2 adds in trunk
Regression(r199087): window.focus() / window.close() can no longer be called by a Window's opener
https://bugs.webkit.org/show_bug.cgi?id=159364
<rdar://problem/27117169>
Reviewed by Gavin Barraclough.
Source/WebCore:
window.focus() / window.close() could no longer be called by a Window's opener
after r199087, which would break focusing of open iWork documents on icloud.com.
Before r199087, we would construct a new function in the caller's context every
time window.focus and window.close was accessed. r199087 fixed the issue so that
we always call the same function. However, those functions are using
[CallWith=Document] and they are were no longer passed the *caller*'s document
as a result. This broke focus / close permission checking as the code needed the
caller's document to do the check.
This patch introduces [CallWith=CallerDocument] and [CallWith=CallerWindow] so
that the implementation can now pass the caller's Document / Window to the
implementation. The bindings rely on JSDOMWindow's callerDOMWindow() to get the
caller DOMWindow / document. This new functionality is now used for window.close
and window.focus to unbreak their permission checking.
Test: fast/dom/Window/child-window-focus.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Add layout test coverage.
- fast/dom/Window/child-window-focus-expected.txt: Added.
- fast/dom/Window/child-window-focus.html: Added.
- 4:15 PM Changeset in webkit [202760] by
-
- 2 edits in trunk/LayoutTests
Test gardening for Sierra WK1
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:50 PM Changeset in webkit [202759] by
-
- 2 edits in trunk/LayoutTests
Remove failure expectation for mathml/presentation/bug97990.html on ios-simulator
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/ios-simulator-wk2/TestExpectations:
- 2:43 PM Changeset in webkit [202758] by
-
- 22 edits in trunk/Source/WebKit2
[Mac] Get rid of support for old SDKs
https://bugs.webkit.org/show_bug.cgi?id=159369
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKFoundation.h: Removed the WK_ARRAY, WK_DICTIONARY, and WK_SET macros, which were only needed for pre-10.11 SDKs.
- Shared/mac/WebEventFactory.mm:
(WebKit::mouseButtonForEvent): Removed checking for pre-10.10.3 SDKs.
(WebKit::globalPointForEvent): Ditto.
(WebKit::pointForEvent): Ditto.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.
- UIProcess/API/Cocoa/WKBackForwardList.h: Replaced WK_ARRAY(...) with NSArray<...>.
- UIProcess/API/Cocoa/WKPreferences.mm: Ditto.
(-[WKPreferences _setFixedPitchFontFamily:]):
(+[WKPreferences _experimentalFeatures]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h: Ditto.
- UIProcess/API/Cocoa/WKUIDelegate.h: Ditto.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Ditto.
- UIProcess/API/Cocoa/WKUserContentController.h: Ditto.
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h: Ditto.
- UIProcess/API/Cocoa/WKUserScriptPrivate.h: Ditto.
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h: Replaced WK_SET(...) with NSSet<...>.
- UIProcess/API/Cocoa/WKWebsiteDataStore.h: Ditto.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm: Ditto.
(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: Ditto.
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: Replaced WK_ARRAY(...) with NSArray<...>.
- UIProcess/API/Cocoa/_WKUserStyleSheet.h: Ditto.
- UIProcess/API/Cocoa/_WKUserStyleSheet.mm: Ditto.
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):
- UIProcess/API/Cocoa/_WKWebsiteDataSize.h: Replaced WK_SET(...) with NSSet<...>.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::pressureChangeWithEvent): Removed checking for pre-10.10.3 SDKs.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Replaced WK_ARRAY(...) with NSArray<...>.
- mac/postprocess-framework-headers.sh: Removed sed rules for WK_ARRAY, WK_DICTIONARY and WK_SET.
- 1:59 PM Changeset in webkit [202757] by
-
- 5 edits in trunk/Source
[iOS] Possible null Range dereference under computeAutocorrectionContext()
https://bugs.webkit.org/show_bug.cgi?id=159328
<rdar://problem/26766720>
Reviewed by Benjamin Poulain.
Source/WebCore:
- editing/Editor.cpp:
(WebCore::Editor::compositionRange):
- editing/Editor.h:
Update to return a RefPtr instead of a PassRefPtr and use nullptr
instead of 0 in the implementation.
Source/WebKit2:
The code in computeAutocorrectionContext() was checking Editor::hasComposition()
before dereferencing Editor::compositionRange(). However, compositionRange()
can also return null in other cases (e.g. compositionStart == compositionEnd).
Drop the check for hasComposition() and do a null check on the value returned
by compositionRange() instead.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::computeAutocorrectionContext):
- 1:58 PM Changeset in webkit [202756] by
-
- 3 edits in trunk/Websites/webkit.org
Added a colorful new image and fixed the Open Graph attribute.
https://bugs.webkit.org/show_bug.cgi?id=159359
Reviewed by Timothy Hatcher.
The Open Graph image tag should use the property attribute not
the itemprop attribute.
- wp-content/plugins/social-meta.php:
- wp-content/themes/webkit/images/ogimage.png:
- 1:55 PM Changeset in webkit [202755] by
-
- 7 edits2 adds in trunk
defineGetter/defineSetter should throw exceptions
https://bugs.webkit.org/show_bug.cgi?id=142934
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.
Source/JavaScriptCore:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
LayoutTests:
- js/dom/dom-properties-are-configurable-expected.txt: Added.
- js/dom/dom-properties-are-configurable.html: Added.
- js/object-literal-duplicate-properties-expected.txt:
- js/property-getters-and-setters-expected.txt:
- js/script-tests/object-literal-duplicate-properties.js:
- js/script-tests/property-getters-and-setters.js:
- 1:52 PM Changeset in webkit [202754] by
-
- 2 edits in trunk/Source/WebKit2
Prevent crash when attempting to copy an image
https://bugs.webkit.org/show_bug.cgi?id=159288
<rdar://problem/23507828>
Reviewed by Brady Eidson.
WebKit could crash if the HTMLImageElement had a null cachedImage member.
A little investigation showed that the URL we retrieve from the cachedImage
is never used, so rather than adding a null check, let's just pass a
default argument. The actual URL gets read from elsewhere in the pasteboard
processing code.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performActionOnElement): Don't bother passing the
unused URL argument to the pasteboard method.
- 1:51 PM Changeset in webkit [202753] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore:
Moved Web Animations and Resource Timing feature entries to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=159356
Reviewed by Timothy Hatcher.
- features.json:
Source/WebCore:
Updated Picture element and WOFF 2 status
https://bugs.webkit.org/show_bug.cgi?id=159356
Reviewed by Timothy Hatcher.
Status updates and clean-up to move Web Animations and Resource Timing entries from JSC to WebCore.
- features.json:
- 1:49 PM Changeset in webkit [202752] by
-
- 5 edits3 adds in trunk
[JSC] Date.toGMTString should be the Date.toUTCString function
https://bugs.webkit.org/show_bug.cgi?id=159318
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.
Source/JavaScriptCore:
See https://tc39.github.io/ecma262/#sec-date.prototype.togmtstring
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToGMTString): Deleted.
LayoutTests:
- js/date-prototype-expected.txt: Added.
- js/date-prototype.html: Added.
- js/script-tests/date-prototype.js: Added.
- 1:46 PM Changeset in webkit [202751] by
-
- 2 edits in trunk/Source/WebCore
Add early return when processing content extensions if there aren't any.
<https://webkit.org/b/159363>
Reviewed by Antti Koivisto.
Short-circuit outta there if there aren't any extensions to query.
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
- 1:44 PM Changeset in webkit [202750] by
-
- 1 edit1 add2 deletes in trunk/LayoutTests
Rebaseline some MathML tests.
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/gtk/mathml/opentype/munderover-window-resize-expected.txt: Removed.
- platform/ios-simulator/mathml/presentation/roots-expected.png: Added.
- platform/mac/mathml/opentype/munderover-window-resize-expected.png: Removed.
- 1:31 PM Changeset in webkit [202749] by
-
- 4 edits in trunk/Source/WebCore
HTMLMediaElement::resume() may cause JavaScript execution
https://bugs.webkit.org/show_bug.cgi?id=159327
<rdar://problem/27131641>
Reviewed by Jer Noble.
HTMLMediaElement::updatePlayState can cause an element to begin playing and enter fullscreen,
which can result in a call to the media controls and JavaScript execution. Javascript is not
allowed allowed to run when a page resumes, so make the call to updatePlayState asynchronous.
No new tests, I wasn't able to create a test that triggers the crash.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleDelayedAction): Support UpdatePlayState.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Ditto.
(WebCore::HTMLMediaElement::setReadyState): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::playInternal): Don't call updateMediaController, it is called
by updatePlayState.
(WebCore::HTMLMediaElement::setMuted): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
(WebCore::HTMLMediaElement::mediaEngineWasUpdated): Update media state asynchronously.
(WebCore::HTMLMediaElement::updatePlayState): Add parameter to allow update to happen
asynchronously.
(WebCore::HTMLMediaElement::setPlaying): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::setPausedInternal): Update media state asynchronously.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::updateMediaState): UpdateMediaState -> UpdateState
- html/HTMLMediaElement.h:
- html/HTMLMediaElementEnums.h: Add UpdatePlayState.
- 12:41 PM Changeset in webkit [202748] by
-
- 26 edits8 adds9 deletes in trunk/LayoutTests
Update OS X and iOS expectations for some MathML pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=159339
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- mathml/opentype/fraction-line.html: Add a comment about font requirements.
- mathml/opentype/horizontal-munderover.html: Ditto.
- mathml/opentype/horizontal.html: Ditto.
- mathml/opentype/large-operators-italic-correction.html: Ditto.
- mathml/opentype/large-operators.html: Ditto.
- mathml/opentype/vertical.html: Ditto.
- mathml/presentation/attributes-mathvariant.html: Ditto.
- mathml/presentation/fractions-linethickness.html: Ditto.
- mathml/presentation/tokenElements-mathvariant.html: Ditto.
- mathml/radical-fallback.html: Ditto.
- platform/ios-simulator-wk1/TestExpectations: Update expectations.
- platform/ios-simulator-wk2/TestExpectations: Ditto.
- platform/ios-simulator-wk2/mathml/opentype/large-operators-expected.png: Removed.
- platform/ios-simulator-wk2/mathml/opentype/vertical-expected.png: Removed.
- platform/ios-simulator-wk2/mathml/presentation/mo-stretch-expected.png: Removed.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/mathml/opentype/horizontal-expected.txt: Removed.
- platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Removed.
- platform/ios-simulator/mathml/opentype/large-operators-expected.txt: Removed.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.png: Added.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.png: Added.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/ios-simulator/mathml/opentype/vertical-expected.txt: Removed.
- platform/ios-simulator/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
- platform/ios-simulator/mathml/presentation/menclose-notation-values-expected.png: Added.
- platform/ios-simulator/mathml/presentation/mo-stretch-expected.png: Added.
- platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt:
- platform/ios-simulator/mathml/presentation/mspace-children-expected.png: Added.
- platform/ios-simulator/mathml/radical-fallback-expected.png:
- platform/mac/TestExpectations: Update expectations.
- platform/mac/mathml/opentype/horizontal-expected.txt: Removed.
- platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Removed.
- platform/mac/mathml/opentype/large-operators-expected.txt: Removed.
- platform/mac/mathml/opentype/opentype-stretchy-expected.png: Added.
- platform/mac/mathml/opentype/vertical-expected.txt: Removed.
- platform/mac/mathml/presentation/menclose-notation-values-expected.png:
- platform/mac/mathml/presentation/menclose-notation-values-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mspace-children-expected.png: Added.
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/radical-fallback-expected.png:
- platform/mac/mathml/radical-fallback-expected.txt:
- 12:10 PM Changeset in webkit [202747] by
-
- 16 edits5 adds in trunk
Blob content type not preserved when retrieving blobs from IndexedDB.
<rdar://problem/27057357> and https://bugs.webkit.org/show_bug.cgi?id=159360
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/blob-svg-image.html
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::postToMainThread):
(WebCore::ThreadableBlobRegistry::registerBlobURLOptionallyFileBacked): Pass along the content type
to the blob registry so that if the file-backed blob takes over, it has the content type.
(WebCore::threadableQueue): Deleted.
- fileapi/ThreadableBlobRegistry.h:
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):
- platform/network/BlobRegistryImpl.h:
Source/WebKit2:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURLOptionallyFileBacked):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked):
- WebProcess/FileAPI/BlobRegistryProxy.h:
LayoutTests:
- storage/indexeddb/modern/blob-svg-image-expected.txt: Added.
- storage/indexeddb/modern/blob-svg-image.html: Added.
- storage/indexeddb/modern/resources/blob-svg-image.js: Added.
- storage/indexeddb/modern/resources/blob-svg-image1.html: Added.
- storage/indexeddb/modern/resources/blob-svg-image2.html: Added.
- 12:07 PM Changeset in webkit [202746] by
-
- 6 edits in trunk/Source/WebKit2
[Cocoa] Get rid of WK_NULLABLE_SPECIFIER now that all supported compilers understand _Nullable
https://bugs.webkit.org/show_bug.cgi?id=159361
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKFoundation.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKWebView.h:
- mac/postprocess-framework-headers.sh:
- 11:36 AM Changeset in webkit [202745] by
-
- 1 delete in tags/Safari-602.1.38.2.100
Delete tag.
- 11:08 AM Changeset in webkit [202744] by
-
- 2 edits in trunk/Source/WebKit/win
ASSERTION FAILED: info.bmBitsPixel == 32
https://bugs.webkit.org/show_bug.cgi?id=17737
Reviewed by Brent Fulgham.
The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
This happens when this method is called indirectly from WebView::updateBackingStore during normal
painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
selected into the device context by default. We can just scroll by repainting the scroll rectangle.
- WebView.cpp:
(WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.
- 10:08 AM Changeset in webkit [202743] by
-
- 9 edits in trunk/Tools
Simplify LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=159353
Reviewed by Daniel Bates.
- Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
by name and runtime makes no sense.
- Removed code to create devices, webkitpy always does this in advance.
- Don't create copies of testing apps - we can install the same one into
each simulator, now that we don't run multiple tester processes in a single simulator.
- Pass information on how to find I/O pipes via environment, not via Info.plist.
- Removed code that kept testing apps alive in the background.
- Slightly updated coding style in functions that I touched.
- LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
Updated for what we acually use at this point.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
(-[LTRelayController ipcIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController didReceiveStdoutData:]):
(-[LTRelayController didCrashWithMessage:]):
(-[LTRelayController installApp]):
(-[LTRelayController _environmentVariables]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
(-[LTRelayController uniqueAppPath]): Deleted.
(-[LTRelayController uniqueAppURL]): Deleted.
(-[LTRelayController uniqueAppIdentifier]): Deleted.
(-[LTRelayController createUniqueApp]): Deleted.
- LayoutTestRelay/LayoutTestRelay/main.m:
(usage):
(getRequiredStringArgument):
(main):
(getTestingSimDevice): Deleted.
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver.cmd_line):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformInitialize):
- WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp applicationDidEnterBackground:]):
- DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):
(-[DumpRenderTree applicationDidEnterBackground:]):
- 10:06 AM Changeset in webkit [202742] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Make enabling protocol logging in inspector tests easy to remember
https://bugs.webkit.org/show_bug.cgi?id=159323
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.
Now you just need to type InspectorTest.debug() or
ProtocolTest.debug() and it will include stderr logging.
- UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness.prototype.debug):
- UserInterface/Test/ProtocolTestHarness.js:
(ProtocolTestHarness.prototype.debug):
(ProtocolTestHarness):
- UserInterface/Test/TestHarness.js:
(TestHarness.prototype.debug):
- 10:03 AM Changeset in webkit [202741] by
-
- 6 edits in trunk/Source/WebCore
Make ResourceLoaderOptions derive from FetchOptions
https://bugs.webkit.org/show_bug.cgi?id=159345
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-01
Reviewed by Alex Christensen.
No change of behavior.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight):
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::fetchOptions): Deleted.
(WebCore::ResourceLoaderOptions::setFetchOptions): Deleted.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
- loader/ThreadableLoader.h: Removing securityOrigin field (left over from https://bugs.webkit.org/show_bug.cgi?id=159221)
- 10:00 AM Changeset in webkit [202740] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Cleanup inspector/console/console-message.html
https://bugs.webkit.org/show_bug.cgi?id=159324
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.
- inspector/console/console-message.html:
- 9:43 AM Changeset in webkit [202739] by
-
- 2 edits in trunk/Tools
[cmake] Build TestNetscapePlugin only if NPAPI is enabled.
https://bugs.webkit.org/show_bug.cgi?id=159344
Reviewed by Alex Christensen.
- DumpRenderTree/CMakeLists.txt:
- 9:39 AM Changeset in webkit [202738] by
-
- 2 edits in trunk/Source/WebCore
[Win] Animations tests are crashing in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=159335
Reviewed by Alex Christensen.
A MSVC runtime check fails because an uninitialized variable is being used.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::keyframeStylesForAnimation):
- 9:38 AM Changeset in webkit [202737] by
-
- 7 edits3 adds in trunk/Source/JavaScriptCore
Update JSC_functionOverrides to handle the new SourceCode strings that have params.
https://bugs.webkit.org/show_bug.cgi?id=159321
Reviewed by Geoffrey Garen.
And add tests so that this won't fail silently and bit rot anymore.
- API/tests/FunctionOverridesTest.cpp: Added.
(testFunctionOverrides):
- API/tests/FunctionOverridesTest.h: Added.
- API/tests/testapi-function-overrides.js: Added.
- API/tests/testapi.c:
(main):
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::link):
- shell/PlatformWin.cmake:
- tools/FunctionOverrides.cpp:
(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::initializeOverrideInfo):
(JSC::FunctionOverrides::initializeOverrideFor):
- tools/FunctionOverrides.h:
(JSC::FunctionOverrides::clear):
- 8:40 AM Changeset in webkit [202736] by
-
- 2 edits in trunk/Source/WTF
Deadlock inside -[WebCoreNSURLSession dealloc]
https://bugs.webkit.org/show_bug.cgi?id=159331
<rdar://problem/27122716>
Reviewed by Alex Christensen.
A Function<> object can wrap any callable type, including a C++ lambda.
dispatchFunctionsFromMainThread() holds a lock while iterating over the functions in
functionQueue(), and during ths iteration, the previous callable object is destroyed by
assigning the result of functionQueue().takeFirst(). Because lambdas (and other callables,
like functors) can own objects, destroying this callable can have side effects, and if one
of those side effects is to call callOnMainThread(), this can deadlock.
Move this side-effect-having call outside the locked block by clearing the function object
immediately after calling it.
- wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
- 8:29 AM Changeset in webkit [202735] by
-
- 2 edits in trunk
[cmake] Make LEGACY_WEB_AUDIO depend on WEB_AUDIO.
https://bugs.webkit.org/show_bug.cgi?id=159338
Reviewed by Michael Catanzaro.
Enabling LEGACY_WEB_AUDIO makes no sense when WEB_AUDIO is
disabled.
- Source/cmake/WebKitFeatures.cmake:
- 8:25 AM Changeset in webkit [202734] by
-
- 4 edits4 adds in trunk/Source/JavaScriptCore
ES6: Implement HasRestrictedGlobalProperty when checking for global lexical tier conflicts
https://bugs.webkit.org/show_bug.cgi?id=148763
Patch by Caio Lima <Caio Lima> on 2016-07-01
Reviewed by Saam Barati
I've implemented the ES6 spec 8.1.1.4.14
(http://www.ecma-international.org/ecma-262/6.0/index.html#sec-hasrestrictedglobalproperty)
that defines when a global property can be shadowed.
Added some test cases into global-lexical-redeclare-variable.js
- runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
- tests/stress/global-lexical-redeclare-variable.js:
(catch):
- tests/stress/multiple-files-tests/global-lexical-redeclare-variable/eighth.js: Added.
- tests/stress/multiple-files-tests/global-lexical-redeclare-variable/nineth.js: Added.
- tests/stress/multiple-files-tests/global-lexical-redeclare-variable/seventh.js: Added.
- tests/stress/multiple-files-tests/global-lexical-redeclare-variable/sixth.js:
- tests/stress/multiple-files-tests/global-lexical-redeclare-variable/tenth.js: Added.
- 5:46 AM Changeset in webkit [202733] by
-
- 3 edits in trunk/LayoutTests
Rebaseline opentype-stretchy-horizontal.html for EFL.
https://bugs.webkit.org/show_bug.cgi?id=135561
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/efl/TestExpectations:
- platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- 5:36 AM Changeset in webkit [202732] by
-
- 2 edits1 add in trunk/LayoutTests
Regenerate EFL expectation for foreign-element-in-token.html
https://bugs.webkit.org/show_bug.cgi?id=133972
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/efl/TestExpectations:
- platform/efl/mathml/presentation/foreign-element-in-token-expected.txt: Added.
- 5:07 AM Changeset in webkit [202731] by
-
- 4 edits in trunk/LayoutTests
Fix warnings about non existent paths in TestExpectations
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 5:07 AM QtWebKitSecurity edited by
- qtwebkit-announce mailing list does not exist anymore (diff)
- 5:01 AM QtWebKitReleases edited by
- qtwebkit-announce mailing list does not exist anymore (diff)
- 4:48 AM Acronyms edited by
- Remove GYP and KURL (diff)
- 4:47 AM Acronyms edited by
- Added definition for DFG and cross-reference for JSC (diff)
- 4:16 AM Acronyms edited by
- (diff)
- 3:53 AM LayoutTestDashboards edited by
- NWRT has superceded old run-webkit-tests (diff)
- 3:52 AM Writing Reftests edited by
- NWRT has superceded old run-webkit-tests (diff)
- 3:30 AM Changeset in webkit [202730] by
-
- 2 edits in trunk/LayoutTests
Fix error in r202729
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/ios-simulator/TestExpectations: Revert unintentional change of horizontal-munderover.
- 2:52 AM Changeset in webkit [202729] by
-
- 4 edits in trunk/LayoutTests
Reorganize and improve comments for MathML test expectations on ios and mac.
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 12:47 AM Changeset in webkit [202728] by
-
- 35 edits in trunk
Add a runtime flag for DOM iterators
https://bugs.webkit.org/show_bug.cgi?id=159300
Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-01
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
Source/WebCore:
- Modules/fetch/FetchHeaders.idl: Making iterator runtime-enabled.
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDOMIteratorEnabled):
(WebCore::RuntimeEnabledFeatures::domIteratorEnabled):
- bindings/scripts/CodeGeneratorJS.pm:
(ToMethodName): Fixing dOM -> dom casing issue.
(GenerateImplementation): Using addIterableProperties new method.
(addIterableProperties): Activating property addition according runtime flag if iterator is rnutime flagged.
- bindings/scripts/IDLParser.pm:
(parseOptionalIterableInterface): Adding extendedAttributes to iterable.
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
- bindings/scripts/test/TestNode.idl: Making iterator runtime-enabled.
- bindings/scripts/test/TestObj.idl: Ditto.
- css/FontFaceSet.idl: Ditto.
- dom/NodeList.idl: Ditto.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences DOMIteratorEnabled]):
(-[WebPreferences setDOMIteratorEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::domIteratorEnabled):
(WebPreferences::setDOMIteratorEnabled):
(WebView::notifyPreferencesChanged):
- WebPreferencesreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setDOMIteratorEnabled):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- 12:29 AM Changeset in webkit [202727] by
-
- 25 edits in trunk/Source/WebCore
Eliminate trailing whitespace in MathML code
https://bugs.webkit.org/show_bug.cgi?id=159091
Patch by Frederic Wang <fwang.igalia.com> on 2016-07-01
Reviewed by Alex Christensen.
No new tests, behavior is unchanged.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::baselinePosition):
(WebCore::RenderMathMLBlock::paint):
(WebCore::parseMathMLNamedSpace):
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::styleDidChange):
(WebCore::RenderMathMLFraction::paint):
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLMenclose.h:
- rendering/mathml/RenderMathMLOperator.cpp:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
- rendering/mathml/RenderMathMLScripts.cpp:
- rendering/mathml/RenderMathMLSpace.cpp:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLToken.h:
- rendering/mathml/RenderMathMLUnderOver.cpp:
- rendering/mathml/RenderMathMLUnderOver.h:
- 12:06 AM Changeset in webkit [202726] by
-
- 2 edits in trunk/Source/WebCore
Small cleanup: Remove unused functions RenderObject::isRenderMathML*Wrapper
https://bugs.webkit.org/show_bug.cgi?id=159333
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
Reviewed by Alex Christensen.
After the refactoring of RenderMathMLRoot and RenderMathMLScripts, the anonymous flexbox
wrappers used in the old layout implementation have been removed. We thus remove the
corresponding isRender* function from RenderObject.
No new tests, behavior is unchanged.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMathMLRootWrapper): Deleted.
(WebCore::RenderObject::isRenderMathMLScriptsWrapper): Deleted.
Jun 30, 2016:
- 11:58 PM Changeset in webkit [202725] by
-
- 10 edits in trunk/Source
[Mac] Get rid of the old timey rubber-banding linen pattern.
<https://webkit.org/b/159329>
Reviewed by Benjamin Poulain.
Source/WebCore:
Remove the "ScrollingOverhang" custom GraphicsLayer appearance since that was only used to
install the old timey linen pattern behind the web content.
We now always just set the overhang area's background color to the document background color.
This fixes an issue where we could end up loading the linen pattern and keeping it in memory
despite never actually showing it on screen.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents): Deleted.
- platform/graphics/GraphicsLayer.cpp:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::updateCustomAppearance):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::linenBackgroundColor): Deleted.
(WebCore::ScrollbarThemeMac::setUpOverhangAreaBackground): Deleted.
(WebCore::ScrollbarThemeMac::removeOverhangAreaBackground): Deleted.
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents): Deleted.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::setRootExtendedBackgroundColor):
Source/WebKit2:
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::updateCustomAppearance):
- 10:23 PM Changeset in webkit [202724] by
-
- 5 edits1 add in trunk
Source/WebKit2:
Add SPI to allow restoring session state without navigation in WKPage
https://bugs.webkit.org/show_bug.cgi?id=159326
Patch by Tina Liu <iting_liu@apple.com> on 2016-06-30
Reviewed by Brady Eidson.
- UIProcess/API/C/WKPage.cpp:
(restoreFromSessionState):
Added a helper function that takes a bool parameter to specify whether
to navigate or not when restoring from the session state.
(WKPageRestoreFromSessionState):
Calling restoreFromSessionState, passing navigate = true.
(WKPageRestoreFromSessionStateWithoutNavigation):
Ditto but passing navigate = false.
- UIProcess/API/C/WKPagePrivate.h:
Tools:
Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
https://bugs.webkit.org/show_bug.cgi?id=159326
Patch by Tina Liu <iting_liu@apple.com> on 2016-06-30
Reviewed by Brady Eidson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeBackForwardListForPage):
(TestWebKitAPI::setPageLoaderClient):
Set the page loader client and register for didFinishLoadForFrame and
didChangeBackForwardList callbacks.
(TestWebKitAPI::createSessionStateData):
Load a webpage ("simple.html") and return the session state for this page.
(TestWebKitAPI::TEST):
Restore the page session state with that of "simple.html" without navigation.
Verify that the committed URL is NULL since there's no navigation involved.
Verify that the current item in the back forward list, which should be what
we restored from the session state, has the expected URL.
- 6:29 PM Changeset in webkit [202723] by
-
- 12 edits in trunk/Source
[iOS] WebContent processes do not exit promptly
https://bugs.webkit.org/show_bug.cgi?id=159301
<rdar://problem/26965488>
Reviewed by Anders Carlsson.
WebContent processes do not exit promptly, they hang around for 10 seconds
until the watchdog forcefully calls exit().
This patch addresses the issue by asking XPC to exit when clean. It also
fixes 2 XPC transactions that were leaking so that XPC can become clean.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:
(DatabaseServiceInitializer):
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(NetworkServiceInitializer):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Add extra priorityBoostMessage parameter which is then passed along to
ChildProcess via initialization parameters. ChildProcess is now in
charge of retaining the message for as long as it needs the priority
boost. In particular, ChildProcess now takes care of releasing the
boost message before existing to avoid leaking an XPC transaction.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
Retain priorityBoostMessage as a data member.
(WebKit::ChildProcess::stopRunLoop):
(WebKit::ChildProcess::platformStopRunLoop):
- Shared/ios/ChildProcessIOS.mm:
(WebKit::ChildProcess::platformStopRunLoop):
On iOS, call XPCServiceExit() to exit instead of RunLoop::main().stop()
which did not work.
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
Set priorityBoostMessage on ChildProcessInitializationParameters.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceExit):
Add XPCServiceExit() function which destroys the priority boost
message, calls xpc_transaction_end() to balance the
xpc_transaction_begin() in XPCServiceInitializer() and then call
xpc_transaction_exit_clean() to ask XPC to exit when clean.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
Leaking the "pre-bootstrap" event for priority boosting would cause us to
leak an XPC transaction, which would prevent XPC from becoming clean and
exiting. Instead, we now pass it along to the initialization function.
We then pass it to ChildProcess which manages the lifetime of this message
instead of leaking it.
- 5:13 PM Changeset in webkit [202722] by
-
- 2 edits in trunk/Source/WebInspectorUI
Unreviewed build fix.
- Localizations/en.lproj/localizedStrings.js:
Add "Area" localized string.
- 5:13 PM Changeset in webkit [202721] by
-
- 1 copy in tags/Safari-602.1.38.4
New tag.
- 5:07 PM Changeset in webkit [202720] by
-
- 2 edits in trunk/LayoutTests
Skipping flaky inspector/debugger/break-on-* tests
https://bugs.webkit.org/show_bug.cgi?id=159272
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:03 PM Changeset in webkit [202719] by
-
- 5 edits in trunk/Source
Create a generic "linked-on-or-after" check for new CSP Rules
https://bugs.webkit.org/show_bug.cgi?id=159322
<rdar://problem/27117220>
Reviewed by Brent Fulgham.
Source/WebCore:
Create a generic "linked-on-or-after" check for new CSP Rules and cleanup
quirks for Ecobee, Quora and XtraMat.
- platform/RuntimeApplicationChecks.h:
- platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isEcobee): Deleted.
(WebCore::IOSApplication::isQuora): Deleted.
(WebCore::IOSApplication::isXtraMath): Deleted.
Source/WebKit/mac:
- WebView/WebView.mm:
(shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
- 4:48 PM Changeset in webkit [202718] by
-
- 3 edits in trunk/LayoutTests
Moving flaky expectation for inspector/codemirror/prettyprinting-css-rules.html from mac-wk1 to mac.
https://bugs.webkit.org/show_bug.cgi?id=153460
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 4:24 PM Changeset in webkit [202717] by
-
- 24 edits4 adds in trunk
Web Inspector: Wrong function name next to scope
https://bugs.webkit.org/show_bug.cgi?id=158210
<rdar://problem/26543093>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-30
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
Add DebuggerLocation. A helper for describing a unique location.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantRegisters):
When compiled with debug info, add a SymbolTable rare data pointer
back to the CodeBlock. This will be used later to get JSScope debug
info if Web Inspector pauses.
- runtime/SymbolTable.h:
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::cloneScopePart):
(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForOffset):
(JSC::SymbolTable::globalTypeSetForOffset):
(JSC::SymbolTable::globalTypeSetForVariable):
Rename rareData and include a CodeBlock pointer.
(JSC::SymbolTable::rareDataCodeBlock):
(JSC::SymbolTable::setRareDataCodeBlock):
Setter and getter for the rare data. It should only be set once.
(JSC::SymbolTable::visitChildren):
Visit the rare data code block if we have one.
- runtime/JSSymbolTableObject.h:
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
Give JSSymbolTable its own class info. JSWithScope was unexpectedly
inheriting from JSSymbolTable since it did not have its own and
was using JSScope's class info. Also do a bit of cleanup.
- debugger/DebuggerLocation.cpp: Added.
(JSC::DebuggerLocation::DebuggerLocation):
- debugger/DebuggerLocation.h: Added.
(JSC::DebuggerLocation::DebuggerLocation):
Construction from a ScriptExecutable.
- runtime/JSScope.cpp:
(JSC::JSScope::symbolTable):
- runtime/JSScope.h:
- debugger/DebuggerScope.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::name):
(JSC::DebuggerScope::location):
Name and location for a scope. This uses:
JSScope -> SymbolTable -> CodeBlock -> Executable
- inspector/protocol/Debugger.json:
- inspector/InjectedScriptSource.js:
(InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
(InjectedScript.CallFrameProxy._createScopeJson):
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::valueForScopeType):
(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):
(Inspector::JSJavaScriptCallFrame::scopeType): Deleted.
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType): Deleted.
Simplify this code to build the objects we will send across the protocol
to descript a Scope.
Source/WebInspectorUI:
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
Include new payload data in the construction call.
All the new data is optional, so we gracefully handle
legacy backends.
- UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get type):
(WebInspector.ScopeChainNode.prototype.get objects):
(WebInspector.ScopeChainNode.prototype.get name):
(WebInspector.ScopeChainNode.prototype.get location):
(WebInspector.ScopeChainNode.prototype.get hash):
Hash is a rough (name:sourceId:line:column) string for quick comparisons.
(WebInspector.ScopeChainNode.prototype.makeLocalScope):
Make this an action you take on a scope, to avoid having to
do it at construction time, or making it a generic setting.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
This was wrong before. Move the work to CallFrame
and change it to be correct.
- UserInterface/CallFrame.js:
(WebInspector.CallFrame.prototype.mergedScopeChain):
This transforms the scope chain for a call frame from:
scope1 scope2 scope3 scope4 scope5 scope6 scope7
foo foo foo bar bar - -
Block Closure Closure Closure Closure GLE GBL
To:
scope1 scope2&3 scope4&5 scope6 scope7
foo foo* bar* - -
Block Local Closure GLE GBL
Doing a few things:
- Merge the first two Closure scopes sharing a location. These are the "var" and "let" Closure scopes in a function, and it is better to present these together in the UI.
- Mark the first Closure scope within a function (*). When this is displayed in the UI, we can provide the name of the function: "Closure Scope (name)", and we even have location information that we can use to display a goto arrow if needed.
- Make the first Closure scope the Local scope if it matches the Call Frame's function name. This lets us display the section as "Local Variables".
LayoutTests:
- inspector/debugger/paused-scopes-expected.txt: Added.
- inspector/debugger/paused-scopes.html: Added.
- inspector/debugger/resources/paused-scopes.js: Added.
Test dumps the call frames and scope chains for each call frame
when pausing at different locations in a program. Outputting
the hashes we can see even identically named functions have
different hashes because their location is different.
- inspector/model/scope-chain-node.html:
Make the test more stable on debug builds which run slower.
- 4:12 PM Changeset in webkit [202716] by
-
- 2 edits in trunk/Source/WebCore
WebContent crash due to RELEASE_ASSERT(!m_inLoadPendingImages) in StyleResolver::~StyleResolver()
https://bugs.webkit.org/show_bug.cgi?id=159307
<rdar://problem/26184868>
Reviewed by Andreas Kling.
Pseudo elements are resolved in RenderTreeUpdater (instead of Style::TreeResolver). Their resolution may trigger
resource loads which can cause synchronous layout (when failing synchronously) and lead to destruction of the
the style resolver in post layout task.
No known reliable way to test this.
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):
Use PostResolutionCallbackDisabler in RenderTreeUpdater similarly to Style::TreeResolver. This prevents
post layout tasks from running synchronously and closes this particular crash path.
- 3:54 PM Changeset in webkit [202715] by
-
- 1 copy in tags/Safari-601.7.6
New tag.
- 3:35 PM Changeset in webkit [202714] by
-
- 2 edits in trunk/Source/JavaScriptCore
missing exception checks in arrayProtoFuncReverse
https://bugs.webkit.org/show_bug.cgi?id=159319
<rdar://problem/27083696>
Reviewed by Filip Pizlo.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncReverse):
- 3:29 PM Changeset in webkit [202713] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add pixel area column to layout timeline view
https://bugs.webkit.org/show_bug.cgi?id=148677
<rdar://problem/22518762>
Reviewed by Timothy Hatcher.
The view can simply add the column. LayoutTimelineDataGridNode
already includes area data and cell formatting.
- UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView):
- 3:18 PM Changeset in webkit [202712] by
-
- 3 edits8 adds in trunk
Drawing an SVG image into a <canvas> that is not in the DOM draws the wrong region
https://bugs.webkit.org/show_bug.cgi?id=159276
Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Dean Jackson.
Source/WebCore:
In the event where the <img> element that we are passing to CanvasRenderingContext2D.drawImage()
points to an SVG resource, we ensure that the container for the SVG image is sized to match the
HTML element. The necessity for setting this container size, explained in webkit.org/b/148845,
is that we must ensure a cached image does not have an outdated container size.
Tests: svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html
svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
LayoutTests:
Adding a series of new tests to check we correctly respect mismatching source and
destination rectangles with SVG images as sources, both with the source <img> element
being present and absent from the DOM, and explicit sizes being set or not set.
- svg/as-image/img-with-svg-resource-in-dom-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html: Added.
- 3:14 PM Changeset in webkit [202711] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: the last normal tab cannot be closed with "Close Tab" context menu item
https://bugs.webkit.org/show_bug.cgi?id=159317
<rdar://problem/27042491>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TabBarItem.js:
(WebInspector.TabBarItem.prototype._handleContextMenuEvent):
(WebInspector.TabBarItem): fix the expression that controls whether the item is disabled.
- 3:06 PM Changeset in webkit [202710] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
get_by_id_with_this does not trigger a to_this in caller.
https://bugs.webkit.org/show_bug.cgi?id=159226
Reviewed by Keith Miller.
This is a bug if the caller is in sloppy mode and the callee is in strict
mode. This can't happen with ES6 classes because they're all in strict mode,
but it can happen with method syntax on an object literal. The caller must
to_this on |this| when it knows that it performs super property accesses.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- tests/stress/super-property-access-object-literal-to-this-2.js: Added.
(assert):
(test):
(let.o1.get foo):
(let.o2.a):
(let.o2.aa):
- tests/stress/super-property-access-object-literal-to-this.js: Added.
(assert):
(test):
(let.o1.get foo):
(let.o2.a):
(let.o2.aa):
(let.o2.b):
(let.o2.bb):
- tests/stress/super-property-access-to-this.js: Added.
(assert):
(test):
(Base.prototype.get foo):
(Base):
(Child.prototype.a):
(Child.prototype.b):
(Child):
- 2:50 PM Changeset in webkit [202709] by
-
- 2 edits in trunk/Websites/webkit.org
Tab pointed out a typo that made the overdamped case fail.
- demos/spring/spring.js:
(SpringSolver.prototype.solve):
- 2:29 PM Changeset in webkit [202708] by
-
- 5 edits in tags/Safari-602.1.38.2.2/Source
Versioning.
- 2:28 PM Changeset in webkit [202707] by
-
- 1 copy in tags/Safari-602.1.38.2.2
New tag.
- 2:23 PM Changeset in webkit [202706] by
-
- 5 edits in tags/Safari-602.1.38.2.100/Source
Versioning.
- 2:22 PM Changeset in webkit [202705] by
-
- 1 copy in tags/Safari-602.1.38.2.100
New tag.
- 2:20 PM Changeset in webkit [202704] by
-
- 3 edits in trunk/Source/WebCore
getUserMedia() exposed, but not functional
https://bugs.webkit.org/show_bug.cgi?id=158393
<rdar://problem/26642259>
Reviewed by Dean Jackson.
Set default value of the Media Stream runtime flag to false on Mac OS X and iOS until the
browser support is in place.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Disable media stream by default
on Mac OS X and iOS.
- bindings/generic/RuntimeEnabledFeatures.h:
- 2:20 PM Changeset in webkit [202703] by
-
- 1 delete in tags/Safari-602.1.38.2.100
Delete tag.
- 2:19 PM Changeset in webkit [202702] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add "spring" to transition-timing-function value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=159313
<rdar://problem/27114269>
Reviewed by Timothy Hatcher.
- UserInterface/Models/CSSKeywordCompletions.js:
- 2:18 PM Changeset in webkit [202701] by
-
- 1 copy in tags/Safari-602.1.38.2.100
New tag.
- 2:17 PM Changeset in webkit [202700] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r202329): WebInspectorProxy's WKPagePolicyClient callbacks are not being called
https://bugs.webkit.org/show_bug.cgi?id=159308
<rdar://problem/27111764>
Reviewed by Tim Horton.
Adopt WKPageNavigationClient and ditch WKPolicyClient and WKPageLoaderClient.
After r202329, it's not possible to set a WKPolicyClient for a WKPage/WebPageProxy that backs a WKWebView.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainOrTestInspectorPage): Take a WebCore::ResourceRequest.
(WebKit::processDidCrash): Deleted.
(WebKit::webProcessDidCrash): Rename to match new client callback name.
(WebKit::decidePolicyForNavigationAction): Rework this to take new argument types.
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
Install a WKPageNavigationClient.
- 1:51 PM Changeset in webkit [202699] by
-
- 5 edits in branches/safari-602.1.38-branch/Source
Versioning.
- 1:44 PM Changeset in webkit [202698] by
-
- 18 edits in trunk/Source/WebCore
Unreviewed, rolling out r202676.
https://bugs.webkit.org/show_bug.cgi?id=159314
This change caused storage/websql tests to crash on Mac and
iOS WK1 (Requested by ryanhaddad on #webkit).
Reverted changeset:
"Purge PassRefPtr in Modules/webdatabase"
https://bugs.webkit.org/show_bug.cgi?id=159255
http://trac.webkit.org/changeset/202676
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-30
- 1:29 PM Changeset in webkit [202697] by
-
- 2 edits in trunk/Websites/webkit.org
Fixed a typo in the link to the other version.
- blog-files/color-gamut/index.html:
- 1:17 PM Changeset in webkit [202696] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Process suspension is prevented for 30 seconds after closing a tab
https://bugs.webkit.org/show_bug.cgi?id=159280
<rdar://problem/27014867>
Reviewed by Gavin Barraclough.
When closing a tab, ConnectionTerminationWatchdog takes a background
assertion on behalf of the WebContent process and only releases it
after 30 seconds, allowing for the WebContent process to exit cleanly
without worrying about getting suspended too early.
However, the child process normally exits much sooner than this and
we end up holding a process assertion for no reason for a full 30
seconds anyway. This patch addresses the issue by registering an
invalidation handler with the BKSProcessAssertion and releasing our
our assertion in such case. The invalidation handler gets called
as soon as the child process exits.
- Platform/spi/ios/AssertionServicesSPI.h:
- UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::ProcessAssertion):
- UIProcess/ProcessAssertion.h:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::validity):
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAssertion::setState): Deleted.
- 12:15 PM Changeset in webkit [202695] by
-
- 4 edits in trunk/Source/WebKit2
Keep track of when a WKWebView is blank before the initial non-empty layout
https://bugs.webkit.org/show_bug.cgi?id=159217
<rdar://problem/26071766>
Reviewed by Beth Dakin.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]):
(-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
- 12:10 PM Changeset in webkit [202694] by
-
- 10 edits2 adds in trunk
[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>
Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Eric Carlson.
Source/WebCore:
In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.
In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.
As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.
Test: media/video-controls-drop-and-restore-timeline.html
- Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):
- Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsiOS.js:
LayoutTests:
Adjust the output of a couple of tests to account for the time label clones, ensure the video
is wide enough to always have its timeline visible for tests that rely on the timeline being
visible to drag and seek, and finally add a new test.
- media/controls-drag-timebar.html:
- media/media-controls-drag-timeline-set-controls-property.html:
- media/video-controls-drop-and-restore-timeline-expected.txt: Added.
- media/video-controls-drop-and-restore-timeline.html: Added.
- platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
- platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
- 11:46 AM Changeset in webkit [202693] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
We need to to_this when an inner arrow function uses 'this'
https://bugs.webkit.org/show_bug.cgi?id=159290
<rdar://problem/27058322>
Reviewed by Geoffrey Garen.
We put the |this| value into the closure object when there
is an arrow function that uses |this|. However, an arrow function
using |this| wasn't causing the creator of the closure that
holds |this| to to_this its value before putting it in the
closure. That's a huge bug because it means some arrow functions
can capture the raw |this| value, which might be a JSLexicalEnvironment.
This patch fixes this by adding an easy to check to see if any
inner arrow functions use |this|, and if any do, it will to_this
the |this| value.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- tests/stress/to-this-before-arrow-function-closes-over-this-that-starts-as-lexical-environment.js: Added.
(assert):
(obj):
(foo.capture):
(foo.wrapper.let.x.):
(foo2.capture):
(foo2.wrapper.let.x.):
(foo2.wrapper.bar):
- 11:19 AM Changeset in webkit [202692] by
-
- 2 edits in trunk/LayoutTests
Removing duplicated line from Mac TestExpectations file.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:18 AM Changeset in webkit [202691] by
-
- 2 edits in tags/Safari-602.1.39/Source/WebKit/mac
Merged r202685. rdar://problem/27092107
- 11:15 AM Changeset in webkit [202690] by
-
- 3 edits in trunk/Source/WebKit2
Cleanup ProcessAssertion RunInBackground management
https://bugs.webkit.org/show_bug.cgi?id=159284
Reviewed by Chris Dumez.
Factor out code that handles taking a background assertion on the UI app into
ProcessAndUIAssertion::updateRunInBackgroundCount helper.
This patch just cleanup to enable a futher fix.
- UIProcess/ProcessAssertion.h:
(WebKit::ProcessAssertion::state):
- Added ProcessAndUIAssertion::updateRunInBackgroundCount
- Added ProcessAndUIAssertion::m_isHoldingBackgroundAssertionOnApp
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):
- helper to manage calls to incrementNeedsToRunInBackgroundCount/decrementNeedsToRunInBackgroundCount
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
- call updateRunInBackgroundCount
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
changed to use m_isHoldingBackgroundAssertionOnApp
(WebKit::ProcessAndUIAssertion::setState):
- call updateRunInBackgroundCount
- 11:13 AM Changeset in webkit [202689] by
-
- 10 edits2 adds in trunk
Generators violate bytecode liveness validation
https://bugs.webkit.org/show_bug.cgi?id=159279
Reviewed by Yusuke Suzuki.
PerformanceTests:
Add Basic to our test harness.
Also made some cosmetic changes to the benchmark harness.
- ES6SampleBench/Basic/basic-tests.yaml: Added.
- ES6SampleBench/Basic/stress-test.js: Added.
(preciseTime):
- ES6SampleBench/driver.js:
(Driver):
(Driver.prototype.start):
(Driver.prototype.reportError):
- ES6SampleBench/glue.js:
- ES6SampleBench/index.html:
Source/JavaScriptCore:
Fix a liveness bug found by Basic. The problem is that resume's intended liveness rule is:
"live-in is just the token argument", but the liveness analysis thought that the rule was
"live-in is live-out minus defs plus live-at-catch". Clearly these two rules are quite
different. The way this sort of worked before is that we would define the defs of resume
as being equal to our prediction of what the live-outs would be. We did this in the hope
that we would subtract all live-outs. But, this misses the live-at-catch part. So, this
change adds another hack to neutralize live-at-catch.
This would make a lot more sense if we wrote a new liveness analysis that was just for
generator conversion. It could reuse BytecodeUseDef but otherwise it would be a new thing.
It would be easy to write crazy rules for save/resume in such an analysis, especially if
that analysis rewrote the bytecode. We could then just have an op_yield that is a no-op.
We would just record the live-outs of op_yield and use that for rewriting the code in terms
of a switch statement.
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::stepOverInstruction):
(JSC::BytecodeLivenessAnalysis::dumpResults):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
Tools:
Add Basic to our test harness.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- 11:06 AM Changeset in webkit [202688] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the macOS Sierra Release configuration after r202642.
- platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
Add missing UNUSED_PARAM for when logging is not enabled.
- 10:49 AM Changeset in webkit [202687] by
-
- 2 edits in trunk/LayoutTests
Marking fast/shrink-wrap/rect-shrink-wrap.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=159275
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 10:48 AM Changeset in webkit [202686] by
-
- 2 edits in trunk/Tools
[Win][Debug] Assertion fails in TestWTF.
https://bugs.webkit.org/show_bug.cgi?id=159299
Reviewed by Alex Christensen.
The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
the assertion failure. Since the variable is actually used, there is no need to use the
UNUSED_PARAM macro.
- TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
(TestWebKitAPI::TEST):
- 10:47 AM Changeset in webkit [202685] by
-
- 2 edits in trunk/Source/WebKit/mac
Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
https://bugs.webkit.org/show_bug.cgi?id=159306
rdar://problem/27092107
Reviewed by Tim Horton.
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove an unneeded #import.
- 10:31 AM Changeset in webkit [202684] by
-
- 21 edits5 deletes in trunk
Unreviewed, rolling out r202659.
https://bugs.webkit.org/show_bug.cgi?id=159305
The test for this change times out on mac-wk2 debug and caused
an existing test to crash. (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"Web Inspector: Wrong function name next to scope"
https://bugs.webkit.org/show_bug.cgi?id=158210
http://trac.webkit.org/changeset/202659
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-30
- 10:16 AM Changeset in webkit [202683] by
-
- 5 edits in trunk
[JSC] Date.setYear() misses timeClip()
https://bugs.webkit.org/show_bug.cgi?id=159289
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-30
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncSetYear):
LayoutTests:
- js/date-timeClip-large-values-expected.txt:
- js/script-tests/date-timeClip-large-values.js:
The failures are caused by bugs related to GregorianDateTime.
The last test case is the one covering this patch.
- 9:19 AM Changeset in webkit [202682] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r202679.
https://bugs.webkit.org/show_bug.cgi?id=159302
Still causing timeouts on media/controls-drag-timebar.html
(Requested by ap on #webkit).
Reverted changeset:
"[iOS] Media controls are too cramped with small video"
https://bugs.webkit.org/show_bug.cgi?id=158815
http://trac.webkit.org/changeset/202679
- 9:14 AM Changeset in webkit [202681] by
-
- 4 edits4 adds in trunk
LayoutTests intermittently failing to run due to issues starting Web Platform Test server
https://bugs.webkit.org/show_bug.cgi?id=159166
<rdar://problem/27051759>
Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-30
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Pregenerating certificates.
- resources/_wpt_certs/.gitignore: Added.
- resources/_wpt_certs/localhost.key: Added.
- resources/_wpt_certs/localhost.pem: Added.
- resources/config.json:
Tools:
Setting the certificate directory to the copied config.json.
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer._copy_webkit_test_files):
- 8:26 AM Changeset in webkit [202680] by
-
- 45 edits1 copy47 adds in trunk
[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber accept non number values
https://bugs.webkit.org/show_bug.cgi?id=154022
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We aim at optimizing @toInteger operation.
While it still has an unoptimized part[1], this patch should be a first step.
We introduce the @toNumber builtin intrinsic operation.
This converts the given value to the JS number by emitting op_to_number bytecode.
Previously @toInteger called C++ @Number constructor for that purpose.
And in DFG, op_to_number is converted to DFG ToNumber node.
During DFG, we attempt to convert this to edge filtering and Identity, but if we fail,
we just fall back to calling the C++ function.
To utilize ToNumber in user-land side, we add a path attempting to convert Number constructor calls
to ToNumber DFG nodes. This conversion is useful becauseNumber(value)is used to convert a value to a number in JS.
Before this patch, we emit simple edge filtering (NumberUse) instead of emitting DFG node like ToNumber for op_to_number.
But emitting ToNumber is useful, because in the case ofNumber(value), consideringvaluemay not be a number is reasonable.
By leveraging @toNumber operation, we rewrite Number.{isFinite, isNaN}, global.{isFinite, isNaN} and @toInteger.
ToNumber DFG node has a value profiling. This profiling is leveraged to determine the result number type of the ToNumber operation.
This value profiling is provided from either NumberConstructor's call operation or op_to_number.
The results (with the added performance tests) show that, while existing cases are performance neutral, the newly added cases gain the performance benefit.
And ASMBench/n-body.c also shows stable ~2% progression.
[1]: https://bugs.webkit.org/show_bug.cgi?id=153738
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/BuiltinNames.h:
- builtins/GlobalObject.js:
(globalPrivate.isFinite):
(globalPrivate.isNaN):
(globalPrivate.toInteger): Deleted.
(globalPrivate.toLength): Deleted.
(globalPrivate.isDictionary): Deleted.
(globalPrivate.speciesGetter): Deleted.
(globalPrivate.speciesConstructor): Deleted.
- builtins/GlobalOperations.js: Copied from Source/JavaScriptCore/builtins/GlobalObject.js.
(globalPrivate.toInteger):
(globalPrivate.toLength):
(globalPrivate.isDictionary):
(globalPrivate.speciesGetter):
(globalPrivate.speciesConstructor):
- builtins/NumberConstructor.js: Added.
(isFinite):
(isNaN):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecode/BytecodeList.json:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitUnaryOpProfiled):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitToNumber):
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_toNumber):
(JSC::UnaryPlusNode::emitBytecode):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
We usegetPrediction()to retrieve the heap prediction from the to_number bytecode.
According to the benchmark results, choosinggetPredictionWithoutOSRExit()causes performance regression (1.5%) in kraken stanford-crypto-aes.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumber):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
Always on the heap prediction.
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
As of 64bit version, we carefully manage the register reuse. The largest difference between 32bit and 64bit is
branchIfNotNumber()requires the temporary register. We should not use the result registers for that since
it may be reuse the argument registers and it can break the argument registers before using them to call the operation.
Currently, we allocate the additional temporary register for that scratch register.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Reuse the argument register for the result if possible. And manually decrement the use count in the middle of the node.
This is similar technique used in ToPrimitive. Typically, the child of ToNumber is only used by this ToNumber node since
we would like to perform the type conversion onto this child node here. So this careful register reuse effectively removes
the spills to call the operation. The example of the actually emitted code is the following.
76:<!2:loc11> ToNumber(Untyped:@68, JS|MustGen|UseAsOther, DoubleimpurenanTopEmpty, R:World, W:Heap, Exits, ClobbersExit, bc#48) predicting DoubleimpurenanTopEmpty
0x7f986d5fe693: test %rax, %r14
0x7f986d5fe696: jz 0x7f986d5fe6a1
0x7f986d5fe69c: jmp 0x7f986d5fe6d1
0x7f986d5fe6a1: mov %rax, %rsi
0x7f986d5fe6a4: mov %rbp, %rdi
0x7f986d5fe6a7: mov $0x2, 0x24(%rbp)
0x7f986d5fe6ae: mov $0x7f98711ea5f0, %r11
0x7f986d5fe6b8: call *%r11
0x7f986d5fe6bb: mov $0x7f982d3f72d0, %r11
0x7f986d5fe6c5: mov (%r11), %r11
0x7f986d5fe6c8: test %r11, %r11
0x7f986d5fe6cb: jnz 0x7f986d5fe88c
It effectively removes the unnecessary spill to call the operation!
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_number):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_to_number):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/Nodes.h:
(JSC::UnaryOpNode::opcodeID):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncIsNaN): Deleted.
(JSC::globalFuncIsFinite): Deleted.
- runtime/JSGlobalObjectFunctions.h:
- runtime/MathCommon.h:
(JSC::maxSafeInteger):
(JSC::minSafeInteger):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
(JSC::numberConstructorFuncIsFinite): Deleted.
(JSC::numberConstructorFuncIsNaN): Deleted.
- runtime/NumberConstructor.h:
- tests/stress/Number-isNaN-basics.js: Added.
(numberIsNaNOnInteger):
(testNumberIsNaNOnIntegers):
(verifyNumberIsNaNOnIntegerWithOtherTypes):
(numberIsNaNOnDouble):
(testNumberIsNaNOnDoubles):
(verifyNumberIsNaNOnDoublesWithOtherTypes):
(numberIsNaNNoArguments):
(numberIsNaNTooManyArguments):
(testNumberIsNaNOnConstants):
(numberIsNaNStructTransition):
(Number.isNaN):
- tests/stress/global-is-finite.js: Added.
(shouldBe):
- tests/stress/global-is-nan.js: Added.
(shouldBe):
- tests/stress/global-isNaN-basics.js: Added.
(isNaNOnInteger):
(testIsNaNOnIntegers):
(verifyIsNaNOnIntegerWithOtherTypes):
(isNaNOnDouble):
(testIsNaNOnDoubles):
(verifyIsNaNOnDoublesWithOtherTypes):
(verifyIsNaNOnCoercedTypes):
(isNaNNoArguments):
(isNaNTooManyArguments):
(testIsNaNOnConstants):
(isNaNTypeCoercionSideEffects):
(i.value.isNaNTypeCoercionSideEffects.valueOf):
(isNaNStructTransition):
(isNaN):
- tests/stress/number-is-finite.js: Added.
(shouldBe):
(test2):
(test3):
- tests/stress/number-is-nan.js: Added.
(shouldBe):
(test2):
(test3):
- tests/stress/to-number-basics.js: Added.
(shouldBe):
- tests/stress/to-number-convert-identity-without-execution.js: Added.
(shouldBe):
(object.valueOf):
(valueOf):
- tests/stress/to-number-int52.js: Added.
(shouldBe):
(object.valueOf):
- tests/stress/to-number-intrinsic-convert-to-identity-without-execution.js: Added.
(shouldBe):
(object.valueOf):
(valueOf):
- tests/stress/to-number-intrinsic-int52.js: Added.
(shouldBe):
(object.valueOf):
- tests/stress/to-number-intrinsic-object-without-execution.js: Added.
(shouldBe):
(object.valueOf):
- tests/stress/to-number-intrinsic-value-profiling.js: Added.
(shouldBe):
(object.valueOf):
- tests/stress/to-number-object-without-execution.js: Added.
(shouldBe):
(object.valueOf):
- tests/stress/to-number-object.js: Added.
(shouldBe):
(test12):
(object1.valueOf):
(test2):
(test22):
(object2.valueOf):
(test3):
(test32):
(object3.valueOf):
- tests/stress/to-number-value-profiling.js: Added.
(shouldBe):
(object.valueOf):
LayoutTests:
- js/regress/Number-isNaN-expected.txt: Added.
- js/regress/Number-isNaN.html: Added.
- js/regress/global-isNaN-expected.txt: Added.
- js/regress/global-isNaN.html: Added.
- js/regress/script-tests/Number-isNaN.js: Added.
- js/regress/script-tests/global-isNaN.js: Added.
- js/regress/script-tests/many-foreach-calls.js:
(i.4.forEach):
(i.array.forEach): Deleted.
- js/regress/script-tests/to-number-constructor-number-string-number-string.js: Added.
(test):
- js/regress/script-tests/to-number-constructor-only-number.js: Added.
(test):
- js/regress/script-tests/to-number-constructor-only-string.js: Added.
(test):
- js/regress/script-tests/to-number-constructor-string-number-string-number.js: Added.
(test):
- js/regress/script-tests/to-number-number-string-number-string.js: Added.
(test):
- js/regress/script-tests/to-number-only-number.js: Added.
(test):
- js/regress/script-tests/to-number-only-string.js: Added.
(test):
- js/regress/script-tests/to-number-string-number-string-number.js: Added.
(test):
- js/regress/to-number-constructor-number-string-number-string-expected.txt: Added.
- js/regress/to-number-constructor-number-string-number-string.html: Added.
- js/regress/to-number-constructor-only-number-expected.txt: Added.
- js/regress/to-number-constructor-only-number.html: Added.
- js/regress/to-number-constructor-only-string-expected.txt: Added.
- js/regress/to-number-constructor-only-string.html: Added.
- js/regress/to-number-constructor-string-number-string-number-expected.txt: Added.
- js/regress/to-number-constructor-string-number-string-number.html: Added.
- js/regress/to-number-number-string-number-string-expected.txt: Added.
- js/regress/to-number-number-string-number-string.html: Added.
- js/regress/to-number-only-number-expected.txt: Added.
- js/regress/to-number-only-number.html: Added.
- js/regress/to-number-only-string-expected.txt: Added.
- js/regress/to-number-only-string.html: Added.
- js/regress/to-number-string-number-string-number-expected.txt: Added.
- js/regress/to-number-string-number-string-number.html: Added.
- 8:09 AM Changeset in webkit [202679] by
-
- 8 edits2 adds in trunk
[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>
Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Eric Carlson.
Source/WebCore:
In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.
In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.
As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.
Test: media/video-controls-drop-and-restore-timeline.html
- Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):
- Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsiOS.js:
LayoutTests:
Adjust the output of this test to account for the time label clones and add a new test.
- media/video-controls-drop-and-restore-timeline-expected.txt: Added.
- media/video-controls-drop-and-restore-timeline.html: Added.
- platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
- platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
- 7:26 AM Changeset in webkit [202678] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Crash registering AVFoundation media engine
https://bugs.webkit.org/show_bug.cgi?id=159269
<rdar://problem/27017656>
Reviewed by Brent Fulgham.
- platform/graphics/MediaPlayer.cpp:
(WebCore::mediaEngineVectorLock): New, return the static Lock.
(WebCore::haveMediaEnginesVector): Wrap the naked bool.
(WebCore::buildMediaEnginesVector): Assert that the lock is locked.
(WebCore::installedMediaEngines): Hold the lock while checking/rebuilding the vector.
(WebCore::MediaPlayer::resetMediaEngines): Hold the lock while clearing the vector.
Use SOFT_LINK_CLASS_FOR_SOURCE instead of SOFT_LINK_CLASS because the former uses dispatch_once
to ensure that class loading is thread safe.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createOpenGLVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(-[WebCoreAVFPullDelegate setCallback:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
- 6:37 AM Changeset in webkit [202677] by
-
- 8 edits in trunk/Source/WebCore
[image-decoders] Use final and override in ImageDecoder subclasses
https://bugs.webkit.org/show_bug.cgi?id=159291
Reviewed by Antonio Gomes.
- platform/image-decoders/bmp/BMPImageDecoder.h:
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameSizeAtIndex):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.h:
- platform/image-decoders/webp/WEBPImageDecoder.h:
- 1:14 AM Changeset in webkit [202676] by
-
- 18 edits in trunk/Source/WebCore
Purge PassRefPtr in Modules/webdatabase
https://bugs.webkit.org/show_bug.cgi?id=159255
Reviewed by Benjamin Poulain.
As a step to remove PassRefPtr use, this patch cleans it up in Modules/webdatabase.
Additionally unnecessary spaces and tabs are removed too.
- Modules/webdatabase/ChangeVersionWrapper.cpp:
- Modules/webdatabase/DOMWindowWebDatabase.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::~Database):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::runTransaction):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::allowRead):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseTask.h:
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
- Modules/webdatabase/SQLResultSetRowList.h:
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::sqlError):
(WebCore::SQLStatement::sqlResultSet):
- Modules/webdatabase/SQLStatement.h:
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::transactionError):
- Modules/webdatabase/SQLTransactionBackend.h:
- 12:32 AM Changeset in webkit [202675] by
-
- 6 edits6 moves in trunk/Source
[Coordinated Graphics] Move CompositingCoordinator from platform to WebKit2 layer
https://bugs.webkit.org/show_bug.cgi?id=159209
Reviewed by Žan Doberšek.
Source/WebCore:
Remove CompositingCoordinator and its helper classes from the platform layer.
- platform/TextureMapper.cmake:
Source/WebKit2:
Move CompositingCoordinator and its helper classes to the WebKit2 layer.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.cpp.
(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):
- WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.h.
(WebKit::nextPowerOfTwo):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp.
(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::~CompositingCoordinator):
(WebKit::CompositingCoordinator::setRootCompositingLayer):
(WebKit::CompositingCoordinator::setViewOverlayRootLayer):
(WebKit::CompositingCoordinator::sizeDidChange):
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::timestamp):
(WebKit::CompositingCoordinator::syncDisplayState):
(WebKit::CompositingCoordinator::nextAnimationServiceTime):
(WebKit::CompositingCoordinator::clearPendingStateChanges):
(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::createRootLayer):
(WebKit::CompositingCoordinator::syncLayerState):
(WebKit::CompositingCoordinator::createImageBackingIfNeeded):
(WebKit::CompositingCoordinator::createImageBacking):
(WebKit::CompositingCoordinator::updateImageBacking):
(WebKit::CompositingCoordinator::clearImageBackingContents):
(WebKit::CompositingCoordinator::removeImageBacking):
(WebKit::CompositingCoordinator::flushPendingImageBackingChanges):
(WebKit::CompositingCoordinator::notifyAnimationStarted):
(WebKit::CompositingCoordinator::notifyFlushRequired):
(WebKit::CompositingCoordinator::paintContents):
(WebKit::CompositingCoordinator::createGraphicsLayer):
(WebKit::CompositingCoordinator::deviceScaleFactor):
(WebKit::CompositingCoordinator::pageScaleFactor):
(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::removeUpdateAtlas):
(WebKit::CompositingCoordinator::visibleContentsRect):
(WebKit::CompositingCoordinator::mainContentsLayer):
(WebKit::CompositingCoordinator::setVisibleContentsRect):
(WebKit::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebKit::CompositingCoordinator::detachLayer):
(WebKit::CompositingCoordinator::commitScrollOffset):
(WebKit::CompositingCoordinator::renderNextFrame):
(WebKit::CompositingCoordinator::purgeBackingStores):
(WebKit::CompositingCoordinator::paintToSurface):
(WebKit::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h.
(WebKit::CompositingCoordinator::clearRootLayer):
(WebKit::CompositingCoordinator::rootLayer):
(WebKit::CompositingCoordinator::state):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.cpp.
(WebKit::UpdateAtlasSurfaceClient::UpdateAtlasSurfaceClient):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::paintOnAvailableBuffer):
- WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.h.
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::supportsAlpha):
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):
Jun 29, 2016:
- 11:28 PM Changeset in webkit [202674] by
-
- 16 edits in trunk/Source/WebCore
Pass SecurityOrigin as references in CORS check code
https://bugs.webkit.org/show_bug.cgi?id=159263
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-29
Reviewed by Alex Christensen.
No change of behavior.
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
- loader/CrossOriginAccessControl.cpp:
(WebCore::updateRequestForAccessControl):
(WebCore::createAccessControlPreflightRequest):
(WebCore::passesAccessControlCheck):
- loader/CrossOriginAccessControl.h:
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::isAllowedRedirect):
(WebCore::DocumentThreadableLoader::securityOrigin):
- loader/DocumentThreadableLoader.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- loader/LinkLoader.cpp:
(WebCore::preloadIfNeeded):
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::requestResource):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkCrossOriginAccessControl):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::load):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::passesAccessControlCheck):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin):
- 10:57 PM Changeset in webkit [202673] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the debug build after r202667
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
The putDirect was missing the Accessor flag for the GetterSetter.
- 10:10 PM Changeset in webkit [202672] by
-
- 7 edits in trunk/LayoutTests
Attempt to fix constructor-length.html
I did a rebaseline of constructor-length.html.
I should have updated the test instead.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
- js/dom/constructor-length.html:
- platform/efl/js/dom/constructor-length-expected.txt:
- platform/gtk/js/dom/constructor-length-expected.txt:
- platform/ios-simulator/js/dom/constructor-length-expected.txt:
- platform/mac/js/dom/constructor-length-expected.txt:
- platform/win/js/dom/constructor-length-expected.txt:
- 9:49 PM Changeset in webkit [202671] by
-
- 11 edits1 move in trunk
WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()
https://bugs.webkit.org/show_bug.cgi?id=159254
Reviewed by Eric Carlson.
Source/WebCore:
Implement MediaEndpointPeerConnection::setConfiguration() which is the
MediaEndpointPeerConnection implementation of RTCPeerConnection.setConfiguration() [1].
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-setconfiguration
Testing: Updated existing test.
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::setConfiguration):
Implemented.
- Modules/mediastream/RTCConfiguration.cpp:
(WebCore::RTCConfiguration::initialize):
- Modules/mediastream/RTCConfiguration.h:
Use shared enums.
- Modules/mediastream/RTCConfiguration.idl:
Remove 'None'/'Public' IceTransportPolicy enum value (removed from WebRTC 1.0).
- platform/mediastream/MediaEndpointConfiguration.cpp:
(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):
- platform/mediastream/MediaEndpointConfiguration.h:
Use shared enums.
(WebCore::MediaEndpointConfiguration::create):
- platform/mediastream/PeerConnectionStates.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnectionStates.h.
Make shared enums accessible to platform objects (currently MediaEndpointConfiguration).
LayoutTests:
Test configuring an RTCPeerConnection object via the constructor and setConfiguration() and
check the resulting configuration with getConfiguration().
- fast/mediastream/RTCPeerConnection-getConfiguration-expected.txt:
- fast/mediastream/RTCPeerConnection-getConfiguration.html:
Remove 'requestIdentity' tests (dictionary member removed from WebRTC 1.0). Add tests for
'bundlePolicy'.
- platform/gtk/TestExpectations:
Unskip above test.
- 9:46 PM Changeset in webkit [202670] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(200114): Netflix app does not see ChromeCast
https://bugs.webkit.org/show_bug.cgi?id=159287
Reviewed by Benjamin Poulain.
Change set 200114 changed the behavior of how we check for whether or not we
wrap Objective C init methods in JavaScript constructors. The prior method
checked the version of JavaScriptCore that was linked with the application.
If the application was not directly linked with JavaScriptCore the prior
method indicated that we shouldn't create constructors. The new method uses
the SDK the application was compiled with. Using the new method, an
application compiled with iOS SDK 8.0 or greater would create constructors
and not export init methods to JavaScript. The problem is that an existing
application that hasn't been recompiled will get a different answer using
the new method. We need to come up with a method that works in a compatible
way with existing programs, but provides a newly compiled program with the
"is built with SDK N or greater" check.
Added back the prior check of the version of JavaScriptCore the program was
directly linked against. However we only use this check if we directly linked
with JavaScriptCore. Otherwise we fall through to check against the SDK the
program was built with. Changed the iOS SDK version we check
against to be the new version of iOS, iOS 10.
This provides compatible behavior for existing programs. It may be the case
that some of those programs may require changes when they are rebuilt with the
iOS 10 SDK or later.
- API/JSWrapperMap.mm:
(supportsInitMethodConstructors):
- 9:46 PM Changeset in webkit [202669] by
-
- 1 edit in trunk/Websites/webkit.org/demos/spring/index.html
Add a link to the proposal.
- demos/spring/index.html:
- 9:39 PM Changeset in webkit [202668] by
-
- 2 edits1 add in trunk/Websites/webkit.org
Add the UI JavaScript library to make
other browsers happy.
- demos/spring/dat.gui.min.js: Added.
- demos/spring/index.html:
- 9:24 PM Changeset in webkit [202667] by
-
- 9 edits in trunk
[JSC] Minor TypedArray fixes
https://bugs.webkit.org/show_bug.cgi?id=159286
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
Reviewed by Keith Miller.
Source/JavaScriptCore:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
See https://tc39.github.io/ecma262/#sec-%typedarray%
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncLength):
See https://tc39.github.io/ecma262/#sec-get-%typedarray%.prototype.length
(JSC::typedArrayViewProtoGetterFuncToStringTag):
Yep, that's odd.
See https://tc39.github.io/ecma262/#sec-get-%typedarray%.prototype-@@tostringtag
(JSC::JSTypedArrayViewPrototype::finishCreation):
See the last paragraph of https://tc39.github.io/ecma262/#sec-ecmascript-standard-built-in-objects
LayoutTests:
- js/script-tests/typedarray-constructors.js:
- js/script-tests/typedarray-prototype.js:
- js/typedarray-constructors-expected.txt:
- js/typedarray-prototype-expected.txt:
- 9:19 PM Changeset in webkit [202666] by
-
- 5 edits in trunk
Web Inspector: API View of Native DOM APIs looks poor (TypeErrors for native getters)
https://bugs.webkit.org/show_bug.cgi?id=158334
<rdar://problem/26615366>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._getProperties):
(InjectedScript.prototype._propertyDescriptors):
Do not create fake value property descriptors for native accessors
unless requested. This means, getProperties for a native prototype
should return accessors for native accessors just like it does
for normal non-native accessors (getters/setters).
(InjectedScript.prototype.getProperties):
Do not produce fake value accessors for native accessors.
(InjectedScript.prototype.getDisplayableProperties):
(InjectedScript.RemoteObject.prototype._generatePreview):
Do produce fake value accessors for native accessors.
LayoutTests:
- inspector/runtime/getProperties-expected.txt:
- inspector/runtime/getProperties.html:
Improve output for accessors now that getProperties
returns real accessor descriptors for native accessors
instead of fake value descriptors.
- 9:17 PM Changeset in webkit [202665] by
-
- 1 edit3 adds in trunk/Websites/webkit.org
Demo and JS implementation of our spring() animation
timing function.
- demos/spring/index.html: Added.
- demos/spring/spring.js: Added.
(SpringSolver):
(SpringSolver.prototype.solve):
- 8:55 PM Changeset in webkit [202664] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
JSGlobalLexicalEnvironment needs a toThis implementation
https://bugs.webkit.org/show_bug.cgi?id=159285
Reviewed by Mark Lam.
This was a huge oversight of my original implementation. It gave users
of the language direct access to the JSGlobalLexicalEnvironment object.
- runtime/JSGlobalLexicalEnvironment.cpp:
(JSC::JSGlobalLexicalEnvironment::isConstVariable):
(JSC::JSGlobalLexicalEnvironment::toThis):
- runtime/JSGlobalLexicalEnvironment.h:
(JSC::JSGlobalLexicalEnvironment::isEmpty):
- tests/stress/global-lexical-environment-to-this.js: Added.
(assert):
(let.f):
(let.fStrict):
- 7:34 PM Changeset in webkit [202663] by
-
- 2 edits in trunk/Websites/webkit.org
Small change to wording, and link to the interactive version.
- blog-files/color-gamut/index.html:
- 7:09 PM Changeset in webkit [202662] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, CMake build fix - 2.
- PlatformMac.cmake:
- 6:03 PM Changeset in webkit [202661] by
-
- 4 edits in trunk/Source
Source/WebCore:
Unreviewed, CMake build fix.
- PlatformMac.cmake:
Source/WebKit2:
Unreviewed, CMake build fix.
- PlatformMac.cmake:
- 5:12 PM Changeset in webkit [202660] by
-
- 4 edits4 adds in trunk
Unprefix webkit-playsinline.
https://bugs.webkit.org/show_bug.cgi?id=159283
Reviewed by Eric Carlson.
Tests: media/video-playsinline.html
media/video-webkit-playsinline.html
Unprefix the webkit-playsinline content attribute, as an unprefixed version
was added to the HTML spec by <https://github.com/whatwg/html/pull/1444>.
The new 'playsinline' content attribute reflects to a new DOM property of
the same name.
- html/HTMLAttributeNames.in:
- html/HTMLVideoElement.idl:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
- 4:59 PM Changeset in webkit [202659] by
-
- 21 edits5 adds in trunk
Web Inspector: Wrong function name next to scope
https://bugs.webkit.org/show_bug.cgi?id=158210
<rdar://problem/26543093>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
Add DebuggerLocation. A helper for describing a unique location.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantRegisters):
When compiled with debug info, add a SymbolTable rare data pointer
back to the CodeBlock. This will be used later to get JSScope debug
info if Web Inspector pauses.
- runtime/SymbolTable.h:
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::cloneScopePart):
(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForOffset):
(JSC::SymbolTable::globalTypeSetForOffset):
(JSC::SymbolTable::globalTypeSetForVariable):
Rename rareData and include a CodeBlock pointer.
(JSC::SymbolTable::rareDataCodeBlock):
(JSC::SymbolTable::setRareDataCodeBlock):
Setter and getter for the rare data. It should only be set once.
(JSC::SymbolTable::visitChildren):
Visit the rare data code block if we have one.
- debugger/DebuggerLocation.cpp: Added.
(JSC::DebuggerLocation::DebuggerLocation):
- debugger/DebuggerLocation.h: Added.
(JSC::DebuggerLocation::DebuggerLocation):
Construction from a ScriptExecutable.
- runtime/JSScope.cpp:
(JSC::JSScope::symbolTable):
- runtime/JSScope.h:
- debugger/DebuggerScope.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::name):
(JSC::DebuggerScope::location):
Name and location for a scope. This uses:
JSScope -> SymbolTable -> CodeBlock -> Executable
- inspector/protocol/Debugger.json:
- inspector/InjectedScriptSource.js:
(InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
(InjectedScript.CallFrameProxy._createScopeJson):
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::valueForScopeType):
(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):
(Inspector::JSJavaScriptCallFrame::scopeType): Deleted.
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType): Deleted.
Simplify this code to build the objects we will send across the protocol
to descript a Scope.
Source/WebInspectorUI:
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
Include new payload data in the construction call.
All the new data is optional, so we gracefully handle
legacy backends.
- UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get type):
(WebInspector.ScopeChainNode.prototype.get objects):
(WebInspector.ScopeChainNode.prototype.get name):
(WebInspector.ScopeChainNode.prototype.get location):
(WebInspector.ScopeChainNode.prototype.get hash):
Hash is a rough (name:sourceId:line:column) string for quick comparisons.
(WebInspector.ScopeChainNode.prototype.makeLocalScope):
Make this an action you take on a scope, to avoid having to
do it at construction time, or making it a generic setting.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
This was wrong before. Move the work to CallFrame
and change it to be correct.
- UserInterface/CallFrame.js:
(WebInspector.CallFrame.prototype.mergedScopeChain):
This transforms the scope chain for a call frame from:
scope1 scope2 scope3 scope4 scope5 scope6 scope7
foo foo foo bar bar - -
Block Closure Closure Closure Closure GLE GBL
To:
scope1 scope2&3 scope4&5 scope6 scope7
foo foo* bar* - -
Block Local Closure GLE GBL
Doing a few things:
- Merge the first two Closure scopes sharing a location. These are the "var" and "let" Closure scopes in a function, and it is better to present these together in the UI.
- Mark the first Closure scope within a function (*). When this is displayed in the UI, we can provide the name of the function: "Closure Scope (name)", and we even have location information that we can use to display a goto arrow if needed.
- Make the first Closure scope the Local scope if it matches the Call Frame's function name. This lets us display the section as "Local Variables".
LayoutTests:
- inspector/debugger/paused-scopes-expected.txt: Added.
- inspector/debugger/paused-scopes.html: Added.
- inspector/debugger/resources/paused-scopes.js: Added.
Test dumps the call frames and scope chains for each call frame
when pausing at different locations in a program. Outputting
the hashes we can see even identically named functions have
different hashes because their location is different.
- 4:28 PM Changeset in webkit [202658] by
-
- 2 edits in trunk/Source/WebCore
Fix null dereferencing after r201441
https://bugs.webkit.org/show_bug.cgi?id=159282
rdar://problem/27082559
Reviewed by Andreas Kling.
No new tests. This is reproducible when dragging from regular to high-DPI displays,
and we don't have testing infrastructure for simulating that.
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::styleResolverChanged):
MediaQueryListListener::queryChanged can mutate the Vector of listeners while we are iterating it.
Copy the Vector of listeners and iterate the copy so we don't go out of bounds.
- 4:05 PM Changeset in webkit [202657] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception page never shows if exception is thrown while processing a protocol event
https://bugs.webkit.org/show_bug.cgi?id=159182
Reviewed by Joseph Pecoraro.
Since we catch exceptions raised during the handling of protocol responses and events, there
is no way for these exceptions to trigger the global exception handler that shows the Uncaught
Exception Reporter sheet. We should show these in the sheet because it makes them get fixed faster.
Add a new entry point, WebInspector.reportInternalError, that takes an error or string and
a free-form map of strings to strings for storing additional information such as message data.
Pass the error and any other relevant details to this entry point, which decides whether to
show the uncaught exception reporter or quietly log the error to Inspector2 console.
In future patches, I would like to do the following once the common errors are fixed:
- enable reporting via Uncaught Exception Reporter for all engineering builds
- move internal console.error call sites to use WebInspector.reportInternalError
- UserInterface/Base/Main.js: Add reportInternalError, which redirects to the uncaught
exception reporter sheet or does console.error. It also adds a console.assert that could
cause the debugger to pause if desired.
- UserInterface/Debug/UncaughtExceptionReporter.css:
(.sheet-container): Make the report scrollable now that we could potentially show a lot of text.
- UserInterface/Debug/UncaughtExceptionReporter.js:
(handleError): Also pass along the 'details' poperty.
(formattedEntry): Refactor the code so it additionally prints out the keys and values of
the 'details' property. It does not do any coercions, so callers must convert values to strings.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype._dispatchResponse): Inlined a function.
(InspectorBackendClass.prototype._dispatchResponseToCallback):
(InspectorBackendClass.prototype._dispatchEvent):
Report uncaught exceptions via WebInspector.reportInternalError.
(InspectorBackendClass.prototype._reportProtocolError): Deleted, inlined into the single use site.
- 4:01 PM Changeset in webkit [202656] by
-
- 11 edits2 adds in trunk/Source/WebCore
Factor pending CSS resources into a struct
https://bugs.webkit.org/show_bug.cgi?id=159268
Reviewed by Andreas Kling.
To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of
resource loads outside the style resolver. The first step for that is to capture pending resources to a struct.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
- css/CSSCursorImageValue.h:
- css/CSSGradientValue.cpp:
(WebCore::GradientStop::GradientStop):
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::loadSubimages):
(WebCore::CSSGradientValue::CSSGradientValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):
- css/CSSImageSetValue.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::ensurePendingResources):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::filterOperationForType):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(WebCore::StyleResolver::loadPendingSVGDocuments): Deleted.
(WebCore::StyleResolver::loadPendingImage): Deleted.
(WebCore::StyleResolver::loadPendingShapeImage): Deleted.
(WebCore::StyleResolver::loadPendingImages): Deleted.
- css/StyleResolver.h:
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::document):
(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::State::takePendingResources):
(WebCore::StyleResolver::State::cssToLengthConversionData):
(WebCore::StyleResolver::State::cascadeLevel):
(WebCore::StyleResolver::State::setCascadeLevel):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::State::pendingImageProperties): Deleted.
(WebCore::StyleResolver::State::filtersWithPendingSVGDocuments): Deleted.
- style/StylePendingResources.cpp: Added.
(WebCore::Style::loadPendingImage):
(WebCore::Style::loadPendingImages):
(WebCore::Style::loadPendingSVGFilters):
(WebCore::Style::loadPendingResources):
Move the functions for triggering the resource loads from StyleResolver.
- style/StylePendingResources.h: Added.
Add struct for pending resources.
- 3:41 PM Changeset in webkit [202655] by
-
- 2 edits in trunk/Source/WebCore
Add "type" and "paymentPass" properties in PaymentMethod
https://bugs.webkit.org/show_bug.cgi?id=159278
rdar://problem/26999112
Reviewed by Dean Jackson.
- Modules/applepay/cocoa/PaymentMethodCocoa.mm:
(WebCore::toString):
(WebCore::toDictionary):
- 3:34 PM Changeset in webkit [202654] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
We don't emit TDZ checks for call_eval
https://bugs.webkit.org/show_bug.cgi?id=159277
<rdar://problem/27018801>
Reviewed by Benjamin Poulain.
This is a problem if you're trying to call a TDZ variable
that is named 'eval'.
- bytecompiler/NodesCodegen.cpp:
(JSC::EvalFunctionCallNode::emitBytecode):
- tests/stress/variable-named-eval-under-tdz.js: Added.
(shouldThrowTDZ):
(test):
(test.foo):
(throw.new.Error):
- 3:18 PM Changeset in webkit [202653] by
-
- 2 edits1 add in trunk/Source/WebKit2
Add media_icon to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=159273
-and corresponding-
rdar://problem/27087714
Reviewed by Dean Jackson.
- Resources/mediaIcon.pdf: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 3:15 PM Changeset in webkit [202652] by
-
- 1 copy in tags/Safari-602.1.38.3
New tag.
- 3:04 PM Changeset in webkit [202651] by
-
- 1 delete in tags/Safari-602.1.38.2.2
Delete tag.
- 3:00 PM Changeset in webkit [202650] by
-
- 8 edits in trunk
Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
https://bugs.webkit.org/show_bug.cgi?id=159274
Reviewed by Keith Miller.
Source/JavaScriptCore:
- jsc.cpp:
(main):
- llint/LLIntData.cpp:
(JSC::LLInt::initialize):
(JSC::LLInt::Data::finalizeStats):
(JSC::LLInt::compareStats):
(JSC::LLInt::Data::dumpStats):
(JSC::LLInt::Data::ensureStats):
(JSC::LLInt::Data::loadStats):
(JSC::LLInt::Data::resetStats):
(JSC::LLInt::Data::saveStats):
- llint/LLIntData.h:
(JSC::LLInt::Data::opcodeStats):
- runtime/Options.cpp:
(JSC::Options::isAvailable):
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
- runtime/Options.h:
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(DumpRenderTreeMain):
- 2:54 PM Changeset in webkit [202649] by
-
- 2 edits in trunk/LayoutTests
Marking perf/rel-list-remove.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=156561
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:48 PM Changeset in webkit [202648] by
-
- 5 edits in trunk
Destructuring variable declaration is missing a validation of the syntax of a sub production when there is a rhs
https://bugs.webkit.org/show_bug.cgi?id=159267
Reviewed by Mark Lam.
Source/JavaScriptCore:
We were parsing something without checking if it had a syntax error.
This is wrong for many reasons, but it could actually cause a crash
in a debug build if you parsed particular programs.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVariableDeclarationList):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 2:23 PM Changeset in webkit [202647] by
-
- 4 edits2 adds in trunk
AX: Crash in WebCore::Document::focusNavigationStartingNode(WebCore::FocusDirection) const + 128
https://bugs.webkit.org/show_bug.cgi?id=159240
Reviewed by Ryosuke Niwa.
Source/WebCore:
This crash is caused by passing an empty node to ElementTraversal::previous(Node&). When the
focusNavigationStartingNode has been removed and it has no next sibling, we should fallback
to itself for calculating the next focused element.
Test: fast/events/remove-focus-navigation-starting-point-crash.html
- dom/Document.cpp:
(WebCore::Document::focusNavigationStartingNode):
LayoutTests:
- fast/events/remove-focus-navigation-starting-point-crash-expected.txt: Added.
- fast/events/remove-focus-navigation-starting-point-crash.html: Added.
- platform/ios-simulator/TestExpectations:
- 1:59 PM Changeset in webkit [202646] by
-
- 2 edits in trunk/LayoutTests
Marking animations/multiple-backgrounds.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=150942
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 1:17 PM Changeset in webkit [202645] by
-
- 3 edits3 deletes in trunk
Unreviewed, rolling out r202617.
The LayoutTest from this change crashes under GuardMalloc
Reverted changeset:
"Throw exceptions for invalid number of channels for
ConvolverNode"
https://bugs.webkit.org/show_bug.cgi?id=159238
http://trac.webkit.org/changeset/202617
- 1:14 PM Changeset in webkit [202644] by
-
- 7 edits in trunk/Source
Rename addressFields to contactFields
https://bugs.webkit.org/show_bug.cgi?id=159271
rdar://problem/27086955
Reviewed by Beth Dakin.
Source/WebCore:
- Modules/applepay/ApplePaySession.cpp:
(WebCore::createContactFields):
(WebCore::isValidPaymentRequestPropertyName):
(WebCore::createPaymentRequest):
(WebCore::createAddressFields): Deleted.
- Modules/applepay/PaymentRequest.h:
(WebCore::PaymentRequest::requiredBillingContactFields):
(WebCore::PaymentRequest::setRequiredBillingContactFields):
(WebCore::PaymentRequest::requiredShippingContactFields):
(WebCore::PaymentRequest::setRequiredShippingContactFields):
(WebCore::PaymentRequest::requiredBillingAddressFields): Deleted.
(WebCore::PaymentRequest::setRequiredBillingAddressFields): Deleted.
(WebCore::PaymentRequest::requiredShippingAddressFields): Deleted.
(WebCore::PaymentRequest::setRequiredShippingAddressFields): Deleted.
Source/WebKit2:
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<PaymentRequest>::encode):
(IPC::ArgumentCoder<PaymentRequest>::decode):
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<PaymentRequest::AddressFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::AddressFields>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKAddressField):
(WebKit::toPKPaymentRequest):
- 12:54 PM Changeset in webkit [202643] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, third attempt to fix ASAN build for r202599
- platform/text/TextCodecReplacement.cpp:
(WebCore::TextCodecReplacement::decode):
- 12:29 PM Changeset in webkit [202642] by
-
- 9 edits1 move8 adds in trunk/Source
Adopt MediaRemote.
https://bugs.webkit.org/show_bug.cgi?id=159250
Reviewed by Eric Carlson.
Source/WebCore:
Adopt MediaRemote and use the framework to implement MediaSessionManageMac
and RemoteCommandListenerMac.
- WebCore.xcodeproj/project.pbxproj:
- platform/RemoteCommandListener.cpp:
- platform/audio/PlatformMediaSessionManager.cpp:
- platform/audio/cocoa/MediaSessionManagerCocoa.cpp: Renamed from Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp.
(PlatformMediaSessionManager::updateSessionState):
- platform/audio/mac/MediaSessionManagerMac.h: Added.
- platform/audio/mac/MediaSessionManagerMac.mm: Added.
(WebCore::PlatformMediaSessionManager::sharedManager):
(WebCore::PlatformMediaSessionManager::sharedManagerIfExists):
(WebCore::MediaSessionManagerMac::MediaSessionManagerMac):
(WebCore::MediaSessionManagerMac::~MediaSessionManagerMac):
(WebCore::MediaSessionManagerMac::sessionWillBeginPlayback):
(WebCore::MediaSessionManagerMac::removeSession):
(WebCore::MediaSessionManagerMac::sessionWillEndPlayback):
(WebCore::MediaSessionManagerMac::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerMac::nowPlayingEligibleSession):
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
- platform/cocoa/SoftLinking.h:
- platform/mac/MediaRemoteSoftLink.cpp: Added.
- platform/mac/MediaRemoteSoftLink.h: Added.
- platform/mac/RemoteCommandListenerMac.h: Added.
(WebCore::RemoteCommandListenerMac::createWeakPtr):
- platform/mac/RemoteCommandListenerMac.mm: Added.
(WebCore::RemoteCommandListener::create):
(WebCore::RemoteCommandListenerMac::RemoteCommandListenerMac):
(WebCore::RemoteCommandListenerMac::~RemoteCommandListenerMac):
- platform/spi/mac/MediaRemoteSPI.h: Added.
Source/WebKit2:
Add a sandbox exception allowing access to the mediaremoted XPC service.
- WebProcess/com.apple.WebProcess.sb.in:
Source/WTF:
Add USE_MEDIAREMOTE.
- wtf/Platform.h:
- 12:22 PM Changeset in webkit [202641] by
-
- 5 edits in trunk
Cannot clear a MediaSource SourceBuffer in Safari 9 and WebKit nightly
https://bugs.webkit.org/show_bug.cgi?id=159230
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-remove.html (modified)
Move to using a MediaTime directly (rather than as a double) to add
and removed buffered ranges. Also, drop the use of the "microsecond"
fudge factor when adding buffered ranges.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
LayoutTests:
- media/media-source/media-source-remove.html:
- media/media-source/media-source-remove-expected.txt:
- 12:19 PM Changeset in webkit [202640] by
-
- 4 edits in trunk
WKWebView should ask WKNavigationDelegate about bad ssl certificates
https://bugs.webkit.org/show_bug.cgi?id=159176
Source/WebKit2:
rdar://problem/26864882
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-29
Reviewed by Sam Weinig.
This can be tested manually by visiting a site in MiniBrowser that has invalid ssl certificates, but we don't have proper ssl testing yet.
Before this change, we would just open the site as if nothing were invalid, now we call the WKNavigationDelegate's didReceiveAuthenticationChallenge
like we did before using NSURLSession, and we do not open the page, also like we did before using NSURLSession.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
When using NSURLConnection and responding to canAuthenticateAgainstProtectionSpace with YES,
we get an NSURLAuthenticationChallenge when a bad ssl certificate is encountered in the handshake.
When using NSURLSession, we want to call webView:didReceiveAuthenticationChallenge:completionHandler: in this case.
The default implementation of NavigationState::NavigationClient::canAuthenticateAgainstProtectionSpace returns true
if there is an implementation of webView:didReceiveAuthenticationChallenge:completionHandler: in its WKNavigationDelegate.
Internal clients can implement _webView:canAuthenticateAgainstProtectionSpace:
and Safari uses canHandleHTTPSServerTrustEvaluation, so it will be unaffected.
Tools:
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-29
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
(-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
(-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
- 11:49 AM Changeset in webkit [202639] by
-
- 5 edits in tags/Safari-602.1.38.2.2/Source
Versioning.
- 11:48 AM Changeset in webkit [202638] by
-
- 8 edits3 deletes in trunk/Source/WebKit2
Delete WKElementInfo since it's not used
https://bugs.webkit.org/show_bug.cgi?id=159265
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WebKit.h:
- UIProcess/API/Cocoa/WKElementInfo.h: Removed.
- UIProcess/API/Cocoa/WKElementInfo.mm: Removed.
- UIProcess/API/Cocoa/WKElementInfoInternal.h: Removed.
- UIProcess/API/Cocoa/WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/WKPreviewElementInfo.mm:
(-[WKPreviewElementInfo _initWithLinkURL:]):
(-[WKPreviewElementInfo copyWithZone:]):
(-[WKPreviewElementInfo linkURL]):
- UIProcess/API/Cocoa/WKPreviewElementInfoInternal.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.mm:
(-[_WKContextMenuElementInfo copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- 11:45 AM Changeset in webkit [202637] by
-
- 1 copy in tags/Safari-602.1.38.2.2
New tag.
- 11:43 AM Changeset in webkit [202636] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, second attempt to fix ASAN build for r202599
- platform/text/TextCodecReplacement.cpp:
- 11:40 AM Changeset in webkit [202635] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, first attempt to fix ASAN build for r202599
- platform/text/TextCodecReplacement.cpp:
- 11:36 AM Changeset in webkit [202634] by
-
- 11 edits2 adds in trunk
Web Inspector: Show Shadow Root type in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=159236
<rdar://problem/27068521>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-29
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Include optional shadowRootType property for DOMNodes.
Source/WebCore:
Test: inspector/dom/shadowRootType.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::shadowRootType):
(WebCore::InspectorDOMAgent::buildObjectForNode):
Set the shadowRootType property when a node is a ShadowRoot.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
"Shadow Content (type)" string.
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.shadowRoots):
(WebInspector.DOMNode.prototype.shadowRootType):
Initialize state and add accessors.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.shadowRootTypeDisplayName):
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
Better string when an element is a Shadow Root.
- UserInterface/Views/DOMTreeElementPathComponent.js:
(WebInspector.DOMTreeElementPathComponent):
Better to check the Shadow Root type.
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom .html-fragment.shadow):
Opacity looks poor when there is a selection. Switch to gray.
LayoutTests:
- inspector/dom/shadowRootType-expected.txt: Added.
- inspector/dom/shadowRootType.html: Added.
- 11:25 AM Changeset in webkit [202633] by
-
- 15 edits2 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r202627.
https://bugs.webkit.org/show_bug.cgi?id=159266
patch is broken on arm (Requested by keith_miller on #webkit).
Reverted changeset:
"LLInt should support other types of prototype GetById
caching."
https://bugs.webkit.org/show_bug.cgi?id=158083
http://trac.webkit.org/changeset/202627
- 11:17 AM Changeset in webkit [202632] by
-
- 5 edits in trunk/Source
Versioning.
- 11:16 AM Changeset in webkit [202631] by
-
- 6 edits3 adds in trunk
[JSC] Fix small issues of TypedArray prototype
https://bugs.webkit.org/show_bug.cgi?id=159248
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
Reviewed by Saam Barati.
Source/JavaScriptCore:
First, TypedArray's toString and Array's toString
should be the same function.
I moved the function to GlobalObject and each array type
gets it as needed.
Then TypedArray length was supposed to be configurable.
I removed the "DontDelete" flag accordingly.
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayProtoToStringFunction):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
LayoutTests:
- js/script-tests/typedarray-prototype.js: Added.
- js/typedarray-prototype-expected.txt: Added.
- js/typedarray-prototype.html: Added.
- 11:11 AM Changeset in webkit [202630] by
-
- 1 copy in tags/Safari-602.1.39
New tag.
- 10:42 AM Changeset in webkit [202629] by
-
- 4 edits in trunk/Source
Replace MPAudioVideoRoutingActionSheet with MPAVRoutingSheet.
https://bugs.webkit.org/show_bug.cgi?id=159161
<rdar://problem/26017691>
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-29
Reviewed by Sam Weinig.
Source/WebCore:
Replace MPAudioVideoRoutingActionSheet SPI with MPAVRoutingSheet SPI.
- platform/spi/ios/MediaPlayerSPI.h:
Source/WebKit2:
MPAudioVideoRoutingActionSheet is being replaced by MPAVRoutingSheet,
with only minor changes to the interface.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):
- 10:36 AM Changeset in webkit [202628] by
-
- 4 edits in trunk
WebRTC: ice-char can not contain '=' characters for credentials
https://bugs.webkit.org/show_bug.cgi?id=159207
Patch by Alejandro G. Castro <alex@igalia.com> on 2016-06-29
Reviewed by Eric Carlson.
Source/WebCore:
Avoid a general calculation to get a base64 without padding which
was wrong in the randomString function. Because each parameter
using the function requires a different setup depending of the
specification and this is not a general API, it is a better
solution to calculate and store the sizes we want to use, comment
them and test them, considering we use base64 to generate the
strings we just need to avoid padding.
Existing test modified to match the correct behavior.
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::randomString): Now the size is the one passed.
(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):
Used different valid values following the sdp parser in each case.
LayoutTests:
Modified the parser to make the regexp similar to the one we have
in WebCore.
- fast/mediastream/resources/sdp-utils.js:
(printComparableSessionDescription):
- 9:53 AM Changeset in webkit [202627] by
-
- 15 edits2 adds in trunk/Source/JavaScriptCore
LLInt should support other types of prototype GetById caching.
https://bugs.webkit.org/show_bug.cgi?id=158083
Recently, we started supporting prototype load caching for get_by_id
in the LLInt. This patch is expading the caching strategy to enable
cache the prototype accessor and custom acessors.
Similarly to the get_by_id_proto_load bytecode, we are adding new
bytecodes called get_by_id_proto_accessor that uses the calculated
offset of a object to call a getter function and get_by_id_proto_custom
that stores the pointer to the custom function and call them directly
from LowLevelInterpreter.
Patch by Caio Lima <Caio Lima> on 2016-06-29
Reviewed by Keith Miller
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 9:50 AM Changeset in webkit [202626] by
-
- 4 edits2 adds in trunk
Crash when 'input' event handler for input[type=color] changes the input type
<https://webkit.org/b/159262>
<rdar://problem/27020404>
Reviewed by Daniel Bates.
Source/WebCore:
Fix based on a Blink change (patch by <tkent@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/a17cb3ecef49a078657524cdeaba33ad2083646c>
Test: fast/forms/color/color-type-change-on-input-crash.html
- html/ColorInputType.cpp:
(WebCore::ColorInputType::didChooseColor): Add EventQueueScope
before setValueFromRenderer() to fix the bug.
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::setValueFromRenderer): Add comment
about how to use this method.
LayoutTests:
Test based on a Blink change (patch by <tkent@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/a17cb3ecef49a078657524cdeaba33ad2083646c>
- fast/forms/color/color-type-change-on-input-crash-expected.txt: Added.
- fast/forms/color/color-type-change-on-input-crash.html: Added.
- 9:18 AM Changeset in webkit [202625] by
-
- 10 edits in trunk
WebRTC: Misc MediaStreamEvent fixes: Update build flag and remove PassRefPtr usage
https://bugs.webkit.org/show_bug.cgi?id=159132
Reviewed by Eric Carlson.
Source/WebCore:
Use the WEB_RTC build flag instead of MEDIA_STREAM since this event is related to
RTCPeerConnection. Also remove PassRefPtr usage.
Updated existing expected results.
- Modules/mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
- Modules/mediastream/MediaStreamEvent.h:
- Modules/mediastream/MediaStreamEvent.idl:
- dom/EventNames.in:
LayoutTests:
Update skip lists and expected results to not expect the MediaStreamEvent constructor in
the global scope (it's under the WEB_RTC build flag).
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
(all above) Remove expected results associated with MediaStreamEvent constructor.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
Skip MediaStreamEvent constructor test on ports that dont't build with WEB_RTC yet.
- 9:10 AM Changeset in webkit [202624] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r202337) [WebRTC] Crash when loading html5test.com
https://bugs.webkit.org/show_bug.cgi?id=159145
Reviewed by Eric Carlson.
MediaEndpointPeerConnection uses an implementation of the MediaEndpoint interface to
interact with the port's WebRTC backend. A mock (MockMediaEndpoint) is used for testing.
This change adds an "empty" MediaEndpoint implementation that simplifies the case when a
port builds and tests with MediaEndpointPeerConnection/MockMediaEndpoint, but doesn't have
a "real" MediaEndpoint implementation yet (to use with MiniBrowser).
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):
- platform/mediastream/MediaEndpoint.cpp:
(WebCore::EmptyRealtimeMediaSource::create):
(WebCore::EmptyRealtimeMediaSource::EmptyRealtimeMediaSource):
(WebCore::EmptyMediaEndpoint::EmptyMediaEndpoint):
(WebCore::createMediaEndpoint):
- 6:14 AM Changeset in webkit [202623] by
-
- 2 edits in trunk/LayoutTests
[GTK] Fix the expectations for crypto/subtle tests after r202535.
https://bugs.webkit.org/show_bug.cgi?id=159260
Unreviewed.
- platform/gtk/TestExpectations: Skip properly the crypto/subtle tests.
- 5:21 AM Changeset in webkit [202622] by
-
- 2 edits in trunk/Tools
[GTK] Add missing install dependency after r202619
https://bugs.webkit.org/show_bug.cgi?id=156716
Unreviewed.
- gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
- 5:16 AM Changeset in webkit [202621] by
-
- 14 edits in trunk/Source/WebKit2
Too much duplicated code in LayerTreeHosts implementations
https://bugs.webkit.org/show_bug.cgi?id=159144
Reviewed by Žan Doberšek.
There's some code common and duplicated in all current LayerTreeHosts implementations (Gtk, Coordinated, and
ThreadedCoordinated). The thing is even worse in the case of ThreadedCoordinated and Coordinated, where the
former is actually a special case of the later, and it seems like code was copy pasted and then modified to add
ThreadedCoordinated specific code. The problem of that approach, apart from the code duplication, is that common
parts end up diverging too. This patch moves the common parts to the base class LayerTreeHost and makes
ThreadedCoordinatedLayerTreeHost inherit from CoordinatedLayerTreeHost, to share the common code and simply add
the specific one.
- PlatformGTK.cmake:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::scheduleLayerFlush):
(WebKit::CoordinatedLayerTreeHost::setViewOverlayRootLayer):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface):
(WebKit::CoordinatedLayerTreeHost::cancelPendingLayerFlush): Deleted.
(WebKit::CoordinatedLayerTreeHost::forceRepaint): Deleted.
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Deleted.
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer): Deleted.
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged): Deleted.
(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged): Deleted.
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory): Deleted.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost):
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange):
(WebKit::ThreadedCoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::ThreadedCoordinatedLayerTreeHost::commitSceneState):
(WebKit::ThreadedCoordinatedLayerTreeHost::create): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::contentsSizeChanged): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportProperties): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::didScaleFactorChanged): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::setNativeSurfaceHandleForCompositing): Deleted.
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::layerHostDidFlushLayers):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::~LayerTreeHost):
(WebKit::LayerTreeHost::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHost::pauseRendering):
(WebKit::LayerTreeHost::resumeRendering):
(WebKit::LayerTreeHost::invalidate):
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::layerTreeContext):
(WebKit::LayerTreeHost::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHost::scrollNonCompositedContents):
(WebKit::LayerTreeHost::graphicsLayerFactory):
(WebKit::LayerTreeHost::contentsSizeChanged):
(WebKit::LayerTreeHost::didChangeViewportProperties):
(WebKit::LayerTreeHost::setNativeSurfaceHandleForCompositing):
(WebKit::LayerTreeHost::setViewOverlayRootLayer):
(WebKit::LayerTreeHost::forceRepaintAsync): Deleted.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::invalidate):
(WebKit::LayerTreeHostGtk::setViewOverlayRootLayer):
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Deleted.
(WebKit::LayerTreeHostGtk::setRootCompositingLayer): Deleted.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay): Deleted.
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents): Deleted.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing): Deleted.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 4:52 AM Changeset in webkit [202620] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in debug build when creating the SocketStreamHandle object.
We have to call relaxAdoptionRequirement to avoid the assertion
when protecting the non-adopted SocketStreamHandle we are
creating. Update to r202370.
Rubber-stamped by Carlos Garcia Campos.
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- 3:52 AM RebaselineServer edited by
- NWRT has superceded old run-webkit-tests (diff)
- 3:47 AM WikiStart edited by
- Fixed typo momory -> memory (diff)
- 3:31 AM Changeset in webkit [202619] by
-
- 9 edits3 adds in trunk
[GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
https://bugs.webkit.org/show_bug.cgi?id=156716
Reviewed by Carlos Garcia Campos and Michael Catanzaro.
Tools:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
(parse_args):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
(GtkPort._driver_class):
(GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
(GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
platform directory for storing the wayland specific layout test results and expectations for ${port}.
For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
test expectations file on the GTK port when running the tests with the --wayland command line switch.
Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
- Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
(WestonDriver.check_driver):
(WestonDriver.init):
(WestonDriver._start):
- Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
(WestonXvfbDriverDisplayTest):
(WestonXvfbDriverDisplayTest.init):
(WestonXvfbDriverDisplayTest._xvfb_run):
(WestonDriverTest.make_driver):
(WestonDriverTest.test_start):
- gtk/install-dependencies: Add the new dependencies that are required for either building weston,
or to satisfy the pkg-config check of the new added modules in JHBuild.
- gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
provided by the system are already new enough.
Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
It was the only way to get the software EGL rasterizer working without depending on user drivers.
Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
feature to avoid building libdrm when the one provided by the system is new enough.
- gtk/jhbuildrc:
- gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
Xorg had no support for searching the DRI drivers on a custom path at runtime.
This patch implements support for that reusing the same variable that we use with Mesa to set the
custom path for the DRI drivers path.
LayoutTests:
- platform/gtk-wayland/TestExpectations: Added. Add initial Wayland specific test expectations.
- 3:28 AM Changeset in webkit [202618] by
-
- 2 edits in trunk/Tools
[WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
https://bugs.webkit.org/show_bug.cgi?id=159256
Patch by Alejandro G. Castro <alex@igalia.com> on 2016-06-29
Reviewed by Philippe Normand.
We need the last fixes in the repository to make the scream queue
work with apprtc.
- gtk/jhbuild.modules:
- 3:19 AM Changeset in webkit [202617] by
-
- 3 edits3 adds in trunk
Throw exceptions for invalid number of channels for ConvolverNode
<https://webkit.org/b/159238>
<rdar://problem/27020410>
Reviewed by Brent Fulgham.
Source/WebCore:
Fix based on a Blink change (patch by <rtoy@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5>
Test: webaudio/convolver-channels.html
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer): Throw an exception for
anything but 1, 2 or 4 channels.
LayoutTests:
Test based on a Blink change (patch by <rtoy@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5>
compatibility.js based on a Blink change (patch by <Raymond Toy>):
<https://chromium.googlesource.com/chromium/src.git/+/f846f5a461d1fcdbe5152898576c125058079ed1>
- webaudio/convolver-channels-expected.txt: Added.
- webaudio/convolver-channels.html: Added.
- webaudio/resources/compatibility.js: Added.
- 12:23 AM Changeset in webkit [202616] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r198782, r201043): [image-decoders] Flickering with some animated gif
https://bugs.webkit.org/show_bug.cgi?id=159089
Reviewed by Antonio Gomes.
There's some flickering when loading big enough animated gifs running the animation in a loop. The first time it
loads everything is fine, but after the first loop iteration there are several flickering effects, once every
time the animation finishes and some others happening in the middle of the animation loop. The flickering
happens because we fail to render some of the frames, and it has two diferent causes:
- In r198782, ImageDecoder::createFrameImageAtIndex(), was modified to check first if the image is empty to
return early, and then try to get the frame image from the decoder. This is the aone causing the flickering
always on the first frame after one iteration. It happens because ImageDecoder::size() is always empty at that
point. The first time doesn't happen because the gif is loaded and BitmapImage calls isSizeAvailable() from
BitmapImage::dataChanged(). The isSizeAvailable call makes the gif decoder calculate the size. But for the next
iterations, frames are cached and BitmapImage already has the decoded data so isSizeAvailable is not called
again. When createFrameImageAtIndex() is called again for the first frame, size is empty until the gif decoder
creates the reader again, which happens when frameBufferAtIndex() is called, so after that the size is
available. So, we could call isSizeAvailable before checking the size, or simply do the check after the
frameBufferAtIndex() call as we used to do.
- In r201043 BitmapImage::destroyDecodedDataIfNecessary() was fixed to use the actual bytes used by the frame
in order to decide whether to destroy decoded data or not. This actually revealed a bug, it didn't happen before
because we were never destroying frames before. The bug is in the gif decoder that doesn't correctly handle the
case of destroying only some of the frames from the buffer cache. The gif decoder is designed to always process the
frames in order, the reader keeps an index of the currently processed frame, so when some frames are read from the
cache, and then we ask the decoder for a not cached frame, the currently processed frame is not in sync with the
actual frame we are asking for, and we end do not processing any frame at all.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::createFrameImageAtIndex): Check the size after calling frameBufferAtIndex().
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache): Delete the reader when clearing the cache since it's out of sync.
Jun 28, 2016:
- 11:33 PM Changeset in webkit [202615] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Adaptive streaming issues
https://bugs.webkit.org/show_bug.cgi?id=144040
Reviewed by Philippe Normand.
There are multiple deadlocks in the web process when HLS content is loaded by GStreamer. It happens because gst
is using several threads to download manifest, fragments, monitor the downloads, etc. To download the fragments
and manifest it always creates the source element in a separate thread, something that is not actually expected
to happen in WebKit source element. Our source element is always scheduling tasks (start, stop, need-data,
enough-data and seek) to the main thread, and those downloads that use the ResourceHandleStreamingClient
(there's no player associated) also happen in the main thread, because libsoup calls all its async callbacks in
the main thread. So, the result is that it can happen that we end up blocking the main thread in a lock until
the download finishes, but the download never finishes because tasks are scheduled in the main thread that is
blocked in a lock. This can be prevented by always using a secondary thread for downloads made by
ResourceHandleStreamingClient, using its own run loop with a different GMainContext so that libsoup sends
callbacks to the right thread. We also had to refactor the tasks a bit, leaving the thread safe parts to be run
in the calling thread always, and only scheduling to the main thread in case of not using
ResourceHandleStreamingClient and only for the non thread safe parts.
This patch also includes r200455 that was rolled out, but it was a perfectly valid workaround for GST bug.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::ensureGRef): Consume the floating ref if needed.
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init): Check if object is being created in the main thread.
(webKitWebSrcStop): Stop the media resource loader in the main thread and the resource handle streaming in the
current thread.
(webKitWebSrcStart): Start the media resource loader in the main thread and the resource handle streaming in
the current thread.
(webKitWebSrcChangeState): Call webKitWebSrcStart and webKitWebSrcStop in the current thread.
(webKitWebSrcNeedData): Update status in the current thread and notify the media resource loader in the main thread.
(webKitWebSrcEnoughData): Ditto.
(webKitWebSrcSeek): Ditto.
(webKitWebSrcSetMediaPlayer): Add an assert to ensure that source elements used by WebKit are always created in
the main thread.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Use a secondary thread to do the download.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Stop the secondary thread.
(ResourceHandleStreamingClient::setDefersLoading): Notify the secondary thread.
- 11:25 PM Changeset in webkit [202614] by
-
- 9 edits in trunk/Source/WebCore
Remove ThreadableLoaderOptions origin
https://bugs.webkit.org/show_bug.cgi?id=159221
Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-28
Reviewed by Sam Weinig.
No change of behavior.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Adding origing parameter.
(WebCore::DocumentThreadableLoader::create): Ditto.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::redirectReceived): Setting m_origin.
(WebCore::DocumentThreadableLoader::securityOrigin): Checking m_origin.
- loader/DocumentThreadableLoader.h: Adding m_origin member.
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Removing origin.
(WebCore::ThreadableLoaderOption::isolatedCopy): Deleted.
- loader/ThreadableLoader.h: Removing origin parameter and isolatedCopy function.
- loader/WorkerThreadableLoader.cpp:
(WebCore::LoaderTaskOptions::LoaderTaskOptions): Structure to pass loader task options from one thread to another.
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- page/EventSource.cpp:
(WebCore::EventSource::connect): Removing setting of the origin.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously): Ditto.
(WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Ditto.
- 10:55 PM Changeset in webkit [202613] by
-
- 2 edits8 adds in trunk/PerformanceTests
ES6SampleBench should have a harness
https://bugs.webkit.org/show_bug.cgi?id=159246
Reviewed by Saam Barati.
This adds a simple web harness for ES6SampleBench. It runs Air and Basic 10 times for 200
iterations each and reports three metrics:
First iteration: the time it takes for the first iteration to run. This is the first
iteration after the benchmark is loaded into the iframe, so it's representative of what
would happen if one of these workloads only ran for a short time.
Worst 2%: of the last 199 iterations, the average of the worst 2% iterations. If code like
any of these workloads was used in an important event handler, you'd want that code to run
well in the worst case in addition to having great throughput.
Steady state: the total of the last 199 iterations. This is representative of what would
happen if you ran code like this for a long time.
The total score is the geomean of the firstIteration/worstCase/steadyState numbers of the
two benchmarks.
The harness does statistics using Student's T-distribution confidence intervals.
- ES6SampleBench/Basic/benchmark.js:
(Benchmark):
- ES6SampleBench/air_benchmark.js: Added.
- ES6SampleBench/basic_benchmark.js: Added.
- ES6SampleBench/driver.js: Added.
(Driver):
(Driver.prototype.addBenchmark):
(Driver.prototype.start):
(Driver.prototype.reportResult):
(Driver.prototype.reportError):
(Driver.prototype._recomputeSummary.Geomean):
(Driver.prototype._recomputeSummary.Geomean.prototype.add):
(Driver.prototype._recomputeSummary.Geomean.prototype.get result):
(Driver.prototype._recomputeSummary):
(Driver.prototype._iterate):
(Driver.prototype._updateIterations):
- ES6SampleBench/glue.js: Added.
- ES6SampleBench/index.html: Added.
- ES6SampleBench/results.js: Added.
(Results):
(Results.prototype.get benchmark):
(Results.prototype.reset):
(Results.prototype.reportRunning):
(Results.prototype.reportDone):
(Results.prototype.reportResult.averageAbovePercentile):
(Results.prototype.reportResult):
(Results.prototype.reportError):
- ES6SampleBench/stats.js: Added.
(Stats):
(Stats.prototype.reset):
(Stats.prototype.add):
(Stats.prototype.get numIterations):
(Stats.prototype.valueForIteration):
(Stats.get result.tDist):
(Stats.prototype.get result):
(Stats.prototype.toString):
(Stats.prototype._update):
- ES6SampleBench/style.css: Added.
(body):
(body, th, tr):
(h1, h2, h3, h4):
(h1):
(h2):
(h3):
(hr):
(address):
(img):
(.underline):
(ol.loweralpha):
(ol.upperalpha):
(ol.lowerroman):
(ol.upperroman):
(ol.arabic):
(.banner-link:link, .banner-link:visited):
(:link, :visited):
(h4 :link, h4 :visited, h5 :link, h5 :visited, h6 :link, h6 :visited):
(.anchor:link, .anchor:visited):
(* > .anchor:link, * > .anchor:visited):
(span:hover .anchor):
(a.forbidden, span.forbidden):
(a.missing:hover):
(a.closed:link, a.closed:visited, span.closed):
(pre):
(div.code):
(div.code pre):
(dt):
(dd):
(dd:last-child):
(.site-logo):
(.site-logo .tagline):
(table):
(#contents):
(p):
(p:last-child):
(th):
(td):
- 10:04 PM Changeset in webkit [202612] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed, rolling out r202586 and r202595.
https://bugs.webkit.org/show_bug.cgi?id=159247
These changes broke the iOS build (Requested by ryanhaddad on
#webkit).
Reverted changesets:
"Keep track of when a WKWebView is blank before the initial
non-empty layout"
https://bugs.webkit.org/show_bug.cgi?id=159217
http://trac.webkit.org/changeset/202586
"Try to fix the build."
http://trac.webkit.org/changeset/202595
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-28
- 9:49 PM Changeset in webkit [202611] by
-
- 89 edits in trunk
Unreviewed, rolling out r202580.
https://bugs.webkit.org/show_bug.cgi?id=159245
Caused all WKTR tests to fail on GuardMalloc and Production
only for unknown reasons, investigating offline. (Requested by
brrian on #webkit).
Reverted changeset:
"RunLoop::Timer should use constructor templates instead of
class templates"
https://bugs.webkit.org/show_bug.cgi?id=159153
http://trac.webkit.org/changeset/202580
- 9:31 PM Changeset in webkit [202610] by
-
- 1 edit3 adds in trunk/LayoutTests
AX: Add accessibility tests for MathML operators
https://bugs.webkit.org/show_bug.cgi?id=124836
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
Reviewed by Joanmarie Diggs.
We add one test to verify the (sub)roles of MathML operators with various fence and separator
properties. These properties can be set via an explicit attribute or read from the operator
dictionary.
- accessibility/math-mo-fences-and-separators.html: Added.
- platform/gtk/accessibility/math-mo-fences-and-separators-expected.txt: Added.
- platform/mac/accessibility/math-mo-fences-and-separators-expected.txt: Added.
- 9:17 PM Changeset in webkit [202609] by
-
- 23 edits in trunk/LayoutTests
Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message
<https://webkit.org/b/159232>
Reviewed by Brent Fulgham.
Based on a Blink change (patch by <hongchan@chromium.org>):
<https://src.chromium.org/viewvc/blink?view=revision&revision=192204>
Currently, shouldNotThrow() and shouldThrow() take the following
arguments:
shouldNotThrow(evalString)
shouldThrow(evalString, expectedExceptionString)
The challenges with this design are:
1) The 'evalString' must capture every variable that it
needs, which means the code can be long, and concatenated
into a single line. It would be really nice to be able
to use an (anonymous) function to capture variables
instead.
2) The 'evalString' is literally printed out in the test
results, which isn't always the most descriptive. A
descriptive message would make it clearer what failed.
3) When changing a shouldThrow() into a shouldNotThrow()
or copying/pasting code, it's possible to forget to
remove 'expectedExceptionString' from the function call.
This patch changes the methods to take the following arguments:
shouldNotThrow(evalString|function [, message])
shouldThrow(evalString|function, expectedExceptionString [, message])
If 'function' is passed in, then it is invoked instead of
evaluated, and 'message' replaces the literal code in the
pass/fail output.
This patch also adds the global 'didFailSomeTests' variable to
js-test.js, which already exists in js-test-pre.js. This was
added to js-test-pre.js in r153203 by Oliver Hunt to
LayoutTests/fast/js/resources/js-test-pre.js.
- fast/canvas/webgl/canvas-supports-context-expected.txt:
- fast/canvas/webgl/gl-bind-attrib-location-before-compile-test-expected.txt:
- fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
- fast/dom/getElementsByClassName/ASCII-case-insensitive-expected.txt:
- storage/indexeddb/cursor-basics-expected.txt:
- storage/indexeddb/cursor-basics-private-expected.txt:
- Update expected results to include "Some tests fail." since some subtests actually do fail during these tests.
- fast/css/parsing-css-lang.html:
- fast/css/parsing-css-matches-1.html:
- fast/css/parsing-css-matches-2.html:
- fast/css/parsing-css-matches-3.html:
- fast/css/parsing-css-matches-4.html:
- fast/css/parsing-css-not-1.html:
- fast/css/parsing-css-not-2.html:
- fast/css/parsing-css-not-3.html:
- fast/css/parsing-css-not-4.html:
- fast/css/parsing-css-nth-child-of-1.html:
- fast/css/parsing-css-nth-child-of-2.html:
- fast/css/parsing-css-nth-last-child-of-1.html:
- fast/css/parsing-css-nth-last-child-of-2.html:
- js/script-tests/arrowfunction-supercall.js:
- Remove expectedExceptionString from shouldNotThrow() calls after they were changed from shouldThrow() calls.
- resources/js-test-pre.js:
(shouldNotThrow): Change to invoke first argument if it is a
function, else use eval() as before. Use second argurment in
place of first argument (if set) when printing results. NOTE:
Care was taken not to add any lines of code to prevent changes
to test results.
(shouldThrow): Ditto. Reformat code.
- resources/js-test.js: Declare 'didFailSomeTests'.
(testFailed): Set 'didFailSomeTests' to true when a test fails.
(shouldNotThrow): Same changes as js-test-pre.js.
(shouldThrow): Ditto.
(isSuccessfullyParsed): Output a message if 'didFailSomeTests'
is true.
- 9:06 PM Changeset in webkit [202608] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
We should not crash there is a finally inside a for-in loop
https://bugs.webkit.org/show_bug.cgi?id=159243
<rdar://problem/27018910>
Reviewed by Benjamin Poulain.
Previously we would swap the m_forInContext with an empty vector
then attempt to shrink the size of m_forInContext by the amount
we expected. This meant that if there was more than one ForInContext
on the stack and we wanted to pop exactly one off we would crash.
This patch makes ForInContexts RefCounted so they can be duplicated
into other vectors. It also has ForInContexts copy the entire stack
rather than do the swap that we did before. This makes ForInContexts
work the same as the other contexts.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):
- bytecompiler/BytecodeGenerator.h:
- tests/stress/finally-for-in.js: Added.
(repeat):
(createSimple):
- 9:03 PM Changeset in webkit [202607] by
-
- 5 edits in trunk/Source/WebCore
Rename ChildrenAffectedByActive to StyleAffectedByActive
https://bugs.webkit.org/show_bug.cgi?id=159187
Reviewed by Antti Koivisto.
Flags named "ChildrenAffectedBy" are used when the invalidation
of children is so crazy that we invalidate the whole parent subtree instead.
That's not the case for :active. It is a straightforward element invalidation.
Consequently, the property is renamed to StyleAffectedByActive.
- dom/Element.cpp:
(WebCore::Element::setActive):
(WebCore::Element::setStyleAffectedByActive):
(WebCore::Element::hasFlagsSetDuringStylingOfChildren):
(WebCore::Element::rareDataStyleAffectedByActive):
(WebCore::Element::setChildrenAffectedByActive): Deleted.
(WebCore::Element::rareDataChildrenAffectedByActive): Deleted.
- dom/Element.h:
(WebCore::Element::styleAffectedByActive):
(WebCore::Element::childrenAffectedByActive): Deleted.
- dom/ElementRareData.h:
(WebCore::ElementRareData::styleAffectedByActive):
(WebCore::ElementRareData::setStyleAffectedByActive):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetDynamicRestyleObservations):
(WebCore::ElementRareData::childrenAffectedByActive): Deleted.
(WebCore::ElementRareData::setChildrenAffectedByActive): Deleted.
- style/StyleRelations.cpp:
(WebCore::Style::commitRelations):
- 8:56 PM Changeset in webkit [202606] by
-
- 4 edits in trunk/Tools
Use a regex to check if a test step is for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=159224
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-06-28
Reviewed by Geoffrey Garen.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
- 8:53 PM Changeset in webkit [202605] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r202598.
https://bugs.webkit.org/show_bug.cgi?id=159244
broke the build. (Requested by keith_miller on #webkit).
Reverted changeset:
"Try to fix the build."
http://trac.webkit.org/changeset/202598
- 7:26 PM Changeset in webkit [202604] by
-
- 2 edits in trunk/Tools
btjs no longer accepts optional frame count argument
https://bugs.webkit.org/show_bug.cgi?id=159235
Reviewed by Saam Barati.
Fix the detection of optional backtrace-depth parameter to use the length
of the command.
- lldb/lldb_webkit.py:
(btjs):
- 7:07 PM Changeset in webkit [202603] by
-
- 2 edits in trunk/Tools
Update animometer.plan
Rubber-stamped by Said Abou-Hallawa.
- Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
- 7:06 PM Changeset in webkit [202602] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Assertion failure or crash when accessing let-variable in TDZ with eval with a function in it that returns let variable
https://bugs.webkit.org/show_bug.cgi?id=158796
<rdar://problem/26984659>
Reviewed by Michael Saboff.
There was a bug where some functions inside of an eval were
omitting a necessary TDZ check. This obviously leads to bad
things because a variable under TDZ is the null pointer.
The eval's bytecode was generated with the correct TDZ set, but
it created all its functions before pushing that TDZ set onto
the stack. That's a mistake. Those functions need to be created with
that TDZ set. The solution is simple, the TDZ set that the eval
is created with needs to be pushed onto the TDZ stack before
the eval creates any functions.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- tests/stress/variable-under-tdz-eval-tricky.js: Added.
(assert):
(throw.new.Error):
(assert.try.underTDZ):
- 6:52 PM Changeset in webkit [202601] by
-
- 4 edits2 copies in trunk/PerformanceTests
Update focus test
https://bugs.webkit.org/show_bug.cgi?id=159242
rdar://problem/27070007
Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.
Move previous test to dom suite, and update the test for better reporting of frame rate, although
it uses a different rendering path.
- Animometer/resources/debug-runner/tests.js: Add to dom suite.
- Animometer/tests/dom/focus.html: Copied from PerformanceTests/Animometer/tests/master/focus.html.
- Animometer/tests/dom/resources/focus.js: Copied from PerformanceTests/Animometer/tests/master/resources/focus.js.
- Animometer/tests/master/focus.html: Remove center element.
- Animometer/tests/master/resources/focus.js: Use narrower size range with smaller particles. Remove the
container elements. Inline getBlurValue and getOpacityValue since they are only called once.
- 6:37 PM Changeset in webkit [202600] by
-
- 1 edit1 add in trunk/Websites/webkit.org
Add a more interactive version of the demo.
- blog-files/color-gamut/comparison.html: Added.
- 6:04 PM Changeset in webkit [202599] by
-
- 14 edits4 adds in trunk
Implement "replacement" codec
https://bugs.webkit.org/show_bug.cgi?id=159180
<rdar://problem/26015178>
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
- web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
Source/WebCore:
Test: fast/encoding/charset-replacement.html
Add support for "replacement" codec according to the spec:
https://encoding.spec.whatwg.org/#replacement
According to the spec, encoding labels {"csiso2022kr", "hz-gb-2312", "iso-2022-cn",
"iso-2022-cn-ext", "iso-2022-kr"} are used to conduct certain attacks that abuse
a mismatch between encodings supported on the server and the client. Therefore,
they are grouped under the "replacement" codec, which does the following things
to prevent those attacks.
1) Decode: terminates with a single U+FFFD.
2) Encode: treated as UTF-8.
Furthermore, the "replacement" codec is a specification convenience to group those
vulnerable encoding labels. Therefore, it should not be able to use directly.
This change is based on the following Blink changes:
https://codereview.chromium.org/265973003, and
https://codereview.chromium.org/261013007.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextAllInOne.cpp:
- platform/text/TextCodecReplacement.cpp: Added.
(WebCore::TextCodecReplacement::create):
(WebCore::TextCodecReplacement::TextCodecReplacement):
(WebCore::TextCodecReplacement::registerEncodingNames):
(WebCore::TextCodecReplacement::registerCodecs):
(WebCore::TextCodecReplacement::decode):
- platform/text/TextCodecReplacement.h: Added.
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::TextEncoding):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::isReplacementEncoding):
(WebCore::extendTextCodecMaps):
- platform/text/TextEncodingRegistry.h:
LayoutTests:
- fast/encoding/char-decoding-expected.txt:
- fast/encoding/char-decoding.html:
- fast/encoding/char-encoding-expected.txt:
- fast/encoding/char-encoding.html:
- fast/encoding/charset-replacement-expected.txt: Added.
- fast/encoding/charset-replacement.html: Added.
- 5:47 PM Changeset in webkit [202598] by
-
- 3 edits in trunk/Source/WebKit2
- UIProcess/API/Cocoa/WKWebView.mm:
(convertSystemLayoutDirection):
(-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]):
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- 5:38 PM Changeset in webkit [202597] by
-
- 5 edits in trunk
REGRESSION (r200946): Improper backtracking from last alternative in sticky patterns
https://bugs.webkit.org/show_bug.cgi?id=159233
Reviewed by Mark Lam.
Source/JavaScriptCore:
Jump to fail exit code when the last alternative of a sticky pattern fails.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::backtrack):
LayoutTests:
Updated tests.
- js/regexp-sticky-expected.txt:
- js/script-tests/regexp-sticky.js:
- 5:18 PM Changeset in webkit [202596] by
-
- 2 edits in trunk/LayoutTests
Marking fast/images/composited-animated-gif-outside-viewport.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=157592
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:12 PM BadContent edited by
- (diff)
- 4:07 PM Changeset in webkit [202595] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the build.
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- 3:16 PM Changeset in webkit [202594] by
-
- 2 edits in trunk/Tools
Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- 3:12 PM Changeset in webkit [202593] by
-
- 2 edits in trunk/Websites/webkit.org
Fixed tile height for mobile phone-sized viewports.
https://bugs.webkit.org/show_bug.cgi?id=159228
Reviewed by Timothy Hatcher.
Prevents cutoff text for featured tiles and prevents overlapping text and controls on the Twitter tile for phone-sized viewports.
- wp-content/themes/webkit/style.css:
(.twitter-tile.text-only .tile-content):
(.tile):
- 3:11 PM Changeset in webkit [202592] by
-
- 2 edits in trunk/Source/WebCore
Remove incorrect comments in HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=159229
Reviewed by Sam Weinig.
These comments are wrong.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::probablySupportsContext):
(WebCore::HTMLCanvasElement::getContext): Deleted.
- 3:09 PM Changeset in webkit [202591] by
-
- 2 edits2 moves1 add in trunk/PerformanceTests
Move Air.js and Basic into ES6SampleBench
Rubber stamped by Geoffrey Garen.
We want to group our ES6 benchmarks together, and eventually, we want to give them a
common harness.
- Air.js: Removed.
- Air.js/README.md: Removed.
- Air.js/airjs-tests.yaml: Removed.
- Air.js/all.js: Removed.
- Air.js/allocate_stack.js: Removed.
- Air.js/arg.js: Removed.
- Air.js/basic_block.js: Removed.
- Air.js/benchmark.js: Removed.
- Air.js/code.js: Removed.
- Air.js/custom.js: Removed.
- Air.js/frequented_block.js: Removed.
- Air.js/insertion_set.js: Removed.
- Air.js/inst.js: Removed.
- Air.js/liveness.js: Removed.
- Air.js/make_dist.sh: Removed.
- Air.js/opcode.js: Removed.
- Air.js/payload-airjs-ACLj8C.js: Removed.
- Air.js/payload-gbemu-executeIteration.js: Removed.
- Air.js/payload-imaging-gaussian-blur-gaussianBlur.js: Removed.
- Air.js/payload-typescript-scanIdentifier.js: Removed.
- Air.js/reg.js: Removed.
- Air.js/stack_slot.js: Removed.
- Air.js/stress-test.js: Removed.
- Air.js/strip-hash.rb: Removed.
- Air.js/symbols.js: Removed.
- Air.js/test.html: Removed.
- Air.js/test.js: Removed.
- Air.js/tmp.js: Removed.
- Air.js/tmp_base.js: Removed.
- Air.js/util.js: Removed.
- Basic: Removed.
- Basic/ast.js: Removed.
- Basic/basic.js: Removed.
- Basic/benchmark.js: Removed.
- Basic/caseless_map.js: Removed.
- Basic/lexer.js: Removed.
- Basic/number.js: Removed.
- Basic/parser.js: Removed.
- Basic/random.js: Removed.
- Basic/state.js: Removed.
- Basic/test.html: Removed.
- Basic/test.js: Removed.
- Basic/util.js: Removed.
- ES6SampleBench: Added.
- ES6SampleBench/Air: Copied from PerformanceTests/Air.js.
- ES6SampleBench/Basic: Copied from PerformanceTests/Basic.
- Skipped:
- 2:35 PM Changeset in webkit [202590] by
-
- 4 edits in trunk/Source/WebCore
CrashTracer beneath JSC::MarkedBlock::specializedSweep
https://bugs.webkit.org/show_bug.cgi?id=159223
Reviewed by Saam Barati.
This crash is caused by a media element re-entering JS during the GC
sweep phase.
In theory, other CachedResourceClients in the DOM might also trigger
similar bugs, but our data only implicates the media elements, so this
fix targets them.
- html/HTMLDocument.h: Document has no reason to inherit from
CachedResourceClient. I found this becuase I had to search for all
CachedResourceClients in researching this patch.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::invalidate): Delay our call to
stopLoading because it might re-enter JS, and we might have been called
by the GC sweep phase destroying a media element.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::invalidate): Ditto.
- 2:33 PM Changeset in webkit [202589] by
-
- 3 edits in trunk/Source/WebInspectorUI
REGRESSION (r188730): Web Inspector: Warning icons incorrectly positioned in CSS Rules sidebar
https://bugs.webkit.org/show_bug.cgi?id=157869
<rdar://problem/26356520>
Reviewed by Timothy Hatcher.
Before r188730, CSS text always had a line break as a prefix. r188730 started trimming text.
This patch keeps trimming unnecessary whitespace but brings back required line break prefix.
- UserInterface/Models/CSSStyleDeclaration.js:
(WebInspector.CSSStyleDeclaration.prototype.set text):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
Make PrefixWhitespace and SuffixWhitespace public.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
Remove an if conditional as it's always true.
- 2:30 PM Changeset in webkit [202588] by
-
- 29 edits in trunk/Source
some Watchpoints' ::fireInternal method will call operations that might GC where the GC will cause the watchpoint itself to destruct
https://bugs.webkit.org/show_bug.cgi?id=159198
<rdar://problem/26302360>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Firing a watchpoint may cause a GC to happen. This GC could destroy various
Watchpoints themselves while they're in the process of firing. It's not safe
for most Watchpoints to be destructed while they're in the middle of firing.
This GC could also destroy the WatchpointSet itself, and it's not in a safe
state to be destroyed. WatchpointSet::fireAllWatchpoints now defers gc for a
while. This prevents a GC from destructing any Watchpoints while they're
in the process of firing. This bug was being hit by the stress GC bots
because we would destruct a particular Watchpoint while it was firing,
and then we would access its field after it had already been destroyed.
This was causing all kinds of weird symptoms. Also, this was easier to
catch when running with guard malloc because the first access after
destruction would lead to a crash.
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
- bytecode/VariableWriteFireDetail.cpp:
(JSC::VariableWriteFireDetail::dump):
(JSC::VariableWriteFireDetail::touch):
- bytecode/VariableWriteFireDetail.h:
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::fireAllSlow):
(JSC::WatchpointSet::fireAllWatchpoints):
(JSC::InlineWatchpointSet::add):
(JSC::InlineWatchpointSet::fireAll):
(JSC::InlineWatchpointSet::inflateSlow):
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::startWatching):
(JSC::WatchpointSet::fireAll):
(JSC::WatchpointSet::touch):
(JSC::WatchpointSet::invalidate):
(JSC::WatchpointSet::isBeingWatched):
(JSC::WatchpointSet::offsetOfState):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::fireAll):
(JSC::InlineWatchpointSet::invalidate):
(JSC::InlineWatchpointSet::touch):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jit/JITOperations.cpp:
- jsc.cpp:
(WTF::Masquerader::create):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ArrayBufferNeuteringWatchpoint.cpp:
(JSC::ArrayBufferNeuteringWatchpoint::fireAll):
- runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::clear):
- runtime/InferredType.cpp:
(JSC::InferredType::willStoreValueSlow):
(JSC::InferredType::makeTopSlow):
(JSC::InferredType::set):
(JSC::InferredType::removeStructure):
(JSC::InferredType::InferredStructureWatchpoint::fireInternal):
- runtime/InferredValue.cpp:
(JSC::InferredValue::notifyWriteSlow):
(JSC::InferredValue::ValueCleanup::finalizeUnconditionally):
- runtime/InferredValue.h:
(JSC::InferredValue::notifyWrite):
(JSC::InferredValue::invalidate):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::haveABadTime):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTablePutTouchWatchpointSet):
(JSC::symbolTablePutInvalidateWatchpointSet):
- runtime/Structure.cpp:
(JSC::Structure::didCachePropertyReplacement):
(JSC::Structure::startWatchingInternalProperties):
(JSC::DeferredStructureTransitionWatchpointFire::~DeferredStructureTransitionWatchpointFire):
(JSC::DeferredStructureTransitionWatchpointFire::add):
(JSC::Structure::didTransitionFromThisStructure):
(JSC::Structure::prototypeForLookup):
- runtime/StructureInlines.h:
(JSC::Structure::didReplaceProperty):
(JSC::Structure::propertyReplacementWatchpointSet):
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::isDontEnum):
(JSC::SymbolTableEntry::disableWatching):
- runtime/VM.cpp:
(JSC::VM::addImpureProperty):
(JSC::enableProfilerWithRespectToCount):
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
- 2:27 PM Changeset in webkit [202587] by
-
- 2 edits in trunk/LayoutTests
Rebaseline http/tests/media/video-auth.html for WK2
https://bugs.webkit.org/show_bug.cgi?id=159195
Unreviewed test gardening.
- platform/wk2/http/tests/media/video-auth-expected.txt:
- 2:10 PM Changeset in webkit [202586] by
-
- 4 edits in trunk/Source/WebKit2
Keep track of when a WKWebView is blank before the initial non-empty layout
https://bugs.webkit.org/show_bug.cgi?id=159217
<rdar://problem/26071766>
Reviewed by Beth Dakin.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]):
(-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
- 2:03 PM Changeset in webkit [202585] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSRopeString should use release asserts, not debug asserts, about substring bounds
https://bugs.webkit.org/show_bug.cgi?id=159227
Reviewed by Saam Barati.
According to my experiments this change costs nothing. That's not surprising since the
most common way to construct a rope these days is inlined into the JIT, which does its own
safety checks. This makes us crash sooner rather than corrupting memory.
- runtime/JSString.h:
- 2:02 PM Changeset in webkit [202584] by
-
- 2 edits in trunk/Source/WebCore
Move the user gesture requirement to the ApplePaySession constructor
https://bugs.webkit.org/show_bug.cgi?id=159225
rdar://problem/26507267
Reviewed by Tim Horton.
By doing this, clients can do pre-validation before showing the sheet, while we still maintain the user gesture requirement.
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::begin): Deleted.
- 1:19 PM Changeset in webkit [202583] by
-
- 7 edits in trunk
Iterable interfaces should have their related prototype @@iterator property writable
https://bugs.webkit.org/show_bug.cgi?id=159211
Source/WebCore:
<rdar://problem/26950766>
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-28
Reviewed by Chris Dumez.
Updating @@iterator property according http://heycam.github.io/webidl/#es-iterator.
Covered by updated test.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Removing ReadOnly flag from @@iterator property of iterable interfaces.
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation): Rebasing expectation.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation): Ditto.
LayoutTests:
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-28
Reviewed by Chris Dumez.
- fast/dom/nodeListIterator-expected.txt:
- fast/dom/nodeListIterator.html: Overriding NodeList @@iterator by Array one and checking everything is fine.
- 12:50 PM Changeset in webkit [202582] by
-
- 2 edits in trunk/Source/WebCore
"Total amount is too big" error message is displaying on clicking Pay button
https://bugs.webkit.org/show_bug.cgi?id=159219
rdar://problem/26722110
Reviewed by Tim Horton.
Match the PassKit max amount.
- Modules/applepay/PaymentRequestValidator.cpp:
(WebCore::PaymentRequestValidator::validateTotal):
- 12:31 PM Changeset in webkit [202581] by
-
- 12 edits1 copy in trunk/Source
PaymentMerchantSession should wrap a PKPaymentMerchantSession
https://bugs.webkit.org/show_bug.cgi?id=159218
rdar://problem/26872118
Reviewed by Tim Horton.
Source/WebCore:
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::completeMerchantValidation):
Use PaymentMerchantSession::fromJS.
(WebCore::createMerchantSession): Deleted.
- Modules/applepay/PaymentCoordinator.h:
PaymentMerchantSession is now a class.
- Modules/applepay/PaymentCoordinatorClient.h:
PaymentMerchantSession is now a class.
- Modules/applepay/PaymentMerchantSession.h:
(WebCore::PaymentMerchantSession::PaymentMerchantSession):
(WebCore::PaymentMerchantSession::~PaymentMerchantSession):
(WebCore::PaymentMerchantSession::pkPaymentMerchantSession):
Store a PKPaymentMerchantSession in a RetainPtr inside the PaymentMerchantSession object.
- Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
(WebCore::PaymentMerchantSession::fromJS):
Convert the JS object to a PKPaymentMerchantSession and return a PaymentMerchantSession that wraps it.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- bindings/js/Dictionary.h:
(WebCore::Dictionary::initializerObject):
Add new getter.
Source/WebKit2:
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode):
Use NSCoder.
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
PaymentMerchantSession is now a class.
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
PaymentMerchantSession is now a class.
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCompleteMerchantValidation):
Just get the underlying PKPaymentMerchantSession from the PaymentMerchantSession object.
(WebKit::toPKPaymentMerchantSession): Deleted.
- 12:10 PM Changeset in webkit [202580] by
-
- 89 edits in trunk
RunLoop::Timer should use constructor templates instead of class templates
https://bugs.webkit.org/show_bug.cgi?id=159153
Reviewed by Alex Christensen.
Source/JavaScriptCore:
Remove the RunLoop::Timer class template argument, and pass its constructor
a reference tothisinstead of a pointer tothis.
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Source/WebCore:
Remove the RunLoop::Timer class template argument, and pass its constructor
a reference tothisinstead of a pointer tothis.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::WebMediaSessionManager):
- Modules/mediasession/WebMediaSessionManager.h:
- page/WheelEventTestTrigger.cpp:
(WebCore::WheelEventTestTrigger::WheelEventTestTrigger):
- page/WheelEventTestTrigger.h:
- page/mac/TextIndicatorWindow.h:
- page/mac/TextIndicatorWindow.mm:
(WebCore::TextIndicatorWindow::TextIndicatorWindow):
- platform/MainThreadSharedTimer.h:
- platform/cocoa/ScrollController.h:
- platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::ScrollController):
- platform/glib/MainThreadSharedTimerGLib.cpp:
(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
- platform/graphics/MediaPlaybackTargetPicker.cpp:
(WebCore::MediaPlaybackTargetPicker::MediaPlaybackTargetPicker):
- platform/graphics/MediaPlaybackTargetPicker.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(VideoRenderRequestScheduler::VideoRenderRequestScheduler):
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::TextureMapperPlatformLayerProxy):
(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
- platform/mock/MediaPlaybackTargetPickerMock.cpp:
(WebCore::MediaPlaybackTargetPickerMock::MediaPlaybackTargetPickerMock):
- platform/mock/MediaPlaybackTargetPickerMock.h:
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
- platform/mock/MockRealtimeVideoSource.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Source/WebKit2:
Remove the RunLoop::Timer class template argument, and pass its constructor
a reference tothisinstead of a pointer tothis.
- NetworkProcess/Downloads/soup/DownloadSoup.cpp:
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
- PluginProcess/PluginProcess.h:
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
- Shared/ChildProcess.h:
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
- UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
(API::SharedJSContext::SharedJSContext):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::PluginInfoCache):
- UIProcess/Plugins/gtk/PluginInfoCache.h:
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::ProcessThrottler):
- UIProcess/ProcessThrottler.h:
- UIProcess/ResponsivenessTimer.cpp:
(WebKit::ResponsivenessTimer::ResponsivenessTimer):
- UIProcess/ResponsivenessTimer.h:
- UIProcess/ViewGestureController.cpp:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::SnapshotRemovalTracker::SnapshotRemovalTracker):
- UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::VisitedLinkStore):
- UIProcess/VisitedLinkStore.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::m_hiddenPageThrottlingTimer):
- UIProcess/WebProcessPool.h:
- UIProcess/gtk/GestureController.cpp:
(WebKit::GestureController::DragGesture::DragGesture):
(WebKit::GestureController::ZoomGesture::ZoomGesture):
- UIProcess/gtk/GestureController.h:
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
- UIProcess/gtk/WebPopupMenuProxyGtk.h:
- UIProcess/mac/ViewGestureController.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::WebLoaderStrategy):
- WebProcess/Network/WebLoaderStrategy.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::Timer::Timer):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::NetscapePluginStream):
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::RenderFrameScheduler::RenderFrameScheduler):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Source/WTF:
Refactor RunLoop::Timer to align with WebCore::Timer. Use a constructor
template instead of a class template. Store a bound std::function rather than
a templated member and function. Add a constructor that takes a std::function.
- wtf/RunLoop.h:
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):
Tools:
Remove the RunLoop::Timer class template argument, and pass its constructor
a reference tothisinstead of a pointer tothis.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- TestWebKitAPI/Tests/WTF/RunLoop.cpp:
(TestWebKitAPI::TEST):
- 11:25 AM Changeset in webkit [202579] by
-
- 5 edits in trunk
Cross-domain video loads do not prompt for authorization.
https://bugs.webkit.org/show_bug.cgi?id=159195
<rdar://problem/26234612>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/media/video-auth.html (modified)
We should prompt for authorization when a cross-origin <video> is embedded
in a web page.
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::requestResource):
LayoutTests:
Add a cross-origin authorization sub-test.
- http/tests/media/video-auth.html:
- http/tests/media/video-auth-expected.txt:
- 11:20 AM Changeset in webkit [202578] by
-
- 6 edits in trunk
REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
https://bugs.webkit.org/show_bug.cgi?id=159199
Source/WebCore:
<rdar://problem/26748189>
Reviewed by Alexey Proskuryakov.
The bug was caused by HTMLInputElement's endEditing no longer getting called due to the behavior change.
Preserve the WebKit2 API semantics by manually calling HTMLInputElement::endEditing in setFocusedElement.
Tests: WebKit2TextFieldDidBeginAndEndEditing
- dom/Document.cpp:
(WebCore::Document::setFocusedElement):
Tools:
Reviewed by Alexey Proskuryakov.
Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
- TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
- TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
an input element getting automatically focused on Mac.
- 11:12 AM Changeset in webkit [202577] by
-
- 2 edits1 add in trunk/Websites/webkit.org
Fixed Open Graph meta data and image entries.
https://bugs.webkit.org/show_bug.cgi?id=159167.
Reviewed by Timothy Hatcher.
This patch addresses Open Graph meta data issues:
- Added a high-resolution PNG of the WebKit logo because Facebook doesn't support SVG images
- Uses the first image of a page or post if not featured image is set
- Article date/time information should not be given for the homepage
- Added Facebook admins as per the Facebook Open Graph debugger
- wp-content/plugins/social-meta.php:
- wp-content/themes/webkit/images/ogimage.png: Added.
- 11:08 AM Changeset in webkit [202576] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Add some logging related to NetworkProcess suspension
https://bugs.webkit.org/show_bug.cgi?id=159178
Reviewed by Andreas Kling.
Add some logging related to NetworkProcess suspension to help debug
suspension issues.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::cancelPrepareToSuspend):
(WebKit::NetworkProcess::processDidResume):
- 11:08 AM Changeset in webkit [202575] by
-
- 5 edits in trunk/Source/WebKit2
Add some more UIProcess-side logging related to process assertions
https://bugs.webkit.org/show_bug.cgi?id=159188
Reviewed by Andreas Kling.
Add some more UIProcess-side logging related to process assertions
to help debug process suspension issues.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateActivityToken):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::didSetAssertionState):
- 11:07 AM Changeset in webkit [202574] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Do not suppress navigation snapshotting on session restore if we are not navigating right away
https://bugs.webkit.org/show_bug.cgi?id=159216
<rdar://problem/27058360>
Reviewed by Andreas Kling.
Do not suppress navigation snapshotting on session restore if we are not navigating
right away. The snapshot we already have may be outdated by the time we actually
navigate (e.g. Because the user scrolled) so we don't want to suppress snapshotting
in this case.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
- 10:23 AM Changeset in webkit [202573] by
-
- 3 edits in trunk/LayoutTests
Marking fast/multicol/fixed-stack.html as failing on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 10:01 AM Changeset in webkit [202572] by
-
- 5 edits in trunk
Phrasing content should be accepted in <mo> elements
https://bugs.webkit.org/show_bug.cgi?id=130245
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
Reviewed by Brent Fulgham.
Source/WebCore:
After r202420, the RenderMathMLOperator element no longer messes with anonymous block and
text nodes. Hence it is now safe to allow foreign content inside <mo>.
We extend foreign-element-in-token.html to cover the mo case.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::childShouldCreateRenderer): Remove the early return for <mo> so
that it accepts phrasing content children.
LayoutTests:
- mathml/presentation/foreign-element-in-token.html: Copy test cases to
check <mo> elements too.
- mathml/presentation/foreign-element-in-token-expected.txt: Add the
expectations for <mo>.
- 9:53 AM Changeset in webkit [202571] by
-
- 2 edits2 moves1 add in trunk/LayoutTests
Sierra test expectation gardening.
- platform/mac-elcapitan/fast/canvas: Added.
- platform/mac-elcapitan/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Copied from platform/mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt.
- platform/mac-elcapitan/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Copied from platform/mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt.
- platform/mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
Sierra matches cross-platform expectations.
- platform/mac/TestExpectations: Removed expectations for fast/canvas/canvas-strokeRect-alpha-shadow.html
- 9:45 AM Changeset in webkit [202570] by
-
- 10 edits in trunk/Source
WebKit::WebPaymentCoordinator leak
https://bugs.webkit.org/show_bug.cgi?id=159168
rdar://problem/26929772
Reviewed by Beth Dakin.
Source/WebCore:
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::~PaymentCoordinator):
Call paymentCoordinatorDestroyed().
- Modules/applepay/PaymentCoordinatorClient.h:
Rename mainFrameDestroyed to paymentCoordinatorDestroyed().
- loader/EmptyClients.cpp:
Source/WebKit/mac:
Update for WebCore changes.
- WebCoreSupport/WebPaymentCoordinatorClient.h:
- WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
(WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
Source/WebKit2:
Update for WebCore changes.
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::paymentCoordinatorDestroyed):
(WebKit::WebPaymentCoordinator::mainFrameDestroyed): Deleted.
- WebProcess/ApplePay/WebPaymentCoordinator.h:
- 8:36 AM Changeset in webkit [202569] by
-
- 4 edits in trunk/Source/WebCore
Remove anonymous in renderName for all MathML renderers but RenderMathMLOperator
https://bugs.webkit.org/show_bug.cgi?id=159114
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
Reviewed by Martin Robinson.
After r202420, the only anonymous MathML renderers are the RenderMathMLOperators created by
the mfenced element. Hence we remove the special case for anonymous in the renderName
implementation of most MathML renderers.
No new tests, behavior unchanged.
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLToken.h:
- 8:33 AM Changeset in webkit [202568] by
-
- 6 edits in trunk
Web Inspector: selectElement.options shows unexpected entries in console (named indexes beyond collection length)
https://bugs.webkit.org/show_bug.cgi?id=159192
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-28
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype.arrayIndexPropertyNames):
Start with an empty array because we just push valid indexes.
(InjectedScript.prototype._propertyDescriptors):
Avoid the >100 length requirement, and always treat the
array-like objects the same. The frontend currently
doesn't show named indexes for arrays anyways, so they
would have been unused.
LayoutTests:
- inspector/model/remote-object-get-properties-expected.txt:
- inspector/model/remote-object-get-properties.html:
- inspector/runtime/getProperties-expected.txt:
- 8:32 AM Changeset in webkit [202567] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Skip failing INTL test.
https://bugs.webkit.org/show_bug.cgi?id=159141
Reviewed by Brent Fulgham.
INTL is not enabled on Windows.
- tests/stress/intl-constructors-with-proxy.js:
(shouldBe):
- 8:12 AM Changeset in webkit [202566] by
-
- 7 edits in trunk
Web Inspector: QuickConsole should update its selection when RuntimeManager.defaultExecutionContextIdentifier changes
https://bugs.webkit.org/show_bug.cgi?id=159183
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Currently, the UI listens for state changes in the Frame tree to decide when to reset
the selected execution context back to its default value. This is no good, because this
should happen even if we have no UI (i.e., testing models only). The UI should simply
display changes to the model rather than driving them based on other model changes.
Move the logic to reset the execution context into RuntimeManager. When the selected
context changes, an event is fired which causes the QuickConsole to rebuild its path components.
- UserInterface/Controllers/RuntimeManager.js:
(WebInspector.RuntimeManager):
(WebInspector.RuntimeManager.prototype.set defaultExecutionContextIdentifier):
Fire an event when the execution context actually changes.
(WebInspector.RuntimeManager.prototype._frameExecutionContextsCleared):
Added. If the selected context was cleared, reset back to default.
- UserInterface/Models/Frame.js:
(WebInspector.Frame.prototype.clearExecutionContexts):
Include the contexts that were cleared so clients can match against them.
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole):
Use the proper constant name. Both the old and new names evaluated toundefined.
No need to keep track of the selected path component, it will always match the
defaultExecutionContextIdentifier in RuntimeManager.
(WebInspector.QuickConsole.prototype.get selectedExecutionContextIdentifier):
(WebInspector.QuickConsole.prototype.set selectedExecutionContextIdentifier):
Forward to RuntimeManager. This name is less awkward for the UI code that manages selections.
(WebInspector.QuickConsole.prototype._executionContextPathComponentsToDisplay):
Special-case for the main frame execution context.
(WebInspector.QuickConsole.prototype._framePageExecutionContextsChanged):
Remove indirection.
(WebInspector.QuickConsole.prototype._frameExecutionContextsCleared):
Fix the guard to handle undefined execution contexts in the case where it represents the main frame (undefined).
(WebInspector.QuickConsole.prototype._defaultExecutionContextChanged):
Rebuild when the model changes.
(WebInspector.QuickConsole.prototype._pathComponentSelected): Simplify.
(WebInspector.QuickConsole.prototype.get executionContextIdentifier):
(WebInspector.QuickConsole.prototype._removeExecutionContextPathComponentForFrame):
Move the fallback selection behavior into RuntimeManager.
(WebInspector.QuickConsole.prototype._updateExecutionContextPathComponentForFrame): Deleted.
This has been dead code ever since we removed iOS 6 legacy support.
LayoutTests:
Add a new test case for reverting to the top-level execution context when the selected context is destroyed.
- inspector/runtime/change-execution-context-identifier-expected.txt:
- inspector/runtime/change-execution-context-identifier.html:
- 8:10 AM Changeset in webkit [202565] by
-
- 6 edits in trunk
WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
https://bugs.webkit.org/show_bug.cgi?id=158831
Reviewed by Youenn Fablet.
Source/WebCore:
Use @operations slot in RTCPeerConnection type check.
Updated results of existing test.
- Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
Initialize @operations slot in constructor.
- Modules/mediastream/RTCPeerConnectionInternals.js:
(isRTCPeerConnection):
Use @operations slot in type check.
LayoutTests:
- fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt:
Flip some result lines from FAIL to PASS. Clean out unnecessary tests (third set).
- 8:05 AM Changeset in webkit [202564] by
-
- 4 edits in trunk/LayoutTests
Remove flakiness expectations for mathml/wbr-in-mroot-crash.html
https://bugs.webkit.org/show_bug.cgi?id=130353
Unreviewed gardening.
The flakiness seemed to be due to the timeout of mathml/very-large-stretchy-operators.html.
The latter was fixed in r202489, so we update the test expectations.
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- 7:43 AM Changeset in webkit [202563] by
-
- 4 edits in trunk/LayoutTests
Increase opacity of stretched operators in mo-stacked-glyphs.html
https://bugs.webkit.org/show_bug.cgi?id=159201
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
Reviewed by Martin Robinson.
The reftest mo-stacked-glyphs.html fails with small pixel differences invisible at the naked
eyes. We increase opacity of stretched operators in that test to reduce these differences and
make the test pass.
- mathml/presentation/mo-stacked-glyphs-expected.html: Increase opacity of stretched operators.
- mathml/presentation/mo-stacked-glyphs.html: Ditto.
- platform/gtk/TestExpectations: Remove failure expectation.
- 7:16 AM Changeset in webkit [202562] by
-
- 2 edits in trunk/Source/WebCore
AX: Remove dead code in AccessibilityRenderObject::textUnderElement
https://bugs.webkit.org/show_bug.cgi?id=159205
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-28
Reviewed by Joanmarie Diggs.
RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous
text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token
elements. Hence we remove the code in AccessibilityRenderObject::textUnderElement that was
used to handle this specific render tree structure.
No new tests, already covered by accessibility/math-text.html.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Remove dead code for RenderText and RenderMathMLOperator.
- 7:10 AM Changeset in webkit [202561] by
-
- 2 edits in trunk/LayoutTests
[GTK] Update expectations for subtle crypto layout tests
Unreviewed.
- platform/gtk/TestExpectations:
- 6:32 AM WebKitGTK/2.12.x edited by
- (diff)
- 6:31 AM WebKitGTK/2.12.x edited by
- (diff)
- 6:25 AM Changeset in webkit [202560] by
-
- 2 edits in trunk/Source/WTF
THUMB2 support not correctly detected on Fedora with GCC 6.1.
https://bugs.webkit.org/show_bug.cgi?id=159083
Patch by Tomas Popela <tpopela@redhat.com> on 2016-06-28
Reviewed by Carlos Garcia Campos.
On Fedora 24 with GCC 6.1. the thumb2 and thumb are not
defined so the detection of THUMB2 support will fail. Look also
whether the ARM_ARCH_ISA_THUMB is defined to fix the THUMB2
detection.
- wtf/Platform.h:
- 4:49 AM Changeset in webkit [202559] by
-
- 22 edits in trunk
[Win] Custom elements tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=159139
Reviewed by Alex Christensen.
.:
Enable custom element API on Windows.
- Source/cmake/OptionsWin.cmake:
Source/WebCore:
Fix compile errors after enabling custom element API.
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
- dom/CustomElementDefinitions.cpp:
(WebCore::CustomElementDefinitions::addElementDefinition):
- dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation):
(WebCore::createFallbackHTMLElement):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/LifecycleCallbackQueue.cpp:
(WebCore::LifecycleQueueItem::LifecycleQueueItem):
(WebCore::LifecycleCallbackQueue::enqueueElementUpgrade):
(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallback):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::CustomElementConstructionData::CustomElementConstructionData):
(WebCore::HTMLTreeBuilder::insertGenericHTMLElement):
- html/parser/HTMLTreeBuilder.h:
Source/WebKit/win:
Add preference for enabling custom element API.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::customElementsEnabled):
(WebPreferences::setCustomElementsEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Enable custom element API when running tests.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
LayoutTests:
Update test expectations for passing custom elements tests.
- platform/win/TestExpectations:
- 4:26 AM Changeset in webkit [202558] by
-
- 4 edits in trunk
[GStreamer] usec rounding is wrong during accurate seeking
https://bugs.webkit.org/show_bug.cgi?id=90734
Reviewed by Carlos Garcia Campos.
Use floor() to round the microseconds value, this is more robust
than roundf.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::toGstClockTime):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
- 4:24 AM Changeset in webkit [202557] by
-
- 6 edits in trunk/LayoutTests
[GTK] Web audio tests failing since GStreamer 1.6 upgrade
https://bugs.webkit.org/show_bug.cgi?id=158927
Unreviewed GTK rebaseline of webaudio tests.
- platform/gtk/TestExpectations:
- platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav:
- platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav:
- platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav:
- platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav:
- 3:20 AM Changeset in webkit [202556] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] improved duration query support in the HTTP source element
https://bugs.webkit.org/show_bug.cgi?id=159204
Reviewed by Carlos Garcia Campos.
When we have the Content-Length value it is possible to infer the TIME
duration in most cases by performing a convert query in the downstream
elements. This is especially useful when the duration query wasn't
managed by the sinks and thus reached the source element.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent):
- 3:15 AM Changeset in webkit [202555] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix build break since r202502 - 2
https://bugs.webkit.org/show_bug.cgi?id=159194
Reviewed by Gyuyoung Kim.
Fix about the error message below.
error: control reaches end of non-void function [-Werror=return-type]
- b3/B3TypeMap.h: add #pragma GCC diagnostic ignored "-Wreturn-type".
- 12:17 AM Changeset in webkit [202554] by
-
- 3 edits in trunk/LayoutTests
http/tests/media/hls/video-controller-getStartDate.html is failing on non-PDT time-based computers
https://bugs.webkit.org/show_bug.cgi?id=159134
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-28
Reviewed by Alex Christensen.
- http/tests/media/hls/video-controller-getStartDate-expected.txt: Converting date to UTC string before making the comparison.
- http/tests/media/hls/video-controller-getStartDate.html: Rebasing.
- 12:10 AM Changeset in webkit [202553] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix build break since r202502
https://bugs.webkit.org/show_bug.cgi?id=159194
Reviewed by Alex Christensen.
Fix about the error message below.
error: control reaches end of non-void function [-Werror=return-type]
- b3/B3TypeMap.h:
(JSC::B3::TypeMap::at): add missing ASSERT_NOT_REACHED().
- 12:09 AM Changeset in webkit [202552] by
-
- 13 edits10 adds in trunk/LayoutTests
Unreviewed EFL Gardening on 28th Jun.
- platform/efl/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
- platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
- platform/efl/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
- platform/efl/accessibility/aria-option-role-expected.txt: Added.
- platform/efl/accessibility/aria-role-on-label-expected.txt: Added.
- platform/efl/accessibility/aria-switch-text-expected.txt:
- platform/efl/accessibility/auto-fill-crash-expected.txt: Added.
- platform/efl/accessibility/empty-image-with-title-expected.txt: Added.
- platform/efl/accessibility/form-control-value-settable-expected.txt: Added.
- platform/efl/accessibility/image-link-expected.txt:
- platform/efl/accessibility/image-map1-expected.txt:
- platform/efl/accessibility/image-map2-expected.txt:
- platform/efl/accessibility/image-with-alt-and-map-expected.txt:
- platform/efl/accessibility/img-fallsback-to-title-expected.txt:
- platform/efl/accessibility/math-fenced-expected.txt: Added.
- platform/efl/accessibility/math-foreign-content-expected.txt: Added.
- platform/efl/accessibility/math-multiscript-attributes-expected.txt:
- platform/efl/accessibility/math-text-expected.txt:
- platform/efl/accessibility/media-element-expected.txt:
- platform/efl/accessibility/meter-element-expected.txt:
- platform/efl/accessibility/radio-button-title-label-expected.txt:
- platform/efl/accessibility/table-detection-expected.txt:
- 12:04 AM Changeset in webkit [202551] by
-
- 15 edits in trunk/Source/WebCore
Binding generator should generate accessors for constructors safely accessed from JS builtin
https://bugs.webkit.org/show_bug.cgi?id=159087
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-28
Reviewed by Alex Christensen.
Removed constructor private slots direct additions in JSDOMGlobalObject.
Added support for generating the code that will do that.
Advantage of the implementation:
- Private slots will expose constructors that are also publically visible (previously workers had some private slots filled with WebRTC constructors).
- Private slots no longer require the creation of the constructors at window creation time.
Although PublicIdentifier and PrivateIdentifier are both added where needed, the binding generator does not
support the case of a constructor accessible only privately.
Covered by existing test set and adding binding test.
- Modules/mediastream/MediaStream.idl: Marked as PublicIdentifier/PrivateIdentifier.
- Modules/mediastream/MediaStreamTrack.idl: Ditto.
- Modules/mediastream/RTCIceCandidate.idl: Ditto.
- Modules/mediastream/RTCSessionDescription.idl: Ditto.
- Modules/streams/ReadableStream.idl: Ditto.
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals): Removed unneeded additions.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Added support for private slots for interface constructors marked as
PrivateIdentifier.
- bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttribute): Make PublicIdentifier/PrivateIdentifier copied interface attributes.
- bindings/scripts/test/GObject/WebKitDOMTestGlobalObject.cpp:
(webkit_dom_test_global_object_set_property):
(webkit_dom_test_global_object_get_property):
(webkit_dom_test_global_object_class_init):
(webkit_dom_test_global_object_get_public_and_private_attribute):
(webkit_dom_test_global_object_set_public_and_private_attribute):
- bindings/scripts/test/GObject/WebKitDOMTestGlobalObject.h:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::JSTestGlobalObject::finishCreation):
(WebCore::jsTestGlobalObjectPublicAndPrivateAttribute):
(WebCore::setJSTestGlobalObjectPublicAndPrivateAttribute):
- bindings/scripts/test/ObjC/DOMTestGlobalObject.h:
- bindings/scripts/test/ObjC/DOMTestGlobalObject.mm:
(-[DOMTestGlobalObject publicAndPrivateAttribute]):
(-[DOMTestGlobalObject setPublicAndPrivateAttribute:]):
- bindings/scripts/test/TestGlobalObject.idl:
- 12:03 AM Changeset in webkit [202550] by
-
- 5 edits in tags/Safari-601.7.5.1/Source
Versioning.
- 12:01 AM Changeset in webkit [202549] by
-
- 1 copy in tags/Safari-601.7.5.1
New tag.
Jun 27, 2016:
- 11:53 PM Changeset in webkit [202548] by
-
- 5 edits in tags/Safari-602.1.38.2.1/Source
Versioning.
- 11:52 PM Changeset in webkit [202547] by
-
- 1 copy in tags/Safari-602.1.38.2.1
New tag.
- 11:44 PM Changeset in webkit [202546] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
https://bugs.webkit.org/show_bug.cgi?id=159172
<rdar://problem/27030025>
Reviewed by Brent Fulgham.
Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
- 11:38 PM Changeset in webkit [202545] by
-
- 2 edits in trunk/Source/WebCore
CMake build fix.
- PlatformMac.cmake:
- 11:22 PM Changeset in webkit [202544] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline test on iOS after r202539.
- platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt:
- 11:11 PM Changeset in webkit [202543] by
-
- 1 edit in trunk/Tools/ChangeLog
Test commit. Please ignore.
- 11:09 PM Changeset in webkit [202542] by
-
- 14 edits in trunk
Remove didFailAccessControlCheck ThreadableLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=159149
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-27
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt:
Source/WebCore:
Adding an AccessControl ResourceError type.
Replacing didFailAccessControlCheck callback by a direct call to didFail with an error of type AccessControl.
Making CrossOriginPreflightChecker always return an AccessControl error. Previously some errors created below
were passed directly to threadable loader clients.
When doing preflight on unauthorized web sites, WTR/DRT will trigger a cancellation error which was translating into an abort event in XMLHttpRequest.
This patch is changing the error type to AccessControl, which translates into an error event in XMLHttpReauest.
This change of behavior is seen in imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm.
No other observable change of behavior should be expected.
- inspector/InspectorNetworkAgent.cpp: Computing error message in didFail according the error type.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse): Setting preflightFailure error type to AccessControl.
(WebCore::CrossOriginPreflightChecker::notifyFinished): Ditto.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Replacing didFailAccessControlCheck
callback by a direct call to didFail with an error of type AccessControl.
(WebCore::reportContentSecurityPolicyError): Ditto.
(WebCore::reportCrossOriginResourceSharingError): Ditto.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
(WebCore::DocumentThreadableLoader::preflightFailure): Calling didFail directly.
- loader/ThreadableLoaderClient.h: Removing didFailAccessControlCheck.
- loader/ThreadableLoaderClientWrapper.h: Ditto.
- loader/WorkerThreadableLoader.cpp: Ditto.
- loader/WorkerThreadableLoader.h: Ditto.
- page/EventSource.cpp:
(WebCore::EventSource::didFail): Removing didFailAccessControlCheck and putting handling code in didFail.
- page/EventSource.h:
- platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::setType): Softening the assertion to cover the case of migration to AccessControl.
- platform/network/ResourceErrorBase.h: Adding AccessControl error type.
(WebCore::ResourceErrorBase::isAccessControl):
- 11:07 PM Changeset in webkit [202541] by
-
- 2 edits in trunk/LayoutTests
Mark some tests as image failures.
These tests started to fail with the render server snapshotting enabled in r202532.
- platform/ios-simulator-wk2/TestExpectations:
- 10:56 PM Changeset in webkit [202540] by
-
- 2 edits in trunk/Source/WebKit2
Fix TestWebKitAPI crash introduced in r202532.
WebPageProxy::forceRepaint() could trigger a call to the didForceRepaintCallback()
after the WebPageProxy had been invalidated, causing a null de-ref of m_drawingArea.
Fix by checking for error and isValid().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
- 10:10 PM Changeset in webkit [202539] by
-
- 9 edits in trunk
HTMLElement / SVGElement should implement GlobalEventHandlers, not Element
https://bugs.webkit.org/show_bug.cgi?id=159191
<rdar://problem/27019299>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
HTMLElement / SVGElement should implement GlobalEventHandlers, not Element:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement
Firefox and Chrome behave as per the specification.
Fixing this also fixes rendering on http://survey123.arcgis.com/.
No new tests, covered by existing tests that were rebaselined.
- dom/Element.idl:
- html/HTMLElement.idl:
- svg/SVGElement.idl:
LayoutTests:
- fast/dom/event-handler-attributes-expected.txt:
Rebaseline tests now that more checks are passing.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
Rebaseline test now that enumeration order is different.
- 9:04 PM Changeset in webkit [202538] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Test gardening: Generic font families should not map to fonts which aren't installed
https://bugs.webkit.org/show_bug.cgi?id=159111
<rdar://problem/25807529>
Unreviewed.
Osaka-Mono does not come preinstalled on macOS Sierra. However, many Japanese users
will have the font installed. Before setting the generic font family, we should check
to see if the font is present.
- page/cocoa/SettingsCocoa.mm:
(WebCore::osakaMonoIsInstalled):
(WebCore::Settings::initializeDefaultFontFamilies):
- 8:25 PM Changeset in webkit [202537] by
-
- 2 edits in trunk/Source/WebCore
Don't keep all newly created potential custom elements alive when the feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=159113
Reviewed by Daniel Bates.
Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.
Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
that is inserted into the document. We'll implement that later.
- dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation):
- 7:58 PM Changeset in webkit [202536] by
-
- 7 edits4 adds in trunk
[iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL
https://bugs.webkit.org/show_bug.cgi?id=159186
rdar://problem/26659341
Reviewed by Zalan Bujtas.
Source/WebCore:
There were two issues with repaints in -webkit-overflow-scrolling:touch scrolling
layers.
First, if the scrolled contents were inline (e.g. a <span>), then repaints were
broken because RenderInline didn't call shouldApplyClipAndScrollPositionForRepaint().
Fix by making shouldApplyClipAndScrollPositionForRepaint() a member function of RenderBox
and calling it from RenderBox::computeRectForRepaint() and RenderInline::clippedOverflowRectForRepaint().
Second, repaints were broken in RTL because RenderLayerBacking::setContentsNeedDisplayInRect()
confused scroll offset and scroll position; it needs to subtract scrollPosition.
Finally renamed to applyCachedClipAndScrollOffsetForRepaint() to applyCachedClipAndScrollPositionForRepaint()
to make it clear that it uses scrollPosition, not scrollOffset.
Tests: compositing/scrolling/touch-scrolling-repaint-spans.html
compositing/scrolling/touch-scrolling-repaint.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollPositionForRepaint):
(WebCore::RenderBox::shouldApplyClipAndScrollPositionForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint): Deleted.
(WebCore::shouldApplyContainersClipAndOffset): Deleted.
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
LayoutTests:
- compositing/scrolling/touch-scrolling-repaint-expected.html: Added.
- compositing/scrolling/touch-scrolling-repaint-spans-expected.html: Added.
- compositing/scrolling/touch-scrolling-repaint-spans.html: Added.
- compositing/scrolling/touch-scrolling-repaint.html: Added.
- 7:47 PM Changeset in webkit [202535] by
-
- 2 edits in trunk/Tools
[GTK][EFL] Disable subtle-crypto in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=155073
Reviewed by Daniel Bates.
- Scripts/webkitperl/FeatureList.pm:
- 7:38 PM Changeset in webkit [202534] by
-
- 12 edits in trunk/Websites/webkit.org
Updated content for the color blog post.
- blog-files/color-gamut/Iceland-P3.jpg:
- blog-files/color-gamut/Iceland-oog.jpg:
- blog-files/color-gamut/Iceland-sRGB.jpg:
- blog-files/color-gamut/Italy-P3.jpg:
- blog-files/color-gamut/Italy-sRGB.jpg:
- blog-files/color-gamut/Sunset-P3.jpg:
- blog-files/color-gamut/Sunset-sRGB.jpg:
- blog-files/color-gamut/YellowFlower-P3.jpg:
- blog-files/color-gamut/YellowFlower-oog.jpg:
- blog-files/color-gamut/YellowFlower-sRGB.jpg:
- blog-files/color-gamut/index.html:
- 7:00 PM Changeset in webkit [202533] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r202436.
https://bugs.webkit.org/show_bug.cgi?id=159190
We don't need to make this change. (Requested by thorton on
#webkit).
Reverted changeset:
"Do not use iOS specific telephone detection on macOS."
https://bugs.webkit.org/show_bug.cgi?id=159096
http://trac.webkit.org/changeset/202436
- 6:44 PM Changeset in webkit [202532] by
-
- 9 edits in trunk
[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
https://bugs.webkit.org/show_bug.cgi?id=159077
Reviewed by Tim Horton.
Source/WebKit2:
Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
Tools:
Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.
Add some null checks to fix issues when the WKWebView gets resized to be empty, which
seems to happen for some tests that call window.resizeTo().
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Deleted.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpResults):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):
LayoutTests:
fast/harness/snapshot-captures-compositing.html passes now.
- platform/ios-simulator-wk2/TestExpectations:
- 6:13 PM Changeset in webkit [202531] by
-
- 6 edits12 adds in trunk
Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch
https://bugs.webkit.org/show_bug.cgi?id=159179
rdar://problem/27006387
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html
fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html
fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html
fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html
fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html
fast/events/touch/ios/drag-block-without-overflow-scroll.html
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::removeAllEventListeners):
- dom/Node.cpp:
(WebCore::Node::willBeDeletedFrom):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::registerForTouchEvents):
(WebCore::SliderThumbElement::unregisterForTouchEvents):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::registerAsTouchEventListenerForScrolling):
(WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling):
LayoutTests:
Several of those tests expose existing bugs with overflow scrolling.
They are not using PASS/FAIL at the moment, just dump the called listeners.
- fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt: Added.
- fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html: Added.
- fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt: Added.
- fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html: Added.
- fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt: Added.
- fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll-expected.txt: Added.
- fast/events/touch/ios/drag-block-without-overflow-scroll.html: Added.
- 6:00 PM Changeset in webkit [202530] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- bindings/js/SerializedScriptValue.h:
WTF
- 5:55 PM Changeset in webkit [202529] by
-
- 5 edits3 adds in trunk
Web Inspector: When modifying sessionStorage, localStorage gets updated
https://bugs.webkit.org/show_bug.cgi?id=159181
<rdar://problem/27043447>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-27
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Test/Test.js:
(WebInspector.loaded):
Add registration for StorageManager and StorageObserver.
Source/WebKit2:
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
This should be dispatching storage events.
LayoutTests:
- inspector/storage/domStorage-events-expected.txt: Added.
- inspector/storage/domStorage-events.html: Added.
Add a new test for DOMStorage domain events. Ensures that sessionStorage
and localStorage events are dispatched for the appropriate DOMStorageObject.
- 5:42 PM Changeset in webkit [202528] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Fix bad assert in StructureRareData::setObjectToStringValue
https://bugs.webkit.org/show_bug.cgi?id=159171
<rdar://problem/26987355>
Reviewed by Mark Lam.
We should not have expected the generateConditionsForPrototypePropertyHit would succeed.
There are many reasons it might fail including that there is a proxy somewhere on the
prototype chain of the object.
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::setObjectToStringValue):
- tests/stress/object-toString-with-proxy.js: Added.
(get target):
- 5:36 PM Changeset in webkit [202527] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r202520.
https://bugs.webkit.org/show_bug.cgi?id=159185
This change broke the 32-bit El Capitan build (Requested by
ryanhaddad on #webkit).
Reverted changeset:
"REGRESSION?(r202466): http/tests/security/canvas-remote-read-
remote-video-redirect.html failing on Sierra"
https://bugs.webkit.org/show_bug.cgi?id=159172
http://trac.webkit.org/changeset/202520
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-27
- 5:36 PM Changeset in webkit [202526] by
-
- 2 edits in trunk/LayoutTests
[Cocoa] Test gardening for the system font in macOS Sierra and iOS 10
https://bugs.webkit.org/show_bug.cgi?id=159175
<rdar://problem/26478081>
Unreviewed.
- fast/text/trak-optimizeLegibility.html:
- 5:34 PM Changeset in webkit [202525] by
-
- 5 edits3 deletes in trunk
Fix flakiness on Sierra after r202511
https://bugs.webkit.org/show_bug.cgi?id=159071
Source/WebKit2:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::clearCredentials):
Replacing the NSURLSessions immediately caused assertions because the tasks are not always all stopped immediately when tearing down a test.
Stopping an NSURLSession needs to be done asynchronously. I'll try a different testing technique for r202511.
LayoutTests:
- http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
- http/tests/xmlhttprequest/sync-delegate-callbacks.html: Removed.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
- 5:33 PM Changeset in webkit [202524] by
-
- 4 edits in trunk/Source/WebKit/mac
REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
https://bugs.webkit.org/show_bug.cgi?id=159184
<rdar://problem/26370206>
Reviewed by Beth Dakin.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
(-[WebImmediateActionController _animationControllerForText]):
(dictionaryPopupInfoForRange): Deleted.
WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
- 5:26 PM Changeset in webkit [202523] by
-
- 2 edits in trunk/Tools
[EFL] Support to build on Debian linux
https://bugs.webkit.org/show_bug.cgi?id=159123
Reviewed by Antonio Gomes.
- efl/install-dependencies: Install libgnutls28-dev.
- 5:23 PM Changeset in webkit [202522] by
-
- 6 edits4 adds in trunk
Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole
https://bugs.webkit.org/show_bug.cgi?id=128092
<rdar://problem/15966526>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
This is a layering violation which makes it harder to use RuntimeManager.evaluateInInspectedWindow
from a testing context where the QuickConsole view does not exist.
Store the selected execution context identifier on RuntimeManager and use it
when doing subsequent evaluations that act on the currently selected frame.
- UserInterface/Controllers/RuntimeManager.js:
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
(WebInspector.RuntimeManager.prototype.saveResult):
Use local state.
(WebInspector.RuntimeManager.prototype.get defaultExecutionContextIdentifier):
(WebInspector.RuntimeManager.prototype.set defaultExecutionContextIdentifier):
Added.
(WebInspector.RuntimeManager):
- UserInterface/Models/ExecutionContext.js:
(WebInspector.ExecutionContext):
Move the symbolic name for the top level execution context to RuntimeManager.
- UserInterface/Test/Test.js:
(WebInspector.loaded): No need to stub out WebInspector.QuickConsole any more.
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._framePageExecutionContextsChanged):
(WebInspector.QuickConsole.prototype._removeExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._updateExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._pathComponentSelected):
For now, set RuntimeManager's selected execution context whenever we set the
selected path component. In a future patch, we should invert the dependency and have
the selected component change whenever RuntimeManager.defaultExecutionContext changes.
LayoutTests:
Add some really basic coverage for RuntimeManager.defaultExecutionContextIdentifier
and using it in RuntimeManager.evaluateInInspectedWindow.
- inspector/runtime/change-execution-context-identifier-expected.txt: Added.
- inspector/runtime/change-execution-context-identifier.html: Added.
- inspector/runtime/resources/change-execution-context-identifier-subframe.html: Added.
- 4:59 PM Changeset in webkit [202521] by
-
- 2 edits in trunk/Websites/webkit.org
Set a default image for sharing webkit.org links via social.
https://bugs.webkit.org/show_bug.cgi?id=159167
Reviewed by Timothy Hatcher.
- wp-content/plugins/social-meta.php:
- 4:56 PM Changeset in webkit [202520] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
https://bugs.webkit.org/show_bug.cgi?id=159172
<rdar://problem/27030025>
Reviewed by Brent Fulgham.
Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
- 4:26 PM Changeset in webkit [202519] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crashing at an unreachable code trap in FTL should give more information
https://bugs.webkit.org/show_bug.cgi?id=159177
Reviewed by Saam Barati.
This stuffs information into registers so that we have some chance of seeing what happened
by looking at the register dumps.
- assembler/AbortReason.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::ftlUnreachable):
(JSC::FTL::DFG::LowerDFGToB3::compileBlock):
(JSC::FTL::DFG::LowerDFGToB3::crash):
- 3:26 PM Changeset in webkit [202518] by
-
- 4 edits in trunk/Source/JavaScriptCore
Clean up resetting reachability in B3/Air
https://bugs.webkit.org/show_bug.cgi?id=159170
Reviewed by Geoffrey Garen.
When I fixed bug 159165, I took the brute force approach. I still used the
B3::resetReachability() method, and changed the callback to record the set of deleted values
instead of deleting them eagerly. But this means tracking the set of deleted values, even
though resetReachability() already internally tracks the set of deleted blocks. You can find
out if a value is deleted by asking if its owning block was deleted.
So, this change refactors B3::resetReachability() into a new helper called
B3::recomputePredecessors(). This new helper skips the block deletion step, and lets the
client delete blocks. This lets Air delete blocks the same way that it did before, and it
lets B3 use the isBlockDead() method (which is a glorified proxy for
block->predecessors().isEmpty()) to track which values are deleted. This allows B3 to turn
Upsilons that point to dead Phis into Nops before deleting the blocks.
This shouldn't affect performance or anything real. It just makes the code cleaner.
- b3/B3BasicBlockUtils.h:
(JSC::B3::updatePredecessorsAfter):
(JSC::B3::recomputePredecessors):
(JSC::B3::isBlockDead):
(JSC::B3::resetReachability): Deleted.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::resetReachability):
(JSC::B3::Procedure::invalidateCFG):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::resetReachability):
(JSC::B3::Air::Code::dump):
- 3:20 PM Changeset in webkit [202517] by
-
- 5 edits14 adds in trunk
Fix style invalidation for :active when the activated node has no renderer
https://bugs.webkit.org/show_bug.cgi?id=159125
Reviewed by Antti Koivisto.
Source/WebCore:
Same old bug: a style invalidation path was depending
on the style.
Here we really need both flags. An element can have
childrenAffectedByActive() false and renderStyle->affectedByActive() true
if it was subject to style sharing.
The element state "childrenAffectedByActive" should be renamed
"styleAffectedByActive" since it is not a parent invalidation flag.
That will be done separately.
Tests: fast/css/pseudo-active-on-labeled-control-without-renderer.html
fast/css/pseudo-active-style-sharing-1.html
fast/css/pseudo-active-style-sharing-2.html
fast/css/pseudo-active-style-sharing-3.html
fast/css/pseudo-active-style-sharing-4.html
fast/css/pseudo-active-style-sharing-5.html
fast/css/pseudo-active-style-sharing-6.html
- dom/Element.cpp:
(WebCore::Element::setActive):
- style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):
LayoutTests:
There was no bug with style sharing but I wanted that covered anyway.
Style sharing depends on 2 flags which is uncommon.
There was no test coverage whatsoever, breaking it did not fail any test.
- fast/css/pseudo-active-on-labeled-control-without-renderer-expected.txt: Added.
- fast/css/pseudo-active-on-labeled-control-without-renderer.html: Added.
- fast/css/pseudo-active-style-sharing-1-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-1.html: Added.
- fast/css/pseudo-active-style-sharing-2-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-2.html: Added.
- fast/css/pseudo-active-style-sharing-3-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-3.html: Added.
- fast/css/pseudo-active-style-sharing-4-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-4.html: Added.
- fast/css/pseudo-active-style-sharing-5-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-5.html: Added.
- fast/css/pseudo-active-style-sharing-6-expected.txt: Added.
- fast/css/pseudo-active-style-sharing-6.html: Added.
- 3:13 PM Changeset in webkit [202516] by
-
- 3 edits3 adds in trunk
AX: REGRESSION (r202063): ARIA role attribute is being ignored for label element
https://bugs.webkit.org/show_bug.cgi?id=159162
Reviewed by Chris Fleizach.
Source/WebCore:
createFromRenderer() was creating an AccessibilityLabel for any HTMLLabelElement which
lacked an explicitly-handled ARIA role. We should instead create an AccessibilityLabel
when there is no ARIA role.
Test: accessibility/aria-role-on-label.html
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
LayoutTests:
This regression was caught by a GTK-specific layout test. Adding a cross-platform
test for additional coverage.
- accessibility/aria-role-on-label.html: Added.
- platform/gtk/accessibility/aria-role-on-label-expected.txt: Added.
- platform/mac/accessibility/aria-role-on-label-expected.txt: Added.
- 2:50 PM Changeset in webkit [202515] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>
Reviewed by Filip Pizlo.
This change caused JSC stress tests to all hit an assertion in RunLoop.
We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
clients like testapi and jsc don't ever call initializeMainRunLoop().
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
- 2:45 PM Changeset in webkit [202514] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r202505.
https://bugs.webkit.org/show_bug.cgi?id=159169
The test added with this change is flaky and it caused an
existing test to time out on El Capitan. (Requested by
ryanhaddad on #webkit).
Reverted changeset:
"[iOS] Media controls are too cramped with small video"
https://bugs.webkit.org/show_bug.cgi?id=158815
http://trac.webkit.org/changeset/202505
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-27
- 2:44 PM Changeset in webkit [202513] by
-
- 2 edits in trunk/Source/WebCore
Add :focus-within to the status page
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-27
- features.json:
I forgot to update the json file when landing the feature.
- 2:36 PM Changeset in webkit [202512] by
-
- 5 edits in trunk/Source/JavaScriptCore
B3::Procedure::resetReachability() can create dangling references from Upsilons to Phis
https://bugs.webkit.org/show_bug.cgi?id=159165
Reviewed by Mark Lam.
You can delete an unreachable block that has a Phi but some prior block may still have an
Upsilon pointing to that Phi. This can happen if the Upsilon precedes a Check that always
exits or it can happen if we remove some successor of a block and this block had an Upsilon
for one of the removed successors. These things are valid IR even if they are not canonical.
Our policy for not-canonical-but-valid IR is that the compiler should still emit valid code
in the end.
The solution is to have Procedure::resetReachability() turn those Upsilons into Nops.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::resetReachability): Fix the bug.
- b3/B3Validate.h:
- b3/testb3.cpp:
(JSC::B3::testResetReachabilityDanglingReference): Add a test. This always crashes prior to this change.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::killUnreachableBlocks): Add a FIXME about a possible similar bug.
- 1:59 PM Changeset in webkit [202511] by
-
- 32 edits3 adds in trunk
Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=159071
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-27
Reviewed by Brady Eidson.
Source/WebKit2:
When CFNetwork asks the NetworkProcess if we can authenticate against this protection space, we used to ask
the WebProcess, which would call ResourceLoader::canAuthenticateAgainstProtectionSpace which would ask the FrameLoaderClient,
which would synchronously ask the UIProcess. Going directly from the NetworkProcess to the UIProcess gives us many advantages:
- It reduces IPC because we ask fewer loads.
- It reduces synchronous IPC because we are not using the same code path as WebKit1 any more.
- It allows us to check if the NetworkProcess is still valid in sendToNetworkingProcess, possibly fixing rdar://problem/26825408
- It allows us to ask the UIProcess when we get authentication challenges for synchronous xhr.
I added a new test http/tests/xmlhttprequest/sync-delegate-callbacks.html to verify the change in behavior of synchronous xhr.
In order to make this test not flaky on platforms using NSURLSession, we clear the NSURLSessions used by WebKitTestRunner
to make sure that the TLS session cache is cleared so we get NSURLAuthenticationChallenges corresponding to the NSURLConnection
canAuthenticateAgainstProtectionSpace callback when we initiate the first HTTPS connection to 127.0.0.1 with this session.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearCachedCredentials):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::cancelDownload):
(WebKit::NetworkProcess::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpaceDownload):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/NetworkResourceLoader.messages.in:
- NetworkProcess/NetworkSession.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::networkStorageSession):
(WebKit::NetworkSession::clearCredentials):
(WebKit::NetworkSession::dataTaskForIdentifier):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::logSampledDiagnosticMessageWithValue):
(WebKit::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::backForwardClear):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResource):
(WebKit::WebResourceLoader::isAlwaysOnLoggingAllowed):
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Deleted.
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearCachedCredentials):
(WebKit::WebProcess::focusedWebPage):
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestRunner::setAuthenticationUsername):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishNavigation):
(WTR::TestController::canAuthenticateAgainstProtectionSpace):
(WTR::TestController::didReceiveAuthenticationChallenge):
(WTR::TestController::didCommitNavigation):
- WebKitTestRunner/TestController.h:
(WTR::TestController::setBlockAllPlugins):
(WTR::TestController::setShouldLogHistoryClientCallbacks):
(WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestController::isCurrentInvocation):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
LayoutTests:
- http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Added.
- http/tests/xmlhttprequest/sync-delegate-callbacks.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Added.
- 1:52 PM Changeset in webkit [202510] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove OS X Mavericks test results
Rubber-stamped by Lucas Forschler.
- platform/mac-mavericks: Removed.
- 1:37 PM Changeset in webkit [202509] by
-
- 5 edits in trunk
[Mac] PiP placeholder should remain visible when 'controls' attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=159158
<rdar://problem/26727435>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing test updated.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.shouldHaveControls): Always return true when in PiP or AirPlay mode.
LayoutTests:
- media/controls/picture-in-picture-expected.txt: Updated.
- media/controls/picture-in-picture.html: Ditto.
- 12:52 PM Changeset in webkit [202508] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add comment to Module feature in features.json
https://bugs.webkit.org/show_bug.cgi?id=159159
Reviewed by Saam Barati.
- features.json:
- 12:17 PM Changeset in webkit [202507] by
-
- 3 edits in trunk/Source/WebCore
Update ATS WebContent exception for more robust framework information
https://bugs.webkit.org/show_bug.cgi?id=159151
Reviewed by Alex Christensen.
We found some unexpected poor interaction with AVFoundation in the existing
CFNetwork SPI. This new SPI is more solid and let's us provide more useful
information while also being more future proof against new frameworks and
ATS modes.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
- 12:11 PM Changeset in webkit [202506] by
-
- 4 edits in trunk/Source/WTF
Remove now unused WTF::findNextLineStart
https://bugs.webkit.org/show_bug.cgi?id=159157
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-27
Reviewed by Mark Lam.
Unused after r202498.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::findNextLineStart): Deleted.
- wtf/text/StringImpl.h:
(WTF::findNextLineStart): Deleted.
- wtf/text/WTFString.h:
(WTF::String::findNextLineStart): Deleted.
- 12:06 PM Changeset in webkit [202505] by
-
- 8 edits2 adds in trunk
[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>
Patch by Antoine Quint <Antoine Quint> on 2016-06-27
Reviewed by Dean Jackson.
Source/WebCore:
In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.
In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.
As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.
Test: media/video-controls-drop-and-restore-timeline.html
- Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):
- Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls-time-remaining-display.clone):
- Modules/mediacontrols/mediaControlsiOS.js:
LayoutTests:
Adjust the output of this test to account for the time label clones and add a new test.
- media/video-controls-drop-and-restore-timeline-expected.txt: Added.
- media/video-controls-drop-and-restore-timeline.html: Added.
- platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
- platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
- 12:06 PM Changeset in webkit [202504] by
-
- 2 edits in trunk/Source/WebKit2
Discounted items are displayed with positive values
https://bugs.webkit.org/show_bug.cgi?id=159160
rdar://problem/26980772
Reviewed by Dean Jackson.
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toDecimalNumber):
Add new helper function. Correctly compute the mantissa.
(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKShippingMethod):
Use toDecimalNumber.
- 11:52 AM Changeset in webkit [202503] by
-
- 2 edits in trunk/Source/JavaScriptCore
Update features.json for ES6 completed features.
https://bugs.webkit.org/show_bug.cgi?id=159152
Reviewed by Mark Lam.
- features.json:
- 11:35 AM Changeset in webkit [202502] by
-
- 12 edits2 adds in trunk/Source/JavaScriptCore
B3 should not use Nops when deleting unreachable code
https://bugs.webkit.org/show_bug.cgi?id=159120
rdar://problem/26500743
Reviewed by Michael Saboff.
Prior to this change, transformations that obviated the need for some value could choose
from these ways to kill it:
- replaceWithIdentity() if we're replacing with another value.
- replaceWithNop() if the type is Void or if we know that we'll fix any users of this value.
- deleteValue() if the code is unreachable.
The bug here is that reduceStrength() was being clever about how to get rid of a value.
reduceStrength() may find a Check that must always exit. The goal is to remove any code
dominated by the Check. But it would be awkward to eagerly delete all of the blocks
dominated by this one. So this code took a much simpler approach: it would
replaceWithNop() for all of the values in this block after the Check and it would replace
the terminal with Oops.
But this corrupts the IR in a subtle way: some of those values may have been non-Void but
now they are Nops so they are Void. reduceStrength() will not yet realize that the blocks
dominated by the one with the Check are unreachable, so it will run all sorts of
optimizations on those blocks. This could have probably manifested as many different kinds
of badness, but the way I found out about this issue was through a crash in
IntRange::top(Type) when inlined into ReduceStrength::rangeFor(). We'd die in a switch
statement over a child's type.
We could fix this by making rangeFor() tolerate Void. But I think that this would be
dangerous. There could easily be other places in reduceStrength() that assume that value's
children are non-Void. So, this change fixes the Check optimization and adds mechanisms to
prevent other optimizations from breaking the children-are-not-Void rule.
This introduces two high-level changes:
- It's no longer legal to replaceWithNop() if the value is not Void. This change alone would cause reduceStrength() to instacrash in its Check optimization. Almost all other uses of replaceWithNop() were already following this rule, so they were fine. One other place was using replaceWithNop() on non-Void values after arranging for them to no longer have any parents. That was changed to call replaceWithNopIgnoringType(), which doesn't have any type assertions.
- For reduceStrength() there is a new Value::replaceWithBottom() method that works with Void or non-Void and behaves like you would want replaceWithNop() to behave: if you know that the code is unreachable then it produces something that is guaranteed to be deleted by later optimizations, and if it's not unreachable, then it's guaranteed to be compiled to something harmless and cheap. This means replacing the value with an identity that points to a bottom constant (the 0 for whatever type we have), or just replacing it with Nop if it's Void.
This also adds a test case for the reason why we do this: we may have two blocks, where
the first block unconditionally exits while dominating the second block. The second block
references values in the part of the first block that is unreachable. In trunk, this test
would assert in ReduceStrength::rangeFor() because the CheckAdd in the second block would
reference a Nop in the first block.
This fixes a high volume crash in ReduceStrength::rangeFor(). This crash was very
confusing. Even though we were crashing at a RELEASE_ASSERT_NOT_REACHED() in a switch
statement in IntRange::top(Type), clang was merging that trap with the trap it used for
Vector OOB. The top of the stack in crash dumps looked like:
JSC::B3::(anonymous namespace)::ReduceStrength::rangeFor(JSC::B3::Value*, unsigned int) + 4477 (Vector.h:655)
Where Vector.h:655 is:
OverflowHandler::overflowed();
But this crash was not at Vector.h:655. It was at B3ReduceStrength.cpp:121. The two lines
are both traps, so they got merged despite differences in debug info. This bug would have
been so much easier to fix if I had the right line number.
- b3/B3BottomProvider.h: Added. This is a utility for creating bottom values.
(JSC::B3::BottomProvider::BottomProvider):
(JSC::B3::BottomProvider::operator()):
- b3/B3InsertionSet.cpp: Optimized adding bottom values a bit. We will no longer create pointless duplicates.
(JSC::B3::InsertionSet::insertBottom):
(JSC::B3::InsertionSet::execute):
(JSC::B3::InsertionSet::bottomForType):
- b3/B3InsertionSet.h:
- b3/B3MoveConstants.cpp: Use replaceWithNopIgnoringType() because we *know* that we can replaceWithNop even for non-Void.
- b3/B3Procedure.h:
- b3/B3ReduceStrength.cpp: Use replaceWithBottom().
- b3/B3ReduceStrength.h:
- b3/B3TypeMap.h: I figured if I wrote type-casing code like this once then I'd never want to write it again.
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithNopIgnoringType):
- b3/B3Value.h:
- b3/B3ValueInlines.h:
(JSC::B3::Value::replaceWithBottom): This is the new method of killing unreachable code.
(JSC::B3::Value::as):
- b3/testb3.cpp: Add new tests!
(JSC::B3::testLateRegister):
(JSC::B3::testReduceStrengthCheckBottomUseInAnotherBlock):
(JSC::B3::zero):
(JSC::B3::run):
- 11:30 AM Changeset in webkit [202501] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:29 AM Changeset in webkit [202500] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 11:28 AM Changeset in webkit [202499] by
-
- 2 edits in trunk/Source/WebCore
No error message when passing an invalid API version to ApplePaySession constructor
https://bugs.webkit.org/show_bug.cgi?id=159154
Reviewed by Tim Horton.
Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
- 11:18 AM Changeset in webkit [202498] by
-
- 5 edits in trunk
REGRESSION: Web Inspector: Text search broken in resources with <CR>
https://bugs.webkit.org/show_bug.cgi?id=159110
<rdar://problem/27008485>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::lineEndings):
The frontend moved to only treated newlines as line endings in
the TextEditor. The backend however was looking for many
different types of line endings (\r\n, \r, \n). This caused
the line endings to ultimately differ between the frontend
and the backend, so the frontend couldn't find the lines that
the backend was claiming search results were on. Change the
backend to only look for \n line endings.
LayoutTests:
- inspector/debugger/searchInContent-linebreaks-expected.txt:
- inspector/debugger/searchInContent-linebreaks.html:
Now that the backend responds with lines that end in \n, this test changes
the number of line results. The frontend interprets this correctly.
- 10:57 AM Changeset in webkit [202497] by
-
- 11 edits6 adds in trunk
AX: Anonymous RenderMathMLOperators are not exposed to the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=139582
<rdar://problem/26938849>
Reviewed by Chris Fleizach.
This is based on a patch by Frederic Wang <fwang@igalia.com>.
Source/WebCore:
WebCore assigns the generic MathElementRole AccessibilityRole to elements
which are expected to be included in the accessibility tree. This assignment
is based on the AccessibilityRenderObject's node being a MathMLElement. The
anonymous RenderMathMLOperators fail that test.
From the perspective of accessibility support, these operators function
like MathMLElements. Furthermore, both WebCore and the platforms rely
upon MathElementRole to identify accessible MathML objects. The simplest
fix is to have AccessibilityRenderObject::isMathElement() treat anonymous
MathML operators as if they were MathMLElements.
Now that these operators are being exposed, we need to handle them in
AccessibilityRenderObject::textUnderElement() which assumes that anonymous
objects either have nodes or have children with nodes. And crashes when
that fails to be the case. Making RenderMathMLOperator::textContent()
public and then using it to get the text under anonymous operators solves
this problem. We also assign StaticTextRole to these operators on the Mac
because the default platform mapping of MathElementRole is GroupRole, which
made sense when we had a child RenderText object holding the operator.
Lastly, AccessibilityRenderObject::isIgnoredElementWithinMathTree() no
longer needs to special-case anonymous operators because they now have
MathElementRole.
Tests: accessibility/math-fenced.html
accessibility/math-foreign-content.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAnonymousMathOperator):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isMathElement):
(WebCore::AccessibilityRenderObject::isAnonymousMathOperator):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper role]):
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::textContent):
LayoutTests:
One of the things making it difficult to tell that the operators were not
exposed on the Mac is the fact that the operator text is present. But the
operator text is simply a StaticTextRole object corresponding to the
RenderText descendant of the operator. Furthermore, on the Mac, accessible
math operators have subroles which are missing from the StaticTextRole
object which is exposed. In order to make issues like this more obvious,
add an option to include the subrole to dumpAccessibilityTree() and use it
in the new math-fenced.html.
This change also fixes the mfenced in mac/mathml-elements.html that was
broken after r202420. We enable it again and update the expectations of
that test because the operators are now in the accessibility tree.
We also add a new test to verify the render tree of foreign content in
MathML formulas.
- accessibility/mac/mathml-elements-expected.txt: Updated.
- accessibility/mac/mathml-elements.html: Re-enable the mfenced test.
- accessibility/math-fenced.html: Added.
- accessibility/math-foreign-content.html: Added.
- platform/gtk/accessibility/math-fenced-expected.txt: Added.
- platform/gtk/accessibility/math-foreign-content-expected.txt: Added.
- platform/mac/accessibility/math-fenced-expected.txt: Added.
- platform/mac/accessibility/math-foreign-content-expected.txt: Added.
- resources/accessibility-helper.js: Add option to include subrole in tree.
(dumpAccessibilityTree):
- 10:57 AM Changeset in webkit [202496] by
-
- 2 edits in trunk/LayoutTests
Remove flaky expectation for imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata.html
https://bugs.webkit.org/show_bug.cgi?id=150956
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:53 AM Changeset in webkit [202495] by
-
- 4 edits in trunk/LayoutTests
WebRTC: Unskip RTCPeerConnection-AddRemoveStream test
https://bugs.webkit.org/show_bug.cgi?id=159133
Reviewed by Eric Carlson.
Unskip RTCPeerConnection-AddRemoveStream test (on GTK+ port). RTCPeerConnection implements
the legacy MediaStream-based API as JS built-ins so we can run this test again.
- fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- platform/gtk/TestExpectations:
- 10:52 AM Changeset in webkit [202494] by
-
- 1 edit1 delete in trunk/Source/WebCore
WebRTC: Remove unused RTCOfferAnswerOptionsPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=159130
Reviewed by Eric Carlson.
Remove unused RTCOfferAnswerOptionsPrivate.h file.
- platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Removed.
- 10:50 AM Changeset in webkit [202493] by
-
- 2 edits in trunk/Source/WebCore
Crash in layout test /media/video-buffered-range-contains-currentTime.html
https://bugs.webkit.org/show_bug.cgi?id=159109
<rdar://problem/26535750>
Reviewed by Alex Christensen.
Guard against a dealloc race condition by holding a retain on the session
until the task's _resource:loadFinishedWithError: completes, including
main thread callbacks.
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:]):
- 10:50 AM Changeset in webkit [202492] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>
Reviewed by Timothy Hatcher.
Move the asynchronous work to a task class that can be cancelled when the
heap agent is reset, disabled or destroyed.
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
(Inspector::SendGarbageCollectionEventsTask::addGarbageCollection):
(Inspector::SendGarbageCollectionEventsTask::reset):
(Inspector::SendGarbageCollectionEventsTask::timerFired):
Added. This holds onto GarbageCollectionData that needs to be sent asynchronously.
It uses the RunLoop variant of Timer and can queue multiple collections to be sent.
The data vector is guarded with a lock so that garbageCollected() can safely add
collection data from a non-main thread while the main thread sends out events.
(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::disable):
Reset the task when disabling or tearing down the agent so the timer doesn't fire after destruction.
(Inspector::InspectorHeapAgent::didGarbageCollect):
Add the collection data to the task, which will dispatch an event for it asynchronously.
- inspector/agents/InspectorHeapAgent.h:
- 10:44 AM Changeset in webkit [202491] by
-
- 5 edits in trunk/LayoutTests
Update TestExpectations for some dynamic MathML tests
https://bugs.webkit.org/show_bug.cgi?id=159142
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.
- TestExpectations: Enable this test again after r199980.
- platform/efl/TestExpectations: This is already claimed to pass in the platform independent TestExpectations.
- platform/gtk/TestExpectations: Ditto.
- platform/ios-simulator/TestExpectations: This test passes after the refactoring of RenderMathMLOperator.
- 10:38 AM Changeset in webkit [202490] by
-
- 7 edits in trunk
ES6 Change: Unify handling of RegExp CharacterClassEscapes \w and \W and Word Asserts \b and \B
https://bugs.webkit.org/show_bug.cgi?id=158505
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This change makes it so that the CharacterClassEscape \w matches the inverse of
\W and vice versa for unicode, ignore case RegExp's.
Before this change, both /\w/ui and /\W/ui RegExp's would match the characters
k, K, s, S, \u017f (Latin Small Letter Long S) and \u212a (Kelvin Sign).
This was due to how the ES6 standard defined matching of character classes
specifically that the abstract operation "Canonicalize()" is called for the
character to be matched AND for the characters in the character class we are
matching against. This change is to make \W always be the inverse of \w.
It is still the case that the characters that match against \w changes
depending on a regular expression's flags.
The only real changes occur for regular expressions with both the unicode and
ignore case flags set. Updated the character class generator to make
nonwordUnicodeIgnoreCaseChar not include k, K, s, S, \u017f and \u212a.
Changed BytecodePattern.wordcharCharacterClass to use the correct
word character class for the flags. Simplfied character class set up in
in the pattern to use m_pattern.wordUnicodeIgnoreCaseCharCharacterClass and
invert as appropriate when unicode and ignore case are both set.
- create_regex_tables:
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
LayoutTests:
Updated and added test cases.
- js/regexp-unicode-expected.txt:
- js/script-tests/regexp-unicode.js:
- 10:36 AM Changeset in webkit [202489] by
-
- 8 edits in trunk
Set an upper limit for the size or number of pieces of stretchy operators
https://bugs.webkit.org/show_bug.cgi?id=155434
Source/WebCore:
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.
Stretchy MathML operators can currently use an arbitrary number of extension glyphs to cover
a target size. This may result in hangs if large stretch sizes are requested. This change
only allow at most the 128 first extensions to be painted by the MathOperator class, which
should really be enough for mathematical formulas used in practice.
No new tests, already tested by very-large-stretchy-operators.
- rendering/mathml/MathOperator.cpp: Add a new kMaximumExtensionCount constant.
(WebCore::MathOperator::fillWithVerticalExtensionGlyph): Limit the number of step in this loop to kMaximumExtensionCount.
(WebCore::MathOperator::fillWithHorizontalExtensionGlyph): Ditto.
LayoutTests:
Update test expectations for very-large-stretchy-operators.
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 10:33 AM Changeset in webkit [202488] by
-
- 2 edits in trunk/Source/WebCore
Small refactoring MathMLInlineContainerElement::createElementRenderer
https://bugs.webkit.org/show_bug.cgi?id=159131
Reviewed by Brent Fulgham.
Many of the MathML renderer classes have been merged during the MathML refactoring. We
simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
by removing duplicate createRenderer calls.
No new tests, behavior unchanged.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createElementRenderer):
- 9:48 AM Changeset in webkit [202487] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
DFGByteCodeParsing does not handle calling the Object constructor with no arguments correctly
https://bugs.webkit.org/show_bug.cgi?id=159117
<rdar://problem/26996781>
Reviewed by Saam Barati.
DFGByteCodeParsing always assumed there would be an argument to the Object constructor.
This is clearly not always the case and we should be able to handle it.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
- tests/stress/indirect-call-object-constructor-with-no-arguments.js: Added.
(let.foo.Object.test):
- 9:01 AM Changeset in webkit [202486] by
-
- 2 edits in trunk/LayoutTests
Skip two LayoutTests that rely on mouse events on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 8:10 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 7:47 AM Changeset in webkit [202485] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Added Failure Test Expectations because of r194502 and r194513.
https://bugs.webkit.org/show_bug.cgi?id=159147
- platform/gtk/TestExpectations:
- 7:23 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:57 AM Changeset in webkit [202484] by
-
- 5 edits in trunk/Source
[GTK][EFL] Build with threaded compositor enabled is broken
https://bugs.webkit.org/show_bug.cgi?id=159138
Patch by Miguel Gomez <magomez@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No need to set the device scale. The compositor buffer is only used for the accelerated
canvas scenario, and the device scale is always 1 there.
This change was introduced in r202421.
Covered by existing tests.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::createCompositorBuffer):
Source/WebKit2:
Replace the usage of NoncopyableFunction with Function, to follow the changes in r202439.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::performTask):
(WebKit::CompositingRunLoop::performTaskSync):
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
- 2:22 AM Changeset in webkit [202483] by
-
- 1 edit2 adds in trunk/LayoutTests
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/ is failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=159136
Unreviewed.
Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-27
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt: Added.
- 2:21 AM Changeset in webkit [202482] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] top/bottom black bars added needlessly in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158980
Patch by Philippe Normand <philn@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.
The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.
Fixes an issue where black borders were added on top and bottom of
fullscreen video.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
- 2:01 AM Changeset in webkit [202481] by
-
- 2 edits in trunk/Tools
[Win] The test fast/events/wheel-event-outside-body.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=159129
Reviewed by Alex Christensen.
Implement the function mouseScrollBy in the Windows event sender.
- DumpRenderTree/win/EventSender.cpp:
(mouseScrollBy):
(mouseScrollByWithWheelAndMomentumPhasesCallback):
- 1:28 AM Changeset in webkit [202480] by
-
- 21 edits in trunk
Remove didFailRedirectCheck ThreadableLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=159085
Patch by Youenn Fablet <youenn@apple.com> on 2016-06-27
Reviewed by Daniel Bates.
Source/WebCore:
Removing didFailRedirectCheck and using didFailAccessControlCheck instead.
The change in behavior is that additional error messages are outputted in the console.
These messages give additional debugging information.
Covered by rebased tests.
- Modules/fetch/FetchLoader.cpp: Removing didFailRedirectCheck.
- Modules/fetch/FetchLoader.h: Ditto.
- inspector/InspectorNetworkAgent.cpp: Ditto.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived): Calling didFailAccessControlCheck with information on failing
URL.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
- loader/ThreadableLoaderClient.h: Removing didFailRedirectCheck.
- loader/ThreadableLoaderClientWrapper.h: Ditto.
- loader/WorkerThreadableLoader.cpp: Ditto.
- loader/WorkerThreadableLoader.h: Ditto.
- page/EventSource.cpp: Ditto.
- page/EventSource.h: Ditto.
- workers/WorkerScriptLoader.cpp: Ditto.
- workers/WorkerScriptLoader.h: Ditto.
- xml/XMLHttpRequest.cpp: Ditto.
- xml/XMLHttpRequest.h: Ditto.
LayoutTests:
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-csp-blocks-xhr-redirect-cross-origin-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
