Timeline
Feb 14, 2017:
- 11:50 PM Changeset in webkit [212350] by
-
- 8 edits4 adds in trunk
Revalidate URL after events that could trigger navigations
https://bugs.webkit.org/show_bug.cgi?id=168071
<rdar://problem/30450379>
Reviewed by Ryosuke Niwa.
Source/WebCore:
When arbitary javascript runs during a load, we should revalidate
the URLs involved to make sure they are still valid.
Tests: http/tests/plugins/navigation-during-load-embed.html
http/tests/plugins/navigation-during-load.html
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Confirm we are still allowed to
load the URL after executing JS callbacks.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed): Split existing function into
existing protected method, and a new public method that checks a passed URL
for validity.
- html/HTMLFrameElementBase.h:
- html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::isURLAllowed):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Confirm we are still allowed to
load the URL after executing JS callbacks.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestFrame): Ditto.
LayoutTests:
- http/tests/plugins/navigation-during-load-embed-expected.txt: Added.
- http/tests/plugins/navigation-during-load-embed.html: Added.
- http/tests/plugins/navigation-during-load-expected.txt: Added.
- http/tests/plugins/navigation-during-load.html: Added.
- 11:44 PM Changeset in webkit [212349] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=168322
Reviewed by Žan Doberšek.
It currently returns true unconditionally. Add resolved-location property to WebKitWebSourceGStreamer to track
the resolved url returned by the server and use that from MediaPlayerPrivate to check if there was a cross
origin redirection.
Fixes: http/tests/security/canvas-remote-read-remote-video-redirect.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcFinalize):
(webKitWebSrcGetProperty):
(webKitWebSrcStart):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(StreamingClient::handleResponseReceived):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
- 11:40 PM Changeset in webkit [212348] by
-
- 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore
Merge r212346 - Unreviewed, rolling out r211967.
Caused rendering issues in HiDPI
Reverted changeset:
"[GTK] scroll with transparent background not repainted after
scrollY >= 32768"
https://bugs.webkit.org/show_bug.cgi?id=154283
http://trac.webkit.org/changeset/211967
- 11:40 PM Changeset in webkit [212347] by
-
- 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore
Merge r212228 - [GTK] Non-accelerated drawing is broken with HiDPI
https://bugs.webkit.org/show_bug.cgi?id=168128
Reviewed by Michael Catanzaro.
When device scale factor changes, the page notifies the page overlay controller about it. Then overlay root
layers are created to be notified about the device scale factor. That causes us to enter in accelerated
compositing mode, because the graphics layer factory is called. But the render layer compositor doesn't really
enter in accelerated mode, because there aren't page overlays, the accelerated mode is not forced and the website
doesn't require acceleration either. This leaves our drawing area in an inconsistent state, it thinks it's in AC
mode because it has a layer tree host, but without a root layer attached, so nothing is rendered. The page
overlay controller doesn't need to create the layers when device scale factor changes, when an overlay is
installed, layers will be created with the current device scale factor anyway.
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::didChangeDeviceScaleFactor): Return early if not initialized yet.
- 11:37 PM Changeset in webkit [212346] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r211967.
Caused rendering issues in HiDPI
Reverted changeset:
"[GTK] scroll with transparent background not repainted after
scrollY >= 32768"
https://bugs.webkit.org/show_bug.cgi?id=154283
http://trac.webkit.org/changeset/211967
- 11:34 PM Changeset in webkit [212345] by
-
- 27 edits in trunk
[GTK] Update cookie manager API to properly work with ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=168230
Reviewed by Michael Catanzaro.
Source/WebCore:
Add implementation for deleteAllCookiesModifiedSince. Note that this only works when the timespan is 0, we need
new libsoup API to support removing recently modified cookies.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteAllCookiesModifiedSince):
Source/WebKit2:
WebKitCookieManager is associated to a particular WebKitWebContext and uses the default session ID
unconditionally. It should be associated to a WebKitWebsiteDataManager instead and use its session ID. This
patch also adds support for handling cookies with WebKitWebsiteDataManager and deprecates
webkit_cookie_manager_get_domains_with_cookies(), webkit_cookie_manager_delete_cookies_for_domain() and
webkit_cookie_manager_delete_all_cookies(). It also adds API to get the the WebKitWebsiteDataManager of a
WebKitWebView, since it's the only way to get the WebKitCookieManager associated to an ephemeral web view.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerDispose): Stop observing cookie changes.
(webkit_cookie_manager_class_init): Add dispose implementation.
(webkitCookieManagerCreate): Create the WebKitCookieManager with a WebKitWebsiteDataManager.
(webkit_cookie_manager_set_persistent_storage): Work with all contexts having the session.
(webkit_cookie_manager_set_accept_policy): Ditto.
(webkit_cookie_manager_get_accept_policy): Use any context having the session.
(webkit_cookie_manager_get_domains_with_cookies): Deprecate and implement using WebKitWebsiteDataManager.
(webkit_cookie_manager_get_domains_with_cookies_finish): Ditto.
(webkit_cookie_manager_delete_cookies_for_domain): Ditto.
(webkit_cookie_manager_delete_all_cookies): Ditto.
- UIProcess/API/gtk/WebKitCookieManager.h:
- UIProcess/API/gtk/WebKitCookieManagerPrivate.h:
- UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp:
(attachCustomProtocolManagerClientToContext):
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
(attachDownloadClientToContext):
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(attachInjectedBundleClientToContext):
- UIProcess/API/gtk/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed): Call webkitWebsiteDataManagerAddProcessPool.
(webkitWebContextDispose): Call webkitWebsiteDataManagerRemoveProcessPool.
(webkit_web_context_get_cookie_manager): Return the WebKitCookieManager of the WebKitWebsiteDataManager.
(webkitWebContextGetProcessPool): Make it return a reference.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Call webkitWebsiteDataManagerAddProcessPool when creating a ephemeral web view.
(webkitWebViewDispose): Call webkitWebsiteDataManagerRemoveProcessPool if needed.
(webkit_web_view_get_website_data_manager): Return the WebKitWebsiteDataManager or the context one.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebsiteData.cpp: Add support for Cookies type.
(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):
- UIProcess/API/gtk/WebKitWebsiteData.h:
- UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:
(_WebKitWebsiteDataManagerPrivate::~_WebKitWebsiteDataManagerPrivate): Ensure all contexts were unregistered.
(webkitWebsiteDataManagerAddProcessPool): Register the process pool in the session.
(webkitWebsiteDataManagerRemoveProcessPool): Unregister the process poll from the session.
(webkitWebsiteDataManagerGetProcessPools): Return the list of proces pools registered.
(webkit_website_data_manager_get_cookie_manager): Return the WebKitCookieManager.
(toWebsiteDataTypes): Add Cookies.
- UIProcess/API/gtk/WebKitWebsiteDataManager.h:
- UIProcess/API/gtk/WebKitWebsiteDataManagerPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::displayNameForCookieHostName): Handle localhost as a special case here for backwards
compatibility.
Tools:
Update unit tests and add new cases for the new API.
- MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):
- TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
(testCookieManagerEphemeral):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextEphemeral):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewEphemeral):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
(serverCallback):
(testWebsiteDataEphemeral):
(testWebsiteDataCookies):
(beforeAll):
- 11:12 PM Changeset in webkit [212344] by
-
- 12 edits in trunk/Source/WebCore
[WebIDL] Improve serializer = { inherit }
https://bugs.webkit.org/show_bug.cgi?id=168293
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-14
Reviewed by Youenn Fablet.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Expose a serialize() method on the interface.
(GenerateSerializerFunction):
(GenerateSerializerAttributesForInterface): Deleted.
Subclasses that haveserializer = { inherit }can use
their parent's serialize() method to get the initial object.
We can now collapse everything back into a single function
because we only generate code for our own attributes.
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNode::serialize):
(WebCore::jsTestNodePrototypeFunctionToJSONCaller):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::serialize):
(WebCore::jsTestObjPrototypeFunctionToJSONCaller):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestSerialization.cpp:
(WebCore::JSTestSerialization::serialize):
(WebCore::jsTestSerializationPrototypeFunctionToJSONCaller):
- bindings/scripts/test/JS/JSTestSerialization.h:
- bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
(WebCore::JSTestSerializationInherit::serialize):
(WebCore::jsTestSerializationInheritPrototypeFunctionToJSONCaller):
- bindings/scripts/test/JS/JSTestSerializationInherit.h:
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
(WebCore::JSTestSerializationInheritFinal::serialize):
(WebCore::jsTestSerializationInheritFinalPrototypeFunctionToJSONCaller):
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.h:
Updated results.
- 9:19 PM Changeset in webkit [212343] by
-
- 12 edits in trunk/Source/WebCore
Move methods from WebCoreThread.h to WebCoreThreadInternal.h
https://bugs.webkit.org/show_bug.cgi?id=168326
Reviewed by Alexey Proskuryakov.
- platform/ios/wak/WebCoreThread.h: Move methods WebThreadRunLoop and WebThreadCurrentContext to WebCoreThreadInternal.h
- platform/ios/wak/WebCoreThreadInternal.h: Ditto.
- platform/ios/wak/WebCoreThreadRun.cpp: Removed WebCoreThread.h as it is already included by WebCoreThreadInternal.h
- platform/ios/wak/WKGraphics.mm: Included WebCoreThreadInternal.h, it subsequently includes WebCoreThread.h
- inspector/InspectorTimelineAgent.cpp: Ditto.
- page/mac/PageMac.mm: Ditto.
- platform/cf/MainThreadSharedTimerCF.cpp: Ditto.
- platform/cocoa/MemoryPressureHandlerCocoa.mm: Ditto.
- platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Ditto.
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Ditto.
- bindings/js/CommonVM.cpp: included WebCoreThreadInternal.h
- 9:05 PM Changeset in webkit [212342] by
-
- 17 edits2 adds in trunk
[WK2] Support data interaction on links
https://bugs.webkit.org/show_bug.cgi?id=168331
<rdar://problem/30200837>
Reviewed by Tim Horton.
Source/WebCore:
Adds support for data interaction on links at the WebCore layer, refactoring some drag-and-drop code on the Mac
along the way. Also adds two new TestWebKitAPI unit tests in DataInteractionTests.mm: LinkToInput and
BackgroundImageLinkToInput (see Tools/ChangeLog for more information).
- page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
Introduce platformAdjustDragImageForDeviceScaleFactor, and special-case drag images for links to anchor at the
bottom center.
- platform/DragImage.cpp:
(WebCore::platformAdjustDragImageForDeviceScaleFactor):
Scale the drag image up by the device scale factor. In WebDragClient, we scale the image back down to the
original size. It seems the reason we do this extra dance is because the image sizing heuristic in between
assumes that the image dimensions are for a non-retina device, but this work should really not be necessary if
we tweak the heuristic to account for deviceScaleFactor. We should address this in a separate patch.
- platform/DragImage.h:
- platform/graphics/Path.h:
Source/WebKit2:
Adds support for data interaction on links at the client layer for WebKit2. This involves several changes,
detailed in the per-method changes below:
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
Add adjustedPointForNodeRespondingToClickEvents (the request point, adjusted to take nodeRespondingToClickEvents
into account) to InteractionInformationAtPosition. The web process sends this adjusted point over to the UI
process so that the UI process will be able to begin a data interaction at the adjusted point rather than the
request point, which is necessary for small clickable (and data-interactive) elements such as links.
- UIProcess/ios/WKActionSheet.h:
- UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet presentSheet:]):
(-[WKActionSheet _presentationRectForStyle:]):
(-[WKActionSheet updateSheetPosition]):
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
(-[WKActionSheetAssistant presentationRectForIndicatedElement]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant _shouldPresentAtTouchLocationForElementRect:]):
(-[WKActionSheetAssistant needsLinkIndicator]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant cleanupSheet]):
(-[WKActionSheetAssistant _presentationStyleForImageAtElementRect:]): Deleted.
Add support for the WKActionSheetPresentAtClosestIndicatorRect style of presenting an action sheet. When
showing the action sheet for a link and there is space along the margins to show a popover in the first place,
we will now target the popover rect to the bounding rect of the set of adjacent (or nearly-adjacent) element
rects closest to the user's touch location. This covers cases where the link is split into multiple rects due to
a line break, when the link is on multiple lines with a jagged rect per line, and when both of the above are
true.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView pointIsInDataInteractionContent:]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView positionInformationForActionSheetAssistant:]):
(-[WKContentView updatePositionInformationForActionSheetAssistant:]):
Include link indicator data in the position information request if needed. As the FIXME suggests, this can be
improved by asynchronously presenting the action sheet assistant after the request returns, and is something we
should address in the future.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Tools:
Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
editable area results in the link URL being inserted.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 7:06 PM Changeset in webkit [212341] by
-
- 1 copy in tags/Safari-604.1.5.6
Tag Safari-604.1.5.6.
- 6:50 PM Changeset in webkit [212340] by
-
- 2 edits in trunk/Source/WebCore
[CURL] ResourceError created with error information should have default type Type::General
https://bugs.webkit.org/show_bug.cgi?id=168345
Patch by Basuke Suzuki <Basuke.Suzuki@am.sony.com> on 2017-02-14
Reviewed by Alex Christensen.
ResourceError has separate implementaion for each platform
so that the interface should be same.
On CURL port, the constructor with error information has
different default value ontypeparameter. It is Type::Null but other implementaitons have Type::General.
This causes some ResourceError is created inconsistent.
- platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
- 5:50 PM Changeset in webkit [212339] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: adjust padding of dashboard icons
https://bugs.webkit.org/show_bug.cgi?id=168340
Reviewed by Matt Baker.
Extract the direction-dependent padding into a "local" variable.
Use two rules to apply it to whichever is the leading side.
While we tend to use leading/trailing in Apple layout technologies,
I think the CSS logical properties specification sticks to using
-start and -end, so let's use that nomenclature where we can.
- UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item > div):
(body[dir=ltr] .toolbar .dashboard.default > .item > div):
(body[dir=rtl] .toolbar .dashboard.default > .item > div):
- 5:23 PM Changeset in webkit [212338] by
-
- 11 edits1 copy3 adds in trunk
[WebRTC] Add support for libwebrtc negotiation needed event
https://bugs.webkit.org/show_bug.cgi?id=168267
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-14
Reviewed by Eric Carlson.
Source/WebCore:
Test: webrtc/negotiatedneeded-event-addStream.html
Moving generic code (markAsNeedingNegotiation) from MediaEndpointPeerConnection to PeerConnectionBackend.
This code handles the control of sending or not the negotiationneeded event.
Updating mock to use markAsNeedingNegotiation when streams are changed.
Updating libwebrtc backend to call markAsNeedingNegotiation when required by libwebrtc implementation.
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::markAsNeedingNegotiation):
- Modules/mediastream/PeerConnectionBackend.h:
(WebCore::PeerConnectionBackend::isNegotiationNeeded):
(WebCore::PeerConnectionBackend::clearNegotiationNeededState):
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnRenegotiationNeeded):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::MockLibWebRTCPeerConnection::AddStream):
(WebCore::MockLibWebRTCPeerConnection::RemoveStream):
LayoutTests:
- fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt:
- platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt.
- webrtc/negotiatedneeded-event-addStream-expected.txt: Added.
- webrtc/negotiatedneeded-event-addStream.html: Added.
- 4:35 PM Changeset in webkit [212337] by
-
- 2 edits in trunk/LayoutTests
Mark media/modern-media-controls/placard-support/placard-support-airplay.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167441
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:29 PM Changeset in webkit [212336] by
-
- 2 edits in trunk/LayoutTests
Mark media/video-zoom.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168087
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:20 PM Changeset in webkit [212335] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed followup to r212330 to fix Debug builds
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Add call to relaxAdoptionRequirement().
- 4:11 PM Changeset in webkit [212334] by
-
- 5 edits1 add in trunk
Source/WebKit2:
Add new WKWebKit Cocoa API for getContentsAsString.
https://bugs.webkit.org/show_bug.cgi?id=168147
<rdar://problem/30502539>
Patch by Jason Rinn <jrinn@apple.com> on 2017-02-14
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getContentsAsStringWithCompletionHandler:]): New API for getContentsAsString.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
Add a test for new WebKit Cocoa API, _getContentsAsString.
https://bugs.webkit.org/show_bug.cgi?id=168147
<rdar://problem/30502539>
Patch by Jason Rinn <jrinn@apple.com> on 2017-02-14
Reviewed by Tim Horton.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
(TEST):
- 4:08 PM Changeset in webkit [212333] by
-
- 28 edits1 delete in trunk/Source/ThirdParty/libwebrtc
Unreviewed, rolling out r212326.
This change broke certain build configurations.
Reverted changeset:
"Make libwebrtc.dylib"
https://bugs.webkit.org/show_bug.cgi?id=168335
http://trac.webkit.org/changeset/212326
- 3:37 PM Changeset in webkit [212332] by
-
- 5 edits2 adds in trunk
Website policies: iframes should respect the autoplay policy of the top-level document
https://bugs.webkit.org/show_bug.cgi?id=168333
Reviewed by Alex Christensen.
Source/WebCore:
API tests were added.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
Tools:
- TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
- TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):
- 3:31 PM Changeset in webkit [212331] by
-
- 8 edits in trunk/Source
Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
https://bugs.webkit.org/show_bug.cgi?id=168339
Source/WebCore:
<rdar://problem/30522092>
Reviewed by Simon Fraser.
Use a setting name that more clearly reflects what it is doing. It's not
preferring to use the low-power GPU, it's forcing it.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
- page/Settings.in:
Source/WebKit/mac:
Reviewed by Simon Fraser.
Use a better name.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences forceLowPowerGPUForWebGL]):
(-[WebPreferences setForceLowPowerGPUForWebGL:]):
(-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
(-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 3:26 PM Changeset in webkit [212330] by
-
- 2 edits in trunk/Source/WebCore
Speculative fix for: Crash in DocumentThreadableLoader::redirectReceived.
<rdar://problem/29899473> and https://bugs.webkit.org/show_bug.cgi?id=168337
Reviewed by Geoffrey Garen.
No new tests (Unable to find a reproduction).
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
- 3:17 PM Changeset in webkit [212329] by
-
- 15 edits5 deletes in trunk/Source/WebCore
[WebRTC] Remove obsolete WebRTC stats API
https://bugs.webkit.org/show_bug.cgi?id=167910
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-14
Reviewed by Alex Christensen.
No change of behavior as removed constructs are not functional.
Removing RTCStatsResponse which no longer exists and made RTCStatsReport an empty container for now.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::getStats):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStats):
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::create): Deleted.
(WebCore::RTCStatsReport::RTCStatsReport): Deleted.
(WebCore::RTCStatsReport::names): Deleted.
(WebCore::RTCStatsReport::local): Deleted.
(WebCore::RTCStatsReport::remote): Deleted.
(WebCore::RTCStatsReport::addStatistic): Deleted.
- Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::timestamp): Deleted.
(WebCore::RTCStatsReport::id): Deleted.
(WebCore::RTCStatsReport::type): Deleted.
(WebCore::RTCStatsReport::stat): Deleted.
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.cpp: Removed.
- Modules/mediastream/RTCStatsResponse.h: Removed.
- Modules/mediastream/RTCStatsResponse.idl: Removed.
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/MediaEndpoint.h:
(WebCore::MediaEndpoint::getStats):
- platform/mediastream/RTCStatsRequest.h: Removed.
- platform/mediastream/RTCStatsResponseBase.h: Removed.
- 3:16 PM Changeset in webkit [212328] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168336
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:16 PM Changeset in webkit [212327] by
-
- 5 edits in trunk/Source/WebCore
Removed unused methods of WebCore::FileStream
https://bugs.webkit.org/show_bug.cgi?id=168025
Patch by Karim H <karim@karhm.com> on 2017-02-14
Reviewed by Michael Catanzaro.
- fileapi/AsyncFileStream.cpp:
(WebCore::AsyncFileStream::openForWrite): Deleted.
(WebCore::AsyncFileStream::write): Deleted.
(WebCore::AsyncFileStream::truncate): Deleted.
- fileapi/AsyncFileStream.h:
- platform/FileStream.cpp:
(WebCore::FileStream::openForWrite): Deleted.
(WebCore::FileStream::write): Deleted.
(WebCore::FileStream::truncate): Deleted.
- platform/FileStream.h:
- 3:11 PM Changeset in webkit [212326] by
-
- 28 edits3 adds in trunk/Source/ThirdParty/libwebrtc
Make libwebrtc.dylib
https://bugs.webkit.org/show_bug.cgi?id=168335
Reviewed by Dan Bernstein.
We were building libwebrtc as a static library, which would prevent us from weak linking with it.
We need to explicitly export what we use from WebCore or WebKit2, and RTCLogging.mm now needs to
be built on Mac, so we make it not automatically reference counted to make it work on 32-bit El Capitan.
- Configurations/libwebrtc.xcconfig:
- Source/webrtc/api/jsep.h:
- Source/webrtc/api/mediastream.h:
- Source/webrtc/api/notifier.h:
(webrtc::Notifier::Notifier): Deleted.
(webrtc::Notifier::RegisterObserver): Deleted.
(webrtc::Notifier::UnregisterObserver): Deleted.
(webrtc::Notifier::FireOnChanged): Deleted.
- Source/webrtc/api/peerconnectioninterface.h:
- Source/webrtc/base/asyncpacketsocket.h:
- Source/webrtc/base/asyncresolverinterface.h:
(rtc::AsyncResolverInterface::address): Deleted.
- Source/webrtc/base/copyonwritebuffer.h:
(rtc::CopyOnWriteBuffer::CopyOnWriteBuffer): Deleted.
(rtc::CopyOnWriteBuffer::data): Deleted.
(rtc::CopyOnWriteBuffer::cdata): Deleted.
(rtc::CopyOnWriteBuffer::size): Deleted.
(rtc::CopyOnWriteBuffer::capacity): Deleted.
(rtc::CopyOnWriteBuffer::operator=): Deleted.
(rtc::CopyOnWriteBuffer::operator!=): Deleted.
(rtc::CopyOnWriteBuffer::operator[]): Deleted.
(rtc::CopyOnWriteBuffer::SetData): Deleted.
(rtc::CopyOnWriteBuffer::AppendData): Deleted.
(rtc::CopyOnWriteBuffer::swap): Deleted.
(rtc::CopyOnWriteBuffer::IsConsistent): Deleted.
- Source/webrtc/base/event.h:
- Source/webrtc/base/export.h: Added.
- Source/webrtc/base/helpers.h:
- Source/webrtc/base/ipaddress.h:
(rtc::IPAddress::IPAddress): Deleted.
(rtc::IPAddress::~IPAddress): Deleted.
(rtc::IPAddress::operator=): Deleted.
(rtc::IPAddress::family): Deleted.
- Source/webrtc/base/location.h:
(rtc::Location::function_name): Deleted.
(rtc::Location::file_and_line): Deleted.
- Source/webrtc/base/messagehandler.h:
(rtc::MessageHandler::MessageHandler): Deleted.
- Source/webrtc/base/network.h:
(rtc::NetworkManagerBase::ipv6_enabled): Deleted.
(rtc::NetworkManagerBase::set_ipv6_enabled): Deleted.
(rtc::NetworkManagerBase::set_max_ipv6_networks): Deleted.
(rtc::NetworkManagerBase::max_ipv6_networks): Deleted.
(rtc::NetworkManagerBase::set_enumeration_permission): Deleted.
(rtc::BasicNetworkManager::started): Deleted.
(rtc::BasicNetworkManager::set_network_ignore_list): Deleted.
(rtc::BasicNetworkManager::set_ignore_non_default_routes): Deleted.
(rtc::Network::default_local_address_provider): Deleted.
(rtc::Network::set_default_local_address_provider): Deleted.
(rtc::Network::name): Deleted.
(rtc::Network::description): Deleted.
(rtc::Network::prefix): Deleted.
(rtc::Network::prefix_length): Deleted.
(rtc::Network::key): Deleted.
(rtc::Network::ip): Deleted.
(rtc::Network::AddIP): Deleted.
(rtc::Network::GetIPs): Deleted.
(rtc::Network::ClearIPs): Deleted.
(rtc::Network::scope_id): Deleted.
(rtc::Network::set_scope_id): Deleted.
(rtc::Network::ignored): Deleted.
(rtc::Network::set_ignored): Deleted.
(rtc::Network::type): Deleted.
(rtc::Network::set_type): Deleted.
(rtc::Network::GetCost): Deleted.
(rtc::Network::id): Deleted.
(rtc::Network::set_id): Deleted.
(rtc::Network::preference): Deleted.
(rtc::Network::set_preference): Deleted.
(rtc::Network::active): Deleted.
(rtc::Network::set_active): Deleted.
- Source/webrtc/base/proxyinfo.h:
- Source/webrtc/base/refcountedobject.h:
(rtc::RefCountedObject::RefCountedObject): Deleted.
(rtc::RefCountedObject::AddRef): Deleted.
(rtc::RefCountedObject::Release): Deleted.
(rtc::RefCountedObject::HasOneRef): Deleted.
(rtc::RefCountedObject::~RefCountedObject): Deleted.
- Source/webrtc/base/socketaddress.h:
(rtc::SocketAddress::hostname): Deleted.
(rtc::SocketAddress::family): Deleted.
(rtc::SocketAddress::scope_id): Deleted.
(rtc::SocketAddress::SetScopeID): Deleted.
(rtc::SocketAddress::operator !=): Deleted.
- Source/webrtc/base/thread.h:
- Source/webrtc/common_types.h:
- Source/webrtc/common_video/include/video_frame_buffer.h:
(webrtc::I420Buffer::Copy): Deleted.
(webrtc::I420Buffer::CropAndScaleFrom): Deleted.
(webrtc::I420Buffer::ScaleFrom): Deleted.
- Source/webrtc/common_video/libyuv/include/webrtc_libyuv.h:
- Source/webrtc/p2p/base/basicpacketsocketfactory.h:
- Source/webrtc/p2p/client/basicportallocator.h:
(cricket::BasicPortAllocator::network_ignore_mask): Deleted.
(cricket::BasicPortAllocator::network_manager): Deleted.
(cricket::BasicPortAllocator::socket_factory): Deleted.
- Source/webrtc/sdk/objc/Framework/Classes/RTCLogging.mm:
(RTCFileName):
- Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:
- Source/webrtc/video_frame.h:
(webrtc::VideoFrame::timestamp_us): Deleted.
(webrtc::VideoFrame::set_timestamp_us): Deleted.
(webrtc::VideoFrame::set_timestamp): Deleted.
(webrtc::VideoFrame::timestamp): Deleted.
(webrtc::VideoFrame::transport_frame_id): Deleted.
(webrtc::VideoFrame::set_ntp_time_ms): Deleted.
(webrtc::VideoFrame::ntp_time_ms): Deleted.
(webrtc::VideoFrame::rotation): Deleted.
(webrtc::VideoFrame::set_rotation): Deleted.
(webrtc::VideoFrame::set_render_time_ms): Deleted.
(webrtc::VideoFrame::render_time_ms): Deleted.
(webrtc::VideoFrame::is_texture): Deleted.
- build: Added.
- build/Debug: Added.
- libwebrtc.xcodeproj/project.pbxproj:
- 3:11 PM Changeset in webkit [212325] by
-
- 25 edits2 adds in trunk
HTML Form Validation bubble should take minimum font size setting into consideration
https://bugs.webkit.org/show_bug.cgi?id=168271
<rdar://problem/29869869>
Reviewed by Simon Fraser.
Source/WebCore:
HTML Form Validation bubble should take minimum font size setting into consideration
for better accessibility.
Test: fast/forms/validation-message-minimum-font-size.html
- platform/ValidationBubble.h:
(WebCore::ValidationBubble::create):
(WebCore::ValidationBubble::fontSize):
- platform/ios/ValidationBubbleIOS.mm:
(WebCore::ValidationBubble::ValidationBubble):
- platform/mac/ValidationBubbleMac.mm:
(WebCore::ValidationBubble::ValidationBubble):
Update the ValidationBubble constructor to take in Settings. For now, there is a
single setting that is the minimum font size and that is taken into account when
setting the font size of the validation bubble text.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _contentsOfUserInterfaceItem:]):
Return font size used in the validation bubble.
(-[WebView showFormValidationMessage:withAnchorRect:]):
Pass minimum font size setting when constructing the validation bubble.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _contentsOfUserInterfaceItem:]):
Return font size used in the validation bubble.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createValidationBubble):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::showValidationMessage):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createValidationBubble):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showValidationMessage):
Pass minimum font size setting when constructing the form validation bubble.
Tools:
Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
font size of the validation bubble.
Add an overridePreference() method to UIScriptController. This is currently
used to override the value of the minimumFontSize setting. testRunner's
overridePreference() is not usable on WK2 because it does not update the
value of the preference on the UIProcess side.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::overridePreference):
- DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::overridePreference):
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::overridePreference):
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::contentsOfUserInterfaceItem):
(WTR::UIScriptController::overridePreference):
LayoutTests:
Add layout test coverage.
- fast/forms/validation-message-minimum-font-size-expected.txt: Added.
- fast/forms/validation-message-minimum-font-size.html: Added.
- 2:51 PM Changeset in webkit [212324] by
-
- 2 edits in trunk/LayoutTests
Remove debug flag from flaky test imported/w3c/web-platform-tests/dom/events/EventListener-invoke-legacy.html.
https://bugs.webkit.org/show_bug.cgi?id=168238
Unreviewed test gardening.
- 2:34 PM Changeset in webkit [212323] by
-
- 14 edits6 adds in trunk
[MediaStream] add navigator.getUserMedia for compatibility with legacy content
https://bugs.webkit.org/show_bug.cgi?id=168324
<rdar://problem/30513125>
Reviewed by Youenn Fablet.
Source/WebCore:
Tests: fast/mediastream/argument-types.html
fast/mediastream/getusermedia.html
fast/mediastream/webkitGetUserMedia-shadowing-then.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/mediastream/MediaDevices.idl:
- Modules/mediastream/NavigatorUserMedia.idl: Added.
- Modules/mediastream/NavigatorUserMedia.js: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- page/Navigator.idl:
Source/WebInspectorUI:
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
- fast/mediastream/argument-types-expected.txt:
- fast/mediastream/argument-types.html: Added.
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html: Added.
- fast/mediastream/script-tests/argument-types.js: Added.
- fast/mediastream/webkitGetUserMedia-shadowing-then.html: Added.
- 1:15 PM Changeset in webkit [212322] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed, rolling out r211879.
https://bugs.webkit.org/show_bug.cgi?id=168330
Not ready for the menu yet (Requested by eric_car_ on
#webkit).
Reverted changeset:
"Add WebRTC as an off-by-default experimental feature menu
item."
https://bugs.webkit.org/show_bug.cgi?id=167972
http://trac.webkit.org/changeset/211879
- 1:11 PM Changeset in webkit [212321] by
-
- 5 edits in trunk
Fallback to legacy type only when event is trusted
https://bugs.webkit.org/show_bug.cgi?id=168301
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline web-platform-test now tha more checks are passing.
- web-platform-tests/dom/events/EventListener-invoke-legacy-expected.txt:
Source/WebCore:
Fallback to legacy type only when event is trusted as per a recent
DOM specification change:
No new tests, rebaselined existing test.
- dom/EventTarget.cpp:
(WebCore::legacyType):
(WebCore::EventTarget::fireEventListeners):
- 1:08 PM Changeset in webkit [212320] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove an unused delegate method
https://bugs.webkit.org/show_bug.cgi?id=168328
Reviewed by Wenson Hsieh.
- DefaultDelegates/WebDefaultUIDelegate.m:
(-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
- 1:01 PM Changeset in webkit [212319] by
-
- 2 edits in trunk/Tools
Use a set instead of a list for tests when parsing expectations
https://bugs.webkit.org/show_bug.cgi?id=168304
In _collect_matching_tests, a lot of membership tests are done on a giant list
of strings. By making it a set instead, we can make those much faster, and
there's no reason for it to be a list.
With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
to 3s on my machine.
Patch by Florian Bruhin <git@the-compiler.org> on 2017-02-14
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.init):
(TestExpectationParser._collect_matching_tests):
- 12:56 PM Changeset in webkit [212318] by
-
- 6 edits in branches/safari-604.1.5-branch/Source
Versioning.
- 12:56 PM Changeset in webkit [212317] by
-
- 2 edits in branches/safari-604.1.5-branch/Source/WebCore
Merge r211530. rdar://problem/30112683
- 12:12 PM Changeset in webkit [212316] by
-
- 11 edits in trunk
Rename preferLowPowerToHighPerformance to powerPreference
https://bugs.webkit.org/show_bug.cgi?id=168269
<rdar://problem/30504444>
Reviewed by Chris Dumez.
Source/WebCore:
Based on the discussion in https://github.com/KhronosGroup/WebGL/pull/2283.
Change WebGLContextAttributes's preferLowPowerToHighPerformance boolean
into a powerPreference enum taking three values. The implementation
of the enum is in GraphicsContext3DAttributes.
While the name and values have changed, there should be no change in
behaviour caused by this patch.
- html/canvas/WebGLContextAttributes.h: Use GraphicsContext3DAttributes
enum GraphicsContext3DPowerPreference.
- html/canvas/WebGLContextAttributes.idl: Rename and add the WebIDL enum.
- html/canvas/WebGLRenderingContextBase.cpp: Use the new values.
(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):
- platform/WebGLStateTracker.cpp:
- platform/WebGLStateTracker.h: Update the state tracker to use the new
values.
- platform/graphics/GraphicsContext3DAttributes.h:
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::setPixelFormat): Accept GraphicsContext3DPowerPreference as a parameter.
(WebCore::GraphicsContext3D::GraphicsContext3D):
LayoutTests:
Handle the rename in the test case. Since Settings.in has
preferLowPowerWebGLRendering initial=true
we will override the incoming request and set the value to
"low-power". This behaviour will change in a subsequent bug.
- fast/canvas/webgl/context-creation-attributes-expected.txt:
- fast/canvas/webgl/context-creation-attributes.html:
- 11:40 AM Changeset in webkit [212315] by
-
- 5 edits in trunk/Source/WebCore
[WebRTC] Implement description getters for libwebrtc RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=168234
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-14
Reviewed by Alex Christensen.
Allows passing W3C webrtc tests.
Implementing localDescription/remoteDescription using libwebrtc backend.
current and pending description getters are made the same as local/remote getters for the moment.
This should be fixed when upgrading to latest libwebrtc revision.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::toSessionDescriptionType):
(WebCore::fromSessionDescriptionType):
(WebCore::fromSessionDescription):
(WebCore::LibWebRTCMediaEndpoint::localDescription):
(WebCore::LibWebRTCMediaEndpoint::remoteDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::localDescription):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- 11:34 AM Changeset in webkit [212314] by
-
- 6 edits2 adds in trunk
When playing inline after fullscreen, set a flag instead of adding attribute plays inline, and use in requiresFullscreenForVideoPlayback.
https://bugs.webkit.org/show_bug.cgi?id=167815
rdar://problem/27685077
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-02-14
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-fullscreen-loop-inline.html
When video is allowed to play inline after fullscreen. Looped video causes play state to update, which can send video back to fullscreen when
allowsInline is false. This change will set a new flag when allowsInlineMediaPlaybackAfterFullscreen allows inline playback that can be tested
in requiresFullscreenForVideoPlayback to prevent sending video back into fullscreen when video loops.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isTemporarilyAllowingInlinePlaybackAfterFullscreen): Added.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
LayoutTests:
Add a new test that tests inline after fullscreen behavior of looping video.
- media/media-fullscreen-loop-inline-expected.txt: Added.
- media/media-fullscreen-loop-inline.html: Added.
- platform/mac-wk2/TestExpectations: Skipped on webkit2.
- 11:24 AM Changeset in webkit [212313] by
-
- 2 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/airplay-button/airplay-button-on.html for ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator/media/modern-media-controls/airplay-button/airplay-button-on-expected.txt:
- 11:20 AM Changeset in webkit [212312] by
-
- 9 edits in trunk/Source/WebKit2
Add logging and defensive fixes to try to detect problems causing blank tabs
https://bugs.webkit.org/show_bug.cgi?id=168270
rdar://problem/30505482
Reviewed by Jon Lee.
Add release logging when -[WKWebView _beginAnimatedResizeWithUpdates:] and -[WKWebView _endAnimatedResize]
are unbalanced across a commit, to detect cases where _endAnimatedResize wasn't called enough times.
Also log when RemoteLayerTreeHost::updateLayerTree() fails to find a root layer, which should never happen.
In WebPageProxy, clear m_firstLayerTreeTransactionIdAfterDidCommitLoad on a web process crash.
- Platform/Logging.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::isAlwaysOnLoggingAllowed):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::clearLayers):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::WebFrame):
- WebProcess/WebPage/WebFrame.h:
- 11:17 AM Changeset in webkit [212311] by
-
- 16 edits2 adds3 deletes in trunk
Video elements with MediaSource objects set by srcObject are not cleared when srcObject is set to null
https://bugs.webkit.org/show_bug.cgi?id=168268
Reviewed by Eric Carlson.
Source/WebCore:
Test: fast/mediastream/MediaStream-MediaElement-setObject-null.html
Make the setSrcObject() operation compliant with the HTML spec. Since the specification defines
srcObject in terms of either a MediaSource, MediaStream, or Blob object, add the variant typedef
to HTMLMediaElement and move the definition out of the Modules/mediastream extension IDL and into
HTMLMediaElement.idl. Then bring the "media elements load" and "resource selection" algorithms up
to their most recent definitions in the HTML5 spec.
Drive-by fix: Allow the (admittedly weird) single-element-union type in IDL.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/mediastream/HTMLMediaElementMediaStream.cpp: Removed.
- Modules/mediastream/HTMLMediaElementMediaStream.h: Removed.
- Modules/mediastream/HTMLMediaElementMediaStream.idl: Removed.
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/IDLParser.pm:
(parseUnionType):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLMediaElement.cpp:
(WebCore::actionName):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::scheduleNextSourceChild):
(WebCore::HTMLMediaElement::pendingActionTimerFired):
(WebCore::HTMLMediaElement::setSrcObject):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::mediaCanStart):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::loadInternal): Deleted.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::srcObject):
- html/HTMLMediaElement.idl:
- platform/ContentType.h:
LayoutTests:
- fast/mediastream/MediaStream-MediaElement-setObject-null-expected.txt: Added.
- fast/mediastream/MediaStream-MediaElement-setObject-null.html: Added.
- fast/mediastream/MediaStream-video-element-expected.txt:
- fast/mediastream/MediaStream-video-element-track-stop-expected.txt:
- fast/mediastream/MediaStream-video-element-track-stop.html:
- fast/mediastream/MediaStream-video-element.html:
- 11:13 AM Changeset in webkit [212310] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add JSC_sweepSynchronously and fix JSC_useZombieMode options.
https://bugs.webkit.org/show_bug.cgi?id=168257
<rdar://problem/30451496>
Reviewed by Filip Pizlo.
JSC_useZombieMode now basically enables JSC_sweepSynchronously and
JSC_scribbleFreeCells, which together does the job of zombifying dead objects
immediately after a GC.
- heap/Heap.cpp:
(JSC::Heap::sweepSynchronously):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::finalize):
(JSC::Heap::didFinishCollection):
(JSC::Zombify::visit): Deleted.
(JSC::Zombify::operator()): Deleted.
(JSC::Heap::zombifyDeadObjects): Deleted.
- heap/Heap.h:
(JSC::Heap::isZombified): Deleted.
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 11:09 AM Changeset in webkit [212309] by
-
- 2 edits in trunk/Tools
Unreviewed build-fix after r212297.
- Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess.stop): Should return value of the ServerProcess's stop.
- 10:52 AM Changeset in webkit [212308] by
-
- 2 edits23 deletes in trunk/Source/ThirdParty/libwebrtc
Remove android-specific files from ThirdParty/libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=168272
Reviewed by Brady Eidson.
- Source/third_party/boringssl/src/third_party/android-cmake: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/AndroidNdkGdb.cmake: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/AndroidNdkModules.cmake: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/LICENSE: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/METADATA: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/README.md: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/android.toolchain.cmake: Removed.
- Source/third_party/boringssl/src/third_party/android-cmake/ndk_links.md: Removed.
- Source/third_party/boringssl/src/util/run_android_tests.go: Removed.
- Source/third_party/libyuv/util/android: Removed.
- Source/third_party/libyuv/util/android/test_runner.py: Removed.
- Source/webrtc/androidjunit: Removed.
- Source/webrtc/androidjunit/OWNERS: Removed.
- Source/webrtc/androidjunit/src: Removed.
- Source/webrtc/androidjunit/src/org: Removed.
- Source/webrtc/androidjunit/src/org/webrtc: Removed.
- Source/webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java: Removed.
- Source/webrtc/api/android: Removed.
- Source/webrtc/api/android/PRESUBMIT.py: Removed.
- Source/webrtc/api/android/README: Removed.
- Source/webrtc/api/android/java: Removed.
- Source/webrtc/api/android/java/src: Removed.
- Source/webrtc/api/android/java/src/org: Removed.
- Source/webrtc/api/android/java/src/org/webrtc: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/AudioSource.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/AudioTrack.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CallSessionFileRotatingLogSink.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera1Capturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera1Enumerator.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera1Session.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera2Capturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Camera2Session.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CameraCapturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CameraEnumerator.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CameraSession.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/CameraVideoCapturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/DataChannel.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/EglBase.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/EglBase10.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/EglBase14.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/EglRenderer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/FileVideoCapturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/GlShader.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/GlTextureFrameBuffer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/GlUtil.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/IceCandidate.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaConstraints.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaSource.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaStream.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/MediaStreamTrack.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/Metrics.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/NetworkMonitor.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/NetworkMonitorAutoDetect.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/OWNERS: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/PeerConnection.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/RendererCommon.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/RtpParameters.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/RtpReceiver.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/RtpSender.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/ScreenCapturerAndroid.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/SdpObserver.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/SessionDescription.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/StatsObserver.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/StatsReport.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/SurfaceTextureHelper.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoCapturer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoRenderer.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoRendererGui.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoSource.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/VideoTrack.java: Removed.
- Source/webrtc/api/android/java/src/org/webrtc/YuvConverter.java: Removed.
- Source/webrtc/api/android/jni: Removed.
- Source/webrtc/api/android/jni/OWNERS: Removed.
- Source/webrtc/api/android/jni/androidmediacodeccommon.h: Removed.
- Source/webrtc/api/android/jni/androidmediadecoder_jni.cc: Removed.
- Source/webrtc/api/android/jni/androidmediadecoder_jni.h: Removed.
- Source/webrtc/api/android/jni/androidmediaencoder_jni.cc: Removed.
- Source/webrtc/api/android/jni/androidmediaencoder_jni.h: Removed.
- Source/webrtc/api/android/jni/androidmetrics_jni.cc: Removed.
- Source/webrtc/api/android/jni/androidnetworkmonitor_jni.cc: Removed.
- Source/webrtc/api/android/jni/androidnetworkmonitor_jni.h: Removed.
- Source/webrtc/api/android/jni/androidvideotracksource_jni.cc: Removed.
- Source/webrtc/api/android/jni/classreferenceholder.cc: Removed.
- Source/webrtc/api/android/jni/classreferenceholder.h: Removed.
- Source/webrtc/api/android/jni/jni_helpers.cc: Removed.
- Source/webrtc/api/android/jni/jni_helpers.h: Removed.
- Source/webrtc/api/android/jni/jni_onload.cc: Removed.
- Source/webrtc/api/android/jni/native_handle_impl.cc: Removed.
- Source/webrtc/api/android/jni/native_handle_impl.h: Removed.
- Source/webrtc/api/android/jni/peerconnection_jni.cc: Removed.
- Source/webrtc/api/android/jni/surfacetexturehelper_jni.cc: Removed.
- Source/webrtc/api/android/jni/surfacetexturehelper_jni.h: Removed.
- Source/webrtc/api/androidtests: Removed.
- Source/webrtc/api/androidtests/AndroidManifest.xml: Removed.
- Source/webrtc/api/androidtests/OWNERS: Removed.
- Source/webrtc/api/androidtests/ant.properties: Removed.
- Source/webrtc/api/androidtests/build.xml: Removed.
- Source/webrtc/api/androidtests/project.properties: Removed.
- Source/webrtc/api/androidtests/res: Removed.
- Source/webrtc/api/androidtests/res/drawable-hdpi: Removed.
- Source/webrtc/api/androidtests/res/drawable-hdpi/ic_launcher.png: Removed.
- Source/webrtc/api/androidtests/res/drawable-ldpi: Removed.
- Source/webrtc/api/androidtests/res/drawable-ldpi/ic_launcher.png: Removed.
- Source/webrtc/api/androidtests/res/drawable-mdpi: Removed.
- Source/webrtc/api/androidtests/res/drawable-mdpi/ic_launcher.png: Removed.
- Source/webrtc/api/androidtests/res/drawable-xhdpi: Removed.
- Source/webrtc/api/androidtests/res/drawable-xhdpi/ic_launcher.png: Removed.
- Source/webrtc/api/androidtests/res/values: Removed.
- Source/webrtc/api/androidtests/res/values/strings.xml: Removed.
- Source/webrtc/api/androidtests/src: Removed.
- Source/webrtc/api/androidtests/src/org: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/Camera1CapturerUsingByteBufferTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/Camera1CapturerUsingTextureTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/Camera2CapturerTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/EglRendererTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/GlRectDrawerTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/NetworkMonitorTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/RendererCommonTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java: Removed.
- Source/webrtc/api/androidtests/src/org/webrtc/WebRtcJniBootTest.java: Removed.
- Source/webrtc/api/androidvideotracksource.cc: Removed.
- Source/webrtc/api/androidvideotracksource.h: Removed.
- Source/webrtc/api/test/androidtestinitializer.cc: Removed.
- Source/webrtc/api/test/androidtestinitializer.h: Removed.
- Source/webrtc/base/ifaddrs-android.cc: Removed.
- Source/webrtc/base/ifaddrs-android.h: Removed.
- Source/webrtc/build/android: Removed.
- Source/webrtc/build/android/AndroidManifest.xml: Removed.
- Source/webrtc/build/android/suppressions.xml: Removed.
- Source/webrtc/build/android/test_runner.py: Removed.
- Source/webrtc/examples/androidapp: Removed.
- Source/webrtc/examples/androidapp/AndroidManifest.xml: Removed.
- Source/webrtc/examples/androidapp/OWNERS: Removed.
- Source/webrtc/examples/androidapp/README: Removed.
- Source/webrtc/examples/androidapp/ant.properties: Removed.
- Source/webrtc/examples/androidapp/build.xml: Removed.
- Source/webrtc/examples/androidapp/project.properties: Removed.
- Source/webrtc/examples/androidapp/res: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi/disconnect.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_action_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_action_return_from_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_launcher.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_loopback_call.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi/disconnect.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_action_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_action_return_from_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_launcher.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_loopback_call.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi/disconnect.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_action_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_action_return_from_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_launcher.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_loopback_call.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi/disconnect.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_action_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_action_return_from_full_screen.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_launcher.png: Removed.
- Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_loopback_call.png: Removed.
- Source/webrtc/examples/androidapp/res/layout: Removed.
- Source/webrtc/examples/androidapp/res/layout/activity_call.xml: Removed.
- Source/webrtc/examples/androidapp/res/layout/activity_connect.xml: Removed.
- Source/webrtc/examples/androidapp/res/layout/fragment_call.xml: Removed.
- Source/webrtc/examples/androidapp/res/layout/fragment_hud.xml: Removed.
- Source/webrtc/examples/androidapp/res/menu: Removed.
- Source/webrtc/examples/androidapp/res/menu/connect_menu.xml: Removed.
- Source/webrtc/examples/androidapp/res/values: Removed.
- Source/webrtc/examples/androidapp/res/values-v17: Removed.
- Source/webrtc/examples/androidapp/res/values-v17/styles.xml: Removed.
- Source/webrtc/examples/androidapp/res/values-v21: Removed.
- Source/webrtc/examples/androidapp/res/values-v21/styles.xml: Removed.
- Source/webrtc/examples/androidapp/res/values/arrays.xml: Removed.
- Source/webrtc/examples/androidapp/res/values/strings.xml: Removed.
- Source/webrtc/examples/androidapp/res/xml: Removed.
- Source/webrtc/examples/androidapp/res/xml/preferences.xml: Removed.
- Source/webrtc/examples/androidapp/src: Removed.
- Source/webrtc/examples/androidapp/src/org: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/DirectRTCClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/HudFragment.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/PercentFrameLayout.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsFragment.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/TCPChannelClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/UnhandledExceptionHandler.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java: Removed.
- Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java: Removed.
- Source/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py: Removed.
- Source/webrtc/examples/androidapp/third_party: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/BUILD.gn: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/LICENSE: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/LICENSE.md: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/NOTICE: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/lib: Removed.
- Source/webrtc/examples/androidapp/third_party/autobanh/lib/autobanh.jar: Removed.
- Source/webrtc/examples/androidjunit: Removed.
- Source/webrtc/examples/androidjunit/README: Removed.
- Source/webrtc/examples/androidjunit/src: Removed.
- Source/webrtc/examples/androidjunit/src/org: Removed.
- Source/webrtc/examples/androidjunit/src/org/appspot: Removed.
- Source/webrtc/examples/androidjunit/src/org/appspot/apprtc: Removed.
- Source/webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java: Removed.
- Source/webrtc/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java: Removed.
- Source/webrtc/examples/androidtests: Removed.
- Source/webrtc/examples/androidtests/AndroidManifest.xml: Removed.
- Source/webrtc/examples/androidtests/README: Removed.
- Source/webrtc/examples/androidtests/ant.properties: Removed.
- Source/webrtc/examples/androidtests/build.xml: Removed.
- Source/webrtc/examples/androidtests/project.properties: Removed.
- Source/webrtc/examples/androidtests/src: Removed.
- Source/webrtc/examples/androidtests/src/org: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/VideoFileRendererTest.java: Removed.
- Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/capturetestvideo.y4m: Removed.
- Source/webrtc/modules/audio_device/android: Removed.
- Source/webrtc/modules/audio_device/android/audio_common.h: Removed.
- Source/webrtc/modules/audio_device/android/audio_device_template.h: Removed.
- Source/webrtc/modules/audio_device/android/audio_device_unittest.cc: Removed.
- Source/webrtc/modules/audio_device/android/audio_manager.cc: Removed.
- Source/webrtc/modules/audio_device/android/audio_manager.h: Removed.
- Source/webrtc/modules/audio_device/android/audio_manager_unittest.cc: Removed.
- Source/webrtc/modules/audio_device/android/audio_record_jni.cc: Removed.
- Source/webrtc/modules/audio_device/android/audio_record_jni.h: Removed.
- Source/webrtc/modules/audio_device/android/audio_track_jni.cc: Removed.
- Source/webrtc/modules/audio_device/android/audio_track_jni.h: Removed.
- Source/webrtc/modules/audio_device/android/build_info.cc: Removed.
- Source/webrtc/modules/audio_device/android/build_info.h: Removed.
- Source/webrtc/modules/audio_device/android/ensure_initialized.cc: Removed.
- Source/webrtc/modules/audio_device/android/ensure_initialized.h: Removed.
- Source/webrtc/modules/audio_device/android/java: Removed.
- Source/webrtc/modules/audio_device/android/java/src: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/BuildInfo.java: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java: Removed.
- Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java: Removed.
- Source/webrtc/modules/audio_device/android/opensles_common.cc: Removed.
- Source/webrtc/modules/audio_device/android/opensles_common.h: Removed.
- Source/webrtc/modules/audio_device/android/opensles_player.cc: Removed.
- Source/webrtc/modules/audio_device/android/opensles_player.h: Removed.
- Source/webrtc/modules/audio_device/android/opensles_recorder.cc: Removed.
- Source/webrtc/modules/audio_device/android/opensles_recorder.h: Removed.
- Source/webrtc/modules/audio_processing/test/android: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/AndroidManifest.xml: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/default.properties: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/jni: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/jni/main.c: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/res: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/res/values: Removed.
- Source/webrtc/modules/audio_processing/test/android/apmtest/res/values/strings.xml: Removed.
- Source/webrtc/modules/utility/include/helpers_android.h: Removed.
- Source/webrtc/modules/utility/include/jvm_android.h: Removed.
- Source/webrtc/modules/utility/source/helpers_android.cc: Removed.
- Source/webrtc/modules/utility/source/jvm_android.cc: Removed.
- Source/webrtc/system_wrappers/source/cpu_features_android.c: Removed.
- libwebrtc.xcodeproj/project.pbxproj:
- 10:51 AM Changeset in webkit [212307] by
-
- 3 edits in trunk/Source/WebCore
Remove unused WebThreadContextIsCurrent method from WebCoreThread.h
https://bugs.webkit.org/show_bug.cgi?id=168254
Reviewed by Dan Bernstein.
- platform/ios/wak/WebCoreThread.h: Removed unused WebThreadContextIsCurrent.
- platform/ios/wak/WebCoreThread.mm:
(WebThreadContextIsCurrent): Deleted.
- 10:07 AM Changeset in webkit [212306] by
-
- 2 edits in trunk/Tools
[CMake] build-webkit should allow building with the default cmake configuration
https://bugs.webkit.org/show_bug.cgi?id=168323
Reviewed by Michael Catanzaro.
Add a --default-cmake-features switch that makes the script pass
no value for any of the features defined by build-webkit, that
way the default values from the port cmake config will be used.
- Scripts/build-webkit:
(cMakeArgsFromFeatures):
- 9:51 AM Changeset in webkit [212305] by
-
- 2 edits in trunk/Tools
Unreviewed build-fix after r212297.
- Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess.stop): Handle case where there is no process to kill.
- 9:29 AM Changeset in webkit [212304] by
-
- 4 edits in trunk/LayoutTests
[mac-wk1] LayoutTest media/modern-media-controls/forward-button/forward-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168265
Unreviewed test gardening.
- media/modern-media-controls/forward-button/forward-button-expected.txt:
- media/modern-media-controls/forward-button/forward-button.html:
- platform/mac-wk1/TestExpectations:
- 9:27 AM Changeset in webkit [212303] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] [l10n] Updated Brazilian Portuguese translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=168303
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2017-02-14
Rubber-stamped by Michael Catanzaro.
- pt_BR.po:
- 9:12 AM Changeset in webkit [212302] by
-
- 4 edits in trunk/Source
WebCore shouldn't export SystemMemory.h
https://bugs.webkit.org/show_bug.cgi?id=168285
Reviewed by Alex Christensen.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- MigrateHeaders.make: And WebKit shouldn't re-export it.
- 9:07 AM Changeset in webkit [212301] by
-
- 3 edits3 adds3 deletes in trunk
worker.postMessage should throw a TypeError if a SharedArrayBuffer is in the transfer list
https://bugs.webkit.org/show_bug.cgi?id=168277
Reviewed by Mark Lam.
Source/WebCore:
Test: workers/sab/postMessage-transfer-type-error.html
This is a simple spec compliance change. The title says it all.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
LayoutTests:
Add a test of the new behavior, and remove tests for the old behavior.
Most of the SharedArrayBuffer tests use the new style, where the buffer is not in the
transfer list, and the tests being removed are clones of the no-transfer tests. So, we
aren't losing any coverage.
- workers/sab/null-worker.js: Added.
- workers/sab/postMessage-transfer-type-error-expected.txt: Added.
- workers/sab/postMessage-transfer-type-error.html: Added.
- workers/sab/sab-creator-transfer.js: Removed. (Sibling: sab-creator-no-transfer.js)
- workers/sab/sent-from-worker-transfer.html: Removed. (Sibling: sent-from-worker-no-transfer.html)
- workers/sab/simple.html: Removed. (Sibling: no-transfer.html)
- 9:01 AM Changeset in webkit [212300] by
-
- 4 edits in trunk/LayoutTests
[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button-on.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167347
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-14
- media/modern-media-controls/airplay-button/airplay-button-on-expected.txt:
- media/modern-media-controls/airplay-button/airplay-button-on.html:
- platform/mac-wk1/TestExpectations:
- 8:48 AM Changeset in webkit [212299] by
-
- 3 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167589
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-14
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
- 8:46 AM Changeset in webkit [212298] by
-
- 2 edits in trunk/Tools
[CMake] build-webkit should print the cmake command executed
https://bugs.webkit.org/show_bug.cgi?id=168318
Reviewed by Michael Catanzaro.
Run the cmake commands to configure or start the build through
a wrapper that prints the command before executing it.
- Scripts/webkitdirs.pm:
(systemVerbose):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cleanCMakeGeneratedProject):
- 8:33 AM Changeset in webkit [212297] by
-
- 3 edits in trunk/Tools
run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
https://bugs.webkit.org/show_bug.cgi?id=168150
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess.stop): Close app before calling ServerProcess's stop.
(SimulatorProcess._kill): Move closing of app into stop().
- Scripts/webkitpy/xcode/simulator.py:
(Device.launch_app):
(Device.terminate_app): Deleted.
- 8:31 AM Changeset in webkit [212296] by
-
- 3 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168125
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-14
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html:
- 8:29 AM Changeset in webkit [212295] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 8:28 AM Changeset in webkit [212294] by
-
- 2 edits in trunk/LayoutTests
Rebase URL test after r212279.
https://bugs.webkit.org/show_bug.cgi?id=168260
- fast/url/ipv4-expected.txt:
http://0X12C0a80001/ is an invalid IPv4 address, so parsing should fail.
This matches Chrome and the URL specification.
- 8:23 AM Changeset in webkit [212293] by
-
- 3 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167372
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-14
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
- 7:45 AM Changeset in webkit [212292] by
-
- 4 edits in trunk/LayoutTests
[mac-wk1] LayoutTest media/modern-media-controls/layout-node/addChild.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168074
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-14
- media/modern-media-controls/layout-node/addChild-expected.txt:
- media/modern-media-controls/layout-node/addChild.html:
- platform/mac-wk1/TestExpectations:
- 5:08 AM Changeset in webkit [212291] by
-
- 2 edits in trunk/Source/WebKit2
Allow to use stored credentials also for downloads started by DownloadManager::startDownload
https://bugs.webkit.org/show_bug.cgi?id=167584
Reviewed by Michael Catanzaro.
Cliking on a link that triggers a download works on an already HTTP authenticated site works, but right clicking
and downloading from the context menu shows the HTTP auth dialog again. This is because PendingDownload uses
DoNotAllowStoredCredentials unconditionally. We want to allow using cached credentials at least for
non-ephemeral sessions.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
- 5:03 AM Changeset in webkit [212290] by
-
- 2 edits in trunk/Tools
REGRESSION(r212192): [GTK] Broke downloads API tests
https://bugs.webkit.org/show_bug.cgi?id=168193
Unreviewed. Update test expectations after r212192.
The suggested filename now includes a file extensions if the MIME type is known.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(testDownloadRemoteFile):
(testDownloadMIMEType):
- 4:56 AM Changeset in webkit [212289] by
-
- 3 edits in trunk/Source/WebCore
HTMLMediaElement: WebKitMediaKeys member name should be prefixed
https://bugs.webkit.org/show_bug.cgi?id=168297
Reviewed by Xabier Rodriguez-Calvar.
Rename the LEGACY_ENCRYPTED_MEDIA m_mediaKeys variable to m_webkitMediaKeys
so that it contains the legacy prefix, just like the API. This will make
room for the MediaKeys member variable that will be implemented under
the ENCRYPTED_MEDIA guards.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCachedKeyForKeyId):
(WebCore::HTMLMediaElement::webkitSetMediaKeys):
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::webkitKeys):
- 4:03 AM Changeset in webkit [212288] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK+ gardening. Add platform specific resuls for http/tests/security/module-no-mime-type.html.
libsoup sniffer correctly guesses the perl MIME type as text/plain which is still an invalid JavaScript MIME type.
- platform/gtk/http/tests/security/module-no-mime-type-expected.txt: Added.
- 3:58 AM Changeset in webkit [212287] by
-
- 5 edits in trunk/Source
[GTK] Make DragImageRef a RefPtr instead of a plain pointer
https://bugs.webkit.org/show_bug.cgi?id=168296
Reviewed by Sergio Villar Senin.
Source/WebCore:
Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port to avoid memory leaks.
- platform/DragImage.h:
- platform/gtk/DragImageGtk.cpp:
(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImageFilename):
Source/WebKit2:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- 3:54 AM Changeset in webkit [212286] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed
https://bugs.webkit.org/show_bug.cgi?id=168299
Reviewed by Sergio Villar Senin.
Sniffing is not allowed but we can try to guess the MIME using the response path, or at least fallback to
default MIME type instead of leaving an empty string. This matches what mac port does.
Fixes: http/tests/inspector/network/fetch-response-body.html
http/tests/inspector/network/xhr-response-body.html
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::didSendRequest):
- 3:30 AM Changeset in webkit [212285] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category
https://bugs.webkit.org/show_bug.cgi?id=168015
Patch by Vanessa Chipirrás Navalón <vchipirras@igalia.com> on 2017-02-14
Reviewed by Xabier Rodriguez-Calvar.
The elements AppendPipeline, PlaybackPipeline, MediaSourceClientGstreamerMSE do not have
a defined Gstreamer log category, then the webkitmse category has been added to them.
WebKitMediaSourceGstreamer has its own category but was not declared at the beginning of
the .cpp file.
- platform/graphics/gstreamer/mse/AppendPipeline.cpp: Added webkitmse category.
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
Added webkitmse category and gst header.
- platform/graphics/gstreamer/mse/PlaybackPipeline.cpp: Added webkitmse category.
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
Added webkitmediasrc category.
- 2:50 AM Changeset in webkit [212284] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r212237.
https://bugs.webkit.org/show_bug.cgi?id=168298
This was a wrong fix (Requested by rniwa on #webkit).
Reverted changeset:
"Nwtr unexpectedly passes mismatch ref test if the hashes
doesn't match but no diff"
https://bugs.webkit.org/show_bug.cgi?id=168221
http://trac.webkit.org/changeset/212237
- 2:43 AM Changeset in webkit [212283] by
-
- 15 edits in trunk/Source
CookieManager only works with the default session
https://bugs.webkit.org/show_bug.cgi?id=168229
Reviewed by Alex Christensen.
Source/WebCore:
Update cookie observer API to use a std::function instead of a function pointer and make it work with multiple
sessions in the backends that support it.
- platform/network/CookieStorage.h:
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::cookieChangeCallbackMap):
(WebCore::notifyCookiesChanged):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
- platform/network/mac/CookieStorageMac.mm:
(-[WebCookieStorageObjCAdapter startListeningForCookieChangeNotificationsWithCallback:]):
(-[WebCookieStorageObjCAdapter stopListeningForCookieChangeNotifications]):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
- platform/network/soup/CookieStorageSoup.cpp:
(WebCore::cookieChangeCallbackMap):
(WebCore::soupCookiesChanged):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
Source/WebKit2:
Make CookieManager session aware by adding a SessionID parameter to all its functions, and update all the callers
to pass the default session ID, preserving the current
behavior. WebCookieManagerProxy::startObservingCookieChanges() now also receives an optional callback to be
called on every change.
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerDeleteCookiesForHostname):
(WKCookieManagerDeleteAllCookies):
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerStartObservingCookieChanges):
(WKCookieManagerStopObservingCookieChanges):
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_delete_cookies_for_domain):
(webkit_cookie_manager_delete_all_cookies):
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::addCookie):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebCookieManagerProxy.messages.in:
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::addCookie):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Cookies/WebCookieManager.messages.in:
- 2:09 AM Changeset in webkit [212282] by
-
- 3 edits in trunk/LayoutTests
Fix typo in performance-observer-callback-mutate.html
https://bugs.webkit.org/show_bug.cgi?id=168294
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-14
Reviewed by Ryosuke Niwa.
- performance-api/performance-observer-callback-mutate-expected.txt:
- performance-api/performance-observer-callback-mutate.html:
- 1:43 AM Changeset in webkit [212281] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fix documentation typo
- UIProcess/API/gtk/WebKitEditingCommands.h:
- 12:11 AM Changeset in webkit [212280] by
-
- 65 edits3 copies3 adds3 deletes in trunk
REGRESSION: Update volume and scrubbing slider to match HI designs
https://bugs.webkit.org/show_bug.cgi?id=168170
<rdar://problem/28095266>
Reviewed by Dean Jackson.
Source/WebCore:
We bring the designs of the control's background materials, scrubber and
volume slider up to spec.
The first important set of changes is that, on macOS, the materials and colors
were incorrect. Buttons and time labels now set a mix-blend-mode to correctly
appear vibrant against the media, and the controls bar, volume container
and tracks menu now use a new BackgroundTint node to correctly apply both
a backdrop-filter and blended tint above it.
The second important set of changes is the rendering of the sliders. Up to now
we would simply style the <input type="range"> track and thumb, applying solid
fills and strokes. We now draw sliders in two ways depending on the platform.
On macOS, we draw the whole slider with a <canvas> element with "mix-blend-mode"
set to "plus-lighter". On iOS, we draw the track as a <div> with "mix-blend-mode"
set to "plus-darker" and draw the fill (up to the thumb) in the <canvas> with
no blend mode to obtain a pure white color, finally the thumb is rendered by the
<input> element. We couldn't draw the pure white color with the track in the
same <canvas> due to the "plus-darker" blend mode.
Test: media/modern-media-controls/background-tint/background-tint.html
- Modules/modern-media-controls/controls/airplay-button.css:
(button.airplay.on):
- Modules/modern-media-controls/controls/background-tint.css: Added.
(.background-tint):
(.background-tint,):
(.background-tint > .blur):
(.background-tint > .tint):
- Modules/modern-media-controls/controls/background-tint.js: Added.
(BackgroundTint):
- Modules/modern-media-controls/controls/ios-inline-media-controls.css:
(.media-controls.ios.inline .scrubber.slider):
(.media-controls.ios.inline .scrubber.slider > div):
(.media-controls.ios.inline .scrubber.slider > input::-webkit-slider-thumb):
(.media-controls.ios.inline .scrubber.slider > .fill): Deleted.
- Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css:
(.media-controls.mac.inline.compact .volume-slider-container):
(.media-controls.mac.inline.compact .volume.slider):
(.media-controls.mac.inline.compact .scrubber.slider > input::-webkit-slider-thumb): Deleted.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
(.media-controls.mac.fullscreen > .controls-bar):
(.media-controls.mac.fullscreen > .controls-bar > .background-tint > div):
(.media-controls.mac.fullscreen .volume.slider):
(.media-controls.mac.fullscreen button.volume-up):
(.media-controls.mac.fullscreen button.rewind):
(.media-controls.mac.fullscreen button.forward):
(.media-controls.mac.fullscreen .buttons-container.right button):
(.media-controls.mac.fullscreen .scrubber):
(.media-controls.mac.fullscreen > .controls-bar button): Deleted.
(.media-controls.mac.fullscreen button.airplay): Deleted.
(.media-controls.mac.fullscreen button.aspect-ratio): Deleted.
(.media-controls.mac.fullscreen button.pip): Deleted.
(.media-controls.mac.fullscreen button.tracks): Deleted.
(.media-controls.mac.fullscreen button.fullscreen): Deleted.
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
- Modules/modern-media-controls/controls/macos-inline-media-controls.css:
(.media-controls.mac.inline .scrubber.slider):
(.media-controls.mac.inline .volume-slider-container):
(.media-controls.mac.inline .volume-slider-container > .background-tint):
(.media-controls.mac.inline .volume-slider-container > .background-tint > div):
(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline button): Deleted.
(.media-controls.mac.inline button:active): Deleted.
(.media-controls.mac.inline > .controls-bar button): Deleted.
(.media-controls.mac.inline > .controls-bar,): Deleted.
(.media-controls.mac.inline .volume-slider-container:before): Deleted.
- Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype.layout):
- Modules/modern-media-controls/controls/macos-media-controls.css: Added.
(.media-controls.mac button:active):
(.media-controls.mac > .controls-bar button):
(.media-controls.mac > .controls-bar .time-label):
(.media-controls.mac > .controls-bar .slider > canvas):
(.media-controls.mac > .controls-bar .slider > input::-webkit-slider-thumb):
- Modules/modern-media-controls/controls/scrubber.css: Removed.
- Modules/modern-media-controls/controls/scrubber.js:
(Scrubber):
(Scrubber.prototype.get buffered):
(Scrubber.prototype.set buffered):
(Scrubber.prototype.draw):
(Scrubber.prototype._drawMacOS):
(Scrubber.prototype._drawiOS):
- Modules/modern-media-controls/controls/slider.css:
(.slider):
(.slider > canvas,):
(.slider > canvas):
(.slider > input):
(.slider > input,): Deleted.
(.slider > .fill): Deleted.
(.slider > input::-webkit-slider-thumb): Deleted.
- Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.set value):
(Slider.prototype.set width):
(Slider.prototype.commitProperty):
(Slider.prototype.layout):
(Slider.prototype.draw):
(Slider.prototype._handleInputEvent):
(Slider.prototype._handleChangeEvent):
(addRoundedRect):
(Slider.prototype._updateFill): Deleted.
- Modules/modern-media-controls/controls/start-button.css:
(button.start):
- Modules/modern-media-controls/controls/time-control.js:
- Modules/modern-media-controls/controls/time-label.css:
(.time-label):
- Modules/modern-media-controls/controls/tracks-panel.css:
(.tracks-panel):
(.tracks-panel > .background-tint > div):
(.tracks-panel > section):
(.tracks-panel > section:first-of-type):
(.tracks-panel > section > h3):
(.tracks-panel > section > ul):
(.tracks-panel > section > ul > li):
(.tracks-panel > section > ul > li:focus):
(.tracks-panel > section > ul > li.selected:before):
(.tracks-panel > section > ul > li.animated):
(.tracks-panel-section): Deleted.
(.tracks-panel-section:first-of-type): Deleted.
(.tracks-panel-section > h3): Deleted.
(.tracks-panel-section > ul): Deleted.
(.tracks-panel-section > ul > li): Deleted.
(.tracks-panel-section > ul > li:focus): Deleted.
(.tracks-panel-section > ul > li.selected:before): Deleted.
(.tracks-panel-section > ul > li.animated): Deleted.
- Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype._childrenFromDataSource):
(TracksPanel.prototype._childrenFromDataSource.): Deleted.
- Modules/modern-media-controls/controls/volume-slider.js:
(VolumeSlider):
(VolumeSlider.prototype.handleEvent):
(VolumeSlider.prototype.draw):
- Modules/modern-media-controls/js-files:
- Modules/modern-media-controls/media/scrubbing-support.js:
(ScrubbingSupport.prototype.get mediaEvents):
(ScrubbingSupport.prototype.syncControl):
(ScrubbingSupport):
LayoutTests:
Rebaselining a host of existing tests to account for new DOM structure, metrics,
colors, blend modes, etc. We're also adding a new test for the BackgroundTint
class and removing one for the slider fill which is no longer appopriate since
we're drawing the slider's fill with a <canvas> element rather than a DOM element.
- media/modern-media-controls/background-tint/background-tint-expected.txt: Added.
- media/modern-media-controls/background-tint/background-tint.html: Added.
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles-expected.txt:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-resize-with-hidden-controls-bar.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles.html:
- media/modern-media-controls/resources/media-controls-loader.js:
- media/modern-media-controls/scrubber/scrubber.html:
- media/modern-media-controls/slider/slider-constructor-expected.txt:
- media/modern-media-controls/slider/slider-constructor.html:
- media/modern-media-controls/slider/slider-fill-expected.txt: Removed.
- media/modern-media-controls/slider/slider-fill.html: Removed.
- media/modern-media-controls/slider/slider-styles-expected.txt:
- media/modern-media-controls/slider/slider-styles.html:
- media/modern-media-controls/time-label/time-label-expected.txt:
- media/modern-media-controls/time-label/time-label.html:
- media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
- media/modern-media-controls/tracks-panel/tracks-panel-population.html:
- media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html:
- media/modern-media-controls/volume-slider/volume-slider-value-expected.txt:
- media/modern-media-controls/volume-slider/volume-slider-value.html:
- media/modern-media-controls/volume-slider/volume-slider.html:
- media/modern-media-controls/volume-support/volume-support-click-expected.txt:
- media/modern-media-controls/volume-support/volume-support-click.html:
- media/modern-media-controls/volume-support/volume-support-drag-expected.txt:
- media/modern-media-controls/volume-support/volume-support-drag.html:
Feb 13, 2017:
- 11:43 PM Changeset in webkit [212279] by
-
- 13 edits in trunk
URLs with an invalid IPv4 address should be invalid
https://bugs.webkit.org/show_bug.cgi?id=168260
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
- web-platform-tests/url/a-element-expected.txt:
- web-platform-tests/url/a-element-xhtml-expected.txt:
- web-platform-tests/url/url-constructor-expected.txt:
Source/WebCore:
All URL hosts are fed through the IPv4 parser. https://webkit.org/ doesn't
look enough like an IPv4 address to be considered an invalid IPv4 address, so
we continue to the String host processing. http://127.0.0.257 does, though, and
according to https://url.spec.whatwg.org/#concept-ipv4-parser parsing that URL
should fail.
Covered by newly passing web platform tests.
- platform/URLParser.cpp:
(WebCore::URLParser::parseIPv4Host):
(WebCore::URLParser::parseHostAndPort):
- platform/URLParser.h:
Source/WTF:
- wtf/Expected.h:
(WTF::Expected::value):
Added missing WTFMove for rvalue Expected::value().
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
Update tests to reflect new correct behavior.
LayoutTests:
- fetch/fetch-url-serialization-expected.txt:
- 11:16 PM Changeset in webkit [212278] by
-
- 2 edits in trunk/Source/WebKit/mac
WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
https://bugs.webkit.org/show_bug.cgi?id=168282
Reviewed by Dan Bernstein.
- MigrateHeaders.make:
- 11:00 PM Changeset in webkit [212277] by
-
- 2 edits in trunk/Source/WebCore
Reverted r212275. It still breaks some Apple-internal builds.
- platform/spi/mac/TUCallSPI.h:
- 9:57 PM Changeset in webkit [212276] by
-
- 16 edits in trunk/Source/WebCore
Address ESLint warnings in modern-media-controls
https://bugs.webkit.org/show_bug.cgi?id=168224
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-13
Reviewed by Alexey Proskuryakov.
- Modules/modern-media-controls/controls/controls-bar.js:
- Modules/modern-media-controls/controls/fullscreen-button.js:
- Modules/modern-media-controls/controls/layout-node.js:
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
- Modules/modern-media-controls/controls/media-controls.js:
- Modules/modern-media-controls/controls/scheduler.js:
- Modules/modern-media-controls/controls/seek-button.js:
- Modules/modern-media-controls/controls/tracks-panel.js:
- Modules/modern-media-controls/controls/volume-slider.js:
- Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js:
- Modules/modern-media-controls/gesture-recognizers/pinch.js:
- Modules/modern-media-controls/media/fullscreen-support.js:
- Modules/modern-media-controls/media/media-controller.js:
- Modules/modern-media-controls/media/placard-support.js:
- Modules/modern-media-controls/media/status-support.js:
Address pedantic warnings.
- 9:40 PM Changeset in webkit [212275] by
-
- 2 edits in trunk/Source/WebCore
Restored changes from r212210 in a way that does not break the build.
- platform/spi/mac/TUCallSPI.h:
- 7:27 PM Changeset in webkit [212274] by
-
- 2 edits in trunk/Source/WebCore
FontCascade::widthForSimpleText should skip applyTransforms() when kerning and ligatures are off.
https://bugs.webkit.org/show_bug.cgi?id=168251
<rdar://problem/30498102>
Reviewed by Antti Koivisto.
Covered by existing (perf)tests.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthForSimpleText):
- 6:29 PM Changeset in webkit [212273] by
-
- 7 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: provide a way to show current value of CSS variables in style rules
https://bugs.webkit.org/show_bug.cgi?id=168172
Patch by Devin Rousso <Devin Rousso> on 2017-02-13
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Images/CSSVariable.svg: Added.
- UserInterface/Models/TextMarker.js:
(WebInspector.TextMarker.Type):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor._createInlineSwatches.update):
- UserInterface/Views/CodeMirrorTextMarkers.js:
(createCodeMirrorTextMarkers):
(createCodeMirrorVariableTextMarkers):
- UserInterface/Views/InlineSwatch.css:
(.inline-swatch.variable):
(.inline-swatch:matches(.bezier, .spring, .variable)):
(.inline-swatch:matches(.bezier, .spring, .variable):hover):
(.inline-swatch:matches(.bezier, .spring, .variable):active):
(.inline-swatch-variable-popover):
(.inline-swatch-variable-popover .CodeMirror):
(.inline-swatch-variable-popover .CodeMirror pre):
(.inline-swatch:matches(.bezier, .spring):hover): Deleted.
(.inline-swatch:matches(.bezier, .spring):active): Deleted.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch):
(WebInspector.InlineSwatch.prototype._fallbackValue):
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
(WebInspector.InlineSwatch.prototype._valueEditorValueDidChange):
(WebInspector.InlineSwatch.Type):
- 6:28 PM Changeset in webkit [212272] by
-
- 13 edits in trunk/Source
Web Inspector: expose system user interface layout direction through InspectorFrontendHost
https://bugs.webkit.org/show_bug.cgi?id=168209
<rdar://problem/11573736>
Reviewed by Joseph Pecoraro.
Forward the UserInterfaceLayoutDirection of the inspector page. If the WebKit client has
properly set the UI directionality from system settings in PageClient, this will get inherited
automatically by the Inspector's WebPage instance.
Source/WebCore:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::userInterfaceLayoutDirection):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
Expose the directionality to the frontend as "ltr" or "rtl" strings.
Source/WebKit2:
- WebProcess/WebPage/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::userInterfaceLayoutDirection):
- WebProcess/WebPage/RemoteWebInspectorUI.h:
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::userInterfaceLayoutDirection):
- WebProcess/WebPage/WebInspectorUI.h:
- 6:20 PM Changeset in webkit [212271] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Do not measure runs with trailing whitespace when kerning and ligatures are off.
https://bugs.webkit.org/show_bug.cgi?id=168247
<rdar://problem/30497288>
Reviewed by Antti Koivisto.
The width of the run is supposed to be the same with or without the trailing whitespace.
Covered by performance test.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- 6:11 PM Changeset in webkit [212270] by
-
- 3 edits2 adds in trunk
Source/WebCore:
Added the other missing BSTR roles tag names.
https://bugs.webkit.org/show_bug.cgi?id=165545
Patch by Karim H <karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.
Test: accessibility/win/bstr-elements-role.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::shouldReturnTagNameAsRoleForMSAA):
LayoutTests:
Added the BSTR roles tag test for Windows.
https://bugs.webkit.org/show_bug.cgi?id=165545
Patch by Karim H <karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.
- accessibility/win/bstr-elements-role-expected.txt: Added.
- accessibility/win/bstr-elements-role.html: Added.
- 6:09 PM Changeset in webkit [212269] by
-
- 16 edits1 move1 delete in trunk/Source
[WebRTC] Creating RTCPeerConnection with libwebrtc backend is crashing on rwt
https://bugs.webkit.org/show_bug.cgi?id=168250
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-13
Reviewed by Alex Christensen.
Source/WebCore:
Covered by webrtc tests in LayoutTests and in web-platform-tests.
Making mock peer connection factory keep a ref of the real libwebrtc peer connection factory.
That way, it can create real libwebrtc backends whenever requested by tests.
Moving LibWebRTCUtils.h routines as static LibWebRTCProvider methods.
In the future, we should make them no longer static.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp: Renamed from Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCUtils.cpp.
(WebCore::LibWebRTCProvider::callOnWebRTCNetworkThread):
(WebCore::LibWebRTCProvider::callOnWebRTCSignalingThread):
(WebCore::LibWebRTCProvider::factory):
(WebCore::LibWebRTCProvider::setPeerConnectionFactory):
(WebCore::createActualPeerConnection):
(WebCore::LibWebRTCProvider::createPeerConnection):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- platform/mediastream/libwebrtc/LibWebRTCUtils.h: Removed.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
- testing/Internals.cpp:
- testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::useMockRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionForIceCandidates::gotLocalDescription):
(WebCore::releaseInNetworkThread):
(WebCore::MockLibWebRTCPeerConnection::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):
(WebCore::MockLibWebRTCPeerConnection::CreateOffer):
(WebCore::MockLibWebRTCPeerConnection::CreateAnswer):
Source/WebKit2:
- WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::createPeerConnection):
- WebProcess/Network/webrtc/LibWebRTCProvider.h:
- WebProcess/Network/webrtc/LibWebRTCSocket.h:
- WebProcess/Network/webrtc/WebRTCMonitor.cpp:
(WebKit::WebRTCMonitor::StartUpdating):
(WebKit::WebRTCMonitor::networksChanged):
- WebProcess/Network/webrtc/WebRTCMonitor.h:
- WebProcess/Network/webrtc/WebRTCResolver.cpp:
(WebKit::WebRTCResolver::setResolvedAddress):
(WebKit::WebRTCResolver::resolvedAddressError):
- WebProcess/Network/webrtc/WebRTCSocket.cpp:
(WebKit::WebRTCSocket::signalOnNetworkThread):
- 5:46 PM Changeset in webkit [212268] by
-
- 2 edits in trunk/Tools
[WinCairo] Add Build Slave
https://bugs.webkit.org/show_bug.cgi?id=168263
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-02-13
Reviewed by Lucas Forschler.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:44 PM Changeset in webkit [212267] by
-
- 2 edits in trunk/Source/WebCore
Simplify DragController::startDrag
https://bugs.webkit.org/show_bug.cgi?id=168240
Reviewed by Tim Horton.
Use early returns instead of assigning to a variable that's returned at the end of the function.
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- 5:32 PM Changeset in webkit [212266] by
-
- 5 edits in trunk/Source/WebKit2
Implement Drag cancels
https://bugs.webkit.org/show_bug.cgi?id=168266
Reviewed by Wenson Hsieh.
Adds support for the UI Process to cancel already started drag events.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::cancelledDrag):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::cancelledDrag):
- WebProcess/WebPage/WebPage.messages.in:
- 5:29 PM Changeset in webkit [212265] by
-
- 10 edits2 adds in trunk
The current frame of an image should not deleted if another frame is asynchronously being decoded
https://bugs.webkit.org/show_bug.cgi?id=167618
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-02-13
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/images/animated-image-draw-while-decode.html
If the memory cache asks the BitmapImage to destroy all its frames while
the next frame is being decoded, a thread contention may happen. This can
happen when BitmapImage::draw() is called and the next frame is not ready
yet for drawing, so the current frame has to be drawn. This will invoke
a frame decoding in the same image from the drawing committing thread.
We can avoid that by destroying all the frames except the current frame if
the image is asynchronously decoding its frames. This should not add extra
memory overhead because building the image frame cache and then destroying
it, when needed, is an on-going process. The frames will be allocated and
decoded all the time and all of them can be destroyed except the current one.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
The logic of destroying the ImageFrames was split among BitmapImage, ImageSource
and ImageFrameCache. Move all the logic to BitmapImage and have ImageFrameCache
be responsible only for destroying a range of ImageFrames.
(WebCore::BitmapImage::draw): add an ASSERT_IMPLIES to ensure the current frame
is ready to be rendered if the next frame is being decoded.
- platform/graphics/BitmapImage.h: Move a const from ImageFrameCache.h to BitmapImage.h.
- platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::destroyDecodedData):
(WebCore::ImageFrameCache::destroyDecodedDataIfNecessary): Deleted.
- platform/graphics/ImageFrameCache.h:
(WebCore::ImageFrameCache::destroyAllDecodedData):
(WebCore::ImageFrameCache::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageFrameCache::destroyDecodedDataBeforeFrame):
Make ImageFrameCache be responsible for destroying a range of ImageFrames.
This range might include all the frames, all the frames but up to a specific
frame, or all the frames but exclude one frame in the middle.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::clear): No need to call clearFrameBufferCache() from clear().
The decision to call clearFrameBufferCache() or clear() is moved to
BitmapImage::destroyDecodedData().
(WebCore::ImageSource::destroyDecodedData): Deleted.
(WebCore::ImageSource::destroyDecodedDataIfNecessary): Deleted.
These functions are replaced by another set of functions in ImageSource.h.
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::destroyAllDecodedData):
(WebCore::ImageSource::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageSource::destroyDecodedDataBeforeFrame):
(WebCore::ImageSource::hasDecodingQueue):
These are new wrappers which call the corresponding ImageFrameCache functions.
Source/WTF:
Add ASSERT_IMPLIES() which should fire when a condition is true but the
assertion is false.
- wtf/Assertions.h:
LayoutTests:
This test did not crash on Mac when running it without this patch. But
the new ASSERT_IMPLIES(), which is added to BitmapImage::draw(), fires
when the other changes are not included. So the bug could have happened
without the patch but the crash did not since it requires a thread
contention in the system underlying components.
- fast/images/animated-image-draw-while-decode-expected.txt: Added.
- fast/images/animated-image-draw-while-decode.html: Added.
- 5:18 PM Changeset in webkit [212264] by
-
- 2 edits in trunk/Tools
Fix the build after r212254
- TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator _currentLocation]):
- 5:17 PM Changeset in webkit [212263] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Stop soft-linking CTRunGetBaseAdvancesAndOrigins()
https://bugs.webkit.org/show_bug.cgi?id=168256
Reviewed by Alex Christensen.
Use of this function is already behind a platform guard.
No new tests because there is no behavior change.
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(SOFT_LINK): Deleted.
- 5:08 PM Changeset in webkit [212262] by
-
- 2 edits in trunk/Source/JavaScriptCore
asyncDisassembly crashes on iOS
https://bugs.webkit.org/show_bug.cgi?id=168259
Reviewed by Filip Pizlo.
Eliminated the dumping of the disassembly for the JIT write thunk.
Not only does it fix the crash, but given the nature of the JIT
write thunk, we probably don't want to disassemble it anyway.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::jitWriteThunkGenerator):
- 5:07 PM Changeset in webkit [212261] by
-
- 62 edits in trunk
[WebCrypto] WebInspector should indicate webkitSubtle is deprecated
https://bugs.webkit.org/show_bug.cgi?id=165913
<rdar://problem/30477222>
Reviewed by Joseph Pecoraro.
Source/WebCore:
Covered by existing tests.
- page/Crypto.cpp:
(WebCore::Crypto::webkitSubtle):
LayoutTests:
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html:
Change webkitSubtle to subtle.
- crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt:
- crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt:
- crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt:
- crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
- crypto/webkitSubtle/aes-cbc-generate-key-expected.txt:
- crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt:
- crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt:
- crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt:
- crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt:
- crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt:
- crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt:
- crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt:
- crypto/webkitSubtle/aes-export-key-expected.txt:
- crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt:
- crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt:
- crypto/webkitSubtle/aes-postMessage-expected.txt:
- crypto/webkitSubtle/argument-conversion-expected.txt:
- crypto/webkitSubtle/array-buffer-view-offset-expected.txt:
- crypto/webkitSubtle/gc-2-expected.txt:
- crypto/webkitSubtle/gc-expected.txt:
- crypto/webkitSubtle/hmac-check-algorithm-expected.txt:
- crypto/webkitSubtle/hmac-export-key-expected.txt:
- crypto/webkitSubtle/hmac-generate-key-expected.txt:
- crypto/webkitSubtle/hmac-import-jwk-expected.txt:
- crypto/webkitSubtle/hmac-postMessage-expected.txt:
- crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt:
- crypto/webkitSubtle/hmac-sign-verify-expected.txt:
- crypto/webkitSubtle/import-jwk-expected.txt:
- crypto/webkitSubtle/jwk-export-use-values-expected.txt:
- crypto/webkitSubtle/jwk-import-use-values-expected.txt:
- crypto/webkitSubtle/rsa-export-generated-keys-expected.txt:
- crypto/webkitSubtle/rsa-export-key-expected.txt:
- crypto/webkitSubtle/rsa-export-private-key-expected.txt:
- crypto/webkitSubtle/rsa-indexeddb-expected.txt:
- crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt:
- crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt:
- crypto/webkitSubtle/rsa-indexeddb-private-expected.txt:
- crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt:
- crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt:
- crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt:
- crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
- crypto/webkitSubtle/rsa-postMessage-expected.txt:
- crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt:
- crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt:
- crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
- crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt:
- crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
- crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt:
- crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
- crypto/webkitSubtle/sha-1-expected.txt:
- crypto/webkitSubtle/sha-224-expected.txt:
- crypto/webkitSubtle/sha-256-expected.txt:
- crypto/webkitSubtle/sha-384-expected.txt:
- crypto/webkitSubtle/sha-512-expected.txt:
- crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt:
- crypto/webkitSubtle/unwrapKey-check-usage-expected.txt:
- crypto/webkitSubtle/wrapKey-check-usage-expected.txt:
- fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:
- 4:47 PM Changeset in webkit [212260] by
-
- 8 edits in trunk/Source
Call WKDestroyRenderingResources() on iOS when tabs are backgrounded
https://bugs.webkit.org/show_bug.cgi?id=168261
rdar://problem/30481079
Reviewed by Tim Horton.
Source/WebCore:
Add CABackingStoreCollectBlocking() to QuartzCoreSPI.h, and fix files in WebCore
that do a framework include.
- platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
- platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
- platform/spi/cocoa/QuartzCoreSPI.h:
- platform/spi/mac/NSViewSPI.h:
Source/WebKit2:
There's code to call CABackingStoreCollectBlocking() on a 10s timer that exists for Mac, but on iOS
the web processes are suspended before this timer fires. So call CABackingStoreCollectBlocking()
from WebProcess::actualPrepareToSuspend(), which is where we also trigger the markAllLayersVolatile()
code.
Also add CABackingStoreCollectBlocking() to QuartzCoreSPI.h so we can use it without using WKSI.
Release-log how long this takes, in case we get reports of bad performance. In my testing it could be up to 10ms.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::actualPrepareToSuspend):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::destroyRenderingResources):
- 4:44 PM Changeset in webkit [212259] by
-
- 2 edits in trunk/LayoutTests
Mark media/modern-media-controls/layout-node/addChild.html as flaky on El Capitan WK1.
https://bugs.webkit.org/show_bug.cgi?id=168074
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:26 PM Changeset in webkit [212258] by
-
- 2 edits in trunk/LayoutTests
Mark media/modern-media-controls/forward-button/forward-button.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=168265
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:16 PM Changeset in webkit [212257] by
-
- 3 edits in trunk/Source/WebCore
ASSERTION FAILED: !m_bodyLoader
https://bugs.webkit.org/show_bug.cgi?id=166986
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-13
Reviewed by Sam Weinig.
Refactoring to make the unset/set pending activity part of body loader.
This allows ensuring to not forget to do that by simply deleting the body loader.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::~BodyLoader):
(WebCore::FetchResponse::stop):
- Modules/fetch/FetchResponse.h:
- 3:26 PM Changeset in webkit [212256] by
-
- 4 edits in trunk/Source
Followup to: Replace all WebKit Library Version checks in WK2 with SDK version checks.
https://bugs.webkit.org/show_bug.cgi?id=168124
Reviewed by Geoffrey Garen.
Source/WebKit2:
- UIProcess/Cocoa/VersionChecks.h:
Source/WTF:
- wtf/spi/darwin/dyldSPI.h:
- 3:10 PM Changeset in webkit [212255] by
-
- 3 edits1 delete in trunk/Source/WebCore
Remove unused WebCoreThreadSafe.h
https://bugs.webkit.org/show_bug.cgi?id=168236
Reviewed by Dan Bernstein.
- platform/ios/wak/WebCoreThreadSafe.h: Removed.
- WebCore.xcodeproj/project.pbxproj: Removed WebCoreThreadSafe.h
- platform/ios/wak/WebCoreThread.mm: Removed WebCoreThreadSafe.h and included WAKWindow.h directly
- 3:10 PM Changeset in webkit [212254] by
-
- 9 edits7 adds in trunk
[WK2] Add test infrastructure and unit tests for data interaction
https://bugs.webkit.org/show_bug.cgi?id=168159
<rdar://problem/30477634>
Reviewed by Tim Horton.
Source/WebKit2:
Adds support at the WebKit2 layer for testing data interaction. Introduces the _WKTestingDelegate, which a
protocol which can specified for a WKWebView and used to install mock objects and simulate the state of the
platform. By default, this delegate is nil, which results in normal behavior. For data interaction, we are able
to specify a mock data interaction gesture recognizer for use by the WKContentView to simulate firing a long
press and subsequent movement. This gesture recognizer is used in place of the regular data interaction gesture
recognizer, and allows for TestWebKitAPI to drive interaction without actually sending events through the
UIApplication. The _WKTestingDelegate also contains optional method hooks which are invoked at key points in
time when performing a data interaction gesture.
Since all methods of the testing delegate are optional, the testing delegate can be easily extended to support
testing for other features -- the idea is that leaving all but the relevant methods in the protocol
unimplemented will result in default behavior for everything other than those methods, so a client need only
implement and add WebKit2 hooks for a few methods to support testing for a new feature.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _testingDelegate]):
(-[WKWebView _setTestingDelegate:]):
Specify the testing delegate to use for this WKWebView (see above for more details).
(-[WKWebView _simulateDataInteractionGestureRecognized]):
(-[WKWebView _simulateDataInteractionEntered:]):
(-[WKWebView _simulateDataInteractionUpdated:]):
(-[WKWebView _simulateDataInteractionPerformOperation:]):
(-[WKWebView _simulateDataInteractionEnded:]):
(-[WKWebView _simulateDataInteractionSessionDidEnd:withOperation:]):
(-[WKWebView _simulateFailedDataInteractionWithIndex:]):
(-[WKWebView _simulateWillBeginDataInteractionWithIndex:withSession:]):
(-[WKWebView _simulatedItemsForDataInteractionWithIndex:]):
Used by TestWebKitAPI to drive data interaction tests. See DataInteractionTests.mm.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/_WKTestingDelegate.h: Added.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _dataInteractionGestureRecognizer]):
- WebKit2.xcodeproj/project.pbxproj:
Tools:
Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
gesture has already been recognized) at regular intervals over the course of the test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
New test pages for data interaction.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
(TestWebKitAPI::runTestsExpectingToObserveEvents):
(TestWebKitAPI::TEST):
- TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView stringByEvaluatingJavaScript:]):
- TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
- TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
(-[MockLongPressGestureRecognizer initWithWindow:]):
(-[MockLongPressGestureRecognizer locationInView:]):
(-[MockLongPressGestureRecognizer state]):
(-[MockLongPressGestureRecognizer numberOfTouches]):
(-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
(-[DataInteractionSimulator dealloc]):
(-[DataInteractionSimulator run]):
Performs a data interaction gesture from the start location to the end location with linear interpolation. For
now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
(-[DataInteractionSimulator _advanceProgress]):
Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
completed, and calls _finishDataInteraction when progress is at 1.
(-[DataInteractionSimulator _finishDataInteraction]):
(-[DataInteractionSimulator _currentLocation]):
(-[DataInteractionSimulator _scheduleAdvanceProgress]):
(-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
(-[DataInteractionSimulator dataInteractionGestureRecognizer]):
(-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
(-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
- 3:07 PM Changeset in webkit [212253] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- platform/ios/DragImageIOS.mm:
(WebCore::deleteDragImage):
- 3:06 PM Changeset in webkit [212252] by
-
- 7 edits2 moves in trunk/Source/WebCore
Rename MediaQueryExp.h/cpp to MediaQueryExpression.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=168249
Patch by Sam Weinig <sam@webkit.org> on 2017-02-13
Reviewed by Dean Jackson.
Fix a FIXME and rename MediaQueryExp.h/cpp to match the class it contains, MediaQueryExpression.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/MediaQuery.h:
- css/MediaQueryEvaluator.h:
- css/MediaQueryExp.cpp: Removed.
- css/MediaQueryExp.h: Removed.
- css/MediaQueryExpression.cpp: Copied from Source/WebCore/css/MediaQueryExp.cpp.
- css/MediaQueryExpression.h: Copied from Source/WebCore/css/MediaQueryExp.h.
- css/parser/MediaQueryParser.h:
- 2:55 PM Changeset in webkit [212251] by
-
- 2 edits in trunk/Source/WebCore
WAKResponder should be exported from WebCore
https://bugs.webkit.org/show_bug.cgi?id=168245
Reviewed by Dan Bernstein.
- platform/ios/wak/WAKResponder.h:
- 2:53 PM Changeset in webkit [212250] by
-
- 4 edits in trunk/Source/WebCore
Log to the History Channel in a few more places
https://bugs.webkit.org/show_bug.cgi?id=168252
Reviewed by Brady Eidson.
* Aliens *
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForReload):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::cancel):
- page/History.cpp:
(WebCore::History::go):
- 2:52 PM Changeset in webkit [212249] by
-
- 9 edits in trunk
Percent should be allowed in non-special URL hosts
https://bugs.webkit.org/show_bug.cgi?id=168255
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
- web-platform-tests/url/a-element-expected.txt:
- web-platform-tests/url/a-element-xhtml-expected.txt:
- web-platform-tests/url/url-constructor-expected.txt:
Source/WebCore:
In the last few weeks, the spec has consolidated its sets of code points.
Now forbidden host code points replace the old invalid host code points with
the modification that percents are allowed in non-special hosts because we
percent-encode non-ascii code points in non-special hosts.
See https://url.spec.whatwg.org/#concept-opaque-host-parser
Covered by newly passing web platform tests.
- platform/URLParser.cpp:
(WebCore::isC0Control):
(WebCore::isInUserInfoEncodeSet):
(WebCore::URLParser::hasForbiddenHostCodePoint):
(WebCore::URLParser::parseHostAndPort):
(WebCore::isInvalidDomainCharacter): Deleted.
(WebCore::URLParser::hasInvalidDomainCharacter): Deleted.
- platform/URLParser.h:
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 1:55 PM Changeset in webkit [212248] by
-
- 1 edit1 add in trunk/PerformanceTests
Simple line layout: Add performance test with text-rendering: optimizeSpeed
https://bugs.webkit.org/show_bug.cgi?id=168248
Reviewed by Simon Fraser.
- Layout/simple-line-layout-with-varying-content-and-optimized-speed.html: Added.
- 1:39 PM Changeset in webkit [212247] by
-
- 2 edits in trunk/Source/WebKit2
[MediaStream Mac] Video capture needs access to /Library/CoreMediaIO/Plug-Ins/DAL/
https://bugs.webkit.org/show_bug.cgi?id=168244
<rdar://problem/30461158>
Reviewed by Brady Eidson.
- WebProcess/com.apple.WebProcess.sb.in: Grant read-access to the video capture
plug-in directory when enabling video capture.
- 1:37 PM Changeset in webkit [212246] by
-
- 2 edits in trunk/LayoutTests
Mark tiled-drawing/scrolling/latched-to-deleted-node.html as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=168085
Unreviewed testg gardening.
- platform/mac-wk2/TestExpectations:
- 1:37 PM Changeset in webkit [212245] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/dom/events/EventListener-invoke-legacy.html as flaky on debug.
https://bugs.webkit.org/show_bug.cgi?id=168238
Unreviewed test gardening.
- 1:30 PM Changeset in webkit [212244] by
-
- 8 edits in trunk/Source/WebKit2
Disable mmap'd cache files if container is class A
https://bugs.webkit.org/show_bug.cgi?id=168241
<rdar://problem/23676252>
Reviewed by JF Bastien and Chris Dumez.
If the mmap'd cache file gets evicted and the device is locked,
then WebContent won't be able to bring the file back in under
class A, causing SIGBUS.
In those circumstances, don't use mmap'd files.
- NetworkProcess/cache/NetworkCache.h:
(WebKit::NetworkCache::Cache::canUseSharedMemoryForBodyData):
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):
Don't initialize the shareable resource handle for the map if forbidden.
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::canUseSharedMemoryForPath):
Query the system for the protection status of the cache path.
- NetworkProcess/cache/NetworkCacheFileSystem.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
- NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::canUseSharedMemoryForBodyData):
- 1:11 PM Changeset in webkit [212243] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::setDragImage):
- 1:05 PM Changeset in webkit [212242] by
-
- 3 edits in trunk/LayoutTests
TestExpectations gardening for imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 12:57 PM Changeset in webkit [212241] by
-
- 2 edits in trunk/Source/WebCore
Fix Yosemite build after r211765
https://bugs.webkit.org/show_bug.cgi?id=168246
<rdar://problem/30494174>
Reviewed by Brady Eidson.
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(SOFT_LINK):
- 12:35 PM Changeset in webkit [212240] by
-
- 1 copy in tags/Safari-603.1.27
Tag Safari-603.1.27.
- 12:31 PM Changeset in webkit [212239] by
-
- 11 edits in trunk/Source/WebCore
Add a DragImage class that wraps a DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=168131
Reviewed by Beth Dakin.
This allows us to get rid of the explicit deleteDragImage calls and will make additional cleanup of the
various drag code paths possible. No functionality change.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::updateDragImage):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
- page/DragController.h:
- platform/DragImage.cpp:
(WebCore::DragImage::DragImage):
(WebCore::DragImage::operator=):
(WebCore::DragImage::~DragImage):
- platform/DragImage.h:
- platform/Pasteboard.h:
- platform/StaticPasteboard.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage):
- 12:19 PM Changeset in webkit [212238] by
-
- 2 edits in trunk/Source/WebCore
Regression(r211455): ASSERTION FAILED: frameView pageCacheState() == InPageCache in com.apple.WebCore: WebCore::Document::destroyRenderTree https://bugs.webkit.org/show_bug.cgi?id=168237
<rdar://problem/30494165>
Reviewed by Gavin Barraclough.
Drop bad assertion under document::destroyRenderTree() that was introduced in r211455.
The assertion seemed like a good idea but the issue is that CachedFrame::destroy()
reset's the document's pageCacheState before calling Document::prepareForDestruction().
No new tests, this fixes assertion hits on our bots.
- dom/Document.cpp:
(WebCore::Document::destroyRenderTree):
- 11:58 AM Changeset in webkit [212237] by
-
- 2 edits in trunk/Tools
Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
https://bugs.webkit.org/show_bug.cgi?id=168221
Patch by Fujii Hironori <Fujii Hironori> on 2017-02-13
Reviewed by Ryosuke Niwa.
There is a logic error in comparing mismatch ref test images. In
mismatch ref tests, it should be failed if two images has no diff.
But, if the hashes are different, nwtr unexpectedly pass the
mismatch ref test.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference): Fail the
mismatch ref test if hashes of two images are equal. Invoke
ImageDiff if the hashes don't match.
- 11:14 AM Changeset in webkit [212236] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r188138): Web Inspector: cannot edit next/previous DOM attribute by using tab/shift-tab
https://bugs.webkit.org/show_bug.cgi?id=168120
<rdar://problem/30466065>
Reviewed by Joseph Pecoraro.
DOMTreeElement's attribute editing committed handler shouldn't early return
when amoveDirectionhas been specified.
- UserInterface/Views/DOMTreeElement.js:
- 11:07 AM Changeset in webkit [212235] by
-
- 14 edits1 copy2 adds1 delete in trunk
Update custom line breaking iterators to the latest version of Unicode
https://bugs.webkit.org/show_bug.cgi?id=168182
Reviewed by Zalan Bujtas.
Source/WebCore:
Clean up our breaking code to be more descriptive about the difference between
line-break: auto vs line-break: loose | normal | strict. The only difference is
that we have some hardcoded tables to speed up character iteration for
line-break: auto.
Tests: TestWebKitAPI WebKit2.LineBreaking
- rendering/BreakLines.h:
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePositionWithoutShortcut):
(WebCore::nextBreakablePositionIgnoringNBSPWithoutShortcut):
(WebCore::isBreakable):
(WebCore::nextBreakablePositionNonLoosely): Deleted.
(WebCore::nextBreakablePositionLoosely): Deleted.
(WebCore::nextBreakablePositionLoose): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSPLoose): Deleted.
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::nextBreakablePositionInSegment):
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord):
Source/WTF:
ICU 55.1 supports loose / normal / strict line breaking rules. The oldest platform we ship
on has a version of ICU >= that one. Therefore, we don't need to compile our own rules;
we can just use ICU's rules.
- wtf/text/LineBreakIteratorPoolICU.h:
(WTF::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
(WTF::LineBreakIteratorPool::take):
- wtf/text/TextBreakIterator.cpp:
(WTF::acquireLineBreakIterator):
(WTF::openLineBreakIterator):
(WTF::mapLineIteratorModeToRules): Deleted.
(WTF::isCJKLocale): Deleted.
- wtf/text/TextBreakIterator.h:
(WTF::LazyLineBreakIterator::LazyLineBreakIterator):
(WTF::LazyLineBreakIterator::mode):
(WTF::LazyLineBreakIterator::get):
(WTF::LazyLineBreakIterator::resetStringAndReleaseIterator):
(WTF::LazyLineBreakIterator::isLooseCJKMode): Deleted.
Tools:
Treat the system's ICU as the source of truth to compare breaking positions against.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
(generateJavaScriptForTest):
(breakingLocationsFromICU):
(testAFewStrings):
(TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
- TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
LayoutTests:
Migrated to TestWebKitAPI.
- css3/line-break/line-break-auto-centered-2-expected.html: Removed.
- css3/line-break/line-break-auto-centered-2.html: Removed.
- css3/line-break/line-break-auto-centered-expected.html: Removed.
- css3/line-break/line-break-auto-centered.html: Removed.
- css3/line-break/line-break-auto-half-kana-2-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana-2.html: Removed.
- css3/line-break/line-break-auto-half-kana-3-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana-3.html: Removed.
- css3/line-break/line-break-auto-half-kana-4-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana-4.html: Removed.
- css3/line-break/line-break-auto-half-kana-5-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana-5.html: Removed.
- css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana.html: Removed.
- css3/line-break/line-break-auto-hyphens-expected.html: Removed.
- css3/line-break/line-break-auto-hyphens.html: Removed.
- css3/line-break/line-break-auto-inseparables-expected.html: Removed.
- css3/line-break/line-break-auto-inseparables.html: Removed.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-auto-iteration-marks.html: Removed.
- css3/line-break/line-break-auto-postfixes-expected.html: Removed.
- css3/line-break/line-break-auto-postfixes.html: Removed.
- css3/line-break/line-break-auto-prefixes-expected.html: Removed.
- css3/line-break/line-break-auto-prefixes.html: Removed.
- css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- css3/line-break/line-break-auto-sound-marks.html: Removed.
- css3/line-break/line-break-loose-centered-2-expected.html: Removed.
- css3/line-break/line-break-loose-centered-2.html: Removed.
- css3/line-break/line-break-loose-centered-expected.html: Removed.
- css3/line-break/line-break-loose-centered.html: Removed.
- css3/line-break/line-break-loose-half-kana-2-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana-2.html: Removed.
- css3/line-break/line-break-loose-half-kana-3-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana-3.html: Removed.
- css3/line-break/line-break-loose-half-kana-4-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana-4.html: Removed.
- css3/line-break/line-break-loose-half-kana-5-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana-5.html: Removed.
- css3/line-break/line-break-loose-half-kana-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana.html: Removed.
- css3/line-break/line-break-loose-hyphens-expected.html: Removed.
- css3/line-break/line-break-loose-hyphens.html: Removed.
- css3/line-break/line-break-loose-inseparables-expected.html: Removed.
- css3/line-break/line-break-loose-inseparables.html: Removed.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-loose-iteration-marks.html: Removed.
- css3/line-break/line-break-loose-postfixes-expected.html: Removed.
- css3/line-break/line-break-loose-postfixes.html: Removed.
- css3/line-break/line-break-loose-prefixes-expected.html: Removed.
- css3/line-break/line-break-loose-prefixes.html: Removed.
- css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
- css3/line-break/line-break-loose-sound-marks.html: Removed.
- css3/line-break/line-break-normal-centered-2-expected.html: Removed.
- css3/line-break/line-break-normal-centered-2.html: Removed.
- css3/line-break/line-break-normal-centered-expected.html: Removed.
- css3/line-break/line-break-normal-centered.html: Removed.
- css3/line-break/line-break-normal-half-kana-2-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana-2.html: Removed.
- css3/line-break/line-break-normal-half-kana-3-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana-3.html: Removed.
- css3/line-break/line-break-normal-half-kana-4-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana-4.html: Removed.
- css3/line-break/line-break-normal-half-kana-5-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana-5.html: Removed.
- css3/line-break/line-break-normal-half-kana-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana.html: Removed.
- css3/line-break/line-break-normal-hyphens-expected.html: Removed.
- css3/line-break/line-break-normal-hyphens.html: Removed.
- css3/line-break/line-break-normal-inseparables-expected.html: Removed.
- css3/line-break/line-break-normal-inseparables.html: Removed.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-normal-iteration-marks.html: Removed.
- css3/line-break/line-break-normal-postfixes-expected.html: Removed.
- css3/line-break/line-break-normal-postfixes.html: Removed.
- css3/line-break/line-break-normal-prefixes-expected.html: Removed.
- css3/line-break/line-break-normal-prefixes.html: Removed.
- css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
- css3/line-break/line-break-normal-sound-marks.html: Removed.
- css3/line-break/line-break-strict-centered-2-expected.html: Removed.
- css3/line-break/line-break-strict-centered-2.html: Removed.
- css3/line-break/line-break-strict-centered-expected.html: Removed.
- css3/line-break/line-break-strict-centered.html: Removed.
- css3/line-break/line-break-strict-half-kana-2-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana-2.html: Removed.
- css3/line-break/line-break-strict-half-kana-3-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana-3.html: Removed.
- css3/line-break/line-break-strict-half-kana-4-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana-4.html: Removed.
- css3/line-break/line-break-strict-half-kana-5-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana-5.html: Removed.
- css3/line-break/line-break-strict-half-kana-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana.html: Removed.
- css3/line-break/line-break-strict-hyphens-expected.html: Removed.
- css3/line-break/line-break-strict-hyphens.html: Removed.
- css3/line-break/line-break-strict-inseparables-expected.html: Removed.
- css3/line-break/line-break-strict-inseparables.html: Removed.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-strict-iteration-marks.html: Removed.
- css3/line-break/line-break-strict-postfixes-expected.html: Removed.
- css3/line-break/line-break-strict-postfixes.html: Removed.
- css3/line-break/line-break-strict-prefixes-expected.html: Removed.
- css3/line-break/line-break-strict-prefixes.html: Removed.
- css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
- css3/line-break/line-break-strict-sound-marks.html: Removed.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 10:58 AM Changeset in webkit [212234] by
-
- 4 edits in trunk/LayoutTests
TestExpectations gardening for imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:45 AM Changeset in webkit [212233] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 10:37 AM Changeset in webkit [212232] by
-
- 2 edits in trunk/Source/WebKit2
[WebRTC] libwebrtc socket factory is not assigning the right socket type
https://bugs.webkit.org/show_bug.cgi?id=168233
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-13
Reviewed by Brent Fulgham.
- WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::CreateUdpSocket):
(WebKit::LibWebRTCSocketFactory::CreateClientTcpSocket):
- 10:32 AM Changeset in webkit [212231] by
-
- 3 edits in trunk/Source/WebCore
Remove @getUserMedia identifier
https://bugs.webkit.org/show_bug.cgi?id=168216
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-13
Reviewed by Sam Weinig.
No change of behavior.
- Modules/mediastream/MediaDevices.idl:
- bindings/js/WebCoreBuiltinNames.h:
- 9:28 AM Changeset in webkit [212230] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Unreviewed, add missing precondition check
- WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:
(webkit_web_editor_get_page):
- 9:26 AM Changeset in webkit [212229] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fix another docs typo.
- UIProcess/API/gtk/WebKitEditingCommands.h:
- 9:12 AM UpdatingBugzilla edited by
- (diff)
- 9:07 AM UpdatingBugzilla edited by
- (diff)
- 5:42 AM Changeset in webkit [212228] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Non-accelerated drawing is broken with HiDPI
https://bugs.webkit.org/show_bug.cgi?id=168128
Reviewed by Michael Catanzaro.
When device scale factor changes, the page notifies the page overlay controller about it. Then overlay root
layers are created to be notified about the device scale factor. That causes us to enter in accelerated
compositing mode, because the graphics layer factory is called. But the render layer compositor doesn't really
enter in accelerated mode, because there aren't page overlays, the accelerated mode is not forced and the website
doesn't require acceleration either. This leaves our drawing area in an inconsistent state, it thinks it's in AC
mode because it has a layer tree host, but without a root layer attached, so nothing is rendered. The page
overlay controller doesn't need to create the layers when device scale factor changes, when an overlay is
installed, layers will be created with the current device scale factor anyway.
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::didChangeDeviceScaleFactor): Return early if not initialized yet.
- 1:53 AM Changeset in webkit [212227] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r210845) Build broken with ENABLE_MHTML disabled
https://bugs.webkit.org/show_bug.cgi?id=167771
Reviewed by Daniel Bates.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
Feb 12, 2017:
- 10:49 PM Changeset in webkit [212226] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Assertion failed: !this._items.has(item) (at Collection.js:50)
https://bugs.webkit.org/show_bug.cgi?id=168212
Reviewed by Joseph Pecoraro.
When turning on DebugUI, WebKit-internal scripts were being added to the
Collection that is the represented object for the Extra Scripts folder.
This was not balanced out by removing the scripts when DebugUI is turned
off, so switching DebugUI on and off several times hit a multiple-add assertion.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._scriptWasRemoved):
Remove the script from its Collection if applicable.
- 10:47 PM Changeset in webkit [212225] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Improve documentation of webkit_context_menu_set_user_data()
https://bugs.webkit.org/show_bug.cgi?id=168214
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitContextMenu.cpp:
- 10:41 PM Changeset in webkit [212224] by
-
- 3 edits in trunk/Tools
[GTK] Several failing WebViewEditor API tests
https://bugs.webkit.org/show_bug.cgi?id=161608
Reviewed by Carlos Garcia Campos.
Selection.collapse() requires arguments; passing no arguments means the JS that selects the
text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
except the first one, which is still broken due to unrelated bug #151654.
- Scripts/run-gtk-tests:
(TestRunner):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
- 10:39 PM Changeset in webkit [212223] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
- platform/spi/mac/TUCallSPI.h: Reverted to r212210.
- 10:34 PM Changeset in webkit [212222] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
- platform/spi/mac/TUCallSPI.h:
- 10:21 PM Changeset in webkit [212221] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
- platform/spi/mac/TUCallSPI.h:
- 10:13 PM Changeset in webkit [212220] by
-
- 6 edits in trunk/Source
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
Source/WebCore:
- platform/spi/mac/NSMenuSPI.h: Replaced declaration of deprecated method with its current equivalent.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(createShareMenuItem): Use non-deprecated method.
Source/WebKit2:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem): Use non-deprecated method.
- 10:04 PM Changeset in webkit [212219] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
- 8:21 PM Changeset in webkit [212218] by
-
- 5 edits6 adds in trunk
parserRemoveChild should unload subframes
https://bugs.webkit.org/show_bug.cgi?id=168151
Reviewed by Darin Adler.
Source/WebCore:
Fix the bug that the adoption agency algorithm does not unload subframes as it disconnects nodes.
Also moved calls to nodeWillBeRemoved inside NoEventDispatchAssertion to expand on r211965.
Tests: fast/parser/adoption-agency-clear-focus-range.html
fast/parser/adoption-agency-unload-iframe-1.html
fast/parser/adoption-agency-unload-iframe-2.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom): Rewritten using idioms used in removeChildren and parserAppendChild.
Disconnect all subframes first since this can synchronously dispatch an unload event. Then update DOM ranges,
the focused element, and other states in the document.
Second, use the regular removeBetween, notifyChildNodeRemoved, childrenChanged sequence of calls to disconnect nodes
instead of a single call to removeDetachedChildren to properly disconnect child nodes since those nodes may have
already come live due to execution of synchronous scripts prior to the adoption agency algorithm has run, or in
response to the unload event we just dispatched.
Third, append these nodes using parserAppendChild to avoid dispatching mutation events.
(WebCore::willRemoveChild): Removed the call to nodeWillBeRemoved. It's now called within NoEventDispatchAssertion
in each call site of willRemoveChild and willRemoveChildren.
(WebCore::willRemoveChildren): Ditto.
(WebCore::ContainerNode::removeChild): Call nodeWillBeRemoved inside NoEventDispatchAssertion.
(WebCore::ContainerNode::replaceAllChildren): Call nodeWillBeRemoved inside NoEventDispatchAssertion.
(WebCore::ContainerNode::parserRemoveChild): Disconnect subframes and update document's states.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::executeTakeAllChildrenAndReparentTask): Add a release assert that new parent does not already have a parent.
LayoutTests:
Add two W3C-style testharness tests for unloading iframes inside the adoption agency algorithm.
Also added a test to make sure ContainerNode::takeAllChildrenFrom adjusts the focused element and DOM ranges.
- fast/css/stylesheet-candidate-nodes-crash-expected.txt: Rebaselined. The difference comes from the fact
iframe now is unloaded in parserRemoveChild as expected and then reloaded in parserAppendChild inside
insertErrorMessageBlock as opposed to after the parser had completed as if the iframe had never been detached.
- fast/parser/adoption-agency-clear-focus-range-expected.txt: Added.
- fast/parser/adoption-agency-clear-focus-range.html: Added.
- fast/parser/adoption-agency-unload-iframe-1-expected.txt: Added.
- fast/parser/adoption-agency-unload-iframe-1.html: Added.
- fast/parser/adoption-agency-unload-iframe-2-expected.txt: Added.
- fast/parser/adoption-agency-unload-iframe-2.html: Added.
- 6:42 PM Changeset in webkit [212217] by
-
- 5 edits in tags/Safari-603.1.26.0.1/Source
Versioning.
- 6:40 PM Changeset in webkit [212216] by
-
- 1 copy in tags/Safari-603.1.26.0.1
New tag.
- 6:32 PM Changeset in webkit [212215] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r211609. rdar://problem/30479663
- 6:01 PM Changeset in webkit [212214] by
-
- 3 edits2 adds in trunk
REGRESSION (r179497): Crash inside setAttributeNode
https://bugs.webkit.org/show_bug.cgi?id=168161
<rdar://problem/30451581>
Reviewed by Andreas Kling.
Source/WebCore:
The bug was caused by setAttributeNode calling setAttributeInternal with the same element data as the one used
to call removeAttributeInternal despite of the fact removeAttributeInternal could have invoked arbitrary scripts
and mutated element's m_elementData.
Fixed the bug by calling with setAttributeInternal with the result of new invocation of ensureUniqueElementData().
Test: fast/dom/Attr/make-unique-element-data-while-replacing-attr.html
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
LayoutTests:
Added a regression test.
- fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt: Added.
- fast/dom/Attr/make-unique-element-data-while-replacing-attr.html: Added.
- 5:59 PM Changeset in webkit [212213] by
-
- 3 edits in trunk/Source/WebCore
Rebaseline bindings tests after r212207.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
- 5:56 PM Changeset in webkit [212212] by
-
- 2 edits in trunk/Source/JavaScriptCore
C loop build fix attempt after r212207.
- runtime/Lookup.h:
- 2:01 PM Changeset in webkit [212211] by
-
- 39 edits in trunk/Source
[Cocoa] Some -respondsToSelector: checks are unnecessary
https://bugs.webkit.org/show_bug.cgi?id=168183
Reviewed by Tim Horton.
Source/WebCore:
- English.lproj/Localizable.strings: Removed a string that’s no longer needed after the change to WebKit2/Platform/mac/MenuUtilities.mm.
- editing/mac/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController): Removed check whether
LULookupDefinitionModule responds to +showDefinitionForTerm:relativeToRect:ofView:options:.
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::initialize): Changed to use
-[NEFilterSource setSourceAppIdentifier:], without checking, instead of
-setSourceAppBundleID:, which does not exist.
- platform/cocoa/ScrollController.mm:
(systemUptime): Deleted.
(WebCore::ScrollController::snapRubberBand): Use -[NSProcessInfo systemUptime] directly.
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Remove unnecessary check.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck): Replaced
-respondsToSelector: check with -isKindOfClass: check corresponding to the above cast.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldDisableSleep): Removed unnecessary
check.
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): Removed unnecessary checks.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Ditto.
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::typeForEvent): Removed check whether NSMenu responds to +menuTypeForEvent: and
all code to handle that case that it doesn’t.
- platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController applicationDidResignActive:]): Removed check whether
NSWindow responds to -isOnActiveSpace.
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Removed check whether
NSApplication responds to -setPresentationOptions:
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC updateIsPlaying:newPlaybackRate:]): Removed
unnecessary -respondsToSelector: check.
(-[WebVideoFullscreenInterfaceMacObjC setVideoDimensions:]): Ditto.
(-[WebVideoFullscreenInterfaceMacObjC setUpPIPForVideoView:withFrame:inWindow:]): Ditto.
- platform/spi/cf/CFNetworkSPI.h: Moved declarations of -[NSURLCache _initWithMemoryCapacity:diskCapacity:relativePath:] and -[NSURLCache _CFURLCache] to the !USE(APPLE_INTERNAL_SDK) section.
- platform/spi/cocoa/NEFilterSourceSPI.h: Added declaration of NEFilterSource’ sourceAppIdentifier property to the !USE(APPLE_INTERNAL_SDK) section and deleted unconditional declaration of sourceAppBundleID property, which doesn’t exist.
- platform/spi/cocoa/QuartzCoreSPI.h: Removed redundant declarations.
- platform/spi/ios/DataDetectorsUISPI.h: Moved declarations of DDDetectionController methods from WebKit2/UIProcess/ios/{WKActionSheetAssistant,WKContentViewInteraction}.mm to here. Removed an unused declaration.
- platform/spi/mac/LookupSPI.h: Moved redundant declarations into the !USE(APPLE_INTERNAL_SDK) section.
- platform/spi/mac/NSMenuSPI.h: Changed to import NSMenu_Private.h when using the Apple internal SDK. Cleaned up the declarations for the other case.
- platform/spi/mac/TUCallSPI.h: Changed to import TUCall_Strings.h when use the Apple internal SDK.
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
responds to -isOnActiveSpace.
(-[WebFullScreenController exitFullScreen]): Ditto.
(-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
NSApplication responds to -setPresentationOptions.
- WebView/WebHTMLView.mm:
(createShareMenuItem): Removed unnecessary -respondsToSelector: check.
(-[WebHTMLView otherMouseDown:]): Ditto.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]): Ditto.
(-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
- WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
(+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
Source/WebKit2:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::setColorMatchUntaggedContent): Removed unnecessary
-respondsToSelector: check.
(WebKit::LayerHostingContext::colorMatchUntaggedContent): Ditto.
- Platform/mac/MenuUtilities.mm:
(WebKit::menuItemTitleForTelephoneNumberGroup): Ditto.
- Platform/spi/ios/UIKitSPI.h: Moved declaration of -[UIScrollView _isInterruptingDeceleration] from WKWebView.mm to the !USE(APPLE_INTERNAL_SDK) section here.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setSharedHTTPCookieStorage): Removed unnecessary -respondsToSelector:
check.
- Shared/mac/WebEventFactory.mm:
(WebKit::typeForEvent): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateVisibleContentRectAfterScrollInView:]): Ditto.
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup): Ditto.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly): Ditto.
- UIProcess/WKImagePreviewViewController.mm:
(-[WKImagePreviewViewController previewActions]): Removed check whether _WKElementAction
responds to -runActionWithElementInfo:.
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsSheet]): Ditto.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _lookup:]): Ditto.
(-[WKContentView _share:]): Ditto.
(-[WKContentView _addShortcut:]): Ditto.
(-[WKContentView _promptForReplace:]): Ditto.
(-[WKContentView _transliterateChinese:]): Ditto.
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]): Removed call to
-[UIKeyboardImpl didHandleWebKeyEvent], which is a no-op.
(-[WKContentView _interpretKeyEvent:isCharEvent:]): Removed unnecessary -respondsToSelector:
check.
(-[WKContentView _dataForPreviewItemController:atPosition:type:]): Ditto.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence): Ditto.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForDataDetectedText]): Ditto.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem): Ditto.
- 1:19 PM Changeset in webkit [212210] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Unreviewed, minor documentation improvements
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
- 11:53 AM Changeset in webkit [212209] by
-
- 2 edits in trunk/Tools
Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
- Scripts/run-gtk-tests:
(TestRunner):
- 11:28 AM Changeset in webkit [212208] by
-
- 2 edits in trunk/Tools
Unreviewed, skip flaky form-controls-associated-signal test
- Scripts/run-gtk-tests:
(TestRunner):
- 10:29 AM Changeset in webkit [212207] by
-
- 24 edits1 delete in trunk/Source
Remove the remaining functions out of JSDOMBinding
https://bugs.webkit.org/show_bug.cgi?id=168179
Reviewed by Darin Adler.
Move utility functions into more appropriate locations.
Source/JavaScriptCore:
- Move hasIteratorMethod to IteratorOperations.
- Move nonCachingStaticFunctionGetter to Lookup
- runtime/IteratorOperations.cpp:
(JSC::hasIteratorMethod):
- runtime/IteratorOperations.h:
- runtime/Lookup.h:
(JSC::nonCachingStaticFunctionGetter):
Source/WebCore:
- Move hasIteratorMethod to runtime/IteratorOperations.h
- Move nonCachingStaticFunctionGetter to runtime/Lookup.h
- Move addImpureProperty to CommonVM
Remove toJS overload that took a Vector<T>. Replace it's usage
with toJS<IDLSequence<T>> usage. To make this work, added two
new types, IDLIDBKeyData and IDLIDBValue.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
Adopt JSDOMConvert infrastructure for conversions using new types.
- bindings/IDLTypes.h:
- bindings/js/JSDOMConvertIndexedDB.h:
(WebCore::JSConverter<IDLIDBKeyData>::convert):
(WebCore::JSConverter<IDLIDBValue>::convert):
Add new types for IDBKeyData and IDBValue.
- bindings/js/CommonVM.cpp:
(WebCore::addImpureProperty):
- bindings/js/CommonVM.h:
Move addImpureProperty here from JSDOMBinding.
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyDataToScriptValue): Deleted.
- bindings/js/IDBBindingUtilities.h:
Remove unused idbKeyDataToScriptValue, and group like functions
together.
- bindings/js/JSDOMBinding.cpp: Removed.
- bindings/js/JSDOMBinding.h:
(WebCore::nonCachingStaticFunctionGetter): Deleted.
(WebCore::toJS): Deleted.
Move/remove functions.
- bindings/js/JSDOMConvertUnion.h:
Update for move of hasIteratorMethod to runtime/IteratorOperations.h
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/js/JSLocationCustom.cpp:
Update for move of nonCachingStaticFunctionGetter to runtime/Lookup.h
- bindings/js/JSSubtleCryptoCustom.cpp:
Remove unneeded include of runtime/IteratorOperations.h
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunctionOrConstructor):
Include runtime/IteratorOperations when needing to distinguish a sequence.
- html/HTMLDocument.cpp:
Replace include of JSDOMBinding.h with CommonVM.h for addImpureProperty.
- 9:05 AM Changeset in webkit [212206] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Downloads fail when the given destination is not a URI
https://bugs.webkit.org/show_bug.cgi?id=168187
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-02-12
Reviewed by Michael Catanzaro.
It always expects a uri, and fails if a local path is given.
Fixes: http/tests/download/anchor-download-no-extension.html
http/tests/download/area-download.html
http/tests/security/anchor-download-allow-data.html
http/tests/security/anchor-download-allow-sameorigin.html
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::download): Use g_file_new_for_path() if the pending destination is a path instead
of a URI.
- 8:48 AM Changeset in webkit [212205] by
-
- 11 edits1 add in trunk
[GTK] Handle caps lock indicator in event modifiers
https://bugs.webkit.org/show_bug.cgi?id=168186
Reviewed by Michael Catanzaro.
Source/WebCore:
Add helper function to check if caps lock is present in the given modifiers. We need this because in GDK
GDK_LOCK_MASK might be either CapsLock or ShiftLock in X11. We use this new method in all platform event
implementations to add the appropriate modifiers.
Fixes: fast/events/special-key-events-in-input-text.html
- platform/PlatformKeyboardEvent.h:
- platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::modifiersForGdkKeyEvent):
(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):
- platform/gtk/PlatformMouseEventGtk.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Source/WebKit2:
Use PlatformKeyboardEvent::modifiersContainCapsLock() to check if modifiers contain the caps lock and add
Modifiers::CapsLockKey in that case.
- Shared/gtk/WebEventFactory.cpp:
(WebKit::modifiersForEvent):
- UIProcess/API/gtk/WebKitPrivate.cpp:
(wkEventModifiersToGdkModifiers):
(toGdkModifiers):
Tools:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
LayoutTests:
Add platform specific results for fast/events/special-key-events-in-input-text.html. This patch fixes the caps
lock key case, but we still have different results in the PrintScreen case.
- platform/gtk/fast/events/special-key-events-in-input-text-expected.txt: Added.
- 4:04 AM Changeset in webkit [212204] by
-
- 2 edits6 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline some test and update expectations.
- platform/gtk/TestExpectations:
- platform/gtk/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
- platform/gtk/fast/events/touch/document-create-touch-expected.txt: Added.
- platform/gtk/fast/repaint/block-inputrange-repaint-expected.txt: Added.
- platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: Added.
- 2:21 AM Changeset in webkit [212203] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] PDF page number indicator can show "0 of n" on short pages
https://bugs.webkit.org/show_bug.cgi?id=168185
Reviewed by Tim Horton.
When viewing a PDF with a last page that is shorter than the frame height, it's possible
(thanks to rubber-banding) to scroll down until the page no longer intersects the rect we
use to determine the center page. When this happens, the page number indicator displays
"0 of n".
Fix this by handling cases where the first page starts below the center page rect or the
last page ends above it.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _revalidateViews]):
Feb 11, 2017:
- 9:17 PM Changeset in webkit [212202] by
-
- 196 edits22 copies12 moves292 adds15 deletes in trunk/LayoutTests
Refresh WPT tests up to 06c6c52e05e05483d3c844168a417ee27a554eb7
https://bugs.webkit.org/show_bug.cgi?id=168175
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-11
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- resources/TestRepositories:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/IndexedDB/OWNERS:
- web-platform-tests/IndexedDB/bindings-inject-key-expected.txt: Added.
- web-platform-tests/IndexedDB/bindings-inject-key.html: Added.
- web-platform-tests/IndexedDB/clone-before-keypath-eval-expected.txt: Added.
- web-platform-tests/IndexedDB/clone-before-keypath-eval.html: Added.
- web-platform-tests/IndexedDB/delete-request-queue-expected.txt: Added.
- web-platform-tests/IndexedDB/delete-request-queue.html: Added.
- web-platform-tests/IndexedDB/error-attributes-expected.txt: Added.
- web-platform-tests/IndexedDB/error-attributes.html: Added.
- web-platform-tests/IndexedDB/idb-binary-key-detached-expected.txt: Added.
- web-platform-tests/IndexedDB/idb-binary-key-detached.htm: Added.
- web-platform-tests/IndexedDB/idb-binary-key-roundtrip-expected.txt: Added.
- web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm: Added.
- web-platform-tests/IndexedDB/idbcursor-advance-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-advance-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbcursor-continue-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-continue-exception-order.htm: Added.
- web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey-exceptions-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey-exceptions.htm: Added.
- web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey.htm: Added.
- web-platform-tests/IndexedDB/idbcursor-delete-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-delete-exception-order.htm: Added.
- web-platform-tests/IndexedDB/idbcursor-update-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbcursor-update-exception-order.htm: Added.
- web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm: Added.
- web-platform-tests/IndexedDB/idbdatabase-deleteObjectStore-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbdatabase-deleteObjectStore-exception-order.htm: Added.
- web-platform-tests/IndexedDB/idbdatabase-transaction-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbdatabase-transaction-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbindex-getAll-enforcerange-expected.txt: Added.
- web-platform-tests/IndexedDB/idbindex-getAll-enforcerange.html: Added.
- web-platform-tests/IndexedDB/idbindex-getAllKeys-enforcerange-expected.txt: Added.
- web-platform-tests/IndexedDB/idbindex-getAllKeys-enforcerange.html: Added.
- web-platform-tests/IndexedDB/idbindex-query-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbindex-query-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbkeyrange-includes-expected.txt:
- web-platform-tests/IndexedDB/idbkeyrange-includes.htm:
- web-platform-tests/IndexedDB/idbobjectstore-add-put-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-add-put-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-clear-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-clear-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-delete-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-delete-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-deleteIndex-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-deleteIndex-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-getAll-enforcerange-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-getAll-enforcerange.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-getAllKeys-enforcerange-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-getAllKeys-enforcerange.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore-query-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbobjectstore_getKey-expected.txt: Added.
- web-platform-tests/IndexedDB/idbobjectstore_getKey.html: Added.
- web-platform-tests/IndexedDB/idbrequest-onupgradeneeded-expected.txt: Added.
- web-platform-tests/IndexedDB/idbrequest-onupgradeneeded.htm: Added.
- web-platform-tests/IndexedDB/idbtransaction-objectStore-exception-order-expected.txt: Added.
- web-platform-tests/IndexedDB/idbtransaction-objectStore-exception-order.html: Added.
- web-platform-tests/IndexedDB/idbversionchangeevent.htm:
- web-platform-tests/IndexedDB/key-conversion-exceptions-expected.txt: Added.
- web-platform-tests/IndexedDB/key-conversion-exceptions.htm: Added.
- web-platform-tests/IndexedDB/keypath-exceptions-expected.txt: Added.
- web-platform-tests/IndexedDB/keypath-exceptions.htm: Added.
- web-platform-tests/IndexedDB/keypath-special-identifiers-expected.txt: Added.
- web-platform-tests/IndexedDB/keypath-special-identifiers.htm: Added.
- web-platform-tests/IndexedDB/open-request-queue-expected.txt: Added.
- web-platform-tests/IndexedDB/open-request-queue.html: Added.
- web-platform-tests/IndexedDB/support.js:
(auto_fail):
(createdb_for_multiple_tests):
(assert_key_equals):
(indexeddb_test):
- web-platform-tests/IndexedDB/w3c-import.log:
- web-platform-tests/README.md:
- web-platform-tests/XMLHttpRequest/abort-during-done.htm:
- web-platform-tests/XMLHttpRequest/historical-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/historical.html: Added.
- web-platform-tests/XMLHttpRequest/resources/corsenabled.py:
(main):
- web-platform-tests/XMLHttpRequest/response-method-expected.txt:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-post-upload-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm:
- web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm:
- web-platform-tests/XMLHttpRequest/w3c-import.log:
- web-platform-tests/check_stability.py:
(do_delayed_imports):
(setup_logging):
(setup_action_filter.as):
(setup_action_filter.LogActionFilter):
(setup_action_filter.LogActionFilter.init):
(setup_action_filter.LogActionFilter.call):
(TravisFold):
(TravisFold.init):
(TravisFold.enter):
(TravisFold.exit):
(FilteredIO):
(FilteredIO.init):
(FilteredIO.getattr):
(FilteredIO.disable):
(FilteredIO.write):
(replace_streams):
(replace_streams.on_write):
(Browser):
(Browser.install):
(Browser.install_webdriver):
(Browser.version):
(Browser.wptrunner_args):
(Firefox):
(Firefox.install):
(Firefox._latest_geckodriver_version):
(Firefox.install_webdriver):
(Firefox.version):
(Firefox.wptrunner_args):
(Chrome):
(Chrome.install):
(Chrome.install_webdriver):
(Chrome.version):
(Chrome.wptrunner_args):
(get):
(call):
(get_git_cmd):
(seekable):
(untar):
(unzip):
(pwd):
(fetch_wpt_master):
(get_sha1):
(build_manifest):
(install_wptrunner):
(get_files_changed):
(get_affected_testfiles):
(wptrunner_args):
(setup_log_handler.as):
(setup_log_handler.LogHandler):
(is_inconsistent):
(err_string):
(process_results):
(format_comment_title):
(markdown_adjust):
(table):
(write_inconsistent):
(write_results):
(get_parser):
(main):
- web-platform-tests/ci_built_diff.sh:
- web-platform-tests/ci_stability.sh:
- web-platform-tests/common/OWNERS:
- web-platform-tests/custom-elements/reactions/DOMTokenList-expected.txt:
- web-platform-tests/custom-elements/reactions/DOMTokenList.html:
- web-platform-tests/dom/events/EventListener-invoke-legacy-expected.txt: Added.
- web-platform-tests/dom/events/EventListener-invoke-legacy.html: Added.
- web-platform-tests/dom/events/w3c-import.log:
- web-platform-tests/dom/lists/DOMTokenList-iteration-expected.txt:
- web-platform-tests/dom/lists/DOMTokenList-iteration.html:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
- web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
- web-platform-tests/dom/nodes/Document-createElementNS.html:
- web-platform-tests/dom/nodes/Document-createElementNS.js:
- web-platform-tests/dom/nodes/Node-isSameNode-expected.txt:
- web-platform-tests/dom/nodes/Node-isSameNode.html:
- web-platform-tests/dom/nodes/NodeList-Iterable-expected.txt:
- web-platform-tests/dom/nodes/NodeList-Iterable.html:
- web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
- web-platform-tests/dom/ranges/Range-selectNode.html:
- web-platform-tests/encrypted-media/content/video_512x288_h264-360k_multikey_key1_dashinit.mp4: Added.
- web-platform-tests/fetch/api/cors/cors-preflight.js:
(corsPreflight):
- web-platform-tests/fetch/api/headers/header-values-expected.txt: Added.
- web-platform-tests/fetch/api/headers/header-values-normalize-expected.txt: Added.
- web-platform-tests/fetch/api/headers/header-values-normalize.html: Added.
- web-platform-tests/fetch/api/headers/header-values.html: Added.
- web-platform-tests/fetch/api/headers/w3c-import.log:
- web-platform-tests/fetch/api/policies/referrer-origin-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin.js:
(promise_test):
- web-platform-tests/fetch/api/request/request-cache-default-conditional-expected.txt:
- web-platform-tests/fetch/api/request/request-cache-default-conditional.html:
- web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
- web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
- web-platform-tests/fetch/api/request/request-disturbed.html:
- web-platform-tests/fetch/api/request/request-error-expected.txt:
- web-platform-tests/fetch/api/request/request-error.html:
- web-platform-tests/fetch/api/request/request-idl-expected.txt:
- web-platform-tests/fetch/api/request/request-idl.html:
- web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-001.sub.html:
- web-platform-tests/fetch/api/resources/preflight.py:
(main):
- web-platform-tests/fetch/api/response/response-idl-expected.txt:
- web-platform-tests/fetch/api/response/response-idl.html:
- web-platform-tests/fonts/OWNERS: Added.
- web-platform-tests/fonts/w3c-import.log:
- web-platform-tests/hr-time/idlharness-expected.txt:
- web-platform-tests/hr-time/idlharness.html:
- web-platform-tests/hr-time/w3c-import.log:
- web-platform-tests/hr-time/window-worker-time-origin-expected.txt: Added.
- web-platform-tests/hr-time/window-worker-time-origin.html: Added.
- web-platform-tests/html/OWNERS:
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name-0.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin.html:
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/same-url-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/same-url.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/w3c-import.log:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin.html:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/w3c-import.log:
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-image-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-image.html:
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html:
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/w3c-import.log:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/w3c-import.log:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/w3c-import.log:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/w3c-import.log:
- web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-expected.txt:
- web-platform-tests/html/browsers/offline/browser-state/navigator_online_online-expected.txt:
- web-platform-tests/html/browsers/origin/cross-origin-objects/frame.html:
- web-platform-tests/html/browsers/windows/browsing-context-names/w3c-import.log:
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub-expected.txt:
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/w3c-import.log:
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/empty.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/w3c-import.log:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/write-active-document-expected.txt: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/write-active-document.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt:
- web-platform-tests/html/dom/elements-forms.js:
- web-platform-tests/html/dom/elements-misc.js:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/reflection-misc-expected.txt:
- web-platform-tests/html/semantics/embedded-content/image-maps/contains.json:
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.whitespace.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-dimension-getter-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-dimension-getter.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html:
- web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
- web-platform-tests/html/semantics/forms/form-control-infrastructure/form.html:
- web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-usv-expected.txt: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-usv-form.html: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-usv.html: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/form-echo.py: Added.
(main):
- web-platform-tests/html/semantics/forms/form-submission-0/url-encoded-expected.txt:
- web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
- web-platform-tests/html/semantics/forms/resetting-a-form/reset-form-event-realm-expected.txt: Added.
- web-platform-tests/html/semantics/forms/resetting-a-form/reset-form-event-realm-support.html: Added.
- web-platform-tests/html/semantics/forms/resetting-a-form/reset-form-event-realm.html: Added.
- web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
- web-platform-tests/html/semantics/forms/the-button-element/button-menu-historical-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-menu-historical.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-fieldset-element/disabled-001.html:
- web-platform-tests/html/semantics/forms/the-input-element/date-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/date.html:
- web-platform-tests/html/semantics/forms/the-input-element/datetime-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/datetime.html:
- web-platform-tests/html/semantics/forms/the-input-element/number-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/number.html:
- web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/range.html:
- web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/selection.html:
- web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/time-2.html:
- web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/time.html:
- web-platform-tests/html/semantics/forms/the-input-element/week-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/week.html:
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-menu-expected.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-menu.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-skip-no-boxes-expected.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-skip-no-boxes.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-li-element/w3c-import.log:
- web-platform-tests/html/semantics/links/linktypes/alternate-import.css: Added.
(body):
- web-platform-tests/html/semantics/links/linktypes/alternate.css:
(@import url("alternate-import.css");):
- web-platform-tests/html/semantics/links/linktypes/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-reflect-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-reflect.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-external-module-script-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-external-module-script.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-classic-scripts-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-classic-scripts.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-module-script-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-module-script.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-synchronously-loaded-classic-scripts-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-synchronously-loaded-classic-scripts.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/resources/cocoa-module.js: Added.
(export.default.Cocoa.prototype.taste):
(export.default.Cocoa):
- web-platform-tests/html/semantics/scripting-1/the-script-element/resources/exports-cocoa.js: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/resources/set-script-executed.js: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/resources/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods.html:
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-expected.txt: Added.
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html: Added.
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/w3c-import.log:
- web-platform-tests/html/syntax/OWNERS: Added.
- web-platform-tests/html/syntax/w3c-import.log:
- web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers-expected.txt: Added.
- web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers.html: Added.
- web-platform-tests/html/webappapis/scripting/events/eventhandler-cancellation-expected.txt: Added.
- web-platform-tests/html/webappapis/scripting/events/eventhandler-cancellation.html: Added.
- web-platform-tests/html/webappapis/scripting/events/w3c-import.log:
- web-platform-tests/images/OWNERS:
- web-platform-tests/lint.whitelist:
- web-platform-tests/media-source/mediasource-duration-expected.txt:
- web-platform-tests/resource-timing/resource-timing-expected.txt:
- web-platform-tests/shadow-dom/HTMLSlotElement-interface-expected.txt:
- web-platform-tests/shadow-dom/HTMLSlotElement-interface.html:
- web-platform-tests/shadow-dom/event-inside-slotted-node-expected.txt:
- web-platform-tests/shadow-dom/event-inside-slotted-node.html:
- web-platform-tests/shadow-dom/event-with-related-target-expected.txt:
- web-platform-tests/shadow-dom/event-with-related-target.html:
- web-platform-tests/streams/OWNERS:
- web-platform-tests/streams/README.md: Added.
- web-platform-tests/streams/byte-length-queuing-strategy-expected.txt:
- web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html: Added.
- web-platform-tests/streams/byte-length-queuing-strategy.html: Added.
- web-platform-tests/streams/byte-length-queuing-strategy.https-expected.txt: Removed.
- web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.https.html.
- web-platform-tests/streams/byte-length-queuing-strategy.sharedworker-expected.txt: Added.
- web-platform-tests/streams/byte-length-queuing-strategy.sharedworker.html: Added.
- web-platform-tests/streams/count-queuing-strategy-expected.txt:
- web-platform-tests/streams/count-queuing-strategy.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html: Added.
- web-platform-tests/streams/count-queuing-strategy.html: Added.
- web-platform-tests/streams/count-queuing-strategy.https-expected.txt: Removed.
- web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/count-queuing-strategy.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.https.html.
- web-platform-tests/streams/count-queuing-strategy.sharedworker-expected.txt: Added.
- web-platform-tests/streams/count-queuing-strategy.sharedworker.html: Added.
- web-platform-tests/streams/generate-test-wrappers.js: Added.
(const.arg.of.process.argv.slice):
(generateWrapper):
- web-platform-tests/streams/piping/close-propagation-backward-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-backward.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-backward.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/close-propagation-backward.html: Added.
- web-platform-tests/streams/piping/close-propagation-backward.js: Added.
(promise_test):
(promise_test.t.const.rs.recordingReadableStream.cancel):
(promise_test.t.string_appeared_here.then):
(string_appeared_here.promise_test):
(Symbol):
(promise_test.t.then):
- web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.https.html.
- web-platform-tests/streams/piping/close-propagation-backward.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-backward.sharedworker.html: Added.
- web-platform-tests/streams/piping/close-propagation-forward-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/close-propagation-forward.html: Added.
- web-platform-tests/streams/piping/close-propagation-forward.js: Added.
(promise_test):
(promise_test.t.const.rs.recordingReadableStream.start):
(promise_test.t.const.ws.recordingWritableStream.close):
(promise_test.t.string_appeared_here.then):
(string_appeared_here.promise_test):
(Symbol):
(promise_test.t.return.pipePromise.then):
(promise_test.t.setTimeout):
- web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.https.html.
- web-platform-tests/streams/piping/close-propagation-forward.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/close-propagation-forward.sharedworker.html: Added.
- web-platform-tests/streams/piping/error-propagation-backward-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/error-propagation-backward.html: Added.
- web-platform-tests/streams/piping/error-propagation-backward.js: Added.
(promise_test.t.const.ws.recordingWritableStream.start):
(promise_test.t.string_appeared_here.then):
(promise_test.t.const.ws.recordingWritableStream.write):
(promise_test.t.const.rs.recordingReadableStream.cancel):
(string_appeared_here.promise_test.t.const.ws.recordingWritableStream.write):
(string_appeared_here.promise_test.t.string_appeared_here.then):
(Symbol):
(promise_test.t.const.rs.recordingReadableStream.start):
(promise_test.t.return.pipePromise.then):
(promise_test):
(promise_test.t.then):
(promise_test.t.return.writeCalledPromise.then):
- web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.https.html.
- web-platform-tests/streams/piping/error-propagation-backward.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-backward.sharedworker.html: Added.
- web-platform-tests/streams/piping/error-propagation-forward-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-forward.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-forward.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/error-propagation-forward.html: Added.
- web-platform-tests/streams/piping/error-propagation-forward.js: Added.
(promise_test.t.const.rs.recordingReadableStream.start):
(promise_test.t.string_appeared_here.then):
(promise_test.t.const.ws.recordingWritableStream.abort):
(string_appeared_here.promise_test.t.const.rs.recordingReadableStream.start):
(string_appeared_here.promise_test.t.string_appeared_here.then):
(Symbol):
(promise_test.t.return.pipePromise.then):
(promise_test.t.setTimeout):
(promise_test.t.const.ws.recordingWritableStream.write):
(promise_test.t.rs.pipeTo.ws.then):
(promise_test.t.return.writeCalledPromise.then):
(promise_test.t.then):
- web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.https.html.
- web-platform-tests/streams/piping/error-propagation-forward.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/error-propagation-forward.sharedworker.html: Added.
- web-platform-tests/streams/piping/flow-control-expected.txt: Added.
- web-platform-tests/streams/piping/flow-control.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/flow-control.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/flow-control.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/cancel.https.html.
- web-platform-tests/streams/piping/flow-control.js: Added.
(promise_test.t.const.rs.recordingReadableStream.start):
(promise_test.t.return.flushAsyncEvents.then):
(promise_test.t.string_appeared_here.then):
(promise_test):
(promise_test.const.rs.recordingReadableStream.):
- web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/flow-control.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/piping/flow-control.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/flow-control.sharedworker.html: Added.
- web-platform-tests/streams/piping/general-expected.txt: Added.
- web-platform-tests/streams/piping/general.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/general.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/general.html: Added.
- web-platform-tests/streams/piping/general.js: Added.
(test):
(promise_test):
(promise_test.t.rs.pipeTo.ws.then):
(false.promise_test.t.const.rs.new.ReadableStream.pull):
(false.promise_test.t.return.rs.pipeTo.new.WritableStream):
(false.promise_test.t.const.ws.new.WritableStream.write):
- web-platform-tests/streams/piping/general.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/general.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/piping/general.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/general.sharedworker.html: Added.
- web-platform-tests/streams/piping/multiple-propagation-expected.txt: Added.
- web-platform-tests/streams/piping/multiple-propagation.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/multiple-propagation.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/multiple-propagation.html: Added.
- web-platform-tests/streams/piping/multiple-propagation.js: Added.
(promise_test.t.const.rs.recordingReadableStream.start):
(promise_test.t.const.ws.recordingWritableStream.start):
(promise_test.t.string_appeared_here.then):
(promise_test):
- web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/multiple-propagation.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/piping/multiple-propagation.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/multiple-propagation.sharedworker.html: Added.
- web-platform-tests/streams/piping/pipe-through-expected.txt: Added.
- web-platform-tests/streams/piping/pipe-through.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/pipe-through.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/pipe-through.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/pipe-through.https.html.
- web-platform-tests/streams/piping/pipe-through.js: Added.
(duckTypedPassThroughTransform):
(promise_test):
(promise_test.t.const.transform.writable.new.WritableStream.start):
(test):
- web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/pipe-through.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/piping/pipe-through.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/pipe-through.sharedworker.html: Added.
- web-platform-tests/streams/piping/transform-streams-expected.txt: Added.
- web-platform-tests/streams/piping/transform-streams.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/piping/transform-streams.dedicatedworker.html: Added.
- web-platform-tests/streams/piping/transform-streams.html: Added.
- web-platform-tests/streams/piping/transform-streams.js: Added.
(promise_test):
- web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/piping/transform-streams.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/piping/transform-streams.sharedworker-expected.txt: Added.
- web-platform-tests/streams/piping/transform-streams.sharedworker.html: Added.
- web-platform-tests/streams/piping/w3c-import.log: Added.
- web-platform-tests/streams/readable-byte-streams/general-expected.txt: Added.
- web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-byte-streams/general.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-byte-streams/general.html: Added.
- web-platform-tests/streams/readable-byte-streams/general.js: Added.
(test):
(promise_test):
(promise_test.t.const.stream.new.ReadableStream.start):
(promise_test.t.return.reader.closed.then):
(promise_test.t.string_appeared_here.then):
(extractViewInfo):
(promise_test.t.const.stream.new.ReadableStream.cancel):
(promise_test.t.pump):
(promise_test.t.const.stream.new.ReadableStream.pull):
- web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-byte-streams/general.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-byte-streams/general.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-byte-streams/general.sharedworker.html: Added.
- web-platform-tests/streams/readable-byte-streams/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log.
- web-platform-tests/streams/readable-streams/bad-strategies-expected.txt:
- web-platform-tests/streams/readable-streams/bad-strategies.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-strategies.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/bad-strategies.html: Added.
- web-platform-tests/streams/readable-streams/bad-strategies.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/bad-strategies.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-strategies.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt:
- web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.html: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.js:
(promise_test.t.const.rs.new.ReadableStream.pull):
(promise_test.t.return.Promise.resolve.then):
- web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.https.html.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/bad-underlying-sources.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/brand-checks-expected.txt:
- web-platform-tests/streams/readable-streams/brand-checks.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/brand-checks.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/brand-checks.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.https.html.
- web-platform-tests/streams/readable-streams/brand-checks.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.https.html.
- web-platform-tests/streams/readable-streams/brand-checks.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/brand-checks.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/cancel-expected.txt:
- web-platform-tests/streams/readable-streams/cancel.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/cancel.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/cancel.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/cancel.https.html.
- web-platform-tests/streams/readable-streams/cancel.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/cancel.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/cancel.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/cancel.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration-expected.txt:
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.https.html: Removed.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/garbage-collection-expected.txt:
- web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/garbage-collection.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.https.html.
- web-platform-tests/streams/readable-streams/garbage-collection.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/garbage-collection.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/garbage-collection.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/general-expected.txt:
- web-platform-tests/streams/readable-streams/general.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/general.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/general.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.https.html.
- web-platform-tests/streams/readable-streams/general.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/general.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/general.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/general.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/pipe-through-expected.txt:
- web-platform-tests/streams/readable-streams/pipe-through.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/pipe-through.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/pipe-through.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/pipe-through.https.html.
- web-platform-tests/streams/readable-streams/pipe-through.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/pipe-through.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/pipe-through.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader-expected.txt:
- web-platform-tests/streams/readable-streams/readable-stream-reader.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader.html: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.https.html.
- web-platform-tests/streams/readable-streams/readable-stream-reader.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/readable-stream-reader.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/tee-expected.txt:
- web-platform-tests/streams/readable-streams/tee.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/tee.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/tee.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.https.html.
- web-platform-tests/streams/readable-streams/tee.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/tee.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/tee.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/tee.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/templated-expected.txt:
- web-platform-tests/streams/readable-streams/templated.dedicatedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/templated.dedicatedworker.html: Added.
- web-platform-tests/streams/readable-streams/templated.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/templated.https.html.
- web-platform-tests/streams/readable-streams/templated.https-expected.txt: Removed.
- web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt: Added.
- web-platform-tests/streams/readable-streams/templated.serviceworker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.https.html.
- web-platform-tests/streams/readable-streams/templated.sharedworker-expected.txt: Added.
- web-platform-tests/streams/readable-streams/templated.sharedworker.html: Added.
- web-platform-tests/streams/readable-streams/w3c-import.log:
- web-platform-tests/streams/resources/recording-streams.js: Added.
(self.recordingReadableStream):
(self.recordingWritableStream):
- web-platform-tests/streams/resources/rs-test-templates.js:
(self.templatedRSEmpty):
(self.templatedRSClosed):
(self.templatedRSErrored):
(self.templatedRSErroredSyncOnly):
(self.templatedRSEmptyReader):
(self.templatedRSClosedReader):
(self.templatedRSErroredReader):
(self.templatedRSTwoChunksOpenReader):
(self.templatedRSTwoChunksClosedReader):
- web-platform-tests/streams/resources/test-initializer.js: Removed.
- web-platform-tests/streams/resources/test-utils.js:
(self.methodRejects):
- web-platform-tests/streams/resources/w3c-import.log:
- web-platform-tests/streams/w3c-import.log:
- web-platform-tests/test_keys_wdspec.html: Added.
- web-platform-tests/url/a-element-expected.txt:
- web-platform-tests/url/a-element-origin-xhtml.xhtml:
- web-platform-tests/url/a-element-origin.html:
- web-platform-tests/url/a-element-xhtml-expected.txt:
- web-platform-tests/url/a-element-xhtml.xhtml:
- web-platform-tests/url/a-element.html:
- web-platform-tests/url/interfaces-expected.txt:
- web-platform-tests/url/setters_tests.json:
- web-platform-tests/url/url-constructor-expected.txt:
- web-platform-tests/url/url-setters-expected.txt:
- web-platform-tests/url/url-tojson-expected.txt:
- web-platform-tests/url/urltestdata.json:
- web-platform-tests/url/w3c-import.log:
- web-platform-tests/user-timing/resources/webperftestharness.js:
(has_required_interfaces):
- web-platform-tests/user-timing/test_user_timing_clear_marks.html:
- web-platform-tests/user-timing/test_user_timing_clear_measures.html:
- web-platform-tests/user-timing/test_user_timing_mark.html:
- web-platform-tests/user-timing/test_user_timing_mark_exceptions.html:
- web-platform-tests/user-timing/test_user_timing_measure.html:
- web-platform-tests/user-timing/test_user_timing_measure_exceptions.html:
- web-platform-tests/user-timing/test_user_timing_measure_navigation_timing-expected.txt:
- web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html:
- web-platform-tests/w3c-import.log:
- web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
- web-platform-tests/webrtc/no-media-call-expected.txt:
- web-platform-tests/webrtc/promises-call-expected.txt:
LayoutTests:
- TestExpectations: Marking some tests as failing/skipping.
- tests-options.json:
- 8:59 PM Changeset in webkit [212201] by
-
- 11 edits1 delete in trunk
Remove custom bindings for XSLTProcessor.idl
https://bugs.webkit.org/show_bug.cgi?id=168174
Reviewed by Andreas Kling.
Source/WebCore:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSXSLTProcessorCustom.cpp: Removed.
Remove file.
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringOrUndefined): Deleted.
- bindings/js/JSDOMBinding.h:
Remove now unused jsStringOrUndefined.
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::setParameter):
(WebCore::XSLTProcessor::getParameter):
(WebCore::XSLTProcessor::removeParameter):
- xml/XSLTProcessor.idl:
Replace custom bindings bindings with early returns. One subtle difference
between the custom bindings and this, is that getParameter will return
jsNull() rather than jsUndefined() for null String returns. This matches
all other bindings.
LayoutTests:
- fast/xsl/xslt-processor-expected.txt:
- fast/xsl/xslt-processor.html:
Update test / results for subtle new no-result behavior.
- 8:14 PM Changeset in webkit [212200] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][MSE][EME] Fix decryptor assignment
https://bugs.webkit.org/show_bug.cgi?id=168122
Patch by Olivier Blin <Olivier Blin> on 2017-02-11
Reviewed by Michael Catanzaro.
The new decryptor is a floating reference so we should not use the
adopt GRefPtr constructor, but use the regular assignment operator
that will sink the object (clear the floating flag).
This fixes assertions in debug build.
See previous pipeline fix in r210851 and WPE commit
06020b18831e1c0eead34e2c1a5a4b7d026c227d.
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
Do not use adoptGRef(), it prevented the object from being sunk.
- 8:11 PM Changeset in webkit [212199] by
-
- 2 edits in trunk/LayoutTests
LayoutTest fast/scrolling/page-cache-back-overflow-scroll-restore.html is a flaky failure
<https://webkit.org/b/168084>
Reviewed by Michael Catanzaro.
Wait for a scroll event before triggering a navigation. This removes the flakiness.
Also use element.scrollTop to scroll the overflow:scroll element instead of eventSender.
- fast/scrolling/page-cache-back-overflow-scroll-restore.html:
- 8:10 PM Changeset in webkit [212198] by
-
- 2 edits in trunk/Source/WebKit2
Fix crashes after [NSURLSession invalidateAndCancel]
https://bugs.webkit.org/show_bug.cgi?id=168181
<rdar://problem/29813868>
Reviewed by Brady Eidson.
When we call NetworkSessionCocoa::invalidateAndCancel, we intend for the session to immediately
become invalid and stop doing things. [NSURLSession invalidateAndCancel] asynchronously cancels
everything and then calls the delegate's didBecomeInvalidWithError, so before this change there
is a time when we have torn down the session with SessionTracker::destroySession but we can still
get a delegate callback which assumes the session and its NetworkStorageSession exists. If we
get any delegate callbacks after a NetworkSession has been invalidated, we will want to ignore them.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate sessionInvalidated]):
(-[WKNetworkSessionDelegate URLSession:didBecomeInvalidWithError:]):
(-[WKNetworkSessionDelegate URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
The pointer to the NetworkSessionCocoa can now be null. We need to check it.
(WebKit::NetworkSessionCocoa::invalidateAndCancel):
Synchronously remove the connection between the delegates and the NetworkSessionCocoa.
- 7:18 PM Changeset in webkit [212197] by
-
- 3 edits in trunk/Source/WebCore
Avoid a redundant scroll to 0,0 when navigating back to a url with no fragment
https://bugs.webkit.org/show_bug.cgi?id=168177
Reviewed by Sam Weinig.
FrameView::scrollToFragment() is called from FrameLoader::scrollToFragmentWithParentBoundary()
when navigating within the page. If the URL had no fragment identifier, this code would
call into FrameView::scrollToAnchor() with an empty name, where maintainScrollPositionAtAnchor()
used the document as the anchor, thus scrolling to 0,0. Later, history().restoreScrollPositionAndViewState()
the restores the scroll position from history.
This scroll to 0,0 happened to be not visible to the page because of scroll event
coalescing, but it makes implementation of history.scrollRestoration harder, so avoid it
by just returning early from FrameView::scrollToFragment() if there is no fragment,
making sure to clear the document's CSSTarget.
- dom/Document.cpp:
(WebCore::Document::setCSSTarget):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::scrollToAnchor):
- 2:12 PM Changeset in webkit [212196] by
-
- 7 edits1 add in trunk
[JSC] Implement (Shared)ArrayBuffer.prototype.byteLength
https://bugs.webkit.org/show_bug.cgi?id=166476
Reviewed by Saam Barati.
JSTests:
- ChakraCore/test/typedarray/arraybufferType.baseline-jsc:
- stress/array-buffer-byte-length.js: Added.
(shouldBe):
(shouldThrow):
(Symbol):
- stress/reflect-set.js:
Source/JavaScriptCore:
byteLengthbecomes getter and is set in ArrayBuffer.prototype
and SharedArrayBuffer.prototype. This patch implements the
above getter in native function. We do not have any optimization
path for that for now since ArrayBuffer.prototype.byteLength is
not considered a hot function: while TypedArrays have [] accesses,
ArrayBuffer does not have that. Thus byteLength getter is not so
meaningful for a hot paths like iterations.
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::getOwnPropertySlot): Deleted.
(JSC::JSArrayBuffer::put): Deleted.
(JSC::JSArrayBuffer::defineOwnProperty): Deleted.
(JSC::JSArrayBuffer::deleteProperty): Deleted.
(JSC::JSArrayBuffer::getOwnNonIndexPropertyNames): Deleted.
- runtime/JSArrayBuffer.h:
(JSC::JSArrayBuffer::impl): Deleted.
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoGetterFuncByteLength):
(JSC::sharedArrayBufferProtoGetterFuncByteLength):
(JSC::JSArrayBufferPrototype::finishCreation):
- 2:12 PM Changeset in webkit [212195] by
-
- 2 edits in trunk/Tools
MiniBrowser WK1 fails to update URL for within-page navigations
https://bugs.webkit.org/show_bug.cgi?id=168173
Reviewed by Tim Horton.
Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
anchors updates the URL field.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
- 9:07 AM Changeset in webkit [212194] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Mark resource load stats tests as crashing.
- platform/gtk/TestExpectations:
- 7:14 AM Changeset in webkit [212193] by
-
- 12 edits4 adds1 delete in trunk
Implement URL's toJSON()
https://bugs.webkit.org/show_bug.cgi?id=167979
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Re-sync URL tests from upstream to gain test coverage for
URL's toJSON().
- web-platform-tests/url/interfaces-expected.txt:
- web-platform-tests/url/interfaces.html:
- web-platform-tests/url/url-tojson-expected.txt: Added.
- web-platform-tests/url/url-tojson.html: Added.
- web-platform-tests/url/w3c-import.log:
Source/WebCore:
Implement URL's toJSON() as per:
This is already supported by Firefox.
Also, drop URLUtils.idl as it is no longer in the specification.
Merge its content to DOMURL.idl as per the URL specification.
Finally, mark href attribute as stringifier and drop the toString()
operation to match the specification. This fixes a bug where our
toString property was not enumerable but should have been.
Tests: fast/url/url-tojson.html
imported/w3c/web-platform-tests/url/url-tojson.html
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMURL.idl:
- html/URLUtils.h:
(WebCore::URLUtils<T>::toJSON):
- html/URLUtils.idl: Removed.
LayoutTests:
Extend test coverage.
- fast/url/url-tojson-expected.txt: Added.
- fast/url/url-tojson.html: Added.
- 6:29 AM Changeset in webkit [212192] by
-
- 5 edits in trunk/Source/WebCore
[GTK][EFL] Implement MIMETypeRegistry::getPreferredExtensionForMIMEType
https://bugs.webkit.org/show_bug.cgi?id=168163
Reviewed by Michael Catanzaro.
It's missing causing several HTML anchor download tests to fail because the suggested filename missed the
extension. This patch moves MIMETypeRegistry::appendFileExtensionIfNecessary() from the cocoa specific file to the
common file because it's not actually platform specific. MIMETypeRegistry::getPreferredExtensionForMIMEType() is
what platforms should implement.
Fixes: fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html
fast/dom/HTMLAnchorElement/anchor-download.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::appendFileExtensionIfNecessary):
- platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::MIMETypeRegistry::appendFileExtensionIfNecessary): Deleted.
- platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- 6:03 AM Changeset in webkit [212191] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Update several tests expected to timeout that are failing now.
- platform/gtk/TestExpectations:
- 5:46 AM Changeset in webkit [212190] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Updated expectations of several WebCryptoAPI tests that are failing.
- platform/gtk/TestExpectations:
- 4:17 AM Changeset in webkit [212189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Mark tests using drag and drop as crashing in Wayland.
- platform/gtk-wayland/TestExpectations:
- 4:02 AM Changeset in webkit [212188] by
-
- 26 edits10 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several tests.
- platform/gtk/fast/css/font_property_normal-expected.png:
- platform/gtk/fast/css/font_property_normal-expected.txt:
- platform/gtk/fast/dynamic/text-combine-expected.png:
- platform/gtk/fast/dynamic/text-combine-expected.txt:
- platform/gtk/fast/forms/select-empty-option-height-expected.png:
- platform/gtk/fast/forms/select-empty-option-height-expected.txt:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/forms/validation-message-appearance-expected.png:
- platform/gtk/fast/forms/validation-message-appearance-expected.txt:
- platform/gtk/fast/images/icon-decoding-expected.png:
- platform/gtk/fast/images/icon-decoding-expected.txt: Added.
- platform/gtk/fast/inline/continuation-outlines-with-layers-expected.png:
- platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.png:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/fast/repaint/4776765-expected.txt: Added.
- platform/gtk/fast/repaint/focus-ring-repaint-expected.txt: Added.
- platform/gtk/fast/repaint/zoomed-fixed-background-expected.txt: Added.
- platform/gtk/fast/scrolling/page-cache-back-overflow-scroll-restore-expected.txt: Added.
- platform/gtk/http/tests/plugins/plugin-javascript-access-expected.txt:
- platform/gtk/http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe-expected.txt: Added.
- platform/gtk/inspector/css/get-system-fonts-expected.txt:
- platform/gtk/plugins/plugin-javascript-access-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
- platform/gtk/svg/batik/text/verticalText-expected.png:
- platform/gtk/svg/batik/text/verticalText-expected.txt: Added.
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.png:
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt: Added.
- platform/gtk/svg/text/text-align-06-b-expected.png:
- platform/gtk/svg/text/text-align-06-b-expected.txt: Added.
- platform/gtk/tables/mozilla/bugs/bug4427-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4427-expected.txt:
- 4:00 AM Changeset in webkit [212187] by
-
- 1 edit4 deletes in trunk/LayoutTests
Unreviewed GTK+ gardening. Remove more platform specific results.
- platform/gtk/fast/media/w3c/test_media_queries-expected.txt: Removed.
- platform/gtk/http/tests/eventsource/eventsource-cors-non-http-expected.txt: Removed.
- platform/gtk/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/failure-expected.txt: Removed.
- 3:05 AM Changeset in webkit [212186] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update imageTitle translatable string.
To match mac port. Fixes fast/images/imageDocument-title.html.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::imageTitle):
- 2:38 AM Changeset in webkit [212185] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Unreviewed GTK+ gardening. Update platform specific results for fast/css-generated-content/malformed-url.html and fast/events/mouse-cursor-image-set.html
Remove platform specific results of fast/css-generated-content/malformed-url.html and add platform specific
results for fast/events/mouse-cursor-image-set.html, because this test fails only for the missing scale due to
MOUSE_CURSOR_SCALE not implemented in GTK+ port.
- platform/gtk/TestExpectations:
- platform/gtk/fast/css-generated-content/malformed-url-expected.txt: Removed.
- platform/gtk/fast/events/mouse-cursor-image-set-expected.txt: Added.
Feb 10, 2017:
- 11:44 PM Changeset in webkit [212184] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Skip CSS image-orientation and image-resolution tests.
- platform/gtk/TestExpectations:
- 11:34 PM Changeset in webkit [212183] by
-
- 36 edits15 adds in trunk
Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
https://bugs.webkit.org/show_bug.cgi?id=167474
<rdar://problem/24681808>
<rdar://problem/24703286>
<rdar://problem/30290270>
Source/WebCore:
This patch does the following:
- Gets the right website data store. API::WebsiteDataStore::defaultDataStore()
does not provide the right data store.
- Introduces timeout for user interaction. A domain needs interaction every 30
days to stay in that category.
- Adds grandfathered to the statistics model in preparation for grandfathering of
existing data records.
- Adds test infrastructure to allow testing of the various rules in place for
data records removal.
- Fixes various smaller bugs that were found as part of setting up the tests.
- Regresses the data records removal counting. We need to come up with a thread
safe way of gathering removal statistics from more than one data store now
that we potentially interact with multiple stores.
- Adds a first set of layout tests for resource load statistics.
Reviewed by Andy Estes.
Tests: http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html
http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html
http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html
http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction.html
http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html
- dom/Document.cpp:
(WebCore::Document::updateLastHandledUserGestureTimestamp):
This now calls ResourceLoadObserver::logUserInteraction() every time since
we want to keep track of the most recent user interaction.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::statisticsStore):
New getter used by WebResourceLoadStatisticsManager::resetToConsistentState().
(WebCore::reduceTimeResolutionToOneDay):
Convenience function.
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
Reduces time resolution for privacy reasons.
(WebCore::ResourceLoadObserver::logUserInteraction):
(WebCore::ResourceLoadObserver::clearUserInteraction):
(WebCore::ResourceLoadObserver::hasHadUserInteraction):
(WebCore::ResourceLoadObserver::setPrevalentResource):
(WebCore::ResourceLoadObserver::isPrevalentResource):
(WebCore::ResourceLoadObserver::clearPrevalentResource):
(WebCore::ResourceLoadObserver::setTimeToLiveUserInteraction):
(WebCore::ResourceLoadObserver::fireDataModificationHandler):
New functions that allow WebKitTestRunner to stage exact
statistics, fire the handler, and test the outcome.
- loader/ResourceLoadObserver.h:
- loader/ResourceLoadStatistics.cpp:
(WebCore::ResourceLoadStatistics::encode):
(WebCore::ResourceLoadStatistics::decode):
(WebCore::ResourceLoadStatistics::toString):
(WebCore::ResourceLoadStatistics::merge):
Support for statistics mostRecentUserInteraction, grandfathered, and
dataRecordsRemoved.
- loader/ResourceLoadStatistics.h:
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::setTimeToLiveUserInteraction):
New function that allows WebKitTestRunner to test
aging out of user interaction.
(WebCore::ResourceLoadStatisticsStore::hasHadRecentUserInteraction):
Now takes into account the timestamp and ages
out user interaction.
(WebCore::ResourceLoadStatisticsStore::prevalentResourceDomainsWithoutUserInteraction):
Now makes use of ResourceLoadStatisticsStore::hasHadRecentUserInteraction().
- loader/ResourceLoadStatisticsStore.h:
Source/WebKit2:
This patch does the following:
- Gets the right website data store. API::WebsiteDataStore::defaultDataStore()
does not provide the right data store.
- Introduces timeout for user interaction. A domain needs interaction every 30
days to stay in that category.
- Adds grandfathered to the statistics model in preparation for grandfathering of
existing data records.
- Adds test infrastructure to allow testing of the various rules in place for
data records removal.
- Fixes various smaller bugs that were found as part of setting up the tests.
- Regresses the data records removal counting. We need to come up with a thread
safe way of gathering removal statistics from more than one data store now
that we potentially interact with multiple stores.
- Adds a first set of layout tests for resource load statistics.
Reviewed by Andy Estes.
- PlatformEfl.cmake:
Added UIProcess/WebResourceLoadStatisticsManager.cpp and
UIProcess/API/C/WKResourceLoadStatisticsManager.cpp.
- PlatformGTK.cmake:
Added UIProcess/WebResourceLoadStatisticsManager.cpp and
UIProcess/API/C/WKResourceLoadStatisticsManager.cpp.
- PlatformMac.cmake:
Added UIProcess/WebResourceLoadStatisticsManager.cpp and
UIProcess/API/C/WKResourceLoadStatisticsManager.cpp.
- Shared/API/APIObject.h:
Adds WebResourceLoadStatisticsManager to the Type enum.
- Shared/API/c/WKBase.h:
Typedef of WKResourceLoadStatisticsManagerRef.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceLoadStatistics>::encode):
(IPC::ArgumentCoder<ResourceLoadStatistics>::decode):
Adds support for statistics mostRecentUserInteraction, grandfathered, and
dataRecordsRemoved.
- UIProcess/API/C/WKAPICast.h:
Adds API mapping between WKResourceLoadStatisticsManagerRef and
WebResourceLoadStatisticsManager.
- UIProcess/API/C/WKResourceLoadStatisticsManager.cpp: Added.
(WKResourceLoadStatisticsManagerGetTypeID):
(WKResourceLoadStatisticsManagerSetPrevalentResource):
(WKResourceLoadStatisticsManagerIsPrevalentResource):
(WKResourceLoadStatisticsManagerSetHasHadUserInteraction):
(WKResourceLoadStatisticsManagerIsHasHadUserInteraction):
(WKResourceLoadStatisticsManagerSetTimeToLiveUserInteraction):
(WKResourceLoadStatisticsManagerFireDataModificationHandler):
(WKResourceLoadStatisticsManagerSetNotifyPagesWhenDataRecordsWereScanned):
(WKResourceLoadStatisticsManagerSetShouldClassifyResourcesBeforeDataRecordsRemoval):
(WKResourceLoadStatisticsManagerSetMinimumTimeBetweeenDataRecordsRemoval):
(WKResourceLoadStatisticsManagerResetToConsistentState):
API level bridge to WebResourceLoadStatisticsManager functions.
- UIProcess/API/C/WKResourceLoadStatisticsManager.h: Added.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyOwnedDomainsInAllPersistentDataStores):
A way to delete website data in persistent store(s) configured by the
embedding client. API::WebsiteDataStore::defaultDataStore() does not
do this which caused us to skip session storage.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebResourceLoadStatisticsManager.cpp: Added.
(WebKit::WebResourceLoadStatisticsManager::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsManager::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsManager::setHasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsManager::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsManager::setTimeToLiveUserInteraction):
(WebKit::WebResourceLoadStatisticsManager::fireDataModificationHandler):
(WebKit::WebResourceLoadStatisticsManager::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebResourceLoadStatisticsManager::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsManager::setMinimumTimeBetweeenDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsManager::resetToConsistentState):
Static functions to manage the state and behavior of the UI process'
resource load statistics store.
- UIProcess/WebResourceLoadStatisticsManager.h: Added.
(WebKit::WebResourceLoadStatisticsManager::create):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
An effect of a member variable rename. See header file comment below.
(WebKit::WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebResourceLoadStatisticsStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsStore::setMinimumTimeBetweeenDataRecordsRemoval):
Three static functions for controlling the behavior of the store.
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
Changes:
- Covers all data record types.
- Allows data removal when m_lastTimeDataRecordsWereRemoved is not set.
- Moves the heavy lifting to WebsiteDataStore (see below).
- No longer counts removed data regressions.
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
See next comment.
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
WebResourceLoadStatisticsStore::processStatisticsAndDataRecords() is
broken out of WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated
to allow for statistics processing without prior classification.
Tests need to set statistics and a run of the classifier may
reset the data.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
Sets the notification callback which calls
WebResourceLoadStatisticsStore::processStatisticsAndDataRecords().
- UIProcess/WebResourceLoadStatisticsStore.h:
(WebKit::WebResourceLoadStatisticsStore::coreStore):
Renamed m_resourceStatisticsStore to m_resourceLoadStatisticsStore to
harmonize with other naming.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyOwnedDomains):
This is now where matching is made between prevalent resources
and data records. This function is used by
WebsiteDataStore::removeDataForTopPrivatelyOwnedDomains().
(WebKit::WebsiteDataStore::removeDataForTopPrivatelyOwnedDomains):
The function WebResourceLoadStatisticsStore::removeDataRecords()
calls to get data records removed in all persistent stores.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::m_resourceLoadStatisticsStore):
(WebKit::WebProcess::statisticsChangedTimerFired):
(WebKit::m_resourceLoadStatisticsStorage): Deleted.
Renamed m_resourceLoadStatisticsStorage to m_resourceLoadStatisticsStore
to harmonize with other naming.
- WebProcess/WebProcess.h:
Tools:
This patch adds test infrastructure to allow testing
of the various rules in place for data records removal.
Reviewed by Andy Estes.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
Callback mechanism to tell pages that a website data store
scan has happened.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setStatisticsPrevalentResource):
(WTR::TestRunner::isStatisticsPrevalentResource):
(WTR::TestRunner::setStatisticsHasHadUserInteraction):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):
(WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
(WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
(WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
(WTR::TestRunner::statisticsFireDataModificationHandler):
(WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
(WTR::TestRunner::statisticsResetToConsistentState):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::setStatisticsPrevalentResource):
(WTR::TestController::isStatisticsPrevalentResource):
(WTR::TestController::setStatisticsHasHadUserInteraction):
(WTR::TestController::isStatisticsHasHadUserInteraction):
(WTR::TestController::setStatisticsTimeToLiveUserInteraction):
(WTR::TestController::statisticsFireDataModificationHandler):
(WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
(WTR::TestController::statisticsResetToConsistentState):
- WebKitTestRunner/TestController.h:
These are all configuration and test functions.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
LayoutTests:
Reviewed by Andy Estes.
Marked as general skip (see WK2 expectations below).
- http/tests/loading/resourceLoadStatistics: Added.
- http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html: Added.
- http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction.html: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html: Added.
- platform/wk2/TestExpectations:
Marked as valid for WebKit2 only.
- 10:01 PM Changeset in webkit [212182] by
-
- 4 edits in trunk/Tools
REGRESSION(r182916) run-perf-tests never timeouts
https://bugs.webkit.org/show_bug.cgi?id=167626
Reviewed by Ryosuke Niwa.
The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
was beeing ignored because the driver was created with no_timeout=True
unconditionally.
This adds a new parameter --no-timeout (disabled by default), that
allows to use the driver with the expected timeout values.
It also passes --no-timeout to DRT/WTR to ensure that timeouts
are always controlled by the Python Driver.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
(PerfTest.run): Disabling timeout should be done when the Driver is created.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init): Ensure --no-timeout is passed to DRT/WTR
(PerfTestsRunner._parse_args): Add a --no-timeout parameter.
(_run_tests_set): Pass the no-timeout parameter.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
(MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
(MainTest.test_parse_args): Test that the argument no-timeout.
- 9:49 PM Changeset in webkit [212181] by
-
- 12 edits in trunk
[WebIDL] Cleanup XMLHttpRequest's bindings
https://bugs.webkit.org/show_bug.cgi?id=168067
Patch by Sam Weinig <sam@webkit.org> on 2017-02-10
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
Update results now that we pass.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsOwnedStringOrNull): Deleted.
- bindings/js/JSDOMBinding.h:
Remove jsOwnedStringOrNull and inline it into it's one use
in JSXMLHttpRequestCustom.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::responseText):
(WebCore::SendFunctor::SendFunctor): Deleted.
(WebCore::SendFunctor::line): Deleted.
(WebCore::SendFunctor::column): Deleted.
(WebCore::SendFunctor::url): Deleted.
(WebCore::SendFunctor::operator()): Deleted.
(WebCore::JSXMLHttpRequest::send): Deleted.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
Remove custom send, replacing it with a single send implementation that
takes a variant.
- xml/XMLHttpRequest.idl:
Cleanup the IDL to better match the spec. Update correct types where trivial.
LayoutTests:
- http/tests/xmlhttprequest/set-bad-headervalue.html:
Update test now that we throw the correct exceptions.
- 9:33 PM Changeset in webkit [212180] by
-
- 2 edits in trunk/Source/WTF
[Xcode] WTF installs extra copies of two headers outside /usr/local/include/wtf
https://bugs.webkit.org/show_bug.cgi?id=168160
Reviewed by Sam Weinig.
- WTF.xcodeproj/project.pbxproj: Demoted OrdinalNumber.h MemoryFootprint.h from Private to Project.
- 8:54 PM Changeset in webkit [212179] by
-
- 2 edits in trunk/Source/WebKit/ios
WebKitLegacy doesn't re-export various symbols from WebCore required by clients
https://bugs.webkit.org/show_bug.cgi?id=168158
<rdar://problem/24527933>
Reviewed by Dan Bernstein.
- WebKit.iOS.exp: Exporting various symbols which are required by clients. This
would enable clients to stop linking against WebCore and instead link against WebKit.
- 8:40 PM Changeset in webkit [212178] by
-
- 9 edits in trunk
document.origin doesn't match spec
https://bugs.webkit.org/show_bug.cgi?id=168022
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline test now that document.origin has the right format.
- web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
Source/WebCore:
Update document.origin to return the origin in the expected format:
Change: "https_webkit.org_0 -> "https://webkit.org".
The new behavior matches Firefox and Chrome.
No new tests, updated existing tests.
- dom/Document.cpp:
(WebCore::Document::origin):
LayoutTests:
- http/tests/media/media-stream/enumerate-devices-source-id-persistent.html:
Fix test that was passing only because the document.origin would never match the
expected string:
- Move idCounts to the global scope has the handler function is called 3 times and we need to properly update the same idCounts object in all 3 calls.
- Fix initialization of idCounts to start at 1, not 0. Otherwise, idCounts[uniqueID] is 0 instead of 1.
- Use a Map instead of an array since the ids are UUID strings, not integers.
- Fix check for non-unique ids, was idCounts[deviceId] == 1 instead of idCounts[deviceId] != 1.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html:
- http/tests/ssl/iframe-upgrade.https.html:
Update / rebaseline now that document.origin has the right format.
- 8:33 PM UpdatingBugzilla edited by
- (diff)
- 8:32 PM UpdatingBugzilla edited by
- (diff)
- 8:29 PM UpdatingBugzilla edited by
- (diff)
- 8:18 PM UpdatingBugzilla edited by
- (diff)
- 8:14 PM UpdatingBugzilla edited by
- (diff)
- 8:05 PM Changeset in webkit [212177] by
-
- 5 edits1 add in trunk
Object allocation sinking phase doesn't properly handle control flow when emitting a PutHint of a materialized object into a PromotedHeapLocation of a still sunken object
https://bugs.webkit.org/show_bug.cgi?id=168140
<rdar://problem/30205880>
Reviewed by Filip Pizlo.
JSTests:
- stress/allocation-sinking-puthint-control-flow.js: Added.
(e):
(bar):
(let.y):
(else.let.y):
(baz):
(foo):
(catch):
Source/JavaScriptCore:
This patch fixes a bug in allocation sinking phase where
we don't properly handle control flow when materializing
an object and also PutHinting that materialization into
a still sunken object. We were performing the PutHint
for the materialization at the point of materialization,
however, we may have materialized along both edges
of a control flow diamond, in which case, we need to
also PutHint at the join point. Consider this program:
`
bb#0:
b: PhantomActivation()
a: PhantomNewFunction()
c: PutHint(@a, @b, ActivationLoc)
Branch(#1, #2)
bb#1:
d: MaterializeActivation()
e: PutHint(@a, @d, ActivationLoc)
f: Upsilon(@d, p)
Jump(#3)
bb#2:
g: MaterializeActivation()
h: PutHint(@a, @g, ActivationLoc)
i: Upsilon(@d, p)
Jump(#3)
bb#3:
p: Phi()
What is PromotedHeapLocation(@a, ActivationLoc) here?
What would we do if we exited?
`
Before this patch, we didn't perform a PutHint of the Phi.
However, we need to, otherwise when exit, we won't know
the value of PromotedHeapLocation(@a, ActivationLoc)
The program we need then, for correctness, is this:
`
bb#0:
b: PhantomActivation()
a: PhantomNewFunction()
c: PutHint(@a, @b, ActivationLoc)
Branch(#1, #2)
bb#1:
d: MaterializeActivation()
e: PutHint(@a, @d, ActivationLoc)
f: Upsilon(@d, p)
Jump(#3)
bb#2:
g: MaterializeActivation()
h: PutHint(@a, @g, ActivationLoc)
i: Upsilon(@d, p)
Jump(#3)
bb#3:
p: Phi()
j: PutHint(@a, @p, ActivationLoc)
`
This patch makes it so that we emit the necessary PutHint at node
j.
I've also added more validation to the OSRAvailabilityAnalysisPhase
to catch this problem during validation.
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- 7:59 PM Changeset in webkit [212176] by
-
- 2 edits in trunk/Source/WebKit2
Zero out some WKWebView state in the case of a web content crash
https://bugs.webkit.org/show_bug.cgi?id=168157
Reviewed by Tim Horton.
Reset some bits of state in WKWebView when the web content process crashes, in
to try to avoid states that might cause the web view to stay blank.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _processDidExit]):
- 7:32 PM Changeset in webkit [212175] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
(https://bugs.webkit.org/show_bug.cgi?id=166774)
Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
- Interfaces/WebKit.idl:
- 7:25 PM UpdatingBugzilla edited by
- (diff)
- 7:09 PM Changeset in webkit [212174] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the build following <https://trac.webkit.org/changeset/212173>
(https://bugs.webkit.org/show_bug.cgi?id=166774)
- dom/Document.cpp:
(WebCore::Document::detachFromCachedFrame): Use ASSER_UNUSED() instead of ASSERT() since
the parameter cachedFrame is unused in non-debug build.
- 6:53 PM Changeset in webkit [212173] by
-
- 41 edits in trunk
Detach frame from document when entering page cache
https://bugs.webkit.org/show_bug.cgi?id=166774
<rdar://problem/29904368>
Reviewed by Chris Dumez.
Source/WebCore:
When a page enters the page cache it is unnecessary for it to hold a reference to its
associated frame because subsequent interactions with the page do not need to make use
of it. Once a page exits the page cache we associate it with its frame.
- dom/Document.cpp:
(WebCore::Document::frameDestroyed): Update comment to reflect the renaming of disconnectFromFrame().
(WebCore::Document::attachToCachedFrame): Added.
(WebCore::Document::detachFromCachedFrame): Added.
(WebCore::Document::prepareForDestruction): Only call CSSAnimationController::detachFromDocument() if
we have a frame. Substitute detachFromFrame() for disconnectFromFrame() as the latter was renamed to
the former.
(WebCore::Document::hasEverCalledWindowOpen): Deleted.
(WebCore::Document::markHasCalledWindowOpen): Deleted.
(WebCore::Document::disconnectFromFrame): Renamed to detachFromFrame.
- dom/Document.h:
(WebCore::Document::detachFromFrame): Renamed; formerly named disconnectFromFrame(). Changed
visibility from public to private and made this function inline.
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::pruneDetachedChildFrames): Remove cached child frames that were
removed from the page when it was in the page cache as there is no need to restore such frames.
(WebCore::CachedFrameBase::restore): Call pruneDetachedChildFrames() before restoring the
frame tree.
(WebCore::CachedFrame::CachedFrame): Detach from the frame.
(WebCore::CachedFrame::open): Assert that we have a document and re-attach the frame.
(WebCore::CachedFrame::destroy): Update assertion as this function should only be called for a
frameless document. Only detach the FrameView, DocumentLoader, and Page when the cached frame is for
subframe and is associated with a Page object. Call CSSAnimationController::detachFromDocument() to
detach the animation controller from the document as it is being destroyed. We have to do this here
because the document does not have a frame. And Document::prepareForDestruction() only calls
CSSAnimationController::detachFromDocument() if the document has a frame.
- history/CachedFrame.h:
- history/PageCache.cpp:
(WebCore::canCachePage): Remove logic that prevents caching of a page that called window.open()
or has an opener as it is feasible to keep such pages in the page cache.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Fix style nit.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::frameDetached): Only stop all loaders and stop active DOM objects if the
page is not in- or about to enter- the page cache. A page in the page cache has finished loading
and its active DOM objects are suspended. Also fix style nit in comment.
(WebCore::FrameLoader::detachFromParent): Only stop all loaders if the page is not in- or about to
enter- the page cache. A page in the page cache has finished loading. Also added a comment to explain
that we protect the frame because stopAllLoaders() can cause the frame to be deallocated.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow): Remove logic to call markHasCalledWindowOpen() as this
function will be removed.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::hasCalledWindowOpenKey): Deleted.
(WebCore::DiagnosticLoggingKeys::hasOpenerKey): Deleted.
- page/DiagnosticLoggingKeys.h:
- page/Page.cpp:
(WebCore::Page::openedByWindowOpen): Deleted.
- page/Page.h:
- page/Settings.in: Remove setting allowsPageCacheWithWindowOpener.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
(-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
(WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAllowsPageCacheWithWindowOpener): Deleted.
(WKPreferencesGetAllowsPageCacheWithWindowOpener): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 6:30 PM Changeset in webkit [212172] by
-
- 4 edits in trunk
REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168054
Reviewed by Tim Horton.
Source/WebCore:
When adding mask layers, there was an ordering dependency. There was a hack in GraphicsLayerCA::setVisibleAndCoverageRects()
to propagate m_intersectsCoverageRect to masks. However, if GraphicsLayerCA::setVisibleAndCoverageRects()
ran on the masked layer before the mask was added, nothing updated the "m_intersectsCoverageRect" state of the mask layer.
Fix by explicitly calling setVisibleAndCoverageRects() on the mask layer, passing the same rects and
viewport-constrained state as for its host layer (we already assume that their geometry matches).
Tested by compositing/masks/solid-color-masked.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
LayoutTests:
Make the timeout 10ms so the test consistently fails with the old code.
- compositing/masks/solid-color-masked.html:
- 6:25 PM Changeset in webkit [212171] by
-
- 6 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Debugger sidebar panel should not have multiple tree selections
https://bugs.webkit.org/show_bug.cgi?id=166000
<rdar://problem/29721988>
Reviewed by Timothy Hatcher.
The method for synchronizing tree element selection across a sidebar's
tree outlines fails for selections made during startup, because it depends
on events which are being suppressed.
This adds a new class, TreeOutlineGroup, which restricts tree element selection
inside a group of tree outlines by receiving messages directly from TreeElement.
- UserInterface/Main.html:
Add file for TreeOutlineGroup class.
- UserInterface/Views/ContentBrowserTabContentView.js:
(WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObject):
(WebInspector.ContentBrowserTabContentView):
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
UpdatecreateContentTreeOutlinecalls for new signature.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel):
Replace _visibleContentTreeOutlines with a TreeOutlineGroup, which
contains the single-selection behavior previously handled by the sidebar.
(WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlines):
(WebInspector.NavigationSidebarPanel.prototype.get hasSelectedElement):
Implement using the sidebar's tree outline group.
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Remove first parameter, which is always true.
(WebInspector.NavigationSidebarPanel.prototype.treeElementForRepresentedObject):
(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
(WebInspector.NavigationSidebarPanel.prototype.pruneStaleResourceTreeElements):
(WebInspector.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie):
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline): Deleted.
Remove unused setter.
(WebInspector.NavigationSidebarPanel.prototype.get visibleContentTreeOutlines): Deleted.
Renamed to contentTreeOutlines.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus): Deleted.
No longer needed.
(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange): Deleted.
Selection across trees handled by the tree outline group.
- UserInterface/Views/TreeElement.js:
(WebInspector.TreeElement.prototype.select):
Inform the element's tree outline group (if any), of the selection changed.
- UserInterface/Views/TreeOutlineGroup.js: Added.
(WebInspector.TreeOutlineGroup):
(WebInspector.TreeOutlineGroup.groupForTreeOutline):
(WebInspector.TreeOutlineGroup.prototype.get selectedTreeElement):
(WebInspector.TreeOutlineGroup.prototype.itemAdded):
Associate tree outline with the group and wrap tree elements. If the
incoming tree outline has a selection, deselect the group's currently
selected tree element.
(WebInspector.TreeOutlineGroup.prototype.itemRemoved):
Disassociate the tree outline from the group.
(WebInspector.TreeOutlineGroup.prototype.didSelectTreeElement):
Called by TreeElement when it becomes selected.
(WebInspector.TreeOutlineGroup.prototype._removeConflictingTreeSelections):
Deselect any selected items in all tree outlines belonging to the group,
except for the specified item.
- 6:20 PM Changeset in webkit [212170] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r212154, r212154, and r212156.
https://bugs.webkit.org/show_bug.cgi?id=168156
broke internal builds (Requested by smfr on #webkit).
Reverted changesets:
"Add a DragImage class that wraps a DragImageRef"
https://bugs.webkit.org/show_bug.cgi?id=168131
http://trac.webkit.org/changeset/212154
"Add a DragImage class that wraps a DragImageRef"
https://bugs.webkit.org/show_bug.cgi?id=168131
http://trac.webkit.org/changeset/212154
"Try to fix the iOS and Windows builds."
http://trac.webkit.org/changeset/212156
- 5:27 PM Changeset in webkit [212169] by
-
- 10 edits4 moves2 adds in trunk/Source
WebInspector: refactor RemoteInspector to move cocoa specific code to their own files
https://bugs.webkit.org/show_bug.cgi?id=166681
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-02-10
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
Move RemoteConnectionToTarget.mm and RemoteInspector.mm to a cocoa directory renamed with a Cocoa prefix,
because those are now the cocoa implementation of RemoteConnectionToTarget and RemoteInspector. The
cross-platform parts of RemoteInspector have been moced to a new RemoteInspector.cpp file. Also moved to cocoa
directory RemoteInspectorXPCConnection.h and RemoteInspectorXPCConnection.mm keeping the same name. Other than
that there aren't important code changes, only some cocoa specific types like NSString used in common headers,
and some other platform ifdefs needed. This is in preparation for adding a remote inspector implementation for
the GTK+ port.
- API/JSRemoteInspector.cpp:
(JSRemoteInspectorSetParentProcessInformation): Add PLATFORM(COCOA) to the ifdef.
- JavaScriptCore.xcodeproj/project.pbxproj:
- PlatformMac.cmake:
- inspector/remote/RemoteConnectionToTarget.h: Add platform ifdefs for cocoa specific parts and change
sendMessageToTarget to receive a WTF String instead of an NSString.
- inspector/remote/RemoteControllableTarget.h: Add platform ifdefs for CF specific parts.
- inspector/remote/RemoteInspectionTarget.h:
- inspector/remote/RemoteInspector.cpp: Added.
(Inspector::RemoteInspector::startDisabled):
(Inspector::RemoteInspector::nextAvailableTargetIdentifier):
(Inspector::RemoteInspector::registerTarget):
(Inspector::RemoteInspector::unregisterTarget):
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::updateClientCapabilities):
(Inspector::RemoteInspector::setRemoteInspectorClient):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupCompleted):
(Inspector::RemoteInspector::waitingForAutomaticInspection):
(Inspector::RemoteInspector::clientCapabilitiesDidChange):
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::listingForTarget):
(Inspector::RemoteInspector::updateHasActiveDebugSession):
- inspector/remote/RemoteInspector.h: Add platform ifdefs for cocoa specific parts. Also add TargetListing
typedef to define platform specific types for the listings without more ifdefs.
- inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm: Renamed from Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm.
(Inspector::RemoteTargetInitializeGlobalQueue):
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
(Inspector::RemoteConnectionToTarget::sendMessageToTarget):
(Inspector::RemoteConnectionToTarget::setupRunLoop):
- inspector/remote/cocoa/RemoteInspectorCocoa.mm: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspector.mm.
(Inspector::canAccessWebInspectorMachPort):
(Inspector::RemoteInspector::singleton):
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::pushListingsSoon):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedProxyApplicationSetupMessage):
- inspector/remote/cocoa/RemoteInspectorXPCConnection.h: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h.
- inspector/remote/cocoa/RemoteInspectorXPCConnection.mm: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm.
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Source/WebKit2:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Add PLATFORM(COCOA) to the ifdef.
- 5:12 PM Changeset in webkit [212168] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- 5:09 PM Changeset in webkit [212167] by
-
- 4 edits1 add in trunk
Infinite UI process hang under ensurePositionInformationIsUpToDate
https://bugs.webkit.org/show_bug.cgi?id=168154
<rdar://problem/30428673>
Reviewed by Simon Fraser.
Source/WebKit2:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
If the web process crashes or we're being torn down for another reason,
assume that we aren't ever going to receive any pending async interaction
information update. Otherwise, ensurePositionInformationIsUpToDate can end
up waiting for it forever.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
(recursiveFindHighlightLongPressRecognizer):
(TEST):
Add a somewhat nasty test that does an async interaction information update, but
kills the Web process before it arrives, and then does a sync interaction
information update, which will wait for the oustanding async interaction
information update if we still think it's coming. Before the patch, this
test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
- 4:44 PM Changeset in webkit [212166] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: ContentViewContainer can have redundant back-forward entries after ContentView close
https://bugs.webkit.org/show_bug.cgi?id=168105
Reviewed by Joseph Pecoraro.
- UserInterface/Models/BackForwardEntry.js:
(WebInspector.BackForwardEntry.prototype.isEqual):
Make check for equal ContentView/cookie reusable.
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
Use BackForwardEntry.prototype.isEqual.
(WebInspector.ContentViewContainer.prototype.replaceContentView):
(WebInspector.ContentViewContainer.prototype.closeContentView):
Clean-up the BackForwardEntry list after changes that can cause
identical entries to become adjacent.
(WebInspector.ContentViewContainer.prototype._removeIdenticalAdjacentBackForwardEntries):
Remove consecutive entries with the same ContentView and cookie.
(WebInspector.ContentViewContainer):
(WebInspector.ContentViewContainer.closeAllContentViewsOfPrototype): Deleted.
Drive-by cleanup: removed dead code.
- 4:19 PM Changeset in webkit [212165] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r212139.
https://bugs.webkit.org/show_bug.cgi?id=168152
Caused some assertions (Requested by JoePeck on #webkit).
Reverted changeset:
"Fix misleading comment in RunLoop.h"
https://bugs.webkit.org/show_bug.cgi?id=167832
http://trac.webkit.org/changeset/212139
- 4:12 PM Changeset in webkit [212164] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(WEBGL) build
https://bugs.webkit.org/show_bug.cgi?id=168112
Reviewed by Alex Christensen.
- html/canvas/WebGLRenderingContextBase.h:
- 3:55 PM Changeset in webkit [212163] by
-
- 4 edits in trunk/Source/WebKit2
Add mediaStreamEnabled property to WKPreferences for Cocoa.
https://bugs.webkit.org/show_bug.cgi?id=168080
Patch by Andrew Gold <agold@apple.com> on 2017-02-10
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Sets the pageConfiguration's mediaStreamEnabled preference value.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]): Copies the mediaStreamEnabled property.
(-[WKWebViewConfiguration _mediaStreamEnabled]): Gets the mediaStreamEnabled property.
(-[WKWebViewConfiguration _setMediaStreamEnabled:]): Sets the mediaStreamEnabled property.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 3:53 PM Changeset in webkit [212162] by
-
- 5 edits in trunk
[Fetch API] fetch fails when undefined is passed as headers
https://bugs.webkit.org/show_bug.cgi?id=168043
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-10
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/request/request-headers-expected.txt:
- web-platform-tests/fetch/api/request/request-headers.html:
Source/WebCore:
Covered by updated test.
- Modules/fetch/FetchInternals.js:
(fillFetchHeaders): Exit early in case of undefined headers, since it is an optional parameter.
- 3:51 PM Changeset in webkit [212161] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=168113
Reviewed by Alex Christensen.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- 3:49 PM Changeset in webkit [212160] by
-
- 3 edits in trunk/Source/WebKit2
WebProcess: remove unused m_inDidClose
https://bugs.webkit.org/show_bug.cgi?id=168121
Patch by Olivier Blin <Olivier Blin> on 2017-02-10
Reviewed by Alex Christensen.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
- WebProcess/WebProcess.h:
m_inDidClose has been unused since r83774
- 3:48 PM Changeset in webkit [212159] by
-
- 1 copy in tags/Safari-603.1.26
Tag Safari-603.1.26.
- 3:47 PM Changeset in webkit [212158] by
-
- 2 edits in trunk/Source/WebCore
Update features.json for Performance Timing APIs
https://bugs.webkit.org/show_bug.cgi?id=168148
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-10
Reviewed by Simon Fraser.
- features.json:
- 3:47 PM Changeset in webkit [212157] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly
https://bugs.webkit.org/show_bug.cgi?id=168141
Reviewed by Joseph Pecoraro.
The generated code erroneously uses the ObjC variable name as the payload key,
rather than the raw type member name. For example, 'identifier' would be used instead of 'id'.
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_payload):
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
Rebaseline an affected test.
- 3:41 PM Changeset in webkit [212156] by
-
- 3 edits in trunk/Source/WebCore
Try to fix the iOS and Windows builds.
- platform/ios/DragImageIOS.mm:
(WebCore::deleteDragImage):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::setDragImage):
- 3:24 PM UpdatingBugzilla edited by
- (diff)
- 3:14 PM Changeset in webkit [212155] by
-
- 2 edits in trunk
Add basic debugging macros for CMake
https://bugs.webkit.org/show_bug.cgi?id=161538
Reviewed by Michael Catanzaro.
It's useful to be able to dump the state of everything when debugging
CMake build problems, especially when they happen on EWS (but not locally).
Start with macros for:
- dumping out all CMake variables
- dumping all executed commands (by turning off pretty-printing)
- Source/cmake/WebKitMacros.cmake:
- 3:09 PM Changeset in webkit [212154] by
-
- 11 edits in trunk/Source/WebCore
Add a DragImage class that wraps a DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=168131
Reviewed by Beth Dakin.
This allows us to get rid of the explicit deleteDragImage calls and will make additional cleanup of the
various drag code paths possible. No functionality change.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::updateDragImage):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
- page/DragController.h:
- platform/DragImage.cpp:
(WebCore::DragImage::DragImage):
(WebCore::DragImage::operator=):
(WebCore::DragImage::~DragImage):
- platform/DragImage.h:
- platform/Pasteboard.h:
- platform/StaticPasteboard.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage):
- 3:02 PM Changeset in webkit [212153] by
-
- 8 edits10 adds in trunk
Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
https://bugs.webkit.org/show_bug.cgi?id=168127
rdar://problem/30467120
Reviewed by Tim Horton.
Source/WebCore:
Replace the special-case, but wrong, GraphicsLayer traversal in setIsInWindowIncludingDescendants()
which forgot to hit masks and replica layers with a generic traverse() function, which
is then used for setting 'inWindow' as well as resetting tracked repaints.
Tests: compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/tiled-reflection-inwindow.html
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::layerWithDocumentOverlays):
(WebCore::PageOverlayController::layerWithViewOverlays):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setIsInWindow):
(WebCore::GraphicsLayer::setReplicatedByLayer):
(WebCore::GraphicsLayer::traverse):
(WebCore::GraphicsLayer::setIsInWindowIncludingDescendants): Deleted.
- platform/graphics/GraphicsLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
(WebCore::resetTrackedRepaintRectsRecursive): Deleted.
Tools:
Reparent the web view before we try to fetch it via:
[[[window contentView] subviews] objectAtIndex:0];
which would throw an exception if the test unparented it.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
(runTest):
LayoutTests:
- compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
- compositing/tiling/tiled-mask-inwindow.html: Added.
- compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
- compositing/tiling/tiled-reflection-inwindow.html: Added.
- platform/ios-simulator-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
- platform/ios-simulator-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
- platform/ios-simulator-wk2/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
- platform/ios-simulator-wk2/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
- platform/mac-wk1/compositing/tiling/tiled-mask-inwindow-expected.txt: Added.
- platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expected.txt: Added.
- 2:40 PM Changeset in webkit [212152] by
-
- 3 edits2 adds in trunk
Tiled layers are sometimes left with some tiles when outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=168104
Source/WebCore:
rdar://problem/30459055
Reviewed by Tim Horton.
When the coverage rect of a TiledBacking goes from a non-empty rect to an empty rect, we
shouldn't just early return from TileGrid::revalidateTiles(), otherwise we are left with some
tiles. Run through the function as normal, which will remove all the tiles for an empty coverage rect.
Minor logging changes.
Test: tiled-drawing/tile-coverage-iframe-to-zero-coverage.html
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::revalidateTiles):
LayoutTests:
Reviewed by Tim Horton.
- tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: Added.
- tiled-drawing/tile-coverage-iframe-to-zero-coverage.html: Added.
- 2:36 PM Changeset in webkit [212151] by
-
- 4 edits1 add in trunk
Mail hangs when removing multiple rows from large table.
https://bugs.webkit.org/show_bug.cgi?id=168103
<rdar://problem/30090186>
Reviewed by Ryosuke Niwa.
PerformanceTests:
- DOM/large-table-edit.html: Added.
Source/WebCore:
DeleteSelectionCommand::removeNode doesn't actually destroy table structure items,
but instead it removes their content. In order to be able to continue editing the table after
the delete, we need to ensure that its cells' width and height are > 0. Currently we issue layout on
each table item recursively.
This patch delays the layout until after we've finished with the entire subtree delete (10x progression).
Performance test added.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::insertBlockPlaceholderForTableCellIfNeeded):
(WebCore::DeleteSelectionCommand::removeNodeUpdatingStates):
(WebCore::shouldRemoveContentOnly):
(WebCore::DeleteSelectionCommand::removeNode):
- editing/DeleteSelectionCommand.h:
- 2:28 PM Changeset in webkit [212150] by
-
- 49 edits in trunk
[Resource Timing] Enable Resource Timing by default in Tests
https://bugs.webkit.org/show_bug.cgi?id=168145
Reviewed by Ryosuke Niwa.
Source/WebCore:
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setResourceTimingEnabled): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
No longer needed for tests.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resourceTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
- fast/dom/Window/window-properties-performance-resource-timing.html:
- http/tests/misc/resource-timing-resolution.html:
- http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
- http/tests/performance/performance-resource-timing-cached-entries.html:
- http/tests/performance/performance-resource-timing-entries-iterable.html:
- http/tests/performance/performance-resource-timing-entries.html:
- http/tests/performance/performance-resource-timing-initiator-css.html:
- http/tests/performance/performance-resource-timing-initiator-no-override.html:
- http/tests/performance/performance-resource-timing-xhr-single-entry.html:
- http/tests/preload/dynamic_remove_preload_href-expected.txt:
- http/tests/preload/dynamic_remove_preload_href.html:
- http/tests/preload/dynamic_removing_preload.html:
- http/tests/preload/not_evicting_preload_at_onload.html:
- http/tests/preload/single_download_preload-expected.txt:
- http/tests/preload/single_download_preload.html:
- resources/testharnessreport.js:
Eliminate the internals setResourceTimingEnabled way to toggle a runtime feature.
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
Update results when ResourceTiming is enabled.
- 2:16 PM Changeset in webkit [212149] by
-
- 7 edits in trunk/Source
[Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate
https://bugs.webkit.org/show_bug.cgi?id=168097
Reviewed by Tim Horton.
Source/WebCore:
Added a userTriggered argument to FrameSelection::setSelectedRange so that WebKit2 can
indicate that changes should be agreed to by the delegate.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectedRange): If the change is user-triggered, check with
shouldChangeSelection.
- editing/FrameSelection.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Declared new delegate method.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Dispatch new delegate
method.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture): Pass UserTriggered whan calling
WebCore::Frame::Selection::setSelectedRange, so that the delegate is consulted.
(WebKit::WebPage::changeBlockSelection): Ditto.
(WebKit::WebPage::updateSelectionWithTouches): Ditto.
(WebKit::WebPage::selectWithTwoTouches): Ditto.
(WebKit::WebPage::extendSelection): Ditto.
(WebKit::WebPage::selectWordBackward): Ditto,
(WebKit::WebPage::moveSelectionByOffset): Ditto.
(WebKit::WebPage::selectPositionAtPoint): Ditto.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.
- 1:58 PM Changeset in webkit [212148] by
-
- 7 edits2 deletes in trunk
Removing LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=165927
Reviewed by Daniel Bates.
Part 2
LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
simulators through simctl (iOS 10 and later), use this functionality instead.
Source/WebCore:
- platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isDumpRenderTree): Update comment to reflect removal of LayoutTestRelay.
Tools:
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
Added a FIXME that we will need to implement similar archiving machinery once we build
ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
- BuildSlaveSupport/kill-old-processes:
(main): Remove LayoutTestRelay from list of processes.
- LayoutTestRelay: Removed LayoutTestRelay.
- Makefile:
- Scripts/build-layouttestrelay: Removed.
- Scripts/build-webkit: Removed LayoutTestRelay references.
- 1:51 PM Changeset in webkit [212147] by
-
- 6 edits2 adds in trunk/LayoutTests
Update LayoutTests/resources/testharness.js
https://bugs.webkit.org/show_bug.cgi?id=168100
Reviewed by Youenn Fablet.
Update LayoutTests/resources/testharness.js to match the web-platform-tests
one landed in r211930.
- media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt:
- media/track/w3c/interfaces/TextTrack/language-expected.txt:
- resources/testharness.js:
(SharedWorkerTestEnvironment):
(ServiceWorkerTestEnvironment):
(create_test_environment):
(promise_test):
(EventWatcher):
(is_node):
(format_value):
- streams/shadowing-Promise-expected.txt:
- streams/shadowing-Promise.html:
- streams/streams-public-array-api-expected.txt: Added.
- streams/streams-public-array-api.html: Added.
- 1:43 PM UpdatingBugzilla edited by
- (diff)
- 1:34 PM Changeset in webkit [212146] by
-
- 3 edits in trunk/Source/JavaScriptCore
StructureStubInfo::considerCaching() should write barrier its owner CodeBlock when buffering a new Structure.
https://bugs.webkit.org/show_bug.cgi?id=168137
<rdar://problem/28656664>
Reviewed by Filip Pizlo.
If we're adding a new structure to StructureStubInfo's bufferedStructures, we
should write barrier the StubInfo's owner CodeBlock because that structure may be
collected during the next GC. Write barrier-ing the owner CodeBlock ensures that
CodeBlock::finalizeBaselineJITInlineCaches() is called on it during the GC,
which, in turn, gives the StructureStubInfo the opportunity to filter out the
dead structure.
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::considerCaching):
- jit/JITOperations.cpp:
- 1:31 PM Changeset in webkit [212145] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
Fix iOS libwebrtc build after r212127
https://bugs.webkit.org/show_bug.cgi?id=168134
- Configurations/libwebrtc.xcconfig:
- libwebrtc.xcodeproj/project.pbxproj:
I got a little carried away removing ObjC sources.
We still need RTCLogging.mm and RTCUIApplication.mm on iOS.
Also sorted the project file.
- 1:29 PM Changeset in webkit [212144] by
-
- 8 edits1 add in trunk/Source/WebCore
[WebRTC] Implement Outgoing libwebrtc audio source support
https://bugs.webkit.org/show_bug.cgi?id=168118
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-10
Reviewed by Eric Carlson.
No new automated tests as we need the audio rendering to work to test the whole loop.
Using an AudioSampleDataSource to convert the captured data to libwebrtc expected format.
Capturing and pushing data happens in the capture thread.
Pulling of converted data happens in libwebrtc thread.
Introducing LibWebRTCAudioFormat.h to centralize libwbebrtc expected audio format.
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/WebAudioBufferList.cpp:
(WebCore::WebAudioBufferList::WebAudioBufferList): Missing initialization leads to assertion failure.
- platform/audio/mac/AudioSampleBufferList.cpp:
(WebCore::AudioSampleBufferList::copyFrom): In case of interleaved channels, there is one buffer but two channels.
- platform/audio/mac/AudioSampleDataSource.cpp:
(WebCore::AudioSampleDataSource::pushSamples):
(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):
- platform/audio/mac/AudioSampleDataSource.h:
- platform/mediastream/libwebrtc/LibWebRTCAudioFormat.h: Added.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::libwebrtcAudioFormat):
(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):
- platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
- 1:24 PM Changeset in webkit [212143] by
-
- 2 edits in trunk/Source/WebKit/mac
cleanup WebLocalizableStrings.
https://bugs.webkit.org/show_bug.cgi?id=168078
Reviewed by Alexey Proskuryakov.
- Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle
as it's for each framework's own consumption, and never needs to be exported.
- 1:17 PM Changeset in webkit [212142] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r211829): Web Inspector: Elements tab is blank when added after page load
https://bugs.webkit.org/show_bug.cgi?id=168142
Reviewed by Brian Burg.
The Elements tab can be shown in two ways: by adding the Elements tab
from the "New Tab" tab, or via Inspect Element. In both cases we should
be checking that the ContentView exists, and create it if needed.
- UserInterface/Views/ElementsTabContentView.js:
(WebInspector.ElementsTabContentView.prototype.showRepresentedObject):
(WebInspector.ElementsTabContentView.prototype.shown):
- 1:15 PM Changeset in webkit [212141] by
-
- 2 edits in trunk/LayoutTests
Skip some very slow WebCryptoAPI tests.
Unreviewed test gardening.
- 1:15 PM Changeset in webkit [212140] by
-
- 4 edits in trunk/Source/WebCore
HTMLConstructionSiteTask::Insert should never be called on a node with a parent
https://bugs.webkit.org/show_bug.cgi?id=168099
Reviewed by Sam Weinig.
insertAlreadyParsedChild always use HTMLConstructionSiteTask::InsertAlreadyParsedChild instead
of using HTMLConstructionSiteTask::Insert when fostering a child.
Also combine the step to take all children and re-parenting into a single task instead of
separately issuing TakeAllChildren and Reparent tasks.
No new tests since this is a refactoring.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::insert): Now asserts that the child node never have a parent.
(WebCore::executeInsertAlreadyParsedChildTask): Moved the code to remove the parent here.
(WebCore::executeTakeAllChildrenAndReparentTask): Renamed from executeTakeAllChildrenTask
now that this function also does the reparenting.
(WebCore::executeTask):
(WebCore::HTMLConstructionSite::reparent): Removed the variant only used with takeAllChildren.
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild): Always use InsertAlreadyParsedChild
instead of calling fosterParent which uses Insert when fostering parents.
(WebCore::HTMLConstructionSite::takeAllChildrenAndReparent): Renamed from takeAllChildren.
- html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSiteTask:Operation):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 1:08 PM Changeset in webkit [212139] by
-
- 3 edits in trunk/Source/WTF
Fix misleading comment in RunLoop.h
https://bugs.webkit.org/show_bug.cgi?id=167832
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-10
Reviewed by Sam Weinig.
- wtf/RunLoop.h:
Mac initialization used to force using CFRunLoopGetMain(). Now however it just
uses RunLoop::current which uses CFRunLoopGetCurrent(). So this comment that
it can be done on any thread is misleading and can lead to incorrect behavior
if it is actually done on a non-main thread on Mac.
- 12:59 PM Changeset in webkit [212138] by
-
- 3 edits1 delete in trunk/LayoutTests
[WebCrypto] Remove imported/w3c/WebCryptoAPI tests
https://bugs.webkit.org/show_bug.cgi?id=168064
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- WebCryptoAPI/OWNERS: Removed.
- WebCryptoAPI/README.md: Removed.
- WebCryptoAPI/WebCryptoAPI.idl: Removed.
- WebCryptoAPI/digest/digest.js: Removed.
- WebCryptoAPI/digest/digest.worker.js: Removed.
- WebCryptoAPI/digest/test_digest-expected.txt: Removed.
- WebCryptoAPI/digest/test_digest.html: Removed.
- WebCryptoAPI/digest/w3c-import.log: Removed.
- WebCryptoAPI/encrypt_decrypt/aes.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_cbc_vectors.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_ctr_vectors.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.js: Removed.
- WebCryptoAPI/encrypt_decrypt/aes_gcm_vectors.js: Removed.
- WebCryptoAPI/encrypt_decrypt/rsa.js: Removed.
- WebCryptoAPI/encrypt_decrypt/rsa.worker.js: Removed.
- WebCryptoAPI/encrypt_decrypt/rsa_vectors.js: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_cbc-expected.txt: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_cbc.html: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_ctr-expected.txt: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_ctr.html: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt: Removed.
- WebCryptoAPI/encrypt_decrypt/test_aes_gcm.html: Removed.
- WebCryptoAPI/encrypt_decrypt/test_rsa_oaep-expected.txt: Removed.
- WebCryptoAPI/encrypt_decrypt/test_rsa_oaep.html: Removed.
- WebCryptoAPI/encrypt_decrypt/w3c-import.log: Removed.
- WebCryptoAPI/generateKey/failures.js: Removed.
- WebCryptoAPI/generateKey/failures.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_AES-CBC.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_AES-CTR.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_AES-GCM.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_AES-KW.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_ECDH.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_ECDSA.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_HMAC.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_RSA-PSS.worker.js: Removed.
- WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.js: Removed.
- WebCryptoAPI/generateKey/successes.js: Removed.
- WebCryptoAPI/generateKey/successes.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_AES-CBC.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_AES-CTR.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_AES-GCM.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_AES-KW.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_ECDH.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_ECDSA.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_HMAC.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_RSA-PSS.worker.js: Removed.
- WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.js: Removed.
- WebCryptoAPI/generateKey/test_aes-cbc-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_aes-cbc.html: Removed.
- WebCryptoAPI/generateKey/test_aes-ctr-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_aes-ctr.html: Removed.
- WebCryptoAPI/generateKey/test_failures-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures.html: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-CBC-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-CBC.html: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-CTR-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-CTR.html: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-GCM.html: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-KW-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_AES-KW.html: Removed.
- WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_ECDH.html: Removed.
- WebCryptoAPI/generateKey/test_failures_ECDSA-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_ECDSA.html: Removed.
- WebCryptoAPI/generateKey/test_failures_HMAC-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_HMAC.html: Removed.
- WebCryptoAPI/generateKey/test_failures_RSA-OAEP-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html: Removed.
- WebCryptoAPI/generateKey/test_failures_RSA-PSS-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_RSA-PSS.html: Removed.
- WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5.html: Removed.
- WebCryptoAPI/generateKey/test_successes-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes.html: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-CBC-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-CBC.html: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-CTR-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-CTR.html: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-GCM.html: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-KW-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_AES-KW.html: Removed.
- WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_ECDH.html: Removed.
- WebCryptoAPI/generateKey/test_successes_ECDSA-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_ECDSA.html: Removed.
- WebCryptoAPI/generateKey/test_successes_HMAC-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_HMAC.html: Removed.
- WebCryptoAPI/generateKey/test_successes_RSA-OAEP-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_RSA-OAEP.html: Removed.
- WebCryptoAPI/generateKey/test_successes_RSA-PSS-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_RSA-PSS.html: Removed.
- WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5-expected.txt: Removed.
- WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.html: Removed.
- WebCryptoAPI/generateKey/w3c-import.log: Removed.
- WebCryptoAPI/getRandomValues.js: Removed.
- WebCryptoAPI/getRandomValues.worker.js: Removed.
- WebCryptoAPI/idlharness-expected.txt: Removed.
- WebCryptoAPI/idlharness.html: Removed.
- WebCryptoAPI/idlharness.worker.js: Removed.
- WebCryptoAPI/test_getRandomValues-expected.txt: Removed.
- WebCryptoAPI/test_getRandomValues.html: Removed.
- WebCryptoAPI/tools/generate.py: Removed.
- WebCryptoAPI/tools/w3c-import.log: Removed.
- WebCryptoAPI/util/helpers.js: Removed.
- WebCryptoAPI/util/w3c-import.log: Removed.
- WebCryptoAPI/w3c-import.log: Removed.
LayoutTests:
Remove test expectations of imported/w3c/WebCryptoAPI tests.
- 12:51 PM Changeset in webkit [212137] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove platform expectations without tests
https://bugs.webkit.org/show_bug.cgi?id=168139
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-10
Reviewed by Sam Weinig.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Removed.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Removed.
- 12:45 PM Changeset in webkit [212136] by
-
- 2 edits in trunk/LayoutTests
fast/forms/formsubmission-appendFormData-crash.html times out on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=168133
Reviewed by Brent Fulgham.
Call testRunner.notifyDone() synchronously instead of doing it in a
setTimeout(). The test no longer times out on WK1 and still reproduces
the original bug.
- fast/forms/formsubmission-appendFormData-crash.html:
- 12:39 PM Changeset in webkit [212135] by
-
- 2 edits in trunk/Tools
[WebCrypto] Add WebCryptoAPI to watchlist
https://bugs.webkit.org/show_bug.cgi?id=168138
Reviewed by Youenn Fablet.
- Scripts/webkitpy/common/config/watchlist:
- 12:38 PM Changeset in webkit [212134] by
-
- 13 edits in trunk
Replace all WebKit Library Version checks in WK2 with SDK version checks.
https://bugs.webkit.org/show_bug.cgi?id=168124
Reviewed by Geoffrey Garen.
Source/WebKit2:
This change gets rid of WebKit Library Version checks and replaces them with SDK version checks.
To allow our tools to still be able to test new behaviors even when built against older SDKs,
it also opts them into an SPI default to have "linkedOnOrAfter()" always return true.
- Shared/Cocoa/CompletionHandlerCallChecker.mm:
(WebKit::shouldThrowExceptionForDuplicateCompletionHandlerCall):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
- UIProcess/Cocoa/VersionChecks.h:
(WebKit::linkedOnOrAfter): Deleted.
- UIProcess/Cocoa/VersionChecks.mm:
(WebKit::linkedOnOrAfter):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::isNetworkCacheEnabled):
Tools:
For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
- MiniBrowser/mac/main.m:
(main):
- MobileMiniBrowser/MobileMiniBrowser/main.m:
(main):
- TestWebKitAPI/ios/mainIOS.mm:
(main):
- TestWebKitAPI/mac/mainMac.mm:
(main):
- WebKitTestRunner/ios/mainIOS.mm:
(main):
- WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):
- 12:35 PM Changeset in webkit [212133] by
-
- 21 edits in branches/safari-603-branch
Merge r212131. rdar://problem/30271744
- 12:34 PM Changeset in webkit [212132] by
-
- 2 edits in trunk/LayoutTests
LayoutTest workers/sab/postMessage-clones.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168129
Unreviewed, make this test more deterministic.
- workers/sab/postMessage-clones.html:
- 12:26 PM Changeset in webkit [212131] by
-
- 21 edits in trunk
[CSS Parser] Make intercap property values serialize correctly
https://bugs.webkit.org/show_bug.cgi?id=168073
Reviewed by Zalan Bujtas.
Source/WebCore:
Fix CSS value keywords to preserve case when the value contains capital
letters. Examples include optimizeSpeed, translateX, scaleY, etc.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
- css/MediaQueryEvaluator.cpp:
(WebCore::colorGamutEvaluate):
- css/SVGCSSValueKeywords.in:
- css/TransformFunctions.cpp:
(WebCore::transformOperationType):
(WebCore::transformsForValue):
- css/makevalues.pl:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::parseTransformTranslateArguments):
(WebCore::parseSimpleTransformValue):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTransformValue):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseColorFunctionParameters):
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/image-rendering-parsing-expected.txt:
- fast/css/parsing-text-rendering-expected.txt:
- fast/css/resources/parsing-text-rendering.js:
- fast/css/script-tests/image-rendering-parsing.js:
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/script-tests/shape-rendering-parsing.js:
- svg/css/shape-rendering-parsing-expected.txt:
- transforms/2d/transform-value-types-expected.txt:
- transforms/2d/transform-value-types.html:
- 11:52 AM Changeset in webkit [212130] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Fix iOS libwebrtc build after r212127
https://bugs.webkit.org/show_bug.cgi?id=168134
- libwebrtc.xcodeproj/project.pbxproj:
I got a little carried away removing -fobjc-arc. These files need it.
It was originally added in r211902 and these files are in the
EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] list in libwebrtc.xcconfig
so adding this flag won't break the 32-bit El Capitan build.
- 11:49 AM Changeset in webkit [212129] by
-
- 2 edits in trunk/PerformanceTests
Beef up the ARES-6 explainer text
https://bugs.webkit.org/show_bug.cgi?id=167867
Reviewed by Saam Barati.
Added appropriate links.
Added text that explains the subscores.
- ARES-6/index.html:
- 11:33 AM UpdatingBugzilla edited by
- (diff)
- 11:26 AM Changeset in webkit [212128] by
-
- 2 edits in trunk/Source/WebKit/mac
WebResourceLoadDelegatePrivate.h cannot be imported standalone
https://bugs.webkit.org/show_bug.cgi?id=168096
Reviewed by Alexey Proskuryakov.
- WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger.
- 11:16 AM Changeset in webkit [212127] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Remove unnecessary automatic reference counting in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=168134
Reviewed by Youenn Fablet.
- libwebrtc.xcodeproj/project.pbxproj:
- 11:03 AM Changeset in webkit [212126] by
-
- 3 edits14 adds in trunk/Source/ThirdParty/libwebrtc
[WebRTC] Activate libwebrtc G711/G722 audio codecs
https://bugs.webkit.org/show_bug.cgi?id=168123
Patch by Youenn Fablet <youennf@gmail.com> on 2017-02-10
Reviewed by Alex Christensen.
Adding G711/G722 missing codec files.
Activating use of these in the build system.
- Configurations/libwebrtc.xcconfig:
- Source/webrtc/modules/audio_coding/codecs/g711/g711.c: Added.
(ulaw_to_alaw):
- Source/webrtc/modules/audio_coding/codecs/g711/g711.h: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/g722_decode.c: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/g722_enc_dec.h: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/g722_encode.c: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.c: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/g722_interface.h: Added.
- Source/webrtc/modules/audio_coding/codecs/g722/test/testG722.cc: Added.
- libwebrtc.xcodeproj/project.pbxproj:
- 10:56 AM Changeset in webkit [212125] by
-
- 14 edits4 adds in branches/safari-603-branch
Merge r211910. rdar://problem/30358835
- 10:21 AM Changeset in webkit [212124] by
-
- 5 edits261 adds in trunk/LayoutTests
[WebCrypto] Import imported/w3c/web-platform-tests/WebCryptoAPI tests
https://bugs.webkit.org/show_bug.cgi?id=165723
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/WebCryptoAPI/OWNERS: Added.
- web-platform-tests/WebCryptoAPI/README.md: Added.
- web-platform-tests/WebCryptoAPI/WebCryptoAPI.idl: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.worker.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.worker.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.worker.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.worker.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_ecdh_bits-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_ecdh_bits.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_ecdh_keys-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_ecdh_keys.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2.html: Added.
- web-platform-tests/WebCryptoAPI/derive_bits_keys/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/digest/digest.js: Added.
- web-platform-tests/WebCryptoAPI/digest/digest.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/digest/digest.worker.html: Added.
- web-platform-tests/WebCryptoAPI/digest/digest.worker.js: Added.
- web-platform-tests/WebCryptoAPI/digest/test_digest-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/digest/test_digest.html: Added.
- web-platform-tests/WebCryptoAPI/digest/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.worker.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.worker.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_cbc-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_cbc.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_ctr-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_ctr.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_rsa_oaep-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_rsa_oaep.html: Added.
- web-platform-tests/WebCryptoAPI/encrypt_decrypt/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CBC.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CBC.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CBC.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CTR.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CTR.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CTR.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-KW.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-KW.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_AES-KW.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_HMAC.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_HMAC.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_HMAC.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-OAEP.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CBC.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CBC.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CBC.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CTR.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CTR.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CTR.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-KW.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-KW.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_AES-KW.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDSA.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDSA.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_ECDSA.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_HMAC.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_HMAC.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_HMAC.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.js: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_aes-cbc-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_aes-cbc.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_aes-ctr-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_aes-ctr.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-CBC-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-CBC.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-CTR-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-CTR.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-KW-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-KW.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDSA-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDSA.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_HMAC-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_HMAC.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-OAEP-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-CBC-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-CBC.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-CTR-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-CTR.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-KW-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-KW.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDSA-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDSA.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_HMAC-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_HMAC.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-OAEP-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-OAEP.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.html: Added.
- web-platform-tests/WebCryptoAPI/generateKey/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/getRandomValues.js: Added.
- web-platform-tests/WebCryptoAPI/getRandomValues.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/getRandomValues.worker.html: Added.
- web-platform-tests/WebCryptoAPI/getRandomValues.worker.js: Added.
- web-platform-tests/WebCryptoAPI/idlharness-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/idlharness.html: Added.
- web-platform-tests/WebCryptoAPI/idlharness.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/idlharness.worker.html: Added.
- web-platform-tests/WebCryptoAPI/idlharness.worker.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/ec_importKey.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker.js: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey.html: Added.
- web-platform-tests/WebCryptoAPI/import_export/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.worker.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.worker.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/ecdsa_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/hmac.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/hmac.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/hmac.worker.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/hmac.worker.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/hmac_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss_vectors.js: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_ecdsa-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_ecdsa.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_hmac-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_hmac.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.html: Added.
- web-platform-tests/WebCryptoAPI/sign_verify/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/test_getRandomValues-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/test_getRandomValues.html: Added.
- web-platform-tests/WebCryptoAPI/tools/generate.py: Added.
- web-platform-tests/WebCryptoAPI/tools/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/util/helpers.js: Added.
- web-platform-tests/WebCryptoAPI/util/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.html: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/w3c-import.log: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.js: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.html: Added.
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.js: Added.
LayoutTests:
Skip superset/unsupported tests and mark slow tests as Slow.
- tests-options.json:
- 10:01 AM Changeset in webkit [212123] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/masks/solid-color-masked.html as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=168054
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 9:54 AM Changeset in webkit [212122] by
-
- 3 edits in branches/safari-603-branch/Source/WebCore
Merge r212026. rdar://problem/30096323
2017-02-09 Chris Dumez <Chris Dumez>
Crash under FormSubmission::create()
https://bugs.webkit.org/show_bug.cgi?id=167200
<rdar://problem/30096323>
Reviewed by Darin Adler.
The issue is that FormSubmission::create() was iterating over
form.associatedElements() as was calling Element::appendFormData()
in the loop. HTMLObjectElement::appendFormData() was calling
pluginWidget(PluginLoadingPolicy::Load) which causes a synchronous
layout and can fire events (such as focus event) synchronously.
Firing those events synchronously allows the JS to modify the
form.associatedElements() vector we are currently iterating on.
To avoid this issue, we now call pluginWidget(PluginLoadingPolicy::DoNotLoad)
in HTMLObjectElement::appendFormData() as we are not allowed to fire
synchronous events at this point. I also added a security assertion
in FormSubmission::create() to catch cases where we fire JS events
while iterating over the form associated elements to more easily
notice these things in the future.
Test: fast/forms/formsubmission-appendFormData-crash.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::appendFormData):
- loader/FormSubmission.cpp: (WebCore::FormSubmission::create):
- 9:46 AM Changeset in webkit [212121] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Unreviewed build fix.
- dom/Document.cpp:
(WebCore::Document::adoptNode): isConnected -> inDocument.
- 9:45 AM Changeset in webkit [212120] by
-
- 4 edits2 deletes in branches/safari-603-branch
- 9:44 AM Changeset in webkit [212119] by
-
- 2 edits1 copy in trunk/LayoutTests
Add platform specific expected.txt file for fast/text/mark-matches-overflow-clip.html after r212113.
Unreviewed test gardening.
- fast/text/mark-matches-overflow-clip-expected.txt:
- platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt: Copied from LayoutTests/fast/text/mark-matches-overflow-clip-expected.txt.
- 9:42 AM UpdatingBugzilla edited by
- (diff)
- 9:33 AM Changeset in webkit [212118] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r212026. rdar://problem/30096323
- 9:31 AM Changeset in webkit [212117] by
-
- 3 edits2 adds in branches/safari-603-branch
Merge r211495. rdar://problem/30106362
- 9:29 AM Changeset in webkit [212116] by
-
- 26 edits in trunk/Source
[Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator
https://bugs.webkit.org/show_bug.cgi?id=168019
<rdar://problem/28718990>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
It's useful to have an symbolic value (not a string) for each of the supported platform values.
Generate this once per protocol for the Objective-C bindings. Covered by existing tests.
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator.generate_output):
(ObjCHeaderGenerator._generate_enum_for_platforms):
Create an NS_ENUM for Platform values in Platforms.
- inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:
(ObjCProtocolTypeConversionsHeaderGenerator.generate_output):
(ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_conversion_for_platforms):
Add type conversion/parsing methods for the newly added enum.
- inspector/scripts/codegen/generator.py:
(Generator.stylized_name_for_enum_value):
(Generator.stylized_name_for_enum_value.replaceCallback):
Support arbitrary special-cased substrings in enums, not just all-caps. Add 'IOS' and 'MacOS'.
- inspector/scripts/codegen/models.py:
(Platforms):
Use lower-case string values for platform names, to avoid guesswork.
(Platforms.metaclass):
(Platforms.metaclass.iter):
Make it possible to iterate over Platform instances of Platforms.
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/domain-availability.json-result:
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
- inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Rebaseline results.
Source/WebKit2:
- UIProcess/Automation/Automation.json: Fix the platform values to be lowercase.
- 9:25 AM Changeset in webkit [212115] by
-
- 4 edits in trunk/Source/WebKit2
Web Automation: fail gracefully when a screenshot cannot be encoded as base64
https://bugs.webkit.org/show_bug.cgi?id=168095
<rdar://problem/30297427>
Reviewed by Joseph Pecoraro.
Convert platformGetBase64EncodedPNGData to return a std::optional<String>.
Return nullopt if we can't create a screenshot or convert it to base64.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::didTakeScreenshot):
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):
- 8:50 AM Changeset in webkit [212114] by
-
- 2 edits in trunk/Tools
Fix El Capitan build.
- Scripts/build-webkit:
Don't build libwebrtc anywhere for now.
- 6:32 AM Changeset in webkit [212113] by
-
- 16 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several fast/text/ tests.
- fast/text/mark-matches-overflow-clip-expected.txt:
- platform/gtk/fast/text/crash-complex-text-surrogate-expected.txt:
- platform/gtk/fast/text/hyphenate-first-word-expected.png:
- platform/gtk/fast/text/hyphenate-first-word-expected.txt:
- platform/gtk/fast/text/hyphenate-limit-lines-expected.png:
- platform/gtk/fast/text/hyphenate-limit-lines-expected.txt:
- platform/gtk/fast/text/hyphens-expected.png:
- platform/gtk/fast/text/hyphens-expected.txt:
- platform/gtk/fast/text/international/text-combine-image-test-expected.png:
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- platform/gtk/fast/text/international/thai-line-breaks-expected.png:
- platform/gtk/fast/text/international/thai-line-breaks-expected.txt:
- platform/gtk/fast/text/orientation-sideways-expected.png:
- platform/gtk/fast/text/orientation-sideways-expected.txt:
- platform/gtk/fast/text/whitespace/023-expected.txt:
- 5:57 AM Changeset in webkit [212112] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline fast/table/ tests.
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- 2:51 AM Changeset in webkit [212111] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Update expectations of CSS shapes duplicated tests.
- platform/gtk/TestExpectations:
- 2:40 AM Changeset in webkit [212110] by
-
- 11 edits2 adds in trunk
[EME] Implement MediaKeySession::load()
https://bugs.webkit.org/show_bug.cgi?id=168041
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement the MediaKeySession::load() method, tracing the steps as they
are defined in the EME specification. The only exception is step 8.3,
which requires additional facility that tracks currently open sessions
and provides information whether for a given session ID there's already
a MediaKeySession that's not yet been closed.
Session ID sanitization is done through the CDM::sanitizeSessionId()
method, which relays the task to the CDMPrivate implementation.
The CDMInstance::loadSession() virtual method is called with the session
type, sanitized ID, the Document's origin (in string form) and the
callback that's invoked upon completion of the task. The callback
checks whether the operation was successful, or examines the reason for
the load failure in case it wasn't, rejecting the promise in the latter
case either immediately or in the following task at the latest.
When the load was successful, the optional known keys, expiration time
and message are handled appropriately, and the promise is resolved.
MockCDM::sanitizeSessionId() implementation only treats
'valid-loaded-session' as a valid session ID.
MockCDMInstance::loadSession() implementation is kept slim for now, only
providing the 'license-renewal' message when invoking the passed-in
callback. Known keys and expiration time will also be tested once the
relevant MediaKeySession algorithms are implemented.
Test: media/encrypted-media/mock-MediaKeySession-load.html
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::sanitizeSessionId):
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMInstance.h:
- Modules/encryptedmedia/CDMPrivate.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::load):
- testing/MockCDMFactory.cpp:
(WebCore::MockCDM::sanitizeSessionId):
(WebCore::MockCDMInstance::loadSession):
- testing/MockCDMFactory.h:
LayoutTests:
Add the mock-MediaKeySession-load.html test, testing the basic behavior
of the MediaKeySession::load() implementation. Invalid session IDs and
session types are tested to ensure the returned promise is rejected.
A simplistic test case also tests that for a valid session ID and
session type, the basic MockCDM implementation correctly 'loads' the
specified session and provides the 'license-renewal' message in return.
More tests should be added as the EME implementation advances and the
MockCDM implementations improve to cover additional cases.
- media/encrypted-media/mock-MediaKeySession-load-expected.txt: Added.
- media/encrypted-media/mock-MediaKeySession-load.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 2:31 AM Changeset in webkit [212109] by
-
- 10 edits in trunk
[EME] Implement MediaKeySession::sessionClosed()
https://bugs.webkit.org/show_bug.cgi?id=168039
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement the 'session closed' algorithm for MediaKeySession by
following the specified steps. After this algorithm is run, the
session should be considered closed, which we track via the m_closed
member variable on the class. This is set to true before the promise
that's accessible through the 'closed' attribute is resolved.
Because the algorithm requires the CDM instance to store any record
of key usage when the session's type is 'persistent-usage-record', the
storeRecordOfKeyUsage() virtual method is added to the CDMInstance
interface. MockCDMInstance implementation is left unimplemented for now.
JSMediaKeySession::closed() accessor now has a custom implementation
that creates a deferred promise for that object if there's none yet, and
shares it with the wrapped class through the registerClosedPromise()
method, storing a reference to the promise in the m_closedPromise
member variable, or resolving the promise immediately if the session was
already closed.
Test cases added to media/encrypted-media/mock-MediaKeySession-close.html.
- Modules/encryptedmedia/CDMInstance.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::registerClosedPromise):
(WebCore::MediaKeySession::sessionClosed):
- Modules/encryptedmedia/MediaKeySession.h:
- bindings/js/JSMediaKeySessionCustom.cpp:
(WebCore::JSMediaKeySession::closed):
- testing/MockCDMFactory.cpp:
(WebCore::MockCDMInstance::storeRecordOfKeyUsage):
- testing/MockCDMFactory.h:
LayoutTests:
Enhance the mock-MediaKeySession-close.html test by adding test cases
covering the dispatch of the promise that's accessible through the
'closed' attribute and covering the session closure status, making
sure that various operations properly resolve or reject after the
session object was closed.
- media/encrypted-media/mock-MediaKeySession-close-expected.txt:
- media/encrypted-media/mock-MediaKeySession-close.html:
- 2:28 AM Changeset in webkit [212108] by
-
- 3 edits in trunk/Tools
Move two MiniBrowserBundle settings out of the .pbxproj
https://bugs.webkit.org/show_bug.cgi?id=168106
Reviewed by Tim Horton.
INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
the project file. This removes the project file override.
WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
- MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- 2:22 AM Changeset in webkit [212107] by
-
- 12 edits in trunk
[EME] Implement MediaKeySession::updateKeyStatuses(), MediaKeyStatusMap
https://bugs.webkit.org/show_bug.cgi?id=167888
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement MediaKeySession::updateKeyStatuses(), transforming the passed-in
KeyStatusVector into a Vector mapping the key IDs to MediaKeyStatus values.
A keystatuseschange event is fired on the MediaKeySession object afterwards.
The queueing of the task that runs the 'attemp to resume playback' on the
related HTMLMediaElement objects isn't done yet since that algorithm isn't
implemented yet.
The statuses Vector is stored on the MediaKeySession object. That Vector is
then exposed through the MediaKeyStatusMap object, each such object being
unique to one MediaKeySession object. The implementation of MediaKeyStatusMap
thus keeps a reference to the session object as long as that object is alive,
and queries the MediaKeySession::statuses() getter to access the Vector that
contains status information for all the key IDs.
MediaKeyStatusMap::Iterator object keeps a reference to the MediaKeyStatusMap
object and accesses the statuses by indexing into the status Vector of the
related MediaKeySession object.
CDMInstance::updateLicense() now accepts the session ID string as the first
argument, making it possible to specify which session should be updated.
MockCDMFactory::keysForSessionWithID() returns an optional reference to the
Vector value in the session map that lists all the key IDs that are being
stored for that session.
MockCDMInstance::updateLicense() now detects the 'keys-changed' entry in the
passed-in response data, and upon detecting that constructs a KeyStatusVector
object containing all the keys for that session. KeyStatus::Usable is returned
for each object at the moment, but this should be adjustable in the future
through additional parameters passed through the response data. The Vector
object is then passed to the callback and is then passed to the 'update key
statuses' algorithm in MediaKeySession.
Covered by a test case in media/encrypted-media/mock-MediaKeySession-update.html.
- Modules/encryptedmedia/CDMInstance.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::~MediaKeySession):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::updateKeyStatuses):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeyStatusMap.cpp:
(WebCore::MediaKeyStatusMap::MediaKeyStatusMap):
(WebCore::MediaKeyStatusMap::detachSession):
(WebCore::MediaKeyStatusMap::size):
(WebCore::keyIdsMatch):
(WebCore::MediaKeyStatusMap::has):
(WebCore::MediaKeyStatusMap::get):
(WebCore::MediaKeyStatusMap::Iterator::Iterator):
(WebCore::MediaKeyStatusMap::Iterator::next):
- Modules/encryptedmedia/MediaKeyStatusMap.h:
(WebCore::MediaKeyStatusMap::create):
- Modules/encryptedmedia/MediaKeyStatusMap.idl:
- testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::keysForSessionWithID):
(WebCore::MockCDMInstance::updateLicense):
- testing/MockCDMFactory.h:
LayoutTests:
Add another test case to the mock-MediaKeySession-update.html test that
ensures the keystatuseschange event is fired on the MediaKeySession object
and that the status of the keys is properly reported through the
MediaKeyStatusMap object associated with this MediaKeySession.
- media/encrypted-media/mock-MediaKeySession-update-expected.txt:
- media/encrypted-media/mock-MediaKeySession-update.html:
- 1:48 AM Changeset in webkit [212106] by
-
- 1 copy in releases/WebKitGTK/webkit-2.14.4
WebKitGTK+ 2.14.4
- 1:46 AM Changeset in webkit [212105] by
-
- 4 edits in releases/WebKitGTK/webkit-2.14
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.14.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.14.4.
- 1:17 AM Changeset in webkit [212104] by
-
- 2 edits in trunk/Tools
Fix 32-and-64-bit build on El Capitan.
- Scripts/build-webkit:
Somebody's building with something like this:
build-webkit ARCHS="i386 x86_64"
We want this to also not build libwebrtc for now.
- 1:11 AM Changeset in webkit [212103] by
-
- 8 edits in branches/safari-603-branch
Merge r211650. rdar://problem/30268004
- 1:11 AM Changeset in webkit [212102] by
-
- 8 edits in branches/safari-603-branch
Merge r211375. rdar://problem/30268004
- 1:11 AM Changeset in webkit [212101] by
-
- 13 edits in branches/safari-603-branch
Roll out r209845. rdar://problem/30114564
- 1:04 AM Changeset in webkit [212100] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Fix ASAN build.
- Source/webrtc/base/sanitizer.h:
SANITIZER_UNUSED3 wasn't defined if we are using address_sanitizer but not memory_sanitizer.
- 12:41 AM Changeset in webkit [212099] by
-
- 2 edits in trunk/Tools
Fix 32-bit build on El Capitan.
- Scripts/build-webkit:
The bot uses ARCHS=i386 instead of --32-bit.
This is a hack, but it should fix the bot until I can do a better fix in the morning.
- 12:33 AM Changeset in webkit [212098] by
-
- 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2
Merge r212097 - Unreviewed. Fix GTK+ build with threaded compositor disabled.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::enterAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow):
- 12:26 AM Changeset in webkit [212097] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ build with threaded compositor disabled.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::enterAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow):
- 12:16 AM Changeset in webkit [212096] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r212029. rdar://problem/30376972
- 12:16 AM Changeset in webkit [212095] by
-
- 6 edits4 adds in branches/safari-603-branch
Merge r212028. rdar://problem/30234133
- 12:16 AM Changeset in webkit [212094] by
-
- 3 edits4 adds in branches/safari-603-branch
Merge r212027. rdar://problem/30145076
- 12:16 AM Changeset in webkit [212093] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r212025. rdar://problem/30076615
- 12:16 AM Changeset in webkit [212092] by
-
- 3 edits2 adds in branches/safari-603-branch
Merge r212024. rdar://problem/30051227
- 12:16 AM Changeset in webkit [212091] by
-
- 3 edits2 adds in branches/safari-603-branch
Merge r212023. rdar://problem/30041640
- 12:16 AM Changeset in webkit [212090] by
-
- 3 edits1 add in branches/safari-603-branch
Merge r212022. rdar://problem/30198083
- 12:16 AM Changeset in webkit [212089] by
-
- 3 edits1 add in branches/safari-603-branch
Merge r212021. rdar://problem/30149432
- 12:16 AM Changeset in webkit [212088] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r212020. rdar://problem/29939864
- 12:15 AM Changeset in webkit [212087] by
-
- 7 edits2 adds in branches/safari-603-branch
Merge r212019. rdar://problem/30128133
- 12:15 AM Changeset in webkit [212086] by
-
- 16 edits2 adds in branches/safari-603-branch
Merge r212015. rdar://problem/30054759
- 12:15 AM Changeset in webkit [212085] by
-
- 3 edits1 add in branches/safari-603-branch
Merge r212009. rdar://problem/29939864
- 12:15 AM Changeset in webkit [212084] by
-
- 3 edits3 adds in branches/safari-603-branch
Merge r211999. rdar://problem/29930443
- 12:12 AM Changeset in webkit [212083] by
-
- 2 edits in trunk/Tools
Fix 32-bit build on El Capitan.
- Scripts/build-webkit:
Don't build i386 libwebrtc.
