Context Navigation

← Previous Period
Next Period →

Timeline

Sep 4, 2017:

9:55 PM Changeset in webkit [221608] by Chris Dumez

6 edits in trunk/Source/WebCore

Use StringView more in DOMFileSystem code
https://bugs.webkit.org/show_bug.cgi?id=176347

Reviewed by Darin Adler.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::evaluatePath):

platform/FileSystem.h:
platform/glib/FileSystemGlib.cpp:

(WebCore::pathByAppendingComponents):

platform/posix/FileSystemPOSIX.cpp:

(WebCore::pathByAppendingComponents):

platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponents):

9:10 PM Changeset in webkit [221607] by sbarati@apple.com

21 edits
1 add in trunk

typeCheckHoistingPhase may emit a CheckStructure on the empty value which leads to a dereference of zero on 64 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=176317

Reviewed by Keith Miller.

JSTests:

stress/dont-crash-when-hoist-check-structure-on-tdz.js: Added.

(Foo):

Source/JavaScriptCore:

It turns out that TypeCheckHoistingPhase may hoist a CheckStructure up to
the SetLocal of a particular value where the value is the empty JSValue.
On 64-bit platforms, the empty value is zero. This means that the empty value
passes a cell check. This will lead to a crash when we dereference null to load
the value's structure. This patch teaches TypeCheckHoistingPhase to be conservative
in the structure checks it hoists. On 64-bit platforms, instead of emitting a
CheckStructure node, we now emit a CheckStructureOrEmpty node. This node allows
the empty value to flow through. If the value isn't empty, it'll perform the normal
structure check that CheckStructure performs. For now, we only emit CheckStructureOrEmpty
on 64-bit platforms since a cell check on 32-bit platforms does not allow the empty
value to flow through.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::convertCheckStructureOrEmptyToCheckStructure):
(JSC::DFG::Node::hasStructureSet):

dfg/DFGNodeType.h:
dfg/DFGObjectAllocationSinkingPhase.cpp:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::SafeToExecuteEdge):
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::SafeToExecuteEdge::maySeeEmptyChild):
(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitStructureCheck):
(JSC::DFG::SpeculativeJIT::compileCheckStructure):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

dfg/DFGValidate.cpp:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckStructureOrEmpty):

8:44 PM Changeset in webkit [221606] by eric.carlson@apple.com

13 edits
1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

dom/Document.h:

Convert debug-only logging to configurable release logging.

html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

html/HTMLMediaElement.h:

Source/WTF:

wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

Tools:

TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LogObserver::level const):

8:39 PM Changeset in webkit [221605] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

[Canvas] Move non-standard functionality/aliases back to CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=176340

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

In r221598 (https://webkit.org/b/176276), the CanvasRenderingContext2D was split out into
separate interfaces to the match the spec and prepare for implementing OffscreenCanvas. While
doing that, related non-standard functionality and aliases were moved as well. In retrospect,
that doesn't really makes sense, as we don't want to add these legacy properties to any new
interfaces that happen to implement/use the broken out interfaces. Since they are specific
to CanvasRenderingContext2D, let's move them back.

html/canvas/CanvasCompositing.idl:
html/canvas/CanvasDrawImage.idl:
html/canvas/CanvasFillStrokeStyles.idl:
html/canvas/CanvasImageData.idl:
html/canvas/CanvasImageSmoothing.idl:
html/canvas/CanvasPathDrawingStyles.idl:
html/canvas/CanvasShadowStyles.idl:
html/canvas/CanvasRenderingContext2D.idl:

Move non-standard operation and attributes back to CanvasRenderingContext2D.idl.

html/canvas/CanvasRenderingContext2D.h:

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stringForCanvasFillRule): Deleted.

Remove unused function.

(WebCore::CanvasRenderingContext2D::setAlpha): Deleted.
(WebCore::CanvasRenderingContext2D::setCompositeOperation): Deleted.

Removed. Instead, the IDL uses [ImplementedAs] to forward to the
underlying setGlobalAlpha/setGlobalCompositeOperation. This reduces
code and makes it clear they are strict aliases.

8:31 PM Changeset in webkit [221604] by yoav@yoav.ws

3 edits in trunk/LayoutTests

[iOS Simulator] http/tests/preload/viewport/meta-viewport-link-headers.php is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=172518

This unflakes the test by downloading a "timer" image and kicking off the timer that runs the
test only once that image was downloaded, while potentially waiting for the preloaded images to arrive,
up to 1 second.
That means that slow test environments would have a longer timer than today, avoiding flakiness.

Reviewed by Youenn Fablet.

http/tests/preload/viewport/meta-viewport-link-headers.php: Add a "timer" image, which load event starts the test.
platform/ios/TestExpectations: Unflake the test in expectations.

8:29 PM Changeset in webkit [221603] by Darin Adler

13 edits in trunk

Fix a few minor problems found while working toward removing unneeded calls to updateStyle
https://bugs.webkit.org/show_bug.cgi?id=176279

Reviewed by Antti Koivisto.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::updateTitleElement): Fix the algorithm so that an SVG title won't
ever become the title when the document element is not an SVG element. We had this wrong
before but we were passing the test because SVGTitleElement::insertedInto had a bug that
hid the problem.
(WebCore::Document::titleElementAdded): Pass a reference instead of a pointer.
(WebCore::Document::titleElementRemoved): Pass a reference instead of nullptr since we
want to know which element is being removed.

dom/Document.h: Update the argument name and type for updateTitleElement.

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto): Call titleElementAdded unconditionally.
The checks to see if the title element is connected to the document and not in the
shadow tree are now handled by the Document class.
(WebCore::HTMLTitleElement::removedFrom): Same for titleElementRemoved.

platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::applySize): Removed incorrect caching of FontCascade
objects; these need to be created each time we draw.
(WebCore::MockRealtimeVideoSource::drawText): Create all the fonts here. Since this is
a mock for testing, there is no real performance concern with doing this.

platform/mock/MockRealtimeVideoSource.h: Removed the FontCascade data members.

rendering/RenderTreeAsText.cpp:

(WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Added. Used below
to update layout more thoroughly.
(WebCore::externalRepresentation): Update layout of all descendant frames, not just
the top level frame.

svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto): Removed bogus firstChild check, bogus isSVGDocument
check, and unneeded isConnected check and call titleElementAdded unconditionally. The checks
are now handled by the Document class.
(WebCore::SVGTitleElement::removedFrom): Same for titleElementRemoved.

testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText const): Added missing updateLayoutIgnorePendingStylesheets,
since dumping the layer tree without first doing a layout will yield stale results.
(WebCore::Internals::layerIDForElement): Added missing updateLayoutIgnorePendingStylesheets,
since using a renderer to check if a layer exists without first doing a layout will yield stale results.
(WebCore::Internals::setElementUsesDisplayListDrawing): Ditto.
(WebCore::Internals::setElementTracksDisplayListReplay): Ditto.
(WebCore::Internals::displayListForElement): Ditto.
(WebCore::Internals::replayDisplayListForElement): Ditto.
(WebCore::Internals::isSelectPopupVisible): Added missing updateLayoutIgnorePendingStylesheets,
since working with the RenderMenuList without first doing a layout will yield stale results.
Also removed unneeded strict handling of null renderer, instead just returning false.
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Removed unnneeded check of
renderer class, since the HTMLPlugInElement::isReplacementObscured already handles that correctly.
(WebCore::Internals::pageOverlayLayerTreeAsText const): Use updateLayoutIgnorePendingStylesheets
instead of the normal updateLayout for consistency with the behavior of the other functions in this
file, and because we need a real answer here.
(WebCore::Internals::scrollSnapOffsets): Ditto. Also rearranged the code so the renderer check is
done after updating the renderer tree.

Tools:

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::setSelectedChild const): Handle null here. The old code instead
would trigger an Objective-C exception unnecessarily.

LayoutTests:

svg/hittest/svg-tooltip.svg: Made this test easier to run outside of WebKitTestRunnner,

by removing some overzealous checks.

8:21 PM Changeset in webkit [221602] by sbarati@apple.com

41 edits in trunk/Source/JavaScriptCore

Support compiling catch in the FTL
https://bugs.webkit.org/show_bug.cgi?id=175396

Reviewed by Filip Pizlo.

This patch implements op_catch in the FTL. It extends the DFG implementation
by supporting multiple entrypoints in DFG-SSA. This patch implements this
by introducing an EntrySwitch node. When converting to SSA, we introduce a new
root block with an EntrySwitch that has the previous DFG entrypoints as its
successors. By convention, we pick the zeroth entry point index to be the
op_enter entrypoint. Like in B3, in DFG-SSA, EntrySwitch just acts like a
switch over the entrypoint index argument. DFG::EntrySwitch in the FTL
simply lowers to B3::EntrySwitch. The EntrySwitch in the root block that
SSAConversion creates can not exit because we would both not know where to exit
to in the program: we would not have valid OSR exit state. This design also
mandates that anything we hoist above EntrySwitch in the new root block
can not exit since they also do not have valid OSR exit state.

This patch also adds a new metadata node named InitializeEntrypointArguments.
InitializeEntrypointArguments is a metadata node that initializes the flush format for
the arguments at a given entrypoint. For a given entrypoint index, this node
tells AI and OSRAvailabilityAnalysis what the flush format for each argument
is. This allows each individual entrypoint to have an independent set of
argument types. Currently, this won't happen in practice because ArgumentPosition
unifies flush formats, but this is an implementation detail we probably want
to modify in the future. SSAConversion will add InitializeEntrypointArguments
to the beginning of each of the original DFG entrypoint blocks.

This patch also adds the ability to specify custom prologue code generators in Air.
This allows the FTL to specify a custom prologue for catch entrypoints that
matches the op_catch OSR entry calling convention that the DFG uses. This way,
the baseline JIT code OSR enters into op_catch the same way both in the DFG
and the FTL. In the future, we can use this same mechanism to perform stack
overflow checks instead of using a patchpoint.

b3/air/AirCode.cpp:

(JSC::B3::Air::Code::isEntrypoint):
(JSC::B3::Air::Code::entrypointIndex):

b3/air/AirCode.h:

(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):

b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGBasicBlock.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCFG.h:

(JSC::DFG::selectCFG):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):
(JSC::DFG::CommonData::finalizeCatchEntrypoints):

dfg/DFGCommonData.h:

(JSC::DFG::CommonData::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::CommonData::appendCatchEntrypoint):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::ensureCPSCFG):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

dfg/DFGGraph.h:

(JSC::DFG::Graph::isEntrypoint):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::shrinkToFit):
(JSC::DFG::JITCode::finalizeOSREntrypoints):

dfg/DFGJITCode.h:

(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex): Deleted.
(JSC::DFG::JITCode::appendCatchEntrypoint): Deleted.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):

dfg/DFGMayExit.cpp:
dfg/DFGNode.h:

(JSC::DFG::Node::isEntrySwitch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::entrySwitchData):
(JSC::DFG::Node::numSuccessors):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::entrypointIndex):

dfg/DFGNodeType.h:
dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareCatchOSREntry):

dfg/DFGOSREntry.h:
dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStaticExecutionCountEstimationPhase.cpp:

(JSC::DFG::StaticExecutionCountEstimationPhase::run):

dfg/DFGValidate.cpp:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileExtractCatchLocal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):
(JSC::FTL::DFG::LowerDFGToB3::compileEntrySwitch):
(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToB3::blessSpeculation):

ftl/FTLOutput.cpp:

(JSC::FTL::Output::entrySwitch):

ftl/FTLOutput.h:
jit/JITOperations.cpp:

8:03 PM Changeset in webkit [221601] by Yusuke Suzuki

23 edits
10 adds in trunk

[DFG][FTL] Efficiently execute number#toString()
https://bugs.webkit.org/show_bug.cgi?id=170007

Reviewed by Keith Miller.

JSTests:

microbenchmarks/number-to-string-strength-reduction.js: Added.

(test):

microbenchmarks/number-to-string-with-radix-10.js: Added.

(test):

microbenchmarks/number-to-string-with-radix-cse.js: Added.

(test):

microbenchmarks/number-to-string-with-radix.js: Added.

(test):

stress/number-to-string-strength-reduction.js: Added.

(shouldBe):
(test):

stress/number-to-string-with-radix-10.js: Added.

(shouldBe):
(test):

stress/number-to-string-with-radix-cse.js: Added.

(shouldBe):
(test):

stress/number-to-string-with-radix-invalid.js: Added.

(shouldThrow):

stress/number-to-string-with-radix-watchpoint.js: Added.

(shouldBe):
(test):
(i.i.1e3.Number.prototype.toString):

stress/number-to-string-with-radix.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

In JS, the natural way to convert number to string with radix is number.toString(radix).
However, our IC only cares about cells. If the base value is a number, it always goes to the slow path.

While extending our IC for number and boolean, the most meaningful use of this IC is calling number.toString(radix).
So, in this patch, we first add a fast path for this in DFG by using watchpoint. We set up a watchpoint for
Number.prototype.toString. And if this watchpoint is kept alive and GetById(base, "toString")'s base should be
speculated as Number, we emit Number related Checks and convert GetById to Number.prototype.toString constant.
It removes costly GetById slow path, and makes it non-clobbering node (JSConstant).

In addition, we add NumberToStringWithValidRadixConstant node. We have NumberToStringWithRadix node, but it may
throw an error if the valid value is incorrect (for example, number.toString(2000)). So its clobbering rule is
conservatively use read(World)/write(Heap). But in reality, number.toString is mostly called with the constant
radix, and we can easily figure out this radix is valid (2 <= radix && radix < 32).
We add a rule to the constant folding phase to convert NumberToStringWithRadix to NumberToStringWithValidRadixConstant.
It ensures that it has valid constant radix. And we relax our clobbering rule for NumberToStringWithValidRadixConstant.

Added microbenchmarks show performance improvement.

baseline patched

number-to-string-with-radix-cse 43.8312+-1.3017 ^{7.4930+-0.5105} definitely 5.8496x faster
number-to-string-with-radix-10 7.2775+-0.5225 ^{2.1906+-0.1864} definitely 3.3222x faster
number-to-string-with-radix 39.7378+-1.4921 ^{16.6137+-0.7776} definitely 2.3919x faster
number-to-string-strength-reduction 94.9667+-2.7157 ^{9.3060+-0.7202} definitely 10.2049x faster

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::isWatchingGlobalObjectWatchpoint):
(JSC::DFG::Graph::isWatchingArrayIteratorProtocolWatchpoint):
(JSC::DFG::Graph::isWatchingNumberToStringWatchpoint):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToNumberToStringWithValidRadixConstant):
(JSC::DFG::Node::hasValidRadixConstant):
(JSC::DFG::Node::validRadixConstant):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructor):
(JSC::DFG::SpeculativeJIT::compileNumberToStringWithValidRadixConstant):
(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnNumber): Deleted.

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::numberToStringWatchpoint):
(JSC::JSGlobalObject::numberProtoToStringFunction const):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::finishCreation):
(JSC::toStringWithRadixInternal):
(JSC::toStringWithRadix):
(JSC::int32ToStringInternal):
(JSC::numberToStringInternal):

runtime/NumberPrototype.h:

6:48 PM Changeset in webkit [221600] by Yusuke Suzuki

13 edits in trunk/Source

Remove OS(SOLARIS) support
https://bugs.webkit.org/show_bug.cgi?id=176341

Reviewed by Sam Weinig.

Source/WebCore:

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

dom/make_names.pl:
inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::platform):

page/Page.h:

Source/WTF:

WebKit project does not have stake holders supporting Solaris right now.
And Solaris + SPARC in 64bit environment does not work well since its
address space includes non-48bit area. It breaks our JSVALUE64 in JSC.
In addition, Solaris a bit complicates our threading implementation
because of its special threading stack.

This patch removes OS(SOLARIS) and COMPILER(SUNCC) support from WebKit.

wtf/Compiler.h:
wtf/InlineASM.h:
wtf/MathExtras.h:

(std::isfinite): Deleted.
(std::signbit): Deleted.
(std::isinf): Deleted.

wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

wtf/Platform.h:
wtf/StackBounds.cpp:
wtf/ThreadingPthreads.cpp:

6:13 PM Changeset in webkit [221599] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

Unreviewed, fixing unused constant for initial buffer size
https://bugs.webkit.org/show_bug.cgi?id=176310

Follow-up patch after r221583. Pointed by darin@.

platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

5:23 PM Changeset in webkit [221598] by weinig@apple.com

39 edits
3 moves
29 adds in trunk

[Canvas] Split CanvasRenderingContext2D.idl into separate IDLs to match current HTML spec
https://bugs.webkit.org/show_bug.cgi?id=176276

Reviewed by Dean Jackson.

Source/WebCore:

Splits CanvasRenderingContext2D.idl out into:

CanvasState
CanvasTransform
CanvasCompositing
CanvasImageSmoothing
CanvasFillStrokeStyles
CanvasShadowStyles
CanvasFilters
CanvasRect
CanvasDrawPath
CanvasUserInterface
CanvasText
CanvasDrawImage
CanvasImageData
CanvasPathDrawingStyles
CanvasTextDrawingStyles

Renames CanvasWindingRule enum to CanvasFillRule, and moves it to its own file so it can be reused by multiple IDLs.
Renames DOMPath to Path2D, which is what it is supposed to be called, and doesn't conflict with any WebCore names.
Converts lineCap, lineJoin, textAlign, textBaseline, direction to use enums, rather than DOMStrings, allowing us to remove a bunch of custom parsing.
Non-standard canvas API was grouped with related functionality in the broken out IDLs and clearly marked as non-standard.
Comments were added for places where we break with the standard, mostly around use of float where we should be using double.

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:

Add new files.

bindings/js/CallTracerTypes.h:
inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):

Update for renames, and use new convertEnumerationToString to
serialize enumerations.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementationContent):
(GenerateEnumerationHeaderContent):

Split string conversion out of convertEnumerationToJS, and into
its own function, convertEnumerationToString, to allow serialization
to string outside of the bindings context, in this case, for the
InspectorCanvas.

(GenerateParametersCheck):

Improve error message to make it clear which operation has the issue
in order to make debugging easier.

html/ImageData.idl:

Re-order constructors to match specification, and add FIXME for incorrect
default argument.

html/TextMetrics.idl:

Add spec'd exposure and spec comments, as well a FIXME to convert the
unrestricted float parameters should be doubles.

html/canvas/CanvasCompositing.idl: Added.
html/canvas/CanvasDirection.h: Added.
html/canvas/CanvasDirection.idl: Added.
html/canvas/CanvasDrawImage.idl: Added.
html/canvas/CanvasDrawPath.idl: Added.
html/canvas/CanvasFillRule.h: Added.
html/canvas/CanvasFillRule.idl: Added.
html/canvas/CanvasFillStrokeStyles.idl: Added.
html/canvas/CanvasFilters.idl: Added.
html/canvas/CanvasImageData.idl: Added.
html/canvas/CanvasImageSmoothing.idl: Added.
html/canvas/CanvasLineCap.h: Added.
html/canvas/CanvasLineCap.idl: Added.
html/canvas/CanvasLineJoin.h: Added.
html/canvas/CanvasLineJoin.idl: Added.
html/canvas/CanvasPathDrawingStyles.idl: Added.
html/canvas/CanvasRect.idl: Added.
html/canvas/CanvasShadowStyles.idl: Added.
html/canvas/CanvasState.idl: Added.
html/canvas/CanvasText.idl: Added.
html/canvas/CanvasTextAlign.h: Added.
html/canvas/CanvasTextAlign.idl: Added.
html/canvas/CanvasTextBaseline.h: Added.
html/canvas/CanvasTextBaseline.idl: Added.
html/canvas/CanvasTextDrawingStyles.idl: Added.
html/canvas/CanvasTransform.idl: Added.
html/canvas/CanvasUserInterface.idl: Added.
html/canvas/ImageSmoothingQuality.h: Added.
html/canvas/ImageSmoothingQuality.idl: Added.

Move CanvasRenderingContext2D.idl content into separate files to
match the specification.

html/canvas/CanvasGradient.idl:
html/canvas/CanvasPath.idl:
html/canvas/CanvasPattern.idl:

Add exposure and FIXMEs on changes need to match the spec.

html/canvas/CanvasRenderingContext2D.cpp:
html/canvas/CanvasRenderingContext2D.h:

Switch to using enums for lineCap, lineJoin, textAlign, textBaseline, and direction.
Rather than using the parsing / stringifying functions from GraphicsTypes, add simple
switch based to/from converters to convert to/from the canvas type to the platform
type. Also update for rename of DOMPath -> Path2D and WindingRule -> CanvasFillRule.

Unfortunately, not all custom parsing could be removed. To support the legacy functions
setLineCap and setLineJoin, which take Strings, two simply parse paths had to be
brought back. They can't use the enums, because the rules for enums as parameters
is stricter that what was implemented in the custom code (e.g. the bindings would
have thrown for strings not in the enum set).

html/canvas/CanvasRenderingContext2D.idl:

Move most of the functions into the new files, which are then 'implemented' by
this.

html/canvas/DOMPath.cpp: Removed.
html/canvas/DOMPath.h: Removed.
html/canvas/DOMPath.idl: Removed.
html/canvas/Path2D.cpp: Copied from Source/WebCore/html/canvas/DOMPath.cpp.
html/canvas/Path2D.h: Copied from Source/WebCore/html/canvas/DOMPath.h.
html/canvas/Path2D.idl: Copied from Source/WebCore/html/canvas/DOMPath.idl.

Rename DOMPath to Path2D to match the spec..

platform/graphics/GraphicsTypes.cpp:

(WebCore::parseLineCap): Deleted.
(WebCore::lineCapName): Deleted.
(WebCore::parseLineJoin): Deleted.
(WebCore::lineJoinName): Deleted.
(WebCore::textAlignName): Deleted.
(WebCore::parseTextAlign): Deleted.
(WebCore::textBaselineName): Deleted.
(WebCore::parseTextBaseline): Deleted.

platform/graphics/GraphicsTypes.h:

Remove now unused parsing / stringifying functions.

testing/Internals.cpp:

Remove unused #include.

bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
bindings/scripts/test/JS/JSTestCallbackInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
bindings/scripts/test/JS/JSTestStandaloneEnumeration.h:

Update test results to add convertEnumerationToString.

LayoutTests:

fast/canvas/canvas-clip-path-expected.txt:
fast/canvas/canvas-fill-path-expected.txt:
fast/canvas/canvas-path-addPath-expected.txt:
fast/canvas/canvas-path-isPointInPath-expected.txt:
fast/canvas/canvas-path-isPointInStroke-expected.txt:
fast/canvas/canvas-stroke-path-expected.txt:
fast/canvas/winding-enumeration-expected.txt:
inspector/canvas/recording-2d-expected.txt:
js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

Update results.

5:11 PM Changeset in webkit [221597] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[DFG] Consider increasing the number of DFG worklist threads
https://bugs.webkit.org/show_bug.cgi?id=176222

Reviewed by Saam Barati.

Attempt to add one more thread to DFG worklist. DFG compiler sometimes takes
very long time if the target function is very large. However, DFG worklist
has only one thread before this patch. Therefore, one function that takes
too much time to be compiled can prevent the other functions from being
compiled in DFG or upper tiers.

One example is Octane/zlib. In zlib, compiling "a1" function in DFG takes
super long time (447 ms) because of its super large size of the function.
While this function never gets compiled in FTL due to its large size,
it can be compiled in DFG and takes super long time. Subsequent "a8" function
compilation in DFG is blocked by this "a1". As a consequence, the benchmark
takes very long time in a1/Baseline code, which is slower than DFG of course.

While FTL has a bit more threads, DFG worklist has only one thread. This patch
adds one more thread to DFG worklist to alleviate the above situation. This
change significantly improves Octane/zlib performance.

baseline patched

zlib x2 482.32825+-6.07640 ^{408.66072+-14.03856} definitely 1.1803x faster

runtime/Options.h:

4:50 PM Changeset in webkit [221596] by Darin Adler

3 edits in trunk/Source/WebCore

Follow up FrameView::updateLayoutAndStyleIfNeededRecursive changes with related improvements
https://bugs.webkit.org/show_bug.cgi?id=176277

Reviewed by Antti Koivisto.

page/FrameView.cpp:

(WebCore::FrameView::needsStyleRecalcOrLayout): Deleted. This function was only used
by an assertion inside updateLayoutAndStyleIfNeededRecursive, and thus there is no reason
for it to be in the header file, or for it to be a public member function.
(WebCore::appendRenderedChildren): Deleted. This function was only used inside
updateLayoutAndStyleIfNeededRecursive, and it is now packaged in an even better way
for efficient use inside that function.
(WebCore::FrameView::renderedChildFrameViews): Deleted. This function was only used
inside needsStyleRecalcOrLayout, and it's now packaged in a better way inside that function.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Created a new lambda called
nextRendereredDescendant that packages up the process of repeatedly iterating this view
and all of its descendants in an easy-to-use way. Replaces both of the functions above.
Rewrote to use it; it made the logic clear enough that it was good to get rid of the
updateOneFrame lambda, too. Added two separate functions, one that checks for needed
style recalculation and a separate one that checked for needed layout. Using those,
replaced the old single assertion with two separate assertions.

page/FrameView.h: Removed needsStyleRecalcOrLayout, renderedChildFrameViews, and

FrameViewList.

4:36 PM Changeset in webkit [221595] by Wenson Hsieh

14 edits
3 adds in trunk

[iOS DnD] Refactor drag and drop logic in WKContentView in preparation for supporting multiple drag items in a drag session
https://bugs.webkit.org/show_bug.cgi?id=176264
<rdar://problem/31144674>

Reviewed by Darin Adler.

Source/WebCore:

Makes some small adjustments to WebItemProviderPasteboard. Rather than just -setItemProviders: on the
WebItemProviderPasteboard when initiating a drag, also stage the WebItemProviderRegistrationList that will be
used to generate an item provider. While it would be cleaner to avoid directly setting item providers so we
don't overwrite item providers on the WebItemProviderPasteboard when adding items to an existing drag session,
this isn't possible without breaking binary compability with older UIKit versions.

Importantly, WKContentView will now ignore any item providers that have been set on the
WebItemProviderPasteboard when initiating a drag or adding items to an existing drag session, and instead only
consider the staged registration list when generating item providers for dragging. This only has the drawback of
generating an unnecessary item provider, but otherwise maintains backwards compatibility while allowing us to
provide WebKit2 support for multiple items per drag session.

Tests: DataInteractionTests.DragEventClientCoordinatesBasic

DataInteractionTests.DragEventClientCoordinatesWithScrollOffset
DataInteractionTests.DragEventPageCoordinatesBasic
DataInteractionTests.DragEventPageCoordinatesWithScrollOffset

platform/ios/AbstractPasteboard.h:
platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):

Changed to only stage registration info on the item provider pasteboard, if possible. This has no effect on the
copy/paste codepath, since it uses a UIPasteboard.

platform/ios/WebItemProviderPasteboard.h:
platform/ios/WebItemProviderPasteboard.mm:

Rename _registrationInfoLists to _stagedRegistrationInfoList, and change it from an array of registration info
lists to a single registration info list. This could be updated in the future to be an array of registration
lists, but currently, it serves no purpose and makes coordination with DragItem info more difficult. This would
need to support multiple registration lists if we are to add a way to begin a drag containing multiple items in
vanilla web content, such as dragging multiple selections.

(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard stageRegistrationList:]):

Sets the staged item provider registration list.

(-[WebItemProviderPasteboard takeRegistrationList]):

Removes the staged item provider registration list from the WebItemProviderPasteboard and also returns it.

(-[WebItemProviderPasteboard registrationInfoAtIndex:]): Deleted.
(-[WebItemProviderPasteboard setRegistrationInfoLists:]): Deleted.

Source/WebKit:

Move DataInteractionState from WKContentViewInteraction.h to DragDropInteractionState.h, and also rename it to
DragDropInteractionState. Additionally, refactor drag and drop state in the UI process to capture metadata about
the dragged element in a separate DragSourceState struct. This patch also moves drag and drop state transition
logic that doesn't involve WKContentView internals out of WKContentView, and into the implementation of
DragDropInteractionState.

To support multiple drag items per session, we also introduce a simple mechanism to trace a UIDragItem back to
the DragSourceState used to generate it. When generating a DragSourceState, we assign it a unique identifier,
which we also set as the privateLocalContext of all UIDragItems generated when beginning the drag (this
includes drag items returned by an internal client that uses one of the SPI hooks to augment drag items when
starting a drag). This is subsequently used in the implementation of lift and cancellation preview delegate
methods to supply the appropriate drag preview for each UIDragItem.

Lastly, fix a bug wherein the pageX and pageY of mouse drag events are inconsistent with other synthetic mouse
events, such as synthetic clicks. For synthetic clicks, the PlatformMouseEvent is initialized with the same
position and globalPosition. Whether this is really intended is unclear (see http://webkit.org/b/173855), but
it's a trivial change for now to keep mouse events on iOS consistent by tweaking the behavior during drag and
drop. See Tools/ChangeLog for some more information.

Platform/spi/ios/UIKitSPI.h:

Add -[UIDragItem privateLocalContext].

UIProcess/ios/DragDropInteractionState.h: Added.

(WebKit::DragDropInteractionState::stagedDragSource const):
(WebKit::DragDropInteractionState::dropSessionDidExit):
(WebKit::DragDropInteractionState::dropSessionWillPerformDrop):
(WebKit::DragDropInteractionState::adjustedPositionForDragEnd const):
(WebKit::DragDropInteractionState::didBeginDragging const):
(WebKit::DragDropInteractionState::isPerformingDrop const):
(WebKit::DragDropInteractionState::dragSession const):
(WebKit::DragDropInteractionState::dropSession const):

Wrap private drag/drop state member variables behind const getters, and move drag and drop logic that involves
only the DragDropInteractionState into helper methods on DragDropInteractionState.

(WebKit::DragDropInteractionState::BlockPtr<void):

UIProcess/ios/DragDropInteractionState.mm: Added.

(WebKit::dragItemMatchingIdentifier):
(WebKit::createTargetedDragPreview):
(WebKit::uiImageForImage):

Move drag preview creation logic here, from WKContentViewInteraction.mm.

(WebKit::shouldUseTextIndicatorToCreatePreviewForDragAction):
(WebKit::DragDropInteractionState::activeDragSourceForItem const):
(WebKit::DragDropInteractionState::anyActiveDragSourceIs const):
(WebKit::DragDropInteractionState::prepareForDragSession):
(WebKit::DragDropInteractionState::dragSessionWillBegin):
(WebKit::DragDropInteractionState::previewForDragItem const):
(WebKit::DragDropInteractionState::dragSessionWillDelaySetDownAnimation):
(WebKit::DragDropInteractionState::dropSessionDidEnterOrUpdate):
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::hasStagedDragSource const):
(WebKit::DragDropInteractionState::clearStagedDragSource):
(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):
(WebKit::DragDropInteractionState::updatePreviewsForActiveDragSources):

UIProcess/ios/WKContentViewInteraction.h:

Move drag-and-drop-related state tied to the WKContentView here, from DataInteractionState (for instance, the
UIView for the drop caret, the WKContentView snapshot when dropping, and a flag use to keep track of hiding the
callout bar when dragging a text selection).

(): Deleted.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
(-[WKContentView _didChangeDragInteractionPolicy]):
(-[WKContentView setupDataInteractionDelegates]):
(-[WKContentView teardownDataInteractionDelegates]):
(-[WKContentView _startDrag:item:]):
(-[WKContentView _didHandleStartDataInteractionRequest:]):
(-[WKContentView computeClientAndGlobalPointsForDropSession:outClientPoint:outGlobalPoint:]):
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _didConcludeEditDataInteraction:]):
(-[WKContentView _didPerformDataInteractionControllerOperation:]):
(-[WKContentView _didChangeDataInteractionCaretRect:currentRect:]):
(-[WKContentView currentDragOrDropSession]):
(-[WKContentView _restoreCalloutBarIfNeeded]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
(-[WKContentView _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):

Pull out logic that mutates drag and drop state into DragDropInteractionState. Adjust places that previously
accessed DataInteractionState's members directly with corresponding getters in DragDropInteractionState.

(-[WKContentView _simulateDataInteractionEntered:]):
(-[WKContentView _simulateDataInteractionUpdated:]):
(-[WKContentView _simulateDataInteractionEnded:]):
(-[WKContentView _simulateDataInteractionPerformOperation:]):
(-[WKContentView _simulateDataInteractionSessionDidEnd:]):
(-[WKContentView _simulateWillBeginDataInteractionWithSession:]):
(-[WKContentView _simulatedItemsForSession:]):
(-[WKContentView _simulatePrepareForDataInteractionSession:completion:]):

Rename _dataInteraction => _dragInteraction and _dataOperation => _dropInteraction.

(uiImageForImage): Deleted.
(shouldUseTextIndicatorToCreatePreviewForDragAction): Deleted.
(-[WKContentView dragPreviewForImage:frameInRootViewCoordinates:clippingRectsInFrameCoordinates:backgroundColor:]): Deleted.
(-[WKContentView dragPreviewForCurrentDataInteractionState]): Deleted.
(-[WKContentView _transitionDragPreviewToImageIfNecessary:]): Deleted.

WebKit.xcodeproj/project.pbxproj:

Tools:

Adds two new iOS drag and drop tests to check that the clientX and clientY attributes of mouse events propagated
to the page during drop are correct. Each test drags from an image element and drops into three custom-drop-
handling elements; dragenter, dragover, and drop event listeners on the body then use the clientX and
clientY event attributes to hit-test for drop target elements. The first test is suffixed with "-Basic"; the
second test, suffixed with "-WithScrollOffset", makes the document scrollable to check that clientY is correct
when scrolled.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/drop-targets.html: Added.
TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::testDragAndDropOntoTargetElements):
(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView stringByEvaluatingJavaScript:]):

Log a warning message when an API test fails due to JavaScript evaluation in TestWKWebView.

1:24 PM Changeset in webkit [221594] by Nikita Vasilyev

5 edits
1 copy
1 move
4 adds
1 delete in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: hook up real data to spreadsheet style editor
https://bugs.webkit.org/show_bug.cgi?id=175343
<rdar://problem/33784793>

Reviewed by Devin Rousso.

Replace static HTML added in <https://webkit.org/b/174838> with actual data.

Addressed in this patch:

CSS rules can be copied.
Source links work as expected.
Nonmatching selectors are grayed out.

Known limitations:

Neither CSS selectors nor CSS properties are editable.
"Inherited from" and media query section headers are missing.
No syntax highlighting of complex CSS values, e.g. hsl(0, 0%, 70%).

UserInterface/Main.html:
UserInterface/Models/CSSStyleDeclaration.js:
UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WI.CSSStyleDeclarationTextEditor):

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel):

UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js: Removed.

Rename RulesStyleSpreadsheetDetailsPanel to SpreadsheetRulesStyleDetailsPanel. All files related to the spreadsheet editor start with "Spreadsheet" now.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: Added.

(.spreadsheet-style-declaration-editor):
(.spreadsheet-style-declaration-editor .name):
(.spreadsheet-style-declaration-editor .value):
(.spreadsheet-style-declaration-editor.no-properties):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: Added.

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get delegate):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set delegate):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get style):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set style):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get _propertiesToRender):
Similar condition is commonly used in CSSStyleDeclarationTextEditor. Abstact it out to its own method.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._renderProperty):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css: Copied from Source/WebInspectorUI/UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css.

(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration .origin):
(.spreadsheet-css-declaration.locked .origin::after):
(.spreadsheet-css-declaration .origin .go-to-link):
(.spreadsheet-css-declaration .origin .go-to-link:hover):
(.spreadsheet-css-declaration .styles-source):
(.spreadsheet-css-declaration .selector.style-attribute):
(.spreadsheet-css-declaration .selector > span):
(.spreadsheet-css-declaration .selector > .matched):
(.spreadsheet-css-declaration .properties):
(.spreadsheet-css-declaration.locked):
(.spreadsheet-css-declaration .locked-icon):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: Added.

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get element):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get style):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorFocused):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get locked):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get selectorEditable):

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css.
UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js: Added.

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):

UserInterface/Views/StyleDetailsPanel.js:

(WI.StyleDetailsPanel.prototype.filterDidChange):

UserInterface/Views/View.js:

(WI.View.prototype.removeAllSubviews):
Add a method to remove all subviews more efficiently.

1:15 PM Changeset in webkit [221593] by fpizlo@apple.com

15 edits
1 add in trunk/Tools

WSL IntLiteral should have variable type so that it can unify with things like uint
https://bugs.webkit.org/show_bug.cgi?id=176209

Reviewed by Mylex Maxfield.

This introduces IntLiteralType, which can unify with any number type that can represent the
int literal.

This means that all of the following are legal:

double x = 0; 0 unifies with double
double y = x + 5; should resolve to double+double
double z = array[0]; 0 unifies with uint

We can do similar things with float literals, so that you don't have to suffix "f" all the
time.

I think that this is very different from what C does. C just supports implicit type
conversions. That's why "double x = 0" works in C. We don't do type conversions. Instead, we
let each literal unify itself with one type.

Also updated Test.html so that it runs again and is better at printing things.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/Checker.js:
WebGPUShadingLanguageRI/IntLiteral.js:

(IntLiteral):
(IntLiteral.prototype.toString):

WebGPUShadingLanguageRI/IntLiteralType.js: Added.

(IntLiteralType):
(IntLiteralType.prototype.get origin):
(IntLiteralType.prototype.get value):
(IntLiteralType.prototype.get isPrimitive):
(IntLiteralType.prototype.get isUnifiable):
(IntLiteralType.prototype.typeVariableUnify):
(IntLiteralType.prototype.unifyImpl):
(IntLiteralType.prototype.verifyAsArgument):
(IntLiteralType.prototype.verifyAsParameter):
(IntLiteralType.prototype.commitUnification):
(IntLiteralType.prototype.toString):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics.):
(Intrinsics):

WebGPUShadingLanguageRI/LiteralTypeChecker.js:

(LiteralTypeChecker.prototype.visitIntLiteralType):
(LiteralTypeChecker):

WebGPUShadingLanguageRI/NativeType.js:

(NativeType):
(NativeType.prototype.get isNumber):
(NativeType.prototype.set isNumber):
(NativeType.prototype.get isInt):
(NativeType.prototype.set isInt):
(NativeType.prototype.get isFloat):
(NativeType.prototype.set isFloat):

WebGPUShadingLanguageRI/Prepare.js:

(prepare):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitIntLiteral):
(Rewriter.prototype.visitIntLiteralType):

WebGPUShadingLanguageRI/StandardLibrary.js:
WebGPUShadingLanguageRI/Test.html:
WebGPUShadingLanguageRI/Test.js:

(this.window.this.print):
(doPrep):
(doLex):
(checkNumber):
(checkInt):
(TEST_nameResolutionFailure):
(TEST_threadArrayLoadIntLiteral):
(TEST_deviceArrayStoreIntLiteral):
(TEST_returnIntLiteralDouble):

WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isNumber):
(Type.prototype.get isInt):
(Type.prototype.get isFloat):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitIntLiteral):
(Visitor.prototype.visitIntLiteralType):

1:14 PM Changeset in webkit [221592] by fpizlo@apple.com

7 edits in trunk/Tools

Add more tests for null behavior in WSL
https://bugs.webkit.org/show_bug.cgi?id=176318

Reviewed by Myles Maxfield.

This adds more tests for the unification behavior of null. In the process, I found a couple
small bugs and fixed them.

WebGPUShadingLanguageRI/Checker.js:
WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):

WebGPUShadingLanguageRI/Substitution.js:

(Substitution.prototype.visitTypeRef):

WebGPUShadingLanguageRI/Test.js:

(TEST_passNullAndNotNullFullPoly):
(TEST_passNullAndNotNullFullPolyReverse):
(TEST_nullTypeVariableUnify.recurse):
(TEST_nullTypeVariableUnify.everyOrder):
(TEST_nullTypeVariableUnify.everyPair):
(TEST_nullTypeVariableUnify):

WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.wrap):

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.verifyAsArgument):

12:34 PM Changeset in webkit [221591] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Loosen the check in video-canvas-drawing-output.html.
https://bugs.webkit.org/show_bug.cgi?id=127106

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-04
Reviewed by Xabier Rodriguez-Calvar.

GStreamer needs the extra tolerance since version 1.2.1.

media/video-canvas-drawing-output.html:
platform/gtk/TestExpectations:

10:54 AM Changeset in webkit [221590] by commit-queue@webkit.org

13 edits
1 delete in trunk

Unreviewed, rolling out r221494 and r221500.
https://bugs.webkit.org/show_bug.cgi?id=176258

This caused the windows build to fail. (Requested by mlewis13
on #webkit).

Reverted changesets:

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221494

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221500

9:27 AM Changeset in webkit [221589] by Darin Adler

5 edits in trunk/Tools

REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175329

Reviewed by Wenson Hsieh.

These tests rely on using setTimeout to wait a run loop iteration for the
video controls to appear. With changes to how loading occurs, it can now
take two run loop iterations. The concept here is inherently a bit flaky
and racy -- end users will not be able to tell how many run loop cycles it
takes for controls to come up, and websites can't tell either -- but for now
changing the tests to wait one more run loop should get rid of the flakiness.

TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: Re-enable test.

TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html: Add a

second setTimeout and a comment.

TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html: Ditto.
TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html: Ditto.

7:01 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

7:01 AM Changeset in webkit [221588] by Adrian Perez de Castro

2 edits in trunk/Source/bmalloc

Unreviewed build fix for Clang with libc++

Fixes a build failure when building with Clang, -stdlib=libc++, and gigacage
support enabled, which resulted in "stderr" being undefined.

bmalloc/Gigacage.cpp: Add missing <ctsdio> include to pull the definition.

6:38 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos

(diff)

6:38 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos

(diff)

4:45 AM Changeset in webkit [221587] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.17.92

WebKitGTK+ 2.17.92

4:44 AM Changeset in webkit [221586] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.92 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.17.92.

3:50 AM Changeset in webkit [221585] by commit-queue@webkit.org

10 edits
3 adds in trunk/Source

Source/JavaScriptCore:
[WebIDL] Unify and simplify EnableBySettings with the rest of the runtime settings
https://bugs.webkit.org/show_bug.cgi?id=176312

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

runtime/CommonIdentifiers.h:

Remove WebCore specific identifiers from CommonIdentifiers. They have been moved
to WebCoreBuiltinNames in WebCore.

Source/WebCore:
[WebIDL] Simplify EnabledBySettings generation
https://bugs.webkit.org/show_bug.cgi?id=176312

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

bindings/scripts/CodeGeneratorJS.pm:

(NeedsRuntimeCheck):
(OperationShouldBeOnInstance):
(GeneratePropertiesHashTable):
(GenerateRuntimeEnableConditionalString):
(GenerateImplementation):
(GenerateAttributeGetterBodyDefinition):

Simplify the [EnabledBySetting] code generation by merging it with the other runtime checks (Exposed, EnabledAtRuntime, EnabledForWorld, and SecureContext).

Switches to using WebCoreBuiltinNames for identifiers, rather than relying on the appropriate identifiers being available on JavaScriptCore's CommonIdentifiers which was an unnecessary layering violation. There are still problems with this as we continue to be inconsistent about which identifiers deserve to be in WebCoreBuiltinNames, and which ones can be created each time and there is no automation of WebCoreBuiltinNames from the IDLs.

Enforce at code generation time that [EnabledBySetting] can only be used on interfaces that are uniquely exposed to the window environment. This is a condition we should find a way to remove (e.g. propagating necessary settings to an object the ScriptExecutionContext owns), but for now, Settings is a main thread only object.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):
(WebCore::addCrossOriginWindowPropertyNames):
(WebCore::addCrossOriginWindowOwnPropertyNames):

Switch to using WebCoreBuiltinNames for WebCore specific identifiers.

bindings/js/WebCoreBuiltinNames.h:

Add WebCore specific identifiers from JavaScriptCore's CommonIdentifiers
as well as some new ones need by the [EnableBySetting] unification.

bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: Added.
bindings/scripts/test/JS/JSTestEnabledBySetting.h: Added.
bindings/scripts/test/TestEnabledBySetting.idl: Added.

Add new test for [EnabledBySetting].

bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/TestObj.idl:

Remove use of [EnabledBySetting] from TestObj, as it is no longer
valid to use [EnabledBySetting] on interfaces that are no uniquely
exposed to the window environment.

2:24 AM Changeset in webkit [221584] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221574 - [Threaded Compositor] Deadlock in ThreadedDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=176296

Reviewed by Žan Doberšek.

The main thread tries to schedule a display refresh monitor from RAF, requestDisplayRefreshMonitorUpdate() tries
to take the attributes lock to update coordinateUpdateCompletionWithClient. The compositing thread has finished
a frame and sceneUpdateFinished() takes the attributes lock to update clientRendersNextFrame and then asks the
display refresh monitor if it requires a new callback. ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback()
takes its lock to check the state, and requestDisplayRefreshMonitorUpdate() was called by
ThreadedDisplayRefreshMonitor::requestRefreshCallback() with the display refresh monitor lock taken. So,
the compositing thread has the attributes lock and wants the display refresh monitor one, and main thread has the
display refresh monitor lock and wants the attributes one.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback): Release the mutex before calling
ThreadedCompositor::requestDisplayRefreshMonitorUpdate().

2:24 AM Changeset in webkit [221583] by Yusuke Suzuki

11 edits in trunk/Source

Remove "malloc" and "free" use
https://bugs.webkit.org/show_bug.cgi?id=176310

Reviewed by Darin Adler.

Source/JavaScriptCore:

Use Vector instead.

API/JSWrapperMap.mm:

(selectorToPropertyName):

Source/WebCore:

Use MallocPtr<>, fastMalloc/fastFree, or Vector instead of manual call of system malloc/free.
In this patch, we apply the above change if we can easily find the pair of malloc/free.
And we do not touch plugin directory since the external code could call free() onto the
fastMalloc-ed memory.

Also, we still use malloc if the system adopts the allocated memory. Later, the system
will deallocate it by calling the system "free".

platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::fftSetupForSize):
(WebCore::FFTFrame::cleanup):

platform/graphics/win/FontCacheWin.cpp:

(WebCore::getLinkedFonts):

platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

platform/mac/WebCoreNSURLExtras.mm:

(WebCore::URLByTruncatingOneCharacterBeforeComponent):
(WebCore::dataForURLComponentType):
(WebCore::URLByRemovingComponentAndSubsequentCharacter):
(WebCore::createStringWithEscapedUnsafeCharacters):
(WebCore::userVisibleString):

platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

Source/WTF:

Use Vector instead.

wtf/Assertions.cpp:

2:24 AM Changeset in webkit [221582] by Carlos Garcia Campos

4 edits
1 copy in releases/WebKitGTK/webkit-2.18/Source

Merge r221572 - [GTK] Libgcrypt warning: missing initialization - please fix the application
https://bugs.webkit.org/show_bug.cgi?id=171230

Reviewed by Michael Catanzaro.

Source/WebCore/PAL:

Add the Initialization.h header, containing the single initialize() static
function that initializes the libgcrypt library. This header only includes
the default libgcrypt header, and nothing else.

It's not added to the existing Utilities.h header because that one pulls in
other unnecessary headers that for instance use the new() operator, but that
collides with the implementation files that define WebKit process entrypoints
and intentionally don't include the config.h that brings in FastMalloc to
properly define the new() and delete() operators, resulting in compilation
errors due to the new and delete operators being defined to warning strings
in always-included WebKit2Prefix.h.

pal/crypto/gcrypt/Initialization.h: Copied from Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp.

(PAL::GCrypt::initialize):

Source/WebKit:

Replicate the libgcrypt initialization in the NetworkProcess entrypoint.
This is required due to libgcrypt being used through digest operations
originating from the certificate hash computation in SoupNetworkSession.

The initialization is moved to the PAL library, and the initialize()
function is now leveraged in both NetworkProcess and WebProcess entrypoints.

NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

2:22 AM Changeset in webkit [221581] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r221562 - String#utf8() allocates new CString
https://bugs.webkit.org/show_bug.cgi?id=176302

Reviewed by Sam Weinig.

Source/WebCore:

Several places uses String#utf8() like an accessor. In reality, it allocates new CString per call.
It is very costly. Furthermore, some places uses this incorrectly. For example,
std::vector<char>(srtpAuth.utf8().data(), srtpAuth.utf8().data() + srtpAuth.utf8().length());
is incorrect since each time strpAuth.utf8() allocates different CString.

This patch calls utf8() first and use it.

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::startClosingHandshake):

platform/wpe/PlatformPasteboardWPE.cpp:

(WebCore::PlatformPasteboard::write):

Source/WebKit:

NetworkProcess/webrtc/NetworkRTCSocket.cpp:

(WebKit::NetworkRTCSocket::sendTo):

2:22 AM Changeset in webkit [221580] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221561 - [SOUP] Use fastMalloced SoupBuffer in ResourcehandleSoup
https://bugs.webkit.org/show_bug.cgi?id=176311

Reviewed by Michael Catanzaro.

Use fastMalloced memory instead of g_malloc for SoupBuffer.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):

2:14 AM Changeset in webkit [221579] by Carlos Garcia Campos

9 edits in releases/WebKitGTK/webkit-2.18

Merge r221542 - Wrong getComputedStyle result for pseudo-elements in display: none subtrees.
https://bugs.webkit.org/show_bug.cgi?id=176259

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-02
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:

Source/WebCore:

Before this patch, we were wrongly returning the parent style when there wasn't
a cached pseudo style.

With this, the only remaining failures in getComputedStyle-pseudo is a
serialisation bug for the "content" property, and the display: contents test,
which is because we don't support pseudo-elements of display: contents elements
yet.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):

dom/Element.h:

1:50 AM Changeset in webkit [221578] by Carlos Garcia Campos

7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221539 - Performance / PerformanceObserver leaks seen on bots
https://bugs.webkit.org/show_bug.cgi?id=176269

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.

page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::removeAllEventListeners):
Also use this opportunity to break up the reference cycle
between PerformanceObservers and the Performance object.

page/Performance.h:
page/Performance.cpp:

(WebCore::Performance::removeAllObservers):
Disassociate and clear observers.

page/PerformanceObserver.h:
page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::disassociate):
Clear the back-reference to the Performance object to
break the cycle.

1:49 AM Changeset in webkit [221577] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r221521 - [GTK][Wayland] Use fast malloc to allocate backing store cairo surfaces data
https://bugs.webkit.org/show_bug.cgi?id=176226

Reviewed by Michael Catanzaro.

Source/WebCore:

It reduces the memory consumption and improves the performance. Also, since performance is better we don't need
to keep the scroll surface allocated all the time, we can create it on demand and keep it allocated only while
scrolling too fast.

platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:

(WebCore::createCairoImageSurfaceWithFastMalloc): Helper to create a cairo image surface using fast malloc.
(WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl): Create the main surface, but no the
scroll one. Initialize the hysteresis activity to discard the scroll surface after scrolling.
(WebCore::BackingStoreBackendCairoImpl::scroll): Create the scroll surface only if it's nullptr, and notify the
hysteresis activity.

platform/graphics/cairo/BackingStoreBackendCairoImpl.h:

Source/WebKit:

Do not create the cairo surface for BackingStoreBackendCairoImpl. When not using X11 we are going to use an
image surface anyway, so we don't really need to use the create similar. This way we only need to pass the size
and device scale factor to BackingStoreBackendCairoImpl that will create the image surface using fast malloc to
allocate the data.

UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

1:49 AM Changeset in webkit [221576] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221514 - [GTK][Wayland] Opening FedoraProject's pastebin chews CPU
https://bugs.webkit.org/show_bug.cgi?id=175942

Reviewed by Žan Doberšek.

This regressed when we introduced the display refresh monitor. The monitor schedules updates immediately,
because we removed the option to not do frame sync in X11 to let swapBuffers do the throttling, but that's
not happening in Wayland because the nested compositor is dispatching frame callbacks on surface commit.
We need to ensure that frame callbacks are dispatched on every monitor refresh, because swapBuffers waits for
frame callbacks to be queued on display.

UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::Surface::~Surface): Destroy pending frame callbacks too.
(WebKit::WaylandCompositor::Surface::setWebPage): Add a tick callback to the web view widget to flush all
committed frame callbacks on every frame update.
(WebKit::WaylandCompositor::Surface::requestFrame): Add the callbacks to m_pendingFrameCallbackList.
(WebKit::WaylandCompositor::Surface::flushFrameCallbacks): Dispatch all committed frame callabcks.
(WebKit::WaylandCompositor::Surface::flushPendingFrameCallbacks): Dispatch all pending frame callbacks.
(WebKit::WaylandCompositor::Surface::commit): Do not dispatch frame callbacks here, move them to the list of
committed frame callbacks that will be dispatched on the next frame clock update.

UIProcess/gtk/WaylandCompositor.h:

(WebKit::WaylandCompositor::Surface::setWebPage): Moved to the cpp.

WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:

(WebKit::AcceleratedSurfaceWayland::AcceleratedSurfaceWayland): Move surface initialization and destruction to
the compositing thread.
(WebKit::AcceleratedSurfaceWayland::initialize):
(WebKit::AcceleratedSurfaceWayland::finalize):
(WebKit::AcceleratedSurfaceWayland::~AcceleratedSurfaceWayland): Deleted.

WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:

1:04 AM Changeset in webkit [221575] by Yusuke Suzuki

2 edits in trunk/Source/WTF

Unreviewed, support libstdc++ use with clang
https://bugs.webkit.org/show_bug.cgi?id=176301

wtf/FastMalloc.h:

Sep 3, 2017:

11:52 PM Changeset in webkit [221574] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[Threaded Compositor] Deadlock in ThreadedDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=176296

Reviewed by Žan Doberšek.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback): Release the mutex before calling
ThreadedCompositor::requestDisplayRefreshMonitorUpdate().

11:09 PM WebKitGTK/2.18.x edited by zandobersek@gmail.com

(diff)

11:07 PM Changeset in webkit [221573] by Chris Dumez

3 edits in trunk/Source/WebCore

Use StringView in DOMFileSystem::evaluatePath()
https://bugs.webkit.org/show_bug.cgi?id=176324

Reviewed by Darin Adler.

Use StringView in DOMFileSystem::evaluatePath() for performance.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::evaluatePath):

Modules/entriesapi/DOMFileSystem.h:

11:04 PM Changeset in webkit [221572] by zandobersek@gmail.com

4 edits
1 add in trunk/Source

[GTK] Libgcrypt warning: missing initialization - please fix the application
https://bugs.webkit.org/show_bug.cgi?id=171230

Reviewed by Michael Catanzaro.

Source/WebCore/PAL:

Add the Initialization.h header, containing the single initialize() static
function that initializes the libgcrypt library. This header only includes
the default libgcrypt header, and nothing else.

pal/crypto/gcrypt/Initialization.h: Copied from Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp.

(PAL::GCrypt::initialize):

Source/WebKit:

The initialization is moved to the PAL library, and the initialize()
function is now leveraged in both NetworkProcess and WebProcess entrypoints.

NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

11:03 PM Changeset in webkit [221571] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

[WPE] Use the device scale factor value in WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=175377

Reviewed by Michael Catanzaro.

WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::AcceleratedDrawingArea):
WebPageCreationParameters::deviceScaleFactor value should be used
to set the device scale factor on the given WebPage object. This
enables correctly leveraging the scale factor for the WPE port
which enters accelerated mode unconditionally and as such doesn't
wait for the backing store update that would provide that value
otherwise.

10:58 PM Changeset in webkit [221570] by Brent Fulgham

2 edits in trunk/Source/WebKit

[WK2][iOS] Remove unnecessary IOHIDEventServiceFastPathUserClient access
https://bugs.webkit.org/show_bug.cgi?id=175947
<rdar://problem/33353627>

Reviewed by Darin Adler.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

9:08 PM Changeset in webkit [221569] by mitz@apple.com

2 edits in trunk/Source/WebCore/PAL

[Cocoa] Tidy up PassKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=176323

Reviewed by Darin Adler.

pal/spi/cocoa/PassKitSPI.h: Moved the declarations of requiredShippingContactFields and requiredBillingContactFields to where other PKPaymentRequest properties are declared, and changed the guard to relate to the SDK version. Replaced use of has_include with checking for the version of the Apple internal SDK in which the typedefs first appeared.

8:33 PM Changeset in webkit [221568] by mitz@apple.com

2 edits in trunk/Source/WebKit

WKContentViewInteraction.mm includes redundant declaration of UIPreviewItemController's presentationSecondaryGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=176322

Reviewed by Darin Adler.

UIProcess/ios/WKContentViewInteraction.mm: Removed the declaration, which is already made in the SDK or in UIKitSPI.h.

8:27 PM Changeset in webkit [221567] by commit-queue@webkit.org

2 edits in trunk/Tools

Make webkit-patch post --no-review enable EWS just like webkit-patch post-commits --no-review
https://bugs.webkit.org/show_bug.cgi?id=176321

Patch by Sam Weinig <sam@webkit.org> on 2017-09-03
Reviewed by Darin Adler.

Scripts/webkitpy/tool/commands/upload.py:

Add the SubmitToEWS step to Post command

8:01 PM Changeset in webkit [221566] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the iOS build

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

7:51 PM Changeset in webkit [221565] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

runtime/JSGlobalObjectFunctions.cpp: #include <unicode/utf8.h>.

7:12 PM Changeset in webkit [221564] by mitz@apple.com

2 edits in trunk/Source/WebCore/PAL

[Cocoa] Remove use of has_include in CoreAudioSPI.h
https://bugs.webkit.org/show_bug.cgi?id=176320

Reviewed by Tim Horton.

pal/spi/cf/CoreAudioSPI.h: AudioHardwarePriv.h is available in all Apple internal SDKs and only in Apple internal SDKs. AudioHardwareBase.h is available only in the macOS SDK, where it is included by AudioHardware.h.

6:40 PM Changeset in webkit [221563] by timothy_horton@apple.com

13 edits in trunk/Source

Fix some style issues in the Remote Layer Tree code
https://bugs.webkit.org/show_bug.cgi?id=176298

Reviewed by Dan Bernstein.

Source/WebCore/PAL:

pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

In bugs 176273 and 176297, the style bot noticed some existing style
issues in the UI-side compositing code. Fix them, because there aren't
many and they're straightforward.

Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h:
UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:

6:38 PM Changeset in webkit [221562] by Yusuke Suzuki

5 edits in trunk/Source

String#utf8() allocates new CString
https://bugs.webkit.org/show_bug.cgi?id=176302

Reviewed by Sam Weinig.

Source/WebCore:

This patch calls utf8() first and use it.

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::startClosingHandshake):

platform/wpe/PlatformPasteboardWPE.cpp:

(WebCore::PlatformPasteboard::write):

Source/WebKit:

NetworkProcess/webrtc/NetworkRTCSocket.cpp:

(WebKit::NetworkRTCSocket::sendTo):

6:37 PM Changeset in webkit [221561] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

[SOUP] Use fastMalloced SoupBuffer in ResourcehandleSoup
https://bugs.webkit.org/show_bug.cgi?id=176311

Reviewed by Michael Catanzaro.

Use fastMalloced memory instead of g_malloc for SoupBuffer.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):

6:00 PM Changeset in webkit [221560] by Yusuke Suzuki

4 edits in trunk/Source

[WTF] Add C++03 allocator interface for GCC < 6
https://bugs.webkit.org/show_bug.cgi?id=176301

Reviewed by Darin Adler.

Source/JavaScriptCore:

dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

Unfortunately, std::list in GCC < 6 does not support C++11 allocator interface.
This patch adds C++03 allocator interface to FastAllocator to make it usable
for std::list. It also allows us to use FastAllocator for data structures that
only support C++03 interface.

wtf/FastMalloc.h:

(WTF::FastAllocator::allocate):
(WTF::FastAllocator::construct):
(WTF::FastAllocator::destroy):
(WTF::FastAllocator::max_size const):
(WTF::FastAllocator::select_on_container_copy_construction const):

3:28 PM Changeset in webkit [221559] by Darin Adler

6 edits in trunk/Source/WebKitLegacy/mac

[Cocoa] Tidy a few things in legacy WebHTMLView
https://bugs.webkit.org/show_bug.cgi?id=176280

Reviewed by Dan Bernstein.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
methods it calls on WebHTMLView were doing nothing on iOS.

WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.

WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling

code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
in a lot more places. Move many of the SPI declarations up to the top in alphabetical
order. Removed all sorts of unused things. Made more code and fields Mac-only where
what was compiled was doing nothing on iOS and it makes the resulting code simpler.
Use RetainPtr instead of writing retain/release wherever possible.
(+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
initialization for it. Removed various unused methods and declarations of methods.
(promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
(-[WebHTMLView _imageExistsAtPaths:]): Deleted.
(-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
(+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
and remove CFRetain no longer needed since we don't support garbage collection any more.
(uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
(-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
(-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
(-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
(-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
(-[WebHTMLView _setMouseDownEvent:]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
debug flag; we haven't used it for years and it's not clearly helpful.
(-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
(-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
WebInternal category to the WebHTMLViewFileInternal category so it can be called by
two additional methods in the WebPrivate category and still be called by the two
methods in the WebInternal category that were already using it.
(-[WebHTMLView didAddSubview:]): Deleted.
(-[WebHTMLView _insideAnotherHTMLView]): Deleted.
(-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
place this was called, the close method.
(-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
(-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
(-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
(-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
(-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
Added helper method to make the one below simpler.
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Compared pasteboard type strings using isEqualToString: rather than using == since
we want to actually compare the string contents. Also updated to use modern for loop,
renamed a local variable from "s" to "localSubresources", and factored out the handling
of three image types to use the helper method above.
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
_web_makePluginSubviewsPerformSelector:withObject: method.
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
(-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
"descendent" rather than the noun "descendant". Also removed Mac-only optimization to
not call the -[NSView subviews] method to make this identical on both platforms and used
a modern for loop.
(-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
(-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
(-[WebHTMLView addWindowObservers]): Removed code dealing with empty
methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
(-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
(-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
of it is Mac-only.
(-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
method did was call itself on the main thread, and do nothing if called on main thread.
(-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
(-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
(-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
half of this method.
(-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
Simplified using a modern for loop and RetainPtr.
(-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
(-[WebHTMLView keyDown:]): Ditto.
(-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
(-[WebHTMLView performKeyEquivalent:]): Ditto.
(-[WebHTMLView _styleForAttributeChange:]): Ditto.
(-[WebHTMLView complete:]): Ditto.
(-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
now macOS-only.
(-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
iOS since that is now macOS-only.
(-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
(-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
a private one because it is not used or needed outside WebKit. Also made it macOS-only
and reorganized to use early return.
(-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
on iOS, but kept there so we don't have to do #if at every call site.
(-[WebHTMLView _pluginController]): Moved into internal category.
(-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
there only for GC, using C++ initialization, removing obsolete comment.
(-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
peculiar iOS-only comment.
(+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].

WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.

Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
_web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
_stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
needed or used as SPI. And made _startAutoscrollTimer macOS-only.

WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,

_clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
them at this time.

3:03 PM Changeset in webkit [221558] by Chris Dumez

13 edits in trunk

Have getFileMetadata() return a std::optional<FileMetadata>
https://bugs.webkit.org/show_bug.cgi?id=176293

Reviewed by Darin Adler.

Source/WebCore:

Have getFileMetadata() return a std::optional<FileMetadata> instead of
using an out parameter for the metadata.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::getEntry):

html/FileListCreator.cpp:

(WebCore::appendDirectoryFiles):

platform/FileSystem.cpp:

(WebCore::fileIsDirectory):

platform/FileSystem.h:
platform/glib/FileSystemGlib.cpp:

(WebCore::getFileMetadata):

platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications):

platform/network/mac/BlobDataFileReferenceMac.mm:

(WebCore::BlobDataFileReference::generateReplacementFile):

platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileMetadata):

platform/win/FileSystemWin.cpp:

(WebCore::getFileMetadata):

Tools:

TestWebKitAPI/Tests/WebCore/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

2:55 PM Changeset in webkit [221557] by Chris Dumez

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r221555.

Did not fix Windows build

Reverted changeset:

"Unreviewed attempt to fix Windows build."
http://trac.webkit.org/changeset/221555

2:49 PM Changeset in webkit [221556] by Chris Dumez

6 edits
5 copies
25 moves
8 adds
3 deletes in trunk/LayoutTests

Consolidate entries-api tests under entries-api/ folders
https://bugs.webkit.org/show_bug.cgi?id=176315

Reviewed by Darin Adler.

Consolidate entries-api tests under entries-api/ folders, for clarity.
Also drop an older test for directory upload which did not pass because
it was missing its resources. We now have good coverage for this feature
so this test is not needed.

editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-error-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-error-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-error.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-error.html.
editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-root-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-root-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-root.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-root.html.
editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader.html.
editing/pasteboard/enties-api/datatransfer-items-drop-fileEntry-file-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-fileEntry-file-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-fileEntry-file.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-fileEntry-file.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getAsEntry-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getAsEntry.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getDirectory-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getDirectory-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getDirectory.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getDirectory.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getFile-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getFile-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getFile.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getFile.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent-root-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-root-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent-root.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-root.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent.html.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent2-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent2-expected.txt.
editing/pasteboard/enties-api/datatransfer-items-drop-getParent2.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent2.html.
fast/forms/file/entries-api/resources/testFiles/file1.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/file1.txt.
fast/forms/file/entries-api/resources/testFiles/file2.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/file2.txt.
fast/forms/file/entries-api/resources/testFiles/subfolder1/file3.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder1/file3.txt.
fast/forms/file/entries-api/resources/testFiles/subfolder2/file4.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder2/file4.txt.
fast/forms/file/entries-api/resources/testFiles/subfolder2/subfolder2a/file5.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder2/subfolder2a/file5.txt.
fast/forms/file/entries-api/webkitdirectory-drag-folder-expected.txt: Renamed from LayoutTests/fast/forms/file/webkitdirectory-drag-folder-expected.txt.
fast/forms/file/entries-api/webkitdirectory-drag-folder.html: Renamed from LayoutTests/fast/forms/file/webkitdirectory-drag-folder.html.
fast/forms/file/entries-api/webkitdirectory-open-panel-expected.txt: Renamed from LayoutTests/fast/forms/file/webkitdirectory-open-panel-expected.txt.
fast/forms/file/entries-api/webkitdirectory-open-panel.html: Renamed from LayoutTests/fast/forms/file/webkitdirectory-open-panel.html.
fast/forms/file/input-file-directory-upload-expected.txt: Removed.
fast/forms/file/input-file-directory-upload.html: Removed.
platform/ios/TestExpectations:
platform/mac-wk1/fast/forms/file/entries-api/webkitdirectory-open-panel-expected.txt: Renamed from LayoutTests/platform/mac-wk1/fast/forms/file/webkitdirectory-open-panel-expected.txt.
platform/mac/TestExpectations:
platform/win/TestExpectations:
platform/wk2/TestExpectations:

1:38 PM Changeset in webkit [221555] by Chris Dumez

2 edits in trunk/Source/JavaScriptCore

Unreviewed attempt to fix Windows build.

runtime/JSGlobalObjectFunctions.cpp:

12:08 PM Changeset in webkit [221554] by timothy_horton@apple.com

3 edits
2 copies
8 moves
1 add
1 delete in trunk/Source/WebKit

Move shared part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176297

Reviewed by Dan Bernstein.

UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.

PlatformMac.cmake:
Shared/RemoteLayerTree/RemoteLayerBackingStore.h: Renamed from Shared/mac/RemoteLayerBackingStore.h.
Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: Renamed from Shared/mac/RemoteLayerBackingStore.mm.
Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: Renamed from Shared/mac/RemoteLayerBackingStoreCollection.h.
Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: Renamed from Shared/mac/RemoteLayerBackingStoreCollection.mm.
Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h: Renamed from Shared/mac/RemoteLayerTreePropertyApplier.h.
Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: Renamed from Shared/mac/RemoteLayerTreePropertyApplier.mm.
Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h: Renamed from Shared/mac/RemoteLayerTreeTransaction.h.
Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm: Renamed from Shared/mac/RemoteLayerTreeTransaction.mm.
Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: Renamed from Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp.
Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h: Renamed from Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h.
WebKit.xcodeproj/project.pbxproj:

11:54 AM Changeset in webkit [221553] by Chris Dumez

4 edits in trunk/Source

Unreviewed, rolling out r221552.

Broke the build

Reverted changeset:

"[WTF] Add C++03 allocator interface for GCC < 6"
https://bugs.webkit.org/show_bug.cgi?id=176301
http://trac.webkit.org/changeset/221552

11:49 AM Changeset in webkit [221552] by Yusuke Suzuki

4 edits in trunk/Source

[WTF] Add C++03 allocator interface for GCC < 6
https://bugs.webkit.org/show_bug.cgi?id=176301

Reviewed by Darin Adler.

Source/JavaScriptCore:

dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

wtf/FastMalloc.h:

10:51 AM Changeset in webkit [221551] by Yusuke Suzuki

5 edits in trunk/Source/JavaScriptCore

[JSC] Clean up BytecodeLivenessAnalysis
https://bugs.webkit.org/show_bug.cgi?id=176295

Reviewed by Saam Barati.

Previously, computeDefsForBytecodeOffset was a bit customizable.
This is used for try-catch handler's liveness analysis. But after
careful generatorification implementation, it is now not necessary.
This patch drops this customizability.

bytecode/BytecodeGeneratorification.cpp:

(JSC::GeneratorLivenessAnalysis::computeDefsForBytecodeOffset): Deleted.
(JSC::GeneratorLivenessAnalysis::computeUsesForBytecodeOffset): Deleted.

bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::computeDefsForBytecodeOffset): Deleted.
(JSC::BytecodeLivenessAnalysis::computeUsesForBytecodeOffset): Deleted.

bytecode/BytecodeLivenessAnalysis.h:
bytecode/BytecodeLivenessAnalysisInlines.h:

(JSC::BytecodeLivenessPropagation::stepOverInstruction):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation::runLivenessFixpoint):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::stepOverInstruction): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBytecodeOffset): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBlock): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::getLivenessInfoAtBytecodeOffset): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::runLivenessFixpoint): Deleted.

10:46 AM Changeset in webkit [221550] by fpizlo@apple.com

25 edits
3 adds in trunk/Tools

WSL should support structs
https://bugs.webkit.org/show_bug.cgi?id=176290

Reviewed by Mylex Maxfield.

This adds parsing of struct types and makes them work.

This required adding a struct layout phase, which in turn required being a bit more careful
about how we instantiate functions and types. We cannot have any instantiation TypeRefs left
once we're doing struct layout.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/DotExpression.js: Added.

(DotExpression):
(DotExpression.prototype.get struct):
(DotExpression.prototype.get fieldName):
(DotExpression.prototype.get isLValue):
(DotExpression.prototype.toString):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

WebGPUShadingLanguageRI/EPtr.js:

(EPtr.prototype.copyFrom): Deleted.
(EPtr.prototype.toString): Deleted.

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitAssignment):
(Evaluator.prototype.visitDotExpression):

WebGPUShadingLanguageRI/Field.js:

(Field):

WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef.prototype.rewrite):

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/Inline.js:

(inline):
(_inlineFunction):
(resolveInlinedFunction):

WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitDotExpression):

WebGPUShadingLanguageRI/InstantiateImmediates.js:

(InstantiateImmediates.prototype.visitTypeRef):
(InstantiateImmediates.prototype.visitVariableDecl):
(InstantiateImmediates):

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype._resolveTypeArguments):
(NameResolver.prototype.visitTypeRef):

WebGPUShadingLanguageRI/Node.js:

(Node.prototype.visit):

WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Added.

(OverloadResolutionFailure):
(OverloadResolutionFailure.prototype.get func):
(OverloadResolutionFailure.prototype.get reason):
(OverloadResolutionFailure.prototype.toString):

WebGPUShadingLanguageRI/Parse.js:

(parsePossibleSuffix):
(parseField):
(parseStructType):
(parse):

WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitDotExpression):
(Rewriter.prototype.visitVariableRef):

WebGPUShadingLanguageRI/StructLayoutBuilder.js: Added.

(StructLayoutBuilder):
(StructLayoutBuilder.prototype.visitStructType):
(StructLayoutBuilder.prototype.get offset):
(StructLayoutBuilder.prototype.visitField):
(StructLayoutBuilder.prototype.visitVariableRef):
(StructLayoutBuilder.prototype.visitVariableDecl):

WebGPUShadingLanguageRI/StructType.js:

(StructType.prototype.add):
(StructType.prototype.instantiate):
(StructType.prototype.populateDefaultValue):

WebGPUShadingLanguageRI/Substitution.js:

(Substitution.prototype.visitTypeRef):
(Substitution.prototype.visitVariableRef):
(Substitution):

WebGPUShadingLanguageRI/Test.js:

(TEST_genericStructInstance):

WebGPUShadingLanguageRI/Type.js:

(Type.prototype.inherits):

WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.instantiate):

WebGPUShadingLanguageRI/VariableRef.js:

(VariableRef.wrap):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitTypeRef):
(Visitor.prototype.visitDotExpression):
(Visitor.prototype.visitVariableRef):

10:43 AM Changeset in webkit [221549] by fpizlo@apple.com

21 edits
4 adds in trunk/Tools

WSL NullType should be a special type variable so it can unify with any pointer type
https://bugs.webkit.org/show_bug.cgi?id=176235

Reviewed by Myles Maxfield.

Null is just a type variable that plays by weird rules:

Other type variables don't recognize it, so if it's unified with T, it fails.
It behaves like a type variable for pointer and array reference types.
It arises only in argument (RHS) position.
Once Checker finds it to be equals to something, we need to remember what that was.

I refactored some of the type system code to allow for the possibility of type variables being
unified during equals() tests. It turns out that we were playing fast and loose here; I needed
to beef up UnificationContext.prototype.verify. I added tests for this.

I added an equalsWithCommit() that triggers commitUnification(), which allows NullType to
remember what type it got unified with.

NullLiteral then just instantiates its own NullType, which is what Checker uses as the type of
the NullLiteral. Everything else just works.

This adds a bunch of tests to make sure we generate type errors in various weird cases while
also accepting a number of safe cases.

I also added a way to run the tests in-browser.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/ArrayRefType.js:

(ArrayRefType.prototype.get isArrayRef):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/ConstexprTypeParameter.js:

(ConstexprTypeParameter.prototype.typeVariableUnify):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitNullLiteral):

WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toString):
(Func):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc.prototype.toDeclString):
(NativeFunc):
(NativeFunc.prototype.toString): Deleted.

WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance.prototype.toDeclString):
(NativeFuncInstance):
(NativeFuncInstance.prototype.toString): Deleted.

WebGPUShadingLanguageRI/Node.js:

(Node.unify):
(Node.prototype._typeVariableUnifyImpl):
(Node.prototype.equals):

WebGPUShadingLanguageRI/NullLiteral.js: Added.

(NullLiteral):
(NullLiteral.prototype.toString):

WebGPUShadingLanguageRI/NullType.js:

(NullType):
(NullType.prototype.get isPrimitive):
(NullType.prototype.get isUnifiable):
(NullType.prototype.typeVariableUnify):
(NullType.prototype.unifyImpl):
(NullType.prototype.verifyAsArgument):
(NullType.prototype.verifyAsParameter):
(NullType.prototype.toString):

WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parseType.getAddressSpace):
(parseType):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitNullLiteral):

WebGPUShadingLanguageRI/Test.html: Added.
WebGPUShadingLanguageRI/Test.js:

(this.window.this.print):
(TEST_doubleGenericCallsSingleGeneric):
(TEST_dereferenceDefaultNull):
(TEST_dereferenceDefaultNullArrayRef):
(doTest):
(let.s.in.this.s.startsWith.string_appeared_here.s.match): Deleted.

WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isArrayRef):

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.typeVariableUnify):

WebGPUShadingLanguageRI/UnificationContext.js:

(UnificationContext.prototype.verify):
(UnificationContext):
(UnificationContext.prototype.isUnunified): Deleted.

WebGPUShadingLanguageRI/VariableRef.js:

(VariableRef.prototype.get unifyNode):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitNullLiteral):

3:31 AM Changeset in webkit [221548] by Yusuke Suzuki

3 edits in trunk/Source/bmalloc

Large virtual memory region allocation requires MMAP_NORESERVE in Linux
https://bugs.webkit.org/show_bug.cgi?id=176211

Reviewed by Geoffrey Garen.

In Linux, we cannot allocate very large memory region without MMAP_NORESERVE.
Linux kernel needs to reserve swap area for allocated memory region. If the
swap area is exhausted, kernel fails to allocate the memory region with ENOMEM.

This patch adds MMAP_NORESERVE to mmap flags in Linux. By adding this flag,
mmap does not need to reserve swap area for the reserved memory region.
This allows us to reserve very large memory region that is necessary for Gigacage.

bmalloc/BPlatform.h:
bmalloc/VMAllocate.h:

(bmalloc::tryVMAllocate):

1:42 AM Changeset in webkit [221547] by commit-queue@webkit.org

25 edits
3 deletes in trunk

Remove CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=176288

Patch by Sam Weinig <sam@webkit.org> on 2017-09-03
Reviewed by Yusuke Suzuki.

CanvasProxy does not appear to be in any current HTML spec
and was disabled and unimplemented in our tree. Time to
get rid of it.

Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
DerivedSources.cpp:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
html/canvas/CanvasProxy.cpp: Removed.
html/canvas/CanvasProxy.h: Removed.
html/canvas/CanvasProxy.idl: Removed.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Sep 2, 2017:

9:42 PM Changeset in webkit [221546] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

Need an API to get the global context from JSObjectRef
https://bugs.webkit.org/show_bug.cgi?id=176291

Reviewed by Saam Barati.

Very simple additional API, starting off as SPI on principle.

API/JSObjectRef.cpp:

(JSObjectGetGlobalContext):

API/JSObjectRefPrivate.h:
API/tests/testapi.c:

(main):

9:05 PM Changeset in webkit [221545] by commit-queue@webkit.org

4 edits in trunk

DOMMatrix/DOMMatrixReadOnly validation is incorrect for NaN values
https://bugs.webkit.org/show_bug.cgi?id=176287

Patch by Sam Weinig <sam@webkit.org> on 2017-09-02
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup-expected.txt:

Update test results.

Source/WebCore:

css/DOMMatrixReadOnly.cpp:

(WebCore::sameValueZero): Added.
(WebCore::DOMMatrixReadOnly::validateAndFixup):

Switch from using standard != to added sameValueZero helper
which implements https://tc39.github.io/ecma262/#sec-samevaluezero

9:02 PM Changeset in webkit [221544] by Chris Dumez

8 edits
2 adds in trunk

Implement FileSystemFileEntry.file()
https://bugs.webkit.org/show_bug.cgi?id=176166
<rdar://problem/34187756>

Reviewed by Sam Weinig.

Source/WebCore:

Implement FileSystemFileEntry.file():

https://wicg.github.io/entries-api/#dom-filesystemfileentry-file

Test: editing/pasteboard/datatransfer-items-drop-fileEntry-file.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::listDirectory):
(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getFile):

Modules/entriesapi/DOMFileSystem.h:
Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::file):

LayoutTests:

Add layout test coverage. I have verified that this test passes in Chrome as well.

editing/pasteboard/datatransfer-items-drop-fileEntry-file-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-fileEntry-file.html: Added.
platform/wk2/TestExpectations:

8:43 PM Changeset in webkit [221543] by aestes@apple.com

20 edits in trunk/Source

[CA] Upstream QuartzCore-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176270

Reviewed by Tim Horton.

Source/WebCore:

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::enumerateRectsBeingDrawn):

platform/graphics/cocoa/WebCoreCALayerExtras.h:
platform/graphics/cocoa/WebCoreCALayerExtras.mm:

(+[CALayer _web_renderLayerWithContextID:]):

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForExternalHostingProcess):

UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):

UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::makeRenderLayer):

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

Plugins/Hosted/WebHostedNetscapePluginView.h:
Plugins/Hosted/WebHostedNetscapePluginView.mm:

(WebKit::SoftwareCARenderer::SoftwareCARenderer):
(WebKit::SoftwareCARenderer::~SoftwareCARenderer):
(WebKit::SoftwareCARenderer::context const):
(WebKit::SoftwareCARenderer::renderContext const):
(WebKit::SoftwareCARenderer::render):
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView createPluginLayer]):
(-[WebHostedNetscapePluginView destroyPlugin]):
(-[WebHostedNetscapePluginView drawRect:]):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:31 PM Changeset in webkit [221542] by commit-queue@webkit.org

9 edits in trunk

Wrong getComputedStyle result for pseudo-elements in display: none subtrees.
https://bugs.webkit.org/show_bug.cgi?id=176259

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-02
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:

Source/WebCore:

Before this patch, we were wrongly returning the parent style when there wasn't
a cached pseudo style.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):

dom/Element.h:

4:52 PM Changeset in webkit [221541] by timothy_horton@apple.com

4 edits
6 copies
9 moves
2 adds
1 delete in trunk/Source/WebKit

Move UI Process part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176273

Reviewed by Dan Bernstein.

UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.

UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h: Renamed from SourceebKit/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h.
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in: Renamed from UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in.
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: Renamed from UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm.
UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h: Renamed from UIProcess/mac/RemoteLayerTreeHost.h.
UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: Renamed from UIProcess/mac/RemoteLayerTreeHost.mm.
UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h: Renamed from UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.h.
UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm: Renamed from UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm.
UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: Renamed from UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp.
UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: Renamed from UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h.
UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: Renamed from UIProcess/Scrolling/RemoteScrollingTree.cpp.
UIProcess/RemoteLayerTree/RemoteScrollingTree.h: Renamed from UIProcess/Scrolling/RemoteScrollingTree.h.
UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: Renamed from UIProcess/ios/RemoteLayerTreeHostIOS.mm.
UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: Renamed from UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm.
UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Renamed from UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h.
UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Renamed from UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm.
WebKit.xcodeproj/project.pbxproj:

2:31 PM Changeset in webkit [221540] by Chris Dumez

7 edits
2 adds in trunk

Implement FileSystemDirectoryEntry.getDirectory()
https://bugs.webkit.org/show_bug.cgi?id=176168
<rdar://problem/34187787>

Reviewed by Darin Adler.

Source/WebCore:

Implement FileSystemDirectoryEntry.getDirectory() as per:

https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getdirectory

Test: editing/pasteboard/datatransfer-items-drop-getDirectory.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::isValidVirtualPath):
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::getEntry):

Modules/entriesapi/DOMFileSystem.h:
Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getEntry):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):

Modules/entriesapi/FileSystemDirectoryEntry.h:

LayoutTests:

Add layout test coverage.

editing/pasteboard/datatransfer-items-drop-getDirectory-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getDirectory.html: Added.
platform/wk2/TestExpectations:

11:31 AM Changeset in webkit [221539] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Performance / PerformanceObserver leaks seen on bots
https://bugs.webkit.org/show_bug.cgi?id=176269

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.

page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::removeAllEventListeners):
Also use this opportunity to break up the reference cycle
between PerformanceObservers and the Performance object.

page/Performance.h:
page/Performance.cpp:

(WebCore::Performance::removeAllObservers):
Disassociate and clear observers.

page/PerformanceObserver.h:
page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::disassociate):
Clear the back-reference to the Performance object to
break the cycle.

11:29 AM Changeset in webkit [221538] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Web Automation: -[_WKAutomationSession init] leaks
https://bugs.webkit.org/show_bug.cgi?id=176268

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.

UIProcess/API/Cocoa/_WKAutomationSession.mm:

(-[_WKAutomationSession init]):

3:48 AM Changeset in webkit [221537] by timothy_horton@apple.com

12 edits in trunk/Source/WebKit

Fix some style issues in the Web Process part of the Remote Layer Tree code
https://bugs.webkit.org/show_bug.cgi?id=176272

Reviewed by Dan Bernstein.

In bug 176271, the style bot noticed some existing style issues in the UI-side
compositing code. Fix them, because there aren't many and they're straightforward.

WebProcess/WebPage/Cocoa/RemoteLayerTree/GraphicsLayerCARemote.cpp:
WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.h:
WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::setValues):

WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::appendSublayer):
(WebKit::PlatformCALayerRemote::insertSublayer):
(WebKit::PlatformCALayerRemote::replaceSublayer):

WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.h:
WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone const):

WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h:
WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeContext.h:
WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.h:
WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.mm:

2:38 AM Changeset in webkit [221536] by timothy_horton@apple.com

4 edits
3 copies
16 moves
1 add
1 delete in trunk/Source/WebKit

Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176271

Rubber-stamped by Dan Bernstein.

UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.

WebKit.xcodeproj/project.pbxproj:
DerivedSources.make:
PlatformMac.cmake:
WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp.
WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.h.
WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h: Renamed from WebProcess/WebPage/mac/PlatformCAAnimationRemote.h.
WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: Renamed from WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemote.cpp.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemote.h.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.cpp: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp.
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeContext.h.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeContext.mm.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h: Renamed from WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.h.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm: Renamed from WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h.
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm.
WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.h.
WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in.
WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.mm.

2:14 AM Changeset in webkit [221535] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.18

Merge r221501 - Wrong getComputedStyle behavior for pseudo-elements for layout-dependent properties.
https://bugs.webkit.org/show_bug.cgi?id=175936

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-01
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
web-platform-tests/cssom/getComputedStyle-pseudo.html: Sync test with upstream.

Source/WebCore:

Before this patch we may wrongly end up using the wrong renderer to resolve
this.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledElement const):
(WebCore::ComputedStyleExtractor::styledRenderer const):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSComputedStyleDeclaration.h:

2:13 AM Changeset in webkit [221534] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.18

transformCanLikelyUseFastPath() can read off the end of a string
https://bugs.webkit.org/show_bug.cgi?id=176232
rdar://problem/33851237

Reviewed by Tim Horton.
Source/WebCore:

Code added in r220382 could read one byte past the end of the string when looking for the 'z'
of a rotateZ() function. The code was actually incorrect, testing for the 'z at i+6 after
already incrementing i by 6. This patch makes the code correctly detect rotateZ().

Also, rotate functions at the end of a string could be ignored because kShortestValidTransformStringLength
was too long, so set it to the length of "rotate(0)", the shortest transform function that we currently
fast-parse.

There's an implicit assumption in this code that chars is not indexed past i+kShortestValidTransformStringLength.
If the 'translate' path is taken, i is incremented by 9 (==kShortestValidTransformStringLength), but that's
OK because WTF::find() doesn't index into chars if i >= length.

Test: fast/css/transform-fast-paths.html

css/parser/CSSParserFastPaths.cpp:

(WebCore::transformCanLikelyUseFastPath):

LayoutTests:

fast/css/transform-fast-paths-expected.txt: Added.
fast/css/transform-fast-paths.html: Added.

2:13 AM Changeset in webkit [221533] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r221474 - [GTK] Improve the way unit test are run and the results reported
https://bugs.webkit.org/show_bug.cgi?id=176104

Reviewed by Carlos Alberto Lopez Perez.

There are several issues with the way unit tests are run by run-gtk-tests and also with the way results are
reported:

The results summary only mentions the test binaries, not the actual test cases, so you always have to scroll up to find the actual test cases failing.
The number of reported failures is the number of test binaries that failed, so if a new test case fails for the same binary in a new revision, we won't notice it just looking at the number of failures.
We show detailed information about skipped test in the results summary, which is just noise.
In the case of glib tests, when a test case times out, we finish the test suite, instead of continuing with the rest of the test cases like we do for normal failures or crashes. If a new test case fails after a test case that timed out we will not notice it until we fix or skip the test cases timing out.
In the case of glib tests, the timeout is applied to the whole suite, instead of per test case, we have a hack to make it longer only for that. It has worked so far, but it doesn't scale, and it's an ugly hack.
It's not currently possible to detect flaky tests, because again, we know the binaries/suites that failed but not the actual test cases.

This patch fixes all these issues and makes it possible to add support for flaky tests in a follow up patch.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete): Update the RunGtkAPITests step to parse the new output.

Scripts/run-gtk-tests:

(TestRunner._start_timeout): Helper to start the timeout if needed.
(TestRunner._start_timeout._alarm_handler): Raise timeout exception.
(TestRunner._stop_timeout): Helper to stop the timeout if needed.
(TestRunner._waitpid): Merged waitpid and return_code_from_exit_status.
(TestRunner._run_test_glib): Do not double the timeout anymore, we now start/stop the timeout for every test
case. Return a dictionary where keys are test cases and values the results only in case of failures.
(TestRunner._run_test_glib.parse_line): Update the parser to also detect test cases and the results.
(TestRunner._run_test_glib.parse_line.set_test_result): Helper to set the result of a test case.
(TestRunner._run_google_test): Return a dictionary where key is the test case and value is the result only in
case of failure.
(TestRunner._run_google_test_suite): Updated now that _run_google_test returns a dictionary.
(TestRunner.run_tests): Handle the results dictionary and show the results with information about test cases
failing and grouped by test binaries.

1:53 AM Changeset in webkit [221532] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221469 - Another attempt to fix the Apple Windows build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Temporarily weaken the size check for RenderStyle from a strict equality to <=.

rendering/style/RenderStyle.cpp:

1:53 AM Changeset in webkit [221531] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221467 - Attempt to fix the Apple Windows and WinCairo build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Explicitly cast PseudoIds to unsigned before computing a difference between two PseudoIds.

rendering/style/RenderStyle.h:

1:53 AM Changeset in webkit [221530] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221459 - Make RenderStyle's non-inherited flags more human friendly
https://bugs.webkit.org/show_bug.cgi?id=176171

Reviewed by Antti Koivisto.

Revert r166465 as we never followed through and made the CSS JIT update
RenderStyle's non-inherited flags directly.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::styleType const):
(WebCore::RenderStyle::setStyleType):
(WebCore::RenderStyle::setHasViewportUnits):
(WebCore::RenderStyle::hasViewportUnits const):
(WebCore::RenderStyle::affectedByHover const):
(WebCore::RenderStyle::affectedByActive const):
(WebCore::RenderStyle::affectedByDrag const):
(WebCore::RenderStyle::setAffectedByHover):
(WebCore::RenderStyle::setAffectedByActive):
(WebCore::RenderStyle::setAffectedByDrag):
(WebCore::RenderStyle::isFloating const):
(WebCore::RenderStyle::display const):
(WebCore::RenderStyle::position const):
(WebCore::RenderStyle::floating const):
(WebCore::RenderStyle::overflowX const):
(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::verticalAlign const):
(WebCore::RenderStyle::unicodeBidi const):
(WebCore::RenderStyle::clear const):
(WebCore::RenderStyle::tableLayout const):
(WebCore::RenderStyle::hasExplicitlySetDirection const):
(WebCore::RenderStyle::isLink const):
(WebCore::RenderStyle::setDisplay):
(WebCore::RenderStyle::setOriginalDisplay):
(WebCore::RenderStyle::setPosition):
(WebCore::RenderStyle::setFloating):
(WebCore::RenderStyle::setOverflowX):
(WebCore::RenderStyle::setOverflowY):
(WebCore::RenderStyle::setVerticalAlign):
(WebCore::RenderStyle::setUnicodeBidi):
(WebCore::RenderStyle::setClear):
(WebCore::RenderStyle::setTableLayout):
(WebCore::RenderStyle::setHasExplicitlySetDirection):
(WebCore::RenderStyle::setIsLink):
(WebCore::RenderStyle::hasExplicitlySetWritingMode const):
(WebCore::RenderStyle::setHasExplicitlySetWritingMode):
(WebCore::RenderStyle::hasExplicitlySetTextAlign const):
(WebCore::RenderStyle::setHasExplicitlySetTextAlign):
(WebCore::RenderStyle::unique const):
(WebCore::RenderStyle::setUnique):
(WebCore::RenderStyle::emptyState const):
(WebCore::RenderStyle::setEmptyState):
(WebCore::RenderStyle::firstChildState const):
(WebCore::RenderStyle::setFirstChildState):
(WebCore::RenderStyle::lastChildState const):
(WebCore::RenderStyle::setLastChildState):
(WebCore::RenderStyle::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyle::hasExplicitlyInheritedProperties const):
(WebCore::RenderStyle::inheritUnicodeBidiFrom):
(WebCore::RenderStyle::NonInheritedFlags::operator!= const):
(WebCore::RenderStyle::NonInheritedFlags::hasAnyPublicPseudoStyles const):
(WebCore::RenderStyle::originalDisplay const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::NonInheritedFlags::hasPseudoStyle const):
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyle):
(WebCore::RenderStyle::NonInheritedFlags::overflowX const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowX): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::overflowY const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowY): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::clear const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setClear): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::effectiveDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEffectiveDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::position const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setPosition): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::originalDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOriginalDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::unicodeBidi const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setUnicodeBidi): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasViewportUnits const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::verticalAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setVerticalAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlyInheritedProperties const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlyInheritedProperties): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isFloating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::floating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFloating): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::tableLayout const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setTableLayout): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::styleType const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setStyleType): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isUnique const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::emptyState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEmptyState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::firstChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::lastChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByHover const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByActive const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByDrag const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByDrag): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isLink const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsLink): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetDirection const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetDirection): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetWritingMode const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetWritingMode): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetTextAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetTextAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagsMemoryOffset): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagPseudoStyle): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::NonInheritedFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateBoolean): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getBoolean const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateValue): Deleted.
(WebCore::RenderStyle::InheritedFlags::operator== const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getValue const): Deleted.
(WebCore::adjustForAbsoluteZoom): Deleted.
(WebCore::adjustFloatForAbsoluteZoom): Deleted.
(WebCore::adjustLayoutUnitForAbsoluteZoom): Deleted.
(WebCore::collapsedBorderStyle): Deleted.
(WebCore::RenderStyle::hasBackground const): Deleted.
(WebCore::RenderStyle::autoWrap): Deleted.
(WebCore::RenderStyle::preserveNewline): Deleted.
(WebCore::RenderStyle::collapseWhiteSpace): Deleted.
(WebCore::RenderStyle::isCollapsibleWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakOnlyAfterWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakWords const): Deleted.
(WebCore::RenderStyle::hasInlineColumnAxis const): Deleted.
(WebCore::RenderStyle::imageOrientation const): Deleted.
(WebCore::RenderStyle::setLogicalWidth): Deleted.
(WebCore::RenderStyle::setLogicalHeight): Deleted.
(WebCore::RenderStyle::setBorderRadius): Deleted.
(WebCore::RenderStyle::setZoom): Deleted.
(WebCore::RenderStyle::setEffectiveZoom): Deleted.
(WebCore::RenderStyle::setTextOrientation): Deleted.
(WebCore::RenderStyle::adjustBackgroundLayers): Deleted.
(WebCore::RenderStyle::adjustMaskLayers): Deleted.
(WebCore::RenderStyle::clearAnimations): Deleted.
(WebCore::RenderStyle::clearTransitions): Deleted.
(WebCore::RenderStyle::setShapeOutside): Deleted.
(WebCore::RenderStyle::setShapeImageThreshold): Deleted.
(WebCore::RenderStyle::setClipPath): Deleted.
(WebCore::RenderStyle::willChangeCreatesStackingContext const): Deleted.
(WebCore::RenderStyle::isDisplayRegionType const): Deleted.
(WebCore::RenderStyle::setWritingMode): Deleted.
(WebCore::RenderStyle::getShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getShadowBlockDirectionExtent const): Deleted.
(WebCore::RenderStyle::isDisplayReplacedType): Deleted.
(WebCore::RenderStyle::isDisplayInlineType): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleBox): Deleted.
(WebCore::RenderStyle::isDisplayGridBox): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleOrGridBox): Deleted.
(WebCore::RenderStyle::hasAnyPublicPseudoStyles const): Deleted.
(WebCore::RenderStyle::hasPseudoStyle const): Deleted.
(WebCore::RenderStyle::setHasPseudoStyle): Deleted.
(WebCore::RenderStyle::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::setBoxReflect): Deleted.
(WebCore::pseudoElementRendererIsNeeded): Deleted.

1:39 AM Changeset in webkit [221529] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.18

Merge r221423 - REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame()

!needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()

https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser and Antti Koivisto.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.

dom/Document.h: Updated for above change.

page/FrameView.cpp:

(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to 25 passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a additional passes are needed, which is what happens
in the test that was failing. We can eventually improve this further, but this resolves
the immediate problem we are seeing in the test.

LayoutTests:

platform/mac-wk2/TestExpectations: Re-enable the disabled test.

1:35 AM Changeset in webkit [221528] by Yusuke Suzuki

27 edits
5 adds in trunk

[DFG] Relax arity requirement
https://bugs.webkit.org/show_bug.cgi?id=175523

Reviewed by Saam Barati.

JSTests:

stress/arity-mismatch-arguments-length.js: Added.

(shouldBe):
(test1):
(test):

stress/arity-mismatch-get-argument.js: Added.

(shouldBe):
(builtin.createBuiltin):
(test):

stress/arity-mismatch-inlining-extra-slots.js: Added.

(shouldBe):
(inlineTarget):
(test):

stress/arity-mismatch-inlining.js: Added.

(shouldBe):
(inlineTarget):
(test):

stress/arity-mismatch-rest.js: Added.

(shouldBe):
(test2):
(test1):
(test):

Source/JavaScriptCore:

Our DFG pipeline gives up inlining when the arity of the target function is more than the number of the arguments.
It effectively prevents us from inlining and optimizing functions, which takes some optional arguments in the form
of the pre-ES6.

This patch removes the above restriction by performing the arity fixup in DFG.

SixSpeed shows improvement when we can inline arity-mismatched functions. (For example, calling generator.next()).

baseline patched

defaults.es5 1232.1226+-20.6775 ^{442.3326+-26.1883} definitely 2.7855x faster
rest.es6 5.3406+-0.8588 ^{3.5812+-0.5388} definitely 1.4913x faster
spread-generator.es6 320.9107+-12.4808 310.4295+-12.0047 might be 1.0338x faster
generator.es6 318.3514+-9.6023 ^{286.4974+-12.6203} definitely 1.1112x faster

bytecode/InlineCallFrame.cpp:

(JSC::InlineCallFrame::dumpInContext const):

bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::InlineCallFrame):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGArgumentsUtilities.cpp:

(JSC::DFG::argumentsInvolveStackSlot):
(JSC::DFG::emitCodeToGetArgumentsArrayLength):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::getArgumentCount):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::validateReferences):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::emitRestoreArguments):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitGetLength):
(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):

ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readInlinedFrame):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::argumentsStart):

jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createWithInlineFrame):

runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::numberOfExtraSlots):
(JSC::CommonSlowPaths::numberOfStackPaddingSlots):
(JSC::CommonSlowPaths::numberOfStackPaddingSlotsWithExtraSlots):
(JSC::CommonSlowPaths::arityCheckFor):

runtime/StackAlignment.h:

(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

1:20 AM Changeset in webkit [221527] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.18

Merge r221420 - [GTK] Several InputMethodFilter tests are failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=176158

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::confirmCurrentComposition): Return early in testing mode because the page is not available.
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting): Use hexadecimal numbers for
logging key codes.

Tools:

This started to happen after the GTK+ upgrade from 3.16 to 3.22 in the internal jhbuild. Now, GtkIMContext
doesn't emit the preedit signals when using the compose key (GDK_KEY_Multi_key). The composition results are
committed directly when they are ready. The test InputMethodFilterComposeKey was failing because it expected
preedit events that no longer happen. Tests InputMethodFilterContextFocusOutDuringOngoingComposition and
InputMethodFilterContextMouseClickDuringOngoingComposition were crashing because InputMethodFilter::confirmCurrentComposition()
accessed the WebPageProxy unconditionally, that is not available in testing mode. I wonder how this ever
worked. Other tests results have also been updated because logHandleKeyboardEventWithCompositionResultsForTesting()
now uses hexadecimal numbers for the key codes, for consistency with all other event logs.

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
(TestWebKitAPI::TEST):
(TestWebKitAPI::verifyCanceledComposition): Deleted.

1:20 AM Changeset in webkit [221526] by Carlos Garcia Campos

8 edits in releases/WebKitGTK/webkit-2.18

Merge r221419 - [GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
https://bugs.webkit.org/show_bug.cgi?id=176154

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

In Wayland gdk_keymap_get_entries_for_keyval() can return TRUE with n_keys=0. We have several places in WebKit
where we just check the return value of gdk_keymap_get_entries_for_keyval() and then use the returned array to
get the first position assuming it has at least one item. This has always worked in X11 because the GDK X11
backend does the right thing, but it's crashing in Wayland now. It should be fixed in GTK+ but in the meantime
it's easy to workaround by also checking n_keys > 0.

UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::keyStroke):

TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

1:16 AM Changeset in webkit [221525] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r221416 - Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.

It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro

numbers into a version string, using the same approach as WebKitAutomationSession.

1:15 AM Changeset in webkit [221524] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/gtk/po

Merge r221411 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=176107

Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2017-08-30
Rubber-stamped by Michael Catanzaro.

pt_BR.po:

1:14 AM Changeset in webkit [221523] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.18

Merge r221408 - Previous elements with lang= can affect fonts selected for subsequent elements
https://bugs.webkit.org/show_bug.cgi?id=175959
<rdar://problem/33785853>

Reviewed by Zalan Bujtas.

Source/WebCore:

FontCascade::update() was erroneously getting a cache hit. Elements with different lang=
should be distinct inside the FontCascadeCache. We should be keying off of the locale
string instead of the script enum because the string is the thing we actually pass to the
platform APIs when performing font selection. This is a regression because we only
recently (within the past few years) started making font selection sensitive to lang= at
all.

Test: fast/text/lang-font-selection-cache.html

platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator== const):
(WebCore::FontDescriptionKey::computeHash const):

LayoutTests:

fast/text/lang-font-selection-cache-expected.html: Added.
fast/text/lang-font-selection-cache.html: Added.

1:10 AM Changeset in webkit [221522] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.18

Merge r221400 - semicolon is being interpreted as an = in the LiteralParser
https://bugs.webkit.org/show_bug.cgi?id=176114

Reviewed by Oliver Hunt.

JSTests:

stress/jsonp-literal-parser-semicolon-is-not-assignment.js: Added.
stress/resources/literal-parser-test-case.js: Added.

Source/JavaScriptCore:

When lexing a semicolon in the LiteralParser, we were properly
setting the TokenType on the current token, however, we were
*returning* the wrong TokenType. The lex function both returns
the TokenType and sets it on the current token. Semicolon was
setting the TokenType to semicolon, but returning the TokenType
for '='. This caused programs like x;123 to be interpreted as
x=123.

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::next):

1:10 AM Changeset in webkit [221521] by Carlos Garcia Campos

5 edits in trunk/Source

[GTK][Wayland] Use fast malloc to allocate backing store cairo surfaces data
https://bugs.webkit.org/show_bug.cgi?id=176226

Reviewed by Michael Catanzaro.

Source/WebCore:

platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:

platform/graphics/cairo/BackingStoreBackendCairoImpl.h:

Source/WebKit:

UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

1:01 AM Changeset in webkit [221520] by Carlos Garcia Campos

27 edits
7 adds in releases/WebKitGTK/webkit-2.18

Merge r221377 - The SVG fragment identifier is not respected if it is a part of an HTTP URL
https://bugs.webkit.org/show_bug.cgi?id=163811

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-30
Reviewed by Darin Adler.

Source/WebCore:

If an image is referenced more than once in a page and the URL to that
image is an HTTP URL, one CachedImage is created for all the renderers
even if the original URLs have different fragmentIdentifiers. In this
case the fragment will be removed from the request which is associated
with the shared CachedImage. This CachedImage creates an SVGImage with
a URL but without a fragmentIdentifier. So SVGImage::draw() does not call
FrameView::scrollToFragment() and therefore the viewport is not setup
correctly for displaying the SVG in this case.

The fix is to move the url from the SVGImage to SVGImageForContainer.
Because there is one SVGImageForContainer created for every renderer,
we can move the full URL there. The drawing of an SVGImage has to start
from the SVGImageForContainer::draw() because the SVGImage may not have
an intrinsic size and the SVGImageForContainer is the one which knows
the destination rectangle. So SVGImageForContainer can pass the full url
to SVGImage::drawForContainer() which can be used to scrollToFragment()
before calling SVGImage::draw().

For clarity and consistency, all setContainerSizeForRenderer() will be
changed to setContainerContext() and the pair SizeAndZoom will be replaced
by the struct ContainerContext.

Tests: http/tests/svg/svg-fragment-background.html

http/tests/svg/svg-fragment-image.html

css/CSSCursorImageValue.h:
css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

css/CSSImageSetValue.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::switchClientsToRevalidatedResource):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::setContainerContextForClient):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::setContainerSizeForRenderer): Deleted.

loader/cache/CachedImage.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry const):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

rendering/RenderImage.cpp:

(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::repaintOrMarkForLayout):

rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::setContainerContext):
(WebCore::RenderImageResource::setContainerSizeForRenderer): Deleted.

rendering/RenderImageResource.h:
rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::setContainerContext):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Deleted.

rendering/RenderImageResourceStyleImage.h:
rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::updateContent):

rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::createShapeForImage const):

rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::imageURL):
(WebCore::StyleCachedImage::setContainerContextForRenderer):
(WebCore::StyleCachedImage::setContainerSizeForRenderer): Deleted.

rendering/style/StyleCachedImage.h:
rendering/style/StyleGeneratedImage.h:
rendering/style/StyleImage.h:
rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::updateImageViewport):

svg/SVGImageElement.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::SVGImage):
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dump const): Deleted.

svg/graphics/SVGImage.h:
svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::setContainerContextForClient):
(WebCore::SVGImageCache::setContainerSizeForRenderer): Deleted.

svg/graphics/SVGImageCache.h:
svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::size const):
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

svg/graphics/SVGImageForContainer.h:

LayoutTests:

http/tests/svg/resources/rgb-icons-1.svg: Added.
http/tests/svg/resources/rgb-icons-2.svg: Added.
http/tests/svg/resources/rgb-icons-3.svg: Added.
http/tests/svg/svg-fragment-background-expected.html: Added.
http/tests/svg/svg-fragment-background.html: Added.
http/tests/svg/svg-fragment-image-expected.html: Added.
http/tests/svg/svg-fragment-image.html: Added.

12:50 AM Changeset in webkit [221519] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.18

Merge r221335 - Assertion failure when opening a file with a missing tag closing bracket
https://bugs.webkit.org/show_bug.cgi?id=176061

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-29
Reviewed by Darin Adler.

Source/WebCore:

If a tag is missing its closing bracket, the tokenizer just needs to advance()
the character position without checking m_currentCharacter != '\n'. Newline
character is a valid ending for partially closed tags.

Test: fast/tokenizer/missing-script-tag-closing-bracket.html

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::commitToPartialEndTag):

LayoutTests:

fast/tokenizer/missing-script-tag-closing-bracket-expected.txt: Added.
fast/tokenizer/missing-script-tag-closing-bracket.html: Added.

12:48 AM Changeset in webkit [221518] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r221295 - Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.

The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
Test::getResourcesDir() were updated to use the new name.

Scripts/run-gtk-tests:

(TestRunner._setup_testing_environment):

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::getResourcesDir):

12:47 AM Changeset in webkit [221517] by Carlos Garcia Campos

4 edits
250 moves
3 adds in releases/WebKitGTK/webkit-2.18/Tools

Merge r221219 - Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.

Rubber-stamped by Brady Eidson.

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldPlugIn.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldProtocol.h: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/password-protected.pages: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Removed.
TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2Gtk: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Removed.
TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Removed.
TestWebKitAPI/Tests/WebKit2ObjC: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Removed.
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Removed.
TestWebKitAPI/Tests/WebKitCocoa: Copied from TestWebKitAPI/Tests/WebKit2Cocoa.
TestWebKitAPI/Tests/WebKitGtk: Copied from TestWebKitAPI/Tests/WebKit2Gtk.
TestWebKitAPI/Tests/WebKitObjC: Copied from TestWebKitAPI/Tests/WebKit2ObjC.
TestWebKitAPI/glib/PlatformGTK.cmake:

12:42 AM Changeset in webkit [221516] by Carlos Garcia Campos

5 edits
202 moves
3 adds in releases/WebKitGTK/webkit-2.18/Tools

Merge r221218 - Rename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.

Rubber-stamped by Brady Eidson.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWin.cmake:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit: Copied from TestWebKitAPI/Tests/WebKit2.
TestWebKitAPI/Tests/WebKit2: Removed.
TestWebKitAPI/Tests/WebKit2/18-characters.html: Removed.
TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Removed.
TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Removed.
TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/Find.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Removed.
TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: Removed.
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Removed.
TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Removed.
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Removed.
TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Removed.
TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKString.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Removed.
TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Removed.
TestWebKitAPI/Tests/WebKit2/bundle-file.html: Removed.
TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Removed.
TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Removed.
TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Removed.
TestWebKitAPI/Tests/WebKit2/cocoa: Removed.
TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Removed.
TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Removed.
TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Removed.
TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Removed.
TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Removed.
TestWebKitAPI/Tests/WebKit2/execCopy.html: Removed.
TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Removed.
TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Removed.
TestWebKitAPI/Tests/WebKit2/file-with-video.html: Removed.
TestWebKitAPI/Tests/WebKit2/find.html: Removed.
TestWebKitAPI/Tests/WebKit2/findRanges.html: Removed.
TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Removed.
TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Removed.
TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Removed.
TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Removed.
TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Removed.
TestWebKitAPI/Tests/WebKit2/gtk: Removed.
TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/icon.png: Removed.
TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Removed.
TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Removed.
TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Removed.
TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Removed.
TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Removed.
TestWebKitAPI/Tests/WebKit2/link-with-title.html: Removed.
TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Removed.
TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Removed.
TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Removed.
TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Removed.
TestWebKitAPI/Tests/WebKit2/mac: Removed.
TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Removed.
TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Removed.
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Removed.
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Removed.
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Removed.
TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Removed.
TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Removed.
TestWebKitAPI/Tests/WebKit2/many-iframes.html: Removed.
TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Removed.
TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Removed.
TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Removed.
TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Removed.
TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Removed.
TestWebKitAPI/Tests/WebKit2/no-autoplay-with-controls.html: Removed.
TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Removed.
TestWebKitAPI/Tests/WebKit2/push-state.html: Removed.
TestWebKitAPI/Tests/WebKit2/set-long-title.html: Removed.
TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple-form.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple-tall.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple2.html: Removed.
TestWebKitAPI/Tests/WebKit2/simple3.html: Removed.
TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Removed.
TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Removed.
TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Removed.
TestWebKitAPI/Tests/WebKit2/test.mp4: Removed.
TestWebKitAPI/Tests/WebKit2/test.pdf: Removed.
TestWebKitAPI/Tests/WebKit2/webfont.html: Removed.

12:38 AM Changeset in webkit [221515] by Carlos Garcia Campos

2 edits
11 moves
3 adds in releases/WebKitGTK/webkit-2.18/Tools

Merge r221217 - Rename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.

Rubber-stamped by Brady Eidson.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit: Removed.
TestWebKitAPI/Tests/WebKit/ios: Removed.
TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Removed.
TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Removed.
TestWebKitAPI/Tests/WebKit/ios/audio-only.html: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Removed.
TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Removed.
TestWebKitAPI/Tests/WebKit/win: Removed.
TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Removed.
TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed.
TestWebKitAPI/Tests/WebKitLegacy: Copied from TestWebKitAPI/Tests/WebKit.

12:05 AM Changeset in webkit [221514] by Carlos Garcia Campos

5 edits in trunk/Source/WebKit

[GTK][Wayland] Opening FedoraProject's pastebin chews CPU
https://bugs.webkit.org/show_bug.cgi?id=175942

Reviewed by Žan Doberšek.

UIProcess/gtk/WaylandCompositor.cpp:

UIProcess/gtk/WaylandCompositor.h:

(WebKit::WaylandCompositor::Surface::setWebPage): Moved to the cpp.

WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:

WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:

Sep 1, 2017:

7:33 PM Changeset in webkit [221513] by fpizlo@apple.com

5 edits
4 adds in trunk/Tools

WSL should check unreachable code and no returns
https://bugs.webkit.org/show_bug.cgi?id=176262

Reviewed by Myles Maxfield.

This adds phases to check whether non-void functions return and whether there is any code after
a return in any block. Added tests for simple versions of both of those things. We cannot add
more complex versions until we support control flow statements.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CheckReturns.js: Added.

(checkReturns):

WebGPUShadingLanguageRI/CheckUnreachableCode.js: Added.

(checkUnreachableCode):

WebGPUShadingLanguageRI/Parse.js:

(parseReturn):

WebGPUShadingLanguageRI/Prepare.js:

(prepare):

WebGPUShadingLanguageRI/ReturnChecker.js: Added.

(ReturnChecker.prototype.visitFuncDef):
(ReturnChecker.prototype.visitBlock):
(ReturnChecker.prototype.visitReturn):
(ReturnChecker):

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleNoReturn):

WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Added.

(UnreachableCodeChecker.prototype.visitBlock):
(UnreachableCodeChecker):

6:38 PM Changeset in webkit [221512] by weinig@apple.com

21 edits in trunk

DOMMatrix and DOMMatrixReadOnly should be available in workers
https://bugs.webkit.org/show_bug.cgi?id=176255

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker-expected.txt:
web-platform-tests/css/geometry-1/interfaces.worker-expected.txt:

Update test results.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Add GlobalPerformance.idl to the project. It was missing.

bindings/scripts/CodeGeneratorJS.pm:

(IsAlwaysExposedOnInterface):
(NeedsRuntimeCheck):
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateRuntimeEnableConditionalString):

Adds support for [Exposed] extended attributes on operations, attributes and
constants. This allows an interface that is exposed to both windows and workers
(with [Exposed=(Window,Worker)]), to indicate that a specific property should
only be be exposed somewhere, e.g only the window. This is need by DOMMatrixReadOnly's
stringifier, which is only exposed in the window environment.

bindings/scripts/IDLParser.pm:

(parseExtendedAttributeRest2):

Fix bug where array extended attributes, like those found in Exposed expressions
where being converter to scalars.

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/TestObj.idl:

Add tests and update results. Some results are just improved
includes.

css/DOMMatrix.cpp:
css/DOMMatrix.h:
css/DOMMatrix.idl:
css/DOMMatrixReadOnly.cpp:
css/DOMMatrixReadOnly.h:
css/DOMMatrixReadOnly.idl:

Expose DOMMatrix and DOMMatrixReadOnly to workers and update the constructors
to match the current spec, throwing if the argument is a string, and the context
is not the window / document context. Also did some refactoring to avoid allocating
the DOMMatrix or DOMMatrixReadOnly until after all the exceptional cases were handled.

LayoutTests:

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

5:57 PM Changeset in webkit [221511] by fpizlo@apple.com

7 edits in trunk/Tools

WSL should use & for getting a ^{and @ for getting a []

https://bugs.webkit.org/show_bug.cgi?id=176245}

Reviewed by Myles Maxfield.

Using \ as an operator was a bad decision since that's an escape character in so many contexts.

Henceforth, & is for making pointers, for example:

thread int^{foo() { int x; return &x; }

And @ is for making array references, for example:

thread int[] foo() { int[42] x; return @x; }

Having separate operators makes it easy to have pointers to fixed-size arrays:

thread int[42]} foo() { int[42] x; return &x; }

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/MakePtrExpression.js:

(MakePtrExpression.prototype.toString):
(MakePtrExpression):

WebGPUShadingLanguageRI/Parse.js:

(parsePossibleSuffix):
(parsePossiblePrefix):
(parseFuncName):

WebGPUShadingLanguageRI/StandardLibrary.js:
WebGPUShadingLanguageRI/Test.js:

(TEST_simpleMakePtr):

5:19 PM Changeset in webkit [221510] by Chris Dumez

6 edits
2 adds in trunk

Implement FileSystemDirectoryEntry.getFile()
https://bugs.webkit.org/show_bug.cgi?id=176167
<rdar://problem/34187775>

Reviewed by Andreas Kling.

Source/WebCore:

Implement FileSystemDirectoryEntry.getFile():

https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getfile

Test: editing/pasteboard/datatransfer-items-drop-getFile.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::isValidPathNameCharacter):
(WebCore::isValidPathSegment):
(WebCore::isValidRelativeVirtualPath):
(WebCore::isValidAbsoluteVirtualPath):
(WebCore::isValidVirtualPath):
Implement various path validation functions as per:

https://wicg.github.io/entries-api/#names-paths

(WebCore::resolveRelativeVirtualPath):

Use StringView for second parameter for efficiency. Had to keep a String for the first parameter because I need the split to return a Vector.
If the input path is absolute, call recursively with '/' as base path so that the virtual path gets sanitized (i.e. '..' and '.' in the absolute URL get resolved).

(WebCore::DOMFileSystem::listDirectory):
Use String instead of auto. It is not much longer and is clearer.

(WebCore::validatePathIsDirectory):
(WebCore::DOMFileSystem::getParent):
Move logic to validate that the path is a directory from getParent() to a
separate function. This only makes sure the ScriptExecutionContext is only
ref'd / deref'd on the main thread.

(WebCore::validatePathIsFile):
Logic for validating that a path is a file, used by getFile().

(WebCore::DOMFileSystem::getFile):
Implement getFile() as per:

https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getfile

Modules/entriesapi/DOMFileSystem.h:
Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getFile):
Add implementation of FileSystemDirectoryEntry::getFile() which merely calls
DOMFileSystem::getFile().

LayoutTests:

Add layout test coverage.

editing/pasteboard/datatransfer-items-drop-getFile-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getFile.html: Added.

4:59 PM Changeset in webkit [221509] by beidson@apple.com

2 edits in trunk/Source/WebCore

ASSERTION FAILED: taken.get() == &job in WebCore::ServiceWorkerContainer::jobDidFinish(WebCore::ServiceWorkerJob &).
https://bugs.webkit.org/show_bug.cgi?id=176234

Rubberstamped by Tim Horton, reluctantly.

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobDidFinish): It's valid for the job to be missing after navigations, which is

why this was hitting downstream tests.

4:54 PM Changeset in webkit [221508] by mmaxfield@apple.com

3 edits in trunk/Tools

WSL's lexer will never emit keyword tokens
https://bugs.webkit.org/show_bug.cgi?id=176248

Reviewed by Filip Pizlo.

Because all tokens are also identified as idents, we need to handle them together.

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/Test.js:

(doLex):
(checkLexerToken):
(TEST_lexerKeyword):

4:43 PM Changeset in webkit [221507] by Matt Lewis

2 edits in trunk/LayoutTests

Skipped multiple webgl tests.
<rdar://problem/34209038>

Unreviewed test gardening.

platform/ios-11/TestExpectations:

4:28 PM Changeset in webkit [221506] by commit-queue@webkit.org

8 edits in trunk/Source

Do not Reject CacheStorage promises when updating the persistent filesystem data fails
https://bugs.webkit.org/show_bug.cgi?id=176241

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

Source/WebCore:

Open/Remove caches may succeed in updating the memory representation but the write-to-disk operation may fail.
In that case, the corresponding promise is now resolved since the web page can still proceeed.

There is no way to test that currently as this would require a write disk failure to be triggered.

Modules/cache/CacheStorage.cpp:

(WebCore::logConsolePersistencyError):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

Modules/cache/DOMCacheEngine.h:

(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::encode const):
(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::decode):

Source/WebKit:

Open/Remove caches may succeed in the memory representation but the write-to-disk operation may fail.
In that case, the callback does not return an error but a value containing the cache identifier.
The value will also contain a boolean flag set to true to notify the client that persistent storage failed this time.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):

NetworkProcess/cache/CacheStorageEngineCaches.h:

3:56 PM Changeset in webkit [221505] by achristensen@apple.com

193 edits in trunk/Tools

Rename WebKit2 API tests after directory rename
https://bugs.webkit.org/show_bug.cgi?id=176250

Reviewed by Tim Horton.

TestWebKitAPI/Tests/Lots of files...

Renamed WebKit2 to WebKit and WebKit1 to WebKitLegacy.

3:53 PM Changeset in webkit [221504] by commit-queue@webkit.org

15 edits
7 adds in trunk

[Fetch API] Add support for consuming a Request ReadableStream body
https://bugs.webkit.org/show_bug.cgi?id=176182

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/fetch/request-stream-empty.html

http/wpt/fetch/request-stream-error.html

Adding a ReadableStreamSink which allows to pipe all ReadableStream data back to C++ code.
This sink only takes BufferSource as the only user is Fetch which has this restriction.
This sink is tied to the readableStreamPipeTo builtin internal function that reads all data from the ReadableStream
and send it to the sink.

Adding a ReadableStreamToSharedBufferSink specialization to get the data as a SharedBuffer.

Use that class in FetchBodyConsumer to get the data back from the ReadableStream and transform it according
the desired body type (text, JSON, ArrayBuffer).

CMakeLists.txt:
DerivedSources.make:
Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::loadingSucceeded):

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::clean):
(WebCore::FetchBodyConsumer::resolveWithData):
(WebCore::FetchBodyConsumer::resolve):

Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::finishConsumingStream):

Modules/streams/ReadableStreamInternals.js:

(readableStreamPipeTo):

Modules/streams/ReadableStreamSink.cpp: Added.

(WebCore::ReadableStreamToSharedBufferSink::ReadableStreamToSharedBufferSink):
(WebCore::ReadableStreamToSharedBufferSink::pipeFrom):
(WebCore::ReadableStreamToSharedBufferSink::enqueue):
(WebCore::ReadableStreamToSharedBufferSink::close):
(WebCore::ReadableStreamToSharedBufferSink::error):

Modules/streams/ReadableStreamSink.h: Added.
Modules/streams/ReadableStreamSink.idl: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::pipeTo):

bindings/js/ReadableStream.h:

LayoutTests:

http/wpt/fetch/request-stream-disturbed-1-expected.txt:
http/wpt/fetch/request-stream-disturbed-2-expected.txt:
http/wpt/fetch/request-stream-disturbed-3-expected.txt:
http/wpt/fetch/request-stream-empty-expected.txt: Added.
http/wpt/fetch/request-stream-empty.html: Added.
http/wpt/fetch/request-stream-error-expected.txt: Added.
http/wpt/fetch/request-stream-error.html: Added.

3:25 PM Changeset in webkit [221503] by achristensen@apple.com

12 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's toolbarsAreVisible
https://bugs.webkit.org/show_bug.cgi?id=176246
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/API/APIUIClient.h:

(API::UIClient::toolbarsAreVisible):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::toolbarsAreVisible):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getToolbarsAreVisible):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[ToolbarDelegate _webView:getToolbarsAreVisibleWithCompletionHandler:]):
(-[ToolbarDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

3:19 PM Changeset in webkit [221502] by achristensen@apple.com

9 edits
2 moves
1 add in trunk/Source/WebKit

Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=176239

Reviewed by Tim Horton.

UIProcess/Cocoa/PageClientImplCocoa.h: Added.

(WebKit::PageClientImplCocoa::PageClientImplCocoa):

UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::isPlayingAudioWillChange):
(WebKit::PageClientImplCocoa::isPlayingAudioDidChange):
(WebKit::PageClientImpl::isPlayingAudioWillChange): Deleted.
(WebKit::PageClientImpl::isPlayingAudioDidChange): Deleted.

UIProcess/Cocoa/WebViewImpl.mm:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):

UIProcess/mac/PageClientImpl.h: Removed.
UIProcess/mac/PageClientImpl.mm: Removed.
UIProcess/mac/PageClientImplMac.h: Copied from Source/WebKit/UIProcess/mac/PageClientImpl.h.
UIProcess/mac/PageClientImplMac.mm: Copied from Source/WebKit/UIProcess/mac/PageClientImpl.mm.

(WebKit::PageClientImpl::PageClientImpl):

UIProcess/mac/WebContextMenuProxyMac.mm:
UIProcess/mac/WebPageProxyMac.mm:
UIProcess/mac/WebPopupMenuProxyMac.mm:
WebKit.xcodeproj/project.pbxproj:

3:16 PM Changeset in webkit [221501] by commit-queue@webkit.org

6 edits in trunk

Wrong getComputedStyle behavior for pseudo-elements for layout-dependent properties.
https://bugs.webkit.org/show_bug.cgi?id=175936

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-01
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
web-platform-tests/cssom/getComputedStyle-pseudo.html: Sync test with upstream.

Source/WebCore:

Before this patch we may wrongly end up using the wrong renderer to resolve
this.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledElement const):
(WebCore::ComputedStyleExtractor::styledRenderer const):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSComputedStyleDeclaration.h:

3:14 PM Changeset in webkit [221500] by eric.carlson@apple.com

2 edits in trunk/Tools

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Unreviewed build fix.

TestWebKitAPI/Tests/WebCore/Logging.cpp:

3:09 PM Changeset in webkit [221499] by pvollan@apple.com

2 edits in trunk/LayoutTests

http/tests/misc/slow-loading-animated-image.html is flaky on iOS simulator and Windows.
https://bugs.webkit.org/show_bug.cgi?id=157916

Unreviewed test gardening.

platform/win/TestExpectations:

2:47 PM Changeset in webkit [221498] by pvollan@apple.com

6 edits
3 moves in trunk/Source/WebCore

[Win] Compile error, 'Cache' is not declared.
https://bugs.webkit.org/show_bug.cgi?id=176062

Reviewed by Youenn Fablet.

Rename Cache to DOMCache.

No new tests, covered by existing tests.

DerivedSources.make:
Modules/cache/Cache.cpp: Removed.
Modules/cache/Cache.h: Removed.
Modules/cache/Cache.idl: Removed.
Modules/cache/CacheStorage.cpp:

(WebCore::doSequentialMatch):
(WebCore::startSequentialMatch):
(WebCore::copyCaches):
(WebCore::CacheStorage::match):
(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):

Modules/cache/CacheStorage.h:
Modules/cache/DOMCache.cpp: Copied from Source/WebCore/Modules/cache/Cache.cpp.

(WebCore::DOMCache::DOMCache):
(WebCore::DOMCache::~DOMCache):
(WebCore::DOMCache::match):
(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::matchAll):
(WebCore::DOMCache::add):
(WebCore::DOMCache::requestFromInfo):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):
(WebCore::DOMCache::remove):
(WebCore::DOMCache::keys):
(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::queryCacheWithTargetStorage):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
(WebCore::DOMCache::updateRecords):
(WebCore::DOMCache::stop):
(WebCore::DOMCache::activeDOMObjectName const):
(WebCore::DOMCache::canSuspendForDocumentSuspension const):
(WebCore::Cache::Cache): Deleted.
(WebCore::Cache::~Cache): Deleted.
(WebCore::Cache::match): Deleted.
(WebCore::Cache::doMatch): Deleted.
(WebCore::Cache::matchAll): Deleted.
(WebCore::Cache::add): Deleted.
(WebCore::Cache::requestFromInfo): Deleted.
(WebCore::Cache::addAll): Deleted.
(WebCore::Cache::put): Deleted.
(WebCore::Cache::remove): Deleted.
(WebCore::Cache::keys): Deleted.
(WebCore::Cache::retrieveRecords): Deleted.
(WebCore::Cache::queryCache): Deleted.
(WebCore::Cache::queryCacheWithTargetStorage): Deleted.
(WebCore::Cache::batchDeleteOperation): Deleted.
(WebCore::Cache::batchPutOperation): Deleted.
(WebCore::Cache::updateRecords): Deleted.
(WebCore::Cache::stop): Deleted.
(WebCore::Cache::activeDOMObjectName const): Deleted.
(WebCore::Cache::canSuspendForDocumentSuspension const): Deleted.

Modules/cache/DOMCache.h: Copied from Source/WebCore/Modules/cache/Cache.h.
Modules/cache/DOMCache.idl: Copied from Source/WebCore/Modules/cache/Cache.idl.
WebCore.xcodeproj/project.pbxproj:

2:45 PM Changeset in webkit [221497] by fpizlo@apple.com

3 edits in trunk/Tools

WSL should have more tests of type checking failures
https://bugs.webkit.org/show_bug.cgi?id=176244

Reviewed by Myles Maxfield.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/Test.js:

(TEST_typeMismatchReturn):

2:35 PM Changeset in webkit [221496] by fpizlo@apple.com

19 edits
1 add in trunk/Tools

WSL should be be able to call a function declared in a protocol from a generic function
https://bugs.webkit.org/show_bug.cgi?id=176242

Reviewed by Myles Maxfield.

It turns out that we need to know when a function is resolved to a protocol signature, so we
need to have a type for this. This introduces ProtocolFuncDecl.

Also, this introduces parsing of protocol decls.

When instantiating a function, we need to rewrite its CallExpressions if they were previously
resolved to a PrtococolFuncDecl instead of a FuncDef or NativeFunc. In that case, we need to
rerun the resolution on the program. That resolution is guaranteed to succeed if the type
system works correctly.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallExpression.js:

(CallExpression.prototype.resolve):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

WebGPUShadingLanguageRI/Func.js:

(Func):
(Func.prototype.get origin):

WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef):
(FuncDef.prototype.get origin): Deleted.

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):

WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc):
(NativeFunc.prototype.get origin): Deleted.

WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance):

WebGPUShadingLanguageRI/Node.js:

(Node.prototype.substitute):

WebGPUShadingLanguageRI/Parse.js:

(parseProtocolFuncDecl):
(parseProtocolDecl):
(parse):

WebGPUShadingLanguageRI/Program.js:

(Program):
(Program.prototype.get protocols):
(Program.prototype.add):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.add):
(ProtocolDecl.prototype.hasHeir):
(ProtocolDecl.prototype.addSignature): Deleted.

WebGPUShadingLanguageRI/ProtocolFuncDecl.js: Added.

(ProtocolFuncDecl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitStructType):
(Rewriter.prototype.visitTypeVariable):
(Rewriter.prototype.visitProtocolFuncDecl):
(Rewriter.prototype.visitCallExpression):

WebGPUShadingLanguageRI/StructType.js:

(StructType.prototype.instantiate):

WebGPUShadingLanguageRI/Substitution.js:

(Substitution):
(Substitution.mapping): Deleted.

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):
(TEST_simpleDereference):
(TEST_dereferenceStore):
(TEST_simpleMakePtr):
(TEST_threadArrayLoad):
(TEST_deviceArrayLoad):
(TEST_threadArrayStore):
(TEST_deviceArrayStore):
(TEST_simpleProtocol):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolFuncDecl):

2:33 PM Changeset in webkit [221495] by beidson@apple.com

7 edits in trunk/Source/WebCore

Move ServiceWorkerJob from FetchLoader to ThreadableLoader.
https://bugs.webkit.org/show_bug.cgi?id=176231

Reviewed by Youenn Fablet.

No new tests (No behavior change).

WebCore.xcodeproj/project.pbxproj:

Re-indent these headers. Yuck!

loader/ThreadableLoader.h:

(WebCore::ThreadableLoader::ref):
(WebCore::ThreadableLoader::deref):
(WebCore::ThreadableLoader::ThreadableLoader):
(WebCore::ThreadableLoader::~ThreadableLoader):

loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didSendData):
(WebCore::ThreadableLoaderClient::didReceiveResponse):
(WebCore::ThreadableLoaderClient::didReceiveData):
(WebCore::ThreadableLoaderClient::didFinishLoading):
(WebCore::ThreadableLoaderClient::didFail):
(WebCore::ThreadableLoaderClient::didFinishTiming):
(WebCore::ThreadableLoaderClient::ThreadableLoaderClient):
(WebCore::ThreadableLoaderClient::~ThreadableLoaderClient):

Move from FetchLoaderClient to ThreadableLoaderClient:

workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::didReceiveData):
(WebCore::ServiceWorkerJob::didFinishLoading):
(WebCore::ServiceWorkerJob::didFail):
(WebCore::ServiceWorkerJob::didSucceed): Deleted.

workers/service/ServiceWorkerJob.h:

workers/service/server/SWClientConnection.cpp: Add a now-required include.

1:40 PM Changeset in webkit [221494] by eric.carlson@apple.com

12 edits
1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

dom/Document.h:

Convert debug-only logging to configurable release logging.

html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

html/HTMLMediaElement.h:

Source/WTF:

wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

wtf/MediaTime.h:

(PAL::LogArgument<WTF::MediaTime>::toString): Logger template.

Tools:

TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LogObserver::level const):

12:47 PM Changeset in webkit [221493] by aestes@apple.com

2 edits in trunk/Source/WebCore/PAL

Try again to fix the Internal iOS Simulator build after r221485.

pal/spi/cg/CoreGraphicsSPI.h:

12:31 PM Changeset in webkit [221492] by aestes@apple.com

2 edits in trunk/Source/WebCore/PAL

Try to fix the Internal iOS Simulator build after r221485.

pal/spi/cg/CoreGraphicsSPI.h:

12:13 PM Changeset in webkit [221491] by commit-queue@webkit.org

2 edits in trunk/Tools

download-latest-github-release.py should have friendlier output for non-404 errors
https://bugs.webkit.org/show_bug.cgi?id=176201

Patch by Ross Kirsling <Ross Kirsling> on 2017-09-01
Reviewed by Brent Fulgham.

Scripts/download-latest-github-release.py:

11:57 AM Changeset in webkit [221490] by fpizlo@apple.com

3 edits in trunk/Tools

[WSL] Add tests for storing to arrays
https://bugs.webkit.org/show_bug.cgi?id=176237

Reviewed by Myles Maxfield.

Storing to arrays works now.

WebGPUShadingLanguageRI/ArrayType.js:

(ArrayType):

WebGPUShadingLanguageRI/Test.js:

(TEST_threadArrayStore):
(TEST_deviceArrayStore):

11:54 AM Changeset in webkit [221489] by achristensen@apple.com

19 edits
1 add in trunk

Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=176212

Reviewed by Tim Horton.

Source/WebKit:

Dan suggested this in bug 176203, I think it's a good idea,
and I'll need to add more KVO properties soon anyways so I'd better learn how.
Determining if audio playing changed is important for Safari, so WKPageUIClient's
isPlayingAudioDidChange was correctly named but incorrectly fired if either audio
or video playing changed and had you check if audio was playing, possibly too often.

UIProcess/API/APIUIClient.h:

(API::UIClient::isPlayingMediaDidChange):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isPlayingAudio]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/glib/WebKitUIClient.cpp:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange): Deleted.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::isPlayingAudioWillChange):
(WebKit::WebViewImpl::isPlayingAudioDidChange):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::isPlayingAudioDidChange):
(WebKit::PageClientImpl::isPlayingAudioWillChange):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[AudioObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):
(-[MediaDelegate _webView:isPlayingMediaDidChange:]): Deleted.

11:49 AM Changeset in webkit [221488] by Simon Fraser

3 edits
2 adds in trunk

transformCanLikelyUseFastPath() can read off the end of a string
https://bugs.webkit.org/show_bug.cgi?id=176232
rdar://problem/33851237

Reviewed by Tim Horton.
Source/WebCore:

Test: fast/css/transform-fast-paths.html

css/parser/CSSParserFastPaths.cpp:

(WebCore::transformCanLikelyUseFastPath):

LayoutTests:

fast/css/transform-fast-paths-expected.txt: Added.
fast/css/transform-fast-paths.html: Added.

11:48 AM Changeset in webkit [221487] by fpizlo@apple.com

5 edits in trunk/Tools

WSL Rewriter should be an identity on things that aren't inside function bodies
https://bugs.webkit.org/show_bug.cgi?id=176208

Reviewed by Myles Maxfield.

Previously, if the Rewriter encountered a FunctionDef, StructType, NativeType, etc., then it
would either crash or try to rewrite them. That's unfortunate because we use the Rewriter to
rewrite struct and function bodies. If a function calls another function, then rewriting the
caller should not mean also rewriting the callee. Previously we "fixed" this by religiously
wrapping references to types with TypeDef and doing other such hacks. But that's subtly wrong.
It only worked because Rewriter wasn't rewriting TypeRef.type. I think that Rewriter has to
rewrite that in the long run because it may refer to another TypeRef, and it may be an
instantiation that is using types that themselves need to be rewritten.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/NullType.js:

(NullType):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncDef):
(Rewriter.prototype.visitNativeFunc):
(Rewriter.prototype.visitNativeFuncInstance):
(Rewriter.prototype.visitNativeType):
(Rewriter.prototype.visitTypeDef):
(Rewriter.prototype.visitStructType):
(Rewriter.prototype.visitTypeVariable):
(Rewriter.prototype.visitConstexprTypeParameter):
(Rewriter.prototype.visitNativeTypeInstance):
(Rewriter.prototype.visitTypeRef):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitNativeTypeInstance):

11:47 AM Changeset in webkit [221486] by achristensen@apple.com

6 edits in trunk

Disable ObjC WebGL policy SPI on iOS
https://bugs.webkit.org/show_bug.cgi?id=176233

Reviewed by Tim Horton.
Source/WebKit:

In r221465 I uploaded new SPI that is only needed on Mac with a beautiful test that only works on Mac.
Since it fails on iOS and is not needed on iOS, let's just disable it on iOS.

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm:

11:37 AM Changeset in webkit [221485] by aestes@apple.com

32 edits
1 copy in trunk/Source

[CG] Upstream CoreGraphics-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176200

Reviewed by Tim Horton.

Source/WebCore:

platform/graphics/GraphicsContext.h:
platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::subsamplingLevelForScaleFactor):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::applyShadowOffsetWorkaroundIfNeeded):

platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::GraphicsContext::focusRingColor):
(WebCore::drawFocusRingAtTime):
(WebCore::drawFocusRing):
(WebCore::drawFocusRingToContext):
(WebCore::drawFocusRingToContextAtTime):

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/PasteboardMac.mm:

(WebCore::flipImageSpec):
(WebCore::setDragImageImpl):
(WebCore::Pasteboard::setDragImage):

platform/mac/PlatformEventFactoryMac.mm:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::linenBackgroundColor):

platform/mac/ThemeMac.mm:

(WebCore::drawCellFocusRingWithFrameAtTime):
(WebCore::drawCellFocusRing):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
platform/mac/WebWindowAnimation.mm:

(flipRect):
(mainWindowServerConnectionID):
(setScaledFrameForWindow):
(-[WebWindowScaleAnimation setCurrentProgress:]):
(-[WebWindowFadeAnimation setCurrentProgress:]):

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cg/CoreGraphicsSPI.h:
pal/spi/mac/HIServicesSPI.h:
pal/spi/mac/NSGraphicsSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h.

Source/WebKit:

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

UIProcess/mac/WindowServerConnection.h:
UIProcess/mac/WindowServerConnection.mm:

(WebKit::registerOcclusionNotificationHandler):
(WebKit::WindowServerConnection::WindowServerConnection):
(WebKit::WindowServerConnection::applicationWindowModificationsStarted): Deleted.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Carbon/HIWebView.mm:

(-[NSWindowGraphicsContext _web_setGraphicsPort:]):
(overrideCGContext):
(restoreCGContext):
(Draw):

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

(WebKit::sendUserChangeNotifications):

Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]):

WebView/WebFullScreenController.mm:

(setClipRectForWindow):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

11:33 AM Changeset in webkit [221484] by Matt Lewis

2 edits in trunk/LayoutTests

Marked webrtc/datachannel/bufferedAmountLowThreshold.html as flaky on Mac WK1.
https://bugs.webkit.org/show_bug.cgi?id=172334

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

11:16 AM Changeset in webkit [221483] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Reject promises in case of internal CacheStorage engine errors.
https://bugs.webkit.org/show_bug.cgi?id=176194

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

No new tests as this covers error cases that should not happen in regular cases.
Replacing lambdas that take no parameters to lambdas taking an optional error.
Reject promise if an error is found.

Modules/cache/Cache.cpp:

(WebCore::Cache::doMatch):
(WebCore::Cache::matchAll):
(WebCore::Cache::keys):
(WebCore::Cache::retrieveRecords):
(WebCore::Cache::queryCache):

Modules/cache/Cache.h:
Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::match):
(WebCore::CacheStorage::has):
(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
(WebCore::CacheStorage::keys):

Modules/cache/CacheStorage.h:

10:53 AM Changeset in webkit [221482] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed WPE build fix after r221439.

html/canvas/WebGL2RenderingContext.cpp: Add the HeapInlines.h

header include in order to properly inline a Heap::vm() call.

10:37 AM Changeset in webkit [221481] by Chris Dumez

18 edits
6 adds in trunk

Implement FileSystemEntry.getParent()
https://bugs.webkit.org/show_bug.cgi?id=176165
<rdar://problem/34187743>

Reviewed by Andreas Kling.

Source/WebCore:

Implement FileSystemEntry.getParent():

https://wicg.github.io/entries-api/#dom-filesystementry-getparent

Tests: editing/pasteboard/datatransfer-items-drop-getParent-root.html

editing/pasteboard/datatransfer-items-drop-getParent.html
editing/pasteboard/datatransfer-items-drop-getParent2.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::toFileSystemEntries):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::isAbsoluteVirtualPath):
Add utility function to determine if a virtual path is absolute:

https://wicg.github.io/entries-api/#absolute-path

(WebCore::DOMFileSystem::root):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::DOMFileSystem::fileAsEntry):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::resolveRelativePath):
Add implementation for:

https://wicg.github.io/entries-api/#resolve-a-relative-path

(WebCore::DOMFileSystem::listDirectory):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::DOMFileSystem::getParent):
Add implementation of getParent() as per:

https://wicg.github.io/entries-api/#dom-filesystementry-getparent

Modules/entriesapi/DOMFileSystem.h:

(WebCore::DOMFileSystem::createEntryForFile):

Modules/entriesapi/DOMFileSystem.idl:
Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):

Modules/entriesapi/FileSystemDirectoryEntry.h:
Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::readEntries):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

Modules/entriesapi/FileSystemEntry.cpp:

(WebCore::FileSystemEntry::FileSystemEntry):
(WebCore::FileSystemEntry::activeDOMObjectName const):
(WebCore::FileSystemEntry::canSuspendForDocumentSuspension const):
(WebCore::FileSystemEntry::getParent):

Modules/entriesapi/FileSystemEntry.h:
Modules/entriesapi/FileSystemEntry.idl:
Add implementation of FileSystemEntry.getParent() which relies on DOMFileSystem::getParent()
Make FileSystemEntry an ActiveDOMObject as getParent() is an asynchronous operation which causes delayed JS execution.

Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::FileSystemFileEntry):

Modules/entriesapi/FileSystemFileEntry.h:
dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::getAsEntry const):

dom/DataTransferItem.h:
dom/DataTransferItem.idl:

Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

LayoutTests:

editing/pasteboard/datatransfer-items-drop-getParent-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent-root-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent-root.html: Added.
editing/pasteboard/datatransfer-items-drop-getParent.html: Added.
editing/pasteboard/datatransfer-items-drop-getParent2-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent2.html: Added.

Add layout test coverage for FileSystemEntry.getParent().

http/wpt/entries-api/interfaces-expected.txt:

Rebaseline test now that one more check is passing.

platform/wk2/TestExpectations:

Skip new tests on WK2 since they rely on beginDragWithFiles.

10:17 AM Changeset in webkit [221480] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Ensure RenderStyle and SameSizeAsRenderStyle have the same size
https://bugs.webkit.org/show_bug.cgi?id=176210

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-01
Reviewed by Daniel Bates.

SameSizeAsRenderStyle::m_nonInheritedFlags requires a 64 bit alignment,
which currently produces an extra 32 bit padding with 32 bit build.

rendering/style/RenderStyle.cpp:

Make m_nonInheritedFlags 32 bit aligned and restore the size check.

9:05 AM Changeset in webkit [221479] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[FTL] FTL allocation for async Function is incorrect
https://bugs.webkit.org/show_bug.cgi?id=176214

Reviewed by Saam Barati.

In FTL, allocating async function / async generator function was incorrectly using
JSFunction logic. While it is not observable right now since sizeof(JSFunction) == sizeof(JSAsyncFunction),
but it is a bug.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

8:08 AM Changeset in webkit [221478] by pvollan@apple.com

26 edits
2 moves in trunk/Source

[Win] Compile error, 'Cache' is not declared.
https://bugs.webkit.org/show_bug.cgi?id=176062

Reviewed by Youenn Fablet.

Rename DOMCache to DOMCacheEngine.

Source/WebCore:

No new tests, covered by existing tests.

Modules/cache/Cache.cpp:

(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::queryCacheMatch):
(WebCore::Cache::batchDeleteOperation):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

Modules/cache/Cache.h:
Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

Modules/cache/CacheStorageConnection.cpp:
Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::clearMemoryRepresentation):
(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

Modules/cache/DOMCache.cpp: Removed.
Modules/cache/DOMCache.h: Removed.
Modules/cache/DOMCacheEngine.cpp: Copied from Source/WebCore/Modules/cache/DOMCache.cpp.

(WebCore::DOMCacheEngine::isolatedResponseBody):
(WebCore::DOMCacheEngine::copyResponseBody):
(WebCore::DOMCache::errorToException): Deleted.
(WebCore::DOMCache::queryCacheMatch): Deleted.
(WebCore::DOMCache::isolatedResponseBody): Deleted.
(WebCore::DOMCache::copyResponseBody): Deleted.
(WebCore::DOMCache::Record::copy const): Deleted.

Modules/cache/DOMCacheEngine.h: Copied from Source/WebCore/Modules/cache/DOMCache.h.
Modules/cache/WorkerCacheStorageConnection.cpp:
Modules/cache/WorkerCacheStorageConnection.h:
WebCore.xcodeproj/project.pbxproj:
testing/Internals.cpp:

(WebCore::Internals::clearCacheStorageMemoryRepresentation):

Source/WebKit:

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::queryCache):
(WebKit::CacheStorage::Engine::writeFile):

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCache.h:
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):

NetworkProcess/cache/CacheStorageEngineCaches.h:
NetworkProcess/cache/CacheStorageEngineConnection.cpp:
NetworkProcess/cache/CacheStorageEngineConnection.h:
NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DOMCacheEngine::CacheInfo>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::CacheInfo>::decode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):
(IPC::ArgumentCoder<DOMCache::CacheInfo>::encode): Deleted.
(IPC::ArgumentCoder<DOMCache::CacheInfo>::decode): Deleted.
(IPC::ArgumentCoder<DOMCache::Record>::encode): Deleted.
(IPC::ArgumentCoder<DOMCache::Record>::decode): Deleted.

Shared/WebCoreArgumentCoders.h:
WebProcess/Cache/WebCacheStorageConnection.cpp:
WebProcess/Cache/WebCacheStorageConnection.h:
WebProcess/Cache/WebCacheStorageConnection.messages.in:

5:44 AM Changeset in webkit [221477] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Mark audio-mpeg-supported.html as passing.
https://bugs.webkit.org/show_bug.cgi?id=131535

Unreviewed test gardening.

The last time it intermittently timed out was on r194436.
(It also timed out between r200951 and r201016, but that was consistent
and unrelated.)

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-01

platform/gtk/TestExpectations:

5:27 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

5:19 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

4:47 AM Changeset in webkit [221476] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Mark media-ended.html as passing.
https://bugs.webkit.org/show_bug.cgi?id=131534

Unreviewed test gardening.

The test needs to run through the entire audio file twice, so it will
take several seconds by design. GTK used to have a shorter timeout,
which was extended in r218270. The test hasn't timed out since.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-01

platform/gtk/TestExpectations:

Aug 31, 2017:

11:40 PM Changeset in webkit [221475] by Yusuke Suzuki

6 edits in trunk

[JSC] Fix "name" and "length" of Proxy revoke function
https://bugs.webkit.org/show_bug.cgi?id=176155

Reviewed by Mark Lam.

JSTests:

test262.yaml:

Source/JavaScriptCore:

ProxyRevoke's length should be configurable. And it does not have
its own name. We add NameVisibility enum to InternalFunction to
control visibility of the name.

runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

runtime/InternalFunction.h:
runtime/ProxyRevoke.cpp:

(JSC::ProxyRevoke::finishCreation):

11:36 PM Changeset in webkit [221474] by Carlos Garcia Campos

3 edits in trunk/Tools

[GTK] Improve the way unit test are run and the results reported
https://bugs.webkit.org/show_bug.cgi?id=176104

Reviewed by Carlos Alberto Lopez Perez.

There are several issues with the way unit tests are run by run-gtk-tests and also with the way results are
reported:

The results summary only mentions the test binaries, not the actual test cases, so you always have to scroll up to find the actual test cases failing.
The number of reported failures is the number of test binaries that failed, so if a new test case fails for the same binary in a new revision, we won't notice it just looking at the number of failures.
We show detailed information about skipped test in the results summary, which is just noise.
In the case of glib tests, when a test case times out, we finish the test suite, instead of continuing with the rest of the test cases like we do for normal failures or crashes. If a new test case fails after a test case that timed out we will not notice it until we fix or skip the test cases timing out.
In the case of glib tests, the timeout is applied to the whole suite, instead of per test case, we have a hack to make it longer only for that. It has worked so far, but it doesn't scale, and it's an ugly hack.
It's not currently possible to detect flaky tests, because again, we know the binaries/suites that failed but not the actual test cases.

This patch fixes all these issues and makes it possible to add support for flaky tests in a follow up patch.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete): Update the RunGtkAPITests step to parse the new output.

Scripts/run-gtk-tests:

11:00 PM Changeset in webkit [221473] by aestes@apple.com

23 edits
3 copies in trunk/Source

[Mac] Upstream AppKit-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176175

Reviewed by Brady Eidson.

Source/WebCore:

Configurations/WebCore.xcconfig: Added -ObjC to OTHER_LDFLAGS so that Objective-C classes

in PAL are exported by WebCore even if WebCore doesn't use them.

platform/mac/PlatformEventFactoryMac.h:
platform/mac/PlatformEventFactoryMac.mm:

(WebCore::getWheelEventDeltas):
(WebCore::keyCharForEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/mac/HIToolboxSPI.h:
pal/spi/mac/NSResponderSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
pal/spi/mac/NSWindowSPI.h:
pal/system/mac/WebPanel.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
pal/system/mac/WebPanel.mm: Copied from Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h.

(-[WebPanel init]):

Source/WebKit:

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeCocoaOverrides):

Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

UIProcess/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel init]):

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::keyEvent):

Plugins/Hosted/WebTextInputWindowController.m:

(-[WebTextInputPanel init]):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _removeWindowObservers]):
(-[WebHTMLView addWindowObservers]):

WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView viewWillMoveToWindow:]):

10:41 PM Changeset in webkit [221472] by sbarati@apple.com

18 edits in trunk/Source/JavaScriptCore

Throwing an exception in the DFG/FTL should not cause a jettison
https://bugs.webkit.org/show_bug.cgi?id=176060
<rdar://problem/34143348>

Reviewed by Keith Miller.

Throwing an exception is not something that should be a jettison-able
OSR exit. We used to count Throw/ThrowStaticError towards our OSR exit
counts which could cause a CodeBlock to jettison and recompile. This
was dumb. Throwing an exception is not a reason to jettison and
recompile in the way that a speculation failure is. This patch
treats Throw/ThrowStaticError as true terminals in DFG IR.

bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

dfg/DFGNode.h:

(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::isPseudoTerminal):
(JSC::DFG::Node::errorType):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileThrow):
(JSC::DFG::SpeculativeJIT::compileThrowStaticError):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):

jit/JITOperations.h:

9:10 PM Changeset in webkit [221471] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build after r221422
https://bugs.webkit.org/show_bug.cgi?id=174924

platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::getLocaleInfoString):
StringVector is now the type that can be adopted by String::adopt.

8:05 PM Changeset in webkit [221470] by sbarati@apple.com

3 edits
1 add in trunk

Graph::methodOfGettingAValueProfileFor compares NodeOrigin instead of the semantic CodeOrigin
https://bugs.webkit.org/show_bug.cgi?id=176206

Reviewed by Keith Miller.

JSTests:

stress/compare-semantic-origin-op-negate-method-of-getting-a-value-profile.js: Added.

(a):
(b):
(foo):

Source/JavaScriptCore:

Mark fixed the main issue in Graph::methodOfGettingAValueProfileFor in r208560
when he fixed it from overwriting invalid parts of the ArithProfile when the
currentNode and the operandNode are from the same bytecode. However, the
mechanism used to determine same bytecode was comparing NodeOrigin. That's
slightly wrong. We need to compare semantic origin, since two NodeOrigins can
have the same semantic origin, but differ only in exitOK. For example,
in the below IR, the DoubleRep and the Phi have the same semantic
origin, but different NodeOrigins.

43 Phi(JS|PureInt, NonBoolInt32|NonIntAsdouble, W:SideState, bc#63, ExitInvalid)
58 ExitOK(MustGen, W:SideState, bc#63)
51 DoubleRep(Check:Number:Kill:@43, Double|PureInt, BytecodeDouble, Exits, bc#63)
54 ArithNegate(DoubleRep:Kill:@51<Double>, Double|UseAsOther|MayHaveDoubleResult, AnyIntAsDouble|NonIntAsdouble, NotSet, Exits, bc#63)

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

7:59 PM Changeset in webkit [221469] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Another attempt to fix the Apple Windows build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Temporarily weaken the size check for RenderStyle from a strict equality to <=.

rendering/style/RenderStyle.cpp:

7:52 PM Changeset in webkit [221468] by fpizlo@apple.com

22 edits
3 adds in trunk/Tools

WSL should support loading from arrays
https://bugs.webkit.org/show_bug.cgi?id=176207

Reviewed by Saam Barati.

Getting a test that loads from arrays to work required doing a lot of things:

a[i] now parses to ^{(operator\[](a, i)).}
added operator\[] for four array reference types.
to make thread|threadgroup|device T[] work, you need T:primitive.
so this adds the magical primitive protocol.

This required a little bit of rejuggling in the name resolver and type checker. The main thing
is that to prevent the rewriter from copying the types referenced by some function, you need to
make sure that when you add a reference to a type, you wrap it in a TypeRef. This doesn't
completely feel right, but I'm sure we'll figure out the balance eventually. See bug 176208.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EArrayRef.js: Added.

(EArrayRef):
(EArrayRef.prototype.get ptr):
(EArrayRef.prototype.get length):
(EArrayRef.prototype.toString):

WebGPUShadingLanguageRI/EPtr.js:

(EPtr.prototype.plus):
(EPtr.prototype.toString):
(EPtr):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitUintLiteral):

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/NameContext.js:

(NameContext.prototype.recognizeIntrinsics):

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProtocolRef):

WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance.prototype.get isNative):

WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parseTypeDef):
(parseNative):
(parsePossibleSuffix):
(parse):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl):

WebGPUShadingLanguageRI/ProtocolRef.js:

(ProtocolRef.prototype.get isPrimitive):
(ProtocolRef):

WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.populateDefaultValue): Deleted.

WebGPUShadingLanguageRI/ReferenceType.js:

(ReferenceType.prototype.populateDefaultValue):
(ReferenceType):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitUintLiteral):
(Rewriter.prototype.visitFunc): Deleted.
(Rewriter.prototype.visitTypeVariable): Deleted.
(Rewriter.prototype.visitConstexprTypeParameter): Deleted.

WebGPUShadingLanguageRI/StandardLibrary.js:
WebGPUShadingLanguageRI/Test.js:

(TEST_threadArrayLoad):
(TEST_deviceArrayLoad):

WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.prototype.get instantiatedType):

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.toString):
(TypeVariable):

WebGPUShadingLanguageRI/UintLiteral.js: Added.

(UintLiteral):
(UintLiteral.prototype.get value):
(UintLiteral.prototype.get isConstexpr):
(UintLiteral.prototype.toString):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitNativeFuncInstance):
(Visitor.prototype.visitTypeVariable):
(Visitor.prototype.visitPtrType):
(Visitor.prototype.visitArrayRefType):
(Visitor.prototype.visitUintLiteral):

WebGPUShadingLanguageRI/WTrapError.js: Added.

(WTrapError):

7:01 PM Changeset in webkit [221467] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Apple Windows and WinCairo build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Explicitly cast PseudoIds to unsigned before computing a difference between two PseudoIds.

rendering/style/RenderStyle.h:

6:47 PM Changeset in webkit [221466] by achristensen@apple.com

10 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
https://bugs.webkit.org/show_bug.cgi?id=176203
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/API/APIUIClient.h:

(API::UIClient::isPlayingMediaDidChange):
(API::UIClient::isPlayingAudioDidChange): Deleted.

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[MediaDelegate _webView:isPlayingMediaDidChange:]):
(-[MediaDelegate webView:didFinishNavigation:]):
(TEST):

6:46 PM Changeset in webkit [221465] by achristensen@apple.com

21 edits
1 add in trunk

Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
https://bugs.webkit.org/show_bug.cgi?id=175779
<rdar://problem/22367975>

Reviewed by Tim Horton.

Source/WebCore:

Covered by new API tests.

loader/FrameLoaderClient.h:

Source/WebKit:

UIProcess/API/APINavigationClient.h:

(API::NavigationClient::webGLLoadPolicy const):
(API::NavigationClient::resolveWebGLLoadPolicy const):

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::toWebCoreWebGLLoadPolicy):
(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webGLPolicyForURL):
(WebKit::WebPageProxy::resolveWebGLPolicyForURL):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::webGLPolicyForURL const):
(WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL const):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::webGLPolicyForURL const):
(WebFrameLoaderClient::resolveWebGLPolicyForURL const):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm: Added.

(-[WebGLTestDelegate webView:startURLSchemeTask:]):
(-[WebGLTestDelegate webView:stopURLSchemeTask:]):
(-[WebGLTestDelegate _webView:webGLLoadPolicyForURL:decisionHandler:]):
(-[WebGLTestDelegate _webView:resolveWebGLLoadPolicyForURL:decisionHandler:]):
(-[WebGLTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(urlsEqual):
(runTest):
(TEST):

6:17 PM Changeset in webkit [221464] by akling@apple.com

7 edits in trunk/Source/WebCore

Element focus appearance update should be either immediate or a post-layout task
https://bugs.webkit.org/show_bug.cgi?id=176193

Reviewed by Antti Koivisto.

This change removes an old mechanism for avoiding element focus appearance updates
while we might be in the middle of attaching a renderer.

Focus appearance updates depend on a clean layout, since they want to be able to
scroll the element into the visible viewport if needed.
We now simply do the updates either immediately after layout in Element::focus(),
or as a post-layout callback when needed for HTMLInputElement::didAttachRenderers().

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::updateFocusAppearanceSoon): Deleted.
(WebCore::Document::cancelFocusAppearanceUpdate): Deleted.
(WebCore::Document::updateFocusAppearanceTimerFired): Deleted.

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::focus):
(WebCore::Element::blur):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded): Deleted.
(WebCore::Element::cancelFocusAppearanceUpdate): Deleted.

dom/Element.h:
dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::needsFocusAppearanceUpdateSoonAfterAttach const): Deleted.
(WebCore::ElementRareData::setNeedsFocusAppearanceUpdateSoonAfterAttach): Deleted.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didAttachRenderers):

5:36 PM Changeset in webkit [221463] by don.olmstead@sony.com

19 edits in trunk

[CMake] Make USE_CF conditional within Windows
https://bugs.webkit.org/show_bug.cgi?id=176173

Reviewed by Alex Christensen.

Source/cmake/OptionsAppleWin.cmake:
Source/cmake/OptionsWinCairo.cmake:

Source/JavaScriptCore:

PlatformWin.cmake:

Source/WebCore:

No new tests. No change in behavior.

PlatformWin.cmake:
WebCorePrefix.h:
testing/js/WebCoreTestSupportPrefix.h:

Source/WebKitLegacy:

PlatformWin.cmake:

Source/WTF:

wtf/Platform.h:
wtf/PlatformWin.cmake:

Tools:

DumpRenderTree/config.h:
MiniBrowser/win/CMakeLists.txt:
MiniBrowser/win/stdafx.h:
TestWebKitAPI/PlatformWin.cmake:

5:21 PM Changeset in webkit [221462] by commit-queue@webkit.org

27 edits
2 copies
7 adds in trunk

Implement DOMMatrix2DInit for setTransform()/addPath()
https://bugs.webkit.org/show_bug.cgi?id=176048

Patch by Sam Weinig <sam@webkit.org> on 2017-08-31
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/geometry-1/DOMMatrix-001.html:
web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.js:

(string_appeared_here.forEach.constr.test):

web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup.html: Added.
web-platform-tests/css/geometry-1/historical.html:
web-platform-tests/css/geometry-1/interfaces-expected.txt: Added.
web-platform-tests/css/geometry-1/interfaces.html: Added.
web-platform-tests/css/geometry-1/interfaces.worker-expected.txt: Added.
web-platform-tests/css/geometry-1/interfaces.worker.html: Added.
web-platform-tests/css/geometry-1/interfaces.worker.js: Added.
web-platform-tests/css/geometry-1/structured-serialization.html:
web-platform-tests/css/geometry-1/w3c-import.log:

Pull latest web-platform-tests/css/geometry-1/ and rebase the results.

Source/WebCore:

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
CMakeLists.txt:

Add new files.

bindings/js/CallTracerTypes.h:
inspector/InspectorCanvas.cpp:

Swap out DOMMatrixInit for DOMMatrix2DInit in canvas tracing infrastructure.

css/DOMMatrix2DInit.h: Added.
css/DOMMatrix2DInit.idl: Added.
css/DOMMatrixInit.h:
css/DOMMatrixInit.idl:

Split DOMMatrixInit in two, with the 2D bits going into DOMMatrix2DInit.

css/DOMMatrixReadOnly.cpp:
css/DOMMatrixReadOnly.h:

Add a validateAndFixup overload for DOMMatrix2DInit.

html/canvas/CanvasRenderingContext2D.cpp:
html/canvas/CanvasRenderingContext2D.h:

Swap out DOMMatrixInit for DOMMatrix2DInit in setTransform. This
should have no observable difference, since we ignored the 3D prior.

html/canvas/DOMPath.cpp:
html/canvas/DOMPath.h:
html/canvas/DOMPath.idl:

Update DOMPath (actually called Path2D) to take an optional DOMMatrix2DInit
rather than an SVGMatrix. Passing an SVGMatrix is still valid, as it conforms
as a DOMMatrix2DInit dictionary (having the necessary properties), so the
risk of compatibility issues is minimal.

LayoutTests:

fast/canvas/canvas-path-addPath-expected.txt:
fast/canvas/canvas-path-addPath.html:

Update test / results now that the transform is for the path is an optional dictionary.
Mostly this means we throw a little less.

5:12 PM Changeset in webkit [221461] by beidson@apple.com

24 edits
1 copy in trunk

Add (entirely incorrect) fetching of ServiceWorker scripts.
https://bugs.webkit.org/show_bug.cgi?id=176179

Reviewed by Andy Estes.

Source/WebCore:

No new tests (Covered by changes to existing tests).

When the Storage process is running the "Update" algorithm and a ServiceWorker script file needs to be fetched, this patch:

Messages back to the WebContent process that started the register/update job
Executes a FetchLoad in that script context for the script
Sends the results back to the Storage process

We don't do anything with the results yet.

Soon.

WebCore.xcodeproj/project.pbxproj:

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):

workers/service/ServiceWorkerContainer.h:

workers/service/ServiceWorkerFetchResult.h: Copied from Source/WebCore/workers/service/server/SWClientConnection.h.

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::startScriptFetch):
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::didReceiveData):
(WebCore::ServiceWorkerJob::didSucceed):
(WebCore::ServiceWorkerJob::didFail):

workers/service/ServiceWorkerJob.h:

workers/service/ServiceWorkerJobClient.h:

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::startScriptFetchForServer):

workers/service/server/SWClientConnection.h:

workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::finishFetchingScriptInServer):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):

workers/service/server/SWServer.h:

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptFetchFinished):
(WebCore::SWServerRegistration::runUpdateJob):
(WebCore::SWServerRegistration::startScriptFetchFromMainThread):
(WebCore::SWServerRegistration::startScriptFetchForCurrentJob):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startScriptFetchInClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::finishFetchingScriptInServer):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

http/tests/workers/service/basic-register-expected.txt:
http/tests/workers/service/resources/basic-register.js:
http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:

5:09 PM Changeset in webkit [221460] by fpizlo@apple.com

14 edits
2 adds in trunk/Tools

WSL should support makeptr (\)
https://bugs.webkit.org/show_bug.cgi?id=176197

Reviewed by Saam Barati.

This required introducing some sanity about how pointers are carried around in the evaluator.
It turns out that we need to be careful about when a pointer to an rvalue is dereferenced. It
should be dereferenced basically immediately. If it cannot be, then we need to snapshot the
value. To do that, we need to know the types of things in a few more places. That's what this
change accomplishes.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/DereferenceExpression.js:

(DereferenceExpression.prototype.get isLValue):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype._snapshot):
(Evaluator.prototype.runBody):
(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitMakePtrExpression):
(Evaluator.prototype.visitCommaExpression):
(Evaluator.prototype.visitCallExpression):
(Evaluator):
(Evaluator.prototype._dereference): Deleted.

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/FunctionLikeBlock.js:

(FunctionLikeBlock):
(FunctionLikeBlock.prototype.get returnType):
(FunctionLikeBlock.prototype.toString):

WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

WebGPUShadingLanguageRI/MakePtrExpression.js: Added.

(MakePtrExpression):
(MakePtrExpression.prototype.get lValue):
(MakePtrExpression.prototype.toString):

WebGPUShadingLanguageRI/NativeFuncInstance.js: Added.

(NativeFuncInstance):
(NativeFuncInstance.prototype.get func):
(NativeFuncInstance.prototype.toString):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitMakePtrExpression):
(Rewriter.prototype.visitCallExpression):

WebGPUShadingLanguageRI/Test.js:

(TEST_dereferenceStore):
(TEST_simpleMakePtr):

WebGPUShadingLanguageRI/Value.js:

(Value.prototype.get isLValue):
(Value):

WebGPUShadingLanguageRI/VariableRef.js:

(VariableRef.prototype.get isLValue):
(VariableRef.prototype.get addressSpace):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitMakePtrExpression):
(Visitor.prototype.visitCallExpression):

4:55 PM Changeset in webkit [221459] by dbates@webkit.org

3 edits in trunk/Source/WebCore

Make RenderStyle's non-inherited flags more human friendly
https://bugs.webkit.org/show_bug.cgi?id=176171

Reviewed by Antti Koivisto.

Revert r166465 as we never followed through and made the CSS JIT update
RenderStyle's non-inherited flags directly.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):

rendering/style/RenderStyle.h:

4:44 PM Changeset in webkit [221458] by Ryan Haddad

3 edits in trunk/JSTests

Skip two slow JSC tests after r221422.

Unreviewed test gardening.

stress/regexp-prototype-match-on-too-long-rope.js:
stress/regexp-prototype-test-on-too-long-rope.js:

4:31 PM Changeset in webkit [221457] by Megan Gardner

2 edits in trunk/Source/WebKit

Fix error in protocol revving
https://bugs.webkit.org/show_bug.cgi?id=176191

Protocol definition was mastered out of later iOS submissions, causing them to not build.

Reviewed by Tim Horton.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):

4:27 PM Changeset in webkit [221456] by Antti Koivisto

26 edits
1 delete in trunk

Remove newBlockInsideInlineModel and anonymous inline block
https://bugs.webkit.org/show_bug.cgi?id=176181

Reviewed by Zalan Bujtas.

Source/WebCore:

Anonymous inline block exists to support newBlockInsideInlineModel which was planned as the replacement for continuations.
It has never been enabled and it is time to remove it.

page/Settings.in:
rendering/InlineElementBox.cpp:

(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::anonymousInlineBlock const): Deleted.

rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasAnonymousInlineBlock const): Deleted.
(WebCore::InlineFlowBox::setHasAnonymousInlineBlock): Deleted.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::RenderBlock::renderName const):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing const):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart): Deleted.

rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent const):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::avoidsFloats const):

rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):

rendering/RenderObject.cpp:

(WebCore::RenderObject::isAnonymousInlineBlock const): Deleted.

rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock const):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::ascentAndDescentForBox const):

rendering/line/BreakingContext.h:

(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::handleReplaced):

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::nextLineBreak):

rendering/line/LineBreaker.h:
rendering/line/LineLayoutState.h:

(WebCore::LineLayoutState::marginInfo):
(WebCore::LineLayoutState::prevFloatBottomFromAnonymousInlineBlock): Deleted.
(WebCore::LineLayoutState::maxFloatBottomFromAnonymousInlineBlock): Deleted.

LayoutTests:

TestExpectations:
fast/block/inside-inlines/crash-on-first-line-change.html:

Don't set newBlockInsideInlineModel.

fast/block/inside-inlines/new-model: Removed.
fast/block/inside-inlines/new-model/basic-float-intrusion-expected.html: Removed.
fast/block/inside-inlines/new-model/basic-float-intrusion.html: Removed.
fast/block/inside-inlines/new-model/block-width-check-expected.html: Removed.
fast/block/inside-inlines/new-model/block-width-check.html: Removed.
fast/block/inside-inlines/new-model/breaking-behavior-expected.html: Removed.
fast/block/inside-inlines/new-model/breaking-behavior.html: Removed.
fast/block/inside-inlines/new-model/empty-block-expected.html: Removed.
fast/block/inside-inlines/new-model/empty-block.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse: Removed.
fast/block/inside-inlines/new-model/margin-collapse/001-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/001.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/002-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/002.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/003-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/003.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/004-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/004.html: Removed.
fast/block/inside-inlines/new-model/margins-pushing-below-float-expected.html: Removed.
fast/block/inside-inlines/new-model/margins-pushing-below-float.html: Removed.
fast/block/inside-inlines/new-model/paint-order-expected.html: Removed.
fast/block/inside-inlines/new-model/paint-order.html: Removed.
fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Removed.
fast/block/inside-inlines/new-model/self-collapsing-test.html: Removed.

These are reftests comparing newBlockInsideInlineModel and the current model and don't have value anymore.

fast/block/inside-inlines/opacity-on-inline.html:

Don't set newBlockInsideInlineModel.
Marked this as failing since it only worked with newBlockInsideInlineModel enabled.
The test passes in Firefox and fails in Chrome.

4:25 PM Changeset in webkit [221455] by Ryan Haddad

13 edits
1 delete in trunk

Unreviewed, rolling out r221445.

This change broke Sierra Release builds.

Reverted changeset:

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221445

4:20 PM Changeset in webkit [221454] by commit-queue@webkit.org

19 edits in trunk/Source

Update CacheStorage caches only if it is updated
https://bugs.webkit.org/show_bug.cgi?id=176135

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebCore:

Covered by existing tests.

When retrieving caches from the engine, CacheStorage gets an update counter.
When this counter is different from the previous received one, CacheStorage will update its cache list.
Otherwise it will skip this update step.

Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::retrieveCaches):

Modules/cache/CacheStorage.h:
Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::retrieveCaches):

Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::doRetrieveCaches):

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::CacheInfos::isolatedCopy):

Modules/cache/DOMCache.h:

(WebCore::DOMCache::CacheInfos::encode const):
(WebCore::DOMCache::CacheInfos::decode):

Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):

Modules/cache/WorkerCacheStorageConnection.h:

Source/WebKit:

For each change to CacheStorageEngineCaches list of cache, CacheStorageEngineCaches increments a counter.
When sending the list of caches, CacheStorageEngineCaches will compare its counter with the one provided.
If they sare the same, CacheStorageEngineCaches will return nothing.
Otherwise it returns the whole list of caches.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveCaches):

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):
(WebKit::CacheStorage::Caches::cacheInfos const):

NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::updateCounter const):

NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::caches):

NetworkProcess/cache/CacheStorageEngineConnection.h:
NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doRetrieveCaches):

WebProcess/Cache/WebCacheStorageConnection.h:

4:19 PM Changeset in webkit [221453] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

useSeparatedWXHeap should never be true when not on iOS
https://bugs.webkit.org/show_bug.cgi?id=176190

Reviewed by JF Bastien.

If you set useSeparatedWXHeap to true on X86_64, and launch the jsc shell,
the process insta-crashes. Let's silently ignore that option and set it
to false when not on iOS.

runtime/Options.cpp:

(JSC::recomputeDependentOptions):

4:19 PM Changeset in webkit [221452] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

4:18 PM Changeset in webkit [221451] by jmarcell@apple.com

1 copy in tags/Safari-604.2.7

Tag Safari-604.2.7.

4:00 PM Changeset in webkit [221450] by fpizlo@apple.com

10 edits
1 add in trunk/Tools

WSL should support dereference (^{)

https://bugs.webkit.org/show_bug.cgi?id=176192}

Reviewed by Myles Maxfield.

This implements DereferenceExpression.

It also renames Evaluator.prototype.visitFunctionBody, because that name confusingly implies
that there is a class named FunctionBody. It's now called runBody.

I made the check to see if a type is a pointer type be the isPtr method, so that we can have
other pointer types that are implemented via something other than PtrType. We might want it if
for example we wanted a pointer type that is generic over address space.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/DereferenceExpression.js: Added.

(DereferenceExpression):
(DereferenceExpression.prototype.get ptr):
(DereferenceExpression.prototype.toString):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype._dereference):
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitFunctionBody): Deleted.

WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.get isPtr):
(PtrType.prototype.populateDefaultValue):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitAssignment):
(Rewriter.prototype.visitDereferenceExpression):

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleDereference):

WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isPtr):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitDereferenceExpression):

3:22 PM Changeset in webkit [221449] by fpizlo@apple.com

4 edits in trunk/Tools

There should only be one callFunction API in WSL
https://bugs.webkit.org/show_bug.cgi?id=176189

Reviewed by Saam Barati.

This removes the need for callFunctionByRef, which was weird. It's now the case the TypedValue
is always a tuple of type and ePtr, and TypedValue has a super simple API for boxing and
unboxing single-cell values like ints.

WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):
(callFunctionByRef): Deleted.

WebGPUShadingLanguageRI/Test.js:

(makeInt):

WebGPUShadingLanguageRI/TypedValue.js:

(TypedValue):
(TypedValue.prototype.get type):
(TypedValue.prototype.get ePtr):
(TypedValue.box):
(TypedValue.prototype.get value):
(TypedValue.prototype.toString):

3:15 PM Changeset in webkit [221448] by fpizlo@apple.com

11 edits
1 delete in trunk/Tools

WSL EPtr does not need to carry around the type
https://bugs.webkit.org/show_bug.cgi?id=176188

Reviewed by Saam Barati.

To validate that the interpreter is modeling a statically typed execution environment, it's
really best if values don't know their types at all. A pointer is just a pointer (i.e a buffer
and offset in our world), and it's the job of the AST node that uses it to figure out what its
type should be.

I think this makes the code simpler overall.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunctionByRef):
(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

WebGPUShadingLanguageRI/EPtr.js:

(EPtr):
(EPtr.box):
(EPtr.prototype.copyFrom):
(EPtr.prototype.toString):

WebGPUShadingLanguageRI/EValue.js: Removed.
WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitVariableDecl):
(Evaluator.prototype.visitAssignment):
(Evaluator.prototype.visitIntLiteral):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitAssignment):

WebGPUShadingLanguageRI/StructType.js:

(StructType.prototype.instantiate):

WebGPUShadingLanguageRI/Test.js:

(checkInt):

2:55 PM Changeset in webkit [221447] by commit-queue@webkit.org

7 edits
1 add in trunk/Source/WebKit

Introduce CacheStorageEngineCache to handle cache records
https://bugs.webkit.org/show_bug.cgi?id=176137

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

CacheStorageEngineCache is the equivalent of WebCore Cache.
It contains a list of records that it needs to manage (add, update, remove).
Moving the logic of this management from CacheStorageEngine to this new class so as to ease future development.

CMakeLists.txt:
NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::cache):
(WebKit::CacheStorage::Engine::writeCacheRecords): Deleted.
(WebKit::CacheStorage::Engine::removeCacheRecords): Deleted.
(WebKit::CacheStorage::Engine::queryCache): Deleted.

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCache.cpp: Added.
NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::identifier const):
(WebKit::CacheStorage::Cache::name const):
(WebKit::CacheStorage::Cache::info const):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::encodeCacheNames):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::cacheInfos const):

WebKit.xcodeproj/project.pbxproj:

2:50 PM Changeset in webkit [221446] by fpizlo@apple.com

7 edits
1 add
2 deletes in trunk/Tools

WSL doesn't need to wrap primitives like ints and floats in specialized classes like EInt and EFloat
https://bugs.webkit.org/show_bug.cgi?id=176184

Reviewed by Saam Barati.

The only use for EInt and EFloat was that users of the interpreter want to be able to reason
about values that know their type. But for the actual interpreter, it makes most sense for
EBuffer to hold values directly - for example, ints in the case of values of type int. Then,
all of the logic of doing math on those things can be implemented in Intrinsics.js.

So, this removes EInt and EFloat but introduces a new TypedValue class that is used only on the
boundary of the interpreter. You can either use the interpreter by speaking its internal
language (EPtr to an EBuffer that has the values) or by using the simple API (which uses
TypedValue as a trade-off between power and convenience).

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/EFloat.js: Removed.
WebGPUShadingLanguageRI/EInt.js: Removed.
WebGPUShadingLanguageRI/EPtr.js:

(EPtr.box):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitIntLiteral):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Test.js:

(makeInt):
(checkInt):
(TEST_add1):
(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):

WebGPUShadingLanguageRI/TypedValue.js: Added.

(TypedValue):
(TypedValue.prototype.toString):

2:41 PM Changeset in webkit [221445] by eric.carlson@apple.com

11 edits
1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

dom/Document.h:

Convert debug-only logging to configurable release logging.

html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

html/HTMLMediaElement.h:

Source/WTF:

wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

wtf/MediaTime.h:

(PAL::LogArgument<WTF::MediaTime>::toString): Logger template.

2:26 PM Changeset in webkit [221444] by commit-queue@webkit.org

17 edits in trunk

WKNavigationDelegatePrivate client redirect SPI needs to be able to detect redirects scheduled before the document finishes loading
https://bugs.webkit.org/show_bug.cgi?id=176128
rdar://problem/34068476

Patch by David Quesada <david_quesada@apple.com> on 2017-08-31
Reviewed by Brady Eidson.

Source/WebCore:

Removed FrameLoaderClient::dispatchDidPerformClientRedirect() since no client cares about this event anymore.
Also removed FrameLoader::performClientRedirect() since it wouldn't do anything but call changeLocation().

No new tests - no change in functionality.

loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/NavigationScheduler.cpp:

Source/WebKit:

_webView:didPerformClientRedirect: isn't useful for delegates that want to know about client redirects
started before the document is finished loading. This is because the method would be called after the
navigation scheduler's timer fires and the navigation for the redirect has begun. Since this happens in
a later iteration of the run loop, the document has already finished loading. Address this by replacing
the method with two that give the navigation delegate more information about when client redirects are
scheduled and canceled.

UIProcess/API/APINavigationClient.h:

(API::NavigationClient::willPerformClientRedirect):
(API::NavigationClient::didCancelClientRedirect):

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::willPerformClientRedirect):
(WebKit::NavigationState::NavigationClient::didCancelClientRedirect):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willPerformClientRedirectForFrame):
(WebKit::WebPageProxy::didCancelClientRedirectForFrame):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Removed API test for the deleted WKNavigationDelegatePrivate method,
and added two new tests for the two new methods.

TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(-[ClientRedirectNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
(-[ClientRedirectNavigationDelegate _webViewDidCancelClientRedirect:]):
(-[ClientRedirectNavigationDelegate webView:didFinishNavigation:]):
(TEST):

2:13 PM Changeset in webkit [221443] by Megan Gardner

5 edits in trunk/Source/WebKit

Remove IsBlockSelection flag
https://bugs.webkit.org/show_bug.cgi?id=176141

Reviewed by Dean Jackson.

Block selection is disabled. Removed code associated with this flag to allow removal of the
flag in UIKit.

No tests for a removed feature.

Platform/spi/ios/UIKitSPI.h:
Shared/ios/GestureTypes.h:
UIProcess/ios/WKContentViewInteraction.mm:

(toUIWKSelectionFlags):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::WebPage::updateBlockSelectionWithTouch):
(WebKit::WebPage::updateSelectionWithTouches):

1:57 PM Changeset in webkit [221442] by fpizlo@apple.com

8 edits in trunk/Tools

WSL should handle variable assignments and variable declarations
https://bugs.webkit.org/show_bug.cgi?id=176180

Reviewed by Saam Barati.

Just fills in VariableDecl and Assignment logic so that we can test variables.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtrForNode):
(EBufferBuilder.prototype.visitFuncParameter):
(EBufferBuilder.prototype.visitVariableDecl):
(EBufferBuilder):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitVariableDecl):
(Evaluator.prototype.visitAssignment):

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitVariableDecl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncParameter):
(Rewriter.prototype.visitVariableDecl):

WebGPUShadingLanguageRI/Test.js:

(makeInt):
(TEST_add1):
(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitVariableDecl):

1:53 PM Changeset in webkit [221441] by Chris Dumez

14 edits in trunk

getFileMetadata() does not work as expected for symbolic links
https://bugs.webkit.org/show_bug.cgi?id=176143

Reviewed by Andreas Kling.

Source/WebCore:

getFileMetadata() does not work as expected for symbolic links:
On POSIX, getFileMetadata() always followed symlinks, which meant that FileMetadata.type could
never be TypeSymbolicLink. On Windows, the function properly did not follow symlinks but failed to set
FileMetadata.type to TypeSymbolicLink when the file was a symbolic link.

This patch adds a new ShouldFollowSymbolicLinks parameter to getFileMetadata() so that
the call site can decide the behavior it wants. If getFileMetadata() is called on a
symbolic link with ShouldFollowSymbolicLinks::No as parameter, FileMetadata.type is now
properly set to TypeSymbolicLink.

No new tests, covered by new API test.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
It is important we do not follow symlinks here since the code wants to discard them
and does so by checking FileMetadata.type.

WebCore.xcodeproj/project.pbxproj:
fileapi/File.cpp:

(WebCore::File::isDirectory const):

html/FileListCreator.cpp:

(WebCore::appendDirectoryFiles):
(WebCore::FileListCreator::createFileList):
It is important we do not follow symlinks here since the code wants to discard them
and does so by checking FileMetadata.type.

platform/FileSystem.cpp:

(WebCore::fileIsDirectory):

platform/FileSystem.h:
platform/glib/FileSystemGlib.cpp:

(WebCore::getFileLStat):
(WebCore::getFileMetadata):

platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileMetadata):
(WebCore::createSymbolicLink):

platform/win/FileSystemWin.cpp:

(WebCore::getFinalPathName):
(WebCore::getFileMetadata):
(WebCore::createSymbolicLink):

Add new createSymbolicLink() function for testing purposes.
On Posix, call lstat() instead of stat if ShouldFollowSymbolicLinks::No.
On Windows, since FindFirstFileW() does not follow symlinks, resolve final path using GetFinalPathNameByHandleW() if ShouldFollowSymbolicLinks::Yes.
On Windows, properly set FileMetadata.type to TypeSymbolicLink if the file is a symbolic link.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebCore/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

1:50 PM Changeset in webkit [221440] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix debug crashes.

Rubber stamped by Mark Lam.

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

1:46 PM Changeset in webkit [221439] by fpizlo@apple.com

12 edits in trunk

All of the different ArrayBuffer::data's should be CagedPtr<>
https://bugs.webkit.org/show_bug.cgi?id=175515

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This straightforwardly implements what the title says.

runtime/ArrayBuffer.cpp:

(JSC::SharedArrayBufferContents::~SharedArrayBufferContents):
(JSC::ArrayBufferContents::destroy):
(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBufferContents::makeShared):
(JSC::ArrayBufferContents::copyTo):
(JSC::ArrayBuffer::createFromBytes):
(JSC::ArrayBuffer::transferTo):

runtime/ArrayBuffer.h:

(JSC::SharedArrayBufferContents::data const):
(JSC::ArrayBufferContents::data const):
(JSC::ArrayBuffer::data):
(JSC::ArrayBuffer::data const):

runtime/ArrayBufferView.h:

(JSC::ArrayBufferView::baseAddress const):

runtime/CagedBarrierPtr.h: Added a specialization so that CagedBarrierPtr<Gigacage::Foo, void> is valid.
runtime/DataView.h:

(JSC::DataView::get):
(JSC::DataView::set):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::ConstructionContext::vector const):
(JSC::JSArrayBufferView::vector const):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

Source/WTF:

Added a specialization so that CagedPtr<void> is valid.

wtf/CagedPtr.h:

1:09 PM Changeset in webkit [221438] by Michael Catanzaro

2 edits in trunk/Source/WebCore

REGRESSION(r221226): [SOUP] libsoup-CRITICAL : soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=176140

Reviewed by Carlos Garcia Campos.

This should fix unexpected stderr output in several tests.

platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForSession):

1:03 PM Changeset in webkit [221437] by commit-queue@webkit.org

15 edits
2 moves
10 adds in trunk

Add support for Request body stream cloning
https://bugs.webkit.org/show_bug.cgi?id=176148

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/fetch/request-clone.html

http/wpt/fetch/request-consume-stream.html
http/wpt/fetch/request-stream-disturbed-1.html
http/wpt/fetch/request-stream-disturbed-2.html
http/wpt/fetch/request-stream-disturbed-3.html

Adding support for ReadableStream teeing for cloning fetch bodies.
Adding support for pushing request body data to its ReadableStream.
Renamed FetchResponseSource to FetchBodySource for that purpose.

Tests extracting body from a ReadableStream through JS API pass.
Tests extracting data stored in a ReadableStream to resolve fetch body promises are failing.
There is no support yet, this will be added as a follow-up.

CMakeLists.txt:
Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeAsStream):
(WebCore::FetchBody::clone):

Modules/fetch/FetchBody.h:
Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::cloneBody):
(WebCore::FetchBodyOwner::loadBlob):
(WebCore::FetchBodyOwner::readableStream):
(WebCore::FetchBodyOwner::consumeBodyAsStream):

Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::feedStream):
(WebCore::FetchBodyOwner::cancel):

Modules/fetch/FetchBodySource.cpp: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.cpp.
Modules/fetch/FetchBodySource.h: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.h.
Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyAsStream):
(WebCore::FetchResponse::createReadableStream):

Modules/fetch/FetchResponse.h:
Modules/fetch/FetchResponse.idl:
Modules/fetch/FetchResponse.js:

(getter.body):
(clone):

WebCore.xcodeproj/project.pbxproj:
bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::tee):

bindings/js/ReadableStream.h:
bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

http/wpt/fetch/request-clone-expected.txt: Added.
http/wpt/fetch/request-clone.html: Added.
http/wpt/fetch/request-consume-stream-expected.txt: Added.
http/wpt/fetch/request-consume-stream.html: Added.
http/wpt/fetch/request-stream-disturbed-1-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-1.html: Added.
http/wpt/fetch/request-stream-disturbed-2-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-2.html: Added.
http/wpt/fetch/request-stream-disturbed-3-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-3.html: Added.

12:51 PM Changeset in webkit [221436] by fpizlo@apple.com

3 edits in trunk/Tools

WSL parser should pass the token as the origin to the AST
https://bugs.webkit.org/show_bug.cgi?id=176177

Reviewed by Keith Miller.

Parse.js was sometimes passing token.origin as the origin, but that's just the filename
component of the origin. This fixes the problem and adds a test. The test previously failed
because instead of reporting the origin of the type error as "<test>:1", it reported undefined.

WebGPUShadingLanguageRI/Parse.js:

(parseProtocolRef):
(consumeEndOfTypeArgs):
(parseTypeParameters):
(parseTerm):
(parseTypeArguments):
(parseType):
(parseTypeDef):
(parseNative):
(parseLeftOperatorCall):
(parsePossibleSuffix):
(parsePossiblePrefix):
(parsePossibleRelationalEquality):
(parseLeftLogicalExpression):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(genericParseCommaExpression):
(parseReturn):
(parseVariableDecls):
(parseBlock):

WebGPUShadingLanguageRI/Test.js:

(checkFail):
(TEST_nameResolutionFailure):

12:42 PM Changeset in webkit [221435] by keith_miller@apple.com

2 edits in trunk/Tools

Add a filter argument to WSL test suite.
https://bugs.webkit.org/show_bug.cgi?id=176176

Reviewed by Filip Pizlo.

WebGPUShadingLanguageRI/Test.js:

(this.string_appeared_here.i.switch):
(let.s.in.this.s.startsWith.string_appeared_here.s.match):
(let.s.in.this.s.startsWith): Deleted.

12:33 PM Changeset in webkit [221434] by fpizlo@apple.com

18 edits in trunk/Tools

WSL should be able to run a program that uses generics
https://bugs.webkit.org/show_bug.cgi?id=176152

Reviewed by Keith Miller.

This fixes the WSL parser and type checker to the point that we can:

Parse a function call!
Type check a generic function call with an inferred type parameter.
Instantiate a generic function.
Inline a function call.
Evaluate an inlined function call.

This also changes the test suite so that it's a little nicer to add new tests. Functions whose
names start with "TEST_" are tests.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype.visitFuncParameter):
(EBufferBuilder):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):

WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef.prototype.toString):
(FuncDef):

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer):

WebGPUShadingLanguageRI/NameContext.js:

(NameContext):
(NameContext.prototype.add):
(NameContext.prototype.get let):
(NameContext.prototype.defineAll):
(NameContext.get intrinsics): Deleted.
(NameContext.set program): Deleted.
(NameContext.get program): Deleted.

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProgram):

WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parsePossibleSuffix):
(genericParseCommaExpression):
(parseReturn):

WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.inherits):

WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncParameter):
(Rewriter.prototype.visitCallExpression):
(Rewriter.prototype._map): Deleted.

WebGPUShadingLanguageRI/Test.js:

(checkInt):
(TEST_add1):
(TEST_simpleGeneric):
(let.s.in.this.s.startsWith):
(load): Deleted.

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.typeVariableUnify):

WebGPUShadingLanguageRI/UnificationContext.js:

(UnificationContext.prototype.union):

12:20 PM Changeset in webkit [221433] by achristensen@apple.com

7 edits
1 add in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's didClickAutoFillButton
https://bugs.webkit.org/show_bug.cgi?id=176139
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Covered by a cool new API test!

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didClickAutoFillButton):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm: Added.

(didClickAutoFillButton):
(-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]):
(-[AutoFillDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

12:09 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

12:05 PM Changeset in webkit [221432] by clopez@igalia.com

3 edits in trunk/LayoutTests

[GTK][WPE] Mark test media/event-queue-crash as flaky
https://bugs.webkit.org/show_bug.cgi?id=176174

Unreviewed gardening.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

11:52 AM Changeset in webkit [221431] by Chris Dumez

5 edits in trunk/Source

Use WTF::crossThreadCopy() in more places
https://bugs.webkit.org/show_bug.cgi?id=176169

Reviewed by Andreas Kling.

Use WTF::crossThreadCopy() in more places to make code more concise.

Source/WebCore:

Modules/indexeddb/IDBValue.cpp:

(WebCore::IDBValue::setAsIsolatedCopy):

Source/WebKit:

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):

11:48 AM Changeset in webkit [221430] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

MSE-to-Canvas painting can become "stuck" during heavy workloads
https://bugs.webkit.org/show_bug.cgi?id=176170

Reviewed by Eric Carlson.

During heavy workloads, the trigger from CMBufferQueue notifying us that we have dipped below
the "low-water mark" of decoded (and decoding) frames will not fire. Instead of using a trigger
(since it will not fire when the number of "frames being decoded" changes, just the number of
decoded frames), just call maybeBecomeReadyForMoreMediaData() whenever the number of frames in
the decoded queue decreases, or when the number of frames being decoded decreases.

platform/graphics/cocoa/WebCoreDecompressionSession.h:
platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaData):
(WebCore::WebCoreDecompressionSession::enqueueSample):
(WebCore::WebCoreDecompressionSession::decodeSample):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
(WebCore::WebCoreDecompressionSession::getFirstVideoFrame):
(WebCore::WebCoreDecompressionSession::automaticDequeue):
(WebCore::WebCoreDecompressionSession::imageForTime):
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaDataCallback): Deleted.

11:37 AM Changeset in webkit [221429] by Jonathan Bedard

2 edits in trunk/LayoutTests

iOS should include both iPad and iPhone when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=176172
<rdar://problem/34190219>

Reviewed by Tim Horton.

resources/ui-helper.js:

(window.UIHelper.isIOS):

11:31 AM Changeset in webkit [221428] by commit-queue@webkit.org

3 edits
4 adds in trunk

Take into account removed caches in Caches::remove assertion
https://bugs.webkit.org/show_bug.cgi?id=176164

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebKit:

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::remove):

LayoutTests:

http/wpt/cache-storage/cache-remove-twice-expected.txt: Added.
http/wpt/cache-storage/cache-remove-twice.html: Added.
http/wpt/cache-storage/resources/cache-remove-twice-iframe.html: Added.

11:21 AM Changeset in webkit [221427] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Move consume promise from FetchBody to FetchBodyConsumer
https://bugs.webkit.org/show_bug.cgi?id=176121

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

No change of behavior.

FetchBodyConsumer should be made responsible for data consumption through promise getters and ReadableStream.
This will allow making data consumption consistent for Request and Response.
This patch is doing the first step.

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeOnceLoadingFinished):
(WebCore::FetchBody::consumeBlob):
(WebCore::FetchBody::loadingFailed):
(WebCore::FetchBody::loadingSucceeded):
(WebCore::FetchBody::clone const):

Modules/fetch/FetchBody.h:

(WebCore::FetchBody::cleanConsumer):
(WebCore::FetchBody::cleanConsumePromise): Deleted.

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::setConsumePromise):
(WebCore::FetchBodyConsumer::loadingFailed):
(WebCore::FetchBodyConsumer::loadingSucceeded):
(WebCore::FetchBodyConsumer::clean):

Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::clean): Deleted.

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::stop):

11:19 AM Changeset in webkit [221426] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit

Do not create a salt if the CacheStorage engine should not persist
https://bugs.webkit.org/show_bug.cgi?id=176138

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::~Engine): Ensuring that Caches will not try using the engine if it goes away.
(WebKit::CacheStorage::Engine::initialize): Removing making a salt if engine data is not persistent.

NetworkProcess/cache/CacheStorageEngine.h: Check persistency according the root path. If it is null, caches should not try to do persistency.
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesRootPath):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::detach):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::writeCachesToDisk):

NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::shouldPersist const):

NetworkProcess/cache/NetworkCacheData.cpp: Making makeSalt private again.

(WebKit::NetworkCache::makeSalt):

NetworkProcess/cache/NetworkCacheData.h:

11:15 AM Changeset in webkit [221425] by pvollan@apple.com

2 edits in trunk/Source/WTF

[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=176163

Reviewed by Alex Christensen.

My previous attempt at fixing this crash in <http://trac.webkit.org/changeset/221323>
was incorrect, since it is still crashing on the bot(s). The current theory of why this
is failing is that the WorkQueue object deletes itself in the middle of the
performWorkOnRegisteredWorkThread method when calling deref(). There is no need to
increase the reference count of the work queue for each function we want to call on the
work thread. It is sufficient to increase it for every work thread we start, and then
dereference it when the thread ends. We should also not attempt to access members after
the deref() call, which can potentially be unsafe.

wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::workThreadCallback):
(WTF::WorkQueue::performWorkOnRegisteredWorkThread):
(WTF::WorkQueue::dispatch):

11:09 AM Changeset in webkit [221424] by Michael Catanzaro

2 edits in trunk/LayoutTests

Unreviewed, remove crash expectation for hopefully-fixed test
https://bugs.webkit.org/show_bug.cgi?id=175577

platform/gtk/TestExpectations:

9:55 AM Changeset in webkit [221423] by Darin Adler

6 edits in trunk

REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame()

!needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()

https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser and Antti Koivisto.

Source/WebCore:

dom/Document.cpp:

dom/Document.h: Updated for above change.

page/FrameView.cpp:

LayoutTests:

platform/mac-wk2/TestExpectations: Re-enable the disabled test.

9:38 AM Changeset in webkit [221422] by fpizlo@apple.com

42 edits
3 adds in trunk

JSTests:
Unreviewed, skipping slow tests.

These tests are now timing out. They would have always been slow. The timeouts are probably because OOMs
work differently now.

stress/regexp-prototype-exec-on-too-long-rope.js:
stress/string-prototype-charCodeAt-on-too-long-rope.js:

Source/bmalloc:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

This adds a StringGigacage.

bmalloc/Gigacage.cpp:
bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::forEachKind):

bmalloc/HeapKind.h:

(bmalloc::isGigacage):
(bmalloc::gigacageKind):
(bmalloc::heapKind):

Source/JavaScriptCore:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToAtomicString const):
(JSC::JSRopeString::resolveRope const):

runtime/JSString.h:

(JSC::JSString::create):
(JSC::JSString::createHasOtherOwner):

runtime/JSStringBuilder.h:
runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

Source/WebCore:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

No new tests because no new behavior.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeSpaces):

Source/WTF:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

This makes all strings allocations come from the string gigacage. Because we expect string allocation
to be a hot path, I created specialized allocation paths for the string gigacage. These paths are
accessible via <wtf/text/StringMalloc.h>. However, those paths are equivalent to saying
Gigacage::malloc and friends with the Gigacage::String kind.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Deque.h:
wtf/FastMalloc.cpp:

(WTF::fastFree):

wtf/FastMalloc.h:

(WTF::FastMalloc::malloc):
(WTF::FastMalloc::tryMalloc):
(WTF::FastMalloc::realloc):
(WTF::FastMalloc::free):

wtf/Forward.h:
wtf/Gigacage.cpp:

(Gigacage::tryMalloc):

wtf/Gigacage.h:

(Gigacage::name):

wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::deallocateBuffer):
(WTF::Malloc>::Vector):
(WTF::=):
(WTF::Malloc>::contains const):
(WTF::Malloc>::findMatching const):
(WTF::Malloc>::find const):
(WTF::Malloc>::reverseFind const):
(WTF::Malloc>::appendIfNotContains):
(WTF::Malloc>::fill):
(WTF::Malloc>::appendRange):
(WTF::Malloc>::expandCapacity):
(WTF::Malloc>::tryExpandCapacity):
(WTF::Malloc>::resize):
(WTF::Malloc>::resizeToFit):
(WTF::Malloc>::shrink):
(WTF::Malloc>::grow):
(WTF::Malloc>::asanSetInitialBufferSizeTo):
(WTF::Malloc>::asanSetBufferSizeToFullCapacity):
(WTF::Malloc>::asanBufferSizeWillChangeTo):
(WTF::Malloc>::reserveCapacity):
(WTF::Malloc>::tryReserveCapacity):
(WTF::Malloc>::reserveInitialCapacity):
(WTF::Malloc>::shrinkCapacity):
(WTF::Malloc>::append):
(WTF::Malloc>::tryAppend):
(WTF::Malloc>::constructAndAppend):
(WTF::Malloc>::tryConstructAndAppend):
(WTF::Malloc>::appendSlowCase):
(WTF::Malloc>::constructAndAppendSlowCase):
(WTF::Malloc>::tryConstructAndAppendSlowCase):
(WTF::Malloc>::uncheckedAppend):
(WTF::Malloc>::appendVector):
(WTF::Malloc>::insert):
(WTF::Malloc>::insertVector):
(WTF::Malloc>::remove):
(WTF::Malloc>::removeFirst):
(WTF::Malloc>::removeFirstMatching):
(WTF::Malloc>::removeAll):
(WTF::Malloc>::removeAllMatching):
(WTF::Malloc>::reverse):
(WTF::Malloc>::map const):
(WTF::Malloc>::releaseBuffer):
(WTF::Malloc>::checkConsistency):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::removeRepeatedElements):
(WTF::minCapacity>::Vector): Deleted.
(WTF::minCapacity>::contains const): Deleted.
(WTF::minCapacity>::findMatching const): Deleted.
(WTF::minCapacity>::find const): Deleted.
(WTF::minCapacity>::reverseFind const): Deleted.
(WTF::minCapacity>::appendIfNotContains): Deleted.
(WTF::minCapacity>::fill): Deleted.
(WTF::minCapacity>::appendRange): Deleted.
(WTF::minCapacity>::expandCapacity): Deleted.
(WTF::minCapacity>::tryExpandCapacity): Deleted.
(WTF::minCapacity>::resize): Deleted.
(WTF::minCapacity>::resizeToFit): Deleted.
(WTF::minCapacity>::shrink): Deleted.
(WTF::minCapacity>::grow): Deleted.
(WTF::minCapacity>::asanSetInitialBufferSizeTo): Deleted.
(WTF::minCapacity>::asanSetBufferSizeToFullCapacity): Deleted.
(WTF::minCapacity>::asanBufferSizeWillChangeTo): Deleted.
(WTF::minCapacity>::reserveCapacity): Deleted.
(WTF::minCapacity>::tryReserveCapacity): Deleted.
(WTF::minCapacity>::reserveInitialCapacity): Deleted.
(WTF::minCapacity>::shrinkCapacity): Deleted.
(WTF::minCapacity>::append): Deleted.
(WTF::minCapacity>::tryAppend): Deleted.
(WTF::minCapacity>::constructAndAppend): Deleted.
(WTF::minCapacity>::tryConstructAndAppend): Deleted.
(WTF::minCapacity>::appendSlowCase): Deleted.
(WTF::minCapacity>::constructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::tryConstructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::uncheckedAppend): Deleted.
(WTF::minCapacity>::appendVector): Deleted.
(WTF::minCapacity>::insert): Deleted.
(WTF::minCapacity>::insertVector): Deleted.
(WTF::minCapacity>::remove): Deleted.
(WTF::minCapacity>::removeFirst): Deleted.
(WTF::minCapacity>::removeFirstMatching): Deleted.
(WTF::minCapacity>::removeAll): Deleted.
(WTF::minCapacity>::removeAllMatching): Deleted.
(WTF::minCapacity>::reverse): Deleted.
(WTF::minCapacity>::map const): Deleted.
(WTF::minCapacity>::releaseBuffer): Deleted.
(WTF::minCapacity>::checkConsistency): Deleted.

wtf/text/AtomicStringImpl.h:
wtf/text/CString.cpp:

(WTF::CStringBuffer::createUninitialized):

wtf/text/CString.h:
wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::~StringBuffer):
(WTF::StringBuffer::resize):

wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::destroy):
(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::releaseAssertCaged const):

wtf/text/StringImpl.h:

(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::bufferOwnership const):
(WTF::StringImpl::assertCaged const):

wtf/text/StringMalloc.cpp: Added.

(WTF::tryStringMalloc):
(WTF::stringMalloc):
(WTF::stringRealloc):
(WTF::stringFree):

wtf/text/StringMalloc.h: Added.

(WTF::StringMalloc::malloc):
(WTF::StringMalloc::tryMalloc):
(WTF::StringMalloc::realloc):
(WTF::StringMalloc::free):

wtf/text/StringVector.h: Added.
wtf/text/SymbolImpl.h:
wtf/text/UniquedStringImpl.h:
wtf/text/WTFString.h:

(WTF::String::adopt):
(WTF::String::assertCaged const):
(WTF::String::releaseAssertCaged const):

8:23 AM Changeset in webkit [221421] by jmarcell@apple.com

2 edits in branches/safari-604-branch/Tools

Cherry-pick r220296. rdar://problem/34177414

7:10 AM Changeset in webkit [221420] by Carlos Garcia Campos

4 edits in trunk

[GTK] Several InputMethodFilter tests are failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=176158

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

UIProcess/gtk/InputMethodFilter.cpp:

Tools:

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
(TestWebKitAPI::TEST):
(TestWebKitAPI::verifyCanceledComposition): Deleted.

7:07 AM Changeset in webkit [221419] by Carlos Garcia Campos

8 edits in trunk

[GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
https://bugs.webkit.org/show_bug.cgi?id=176154

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::keyStroke):

TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

5:57 AM Changeset in webkit [221418] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Mark some tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=176156

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-31

platform/gtk/TestExpectations:
- fast/hidpi/percent-height-image-nested.html: passing since test change in r217943.
- fast/ruby/bopomofo.html: passing since r216874.
- fast/ruby/bopomofo-letter-spacing.html: passing since r216874.
- fast/ruby/bopomofo-rl.html: passing since r216874.
- fast/sub-pixel/sub-pixel-composited-layers.html: passing since r215179.
- fast/text/font-weight-download-2.html: passing since r216944.
- fast/text/justify-ideograph-vertical.html: passing since r216874.
- fast/text/multiglyph-characters.html: passing since r216817.
- http/tests/misc/will-send-request-returns-null-on-redirect.html: passing since r214245.
- http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html: passing since r211627.
- imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-005.html: has been passing all along on GTK.
- imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.html: passing since r218269-r218276.
- imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: matching expectations since rebaseline in r215164.
- imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: matching expectations since rebaseline in r215164.
- imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html: passing since r218248.

3:04 AM Changeset in webkit [221417] by Yusuke Suzuki

58 edits
4 adds in trunk

[JSC] Use reifying system for "name" property of builtin JSFunction
https://bugs.webkit.org/show_bug.cgi?id=175260

Reviewed by Saam Barati.

JSTests:

stress/accessors-get-set-prefix.js:
stress/builtin-function-name.js: Added.

(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):

stress/private-name-as-anonymous-builtin.js: Added.

(shouldBe):
(NotPromise):

Source/JavaScriptCore:

Currently builtin JSFunction uses direct property for "name", which is different
from usual JSFunction. Usual JSFunction uses reifying system for "name". We would like
to apply this reifying mechanism to builtin JSFunction to simplify code and drop
JSFunction::createBuiltinFunction.

We would like to store the "correct" name in FunctionExecutable. For example,
we would like to store the name like "get [Symbol.species]" to FunctionExecutable
instead of specifying name when creating JSFunction. To do so, we add a new
annotations, @getter and @overriddenName. When @getter is specified, the name of
the function becomes "get xxx". And when @overriddenName="xxx" is specified,
the name of the function becomes "xxx".

We also treat @xxx as anonymous builtin functions that cannot be achieved in
the current JS without privilege.

Scripts/builtins/builtins_generate_combined_header.py:

(generate_section_for_code_table_macro):

Scripts/builtins/builtins_generate_combined_implementation.py:

(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):

Scripts/builtins/builtins_generate_separate_header.py:

(generate_section_for_code_table_macro):

Scripts/builtins/builtins_generate_separate_implementation.py:

(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):

Scripts/builtins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):

Scripts/builtins/builtins_templates.py:
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js:

(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):

Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js:

(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):

Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
builtins/AsyncIteratorPrototype.js:

(symbolAsyncIteratorGetter): Deleted.

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::BuiltinExecutables):

builtins/BuiltinExecutables.h:
builtins/BuiltinNames.h:
builtins/FunctionPrototype.js:

(symbolHasInstance): Deleted.

builtins/GlobalOperations.js:

(globalPrivate.speciesGetter): Deleted.

builtins/IteratorPrototype.js:

(symbolIteratorGetter): Deleted.

builtins/PromiseConstructor.js:

(all.newResolveElement.return.resolve):
(all.newResolveElement):
(all):

builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapability.executor):
(globalPrivate.newPromiseCapability):
(globalPrivate.createResolvingFunctions.resolve):
(globalPrivate.createResolvingFunctions.reject):
(globalPrivate.createResolvingFunctions):

builtins/RegExpPrototype.js:

(match): Deleted.
(replace): Deleted.
(search): Deleted.
(split): Deleted.

jsc.cpp:

(functionCreateBuiltin):

runtime/AsyncIteratorPrototype.cpp:

(JSC::AsyncIteratorPrototype::finishCreation):

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

runtime/IteratorPrototype.cpp:

(JSC::IteratorPrototype::finishCreation):

runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
(JSC::JSFunction::createBuiltinFunction): Deleted.

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectBuiltinFunction):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition):

runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

runtime/Lookup.cpp:

(JSC::reifyStaticAccessor):

runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):

runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

Source/WebCore:

Test: js/dom/builtin-getter-name.html

Use @getter for JSBuiltin getters.

Modules/fetch/FetchResponse.js:

(bodyUsed): Deleted.
(body): Deleted.

Modules/streams/ReadableByteStreamController.js:

(byobRequest): Deleted.
(desiredSize): Deleted.

Modules/streams/ReadableStream.js:

(locked): Deleted.

Modules/streams/ReadableStreamBYOBReader.js:

(closed): Deleted.

Modules/streams/ReadableStreamBYOBRequest.js:

(view): Deleted.

Modules/streams/ReadableStreamDefaultController.js:

(desiredSize): Deleted.

Modules/streams/ReadableStreamDefaultReader.js:

(closed): Deleted.

Modules/streams/WritableStream.js:

(closed): Deleted.
(ready): Deleted.
(state): Deleted.

bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::finishCreation):

LayoutTests:

js/dom/builtin-getter-name-expected.txt: Added.
js/dom/builtin-getter-name.html: Added.

1:15 AM Changeset in webkit [221416] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.

It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro

numbers into a version string, using the same approach as WebKitAutomationSession.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed