Timeline



Oct 29, 2017:

8:40 PM Changeset in webkit [224168] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Use of uninitialized value $targetIdlFile in hash element at preprocess-idls.pl line 165.
​https://bugs.webkit.org/show_bug.cgi?id=177743

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-29
Reviewed by Darin Adler.

GamepadWebVR.idl supplements Gamepad.idl. But, Gamepad.idl is not
processed because ENABLE_GAMEPAD is OFF.

No new tests since there should be no behavioral change.

  • CMakeLists.txt: Include GamepadWebVR.idl only if ENABLE_GAMEPAD.
  • Sources.txt: Ditto.
  • bindings/scripts/preprocess-idls.pl: Die if a supplemented IDL file is not found.
7:23 PM Changeset in webkit [224167] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source

Apply patch. rdar://problem/35058061

We should ignore HSTS for partitioned, cross-origin subresource requests since HSTS is being abused for cross-site tracking purposes.

5:04 PM Changeset in webkit [224166] by Chris Dumez
  • 6 edits
    2 adds in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed, revaseline a few tests after r224156.

  • web-platform-tests/service-workers/service-worker/import-scripts-redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/mime-sniffing.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ready.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https-expected.txt:

LayoutTests:
Unreviewed, rebaseline a few tests after r224156.

4:07 PM Changeset in webkit [224165] by weinig@apple.com
  • 13 edits
    4 adds in trunk

[Conic Gradients] Add support for parsing conic gradients
​https://bugs.webkit.org/show_bug.cgi?id=178987

Reviewed by Dean Jackson.

Source/WebCore:

Adds initial support, disabled by default, for parsing conic gradients as per
CSS 4 Images - ​https://www.w3.org/TR/css-images-4/#conic-gradients.

Test: fast/gradients/conic-gradient-parsing.html

  • css/CSSGradientValue.cpp:

(WebCore::clone):
(WebCore::CSSGradientValue::isCacheable const):
(WebCore::CSSConicGradientValue::customCSSText const):
(WebCore::CSSConicGradientValue::createGradient):
(WebCore::CSSConicGradientValue::equals const):

  • css/CSSGradientValue.h:


Add CSSConicGradientValue as a subclass of CSSGradientValue and implement
customCSSText() and equals(). Stub out createGradient() as painting is not
yet implemented.


  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize const):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::isPending const):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque const):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

Dispatch to CSSConicGradientValue as needed.


  • css/CSSValue.h:

(WebCore::CSSValue::isImageGeneratorValue const):
(WebCore::CSSValue::isGradientValue const):
(WebCore::CSSValue::isConicGradientValue const):

Add conic gradient predicate support and update isImageGeneratorValue and
isGradientValue to include conic gradient.


  • css/CSSValueKeywords.in:


Add conic-gradient and repeating-conic-gradient.


  • css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

  • css/parser/CSSParserMode.h:

(WebCore::CSSParserContextHash::hash):

Add runtime flags to enable conic gradients.


  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):

Helper, similar to consumeLengthOrPercent, for consumeGradientColorStops.
Corresponds to ​https://drafts.csswg.org/css-values-4/#typedef-angle-percentage


(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):

Convert to take CSSGradientValue by reference.


(WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):

Helper, similar to consumeGradientColorStops, but for angular color stops
used in conic gradients. Corresponds to ​https://www.w3.org/TR/css-images-4/#typedef-angular-color-stop-list
but does not yet support double position syntax.


(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):

Pass CSSGradientValue by reference.


(WebCore::CSSPropertyParserHelpers::consumeConicGradient):

Parse conic gradient.


(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):

Dispatch to consumeConicGradient for repeating and non-repeating
conic gradients.


(WebCore::CSSPropertyParserHelpers::isGeneratedImage):

Put each value on its own line to make it more readable and add CSSValueConicGradient
and CSSValueRepeatingConicGradient.


  • page/Settings.yaml:


Add a setting to enable conic gradients. Disabled by default.

  • features.json:


Move conic gradients to "In Development".

LayoutTests:

  • http/wpt/css: Added.
  • http/wpt/css/css-images-4: Added.
  • http/wpt/css/css-images-4/conic-gradient-parsing-expected.txt: Added.
  • http/wpt/css/css-images-4/conic-gradient-parsing.html: Added.

Add tests for basic parsing of conic gradients.

2:08 PM Changeset in webkit [224164] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Expose the currentTime property on Animation
​https://bugs.webkit.org/show_bug.cgi?id=178988

Unreviewed.

Style fixes missed in previous patch.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setCurrentTime):

1:22 PM Changeset in webkit [224163] by graouts@webkit.org
  • 5 edits
    2 adds in trunk

[Web Animations] Expose the currentTime property on Animation
​https://bugs.webkit.org/show_bug.cgi?id=178988

Reviewed by Dean Jackson.

Source/WebCore:

We now expose the currentTime property on Animation objects, our first
step in implementing the Web Animations timing model, specifically section
3.5.4. "The current time of an animation" and section 3.5.5. "Setting the
current time of an animation". Setting the startTime has implications on
currentTime and vice-versa.

Test: webanimations/animation-current-time.html

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::startTime const):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::bindingsCurrentTime const):
(WebCore::WebAnimation::setBindingsCurrentTime):
(WebCore::WebAnimation::currentTime const):
(WebCore::WebAnimation::setCurrentTime):

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:

LayoutTests:

Add a new test that checks that the currentTime property is set
correctly based on the startTime value and the document timeline
currentTime, and that setting the property may raise an exception
and otherwise update the animation startTime.

  • webanimations/animation-current-time-expected.txt: Added.
  • webanimations/animation-current-time.html: Added.
11:24 AM WikiStart edited by Laszlo Gombos
(diff)
10:58 AM Changeset in webkit [224162] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/LayoutTests

Cherry-pick r224139. rdar://problem/35143359

10:58 AM Changeset in webkit [224161] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r224135. rdar://problem/35143359

10:58 AM Changeset in webkit [224160] by jmarcell@apple.com
  • 15 edits
    29 adds in branches/safari-604-branch

Cherry-pick r224134. rdar://problem/35143359

3:15 AM Changeset in webkit [224159] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Assert that no script is executed during style recalc
​https://bugs.webkit.org/show_bug.cgi?id=178845
<rdar://problem/35106129>

Reviewed by Antti Koivisto.

This patch adds NoEventDispatchAssertion to Document::updateStyle and Document::updateStyleIfNeeded
to make sure we don't start mutating DOM in the middle of a style update.

Added NoEventDispatchAssertion::EventAllowedScope for various places in SVGUseElement to update its
shadow tree since that happens while updating the style.

No new tests since there should be no behavioral change.

  • dom/Document.cpp:

(WebCore::Document::resolveStyle): Added NoEventDispatchAssertion while flushing pending stylesheets
and calling FrameView::willRecalcStyle, and while the style tree solver is in works. Also moved in
the code to update the selection and schedule to dispatch a fake mouse event into the same scope.
Also increment m_styleRecalcCount in the same code since post resolution callbacks could run author
scripts which in turn trigger another (recursive) style recalc.
(WebCore::Document::updateStyleIfNeeded): Put everything but the call to resolveStyle in a scope with
NoEventDispatchAssertion.

  • dom/Element.cpp:

(WebCore::Element::cloneElementWithChildren): Added NoEventDispatchAssertion::EventAllowedScope to the
newly cloned element for SVG use element's shadow tree.
(WebCore::Element::cloneElementWithoutChildren): Ditto.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Make the assertion more precise to workaround the fact SVG
use elements update its shadow tree in the middle of style updates. Also removed a redundant assertion
since the result of NoEventDispatchAssertion::isEventDispatchAllowedInSubtree cannot chance without
pushing or popoing the stack frame.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearShadowTree):
(WebCore::SVGUseElement::updateShadowTree): Added NoEventDispatchAssertion to the user-agent shadow root
of a SVG use element. Since this is a newly created shadow tree which hasn't been exposed to author
scripts, it's safe to mutate them during the style recalc even though it's not the best design.
(WebCore::SVGUseElement::cloneTarget const): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree const):

3:06 AM Changeset in webkit [224158] by dino@apple.com
  • 14 edits in trunk

createImageBitmap with HTMLCanvasElement
​https://bugs.webkit.org/show_bug.cgi?id=178984
<rdar://problem/35238440>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Update the expected results.

  • web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
  • web-platform-tests/2dcontext/imagebitmap/createImageBitmap-sizeOverflow-expected.txt:
  • web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt:

Source/WebCore:

Implement createImageBitmap(HTMLCanvasElement).

While here, explicitly reject the promises for the
methods we haven't yet implemented. I was hoping this
would avoid a lengthy timeout in one of the imported
WPT tests but, alas, it doesn't. However, it's still
a good idea.

Extend internal WPT proposals to cover canvas creation.

  • html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise): Get the image from
the canvas and draw it into a new ImageBitmap buffer.

LayoutTests:

Exercise new creation method.

  • http/wpt/2dcontext/imagebitmap/common.js:

(create9x9CanvasWithTargetImage):

  • http/wpt/2dcontext/imagebitmap/createImageBitmap-expected.txt:
  • http/wpt/2dcontext/imagebitmap/createImageBitmap-sizing-expected.txt:
  • http/wpt/2dcontext/imagebitmap/createImageBitmap-sizing.html:
  • http/wpt/2dcontext/imagebitmap/createImageBitmap.html:
  • http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap-expected.txt:
  • http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html:

Oct 28, 2017:

10:31 PM Changeset in webkit [224157] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Make HTTPS WPT tests time out through testharness.js to get better error reports
​https://bugs.webkit.org/show_bug.cgi?id=178982

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-28
Reviewed by Chris Dumez.

  • resources/testharnessreport.js: extending to tests run over HTTPS WPT port 9443.
8:02 PM Changeset in webkit [224156] by commit-queue@webkit.org
  • 74 edits
    1 copy
    4 moves
    287 adds
    26 deletes in trunk/LayoutTests

Rebase WPT tests up to a1c0107
​https://bugs.webkit.org/show_bug.cgi?id=178589

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-28
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • resources/TestRepositories:
  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests: Updated.

LayoutTests:

  • TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-sync-default-feature-policy.sub-expected.txt: Added.
7:45 PM Changeset in webkit [224155] by mmaxfield@apple.com
  • 6 edits
    3 deletes in trunk

[iOS] Unify Font::platformCharWidthInit() with macOS
​https://bugs.webkit.org/show_bug.cgi?id=178951
<rdar://problem/7848198>

Reviewed by Zalan Bujtas.

Source/WebCore:

The only reason these codepaths are different is because historically this codepath
didn't work with GS fonts (which we don't use anymore).

Tests: fast/forms/search-styled.html

fast/forms/text-control-intrinsic-widths.html
fast/forms/textarea-width.html

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformCharWidthInit):

LayoutTests:

Updating expected results.

  • platform/ios-wk2/fast/forms/search-styled-expected.txt: Removed.
  • platform/ios-wk2/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
  • platform/ios-wk2/fast/forms/textarea-width-expected.txt: Removed.
  • platform/ios/fast/forms/search-styled-expected.txt:
  • platform/ios/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/ios/fast/forms/textarea-width-expected.txt:
11:24 AM Changeset in webkit [224154] by weinig@apple.com
  • 9 edits
    1 move
    3 adds
    2 deletes in trunk/Source/WebKit

[Settings] Generate more of the WebKit preferences code
​https://bugs.webkit.org/show_bug.cgi?id=178945

Reviewed by Chris Dumez.

Generate WebPreferencesKeys.{h,cpp} and WebPreferencesStoreDefaultsMap.cpp

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit.xcodeproj/project.pbxproj:
  • Scripts/GeneratePreferences.rb:


Generate new files.


  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:


Update include.


  • Scripts/PreferencesTemplates/WebPreferencesKeys.cpp.erb: Added.
  • Scripts/PreferencesTemplates/WebPreferencesKeys.h.erb: Added.
  • Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb: Added.

Add template files for new generated files.

  • Shared/WebPreferencesDefaultValues.h: Copied from Source/WebKit/Shared/WebPreferencesDefinitionsBase.h.
  • Shared/WebPreferencesDefinitionsBase.h:


Renamed WebPreferencesDefinitionsBase.h to WebPreferencesDefaultValues.h to better indicate what it is.


  • Shared/WebPreferencesKeys.cpp: Removed.
  • Shared/WebPreferencesKeys.h: Removed.


Replaced with generated versions.

  • Shared/WebPreferencesStore.cpp:

(WebKit::defaults): Deleted.

  • Shared/WebPreferencesStore.h:


Replace macro driven defaults map with generated WebPreferencesStoreDefaultsMap.cpp.

10:40 AM Changeset in webkit [224153] by Chris Dumez
  • 6 edits
    3 adds in trunk

self.ExtendableEvent / Client / Clients / WindowClient do not exist in a Service Worker
​https://bugs.webkit.org/show_bug.cgi?id=178976

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/workers/service/ServiceWorkerGlobalScope-properties.html

  • workers/service/ExtendableEvent.idl:
  • workers/service/FetchEvent.idl:

Drop [Exposed=Worker] as there is already [Exposed=ServiceWorker] and
ServiceWorkerGlobalScope inherits from WorkerGlobalScope. This is redundant
and we would hit assertions and adding the global constructors at runtime
when the feature is enabled, because the property already exists.

Source/WebKit:

Actually enable the Service Worker RuntimeEnabledFeature in the Service Worker
WebProcess.

  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::updatePreferences):

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/ServiceWorkerGlobalScope-properties-expected.txt: Added.
  • http/tests/workers/service/ServiceWorkerGlobalScope-properties.html: Added.
  • http/tests/workers/service/resources/ServiceWorkerGlobalScope-properties-worker.js: Added.
10:38 AM Changeset in webkit [224152] by Chris Dumez
  • 6 edits in trunk/LayoutTests

Update testharness.js to work around our lack of support for MessagePort in service workers
​https://bugs.webkit.org/show_bug.cgi?id=178977

Reviewed by Sam Weinig.

Update testharness.js to work around our lack of support for MessagePort in service workers, similarly
to what was already done for Edge.

  • web-platform-tests/resources/testharness.js:
10:18 AM Changeset in webkit [224151] by Michael Catanzaro
  • 4 edits in trunk/Tools

[WPE] Build gst-plugins-base without pango support
​https://bugs.webkit.org/show_bug.cgi?id=178918

Reviewed by Carlos Garcia Campos.

We need to build gst-plugins-base without pango support for WPE. Let's use JHBuild
conditions so we can make platform-specific changes in the shared GStreamer moduleset.

  • gstreamer/jhbuild.modules:
  • gtk/jhbuildrc:
  • wpe/jhbuildrc:
8:24 AM Changeset in webkit [224150] by Alan Bujtas
  • 34 edits
    2 adds in trunk/Source

[FrameView::layout cleanup] Move core layout logic to a separate class.
​https://bugs.webkit.org/show_bug.cgi?id=178771
<rdar://problem/35166542>

Reviewed by Simon Fraser.

Move layout code out from FrameView to LayoutContext.

Source/WebCore:

LayoutContext holds all the layout related logic (scheduling, needsLayout, handling layout states),
while scrolling, view sizing methods stay in FrameView.
Having a dedicated LayoutContext allows to structure the code better.

Covered by existing tests.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::rendererNeedsDeferredUpdate):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement const):
(WebCore::AccessibilityRenderObject::layoutCount const):

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
(WebCore::Document::implicitClose):
(WebCore::Document::isLayoutTimerActive):

  • dom/Element.cpp:

(WebCore::Element::absoluteEventHandlerBounds):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin const):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didAttachRenderers):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopForUserCancel):

  • page/Frame.cpp:

(WebCore::Frame::setView):
(WebCore::Frame::clearTimers):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::didFirstLayout const):
(WebCore::FrameView::willDestroyRenderTree):
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::topContentInsetDidChange):
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::adjustScrollbarsForLayout):
(WebCore::FrameView::willDoLayout): This takes care of the view related task right before entering render tree layout.
(WebCore::FrameView::didLayout): post layout tasks.
(WebCore::FrameView::shouldDeferScrollUpdateAfterContentSizeChange):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::updateLayerPositionsAfterScrolling):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):
(WebCore::FrameView::availableContentSizeChanged):
(WebCore::FrameView::updateContentsSize):
(WebCore::FrameView::needsLayout const):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::scheduleSelectionUpdate):
(WebCore::FrameView::updateEmbeddedObjects):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::flushPostLayoutTasksQueue):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::paintControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::forceLayout):
(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer): Deleted.
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer): Deleted.
(WebCore::SubtreeLayoutStateMaintainer::shouldDisableLayoutStateForSubtree): Deleted.
(): Deleted.
(WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker): Deleted.
(WebCore::applyTextSizingIfNeeded): Deleted.
(WebCore::FrameView::handleLayoutWithFrameFlatteningIfNeeded): Deleted.
(WebCore::FrameView::updateStyleForLayout): Deleted.
(WebCore::FrameView::canPerformLayout const): Deleted.
(WebCore::FrameView::layout): Deleted.
(WebCore::FrameView::runOrSchedulePostLayoutTasks): Deleted.
(WebCore::FrameView::convertSubtreeLayoutToFullLayout): Deleted.
(WebCore::FrameView::layoutTimerFired): Deleted.
(WebCore::FrameView::scheduleRelayout): Deleted.
(WebCore::isObjectAncestorContainerOf): Deleted.
(WebCore::FrameView::scheduleRelayoutOfSubtree): Deleted.
(WebCore::FrameView::layoutPending const): Deleted.
(WebCore::FrameView::unscheduleRelayout): Deleted.
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded): Deleted.

  • page/FrameView.h:
  • page/LayoutContext.cpp: Added.

(WebCore::isObjectAncestorContainerOf):
(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::shouldDisableLayoutStateForSubtree):
(WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker):
(WebCore::LayoutScope::LayoutScope):
(WebCore::LayoutScope::~LayoutScope):
(WebCore::LayoutContext::LayoutContext):
(WebCore::LayoutContext::layout):
(WebCore::LayoutContext::runOrScheduleAsynchronousTasks):
(WebCore::LayoutContext::runAsynchronousTasks):
(WebCore::LayoutContext::flushAsynchronousTasks):
(WebCore::LayoutContext::reset):
(WebCore::LayoutContext::needsLayout const):
(WebCore::LayoutContext::setNeedsLayout):
(WebCore::LayoutContext::enableSetNeedsLayout):
(WebCore::LayoutContext::disableSetNeedsLayout):
(WebCore::LayoutContext::scheduleLayout):
(WebCore::LayoutContext::unscheduleLayout):
(WebCore::LayoutContext::scheduleSubtreeLayout):
(WebCore::LayoutContext::layoutTimerFired):
(WebCore::LayoutContext::convertSubtreeLayoutToFullLayout):
(WebCore::LayoutContext::setSubtreeLayoutRoot):
(WebCore::LayoutContext::canPerformLayout const):
(WebCore::LayoutContext::applyTextSizingIfNeeded):
(WebCore::LayoutContext::updateStyleForLayout):
(WebCore::LayoutContext::handleLayoutWithFrameFlatteningIfNeeded):
(WebCore::LayoutContext::startLayoutAtMainFrameViewIfNeeded):
(WebCore::LayoutContext::frame const):
(WebCore::LayoutContext::view const):
(WebCore::LayoutContext::renderView const):
(WebCore::LayoutContext::document const):

  • page/LayoutContext.h: Added.

(WebCore::LayoutContext::startDisallowingLayout):
(WebCore::LayoutContext::endDisallowingLayout):
(WebCore::LayoutContext::layoutPhase const):
(WebCore::LayoutContext::isLayoutNested const):
(WebCore::LayoutContext::layoutCount const):
(WebCore::LayoutContext::isLayoutPending const):
(WebCore::LayoutContext::isInLayout const):
(WebCore::LayoutContext::isInRenderTreeLayout const):
(WebCore::LayoutContext::inPaintableState const):
(WebCore::LayoutContext::subtreeLayoutRoot const):
(WebCore::LayoutContext::clearSubtreeLayoutRoot):
(WebCore::LayoutContext::resetFirstLayoutFlag):
(WebCore::LayoutContext::didFirstLayout const):
(WebCore::LayoutContext::setNeedsFullRepaint):
(WebCore::LayoutContext::needsFullRepaint const):
(WebCore::LayoutContext::layoutDisallowed const):
(WebCore::LayoutContext::isLayoutSchedulingEnabled const):
(WebCore::LayoutContext::inAsynchronousTasks const):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::imageChanged):
(WebCore::RenderBox::computeLogicalWidthInFragment const):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::clearSubtreeLayoutRootIfNeeded const):
(WebCore::RenderElement::checkForRepaintDuringLayout const):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::performLayoutWithFlattening):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

  • rendering/RenderObject.cpp:

(WebCore::scheduleRelayoutForSubtree):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):

  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

  • testing/Internals.cpp:

(WebCore::Internals::layoutCount const):

Source/WebKitLegacy/mac:

  • WebView/WebClipView.mm:

(-[WebClipView _immediateScrollToPoint:]):

  • WebView/WebFrame.mm:

(-[WebFrame layoutCount]):

Source/WebKitLegacy/win:

  • WebFrame.cpp:

(WebFrame::layout):

7:51 AM Changeset in webkit [224149] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Make postprocess-framework-headers.sh a little easier to read
​https://bugs.webkit.org/show_bug.cgi?id=178971

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-28
Reviewed by Sam Weinig.

  • mac/postprocess-framework-headers.sh:
7:36 AM Changeset in webkit [224148] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Cleanup PageDebuggable
​https://bugs.webkit.org/show_bug.cgi?id=178972

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-28
Reviewed by Sam Weinig.

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::PageDebuggable):

  • page/PageDebuggable.h:
7:35 AM Changeset in webkit [224147] by commit-queue@webkit.org
  • 13 edits
    1 copy in trunk/Source/WebCore

Extract a WorkerDebuggerProxy interface out of WorkerReportingProxy
​https://bugs.webkit.org/show_bug.cgi?id=178975

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-28
Reviewed by Sam Weinig.

No new tests, just refactoring.

  • workers/WorkerDebuggerProxy.h:
  • workers/WorkerReportingProxy.h:
  • WebCore.xcodeproj/project.pbxproj:

Extract a method from WorkerReportingProxy to WorkerDebuggerProxy and
rename it to be more general.

  • inspector/WorkerToPageFrontendChannel.h:

(WebCore::WorkerToPageFrontendChannel::sendMessageToFrontend):

  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):

  • workers/DedicatedWorkerThread.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postMessageToDebugger):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector): Deleted.

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WebCore::WorkerThread::workerDebuggerProxy const):

  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):

  • workers/service/context/ServiceWorkerThread.h:
  • workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::create):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
Include a WorkerDebuggerProxy alongside the other proxies.
Use the renamed debugger proxy method.

2:17 AM Changeset in webkit [224146] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource
​https://bugs.webkit.org/show_bug.cgi?id=178715
<rdar://problem/35144665>

Reviewed by Brent Fulgham.

Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first
instead of in the middle of collecting a list of stylesheets.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize the newly added timer.
(WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event
handlers may be expecting to see the document after XSLT had been applied.
(WebCore::Document::scheduleToApplyXSLTransforms): Added.
(WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added.
(WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from
Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function.
(WebCore::Document::applyXSLTransform): Deleted.
(WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply
inline XSLT and it happens much earlier than implicitClose.
(WebCore::Document::suspendScheduledTasks): Suspend the XSLT timer.
(WebCore::Document::resumeScheduledTasks): Reschedule the XSLT timer if m_hasPendingXSLTransforms is set.

  • dom/Document.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending
stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this
function can be called from a non-script-resilient call stack.
(WebCore::ProcessingInstruction::sheetLoaded): Ditto.

  • style/StyleScope.cpp:

(WebCore::Style::Scope::collectXSLTransforms): Added.
(WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions
that applies XSLT. Also use RefPtr<StyleSheet> instead of a raw pointer to store StyleSheet.

  • style/StyleScope.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests.

Oct 27, 2017:

9:17 PM Changeset in webkit [224145] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r222004. rdar://problem/35225406

9:17 PM Changeset in webkit [224144] by jmarcell@apple.com
  • 12 edits
    1 add in branches/safari-604-branch

Cherry-pick r221233. rdar://problem/35228663

8:49 PM Changeset in webkit [224143] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Tools

[Win] Detect Visual Studio 2017 location
​https://bugs.webkit.org/show_bug.cgi?id=175275

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-10-27
Reviewed by Per Arne Vollan.

  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/update-vswhere.py: Added.
  • Scripts/webkitdirs.pm:

(pickCurrentVisualStudioInstallation):
(pickLegacyVisualStudioInstallation):
(visualStudioInstallDir):
(visualStudioInstallDirVSWhere):
(visualStudioInstallDirLegacy):
(visualStudioInstallDirFallback):
(msBuildInstallDir):
(visualStudioVersion):
(visualStudioVersionFromInstallDir):
(generateBuildSystemFromCMakeProject):

6:58 PM Changeset in webkit [224142] by webkit@devinrousso.com
  • 18 edits in trunk

Web Inspector: Canvas Tab: no way to see backtrace of where a canvas context was created
​https://bugs.webkit.org/show_bug.cgi?id=178799
<rdar://problem/35175805>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add optional backtrace to Canvas type that is an array of Console.CallFrame.

Source/WebCore:

No new tests, updated existing tests.

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(iterateCallFrames):
(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::buildAction):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
If the Canvas agent is enabled, generate a backtrace and send it to the frontend with the canvas.
We do not do this for canvases created before the agent is enabled for performance reasons.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/Canvas.js:

(WI.Canvas.fromPayload):
(WI.Canvas.prototype.get backtrace):

  • UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas .details-section.canvas-backtrace .call-frame):

  • UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):
(WI.CanvasDetailsSidebarPanel.prototype._refreshBacktraceSection):

  • UserInterface/Views/ResourceIcons.css:

(.canvas > .icon):
(.canvas .icon): Deleted.

LayoutTests:

  • inspector/canvas/create-context-2d-expected.txt:
  • inspector/canvas/create-context-webgl-expected.txt:
  • inspector/canvas/create-context-webgl2-expected.txt:
  • inspector/canvas/create-context-webgpu-expected.txt:
  • inspector/canvas/resources/create-context-utilities.js:

(TestPage.registerInitializer.sanitizeURL):
(TestPage.registerInitializer.awaitCanvasAdded):
Pretty-print backtrace when canvases are added to the page.

6:48 PM Changeset in webkit [224141] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Tweak ES6 generator function to allow inlining
​https://bugs.webkit.org/show_bug.cgi?id=178935

Reviewed by Saam Barati.

We optimize builtins' generator helper functions to allow them inlined in the caller side.
This patch adjust the layer between @generatorResume, next(), throw(), and return() to allow
them inlined in DFG.

baseline patched

spread-generator.es6 301.2637+-11.1011 260.5905+-14.2258 definitely 1.1561x faster
generator.es6 269.6030+-13.2435 148.8840+-6.7614 definitely 1.8108x faster

  • builtins/GeneratorPrototype.js:

(globalPrivate.generatorResume):
(next):
(return):
(throw):

6:39 PM Changeset in webkit [224140] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Create watchlist for files related WebInspector Recording
​https://bugs.webkit.org/show_bug.cgi?id=178965

Reviewed by Joseph Pecoraro.

  • Scripts/webkitpy/common/config/watchlist:
6:05 PM Changeset in webkit [224139] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test http/tests/security/mixedContent/insecure-download-redirects-to-basic-auth-secure-download.https.html on OS X El Capitan

For now skip this test that was added in r224134 on OS X El Capitan. OS X El Capitan uses the
legacy NSURLDownload code path for downloads. This code path is not happy with the self-signed
certificate we use when running HTTPS tests. See <​https://bugs.webkit.org/show_bug.cgi?id=155132>
for more details.

  • platform/mac-elcapitan/TestExpectations:
6:03 PM Changeset in webkit [224138] by sbarati@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Bytecode liveness should live on UnlinkedCodeBlock so it can be shared amongst CodeBlocks
​https://bugs.webkit.org/show_bug.cgi?id=178949

Reviewed by Keith Miller.

This patch stores BytecodeLiveness on UnlinkedCodeBlock instead of CodeBlock
so that we don't need to recompute liveness for the same UnlinkedCodeBlock
more than once. To do this, this patch solidifies the invariant that CodeBlock
linking can't do anything that would change the result of liveness. For example,
it can't introduce new locals. This invariant was met my JSC before, because we
didn't do anything in bytecode linking that would change liveness. However, it is
now a correctness requirement that we don't do anything that would change the
result of running liveness. To support this change, I've refactored BytecodeGraph
to not be tied to a CodeBlockType*. Things that perform liveness will pass in
CodeBlockType* and the instruction stream as needed. This means that we may
compute liveness with one CodeBlock*'s instruction stream, and then perform
queries on that analysis with a different CodeBlock*'s instruction stream.

This seems to be a 2% JSBench progression.

  • bytecode/BytecodeGeneratorification.cpp:

(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::BytecodeGeneratorification::graph):
(JSC::BytecodeGeneratorification::storageForGeneratorLocal):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):

  • bytecode/BytecodeGraph.h:

(JSC::BytecodeGraph::BytecodeGraph):
(JSC::BytecodeGraph::codeBlock const): Deleted.
(JSC::BytecodeGraph::instructions): Deleted.
(JSC::BytecodeGraph<Block>::BytecodeGraph): Deleted.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset): Deleted.
(JSC::BytecodeLivenessAnalysis::compute): Deleted.

  • bytecode/BytecodeLivenessAnalysis.h:
  • bytecode/BytecodeLivenessAnalysisInlines.h:

(JSC::BytecodeLivenessPropagation::stepOverInstruction):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation::runLivenessFixpoint):

  • bytecode/BytecodeRewriter.cpp:

(JSC::BytecodeRewriter::applyModification):
(JSC::BytecodeRewriter::execute):
(JSC::BytecodeRewriter::adjustJumpTargetsInFragment):

  • bytecode/BytecodeRewriter.h:

(JSC::BytecodeRewriter::BytecodeRewriter):
(JSC::BytecodeRewriter::removeBytecode):
(JSC::BytecodeRewriter::graph):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeOffsetSlow):
(JSC::CodeBlock::validate):
(JSC::CodeBlock::livenessAnalysisSlow): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::livenessAnalysis):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::applyModification):
(JSC::UnlinkedCodeBlock::livenessAnalysisSlow):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::livenessAnalysis):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::killsFor):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::cleanMustHandleValuesIfNecessary):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

5:09 PM Changeset in webkit [224137] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WTF

[WinCairo] Add WTF files for wincairo webkit
​https://bugs.webkit.org/show_bug.cgi?id=176894

Patch by Yousuke Kimoto <​yousuke.kimoto@sony.com> on 2017-10-27
Reviewed by Alex Christensen.

  • wtf/PlatformWin.cmake:
  • wtf/WorkQueue.cpp:
  • wtf/WorkQueue.h:
  • wtf/win/Win32Handle.h:
  • wtf/win/WorkItemContext.cpp: Added.

(WTF::WorkItemContext::WorkItemContext):
(WTF::WorkItemContext::create):
(WTF::WorkItemContext::~WorkItemContext):

  • wtf/win/WorkItemContext.h: Added.

(WTF::WorkItemContext::handle):
(WTF::WorkItemContext::waitHandle):
(WTF::WorkItemContext::Function<void):
(WTF::WorkItemContext::queue const):

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::handleCallback):
(WTF::WorkQueue::registerHandle):
(WTF::WorkQueue::unregisterAndCloseHandle):
(WTF::WorkQueue::unregisterWaitAndDestroyItemSoon):
(WTF::WorkQueue::unregisterWaitAndDestroyItemCallback):

4:45 PM Changeset in webkit [224136] by keith_miller@apple.com
  • 7 edits
    1 move in trunk/Source

Add unified source list files and build scripts to Xcode project navigator
​https://bugs.webkit.org/show_bug.cgi?id=178959

Reviewed by Andy Estes.

Source/JavaScriptCore:

Also, Add some extra source files for so new .cpp/.mm files don't cause the build
to fail right away. We already do this in WebCore.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • PlatformMac.cmake:
  • SourcesCocoa.txt: Renamed from Source/JavaScriptCore/SourcesMac.txt.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
4:40 PM Changeset in webkit [224135] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

Attempt to fix the Apple El Capitan build following <​https://trac.webkit.org/changeset/224134>
(​https://bugs.webkit.org/show_bug.cgi?id=178919)

Move definition of NetworkLoad::isAllowedToAskUserForCredentials() outside of USE(NETWORK_SESSION)-guarded section.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::isAllowedToAskUserForCredentials const):

3:31 PM Changeset in webkit [224134] by dbates@webkit.org
  • 16 edits
    29 adds in trunk

Only allow non-mixed content protected subresources to ask for credentials
​https://bugs.webkit.org/show_bug.cgi?id=178919
<rdar://problem/35015245>

Reviewed by Alex Christensen.

Source/WebCore:

Only allow non-mixed content protected subresources to ask for credentials. It is not meaningful
to allow protected mixed-content subresources to ask for credentials.

Tests: http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image.html

http/tests/security/mixedContent/insecure-script-redirects-to-basic-auth-secure-script.html
http/tests/security/mixedContent/insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet.html
http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https.html
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https.html
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::ResourceLoader): Initialize m_canAskClientForCredentials based on the
specified resource loader options.
(WebCore::ResourceLoader::init): Update m_canAskClientForCredentials based on the URL of the initial
request.
(WebCore::ResourceLoader::isMixedContent const): Helper function to check if the specified URL
represents a mixed content resource.
(WebCore::ResourceLoader::willSendRequestInternal): If the original request or the redirect request
is mixed content then update state such that we will disallow asking for credentials.
(WebCore::ResourceLoader::isAllowedToAskUserForCredentials const): Modified to use m_canAskClientForCredentials
when determining whether the request is allowed to ask for credentials.

  • loader/ResourceLoader.h:

Source/WebKit:

Only allow non-mixed content protected subresources to ask for credentials. It is not meaningful
to allow protected mixed-content subresources to ask for credentials.

  • NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::PendingDownload): Initialize m_isAllowedToAskUserForCredentials based on
the specified resource load parameters or NetworkLoad object.

  • NetworkProcess/Downloads/PendingDownload.h: Add override for NetworkLoadClient::isAllowedToAskUserForCredentials().
  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::isAllowedToAskUserForCredentials const): Added.
(WebKit::NetworkLoad::completeAuthenticationChallenge): Ask NetworkLoadClient whether the load is
allowed to prompt for credentials.
(WebKit::NetworkLoad::didReceiveAuthenticationChallenge): Ditto.

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkLoadClient.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader): Initialize m_isAllowedToAskUserForCredentials
based on the specified resource load parameters.
(WebKit::NetworkResourceLoader::willSendRedirectedRequest): We do not support prompting for credentials
for synchronous loads.
(WebKit::NetworkResourceLoader::continueWillSendRequest): Modified to take an argument as to whether the
load is allowed to ask the user for credentials and updates state.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.messages.in: Modified message ContinueWillSendRequest to take a

boolean as to whether the load is allowed to ask the user for credentials.

  • NetworkProcess/PreconnectTask.h: Override NetworkLoadClient::isAllowedToAskUserForCredentials()

such that we never ask for credentials. This matches our current behavior.

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.h: Ditto.
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest): Query ResourceLoader as to whether the load is allowed to
ask the user for credentials and pass this state to NetworkResourceLoader.

LayoutTests:

  • http/tests/security/mixedContent/insecure-download-redirects-to-basic-auth-secure-download.https-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-download-redirects-to-basic-auth-secure-download.https.html: Added.
  • http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image.html: Added.
  • http/tests/security/mixedContent/insecure-script-redirects-to-basic-auth-secure-script-expected.https.txt: Added.
  • http/tests/security/mixedContent/insecure-script-redirects-to-basic-auth-secure-script-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-script-redirects-to-basic-auth-secure-script.html: Added.
  • http/tests/security/mixedContent/insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image-redirects-to-basic-auth-secure-image.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-script-redirects-to-basic-auth-secure-script.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-programmatically-added-insecure-image-redirects-to-basic-auth-secure-image.html: Added.
  • http/tests/security/mixedContent/resources/subresource/protected-image.php: Added.
  • http/tests/security/mixedContent/resources/subresource/protected-pdf.php: Added.
  • http/tests/security/mixedContent/resources/subresource/protected-script.php: Added.
  • http/tests/security/mixedContent/resources/subresource/protected-stylesheet.php: Added.
  • http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https-expected.txt: Added.
  • http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https.html: Added.
  • http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https-expected.txt: Added.
  • http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https.html: Added.
  • http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt: Added.
  • http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https.html: Added.
  • platform/ios-wk1/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt: Added.
  • platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt: Added.
  • platform/win/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt: Added.
3:28 PM Changeset in webkit [224133] by dbates@webkit.org
  • 5 edits
    13 adds in trunk/LayoutTests

Add tests for automatic decompression of gzip-compressed subresources
​https://bugs.webkit.org/show_bug.cgi?id=178941
<rdar://problem/35230090>

Reviewed by Alex Christensen.

Although automatic decompression of gzip-compressed subresources is handled by CFNetwork
(<rdar://problem/5418646>) we should add tests to ensure that WebKit does not inadvertently
opt out of such functionality and to catch a regression in CFNetwork.

  • TestExpectations: Skip the tests on all platforms. We will unskip on Cocoa platforms and Apple Windows.
  • http/tests/gzip-content-encoding/gzip-encoded-script-expected.txt: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-script.html: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-script2-expected.txt: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-script2.html: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-stylesheet-expected.html: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-stylesheet.html: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-stylesheet2-expected.html: Added.
  • http/tests/gzip-content-encoding/gzip-encoded-stylesheet2.html: Added.
  • http/tests/gzip-content-encoding/resources/echo-data-encoding-with-gzip.php: Added.
  • http/tests/gzip-content-encoding/resources/script.js.gz: Added.
  • http/tests/gzip-content-encoding/resources/stylesheet.css.gz: Added.
  • platform/ios/TestExpectations: Unskip tests.
  • platform/mac/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
2:43 PM Changeset in webkit [224132] by Chris Dumez
  • 12 edits
    189 adds in trunk

Unskip more Service Workers tests
​https://bugs.webkit.org/show_bug.cgi?id=178944

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Land expected results for tests that have been unskipped.

  • web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/activate-event-after-install-state-change.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/activation-after-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/activation.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/active.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/appcache-ordering-main.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-fetch.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-not-using-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-using-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/claim-worker-fetch.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/client-id.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-order.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/controller-on-disconnect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/controller-on-load.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/controller-on-reload.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/extendable-event-async-waituntil.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-csp.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-after-navigation-within-page.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-throws-after-respond-with.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-within-sw-manual.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-header-visibility.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-css-cross-origin-mime-check.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-css-images.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-fallback.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-html-imports.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-resources.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-xhr-sync.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-response-xhr.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/getregistration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/immutable-prototype-serviceworker.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/import-scripts-resource-map.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/indexeddb.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/install-event-type.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/installing.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/interfaces-window.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/invalid-blobtype.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/invalid-header.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/iso-latin1-header.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/multi-globals/url-parsing.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/multiple-register.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/multiple-update.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigate-window.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/get-state.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-preload/resource-timing.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-redirect-body.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/onactivate-script-error.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/oninstall-script-error.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-blob-url.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-from-waiting-serviceworker.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-msgport-to-client.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-to-client.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/ready.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/referer.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/referrer-policy-header.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/register-default-scope.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/register-link-header.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-basic.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-end-to-end.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-events.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-iframe.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-mime-types.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-scope.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-script-url.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-script.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-security-error.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/rejections.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/request-body-blob.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/shared-worker-controlled.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/state.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/synced-state.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/uncontrolled-page.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/unregister.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/update-after-oneday.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/update-recovery.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/update.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/websocket.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/windowclient-navigate.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/xhr.https-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.1-service-worker-obj-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.1.1-service-worker-scope-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.1.2-service-worker-url-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.1.3-service-worker-state-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.1.4-service-worker-on-state-change-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2-navigator-service-worker-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.1-navigator-service-worker-installing-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.10-navigator-service-worker-oncontrollerchange-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.11-navigator-service-worker-onreloadpage-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.12-navigator-service-worker-onerror-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.2-navigator-service-worker-waiting-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.3-navigator-service-worker-active-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.4-navigator-service-worker-controller-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.5-navigator-service-worker-ready-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.6-navigator-service-worker-getAll-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.7-navigator-service-worker-register-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.8-navigator-service-worker-unregister-expected.txt: Added.
  • web-platform-tests/service-workers/stub-3.2.9-navigator-service-worker-onupdatefound-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1-service-worker-global-scope-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.1-service-worker-global-scope-caches-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.2-service-worker-global-scope-clients-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.3-service-worker-global-scope-scope-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.4-service-worker-global-scope-fetch-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.5-service-worker-global-scope-update-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.6-service-worker-global-scope-unregister-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.1.7-service-worker-global-scope-onmessage-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.2-client-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.3-service-worker-clients-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.3.1-get-serviced-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.3.2-reloadall-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.4-request-objects-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.5-response-objects-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.5.2-response-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.5.4-opaque-response-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.6-cache-objects-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.6.1-cache-lifetimes-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.1-install-phase-event-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.1.1-wait-until-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.2-install-event-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.2.1-install-event-section-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.2.2-replace-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.3-activate-event-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.4.1-fetch-event-section-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.4.2-respond-with-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.4.3-default-method-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.7.4.4-is-reload-attribute-expected.txt: Added.
  • web-platform-tests/service-workers/stub-5.1-origin-relativity-expected.txt: Added.
  • web-platform-tests/service-workers/stub-5.2-cross-origin-resources-expected.txt: Added.

Source/WebCore:

Drop bad assertion that was causing the Service Worker WebProcess to crash and causing
tests to fail as a result.

  • workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::registration):

  • workers/service/ServiceWorkerGlobalScope.h:

LayoutTests:

Unskip all Service Workers tests except for the 39 that are timing out.

2:35 PM Changeset in webkit [224131] by Ryan Haddad
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r224011.

xsl LayoutTests hit an assertion added with this change since
r223999 was rolled out.

Reverted changeset:

"Assert that no script is executed during style recalc"
​https://bugs.webkit.org/show_bug.cgi?id=178845
​https://trac.webkit.org/changeset/224011

2:30 PM Changeset in webkit [224130] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Adjusted expectations for fast/scrolling/arrow-key-scroll-in-rtl-document.html.
​https://bugs.webkit.org/show_bug.cgi?id=173779

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:48 PM Changeset in webkit [224129] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Adjusted expectations for multiple media/ Layout Tests.
​https://bugs.webkit.org/show_bug.cgi?id=176054

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:29 PM Changeset in webkit [224128] by graouts@webkit.org
  • 8 edits
    2 adds in trunk

[Web Animations] Expose the currentTime property on AnimationTimeline
​https://bugs.webkit.org/show_bug.cgi?id=178928

Reviewed by Dean Jackson.

Source/WebCore:

We add the currentTime property on AnimationTimeline and add an internals method
to set it in a test which will allow us to validate the timing model state for
a given time.

Test: webanimations/timeline-current-time.html

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::bindingsCurrentTime const):
(WebCore::AnimationTimeline::setCurrentTime):

  • animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::currentTime const):

  • animation/AnimationTimeline.idl:
  • testing/Internals.cpp:

(WebCore::Internals::setTimelineCurrentTime):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add a new test that checks we can read the document's timeline currentTime
property and set it via the internals method.

  • webanimations/timeline-current-time-expected.txt: Added.
  • webanimations/timeline-current-time.html: Added.
1:17 PM Changeset in webkit [224127] by graouts@webkit.org
  • 3 edits in trunk/Source/WebCore

[Web Animations] Use Seconds vs. MonotonicTime to represent times
​https://bugs.webkit.org/show_bug.cgi?id=178950

Reviewed by Dean Jackson.

Animation start times, all expressed in seconds, in the Web Animations API are relative to the timeline
originTime, itself relative to the page's nagigation time (Performance.navigationTime), so it makes more
sense to use Seconds to represent them as opposed to a MonotonicTime.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::setBindingsStartTime):

  • animation/WebAnimation.h:
1:09 PM Changeset in webkit [224126] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip two tests that are flaky crashes.
​https://bugs.webkit.org/show_bug.cgi?id=177828

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:56 PM Changeset in webkit [224125] by Chris Dumez
  • 4 edits
    2 adds in trunk

DOMWindow::dispatchEvent() does not reset the event's dispatch flag
​https://bugs.webkit.org/show_bug.cgi?id=178897

Reviewed by Darin Adler.

Source/WebCore:

Make sure we reset the currentTarget, dispatch flag, phase and propagation flags
after dispatching an event on a Window, as per:

This behavior is consistent with Firefox.

Test: fast/events/window-load-initEvent.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

LayoutTests:

Add layout test coverage. I have verified that this test is passing in Firefox.

  • fast/events/window-load-initEvent-expected.txt: Added.
  • fast/events/window-load-initEvent.html: Added.
12:10 PM Changeset in webkit [224124] by Jonathan Bedard
  • 2 edits in trunk/Tools

Windows and WebViews are retained after re-configure
​https://bugs.webkit.org/show_bug.cgi?id=178902
<rdar://problem/35211518>

Reviewed by Alexey Proskuryakov.

The test runner effectively leaks windows every time a test changes configuration.
We give each test it's own AutoreleasePool to fix this problem.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
so that when a configuration changes, the old window and WebView are released.

11:56 AM Changeset in webkit [224123] by keith_miller@apple.com
  • 7 edits in trunk/Source/WebCore

Move iOS specific sources to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178915

Rubber-stamped by Tim Horton.

Source/WebCore:

  • SourcesCocoa.txt:
  • SourcesIOS.txt:
  • SourcesMac.txt:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

  • pal/spi/cocoa/QuartzCoreSPI.h: Add missing pragma once.
11:42 AM Changeset in webkit [224122] by jfbastien@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

WebAssembly: update arbitrary limits to what browsers use
​https://bugs.webkit.org/show_bug.cgi?id=178946
<rdar://problem/34257412>
<rdar://problem/34501154>

Reviewed by Saam Barati.

​https://github.com/WebAssembly/design/issues/1138 discusses the
arbitrary function size limit, which it turns out Chrome and
Firefox didn't enforce. We didn't use it because it was
ridiculously low and actual programs ran into that limit (bummer
for Edge which just shipped it...). Now that we agree on a high
arbitrary program limit, let's update it! While I'm doing this
there are a few other spots that I polished to use Checked or
better check limits overall.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addLocal):

  • wasm/WasmFormat.cpp:

(JSC::Wasm::Segment::create):

  • wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parse):

  • wasm/WasmInstance.cpp:
  • wasm/WasmLimits.h:
  • wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseGlobal):
(JSC::Wasm::ModuleParser::parseCode):
(JSC::Wasm::ModuleParser::parseData):

  • wasm/WasmSignature.h:

(JSC::Wasm::Signature::allocatedSize):

  • wasm/WasmTable.cpp:

(JSC::Wasm::Table::Table):

  • wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::JSWebAssemblyTable):
(JSC::JSWebAssemblyTable::grow):

11:38 AM Changeset in webkit [224121] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

NowPlayingInfo should contain a unique identifier
​https://bugs.webkit.org/show_bug.cgi?id=178872
<rdar://problem/34924012>

Unreviewed, build fix.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::updateNowPlayingInfo): Call string.impl().hash() instead of
string.existingHash() because the later will assert in a debug build if the hash hasn't
been calculated yet.

  • platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::updateNowPlayingInfo): Ditto.

10:48 AM Changeset in webkit [224120] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Move TestExpectation for imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm.
​https://bugs.webkit.org/show_bug.cgi?id=178190

Unreviewed test gardening.

10:39 AM Changeset in webkit [224119] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix accessibility/mac/aria-label-on-label-element.html after r224074
​https://bugs.webkit.org/show_bug.cgi?id=178892

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText const):
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityText::AccessibilityText):
Turns out my null checks changed behavior. This undoes them.

10:33 AM Changeset in webkit [224118] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime library path
​https://bugs.webkit.org/show_bug.cgi?id=178936

Reviewed by Michael Catanzaro.

  • PlatformGTK.cmake: Fix spelling of variable used in conditional.
10:16 AM Changeset in webkit [224117] by eric.carlson@apple.com
  • 2 edits in trunk/Tools

NowPlayingInfo should contain a unique identifier
​https://bugs.webkit.org/show_bug.cgi?id=178872
<rdar://problem/34924012>

Unreviewed, fix a flakey test.

  • TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:

(-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
(-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.

10:06 AM Changeset in webkit [224116] by Ryan Haddad
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r223999.

Caused xsl LayoutTest flakiness.

Reverted changeset:

"Style::Scope::flushPendingUpdate() can replace the entire
document in XSLTProcessor::createDocumentFromSource"
​https://bugs.webkit.org/show_bug.cgi?id=178715
​https://trac.webkit.org/changeset/223999

9:49 AM Changeset in webkit [224115] by Chris Dumez
  • 8 edits in trunk/Source/WebCore

Audit init*Event() method to make sure they reset internal data members
​https://bugs.webkit.org/show_bug.cgi?id=178886

Reviewed by Ryosuke Niwa.

Audit init*Event() method to make sure they reset internal data members.

  • dom/Event.cpp:

(WebCore::Event::initEvent):

  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::initKeyboardEvent):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::initMessageEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::setIsSimulated):

  • dom/TextEvent.cpp:

(WebCore::TextEvent::initTextEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::initWheelEvent):

9:38 AM Changeset in webkit [224114] by Ryan Haddad
  • 2 edits in trunk/Tools

autoinstall can't download from ​http://pypi.python.org
​https://bugs.webkit.org/show_bug.cgi?id=178925

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-27
Reviewed by Ryosuke Niwa.

The web server pypi.python.org rejects non secure http.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize): Use https instead of http.
(AutoinstallImportHook._install_pep8): Ditto.
(AutoinstallImportHook._install_pylint): Ditto.
(AutoinstallImportHook._install_buildbot): Ditto.
(AutoinstallImportHook._install_coverage): Ditto.

9:35 AM Changeset in webkit [224113] by Chris Dumez
  • 38 edits
    1 copy in trunk

Add initial support for serviceWorkerClient.postMessage()
​https://bugs.webkit.org/show_bug.cgi?id=178794

Reviewed by Youenn Fablet.

Source/WebCore:

Add initial support for serviceWorkerClient.postMessage():

It is now possible to do bi-directional communication with a service worker
via postMessage().

No new tests, updated existing test.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::generateDocumentIdentifier):
(WebCore::Document::allDocumentsMap):
(WebCore::Document::allDocuments):
(WebCore::m_identifier):
(WebCore::Document::~Document):

  • dom/Document.h:

(WebCore::Document::identifier const):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::serviceWorkerContainer):

  • dom/ScriptExecutionContext.h:
  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

  • workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::~ServiceWorkerClient):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):

  • workers/service/ServiceWorkerClient.h:

(WebCore::ServiceWorkerClient::create):

  • workers/service/ServiceWorkerClient.idl:
  • workers/service/ServiceWorkerClientIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.

(WebCore::ServiceWorkerClientIdentifier::toString const):

  • workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::unregister):

  • workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):

  • workers/service/ServiceWorkerWindowClient.h:
  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):

  • workers/service/context/SWContextManager.h:
  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):

  • workers/service/context/ServiceWorkerThread.h:
  • workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::postMessageToServiceWorkerClient):

  • workers/service/server/SWClientConnection.h:

Source/WebKit:

Add initial support for serviceWorkerClient.postMessage():

It is now possible to do bi-directional communication with a service worker
via postMessage().

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ServiceWorkerClientIdentifier>::encode):
(IPC::ArgumentCoder<ServiceWorkerClientIdentifier>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::postMessageToServiceWorkerClient):

  • StorageProcess/StorageProcess.h:
  • StorageProcess/StorageProcess.messages.in:
  • WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):

  • WebProcess/Storage/WebSWClientConnection.h:
  • WebProcess/Storage/WebSWClientConnection.messages.in:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerClient):

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/basic-ServiceWorker-postMessage.https-expected.txt:
  • http/tests/workers/service/resources/basic-ServiceWorker-postMessage-worker.js:
  • http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js:

(then):

9:09 AM Changeset in webkit [224112] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip failing service worker tests that were missed in r224066.
​https://trac.webkit.org/changeset/224066/webkit

Unreviewed test gardening.

8:35 AM Changeset in webkit [224111] by jmarcell@apple.com
  • 4 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r223993. rdar://problem/34771415

7:38 AM Changeset in webkit [224110] by fred.wang@free.fr
  • 3 edits in trunk/Source/WebCore

Use auto for some variables in RenderLayerCompositor/Backing
​https://bugs.webkit.org/show_bug.cgi?id=178570

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-27
Reviewed by Darin Adler.

No new tests, behavior unchanged.

  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computePageTiledBackingCoverage):
(WebCore::RenderLayerBacking::layerWillBeDestroyed):
(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::ComputedOffsets::fromAncestorGraphicsLayer):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::hasUnpositionedOverflowControlsLayers const):
(WebCore::RenderLayerBacking::compositingOpacity const):
(WebCore::isRestartedPlugin):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage const):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::getCurrentTransform const):
(WebCore::RenderLayerBacking::logFilledVisibleFreshTile):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin const):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlushIncludingSubframes):
(WebCore::updateScrollingLayerWithClient):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::didPaintBacking):
(WebCore::RenderLayerCompositor::didChangeVisibleRect):
(WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers const):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::checkIfDescendantClippingContextNeedsUpdate):
(WebCore::styleChangeRequiresLayerRebuild):
(WebCore::RenderLayerCompositor::canCompositeClipPath):
(WebCore::rendererForCompositingTests):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer const):
(WebCore::RenderLayerCompositor::setCompositingParent):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::hasCoordinatedScrolling const):
(WebCore::RenderLayerCompositor::updateScrollLayerPosition):
(WebCore::RenderLayerCompositor::positionForClipLayer const):
(WebCore::RenderLayerCompositor::frameViewDidLayout):
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::RenderLayerCompositor::clippedByAncestor const):
(WebCore::RenderLayerCompositor::requiresCompositingForBackfaceVisibility const):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas const):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin const):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason const):
(WebCore::RenderLayerCompositor::isAsyncScrollableStickyLayer const):
(WebCore::RenderLayerCompositor::isViewportConstrainedFixedOrStickyLayer const):
(WebCore::RenderLayerCompositor::requiresScrollLayer const):
(WebCore::RenderLayerCompositor::supportsFixedRootBackgroundCompositing const):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayer const):
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles const):
(WebCore::RenderLayerCompositor::documentUsesTiledBacking const):
(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls const):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore::RenderLayerCompositor::destroyRootLayer):
(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints const):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints const):
(WebCore::enclosingScrollingNodeID):
(WebCore::scrollCoordinatedAncestorInParentOfFrame):
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::unregisterAllScrollingLayers):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):
(WebCore::RenderLayerCompositor::updateScrollSnapPropertiesWithFrameView):

3:27 AM Changeset in webkit [224109] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.18.2

WebKitGTK+ 2.18.2

3:25 AM Changeset in webkit [224108] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.18.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.18.2.
2:35 AM Changeset in webkit [224107] by commit-queue@webkit.org
  • 6 edits in trunk

[GStreamer][MSE] Trim space between codecs
​https://bugs.webkit.org/show_bug.cgi?id=178160

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-10-27
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Modify supportsCodecs() to accept a Vector<String> instead of
receiving a string and parsing itself.

This improves passrate for mediasource-is-type-supported as it
ensures that whitespace between codecs is now trimmed and codec
strings such as video/webm;codecs="opus, vp9" are matched as a valid
type, as required by the spec.

This patch also renames supportCodecs() to supportAllCodecs() and adds
a new variant, supportCodec(), that checks for support of an
individual codec.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::supportsCodec):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsAllCodecs):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

LayoutTests:

Update expected test output.

  • platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported-expected.txt:
2:34 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
2:31 AM Changeset in webkit [224106] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224090 - WebDriver: unknown capabilities should produce an InvalidArgument error when validating capabilities
​https://bugs.webkit.org/show_bug.cgi?id=178868

Reviewed by Brian Burg.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_extensions

  • WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):

2:31 AM Changeset in webkit [224105] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224089 - WebDriver: deserializeTimeouts should fail if the value is not integer
​https://bugs.webkit.org/show_bug.cgi?id=178866

Reviewed by Brian Burg.

If value is not an integer, or it is less than 0 or greater than 264 – 1, return error with error code invalid
argument.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-deserialize-as-a-timeout

Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_values[timeouts-value59-body0]

imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_values[timeouts-value59-body1]

  • WebDriverService.cpp:

(WebDriver::deserializeTimeouts):

2:31 AM Changeset in webkit [224104] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224088 - WebDriver: failing to process capabilities should produce InvalidArgument error not SessionNotCreated
​https://bugs.webkit.org/show_bug.cgi?id=178864

Reviewed by Brian Burg.

Fixes most of the tests in imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities

  • WebDriverService.cpp:

(WebDriver::WebDriverService::processCapabilities const):

2:27 AM Changeset in webkit [224103] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.18

Merge r224047 - [WPE] Use proper shared object versioning for libWPEWebKit.so
​https://bugs.webkit.org/show_bug.cgi?id=178878

Reviewed by Michael Catanzaro.

Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
unify setting the PROJECT_VERSION* family of variables.

  • Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
  • Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,

using the common macros from VersioningUtils.cmake.

  • Source/cmake/VersioningUtils.cmake: Added.
2:20 AM Changeset in webkit [224102] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223999 - Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource
​https://bugs.webkit.org/show_bug.cgi?id=178715
<rdar://problem/35144665>

Reviewed by Brent Fulgham.

Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first
instead of in the middle of collecting a list of stylesheets.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize the newly added timer.
(WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event
handlers may be expecting to see the document after XSLT had been applied.
(WebCore::Document::scheduleToApplyXSLTransforms): Added.
(WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added.
(WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from
Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function.
(WebCore::Document::applyXSLTransform): Deleted.
(WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply
inline XSLT and it happens much earlier than implicitClose.

  • dom/Document.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending
stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this
function can be called from a non-script-resilient call stack.
(WebCore::ProcessingInstruction::sheetLoaded): Ditto.

  • style/StyleScope.cpp:

(WebCore::Style::Scope::collectXSLTransforms): Added.
(WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions
that applies XSLT. Also use RefPtr<StyleSheet> instead of a raw pointer to store StyleSheet.

  • style/StyleScope.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests.

2:02 AM Changeset in webkit [224101] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r223965 - Unreviewed, rolling out r222945.
​https://bugs.webkit.org/show_bug.cgi?id=178818

"It made WasmBench crash" (Requested by saamyjoon on #webkit).

Reverted changeset:

"bmalloc mutex should be adaptive"
​https://bugs.webkit.org/show_bug.cgi?id=177839
​https://trac.webkit.org/changeset/222945

2:00 AM Changeset in webkit [224100] by Carlos Garcia Campos
  • 15 edits in releases/WebKitGTK/webkit-2.18

Merge r223953 - [WPE] Remove GLib API functions which use Cairo
​https://bugs.webkit.org/show_bug.cgi?id=178205

Reviewed by Michael Catanzaro.

Source/WebKit:

Add PLATFORM(GTK) guards for the parts of of the GLib API which use cairo_surface_t (web
page snapshots and favicons), and remove the affected function prototypes from public API
headers. This way, the WPE version of the API is not tied to Cairo.

  • PlatformWPE.cmake:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:
  • UIProcess/API/glib/WebKitFaviconDatabasePrivate.h:
  • UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkitWebViewDispose):
(webkit_web_view_class_init):
(webkitWebViewLoadChanged):

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/API/wpe/WebKitFaviconDatabase.h:
  • UIProcess/API/wpe/WebKitWebView.h:
  • WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(webkitWebPageDidReceiveMessage):

Tools:

Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
page snapshots and favicons) which are not available in the WPE version of the GLib API.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:

(testNotInitialized):
(testPrivateBrowsing):
(testFaviconDatabase):

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:

(testFindControllerHide):
(beforeAll):

  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1:57 AM Changeset in webkit [224099] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r223916 - [mips] fix offsets of branches that have to go over a jump
​https://bugs.webkit.org/show_bug.cgi?id=153464

The jump() function creates 8 instructions, but the offsets of branches
meant to go over them only account for 6. In most cases, this is not an
issue as the last two instructions of jump() would be nops, but in the
rarer case where the jump destination is in a different 256 MB segment,
MIPSAssembler::linkWithOffset() will rewrite the code in a way in which
the last 4 instructions would be a 2 instruction load (lui/ori) into
$t9, a "j $t9" and then a nop. The wrong offset will mean that the
previous branches meant to go over the whole jump will branch to the
"j $t9" instruction, which would jump to whatever is currently in $t9
(since lui/ori would not be executed).

Reviewed by Michael Catanzaro.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
Fix the offsets of branches meant to go over code generated by jump().

1:55 AM Changeset in webkit [224098] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223887 - [GTK][X11] Windy.com shows always straight wind lines
​https://bugs.webkit.org/show_bug.cgi?id=176718

Reviewed by Carlos Garcia Campos.

WebGL's GL_LUMINANCE_ALPHA format is not available in OpenGL when using a version >= 3.2
and a core profile. In that case, we need to replace it with GL_RG and swizzle the color
components appropriately.

No new behavior.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texSubImage2D):

1:47 AM Changeset in webkit [224097] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/bmalloc

Merge r223844 - bmalloc::api::tryLargeMemalignVirtual() shouldn't assert on a failed allocation
​https://bugs.webkit.org/show_bug.cgi?id=178654

Reviewed by Geoffrey Garen.

  • bmalloc/bmalloc.h:

(bmalloc::api::tryLargeMemalignVirtual): Call Heap::tryAllocateLarge()
instead of Heap::allocateLarge(). The former will return a null pointer
upon a failed allocation, allowing the caller to fail gracefully just as
the API entrypoint implies, while the latter currently provokes a crash
in these circumstances.

1:45 AM Changeset in webkit [224096] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223835 - Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty.
​https://bugs.webkit.org/show_bug.cgi?id=178651
<rdar://problem/35117448>

Reviewed by Antti Koivisto.

Calling setNeedsLayout() on the RenderView to trigger selection update is problematic in 2 different ways:

  1. marking the root renderer dirty does not trigger layout (this is very specific to the root,

other renderers do trigger layout). It means that it works as long as someone else schedules a layout.

  1. when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with

the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself).

This patch addresses these issues by scheduling/converting subtree layout when needed.

Covered by fast/dynamic/remove-invisible-node-inside-selection.html/remove-node-inside-selection.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::respondToNodeModification):

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleSelectionUpdate):

  • page/FrameView.h:
1:36 AM Changeset in webkit [224095] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (r224077): DeprecatedGlobalSettings::setAVKitEnabled() not protected by HAVE(AVKIT)

Unreviewed build fix.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Fix build.

1:28 AM Changeset in webkit [224094] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223789 - When destroying a resource, register "only" the clients who are losing their resource as having pending resources
​https://bugs.webkit.org/show_bug.cgi?id=178567
<rdar://problem/35064781>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-10-20
Reviewed by Simon Fraser.

SVGResources::resourceDestroyed() will return a bool indicating whether
it had a reference to the destroyed resource or not. If it returns true
SVGResourcesCache::resourceDestroyed() will register the client Element
as having pending resources.

  • rendering/svg/SVGResources.cpp:

(WebCore::paintingResourceFromSVGPaint):
(WebCore::SVGResources::removeClientFromCache const):
(WebCore::SVGResources::resourceDestroyed):
(WebCore::SVGResources::buildSetOfResources):
(WebCore::SVGResources::resetClipper):
(WebCore::SVGResources::resetFilter):
(WebCore::SVGResources::resetMarkerStart):
(WebCore::SVGResources::resetMarkerMid):
(WebCore::SVGResources::resetMarkerEnd):
(WebCore::SVGResources::resetMasker):
(WebCore::SVGResources::resetFill):
(WebCore::SVGResources::resetStroke):
(WebCore::SVGResources::resetLinkedResource):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::isEmpty const):
(WebCore::SVGResources::ClipperFilterMaskerData::ClipperFilterMaskerData): Deleted.
(WebCore::SVGResources::MarkerData::MarkerData): Deleted.
(WebCore::SVGResources::FillStrokeData::FillStrokeData): Deleted.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

1:26 AM Changeset in webkit [224093] by Carlos Garcia Campos
  • 7 edits
    4 adds in releases/WebKitGTK/webkit-2.18

Merge r223766 - AX: [ATK] Events missing and state incorrect for aria-activedescendant
​https://bugs.webkit.org/show_bug.cgi?id=178523

Reviewed by Chris Fleizach.

Source/WebCore:

When the aria-activedescendant of an element changes, emit object:state-changed:focused.
When a focused element has a valid active descendant, do not expose the focused state on
the element, but rather on the active descendant. Also expose the focusable state on the
active descendant.

Tests: accessibility/gtk/aria-activedescendant-changed-notification.html

accessibility/gtk/aria-activedescendant.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isActiveDescendantOfFocusedContainer const):
(WebCore::AccessibilityObject::ariaActiveDescendantReferencingElements const):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant const):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

LayoutTests:

  • accessibility/gtk/aria-activedescendant-changed-notification-expected.txt: Added.
  • accessibility/gtk/aria-activedescendant-changed-notification.html: Added.
  • accessibility/gtk/aria-activedescendant-expected.txt: Added.
  • accessibility/gtk/aria-activedescendant.html: Added.
1:12 AM Changeset in webkit [224092] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r223688 - Overlapping text on all CSS fonts specs
​https://bugs.webkit.org/show_bug.cgi?id=177585
<rdar://problem/34704078>

Reviewed by Daniel Bates.

Source/WebCore:

We were resetting StyleResolver::overrideDocumentElementStyle too early when resolving slot elements.
This resulted in 'rem' units being miscomputed.

Reduction by Zalan.

Test: fast/html/details-line-height-overlap.html

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::Scope::Scope):
(WebCore::Style::TreeResolver::Scope::~Scope):

Only reset overrideDocumentElementStyle when destroying the scope.

(WebCore::Style::TreeResolver::pushScope):
(WebCore::Style::TreeResolver::pushEnclosingScope):
(WebCore::Style::TreeResolver::popScope):

A scope can show up multiple times in scope stack.

  • style/StyleTreeResolver.h:

LayoutTests:

  • fast/html/details-line-height-overlap-expected.html: Added.
  • fast/html/details-line-height-overlap.html: Added.
  • platform/ios/fast/shadow-dom/copy-shadow-tree-expected.txt:
1:02 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
12:41 AM Changeset in webkit [224091] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip some copy & paste tests I wrote on GTK since they're are known to timeout/slow.

  • platform/gtk/TestExpectations:
12:13 AM Changeset in webkit [224090] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: unknown capabilities should produce an InvalidArgument error when validating capabilities
​https://bugs.webkit.org/show_bug.cgi?id=178868

Reviewed by Brian Burg.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_extensions

  • WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):

12:11 AM Changeset in webkit [224089] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: deserializeTimeouts should fail if the value is not integer
​https://bugs.webkit.org/show_bug.cgi?id=178866

Reviewed by Brian Burg.

If value is not an integer, or it is less than 0 or greater than 264 – 1, return error with error code invalid
argument.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-deserialize-as-a-timeout

Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_values[timeouts-value59-body0]

imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_values[timeouts-value59-body1]

  • WebDriverService.cpp:

(WebDriver::deserializeTimeouts):

12:10 AM Changeset in webkit [224088] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: failing to process capabilities should produce InvalidArgument error not SessionNotCreated
​https://bugs.webkit.org/show_bug.cgi?id=178864

Reviewed by Brian Burg.

Fixes most of the tests in imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities

  • WebDriverService.cpp:

(WebDriver::WebDriverService::processCapabilities const):

12:04 AM Changeset in webkit [224087] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

[GTK] Crash in WebCore::SelectionRangeData::apply
​https://bugs.webkit.org/show_bug.cgi?id=177808

Reviewed by Carlos Garcia Campos.

The problem appears to be a name collision between WebCore::SelectionData and
WebCore::SelectionData. Yes, those are the same names. It seems the destructor for a
Source/WebCore/platform/gtk/SelectionData.h SelectionData is being called on a
Source/WebCore/rendering/SelectionRangeData.cpp SelectionData. Yikes. Can you forgive the
poor linker for not being magic?

This fixes crashes in approximately one bajillion tests.

  • rendering/SelectionRangeData.cpp: Move SelectionData into an anonymous namespace.

Oct 26, 2017:

11:18 PM Changeset in webkit [224086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Fix build after WebCore moves to unified source.
​https://bugs.webkit.org/show_bug.cgi?id=178920

Added empty implementations to fix link error.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-26
Reviewed by Ryosuke Niwa.

  • platform/network/curl/DNSCurl.cpp:

(WebCore::DNSResolveQueue::updateIsUsingProxy):
(WebCore::DNSResolveQueue::platformResolve):

11:06 PM Changeset in webkit [224085] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Implement seek tolerance methods in WebAVPlayerController.
​https://bugs.webkit.org/show_bug.cgi?id=178838
rdar://problem/33781777

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-26
Reviewed by Eric Carlson.

Source/WebCore:

No new tests because this doesn't change any behavior in the page, but exposes seek tolerance to fullscreen platform UI.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setCurrentTimeWithTolerance):

  • html/HTMLMediaElement.h:
  • platform/cocoa/PlaybackSessionModel.h:
  • platform/cocoa/PlaybackSessionModelMediaElement.h:
  • platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::seekToTime):

  • platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController seekToTime:]):
(-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):
(-[WebAVPlayerController seekByTimeInterval:]):
(-[WebAVPlayerController seekByTimeInterval:toleranceBefore:toleranceAfter:]):
(-[WebAVPlayerController seekToBeginning:]):
(-[WebAVPlayerController seekToEnd:]):

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::seekToTime):

Source/WebKit:

This implementes additional methods on WebAVPlayerController that allows AVKit more control over seeking.

  • UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::seekToTime):
(WebKit::PlaybackSessionManagerProxy::seekToTime):

  • WebProcess/cocoa/PlaybackSessionManager.h:
  • WebProcess/cocoa/PlaybackSessionManager.messages.in:
  • WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::seekToTime):

9:04 PM Changeset in webkit [224084] by commit-queue@webkit.org
  • 5 edits
    2 moves
    1 delete in trunk

[GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10
​https://bugs.webkit.org/show_bug.cgi?id=178854

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-26
Reviewed by Michael Catanzaro.

Tools:

  • Scripts/webkitpy/port/base.py:

(Port._debian_php_version): Return "-php7.1" if libphp7.1.so found.
(Port._is_debian_php_version_7): Deleted.

  • gtk/install-dependencies: Install libapache2-mod-php instead of libapache2-mod-php7.0.
  • wpe/install-dependencies: Ditto.

LayoutTests:

  • http/conf/debian-httpd-2.2.conf: Removed.
  • http/conf/debian-httpd-2.4-php7.0.conf: Renamed from LayoutTests/http/conf/debian-httpd-2.4-php7.conf.
  • http/conf/debian-httpd-2.4-php7.1.conf: Copied from LayoutTests/http/conf/debian-httpd-2.4-php7.conf.
7:44 PM Changeset in webkit [224083] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

Fix Windows build
​https://bugs.webkit.org/show_bug.cgi?id=178892

  • AccessibleBase.cpp:

(MSAARole):

7:32 PM Changeset in webkit [224082] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Web Automation: denying user permission for getUserMedia doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=178895

Reviewed by Youenn Fablet.

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The ordering of special cases is incorrect. Safari configures its automation views to
allow mock devices and never prompt for them. These checks were before the check for
the automation session's getUserMedia permission. Switch these checks.

Also change the deny reason so that subsequent requests are also denied. This matches
behavior when a user denies a permission request on a real dialog. With this change,
the DOM error changes from SecurityError to NotAllowedError, which makes more sense.

7:20 PM Changeset in webkit [224081] by webkit@devinrousso.com
  • 8 edits in trunk

Web Inspector: Canvas Tab: canvas path components from old page stick around when page is reloaded
​https://bugs.webkit.org/show_bug.cgi?id=178806
<rdar://problem/35176360>

Reviewed by Brian Burg.

Source/WebInspectorUI:

Before this change, the CanvasCollection was regenerated each time the Canvas tab was
attached. This also caused the invisible TreeOutline, used for the path components and to
manage selection, to be reset as well. Whenever the page refreshed, however, the old
canvases, and associated recordings, were not removed. This patch reworks all of this logic
to create the CanvasCollection on construction of the tab and add/remove canvases as needed.

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.canvasAdded):
(WI.CanvasManager.prototype.canvasRemoved):
(WI.CanvasManager.prototype._removeCanvas):
(WI.CanvasManager.prototype._mainResourceDidChange):
Replaced the "Cleared" event by instead firing "CanvasRemoved" for every tracked canvas. This
massively simplifies the logic for when the page navigates, as everything goes through a
single event listener.
Drive-by: changed existing event names to remove unnecessary words.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype.detached):
(WI.CanvasTabContentView.prototype._addCanvas):
(WI.CanvasTabContentView.prototype._removeCanvas):
(WI.CanvasTabContentView.prototype._handleCanvasAdded):
(WI.CanvasTabContentView.prototype._handleCanvasRemoved):
(WI.CanvasTabContentView.prototype._canvasAdded): Deleted.
(WI.CanvasTabContentView.prototype._canvasRemoved): Deleted.
(WI.CanvasTabContentView.prototype._mainResourceDidChange): Deleted.
Rework logic for the way that the CanvasCollection is maintained. It is no longer
created/destroyed each time the view is attached/detached, and instead a diff is calculated
for the added/existing/removed canvases and the content views are added/removed as such.

  • UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._selectionPathComponentsChanged):
Drive-by: if an imported recording is selected on the Canvas Overview view, we should show it.

LayoutTests:

  • inspector/canvas/context-attributes.html:
  • inspector/canvas/resources/create-context-utilities.js:

(destroyCanvases):
(TestPage.registerInitializer.awaitCanvasAdded):
(TestPage.registerInitializer):

  • inspector/canvas/resources/shaderProgram-utilities.js:

(deleteContext):
(TestPage.registerInitializer.window.addParentCanvasRemovedTestCase):
(TestPage.registerInitializer):

7:19 PM Changeset in webkit [224080] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix GCC warning spam after r224077
​https://bugs.webkit.org/show_bug.cgi?id=178823

Need to leave a blank line at the bottom of the file.

  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
7:02 PM Changeset in webkit [224079] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix WPE build after r224074
​https://bugs.webkit.org/show_bug.cgi?id=178892

  • accessibility/wpe/AccessibilityObjectWPE.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

6:57 PM Changeset in webkit [224078] by Simon Fraser
  • 17 edits
    1 move
    3 adds in trunk

When navigating back to a page, compositing layers may not use accelerated drawing
​https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946

Reviewed by Dean Jackson.
Source/WebCore:

There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which
occurred on back navigation, related to the ordering of style recalcs and layout.

First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called
its cacheAcceleratedCompositingFlags(), so any layers created during style update
didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal
to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers().

Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing()
before updating tiles, so that new tiles fetch the right acceleratesDrawing state from
the TileController.

Test: compositing/accelerated-layers-after-back.html

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderLayerCompositor.h:

Source/WebKit:

Avoid assertions when a test enables accelerated drawing (which we can't support
in the iOS simulator).

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):

Tools:

Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
and use it to set the state of the web view.

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html.

  • compositing/accelerated-layers-after-back-expected.txt: Added.
  • compositing/accelerated-layers-after-back.html: Added.
  • compositing/iframes/page-cache-layer-tree.html:
  • compositing/page-cache-back-crash.html:
  • compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html.
  • platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added.
6:45 PM Changeset in webkit [224077] by commit-queue@webkit.org
  • 14 edits
    1 copy in trunk/Source/WebKit

[Settings] Generate the bulk of WebPage::updatePreferences(...)
​https://bugs.webkit.org/show_bug.cgi?id=178823

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-26
Reviewed by Tim Horton.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit.xcodeproj/project.pbxproj:

Add new file generation.

  • Scripts/GeneratePreferences.rb:

Replace 'webkitOnly' boolean option with a new 'webcoreBinding' option.
'webcoreBinding' supports the following values:

  • none (same as webkit only)
  • custom (means that you do bind to a webcore concept, but currently it must be done in a custom manner)
  • DeprecatedGlobalSettings (binds to a DeprecatedGlobalSettings setting)
  • RuntimeEnabledFeatures (binds to a RuntimeEnabledFeatures setting)

If 'webcoreBinding' is not provided, the preference binds to WebCore Setting
of either the same name or the override name provided by the new 'webcoreName'
option (we should try to remove the need for 'webcoreName' by unifying with
WebCore on preference/setting naming).

A 'condition' option was also added to indicate that the preference is only available
when that macro condition is true.

Since we are generating most of WebPage::updatePreferences, we can simplify the
macros in WebPreferencesDefinitions.h to only have normal/debug/experimental variants
and remove the need for per-type macros, which were only used in WebPage::updatePreferences.

  • Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb: Added.

Generates bindings from WebPreferences to WebCore::Settings/DeprecatedGlobalSettings/RuntimeEnabledFeatures.
Does not generate a binding if the 'webcoreBinding' option is set to either 'none' or 'custom'.

  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:

Simplify down to just normal/debug/experimental macros.

  • Shared/WebPreferences.yaml:

Annotate perferences with new optional 'webcoreBinding', 'webcoreName', and 'condition'
options.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Replace a ton of hand written preference to settings bindings with a call to updatePreferencesGenerated().

  • WebProcess/WebPage/WebPage.h:

Add declaration of updatePreferencesGenerated, remove platformPreferencesDidChange.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformPreferencesDidChange): Deleted.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformPreferencesDidChange): Deleted.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Deleted.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformPreferencesDidChange): Deleted.

  • WebProcess/WebPage/wpe/WebPageWPE.cpp:

(WebKit::WebPage::platformPreferencesDidChange): Deleted.

Remove all the empty platformPreferencesDidChange functions.

6:14 PM Changeset in webkit [224076] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

Fix Windows build
​https://bugs.webkit.org/show_bug.cgi?id=178892

  • AccessibleBase.cpp:

(AccessibleBase::state const):
(MSAARole):

5:54 PM Changeset in webkit [224075] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build
​https://bugs.webkit.org/show_bug.cgi?id=178892

  • accessibility/win/AccessibilityObjectWin.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

5:37 PM Changeset in webkit [224074] by achristensen@apple.com
  • 57 edits in trunk/Source/WebCore

Modernize AccessibilityObject.h
​https://bugs.webkit.org/show_bug.cgi?id=178892

Reviewed by Tim Horton.

The enums in AccessibilityObject.h are causing naming collisions with unified builds.
This is what enum classes are for.
HashMaps of enum classes still need a few casts to/from int.

I also made some RefPtr's Ref's, use some initializer lists instead of values in the constructor implementation, and indentation fixing.

No change in behavior.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXComputedObjectAttributeCache::getIgnored const):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AXObjectCache.h:

(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(WebCore::AXComputedObjectAttributeCache::getIgnored const):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::parentRowGroup const):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::headerObject):

  • accessibility/AccessibilityAttachment.cpp:

(WebCore::AccessibilityAttachment::accessibilityText):

  • accessibility/AccessibilityAttachment.h:
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::roleValue const):
(WebCore::AccessibilityImageMapLink::accessibilityText):

  • accessibility/AccessibilityLabel.cpp:

(WebCore::childrenContainOnlyStaticText):

  • accessibility/AccessibilityLabel.h:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isUnorderedList const):
(WebCore::AccessibilityList::isOrderedList const):
(WebCore::AccessibilityList::determineAccessibilityRole):
(WebCore::AccessibilityList::roleValue const):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject const):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMathMLElement.cpp:

(WebCore::AccessibilityMathMLElement::determineAccessibilityRole):
(WebCore::AccessibilityMathMLElement::isMathScriptObject const):
(WebCore::AccessibilityMathMLElement::isMathMultiscriptObject const):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::accessibilityText):
(WebCore::AccessibilityMediaControl::roleValue const):

  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject const):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::canHaveChildren const):
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityNodeObject::isSearchField const):
(WebCore::AccessibilityNodeObject::isImage const):
(WebCore::AccessibilityNodeObject::isPasswordField const):
(WebCore::AccessibilityNodeObject::isInputImage const):
(WebCore::AccessibilityNodeObject::isProgressIndicator const):
(WebCore::AccessibilityNodeObject::isSlider const):
(WebCore::AccessibilityNodeObject::isMenuRelated const):
(WebCore::AccessibilityNodeObject::isMenu const):
(WebCore::AccessibilityNodeObject::isMenuBar const):
(WebCore::AccessibilityNodeObject::isMenuButton const):
(WebCore::AccessibilityNodeObject::isMenuItem const):
(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isChecked const):
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute const):
(WebCore::AccessibilityNodeObject::headingLevel const):
(WebCore::AccessibilityNodeObject::isHeading const):
(WebCore::AccessibilityNodeObject::isLink const):
(WebCore::AccessibilityNodeObject::isGroup const):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::checkboxOrRadioValue const):
(WebCore::AccessibilityNodeObject::actionElement const):
(WebCore::AccessibilityNodeObject::alterSliderValue):
(WebCore::AccessibilityNodeObject::isGenericFocusableElement const):
(WebCore::AccessibilityNodeObject::menuElementForMenuButton const):
(WebCore::AccessibilityNodeObject::menuItemElementForMenu const):
(WebCore::AccessibilityNodeObject::titleElementText const):
(WebCore::AccessibilityNodeObject::alternativeText const):
(WebCore::AccessibilityNodeObject::visibleText const):
(WebCore::AccessibilityNodeObject::helpText const):
(WebCore::AccessibilityNodeObject::accessibilityText):
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::accessibilityDescription const):
(WebCore::AccessibilityNodeObject::roleIgnoresTitle const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):
(WebCore::AccessibilityNodeObject::title const):
(WebCore::AccessibilityNodeObject::text const):
(WebCore::AccessibilityNodeObject::stringValue const):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent const):
(WebCore::AccessibilityNodeObject::canSetSelectedAttribute const):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::accessibleNameDerivesFromContent const):
(WebCore::AccessibilityObject::isBlockquote const):
(WebCore::AccessibilityObject::isTextControl const):
(WebCore::AccessibilityObject::isARIATextControl const):
(WebCore::AccessibilityObject::isLandmark const):
(WebCore::AccessibilityObject::findMatchingObjects):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::isARIAInput):
(WebCore::AccessibilityObject::isARIAControl):
(WebCore::AccessibilityObject::isRangeControl const):
(WebCore::AccessibilityObject::visiblePositionForBounds const):
(WebCore::AccessibilityObject::supportsARIAReadOnly const):
(WebCore::AccessibilityObject::ariaReadOnlyValue const):
(WebCore::AccessibilityObject::headingElementForNode):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::actionVerb const):
(WebCore::AccessibilityObject::ariaCurrentState const):
(WebCore::AccessibilityObject::ariaCurrentValue const):
(WebCore::AccessibilityObject::orientation const):
(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
(WebCore::AccessibilityObject::computedRoleString const):
(WebCore::AccessibilityObject::supportsPressAction const):
(WebCore::AccessibilityObject::sortDirection const):
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::supportsChecked const):
(WebCore::AccessibilityObject::checkboxOrRadioValue const):
(WebCore::AccessibilityObject::scrollByPage const):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::buttonRoleType const):
(WebCore::AccessibilityObject::isButton const):
(WebCore::AccessibilityObject::accessibilityIsIgnoredByDefault const):
(WebCore::AccessibilityObject::defaultObjectInclusion const):
(WebCore::AccessibilityObject::accessibilityIsIgnored const):
(WebCore::AccessibilityObject::isContainedByPasswordField const):
(WebCore::AccessibilityObject::AccessibilityObject): Deleted.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityText::AccessibilityText):
(WebCore::AccessibilityIsIgnoredFromParentData::AccessibilityIsIgnoredFromParentData):
(WebCore::AccessibilityObject::isImageMap const):
(WebCore::AccessibilityObject::isWebArea const):
(WebCore::AccessibilityObject::isCheckbox const):
(WebCore::AccessibilityObject::isRadioButton const):
(WebCore::AccessibilityObject::isListBox const):
(WebCore::AccessibilityObject::isSpinButton const):
(WebCore::AccessibilityObject::isSwitch const):
(WebCore::AccessibilityObject::isToggleButton const):
(WebCore::AccessibilityObject::isTabList const):
(WebCore::AccessibilityObject::isTabItem const):
(WebCore::AccessibilityObject::isRadioGroup const):
(WebCore::AccessibilityObject::isComboBox const):
(WebCore::AccessibilityObject::isTree const):
(WebCore::AccessibilityObject::isTreeGrid const):
(WebCore::AccessibilityObject::isTreeItem const):
(WebCore::AccessibilityObject::isScrollbar const):
(WebCore::AccessibilityObject::isListItem const):
(WebCore::AccessibilityObject::isScrollView const):
(WebCore::AccessibilityObject::isCanvas const):
(WebCore::AccessibilityObject::isPopUpButton const):
(WebCore::AccessibilityObject::isColorWell const):
(WebCore::AccessibilityObject::isSplitter const):
(WebCore::AccessibilityObject::isToolbar const):
(WebCore::AccessibilityObject::isSummary const):
(WebCore::AccessibilityObject::isStaticText const):
(WebCore::AccessibilityObject::ariaRoleAttribute const):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObject const):
(WebCore::AccessibilityRenderObject::isAttachment const):
(WebCore::AccessibilityRenderObject::helpText const):
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupChildren const):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers const):
(WebCore::AccessibilityRenderObject::linkedUIElements const):
(WebCore::AccessibilityRenderObject::isAllowedChildOfTree const):
(WebCore::objectInclusionFromAltText):
(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityRenderObject::selectedTextRange const):
(WebCore::AccessibilityRenderObject::isTabItemSelected const):
(WebCore::AccessibilityRenderObject::isFocused const):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant const):
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::supportsExpandedTextValue const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::orientation const):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren const):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute const):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic const):
(WebCore::AccessibilityRenderObject::canHaveSelectedChildren const):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
(WebCore::AccessibilityRenderObject::visibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::actionVerb const):
(WebCore::msaaRoleForRenderer):
(WebCore::AccessibilityRenderObject::roleValueForMSAA const):

  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::accessibilityText):
(WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const):
(WebCore::AccessibilitySVGElement::inheritsPresentationalRole const):
(WebCore::AccessibilitySVGElement::determineAriaRoleAttribute const):
(WebCore::AccessibilitySVGElement::determineAccessibilityRole):

  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::scrollBar):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::orientation const):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation const):
(WebCore::AccessibilitySlider::addChildren):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::addChildren):

  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::hasARIARole const):
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):
(WebCore::AccessibilityTable::roleValue const):
(WebCore::AccessibilityTable::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityTable::titleElementText const):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityTableCell::determineAccessibilityRole):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObject):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::determineAccessibilityRole):
(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored const):

  • accessibility/AccessibilityTree.cpp:

(WebCore::AccessibilityTree::determineAccessibilityRole):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
(WebCore::AccessibilityObject::isInputTypePopupButton const):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]):
(-[WebAccessibilityObjectWrapper _accessibilityTreeAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityListAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper _accessibilityTextEntryTraits]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(-[WebAccessibilityObjectWrapper accessibilityLinkedElement]):
(-[WebAccessibilityObjectWrapper treeItemParentForObject:]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
(-[WebAccessibilityObjectWrapper accessibilitySortDirection]):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

5:34 PM Changeset in webkit [224073] by mmaxfield@apple.com
  • 10 edits in trunk/LayoutTests

[iOS] Update expected results for writing-mode tests
​https://bugs.webkit.org/show_bug.cgi?id=178916
<rdar://problem/33250084>

Unreviewed.

  • platform/ios/TestExpectations:
  • platform/ios/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/ios/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/ios/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/ios/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/ios/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/ios/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/ios/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/ios/fast/writing-mode/vertical-baseline-alignment-expected.txt:
5:31 PM Changeset in webkit [224072] by msaboff@apple.com
  • 3 edits
    1 add in trunk

REGRESSION(r222601): We fail to properly backtrack into a sub pattern of a parenthesis with non-zero minimum
​https://bugs.webkit.org/show_bug.cgi?id=178890

Reviewed by Keith Miller.

JSTests:

New regression test.

  • stress/regress-178890.js: Added.

Source/JavaScriptCore:

We need to let a contained subpattern backtrack before declaring that the containing
parenthesis doesn't match. If the subpattern fails to match backtracking, then we
can check to see if we trying to backtrack below the minimum match count.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParentheses):

4:59 PM Changeset in webkit [224071] by achristensen@apple.com
  • 6 edits
    1 add in trunk

Move WKWebViewConfiguration validation to WKWebView construction
​https://bugs.webkit.org/show_bug.cgi?id=178840

Reviewed by Tim Horton.
Source/WebKit:


I'm trying to remove WKWebViewConfigurationInternal methods so I can make WKWebViewConfiguration
a wrapper around an APIObject like all the other API objects. A small step towards making this easier
is to remove the unnecessary method _validate and move its logic to its one callsite. I added an API test
that ensures no change in behavior.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _validate]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm: Added.

(TEST):

4:50 PM Changeset in webkit [224070] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

importScripts in service worker should use ServiceWorkersMode::None
​https://bugs.webkit.org/show_bug.cgi?id=178888

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/service-worker-importScript.html

Made sure ServiceWorkersMode::None is used for loading scripts in service workers as we do not support foreign fetch.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

LayoutTests:

  • http/tests/workers/service/resources/service-worker-importScript-worker.js: Added.
  • http/tests/workers/service/resources/service-worker-importScript.js: Added.
  • http/tests/workers/service/service-worker-importScript-expected.txt: Added.
  • http/tests/workers/service/service-worker-importScript.html: Added.
4:44 PM Changeset in webkit [224069] by keith_miller@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed, cleanup changelogs.

4:42 PM Changeset in webkit [224068] by Megan Gardner
  • 3 edits in trunk/Source/WebKit

Remove unneeded block selection calculation code
​https://bugs.webkit.org/show_bug.cgi?id=178889

Reviewed by Tim Horton.

Removing more block selection code. Much of this should have been removed
before, as the only things that were using these functions were removed in the
last patch. Also remove the code decided if you should move to block mode or not,
as the answer now is always NO.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::WebPage::rangeForBlockAtPoint): Deleted.
(WebKit::distanceBetweenRectsForPosition): Deleted.
(WebKit::rectsEssentiallyTheSame): Deleted.
(WebKit::unionDOMRanges): Deleted.
(WebKit::computeEdgeCenter): Deleted.
(WebKit::WebPage::expandedRangeFromHandle): Deleted.
(WebKit::WebPage::contractedRangeFromHandle): Deleted.
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle): Deleted.
(WebKit::WebPage::switchToBlockSelectionAtPoint): Deleted.
(WebKit::WebPage::shouldSwitchToBlockModeForHandle): Deleted.

4:41 PM Changeset in webkit [224067] by webkit@devinrousso.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab: canvases overview should support navigation via keyboard
​https://bugs.webkit.org/show_bug.cgi?id=178800
<rdar://problem/35175856>

Reviewed by Brian Burg.

Create a KeyboardShorcut for each of the following:

  • Up: selects the previous canvas in the selected column
  • Down: selects the next canvas in the selected column
  • Right: selects the next canvas in the selected row
  • Left: selects the previous canvas in the selected row
  • Space: toggle recording of the selected canvas
  • Shift+Space: toggle single-frame recording of the selected canvas

The calculation for selected row/colum is based on the offsetWidth of the parent element
and the selected item's content view element. Since this view uses a flexbox, all of the
items are expected to have the same dimensions, meaning that this value is uniform. The
intended functionality is that of a spreadsheet, where pressing pressing left/right will
never change the selected row and up/down will never change the selected column.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview):
(.content-view.canvas-overview .content-view.canvas):
Move margin value to a CSS variable so that it can be easily retrieved via JavaScript.

  • UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.contentViewAdded):
(WI.CanvasOverviewContentView.prototype.contentViewRemoved):
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype.get _itemMargin):
(WI.CanvasOverviewContentView.prototype._changeSelectedItemVertically):
(WI.CanvasOverviewContentView.prototype._changeSelectedItemHorizontally):
(WI.CanvasOverviewContentView.prototype._updateNavigationItems):
(WI.CanvasOverviewContentView.prototype._handleUp):
(WI.CanvasOverviewContentView.prototype._handleRight):
(WI.CanvasOverviewContentView.prototype._handleDown):
(WI.CanvasOverviewContentView.prototype._handleLeft):
(WI.CanvasOverviewContentView.prototype._handleSpace):
(WI.CanvasOverviewContentView.prototype._supplementalRepresentedObjectsDidChange):
Drive-by: call _updateNavigationItems whenever an item is added/removed so that if there
are no items the navigation items cannot be clicked.

4:37 PM Changeset in webkit [224066] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Implement ServiceWorkerContainer getRegistration
​https://bugs.webkit.org/show_bug.cgi?id=178882

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26

  • TestExpectations: Skipping service worker tests until they can produce results.
4:32 PM Changeset in webkit [224065] by mmaxfield@apple.com
  • 2 edits
    47 adds in trunk/Tools

Demonstrate a possible structure of the WebGPU API
​https://bugs.webkit.org/show_bug.cgi?id=178874

Reviewed by Dean Jackson.

Over the past few weeks, we've been putting together an example showing that a WebGPU API
which has implicit barriers can work on all three low-level graphics APIs. We've implemented
it on top of Vulkan first, because this is the API which has the strictest requirements and
is most difficult to use.

With this API, this is a valid WebGPU snippet:

auto device = WebGPU::Device::create(hInstance, hWnd);
auto& commandQueue = device->getCommandQueue();
auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { }, nullptr);

… later, in the draw() function …

auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState);
renderPass->setViewport(0, 0, width, height);
renderPass->setScissorRect(0, 0, width, height);
renderPass->draw(3);
commandQueue->commitRenderPass(std::move(renderPass));
commandQueue->present();

This snippet doesn’t hook up any vertex attributes or resources, which means the vertex
shader has to say something like ({vec4(…), vec4(…), vec4(…)})[gl_VertexIndex]. It also
passes in “nullptr” when creating the render pass, which means “render to the screen, rather
than to a frame buffer.” You can also see that it doesn’t attach any resources to the draw
call.

In Direct3D 12 and Vulkan, resources are bound in sets, rather than individually. For
example, a set might contain two uniform buffers, a texture, and another uniform buffer. At
draw time, you swap in whole sets of resources with a single call. A shader invocation can
access a collection of sets. Because all shader resource accesses are indirected through
these sets, the shape of these sets needs to be supplied at the time you compile the render
state. Here is a snippet which bounds a single set which contains a uniform buffer and a
texture:

auto buffer = device->getBuffer(bufferInitialContents);
auto texture = device->getTexture(buffer width, height, WebGPU::PixelFormat::RGBA8, textureInitialContents);
One resource set, which holds a single uniform buffer object and a single texture
auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { { WebGPU::ResourceType::UniformBufferObject, WebGPU::ResourceType::Texture } }, nullptr);

… later, in the draw() function …

auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState);
renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()), WebGPU::TextureReference(texture.get()) });
…
renderPass->draw(3);
commandQueue->commitRenderPass(std::move(renderPass));
commandQueue->present();

The first argument to the setResources() call identifies which set to populate with the supplied resources.

One tenant of the low-level graphics APIs is that, if you’ve enabled double buffering (or
triple buffering), the GPU is executing one frame at the same time you are recording the
next frame. This often means that you need duplicate resources so the CPU and GPU don’t step
on each other’s toes. However, platforms have platform-specific requirements about whether
or not they can be double / triple buffered, and we don’t want to expose this to the Web for
fear of badly-authored programs.

To solve this, resources are reference counted, and the return type of getBuffer() is an
RAII type called BufferHolder which increments and decrements the reference count
automatically. The reference count is also incremented and decremented when the GPU is using
the resource in a Pass. When the reference count reaches 0, the resource isn’t destroyed;
instead, it’s simply moved to a “free list” which getBuffer() may pull from. Therefore,
applications don’t need to know whether the frame buffer is double buffered or triple
buffered; they can just getBuffer() each frame, and the correct number of buffers will be
created and recycled.

{

auto buffer = device->getBuffer(bufferSize); These get recycled
… populate the buffer …
auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState);
renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()) });
…
renderPass->draw(…);
commandQueue->commitRenderPass(std::move(renderPass));

}
commandQueue->present();

In Direct3D and Vulkan, vertex buffers and index buffers are not part of the resource sets
mentioned above. Instead, you tell the render state about the shape of the vertex and index
buffers, and you swap them out independently in the draw loop. Metal and Vulkan have almost
identical API to specify this shape of the vertex buffers, so I’ve mostly copied it. In this
example, we have two vertex attributes, a vec2 and a vec3, which both come from the same
buffer:

{ Attribute format, offset within stride, buffer to pull from }
std::vector<WebGPU::RenderState::VertexAttribute> vertexAttributes = { {WebGPU::RenderState::VertexFormat::Float2, 0, 0}, {WebGPU::RenderState::VertexFormat::Float3, sizeof(float) * 2, 0} };
 A single vertex buffer, with a stride of 5 floats
auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { sizeof(float) * 5 }, vertexAttributes, resourceTypes, nullptr);

… later, in the draw() function …

auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState);
renderPass->setVertexAttributeBuffers({ vertexBuffer.get() }); The one vertex buffer which both attributes pull from
renderPass->setResources(…);
…
renderPass->draw(…);
commandQueue->commitRenderPass(std::move(renderPass));
commandQueue->present();

You can also tell the RenderState about how many render targets you have and their formats,
and then when you create the RenderPass, you specify the specific textures you want to
render into.

std::vector<WebGPU::PixelFormat> colorPixelFormats = { WebGPU::PixelFormat::RGBA8, WebGPU::PixelFormat::RGBA8 }; Two render targets, with these formats
auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", vertexBufferStrides, vertexAttributes, resourceTypes, &colorPixelFormats);

… later, in the draw() function …

std::vector<std::reference_wrapper<WebGPU::Texture>> destinationTextures = { texture1->get(), texture2->get() };
auto renderPass = commandQueue->createRenderPass(&destinationTextures);
renderPass->setRenderState(renderState);
…
renderPass->draw(…);
commandQueue->commitRenderPass(std::move(renderPass));

Now, draw one of the textures to the screen. Note that no synchronization is necessary here!
auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState2);
renderPass->setResources(0, { WebGPU:: TextureReference(texture1.get()) });
…
renderPass->draw(…);
commandQueue->commitRenderPass(std::move(renderPass));
commandQueue->present();

Just like how in Metal has Render Encoders and Compute Encoders, WebGPU has RenderPasses
and ComputePasses.

auto& computeState = device->getComputeState(computeShader, "main", resourceTypes);
…
auto computePass = commandQueue->createComputePass();
computePass->setComputeState(computeState);
computePass->setResources(0, resources);
computePass->dispatch(width, height, depth);
commandQueue->commitComputePass(std::move(computePass));

Now, draw the resources we just computed. Note that no synchronization is necessary here!
auto renderPass = commandQueue->createRenderPass(nullptr);
renderPass->setRenderState(renderState);
renderPass->setResources(0, resources });
…
renderPass->draw(…);
commandQueue->commitRenderPass(std::move(renderPass));
commandQueue->present();

There are also two other types of passes: one that corresponds to a Metal blit encoder, and
one that allows the CPU to change the contents of GPU buffers and textures. This last kind
of pass is a little interesting: you can’t just change the contents of a buffer at any time
you feel like it, because that resource might be in use by the GPU. Therefore, we need to do
the same kind of synchronization that we already do at render pass boundaries.

In addition, both Vulkan and Direct3D have a concept of a memory heap. A resource might
exist inside a heap which is fast, but invisible from the CPU, or in a heap which is slow,
but visible by the CPU. Certain operations are not possible from some types of images (e.g.
non-tiled textures may not be able to be sampled from). The usual way to get around this
problem is to have two resources: a slow staging resource which the CPU can see, and a fast
resource which the CPU can’t see. Uploading data is a two-pass algorithm, where the CPU
memcpy()s into the slow staging resource, and then a blit command is enqueued on the GPU to
copy the contents of the staging resource to the real resource. This requires that the
upload have access to the commandQueue so it can possibly enqueue a blit between the staging
and real resources. Therefore, a pass is the right level of abstraction for these facilities.

std::queue<boost::unique_future<std::vector<uint8_t>>> futureQueue; Promises for data downloads from the GPU

… later, in the draw() function …

See if any of the previously-enqueued downloads are finished
while (!futureQueue.empty() && futureQueue.front(). has_value()) {

std::vector<uint8_t>& data = futureQueue.front().get();
Use the downloaded data
futureQueue.pop();

}
…
auto hostAccessPass = commandQueue->createHostAccessPass();
hostAccessPass->overwriteBuffer(buffer->get(), bufferContents); Upload data to a resource

futureQueue.emplace(hostAccessPass->getBufferContents(buffer->get()));
commandQueue->commitHostAccessPass(std::move(hostAccessPass));

You can also issue copy commands between resources entirely on the GPU:

auto blitPass = commandQueue->createBlitPass();
blitPass->copyTexture(source->get(), destination->get(), sourceX, sourceY, destinationX, destinationY, width, height);
commandQueue->commitBlitPass(std::move(blitPass));

  • Scripts/webkitpy/style/checker.py:
  • WebGPUAPIStructure/Example/Example.cpp: Added.

(readFile):
(drawWebGPU):
(wWinMain):
(MyRegisterClass):
(InitInstance):
(WndProc):

  • WebGPUAPIStructure/Example/Example.h: Added.
  • WebGPUAPIStructure/Example/Example.ico: Added.
  • WebGPUAPIStructure/Example/Example.rc: Added.
  • WebGPUAPIStructure/Example/Example.vcxproj: Added.
  • WebGPUAPIStructure/Example/Example.vcxproj.filters: Added.
  • WebGPUAPIStructure/Example/Example.vcxproj.user: Added.
  • WebGPUAPIStructure/Example/resource.h: Added.
  • WebGPUAPIStructure/Example/small.ico: Added.
  • WebGPUAPIStructure/Example/stdafx.cpp: Added.
  • WebGPUAPIStructure/Example/stdafx.h: Added.
  • WebGPUAPIStructure/Example/targetver.h: Added.
  • WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj: Added.
  • WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj.filters: Added.
  • WebGPUAPIStructure/WebGPU-Common/WebGPU.cpp: Added.

(WebGPU::BufferHolder::BufferHolder):
(WebGPU::BufferHolder::~BufferHolder):
(WebGPU::TextureHolder::TextureHolder):
(WebGPU::TextureHolder::~TextureHolder):
(WebGPU::SamplerHolder::SamplerHolder):
(WebGPU::SamplerHolder::~SamplerHolder):

  • WebGPUAPIStructure/WebGPU-Common/WebGPU.h: Added.

(WebGPU::Queue::~Queue):
(WebGPU::RenderState::~RenderState):
(WebGPU::ComputeState::~ComputeState):
(WebGPU::Buffer::~Buffer):
(WebGPU::Texture::~Texture):
(WebGPU::Sampler::~Sampler):
(WebGPU::TextureReference::TextureReference):
(WebGPU::TextureReference::get const):
(WebGPU::SamplerReference::SamplerReference):
(WebGPU::SamplerReference::get const):
(WebGPU::UniformBufferObjectReference::UniformBufferObjectReference):
(WebGPU::UniformBufferObjectReference::get const):
(WebGPU::ShaderStorageBufferObjectReference::ShaderStorageBufferObjectReference):
(WebGPU::ShaderStorageBufferObjectReference::get const):
(WebGPU::RenderPass::~RenderPass):
(WebGPU::ComputePass::~ComputePass):
(WebGPU::BlitPass::~BlitPass):
(WebGPU::HostAccessPass::~HostAccessPass):
(WebGPU::BufferHolder::get):
(WebGPU::TextureHolder::get):
(WebGPU::SamplerHolder::get):
(WebGPU::Device::~Device):

  • WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.cpp: Added.

(WebGPU::BlitPassImpl::BlitPassImpl):
(WebGPU::BlitPassImpl::copyTexture):

  • WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.h: Added.
  • WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.cpp: Added.

(WebGPU::BufferImpl::BufferImpl):
(WebGPU::BufferImpl::decrementReferenceCount):

  • WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.h: Added.

(WebGPU::BufferImpl::getBuffer const):
(WebGPU::BufferImpl::getDeviceMemory const):
(WebGPU::BufferImpl::incrementReferenceCount):
(WebGPU::BufferImpl::getLength const):

  • WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.cpp: Added.

(WebGPU::ComputePassImpl::ComputePassImpl):
(WebGPU::ComputePassImpl::setComputeState):
(WebGPU::ComputePassImpl::setResources):
(WebGPU::ComputePassImpl::dispatch):

  • WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.h: Added.
  • WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.cpp: Added.

(WebGPU::ComputeStateImpl::ComputeStateImpl):

  • WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.h: Added.

(WebGPU::ComputeStateImpl::getPipeline const):
(WebGPU::ComputeStateImpl::getPipelineLayout const):
(WebGPU::ComputeStateImpl::getDescriptorSetLayouts const):

  • WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.cpp: Added.

(WebGPU::Device::create):
(WebGPU::convertPixelFormat):
(WebGPU::convertFormat):
(WebGPU::debugReport):
(WebGPU::DeviceImpl::DeviceImpl):
(WebGPU::DeviceImpl::getCommandQueue):
(WebGPU::DeviceImpl::prepareShader):
(WebGPU::DeviceImpl::createPipelineLayout):
(WebGPU::DeviceImpl::createCompatibleRenderPass):
(WebGPU::convertVertexFormat):
(WebGPU::DeviceImpl::getRenderState):
(WebGPU::DeviceImpl::getComputeState):
(WebGPU::DeviceImpl::getBuffer):
(WebGPU::DeviceImpl::returnBuffer):
(WebGPU::DeviceImpl::getTexture):
(WebGPU::DeviceImpl::returnTexture):
(WebGPU::DeviceImpl::getSampler):
(WebGPU::DeviceImpl::returnSampler):
(WebGPU::DeviceImpl::~DeviceImpl):

  • WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.h: Added.

(WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::UniqueDebugReportCallbackEXT):
(WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::operator=):
(WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::~UniqueDebugReportCallbackEXT):
(WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::destroy):
(WebGPU::DeviceImpl::TextureParameters::operator== const):
(WebGPU::DeviceImpl::TextureParametersHash::operator() const):

  • WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.cpp: Added.

(WebGPU::HostAccessPassImpl::HostAccessPassImpl):
(WebGPU::HostAccessPassImpl::overwriteBuffer):
(WebGPU::HostAccessPassImpl::getBufferContents):
(WebGPU::HostAccessPassImpl::execute):

  • WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.h: Added.

(WebGPU::HostAccessPassImpl::getFinishedEvent const):

  • WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.cpp: Added.

(WebGPU::PassImpl::PassImpl):
(WebGPU::ResourceVisitor::operator()):
(WebGPU::ResourceVisitor::getBindings const):
(WebGPU::ResourceVisitor::releaseWriteDescriptorSets):
(WebGPU::ResourceVisitor::getDescriptorImageInfos const):
(WebGPU::ResourceVisitor::getDescriptorBufferInfos const):
(WebGPU::ResourceVisitor::getBuffers const):
(WebGPU::ResourceVisitor::getTextures const):
(WebGPU::ResourceVisitor::getSamplers const):
(WebGPU::ResourceVisitor::getImageCount const):
(WebGPU::ResourceVisitor::getSamplerCount const):
(WebGPU::ResourceVisitor::getUniformBufferCount const):
(WebGPU::ResourceVisitor::getStorageBufferCount const):
(WebGPU::PassImpl::setResources):
(WebGPU::PassImpl::insertBuffer):
(WebGPU::PassImpl::insertTexture):
(WebGPU::PassImpl::insertSampler):

  • WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.h: Added.

(WebGPU::PassImpl::getCommandBuffer const):
(WebGPU::PassImpl::iterateBuffers):
(WebGPU::PassImpl::iterateTextures):
(WebGPU::PassImpl::ResourceReference::ResourceReference):
(WebGPU::PassImpl::ResourceReference::~ResourceReference):
(WebGPU::PassImpl::ResourceReference::operator=):
(WebGPU::PassImpl::ResourceReference::operator== const):
(WebGPU::PassImpl::ResourceReference::get const):
(WebGPU::PassImpl::ResourceReference::release):
(WebGPU::PassImpl::ResourceReferenceHash::operator() const):

  • WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp: Added.

(WebGPU::QueueImpl::QueueImpl):
(WebGPU::QueueImpl::prepareCurrentFrame):
(WebGPU::QueueImpl::createSpecificRenderPass):
(WebGPU::QueueImpl::createFramebuffer):
(WebGPU::QueueImpl::createRenderPass):
(WebGPU::QueueImpl::commitRenderPass):
(WebGPU::QueueImpl::createComputePass):
(WebGPU::QueueImpl::commitComputePass):
(WebGPU::QueueImpl::createBlitPass):
(WebGPU::QueueImpl::commitBlitPass):
(WebGPU::QueueImpl::createHostAccessPass):
(WebGPU::QueueImpl::commitHostAccessPass):
(WebGPU::QueueImpl::present):
(WebGPU::QueueImpl::commitPass):
(WebGPU::QueueImpl::synchronizeResources):
(WebGPU::QueueImpl::~QueueImpl):

  • WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.h: Added.
  • WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.cpp: Added.

(WebGPU::RenderPassImpl::RenderPassImpl):
(WebGPU::RenderPassImpl::setRenderState):
(WebGPU::RenderPassImpl::setVertexAttributeBuffers):
(WebGPU::RenderPassImpl::setResources):
(WebGPU::RenderPassImpl::setViewport):
(WebGPU::RenderPassImpl::setScissorRect):
(WebGPU::RenderPassImpl::draw):

  • WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.h: Added.
  • WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.cpp: Added.

(WebGPU::RenderStateImpl::RenderStateImpl):

  • WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.h: Added.

(WebGPU::RenderStateImpl::getPipeline const):
(WebGPU::RenderStateImpl::getPipelineLayout const):
(WebGPU::RenderStateImpl::getDescriptorSetLayouts const):

  • WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.cpp: Added.

(WebGPU::SamplerImpl::SamplerImpl):
(WebGPU::SamplerImpl::decrementReferenceCount):

  • WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.h: Added.

(WebGPU::SamplerImpl::getSampler):
(WebGPU::SamplerImpl::incrementReferenceCount):
(WebGPU::SamplerImpl::getFilter):
(WebGPU::SamplerImpl::getMipmapMode):
(WebGPU::SamplerImpl::getAddressMode):

  • WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.cpp: Added.

(WebGPU::TextureImpl::TextureImpl):
(WebGPU::TextureImpl::decrementReferenceCount):

  • WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.h: Added.

(WebGPU::TextureImpl::getImage const):
(WebGPU::TextureImpl::getImageView const):
(WebGPU::TextureImpl::getFormat const):
(WebGPU::TextureImpl::incrementReferenceCount):
(WebGPU::TextureImpl::getWidth const):
(WebGPU::TextureImpl::getHeight const):
(WebGPU::TextureImpl::getTransferredToGPU const):
(WebGPU::TextureImpl::setTransferredToGPU):

  • WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj: Added.
  • WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj.filters: Added.
  • WebGPUAPIStructure/WebGPU.sln: Added.
4:32 PM Changeset in webkit [224064] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: Make "Style Attribute" text darker and non-focusable
​https://bugs.webkit.org/show_bug.cgi?id=178837

Reviewed by Brian Burg.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .selector.style-attribute):
Use the same shade of gray as in the "Inherited from" sections.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
Only editable selectors should be focusable.

4:30 PM Changeset in webkit [224063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Call setFullscreenClient on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=178089

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-26
Reviewed by Simon Fraser.

This was only being set for MacOS.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

4:28 PM Changeset in webkit [224062] by keith_miller@apple.com
  • 2 edits in trunk/Source/WebCore

[Payment Request] Restrict API use to secure, same-origin frames
​https://bugs.webkit.org/show_bug.cgi?id=178887

Patch by Andy Estes <​aestes@apple.com> on 2017-10-26
Reviewed by Tim Horton.

Reuse the access checks from Apple Pay to restrict PaymentRequest API usage to secure frames
in the same origin as the main frame.

Progresses active-document-cross-origin.https.sub.html and
active-document-same-origin.https.html from web-platform-tests. Regresses basic.https.html
since the allowpaymentrequest <iframe> attribute is not yet implemented.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::isSecure): Deleted.
(WebCore::canCallApplePaySessionAPIs): Deleted.

  • Modules/applepay/PaymentSession.cpp: Added.

(WebCore::isSecure):
(WebCore::PaymentSession::canCreateSession):

  • Modules/applepay/PaymentSession.h:
  • Modules/paymentrequest/PaymentHandler.cpp:

(WebCore::PaymentHandler::canCreateSession):

  • Modules/paymentrequest/PaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

  • WebCore.xcodeproj/project.pbxproj:
4:25 PM Changeset in webkit [224061] by aestes@apple.com
  • 11 edits
    1 add in trunk

[Payment Request] Restrict API use to secure, same-origin frames
​https://bugs.webkit.org/show_bug.cgi?id=178887

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

The allowpaymentrequest <iframe> attribute is not yet implemented, so the regression in basic.https.html is expected.

  • web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:

Source/WebCore:

Reuse the access checks from Apple Pay to restrict PaymentRequest API usage to secure frames
in the same origin as the main frame.

Progresses active-document-cross-origin.https.sub.html and
active-document-same-origin.https.html from web-platform-tests. Regresses basic.https.html
since the allowpaymentrequest <iframe> attribute is not yet implemented.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::isSecure): Deleted.
(WebCore::canCallApplePaySessionAPIs): Deleted.

  • Modules/applepay/PaymentSession.cpp: Added.

(WebCore::isSecure):
(WebCore::PaymentSession::canCreateSession):

  • Modules/applepay/PaymentSession.h:
  • Modules/paymentrequest/PaymentHandler.cpp:

(WebCore::PaymentHandler::canCreateSession):

  • Modules/paymentrequest/PaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

  • WebCore.xcodeproj/project.pbxproj:
4:07 PM Changeset in webkit [224060] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

3:57 PM Changeset in webkit [224059] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Add service worker handle fetch support for all subresource requests
​https://bugs.webkit.org/show_bug.cgi?id=178769

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/image-fetch.html

Moving DocumentThreadableLoader logic to CachedResourceLoader to apply it for all resource loads.
Setting the selected service worker identifier for subresource only at the moment.

Testing is limited to images, future wpt tests should cover other subresource cases.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::prepareFetch):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded):

  • loader/cache/CachedResourceRequest.h:

LayoutTests:

  • http/tests/workers/service/image-fetch-expected.txt: Added.
  • http/tests/workers/service/image-fetch.html: Added.
  • http/tests/workers/service/resources/image-fetch-worker.js: Added.

(event.event.request.url.indexOf):
(event.event.request.url.endsWith):

  • http/tests/workers/service/resources/image-fetch.js: Added.

(done):
(async.loadedImage):
(async.erroredImage):
(async.logStatus):
(async.test):

3:55 PM Changeset in webkit [224058] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.6

Tag Safari-604.4.6.

3:44 PM Changeset in webkit [224057] by eric.carlson@apple.com
  • 24 edits in trunk

NowPlayingInfo should contain a unique identifier
​https://bugs.webkit.org/show_bug.cgi?id=178872

Reviewed by Jer Noble.

Source/WebCore:

Updated TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm.

  • platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const): New.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::updateNowPlayingInfo): Ditto.

  • platform/audio/mac/MediaSessionManagerMac.h:
  • platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::updateNowPlayingInfo): Ditto. Don't leak CFString.

  • platform/mac/MediaRemoteSoftLink.cpp: Softlink kMRMediaRemoteNowPlayingInfoUniqueIdentifier.
  • platform/mac/MediaRemoteSoftLink.h:

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _requestActiveNowPlayingSessionInfo:]): Take a completion handler.
(-[WKWebView _requestActiveNowPlayingSessionInfo]): Deleted.
(-[WKWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestActiveNowPlayingSessionInfo): Ditto.
(WebKit::WebPageProxy::nowPlayingInfoCallback): Lookup and call completion handler.
(WebKit::WebPageProxy::handleActiveNowPlayingSessionInfoResponse const): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::handleActiveNowPlayingSessionInfoResponse): Deleted.

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::handleActiveNowPlayingSessionInfoResponse): Deleted.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::requestActiveNowPlayingSessionInfo): Take callback ID. Pass unique ID.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:

(-[NowPlayingTestWebView hasActiveNowPlayingSession]): Use completion handler.
(TestWebKitAPI::TEST): Cleanup tests. Use new API.
(-[NowPlayingTestWebView waitForNowPlayingInfoToChange]): Deleted.

3:42 PM Changeset in webkit [224056] by keith_miller@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, iOS build fix.

  • SourcesMac.txt:
  • WebCore.xcodeproj/project.pbxproj:
3:36 PM Changeset in webkit [224055] by mark.lam@apple.com
  • 8 edits
    1 add in trunk

JSRopeString::RopeBuilder::append() should check for overflows.
​https://bugs.webkit.org/show_bug.cgi?id=178385
<rdar://problem/35027468>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-178385.js: Added.

Source/JavaScriptCore:

  1. Made RopeString check for overflow like the Checked class does.
  2. Added a missing overflow check in objectProtoFuncToString().
  • runtime/JSString.cpp:

(JSC::JSRopeString::RopeBuilder<RecordOverflow>::expand):
(JSC::JSRopeString::RopeBuilder::expand): Deleted.

  • runtime/JSString.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/Operations.h:

(JSC::jsStringFromRegisterArray):
(JSC::jsStringFromArguments):

Source/WTF:

  • wtf/CheckedArithmetic.h:
3:25 PM Changeset in webkit [224054] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Move Mac specific files to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178883

Rubber-stamped by Tim Horton.

  • SourcesCocoa.txt:
  • SourcesMac.txt:
  • WebCore.xcodeproj/project.pbxproj:
3:02 PM Changeset in webkit [224053] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

DidMoveToNewDocumentAssertionScope shouldn't be necessary
​https://bugs.webkit.org/show_bug.cgi?id=178836
<rdar://problem/35008876>

Reviewed by Antti Koivisto.

DidMoveToNewDocumentAssertionScope was introduced in r217972 to replace an existing assertion to make sure
Node::didMoveToNewDocument is always called by its overrides in Node's subclasses. However, we can ensure
better Node::didMoveToNewDocument is always called if we called it directly in Node::moveTreeToNewScope.

Because only subclasses of Element and ShadowRoot override Node::didMoveToNewDocument and we already have
a specialized code path to adopt a ShadowRoot to a new document, this refactoring eliminates the need for
having a virtual function on Node at all.

Hence this patch names Node::didMoveToNewDocument to Node::moveToNewDocument and makes it non-virtual,
splits ShadowRoot::didMoveToNewDocument into moveShadowRootToNewParentScope and moveShadowRootToNewDocument,
and removes DidMoveToNewDocumentAssertionScope completely.

No new tests since there should be no behavioral change.

  • dom/Document.cpp:

(WebCore::Document::moveNodeIteratorsToNewDocumentSlowCase): Renamed from moveNodeIteratorsToNewDocument.

  • dom/Document.h:

(WebCore::Document::moveNodeIteratorsToNewDocument): Inlined the check for emptiness of m_nodeIterators to
avoid keep calling moveNodeIteratorsToNewDocumentSlowCase on every single node getting moved.

  • dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument): Removed the call to Node::didMoveToNewDocument since this is the
base virtual function now.

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::DidMoveToNewDocumentAssertionScope::DidMoveToNewDocumentAssertionScope): Deleted.
(WebCore::DidMoveToNewDocumentAssertionScope::~DidMoveToNewDocumentAssertionScope): Deleted.
(WebCore::DidMoveToNewDocumentAssertionScope::didRecieveCall): Deleted.
(WebCore::moveNodeToNewDocument): Deleted.
(WebCore::Node::moveShadowTreeToNewDocument): Made this a member function of Node since it needs to call
moveNodeToNewDocument, which is private to Node.
(WebCore::Node::moveTreeToNewScope): Removed the release assert for the root node since the same check
exists inside traverseSubtreeToUpdateTreeScope. Also removed the release assertion for checking that
node's old document matches the old document since document() simply calls treeScope().documentScope()
and we're already release-asserting that the old scope of a node matches the old scope we know of.
We release-assert that the old tree scope's document didn't change after the traversal instead. Finally,
replaced a bunch of RELEASE_ASSERT with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION.
(WebCore::Node::moveNodeToNewDocument): Renamed from didMoveToNewDocument. Moved the code related to
mutation observers inside hasRareData() check, and moved the the code to move event listeners inside
eventTargetData() check both for clarity, and avoid doing the work for every single node being moved.
Finally, call the old didMoveToNewDocument when "this" is an Element.

  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::moveShadowRootToNewParentScope): Added. Extracted from didMoveToNewDocument.
(WebCore::ShadowRoot::moveShadowRootToNewDocument): Renamed from didMoveToNewDocument. We now
release-assert that parent tree scope's document matches the new document if any.

  • dom/ShadowRoot.h:
3:00 PM Changeset in webkit [224052] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=178828

Reviewed by Wenson Hsieh.

When the pasted content's iframe's body isn't available, wait for load event.

  • http/tests/security/clipboard/resources/content-to-copy.html: Always wait for load event before notifying

the parent page that it had finish loading.

  • http/tests/security/clipboard/resources/subdirectory/paste-html.html:
2:41 PM Changeset in webkit [224051] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Implement ServiceWorkerContainer getRegistration
​https://bugs.webkit.org/show_bug.cgi?id=178882

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26
Reviewed by Chris Dumez.

Replace rejection promise by resolving the promise with a null value.
This helps in running WPT tests as WPT tests usually check for registered service workers before running tests.
For WTR, there should be no registered service worker anyway.

  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::getRegistration):

  • workers/service/ServiceWorkerContainer.h:
2:36 PM Changeset in webkit [224050] by mmaxfield@apple.com
  • 4 edits in trunk/LayoutTests

[iOS] Update expected results for platform/ios/ios/fast/text/opticalFontWith*.html
​https://bugs.webkit.org/show_bug.cgi?id=178885

Unreviewed.

  • platform/ios/TestExpectations:
  • platform/ios/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
  • platform/ios/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt:
2:24 PM Changeset in webkit [224049] by mmaxfield@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

[iOS] Update expected results for fast/text/international/complex-character-based-fallback.html
​https://bugs.webkit.org/show_bug.cgi?id=178884
<rdar://problem/33602192>

Unreviewed.

Test gardening.

  • platform/ios/TestExpectations:
  • platform/ios/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/ios/fast/text/international/complex-character-based-fallback-expected.txt:
2:07 PM Changeset in webkit [224048] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Account for Mail’s WebMessageDocument class being renamed
​https://bugs.webkit.org/show_bug.cgi?id=178881

Reviewed by Sam Weinig.

  • editing/cocoa/HTMLConverter.mm:

(_WebMessageDocumentClass): Look up the class by its new name. No longer look it up by the

old old name, because TOT WebKit isn’t going to be used by versions of Mail that have that name.

1:57 PM Changeset in webkit [224047] by Adrian Perez de Castro
  • 3 edits
    1 add in trunk

[WPE] Use proper shared object versioning for libWPEWebKit.so
​https://bugs.webkit.org/show_bug.cgi?id=178878

Reviewed by Michael Catanzaro.

Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
unify setting the PROJECT_VERSION* family of variables.

  • Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
  • Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,

using the common macros from VersioningUtils.cmake.

  • Source/cmake/VersioningUtils.cmake: Added.
1:45 PM Changeset in webkit [224046] by jmarcell@apple.com
  • 8 edits
    1 delete in tags/Safari-605.1.12

Revert r223691. rdar://problem/35205048

1:22 PM Changeset in webkit [224045] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove FrameView::serviceScriptedAnimations and Document::serviceScriptedAnimations
​https://bugs.webkit.org/show_bug.cgi?id=178879

Patch by Antoine Quint <Antoine Quint> on 2017-10-26
Reviewed by Dean Jackson.

There are no call sites for FrameView::serviceScriptedAnimations() and that method is the
only call site for Document::serviceScriptedAnimations(), so both can go.

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations): Deleted.

  • dom/Document.h:
  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations): Deleted.

  • page/FrameView.h:
1:22 PM Changeset in webkit [224044] by Ryan Haddad
  • 2 edits in trunk/Tools

[MediaStream] Clear cached gUM prompt state
​https://bugs.webkit.org/show_bug.cgi?id=178754
<rdar://problem/32742356>

Unreviewed, fix a flakey test.

Patch by Eric Carlson <​eric.carlson@apple.com> on 2017-10-26

  • TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:

(-[GetUserMediaRepromptTestView haveStream:]): New, check several times for expected state.
(TestWebKitAPI::TEST): Don't assume stream state changes in the page immediately.

1:20 PM Changeset in webkit [224043] by aestes@apple.com
  • 7 edits in trunk

[Payment Request] Enable Payment Request whenever Apple Pay is enabled
​https://bugs.webkit.org/show_bug.cgi?id=178880

Reviewed by Tim Horton.

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPaymentRequestEnabled): Deleted.
(WKPreferencesGetPaymentRequestEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

1:17 PM Changeset in webkit [224042] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

http/tests/workers/service/service-worker-cache-api.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=178877

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26
Reviewed by Alex Christensen.

Marking test as PASS/FAIL.
Changing test to finish after 10 seconds.
Beefing up logging to help identifiying flakiness reason.

  • TestExpectations:
  • http/tests/workers/service/resources/service-worker-cache-api-worker.js:

(event.event.respondWith.promise.then):

  • http/tests/workers/service/resources/service-worker-cache-api.js:

(async.test):

  • http/tests/workers/service/service-worker-cache-api.https-expected.txt:
1:14 PM Changeset in webkit [224041] by Chris Dumez
  • 10 edits
    2 copies
    3 moves in trunk/Source

Bring back SWContextManager abstraction in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=178876

Reviewed by Geoffrey Garen.

Bring back SWContextManager abstraction in WebCore. It was killed in <​https://trac.webkit.org/changeset/223718> but
is actually useful when the ServiceWorker wants to message the storage process.

Source/WebCore:

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/context/SWContextManager.cpp: Added.

(WebCore::SWContextManager::singleton):
(WebCore::SWContextManager::setConnection):
(WebCore::SWContextManager::connection const):
(WebCore::SWContextManager::registerServiceWorkerThread):
(WebCore::SWContextManager::serviceWorkerThreadProxy const):
(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):

  • workers/service/context/SWContextManager.h: Copied from Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.h.

(WebCore::SWContextManager::Connection::~Connection):

Source/WebKit:

  • CMakeLists.txt:
  • DerivedSources.make:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startServiceWorkerContext):
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp: Renamed from Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.cpp.

(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
(WebKit::WebSWContextManagerConnection::updatePreferences):
(WebKit::WebSWContextManagerConnection::startServiceWorker):
(WebKit::WebSWContextManagerConnection::startFetch):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):

  • WebProcess/Storage/WebSWContextManagerConnection.h: Renamed from Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.h.
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in: Renamed from Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.messages.in.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::getWorkerContextConnection):

  • WebProcess/WebProcess.h:
1:13 PM Changeset in webkit [224040] by Simon Fraser
  • 2 edits in trunk/Source/WebKitLegacy/mac

Fix issues with WebView subframe painting
​https://bugs.webkit.org/show_bug.cgi?id=178842
rdar://problem/34072253

Reviewed by Daniel Bates.

WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
High Sierra, so match the new signature.

Also rename the 'rect' param to 'displayRect' to match AppKit code.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.

12:33 PM Changeset in webkit [224039] by jmarcell@apple.com
  • 6 edits
    6 adds in branches/safari-604-branch

Cherry-pick r223974. rdar://problem/35178887

12:19 PM Changeset in webkit [224038] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Add and update some watchlists
​https://bugs.webkit.org/show_bug.cgi?id=178304

Reviewed by Simon Fraser.

  • Scripts/webkitpy/common/config/watchlist:
11:58 AM Changeset in webkit [224037] by commit-queue@webkit.org
  • 8 edits
    3 moves
    1 add in trunk/Source/WebCore

[Curl] Rename CurlJobManager to CurlRequestScheduler
​https://bugs.webkit.org/show_bug.cgi?id=178775

To match the meaning of the class.
It was originally meant to be more generic purpose, but as
other classes was introduced, the objective of the class is
now only to handle the life cycle of curl requests.

The delegate is also renamed to CurlRequestSchedulerClient.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-26
Reviewed by Alex Christensen.

  • platform/Curl.cmake:
  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::~CurlDownload):
(WebCore::CurlDownload::willSendRequest):

  • platform/network/curl/CurlDownload.h:
  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::CurlRequest):
(WebCore::CurlRequest::start):
(WebCore::CurlRequest::startWithJobManager):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::callClient):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::pausedStatusChanged):
(WebCore::CurlRequest::callDelegate): Deleted.

  • platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::create):
(WebCore::CurlRequest::setClient):
(WebCore::CurlRequest::setDelegate): Deleted.

  • platform/network/curl/CurlRequestClient.h: Renamed from Source/WebCore/platform/network/curl/CurlRequestDelegate.h.
  • platform/network/curl/CurlRequestScheduler.cpp: Renamed from Source/WebCore/platform/network/curl/CurlJobManager.cpp.

(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlRequestScheduler::singleton):
(WebCore::CurlRequestScheduler::add):
(WebCore::CurlRequestScheduler::cancel):
(WebCore::CurlRequestScheduler::callOnWorkerThread):
(WebCore::CurlRequestScheduler::startThreadIfNeeded):
(WebCore::CurlRequestScheduler::stopThreadIfNoMoreJobRunning):
(WebCore::CurlRequestScheduler::stopThread):
(WebCore::CurlRequestScheduler::updateJobList):
(WebCore::CurlRequestScheduler::workerThread):

  • platform/network/curl/CurlRequestScheduler.h: Renamed from Source/WebCore/platform/network/curl/CurlJobManager.h.

(WebCore::CurlRequestScheduler::~CurlRequestScheduler):

  • platform/network/curl/CurlRequestSchedulerClient.h: Added.

(WebCore::CurlRequestSchedulerClient::~CurlRequestSchedulerClient):

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::continueAfterWillSendRequest):

  • platform/network/curl/ResourceHandleCurlDelegate.h:
11:56 AM Changeset in webkit [224036] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked webrtc/video-mute.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=177501

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
11:54 AM Changeset in webkit [224035] by ap@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit

Remove deprecated WebKit symbols
​https://bugs.webkit.org/show_bug.cgi?id=178875
rdar://problem/31139070

Reviewed by Dan Bernstein.

  • PlatformMac.cmake:
  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKContextSetProcessModel):
(WKPageGroupCopyIdentifier): Deleted.
(WKPageGroupAddUserContentFilter): Deleted.
(WKPageGroupRemoveUserContentFilter): Deleted.

  • UIProcess/API/C/WKPageGroup.h:
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Removed.
  • UIProcess/API/Cocoa/_WKVisitedLinkStore.h:
  • WebKit.xcodeproj/project.pbxproj:
11:51 AM Changeset in webkit [224034] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Remove unnecessary whitespace invalidation logic from RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=178786

Reviewed by Zalan Bujtas.

RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded is a somewhat complex
and confusing function for figuring out if some whitespace-only text node might need to have its
rendering status recomputed. However actually computing if a text renderer is needed is not expensive.
We can simply do it for all whitespace nodes after a sibling mutation.

This also removes a set that could have stale renderer pointers in it (they were never dereferenced).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringContinuation):

Fix a display:contents bug exposed by this change. With display:contents a text renderer may have an anonymous
inline wrapper and we need to take it into account when the text renderer is the beforeChild.

Tested by imported/w3c/web-platform-tests/css/css-display-3/display-contents-state-change-001.html

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):

Call updateTextRenderer() for all whitespace-only text nodes after a change in siblings.
In normal update case it just figures out quickly (by calling textRendererIsNeeded)
that there are no changes and bails out.

(WebCore::RenderTreeUpdater::updateElementRenderer):
(WebCore::RenderTreeUpdater::updateTextRenderer):
(WebCore::RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded): Deleted.

No longer needed. Just mark that there have been changes to siblings instead.

  • style/RenderTreeUpdater.h:
11:46 AM Changeset in webkit [224033] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Mark font palettes as in development
​https://bugs.webkit.org/show_bug.cgi?id=178590

Unreviewed.

  • features.json:
11:44 AM Changeset in webkit [224032] by Ryan Haddad
  • 16 edits
    1 move
    3 deletes in trunk

Unreviewed, rolling out r223984.

Caused LayoutTest assertion failures.

Reverted changeset:

"When navigating back to a page, compositing layers may not
use accelerated drawing"
​https://bugs.webkit.org/show_bug.cgi?id=178749
​https://trac.webkit.org/changeset/223984

11:41 AM Changeset in webkit [224031] by achristensen@apple.com
  • 11 edits in trunk/LayoutTests

Rebase contentextensions test expectations
​https://bugs.webkit.org/show_bug.cgi?id=178841

Reviewed by Alexey Proskuryakov.

They've been marked as flaky for so long that nobody has rebased them. The URLParser
has changed underneath them, DOM error reporting has changed, etc. The first step to
gaining this test coverage back again is rebasing.

  • http/tests/contentextensions/block-everything-if-domain-expected.txt:
  • http/tests/contentextensions/block-everything-unless-domain-redirect-expected.txt:
  • http/tests/contentextensions/character-set-basic-support-expected.txt:
  • http/tests/contentextensions/main-resource-expected.txt:
  • http/tests/contentextensions/main-resource-redirect-blocked-expected.txt:
  • http/tests/contentextensions/main-resource-redirect-error-expected.txt:
  • http/tests/contentextensions/make-https-expected.txt:
  • http/tests/contentextensions/plugin-doesnt-crash-expected.txt:
  • http/tests/contentextensions/sync-xhr-blocked-expected.txt:
  • http/tests/contentextensions/text-track-blocked-expected.txt:
11:38 AM Changeset in webkit [224030] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add inspector logging for MediaElementSession autoplay
​https://bugs.webkit.org/show_bug.cgi?id=178846

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-26
Reviewed by Eric Carlson.

No change of behavior.
Making use of pal Logger in MediaElementSession.
This new logging is limited to autoplay/playback for now.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::MediaElementSession):
(WebCore::MediaElementSession::playbackPermitted const):
(WebCore::MediaElementSession::autoplayPermitted const):
(WebCore::MediaElementSession::willLog const):
(WebCore::MediaElementSession::logChannel const):

  • html/MediaElementSession.h:
11:20 AM Changeset in webkit [224029] by Megan Gardner
  • 13 edits in trunk/Source/WebKit

Remove code to update block selection
​https://bugs.webkit.org/show_bug.cgi?id=178843

Reviewed by Tim Horton.

Removes code for updating block selection, which has been disabled.
This code is being slowly pruned to avoid regressions and accidental removal of code that is being used.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didUpdateBlockSelectionWithTouch): Deleted.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(toSelectionHandlePosition): Deleted.
(-[WKContentView _didUpdateBlockSelectionWithTouch:withFlags:growThreshold:shrinkThreshold:]): Deleted.
(-[WKContentView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateBlockSelectionWithTouch): Deleted.
(WebKit::WebPageProxy::didUpdateBlockSelectionWithTouch): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::shouldExpand): Deleted.
(WebKit::WebPage::changeBlockSelection): Deleted.
(WebKit::WebPage::updateBlockSelectionWithTouch): Deleted.

11:16 AM Changeset in webkit [224028] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Skipped webrtc/video-replace-muted-track.html on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=173608

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
11:11 AM Changeset in webkit [224027] by keith_miller@apple.com
  • 3 edits in trunk/Source/WebCore

Move ApplePay to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178871

Rubber-stamped by Tim Horton.

Also, add some other missing files.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
10:59 AM Changeset in webkit [224026] by Adrian Perez de Castro
  • 2 edits in trunk

[GTK] WebKit library .so version is not being set correctly
​https://bugs.webkit.org/show_bug.cgi?id=178873

Reviewed by Michael Catanzaro.

  • Source/cmake/OptionsGTK.cmake: Adjust name of the target for which the .so version gets calculated.
10:45 AM Changeset in webkit [224025] by Ryan Haddad
  • 8 edits
    6 deletes in trunk

Unreviewed, rolling out r224019.

This change caused API test WebKit.MSEIsPlayingAudio to time
out.

Reverted changeset:

"XMLHttpRequest should not treat file URLs as same origin"
​https://bugs.webkit.org/show_bug.cgi?id=178565
​https://trac.webkit.org/changeset/224019

10:26 AM Changeset in webkit [224024] by Ryan Haddad
  • 8 edits
    4 deletes in trunk

Unreviewed, rolling out r223994.

The LayoutTest for this change is failing.

Reverted changeset:

"Add service worker handle fetch support for all subresource
requests"
​https://bugs.webkit.org/show_bug.cgi?id=178769
​https://trac.webkit.org/changeset/223994

10:18 AM Changeset in webkit [224023] by Ryan Haddad
  • 20 edits
    1 delete in trunk/Source

Unreviewed, rolling out r223908.

Causes LayoutTest crashes with newer SDKs.

Reverted changeset:

"Adopt new secure coding APIs"
​https://bugs.webkit.org/show_bug.cgi?id=178484
​https://trac.webkit.org/changeset/223908

9:41 AM Changeset in webkit [224022] by Ryan Haddad
  • 2 edits in trunk/JSTests

Unreviewed, rolling out r223961.

The change that required this has been rolled out.

Reverted changeset:

"Mark test262.yaml/test262/test/language/statements/try/tco-
catch.js as passing."
​https://bugs.webkit.org/show_bug.cgi?id=178592
​https://trac.webkit.org/changeset/223961

9:32 AM Changeset in webkit [224021] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for compositing/tiling/non-active-window-tiles-size.html.
​https://bugs.webkit.org/show_bug.cgi?id=171763

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Remove Debug-only flag.
9:13 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
9:12 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
9:11 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
9:01 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
8:56 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
8:49 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
8:33 AM Changeset in webkit [224020] by jfbastien@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

WebAssembly: no VM / JS version of our implementation
​https://bugs.webkit.org/show_bug.cgi?id=177472

Reviewed by Michael Saboff.

This patch removes all appearances of "JS" and "VM" in the wasm
directory. These now only appear in the wasm/js directory, which
is only used in a JS embedding of wasm. It should therefore now be
possible to create non-JS embeddings of wasm through JSC, though
it'll still require:

  • Mild codegen for wasm<->embedder calls;
  • A strategy for trap handling (no need for full unwind! Could kill).
  • Creation of the Wasm::* objects.
  • Calling convention handling to call the embedder.
  • Handling of multiple embedders (see #177475, this is optional).

Most of the patch consists in renaming JSWebAssemblyInstance to
Instance, and removing temporary copies which I'd added to make
this specific patch very simple.

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::wasmAwareLexicalGlobalObject): this one place
which needs to know about who "owns" the Wasm::Instance. In a JS
embedding it's the JSWebAssemblyInstance.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::addGrowMemory):
(JSC::Wasm::B3IRGenerator::addCurrentMemory):
(JSC::Wasm::B3IRGenerator::getGlobal):
(JSC::Wasm::B3IRGenerator::setGlobal):
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):

  • wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

  • wasm/WasmContext.cpp:

(JSC::Wasm::Context::load const):
(JSC::Wasm::Context::store):

  • wasm/WasmContext.h:
  • wasm/WasmEmbedder.h:
  • wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::create):
(JSC::Wasm::Instance::extraMemoryAllocated const):

  • wasm/WasmInstance.h: add an "owner", the Wasm::Context, move the

"tail" import information from JSWebAssemblyInstance over to here.
(JSC::Wasm::Instance::finalizeCreation):
(JSC::Wasm::Instance::owner const):
(JSC::Wasm::Instance::offsetOfOwner):
(JSC::Wasm::Instance::context const):
(JSC::Wasm::Instance::setMemory):
(JSC::Wasm::Instance::setTable):
(JSC::Wasm::Instance::offsetOfMemory):
(JSC::Wasm::Instance::offsetOfGlobals):
(JSC::Wasm::Instance::offsetOfTable):
(JSC::Wasm::Instance::offsetOfTail):
(JSC::Wasm::Instance::numImportFunctions const):
(JSC::Wasm::Instance::importFunctionInfo):
(JSC::Wasm::Instance::offsetOfTargetInstance):
(JSC::Wasm::Instance::offsetOfWasmEntrypoint):
(JSC::Wasm::Instance::offsetOfWasmToEmbedderStubExecutableAddress):
(JSC::Wasm::Instance::offsetOfImportFunction):
(JSC::Wasm::Instance::importFunction):
(JSC::Wasm::Instance::allocationSize):
(JSC::Wasm::Instance::create): Deleted.

  • wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::runForIndex):

  • wasm/WasmOMGPlan.h:
  • wasm/WasmTable.cpp:

(JSC::Wasm::Table::Table):
(JSC::Wasm::Table::setFunction):

  • wasm/WasmTable.h:
  • wasm/WasmThunks.cpp:

(JSC::Wasm::throwExceptionFromWasmThunkGenerator):
(JSC::Wasm::triggerOMGTierUpThunkGenerator):

  • wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

  • wasm/js/JSWebAssemblyInstance.cpp: delete code that is now on Wasm::Instance

(JSC::JSWebAssemblyInstance::JSWebAssemblyInstance): The embedder
decides what the import function is. Here we must properly
placement-new it to what we've elected (and initialize it later).
(JSC::JSWebAssemblyInstance::visitChildren):
(JSC::JSWebAssemblyInstance::finalizeCreation):
(JSC::JSWebAssemblyInstance::create):

  • wasm/js/JSWebAssemblyInstance.h: delete code that is now on Wasm::Instance

(JSC::JSWebAssemblyInstance::instance):
(JSC::JSWebAssemblyInstance::moduleNamespaceObject):
(JSC::JSWebAssemblyInstance::setMemory):
(JSC::JSWebAssemblyInstance::table):
(JSC::JSWebAssemblyInstance::setTable):
(JSC::JSWebAssemblyInstance::offsetOfInstance):
(JSC::JSWebAssemblyInstance::offsetOfCallee):
(JSC::JSWebAssemblyInstance::context const): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfTail): Deleted.
(): Deleted.
(JSC::JSWebAssemblyInstance::importFunctionInfo): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfTargetInstance): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfWasmEntrypoint): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfWasmToEmbedderStubExecutableAddress): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfImportFunction): Deleted.
(JSC::JSWebAssemblyInstance::importFunction): Deleted.
(JSC::JSWebAssemblyInstance::internalMemory): Deleted.
(JSC::JSWebAssemblyInstance::wasmCodeBlock const): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfWasmTable): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfGlobals): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfCodeBlock): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfWasmCodeBlock): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfCachedStackLimit): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfWasmMemory): Deleted.
(JSC::JSWebAssemblyInstance::offsetOfTopEntryFramePointer): Deleted.
(JSC::JSWebAssemblyInstance::cachedStackLimit const): Deleted.
(JSC::JSWebAssemblyInstance::setCachedStackLimit): Deleted.
(JSC::JSWebAssemblyInstance::wasmMemory): Deleted.
(JSC::JSWebAssemblyInstance::wasmModule): Deleted.
(JSC::JSWebAssemblyInstance::allocationSize): Deleted.

  • wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::setFunction):

  • wasm/js/WasmToJS.cpp: One extra indirection to find the JSWebAssemblyInstance.

(JSC::Wasm::materializeImportJSCell):
(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):
(JSC::Wasm::wasmToJSException):

  • wasm/js/WasmToJS.h:
  • wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

  • wasm/js/WebAssemblyPrototype.cpp:

(JSC::instantiate):

  • wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::create):

8:14 AM Changeset in webkit [224019] by Brent Fulgham
  • 8 edits
    6 adds in trunk

XMLHttpRequest should not treat file URLs as same origin
​https://bugs.webkit.org/show_bug.cgi?id=178565
<rdar://problem/11115901>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not treat file URLs as same-origin for XHR requests.

Test: fast/xmlhttprequest/xmlhttprequest-access-self-as-file.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Use new helper method.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::requestIsSameOrigin): New method to recognize same-origin
requests, with special handling for XHR.

  • page/SecurityOrigin.h:

LayoutTests:

  • fast/xmlhttprequest/resources/xmlhttprequest-access-self-as-file-real.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-access-self-as-file.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-access-self-as-file-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-access-self-as-blob-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-access-self-as-blob.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Rebaseline test now that we reject XHR to local file URLs.
  • platform/ios/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Rebaselined.
  • platform/wk2/TestExpectations: Skip test since 'beginDragWithFiles' is not supported in WKTR.
7:06 AM Changeset in webkit [224018] by commit-queue@webkit.org
  • 13 edits
    1 delete in trunk

Remove scopeguard from platform
​https://bugs.webkit.org/show_bug.cgi?id=178681

Patch by Christopher Reid <​chris.reid@sony.com> on 2017-10-26
Reviewed by Brady Eidson.

Source/WebCore:

Replacing platform/ScopeGuard with WTF::ScopeExit.
No new tests, no change in behavior.

  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FileSystem.cpp:
  • platform/ScopeGuard.h: Removed.
  • platform/network/BlobRegistryImpl.cpp:
  • workers/service/ServiceWorkerContainer.cpp:

Source/WebKit:

  • Shared/mac/ChildProcessMac.mm:

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
6:14 AM Changeset in webkit [224017] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

[GTK][Stable] Crash on WebCore::SharedBuffer::data() on 2.18.1
​https://bugs.webkit.org/show_bug.cgi?id=178852

Reviewed by Carlos Garcia Campos.

Add a mutex to control that the image decoders are not used at the same
time from the main thread and the decoding thread.

Backport of the fix to ​https://bugs.webkit.org/show_bug.cgi?id=178510
created by Fujii Hironori <Fujii Hironori>.

Covered by existent tests.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameIsCompleteAtIndex):
(WebCore::ImageDecoder::frameHasAlphaAtIndex const):
(WebCore::ImageDecoder::frameBytesAtIndex const):
(WebCore::ImageDecoder::frameDurationAtIndex):
(WebCore::ImageDecoder::createFrameImageAtIndex):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::setData):

5:50 AM Changeset in webkit [224016] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r224015 - REGRESSION(r222090): [HarfBuzz] Arabic shaping is broken except for first word in line
​https://bugs.webkit.org/show_bug.cgi?id=178625

Reviewed by Michael Catanzaro.

Source/WebCore:

Once we find the first space, which has the COMMON script, we split the run, and the next ones keep using
COMMON instead of ARABIC because we don't update the current script on every loop iteration. This patch
simplifies the script handling by moving the code back to the loop and always breaking in case of different
scripts, correctly handling INHERITED and COMMON cases and updating the current script when needed.

Covered by existing tests. This improves several tests that have been rebaselined.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::findNextRun):
(WebCore::scriptsAreCompatibleForCharacters): Deleted.

5:34 AM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
5:03 AM Changeset in webkit [224015] by Carlos Garcia Campos
  • 19 edits in trunk

REGRESSION(r222090): [HarfBuzz] Arabic shaping is broken except for first word in line
​https://bugs.webkit.org/show_bug.cgi?id=178625

Reviewed by Michael Catanzaro.

Source/WebCore:

Once we find the first space, which has the COMMON script, we split the run, and the next ones keep using
COMMON instead of ARABIC because we don't update the current script on every loop iteration. This patch
simplifies the script handling by moving the code back to the loop and always breaking in case of different
scripts, correctly handling INHERITED and COMMON cases and updating the current script when needed.

Covered by existing tests. This improves several tests that have been rebaselined.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::findNextRun):
(WebCore::scriptsAreCompatibleForCharacters): Deleted.

LayoutTests:

Rebaseline several tests that have been improved.

  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/gtk/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/gtk/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.png:
  • platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt:
3:58 AM Changeset in webkit [224014] by Carlos Garcia Campos
  • 3 edits
    315 adds in trunk

WebDriver: Add support to import and run W3C tests
​https://bugs.webkit.org/show_bug.cgi?id=177304

Reviewed by Brian Burg.

Tools:

WPT has now several WebDriver tests, and new ones are going to be added to cover the whole spec. This patch
adds the initial support for running W3C tests. The script import-w3c-webdriver-tests reuses parts of the W3C
test downloader to download the tests and required tools from WPT repository into WebDriverTests
directory. Tests can be run with run-webdriver-tests, a new script that works similar to other test runner
scripts. For now it shows a summary at the end of the execution, there aren't expectations yet, since we are not
ready to run those tests in the bots. Once we are ready to properly run the tests, we can add the expectations
support and run the tests in the bots.

  • Scripts/import-w3c-webdriver-tests: Added.
  • Scripts/run-webdriver-tests: Added.
  • Scripts/webkitpy/style/checker.py: Skip WebDriverTests directory since it only contains third-party python

code.

  • Scripts/webkitpy/thirdparty/init.py: Add support to autodownload mozlog and mozprocess since they are

required by the WebDriver tests.

  • Scripts/webkitpy/webdriver_tests/init.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_driver.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_test_result.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Added.
  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py: Added.

WebDriverTests:

Add json file used by the importer and the result of running the importer.

  • imported/w3c/importer.json: Added.
  • imported/w3c/tools/pytest/: Added.
  • imported/w3c/tools/webdriver/: Added.
  • imported/w3c/tools/wptrunner/: Added.
  • imported/w3c/webdriver/: Added.
3:44 AM Changeset in webkit [224013] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add CanvasOverview.svg and Canvas.svg
​https://bugs.webkit.org/show_bug.cgi?id=178426

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-26
Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/Canvas.svg: Added.
  • UserInterface/Images/gtk/CanvasOverview.svg: Added.
3:31 AM Changeset in webkit [224012] by eocanha@igalia.com
  • 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Fix hang on clearing/destroying AppendPipeline
​https://bugs.webkit.org/show_bug.cgi?id=178819

Reviewed by Xabier Rodriguez-Calvar.

The deadlock may occur when UI thread tries to clear pipeline in
AppendPipeline::clearPlayerPrivate() while parser thread tries to change
pipeline state to pause holding the stream lock in
AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread()

This patch is authored by Eugene Mutavchi <​Ievgen_Mutavchi@comcast.com>

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
Return if there's no player private.

1:46 AM Changeset in webkit [224011] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Assert that no script is executed during style recalc
​https://bugs.webkit.org/show_bug.cgi?id=178845
<rdar://problem/35106129>

Reviewed by Antti Koivisto.

This patch adds NoEventDispatchAssertion to Document::updateStyle and Document::updateStyleIfNeeded
to make sure we don't start mutating DOM in the middle of a style update.

Added NoEventDispatchAssertion::EventAllowedScope for various places in SVGUseElement to update its
shadow tree since that happens while updating the style.

No new tests since there should be no behavioral change.

  • dom/Document.cpp:

(WebCore::Document::resolveStyle): Added NoEventDispatchAssertion while flushing pending stylesheets
and calling FrameView::willRecalcStyle, and while the style tree solver is in works. Also moved in
the code to update the selection and schedule to dispatch a fake mouse event into the same scope.
Also increment m_styleRecalcCount in the same code since post resolution callbacks could run author
scripts which in turn trigger another (recursive) style recalc.
(WebCore::Document::updateStyleIfNeeded): Put everything but the call to resolveStyle in a scope with
NoEventDispatchAssertion.

  • dom/Element.cpp:

(WebCore::Element::cloneElementWithChildren): Added NoEventDispatchAssertion::EventAllowedScope to the
newly cloned element for SVG use element's shadow tree.
(WebCore::Element::cloneElementWithoutChildren): Ditto.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Make the assertion more precise to workaround the fact SVG
use elements update its shadow tree in the middle of style updates. Also removed a redundant assertion
since the result of NoEventDispatchAssertion::isEventDispatchAllowedInSubtree cannot chance without
pushing or popoing the stack frame.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearShadowTree):
(WebCore::SVGUseElement::updateShadowTree): Added NoEventDispatchAssertion to the user-agent shadow root
of a SVG use element. Since this is a newly created shadow tree which hasn't been exposed to author
scripts, it's safe to mutate them during the style recalc even though it's not the best design.
(WebCore::SVGUseElement::cloneTarget const): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree const):

12:10 AM Changeset in webkit [224010] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTest http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=178828

Reviewed by Wenson Hsieh.

Removed the superflous call to finishJSTest after 3s.

  • http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html:
12:07 AM Changeset in webkit [224009] by keith_miller@apple.com
  • 3 edits in trunk/Source/WebCore

Move platform Cocoa sources to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178851

Rubber-stamped by Tim Horton.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:

Oct 25, 2017:

11:21 PM Changeset in webkit [224008] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Start moving Cocoa specific unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178850

Rubber-stamped by Tim Horton.

  • PlatformMac.cmake:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
11:03 PM Changeset in webkit [224007] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
​https://bugs.webkit.org/show_bug.cgi?id=178788

Reviewed by Michael Catanzaro.

Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character
indexes will be swapped in m_coreTextIndices.

  • platform/graphics/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create): Remove the ltr parameter.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isLTR using hb_buffer_get_direction().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Do not pass ltr to ComplexTextRun::create().

10:23 PM Changeset in webkit [224006] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Move remaining platform independent sources to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178849

Rubber-stamped by Tim Horton.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
9:57 PM Changeset in webkit [224005] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Move plugins and rendering to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178848

Rubber-stamped by Tim Horton.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
9:27 PM Changeset in webkit [224004] by keith_miller@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, add FEMorphology.cpp back to the regular build after r224003.

  • WebCore.xcodeproj/project.pbxproj:
9:24 PM Changeset in webkit [224003] by keith_miller@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, Windows build fix.

  • Sources.txt:
9:07 PM Changeset in webkit [224002] by webkit@devinrousso.com
  • 16 edits
    2 adds in trunk

Web Inspector: provide a way to enable/disable event listeners
​https://bugs.webkit.org/show_bug.cgi?id=177451
<rdar://problem/34994925>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Add setEventListenerDisabled command that enables/disables a specific event listener
during event dispatch. When a disabled event listener is fired, the listener's callback will
not be called.

Source/WebCore:

Test: inspector/dom/setEventListenerDisabled.html

  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):
Add InspectorInstrumentation call to isEventListenerDisabled. If true, the event listener's
callback will not be called.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setEventListenerDisabled):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::willRemoveEventListener):
(WebCore::InspectorDOMAgent::isEventListenerDisabled):
Introduce a mapping of EventListener* to InspectorEventListener, a struct for uniquely
identifying event listeners so they can be referenced from the frontend. We only add items
to this mapping when getEventListenersForNode is called, as that is when EventListener
data is sent to the frontend. This allows us to defer creating an Inspector "mirror" object
for each EventListener until it is needed. Items are removed whenever an event listener is
removed or when the document changes.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::isEventListenerDisabled):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willRemoveEventListenerImpl):
(WebCore::InspectorInstrumentation::isEventListenerDisabledImpl):
Pass additional parameters to InspectorDOMAgent so it can determine if the event listener
actually exists. If not, don't dispatch an event to the frontend as nothing will change.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/DOMTreeManager.js:

(WI.DOMTreeManager.prototype.setEventListenerDisabled):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.attached):
(WI.DOMNodeDetailsSidebarPanel.prototype.detached):
(WI.DOMNodeDetailsSidebarPanel.prototype._eventListenersChanged):
(WI.DOMNodeDetailsSidebarPanel.prototype.addEventListeners): Deleted.
(WI.DOMNodeDetailsSidebarPanel.prototype.removeEventListeners): Deleted.
Listen for WI.DOMNode.Event.EventListenersChanged on all instances of WI.DOMNode, since we
will still want to refresh the event listeners section in the event that an event listener
is removed from a parent node.

  • UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):
(WI.EventListenerSectionGroup.prototype._eventText):
(WI.EventListenerSectionGroup.prototype._nodeTextOrLink):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement.updateTitle):

  • UserInterface/Views/EventListenerSectionGroup.css:

(.event-listener-section > .content input[type="checkbox"]):

  • UserInterface/Views/DetailsSectionSimpleRow.js:

(WI.DetailsSectionSimpleRow.prototype.get label):
(WI.DetailsSectionSimpleRow.prototype.set label):

LayoutTests:

  • inspector/dom/setEventListenerDisabled-expected.txt: Added.
  • inspector/dom/setEventListenerDisabled.html: Added.
8:59 PM Changeset in webkit [224001] by keith_miller@apple.com
  • 6 edits in trunk/Source/WebCore

Move Platform to unified sources.
​https://bugs.webkit.org/show_bug.cgi?id=178829

Rubber-stamped by Tim Horton.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Cursor.cpp:
  • platform/sql/SQLiteDatabase.h:
7:57 PM Changeset in webkit [224000] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

messageEvent.source can also be a ServiceWorker
​https://bugs.webkit.org/show_bug.cgi?id=178839

Reviewed by Brady Eidson.

messageEvent.source can also be a ServiceWorker:

This enables calling postMessage() from a ServiceWorker via Bug 178794.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::source const): Deleted.

  • dom/MessageEvent.h:
  • dom/MessageEvent.idl:
5:30 PM Changeset in webkit [223999] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource
​https://bugs.webkit.org/show_bug.cgi?id=178715
<rdar://problem/35144665>

Reviewed by Brent Fulgham.

Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first
instead of in the middle of collecting a list of stylesheets.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize the newly added timer.
(WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event
handlers may be expecting to see the document after XSLT had been applied.
(WebCore::Document::scheduleToApplyXSLTransforms): Added.
(WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added.
(WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from
Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function.
(WebCore::Document::applyXSLTransform): Deleted.
(WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply
inline XSLT and it happens much earlier than implicitClose.

  • dom/Document.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending
stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this
function can be called from a non-script-resilient call stack.
(WebCore::ProcessingInstruction::sheetLoaded): Ditto.

  • style/StyleScope.cpp:

(WebCore::Style::Scope::collectXSLTransforms): Added.
(WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions
that applies XSLT. Also use RefPtr<StyleSheet> instead of a raw pointer to store StyleSheet.

  • style/StyleScope.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests.

4:50 PM Changeset in webkit [223998] by webkit@devinrousso.com
  • 5 edits in trunk

Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty
​https://bugs.webkit.org/show_bug.cgi?id=178805
<rdar://problem/35176303>

Reviewed by Brian Burg.

Source/WebCore:

No new tests, updated existing tests.

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
If the recording was stopped and had no data, reset the CallTracingActive flag to false.

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:
4:49 PM Changeset in webkit [223997] by webkit@devinrousso.com
  • 16 edits in trunk

Web Inspector: replace TypeVerifier with subclasses of WI.Collection
​https://bugs.webkit.org/show_bug.cgi?id=178045
<rdar://problem/35174307>

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Models/Collection.js:

(WI.Collection):
(WI.Collection.prototype.get displayName):
(WI.Collection.prototype.objectIsRequiredType):
(WI.Collection.prototype.add):
(WI.Collection.prototype.get typeVerifier): Deleted.
Instead of exposing the typeVerifier, we create a public predicate that returns whether the
given object matches the expected type of the Collection. Subclasses can override it to
limit the scope of the collection to a particular type.

  • UserInterface/Models/CollectionTypes.js:

(WI.FrameCollection.prototype.get displayName):
(WI.FrameCollection.prototype.objectIsRequiredType):
(WI.FrameCollection): Deleted.
(WI.ScriptCollection.prototype.get displayName):
(WI.ScriptCollection.prototype.objectIsRequiredType):
(WI.ScriptCollection): Deleted.
(WI.CSSStyleSheetCollection.prototype.get displayName):
(WI.CSSStyleSheetCollection.prototype.objectIsRequiredType):
(WI.CSSStyleSheetCollection): Deleted.
(WI.CanvasCollection.prototype.get displayName):
(WI.CanvasCollection.prototype.objectIsRequiredType):
(WI.CanvasCollection): Deleted.
(WI.ShaderProgramCollection.prototype.get displayName):
(WI.ShaderProgramCollection.prototype.objectIsRequiredType):
(WI.ShaderProgramCollection): Deleted.
(WI.RecordingCollection.prototype.get displayName):
(WI.RecordingCollection.prototype.objectIsRequiredType):
(WI.RecordingCollection): Deleted.

  • UserInterface/Models/ResourceCollection.js:

(WI.ResourceCollection):
(WI.ResourceCollection.prototype.get displayName):
(WI.ResourceCollection.prototype.objectIsRequiredType):
(WI.ResourceCollection.verifierForType): Deleted.

  • UserInterface/Views/TreeOutlineGroup.js:

(WI.TreeOutlineGroup.prototype.objectIsRequiredType):
(WI.TreeOutlineGroup): Deleted.
Introduce additional subclasses of Collection for other model types. Modify existing
subclasses to remove typeVerifier and instead extend objectIsRequiredType.

  • UserInterface/Models/Canvas.js:

(WI.Canvas):

  • UserInterface/Models/Frame.js:

(WI.Frame):

  • UserInterface/Protocol/Target.js:

(WI.Target):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
(WI.ResourceSidebarPanel.prototype._addScript):

  • UserInterface/Views/CollectionContentView.js:

(WI.CollectionContentView):
(WI.CollectionContentView.titleForCollection): Delete.

  • UserInterface/Views/ResourceCollectionContentView.js:

(WI.ResourceCollectionContentView):
Require that subclasses of Collection override get displayName if the CollectionContentView
is not provided with a contentPlaceholderText.

(WI.CollectionContentView.prototype.initialLayout):
We don't need to create and add ContentView for each item of the Collection, as this is
already done by attached().

(WI.CollectionContentView.prototype._showContentPlaceholder):
Remove the 250ms delay before showing the placeholder TitleView.

  • UserInterface/Views/FolderizedTreeElement.js:

(WI.FolderizedTreeElement.prototype._settingsForRepresentedObject):

LayoutTests:

  • inspector/unit-tests/collection-expected.txt:
  • inspector/unit-tests/collection.html:
4:47 PM Changeset in webkit [223996] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Move html to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=178709

Reviewed by Alex Christensen.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
4:39 PM Changeset in webkit [223995] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Delete temporally downloaded file when it cancelled
​https://bugs.webkit.org/show_bug.cgi?id=134393

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-25
Reviewed by Alex Christensen.

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::writeDataToDownloadFileIfEnabled):
(WebCore::CurlRequest::closeDownloadFile):
(WebCore::CurlRequest::cleanupDownloadFile):

  • platform/network/curl/CurlRequest.h:
4:32 PM Changeset in webkit [223994] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Add service worker handle fetch support for all subresource requests
​https://bugs.webkit.org/show_bug.cgi?id=178769

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-25
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/image-fetch.https.html

Moving DocumentThreadableLoader logic to CachedResourceLoader to apply it for all resource loads.
Setting the selected service worker identifier for subresource only at the moment.

Testing is limited to images, future wpt tests should cover other subresource cases.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::prepareFetch):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded):

  • loader/cache/CachedResourceRequest.h:

LayoutTests:

  • http/tests/workers/service/image-fetch.https-expected.txt: Added.
  • http/tests/workers/service/image-fetch.https.html: Added.
  • http/tests/workers/service/resources/image-fetch-worker.js: Added.

(event.event.request.url.indexOf):
(event.event.request.url.endsWith):

  • http/tests/workers/service/resources/image-fetch.js: Added.

(done):
(async.loadedImage):
(async.erroredImage):
(async.logStatus):
(async.test):

4:24 PM Changeset in webkit [223993] by pvollan@apple.com
  • 4 edits in trunk/Source/WebKit

Network process crash under WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge.
​https://bugs.webkit.org/show_bug.cgi?id=160234
rdar://problem/30675510

Reviewed by Geoffrey Garen.

An exception is raised because we call the method rejectProtectionSpaceAndContinueWithChallenge on the CFNetwork
challenge sender, which does not implement this optional method. The methods on the authentication challenge
sender are deprecated when network session is used, so we should not call them in that case.

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):

  • Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:

(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):

  • Shared/Authentication/soup/AuthenticationManagerSoup.cpp:
4:21 PM Changeset in webkit [223992] by Simon Fraser
  • 3 edits
    3 adds in trunk

Aliasing of text in CSS specs is blocky and ugly
​https://bugs.webkit.org/show_bug.cgi?id=174946
Source/WebCore:

rdar://problem/33594542

Reviewed by Dean Jackson.

The PaintedContentRequest relating to subpixel-antialiased text was failing to be
satisfied if the text content in a composited layer was nested inside descendant
RenderLayers, because RenderLayer::isVisuallyNonEmpty() returned early. If this
function is passed a request, we can't return until we've satisfied the request
(which triggers the checking of descendant layers).

Test: compositing/contents-format/subpixel-antialiased-nested-layer.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

LayoutTests:

Reviewed by Dean Jackson.

  • compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.
4:13 PM Changeset in webkit [223991] by webkit@devinrousso.com
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab: clicking on a canvas card causes details sidebar to show and mess up card arrangement
​https://bugs.webkit.org/show_bug.cgi?id=178803
<rdar://problem/35176082>

Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder):
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder > .message):

  • UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel):
(WI.CanvasDetailsSidebarPanel.prototype.inspect):
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.disallowInstanceForClass): Deleted.

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.disallowInstanceForClass): Deleted.

  • UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:

(WI.RecordingTraceDetailsSidebarPanel.disallowInstanceForClass): Deleted.
Drive-by: these sidebar panels are now only used by the Canvas tab, so we no longer need to
provide support for multiple instances of them.

4:04 PM CommitterTips edited by Ross Kirsling
(diff)
3:27 PM Changeset in webkit [223990] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

Move DNS resolution outside of NetworkRTCProvider
​https://bugs.webkit.org/show_bug.cgi?id=178796

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-25
Reviewed by Geoffrey Garen.

Tested through manual testing on external STUN servers.
Moving NetworkRTCProvider::Resolver into NetworkRTCResolver.
Updating the implementation to use a completion handler.

  • NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createResolver):

  • NetworkProcess/webrtc/NetworkRTCProvider.h:
  • NetworkProcess/webrtc/NetworkRTCResolver.cpp:

(WebKit::NetworkRTCResolver::NetworkRTCResolver):
(WebKit::NetworkRTCResolver::~NetworkRTCResolver):
(WebKit::NetworkRTCResolver::start):
(WebKit::NetworkRTCResolver::stop):
(WebKit::NetworkRTCResolver::completed):
(WebKit::NetworkRTCProvider::Resolver::~Resolver): Deleted.
(WebKit::NetworkRTCProvider::stop): Deleted.
(WebKit::NetworkRTCProvider::resolutionCompleted): Deleted.

  • NetworkProcess/webrtc/NetworkRTCResolver.h:
  • WebKit.xcodeproj/project.pbxproj:
3:15 PM Changeset in webkit [223989] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk

Unreviewed, rolling out r223691 and r223729.
​https://bugs.webkit.org/show_bug.cgi?id=178834

Broke Speedometer 2 React-Redux-TodoMVC test case (Requested
by rniwa on #webkit).

Reverted changesets:

"Turn recursive tail calls into loops"
​https://bugs.webkit.org/show_bug.cgi?id=176601
​https://trac.webkit.org/changeset/223691

"REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning:
comparison is always false due to limited range of data type
[-Wtype-limits]"
​https://bugs.webkit.org/show_bug.cgi?id=178543
​https://trac.webkit.org/changeset/223729

3:15 PM Changeset in webkit [223988] by eric.carlson@apple.com
  • 12 edits
    1 add in trunk

[MediaStream] Clear cached gUM prompt state
​https://bugs.webkit.org/show_bug.cgi?id=178754
<rdar://problem/32742356>

Reviewed by Youenn Fablet.

Source/WebKit:

  • Shared/WebPreferences.yaml: Define new settings.
  • Shared/WebPreferencesDefinitionsBase.h: New default values.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInactiveMediaCaptureSteamRepromptIntervalInMinutes): New.
(WKPreferencesGetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Ditto.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _inactiveMediaCaptureSteamRepromptIntervalInMinutes]): Ditto.
(-[WKPreferences _setInactiveMediaCaptureSteamRepromptIntervalInMinutes:]): Ditto.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::UserMediaPermissionRequestManagerProxy): Initialize
the timer.
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Remove unneeded namespace.
(WebKit::toWebCore): Remove unneeded breaks.
(WebKit::UserMediaPermissionRequestManagerProxy::searchForGrantedRequest const): Remove unneeded namespace.
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged): Set the watchdog timer
to the correct interval based on capture state.
(WebKit::UserMediaPermissionRequestManagerProxy::watchdogTimerFired): Clear cached state.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test
  • TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm: Added.

(-[GetUserMediaRepromptUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(-[GetUserMediaRepromptUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3:06 PM Changeset in webkit [223987] by Ross Kirsling
  • 2 edits in trunk/Tools

Add committer status for Ross Kirsling
​https://bugs.webkit.org/show_bug.cgi?id=178832

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
2:47 PM Changeset in webkit [223986] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, add missing copyright header to ServiceWorkerClientType.idl.

  • workers/service/ServiceWorkerClientType.idl:
2:36 PM Changeset in webkit [223985] by Chris Dumez
  • 8 edits
    1 copy in trunk/Source/WebCore

Make toJS() do the right thing for ServiceWorkerClient
​https://bugs.webkit.org/show_bug.cgi?id=178816

Reviewed by Youenn Fablet.

Make toJS() do the right thing for ServiceWorkerClient. In particular,
it needs to construct a JSServiceWorkerWindowClient wrapper if the
implementation object is a ServiceWorkerWindowClient.

Also, ServiceWorkerClient does not need to be an ActiveDOMObject as
it does not have any long-running tasks. Make it a ContextDestructionObject
instead for now.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):

  • workers/service/ServiceWorkerClient.h:

(WebCore::ServiceWorkerClient::create):

  • workers/service/ServiceWorkerClient.idl:
  • workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.
  • workers/service/ServiceWorkerClientType.idl: Added.
  • workers/service/ServiceWorkerClients.h:
  • workers/service/ServiceWorkerClients.idl:
2:32 PM Changeset in webkit [223984] by Simon Fraser
  • 16 edits
    1 move
    3 adds in trunk

When navigating back to a page, compositing layers may not use accelerated drawing
​https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946

Reviewed by Dean Jackson.
Source/WebCore:

There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which
occurred on back navigation, related to the ordering of style recalcs and layout.

First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called
its cacheAcceleratedCompositingFlags(), so any layers created during style update
didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal
to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers().

Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing()
before updating tiles, so that new tiles fetch the right acceleratesDrawing state from
the TileController.

Test: compositing/accelerated-layers-after-back.html

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderLayerCompositor.h:

Source/WebKit:

Avoid assertions when a test enables accelerated drawing (which we can't support
in the iOS simulator).

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):

Tools:

Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
and use it to set the state of the web view.

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html.

  • compositing/accelerated-layers-after-back-expected.txt: Added.
  • compositing/accelerated-layers-after-back.html: Added.
  • compositing/iframes/page-cache-layer-tree.html:
  • compositing/page-cache-back-crash.html:
  • compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html.
  • platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added.
2:30 PM Changeset in webkit [223983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Display fetch() initiated loads as "fetch" instead of "xhr" in the Network Tab
​https://bugs.webkit.org/show_bug.cgi?id=178826

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-25
Reviewed by Youenn Fablet.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.shortDisplayNameForResourceType):
Fetch and XHR loads are still grouped under the succinct "XHR" filter, but
at least display the better type name in the "Type" column of the table.

2:19 PM Changeset in webkit [223982] by achristensen@apple.com
  • 5 edits in trunk/LayoutTests

LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=159427

Reviewed by Youenn Fablet.

Use setTimeout to make load delegate callback printing more deterministic.
The important part is that the credentials are printed, and they still are.

  • http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • http/tests/loading/basic-credentials-sent-automatically.html:
  • platform/mac/TestExpectations:
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
2:17 PM Changeset in webkit [223981] by commit-queue@webkit.org
  • 35 edits
    2 copies
    5 adds in trunk

Enable ServiceWorker to fetch resources
​https://bugs.webkit.org/show_bug.cgi?id=178673

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-25
Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/workers/service/service-worker-fetch.html

Allow reusing of EmptyFrameLoaderClient for network loading in WebKit Service Worker environment.
Allow overriding the creation of a document loader, pageID, frameID and sessionID getters.

Allow the possibility to create synthetic documents for all ports.

Beefing up ServiceWorkerThreadProxy as it owns a Document and a Page that do nothing but server
the purpose of loading resources for a service worker thread.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setResponse):

  • loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::sessionID const):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::createEmptyFrameNetworkingContext):

  • loader/EmptyClients.h:
  • loader/EmptyFrameLoaderClient.h: Added.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::initForSynthesizedDocument):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::m_workerObjectProxy):

  • workers/service/context/ServiceWorkerThread.h:
  • workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::create):
(WebCore::createPageForServiceWorker):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::postTaskToLoader):

  • workers/service/context/ServiceWorkerThreadProxy.h:

Test: http/tests/workers/service/service-worker-fetch.html

Source/WebKit:

ServiceWorkerContextManager makes use of the new ServiceWorkerThreadProxy.
It creates the necessary environment for the thread to make use of network loads, web sockets and cache storage.
Fetch is functional with these changes.

ServiceWorkerProcessProxy is introduced as a UIProcess proxy to the service worker process.
This process proxy is responsible to give the pageID used by all service worker thread instances for network loads.
ServiceWorkerContextManager is responsible to give a unique frameID for all service worker threads.
This is necessary as these two ids are currently needed for any network load.

ServiceWorkerThreadProxy creates its own FrameLoaderClient which is now used to get pageID, frameID and sessionID.

  • UIProcess/ServiceWorkerProcessProxy.cpp: Added.

(WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy):
(WebKit::m_serviceWorkerPageID):
(WebKit::ServiceWorkerProcessProxy::~ServiceWorkerProcessProxy):
(WebKit::ServiceWorkerProcessProxy::start):

  • UIProcess/ServiceWorkerProcessProxy.h: Added.
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getWorkerContextProcessConnection):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::generatePageID):

  • UIProcess/WebProcessProxy.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::startPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:
  • WebProcess/Storage/ServiceWorkerContextManager.cpp:

(WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager):
(WebKit::ServiceWorkerContextManager::startServiceWorker):
(WebKit::ServiceWorkerContextManager::startFetch):

  • WebProcess/Storage/ServiceWorkerContextManager.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::pageID const):
(WebKit::WebFrameLoaderClient::frameID const):
(WebKit::WebFrameLoaderClient::sessionID const):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWorkerContextConnection):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::pageID const):
(WebFrameLoaderClient::frameID const):
(WebFrameLoaderClient::sessionID const):

Added implementation to the new getters.
They are noop in the context of WK1.

Source/WebKitLegacy/win:

Added implementation to the new getters.
They are noop in the context of WK1.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::pageID const):
(WebFrameLoaderClient::frameID const):
(WebFrameLoaderClient::sessionID const):

  • WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

  • http/tests/workers/service/resources/service-worker-fetch-worker.js: Added.
  • http/tests/workers/service/resources/service-worker-fetch.js: Added.
  • http/tests/workers/service/service-worker-fetch-expected.txt: Added.
  • http/tests/workers/service/service-worker-fetch.html: Added.
2:12 PM Changeset in webkit [223980] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers
​https://bugs.webkit.org/show_bug.cgi?id=178825

Reviewed by Mark Lam.

Enable ARC for ARM64_32. This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK.

  • Configurations/ToolExecutable.xcconfig:
2:12 PM Changeset in webkit [223979] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab: selected canvas card loses selection outline style while recording
​https://bugs.webkit.org/show_bug.cgi?id=178814
<rdar://problem/35177317>

Reviewed by Brian Burg.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas):
(.content-view.canvas-overview .content-view.canvas > :matches(header, .preview, footer)):
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.preview, footer),):
(.content-view.canvas-overview .content-view.canvas > header):
(.content-view.canvas-overview .content-view.canvas.is-recording > header):
(.content-view.canvas-overview .content-view.canvas > .preview):
(.content-view.canvas-overview .content-view.canvas > footer):
(.content-view.canvas-overview .content-view.canvas.selected:not(.is-recording)): Deleted.
Instead of applying the border to the entire element, apply parts of the border to each of
its children so that we can choose what colors to use for each part.

2:09 PM Changeset in webkit [223978] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier curve, and spring inline widgets
​https://bugs.webkit.org/show_bug.cgi?id=178404
<rdar://problem/35035992>

Reviewed by Devin Rousso.

Add inline widgets for the following CSS values:

  • Gradients, e.g. background-image: linear-gradient(yellow, orange)
  • Bezier curves, e.g. transition-timing-function: cubic-bezier(0.68, -0.55, 0.265, 1.55)
  • Spring functions, e.g. transition-timing-function: spring(1, 2, 2, 4)
  • UserInterface/Models/Color.js:

(WI.Color.prototype.toString):
Don't throw. The are never try/catch blocks on the callsites.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
(WI.SpreadsheetStyleProperty.prototype._addGradientTokens):
(WI.SpreadsheetStyleProperty.prototype._addColorTokens):
(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):

1:44 PM Changeset in webkit [223977] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

1:18 PM Changeset in webkit [223976] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.12

Tag Safari-605.1.12.

12:48 PM Changeset in webkit [223975] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

Fix a bug in syncing script that test/build syncer is never set.
​https://bugs.webkit.org/show_bug.cgi?id=178772

Reviewed by Ryosuke Niwa.

Neither 'buildSyncer' nor 'testSyncer' is ever set.
Added a unit test to cover this case.

  • server-tests/tools-sync-buildbot-integration-tests.js:

(createTriggerable): Refactor it to allow customized name.

  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Update syncer info accordingly.
(BuildbotTriggerable._testGroupMapForBuildRequests): Initialize build and test syncer to null.

12:42 PM Changeset in webkit [223974] by jer.noble@apple.com
  • 6 edits
    6 adds in trunk

UNPACK_FLIP_Y is broken for MSE-backed videos
​https://bugs.webkit.org/show_bug.cgi?id=178774

Reviewed by Dean Jackson.

Source/WebCore:

The global GLSL variable gl_Position can apparently only be set once, and any modifications
made after that initial set are ignored. So rather than implement flipping by changing
gl_Position.y, flip the texture coordinates instead.

Drive-by fix: some of the constants used in VideoTextureCopierCV are not defined on older
macOS versions, so make them optional.

Tests: fast/canvas/webgl/texImage2D-mse-flipY-false.html

fast/canvas/webgl/texImage2D-mse-flipY-true.html

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::transferFunctionFromString):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:

LayoutTests:

  • fast/canvas/webgl/resources/orientation-flipped-fragmented.mp4: Added.
  • fast/canvas/webgl/resources/orientation-normal-fragmented.mp4: Added.
  • fast/canvas/webgl/texImage2D-mse-flipY-false-expected.txt: Added.
  • fast/canvas/webgl/texImage2D-mse-flipY-false.html: Added.
  • fast/canvas/webgl/texImage2D-mse-flipY-true-expected.txt: Added.
  • fast/canvas/webgl/texImage2D-mse-flipY-true.html: Added.
  • platform/ios/TestExpectations:
12:36 PM Changeset in webkit [223973] by Chris Dumez
  • 10 edits
    1 copy
    1 add in trunk/Source/WebCore

[Service Worker] Add stubs for serviceWorkerClient.type
​https://bugs.webkit.org/show_bug.cgi?id=178812

Reviewed by Youenn Fablet.

Add stubs for serviceWorkerClient.type to match the latest specification:

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::type const):

  • workers/service/ServiceWorkerClient.h:
  • workers/service/ServiceWorkerClient.idl:
  • workers/service/ServiceWorkerClientType.h: Added.
  • workers/service/ServiceWorkerClientType.idl: Added.
  • workers/service/ServiceWorkerClients.h:
  • workers/service/ServiceWorkerClients.idl:
12:27 PM Changeset in webkit [223972] by keith_miller@apple.com
  • 4 edits in trunk/Source/WebCore

Move mathml and page to unified souces
​https://bugs.webkit.org/show_bug.cgi?id=178770

Rubber-stamped by Tim Horton.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
12:06 PM Changeset in webkit [223971] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix implicit cast of enum, which seems to break the windows build of unified sources.
​https://bugs.webkit.org/show_bug.cgi?id=178822

Reviewed by Saam Barati.

  • bytecode/DFGExitProfile.h:

(JSC::DFG::FrequentExitSite::hash const):

12:02 PM Changeset in webkit [223970] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid
​https://bugs.webkit.org/show_bug.cgi?id=178488

Reviewed by Brian Burg.

  • UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration.prototype.newBlankProperty):
Call this.update to update _properties, _allProperties, _visibleProperties, and _allVisibleProperties.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-name:not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-value:not(.disabled) .value):
When the property name is valid, but the value isn't, display red line-through only for the value.
This is how it works in the old styles sidebar as well.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.updateClassNames):
(WI.SpreadsheetStyleProperty.prototype._update):
Introduce updateClassNames method. Unlike _update, it doesn't change text selection or focus and
can be safely called on a property while it's being edited.

12:01 PM Changeset in webkit [223969] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223960. rdar://problem/35178892

11:54 AM Changeset in webkit [223968] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

fast/images/animated-gif-paint-after-animation.html flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=178510

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-25
Reviewed by Said Abou-Hallawa.

ScalableImageDecoder was accessed from the main thread and the
image decoding thread without a mutex.

No new tests because there is no behavior change.

  • platform/image-decoders/ScalableImageDecoder.h: Add m_mutex. Lock the mutex in setData.
  • platform/image-decoders/ScalableImageDecoder.cpp:

(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const): Lock the mutex.
(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameBytesAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameDurationAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::createFrameImageAtIndex): Ditto.

11:42 AM Changeset in webkit [223967] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/loading/basic-credentials-sent-automatically.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=159427

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:38 AM Changeset in webkit [223966] by commit-queue@webkit.org
  • 4 edits
    2 copies
    2 adds in trunk/Source/WebKit

[WinCairo] Add WebKit platform files for wincairo webkit
​https://bugs.webkit.org/show_bug.cgi?id=178000

Patch by Yousuke Kimoto <​yousuke.kimoto@sony.com> on 2017-10-25
Reviewed by Alex Christensen.

  • Platform/Module.h:
  • Platform/SharedMemory.h:

(WebKit::SharedMemory::handle const):

  • Platform/win/LoggingWin.cpp: Added. It is based on Source/WebCore/platform/win/LoggingWin.cpp

(WebKit::logLevelString):

  • Platform/win/ModuleWin.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer const):

  • Platform/win/SharedMemoryWin.cpp: Added.

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull const):
(WebKit::SharedMemory::Handle::encode const):
(WebKit::SharedMemory::Handle::clear):
(WebKit::getDuplicatedHandle):
(WebKit::SharedMemory::Handle::decode):
(WebKit::protectAttribute):
(WebKit::SharedMemory::allocate):
(WebKit::SharedMemory::create):
(WebKit::accessRights):
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::adopt):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
(WebKit::SharedMemory::systemPageSize):

  • PlatformWin.cmake:
11:32 AM Changeset in webkit [223965] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r222945.
​https://bugs.webkit.org/show_bug.cgi?id=178818

"It made WasmBench crash" (Requested by saamyjoon on #webkit).

Reverted changeset:

"bmalloc mutex should be adaptive"
​https://bugs.webkit.org/show_bug.cgi?id=177839
​https://trac.webkit.org/changeset/222945

11:28 AM Changeset in webkit [223964] by Chris Dumez
  • 20 edits
    3 adds in trunk

Add support for unregistering a service worker
​https://bugs.webkit.org/show_bug.cgi?id=178735

Reviewed by Brady Eidson.

Source/WebCore:

Add support for unregistering a service worker:

Test: http/tests/workers/service/basic-unregister.https.html

  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::resolvedWithUnregistrationResult):

  • workers/service/ServiceWorkerJob.h:
  • workers/service/ServiceWorkerJobClient.h:
  • workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

  • workers/service/ServiceWorkerJobType.h:
  • workers/service/ServiceWorkerRegistration.cpp:

(WebCore::containerForScriptExecutionContext):
(WebCore::ServiceWorkerRegistration::unregister):

  • workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):

  • workers/service/server/SWClientConnection.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::resolveRegistationJob):
(WebCore::SWServer::resolveUnregistrationJob):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptContextStarted):
(WebCore::SWServerRegistration::startNextJob):
(WebCore::SWServerRegistration::runUnregisterJob):
(WebCore::SWServerRegistration::resolveWithRegistrationOnMainThread):
(WebCore::SWServerRegistration::resolveWithUnregistrationResultOnMainThread):
(WebCore::SWServerRegistration::resolveCurrentRegistrationJob):
(WebCore::SWServerRegistration::resolveCurrentUnregistrationJob):

  • workers/service/server/SWServerRegistration.h:

Source/WebKit:

Add support for unregistering a service worker:

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/basic-unregister.https-expected.txt: Added.
  • http/tests/workers/service/basic-unregister.https.html: Added.
  • http/tests/workers/service/resources/basic-unregister.js: Added.
11:21 AM Changeset in webkit [223963] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

MediaSessionManager* needs to catch Obj-C exceptions
​https://bugs.webkit.org/show_bug.cgi?id=178813

Reviewed by Tim Horton.

Wrap all calls out to Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring):
(WebCore::MediaSessionManageriOS::updateNowPlayingInfo):
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper initWithCallback:]):

  • platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):

11:00 AM Changeset in webkit [223962] by aestes@apple.com
  • 11 edits in trunk

[Payment Request] Implement the "user aborts the payment request" algorithm
​https://bugs.webkit.org/show_bug.cgi?id=178810

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::didCancelPaymentSession):

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::cancel):

  • Modules/paymentrequest/PaymentRequest.h:
  • testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::cancelPayment):

  • testing/MockPaymentCoordinator.h:
  • testing/MockPaymentCoordinator.idl:

LayoutTests:

  • http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
  • http/tests/paymentrequest/payment-request-show-method.https.html:
10:42 AM Changeset in webkit [223961] by Ryan Haddad
  • 2 edits in trunk/JSTests

Mark test262.yaml/test262/test/language/statements/try/tco-catch.js as passing.
​https://bugs.webkit.org/show_bug.cgi?id=178592

Unreviewed test gardening.

  • test262.yaml:
10:39 AM Changeset in webkit [223960] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Autoplay muted videos still stop playback of other streaming apps in the background
​https://bugs.webkit.org/show_bug.cgi?id=177920

Reviewed by Eric Carlson.

When creating a new <video> or <audio> element, the global AudioSession can sometimes have
its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
source. This is because the constructor for the MediaElementSession is called before
m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.

We could move the MediaElementSession ivar to the very end of the header, so it's
initialized last, but that still leaves the possibility of the MediaElementSession et. all
calling into the HTMLMediaElement before it's subclass's constructors have a chance to
initialize their own ivars (much less their vtables). So instead, we'll create and set the
MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
HTMLAudioElement's create() factory methods.

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::finishInitialization):

  • html/HTMLMediaElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

10:27 AM Changeset in webkit [223959] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

Attempt to fix flaky test fast/writing-mode/english-bt-text-with-spelling-marker.html following r223938
(​https://bugs.webkit.org/show_bug.cgi?id=178759)

Call internals.updateEditorUINowIfScheduled() to force the editor UI to update and add spelling markers.

  • fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
  • fast/writing-mode/english-bt-text-with-spelling-marker.html:
10:19 AM Changeset in webkit [223958] by Chris Dumez
  • 8 edits
    2 copies in trunk/Source/WebKit

Make SharedStringHashTable less error prone
​https://bugs.webkit.org/show_bug.cgi?id=178764

Reviewed by Youenn Fablet.

SharedStringHashTable is backed by SharedMemory and this SharedMemory
may be readonly (and is when used in the WebContent process). As a result,
some of the operations on SharedStringHashTable that write to this shared
memory will crash if called and the SharedMemory is readonly.

To make this less error prone, introduce a new SharedStringHashTableReadOnly
base class for SharedStringHashTable and only keep the operations that
write to the shared memory on SharedStringHashTableReadOnly (namely, add() /
remove() / clear(). Update VisitedLinkTableController and WebSWOriginTable
to use SharedStringHashTableReadOnly since they are instantiated in the
WebContent process and use readonly shared memory.

  • Shared/SharedStringHashTable.cpp:

(WebKit::SharedStringHashTableReadOnly::SharedStringHashTableReadOnly):
(WebKit::SharedStringHashTableReadOnly::~SharedStringHashTableReadOnly):
(WebKit::SharedStringHashTableReadOnly::setSharedMemory):
(WebKit::doubleHash):
(WebKit::SharedStringHashTableReadOnly::contains const):
(WebKit::SharedStringHashTableReadOnly::findSlot const):
(WebKit::SharedStringHashTable::SharedStringHashTable):
(WebKit::SharedStringHashTable::~SharedStringHashTable):
(WebKit::SharedStringHashTable::add):
(WebKit::SharedStringHashTable::remove):
(WebKit::SharedStringHashTable::clear):

  • Shared/SharedStringHashTable.h:
  • WebProcess/Storage/WebSWOriginTable.h:
  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::removeAllVisitedLinks):

  • WebProcess/WebPage/VisitedLinkTableController.h:
10:18 AM Changeset in webkit [223957] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

Web Inspector: Enable WebKit logging configuration and display
​https://bugs.webkit.org/show_bug.cgi?id=177027
<rdar://problem/33964767>

Unreviewed, fix flakey test.

  • inspector/console/webcore-logging-expected.txt:
  • inspector/console/webcore-logging.html:
9:58 AM Changeset in webkit [223956] by rmorisset@apple.com
  • 5 edits
    2 deletes in trunk

Support the TailBench9000 benchmark in run-jsc-benchmarks
​https://bugs.webkit.org/show_bug.cgi?id=178451

Reviewed by Saam Barati.

PerformanceTests:

The separation between the definition of the benchmarks (in merge-sort.js and n-body.js) and their loops (in *-run.js)
was causing trouble since the load of the js files only succeeded from the same directory. So I chose to merge them, following
the example of the other benchmarks.

  • TailBench9000/merge-sort-run.js: Removed.
  • TailBench9000/merge-sort.js:
  • TailBench9000/n-body-run.js: Removed.
  • TailBench9000/n-body.js:

Tools:

  • Scripts/run-jsc-benchmarks:
9:38 AM Changeset in webkit [223955] by jfernandez@igalia.com
  • 3 edits in trunk/Source/WebCore

[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
​https://bugs.webkit.org/show_bug.cgi?id=178260

Reviewed by Sergio Villar Senin.

Since the intrinsic width computation uses the same logic than the
track sizing algorithm we are clearing the overrideContainingBlockWidth
of some grid items that are required to laid out them properly.

It's very uncommon that any intrinsic size computation isn't performed
as part of a layout process. However, if it happens, once cleared the
overrideContainingBlockWidth it may lead to an incorrect layout of the
affected grid items.

This change is a defensive approach to avoid the issues caused by
such off-layout preferred size requests, which may imply recomputing
the grid container intrinsic size.

No new tests, because we are only removing some redundant logic.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):

  • rendering/GridTrackSizingAlgorithm.h:
8:33 AM WebKitGTK/Gardening/Calendar edited by aboya@igalia.com
(diff)
8:11 AM Changeset in webkit [223954] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebCore

Unreviewed follow up changing one more enum value as discussed in the bug
​https://bugs.webkit.org/show_bug.cgi?id=177810

  • platform/glib/LowPowerModeNotifierGLib.cpp:

(WebCore::LowPowerModeNotifier::updateState): use NONE instead of DISCHARGING, to ensure
it will build even with older upower.

2:00 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
1:34 AM Changeset in webkit [223953] by Adrian Perez de Castro
  • 15 edits in trunk

[WPE] Remove GLib API functions which use Cairo
​https://bugs.webkit.org/show_bug.cgi?id=178205

Reviewed by Michael Catanzaro.

Source/WebKit:

Add PLATFORM(GTK) guards for the parts of of the GLib API which use cairo_surface_t (web
page snapshots and favicons), and remove the affected function prototypes from public API
headers. This way, the WPE version of the API is not tied to Cairo.

  • PlatformWPE.cmake:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:
  • UIProcess/API/glib/WebKitFaviconDatabasePrivate.h:
  • UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkitWebViewDispose):
(webkit_web_view_class_init):
(webkitWebViewLoadChanged):

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/API/wpe/WebKitFaviconDatabase.h:
  • UIProcess/API/wpe/WebKitWebView.h:
  • WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(webkitWebPageDidReceiveMessage):

Tools:

Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
page snapshots and favicons) which are not available in the WPE version of the GLib API.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:

(testNotInitialized):
(testPrivateBrowsing):
(testFaviconDatabase):

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:

(testFindControllerHide):
(beforeAll):

  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
12:39 AM Changeset in webkit [223952] by webkit@devinrousso.com
  • 9 edits in trunk

Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab
​https://bugs.webkit.org/show_bug.cgi?id=178767
<rdar://problem/35167239>

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Test.html:

Include CollectionTypes for tests.

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.recordingFinished):

  • UserInterface/Models/Canvas.js:

(WI.Canvas):
(WI.Canvas.prototype.get recordingCollection):

  • UserInterface/Models/CollectionTypes.js:

(WI.CanvasCollection):
(WI.RecordingCollection):

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._addRecording):
(WI.CanvasContentView.prototype._recordingStopped):

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._recordingAdded):

LayoutTests:

  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.window.startRecording):
Add assertions that the recording is added to the canvas' RecordingCollection.

12:17 AM Changeset in webkit [223951] by zandobersek@gmail.com
  • 16 edits in trunk

Make SERVICE_WORKER feature buildable on GTK, WPE
​https://bugs.webkit.org/show_bug.cgi?id=178574

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • CMakeLists.txt: Add missing include paths and files to the build.
  • Sources.txt: Add missing files to the build.
  • WebCore.xcodeproj/project.pbxproj: Remove the JSDOMPromise.cpp and

JSFetchEventCustom.cpp targets, they're now built via unified sources.

  • bindings/js/JSFetchEventCustom.cpp: Guard custom JSFetchEvent code

with the ENABLE(SERVICE_WORKER) guards.

Source/WebKit:

  • CMakeLists.txt: Add missing files to the build.
  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
IPC::Attachment object should be accessed through an rvalue reference,
making it mutable and enabling releasing the file descriptor.

  • StorageProcess/StorageProcess.h: Adjust the method signature.
  • WebProcess/Storage/ServiceWorkerClientFetch.cpp:

Explicitly include the ResourceError header from WebCore (using a forwarding header).

  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

Include the CachedResource header from WebCore (again using a forwarding header).

  • WebProcess/Storage/WebServiceWorkerProvider.h: Forward-declare the WebCore::CachedResource type.

Source/WTF:

  • wtf/Identified.h: Explicitly include the <atomic> header since

std::atomic<> is used in the ThreadSafeIdentified definition.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add the --service-worker option

that enables the SERVICE_WORKER feature flag. For now it's enabled
on Apple's Cocoa ports (even when build-webkit isn't used for those
builds, the flag is enabled here for consistency).

Note: See TracTimeline for information about the timeline view.