Timeline
Nov 18, 2017:
- 11:19 PM Changeset in webkit [225031] by
-
- 35 edits1 copy in trunk
ASSERTION FAILED: registration in WebCore::SWServerJobQueue::scriptContextStarted(ServiceWorkerIdentifier)
https://bugs.webkit.org/show_bug.cgi?id=179846
Reviewed by Darin Adler.
Source/WebCore:
We have seen crashes on the bots in SWServerJobQueue because methods such as scriptContextStarted()
can get called after the jobQueue has been cleared. This is because when a jobQueue is cleared,
an asynchronous operation may be pending (e.g. script fetch, service worker starting, install event).
To address the issue, we now pass the identifier of the job that started the asynchronous operation
when calling the methods on SWServerJobQueue. If the identifier does not match the identifier of
the current job in the JobQueue, we ignore it.
This patch also starts using a strongly typed identifier (ServiceWorkerJobIdentifier) for
ServiceWorkerJob, instead of a uint64_t. It also introduces a ServiceWorkerJobDataIdentifier type
which contains both a SWServerConnectionIdentifier and a ServiceWorkerJobIdentifier. This is useful
because ServiceWorkerJobData is passed to the StorageProcess and it needs a globally unique identifier.
ServiceWorkerJobIdentifier is only guaranteed to be unique within a single WebProcess. Augmenting it
with the SWServerConnectionIdentifier of the WebProcess makes it globally unique.
No new tests, unskipped exiting test.
- WebCore.xcodeproj/project.pbxproj:
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerContextData.cpp:
(WebCore::ServiceWorkerContextData::isolatedCopy const):
- workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):
- workers/service/ServiceWorkerFetchResult.h:
(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):
- workers/service/ServiceWorkerJob.h:
(WebCore::ServiceWorkerJob::identifier const):
- workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):
- workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::identifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):
- workers/service/ServiceWorkerJobDataIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerFetchResult.h.
(WebCore::ServiceWorkerJobDataIdentifier::operator== const):
(WebCore::ServiceWorkerJobDataIdentifier::loggingString const):
(WebCore::ServiceWorkerJobDataIdentifier::encode const):
(WebCore::ServiceWorkerJobDataIdentifier::decode):
- workers/service/ServiceWorkerTypes.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):
- workers/service/context/SWContextManager.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::fireInstallEvent):
- workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::updateWorker):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::didFinishInstall):
- workers/service/server/SWServerJobQueue.h:
- workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):
- workers/service/server/SWServerWorker.h:
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::didFinishInstall):
- WebProcess/Storage/WebSWContextManagerConnection.h:
Source/WTF:
Add a generateThreadSafeObjectIdentifier() for generating an ObjectIdentifier
in a thread-safe manner, using std::atomic.
- wtf/ObjectIdentifier.h:
(WTF::generateObjectIdentifier):
(WTF::generateThreadSafeObjectIdentifier):
LayoutTests:
Unskip test that use to flakily crash.
- platform/mac/TestExpectations:
- 10:59 PM Changeset in webkit [225030] by
-
- 24 edits2 adds in trunk
AX: AOM: Implement number type properties
https://bugs.webkit.org/show_bug.cgi?id=179497
Reviewed by Chris Fleizach.
Source/WebCore:
Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/
Implemented the number type properties for Accessibility Object Modal.
Test: accessibility/mac/AOM-number-properties.html
- accessibility/AXObjectCache.cpp:
(WebCore::isNodeAriaVisible):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::isMultiSelectable const):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange const):
(WebCore::AccessibilityARIAGridCell::axRowSpanWithRowIndex const):
(WebCore::AccessibilityARIAGridCell::columnIndexRange const):
(WebCore::AccessibilityARIAGridCell::ariaRowSpanWithRowIndex const): Deleted.
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::headingLevel const):
(WebCore::AccessibilityNodeObject::valueForRange const):
(WebCore::AccessibilityNodeObject::maxValueForRange const):
(WebCore::AccessibilityNodeObject::minValueForRange const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::supportsSetSize const):
(WebCore::AccessibilityObject::supportsPosInSet const):
(WebCore::AccessibilityObject::setSize const):
(WebCore::AccessibilityObject::posInSet const):
(WebCore::AccessibilityObject::supportsARIASetSize const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPosInSet const): Deleted.
(WebCore::AccessibilityObject::ariaSetSize const): Deleted.
(WebCore::AccessibilityObject::ariaPosInSet const): Deleted.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::axColumnCount const):
(WebCore::AccessibilityTable::axRowCount const):
(WebCore::AccessibilityTable::ariaColumnCount const): Deleted.
(WebCore::AccessibilityTable::ariaRowCount const): Deleted.
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
(WebCore::AccessibilityTableCell::axColumnIndex const):
(WebCore::AccessibilityTableCell::axRowIndex const):
(WebCore::AccessibilityTableCell::axColumnSpan const):
(WebCore::AccessibilityTableCell::axRowSpan const):
(WebCore::AccessibilityTableCell::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaColumnSpan const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowSpan const): Deleted.
- accessibility/AccessibilityTableCell.h:
(WebCore::AccessibilityTableCell::setAXColIndexFromRow):
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow): Deleted.
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::axColumnIndex const):
(WebCore::AccessibilityTableRow::axRowIndex const):
(WebCore::AccessibilityTableRow::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableRow::ariaRowIndex const): Deleted.
- accessibility/AccessibilityTableRow.h:
- accessibility/AccessibleNode.cpp:
(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueInt):
(WebCore::isPropertyValueUnsigned):
(WebCore::isPropertyValueFloat):
(WebCore::AccessibleNode::setProperty):
(WebCore::AccessibleNode::setOptionalProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::optionalValueForProperty):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::effectiveIntValueForElement):
(WebCore::AccessibleNode::effectiveUnsignedValueForElement):
(WebCore::AccessibleNode::effectiveDoubleValueForElement):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::colCount const):
(WebCore::AccessibleNode::setColCount):
(WebCore::AccessibleNode::colIndex const):
(WebCore::AccessibleNode::setColIndex):
(WebCore::AccessibleNode::colSpan const):
(WebCore::AccessibleNode::setColSpan):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::level const):
(WebCore::AccessibleNode::setLevel):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::posInSet const):
(WebCore::AccessibleNode::setPosInSet):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::rowCount const):
(WebCore::AccessibleNode::setRowCount):
(WebCore::AccessibleNode::rowIndex const):
(WebCore::AccessibleNode::setRowIndex):
(WebCore::AccessibleNode::rowSpan const):
(WebCore::AccessibleNode::setRowSpan):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):
(WebCore::AccessibleNode::setSize const):
(WebCore::AccessibleNode::setSetSize):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueMax const):
(WebCore::AccessibleNode::setValueMax):
(WebCore::AccessibleNode::valueMin const):
(WebCore::AccessibleNode::setValueMin):
(WebCore::AccessibleNode::valueNow const):
(WebCore::AccessibleNode::setValueNow):
(WebCore::AccessibleNode::setValueText):
(WebCore::AccessibleNode::boolValueForProperty): Deleted.
(WebCore::AccessibleNode::setBoolProperty): Deleted.
- accessibility/AccessibleNode.h:
- accessibility/AccessibleNode.idl:
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
- accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:
(webkitAccessibleTableCellGetPosition):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- accessibility/mac/AOM-number-properties-expected.txt: Added.
- accessibility/mac/AOM-number-properties.html: Added.
- 9:05 PM Changeset in webkit [225029] by
-
- 3 edits in trunk/Source/WebKit
Rename some Network Capture debugging defines
https://bugs.webkit.org/show_bug.cgi?id=179870
Reviewed by Darin Adler.
- NetworkProcess/capture/NetworkCaptureLogging.h:
- NetworkProcess/capture/NetworkCaptureManager.cpp:
(WebKit::NetworkCapture::Manager::findMatch):
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
These shouldn't have WTF in their name - they have nothing to do with WTF.
These shouldn't use ENABLE(), since they're not features, just debugging macros.
- 7:48 PM Changeset in webkit [225028] by
-
- 6 edits in trunk/Source
Fix typos in closing ENABLE() comments
https://bugs.webkit.org/show_bug.cgi?id=179869
Unreviewed.
Source/JavaScriptCore:
- wasm/WasmMemory.h:
- wasm/WasmMemoryMode.h:
Source/WebCore:
- platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
- platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
- 7:42 PM Changeset in webkit [225027] by
-
- 11 edits2 adds9 deletes in trunk
Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
https://bugs.webkit.org/show_bug.cgi?id=179582
Reviewed by Darin Adler.
Source/WebCore:
Already covered by fast/encoding/legacy-tec-encodings.html
- platform/text/TextCodecICU.cpp: Add support for EUC-TW.
Remove all vestiges of TEC text codec and its related autogeneration scripts.
- DerivedSources.make:
- PlatformMac.cmake:
- SourcesMac.txt:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData): No more cached TEC decoder.
(WebCore::ThreadGlobalData::destroy): ditto
- platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterTEC): Deleted.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps): Don't add TEC decoders on MAc.
- platform/text/mac/CharsetData.h: Removed.
- platform/text/mac/TextCodecMac.cpp: Removed.
- platform/text/mac/TextCodecMac.h: Removed.
- platform/text/mac/character-sets.txt: Removed.
- platform/text/mac/ios-encodings.txt: Removed.
- platform/text/mac/mac-encodings.txt: Removed.
- platform/text/mac/make-charset-table.pl: Removed.
LayoutTests:
- fast/encoding/legacy-tec-encodings.html: Added. Verify that we
no longer support these encodings.
- fast/encoding/legacy-tec-encodings-expected.txt: Added.
- platform/mac/fast/encoding/xnextstep-decoding.html: Removed. We no longer support this encoding.
- platform/mac/fast/encoding/xnextstep-decoding-expected.txt: Removed.
- 5:55 PM Changeset in webkit [225026] by
-
- 42 edits in trunk/Source/WebCore
Mechanical cleanup of FE* files
https://bugs.webkit.org/show_bug.cgi?id=179868
Reviewed by Wenson Hsieh.
Remove unused dump() functions.
Make overridden member functions in derived classes private.
Make simple getters inline.
Move common FESpecularLighting and FEDiffuseLighting functions into the
FELighting base class.
- platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::blendMode const): Deleted.
(WebCore::FEBlend::dump): Deleted.
- platform/graphics/filters/FEBlend.h:
(WebCore::FEBlend::blendMode const):
- platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::type const): Deleted.
(WebCore::FEColorMatrix::values const): Deleted.
(WebCore::FEColorMatrix::dump): Deleted.
- platform/graphics/filters/FEColorMatrix.h:
(WebCore::FEColorMatrix::type const):
(WebCore::FEColorMatrix::values const):
- platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::redFunction const): Deleted.
(WebCore::FEComponentTransfer::greenFunction const): Deleted.
(WebCore::FEComponentTransfer::blueFunction const): Deleted.
(WebCore::FEComponentTransfer::alphaFunction const): Deleted.
(WebCore::FEComponentTransfer::dump): Deleted.
- platform/graphics/filters/FEComponentTransfer.h:
(WebCore::FEComponentTransfer::redFunction const):
(WebCore::FEComponentTransfer::greenFunction const):
(WebCore::FEComponentTransfer::blueFunction const):
(WebCore::FEComponentTransfer::alphaFunction const):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::operation const): Deleted.
(WebCore::FEComposite::k1 const): Deleted.
(WebCore::FEComposite::k2 const): Deleted.
(WebCore::FEComposite::k3 const): Deleted.
(WebCore::FEComposite::k4 const): Deleted.
(WebCore::FEComposite::dump): Deleted.
- platform/graphics/filters/FEComposite.h:
(WebCore::FEComposite::operation const):
(WebCore::FEComposite::k1 const):
(WebCore::FEComposite::k2 const):
(WebCore::FEComposite::k3 const):
(WebCore::FEComposite::k4 const):
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::kernelSize const): Deleted.
(WebCore::FEConvolveMatrix::kernel const): Deleted.
(WebCore::FEConvolveMatrix::divisor const): Deleted.
(WebCore::FEConvolveMatrix::bias const): Deleted.
(WebCore::FEConvolveMatrix::targetOffset const): Deleted.
(WebCore::FEConvolveMatrix::edgeMode const): Deleted.
(WebCore::FEConvolveMatrix::kernelUnitLength const): Deleted.
(WebCore::FEConvolveMatrix::preserveAlpha const): Deleted.
(WebCore::FEConvolveMatrix::dump): Deleted.
- platform/graphics/filters/FEConvolveMatrix.h:
(WebCore::FEConvolveMatrix::kernelSize const):
(WebCore::FEConvolveMatrix::kernel const):
(WebCore::FEConvolveMatrix::divisor const):
(WebCore::FEConvolveMatrix::bias const):
(WebCore::FEConvolveMatrix::targetOffset const):
(WebCore::FEConvolveMatrix::edgeMode const):
(WebCore::FEConvolveMatrix::kernelUnitLength const):
(WebCore::FEConvolveMatrix::preserveAlpha const):
- platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::lightingColor const): Deleted.
(WebCore::FEDiffuseLighting::setLightingColor): Deleted.
(WebCore::FEDiffuseLighting::surfaceScale const): Deleted.
(WebCore::FEDiffuseLighting::setSurfaceScale): Deleted.
(WebCore::FEDiffuseLighting::diffuseConstant const): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthX const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthX): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthY const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthY): Deleted.
(WebCore::FEDiffuseLighting::lightSource const): Deleted.
(WebCore::FEDiffuseLighting::dump): Deleted.
- platform/graphics/filters/FEDiffuseLighting.h:
(WebCore::FEDiffuseLighting::diffuseConstant const):
- platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::xChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::yChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::scale const): Deleted.
(WebCore::FEDisplacementMap::dump): Deleted.
- platform/graphics/filters/FEDisplacementMap.h:
(WebCore::FEDisplacementMap::xChannelSelector const):
(WebCore::FEDisplacementMap::yChannelSelector const):
(WebCore::FEDisplacementMap::scale const):
- platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::dump): Deleted.
- platform/graphics/filters/FEDropShadow.h:
- platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::floodColor const): Deleted.
(WebCore::FEFlood::floodOpacity const): Deleted.
(WebCore::FEFlood::dump): Deleted.
- platform/graphics/filters/FEFlood.h:
(WebCore::FEFlood::floodColor const):
(WebCore::FEFlood::floodOpacity const):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::stdDeviationX const): Deleted.
(WebCore::FEGaussianBlur::stdDeviationY const): Deleted.
(WebCore::FEGaussianBlur::edgeMode const): Deleted.
(WebCore::FEGaussianBlur::dump): Deleted.
- platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::stdDeviationX const):
(WebCore::FEGaussianBlur::stdDeviationY const):
(WebCore::FEGaussianBlur::edgeMode const):
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::setSurfaceScale):
(WebCore::FELighting::setLightingColor):
(WebCore::FELighting::setKernelUnitLengthX):
(WebCore::FELighting::setKernelUnitLengthY):
- platform/graphics/filters/FELighting.h:
(WebCore::FELighting::surfaceScale const):
(WebCore::FELighting::lightingColor const):
(WebCore::FELighting::kernelUnitLengthX const):
(WebCore::FELighting::kernelUnitLengthY const):
(WebCore::FELighting::lightSource const):
- platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::dump): Deleted.
- platform/graphics/filters/FEMerge.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::dump): Deleted.
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::dx const): Deleted.
(WebCore::FEOffset::dy const): Deleted.
(WebCore::FEOffset::dump): Deleted.
- platform/graphics/filters/FEOffset.h:
(WebCore::FEOffset::dx const):
(WebCore::FEOffset::dy const):
- platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::lightingColor const): Deleted.
(WebCore::FESpecularLighting::setLightingColor): Deleted.
(WebCore::FESpecularLighting::surfaceScale const): Deleted.
(WebCore::FESpecularLighting::setSurfaceScale): Deleted.
(WebCore::FESpecularLighting::specularConstant const): Deleted.
(WebCore::FESpecularLighting::specularExponent const): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthX const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthX): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthY const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthY): Deleted.
(WebCore::FESpecularLighting::lightSource const): Deleted.
(WebCore::FESpecularLighting::dump): Deleted.
- platform/graphics/filters/FESpecularLighting.h:
(WebCore::FESpecularLighting::specularConstant const):
(WebCore::FESpecularLighting::specularExponent const):
- platform/graphics/filters/FETile.cpp:
(WebCore::FETile::dump): Deleted.
- platform/graphics/filters/FETile.h:
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::dump): Deleted.
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::dump): Deleted.
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::dump): Deleted.
- platform/graphics/filters/SourceGraphic.h:
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::dump): Deleted.
- svg/graphics/filters/SVGFEImage.h:
- 5:35 PM Changeset in webkit [225025] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix Windows build failures seen in EWS.
Remove default constructor for ColorComponents, which was ambiguous with the
one that takes 4 values.
- platform/graphics/ColorUtilities.h:
- 4:48 PM Changeset in webkit [225024] by
-
- 3 edits2 adds in trunk
Line of garbage pixels at the bottom of an feTurbulence sometimes
https://bugs.webkit.org/show_bug.cgi?id=179866
Reviewed by Wenson Hsieh.
Source/WebCore:
The ParallelJobs logic was broken in that the sum of the computed job
heights was one too short sometimes. Fix and clean up the logic.
Test: svg/filters/feTurbulence-parallel-jobs.html
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
LayoutTests:
- svg/filters/feTurbulence-parallel-jobs-expected.html: Added.
- svg/filters/feTurbulence-parallel-jobs.html: Added.
- 2:50 PM Changeset in webkit [225023] by
-
- 16 edits in trunk/Source/WebCore
Use #pragma once in FE* files.
Rubber-stamped by Dan Bates.
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEDiffuseLighting.h:
- platform/graphics/filters/FEDisplacementMap.h:
- platform/graphics/filters/FEDropShadow.h:
- platform/graphics/filters/FEFlood.h:
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMerge.h:
- platform/graphics/filters/FEOffset.h:
- platform/graphics/filters/FESpecularLighting.h:
- platform/graphics/filters/FETile.h:
- 2:44 PM Changeset in webkit [225022] by
-
- 2 edits in trunk/Source/WebCore
Remove a TimingScope that I left in by mistake.
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
- 2:40 PM Changeset in webkit [225021] by
-
- 3 edits in trunk/Source/WebCore
FETurbulence: round the result according to the spec
https://bugs.webkit.org/show_bug.cgi?id=179865
Reviewed by Zalan Bujtas.
The spec explicitly says that the floating point results are multiplied by 255 then
clamped between 0 and 255, so do this instead of using lroundf().
This is also faster (about 10%).
- platform/graphics/ColorUtilities.h:
(WebCore::ColorComponents::ColorComponents):
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::toColorComponents):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
- 2:06 PM Changeset in webkit [225020] by
-
- 25 edits in trunk
More FETurbulence cleanup
https://bugs.webkit.org/show_bug.cgi?id=179863
Reviewed by Zalan Bujtas.
Source/WebCore:
Hoist computation of initial StitchData up to be done once per filter,
not once per pixel. Passing initial StitchData by value to calculateTurbulenceValueForPoint()
ensures that each pixel gets the initial state.
Also, adjusted baseFrequencyX and baseFrequencyY can be computed just once at the start,
and passed through via PaintingData.
Change enum TurbulenceType to be an enum class (requiring casts in a couple of places)
and undo the capitalization of the values.
Fix spelling of TURBULANCE -> TURBULENCE in test output.
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::computeStitching const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
(WebCore::operator<<):
- platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData): Deleted.
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::enumerationValueForTargetAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
(WebCore::SVGFETurbulenceElement::parseAttribute):
- svg/SVGFETurbulenceElement.h:
(WebCore::SVGPropertyTraits<TurbulenceType>::highestEnumValue):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):
LayoutTests:
Fix spelling of TURBULANCE -> TURBULENCE.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/ios/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/ios/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- 1:59 PM Changeset in webkit [225019] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Update the Trash / Clear icon
https://bugs.webkit.org/show_bug.cgi?id=179850
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-18
Reviewed by Matt Baker.
- UserInterface/Images/NavigationItemTrash.svg:
Update the icon.
- UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.sidebar > .panel.probes > .navigation-bar .item.clear-samples):
- UserInterface/Views/ProbeSetDetailsSection.js:
(WI.ProbeSetDetailsSection):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
(.scope-chain .navigation-bar .item.clear-watch-expressions):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WI.ScopeChainDetailsSidebarPanel):
Resize to 15x15 and move it down a pixel.
- 12:37 PM Changeset in webkit [225018] by
-
- 5 edits2 adds in trunk
feTurbulence with stitchTiles is broken
https://bugs.webkit.org/show_bug.cgi?id=179862
Reviewed by Zalan Bujtas.
Source/WebCore:
The "stitchTiles" logic was broken, and not equivalent to the spec sample code,
because it didn't compute and wrap the bx1 and by1 equivalents separately from
bx0 and by0.
Annotated the code with the equivalent sample code from the spec for ease of
comparison.
Also make some functions const.
Test: svg/filters/feTurbulence-stitchTiles.html
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::noise2D const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::checkNoise): Deleted.
(WebCore::FETurbulence::noise2D): Deleted.
(WebCore::FETurbulence::calculateTurbulenceValueForPoint): Deleted.
(WebCore::FETurbulence::fillRegion): Deleted.
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::filter const):
LayoutTests:
Ref test that masks out an empty area of the filter and compares with a green rectangle.
- svg/filters/feTurbulence-stitchTiles-expected.html: Added.
- svg/filters/feTurbulence-stitchTiles.html: Added.
- 9:25 AM Changeset in webkit [225017] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test for a multicolumn render tree update issue
https://bugs.webkit.org/show_bug.cgi?id=179860
Reviewed by Zalan Bujtas.
- fast/multicol/column-span-range-crash-expected.txt: Added.
- fast/multicol/column-span-range-crash.html: Added.
- 7:17 AM Changeset in webkit [225016] by
-
- 5 edits2 adds in trunk/Tools
webkitpy: Better name-version mapping (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>
Reviewed by David Kilzer.
Mapping version numbers to version names should occur in a central location.
This has a few advantages. First, it makes iterating through versions easier.
Second, it allows for apple_additions to define an additional set of name
mappings. Lastly, it will allow, in a future patch, for us to track version
instead of version name, only mapping version to version name when required.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.init):
(PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
mapping version to name.
(PlatformInfo._determine_linux_version): Deleted.
(PlatformInfo._determine_mac_version): Deleted.
(PlatformInfo._determine_win_version): Deleted.
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):
- Scripts/webkitpy/common/version.py:
(Version.contained_in): Add partial version mapping.
- Scripts/webkitpy/common/version_name_map.py: Added.
(VersionNameMap): Holds a mapping of version name to version object.
(VersionNameMap.map): Don't re-create VersionNameMap every time.
(VersionNameMap.init): Initialize mapping, use platform to
define the default system platform.
(VersionNameMap._automap_to_major_version): Some operating systems, such
as iOS, have a naming scheme based on their major version and os name.
Automatically generate such mappings.
(VersionNameMap.to_name): Given a version object, platform name and
table, find the closest matching version name.
(VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
if a version string is included in the name.
(VersionNameMap.from_name): Return an os name and version given a version name.
- Scripts/webkitpy/common/version_name_map_unittest.py: Added.
(VersionMapTestCase):
(VersionMapTestCase.test_default_system_platform):
(VersionMapTestCase.test_mac_version_by_name):
(VersionMapTestCase.test_ios_version_by_name):
(VersionMapTestCase.test_mac_name_by_version):
(VersionMapTestCase.test_ios_name_by_version):
- Scripts/webkitpy/common/version_unittest.py:
(VersionTestCase.test_contained_in):
- 6:09 AM Changeset in webkit [225015] by
-
- 3 edits in trunk/Source/WTF
[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
https://bugs.webkit.org/show_bug.cgi?id=179859
Reviewed by JF Bastien.
Currently, we know that CPU(HPPA)'s stack direction is upward! But listing
CPU architectures here is not a scalable way.
Instead, we use runtime stack direction test. By doing so, we can handle
such a strange architecture without listing the CPU to Platform.h. This paves
the way to dropping many CPUs in Platform.h by replacing them with CPU(UNKNOWN)[1].
We also fix StackBounds::isGrowingDownward().
[1]: https://bugs.webkit.org/show_bug.cgi?id=179243
- wtf/StackBounds.cpp:
(WTF::StackBounds::stackDirection):
(WTF::testStackDirection2):
(WTF::testStackDirection):
(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):
- wtf/StackBounds.h:
(WTF::StackBounds::isGrowingDownward const):
- 3:46 AM Changeset in webkit [225014] by
-
- 3 edits2 adds in trunk
Source/WebCore:
REGRESSION (r220646): REGRESSION (r220646): RenderTreePosition::computeNextSibling hits assertion with certain first-letter mutations
https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>
Reviewed by Zalan Bujtas.
Test: fast/css-generated-content/first-letter-update-crash.html
- style/RenderTreeUpdaterFirstLetter.cpp:
(WebCore::styleForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
Tighten these to take RenderBlock.
(WebCore::supportsFirstLetter):
Test exact conditions where first letter renderer is allowed for fast rejection.
(WebCore::RenderTreeUpdater::FirstLetter::update):
If update was called on a block that doesn't support first letter, getFirstLetter could in
some cases return an ancestor of the block and we would end up mutating a first letter renderer
that wasn't current block's descendant. This violates assumptions of the RenderTreeUpdater
and could cause cached render tree position to become invalid.
Fix by ensuring we are always updating first letter for the current block only.
LayoutTests:
REGRESSION (r220646): ASSERTION FAILED: skipAssert nextSiblingRenderer(node) == m_nextSibling https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>
Reviewed by Zalan Bujtas.
- fast/css-generated-content/first-letter-update-crash-expected.txt: Added.
- fast/css-generated-content/first-letter-update-crash.html: Added.
Nov 17, 2017:
- 10:32 PM Changeset in webkit [225013] by
-
- 7 edits in trunk/LayoutTests
Rebaseline and/or turn on more iOS selection tests that either already pass, or need minimal visual tweaking
https://bugs.webkit.org/show_bug.cgi?id=179856
Reviewed by Myles C. Maxfield.
These tests all neither to either be minimally rebaselined, or they worked, but were marked as failing.
All were checked for flakiness, and none were found to be flakey on the open source bots.
- platform/ios-wk2/TestExpectations:
- platform/ios/editing/selection/extend-by-word-002-expected.txt:
- platform/ios/editing/selection/iframe-expected.png: Modified property svn:mime-type.
- platform/ios/editing/selection/iframe-expected.txt:
- platform/ios/editing/selection/inline-table-expected.png: Modified property svn:mime-type.
- platform/ios/editing/selection/inline-table-expected.txt:
- 8:46 PM Changeset in webkit [225012] by
-
- 1 edit2 adds in trunk/LayoutTests
Test case for r224995.
https://bugs.webkit.org/show_bug.cgi?id=179854
- fast/dom/getSVGDocument-on-object-crash-expected.txt: Added.
- fast/dom/getSVGDocument-on-object-crash.html: Added.
- 7:42 PM Changeset in webkit [225011] by
-
- 16 edits2 adds in trunk
[Service Workers] Implement "Notify Controller Change" algorithm
https://bugs.webkit.org/show_bug.cgi?id=179822
Reviewed by Youenn Fablet.
Source/WebCore:
Implement "Notify Controller Change" algorithm:
Use it to support step 7 of "Activate" algorithm:
Test: http/tests/workers/service/controller-change.html
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):
- workers/service/ServiceWorkerContainer.h:
- workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.h:
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::activate):
- workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::notifyClientsOfControllerChange):
- workers/service/server/SWServerRegistration.h:
Source/WebKit:
- Scripts/webkit/messages.py:
(class_template_headers):
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::notifyClientsOfControllerChange):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/controller-change-expected.txt: Added.
- http/tests/workers/service/controller-change.html: Added.
- 7:02 PM Changeset in webkit [225010] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix build after r225006.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::setStorageAccessGranted):
- 6:32 PM Changeset in webkit [225009] by
-
- 5 edits2 adds in trunk/Source/WebCore
FETurbulence: compute all 4 channels at once
https://bugs.webkit.org/show_bug.cgi?id=179833
Reviewed by Sam Weinig.
Introduce some new helper classes for storing float color components, and use
them in calculateTurbulenceValueForPoint() and noise2D() for all the channels in one
pass. This makes FETurbulence about twice as fast.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ColorUtilities.cpp: Added.
(WebCore::ColorComponents::ColorComponents):
- platform/graphics/ColorUtilities.h: Added.
(WebCore::FloatComponents::FloatComponents):
(WebCore::FloatComponents::operator +=):
(WebCore::FloatComponents::operator + const):
(WebCore::FloatComponents::operator / const):
(WebCore::FloatComponents::operator * const):
(WebCore::FloatComponents::abs const):
(WebCore::clampedColorComponent):
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::noise2D):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
- 6:27 PM Changeset in webkit [225008] by
-
- 47 edits in trunk/Source
Use a strongly typed identifier for SWServer::Connection
https://bugs.webkit.org/show_bug.cgi?id=179848
Reviewed by Brady Eidson.
Source/WebCore:
Use a strongly typed identifier for SWServer::Connection, for clarity.
- workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):
- workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):
- workers/service/ServiceWorkerClient.h:
(WebCore::ServiceWorkerClient::create):
(WebCore::ServiceWorkerClient::identifier const):
- workers/service/ServiceWorkerClientData.cpp:
(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::from):
- workers/service/ServiceWorkerClientData.h:
(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):
- workers/service/ServiceWorkerClientIdentifier.h:
(WebCore::ServiceWorkerClientIdentifier::toString const):
(WebCore::ServiceWorkerClientIdentifier::decode):
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::updateRegistration):
(WebCore::ServiceWorkerContainer::connectionIdentifier):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerFetchResult.h:
(WebCore::ServiceWorkerFetchResult::decode):
- workers/service/ServiceWorkerJobClient.h:
- workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
- workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::decode):
- workers/service/ServiceWorkerTypes.h:
- workers/service/ServiceWorkerWindowClient.cpp:
(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):
- workers/service/ServiceWorkerWindowClient.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):
- workers/service/context/SWContextManager.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):
- workers/service/server/SWServer.h:
(WebCore::SWServer::Connection::identifier const):
(WebCore::SWServer::getConnection):
- workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::forEachConnection):
(WebCore::SWServerRegistration::addClientServiceWorkerRegistration):
(WebCore::SWServerRegistration::removeClientServiceWorkerRegistration):
(WebCore::SWServerRegistration::unregisterServerConnection):
- workers/service/server/SWServerRegistration.h:
Source/WebKit:
Use a strongly typed identifier for SWServer::Connection, for clarity.
- Scripts/webkit/messages.py:
(forward_declarations_and_headers):
(forward_declarations_and_headers.templates):
(headers_for_type):
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didFailFetch):
(WebKit::StorageProcess::didNotHandleFetch):
(WebKit::StorageProcess::didReceiveFetchResponse):
(WebKit::StorageProcess::didReceiveFetchData):
(WebKit::StorageProcess::didReceiveFetchFormData):
(WebKit::StorageProcess::didFinishFetch):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::generateIDBConnectionToServerIdentifier):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):
- StorageProcess/StorageToWebProcessConnection.h:
- StorageProcess/StorageToWebProcessConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::startFetch):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::WebServiceWorkerFetchTaskClient):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
- WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):
- WebProcess/Storage/WebToStorageProcessConnection.h:
Source/WTF:
Make ObjectIdentifier a little more flexible to support more use cases.
- wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifier::toUInt64 const):
(WTF::makeObjectIdentifier):
- 5:57 PM Changeset in webkit [225007] by
-
- 7 edits in trunk/LayoutTests
Web Inspector: Fix grammar typo in tests
https://bugs.webkit.org/show_bug.cgi?id=179852
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Matt Baker.
- http/tests/inspector/network/resource-response-source-memory-cache-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html:
- http/tests/inspector/network/resource-response-source-memory-cache.html:
- http/tests/inspector/network/set-resource-caching-disabled-memory-cache-expected.txt:
- http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html:
- 5:27 PM Changeset in webkit [225006] by
-
- 39 edits2 moves4 adds in trunk
Storage Access API: UI process should update network process about granted access
https://bugs.webkit.org/show_bug.cgi?id=176943
<rdar://problem/34440612>
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction.html
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled):
(WebCore::NetworkStorageSession::cookieStoragePartition const):
Now also checks if the resource has been granted storage access
under this partition and if so, does not return a partition.
(WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):
Now clears storage access when it is told to clear first.
(WebCore::NetworkStorageSession::isStorageAccessGranted const):
(WebCore::NetworkStorageSession::setStorageAccessGranted):
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updateStorageAccessForPrevalentDomains):
Updates storage access on the session.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled):
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetStorageAccessAPIEnabled):
- UIProcess/API/C/WKCookieManager.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetStatisticsHasHadNonRecentUserInteraction):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _isStorageAccessAPIEnabled]):
(-[WKProcessPool _setStorageAccessAPIEnabled:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _resourceLoadStatisticsSetHasHadNonRecentUserInteractionForHost:]):
Test infrastructure.
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setStorageAccessAPIEnabled):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::nextRequestStorageAccessContextId):
(WebKit::NetworkProcessProxy::updateStorageAccessForPrevalentDomains):
Sends a message to the network process to update storage access.
(WebKit::NetworkProcessProxy::storageAccessRequestResult):
Receives a message from the network process that storage access
was updated.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::setStorageAccessAPIEnabled):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebProcessPool.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::logNonRecentUserInteraction):
Test infrastructure.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
Now makes the API call even if the only operation is to clear first.
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updateStorageAccessForPrevalentDomainsHandler):
Propagates the storage access directive to the network process proxy.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
which enables testing of prevalent resources with user interaction outside the
24 hour window.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setStorageAccessAPIEnabled):
(WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
(WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
LayoutTests:
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-expected.txt: Added.
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html: Added.
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction-expected.txt: Added.
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction.html: Added.
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-expected.txt: Removed.
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction.html: Removed.
Renamed to make the recent and non-recent user interaction explicit.
- http/tests/storageAccess/resources/get-cookies.php: Added.
- http/tests/storageAccess/resources/set-cookie.php: Added.
- platform/mac-wk2/TestExpectations:
Added the new tests as [ Pass ] for High Sierra and up.
- 5:18 PM Changeset in webkit [225005] by
-
- 2 edits in trunk/Source/WebCore
Inadvertently swapped m_baseFrequencyX and m_baseFrequencyY in the previous commit.
- platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::baseFrequencyY const):
(WebCore::FETurbulence::baseFrequencyX const):
- 5:07 PM Changeset in webkit [225004] by
-
- 2 edits in trunk/LayoutTests
Skip imported/w3c/web-platform-tests/service-workers/service-worker/getregistration.https.html on debug bots.
https://bugs.webkit.org/show_bug.cgi?id=179846
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:00 PM Changeset in webkit [225003] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(224348): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=179806
Reviewed by Jer Noble.
In r224348 I used callOnMainThread to fix UIWebView which uses the web thread, but Mac doesn't
use the web thread. Something about the timing of operations in the media stack requires that
dispatch_async be used instead of performSelectorOnMainThread.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]):
Use callOnMainThread on iOS, dispatch_async on Mac.
- 4:49 PM Changeset in webkit [225002] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations for service-worker tests.
Unreviewed test gardening.
- 4:48 PM Changeset in webkit [225001] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations for inspector/canvas/shaderProgram-add-remove-webgl2.html.
https://bugs.webkit.org/show_bug.cgi?id=179827
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:48 PM Changeset in webkit [225000] by
-
- 2 edits in trunk/Source/WebCore
[Win] Compile error in InbandTextTrackPrivateAVCF::readNativeSampleBuffer.
https://bugs.webkit.org/show_bug.cgi?id=179845
Reviewed by Jer Noble.
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):
- 4:22 PM Changeset in webkit [224999] by
-
- 2 edits in trunk/LayoutTests
Mark svg/in-html/by-reference.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=179784
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 4:19 PM Changeset in webkit [224998] by
-
- 2 edits in trunk/Tools
Disable failing API tests for rdar://problem/35344202.
Unreviewed test gardening.
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
- 3:44 PM Changeset in webkit [224997] by
-
- 5 edits2 adds in trunk
AX: VoiceOver in Safari does not read table header for first cell in first body row
https://bugs.webkit.org/show_bug.cgi?id=179780
<rdar://problem/35590551>
Reviewed by Joanmarie Diggs.
Source/WebCore:
A table cell shouldn't be considered a row header if it's in a row of other headers.
Test: accessibility/table-header-calculation-for-header-rows.html
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
LayoutTests:
- accessibility/table-header-calculation-for-header-rows-expected.txt: Added.
- accessibility/table-header-calculation-for-header-rows.html: Added.
- accessibility/table-attributes-expected.txt: Updated.
- platform/gtk/accessibility/table-attributes-expected.txt: Updated.
- 3:36 PM Changeset in webkit [224996] by
-
- 4 edits in trunk/Source/WebCore
Don't invert a matrix for every channel of every pixel of an FETurbulence filter
https://bugs.webkit.org/show_bug.cgi?id=179829
Reviewed by Dean Jackson.
FETurbulence::fillRegion() called filter().mapAbsolutePointToLocalPoint(point) for each
of the 4 channels on a point, which is stupid.
Fix to invert the matrix once, and then map the point once for each pixel. This reduces
the time in fillRegion() function by about 30%.
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion):
- platform/graphics/filters/Filter.h:
(WebCore::Filter::absoluteTransform const):
(WebCore::Filter::mapAbsolutePointToLocalPoint const): Deleted.
- 3:34 PM Changeset in webkit [224995] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r224390): Revert unneeded Ref use.
https://bugs.webkit.org/show_bug.cgi?id=179844
<rdar://problem/35624718>
Reviewed by Chris Dumez.
A Ref was added to a simple code path used for type checking, which introduced a nullptr
deref. The original change was not needed, so let's revert it.
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::contentDocument const): Use 'nullptr' instead of 0.
(WebCore::HTMLFrameOwnerElement::contentWindow const): Ditto.
(WebCore::HTMLFrameOwnerElement::getSVGDocument const): Revert to original code here.
- 3:32 PM Changeset in webkit [224994] by
-
- 4 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Add HAR Export button
https://bugs.webkit.org/show_bug.cgi?id=179570
<rdar://problem/35484918>
Reviewed by Matt Baker.
- Localizations/en.lproj/localizedStrings.js:
New strings.
- UserInterface/Images/Export.svg: Added.
- UserInterface/Images/Import.svg: Added.
Add symmetric import/export buttons.
- UserInterface/Base/Main.js:
(WI.contentLoaded):
Expose the save keyboard shortcut so we can show its display name in a tooltip.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get navigationItems):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._updateExportButton):
Include the export button and enable/disable it when appropriate.
(WI.NetworkTableContentView.prototype.closed):
Add a missing event listener removal.
- 3:18 PM Changeset in webkit [224993] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Disabled ImageAndText-style buttons should have gray text
https://bugs.webkit.org/show_bug.cgi?id=179843
<rdar://problem/35624337>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.disabled.image-and-text,):
(.navigation-bar .item.button.disabled > .glyph): Deleted.
- 3:14 PM Changeset in webkit [224992] by
-
- 18 edits2 adds in trunk
AX: AOM: Implement boolean type properties
https://bugs.webkit.org/show_bug.cgi?id=179496
Reviewed by Chris Fleizach.
Source/WebCore:
Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/
Implemented the boolean type properties for Accessibility Object Modal.
Test: accessibility/mac/AOM-bool-properties.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::findModalNodes):
(WebCore::AXObjectCache::updateCurrentModalNode):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::focusModalNode):
(WebCore::AXObjectCache::focusModalNodeTimerFired):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::isNodeAriaVisible):
(WebCore::AXObjectCache::findAriaModalNodes): Deleted.
(WebCore::AXObjectCache::updateCurrentAriaModalNode): Deleted.
(WebCore::AXObjectCache::ariaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleAriaModalChange): Deleted.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::focusModalNodeTimerFired):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::AXObjectCache::ariaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleAriaModalChange): Deleted.
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::isMultiSelectable const):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::readOnlyValue const):
(WebCore::AccessibilityARIAGridCell::ariaReadOnlyValue const): Deleted.
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled const):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::shouldUseAccessibilityObjectInnerText):
(WebCore::AccessibilityNodeObject::canSetValueAttribute const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsReadOnly const):
(WebCore::AccessibilityObject::readOnlyValue const):
(WebCore::AccessibilityObject::ariaIsMultiline const):
(WebCore::AccessibilityObject::isModalDescendant const):
(WebCore::AccessibilityObject::isModalNode const):
(WebCore::AccessibilityObject::ignoredFromModalPresence const):
(WebCore::AccessibilityObject::boolValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::isAXHidden const):
(WebCore::AccessibilityObject::defaultObjectInclusion const):
(WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild):
(WebCore::AccessibilityObject::supportsARIAReadOnly const): Deleted.
(WebCore::AccessibilityObject::ariaReadOnlyValue const): Deleted.
(WebCore::AccessibilityObject::isAriaModalDescendant const): Deleted.
(WebCore::AccessibilityObject::isAriaModalNode const): Deleted.
(WebCore::AccessibilityObject::ignoredFromARIAModalPresence const): Deleted.
(WebCore::AccessibilityObject::isARIAHidden const): Deleted.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isHidden const):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::isSelected const):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
(WebCore::AccessibilityRenderObject::isBusy const):
- accessibility/AccessibleNode.cpp:
(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueBoolean):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::boolValueForProperty):
(WebCore::AccessibleNode::setBoolProperty):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):
- accessibility/AccessibleNode.h:
- accessibility/AccessibleNode.idl:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
LayoutTests:
- accessibility/mac/AOM-bool-properties-expected.txt: Added.
- accessibility/mac/AOM-bool-properties.html: Added.
- 3:10 PM Changeset in webkit [224991] by
-
- 2 edits in trunk/Source/JavaScriptCore
NFC update ClassInfo to C++14
https://bugs.webkit.org/show_bug.cgi?id=179783
Reviewed by Mark Lam.
Forked from #179734, use
usinginstead oftypedef. It's easier
to read.
- runtime/ClassInfo.h:
- 3:00 PM Changeset in webkit [224990] by
-
- 3 edits2 adds in trunk/Source/WTF
Add a TimingScope class for microbenchmarking sections of code
https://bugs.webkit.org/show_bug.cgi?id=179825
Reviewed by Zalan Bujtas.
Add a class, similar to B3TimingScope, which makes it easy to microbenchmark
sections of code. Use looks like:
TimingScope scope("some label", 100);
where this will print mean scope duration every 100 calls. Sample output:
FETurbulence::platformApplySoftware: 100 calls, mean duration: 3.073181ms
FETurbulence::platformApplySoftware: 200 calls, mean duration: 3.074612ms
FETurbulence::platformApplySoftware: 300 calls, mean duration: 3.065722ms
Because TimingScope needs to store state beween invocations, and there may be
multiple TimingScopes in use at the same time, data is stored in a global
hash map with atomic access.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/TimingScope.cpp: Added.
(WTF::TimingScope::scopeDidEnd):
- wtf/TimingScope.h: Added.
(WTF::TimingScope::TimingScope):
(WTF::TimingScope::~TimingScope):
- 2:53 PM Changeset in webkit [224989] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Update Ignore Caches button
https://bugs.webkit.org/show_bug.cgi?id=179841
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Matt Baker.
- UserInterface/Images/IgnoreCaches.svg:
This changes from an arrow over a cache to a slash through a cache.
- 2:12 PM Changeset in webkit [224988] by
-
- 2 edits in trunk/LayoutTests
Turn on selection layout tests that are already working on iOS
https://bugs.webkit.org/show_bug.cgi?id=179842
Reviewed by Tim Horton.
I have checked these test manually and on the flakiness dashboard and they are all
working on iOS. No reason to not run them on iOS now.
- platform/ios-wk2/TestExpectations:
- 2:12 PM Changeset in webkit [224987] by
-
- 2 edits in tags/Safari-605.1.14.1/Source/WebCore
Cherry-pick r224960. rdar://problem/35485349
- 2:09 PM Changeset in webkit [224986] by
-
- 5 edits2 adds in trunk
AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
https://bugs.webkit.org/show_bug.cgi?id=179837
Reviewed by Chris Fleizach.
Tools:
Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
to getTableRowHeaders() and getTableColumnHeaders() respectively.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
LayoutTests:
- accessibility/gtk/table-headers-count-expected.txt: Added.
- accessibility/gtk/table-headers-count.html: Added.
- platform/gtk/TestExpectations: Remove a couple of "crash" failures.
- platform/gtk/accessibility/table-sections-expected.txt: Remove null objects.
- 1:57 PM Changeset in webkit [224985] by
-
- 3 edits1 add in trunk
WebAssembly JS API: throw when a promise can't be created
https://bugs.webkit.org/show_bug.cgi?id=179826
<rdar://problem/35455813>
Reviewed by Mark Lam.
JSTests:
Test WebAssembly.{compile,instantiate} where promise creation
fails because of a stack overflow.
- wasm/js-api/promise-stack-overflow.js: Added.
(const.runNearStackLimit.f.const.t):
(async.testCompile):
(async.testInstantiate):
Source/JavaScriptCore:
Failure *in* a promise causes rejection, but failure to create a
promise (because of stack overflow) isn't really spec'd (as all
stack things JS). This applies to WebAssembly.compile and
WebAssembly.instantiate.
Dan's current proposal says:
https://littledan.github.io/spec/document/js-api/index.html#stack-overflow
Whenever a stack overflow occurs in WebAssembly code, the same
class of exception is thrown as for a stack overflow in
JavaScript. The particular exception here is
implementation-defined in both cases.
Note: ECMAScript doesn’t specify any sort of behavior on stack
overflow; implementations have been observed to throw RangeError,
InternalError or Error. Any is valid here.
This is for general stack overflow within WebAssembly, not
specifically for promise creation within JavaScript, but it seems
like a stack overflow in promise creation should follow the same
rule instead of, say, swallowing the overflow and returning
undefined.
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):
- 1:38 PM Changeset in webkit [224984] by
-
- 6 edits in trunk/Source/WebCore
Clean up URL.h
https://bugs.webkit.org/show_bug.cgi?id=179710
Reviewed by Brady Eidson.
No change in behavior.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::urlString const):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::url const):
- platform/URL.cpp:
(WebCore::URL::serialize const): Deleted.
- platform/URL.h:
- platform/mac/URLMac.mm:
(WebCore::URL::createCFURL const):
- 1:35 PM Changeset in webkit [224983] by
-
- 6 edits in trunk/Source/WTF
Clean up after r224952
https://bugs.webkit.org/show_bug.cgi?id=179809
Reviewed by Brady Eidson.
- wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
- wtf/MainThread.h:
- wtf/generic/MainThreadGeneric.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.
- wtf/mac/MainThreadMac.mm:
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.
- wtf/win/MainThreadWin.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.
- 1:33 PM Changeset in webkit [224982] by
-
- 3 edits in trunk
Use RunLoop and Mode from NetworkingContext if they are given
https://bugs.webkit.org/show_bug.cgi?id=179800
<rdar://problem/35519421>
Reviewed by Brady Eidson.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(callOnMainThreadOrSchedule):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):
- 1:29 PM Changeset in webkit [224981] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove WI.instanceForClass
https://bugs.webkit.org/show_bug.cgi?id=179746
Reviewed by Timothy Hatcher.
The implementations of DetailsSidebarPanel subclasses assume that panels
are closed and released when no longer needed. Keeping them alive with
instanceForClass isn't the right choice, since sidebar panels remove their
event listeners when closed.
- UserInterface/Base/Main.js:
(WI.instanceForClass): Deleted.
- UserInterface/Views/DebuggerTabContentView.js:
(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
- UserInterface/Views/TabContentView.js:
(WI.TabContentView.prototype.get detailsSidebarPanels):
- 1:11 PM Changeset in webkit [224980] by
-
- 7 edits in branches/safari-604.4.7.10-branch/Source
Versioning.
- 12:43 PM Changeset in webkit [224979] by
-
- 3 edits in trunk/LayoutTests
LayoutTest http/tests/inspector/network/har/har-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179781
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Alexey Proskuryakov.
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/har/har-page.html:
Filter out the protocol value since it might not be available if the resource was cached.
- 12:38 PM Changeset in webkit [224978] by
-
- 5 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: ButtonNavigationItem should support image and text button style
https://bugs.webkit.org/show_bug.cgi?id=179625
<rdar://problem/35512238>
Reviewed by Joseph Pecoraro.
- UserInterface/Main.html:
- UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button):
(.navigation-bar .item.button.image-only):
(.navigation-bar .item.button.image-and-text):
(.navigation-bar .item.button.image-and-text > span):
(.navigation-bar .item.button.text-only):
(.navigation-bar .item.button.text-only.checkbox): Deleted.
(.navigation-bar .item.button.text-only.checkbox label): Deleted.
Checkbox styles have been moved to a separate CSS file.
- UserInterface/Views/ButtonNavigationItem.js:
Add backing data members for the image and label, allowing the DOM
representation of the button to change as needed.
(WI.ButtonNavigationItem):
Remove duplicate role logic. The base class sets the role.
(WI.ButtonNavigationItem.prototype.set label):
(WI.ButtonNavigationItem.prototype.set image):
(WI.ButtonNavigationItem.prototype.get buttonStyle):
(WI.ButtonNavigationItem.prototype.set buttonStyle):
(WI.ButtonNavigationItem.prototype.get additionalClassNames):
(WI.ButtonNavigationItem.prototype._mouseClicked):
(WI.ButtonNavigationItem.prototype._update):
(WI.ButtonNavigationItem.prototype.updateButtonText): Deleted.
- UserInterface/Views/CheckboxNavigationItem.css: Added.
(.navigation-bar .item.checkbox):
(.navigation-bar .item.checkbox label):
- UserInterface/Views/CheckboxNavigationItem.js:
Change base class to NavigationItem, since this item lacks an image
and makes use of an actual label element instead of a span for its text.
(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype._checkboxChanged):
(WI.CheckboxNavigationItem.prototype.updateButtonText): Deleted.
- 11:39 AM Changeset in webkit [224977] by
-
- 3 edits in trunk/Source/WebCore
FETurbulence const and inline cleanup
https://bugs.webkit.org/show_bug.cgi?id=179832
Reviewed by Dean Jackson.
Pass the PaintingData& around as const, and remove some 'inline', letting the compiler
decide. Also declare a few variables closer to first use.
Speeds up FETurbulence by about 1%.
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::initPaint):
(WebCore::FETurbulence::noise2D):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):
- platform/graphics/filters/FETurbulence.h:
- 11:34 AM Changeset in webkit [224976] by
-
- 7 edits in trunk/Source/WebCore
Move destroyLeftoverChildren call to RenderObject::destroy
https://bugs.webkit.org/show_bug.cgi?id=179819
Reviewed by Zalan Bujtas.
This is currently called inconsistenly from various willBeDestroyed implementations.
We should always call it before invoking willBeDestroyed.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeDestroyed):
- rendering/RenderElement.h:
(WebCore::RenderElement::setLastChild):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
Add some release asserts verifying layer has been detached before destruction.
This would reveal cases where destroyLeftoverChildren was called too late.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroy):
Call destroyLeftoverChildren.
- 11:29 AM Changeset in webkit [224975] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove FIXMEs for GTK+ missing icons
https://bugs.webkit.org/show_bug.cgi?id=155282
<rdar://problem/25076615>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Michael Catanzaro.
- UserInterface/Views/PathComponentIcons.css:
(.source-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,): Deleted.
- UserInterface/Views/ResourceIcons.css:
(.large .resource-icon.resource-type-websocket .icon):
(body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,): Deleted.
(body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,): Deleted.
All ports now share the same images.
- 11:16 AM Changeset in webkit [224974] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=179773
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 10:40 AM Changeset in webkit [224973] by
-
- 7 edits2 adds in trunk
SVG scrolling anchor should be reset if the fragmentIdentifier does not exist or is not provided
https://bugs.webkit.org/show_bug.cgi?id=176577
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-17
Reviewed by Simon Fraser.
Source/WebCore:
Because the SVGImage can be cached only once but used multiple times with
different fragmentIdentifiers, SVGImage has to call FrameView::scrollToFragment()
before the image is displayed. If the fragmentIdentifier is not provided
in the URL or it does not exist in the SVGImage, FrameView::scrollToFragment()
has to reset the scrolling anchor of the SVG as if it was not displayed before.
We do not want the previous scrolling anchor to be used when the FrameView
of SVGImage can't scroll to the current fragmentIdentifier for any reason.
Test: http/tests/svg/svg-fragment-url-special-cases.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::resetScrollAnchor):
- page/FrameView.h:
- platform/URL.cpp:
(WebCore::URL::fragmentIdentifier const): Call hasFragmentIdentifier()
instead of repeating the same condition.
(WebCore::decodeURLEscapeSequences):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::findViewAnchor const):
(WebCore::SVGSVGElement::findRootAnchor const):
(WebCore::SVGSVGElement::scrollToAnchor): We want to know whether the SVG
root element could scroll to the fragmentIdentifier or not. If it could not,
FrameView::scrollToAnchor() can still try one last time to do the scrolling
only if anchorElement is not nullptr.
(WebCore::SVGSVGElement::resetScrollAnchor): Reset the FrameView scrolling
state to its initial value.
- svg/SVGSVGElement.h:
LayoutTests:
- http/tests/svg/svg-fragment-url-special-cases-expected.html: Added.
- http/tests/svg/svg-fragment-url-special-cases.html: Added.
- 10:38 AM Changeset in webkit [224972] by
-
- 1 copy in tags/Safari-604.4.7.10.4
Tag Safari-604.4.7.10.4.
- 10:33 AM Changeset in webkit [224971] by
-
- 5 edits in trunk
ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
https://bugs.webkit.org/show_bug.cgi?id=179803
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-17
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
- web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:
Source/WebCore:
Covered by updated tests.
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
- 10:27 AM Changeset in webkit [224970] by
-
- 2 edits in trunk/Source/WebCore
AX: [GTK] Regression: accessibility/gtk/aria-keyshortcuts.html fails after r224953
https://bugs.webkit.org/show_bug.cgi?id=179824
Reviewed by Chris Fleizach.
The failure was due to AXPropertyName::KeyShortcuts not being included in
the group of properties whose value is a string. As a result, the new method
to get string values, AccessibleNode::effectiveStringValueForElement(), was
returning an empty String. This was not caught by the shared set of tests
because at the present time, only WebKitGtk supports aria-keyshortcuts.
No new tests needed. The regression was caught by an existing test.
- accessibility/AccessibleNode.cpp:
(WebCore::isPropertyValueString):
- 10:02 AM Changeset in webkit [224969] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r224952.
This change introduced LayoutTest failures on WK1.
Reverted changeset:
"Use RunLoop and Mode from NetworkingContext if they are
given"
https://bugs.webkit.org/show_bug.cgi?id=179800
https://trac.webkit.org/changeset/224952
- 9:42 AM Changeset in webkit [224968] by
-
- 4 edits2 adds in trunk
[Web Animations] Force a stacking context during animations that animate properties that will force a stacking context
https://bugs.webkit.org/show_bug.cgi?id=179811
Reviewed by Dean Jackson.
Source/WebCore:
The Web Animations specification mandates in section 4.7 (w3c.github.io/web-animations/#side-effects-section) that
"for every property targeted by at least one animation effect that is current or in effect, the user agent must act
as if the will-change property ([css-will-change-1]) on the target element includes the property."
After parsing new keyframes, we check if any of the CSS properties that get animated would end up forcing a stacking
context, and if so, enforce a stacking context during the entire active lifetime of the animation.
Test: webanimations/animation-opacity-animation-crash.html
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::computeStackingContextImpact):
(WebCore::KeyframeEffect::applyAtLocalTime):
- animation/KeyframeEffect.h:
LayoutTests:
Adding a new test that would crash otherwise because we wouldn't adequately force a stacking
context as the animation would begin.
- webanimations/animation-opacity-animation-crash-expected.txt: Added.
- webanimations/animation-opacity-animation-crash.html: Added.
- 8:25 AM Changeset in webkit [224967] by
-
- 2 edits in trunk/Source/WebCore
Update feature status for Visual Viewport API to "In Development"
https://bugs.webkit.org/show_bug.cgi?id=179818
Patch by Ali Juma <ajuma@chromium.org> on 2017-11-17
Reviewed by Frédéric Wang.
Work on this feature has started, tracked by bug 170982.
No new tests since there's no change in behavior.
- features.json:
Nov 16, 2017:
- 10:43 PM Changeset in webkit [224966] by
-
- 2 edits in tags/Safari-605.1.14.1/Source/WebCore
Cherry-pick r224952. rdar://problem/35581599
- 10:41 PM Changeset in webkit [224965] by
-
- 7 edits in tags/Safari-605.1.14.1/Source
Versioning.
- 10:39 PM Changeset in webkit [224964] by
-
- 1 copy in tags/Safari-605.1.14.1
New tag.
- 10:33 PM Changeset in webkit [224963] by
-
- 2 edits in trunk/JSTests
Unreviewed, mark regress-178385.js as memory exhausting
- stress/regress-178385.js:
- 10:17 PM Changeset in webkit [224962] by
-
- 3 edits56 copies32 adds1 delete in trunk/LayoutTests
Unreviewed, rolling out r224921.
https://bugs.webkit.org/show_bug.cgi?id=179813
We shouldn't be doing this (Requested by ap on #webkit).
Reverted changeset:
"Remove the outdated and unmaintained copies of the tests in
wpt/2dcontext/the-canvas-state/."
https://bugs.webkit.org/show_bug.cgi?id=179769
https://trac.webkit.org/changeset/224921
- 10:14 PM Changeset in webkit [224961] by
-
- 5 edits1 copy3 moves1 add in trunk/Source
[WinCairo] Add network (curl) files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=179474
Patch by Yousuke Kimoto <yousuke.kimoto@sony.com> on 2017-11-16
Reviewed by Alex Christensen.
Source/WebCore:
No new behvaior, no new tests.
- PlatformWinCairo.cmake:
- platform/Curl.cmake:
- platform/network/curl/CookieStorageCurl.cpp: Added.
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
- platform/network/curl/NetworkStorageSessionCurl.cpp: Added.
(WebCore::NetworkStorageSession::~NetworkStorageSession):
(WebCore::NetworkStorageSession::context const):
(WebCore::defaultSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::setCookies):
(WebCore::NetworkStorageSession::setCookie):
(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):
(WebCore::NetworkStorageSession::flushCookieStore):
Source/WebKit:
- Shared/curl/WebCoreArgumentCodersCurl.cpp:
(IPC::ArgumentCoder<CertificateInfo>::decode): Fidex return value since currently no operation is needed for wincairo webkit.
(IPC::ArgumentCoder<ResourceError>::decodePlatformData): Fidex return value since currently no operation is needed for wincairo webkit.
- WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp: Renamed from Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp.
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
- WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h: Renamed from Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h.
- 9:49 PM Changeset in webkit [224960] by
-
- 2 edits in trunk/Source/WebCore
Fix occasional crash when adding and removing videos
https://bugs.webkit.org/show_bug.cgi?id=179792
Reviewed by Geoffrey Garen.
In taskCompleted we null out session, and in resume we call _restart on the main thread.
If _restart is called after taskCompleted, we want to do nothing.
Right now we are calling a method on self.session.loader which is a PlatformMediaResourceLoader&
but in ObjC if session is null it will call PlatformMediaResourceLoader::requestResource with a
null this pointer, which crashes. Let's not crash.
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask _restart]):
Early return if we don't have a session.
- 7:36 PM Changeset in webkit [224959] by
-
- 8 edits in trunk
[WinCairo] Update WinCairoRequirements
https://bugs.webkit.org/show_bug.cgi?id=179790
Reviewed by Alex Christensen.
.:
- Source/cmake/OptionsWinCairo.cmake:
Source/WebCore:
No new tests. No change in behavior.
- PlatformWin.cmake:
Source/WebKit:
- PlatformWin.cmake:
Tools:
- TestWebKitAPI/PlatformWin.cmake:
- 7:28 PM Changeset in webkit [224958] by
-
- 6 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline skipped / flaky service worker tests
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
- 7:25 PM Changeset in webkit [224957] by
-
- 7 edits1 copy in trunk/Source/WebCore
[Web Animations] Allow KeyframeEffect to support CSS property animation blending
https://bugs.webkit.org/show_bug.cgi?id=179810
Reviewed by Tim Horton.
We used to pass nullptr instead of a valid AnimationBase when calling CSSPropertyAnimation::blendProperties()
in KeyframeEffect::applyAtLocalTime() when blending CSS styles during a keyframe animation. Without this
AnimationBase, some blending functions would crash as certain supporting calls couldn't be made.
We now add a new CSSPropertyBlendingClient virtual interface that both KeyframeEffect and AnimationBase
implement and that CSSPropertyAnimation::blendProperties() take as a parameter in order to support
blending code.
- WebCore.xcodeproj/project.pbxproj:
- animation/CSSPropertyBlendingClient.h: Added.
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyAtLocalTime):
(WebCore::KeyframeEffect::renderer const):
(WebCore::KeyframeEffect::currentStyle const):
- animation/KeyframeEffect.h:
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::isAccelerated const):
(WebCore::AnimationBase::transformFunctionListsMatch const):
(WebCore::AnimationBase::filterFunctionListsMatch const):
(WebCore::AnimationBase::backdropFilterFunctionListsMatch const):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::blendFilterOperations):
(WebCore::blendFilter):
(WebCore::crossfadeBlend):
(WebCore::PropertyWrapperAcceleratedBackdropFilter::blend const):
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists const):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists const):
(WebCore::CSSPropertyAnimation::blendProperties):
- page/animation/CSSPropertyAnimation.h:
- 6:36 PM Changeset in webkit [224956] by
-
- 29 edits3 adds in trunk
Service Worker should get the body of intercepted requests
https://bugs.webkit.org/show_bug.cgi?id=179776
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
- imported/w3c/web-platform-tests/fetch/api/request/request-init-002-expected.txt:
- imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
- imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt:
- imported/w3c/web-platform-tests/fetch/api/response/response-init-002-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
Source/WebCore:
Test: http/tests/workers/service/service-worker-request-with-body.https.html
Make use of FetchBodyConsumer to store raw data for FetchRequest.
This is used when setting FetchRequest body from a FormData.
If FormData is only bytes (no blob, no file), FetchBodyConsumer will store that data.
This allows Service Worker to get access to simple request bodies.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::fromFormData):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::bodyAsFormData const): Making sure body is set appropriately when used to make fetch load.
- Modules/fetch/FetchBody.h: Making some methods private.
- Modules/fetch/FetchBodyConsumer.h: Adding accessors.
(WebCore::FetchBodyConsumer::hasData const):
(WebCore::FetchBodyConsumer::data const):
- Modules/fetch/FetchRequest.h:
(WebCore::FetchRequest::FetchRequest):
- platform/network/FormData.cpp:
(WebCore::FormData::asSharedBuffer const):
- platform/network/FormData.h:
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent): Setting FetchRequest body based on given FormData.
Source/WebKit:
Pass a FormDataReference when starting fetch IPC.
Convert this FormDataReference in a FormData and using it to set the FetchRequest body properly in Service Worker process.
Forbid fetch interception when URL is not HTTP/HTTPS.
- Platform/IPC/FormDataReference.h:
(IPC::FormDataReference::FormDataReference):
(IPC::FormDataReference::takeData):
(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::startFetch):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::startFetch):
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::startFetch):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::handleFetch):
LayoutTests:
- http/tests/workers/service/resources/service-worker-fetch.js:
- http/tests/workers/service/service-worker-fetch.https-expected.txt:
- http/tests/workers/service/resources/service-worker-request-with-body-worker.js: Added.
- http/tests/workers/service/service-worker-request-with-body.https-expected.txt: Added.
- http/tests/workers/service/service-worker-request-with-body.https.html: Added.
- 6:32 PM Changeset in webkit [224955] by
-
- 5 edits in trunk/Source/WebCore
Make sure service workers get terminated between tests
https://bugs.webkit.org/show_bug.cgi?id=179774
Reviewed by Alex Christensen.
Make sure service workers get terminated between tests. Previously, we
would merely clear all registrations and job queues but it would not
cause the registrations' service workers to get terminated.
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::updateExtendedEventsSet):
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::clearAll):
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryClearRegistration):
(WebCore::SWServerJobQueue::clearRegistration):
- workers/service/server/SWServerJobQueue.h:
- 6:29 PM Changeset in webkit [224954] by
-
- 3 edits in trunk/Source/WebCore
FetchLoader should unregister its blob URL
https://bugs.webkit.org/show_bug.cgi?id=179768
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
Reviewed by Alex Christensen.
No observable change.
Keep the blob URL used for reading and unregister it in destructor.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::~FetchLoader):
(WebCore::FetchLoader::start):
- Modules/fetch/FetchLoader.h:
- 6:24 PM Changeset in webkit [224953] by
-
- 17 edits2 adds in trunk
AX: AOM: Implement string type properties
https://bugs.webkit.org/show_bug.cgi?id=179495
Reviewed by Chris Fleizach.
Source/WebCore:
Implemented the rest of the string type properties for Accessibility
Object Model.
Test: accessibility/mac/AOM-string-properties.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleLiveRegionCreated):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::isPressed const):
(WebCore::AccessibilityNodeObject::isChecked const):
(WebCore::AccessibilityNodeObject::valueDescription const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::supportsAutoComplete const):
(WebCore::AccessibilityObject::autoCompleteValue const):
(WebCore::AccessibilityObject::invalidStatus const):
(WebCore::AccessibilityObject::supportsCurrent const):
(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::currentValue const):
(WebCore::AccessibilityObject::roleDescription const):
(WebCore::AccessibilityObject::keyShortcutsValue const):
(WebCore::AccessibilityObject::placeholderValue const):
(WebCore::AccessibilityObject::isInsideLiveRegion const):
(WebCore::AccessibilityObject::liveRegionAncestor const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::supportsLiveRegion const):
(WebCore::AccessibilityObject::sortDirection const):
(WebCore::AccessibilityObject::supportsHasPopup const):
(WebCore::AccessibilityObject::hasPopupValue const):
(WebCore::AccessibilityObject::supportsPressed const):
(WebCore::AccessibilityObject::checkboxOrRadioValue const):
(WebCore::AccessibilityObject::pressedIsPresent const):
(WebCore::AccessibilityObject::buttonRoleType const):
(WebCore::AccessibilityObject::supportsARIAAutoComplete const): Deleted.
(WebCore::AccessibilityObject::ariaAutoCompleteValue const): Deleted.
(WebCore::AccessibilityObject::supportsARIACurrent const): Deleted.
(WebCore::AccessibilityObject::ariaCurrentState const): Deleted.
(WebCore::AccessibilityObject::ariaCurrentValue const): Deleted.
(WebCore::AccessibilityObject::ariaKeyShortcutsValue const): Deleted.
(WebCore::AccessibilityObject::isInsideARIALiveRegion const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionAncestor const): Deleted.
(WebCore::AccessibilityObject::supportsARIALiveRegion const): Deleted.
(WebCore::AccessibilityObject::supportsARIAHasPopup const): Deleted.
(WebCore::AccessibilityObject::ariaPopupValue const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPressed const): Deleted.
(WebCore::AccessibilityObject::ariaPressedIsPresent const): Deleted.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::hasPopup const):
(WebCore::AccessibilityObject::liveRegionStatus const):
(WebCore::AccessibilityObject::liveRegionRelevant const):
(WebCore::AccessibilityObject::liveRegionAtomic const):
(WebCore::AccessibilityObject::ariaHasPopup const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionStatus const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionRelevant const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionAtomic const): Deleted.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPopup const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::orientation const):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::liveRegionStatus const):
(WebCore::AccessibilityRenderObject::liveRegionRelevant const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
(WebCore::AccessibilityRenderObject::ariaHasPopup const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic const): Deleted.
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibleNode.cpp:
(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueString):
(WebCore::AccessibleNode::notifyAttributeChanged):
(WebCore::AccessibleNode::autocomplete const):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::checked const):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::current const):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::hasPopUp const):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::invalid const):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::keyShortcuts const):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::orientation const):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::placeholder const):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::pressed const):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::relevant const):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::role const):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::roleDescription const):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::sort const):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueText const):
(WebCore::AccessibleNode::setValueText):
- accessibility/AccessibleNode.h:
(WebCore::AXPropertyHashTraits::constructDeletedValue):
(WebCore::AXPropertyHashTraits::isDeletedValue):
- accessibility/AccessibleNode.idl:
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(atkRole):
(setAtkStateSetFromCoreObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHasPopup]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAPressed]):
(-[WebAccessibilityObjectWrapper accessibilityARIACurrentStatus]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
LayoutTests:
- accessibility/accessibility-object-model.html:
- accessibility/mac/AOM-string-properties-expected.txt: Added.
- accessibility/mac/AOM-string-properties.html: Added.
- 5:34 PM Changeset in webkit [224952] by
-
- 2 edits in trunk/Source/WebCore
Use RunLoop and Mode from NetworkingContext if they are given
https://bugs.webkit.org/show_bug.cgi?id=179800
<rdar://problem/35519421>
Reviewed by Brady Eidson.
We used to call [NSURLConnection scheduleInRunLoop:forMode:] before r224267.
That change broke WebKitLegacy clients using custom run loop modes, which I partially fixed in r224687 and r224896,
but that hangs if there are any non-scheduled calls to callOnMainThread and it ignores the CFRunLoop part of the SchedulePair.
This is a more elegant solution that fixes all known bugs with custom run loop modes and makes the
behavior as close to the pre-r224267 behavior as possible by using all parameters in a good way.
I verified the bug in the radar is fixed, the API test WebKitLegacy.ScheduleInRunLoop still passes,
and UIWebView still works on iOS.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(callOnMainThreadOrSchedule):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):
- 5:30 PM Changeset in webkit [224951] by
-
- 2 edits in tags/Safari-605.1.14/Source/WTF
Revert r224907. rdar://problem/35519421
- 5:17 PM Changeset in webkit [224950] by
-
- 17 edits in trunk
Add feature define for alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179692
Part of <rdar://problem/34917108>
Reviewed by Andy Estes.
Only enabled on Cocoa platforms by default.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 5:15 PM Changeset in webkit [224949] by
-
- 7 edits in trunk/Source
Versioning.
- 5:04 PM Changeset in webkit [224948] by
-
- 2 edits in trunk/JSTests
Mark test262/test/language/statements/class/definition/fn-name-static-precedence.js as passing after r224927.
Unreviewed test gardening.
- test262.yaml:
- 4:59 PM Changeset in webkit [224947] by
-
- 21 edits in trunk
[Service Worker] Implement "Try Clear Registration" algorithm
https://bugs.webkit.org/show_bug.cgi?id=179791
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline several WPT tests that are now passing or failing later.
- web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
- web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:
- web-platform-tests/service-workers/service-worker/ready.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:
Source/WebCore:
Implement "Try Clear Registration" algorithm:
In particular, a SWServerRegistration now knows if it is "in use" by a given
service worker client (i.e. The registration's active service worker is
controlling the service worker client). See:
- https://w3c.github.io/ServiceWorker/#selection (last paragraph)
No new tests, rebaselined existing tests.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::setActiveServiceWorker):
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::serviceWorkerStartedControllingClient):
(WebCore::SWServer::Connection::serviceWorkerStoppedControllingClient):
(WebCore::SWServer::serviceWorkerStartedControllingClient):
(WebCore::SWServer::serviceWorkerStoppedControllingClient):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::tryClearRegistration):
- workers/service/server/SWServerRegistration.h:
(WebCore::SWServerRegistration::hasClientsUsingRegistration const):
(WebCore::SWServerRegistration::addClientUsingRegistration):
(WebCore::SWServerRegistration::removeClientUsingRegistration):
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::serviceWorkerStartedControllingClient):
(WebKit::WebSWClientConnection::serviceWorkerStoppedControllingClient):
- WebProcess/Storage/WebSWClientConnection.h:
- 4:52 PM Changeset in webkit [224946] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179773
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:48 PM Changeset in webkit [224945] by
-
- 11 edits in trunk/Source
REGRESSION(r224179): layer flush now requires sync IPC to compute undo/redo availability in EditorState
https://bugs.webkit.org/show_bug.cgi?id=179797
Reviewed by Simon Fraser.
Source/WebCore:
Editor::canUndo and Editor::CanRedo no longer need to be exported.
- editing/Editor.h:
Source/WebKit:
r224179 introduced a performance regression. The newly-added code in WebPage::editorState is
part of a performance-critical path. (The editor state is computed and sent to the UI
process during the layer flush.) Calls to Editor::canUndo and Editor::canRedo were added,
but these calls are both implemented with sync IPC calls to WebPageProxy in the UI process.
WebPageProxy passes them along to PageClientImpl to compute the availability of the
commands.
That's all pointless because this code only exists for the purpose of getting editing
command availability to the UI process. In the case of undo and redo, it's not needed at
all. I did not realize that when writing the code. So canUndo and canRedo should be removed
from EditorState. This ought to be sufficient to avoid the perf regression.
No changes are needed to the GTK/WPE WebKitEditorState API. The API is reimplemented using
WebPageProxy::canUndoRedo instead of EditorState. There should be no changes in behavior,
only performance.
- Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
- UIProcess/API/glib/WebKitEditorState.cpp:
(webkitEditorStateCreate):
(webkitEditorStateChanged):
- UIProcess/API/glib/WebKitEditorStatePrivate.h:
- UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_get_editor_state):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canUndo):
(WebKit::WebPageProxy::canRedo):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState const):
- 4:45 PM Changeset in webkit [224944] by
-
- 6 edits2 adds in trunk
Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC
https://bugs.webkit.org/show_bug.cgi?id=179751
Reviewed by Geoffrey Garen.
Source/WebCore:
Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC. We
need to make sure that a ServiceWorkerRegistration's wrapper stays alive as long as
we may dispatch events on it.
Keep the wrapper alive by making ServiceWorker an ActiveDOMObject and making sure the
implementation object keeps a PendingActivity alive while it may dispatch JS events.
The only event dispatched on ServiceWorkerRegistration objects is the "updatefound"
one. We may dispatch updatefound events on a ServiceWorkerRegistration until the
registration gets cleared on server side, in which case the ServiceWorkerRegistration
object ends up with no service worker. We therefore take a PendingActivity when the
ServiceWorkerRegistration is constructed and we release it once the registration has
no more associated ServiceWorker or the ActiveDOMObject is stopped (to avoid leaks on
navigation).
Test: http/tests/workers/service/service-worker-registration-gc-event.html
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::getOrCreate):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):
(WebCore::ServiceWorkerRegistration::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerRegistration::stop):
(WebCore::ServiceWorkerRegistration::updatePendingActivityForEventDispatch):
- workers/service/ServiceWorkerRegistration.h:
- workers/service/ServiceWorkerRegistration.idl:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/service-worker-registration-gc-event-expected.txt: Added.
- http/tests/workers/service/service-worker-registration-gc-event.html: Added.
- 4:35 PM Changeset in webkit [224943] by
-
- 3 edits in trunk/Source/WebCore
Crash in WebCore::SWServerJobQueue::scriptFetchFinished(WebCore::SWServer::Connection&, WebCore::ServiceWorkerFetchResult const&) + 77
https://bugs.webkit.org/show_bug.cgi?id=179394
<rdar://problem/35478190>
Reviewed by Youenn Fablet.
In SWServerJobQueue::scriptFetchFinished(), make sure the job queue is still processing the
job that triggered the fetch. If it is not, ignore the callback.
This could happen when calling SWServer::clear() while a script fetch was pending.
No new tests, already covered by existing tests that sometimes crash on the bots.
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):
- workers/service/server/SWServerJobQueue.h:
- 4:35 PM Changeset in webkit [224942] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a bug with cpuid in the FTL.
Rubber stamped by Mark Lam.
Before uploading the previous patch, I tried to condense the code. I
accidentally removed a crucial line saying that CPUID clobbers various
registers.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCPUIntrinsic):
- 4:28 PM Changeset in webkit [224941] by
-
- 2 edits in trunk/Source/WebCore
Crash in worker tests handling the m_stoppedCallback.
<rdar://problem/35590875> and https://bugs.webkit.org/show_bug.cgi?id=179798
Reviewed by Chris Dumez.
No new tests (Covered by existing tests).
Protect manipulation of m_stoppedCallback with m_threadCreationAndWorkerGlobalScopeMutex.
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
- 4:26 PM Changeset in webkit [224940] by
-
- 3 edits in trunk/LayoutTests
Marked svg/wicd/test-rightsizing-a.xhtml as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179176
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 3:56 PM Changeset in webkit [224939] by
-
- 11 edits in trunk
[Web Animations] Express time in milliseconds through the API
https://bugs.webkit.org/show_bug.cgi?id=179799
Patch by Antoine Quint <Antoine Quint> on 2017-11-16
Reviewed by Simon Fraser.
Source/WebCore:
While internally we use seconds to specify times and durations, the Web Animations API
uses milliseconds, so we have to convert times and durations from and to milliseconds.
- animation/AnimationEffectTiming.h:
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::bindingsCurrentTime):
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::bindingsCurrentTime const):
(WebCore::WebAnimation::setBindingsCurrentTime):
- testing/Internals.cpp:
(WebCore::Internals::setTimelineCurrentTime):
LayoutTests:
Update tests to use milliseconds rather than seconds.
- http/wpt/wk-web-animations/timing-model/animation-current-time.html:
- http/wpt/wk-web-animations/timing-model/animation-interface-start-time-property.html:
- http/wpt/wk-web-animations/timing-model/animation-playback-rate.html:
- http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html:
- http/wpt/wk-web-animations/timing-model/timeline-current-time.html:
- 3:44 PM Changeset in webkit [224938] by
-
- 21 edits in trunk/Source/JavaScriptCore
Add some X86 intrinsics to $vm to help with some perf testing
https://bugs.webkit.org/show_bug.cgi?id=179693
Reviewed by Mark Lam.
I've been doing some local perf testing of various ideas and have
had these come in handy. I'm going to land them to dollarVM to prevent
having to add them to my local build every time I do perf testing.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::mfence):
(JSC::MacroAssemblerX86Common::rdtsc):
(JSC::MacroAssemblerX86Common::pause):
(JSC::MacroAssemblerX86Common::cpuid):
- assembler/X86Assembler.h:
(JSC::X86Assembler::rdtsc):
(JSC::X86Assembler::pause):
(JSC::X86Assembler::cpuid):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.h:
(JSC::DFG::Node::intrinsic):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCPUIntrinsic):
- runtime/Intrinsic.cpp:
(JSC::intrinsicName):
- runtime/Intrinsic.h:
- tools/JSDollarVM.cpp:
(JSC::functionCpuMfence):
(JSC::functionCpuRdtsc):
(JSC::functionCpuCpuid):
(JSC::functionCpuPause):
(JSC::functionCpuClflush):
(JSC::JSDollarVM::finishCreation):
- 3:27 PM Changeset in webkit [224937] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r224887): GCC 5 build broken
https://bugs.webkit.org/show_bug.cgi?id=179750
Reviewed by Jer Noble.
Add a legacy FourCC constructor that will be used only when building with GCC 5. This is
bad, but it seems acceptable for use with a fallback codepath.
Unfortunately, this requires adjusting some initializations to avoid ambiguity with the
uint32_t constructor.
- platform/graphics/FourCC.h:
(WebCore::FourCC::FourCC):
- platform/graphics/iso/ISOBox.cpp:
(WebCore::ISOBox::peekBox):
- platform/graphics/iso/ISOBox.h:
- platform/graphics/iso/ISOOriginalFormatBox.h:
- platform/graphics/iso/ISOSchemeTypeBox.h:
- 2:27 PM Changeset in webkit [224936] by
-
- 2 edits in trunk/LayoutTests
Marked multiple http/tests/cache/disk-cache/ tests as flaky.
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:59 PM Changeset in webkit [224935] by
-
- 2 edits in trunk/Source/WebCore
[Payment Request] Update feature status to "Supported In Preview"
https://bugs.webkit.org/show_bug.cgi?id=179793
Reviewed by Tim Horton.
- features.json:
- 12:38 PM Changeset in webkit [224934] by
-
- 3 edits in trunk/Source/WebCore
Clean up KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=179777
Patch by Antoine Quint <Antoine Quint> on 2017-11-16
Reviewed by Daniel Bates.
A few review comments came in after https://bugs.webkit.org/show_bug.cgi?id=179707 landed,
addressing them with this follow-up patch.
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create): Use "keyframeEffect" instead of "result" for clarity.
(WebCore::KeyframeEffect::processKeyframes): Use consistent index and length types while iterating
over properties in PropertyNameArray and explicitly size the properties array since we already
know its final size.
- dom/Element.cpp:
(WebCore::Element::getAnimations):
- 12:26 PM Changeset in webkit [224933] by
-
- 16 edits in trunk/Source/WebCore
Always invoke RenderObject::insertedIntoTree/willBeRemovedFromTree
https://bugs.webkit.org/show_bug.cgi?id=178007
Reviewed by Antti Koivisto.
Based on Antti Koivisto's patch:
These call are currently skipped in some cases making them bug prone and difficult to reason about.
This is done as an optimization that doesn't appear to be valuable anymore.
Covered by existing tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::dropAnonymousBoxChild):
(WebCore::RenderBlock::takeChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::moveAllChildrenIncludingFloatsTo):
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveAllChildrenTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::addChild):
(WebCore::RenderElement::takeChild):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::takeChildInternal):
(WebCore::RenderElement::handleDynamicFloatPositionChange):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::childBecameNonInline):
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::takeChild):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::collapseAndDestroyAnonymousSiblingRows):
- style/RenderTreeUpdaterMultiColumn.cpp:
(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):
- 12:07 PM Changeset in webkit [224932] by
-
- 2 edits in tags/Safari-605.1.14/Source/WTF
Cherry-pick r224907. rdar://problem/35519421
- 12:02 PM Changeset in webkit [224931] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001.htm is an ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=179786
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
- TestExpectations: Temporarily marking test as failing.
- 11:33 AM Changeset in webkit [224930] by
-
- 13 edits in trunk/Source/WebKit
Remove allowBlockSelection as block selection is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=179738
Reviewed by Tim Horton.
Remove all instances of the alloweBlockSelection flag. Blocks selection is fully disabled
and thus this flag will do nothing. This was only added as a debug measure last year, and nothing
ever actually used it.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsBlockSelection]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]): Deleted.
(-[WKWebViewConfiguration _setAllowsBlockSelection:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::allowsBlockSelection): Deleted.
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- 11:19 AM Changeset in webkit [224929] by
-
- 27 edits2 copies in trunk/Source/WebCore
Add a base class for HTMLCanvasElement and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=179701
<rdar://problem/35545195>
Reviewed by Sam Weinig.
In order for OffscreenCanvas to be able to create a WebGLRenderingContext,
there needs to be a shared base class with HTMLCanvasElement. Add such a
class called CanvasBase.
There is a lot of potential for functionality to move into the base class, but
unfortunately HTMLCanvasElement is a bit messy. It implements a lot of the 2d
rendering context functionality, and also many const functions that actually
cause changes. Thus, things like the canvas size have to remain in the subclasses
for now.
The existence of the new base class meant the canvas() accessor in CanvasRenderingContext
had to move out into the subclasses, and do the correct casting. Eventually, at least
for WebGLRenderingContext, this will have a change in behaviour, but for now we only
ever use HTMLCanvasElements, so most of these changes are just for the sake of
compilation.
No behaviour change - covered by existing tests.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/CanvasBase.cpp: Copied from Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h.
(WebCore::CanvasBase::CanvasBase): New base class.
(WebCore::CanvasBase::asHTMLCanvasElement): Casts to an HTMLCanvasElement*, which many of the
rendering context code uses.
- html/CanvasBase.h: Copied from Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h.
(WebCore::CanvasBase::isHTMLCanvasElement const):
(WebCore::CanvasBase::isOffscreenCanvas const):
(WebCore::CanvasBase::setOriginClean):
(WebCore::CanvasBase::setOriginTainted):
(WebCore::CanvasBase::originClean const):
(WebCore::CanvasBase::securityOrigin const):
(WebCore::CanvasBase::scriptExecutionContext const):
- html/HTMLCanvasElement.cpp: Use the base class methods where possible.
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::toBlob):
(WebCore::HTMLCanvasElement::createImageBuffer const): Be explict as to
which of the derived classes scriptExecutionContext() method we are calling.
- html/HTMLCanvasElement.h: Use the base class, mark a few things as virtual,
and remove the parts that are now in CanvasBase.
- html/OffscreenCanvas.cpp: Use the base class.
(WebCore::OffscreenCanvas::OffscreenCanvas):
(WebCore::OffscreenCanvas::size const):
(WebCore::OffscreenCanvas::setSize):
- html/OffscreenCanvas.h:
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::CanvasRenderingContext):
(WebCore::CanvasRenderingContext::ref): Call the correct ref/deref functions, depending
on the base class type.
(WebCore::CanvasRenderingContext::deref):
(WebCore::CanvasRenderingContext::wouldTaintOrigin): We no longer have a canvas() method.
(WebCore::CanvasRenderingContext::checkOrigin):
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::canvasBase const): Add this accessor to the base canvas object
to replace the canvas() call.
(WebCore::CanvasRenderingContext::checkOrigin):
(WebCore::CanvasRenderingContext::ref): Deleted.
(WebCore::CanvasRenderingContext::deref): Deleted.
(WebCore::CanvasRenderingContext::canvas const): Deleted.
- html/canvas/CanvasRenderingContext2D.cpp: Use the base class.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/GPUBasedCanvasRenderingContext.h:
(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):
- html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::ImageBitmapRenderingContext):
(WebCore::ImageBitmapRenderingContext::canvas const):
(WebCore::ImageBitmapRenderingContext::setOutputBitmap):
- html/canvas/ImageBitmapRenderingContext.h:
- html/canvas/PlaceholderRenderingContext.cpp:
(WebCore::PlaceholderRenderingContext::PlaceholderRenderingContext):
- html/canvas/PlaceholderRenderingContext.h:
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create): Assume that we're still getting an HTMLCanvasElement,
but protect some of the logic just in case we don't.
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::canvas):
(WebCore::WebGLRenderingContextBase::checkForContextLossHandling):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::addActivityStateChangeObserverIfNecessary):
(WebCore::WebGLRenderingContextBase::removeActivityStateChangeObserver):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContextBase::reshape):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::isContextLostOrPending):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::printToConsole):
(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::dispatchContextChangedEvent):
(WebCore::WebGLRenderingContextBase::clampedCanvasSize):
- html/canvas/WebGLRenderingContextBase.h:
- html/canvas/WebGLRenderingContextBase.idl:
- html/canvas/WebGPURenderingContext.cpp:
(WebCore::WebGPURenderingContext::create):
(WebCore::WebGPURenderingContext::WebGPURenderingContext):
(WebCore::WebGPURenderingContext::canvas const):
(WebCore::WebGPURenderingContext::clampedCanvasSize const):
- html/canvas/WebGPURenderingContext.h:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::didEnableExtension):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::willDeleteProgram):
(WebCore::InspectorInstrumentation::isShaderProgramDisabled):
- inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didEnableExtension):
(WebCore::InspectorCanvasAgent::didCreateProgram):
- 11:13 AM Changeset in webkit [224928] by
-
- 3 edits2 adds in trunk
Source/WebCore:
Added mime type check to the picture source preloader to avoid downloading incompatible resources.
https://bugs.webkit.org/show_bug.cgi?id=179231
Patch by Colin Bendell <colin> on 2017-11-16
Reviewed by Alex Christensen.
Test: http/tests/loading/preload-picture-type.html
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): include type match state when selecting candidate imgs
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): added type attribute evaluation and matching
LayoutTests:
Add tests to ensure that <source> tags are only preloaded when thetype
attribute matches.
https://bugs.webkit.org/show_bug.cgi?id=179231
Patch by Colin Bendell <colin> on 2017-11-16
Reviewed by Alex Christensen.
- http/tests/preload/picture-type-expected.txt: Added.
- http/tests/preload/picture-type.html: Added.
- 11:08 AM Changeset in webkit [224927] by
-
- 7 edits in trunk/Source/JavaScriptCore
It should be easier to reify lazy property names
https://bugs.webkit.org/show_bug.cgi?id=179734
<rdar://problem/35492521>
Reviewed by Keith Miller.
We reify lazy property names in a few different ways, each
specific to the JSCell implementation, in put() instead of having
a special function to do reification. Let's make that simpler.
This patch makes it easier to reify property names in a uniform
manner, and does so in JSFunction. As a follow up I'll use the
same mechanics for:
ClonedArguments callee, iteratorSymbol (Symbol.iterator)
ErrorConstructor stackTraceLimit
ErrorInstance line, column, sourceURL, stack
GenericArguments length, callee, iteratorSymbol (Symbol.iterator)
GetterSetter RELEASE_ASSERT_NOT_REACHED()
JSArray length
RegExpObject lastIndex
StringObject length
- runtime/ClassInfo.h: Add reifyPropertyNameIfNeeded to method table.
- runtime/JSCell.cpp:
(JSC::JSCell::reifyPropertyNameIfNeeded): by default, don't reify.
- runtime/JSCell.h:
- runtime/JSFunction.cpp:
nameandlengthcan be reified.
(JSC::JSFunction::reifyPropertyNameIfNeeded):
(JSC::JSFunction::put):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyName):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyLazyPropertyForHostOrBuiltinIfNeeded):
(JSC::JSFunction::reifyLazyLengthIfNeeded):
(JSC::JSFunction::reifyLazyNameIfNeeded):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
- runtime/JSFunction.h:
(JSC::JSFunction::isLazy):
(JSC::JSFunction::isReified):
- runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectInternal): do the reification here.
- 11:07 AM Changeset in webkit [224926] by
-
- 2 edits in trunk
[WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
https://bugs.webkit.org/show_bug.cgi?id=179730
Reviewed by Carlos Alberto Lopez Perez.
- Source/cmake/OptionsWPE.cmake:
- 10:47 AM Changeset in webkit [224925] by
-
- 2 edits in trunk/Source/WebKit
Whitelist additional IOKit properties based on customer feedback
https://bugs.webkit.org/show_bug.cgi?id=179782
<rdar://problem/35508246>
Reviewed by Dean Jackson.
Expand the IOKit property whitelist to recognize a few more properties as valid based on review of logs
from customer systems and our test infrastructure.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:21 AM Changeset in webkit [224924] by
-
- 6 edits2 adds in trunk
Dispatching an event on a ServiceWorker may fail or crash due to GC
https://bugs.webkit.org/show_bug.cgi?id=179745
Reviewed by Geoffrey Garen.
Source/WebCore:
Dispatching an event on a ServiceWorker may fail or crash due to GC. We need to make sure
that a ServiceWorker's wrapper stays alive as long as we may dispatch events on it.
Keep the wrapper alive by making ServiceWorker an ActiveDOMObject and making sure the
implementation object keeps a PendingActivity alive while it may dispatch JS events.
The only event dispatched on ServiceWorker objects is the "statechange" one. We may
dispatch statechange events on a ServiceWorker until its state becomes "redundant".
We therefore take a PendingActivity when the ServiceWorker's state is or becomes
non-redundant (becoming non redundant can only happen when switching initially from
redundant to installing, at which point the ServiceWorker object is not exposed to
the JS yet). We release the PendingActivity when the ServiceWorker's state becomes
redundant or the ActiveDOMObject is stopped (to avoid leaks on navigation).
Test: http/tests/workers/service/service-worker-gc-event.html
- workers/service/ServiceWorker.cpp:
(WebCore::mutableAllWorkers):
(WebCore::ServiceWorker::removeFromAllWorkers):
(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
(WebCore::ServiceWorker::activeDOMObjectName const):
(WebCore::ServiceWorker::canSuspendForDocumentSuspension const):
(WebCore::ServiceWorker::stop):
(WebCore::ServiceWorker::updatePendingActivityForEventDispatch):
- workers/service/ServiceWorker.h:
- workers/service/ServiceWorker.idl:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/resources/sw-test-pre.js:
- http/tests/workers/service/service-worker-gc-event.html: Added.
- http/tests/workers/service/service-worker-gc-event-expected.txt: Added.
- 10:05 AM Changeset in webkit [224923] by
-
- 10 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline skipped and flaky service workers tests.
- web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
- web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt:
- web-platform-tests/service-workers/service-worker/uncontrolled-page.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
- web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:
- web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
- 9:37 AM Changeset in webkit [224922] by
-
- 2 edits in trunk/LayoutTests
LayoutTest imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179771
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
- TestExpectations: Marking test as flaky until we have full support of SW opaque responses.
- 9:30 AM Changeset in webkit [224921] by
-
- 3 edits41 moves9 adds47 deletes in trunk/LayoutTests
LayoutTests/imported/w3c:
Import 2dcontext/the-canvas-state/ from wpt.
https://bugs.webkit.org/show_bug.cgi?id=179769
Reviewed by Youenn Fablet.
Also remove the outdated and unmaintained copies of those tests.
The only substantive changes are changes from _assertEqual to _assertSame;
that is, from comparing with == to comparing with ===. (I made this
change upstream in 2014.)
- resources/import-expectations.json:
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.bitmap-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.bitmap-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.bitmap.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.bitmap.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.clip-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.clip-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.clip.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.clip.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.fillStyle-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.fillStyle-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.fillStyle.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.fillStyle.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.font-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.font-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.font.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.font.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalAlpha-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalAlpha-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalAlpha.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalAlpha.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalCompositeOperation-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalCompositeOperation-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalCompositeOperation.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalCompositeOperation.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.imageSmoothingEnabled-expected.txt: Added.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.imageSmoothingEnabled.html: Added.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineCap-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineCap-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineCap.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineCap.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineJoin-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineJoin-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineJoin.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineJoin.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineWidth-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineWidth-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineWidth.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineWidth.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.miterLimit-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.miterLimit-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.miterLimit.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.miterLimit.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.path-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.path-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.path.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.path.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowBlur-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowBlur-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowBlur.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowBlur.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowColor-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowColor-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowColor.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowColor.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetX-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetX-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetX.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetX.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetY-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetY-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetY.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetY.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stack-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stack-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stack.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stack.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stackdepth-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stackdepth-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stackdepth.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stackdepth.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.strokeStyle-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.strokeStyle-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.strokeStyle.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.strokeStyle.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textAlign-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textAlign-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textAlign.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textAlign.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textBaseline-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textBaseline-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textBaseline.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textBaseline.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.transformation-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.transformation-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.transformation.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.transformation.html.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.underflow-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.underflow-expected.txt.
- web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.underflow.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.underflow.html.
- web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001-expected.htm: Added.
- web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001.htm: Added.
- web-platform-tests/2dcontext/the-canvas-state/w3c-import.log: Added.
LayoutTests:
Remove the outdated and unmaintained copies of the tests in wpt/2dcontext/the-canvas-state/.
https://bugs.webkit.org/show_bug.cgi?id=179769
Reviewed by Youenn Fablet.
- canvas/philip/tests/2d.state.saverestore.bitmap-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.bitmap.html: Removed.
- canvas/philip/tests/2d.state.saverestore.clip-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.clip.html: Removed.
- canvas/philip/tests/2d.state.saverestore.fillStyle-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.fillStyle.html: Removed.
- canvas/philip/tests/2d.state.saverestore.font-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.font.html: Removed.
- canvas/philip/tests/2d.state.saverestore.globalAlpha-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.globalAlpha.html: Removed.
- canvas/philip/tests/2d.state.saverestore.globalCompositeOperation-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.globalCompositeOperation.html: Removed.
- canvas/philip/tests/2d.state.saverestore.lineCap-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.lineCap.html: Removed.
- canvas/philip/tests/2d.state.saverestore.lineJoin-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.lineJoin.html: Removed.
- canvas/philip/tests/2d.state.saverestore.lineWidth-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.lineWidth.html: Removed.
- canvas/philip/tests/2d.state.saverestore.miterLimit-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.miterLimit.html: Removed.
- canvas/philip/tests/2d.state.saverestore.path-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.path.html: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowBlur-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowBlur.html: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowColor-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowColor.html: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowOffsetX-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowOffsetX.html: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowOffsetY-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.shadowOffsetY.html: Removed.
- canvas/philip/tests/2d.state.saverestore.stack-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.stack.html: Removed.
- canvas/philip/tests/2d.state.saverestore.stackdepth-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.stackdepth.html: Removed.
- canvas/philip/tests/2d.state.saverestore.strokeStyle-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.strokeStyle.html: Removed.
- canvas/philip/tests/2d.state.saverestore.textAlign-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.textAlign.html: Removed.
- canvas/philip/tests/2d.state.saverestore.textBaseline-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.textBaseline.html: Removed.
- canvas/philip/tests/2d.state.saverestore.transformation-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.transformation.html: Removed.
- canvas/philip/tests/2d.state.saverestore.underflow-expected.txt: Removed.
- canvas/philip/tests/2d.state.saverestore.underflow.html: Removed.
- 7:52 AM Changeset in webkit [224920] by
-
- 2 edits in trunk/Tools
Win EWS bots should reboot after N webkit-patch iterations.
https://bugs.webkit.org/show_bug.cgi?id=177970
Reviewed by Brent Fulgham.
- EWSTools/start-queue-win.sh:
- 7:49 AM Changeset in webkit [224919] by
-
- 2 edits in trunk/LayoutTests
Mark http/wpt/offscreen-canvas/getContext-webgl.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=179767
Unreviewed test gardening.
- platform/win/TestExpectations:
- 7:48 AM Changeset in webkit [224918] by
-
- 5 edits in trunk/Source/JavaScriptCore
Provide a runtime option for disabling the optimization of recursive tail calls
https://bugs.webkit.org/show_bug.cgi?id=179765
Reviewed by Mark Lam.
- bytecode/PreciseJumpTargets.cpp:
(JSC::getJumpTargetsForBytecodeOffset):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEnter):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
- runtime/Options.h:
- 7:41 AM Changeset in webkit [224917] by
-
- 2 edits in trunk/LayoutTests
Mark accessibility/accessibility-object-model.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=179766
Unreviewed test gardening.
- platform/win/TestExpectations:
- 7:08 AM Changeset in webkit [224916] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix null pointer dereference in bytecodeDumper
https://bugs.webkit.org/show_bug.cgi?id=179764
Reviewed by Mark Lam.
The problem was just a call to lastSeenCallee() that was unguarded by haveLastSeenCallee().
- bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::printCallOp):
- 7:04 AM Changeset in webkit [224915] by
-
- 3 edits1 add in trunk
REGRESSION (r224592): oss-fuzz: jsc: Null-dereference READ in JSC::JSCell::isObject (4216)
https://bugs.webkit.org/show_bug.cgi?id=179763
<rdar://problem/35550513>
Reviewed by Keith Miller.
JSTests:
Just adding a slightly cleaned-up version of the original fuzzer-found test.
- stress/tdz-this-in-try-catch.js: Added.
(v_6388):
(v_6392):
Source/JavaScriptCore:
Fix null pointer dereference caused by an eliminated tdz_check
The problem was when doing an OSR entry in DFG while |this| was null
(because super() had not yet been called in the constructor of this
subclass), it would be marked as non-null, and the tdz_check eliminated.
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
- 5:49 AM Changeset in webkit [224914] by
-
- 2 edits in trunk/Source/WebCore
Consider non-main frames for frameViewRootLayerDidChange
https://bugs.webkit.org/show_bug.cgi?id=178508
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-16
Reviewed by Antonio Gomes.
No new tests, behavior unchanged.
AsyncScrollingCoordinator::frameViewRootLayerDidChange assumes that frameView is always a
main-frame. It calls ensureRootStateNodeForFrameView, which always attaches a frame node with
null parent ID. It also has an ASSERT to check m_scrollingStateTree->rootStateNode(), instead
of m_scrollingStateTree->stateNodeForID(frameView.scrollLayerID()). This patch makes the
ASSERT more generic. It also adds an early return into ensureRootStateNodeForFrameView when the
node already exists so that the call to attachToStateTree can be skipped. It turns out that that
call is actually only necessary for main frame, so another ASSERT is added to verify it.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange): Modify the ASSERT to
verify the availability of a scrolling node for the frame, not just the root node.
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView): Add an early return to
skip the call to attachToStateTree when the node is actually already available. Add an ASSERT to
ensure that attaching a new node is only necessary for main frames.
- 4:48 AM Changeset in webkit [224913] by
-
- 12 edits3 copies2 adds in trunk
[WPE] Add initial support for WebDriver
https://bugs.webkit.org/show_bug.cgi?id=179727
Reviewed by Michael Catanzaro.
.:
Enable WebDriver by default in WPE.
- Source/cmake/OptionsWPE.cmake:
Source/WebDriver:
Add WPE implementation for platform-specific methods. Move the version handling to a common file
WebDriverServiceGLib.cpp.
- Capabilities.h:
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- glib/WebDriverServiceGLib.cpp: Added.
(WebDriver::parseVersion):
(WebDriver::WebDriverService::platformCompareBrowserVersions):
- gtk/WebDriverServiceGtk.cpp:
- wpe/WebDriverServiceWPE.cpp: Copied from Source/WebDriver/gtk/WebDriverServiceGtk.cpp.
(WebDriver::WebDriverService::platformCapabilities):
(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):
Tools:
Make it possible to run WebDriver tests with WPE.
- Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
- Scripts/webkitpy/port/wpe.py:
(WPEPort.init): Initialize _display_server from options.
(WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.
- Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
(WebDriver.browser_env): Add virtual method to get the environment that should be used.
- Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.
(WebDriverWPE):
(WebDriverWPE.init):
(WebDriverWPE.binary_path):
(WebDriverWPE.browser_name):
(WebDriverWPE.capabilities):
(WebDriverWPE.browser_env):
- Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.init): Update the environment with the one provided by the driver.
- wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.
- 4:22 AM Changeset in webkit [224912] by
-
- 15 edits in trunk/Source/WebCore
[TexMap] Remove use of GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=174860
Reviewed by Žan Doberšek.
Remove remaining uses of GC3D that are not WebGL related:
- Remove the option to create a GC3D to render to the curren OpenGL context.
- Remove the remaining usage of GC3D inside MediaPlayerPrivateGStreamerBase.
- Replace the usage inside TextureMapper with direct OpenGL calls, and use a
VAO when the OpenGL version is higher than 3.2.
This also modifies TextureMapperContextAttributes so all the tested features are
supported when using OpenGL, and we only check for the extensions when using GLES2.
No new tests as there's no behavior change.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
- platform/graphics/GraphicsContext3DPrivate.h:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperContextAttributes.cpp:
(WebCore::TextureMapperContextAttributes::initialize):
- platform/graphics/texmap/TextureMapperContextAttributes.h:
- platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
(WebCore::TextureMapperGC3DPlatformLayer::TextureMapperGC3DPlatformLayer):
(WebCore::TextureMapperGC3DPlatformLayer::makeContextCurrent):
(WebCore::TextureMapperGC3DPlatformLayer::platformContext):
(WebCore::TextureMapperGC3DPlatformLayer::swapBuffersIfNeeded):
(WebCore::TextureMapperGC3DPlatformLayer::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(WebCore::TextureMapperGLData::~TextureMapperGLData):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGLData::getStaticVBO):
(WebCore::TextureMapperGLData::getVAO):
(WebCore::TextureMapperGLData::getShaderProgram):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawBorder):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::clearColor):
(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
(WebCore::TextureMapperGL::draw):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::createTexture):
- platform/graphics/texmap/TextureMapperGL.h:
- 3:26 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:20 AM Changeset in webkit [224911] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK+ and WPE gardening after r224910.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 12:14 AM Changeset in webkit [224910] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: !isAnonymous() in WebCore::RenderMathMLOperator::updateTokenContent
https://bugs.webkit.org/show_bug.cgi?id=166011
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-16
Reviewed by Alejandro G. Castro.
Source/WebCore:
RenderMathMLFencedOperator does not support mathvariant or displaystyle transforms. This is
one of several issues of the mfenced element (see bug 160509). However,
MathMLStyle::updateStyleIfNeeded() still tries to use the implementation of the parent
RenderMathMLOperator class, which only works for non-anonymous operators. This patch skips
the updateTokenContent() calls for anonymous mfenced operators in order to avoid ASSERTION
failures.
Test: mathml/mfenced-displaystyle-and-mathvariant-crash.html
- rendering/mathml/MathMLStyle.cpp:
(WebCore::MathMLStyle::updateStyleIfNeeded): Skip anonymous token elements.
LayoutTests:
Add a crash test checking displaystyle and mathvariant on mfenced operators.
- mathml/mfenced-displaystyle-and-mathvariant-crash-expected.txt: Added.
- mathml/mfenced-displaystyle-and-mathvariant-crash.html: Added.
Nov 15, 2017:
- 7:05 PM Changeset in webkit [224909] by
-
- 20 edits in trunk/Source
Implement basics of "Terminate Service Worker" algorithm.
https://bugs.webkit.org/show_bug.cgi?id=179551
Reviewed by Chris Dumez.
Source/WebCore:
No new tests (No observable behavior change yet).
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::stopIndexedDatabase):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
- workers/WorkerThread.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::terminateWorker):
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::workerContextTerminated):
(WebCore::SWServer::terminateWorker):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::workerTerminated):
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::terminate):
(WebCore::SWServerWorker::contextTerminated):
- workers/service/server/SWServerWorker.h:
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::terminateWorker):
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::terminateWorker):
(WebKit::WebSWContextManagerConnection::workerTerminated):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- 5:17 PM Changeset in webkit [224908] by
-
- 2 edits in trunk/Source/WebKit
Remove access to 'com.apple.mediaaccessibility.public' preferences in WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=179747
<rdar://problem/35367346>
Reviewed by Dean Jackson.
The 'mediaaccessibilityd' process handles access to MediaAccessibility preferences. We don't need
to grant the WebContent Process sandbox access to them.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:36 PM Changeset in webkit [224907] by
-
- 2 edits in trunk/Source/WTF
Fix fast/events/message-port-postMessage-recursive.html after r224896
https://bugs.webkit.org/show_bug.cgi?id=179749
Reviewed by Jer Noble.
- wtf/mac/MainThreadMac.mm:
(WTF::currentRunLoopInCommonMode):
We sometimes run the runloop in kCFRunLoopDefaultMode, which should also have the responsiveness optimization.
This allows the runloop to continue to iterate when we are doing lots of things on the main thread.
CFRunLoop.h has a special definition of these two constants.
- 4:31 PM Changeset in webkit [224906] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: typing colon in property name should advance to value field
https://bugs.webkit.org/show_bug.cgi?id=178795
<rdar://problem/35174674>
Reviewed by Devin Rousso.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._handleNameBeforeInput):
Unlike pressing Tab or Enter, typing ":" in the property name should discard suggestion hint.
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):
We use 250ms debounce before updating this._property.name.
When typing "font-f:", we want to discard suggestion hint (i.e. "font-family"),
and immediately show autocomplete for "font-f" (in this case, invalid property).
- UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.stopEditing):
(WI.SpreadsheetTextField.prototype.discardCompletion):
Call spreadsheetTextFieldDidChange when discarding non-empty suggestion hint.
(WI.SpreadsheetTextField.prototype.detached):
(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion):
(WI.SpreadsheetTextField.prototype._handleBlur):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._applyCompletionHint):
(WI.SpreadsheetTextField.prototype._hideCompletions): Deleted.
- 3:39 PM Changeset in webkit [224905] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r217750): Navigation sidebar broken after closing and re-opening tab
https://bugs.webkit.org/show_bug.cgi?id=179717
<rdar://problem/35551541>
Reviewed by Devin Rousso.
NavigationSidebarPanels should not be created with WI.instanceForClass.
- UserInterface/Views/DebuggerSidebarPanel.js:
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
- UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel):
- UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
- UserInterface/Views/TabContentView.js:
(WI.TabContentView.prototype.get navigationSidebarPanel):
- 3:25 PM Changeset in webkit [224904] by
-
- 6 edits in trunk/Source/WebCore
Log media readyState and networkState as strings
https://bugs.webkit.org/show_bug.cgi?id=179732
Reviewed by Youenn Fablet.
- html/HTMLMediaElement.cpp:
(WebCore::convertEnumerationToString):
(WebCore::HTMLMediaElement::scheduleDelayedAction): Fix logic error.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Fix incorrect log string.
(WebCore::HTMLMediaElement::setNetworkState): Don't cast to int for logging.
(WebCore::HTMLMediaElement::setReadyState): Ditto. Log when autoplay is blocked.
- html/HTMLMediaElementEnums.h:
(PAL::LogArgument<WebCore::HTMLMediaElementEnums::ReadyState>::toString): New.
(PAL::LogArgument<WebCore::HTMLMediaElementEnums::NetworkState>::toString): New.
- platform/graphics/MediaPlayer.cpp:
(WebCore::convertEnumerationToString):
- platform/graphics/MediaPlayerEnums.h:
(PAL::LogArgument<WebCore::MediaPlayerEnums::ReadyState>::toString):
(PAL::LogArgument<WebCore::MediaPlayerEnums::NetworkState>::toString):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Log strings.
- 3:05 PM Changeset in webkit [224903] by
-
- 7 edits in trunk
Service Worker fetch should handle empty responses
https://bugs.webkit.org/show_bug.cgi?id=179740
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
Source/WebCore:
Covered by updated test.
- Modules/streams/ReadableStreamSink.cpp:
(WebCore::ReadableStreamToSharedBufferSink::enqueue): Not create a buffer until actually needed.
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse): Check for null buffers.
LayoutTests:
- http/tests/workers/service/resources/service-worker-fetch-worker.js:
(event.event.request.url.endsWith):
- http/tests/workers/service/resources/service-worker-fetch.js:
(async.test):
- http/tests/workers/service/service-worker-fetch.https-expected.txt:
- 2:56 PM Changeset in webkit [224902] by
-
- 4 edits3 adds in trunk
ReloadFromOrigin loads should not select any service worker
https://bugs.webkit.org/show_bug.cgi?id=179736
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/workers/service/shift-reload-navigation.html
In case of ReloadFromOrigin (equivalent of shift reload), do not select any service worker.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/FrameLoader.h:
(WebCore::FrameLoader::isReloadingFromOrigin const):
LayoutTests:
- http/tests/workers/service/resources/shift-reload-navigation.js: Added.
(async.test):
- http/tests/workers/service/shift-reload-navigation-expected.txt: Added.
- http/tests/workers/service/shift-reload-navigation.html: Added.
- 2:30 PM Changeset in webkit [224901] by
-
- 8 edits in tags/Safari-605.1.14
Cherry-pick r224896. rdar://problem/35519421
- 2:07 PM Changeset in webkit [224900] by
-
- 2 edits in trunk/Source/WebKit
Revert r224885
https://bugs.webkit.org/show_bug.cgi?id=179719
- UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
r224885 was a speculative fix that did not fix anything on the bots.
- 1:50 PM Changeset in webkit [224899] by
-
- 2 edits in trunk/Source/WebCore
AX triggers sync layout while building the render tree on www.macrumors.com.
https://bugs.webkit.org/show_bug.cgi?id=179741
rdar://problem/35462531
Reviewed by Antti Koivisto.
It's unsafe to issue layout while mutating the render tree. If a mutation
requires AX to issue a layout, it needs to be issued in a delayed manner (which the render
tree mutation will trigger anyway).
Unable to reproduce.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
- 1:36 PM Changeset in webkit [224898] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 44
Added a tag for Safari Technology Preview release 44.
- 1:35 PM Changeset in webkit [224897] by
-
- 27 edits in trunk
[Web Animations] Implement basic to-from animations
https://bugs.webkit.org/show_bug.cgi?id=179707
<rdar://problem/34932456>
Source/WebCore:
We can now actually perform an animation, in software only, when provided two keyframes on an AnimationEffect.
To parse a keyframes object from JS, we use the StyleResolver to create RenderStyle objects based on the strings
provided for the property names and values. Then, when the DocumentTimeline indicates that animations are ready
to be updated, we invalidate the style of elements with animations, so that during style resolution we can perform
blending between the RenderStyles for each keyframe.
Reviewed by Dean Jackson.
- animation/AnimationEffect.h:
(WebCore::AnimationEffect::~AnimationEffect): Deleted.
- animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::elementToAnimationsMap const):
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationResolutionTimerFired):
(WebCore::DocumentTimeline::updateAnimations): Renamed from resolveAnimations() since we're not
actually resolving animations, merely invalidating styles in preparation for resolution.
(WebCore::DocumentTimeline::resolveAnimations): Deleted.
- animation/DocumentTimeline.h:
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create): Pass the keyframes argument to setKeyframes() and forward the
exception in case one was raised in the setter.
(WebCore::KeyframeEffect::setKeyframes): Pass the keyframes argument to processKeyframes() and
forward the exception in case one was raised during processing.
(WebCore::KeyframeEffect::processKeyframes): Deal with exactly two keyframes, set at 0 and 1 offsets,
specified in array forms for the keyframes object. As we parse the content of the provided JS object,
we create RenderStyle objects using the element's StyleResolver from a CSS text string we create
based on the property and values as strings.
(WebCore::KeyframeEffect::applyAtLocalTime): Compute the progress based on the local time and duration,
using the existing CSSPropertyAnimation::blendProperties() mechanics to perform the blend between the
from and to keyframes.
- animation/KeyframeEffect.h:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::resolve):
- animation/WebAnimation.h:
- bindings/IDLTypes.h:
(WebCore::IDLObject::nullValue): Make JSC::Strong an optional type.
- dom/Document.h:
(WebCore::Document::existingTimeline const): Provide an explicit method for call sites to check existence
of a timeline before forcing one to be created if missing by calling timeline().
- dom/Element.cpp:
(WebCore::Element::getAnimations): Do not force the creation of a timeline if one isn't already created.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate): When applying styles, account for any Web
Animation applied to the provided element.
LayoutTests:
Reviewed by Dean Jackson.
Update existing tests to explicitly pass null for keyframes and update WPT expectations.
- http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:
- http/wpt/wk-web-animations/interfaces/element-get-animations.html:
- http/wpt/wk-web-animations/timing-model/animation-creation-basic.html:
- http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html:
- http/wpt/wk-web-animations/timing-model/animation-interface-effect-property.html:
- http/wpt/wk-web-animations/timing-model/keyframe-effect-expected.txt:
- http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html:
- http/wpt/wk-web-animations/timing-model/keyframe-effect.html:
- 1:28 PM Changeset in webkit [224896] by
-
- 8 edits in trunk
WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
https://bugs.webkit.org/show_bug.cgi?id=179742
<rdar://problem/35519421>
Reviewed by Jer Noble.
Source/WTF:
In r224687 I fixed loading from scheduled WebViews with custom run loop modes, but in
dispatchFunctionsFromMainThread we have an optimization to yield the run loop if we have already
done more than 50ms of work on the main thread in this run loop iteration. When this happens
and we are running in a custom run loop mode, we disable this responsiveness optimization.
We are calling CFRunLoopRunInMode or [NSRunLoop acceptInputForMode:beforeDate:] in a while loop anyways,
so we would not benefit from a responsiveness optimization. We definitely don't want to reschedule
on the main thread in the common run loop mode in this case.
- wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
- wtf/MainThread.h:
- wtf/generic/MainThreadGeneric.cpp:
(WTF::currentRunLoopInCommonMode):
- wtf/mac/MainThreadMac.mm:
(WTF::currentRunLoopInCommonMode):
- wtf/win/MainThreadWin.cpp:
(WTF::currentRunLoopInCommonMode):
Tools:
- TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
(-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
Load more than one scheduled WebView to test work that typically takes more than 50 ms.
- 1:18 PM Changeset in webkit [224895] by
-
- 1 copy in tags/Safari-605.1.14
Tag Safari-605.1.14.
- 12:07 PM Changeset in webkit [224894] by
-
- 11 edits2 adds in trunk
ASSERTION FAILED: !renderer->needsLayout() in WebCore::RenderBlock::checkPositionedObjectsNeedLayout with MathML
https://bugs.webkit.org/show_bug.cgi?id=178865
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-15
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
MathML token elements can contain HTML elements and hence MathML elements can contain
out-of-flow positioned descendants. Also all MathML elements can be containing block and hence
should position their out-of-flow positioned descendants before calling clearNeedsLayout().
This patch does that in all places in the MathML renderer classes, except a few of them:
- RenderMathMLSpace, which can not have descendants.
- RenderMathMLToken and RenderMathMLOperator, since they will use the layout implementation of RenderMathMLBlock when they contain non-text children.
The patch also fixes an ASSERTION failure in WebCore::RenderBlock::checkPositionedObjectsNeedLayout
due to some descendants that are not laid out.
Test: mathml/out-of-flow-in-token-crash.html
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::layoutBlock): Call layoutPositionedObjects.
(WebCore::RenderMathMLBlock::layoutInvalidMarkup): Ditto and pass the relayoutChildren boolean.
- rendering/mathml/RenderMathMLBlock.h: Add a relayoutChildren boolean to layoutInvalidMarkup.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layoutBlock): Pass the relayoutChildren boolean to layoutInvalidMarkup
and call layoutPositionedObjects.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::layoutBlock): Call layoutPositionedObjects.
- rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layoutBlock): Ditto.
LayoutTests:
Add a test to trigger various clearNeedsLayout() in a MathML containing block with
out-of-flow positioned descendants.
- mathml/out-of-flow-in-token-crash-expected.txt: Added.
- mathml/out-of-flow-in-token-crash.html: Added.
- 12:02 PM Changeset in webkit [224893] by
-
- 3 edits in trunk/LayoutTests
[GTK] accessibility/accessibility-object-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=179723
Reviewed by Chris Fleizach.
Updated the test to support different platforms.
- accessibility/accessibility-object-model-expected.txt:
- accessibility/accessibility-object-model.html:
- 11:50 AM Changeset in webkit [224892] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix tests introduced in r224880.
This is needed because of the changes in r224876.
- http/tests/workers/service/Client-properties.html:
- 11:40 AM Changeset in webkit [224891] by
-
- 6 edits in trunk/LayoutTests
Some service worker tests are flaky due to console log messages
https://bugs.webkit.org/show_bug.cgi?id=179601
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
LayoutTests:
- 11:36 AM Changeset in webkit [224890] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r224830.
- WebProcess/com.apple.WebProcess.sb.in: Add missing sysctl-read permissions needed
to support testing on Mac Mini hardware.
- 11:28 AM Changeset in webkit [224889] by
-
- 15 edits1 copy in trunk/Source
Add ServiceWorker to WebProcess plumbery for FormData fetch responses
https://bugs.webkit.org/show_bug.cgi?id=179694
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
Source/WebCore:
No observable changes since we are not actually loading FormData right now.
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
- workers/service/context/ServiceWorkerFetch.h:
Source/WebKit:
Added plumbery from Service Worker up to Web Process to pass form data response bodies.
A follow-up patch should read the data from Network Process and send it to the ResourceLoader.
- Platform/IPC/FormDataReference.h: Added.
(IPC::FormDataReference::FormDataReference):
(IPC::FormDataReference::takeData):
(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::didReceiveFetchFormData):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didReceiveFetchFormData):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveFormData):
- WebProcess/Storage/ServiceWorkerClientFetch.h:
- WebProcess/Storage/ServiceWorkerClientFetch.messages.in:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormData):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
- 11:22 AM Changeset in webkit [224888] by
-
- 2 edits in trunk
Unreviewed, sort async iteration feature.
- Source/cmake/WebKitFeatures.cmake:
- 11:06 AM Changeset in webkit [224887] by
-
- 10 edits in trunk/Source/WebCore
Add a compile-time-checked string literal initializer for FourCC.
https://bugs.webkit.org/show_bug.cgi?id=179706
Reviewed by Alex Christensen.
Add a contexpr constructor for FourCC that takes a string literal and static_asserts that it
is exactly 4 chars long. Use this string literal constructor everywhere instead of multi-
character literals.
- platform/graphics/FourCC.h:
(WebCore::FourCC::FourCC):
- platform/graphics/iso/ISOBox.cpp:
(WebCore::ISOBox::parse):
- platform/graphics/iso/ISOOriginalFormatBox.h:
(WebCore::ISOOriginalFormatBox::boxTypeName):
- platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
(WebCore::ISOProtectionSchemeInfoBox::boxTypeName):
- platform/graphics/iso/ISOSchemeInformationBox.h:
(WebCore::ISOSchemeInformationBox::boxTypeName):
- platform/graphics/iso/ISOSchemeTypeBox.h:
(WebCore::ISOSchemeTypeBox::boxTypeName):
- platform/graphics/iso/ISOTrackEncryptionBox.h:
(WebCore::ISOTrackEncryptionBox::boxTypeName):
- platform/graphics/iso/ISOVTTCue.h:
(WebCore::ISOWebVTTCue::boxTypeName):
- 10:48 AM Changeset in webkit [224886] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r223781.
The test is now returning false, so the FIXME is not needed
anymore.
Reverted changeset:
"WebsiteDataStoreCustomPaths.mm is failing after r223718"
https://bugs.webkit.org/show_bug.cgi?id=178596
https://trac.webkit.org/changeset/223781
- 10:36 AM Changeset in webkit [224885] by
-
- 2 edits in trunk/Source/WebKit
Move a compiled WKContentRuleList to its destination before calling mmap
https://bugs.webkit.org/show_bug.cgi?id=179719
Reviewed by Brady Eidson.
Right now we compile a WKContentRuleList to a temporary file, call mmap, close the file, then move it.
Sometimes, especially on bots running tests, the move fails because the temporary file doesn't exist
any more. Moving the file before mmaping and closing the file might prevent this failure.
- UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
- 10:31 AM Changeset in webkit [224884] by
-
- 2 edits in trunk
REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures
https://bugs.webkit.org/show_bug.cgi?id=179704
Reviewed by Yusuke Suzuki.
Add feature flag for Async iteration.
- Source/cmake/WebKitFeatures.cmake:
- 10:24 AM Changeset in webkit [224883] by
-
- 2 edits in trunk/LayoutTests
Adjusted expectations for compositing/repaint/fixed-background-scroll.html.
https://bugs.webkit.org/show_bug.cgi?id=154612
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:06 AM Changeset in webkit [224882] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=179729
Reviewed by Michael Catanzaro.
No new tests needed.
- platform/graphics/cairo/CairoOperations.h: Make the forward declaration use "struct"
as the actual implementation of the type does.
- 10:04 AM Changeset in webkit [224881] by
-
- 7 edits in branches/safari-604.4.7.1-branch/Source
Versioning.
- 10:00 AM Changeset in webkit [224880] by
-
- 30 edits2 copies7 adds in trunk
[Service Workers] Implement Client API
https://bugs.webkit.org/show_bug.cgi?id=179709
Reviewed by Alex Christensen.
Source/WebCore:
Implement Client API as per:
Tests:
http/tests/workers/service/Client-properties.html
http/tests/workers/service/Client-properties-subframe.html
http/tests/workers/service/Client-properties-auxiliary.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):
- workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::url const):
(WebCore::ServiceWorkerClient::type const):
(WebCore::ServiceWorkerClient::frameType const):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):
- workers/service/ServiceWorkerClient.h:
(WebCore::ServiceWorkerClient::create):
- workers/service/ServiceWorkerClientData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp.
(WebCore::toServiceWorkerClientFrameType):
(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::from):
- workers/service/ServiceWorkerClientData.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.h.
(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):
- workers/service/ServiceWorkerClientIdentifier.h:
(WebCore::ServiceWorkerClientIdentifier::encode const):
(WebCore::ServiceWorkerClientIdentifier::decode):
- workers/service/ServiceWorkerTypes.h:
- workers/service/ServiceWorkerWindowClient.cpp:
(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):
- workers/service/ServiceWorkerWindowClient.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):
- workers/service/context/SWContextManager.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/server/SWClientConnection.h:
Source/WebKit:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/Client-properties-auxiliary-expected.txt: Added.
- http/tests/workers/service/Client-properties-auxiliary.html: Added.
- http/tests/workers/service/Client-properties-expected.txt: Added.
- http/tests/workers/service/Client-properties-subframe-expected.txt: Added.
- http/tests/workers/service/Client-properties-subframe.html: Added.
- http/tests/workers/service/Client-properties.html: Added.
- http/tests/workers/service/resources/Client-properties-worker.js: Added.
- 9:13 AM Changeset in webkit [224879] by
-
- 113 edits3 moves2 adds in trunk
Unreviewed, rolling out r224863.
Introduced LayoutTest crashes on iOS Simulator.
Reverted changeset:
"Move JSONValues to WTF and convert uses of InspectorValues.h
to JSONValues.h"
https://bugs.webkit.org/show_bug.cgi?id=173793
https://trac.webkit.org/changeset/224863
- 9:06 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 8:59 AM Changeset in webkit [224878] by
-
- 2 edits in trunk/Source/WebKit
Remove access to "com.apple.pbs.fetch_services" from WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=179689
<rdar://problem/35369172>
Reviewed by Per Arne Vollan.
WebKit's WebContent process should not have any need to interact with the fetch_services
API exposed to the system. These interactions (if needed) should be happening in the UIProcess,
so we should prevent the untrusted Web Content Process from being able to connect.
- WebProcess/com.apple.WebProcess.sb.in:
- 8:56 AM Changeset in webkit [224877] by
-
- 9 edits1 delete in trunk
Remove GTK web inspector images
https://bugs.webkit.org/show_bug.cgi?id=179716
Reviewed by Carlos Garcia Campos.
Source/WebInspectorUI:
- Scripts/copy-user-interface-resources.pl:
- UserInterface/Images/gtk/AUTHORS: Removed.
- UserInterface/Images/gtk/ActiveCallFrame.svg: Removed.
- UserInterface/Images/gtk/AnimationPlayStatePaused.svg: Removed.
- UserInterface/Images/gtk/AnimationPlayStateRunning.svg: Removed.
- UserInterface/Images/gtk/ApplicationCache.png: Removed.
- UserInterface/Images/gtk/ApplicationCache@2x.png: Removed.
- UserInterface/Images/gtk/ApplicationCacheManifest.png: Removed.
- UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Removed.
- UserInterface/Images/gtk/ArrowUp.svg: Removed.
- UserInterface/Images/gtk/Assertion.svg: Removed.
- UserInterface/Images/gtk/BackForwardArrows.svg: Removed.
- UserInterface/Images/gtk/Breakpoint.png: Removed.
- UserInterface/Images/gtk/Breakpoint@2x.png: Removed.
- UserInterface/Images/gtk/BreakpointButton.svg: Removed.
- UserInterface/Images/gtk/BreakpointInactive.png: Removed.
- UserInterface/Images/gtk/BreakpointInactive@2x.png: Removed.
- UserInterface/Images/gtk/BreakpointInactiveButton.svg: Removed.
- UserInterface/Images/gtk/Breakpoints.svg: Removed.
- UserInterface/Images/gtk/COPYING: Removed.
- UserInterface/Images/gtk/COPYING_CCBYSA3: Removed.
- UserInterface/Images/gtk/COPYING_LGPL2: Removed.
- UserInterface/Images/gtk/CSSVariable.svg: Removed.
- UserInterface/Images/gtk/CallTrees.svg: Removed.
- UserInterface/Images/gtk/Canvas.svg: Removed.
- UserInterface/Images/gtk/Canvas2D.svg: Removed.
- UserInterface/Images/gtk/Canvas3D.svg: Removed.
- UserInterface/Images/gtk/CanvasOverview.svg: Removed.
- UserInterface/Images/gtk/Checkers.svg: Removed.
- UserInterface/Images/gtk/Circle.svg: Removed.
- UserInterface/Images/gtk/ClearBoth.svg: Removed.
- UserInterface/Images/gtk/ClearLeft.svg: Removed.
- UserInterface/Images/gtk/ClearRight.svg: Removed.
- UserInterface/Images/gtk/ClippingCSS.png: Removed.
- UserInterface/Images/gtk/ClippingCSS@2x.png: Removed.
- UserInterface/Images/gtk/ClippingCSSLarge.png: Removed.
- UserInterface/Images/gtk/ClippingCSSLarge@2x.png: Removed.
- UserInterface/Images/gtk/ClippingGeneric.png: Removed.
- UserInterface/Images/gtk/ClippingGeneric@2x.png: Removed.
- UserInterface/Images/gtk/ClippingGenericLarge.png: Removed.
- UserInterface/Images/gtk/ClippingGenericLarge@2x.png: Removed.
- UserInterface/Images/gtk/ClippingJS.png: Removed.
- UserInterface/Images/gtk/ClippingJS@2x.png: Removed.
- UserInterface/Images/gtk/ClippingJSLarge.png: Removed.
- UserInterface/Images/gtk/ClippingJSLarge@2x.png: Removed.
- UserInterface/Images/gtk/Close.svg: Removed.
- UserInterface/Images/gtk/CloseLarge.svg: Removed.
- UserInterface/Images/gtk/CloseWhite.svg: Removed.
- UserInterface/Images/gtk/ColorIcon.png: Removed.
- UserInterface/Images/gtk/ColorIcon@2x.png: Removed.
- UserInterface/Images/gtk/Console.svg: Removed.
- UserInterface/Images/gtk/Cookie.png: Removed.
- UserInterface/Images/gtk/Cookie@2x.png: Removed.
- UserInterface/Images/gtk/Crosshair.svg: Removed.
- UserInterface/Images/gtk/CubicBezier.svg: Removed.
- UserInterface/Images/gtk/DOMBreakpoint.svg: Removed.
- UserInterface/Images/gtk/DOMCharacterData.svg: Removed.
- UserInterface/Images/gtk/DOMComment.svg: Removed.
- UserInterface/Images/gtk/DOMDocument.svg: Removed.
- UserInterface/Images/gtk/DOMDocumentType.svg: Removed.
- UserInterface/Images/gtk/DOMElement.svg: Removed.
- UserInterface/Images/gtk/DOMNode.svg: Removed.
- UserInterface/Images/gtk/DOMTextNode.svg: Removed.
- UserInterface/Images/gtk/Database.png: Removed.
- UserInterface/Images/gtk/Database@2x.png: Removed.
- UserInterface/Images/gtk/DatabaseTable.png: Removed.
- UserInterface/Images/gtk/DatabaseTable@2x.png: Removed.
- UserInterface/Images/gtk/Debug.svg: Removed.
- UserInterface/Images/gtk/Debugger.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangles.svg: Removed.
- UserInterface/Images/gtk/DockBottom.svg: Removed.
- UserInterface/Images/gtk/DockLeft.svg: Removed.
- UserInterface/Images/gtk/DockRight.svg: Removed.
- UserInterface/Images/gtk/DocumentCSS.png: Removed.
- UserInterface/Images/gtk/DocumentCSS@2x.png: Removed.
- UserInterface/Images/gtk/DocumentCSSLarge.png: Removed.
- UserInterface/Images/gtk/DocumentCSSLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentFont.png: Removed.
- UserInterface/Images/gtk/DocumentFont@2x.png: Removed.
- UserInterface/Images/gtk/DocumentFontLarge.png: Removed.
- UserInterface/Images/gtk/DocumentFontLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentGeneric.png: Removed.
- UserInterface/Images/gtk/DocumentGeneric@2x.png: Removed.
- UserInterface/Images/gtk/DocumentGenericLarge.png: Removed.
- UserInterface/Images/gtk/DocumentGenericLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentImage.png: Removed.
- UserInterface/Images/gtk/DocumentImage@2x.png: Removed.
- UserInterface/Images/gtk/DocumentImageLarge.png: Removed.
- UserInterface/Images/gtk/DocumentImageLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentJS.png: Removed.
- UserInterface/Images/gtk/DocumentJS@2x.png: Removed.
- UserInterface/Images/gtk/DocumentJSLarge.png: Removed.
- UserInterface/Images/gtk/DocumentJSLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentMarkup.png: Removed.
- UserInterface/Images/gtk/DocumentMarkup@2x.png: Removed.
- UserInterface/Images/gtk/DocumentMarkupLarge.png: Removed.
- UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Removed.
- UserInterface/Images/gtk/DownloadArrow.svg: Removed.
- UserInterface/Images/gtk/Elements.svg: Removed.
- UserInterface/Images/gtk/Error.svg: Removed.
- UserInterface/Images/gtk/Errors.svg: Removed.
- UserInterface/Images/gtk/ErrorsEnabled.svg: Removed.
- UserInterface/Images/gtk/EventListener.svg: Removed.
- UserInterface/Images/gtk/Events.svg: Removed.
- UserInterface/Images/gtk/Exception.svg: Removed.
- UserInterface/Images/gtk/Eye.svg: Removed.
- UserInterface/Images/gtk/FilterFieldActiveGlyph.svg: Removed.
- UserInterface/Images/gtk/FilterFieldGlyph.svg: Removed.
- UserInterface/Images/gtk/FloatLeft.svg: Removed.
- UserInterface/Images/gtk/FloatRight.svg: Removed.
- UserInterface/Images/gtk/FolderGeneric.png: Removed.
- UserInterface/Images/gtk/FolderGeneric@2x.png: Removed.
- UserInterface/Images/gtk/FontStyleItalic.svg: Removed.
- UserInterface/Images/gtk/FontStyleNormal.svg: Removed.
- UserInterface/Images/gtk/Function.svg: Removed.
- UserInterface/Images/gtk/Gear.svg: Removed.
- UserInterface/Images/gtk/GoToArrow.svg: Removed.
- UserInterface/Images/gtk/GradientStop.png: Removed.
- UserInterface/Images/gtk/GradientStop@2x.png: Removed.
- UserInterface/Images/gtk/GradientStopSelected.png: Removed.
- UserInterface/Images/gtk/GradientStopSelected@2x.png: Removed.
- UserInterface/Images/gtk/HeapAllocationsInstrument.svg: Removed.
- UserInterface/Images/gtk/HeapSnapshotObjectGraph.svg: Removed.
- UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Removed.
- UserInterface/Images/gtk/HoverMenuButton.png: Removed.
- UserInterface/Images/gtk/HoverMenuButton@2x.png: Removed.
- UserInterface/Images/gtk/IgnoreCaches.svg: Removed.
- UserInterface/Images/gtk/Image.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Removed.
- UserInterface/Images/gtk/Info.svg: Removed.
- UserInterface/Images/gtk/InstructionPointer.png: Removed.
- UserInterface/Images/gtk/InstructionPointer@2x.png: Removed.
- UserInterface/Images/gtk/Issues.svg: Removed.
- UserInterface/Images/gtk/IssuesEnabled.svg: Removed.
- UserInterface/Images/gtk/LayerBorders.svg: Removed.
- UserInterface/Images/gtk/Layers.svg: Removed.
- UserInterface/Images/gtk/LayoutInstrument.svg: Removed.
- UserInterface/Images/gtk/ListStylePositionInside.svg: Removed.
- UserInterface/Images/gtk/ListStylePositionOutside.svg: Removed.
- UserInterface/Images/gtk/LocalStorage.png: Removed.
- UserInterface/Images/gtk/LocalStorage@2x.png: Removed.
- UserInterface/Images/gtk/Locked.svg: Removed.
- UserInterface/Images/gtk/Log.svg: Removed.
- UserInterface/Images/gtk/Logs.svg: Removed.
- UserInterface/Images/gtk/MemoryInstrument.svg: Removed.
- UserInterface/Images/gtk/Minus.svg: Removed.
- UserInterface/Images/gtk/Native.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCheckers.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCodeCoverage.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Removed.
- UserInterface/Images/gtk/NavigationItemGarbageCollect.svg: Removed.
- UserInterface/Images/gtk/NavigationItemTrash.svg: Removed.
- UserInterface/Images/gtk/NavigationItemTypes.svg: Removed.
- UserInterface/Images/gtk/Network.svg: Removed.
- UserInterface/Images/gtk/NetworkInstrument.svg: Removed.
- UserInterface/Images/gtk/NewTab.svg: Removed.
- UserInterface/Images/gtk/NewTabPlus.svg: Removed.
- UserInterface/Images/gtk/Paint.svg: Removed.
- UserInterface/Images/gtk/Path.svg: Removed.
- UserInterface/Images/gtk/Pause.svg: Removed.
- UserInterface/Images/gtk/PausedBreakpoint.svg: Removed.
- UserInterface/Images/gtk/Pencil.svg: Removed.
- UserInterface/Images/gtk/Plus13.svg: Removed.
- UserInterface/Images/gtk/Plus15.svg: Removed.
- UserInterface/Images/gtk/Printer.svg: Removed.
- UserInterface/Images/gtk/Program.svg: Removed.
- UserInterface/Images/gtk/PseudoElement.svg: Removed.
- UserInterface/Images/gtk/Receiving.svg: Removed.
- UserInterface/Images/gtk/Record.svg: Removed.
- UserInterface/Images/gtk/Recording.svg: Removed.
- UserInterface/Images/gtk/Reflection.svg: Removed.
- UserInterface/Images/gtk/ReloadFull.svg: Removed.
- UserInterface/Images/gtk/ReloadToolbar.svg: Removed.
- UserInterface/Images/gtk/RenderingFrame.svg: Removed.
- UserInterface/Images/gtk/RenderingFramesInstrument.svg: Removed.
- UserInterface/Images/gtk/Request.svg: Removed.
- UserInterface/Images/gtk/Resources.svg: Removed.
- UserInterface/Images/gtk/Response.svg: Removed.
- UserInterface/Images/gtk/ResultLine.svg: Removed.
- UserInterface/Images/gtk/Resume.svg: Removed.
- UserInterface/Images/gtk/ScriptsInstrument.svg: Removed.
- UserInterface/Images/gtk/Search.svg: Removed.
- UserInterface/Images/gtk/SearchResults.svg: Removed.
- UserInterface/Images/gtk/Sending.svg: Removed.
- UserInterface/Images/gtk/SessionStorage.png: Removed.
- UserInterface/Images/gtk/SessionStorage@2x.png: Removed.
- UserInterface/Images/gtk/ShadowDOM.svg: Removed.
- UserInterface/Images/gtk/SliderThumb.png: Removed.
- UserInterface/Images/gtk/SliderThumb@2x.png: Removed.
- UserInterface/Images/gtk/SliderThumbPressed.png: Removed.
- UserInterface/Images/gtk/SliderThumbPressed@2x.png: Removed.
- UserInterface/Images/gtk/SortIndicatorArrows.svg: Removed.
- UserInterface/Images/gtk/Source.svg: Removed.
- UserInterface/Images/gtk/SplitToggleUp.svg: Removed.
- UserInterface/Images/gtk/StepInto.svg: Removed.
- UserInterface/Images/gtk/StepOut.svg: Removed.
- UserInterface/Images/gtk/StepOver.svg: Removed.
- UserInterface/Images/gtk/Stop.svg: Removed.
- UserInterface/Images/gtk/Stopwatch.svg: Removed.
- UserInterface/Images/gtk/Storage.svg: Removed.
- UserInterface/Images/gtk/StyleRule.svg: Removed.
- UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Removed.
- UserInterface/Images/gtk/StyleRulePseudoElement.svg: Removed.
- UserInterface/Images/gtk/TailDeletedFunction.svg: Removed.
- UserInterface/Images/gtk/TextAlignCenter.svg: Removed.
- UserInterface/Images/gtk/TextAlignJustify.svg: Removed.
- UserInterface/Images/gtk/TextAlignLeft.svg: Removed.
- UserInterface/Images/gtk/TextAlignRight.svg: Removed.
- UserInterface/Images/gtk/TextDecorationLineThrough.svg: Removed.
- UserInterface/Images/gtk/TextDecorationOverline.svg: Removed.
- UserInterface/Images/gtk/TextDecorationUnderline.svg: Removed.
- UserInterface/Images/gtk/TextTransformCapitalize.svg: Removed.
- UserInterface/Images/gtk/TextTransformLowercase.svg: Removed.
- UserInterface/Images/gtk/TextTransformUppercase.svg: Removed.
- UserInterface/Images/gtk/Thread.svg: Removed.
- UserInterface/Images/gtk/Time.svg: Removed.
- UserInterface/Images/gtk/Timeline.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordAPI.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordAnimation.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordComposite.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordEvent.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordLayout.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordPaint.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordStyle.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordTimer.svg: Removed.
- UserInterface/Images/gtk/ToggleLeftSidebar.svg: Removed.
- UserInterface/Images/gtk/ToggleRightSidebar.svg: Removed.
- UserInterface/Images/gtk/TypeBoolean.svg: Removed.
- UserInterface/Images/gtk/TypeNull.svg: Removed.
- UserInterface/Images/gtk/TypeNumber.svg: Removed.
- UserInterface/Images/gtk/TypeObject.svg: Removed.
- UserInterface/Images/gtk/TypeRegex.svg: Removed.
- UserInterface/Images/gtk/TypeString.svg: Removed.
- UserInterface/Images/gtk/TypeSymbol.svg: Removed.
- UserInterface/Images/gtk/TypeUndefined.svg: Removed.
- UserInterface/Images/gtk/Undock.svg: Removed.
- UserInterface/Images/gtk/UpDownArrows.svg: Removed.
- UserInterface/Images/gtk/UserInputPrompt.svg: Removed.
- UserInterface/Images/gtk/UserInputPromptPrevious.svg: Removed.
- UserInterface/Images/gtk/UserInputResult.svg: Removed.
- UserInterface/Images/gtk/VisualStyleNone.svg: Removed.
- UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Removed.
- UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Removed.
- UserInterface/Images/gtk/Warning.svg: Removed.
- UserInterface/Images/gtk/WebSocket.png: Removed.
- UserInterface/Images/gtk/WebSocket@2x.png: Removed.
- UserInterface/Images/gtk/WebSocketLarge.png: Removed.
- UserInterface/Images/gtk/WebSocketLarge@2x.png: Removed.
- UserInterface/Images/gtk/Weight.svg: Removed.
- UserInterface/Images/gtk/WorkerScript.png: Removed.
- UserInterface/Images/gtk/WorkerScript@2x.png: Removed.
- UserInterface/Images/gtk/WorkerScriptLarge.png: Removed.
- UserInterface/Images/gtk/WorkerScriptLarge@2x.png: Removed.
Source/WebKit:
- InspectorGResources.cmake:
Tools:
- Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):
- glib/generate-inspector-gresource-manifest.py:
(get_filenames.should_ignore_resource):
- gtk/manifest.txt.in:
- wpe/manifest.txt.in:
- 8:24 AM Changeset in webkit [224876] by
-
- 25 edits1 copy in trunk
Remove service worker selection based on registration
https://bugs.webkit.org/show_bug.cgi?id=179705
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/controller-on-reload.https-expected.txt:
Source/WebCore:
Covered by updated tests.
Selection is now handled at navigation time.
We can remove the selection/unselection of worker based on registration.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
LayoutTests:
Updating tests to use actual selected frames.
- http/tests/inspector/network/resource-response-service-worker.html:
- http/tests/inspector/network/resources/fetch-service-worker.js:
- http/tests/workers/service/ServiceWorkerGlobalScope-properties.html:
- http/tests/workers/service/basic-fetch.https-expected.txt:
- http/tests/workers/service/cors-image-fetch-expected.txt:
- http/tests/workers/service/cors-image-fetch.html:
- http/tests/workers/service/image-fetch-expected.txt:
- http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js:
(then):
- http/tests/workers/service/resources/basic-fetch-worker.js:
- http/tests/workers/service/resources/basic-fetch.js:
(async.test):
- http/tests/workers/service/resources/cors-image-fetch.js:
(async.test):
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/cors-image-fetch-iframe.html: Added.
- http/tests/workers/service/resources/image-fetch.js:
(async.test):
(done): Deleted.
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-crossorigin-fetch.js:
(async.test):
(done): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-fetch.js:
(async.test):
(done): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-importScript.js:
(async.test):
(async.logStatus): Deleted.
- http/tests/workers/service/resources/sw-test-pre.js:
(async.interceptedFrame):
- http/tests/workers/service/resources/tainted-image-fetch.js:
(async.test):
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/service-worker-fetch.https-expected.txt:
- http/tests/workers/service/tainted-image-fetch-expected.txt:
- 8:17 AM Changeset in webkit [224875] by
-
- 2 edits in trunk/Tools
REGRESSION(r221877): 'future' handled incorrectly for mac
https://bugs.webkit.org/show_bug.cgi?id=179711
<rdar://problem/35546604>
Reviewed by Alex Christensen.
- Scripts/webkitpy/port/mac.py:
(MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
platform/<version> as the baseline search path.
- 5:26 AM Changeset in webkit [224874] by
-
- 7 edits3 adds2 deletes in trunk/LayoutTests
[GTK][WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=179726
Unreviewed test gardening.
- platform/gtk/TestExpectations: Add new expectations.
- platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt: Rebaseline for bug 179431.
- platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494.
- platform/wpe/TestExpectations: Remove expectations that were redundant with other (more correct) expectations in the same file, or with the new expectation file.
- platform/wpe/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file.
- platform/wpe/fast/workers/self-hasOwnProperty-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file.
- platform/wpe/http/tests/uri/css-href-expected.txt: Added: missing baseline.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: Rebaseline to make the test useful as a regression test.
- platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494.
- 5:00 AM Changeset in webkit [224873] by
-
- 3 edits in trunk/Source/WebCore
[Cairo] GraphicsContext::setPlatformShadow() has to update state's shadow offset when ignoring transforms
https://bugs.webkit.org/show_bug.cgi?id=179725
Reviewed by Carlos Garcia Campos.
In r224753, GraphicsContext::setPlatformShadow() stopped updating the
shadow offset value that's kept in GraphicsContextState. This regressed
a few tests, so the adjustment of the shadow offset value in the
GraphicsContext state is brought back.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setShadowValues):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
- 4:06 AM Changeset in webkit [224872] by
-
- 6 edits in trunk/Source
[GTK] Automatically adjust font size when gtk-xft-dpi changes
https://bugs.webkit.org/show_bug.cgi?id=142673
Some follow-up fixes for the previous patch.
Patch by Gabriel Ivascu <givascu@igalia.com> on 2017-11-15
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- platform/PlatformScreen.h:
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDPIObserverHandlersMap):
(WebCore::gtkXftDPIChangedCallback):
(WebCore::setScreenDPIObserverHandler):
- platform/wpe/PlatformScreenWPE.cpp:
(WebCore::setScreenDPIObserverHandler):
Source/WebKit:
- UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsDispose):
(webKitSettingsConstructed):
Nov 14, 2017:
- 11:56 PM Changeset in webkit [224871] by
-
- 37 edits5 adds in trunk
AX: AOM: Implement AccessibleNode class and support label and role attributes
https://bugs.webkit.org/show_bug.cgi?id=179494
Reviewed by Ryosuke Niwa.
Source/WebCore:
Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/
This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode.
In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new function that first checks the
AOM property and then checks the equivalent ARIA attribute.
Test: accessibility/accessibility-object-model.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
(WebCore::AXObjectCache::handleLiveRegionCreated):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::roleValue const):
(WebCore::AccessibilityImageMapLink::accessibilityDescription const):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue const):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaAccessibilityDescription const):
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::textForLabelElement const):
(WebCore::AccessibilityNodeObject::alternativeText const):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea const):
(WebCore::AccessibilityNodeObject::stringValue const):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasProperty const):
(WebCore::AccessibilityObject::stringValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibleNode.cpp: Added.
(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueString):
(WebCore::AccessibleNode::hasProperty):
(WebCore::AccessibleNode::valueForProperty):
(WebCore::AccessibleNode::effectiveStringValueForElement):
(WebCore::AccessibleNode::stringValueForProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::role const):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
- accessibility/AccessibleNode.h: Added.
(WebCore::AXPropertyHashTraits::emptyValue):
(WebCore::AXPropertyHashTraits::constructDeletedValue):
(WebCore::AXPropertyHashTraits::isDeletedValue):
(WebCore::AccessibleNode::AccessibleNode):
(WebCore::AccessibleNode::ref):
(WebCore::AccessibleNode::deref):
- accessibility/AccessibleNode.idl: Added.
- bindings/js/WebCoreBuiltinNames.h:
- dom/Element.cpp:
(WebCore::Element::canContainRangeEndPoint const):
(WebCore::Element::accessibleNode):
(WebCore::Element::existingAccessibleNode const):
- dom/Element.h:
- dom/Element.idl:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::accessibleNode const):
(WebCore::ElementRareData::setAccessibleNode):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled):
(WebCore::RuntimeEnabledFeatures::accessibilityObjectModelEnabled const):
- rendering/RenderMenuList.cpp:
(RenderMenuList::itemAccessibilityText const):
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAccessibilityObjectModelEnabled):
(WKPreferencesGetAccessibilityObjectModelEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences accessibilityObjectModelEnabled]):
(-[WebPreferences setAccessibilityObjectModelEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
- accessibility/accessibility-object-model-expected.txt: Added.
- accessibility/accessibility-object-model.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 10:08 PM Changeset in webkit [224870] by
-
- 2 edits2 adds in trunk/Source/WebCore
[Cairo] Add GraphicsContextImplCairo stub
https://bugs.webkit.org/show_bug.cgi?id=179658
Reviewed by Carlos Garcia Campos.
Add the GraphicsContextImplCairo class, which at this point is still
an empty implementation of the GraphicsContextImpl interface. Plan for
the near future is to start mapping method invocations to CairoOperation
functions, essentially mirroring what the Cairo-specific GraphicsContext
methods do today.
In the future this implementation would hopefully allow us to apply a
recorded list of GraphicsContext commands against a PlatformContextCairo
instance.
- platform/SourcesCairo.txt:
- platform/graphics/cairo/GraphicsContextImplCairo.cpp: Added.
(WebCore::GraphicsContextImplCairo::GraphicsContextImplCairo):
(WebCore::m_platformContext):
(WebCore::GraphicsContextImplCairo::updateState):
(WebCore::GraphicsContextImplCairo::clearShadow):
(WebCore::GraphicsContextImplCairo::setLineCap):
(WebCore::GraphicsContextImplCairo::setLineDash):
(WebCore::GraphicsContextImplCairo::setLineJoin):
(WebCore::GraphicsContextImplCairo::setMiterLimit):
(WebCore::GraphicsContextImplCairo::fillRect):
(WebCore::GraphicsContextImplCairo::fillRoundedRect):
(WebCore::GraphicsContextImplCairo::fillRectWithRoundedHole):
(WebCore::GraphicsContextImplCairo::fillPath):
(WebCore::GraphicsContextImplCairo::fillEllipse):
(WebCore::GraphicsContextImplCairo::strokeRect):
(WebCore::GraphicsContextImplCairo::strokePath):
(WebCore::GraphicsContextImplCairo::strokeEllipse):
(WebCore::GraphicsContextImplCairo::clearRect):
(WebCore::GraphicsContextImplCairo::drawGlyphs):
(WebCore::GraphicsContextImplCairo::drawImage):
(WebCore::GraphicsContextImplCairo::drawTiledImage):
(WebCore::GraphicsContextImplCairo::drawNativeImage):
(WebCore::GraphicsContextImplCairo::drawPattern):
(WebCore::GraphicsContextImplCairo::drawRect):
(WebCore::GraphicsContextImplCairo::drawLine):
(WebCore::GraphicsContextImplCairo::drawLinesForText):
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker):
(WebCore::GraphicsContextImplCairo::drawEllipse):
(WebCore::GraphicsContextImplCairo::drawPath):
(WebCore::GraphicsContextImplCairo::drawFocusRing):
(WebCore::GraphicsContextImplCairo::save):
(WebCore::GraphicsContextImplCairo::restore):
(WebCore::GraphicsContextImplCairo::translate):
(WebCore::GraphicsContextImplCairo::rotate):
(WebCore::GraphicsContextImplCairo::scale):
(WebCore::GraphicsContextImplCairo::concatCTM):
(WebCore::GraphicsContextImplCairo::beginTransparencyLayer):
(WebCore::GraphicsContextImplCairo::endTransparencyLayer):
(WebCore::GraphicsContextImplCairo::clip):
(WebCore::GraphicsContextImplCairo::clipOut):
(WebCore::GraphicsContextImplCairo::clipPath):
(WebCore::GraphicsContextImplCairo::applyDeviceScaleFactor):
- platform/graphics/cairo/GraphicsContextImplCairo.h: Added.
- 10:05 PM Changeset in webkit [224869] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Clean up CairoOperations, GradientCairo, GraphicsContextCairo implementation files
https://bugs.webkit.org/show_bug.cgi?id=179679
Reviewed by Michael Catanzaro.
Clean up random tidbits in the CairoOperations, GradientCairo and
GraphicsContextCairo implementation files that I've been ravaging
through over the last few days.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
Add a missing <algorithms> include, drop an unnecessary empty line.
(WebCore::Cairo::drawLine):
- platform/graphics/cairo/GradientCairo.cpp:
Add a missing CairoOperations.h include.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
Drop unnecessary includes and a bunch of redundant helper functions.
(WebCore::GraphicsContext::drawLineForText):
Inline the DashArray object construction into the relay call.
(WebCore::GraphicsContext::drawLinesForText):
size_t can't be negative, so just check for DashArray being empty.
(WebCore::fillRectWithColor): Deleted.
(): Deleted.
(WebCore::drawPathShadow): Deleted.
(WebCore::fillCurrentCairoPath): Deleted.
(WebCore::shadowAndFillCurrentCairoPath): Deleted.
(WebCore::shadowAndStrokeCurrentCairoPath): Deleted.
- 9:21 PM Changeset in webkit [224868] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: CLoop build fix after r224862.
https://bugs.webkit.org/show_bug.cgi?id=179699
Not reviewed..
- bytecode/CodeBlock.h:
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
- 8:09 PM Changeset in webkit [224867] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, another attempt to fix builds after r224707
https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>
- PlatformWin.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 7:46 PM Changeset in webkit [224866] by
-
- 5 edits in trunk/Tools
[Windows] Fix error while launching subprocess on Windows Python
https://bugs.webkit.org/show_bug.cgi?id=179637
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-14
Reviewed by Alex Christensen.
To pass environment variables to subprocess.popen on Windows Python 2,
the dict values must be str not unicode.
Also is_native_win() method is added to port.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.is_native_win):
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_native_win):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_name_and_wrappers):
- Scripts/webkitpy/port/server_process.py:
(ServerProcess.init):
- 5:25 PM Changeset in webkit [224865] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r224860.
This change broke the macOS and iOS builds.
Reverted changeset:
"Unreviewed, fix CMake debug builds after r224707"
https://bugs.webkit.org/show_bug.cgi?id=179499
https://trac.webkit.org/changeset/224860
- 5:15 PM Changeset in webkit [224864] by
-
- 5 edits in trunk
Media query with :host inside a custom elements doesn't get updated on window resize
https://bugs.webkit.org/show_bug.cgi?id=176101
<rdar://problem/34163850>
Reviewed by Simon Fraser.
Source/WebCore:
If a media query containing :host or ::slotted stops applying we fail to update the style.
- style/StyleScope.cpp:
(WebCore::Style::invalidateHostAndSlottedStyleIfNeeded):
Factor into function.
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::scheduleUpdate):
Invalidate elements that may match :host and ::slotted before clearing style resolver for full update.
LayoutTests:
Expand the existing test case to cover :host and ::slotted.
- fast/shadow-dom/media-query-in-shadow-style-expected.html:
- fast/shadow-dom/resources/media-query-in-shadow-style-frame.html:
- 4:43 PM Changeset in webkit [224863] by
-
- 113 edits1 copy2 moves2 deletes in trunk
Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
https://bugs.webkit.org/show_bug.cgi?id=173793
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-11-14
Reviewed by Brian Burg.
Source/JavaScriptCore:
Based on patch by Brian Burg.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bindings/ScriptValue.cpp:
(Inspector::jsToInspectorValue):
(Inspector::toInspectorValue):
(Deprecated::ScriptValue::toInspectorValue const):
- bindings/ScriptValue.h:
- inspector/AsyncStackTrace.cpp:
- inspector/ConsoleMessage.cpp:
- inspector/ContentSearchUtilities.cpp:
- inspector/InjectedScript.cpp:
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeEvalCall):
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::injectedScriptForObjectId):
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::CallbackBase::sendSuccess):
(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):
(Inspector::BackendDispatcher::getPropertyValue):
(Inspector::castToInteger):
(Inspector::castToNumber):
(Inspector::BackendDispatcher::getInteger):
(Inspector::BackendDispatcher::getDouble):
(Inspector::BackendDispatcher::getString):
(Inspector::BackendDispatcher::getBoolean):
(Inspector::BackendDispatcher::getObject):
(Inspector::BackendDispatcher::getArray):
(Inspector::BackendDispatcher::getValue):
- inspector/InspectorBackendDispatcher.h:
- inspector/InspectorProtocolTypes.h:
(Inspector::Protocol::Array::openAccessors):
(Inspector::Protocol::PrimitiveBindingTraits::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<JSON::Value>::assertValueHasExpectedType):
- inspector/ScriptCallFrame.cpp:
- inspector/ScriptCallStack.cpp:
- inspector/agents/InspectorAgent.cpp:
(Inspector::InspectorAgent::inspect):
- inspector/agents/InspectorAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::buildAssertPauseReason):
(Inspector::buildCSPViolationPauseReason):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::buildExceptionPauseReason):
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::breakProgram):
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::saveResult):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:
(CppBackendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_command):
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:
(CppBackendDispatcherImplementationGenerator.generate_output):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:
(CppFrontendDispatcherHeaderGenerator.generate_output):
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:
(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):
- inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
(_generate_unchecked_setter_for_member):
- inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:
(CppProtocolTypesImplementationGenerator):
- inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:
(ObjCBackendDispatcherImplementationGenerator.generate_output):
(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):
- inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:
(ObjCFrontendDispatcherImplementationGenerator.generate_output):
(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):
- inspector/scripts/codegen/generate_objc_internal_header.py:
(ObjCInternalHeaderGenerator.generate_output):
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator.generate_output):
- inspector/scripts/codegen/generator.py:
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/domain-availability.json-result:
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
- inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
- inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Source/WebCore:
Based on patch by Brian Burg.
- ForwardingHeaders/inspector/InspectorValues.h: Removed.
- Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::generateViolationReport):
- inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::inspect):
- inspector/CommandLineAPIHost.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):
(WebCore::InspectorCanvas::buildArrayForImageBitmap):
- inspector/InspectorCanvas.h:
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorOverlay.cpp:
(WebCore::evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
- inspector/InspectorOverlay.h:
- inspector/InspectorShaderProgram.h:
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::createQuad):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):
- inspector/TimelineRecordFactory.h:
- inspector/agents/InspectorApplicationCacheAgent.cpp:
- inspector/agents/InspectorApplicationCacheAgent.h:
- inspector/agents/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::forcePseudoState):
- inspector/agents/InspectorCSSAgent.h:
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::highlightFrame):
- inspector/agents/InspectorDOMAgent.h:
- inspector/agents/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
- inspector/agents/InspectorDOMDebuggerAgent.h:
- inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
- inspector/agents/InspectorDOMStorageAgent.h:
- inspector/agents/InspectorDatabaseAgent.cpp:
- inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::Inspector::idbKeyFromInspectorObject):
(WebCore::Inspector::idbKeyRangeFromKeyRange):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/agents/InspectorIndexedDBAgent.h:
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::buildObjectForHeaders):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::setExtraHTTPHeaders):
- inspector/agents/InspectorNetworkAgent.h:
- inspector/agents/InspectorPageAgent.cpp:
- inspector/agents/InspectorPageAgent.h:
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::didInvalidateLayout):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didScheduleStyleRecalculation):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::createRecordEntry):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/agents/InspectorTimelineAgent.h:
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::parseJSONObject):
(WebCore::parseLicenseFormat):
(WebCore::parseLicenseReleaseAcknowledgementFormat):
(WebCore::CDMInstanceClearKey::updateLicense):
(WebCore::CDMInstanceClearKey::removeSessionData):
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::extractSinfData):
- testing/Internals.cpp:
Source/WebDriver:
- CMakeLists.txt:
- CommandResult.cpp:
(WebDriver::CommandResult::CommandResult):
- CommandResult.h:
(WebDriver::CommandResult::success):
(WebDriver::CommandResult::fail):
(WebDriver::CommandResult::result const):
(WebDriver::CommandResult::setAdditionalErrorData):
(WebDriver::CommandResult::additionalErrorData const):
- Session.cpp:
(WebDriver::firstWindowHandleInResult):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::moveToplevelBrowsingContextWindow):
(WebDriver::Session::resizeToplevelBrowsingContextWindow):
(WebDriver::Session::createElement):
(WebDriver::Session::extractElement):
(WebDriver::Session::extractElementID):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::elementSubmit):
(WebDriver::Session::handleScriptResult):
(WebDriver::Session::executeScript):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::parseAutomationCookie):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):
- Session.h:
- SessionHost.cpp:
(WebDriver::SessionHost::sendCommandToBackend):
(WebDriver::SessionHost::dispatchMessage):
- SessionHost.h:
- WebDriverService.cpp:
(WebDriver::WebDriverService::handleRequest):
(WebDriver::WebDriverService::sendResponse const):
(WebDriver::deserializeTimeouts):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::mergeCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::newSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::setTimeouts):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::getCurrentURL):
(WebDriver::WebDriverService::back):
(WebDriver::WebDriverService::forward):
(WebDriver::WebDriverService::refresh):
(WebDriver::WebDriverService::getTitle):
(WebDriver::WebDriverService::getWindowHandle):
(WebDriver::WebDriverService::getWindowRect):
(WebDriver::valueAsNumberInRange):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::closeWindow):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::getWindowHandles):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::WebDriverService::switchToParentFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::findElement):
(WebDriver::WebDriverService::findElements):
(WebDriver::WebDriverService::findElementFromElement):
(WebDriver::WebDriverService::findElementsFromElement):
(WebDriver::WebDriverService::isElementSelected):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementText):
(WebDriver::WebDriverService::getElementTagName):
(WebDriver::WebDriverService::getElementRect):
(WebDriver::WebDriverService::isElementEnabled):
(WebDriver::WebDriverService::isElementDisplayed):
(WebDriver::WebDriverService::elementClick):
(WebDriver::WebDriverService::elementClear):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::WebDriverService::elementSubmit):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::executeScript):
(WebDriver::WebDriverService::executeAsyncScript):
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):
- WebDriverService.h:
- gtk/WebDriverServiceGtk.cpp:
(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):
Source/WebKit:
Based on patch by Brian Burg.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::resizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::moveWindowOfBrowsingContext):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame):
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::navigationOccurredForFrame):
(WebKit::WebAutomationSession::documentLoadedForFrame):
(WebKit::WebAutomationSession::inspectorFrontendLoaded):
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::setFilesToSelectForFileUpload):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
- UIProcess/Automation/WebAutomationSession.h:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/JSONValues.cpp: Renamed from Source/JavaScriptCore/inspector/InspectorValues.cpp.
(JSON::Value::null):
(JSON::Value::create):
(JSON::Value::asValue):
(JSON::Value::asObject):
(JSON::Value::asArray):
(JSON::Value::parseJSON):
(JSON::Value::toJSONString const):
(JSON::Value::asBoolean const):
(JSON::Value::asDouble const):
(JSON::Value::asInteger const):
(JSON::Value::asString const):
(JSON::Value::writeJSON const):
(JSON::Value::memoryCost const):
(JSON::ObjectBase::~ObjectBase):
(JSON::ObjectBase::asObject):
(JSON::ObjectBase::openAccessors):
(JSON::ObjectBase::memoryCost const):
(JSON::ObjectBase::getBoolean const):
(JSON::ObjectBase::getString const):
(JSON::ObjectBase::getObject const):
(JSON::ObjectBase::getArray const):
(JSON::ObjectBase::getValue const):
(JSON::ObjectBase::remove):
(JSON::ObjectBase::writeJSON const):
(JSON::ObjectBase::ObjectBase):
(JSON::ArrayBase::~ArrayBase):
(JSON::ArrayBase::asArray):
(JSON::ArrayBase::writeJSON const):
(JSON::ArrayBase::ArrayBase):
(JSON::ArrayBase::get const):
(JSON::Object::create):
(JSON::Array::create):
(JSON::ArrayBase::memoryCost const):
- wtf/JSONValues.h: Renamed from Source/JavaScriptCore/inspector/InspectorValues.h.
(JSON::ObjectBase::find):
(JSON::ObjectBase::find const):
(JSON::ObjectBase::setBoolean):
(JSON::ObjectBase::setInteger):
(JSON::ObjectBase::setDouble):
(JSON::ObjectBase::setString):
(JSON::ObjectBase::setValue):
(JSON::ObjectBase::setObject):
(JSON::ObjectBase::setArray):
(JSON::ArrayBase::pushBoolean):
(JSON::ArrayBase::pushInteger):
(JSON::ArrayBase::pushDouble):
(JSON::ArrayBase::pushString):
(JSON::ArrayBase::pushValue):
(JSON::ArrayBase::pushObject):
(JSON::ArrayBase::pushArray):
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
(TestWebKitAPI::TEST):
- 4:40 PM Changeset in webkit [224862] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a bit-rotted Interpreter::dumpRegisters() and make it more robust.
https://bugs.webkit.org/show_bug.cgi?id=179699
<rdar://problem/35462346>
Reviewed by Michael Saboff.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
- Need to skip the callee saved registers
- 4:30 PM Changeset in webkit [224861] by
-
- 1 edit1 delete in trunk/Source/WebInspectorUI
Relicense non-distributable web inspector images
https://bugs.webkit.org/show_bug.cgi?id=166460
<rdar://problem/29800966>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-14
Reviewed by Brian Burg.
- APPLE_IMAGES_LICENSE.rtf: Removed.
Remove the restrictive Web Inspector images license and default to the
same license as the rest of WebKit.
The Apple Images license was never intended to restrict distribution of
Web Inspector images when used as part of WebKit. Now, all contributions
to Web Inspector, images and source, have the same licensing as all other
WebKit contributions.
- 4:12 PM Changeset in webkit [224860] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fix CMake debug builds after r224707
https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>
- PlatformWin.cmake:
- Sources.txt:
- 4:12 PM Changeset in webkit [224859] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fix GTK/WPE debug builds
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 4:09 PM Changeset in webkit [224858] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- html/canvas/WebGLRenderingContext.h:
- 4:04 PM Changeset in webkit [224857] by
-
- 21 edits in trunk
[Service Workers] Implement container.getRegistrations()
https://bugs.webkit.org/show_bug.cgi?id=179672
Reviewed by Brady Eidson.
LayoutTests/imported/w3c:
Rebaseline test now that more checks are passing.
- web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:
Source/WebCore:
Implement container.getRegistrations():
No new tests, rebaselined existing test.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::getOrCreate):
- workers/service/ServiceWorkerRegistration.h:
- workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::isMatching const):
(WebCore::ServiceWorkerRegistrationKey::originIsMatching const):
- workers/service/ServiceWorkerRegistrationKey.h:
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::getRegistrations):
- workers/service/server/SWServer.h:
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::getRegistrations):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::didGetRegistrations):
(WebKit::WebSWClientConnection::getRegistrations):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- 3:49 PM Changeset in webkit [224856] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- html/canvas/WebGLRenderingContext.h:
- 3:42 PM Changeset in webkit [224855] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK/WPE debug builds even better after r224813
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 3:40 PM Changeset in webkit [224854] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK/WPE debug builds after r224813
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 3:32 PM Changeset in webkit [224853] by
-
- 2 edits in trunk/LayoutTests
Mark fast/scrolling/rtl-scrollbars.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179455
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:25 PM Changeset in webkit [224852] by
-
- 74 edits in trunk
Implement ServiceWorker handle fetch for navigation loads
https://bugs.webkit.org/show_bug.cgi?id=179404
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-14
Reviewed by Alex Christensen and Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
- web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/claim-not-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/client-id.https-expected.txt:
- web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt:
- web-platform-tests/service-workers/service-worker/controller-on-disconnect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/controller-on-load.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-csp.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-after-navigation-within-page.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-header-visibility.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-inscope.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-outscope.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-css-cross-origin-mime-check.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-response-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https-expected.txt:
- web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/invalid-header.https-expected.txt:
- web-platform-tests/service-workers/service-worker/mime-sniffing.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https-expected.txt:
- web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt:
- web-platform-tests/service-workers/service-worker/postmessage-msgport-to-client.https-expected.txt:
- web-platform-tests/service-workers/service-worker/postmessage-to-client.https-expected.txt:
- web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
- web-platform-tests/service-workers/service-worker/referrer-policy-header.https-expected.txt:
- web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
- web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:
- web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt:
- web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:
- web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:
- web-platform-tests/service-workers/service-worker/update-recovery.https-expected.txt:
- web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
Source/WebCore:
Covered by rebased tests.
Step 11 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm is implemented in DocumentLoader as it centralizes main request loading
and knows about the context of it.
For each main resource load in document loader, we first check whether there is a matching service worker.
The fetch request is updated accordingly so that there is no difference in the handling of navigation vs. subresource requests after that point.
Updated DocumentThreadableLoader::didReceiveResponse since it can now receive responses from service worker with various response types.
A follow-up patch should properly handle cross origin responses.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::doLoadingMainResource):
- loader/DocumentLoader.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setNavigationServiceWorkerRegistrationData):
- loader/cache/CachedResourceRequest.h:
- platform/MIMETypeRegistry.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
Source/WebKit:
Update handle fetch algorithm to support navigation requests.
In case of navigation requests, set service worker response mime type to text/html if none is provided.
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::startFetch):
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):
(WebKit::WebServiceWorkerProvider::handleFetch):
LayoutTests:
Some new tests are timing out due to missing SW API support.
fetch-request-xhr.https.html is flaky due to always changing assertions.
uncontrolled-page.https.html is probably flaky due to setting the active service worker
in ServiceWorkerRegistration constructor. Plan is to fix that hack as a follow-up.
fetch-event-respond-with-response-body-with-invalid-chunk.https.html might be flaky for the same reason.
Marking unregister-then-register.https.html as flaky. Will follow-up investigating.
- TestExpectations: Skipping some timing out tests and marking some as flaky.
- 3:22 PM Changeset in webkit [224851] by
-
- 4 edits1 move3 adds1 delete in trunk/Source/WebInspectorUI
Web Inspector: Network Detail Views - Split Metrics into Sizes and Timing
https://bugs.webkit.org/show_bug.cgi?id=179569
<rdar://problem/35484914>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-14
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
New resources and strings.
- UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView):
(WI.NetworkResourceDetailView.prototype.initialLayout):
(WI.NetworkResourceDetailView.prototype._showPreferredContentView):
(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToHeaders): Renamed.
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToRequestBody): Renamed.
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToResponseBody): Renamed.
Split into two navigation items and views.
- UserInterface/Views/ResourceMetricsContentView.css: Removed.
- UserInterface/Views/ResourceMetricsContentView.js: Removed.
- UserInterface/Views/ResourceSizesContentView.css: Added.
- UserInterface/Views/ResourceSizesContentView.js: Added.
- UserInterface/Views/ResourceTimingContentView.css: Added.
- UserInterface/Views/ResourceTimingContentView.js: Added.
Split Metrics into two views.
- 2:59 PM Changeset in webkit [224850] by
-
- 2 edits in trunk/Source/WebCore
Log moveFile failure errors
https://bugs.webkit.org/show_bug.cgi?id=179695
Reviewed by Brady Eidson.
Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
To further understand why, I'm adding logs to see what's happening sometimes on the bots.
- platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::moveFile):
- 2:31 PM Changeset in webkit [224849] by
-
- 4 edits in trunk/Source/WebCore
Fix Windows build.
- html/OffscreenCanvas.cpp:
- html/OffscreenCanvas.h:
- html/OffscreenCanvas.idl:
- 2:26 PM Changeset in webkit [224848] by
-
- 1 edit1 copy11 adds1 delete in trunk/LayoutTests
Unreviewed test gardening for High Sierra.
- platform/mac-sierra/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
- platform/mac-sierra/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Renamed from LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt.
- platform/mac/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.
- 2:23 PM Changeset in webkit [224847] by
-
- 1 copy in tags/Safari-604.4.7.1.4
Tag Safari-604.4.7.1.4.
- 2:20 PM Changeset in webkit [224846] by
-
- 59 edits3 deletes in trunk/Source
Remove Cocoa CFURLConnection loading code
https://bugs.webkit.org/show_bug.cgi?id=179688
Reviewed by Antti Koivisto.
Source/WebCore:
CFURLConnection is only used on the AppleWin port now.
- PlatformMac.cmake:
- SourcesCocoa.txt:
- SourcesIOS.txt:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.h:
- loader/EmptyFrameLoaderClient.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/cf/ResourceLoaderCFNet.cpp:
- loader/cocoa/SubresourceLoaderCocoa.mm:
- loader/mac/DocumentLoaderMac.cpp:
- loader/mac/ResourceLoaderMac.mm:
- page/mac/PageMac.mm:
(WebCore::Page::platformInitialize):
(WebCore::Page::addSchedulePair):
(WebCore::Page::removeSchedulePair):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
(WebCore::WebCoreNSURLAuthenticationChallengeClient::create): Deleted.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::WebCoreNSURLAuthenticationChallengeClient): Deleted.
(): Deleted.
- platform/network/ProtectionSpaceBase.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::createCF):
(WebCore::core):
(): Deleted.
- platform/network/cf/AuthenticationCF.h:
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):
(WebCore::deleteAllCookiesModifiedSince):
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::setCertificate):
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::cfError const):
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::installHookToRemoveCFNetworkMessageBlockingMainThread):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupConnectionScheduling):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::Credential::cfCredential const): Deleted.
- platform/network/cocoa/ProtectionSpaceCocoa.mm:
(WebCore::ProtectionSpace::cfSpace const): Deleted.
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest const):
(WebCore::ResourceRequest::clearOrUpdateNSURLRequest): Deleted.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformCertificateInfo const):
(WebCore::ResourceResponse::ResourceResponse): Deleted.
- platform/network/ios/ResourceHandleIOS.mm: Removed.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::AuthenticationChallenge::authenticationClient const):
(WebCore::mac):
(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Deleted.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]): Deleted.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::synchronousWillSendRequestEnabled):
- platform/network/mac/ResourceRequestMac.mm: Removed.
Source/WebKit:
- NetworkProcess/Downloads/Download.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::scheduleLoad):
Source/WebKitLegacy/mac:
- Misc/WebDownload.mm:
(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
- Misc/WebDownloadInternal.h:
- Plugins/WebBaseNetscapePluginView.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
- WebView/WebView.mm:
(-[WebView scheduleInRunLoop:forMode:]):
(-[WebView unscheduleFromRunLoop:forMode:]):
Source/WTF:
- wtf/SchedulePair.h:
- wtf/SchedulePairMac.mm:
- 2:19 PM Changeset in webkit [224845] by
-
- 3 edits in trunk/Tools
webkitpy: Use more verbose version info from simctl
https://bugs.webkit.org/show_bug.cgi?id=179687
<rdar://problem/35539392>
Reviewed by Tim Horton.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator): Address FIXME, use more verbose version.
(Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
string instead.
- Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
8.4.1, not iOS 8.4.
- 1:55 PM Changeset in webkit [224844] by
-
- 7 edits in tags/Safari-605.1.13.3/Source
Versioning.
- 1:53 PM Changeset in webkit [224843] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r224623) [MIPS] branchTruncateDoubleToInt32() doesn't set return register when branching
https://bugs.webkit.org/show_bug.cgi?id=179563
Reviewed by Carlos Alberto Lopez Perez.
When run with BranchIfTruncateSuccessful,
branchTruncateDoubleToInt32() should set the destination register
before branching.
This change also removes branchTruncateDoubleToUInt32() as it is
deprecated (see r160205), merges branchOnTruncateResult() into
branchTruncateDoubleToInt32() and adds test cases in testmasm.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchOnTruncateResult): Deleted.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
Properly set dest before branching.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUInt32): Deleted.
- assembler/testmasm.cpp:
(JSC::testBranchTruncateDoubleToInt32):
(JSC::run):
Add tests for branchTruncateDoubleToInt32().
- 1:49 PM Changeset in webkit [224842] by
-
- 1 copy in tags/Safari-605.1.13.3
Tag Safari-605.1.13.3.
- 1:30 PM Changeset in webkit [224841] by
-
- 12 edits in trunk
Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
for feature defines
Following r195498 and r201917 the Visual Studio property files for feature defines have
moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
files.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 1:26 PM Changeset in webkit [224840] by
-
- 3 edits in trunk/Source/WebCore
Remove StyleResolver::State::document()
https://bugs.webkit.org/show_bug.cgi?id=179678
Reviewed by Antoine Quint.
We don't need both StyleResolver::document() and StyleResolver::State::document().
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::updateConversionData):
(WebCore::StyleResolver::resolvedVariableValue):
(WebCore::StyleResolver::colorFromPrimitiveValue const):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::document const): Deleted.
- 1:22 PM Changeset in webkit [224839] by
-
- 7 edits in branches/safari-604.3.5.1-branch/Source
Versioning.
- 1:16 PM Changeset in webkit [224838] by
-
- 8 edits2 deletes in trunk/Source/JavaScriptCore
Remove JSDollarVMPrototype.
https://bugs.webkit.org/show_bug.cgi?id=179685
Reviewed by Saam Barati.
- Move the JSDollarVMPrototype C++ utility functions into VMInspector.cpp.
This allows us to call these functions during lldb debugging sessions using
VMInspector::foo() instead of JSDollarVMPrototype::foo(). It makes sense that
VMInspector provides VM debugging utility methods. It doesn't make sense to
have a JSDollarVMPrototype object provide these methods.
Plus, it's shorter to type VMInspector than JSDollarVMPrototype.
- Move the JSDollarVMPrototype JS functions into JSDollarVM.cpp.
JSDollarVM is a special object used only for debugging purposes. There's no
gain in requiring its methods to be stored in a prototype object other than to
conform to typical JS convention. We can remove this complexity.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- tools/JSDollarVM.cpp:
(JSC::JSDollarVM::addFunction):
(JSC::functionCrash):
(JSC::functionDFGTrue):
(JSC::CallerFrameJITTypeFunctor::CallerFrameJITTypeFunctor):
(JSC::CallerFrameJITTypeFunctor::operator() const):
(JSC::CallerFrameJITTypeFunctor::jitType):
(JSC::functionLLintTrue):
(JSC::functionJITTrue):
(JSC::functionGC):
(JSC::functionEdenGC):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::functionCodeBlockFor):
(JSC::functionPrintSourceFor):
(JSC::functionPrintBytecodeFor):
(JSC::functionPrint):
(JSC::functionPrintCallFrame):
(JSC::functionPrintStack):
(JSC::functionValue):
(JSC::functionGetPID):
(JSC::JSDollarVM::finishCreation):
- tools/JSDollarVM.h:
(JSC::JSDollarVM::create):
- tools/JSDollarVMPrototype.cpp: Removed.
- tools/JSDollarVMPrototype.h: Removed.
- tools/VMInspector.cpp:
(JSC::VMInspector::currentThreadOwnsJSLock):
(JSC::ensureCurrentThreadOwnsJSLock):
(JSC::VMInspector::gc):
(JSC::VMInspector::edenGC):
(JSC::VMInspector::isInHeap):
(JSC::CellAddressCheckFunctor::CellAddressCheckFunctor):
(JSC::CellAddressCheckFunctor::operator() const):
(JSC::VMInspector::isValidCell):
(JSC::VMInspector::isValidCodeBlock):
(JSC::VMInspector::codeBlockForFrame):
(JSC::PrintFrameFunctor::PrintFrameFunctor):
(JSC::PrintFrameFunctor::operator() const):
(JSC::VMInspector::printCallFrame):
(JSC::VMInspector::printStack):
(JSC::VMInspector::printValue):
- tools/VMInspector.h:
- 1:14 PM Changeset in webkit [224837] by
-
- 2 edits in trunk/Source/WebKit
Whitelist some IOKIt properties to avoid sandbox violations on YouTube
https://bugs.webkit.org/show_bug.cgi?id=179683
<rdar://problem/35415368>
Reviewed by Dean Jackson.
YouTube video playback on some hardware (and some video encodings) generates sandbox violations. Add
whitelist entries for the relevant IOKit properties needed to support these activities.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:11 PM Changeset in webkit [224836] by
-
- 6 edits4 adds in trunk
Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=179671
<rdar://problem/35534018>
Reviewed by Antoine Quint.
Source/WebCore:
Empty implementations of getContext and transferToImageBitmap. At the moment
only return a WebGLRenderingContext from getContext, since we don't
have an Offscreen 2d context type yet.
Tests: http/wpt/offscreen-canvas/getContext-webgl.html
http/wpt/offscreen-canvas/transferToImageBitmap.html
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::getContext):
(WebCore::OffscreenCanvas::transferToImageBitmap):
- html/OffscreenCanvas.h:
- html/OffscreenCanvas.idl:
- html/canvas/GPUBasedCanvasRenderingContext.h: Drive-by parameter rename.
(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):
LayoutTests:
- http/wpt/offscreen-canvas/getContext-webgl-expected.txt: Added.
- http/wpt/offscreen-canvas/getContext-webgl.html: Added.
- http/wpt/offscreen-canvas/transferToImageBitmap-expected.txt: Added.
- http/wpt/offscreen-canvas/transferToImageBitmap.html: Added.
- 12:48 PM Changeset in webkit [224835] by
-
- 2 edits in trunk/Source/WebKit
Mark WebChromeClient::requestStorageAccess() as final
https://bugs.webkit.org/show_bug.cgi?id=179673
Reviewed by Sam Weinig.
Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 12:38 PM Changeset in webkit [224834] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening for High Sierra.
- platform/mac/TestExpectations:
- platform/mac/editing/deleting/delete-emoji-9-expected.txt:
- 12:29 PM Changeset in webkit [224833] by
-
- 10 edits in trunk
Enable Modern EME tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=179544
Reviewed by Alex Christensen.
Source/WebKitLegacy/mac:
Add a WebPreferences property to enable the (modern) EME API.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences encryptedMediaAPIEnabled]):
(-[WebPreferences setEncryptedMediaAPIEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
- 12:28 PM Changeset in webkit [224832] by
-
- 17 edits in trunk
WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized
https://bugs.webkit.org/show_bug.cgi?id=179668
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-14
Reviewed by Chris Dumez.
Source/WebCore:
Covered by existing updated tests.
Removing hasServiceWorkerRegisteredForOrigin and using hasServiceWorkerRegistration instead.
The former is only checking the shared map which might not be initialized at the time the function is called.
The latter is going to the StorageProcess if the map is not yet initialized.
- testing/Internals.cpp:
(WebCore::Internals::hasServiceWorkerRegisteredForOrigin): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
- workers/service/server/SWClientConnection.h:
Source/WebKit:
There may be cases where the origin table is not initialized and we would think there is no service worker registration.
In such a case, we should go to the StorageProcess.
StorageProcess is now sending an IPC message back to each registered SW connection so that WebProcess will know whether its map
is correctly initialized or not.
Renaming hasServiceWorkerRegisteredForOrigin in mayHaveServiceWorkerRegisteredForOrigin.
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::hasServiceWorkerRegisteredForOrigin const): Deleted.
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWOriginTable.h:
(WebKit::WebSWOriginTable::isInitialized const):
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):
LayoutTests:
Updated tests to use hasServiceWorkerRegistration instead of hasServiceWorkerRegisteredForOrigin.
Since the latter is trying to match a registration and compares scopes, we need the scopes to be set right on the tests.
- http/tests/workers/service/basic-unregister.https-expected.txt:
- http/tests/workers/service/resources/basic-register.js:
- http/tests/workers/service/resources/basic-unregister.js:
- 12:22 PM Changeset in webkit [224831] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r224800.
https://bugs.webkit.org/show_bug.cgi?id=179684
"Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
(Requested by mlam on #webkit).
Reverted changeset:
"Pass --useDollarVM=true to all JSC tests."
https://bugs.webkit.org/show_bug.cgi?id=179647
https://trac.webkit.org/changeset/224800
- 12:09 PM Changeset in webkit [224830] by
-
- 2 edits in trunk/Source/WebKit
Consolidate sysctl-read rules in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179674
<rdar://problem/35367154>
Reviewed by Dean Jackson.
Consolidate the various calls to 'allow sysctl-read' imported during Bug 179548 into
the main function in the sandbox profile.
Remove the statement to grant global sysctl-read permissions that was copied into this
sandbox profile in an earlier checkin. We started blocking the blanket read permissions in
macOS 10.13, and want to continue to do so.
The earlier "grant global read access" in 'system.sb' apparently allowed some sysctl reads
to occur before we hit the block declaration in the WebContent sandbox. Now that we are
consistently blocking systcl reads from the start, we need to add whitelist entries for a
few more entries to avoid creating new sandbox violations.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:06 PM Changeset in webkit [224829] by
-
- 8 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline skipped / flaky service worker tests
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
- web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
- 11:54 AM Changeset in webkit [224828] by
-
- 13 edits in trunk/Source/WebKit
Remove WebKit CFURLConnection code
https://bugs.webkit.org/show_bug.cgi?id=179645
Reviewed by Alexey Proskuryakov.
The CFURLConnection code is Windows-specific now. Nobody can use it in modern WebKit.
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/mac/DownloadMac.mm:
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::serverTrustCredential):
- NetworkProcess/mac/NetworkLoadMac.mm:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- config.h:
- 11:50 AM Changeset in webkit [224827] by
-
- 3 edits in trunk/Source/WebKit
Remove assertions added in r224791
https://bugs.webkit.org/show_bug.cgi?id=178751#c10
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
I had added assertions that sandbox extension handle consumption succeeds.
In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
to give access to a directory that does not exist and consumption fails. We want it to fail,
so my optimistic addition of a success assertion was incorrect. The test passes without it
and behaves like it used to.
- 11:44 AM Changeset in webkit [224826] by
-
- 8 edits3 adds in trunk/Source
Web Inspector: Add a ServiceWorker domain to get information about an inspected ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=179640
<rdar://problem/35517361>
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- CMakeLists.txt:
- DerivedSources.make:
Gate the ServiceWorker domain on the ENABLE feature flag.
- inspector/protocol/ServiceWorker.json: Added.
New domain to be made available inside of a ServiceWorker target.
Source/WebCore:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
New files.
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::createLazyAgents):
Add a ServiceWorkerAgent when the Worker is a ServiceWorker.
- inspector/agents/worker/ServiceWorkerAgent.h: Added.
- inspector/agents/worker/ServiceWorkerAgent.cpp: Added.
(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
(WebCore::ServiceWorkerAgent::didCreateFrontendAndBackend):
(WebCore::ServiceWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::ServiceWorkerAgent::getInitializationInfo):
Populate initialization info.
- 11:43 AM Changeset in webkit [224825] by
-
- 2 edits in trunk/Source/WebKit
Don't use -[NSString stringWithFormat:] to build defaults keys
https://bugs.webkit.org/show_bug.cgi?id=179680
Reviewed by Simon Fraser.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
Use string concatenation instead of stringWithFormat to build
preference keys. This wasn't a huge cost, but it shaves a few milliseconds
off process launch.
- 11:40 AM Changeset in webkit [224824] by
-
- 2 edits in trunk/Source/WebCore
Remove some accidentally checked-in commented-out code.
Unreviewed.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):
- 11:15 AM Changeset in webkit [224823] by
-
- 12 edits in trunk
Clean up old URL parser remnants
https://bugs.webkit.org/show_bug.cgi?id=179573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/url/url-setters-expected.txt:
We're more spec compliant! Hooray!
Source/WebCore:
When we transitioned to the new URLParser, we kept the old character tables which were less spec-conformant.
Removing them and transitioning to URLParser's table makes more web platform tests pass!
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
There's no need to percent-encode an origin. It's already ascii, and if it's not, then the URLParser will escape it.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::createFileURL):
Removed comment that no longer applies.
- platform/URL.cpp:
(WebCore::URL::setProtocol):
(WebCore::percentEncodeCharacters):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
Percent encode the userinfo character set from the URLParser according to https://url.spec.whatwg.org/#set-the-username and https://url.spec.whatwg.org/#set-the-password
(WebCore::URL::setPath):
A ? or a # are the only two characters that need to be pre-encoded when setting the path because they indicate the
beginning of a query or fragment. All other characters will be encoded if necessary during parsing.
(WebCore::protocolIsInternal):
(): Deleted.
(WebCore::isSchemeFirstChar): Deleted.
(WebCore::isSchemeChar): Deleted.
(WebCore::isBadChar): Deleted.
(WebCore::isTabNewline): Deleted.
(WebCore::appendEscapedChar): Deleted.
(WebCore::encodeWithURLEscapeSequences):
Encode characters needed. I used the user info set of characters because that was most similar to the BadChar set of the old parser.
This isn't standardized, and it's only used for the search context menu item which certainly isn't standardized.
(WebCore::isValidProtocol): Deleted.
Remove a bunch of old unused functions.
- platform/URLParser.cpp:
(WebCore::URLParser::isInUserInfoEncodeSet):
(WebCore::URLParser::parseAuthority):
- platform/URLParser.h:
Expose a few functions for URL.cpp to use.
Source/WebKit:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.
Source/WebKitLegacy/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.
- 11:01 AM Changeset in webkit [224822] by
-
- 9 edits in trunk
Enable display:contents by default
https://bugs.webkit.org/show_bug.cgi?id=179655
Reviewed by Sam Weinig.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
Make non-experimental and enabled.
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Tools:
No need to enable this specifically for tests anymore.
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 10:36 AM Changeset in webkit [224821] by
-
- 2 edits in trunk/Source/WebKit
Consolidate mach-lookup calls in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179650
<rdar://problem/35367154>
Reviewed by Dean Jackson.
Consolidate the various calls to 'allow mach-lookup' imported during Bug 179548 into the main
function in the sandbox profile. Remove some entries that are not needed by WebKit.
Remove the statement to grant global permission to perform mach-lookup for any xpc
service name that was copied into this sandbox profile in Bug 179548. We started blocking
this in macOS 10.13 and want to continue to do so.
The earlier "grant global permission" in 'system.sb' apparently allowed some xpc lookups to occur
before we hit the block declaration in the WebContent sandbox. Now that we are consistently blocking
mach lookups we need to add whitelist entries for a few more services to avoid creating new
sandbox violations.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:02 AM Changeset in webkit [224820] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move drawLine operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179669
Reviewed by Carlos Garcia Campos.
Move the drawLine operation implementation into the CairoOperations
implementation file, with the Cairo::drawLine() function only expecting
a PlatformContextCairo object, two FloatingPoints, and a const reference
to a GraphicsContextState object.
As with drawLinesForText(), the drawLine() implementation utilized a few
private GraphicsContext methods that we for now reimplement in the
Cairo namespace as static functions, providing necessary state values to
perform the computations. The GraphicsContext methods should be changed
to become static public functions -- after that we'll be able to remove
the new duplicated helper functions.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::dashedLineCornerWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternOffsetForPatternAndStrokeWidth):
(WebCore::Cairo::centerLineAndCutOffCorners):
(WebCore::Cairo::drawLine):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
- 9:44 AM Changeset in webkit [224819] by
-
- 8 edits in trunk
Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
https://bugs.webkit.org/show_bug.cgi?id=179646
<rdar://problem/35337288>
Reviewed by Simon Fraser.
Source/WebCore:
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::canBePresentedByDataDetectors):
(WebCore::DataDetection::isDataDetectorLink):
Expose canBePresentedByDataDetectors, which tests if the URL's
scheme is one of Data Detectors' known long-press schemes.
Source/WebKit:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
Make use of canBePresentedByDataDetectors with our WebCore URL instead
of (sometimes unsucessfully) reparsing the URL with NSURL's parser.
Also, avoid a few unnecessary round-trips through String when converting
from URL to NSURL.
Tools:
- TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(-[ActionSheetObserver _dataDetectionContextForWebView:]):
(TestWebKitAPI::TEST):
Add a test that ensures that a phone number with spaces in it
invokes a data detectors sheet, not a normal link sheet.
- 9:35 AM Changeset in webkit [224818] by
-
- 7 edits2 adds in trunk
[DFG][FTL] Support Array::DirectArguments with OutOfBounds
https://bugs.webkit.org/show_bug.cgi?id=179594
Reviewed by Saam Barati.
JSTests:
- stress/direct-arguments-in-bounds-to-out-of-bounds.js: Added.
(shouldBe):
(args):
- stress/direct-arguments-out-of-bounds-watchpoint.js: Added.
(shouldBe):
(args):
Source/JavaScriptCore:
Currently we handle OOB access to DirectArguments as GetByVal(Array::Generic).
If we can handle it as GetByVal(Array::DirectArguments+OutOfBounds), we can (1) optimize
arguments[i]accesses if i is in bound, and (2) encourage arguments elimination phase
to convert CreateDirectArguments and GetByVal(Array::DirectArguments+OutOfBounds) to
PhantomDirectArguments and GetMyArgumentOutOfBounds respectively.
This patch introduces Array::DirectArguments+OutOfBounds array mode. GetByVal can
accept this type, and emit optimized code compared to Array::Generic case.
We make OOB check failures in GetByVal(Array::DirectArguments+InBounds) as OutOfBounds
exit instead of ExoticObjectMode.
This change significantly improves SixSpeed rest.es5 since it uses OOB access.
Our arguments elimination phase can change CreateDirectArguments to PhantomDirectArguments.
rest.es5 59.6719+-2.2440 3.1634+-0.5507 definitely 18.8635x faster
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine const):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
- 9:18 AM Changeset in webkit [224817] by
-
- 2 edits in trunk/Source/WebCore
[GTK][WPE] Don't require brotli
https://bugs.webkit.org/show_bug.cgi?id=178122
Reviewed by Frédéric Wang.
Remove stray remaining use of brotli CMake variable.
- CMakeLists.txt:
- 8:37 AM Changeset in webkit [224816] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r224799): WebKit crashes on Sierra due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=179656
Unreviewed build fix.
- WebProcess/com.apple.WebProcess.sb.in: Switch to Dan's recommended version check.
- 7:47 AM Changeset in webkit [224815] by
-
- 2 edits in trunk/Tools
Add committer status for Emilio Cobos Álvarez.
https://bugs.webkit.org/show_bug.cgi?id=179667
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 5:45 AM Changeset in webkit [224814] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move drawLinesForText operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179661
Reviewed by Carlos Garcia Campos.
Encapsulate the drawLinesForText() operation in the WebCore::Cairo
namespace. Apart from moving gist of the code from GraphicsContextCairo
to CairoOperations, we also (for the moment) have to duplicate the
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code.
This is necessary because the given method is private on the
GraphicsContext class, and relies on an underlying GraphicsContext
object to retrieve the current CTM and stroke thickness values.
The adjusted reimplementation uses PlatformContextCairo to retrieve
the CTM (just like Cairo's GraphicsContext::getCTM() does), and
requires the stroke thickness value to be passed in as an argument.
Similar modifications will be proposed for the existing
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code,
and once that's approved the duplicated code will be eliminated.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::computeLineBoundsAndAntialiasingModeForText):
(WebCore::Cairo::drawLinesForText):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLinesForText):
- 5:42 AM Changeset in webkit [224813] by
-
- 5 edits in trunk/Source/WebCore
[Cairo] Move native image drawing operation to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179660
Reviewed by Carlos Garcia Campos.
Unify the native image drawing operation behavior between the
Cairo-specific GraphicsContext and drawNativeImage() implementations and
then move the code into the Cairo::drawNativeImage() function, inside
the CairoOperations implementation file.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::cairoSurfaceHasAlpha):
(WebCore::Cairo::drawNativeImage):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawNativeImage):
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 5:23 AM Changeset in webkit [224812] by
-
- 3 edits in trunk/LayoutTests
Add some bug numbers for failing XHR tests
https://bugs.webkit.org/show_bug.cgi?id=179664
Unreviewed test gardening.
- TestExpectations:
- platform/gtk/TestExpectations: The two send-entity-body tests were not marked as failing anywhere, so the annotations here were superfluous.
- 1:08 AM Changeset in webkit [224811] by
-
- 2 edits in trunk/Source/bmalloc
Make the gigacage runway 32GB
https://bugs.webkit.org/show_bug.cgi?id=175062
Reviewed by Mark Lam.
Making the gigacage runway 32GB defends us against buffer overflows in the
cage reaching memory outside the cage assuming indices are 32-bit unsigned
integers and the type they're indexing into has size <= 8 bytes. This is
exactly the case for many things in JSC. For example, butterfly access in
JSC meet this criteria, as does typed array access.
The 32GB comes from 8 * 232 = 32GB.
- bmalloc/Gigacage.cpp:
- 1:05 AM Changeset in webkit [224810] by
-
- 10 edits1 add in trunk
We need to set topCallFrame when calling Wasm::Memory::grow from the JIT
https://bugs.webkit.org/show_bug.cgi?id=179639
<rdar://problem/35513018>
Reviewed by JF Bastien.
JSTests:
- wasm/function-tests/grow-memory-cause-gc.js: Added.
(escape):
(i.func):
Source/JavaScriptCore:
Calling Wasm::Memory::grow from the JIT may cause us to GC. When we GC, we will
walk the stack for ShadowChicken (and maybe other things). We weren't updating
topCallFrame when calling grow from the Wasm JIT. This would cause the GC to
use stale topCallFrame bits in VM, often leading to crashes. This patch fixes
this bug by giving Wasm::Instance a lambda that is called when we need to store
the topCallFrame. Users of Wasm::Instance can provide a function to do this action.
Currently, JSWebAssemblyInstance passes in a lambda that stores to
VM.topCallFrame.
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addGrowMemory):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::create):
- wasm/WasmInstance.h:
(JSC::Wasm::Instance::storeTopCallFrame):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::create):
- wasm/js/JSWebAssemblyInstance.h:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJSException):
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::instantiate):
- 12:56 AM Changeset in webkit [224809] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Perform GraphicsContextPlatformPrivate method calls from CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179657
Reviewed by Carlos Garcia Campos.
To enable encapsulating remaining Cairo operations in static functions
inside the WebCore::Cairo namespace, we have to work around the
GraphicsContextPlatformPrivate methods that are invoked in the current
GraphicsContext implementation for Cairo.
A pointer to the GraphicsContextPlatformPrivate object is now kept on
the PlatformContextCairo instance, and we take care of setting it up
and clearing it out appropriate to the GraphicsContextPlatformPrivate
lifetime (as managed in Cairo-specific GraphicsContext implementation).
The GraphicsContextPlatformPrivate method invocations are then moved
to the appropriate CairoOperations functions.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::clip):
(WebCore::Cairo::clipPath):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
- platform/graphics/cairo/PlatformContextCairo.h:
(WebCore::PlatformContextCairo::graphicsContextPrivate):
(WebCore::PlatformContextCairo::setGraphicsContextPrivate):
- 12:50 AM Changeset in webkit [224808] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move simpler draw operations from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179614
Reviewed by Carlos Garcia Campos.
Move operations that perform simpler drawing to the CairoOperations
file. This isolates the Cairo code and encapsulates operation work
into a limited scope. This patch only covers drawing patterns,
rectangles, document marker lines and ellipses. A missing forward
declaration for the drawGlyphs() function is also added in the
CairoOperations header.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawPattern):
(WebCore::Cairo::drawRect):
(WebCore::Cairo::drawLineForDocumentMarker):
(WebCore::Cairo::drawEllipse):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawPattern):
- 12:49 AM Changeset in webkit [224807] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup navigation bar dividers and separators
https://bugs.webkit.org/show_bug.cgi?id=179654
<rdar://problem/35523734>
Reviewed by Devin Rousso.
Update path separator icon, and reduce number of dividers used in the
content browser's navigation bar, to more closely match modern Xcode.
- UserInterface/Images/HierarchicalNavigationItemChevron.svg:
Update icon, remove tapered arrow head.
- UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser):
Remove divider between back/forward buttons and item name.
(WI.ContentBrowser.prototype._updateContentViewNavigationItems):
- UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > .separator):
- UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.get navigationItems):
Remove dividers between buttons provided by the current content view.
