Context Navigation

← Previous Period
Next Period →

Timeline

Nov 22, 2017:

10:47 PM Changeset in webkit [225107] by Simon Fraser

3 edits in trunk/Source/WebCore

FEComponentTransfer cleanup and optimization
https://bugs.webkit.org/show_bug.cgi?id=179952

Reviewed by Darin Adler.

Change terminology for FEComponentTransfer to be more explicit about the fact
that it's creating and using lookup tables. Use std::array for the lookup tables.

Use uint8_t instead of unsigned char.

Avoid confusing arrays for channels in computeLookupTables; just setup the lut for
each channel manually.

This is about 1.25x faster than before.

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::computeIdentityTable):
(WebCore::FEComponentTransfer::computeTabularTable):
(WebCore::FEComponentTransfer::computeDiscreteTable):
(WebCore::FEComponentTransfer::computeLinearTable):
(WebCore::FEComponentTransfer::computeGammaTable):
(WebCore::FEComponentTransfer::platformApplySoftware):
(WebCore::FEComponentTransfer::computeLookupTables):
(WebCore::operator<<):
(WebCore::identity): Deleted.
(WebCore::table): Deleted.
(WebCore::discrete): Deleted.
(WebCore::linear): Deleted.
(WebCore::gamma): Deleted.
(WebCore::FEComponentTransfer::getValues): Deleted.

platform/graphics/filters/FEComponentTransfer.h:

(WebCore::ComponentTransferFunction::ComponentTransferFunction): Deleted.

10:47 PM Changeset in webkit [225106] by Simon Fraser

2 edits in trunk/Source/JavaScriptCore

Followup after r225084: if anyone called GenericTypedArrayView() it didn't compile,
because of a getRangeUnchecked/getRangeImpl name mismatch; fixed to use getRangeImpl().

Also name the argument to zeroRange() to 'count' since it's an item count.

runtime/GenericTypedArrayView.h:

(JSC::GenericTypedArrayView::zeroRange):
(JSC::GenericTypedArrayView::getRange):

4:57 PM Changeset in webkit [225105] by Michael Catanzaro

8 edits in trunk

Sanity-check feature defaults in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=179095

Reviewed by Konstantin Tokarev.

Change the default value of some features in WebKitFeatures.cmake to reduce the number of
Options*.cmake files the feature's default value must be overridden in.

Remove feature definitions where they are redundant with the definition in
WebKitFeatures.cmake, particluarly in OptionsMac.cmake.

This commit should not include any functional changes. It just aims to reduce the total
number of times we need to call WEBKIT_OPTION_DEFAULT_PORT_VALUE.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsJSCOnly.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWPE.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

3:46 PM Changeset in webkit [225104] by jfernandez@igalia.com

8 edits
1 copy
1 add in trunk/Source/WebCore

[css-grid] Refactoring and new namespace with grid related utility functions
https://bugs.webkit.org/show_bug.cgi?id=179633

Reviewed by Darin Adler.

Added a new namespace with several utility functions to share logic
between RenderGrid and GridTrackSizingAlgorithm.

No new tests, since no new functionality is added.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
rendering/GridLayoutUtils.cpp: Added.

(WebCore::GridLayoutUtils::computeMarginLogicalSizeForChild):
(WebCore::GridLayoutUtils::marginLogicalSizeForChild):
(WebCore::GridLayoutUtils::isOrthogonalChild):
(WebCore::GridLayoutUtils::flowAwareDirectionForChild):

rendering/GridLayoutUtils.h: Added.
rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching const):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::isInlineBaselineAlignedChild const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::RenderGrid::findChildLogicalPosition const):

2:20 PM Changeset in webkit [225103] by commit-queue@webkit.org

44 edits
18 adds in trunk

Implement VisualViewport API attributes
https://bugs.webkit.org/show_bug.cgi?id=179385

Patch by Ali Juma <ajuma@chromium.org> on 2017-11-22
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectations for viewport WPTs. The new expectations are all passing,
except as mentioned below.

web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt:
web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt:
web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt:
web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt: Fails since events are not implemented yet (wkbug.com/b/179386).
web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt:
web-platform-tests/viewport/viewport-type-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scale-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).
web-platform-tests/viewport/viewport-unscaled-size-expected.txt:
web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).

Source/WebCore:

Add a visualViewport attribute to Window, and implement the VisualViewport
interface (https://wicg.github.io/visual-viewport/#the-visualviewport-interface).

This is behind a newly-added VisualViewportAPI experimental feature flag.

Tests: fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html

fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
fast/visual-viewport/viewport-dimensions-iframe.html
fast/visual-viewport/viewport-dimensions-under-page-zoom.html
fast/visual-viewport/viewport-dimensions.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventTargetFactory.in:
page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::visualViewport const):

page/DOMWindow.h:
page/DOMWindow.idl:
page/Settings.yaml:
page/VisualViewport.cpp: Added.

(WebCore::VisualViewport::VisualViewport):
(WebCore::VisualViewport::eventTargetInterface const):
(WebCore::VisualViewport::scriptExecutionContext const):
(WebCore::getFrameViewAndLayoutIfNonNull):
(WebCore::VisualViewport::offsetLeft const):
(WebCore::VisualViewport::offsetTop const):
(WebCore::VisualViewport::pageLeft const):
(WebCore::VisualViewport::pageTop const):
(WebCore::VisualViewport::width const):
(WebCore::VisualViewport::height const):
(WebCore::VisualViewport::scale const):

page/VisualViewport.h: Added.
page/VisualViewport.idl: Added.

Source/WebKit:

Add a VisualViewportAPI experimental feature.

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add a VisualViewportAPI preference.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences visualViewportAPIEnabled]):
(-[WebPreferences setVisualViewportAPIEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a VisualViewportAPI preference.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::visualViewportAPIEnabled):
(WebPreferences::setVisualViewportAPIEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Enable the VisualViewportAPI in layout tests.

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

LayoutTests:

Add tests for the Visual Viewport API, based on Blink's layout tests but modified
to use UIScriptController.

fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html: Added.
fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html: Added.
fast/visual-viewport/viewport-dimensions-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-iframe.html: Added.
fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-under-page-zoom.html: Added.
fast/visual-viewport/viewport-dimensions.html: Added.
platform/gtk/TestExpectations: Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK (webkit.org/b/168050).
platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt: Added. Platform-specific expectation because of the window size being different on iOS.
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/mac-wk1/TestExpectations: Skipped a test that applies webkit-scrollbar to main frame scrollbars, since this is unsupported in WK1.

1:24 PM Changeset in webkit [225102] by Antti Koivisto

1 edit
1 add in trunk/PerformanceTests

Add performance test for inlines and inline-blocks without text
https://bugs.webkit.org/show_bug.cgi?id=179955

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=179950

Layout/inline-layout-no-text.html: Added.

12:37 PM Changeset in webkit [225101] by Manuel Rego Casasnovas

3 edits
4 adds in trunk

Available height is wrong for positioned elements with "box-sizing: border-box"
https://bugs.webkit.org/show_bug.cgi?id=178783

Reviewed by Darin Adler.

Source/WebCore:

These methods were returning a wrong value for positioned items
in combination with "box-sizing: border-box".
The problem was that if the height of the element is given
by its offset properties (top and bottom) we don't need to call
adjustContentBoxLogicalHeightForBoxSizing().

Tests: fast/box-sizing/fill-available.html

fast/box-sizing/replaced.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):

LayoutTests:

There are some cases failing in fast/box-sizing/fill-available.html,
this is because of a different bug (see https://webkit.org/b/178790)
as noted down in the text comments.

fast/box-sizing/fill-available-expected.txt: Added.
fast/box-sizing/fill-available.html: Added.
fast/box-sizing/replaced-expected.txt: Added.
fast/box-sizing/replaced.html: Added.

11:44 AM Changeset in webkit [225100] by commit-queue@webkit.org

12 edits in trunk/Source

WebCoreObjCExtras.h is being included in too many places
https://bugs.webkit.org/show_bug.cgi?id=179931

Patch by Christopher Reid <chris.reid@sony.com> on 2017-11-22
Reviewed by Darin Adler.

Source/WebCore:

No new tests no change in behavior.

Fixing cases where WebCoreObjCExtras.h is imported but not used.

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
platform/mac/WebCoreNSURLExtras.mm:

Source/WebKitLegacy/mac:

Plugins/Hosted/WebHostedNetscapePluginView.mm:
Plugins/WebBaseNetscapePluginView.mm:
Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginStream.mm:
Plugins/WebNetscapePluginView.mm:
WebView/WebTextIterator.mm:
WebView/WebViewData.mm:

11:04 AM Changeset in webkit [225099] by graouts@webkit.org

4 edits in trunk/Source/WebCore

[Web Animations] Adopt KeyframeList in KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=179941
<rdar://problem/35666924>

Reviewed by Darin Adler.

KeyframeEffect used to model its keyframes by creating a new Keyframe struct and storing them in a Vector<Keyframe>.
However, there already is a way to model keyframes in WebCore using the KeyframeList class. We now adopt this class
in KeyframeEffect, which makes it possible to run hardware-composited animations using RenderBoxModelObject::startAnimation()
in a follow-up patch, since this function expects a KeyframeList.

No news tests, this is an internals change and does not yield any changes in Web content.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::KeyframeEffect): Create a default m_keyframes at construction time.
(WebCore::KeyframeEffect::processKeyframes): Create a temporary KeyframeList as we parse keyframes passed from the JS API
and assign it to m_keyframes upon successful parsing. We also use cssPropertyId to refer to a CSSPropertyID to make the code
clearer and ensure there is no confusion with JS properties that we manipulate in this function.
(WebCore::KeyframeEffect::computeStackingContextImpact): Use the list of CSS properties exposed on KeyframeList directly rather
than enumerating each keyframe and use cssPropertyId to refer to individual CSSPropertyID values for consistency.
(WebCore::KeyframeEffect::applyAtLocalTime): Use the list of CSS properties exposed on KeyframeList directly rather than
using the properties specified on the first keyframe only. We also remove a stale FIXME comment which was addressed in r224957.

animation/KeyframeEffect.h: Remove the Keyframe struct and change the type of m_keyframes from Vector<Keyframe> to KeyframeList.
rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList): We remove the default insertions at KeyframeList construction time since it requires
an immediate call to clear() when doing any meaningful work with a KeyframeList. We also add the default move assignment operator
to allow KeyframeEffect::processKeyframes() to make a move assignment from the temporary keyframe list we build at parsing to the
member variable.

10:52 AM Changeset in webkit [225098] by Michael Catanzaro

11 edits in trunk

Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338

Reviewed by Carlos Alberto Lopez Perez.

Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.

Source/cmake/OptionsGTK.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

Use ENABLE_EXPERIMENTAL_FEATURES instead of ENABLE_DEVELOPER_MODE to enable runtime
experimental features.

Shared/WebPreferencesDefaultValues.h:

Tools:

Delegate feature flag default values to the build system.
(FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
bots instead of --default-cmake-features.

Scripts/build-webkit:

(cMakeArgsFromFeatures): Deleted.
Default feature values to 'undef'.
Remove the --default-cmake-features argument; it is now the default.
Add --no-experimental-features to replace it.
Stop printing the default feature flag value in the help.
Avoid propagating undefined values to the build system;
only mention flags that are overridden on the command line.

This has the nice side effect of using the default CMake features
for CMake builds, but still allowing toggling of them using the
prettier --FEATURE and --no-FEATURE arguments.

Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):
No longer need to suppress CMake warnings about unused arguments.

Scripts/webkitperl/FeatureList.pm:

Remove the default values from the feature list.

10:08 AM Changeset in webkit [225097] by mark.lam@apple.com

2 edits in trunk/Tools

[Re-landing] Pass --useDollarVM=true to all JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=179647

Reviewed by Saam Barati.

Scripts/run-jsc-stress-tests:

9:56 AM Changeset in webkit [225096] by commit-queue@webkit.org

4 edits in trunk/Source/WTF

tuple related items are used in WTF without including tuple
https://bugs.webkit.org/show_bug.cgi?id=179926

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-22
Reviewed by Darin Adler.

wtf/HashFunctions.h:
wtf/PrintStream.h:
wtf/threads/Signals.h:

8:54 AM Changeset in webkit [225095] by Ms2ger@igalia.com

2 edits in trunk/LayoutTests

[WPE] Enable request-animation-frame-disabled.html.
https://bugs.webkit.org/show_bug.cgi?id=173422

Unreviewed test gardening.

The test is passing since the change in r218754, and doesn't seem to have
crashed in months.

platform/wpe/TestExpectations:

8:33 AM WebKitGTK/Gardening/Calendar edited by aboya@igalia.com

(diff)

12:14 AM Changeset in webkit [225094] by fred.wang@free.fr

44 edits
15 deletes in trunk

Unreviewed, rolling out r225093.
https://bugs.webkit.org/show_bug.cgi?id=179938

Compilation failed on WinCairo 64-bit Release (Requested by
fredw on #webkit).

Reverted changeset:

"Implement VisualViewport API attributes"
https://bugs.webkit.org/show_bug.cgi?id=179385
https://trac.webkit.org/changeset/225093

Patch by Commit Queue <commit-queue@webkit.org> on 2017-11-22

Nov 21, 2017:

11:26 PM Changeset in webkit [225093] by commit-queue@webkit.org

44 edits
18 adds in trunk

Implement VisualViewport API attributes
https://bugs.webkit.org/show_bug.cgi?id=179385

Patch by Ali Juma <ajuma@chromium.org> on 2017-11-21
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectations for viewport WPTs. The new expectations are all passing,
except as mentioned below.

web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt:
web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt:
web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt:
web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt: Fails since events are not implemented yet (wkbug.com/b/179386).
web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt:
web-platform-tests/viewport/viewport-type-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scale-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt:
web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).
web-platform-tests/viewport/viewport-unscaled-size-expected.txt:
web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).

Source/WebCore:

Add a visualViewport attribute to Window, and implement the VisualViewport
interface (https://wicg.github.io/visual-viewport/#the-visualviewport-interface).

This is behind a newly-added VisualViewportAPI experimental feature flag.

Tests: fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html

fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
fast/visual-viewport/viewport-dimensions-iframe.html
fast/visual-viewport/viewport-dimensions-under-page-zoom.html
fast/visual-viewport/viewport-dimensions.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventTargetFactory.in:
page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::visualViewport const):

page/DOMWindow.h:
page/DOMWindow.idl:
page/Settings.yaml:
page/VisualViewport.cpp: Added.

page/VisualViewport.h: Added.
page/VisualViewport.idl: Added.

Source/WebKit:

Add a VisualViewportAPI experimental feature.

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add a VisualViewportAPI preference.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences visualViewportAPIEnabled]):
(-[WebPreferences setVisualViewportAPIEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a VisualViewportAPI preference.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::visualViewportAPIEnabled):
(WebPreferences::setVisualViewportAPIEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Enable the VisualViewportAPI in layout tests.

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

LayoutTests:

Add tests for the Visual Viewport API, based on Blink's layout tests but modified
to use UIScriptController.

fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html: Added.
fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html: Added.
fast/visual-viewport/viewport-dimensions-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-iframe.html: Added.
fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt: Added.
fast/visual-viewport/viewport-dimensions-under-page-zoom.html: Added.
fast/visual-viewport/viewport-dimensions.html: Added.
platform/gtk/TestExpectations: Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK (webkit.org/b/168050).
platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt: Added. Platform-specific expectation because of the window size being different on iOS.
platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
platform/mac-wk1/TestExpectations: Skipped a test that applies webkit-scrollbar to main frame scrollbars, since this is unsupported in WK1.

11:17 PM Changeset in webkit [225092] by fred.wang@free.fr

7 edits in trunk

Async frame scrolling: handle fixed root backgrounds in frames
https://bugs.webkit.org/show_bug.cgi?id=176261

Source/WebCore:

Based on patch by Simon Fraser <Simon Fraser>
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

For frames with tiled backing, we register a slow-repaint object because we hit
RenderElement::styleWillChange() before we've made a backing for the iframe's RenderView so
view().compositor().supportsFixedRootBackgroundCompositing() returns false. This patch
ensures that this object is removed when setBackgroundLayerPaintsFixedRootBackground is
called. It also removes the opaque background of non-main frames with tiled backing.
This fixes a possible hit of ASSERT(!m_backgroundLayer) after r221615.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry): Do not set opaque contents for frames with
tiled backing. We keep !m_isMainFrameRenderViewLayer for backward compatibility with WK1.
(WebCore::RenderLayerBacking::setBackgroundLayerPaintsFixedRootBackground): Add an early
return when m_backgroundLayerPaintsFixedRootBackground is not changed. Remove the slow
repaint object previously registered for this frame. Also add an ASSERT to ensure that a
fixed root background is only set for frames with async scrolling.
(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Restrict some special handling
of background and opaqueness to the main frame.

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

Extend tiled-drawing-async-frame-scrolling with new test cases and update expectations.

compositing/tiling/tiled-drawing-async-frame-scrolling.html: Add two test cases with

non-white and fixed gradient background. The latter exhibits a crash fixed by that commit.

compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Adjust expectation due

to spacing changes.

platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

Update expectation for the first case to remove the white background and add expectations for
the two new cases.

platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

10:54 PM Changeset in webkit [225091] by zandobersek@gmail.com

11 edits in trunk

Drop ENABLE_IMAGE_DECODER_DOWN_SAMPLING code
https://bugs.webkit.org/show_bug.cgi?id=179921

Reviewed by Carlos Garcia Campos.

Source/cmake/WebKitFeatures.cmake: Remove the CMake option that

enabled IMAGE_DECODER_DOWN_SAMPLING code.

Source/WebCore:

Drop the ENABLE_IMAGE_DECODER_DOWN_SAMPLING code, along with the build
guard definitions in WTF and CMake.

This was apparently in use in the Qt port, but since then no port
enables this. It's not exposed in the Xcode build, and the CMake option
is disabled by default, with no way to enable it through build-webkit.

While the code guarded with this build guard is removed, there's still
code in the ScalableImageDecoder class that only operated when this
feature was enabled. This should be addressed in the future, after
evaluating the need for this scaling capability.

No new tests -- no change in behavior.

platform/graphics/Image.cpp:

(WebCore::Image::adjustSourceRectForDownSampling const): Deleted.

platform/graphics/Image.h:
platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawNativeImage):

platform/image-decoders/ScalableImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::frameComplete):

Source/WTF:

wtf/FeatureDefines.h: Remove the ENABLE_IMAGE_DECODER_DOWN_SAMPLING

definition.

10:40 PM Changeset in webkit [225090] by fred.wang@free.fr

7 edits in trunk

Unreviewed, rolling out r225089.
https://bugs.webkit.org/show_bug.cgi?id=179937

This patch caused compilation failures (Requested by fredw on
#webkit).

Reverted changeset:

"Async frame scrolling: handle fixed root backgrounds in
frames"
https://bugs.webkit.org/show_bug.cgi?id=176261
https://trac.webkit.org/changeset/225089

Patch by Commit Queue <commit-queue@webkit.org> on 2017-11-21

10:30 PM Changeset in webkit [225089] by fred.wang@free.fr

7 edits in trunk

Async frame scrolling: handle fixed root backgrounds in frames
https://bugs.webkit.org/show_bug.cgi?id=176261

Source/WebCore:

Based on patch by Simon Fraser <Simon Fraser>
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

rendering/RenderLayerBacking.cpp:

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Antonio Gomes.

Extend tiled-drawing-async-frame-scrolling with new test cases and update expectations.

compositing/tiling/tiled-drawing-async-frame-scrolling.html: Add two test cases with

non-white and fixed gradient background. The latter exhibits a crash fixed by that commit.

compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Adjust expectation due

to spacing changes.

platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

Update expectation for the first case to remove the white background and add expectations for
the two new cases.

platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Ditto.

5:02 PM Changeset in webkit [225088] by Simon Fraser

3 edits in trunk/Source/WebCore

Some FELighting cleanup
https://bugs.webkit.org/show_bug.cgi?id=179924

Reviewed by Sam Weinig.

Make the normal-computation functions const and have them return an IntSize.
Replace bit shifting with multiply by two (compilers know how to do this, folks).

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::topLeftNormal const):
(WebCore::FELighting::LightingData::topRowNormal const):
(WebCore::FELighting::LightingData::topRightNormal const):
(WebCore::FELighting::LightingData::leftColumnNormal const):
(WebCore::FELighting::LightingData::interiorNormal const):
(WebCore::FELighting::LightingData::rightColumnNormal const):
(WebCore::FELighting::LightingData::bottomLeftNormal const):
(WebCore::FELighting::LightingData::bottomRowNormal const):
(WebCore::FELighting::LightingData::bottomRightNormal const):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::LightingData::topLeft): Deleted.
(WebCore::FELighting::LightingData::topRow): Deleted.
(WebCore::FELighting::LightingData::topRight): Deleted.
(WebCore::FELighting::LightingData::leftColumn): Deleted.
(WebCore::FELighting::LightingData::interior): Deleted.
(WebCore::FELighting::LightingData::rightColumn): Deleted.
(WebCore::FELighting::LightingData::bottomLeft): Deleted.
(WebCore::FELighting::LightingData::bottomRow): Deleted.
(WebCore::FELighting::LightingData::bottomRight): Deleted.

platform/graphics/filters/FELighting.h:

3:14 PM Changeset in webkit [225087] by commit-queue@webkit.org

17 edits
2 deletes in trunk/Source

[PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
https://bugs.webkit.org/show_bug.cgi?id=179504

Patch by Christopher Reid <chris.reid@sony.com> on 2017-11-21
Reviewed by Darin Adler.

Source/WebCore:

No new tests no change in behavior.

Removed WebCoreNSStringExtras.
Replaced calls to string helpers in WebCoreNSStringExtras with calls to WTF::String.
Moved filenameByFixingIllegalCharacters into LoaderNSURLExtras.
Moved preferredBundleLocalizationName into WebKitLegacy.

PlatformMac.cmake: Removed WebCoreNSStringExtras.mm
SourcesCocoa.txt: Removed WebCoreNSStringExtras.mm
WebCore.xcodeproj/project.pbxproj: Removed WebCoreNSStringExtras
loader/mac/LoaderNSURLExtras.h:
loader/mac/LoaderNSURLExtras.mm:
platform/graphics/mac/FontCacheMac.mm:
platform/mac/PasteboardMac.mm:
platform/mac/WebCoreNSURLExtras.mm:

Source/WebKit:

UIProcess/Cocoa/WebViewImpl.mm:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:
UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

Source/WebKitLegacy/mac:

Misc/WebKitNSStringExtras.mm:
Plugins/Hosted/NetscapePluginHostManager.mm:
Plugins/WebBasePluginPackage.mm:

2:32 PM Changeset in webkit [225086] by Simon Fraser

2 edits in trunk/Source/WebCore

Use vImage to do alpha premultiplication/unpremultiplication in FilterEffect
https://bugs.webkit.org/show_bug.cgi?id=179928

Reviewed by Tim Horton.

The vImage functions are about twice as fast as the existing code.

platform/graphics/filters/FilterEffect.cpp:

(WebCore::copyPremultiplyingAlpha):
(WebCore::copyUnpremultiplyingAlpha):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):

10:43 AM Changeset in webkit [225085] by Ms2ger@igalia.com

4 edits in trunk/LayoutTests

LayoutTests/imported/w3c:
[GTK] Update expectations for wpt/url/failure.html.
https://bugs.webkit.org/show_bug.cgi?id=179920

Unreviewed test gardening.

web-platform-tests/url/failure-expected.txt: update for sendBeacon support.

LayoutTests:
[GTK] Enable imported/w3c/web-platform-tests/url/failure.html
https://bugs.webkit.org/show_bug.cgi?id=179920

Unreviewed test gardening.

platform/gtk/TestExpectations: the test is only flaky or prone to crashing on platforms that enable CONTENT_EXTENSIONS; i.e. mac and ios.

9:16 AM Changeset in webkit [225084] by Simon Fraser

3 edits in trunk/Source/JavaScriptCore

Allow for more efficient use of GenericTypedArrayView
https://bugs.webkit.org/show_bug.cgi?id=179899

Reviewed by Sam Weinig.

Fix ArrayBufferView::setRange() to not make two virtual function calls to byteLength()
under setRangeImpl(). There is only one caller in GenericTypedArrayView, and it can pass
in a length.

Add GenericTypedArrayView::getRange() to fetch a range of elements, also without virtual
byteLength() calls.

Renamed 'dataLength' to 'count' in setRange() to be clearer.

Added setNative() for callers who don't need clamping of doubles.

runtime/ArrayBufferView.h:

(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::getRangeImpl):

runtime/GenericTypedArrayView.h:

(JSC::GenericTypedArrayView::setRange):
(JSC::GenericTypedArrayView::setNative const):
(JSC::GenericTypedArrayView::getRange):
(JSC::GenericTypedArrayView::checkInboundData const):
(JSC::GenericTypedArrayView::internalByteLength const):

8:56 AM Changeset in webkit [225083] by Carlos Garcia Campos

3 edits in trunk/Source/WebDriver

WebDriver: do not try to parse http body if method is not POST
https://bugs.webkit.org/show_bug.cgi?id=179918

Reviewed by Darin Adler.

As said in the spec:

If request’s method is POST:

Let parse result be the result of parsing as JSON with request’s body as the argument. If this process throws an exception, return an error with error code invalid argument and jump back to step 1 in this overall algorithm.

If parse result is not an Object, send an error with error code invalid argument and jump back to step 1 in this overall algorithm.

Otherwise, let parameters be parse result.

Otherwise, let parameters be null.

6.3 Processing Model
https://w3c.github.io/webdriver/webdriver-spec.html#processing-model

Now, w3c tests are sending null as body of delete session command (it used to be just empty), making it fail
with invalid argument error.

WebDriverService.cpp:

(WebDriver::WebDriverService::findCommand):
(WebDriver::WebDriverService::handleRequest):

WebDriverService.h:

8:55 AM Changeset in webkit [225082] by Carlos Garcia Campos

2 edits in trunk/Source/WebDriver

WebDriver: crash in Session::computeElementLayout when called without a current browsing context
https://bugs.webkit.org/show_bug.cgi?id=179917

Reviewed by Darin Adler.

In the case of computeElementLayout message, the frameHandle parameter is not optional, but we still need to
provide a valid value (empty string means the default frame) when m_currentBrowsingContext is std::nullopt. The
same applies to selectOptionElement.

Session.cpp:

(WebDriver::Session::computeElementLayout):
(WebDriver::Session::selectOptionElement):

8:53 AM Changeset in webkit [225081] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GLIB] Test FileMonitorTest.DetectChangeAndThenDelete sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=179909

Reviewed by Michael Catanzaro.

The problem sems to be that the GFileMonitor is created in the main thread, but destroyed in the WorkQueue
thread. We can create the monitor in the WorkQueue thread and do the monitoring there.

Fixes unit test FileMonitorTest.DetectChangeAndThenDelete.

platform/glib/FileMonitorGLib.cpp:

(WebCore::FileMonitor::FileMonitor): Create the GFileMonitor in the WorkQueue.
(WebCore::FileMonitor::didChange): No need to dispatch the handler in the WorkQueue, since this is now called in
the WorkQueue.

8:52 AM Changeset in webkit [225080] by Carlos Garcia Campos

3 edits in trunk/Tools

[WPE] Run unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=179910

Reviewed by Michael Catanzaro.

Add a step to run unit tests in WPE test bots.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGLibAPITests):
(RunGtkAPITests):
(RunWPEAPITests):
(TestFactory.init):
(RunGtkAPITests.start): Deleted.
(RunGtkAPITests.commandComplete): Deleted.
(RunGtkAPITests.evaluateCommand): Deleted.
(RunGtkAPITests.getText): Deleted.
(RunGtkAPITests.getText2): Deleted.

wpe/jhbuild.modules: Upgrade WPEBackend-mesa to fix crashes when running unit tests.

7:32 AM WebKitGTK/Releasing edited by Michael Catanzaro

Need to update gnome-sdk-images and gnome-continuous after releases (diff)

7:20 AM Changeset in webkit [225079] by tpopela@redhat.com

2 edits in trunk/Source/WebInspectorUI

Unreviewed compile warning fix

WARNING: console.assert inside control flow statement without braces on line: 130487:
console.assert(this._loggingChannelSources.includes(channel.source));

UserInterface/Controllers/LogManager.js:

(WI.LogManager):

6:06 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

5:37 AM Changeset in webkit [225078] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[WPE] WPEWebProcess: Couldn't find current GLX or EGL context
https://bugs.webkit.org/show_bug.cgi?id=179883

Reviewed by Žan Doberšek.

I'm seeing that message quite often when running the unit tests. The problem seems to be that some tests run so
fast that the web process never renders the first frame, so the context is created but never made current. I've
checked with apitrace that there are calls to eglQueryContext with null display, causing a EGL_BAD_DISPLAY, but
I don't know where those calls are originated. Making the context current right after it's created fixes the
problem.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::createGLContext): Always call makeContextCurrent() right after the context is created.

5:37 AM Changeset in webkit [225077] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

[Cairo] drawNativeImage(), drawPattern() in CairoOperations should operate directly with cairo_surface_t objects
https://bugs.webkit.org/show_bug.cgi?id=179888

Reviewed by Carlos Garcia Campos.

Cairo::drawNativeImage() should receive a valid cairo_surface_t pointer
and work with that, instead of using a NativeImagePtr. Callers are thus
forced to pass the pointer into the drawNativeImage() call, and the
CairoOperations implementation file drops the need to know about the
NativeImagePtr type alias.

Cairo::drawPattern() now accepts pointer to the cairo_surface_t object,
along with an IntSize object that descibes the surface's size. This way
it's up to the caller to retrieve any valid native image for the current
frame and pass that to the drawPattern() call. The need to use IntSize
here is strange, but we should investigate this later.

No new tests -- no change in behavior.

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawNativeImage):
(WebCore::Cairo::drawPattern):

platform/graphics/cairo/CairoOperations.h: Include the Cairo header.

Also fix forward declaration of Cairo::drawGlyphs().

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):

platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::drawNativeImage): Execute operation through GraphicsContext,
kicking into effect any recording that could be done this way.

5:35 AM Changeset in webkit [225076] by Carlos Garcia Campos

46 edits
13 adds in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

imported/w3c/importer.json:
imported/w3c/tools/webdriver/webdriver/client.py:
imported/w3c/tools/webdriver/webdriver/error.py:
imported/w3c/tools/webdriver/webdriver/protocol.py: Added.
imported/w3c/tools/webdriver/webdriver/transport.py:
imported/w3c/tools/wptrunner/MANIFEST.in:
imported/w3c/tools/wptrunner/requirements_firefox.txt:
imported/w3c/tools/wptrunner/requirements_opera.txt: Added.
imported/w3c/tools/wptrunner/wptrunner/browsers/init.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/edge.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/opera.py: Added.
imported/w3c/tools/wptrunner/wptrunner/environment.py:
imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executoredge.py: Added.
imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executoropera.py: Added.
imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
imported/w3c/tools/wptrunner/wptrunner/executors/testharness_webdriver.js:
imported/w3c/tools/wptrunner/wptrunner/executors/testharness_webdriver_resume.js: Added.
imported/w3c/tools/wptrunner/wptrunner/stability.py: Added.
imported/w3c/tools/wptrunner/wptrunner/testdriver-extra.js: Added.
imported/w3c/tools/wptrunner/wptrunner/testloader.py:
imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
imported/w3c/tools/wptrunner/wptrunner/update/state.py:
imported/w3c/tools/wptrunner/wptrunner/update/sync.py:
imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
imported/w3c/tools/wptrunner/wptrunner/wptlogging.py:
imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
imported/w3c/webdriver/tests/actions/conftest.py:
imported/w3c/webdriver/tests/actions/key.py:
imported/w3c/webdriver/tests/actions/key_shortcuts.py: Added.
imported/w3c/webdriver/tests/actions/modifier_click.py: Added.
imported/w3c/webdriver/tests/actions/mouse.py:
imported/w3c/webdriver/tests/actions/sequence.py:
imported/w3c/webdriver/tests/actions/special_keys.py:
imported/w3c/webdriver/tests/actions/support/keys.py:
imported/w3c/webdriver/tests/actions/support/test_actions_wdspec.html:
imported/w3c/webdriver/tests/cookies/add_cookie.py:
imported/w3c/webdriver/tests/cookies/get_named_cookie.py:
imported/w3c/webdriver/tests/element_click/stale.py: Added.
imported/w3c/webdriver/tests/element_retrieval/get_active_element.py:
imported/w3c/webdriver/tests/interaction/element_clear.py: Added.
imported/w3c/webdriver/tests/navigation/get_title.py:
imported/w3c/webdriver/tests/retrieval/find_element.py:
imported/w3c/webdriver/tests/retrieval/find_element_from_element.py:
imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py:
imported/w3c/webdriver/tests/retrieval/find_elements.py:
imported/w3c/webdriver/tests/sessions/new_session/support/init.py:
imported/w3c/webdriver/tests/state/get_element_attribute.py:
imported/w3c/webdriver/tests/state/get_element_property.py:
imported/w3c/webdriver/tests/state/get_element_tag_name.py:
imported/w3c/webdriver/tests/state/is_element_selected.py:
imported/w3c/webdriver/tests/support/asserts.py:
imported/w3c/webdriver/tests/user_prompts/send_alert_text.py: Added.

5:35 AM Changeset in webkit [225075] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[Cairo] Gradient::fill() should only operate on PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=179887

Reviewed by Carlos Garcia Campos.

In Gradient::fill(), directly invoke Cairo::save() and Cairo::restore(),
instead of doing so indirectly through GraphicsContext::save() and
GraphicsContext::restore(). The latter pair stashes the internal state
that's managed in GraphicsContext, but that doesn't get modified at all
in this case.

No new tests -- no change in behavior.

platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::fill):

4:58 AM Changeset in webkit [225074] by tpopela@redhat.com

2 edits in trunk/Tools

Fix WebKitGTK+ compilation

Reviewed by Carlos Garcia Campos.

File "/builddir/build/BUILD/webkitgtk-2.19.2/Tools/gtk/generate-gtkdoc", line 31, in <module>
import common
ImportError: No module named common

gtk/manifest.txt.in:

Add Tools/glib/common.py to the tarball.

3:28 AM Changeset in webkit [225073] by Ms2ger@igalia.com

2 edits in trunk/Tools

[GTK] Avoid warning in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=179913

Reviewed by Carlos Garcia Campos.

Apparently this is not quite a real python file; this declaration causes
warnings like

I: unknown keys defined in configuration file: top_level_directory

which break run-webkit-tests.

gtk/jhbuildrc:

2:40 AM Changeset in webkit [225072] by Yusuke Suzuki

24 edits
5 adds in trunk

[DFG][FTL] Support MapSet / SetAdd intrinsics
https://bugs.webkit.org/show_bug.cgi?id=179858

Reviewed by Saam Barati.

JSTests:

microbenchmarks/map-has-and-set.js: Added.

(test):

stress/map-set-check-failure.js: Added.

(shouldBe):
(shouldThrow):
(target):

stress/map-set-cse.js: Added.

(shouldBe):
(test):

stress/set-add-check-failure.js: Added.

(shouldBe):
(shouldThrow):
(set shouldThrow):

stress/set-add-cse.js: Added.

(shouldBe):

Source/JavaScriptCore:

Map.prototype.set and Set.prototype.add uses MapHash value anyway.
By handling them as MapSet and SetAdd DFG nodes and decoupling
MapSet and SetAdd nodes from MapHash DFG node, we have a chance to
remove duplicate MapHash calculation for the same key.

One story is *set-if-not-exists*.

if (!map.has(key))

map.set(key, value);

In the above code, both has and set require hash value for key.
If we can change set to the series of DFG nodes:

1: MapHash(key)
2: MapSet(MapObjectUse:map, Untyped:key, Untyped:value, Int32Use:@1)

we can remove duplicate @1 produced by has operation.

This patch improves SixSpeed map-set.es6 and map-set-object.es6 by 20.5% and 20.4% respectively,

baseline patched

map-set.es6 246.2413+-15.2084 ^{204.3679+-11.2408} definitely 1.2049x faster
map-set-object.es6 266.5075+-17.2289 ^{221.2792+-12.2948} definitely 1.2044x faster

Microbenchmarks

map-has-and-set 148.1522+-7.6665 ^{131.4552+-7.8846} definitely 1.1270x faster

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSetAdd):
(JSC::DFG::SpeculativeJIT::compileMapSet):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):

jit/JITOperations.h:
runtime/HashMapImpl.h:

(JSC::HashMapImpl::addNormalized):
(JSC::HashMapImpl::addNormalizedInternal):

runtime/Intrinsic.cpp:

(JSC::intrinsicName):

runtime/Intrinsic.h:
runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

2:07 AM Changeset in webkit [225071] by Yusuke Suzuki

6 edits
2 adds in trunk

[JSC] Allow poly proto for intrinsic getters
https://bugs.webkit.org/show_bug.cgi?id=179550

Reviewed by Saam Barati.

JSTests:

This change is also tested by existing tests.

stress/intrinsic-getter-with-poly-proto.js
stress/poly-proto-intrinsic-getter-correctness.js

stress/intrinsic-getter-with-poly-proto-getter-change.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

stress/intrinsic-getter-with-poly-proto-proto-change.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

Source/JavaScriptCore:

This patch allows intrinsic getters to accept poly proto.
We propagate PolyProtoAccessChain in IntrinsicGetterAccessCase to perform
poly proto checks. And we extend UnderscoreProtoIntrinsic to emit
code for poly proto case.

bytecode/IntrinsicGetterAccessCase.cpp:

(JSC::IntrinsicGetterAccessCase::IntrinsicGetterAccessCase):
(JSC::IntrinsicGetterAccessCase::create):

bytecode/IntrinsicGetterAccessCase.h:
jit/IntrinsicEmitter.cpp:

(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):

jit/Repatch.cpp:

(JSC::tryCacheGetByID):

1:19 AM Changeset in webkit [225070] by fred.wang@free.fr

1 edit
1 delete in trunk/Source/WebCore

Remove unintentionally committed .orig file.
https://bugs.webkit.org/show_bug.cgi?id=174131

Unreviewed, fix previous commit.

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21

rendering/mathml/RenderMathMLScripts.cpp.orig: Removed.

12:37 AM Changeset in webkit [225069] by fred.wang@free.fr

3 edits
1 copy
2 adds in trunk

ASSERTION FAILED: !needsLayout() in WebCore::RenderMathMLScripts::firstLineBaseline
https://bugs.webkit.org/show_bug.cgi?id=174131

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-21
Reviewed by Alejandro G. Castro.

Source/WebCore:

RenderMathMLScripts::firstLineBaseline() has an ASSERT at the beginning to ensure that the function
is called after the element was laid out. However, this is not respected by HTML table layout as
RenderBlock::firstLineBaseline() is called for elements in a table cell before they are laid out.
This happens for example for RenderGrid::firstLineBaseline() and probably for other renderers.
Additionally, RenderMathMLScripts::firstLineBaseline() only involves calling firstLineBaseline();
logicalTop() or logicalHeight() on the first child box so it is safe to call it before layout, even
if the return value might be wrong at that time. This patch removes this too restrictive ASSERT for
RenderMathMLScripts, for consistency with other implementations of firstLineBaseline().

Test: mathml/cells-and-scripts-crash.html

rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::firstLineBaseline const): Remove the ASSERT.

LayoutTests:

Add tests for calling RenderMathMLScripts::firstLineBaseline with needsLayout() == true.

mathml/cells-and-scripts-crash-expected.txt: Added.
mathml/cells-and-scripts-crash.html: Added.

12:03 AM Changeset in webkit [225068] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix WPE make distcheck.

wpe/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.

12:02 AM Changeset in webkit [225067] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.19.2

WebKitGTK+ 2.19.2

12:01 AM Changeset in webkit [225066] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.2 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.19.2.

Nov 20, 2017:

11:59 PM Changeset in webkit [225065] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

gtk/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.

6:49 PM Changeset in webkit [225064] by don.olmstead@sony.com

2 edits in trunk/Source/WebKit

Add declspec within WebKit API
https://bugs.webkit.org/show_bug.cgi?id=179893

Reviewed by Darin Adler.

Shared/API/c/WKDeclarationSpecifiers.h:

6:48 PM Changeset in webkit [225063] by don.olmstead@sony.com

2 edits in trunk/Source/JavaScriptCore

Detect declspec within JSBase.h
https://bugs.webkit.org/show_bug.cgi?id=179892

Reviewed by Darin Adler.

API/JSBase.h:

6:29 PM Changeset in webkit [225062] by Michael Catanzaro

2 edits in trunk/LayoutTests

Unreviewed, mark one more GTK test as passing

platform/gtk/TestExpectations:

5:27 PM Changeset in webkit [225061] by guijemont@igalia.com

2 edits in trunk/JSTests

Skip stress/unshiftCountSlowCase-correct-postCapacity.js on embedded Linux
https://bugs.webkit.org/show_bug.cgi?id=179744

Reviewed by Michael Catanzaro.

This test uses too much memory for our buildbots on these platforms
and gets OOM-killed.

stress/unshiftCountSlowCase-correct-postCapacity.js:

Skip if $memoryLimited and linux.

5:25 PM Changeset in webkit [225060] by Michael Catanzaro

2 edits in trunk/Tools

[WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=179889

Reviewed by Darin Adler.

Scripts/webkitperl/FeatureList.pm:

5:24 PM Changeset in webkit [225059] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

Layout Test js/intl-datetimeformat.html is failing on High Sierra (GMT vs. UTC)
https://bugs.webkit.org/show_bug.cgi?id=179208

Patch by Andy VanWagoner <andy@thetalecrafter.com> on 2017-11-20
Reviewed by Darin Adler.

Use time zones that are unambiguous in datetimeformat tests.

js/intl-datetimeformat-expected.txt:
js/script-tests/intl-datetimeformat.js:
platform/mac/TestExpectations:

4:59 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

4:58 PM Changeset in webkit [225058] by Michael Catanzaro

3 edits in trunk/LayoutTests

Unreviewed GTK test gardening

TestExpectations:
platform/gtk/TestExpectations:

3:55 PM Changeset in webkit [225057] by Michael Catanzaro

2 edits in trunk/LayoutTests

Better unreviewed WPE test gardening

I gave this test a TIMEOUT expectation because there is an XHR timeout, but that was dumb
because the test itself does not time out.

platform/wpe/TestExpectations:

3:54 PM Changeset in webkit [225056] by Michael Catanzaro

2 edits in trunk/LayoutTests

Unreviewed WPE test gardening

platform/wpe/TestExpectations:

3:51 PM Changeset in webkit [225055] by Michael Catanzaro

2 edits in trunk/Tools

Unreviewed, speculative attempt to fix run-gtk-tests after r225047
https://bugs.webkit.org/show_bug.cgi?id=173772

jhbuild/jhbuildutils.py:

(enter_jhbuild_environment_if_available):

2:02 PM Changeset in webkit [225054] by mario@webkit.org

11 edits
1 add in trunk

[GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=177932

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Implemented setCookie(), getCookies() and deleteCookie() in the Soup
backend, and refactored some utility functions and conversions out of
NetworkStorageSessionSoup into a new CookieSoup.cpp file, so
that we now can convert between SoupCookie* and WebCore::Cookie
easily from anywhere (this is now needed from the UI Process).

platform/Cookie.h: Add declarations for the new conversions.
platform/SourcesSoup.txt: Add CookieSoup.cpp.
platform/network/soup/CookieSoup.cpp: Added.

(WebCore::Cookie::Cookie): New constructor, creates a WebCore::Cookie out of a SoupCookie*.
(WebCore::msToSoupDate): Moved from NetworkStorageSessionSoup.cpp.
(WebCore::Cookie::toSoupCookie): New, based on toSoupCookie() from NetworkStorageSessionSoup.cpp.

platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookies): Used the new implicit conversion.
(WebCore::NetworkStorageSession::setCookie): Newly implemented.
(WebCore::NetworkStorageSession::deleteCookie): Newly implemented.
(WebCore::NetworkStorageSession::getCookies): Newly implemented.

Source/WebKit:

Added new API to WebKitCookieManager to add, retrieve and delete complete
cookies into/out-of a running session, and updated documentation sections.

UIProcess/API/glib/WebKitCookieManager.cpp:

(webkit_cookie_manager_add_cookie): New function.
(webkit_cookie_manager_add_cookie_finish): Ditto.
(webkit_cookie_manager_get_cookies): Ditto.
(webkit_cookie_manager_get_cookies_finish): Ditto.
(webkit_cookie_manager_delete_cookie): Ditto.
(webkit_cookie_manager_delete_cookie_finish): Ditto.

UIProcess/API/gtk/WebKitCookieManager.h: Added new functions.
UIProcess/API/wpe/WebKitCookieManager.h: Ditto.
UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Ditto.

Tools:

Added new test cases to cover the newly added API for WebKitCookieManager:
webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
webkit_cookie_manager_delete_cookie.

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerAddCookie): Added.
(testCookieManagerGetCookies): Added.
(testCookieManagerDeleteCookie): Added.
(serverCallback): Small update to avoid hardcoding strings we reuse.
(beforeAll): Added the new test cases to the test suite.

1:20 PM Changeset in webkit [225053] by commit-queue@webkit.org

2 edits in trunk/Tools

[Win] Update ruby JSC test writer for gigacage changes
https://bugs.webkit.org/show_bug.cgi?id=178757

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-20
Reviewed by Keith Miller.

Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:

Add additionalEnv to ruby test writer Plan

11:28 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

9:18 AM Changeset in webkit [225052] by Alan Bujtas

5 edits
2 adds in trunk

Remove slow repaint object from FrameView when style changes.
https://bugs.webkit.org/show_bug.cgi?id=179871

Reviewed by Antti Koivisto.

Source/WebCore:

The "oldStyleSlowScroll" value does not need to be computed. We already know its value
by checking the HashSet. This code is also unnecessarily complicated and error prone
(could lead to UAF errors by leaving stale renderers in the slow paint list).

Test: fast/repaint/slow-repaint-object-crash.html

rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

LayoutTests:

fast/repaint/slow-repaint-object-crash-expected.txt: Added.
fast/repaint/slow-repaint-object-crash.html: Added.

9:17 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

8:33 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:33 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:30 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:26 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

8:26 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

8:25 AM WebKitGTK/GCCRequirement created by Michael Catanzaro

7:57 AM Changeset in webkit [225051] by clopez@igalia.com

2 edits in trunk/Source/WebCore

[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}
https://bugs.webkit.org/show_bug.cgi?id=179511

Reviewed by Žan Doberšek.

r217208 changed the definition of GLNativeWindowType from EGLNativeWindowType to uint64_t for platform WPE.
This built fine on a 64-bit platform since uint64_t matches the size of a pointer, but fails on 32-bits.

This switches back the definition to EGLNativeWindowType.
And we need to include <EGL/eglplatform.h> first in order to get a definition for EGLNativeWindowType itself.

This commit pretty much reverts the changes r217208 did on platform/graphics/GLContext.h

No new tests, it is a build fix.

platform/graphics/GLContext.h:

7:46 AM Changeset in webkit [225050] by Michael Catanzaro

7 edits in trunk

Remove ENABLE_ALLINONE_BUILD option
https://bugs.webkit.org/show_bug.cgi?id=179823

Reviewed by Darin Adler.

Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

CMakeLists.txt:

Tools:

Scripts/webkitperl/FeatureList.pm:

4:32 AM Changeset in webkit [225049] by emilio

8 edits in trunk

Incorrect computed style in pseudo-elements with display: contents
https://bugs.webkit.org/show_bug.cgi?id=179812

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
web-platform-tests/cssom/getComputedStyle-pseudo.html: Extended the testcase to cover this bug.

Source/WebCore:

Bug 178513 gave them an anon renderer as the main renderer. Unfortunately, the
style of that box is exposed via getComputedStyle, so that needs to be handled
somehow to return the correct style.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledRenderer const):

Don't return a display: contents pseudo anon box.

dom/Element.cpp:

(WebCore::Element::hasDisplayContents const):

Just look at the rare data style.

(WebCore::Element::existingComputedStyle const):

Look at the rare data first. This also fixes an inefficiency in the
sense that before then we'd compare the anon box style to the
pseudo-element style during style update, that may be more changes
than needed.

style/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolvePseudoStyle):

Move the anon box creation to render tree update instead of style
resolution.

3:22 AM Changeset in webkit [225048] by Carlos Garcia Campos

3 edits in trunk/Tools

Unreviewed. Fix WPE build after r225047.

Remove changes from an old patch committed by mistake in r225047.

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

3:03 AM Changeset in webkit [225047] by Carlos Garcia Campos

8 edits
1 copy
1 move
3 adds in trunk/Tools

[WPE] Add run-wpe-tests script to run WPE glib API tests
https://bugs.webkit.org/show_bug.cgi?id=173772

Reviewed by Michael Catanzaro.

Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.

Scripts/run-gtk-tests:

(GtkTestRunner):
(GtkTestRunner.init):
(GtkTestRunner._start_accessibility_daemons):
(GtkTestRunner._setup_testing_environment):
(GtkTestRunner._tear_down_testing_environment):
(GtkTestRunner.is_glib_test):
(GtkTestRunner.is_google_test):

Scripts/run-wpe-tests: Added.

(WPETestRunner):
(WPETestRunner.init):
(WPETestRunner.is_glib_test):
(WPETestRunner.is_google_test):

Scripts/webkitpy/port/headlessdriver.py: Added.

(HeadlessDriver):
(HeadlessDriver._setup_environ_for_test):
(HeadlessDriver._start):

Scripts/webkitpy/port/headlessdriver_unittest.py: Added.

(HeadlessDriverTest):
(HeadlessDriverTest.make_driver):
(HeadlessDriverTest.make_environment):
(HeadlessDriverTest.test_environment_needed_variables):
(HeadlessDriverTest.test_environment_forbidden_variables):

Scripts/webkitpy/port/wpe.py:

(WPEPort._driver_class):

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.

(SkippedTest):
(SkippedTest.init):
(SkippedTest.str):
(SkippedTest.skip_entire_suite):
(SkippedTest.skip_for_build_type):
(TestTimeout):
(TestRunner):
(TestRunner.init):
(TestRunner._test_programs_base_dir):
(TestRunner._get_tests_from_dir):
(TestRunner._get_tests):
(TestRunner._create_driver):
(TestRunner._setup_testing_environment):
(TestRunner._tear_down_testing_environment):
(TestRunner._test_cases_to_skip):
(TestRunner._should_run_test_program):
(TestRunner._kill_process):
(TestRunner._start_timeout):
(TestRunner._start_timeout._alarm_handler):
(TestRunner._stop_timeout):
(TestRunner._waitpid):
(TestRunner._run_test_glib):
(TestRunner._run_test_glib.parse_line):
(TestRunner._run_test_glib.parse_line.set_test_result):
(TestRunner._get_tests_from_google_test_suite):
(TestRunner._run_google_test):
(TestRunner._run_google_test_suite):
(TestRunner.is_glib_test):
(TestRunner.is_google_test):
(TestRunner._run_test):
(TestRunner.run_tests):
(add_options):

glib/common.py: Renamed from Tools/gtk/common.py.

(get_build_path.is_valid_build_directory):

gtk/generate-gtkdoc:
gtk/jhbuildrc:
gtk/ycm_extra_conf.py:

1:51 AM Changeset in webkit [225046] by Carlos Garcia Campos

6 edits
1 add in trunk/Tools

[WPE] Build C API tests
https://bugs.webkit.org/show_bug.cgi?id=179817

Reviewed by Michael Catanzaro.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWPE.cmake:
TestWebKitAPI/PlatformWebView.h:
TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:

(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):

TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::page const):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

1:47 AM Changeset in webkit [225045] by Carlos Garcia Campos

11 edits
2 moves
2 adds in trunk/Tools

[WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
https://bugs.webkit.org/show_bug.cgi?id=173770

Reviewed by Michael Catanzaro.

Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".

CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionRequestSession):

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerEphemeral):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:

(testPrivateBrowsing):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextProxySettings):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewWebContext):
(testWebViewEphemeral):

TestWebKitAPI/glib/PlatformWPE.cmake:
TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebViewBackend):
(Test::createWebView):

TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):

WebKitTestRunner/PlatformWPE.cmake:
wpe/HeadlessViewBackend/CMakeLists.txt: Added.
wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.

(HeadlessViewBackend::HeadlessViewBackend):

wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.

12:38 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:16 AM Changeset in webkit [225044] by Carlos Garcia Campos

22 edits
3 adds in trunk

[WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
https://bugs.webkit.org/show_bug.cgi?id=178655

Reviewed by Michael Catanzaro.

Source/WebKit:

Update all WebKitWebView constructors to receive a WebKitWebViewBackend as argument. It's now required to
provide a backend to create a web view, but it can be NULL to use the default one. WebKitWebViewBackend is a
boxed type wrapping a struct wpe_view_backend* used as construct only property of WebKitWebView. The view always
takes the ownership of the WebKitWebViewBackend which owns the struct wpe_view_backend*. An optional
GDestroyNotify and user data pointer can be passed to the WebKitWebViewBackend constructor to provide a custom
deleter for the backend. In the C API the struct wpe_view_backend* is also mandatory now, but it can't be NULL
and it's owned by the caller, not the view.

PlatformWPE.cmake:
UIProcess/API/C/wpe/WKView.cpp:

(WKViewCreate):

UIProcess/API/C/wpe/WKView.h:
UIProcess/API/glib/WebKitWebView.cpp:

(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkitWebViewCreatePage):
(webkit_web_view_get_backend):

UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):
(WKWPE::View::~View):

UIProcess/API/wpe/WebKitWebView.h:
UIProcess/API/wpe/WebKitWebViewBackend.cpp: Added.

(_WebKitWebViewBackend::_WebKitWebViewBackend):
(_WebKitWebViewBackend::~_WebKitWebViewBackend):
(webkitWebViewBackendRef):
(webkitWebViewBackendUnref):
(webkitWebViewBackendCreateDefault):
(webkit_web_view_backend_new):
(webkit_web_view_backend_get_wpe_backend):

UIProcess/API/wpe/WebKitWebViewBackend.h: Added.
UIProcess/API/wpe/WebKitWebViewBackendPrivate.h: Added.
UIProcess/API/wpe/WebKitWebViewWPE.cpp:

(webkit_web_view_new):
(webkit_web_view_new_with_context):
(webkit_web_view_new_with_related_view):
(webkit_web_view_new_with_settings):
(webkit_web_view_new_with_user_content_manager):

UIProcess/API/wpe/webkit.h:

Tools:

Update unit tests to create web views using helper methods that have a different implementation for GTK and
WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionRequestSession):

TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:

(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):
(testWebKitWebViewNavigationAfterSessionRestore):

TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:

(testWebResourceGetDataError):

TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:

(testWebViewNewWithUserContentManager):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextEphemeral):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewWebContext):
(testWebViewWebContextLifetime):
(testWebViewWebBackend):
(testWebViewSettings):
(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(testWebsiteDataEphemeral):

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebView):

WebKitTestRunner/wpe/HeadlessViewBackend.cpp:

(HeadlessViewBackend::~HeadlessViewBackend):

WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::PlatformWebView):

12:11 AM Changeset in webkit [225043] by Carlos Garcia Campos

4 edits in trunk

[GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Reviewed by Michael Catanzaro.

Source/WebKit:

This is what happens:

1- We create our WebKitWebContext that creates its WebProcessPool.
2- We set a persistent cookies storage.
3- We ask the website data store to delete all cookies, but since website data store is a web process observer

and we haven't spawned any web process yet, it creates a new WebProcessPool with the default configuration
(no persistent cookies) and sends the message to delete the cookies there.

4- The network process of the second process pool does nothing because it doesn't have cookies at all.

We need to set the primary data store of the WebProcessPool when WebKitWebContext is constructed to ensure that
one is used before the web process is launched.

UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):

Tools:

Add test case.

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerPersistentStorageDeleteAll):
(serverCallback):
(beforeAll):

Nov 19, 2017:

9:10 PM Changeset in webkit [225042] by timothy_horton@apple.com

18 edits in trunk

Remove unused TOUCH_ICON_LOADING feature flag
https://bugs.webkit.org/show_bug.cgi?id=179873

Reviewed by Simon Fraser.

Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:53 PM Changeset in webkit [225041] by Ms2ger@igalia.com

2 edits
5 adds in trunk/LayoutTests

[WPE] Enable the XMLHttpRequest/ directory of web-platform-tests.
https://bugs.webkit.org/show_bug.cgi?id=179820

Reviewed by Sam Weinig.

Added test expectations are copied from platform/gtk/

platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Added.

5:41 PM Changeset in webkit [225040] by Yusuke Suzuki

8 edits in trunk

Add CPU(UNKNOWN) to cover all the unknown CPU types
https://bugs.webkit.org/show_bug.cgi?id=179243

Reviewed by JF Bastien.

Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).

CMakeLists.txt:

Source/JavaScriptCore:

CMakeLists.txt:

Source/WTF:

This patch adds a new CPU type, CPU(UNKNOWN) to cover all the unknown CPUs.
This CPU architecture tells conservative assumption to make JSC work on all
the unknown generic CPUs. And we make several CPUs (ALPHA, SH4, S390, S390X, IA64, IA64_32)
UNKNOWN.

We also make InlineASM available only for !CPU(UNKNOWN). In an unknown CPU, inline asm is not useful.

And we also introduce a generic way to detect 64bit pointer environment by using
SIZEOF_POINTER predefined macro, or UINTPTR_MAX > UINT32_MAX.

wtf/InlineASM.h:
wtf/Platform.h:
wtf/dtoa/utils.h:

5:31 PM Changeset in webkit [225039] by timothy_horton@apple.com

19 edits in trunk

Remove unused LEGACY_VENDOR_PREFIXES feature flag
https://bugs.webkit.org/show_bug.cgi?id=179872

Reviewed by Darin Adler.

Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:08 PM Changeset in webkit [225038] by Chris Dumez

2 edits in trunk/Source/WTF

Fix potential thread safety issue in ThreadSafeIdentified
https://bugs.webkit.org/show_bug.cgi?id=179879

Reviewed by Darin Adler.

Fix potential thread safety issue in ThreadSafeIdentified. Protect static std::atomic
initialization with an std::call_once() given that we build with
--fno-threadsafe-statics.

wtf/Identified.h:

(WTF::Identified::Identified):
(WTF::Identified::generateIdentifier):
(WTF::ThreadSafeIdentified::ThreadSafeIdentified):
(WTF::ThreadSafeIdentified::generateIdentifier):

4:56 PM Changeset in webkit [225037] by Darin Adler

38 edits in trunk/Source

Eliminate some cases of double hashing, other related refactoring
https://bugs.webkit.org/show_bug.cgi?id=179867

Reviewed by Sam Weinig.

Source/WebCore:

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore): Use get instead of find.

Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::unregisterURL): Use take instead of find/remove.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache): Call setAXObjectID instead of
using the removeAXID, which doesn't do anything else useful in the destructor.
(WebCore::AXObjectCache::remove): Use take instead of get/remove. Also rearrange
logic to eliminate the removeAXID function.
(WebCore::AXObjectCache::removeAXID): Deleted. This only did two things,
setAXObjectID(0) and remove from m_idsInUse, and was only called in one place
besides the destructor. Clearer to not have this funtion.
(WebCore::AXObjectCache::visiblePositionForTextMarkerData): Use m_idsInUse
directly instead of using a function.

accessibility/AXObjectCache.h: Deleted removeAXID and isIDinUse.

dom/Document.cpp:

(WebCore::Document::removedLastRef): Call UserActionElementSet::clear instead
of UserActionElementSet::documentDidRemoveLastRef; new name fo the same function.
(WebCore::Document::updateHoverActiveState): Use a reference when calling
setInActiveChain.

dom/Element.cpp:

(WebCore::Element::isUserActionElementInActiveChain const): Pass reference
instead of pointer.
(WebCore::Element::isUserActionElementActive const): Ditto.
(WebCore::Element::isUserActionElementFocused const): Ditto.
(WebCore::Element::isUserActionElementHovered const): Ditto.
(WebCore::Element::setActive): Ditto.
(WebCore::Element::setFocus): Ditto.
(WebCore::Element::setHovered): Ditto.
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer): Ditto.

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::resume): Removed unneeded speical case for
empty vector.

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Updated now that
parseAttributes returns an optional instead of using a boolean "OK" out argument.

dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add): Use get instead of find.

dom/UserActionElementSet.cpp:

(WebCore::UserActionElementSet::didDetach): Deleted. Moved to class definition and
named clearActiveAndHovered.
(WebCore::UserActionElementSet::clear): Renamed documentDidRemoveLastRef to clear.
(WebCore::UserActionElementSet::hasFlag const): Renamed from hasFlags and also
take reference and enumeration instead of pointer and unsigned. Makes it clearer
this does not allow null and that it works on a single flag, not a set of flags.
(WebCore::UserActionElementSet::clearFlags): Changed argument types to reference
and OptionSet to make it clear this works on a set of flags.
(WebCore::UserActionElementSet::setFlags): Ditto.

dom/UserActionElementSet.h: Updated for changes above. Also made some name

changes, and used an enum class instead of an enum.

html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState const): Updated since
FormControlState is now just a vector, not a class.

html/FileInputType.cpp:

(WebCore::FileInputType::filesFromFormControlState): Ditto.
(WebCore::FileInputType::restoreFormControlState): Removed unneeded check that
valueSize is a multiple of 2. Code will ignore any extra strings at the end, so
there is no need for the validity check.

html/FormController.cpp:

(WebCore::serializeFormControlStateTo): Made a non-member function since
FormControlState is now just a vector, not a class.
(WebCore::deserializeFormControlState): Ditto. Also return optional instead
of relying on a special failure state.
(WebCore::SavedFormState::deserialize): Updated for above changes.
(WebCore::SavedFormState::serializeTo const): Ditto.
(WebCore::SavedFormState::appendControlState): Use add instead of both find and add
to avoid double hashing.
(WebCore::SavedFormState::takeControlState): Removed unneeded check for empty
hash table and tweaked coding style.
(WebCore::SavedFormState::referencedFilePaths const): Renamed to remove "get".
(WebCore::FormKeyGenerator::formKey): Use ensure instead of find and add.
(WebCore::FormController::formElementsCharacterCount const): Don't call
saveFormControlState for non-text-form-controls since we ignored those values.
(WebCore::FormController::willDeleteForm): Take a reference.
(WebCore::FormController::restoreControlStateFor): Update since FormControlState
is now a vector.
(WebCore::FormController::restoreControlStateIn): Use is/downcast and update
since FormControlState is now a vector.
(WebCore::FormController::referencedFilePaths): Renamed to remove "get".
(WebCore::FormController::registerFormElementWithState):Take a reference.
(WebCore::FormController::unregisterFormElementWithState): Ditto.

html/FormController.h: Removed FormControlState class since it was just a

Vector<String> with various unneeded features, such as a "failure" state,
and a never-looked-at type of "skip" or "restore". Updated for other changes
above.

html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::insertedIntoAncestor): Pass reference.
(WebCore::HTMLFormControlElementWithState::removedFromAncestor): Ditto.

html/HTMLFormControlElementWithState.h: Updated for the above. Also added

support for using is/downcast on this.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement): Pass reference.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveFormControlState const): Use reserveInitialCapacit
and uncheckedAppend.
(WebCore::HTMLSelectElement::restoreFormControlState): Updated since state is now
a vector.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState const): Ditto.

html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState const): Ditto.

html/InputType.cpp:

(WebCore::InputType::saveFormControlState const): Ditto.

inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::forcePseudoState): Use get instead of find/end and got
rid of uneeded special case. In another overload, ue add and remove instead of
a find followed by a set or a remove.
(WebCore::InspectorCSSAgent::asInspectorStyleSheet): Use ensure instead of find/set.
(WebCore::InspectorCSSAgent::didRemoveDOMNode): Use take instead of find/remove.
(WebCore::InspectorCSSAgent::didModifyDOMAttr): Use get instead of find.

inspector/agents/InspectorCSSAgent.h: Removed unneeded NodeToInspectorStyleSheet

typedef and changed value type to Ref instead of RefPtr.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind): Use remove instead of contains/remove.
(WebCore::InspectorDOMAgent::nodeForId): Use isValidKey instead of just checking for
0 and use get instead of find.
(WebCore::InspectorDOMAgent::setAttributesAsText): Take out bogus const.
(WebCore::InspectorDOMAgent::moveTo): Ditto.
(WebCore::InspectorDOMAgent::resolveNode): Ditto.
(WebCore::InspectorDOMAgent::isWhitespace): Added FIXME. Use is<Text> instead of
slower nodeType.

inspector/agents/InspectorDOMAgent.h: Removed bogus const.

inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::bind): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbind): Use take instead of find/remove.
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Use take instead of
find/remove.

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies): Use add instead of contains/add.
(WebCore::InspectorPageAgent::frameDetached): Use take instead of find/remove.
(WebCore::InspectorPageAgent::frameId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::loaderId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Got rid of unneeded
local variable.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::sessionID const): Tweaked coding style and added
a null check for page.
(WebCore::CachedResourceLoader::requestResource): Call page directly on the frame
instead of first getting the main frame. Also use take instead of find/remove.
(WebCore::CachedResourceLoader::removeCachedResource): Rewrite assertion.

platform/graphics/FontGenericFamilies.cpp:

(WebCore::setGenericFontFamilyForScript): Use remove instead of find/remove.
Simplified the logic a bit in the add case.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::pauseAnimation): Use add instead of find/add.
Removed code that said "if (action != Remove) action = Pause" since that is a
no-op; there are only two actions, Remove and Pause.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript): Use makeString instead of StringBuilder.
(WebCore::RenderThemeMac::systemColor const): Rewrote to use ensure instead of add.
Also crunched the code a little.

testing/Internals.cpp:

(WebCore::Internals::getReferencedFilePaths const): Updated function name.

xml/parser/XMLDocumentParser.h: Updated for change below.
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::attributesStartElementNsHandler): Updated to use std::optional instead of
a separate boolean for AttributeParseState.
(WebCore::parseAttributes): Ditto. Also changed the return value to work the same way.

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::containsOnlyWhitespace): Added FIXME.

3:06 PM Changeset in webkit [225036] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

Clean up gradient code in preparation for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=179595

Patch by Sam Weinig <sam@webkit.org> on 2017-11-19
Reviewed by Darin Adler.

Switches Gradient to use a Varient with type specific data structs and makes the points / radii immutable.
Replaces CSSGradientValue::addStops with template function CSSGradientValue::computeStops which dispatches to a helper adoptor struct which is passed in for gradient type specific values, rather than switching on type in the function itself. In addition, the function no longer mutates a Gradient, but rather mutates type specific the data struct (e.g. Linear or Radial for now).

css/CSSGradientValue.cpp:

(WebCore::LinearGradientAdaptor::LinearGradientAdaptor):
(WebCore::RadialGradientAdaptor::RadialGradientAdaptor):

Add helper structs for the now templatized CSSGradientValue::computeStops that
implement type specific functionality.

(WebCore::CSSGradientValue::computeStops):

Renamed from addStops. Now takes a GradientAdaptor wrapper which abstracts out
the gradient type specific functionlity.

(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

Update to call computeStops and use new Gradient create function.

css/CSSGradientValue.h:

Update for new signature for computeStops.

html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):

Update to use new Gradient create function.

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

Update to get gradient point / radii information from the data accessor.

platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient):

Update constructors to the new data structs.

(WebCore::Gradient::type const):

Add helper to get the type of the varient, need for inspector code.

(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::addColorStop):

Simplify by having one addColorStop call the other.

(WebCore::Gradient::setSortedColorStops):

Added. Replaces setStopsSorted. Used now that CSSGradientValue computes and sorts
its color stops before creating the gradient.

platform/graphics/Gradient.h:

(WebCore::Gradient::create):

Replace create functions with ones that take data structs.

(WebCore::Gradient::data const):

Add accessor for the underlying variant.

(WebCore::Gradient::isRadial const): Deleted.

Replaced by type accessor.

(WebCore::Gradient::p0 const): Deleted.
(WebCore::Gradient::p1 const): Deleted.
(WebCore::Gradient::setP0): Deleted.
(WebCore::Gradient::setP1): Deleted.
(WebCore::Gradient::startRadius const): Deleted.
(WebCore::Gradient::endRadius const): Deleted.
(WebCore::Gradient::setStartRadius): Deleted.
(WebCore::Gradient::setEndRadius): Deleted.

Point and radii are now immutable.

(WebCore::Gradient::setStopsSorted): Deleted.

Replaced by setSortedColorStops function.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):

Pass the GraphicsContext by reference.

platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformDestroy):

Use nullptr.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

(WebCore::Gradient::paint):

Update to switch on the underlying variant to get data values.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

Pass the GraphicsContext by reference.

platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintProgressBar):

rendering/svg/RenderSVGResourceLinearGradient.cpp:

(WebCore::RenderSVGResourceLinearGradient::buildGradient const):

rendering/svg/RenderSVGResourceRadialGradient.cpp:

(WebCore::RenderSVGResourceRadialGradient::buildGradient const):

Update for new Gradient create function signature.

1:57 PM Changeset in webkit [225035] by Simon Fraser

2 edits in trunk/Source/WebCore

Use TypedArrayView's setRange() in FETurbulence
https://bugs.webkit.org/show_bug.cgi?id=179878

Reviewed by Sam Weinig.

Writing the 4 component values at once makes the function about 10% faster.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):

1:56 PM Changeset in webkit [225034] by Chris Dumez

2 edits in trunk/Source/WTF

Fix potential thread safety issue in generateThreadSafeObjectIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=179877

Reviewed by Sam Weinig.

Fix potential thread safety issue in generateThreadSafeObjectIdentifier().
Protect std::atomic initialization with an std::call_once() given that we
build with --fno-threadsafe-statics.

wtf/ObjectIdentifier.h:

(WTF::generateThreadSafeObjectIdentifier):

7:06 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:19 AM Changeset in webkit [225033] by Yusuke Suzuki

5 edits
2 deletes in trunk/Tools

Unreviewed, rolling out r225016.

Break webkit-patch on Ubuntu and Debian Linux

Reverted changeset:

"webkitpy: Better name-version mapping (Part 1)"
https://bugs.webkit.org/show_bug.cgi?id=179621
https://trac.webkit.org/changeset/225016

12:07 AM Changeset in webkit [225032] by Yusuke Suzuki

2 edits in trunk/Source/WTF

[WTF] Use system endianess information instead of relying CPU information
https://bugs.webkit.org/show_bug.cgi?id=179861

Reviewed by JF Bastien.

Currently, we use known CPU information to determine endianess of the current
architecture. But this means that unknown CPU does not work well in WebKit
withou modifying code. Instead, we use compiler or system's macro to determine
endianess. This paves the way to dropping many CPUs in Platform.h by replacing
them with CPU(UNKNOWN)[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=179243

wtf/Platform.h:

Nov 18, 2017:

11:19 PM Changeset in webkit [225031] by Chris Dumez

35 edits
1 copy in trunk

ASSERTION FAILED: registration in WebCore::SWServerJobQueue::scriptContextStarted(ServiceWorkerIdentifier)
https://bugs.webkit.org/show_bug.cgi?id=179846

Reviewed by Darin Adler.

Source/WebCore:

We have seen crashes on the bots in SWServerJobQueue because methods such as scriptContextStarted()
can get called after the jobQueue has been cleared. This is because when a jobQueue is cleared,
an asynchronous operation may be pending (e.g. script fetch, service worker starting, install event).

To address the issue, we now pass the identifier of the job that started the asynchronous operation
when calling the methods on SWServerJobQueue. If the identifier does not match the identifier of
the current job in the JobQueue, we ignore it.

This patch also starts using a strongly typed identifier (ServiceWorkerJobIdentifier) for
ServiceWorkerJob, instead of a uint64_t. It also introduces a ServiceWorkerJobDataIdentifier type
which contains both a SWServerConnectionIdentifier and a ServiceWorkerJobIdentifier. This is useful
because ServiceWorkerJobData is passed to the StorageProcess and it needs a globally unique identifier.
ServiceWorkerJobIdentifier is only guaranteed to be unique within a single WebProcess. Augmenting it
with the SWServerConnectionIdentifier of the WebProcess makes it globally unique.

No new tests, unskipped exiting test.

WebCore.xcodeproj/project.pbxproj:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::identifier const):

workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):

workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::identifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

workers/service/ServiceWorkerJobDataIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerFetchResult.h.

(WebCore::ServiceWorkerJobDataIdentifier::operator== const):
(WebCore::ServiceWorkerJobDataIdentifier::loggingString const):
(WebCore::ServiceWorkerJobDataIdentifier::encode const):
(WebCore::ServiceWorkerJobDataIdentifier::decode):

workers/service/ServiceWorkerTypes.h:
workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):

workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireInstallEvent):

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::updateWorker):

workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::didFinishInstall):

workers/service/server/SWServerJobQueue.h:
workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):

workers/service/server/SWServerWorker.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.messages.in:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::didFinishInstall):

WebProcess/Storage/WebSWContextManagerConnection.h:

Source/WTF:

Add a generateThreadSafeObjectIdentifier() for generating an ObjectIdentifier
in a thread-safe manner, using std::atomic.

wtf/ObjectIdentifier.h:

(WTF::generateObjectIdentifier):
(WTF::generateThreadSafeObjectIdentifier):

LayoutTests:

Unskip test that use to flakily crash.

platform/mac/TestExpectations:

10:59 PM Changeset in webkit [225030] by n_wang@apple.com

24 edits
2 adds in trunk

AX: AOM: Implement number type properties
https://bugs.webkit.org/show_bug.cgi?id=179497

Reviewed by Chris Fleizach.

Source/WebCore:

Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/

Implemented the number type properties for Accessibility Object Modal.

Test: accessibility/mac/AOM-number-properties.html

accessibility/AXObjectCache.cpp:

(WebCore::isNodeAriaVisible):

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange const):
(WebCore::AccessibilityARIAGridCell::axRowSpanWithRowIndex const):
(WebCore::AccessibilityARIAGridCell::columnIndexRange const):
(WebCore::AccessibilityARIAGridCell::ariaRowSpanWithRowIndex const): Deleted.

accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::headingLevel const):
(WebCore::AccessibilityNodeObject::valueForRange const):
(WebCore::AccessibilityNodeObject::maxValueForRange const):
(WebCore::AccessibilityNodeObject::minValueForRange const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::supportsSetSize const):
(WebCore::AccessibilityObject::supportsPosInSet const):
(WebCore::AccessibilityObject::setSize const):
(WebCore::AccessibilityObject::posInSet const):
(WebCore::AccessibilityObject::supportsARIASetSize const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPosInSet const): Deleted.
(WebCore::AccessibilityObject::ariaSetSize const): Deleted.
(WebCore::AccessibilityObject::ariaPosInSet const): Deleted.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::axColumnCount const):
(WebCore::AccessibilityTable::axRowCount const):
(WebCore::AccessibilityTable::ariaColumnCount const): Deleted.
(WebCore::AccessibilityTable::ariaRowCount const): Deleted.

accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
(WebCore::AccessibilityTableCell::axColumnIndex const):
(WebCore::AccessibilityTableCell::axRowIndex const):
(WebCore::AccessibilityTableCell::axColumnSpan const):
(WebCore::AccessibilityTableCell::axRowSpan const):
(WebCore::AccessibilityTableCell::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaColumnSpan const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowSpan const): Deleted.

accessibility/AccessibilityTableCell.h:

(WebCore::AccessibilityTableCell::setAXColIndexFromRow):
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow): Deleted.

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::axColumnIndex const):
(WebCore::AccessibilityTableRow::axRowIndex const):
(WebCore::AccessibilityTableRow::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableRow::ariaRowIndex const): Deleted.

accessibility/AccessibilityTableRow.h:
accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueInt):
(WebCore::isPropertyValueUnsigned):
(WebCore::isPropertyValueFloat):
(WebCore::AccessibleNode::setProperty):
(WebCore::AccessibleNode::setOptionalProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::optionalValueForProperty):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::effectiveIntValueForElement):
(WebCore::AccessibleNode::effectiveUnsignedValueForElement):
(WebCore::AccessibleNode::effectiveDoubleValueForElement):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::colCount const):
(WebCore::AccessibleNode::setColCount):
(WebCore::AccessibleNode::colIndex const):
(WebCore::AccessibleNode::setColIndex):
(WebCore::AccessibleNode::colSpan const):
(WebCore::AccessibleNode::setColSpan):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::level const):
(WebCore::AccessibleNode::setLevel):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::posInSet const):
(WebCore::AccessibleNode::setPosInSet):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::rowCount const):
(WebCore::AccessibleNode::setRowCount):
(WebCore::AccessibleNode::rowIndex const):
(WebCore::AccessibleNode::setRowIndex):
(WebCore::AccessibleNode::rowSpan const):
(WebCore::AccessibleNode::setRowSpan):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):
(WebCore::AccessibleNode::setSize const):
(WebCore::AccessibleNode::setSetSize):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueMax const):
(WebCore::AccessibleNode::setValueMax):
(WebCore::AccessibleNode::valueMin const):
(WebCore::AccessibleNode::setValueMin):
(WebCore::AccessibleNode::valueNow const):
(WebCore::AccessibleNode::setValueNow):
(WebCore::AccessibleNode::setValueText):
(WebCore::AccessibleNode::boolValueForProperty): Deleted.
(WebCore::AccessibleNode::setBoolProperty): Deleted.

accessibility/AccessibleNode.h:
accessibility/AccessibleNode.idl:
accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):

accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:

(webkitAccessibleTableCellGetPosition):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

accessibility/mac/AOM-number-properties-expected.txt: Added.
accessibility/mac/AOM-number-properties.html: Added.

9:05 PM Changeset in webkit [225029] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Rename some Network Capture debugging defines
https://bugs.webkit.org/show_bug.cgi?id=179870

Reviewed by Darin Adler.

NetworkProcess/capture/NetworkCaptureLogging.h:
NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::findMatch):
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
These shouldn't have WTF in their name - they have nothing to do with WTF.
These shouldn't use ENABLE(), since they're not features, just debugging macros.

7:48 PM Changeset in webkit [225028] by timothy_horton@apple.com

6 edits in trunk/Source

Fix typos in closing ENABLE() comments
https://bugs.webkit.org/show_bug.cgi?id=179869

Unreviewed.

Source/JavaScriptCore:

wasm/WasmMemory.h:
wasm/WasmMemoryMode.h:

Source/WebCore:

platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:

7:42 PM Changeset in webkit [225027] by mjs@apple.com

11 edits
2 adds
9 deletes in trunk

Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
https://bugs.webkit.org/show_bug.cgi?id=179582

Reviewed by Darin Adler.

Source/WebCore:

Already covered by fast/encoding/legacy-tec-encodings.html

platform/text/TextCodecICU.cpp: Add support for EUC-TW.

Remove all vestiges of TEC text codec and its related autogeneration scripts.

DerivedSources.make:
PlatformMac.cmake:
SourcesMac.txt:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:
platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): No more cached TEC decoder.
(WebCore::ThreadGlobalData::destroy): ditto

platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterTEC): Deleted.

platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps): Don't add TEC decoders on MAc.

platform/text/mac/CharsetData.h: Removed.
platform/text/mac/TextCodecMac.cpp: Removed.
platform/text/mac/TextCodecMac.h: Removed.
platform/text/mac/character-sets.txt: Removed.
platform/text/mac/ios-encodings.txt: Removed.
platform/text/mac/mac-encodings.txt: Removed.
platform/text/mac/make-charset-table.pl: Removed.

LayoutTests:

fast/encoding/legacy-tec-encodings.html: Added. Verify that we

no longer support these encodings.

fast/encoding/legacy-tec-encodings-expected.txt: Added.
platform/mac/fast/encoding/xnextstep-decoding.html: Removed. We no longer support this encoding.
platform/mac/fast/encoding/xnextstep-decoding-expected.txt: Removed.

5:55 PM Changeset in webkit [225026] by Simon Fraser

42 edits in trunk/Source/WebCore

Mechanical cleanup of FE* files
https://bugs.webkit.org/show_bug.cgi?id=179868

Reviewed by Wenson Hsieh.

Remove unused dump() functions.
Make overridden member functions in derived classes private.
Make simple getters inline.

Move common FESpecularLighting and FEDiffuseLighting functions into the
FELighting base class.

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::blendMode const): Deleted.
(WebCore::FEBlend::dump): Deleted.

platform/graphics/filters/FEBlend.h:

(WebCore::FEBlend::blendMode const):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::type const): Deleted.
(WebCore::FEColorMatrix::values const): Deleted.
(WebCore::FEColorMatrix::dump): Deleted.

platform/graphics/filters/FEColorMatrix.h:

(WebCore::FEColorMatrix::type const):
(WebCore::FEColorMatrix::values const):

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::redFunction const): Deleted.
(WebCore::FEComponentTransfer::greenFunction const): Deleted.
(WebCore::FEComponentTransfer::blueFunction const): Deleted.
(WebCore::FEComponentTransfer::alphaFunction const): Deleted.
(WebCore::FEComponentTransfer::dump): Deleted.

platform/graphics/filters/FEComponentTransfer.h:

(WebCore::FEComponentTransfer::redFunction const):
(WebCore::FEComponentTransfer::greenFunction const):
(WebCore::FEComponentTransfer::blueFunction const):
(WebCore::FEComponentTransfer::alphaFunction const):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::operation const): Deleted.
(WebCore::FEComposite::k1 const): Deleted.
(WebCore::FEComposite::k2 const): Deleted.
(WebCore::FEComposite::k3 const): Deleted.
(WebCore::FEComposite::k4 const): Deleted.
(WebCore::FEComposite::dump): Deleted.

platform/graphics/filters/FEComposite.h:

(WebCore::FEComposite::operation const):
(WebCore::FEComposite::k1 const):
(WebCore::FEComposite::k2 const):
(WebCore::FEComposite::k3 const):
(WebCore::FEComposite::k4 const):

platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::kernelSize const): Deleted.
(WebCore::FEConvolveMatrix::kernel const): Deleted.
(WebCore::FEConvolveMatrix::divisor const): Deleted.
(WebCore::FEConvolveMatrix::bias const): Deleted.
(WebCore::FEConvolveMatrix::targetOffset const): Deleted.
(WebCore::FEConvolveMatrix::edgeMode const): Deleted.
(WebCore::FEConvolveMatrix::kernelUnitLength const): Deleted.
(WebCore::FEConvolveMatrix::preserveAlpha const): Deleted.
(WebCore::FEConvolveMatrix::dump): Deleted.

platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::kernelSize const):
(WebCore::FEConvolveMatrix::kernel const):
(WebCore::FEConvolveMatrix::divisor const):
(WebCore::FEConvolveMatrix::bias const):
(WebCore::FEConvolveMatrix::targetOffset const):
(WebCore::FEConvolveMatrix::edgeMode const):
(WebCore::FEConvolveMatrix::kernelUnitLength const):
(WebCore::FEConvolveMatrix::preserveAlpha const):

platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::lightingColor const): Deleted.
(WebCore::FEDiffuseLighting::setLightingColor): Deleted.
(WebCore::FEDiffuseLighting::surfaceScale const): Deleted.
(WebCore::FEDiffuseLighting::setSurfaceScale): Deleted.
(WebCore::FEDiffuseLighting::diffuseConstant const): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthX const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthX): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthY const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthY): Deleted.
(WebCore::FEDiffuseLighting::lightSource const): Deleted.
(WebCore::FEDiffuseLighting::dump): Deleted.

platform/graphics/filters/FEDiffuseLighting.h:

(WebCore::FEDiffuseLighting::diffuseConstant const):

platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::xChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::yChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::scale const): Deleted.
(WebCore::FEDisplacementMap::dump): Deleted.

platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::xChannelSelector const):
(WebCore::FEDisplacementMap::yChannelSelector const):
(WebCore::FEDisplacementMap::scale const):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::dump): Deleted.

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::floodColor const): Deleted.
(WebCore::FEFlood::floodOpacity const): Deleted.
(WebCore::FEFlood::dump): Deleted.

platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::floodColor const):
(WebCore::FEFlood::floodOpacity const):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::stdDeviationX const): Deleted.
(WebCore::FEGaussianBlur::stdDeviationY const): Deleted.
(WebCore::FEGaussianBlur::edgeMode const): Deleted.
(WebCore::FEGaussianBlur::dump): Deleted.

platform/graphics/filters/FEGaussianBlur.h:

(WebCore::FEGaussianBlur::stdDeviationX const):
(WebCore::FEGaussianBlur::stdDeviationY const):
(WebCore::FEGaussianBlur::edgeMode const):

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::setSurfaceScale):
(WebCore::FELighting::setLightingColor):
(WebCore::FELighting::setKernelUnitLengthX):
(WebCore::FELighting::setKernelUnitLengthY):

platform/graphics/filters/FELighting.h:

(WebCore::FELighting::surfaceScale const):
(WebCore::FELighting::lightingColor const):
(WebCore::FELighting::kernelUnitLengthX const):
(WebCore::FELighting::kernelUnitLengthY const):
(WebCore::FELighting::lightSource const):

platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::dump): Deleted.

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::dump): Deleted.

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::dx const): Deleted.
(WebCore::FEOffset::dy const): Deleted.
(WebCore::FEOffset::dump): Deleted.

platform/graphics/filters/FEOffset.h:

(WebCore::FEOffset::dx const):
(WebCore::FEOffset::dy const):

platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::lightingColor const): Deleted.
(WebCore::FESpecularLighting::setLightingColor): Deleted.
(WebCore::FESpecularLighting::surfaceScale const): Deleted.
(WebCore::FESpecularLighting::setSurfaceScale): Deleted.
(WebCore::FESpecularLighting::specularConstant const): Deleted.
(WebCore::FESpecularLighting::specularExponent const): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthX const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthX): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthY const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthY): Deleted.
(WebCore::FESpecularLighting::lightSource const): Deleted.
(WebCore::FESpecularLighting::dump): Deleted.

platform/graphics/filters/FESpecularLighting.h:

(WebCore::FESpecularLighting::specularConstant const):
(WebCore::FESpecularLighting::specularExponent const):

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::dump): Deleted.

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::dump): Deleted.

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::dump): Deleted.

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::dump): Deleted.

platform/graphics/filters/SourceGraphic.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::dump): Deleted.

svg/graphics/filters/SVGFEImage.h:

5:35 PM Changeset in webkit [225025] by Simon Fraser

2 edits in trunk/Source/WebCore

Attempt to fix Windows build failures seen in EWS.

Remove default constructor for ColorComponents, which was ambiguous with the
one that takes 4 values.

platform/graphics/ColorUtilities.h:

4:48 PM Changeset in webkit [225024] by Simon Fraser

3 edits
2 adds in trunk

Line of garbage pixels at the bottom of an feTurbulence sometimes
https://bugs.webkit.org/show_bug.cgi?id=179866

Reviewed by Wenson Hsieh.
Source/WebCore:

The ParallelJobs logic was broken in that the sum of the computed job
heights was one too short sometimes. Fix and clean up the logic.

Test: svg/filters/feTurbulence-parallel-jobs.html

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

svg/filters/feTurbulence-parallel-jobs-expected.html: Added.
svg/filters/feTurbulence-parallel-jobs.html: Added.

2:50 PM Changeset in webkit [225023] by Simon Fraser

16 edits in trunk/Source/WebCore

Use #pragma once in FE* files.

Rubber-stamped by Dan Bates.

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.h:

2:44 PM Changeset in webkit [225022] by Simon Fraser

2 edits in trunk/Source/WebCore

Remove a TimingScope that I left in by mistake.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

2:40 PM Changeset in webkit [225021] by Simon Fraser

3 edits in trunk/Source/WebCore

FETurbulence: round the result according to the spec
https://bugs.webkit.org/show_bug.cgi?id=179865

Reviewed by Zalan Bujtas.

The spec explicitly says that the floating point results are multiplied by 255 then
clamped between 0 and 255, so do this instead of using lroundf().

This is also faster (about 10%).

platform/graphics/ColorUtilities.h:

(WebCore::ColorComponents::ColorComponents):

platform/graphics/filters/FETurbulence.cpp:

(WebCore::toColorComponents):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):

2:06 PM Changeset in webkit [225020] by Simon Fraser

25 edits in trunk

More FETurbulence cleanup
https://bugs.webkit.org/show_bug.cgi?id=179863

Reviewed by Zalan Bujtas.

Source/WebCore:

Hoist computation of initial StitchData up to be done once per filter,
not once per pixel. Passing initial StitchData by value to calculateTurbulenceValueForPoint()
ensures that each pixel gets the initial state.

Also, adjusted baseFrequencyX and baseFrequencyY can be computed just once at the start,
and passed through via PaintingData.

Change enum TurbulenceType to be an enum class (requiring casts in a couple of places)
and undo the capitalization of the values.

Fix spelling of TURBULANCE -> TURBULENCE in test output.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::computeStitching const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
(WebCore::operator<<):

platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData): Deleted.

svg/SVGAnimatedEnumeration.cpp:

(WebCore::enumerationValueForTargetAttribute):

svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
(WebCore::SVGFETurbulenceElement::parseAttribute):

svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<TurbulenceType>::highestEnumValue):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):

LayoutTests:

Fix spelling of TURBULANCE -> TURBULENCE.

platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/ios/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/ios/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:

1:59 PM Changeset in webkit [225019] by commit-queue@webkit.org

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Update the Trash / Clear icon
https://bugs.webkit.org/show_bug.cgi?id=179850

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-18
Reviewed by Matt Baker.

UserInterface/Images/NavigationItemTrash.svg:

Update the icon.

UserInterface/Views/ProbeDetailsSidebarPanel.css:

(.sidebar > .panel.probes > .navigation-bar .item.clear-samples):

UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

UserInterface/Views/ScopeChainDetailsSidebarPanel.css:

(.scope-chain .navigation-bar .item.clear-watch-expressions):

UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel):
Resize to 15x15 and move it down a pixel.

12:37 PM Changeset in webkit [225018] by Simon Fraser

5 edits
2 adds in trunk

feTurbulence with stitchTiles is broken
https://bugs.webkit.org/show_bug.cgi?id=179862

Reviewed by Zalan Bujtas.

Source/WebCore:

The "stitchTiles" logic was broken, and not equivalent to the spec sample code,
because it didn't compute and wrap the bx1 and by1 equivalents separately from
bx0 and by0.

Annotated the code with the equivalent sample code from the spec for ease of
comparison.

Also make some functions const.

Test: svg/filters/feTurbulence-stitchTiles.html

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::checkNoise): Deleted.
(WebCore::FETurbulence::noise2D): Deleted.
(WebCore::FETurbulence::calculateTurbulenceValueForPoint): Deleted.
(WebCore::FETurbulence::fillRegion): Deleted.

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter const):

LayoutTests:

Ref test that masks out an empty area of the filter and compares with a green rectangle.

svg/filters/feTurbulence-stitchTiles-expected.html: Added.
svg/filters/feTurbulence-stitchTiles.html: Added.

9:25 AM Changeset in webkit [225017] by Antti Koivisto

1 edit
2 adds in trunk/LayoutTests

Add test for a multicolumn render tree update issue
https://bugs.webkit.org/show_bug.cgi?id=179860

Reviewed by Zalan Bujtas.

fast/multicol/column-span-range-crash-expected.txt: Added.
fast/multicol/column-span-range-crash.html: Added.

7:17 AM Changeset in webkit [225016] by Jonathan Bedard

5 edits
2 adds in trunk/Tools

webkitpy: Better name-version mapping (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>

Reviewed by David Kilzer.

Mapping version numbers to version names should occur in a central location.
This has a few advantages. First, it makes iterating through versions easier.
Second, it allows for apple_additions to define an additional set of name
mappings. Lastly, it will allow, in a future patch, for us to track version
instead of version name, only mapping version to version name when required.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
mapping version to name.
(PlatformInfo._determine_linux_version): Deleted.
(PlatformInfo._determine_mac_version): Deleted.
(PlatformInfo._determine_win_version): Deleted.

Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):

Scripts/webkitpy/common/version.py:

(Version.contained_in): Add partial version mapping.

Scripts/webkitpy/common/version_name_map.py: Added.

(VersionNameMap): Holds a mapping of version name to version object.
(VersionNameMap.map): Don't re-create VersionNameMap every time.
(VersionNameMap.init): Initialize mapping, use platform to
define the default system platform.
(VersionNameMap._automap_to_major_version): Some operating systems, such
as iOS, have a naming scheme based on their major version and os name.
Automatically generate such mappings.
(VersionNameMap.to_name): Given a version object, platform name and
table, find the closest matching version name.
(VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
if a version string is included in the name.
(VersionNameMap.from_name): Return an os name and version given a version name.

Scripts/webkitpy/common/version_name_map_unittest.py: Added.

(VersionMapTestCase):
(VersionMapTestCase.test_default_system_platform):
(VersionMapTestCase.test_mac_version_by_name):
(VersionMapTestCase.test_ios_version_by_name):
(VersionMapTestCase.test_mac_name_by_version):
(VersionMapTestCase.test_ios_name_by_version):

Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_contained_in):

6:09 AM Changeset in webkit [225015] by Yusuke Suzuki

3 edits in trunk/Source/WTF

[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
https://bugs.webkit.org/show_bug.cgi?id=179859

Reviewed by JF Bastien.

Currently, we know that CPU(HPPA)'s stack direction is upward! But listing
CPU architectures here is not a scalable way.

Instead, we use runtime stack direction test. By doing so, we can handle
such a strange architecture without listing the CPU to Platform.h. This paves
the way to dropping many CPUs in Platform.h by replacing them with CPU(UNKNOWN)[1].

We also fix StackBounds::isGrowingDownward().

[1]: https://bugs.webkit.org/show_bug.cgi?id=179243

wtf/StackBounds.cpp:

(WTF::StackBounds::stackDirection):
(WTF::testStackDirection2):
(WTF::testStackDirection):
(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):

wtf/StackBounds.h:

(WTF::StackBounds::isGrowingDownward const):

3:46 AM Changeset in webkit [225014] by Antti Koivisto

3 edits
2 adds in trunk

Source/WebCore:
REGRESSION (r220646): REGRESSION (r220646): RenderTreePosition::computeNextSibling hits assertion with certain first-letter mutations
https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

Test: fast/css-generated-content/first-letter-update-crash.html

style/RenderTreeUpdaterFirstLetter.cpp:

(WebCore::styleForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):

Tighten these to take RenderBlock.

(WebCore::supportsFirstLetter):

Test exact conditions where first letter renderer is allowed for fast rejection.

(WebCore::RenderTreeUpdater::FirstLetter::update):

If update was called on a block that doesn't support first letter, getFirstLetter could in
some cases return an ancestor of the block and we would end up mutating a first letter renderer
that wasn't current block's descendant. This violates assumptions of the RenderTreeUpdater
and could cause cached render tree position to become invalid.

Fix by ensuring we are always updating first letter for the current block only.

LayoutTests:

REGRESSION (r220646): ASSERTION FAILED: skipAssert

nextSiblingRenderer(node) == m_nextSibling

https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

fast/css-generated-content/first-letter-update-crash-expected.txt: Added.
fast/css-generated-content/first-letter-update-crash.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed