Context Navigation

← Previous Period
Next Period →

Timeline

Jul 5, 2018:

11:43 PM Changeset in webkit [233570] by bshafiei@apple.com

2 edits in branches/safari-606.1.24-branch/Source/WebCore

Cherry-pick r233557. rdar://problem/41870910

REGRESSION(r233496): Crash in WebCore::VideoTrack::clearClient()
https://bugs.webkit.org/show_bug.cgi?id=187377

Reviewed by Simon Fraser.

Clear m_client of an audio track or a video track before removing it from the list
since TrackListBase::m_inbandTracks may hold the last ref to the track.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removeAudioTrack): (WebCore::HTMLMediaElement::removeVideoTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:43 PM Changeset in webkit [233569] by bshafiei@apple.com

3 edits in branches/safari-606.1.24-branch/Source/WebKit

Cherry-pick r233546. rdar://problem/41867306

Upstream hover gesture implementation
https://bugs.webkit.org/show_bug.cgi?id=187366

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView cleanupInteraction]): (-[WKContentView _removeDefaultGestureRecognizers]): (-[WKContentView _addDefaultGestureRecognizers]): (-[WKContentView _hoverGestureRecognizerChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:40 PM Changeset in webkit [233568] by bshafiei@apple.com

7 edits in branches/safari-606.1.24-branch/Source

Versioning.

11:31 PM Changeset in webkit [233567] by bshafiei@apple.com

1 copy in branches/safari-606.1.24-branch

New branch.

11:28 PM Changeset in webkit [233566] by Carlos Garcia Campos

1 edit
1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Remove platform expectations for imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html

Since r233512 we are getting the same results as other ports.

platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt: Removed.

11:12 PM Changeset in webkit [233565] by bshafiei@apple.com

7 edits in tags/Safari-606.1.24/Source

Versioning.

10:57 PM Changeset in webkit [233564] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

MeasurementSet should merge last four segments into two if values are identical.
https://bugs.webkit.org/show_bug.cgi?id=187311

Reviewed by Ryosuke Niwa.

If last four segments has the same value, MeasurmentSet should merge them.

public/v3/models/measurement-set.js: Added the logic to conditionally merge last segments.

(MeasurementSet.prototype.fetchSegmentation):

unit-tests/measurement-set-tests.js: Added a unit test for this change.

10:50 PM Changeset in webkit [233563] by youenn@apple.com

14 edits
2 adds in trunk

REGRESSION (r230843): Flash doesn't work; Produces blue box on page
https://bugs.webkit.org/show_bug.cgi?id=187346
<rdar://problem/41773974>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce clearPagesPluginData used by WebProcess when a plugin policy changes.
Add a new internals API to get the plugin count as navigator.plugin is filtering plugins.

Test: http/tests/plugins/plugin-allow-then-reload.html

plugins/PluginData.h:
plugins/PluginInfoProvider.cpp:

(WebCore::PluginInfoProvider::clearPagesPluginData):

plugins/PluginInfoProvider.h:
testing/Internals.cpp:

(WebCore::Internals::pluginCount):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Reset page plugins when the load client policies are updated.
This will ensure that pages will rebuild their plugin lists based on the new policies.

WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):
(WebKit::WebPluginInfoProvider::clearPluginClientPolicies):

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setBlockAllPlugins):
When not blocked, set the load policy to allow once.

WebKitTestRunner/TestController.h:

LayoutTests:

Skip new test on WK1 since it does not have the ability to block plugins.

http/tests/plugins/plugin-allow-then-reload-expected.txt: Added.
http/tests/plugins/plugin-allow-then-reload.html: Added.
platform/mac-wk1/TestExpectations:

10:48 PM Changeset in webkit [233562] by beidson@apple.com

19 edits
2 adds in trunk

IndexedDB operations in a Page fail after a StorageProcess crash.
<rdar://problem/41626526> and https://bugs.webkit.org/show_bug.cgi?id=187123

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-after-storage-crash.html

When the connection to a StorageProcess goes away, explicitly tell all of the WebPages
in the WebProcess about it.

This puts Documents/Workers in an error mode where requests fail instead of timeout.
It also clears the Page's connection so *new* Documents and Workers will get a fresh
new connection that works.

Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::callResultFunctionLater):
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::createObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::deleteObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::renameObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::clearObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::createIndex):
(WebCore::IDBClient::IDBConnectionToServer::deleteIndex):
(WebCore::IDBClient::IDBConnectionToServer::renameIndex):
(WebCore::IDBClient::IDBConnectionToServer::putOrAdd):
(WebCore::IDBClient::IDBConnectionToServer::getRecord):
(WebCore::IDBClient::IDBConnectionToServer::getAllRecords):
(WebCore::IDBClient::IDBConnectionToServer::getCount):
(WebCore::IDBClient::IDBConnectionToServer::deleteRecord):
(WebCore::IDBClient::IDBConnectionToServer::openCursor):
(WebCore::IDBClient::IDBConnectionToServer::iterateCursor):
(WebCore::IDBClient::IDBConnectionToServer::establishTransaction):
(WebCore::IDBClient::IDBConnectionToServer::commitTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebCore::IDBClient::IDBConnectionToServer::abortTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didFireVersionChangeEvent):
(WebCore::IDBClient::IDBConnectionToServer::confirmDidCloseFromServer):
(WebCore::IDBClient::IDBConnectionToServer::connectionToServerLost):
(WebCore::IDBClient::IDBConnectionToServer::openDBRequestCancelled):
(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionPendingClose):
(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionClosed):
(WebCore::IDBClient::IDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames):

Modules/indexeddb/client/IDBConnectionToServer.h:

Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::serverConnectionLostError):

page/Page.cpp:

(WebCore::Page::setSessionID):
(WebCore::Page::idbConnection):
(WebCore::Page::optionalIDBConnection):
(WebCore::Page::clearIDBConnection):

page/Page.h:

Source/WebKit:

When the connection to a StorageProcess goes away, explicitly tell all of the WebPages
in the WebProcess about it.

This puts Documents/Workers in an error mode where requests fail instead of timeout.
It also clears the Page's connection so *new* Documents and Workers will get a fresh
new connection that works.

UIProcess/API/C/WKContext.cpp:

(WKContextTerminateStorageProcess):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _terminateStorageProcess]):

UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::terminateForTesting):

UIProcess/Storage/StorageProcessProxy.h:

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::terminateStorageProcessForTesting):
(WebKit::WebProcessPool::terminateStorageProcess): Deleted.

UIProcess/WebProcessPool.h:

WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didClose):

WebProcess/Storage/WebToStorageProcessConnection.h:

(WebKit::WebToStorageProcessConnection::existingIDBConnectionToServerForIdentifier):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webToStorageProcessConnectionClosed):

LayoutTests:

storage/indexeddb/modern/opendatabase-after-storage-crash.html: Added.

9:56 PM Changeset in webkit [233561] by Simon Fraser

2 edits in trunk/Source/WebKit

Address two possible causes of missing tiles in iOS Safari, and add logging to gather more data about other possible causes
https://bugs.webkit.org/show_bug.cgi?id=187376
rdar://problem/40941118

Reviewed by Tim Horton.

We have continual reports of users experiencing missing tiles in MobileSafari, where loading a page
shows the tiles at the top, but we don't render new tiles as the user scrolls down. This is consistent
with failing to dispatch visible content rect updates via -[WKWebView _updateVisibleContentRects].

This patch addresses two possible (but unlikely) causes. First, it resets _currentlyAdjustingScrollViewInsetsForKeyboard
after a web process crash. Second, it catches exceptions thrown by [webView _updateVisibleContentRects]
and resets _hasScheduledVisibleRectUpdate.

This patch also adds release logging that fires if over 1s has elapsed between scheduling
a visible content rect update and trying to re-schedule, and logging for all reasons that
-_updateVisibleContentRects returns early.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _addUpdateVisibleContentRectPreCommitHandler]):
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
(-[WKWebView _updateVisibleContentRects]):

8:20 PM Changeset in webkit [233560] by rniwa@webkit.org

8 edits
2 adds in trunk

Youtube video pages crash after a couple of minutes
https://bugs.webkit.org/show_bug.cgi?id=187316

Reviewed by Antti Koivisto.

Source/WebCore:

The crash was caused by HTMLMediaElement::stopWithoutDestroyingMediaPlayer invoking updatePlaybackControlsManager,
which traverses all media players across different documents including the one in the main frame while its iframe
is getting removed (to update the Touch Bar's media control).

Fixed the bug by making this code async in both stopWithoutDestroyingMediaPlayer and ~HTMLMediaElement. To do this,
this patch moves the timer to update the playback controls manager from HTMLMediaElement to Page since scheduling
a timer owned by HTMLMediaElement in its destructor wouldn't work as the timer would get destructed immediately.

Also replaced the call to clientWillPausePlayback by a call to stopSession in stopWithoutDestroyingMediaPlayer
since the former also updates the layout synchronously via updateNowPlayingInfo; the latter function schedules
a timer via scheduleUpdateNowPlayingInfo instead.

Test: media/remove-video-best-media-element-in-main-frame-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call scheduleUpdatePlaybackControlsManager now that timer has been
moved to Page.
(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager): Made this return a RefPtr instead of
a raw pointer while we're at it.
(WebCore::HTMLMediaElement::clearMediaPlayer): Call scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): Ditto. Also invoke stopSession instead of
clientWillPausePlayback on MediaSession since clientWillPausePlayback will synchronously try to update the layout.
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::schedulePlaybackControlsManagerUpdate): Renamed from scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::updatePlaybackControlsManager): Moved to Page::playbackControlsManagerUpdateTimerFired.

html/HTMLMediaElement.h:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::schedulePlaybackControlsManagerUpdate): Added.
(WebCore::Page::playbackControlsManagerUpdateTimerFired): Moved from HTMLMediaElement::updatePlaybackControlsManager.

page/Page.h:
testing/Internals.cpp:

(WebCore::Internals::bestMediaElementForShowingPlaybackControlsManager):

testing/Internals.h:

LayoutTests:

Added a regression test to remove an iframe with a video while there is a main content
which is eligible to be shown in the Touch Bar.

media/remove-video-best-media-element-in-main-frame-crash-expected.txt: Added.
media/remove-video-best-media-element-in-main-frame-crash.html: Added.

7:44 PM Changeset in webkit [233559] by Kocsen Chung

1 copy in tags/Safari-606.1.24.1

Tag Safari-606.1.24.1.

7:39 PM Changeset in webkit [233558] by Kocsen Chung

7 edits in tags/Safari-606.1.24/Source

Versioning.

7:32 PM Changeset in webkit [233557] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r233496): Crash in WebCore::VideoTrack::clearClient()
https://bugs.webkit.org/show_bug.cgi?id=187377

Reviewed by Simon Fraser.

Clear m_client of an audio track or a video track before removing it from the list
since TrackListBase::m_inbandTracks may hold the last ref to the track.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):

6:56 PM Changeset in webkit [233556] by Fujii Hironori

4 edits in trunk

REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius
https://bugs.webkit.org/show_bug.cgi?id=187336

Reviewed by Carlos Garcia Campos.

Source/WebCore:

drawGlyphsShadow has a fast path to draw a shadow without a shadow
layer. Since r233495, it is not used for zero blur-radius shadow.

In Bug 187244, I changed ShadowState::isRequired not to check
blur-radius is zero. This is not a right fix.

This change reverts r233495.

No new tests (Covered by existing tests).

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::ShadowState::isRequired const): Return false if
'blur' is zero.
(WebCore::Cairo::fillRectWithRoundedHole): Use
ShadowState::isVisible instead of ShadowState::isRequired to check
a shadow should be drawn.

LayoutTests:

platform/gtk/TestExpectations: Unmarked fast/text/multiple-text-shadow-overflow-layout-rect.html.

6:35 PM Changeset in webkit [233555] by sbarati@apple.com

3 edits in trunk/LayoutTests

[mac-wk1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=187309

Reviewed by Mark Lam.

Try to make this test less flaky by making percents threshold of freed
objects smaller.

editing/selection/navigation-clears-editor-state-expected.txt:
editing/selection/navigation-clears-editor-state.html:

5:43 PM Changeset in webkit [233554] by youenn@apple.com

4 edits in trunk/LayoutTests

Layout Test http/tests/workers/service/basic-messageport.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182630

Reviewed by Alex Christensen.

Test is flaky due to a race between serviceWorkerClient.postMessage and MessagePort.postMessage.
Both are going through UIProcess but MessagePort events are grabbed asynchronously.
Fixed the test to not expect order between these two message exchange channels.

http/tests/workers/service/basic-messageport-expected.txt:
http/tests/workers/service/resources/basic-messageport.js:

(channel.port1.onmessage):
(then):

platform/mac-wk2/TestExpectations:

5:40 PM Changeset in webkit [233553] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
https://bugs.webkit.org/show_bug.cgi?id=187363
<rdar://problem/41106306>

Patch by Olivia Barnett <obarnett@apple.com> on 2018-07-05
Reviewed by Tim Horton.

Added extra check to prevent keyboard scrolling when the select box is open.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _scrollOffsetForEvent:]):

5:38 PM Changeset in webkit [233552] by timothy@apple.com

44 edits in trunk/Source

Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
https://bugs.webkit.org/show_bug.cgi?id=187369
rdar://problem/41870420

Reviewed by Tim Horton.

Source/WebCore:

Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):

css/MediaQueryEvaluator.cpp:

(WebCore::prefersDarkInterfaceEvaluate):

css/StyleColor.h:
dom/Document.cpp:

(WebCore::Document::useDarkAppearance const):
(WebCore::Document::styleColorOptions const):
(WebCore::Document::useDefaultAppearance const): Deleted.

dom/Document.h:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

page/Page.cpp:

(WebCore::Page::useDarkAppearance const):
(WebCore::Page::defaultAppearance const): Deleted.

page/Page.h:

(WebCore::Page::setUseDarkAppearance):
(WebCore::Page::setDefaultAppearance): Deleted.

platform/Theme.h:
platform/graphics/MediaPlaybackTargetPicker.h:
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker):

platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):

platform/mac/LocalDefaultSystemAppearance.h:
platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):

platform/mac/ThemeMac.h:
platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::paint):

platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker):

platform/mock/MediaPlaybackTargetPickerMock.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::resolveStyleForMarkedText):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor const):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors const):
(WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const):
(WebCore::RenderThemeMac::colorCache const):
(WebCore::RenderThemeMac::systemColor const):
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary):
(WebCore::RenderThemeMac::paintSliderThumb):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

Source/WebKit:

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _effectiveAppearanceIsDark]):
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setUseSystemAppearance:]):
(-[WKWebView effectiveAppearanceDidChange]):
(-[WKWebView _defaultAppearance]): Deleted.

UIProcess/API/mac/WKView.mm:

(-[WKView _effectiveAppearanceIsDark]):
(-[WKView effectiveAppearanceDidChange]):
(-[WKView _setUseSystemAppearance:]):
(-[WKView _defaultAppearance]): Deleted.
(-[WKView _setDefaultAppearance:]): Deleted.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::effectiveAppearanceIsDark):
(WebKit::WebViewImpl::setUseDarkAppearance):
(WebKit::WebViewImpl::useDefaultAppearance): Deleted.
(WebKit::WebViewImpl::setDefaultAppearance): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setUseDarkAppearance):
(WebKit::WebPageProxy::showPlaybackTargetPicker):
(WebKit::WebPageProxy::setDefaultAppearance): Deleted.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::defaultAppearance const): Deleted.

UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]):

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::paintControlForLayerInContext):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_credentialsMessenger):
(WebKit::WebPage::drawRect):
(WebKit::WebPage::setUseDarkAppearance):
(WebKit::WebPage::setDefaultAppearance): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _effectiveAppearanceIsDark]):
(-[WebView _updateDefaultAppearance]):
(-[WebView _defaultAppearance]): Deleted.

5:25 PM Changeset in webkit [233551] by david_fenton@apple.com

2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187372

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

5:19 PM Changeset in webkit [233550] by ddkilzer@apple.com

3 edits in trunk/Source/bmalloc

Build fix (r233547): Disable IsoHeaps when Gigacage is off
<https://webkit.org/b/187160>

bmalloc/PerThread.cpp: Add #if !HAVE_PTHREAD_MACHDEP_H/#endif

around variables only used when that macro is 0. Include what
you use: Cache.h and Heap.h.

bmalloc/PerThread.h: Include <memory> for std::once_flag.

4:24 PM Changeset in webkit [233549] by commit-queue@webkit.org

8 edits
2 deletes in trunk

Unreviewed, rolling out r233539.
https://bugs.webkit.org/show_bug.cgi?id=187368

Changes made for youtube crashes has caused 15 api failures
(Requested by Truitt on #webkit).

Reverted changeset:

"Youtube video pages crash after a couple of minutes"
https://bugs.webkit.org/show_bug.cgi?id=187316
https://trac.webkit.org/changeset/233539

4:17 PM Changeset in webkit [233548] by BJ Burg

2 edits in trunk/Source/WebKit

REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
https://bugs.webkit.org/show_bug.cgi?id=187367
<rdar://problem/41861346>

Reviewed by Timothy Hatcher.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.

4:12 PM Changeset in webkit [233547] by msaboff@apple.com

5 edits
1 add in trunk/Source/bmalloc

Disable IsoHeaps when Gigacage is off
https://bugs.webkit.org/show_bug.cgi?id=187160

Reviewed by Saam Barati.

Updated determineMallocFallbackState to base enabling of Iso Heaps on Gigacage
being enabled. We do this because if Gigacage is disabled, it may be due to lack
of address space.

To work around a compiler issue uncovered by the change above, I added explicit
instantiation of PerThread's static variables. Defined the same explicit
instantiated static variables with export scope in the new file PerThread.cpp
to eliminate separate variables allocations in each linked framework / library.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::determineMallocFallbackState):

bmalloc/PerThread.cpp: Added.
bmalloc/PerThread.h:

3:28 PM Changeset in webkit [233546] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Upstream hover gesture implementation
https://bugs.webkit.org/show_bug.cgi?id=187366

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView _hoverGestureRecognizerChanged:]):

3:20 PM Changeset in webkit [233545] by Chris Dumez

3 edits in trunk/Source/WebCore

Update Element API to use qualifiedName instead of name/localName where applicable
https://bugs.webkit.org/show_bug.cgi?id=187347

Reviewed by Darin Adler.

Update Element API to use qualifiedName instead of name/localName where applicable. Naming
is now consistent with the IDL and the specification:

https://dom.spec.whatwg.org/#element

Our implementation properly deals with qualified names already, even though the parameters
were named localName.

dom/Element.cpp:

(WebCore::Element::getAttribute const):
(WebCore::Element::toggleAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::getAttributeNode):
(WebCore::Element::hasAttribute const):

dom/Element.h:

3:20 PM Changeset in webkit [233544] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit

Fix some -Wdocumentation warnings in WebKit
https://bugs.webkit.org/show_bug.cgi?id=187318

Reviewed by Dan Bernstein.

Fix most of the -Wdocumentation warnings in WebKit. The remaining
ones are slightly mysterious, so we can't turn the warning on yet.

Configurations/BaseTarget.xcconfig:

Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects,
and the doc comments in the deprecated ICU API have some errors.

UIProcess/API/Cocoa/WKUIDelegate.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Adjust comments or parameter names to be consistent with each other.

2:51 PM Changeset in webkit [233543] by Kocsen Chung

7 edits in trunk/Source

Versioning.

2:46 PM Changeset in webkit [233542] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

Unreviewed, rolling out r233417 and r233418.
https://bugs.webkit.org/show_bug.cgi?id=187364

Introduced an occasional crash on Google Drive (Requested by
rniwa on #webkit).

Reverted changesets:

"WTF's internal std::optional implementation should abort() on
bad optional access"
https://bugs.webkit.org/show_bug.cgi?id=186536
https://trac.webkit.org/changeset/233417

"WTF's internal std::optional implementation should abort() on
bad optional access"
https://bugs.webkit.org/show_bug.cgi?id=186536
https://trac.webkit.org/changeset/233418

2:43 PM Changeset in webkit [233541] by Kocsen Chung

4 edits in tags/Safari-606.1.24

Revert r233417. rdar://problem/41863878

2:35 PM Changeset in webkit [233540] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

ProgramExecutable may be collected as we checkSyntax on it
https://bugs.webkit.org/show_bug.cgi?id=187359
<rdar://problem/41832135>

Reviewed by Mark Lam.

The bug was we were passing in a reference to the SourceCode field on ProgramExecutable as
the ProgramExecutable itself may be collected. The fix here is to make a copy
of the field instead of passing in a reference inside of ParserError::toErrorObject.

No new tests here as this was already caught by our iOS JSC testers.

parser/ParserError.h:

(JSC::ParserError::toErrorObject):

2:02 PM Changeset in webkit [233539] by rniwa@webkit.org

9 edits
2 adds in trunk

Youtube video pages crash after a couple of minutes
https://bugs.webkit.org/show_bug.cgi?id=187316

Reviewed by Antti Koivisto.

Source/WebCore:

Test: media/remove-video-best-media-element-in-main-frame-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call scheduleUpdatePlaybackControlsManager now that timer has been
moved to Page.
(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager): Made this return a RefPtr instead of
a raw pointer while we're at it.
(WebCore::HTMLMediaElement::clearMediaPlayer): Call scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): Ditto. Also invoke stopSession instead of
clientWillPausePlayback on MediaSession since clientWillPausePlayback will synchronously try to update the layout.
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::scheduleUpdatePlaybackControlsManager):
(WebCore::HTMLMediaElement::updatePlaybackControlsManager): Moved to Page::schedulePlaybackControlsManagerUpdate.

html/HTMLMediaElement.h:
page/Page.cpp:

(WebCore::Page::schedulePlaybackControlsManagerUpdate): Added.

page/Page.h:
testing/Internals.cpp:

(WebCore::Internals::bestMediaElementForShowingPlaybackControlsManager):

testing/Internals.h:

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

Added a regression test to remove an iframe with a video while there is a main content
which is eligible to be shown in the Touch Bar.

media/remove-video-best-media-element-in-main-frame-crash-expected.txt: Added.
media/remove-video-best-media-element-in-main-frame-crash.html: Added.

1:41 PM Changeset in webkit [233538] by Chris Dumez

2 edits in trunk/Source/WebKit

Regression(r232886): WebsiteDataStore objects may get destroyed on a background thread
https://bugs.webkit.org/show_bug.cgi?id=187356
<rdar://problem/41854555>

Reviewed by Geoffrey Garen.

As of r232886, CallbackAggregators in WebsiteDataStore hold a Ref<> to their WebsiteDataStore. This
is an issue because CallbackAggregator objects can get destroyed on a background thread and may be
the last ones holding a ref to the data store. When this happens, the WebsiteDataStore would get
destroyed on a background store and potentially cause crashes. Note that even if the callback
aggregator would not be the last one to hold a ref to the store, it still would not be safe to deref
the store on the background thread since WebsiteDataStore is not ThreadSafeRefCounted.

To address the issue, this patch updates the CallbackAggregators' destructor to deref their data
store member on the main thread. Note that we could also have WebsiteDataStore subclass
ThreadSafeRefCounted<T, DestructionThread::Main> but the data store technically does not need to
be ThreadSafeRefCounted at the moment.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

1:28 PM Changeset in webkit [233537] by Alan Bujtas

4 edits
2 adds in trunk

Do not assume that hypen's width can be computed using the simplified text measure codepath.
https://bugs.webkit.org/show_bug.cgi?id=187352
<rdar://problem/40821283>

Reviewed by Simon Fraser.

Source/WebCore:

Just because the text content is qualified for simplified text measure, it does not necessarily mean the hyphen is simple enough as well.

Test: fast/text/hyphen-is-complex-crash.html

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):

rendering/SimpleLineLayoutTextFragmentIterator.h:

LayoutTests:

fast/text/hyphen-is-complex-crash-expected.txt: Added.
fast/text/hyphen-is-complex-crash.html: Added.

12:45 PM Changeset in webkit [233536] by mitz@apple.com

2 edits in trunk/Source/WebKit

[macOS] REGRESSION: Development WebContent service has restricted entitlements, rendering it useless for development
https://bugs.webkit.org/show_bug.cgi?id=187355

Reviewed by Anders Carlsson.

Configurations/WebContentService.Development.xcconfig: Set WK_USE_RESTRICTED_ENTITLEMENTS to NO for the Development service.

12:42 PM Changeset in webkit [233535] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Video sometimes flickers when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=187193
<rdar://problem/40153865>

Unreviewed, fix a broken API test.

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory): None should set the category to AVAudioSessionCategoryAmbient,
because it signals that WebKit is not playing audio so we want allow other apps to play.

12:39 PM Changeset in webkit [233534] by pvollan@apple.com

2 edits in trunk/Source/WebCore

Use ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=187334

Reviewed by Alex Christensen.

Use ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) instead of MAC_OS_X_VERSION_MIN_REQUIRED when deciding
to use NSTimer or NSAnimation for scrollbar animation.

No new tests. No change in behavior.

platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation startAnimation]):
(-[WebScrollbarPartAnimation setCurrentProgress:setCurrentProgress:]):

12:28 PM Changeset in webkit [233533] by Wenson Hsieh

2 edits in trunk/LayoutTests

[WK1] editing/spelling/markers.html times out on High Sierra after r233439
https://bugs.webkit.org/show_bug.cgi?id=187351

Reviewed by Tim Horton.

This is currently timing out on High Sierra, because the verifyUnexpectedMarkers portion of the
test fails to actually make use of the override spell checking results. Fix this by passing the
results when calling the function.

editing/spelling/markers.html:

12:11 PM Changeset in webkit [233532] by timothy@apple.com

5 edits in trunk/Source/WebCore

Don't invert text color for selections in light mode.
https://bugs.webkit.org/show_bug.cgi?id=187349
rdar://problem/41297946

Reviewed by Tim Horton.

Fix color caching in RenderTheme so we don't cache a dark mode color
for a light appearance, or vise versa. Use the new color caching
in RenderThemeMac, and clear the color caches in purgeCaches.

Allow supportsSelectionForegroundColors to conditionalize on StyleColor::Options.
Return true only in dark mode.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::activeSelectionBackgroundColor const):
(WebCore::RenderTheme::inactiveSelectionBackgroundColor const):
(WebCore::RenderTheme::activeSelectionForegroundColor const):
(WebCore::RenderTheme::inactiveSelectionForegroundColor const):
(WebCore::RenderTheme::activeListBoxSelectionBackgroundColor const):
(WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderTheme::activeListBoxSelectionForegroundColor const):
(WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor const):
(WebCore::RenderTheme::purgeCaches):
(WebCore::RenderTheme::platformColorsDidChange):
(WebCore::RenderTheme::activeTextSearchHighlightColor const):
(WebCore::RenderTheme::inactiveTextSearchHighlightColor const):

rendering/RenderTheme.h:

(WebCore::RenderTheme::supportsSelectionForegroundColors const):
(WebCore::RenderTheme::supportsListBoxSelectionForegroundColors const):
(WebCore::RenderTheme::colorCache const):
(WebCore::RenderTheme::purgeCaches): Deleted.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::purgeCaches):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors const):
(WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::colorCache const):
(WebCore::RenderThemeMac::systemColor const):

11:36 AM Changeset in webkit [233531] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] Bindings-tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187330

Reviewed by David Kilzer.

BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests): Passed --json-output parameter to run-bindings-tests.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

11:18 AM Changeset in webkit [233530] by Alan Bujtas

2 edits in trunk/Source/WebCore

SimpleLineLayout::FlowContents wastes 54KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186709
<rdar://problem/41173793>

Reviewed by Simon Fraser.

The size of the m_segments vector in SimpleLineLayoutFlowContents is alway pre-computed and don't change after the initial append.

Not testable.

rendering/SimpleLineLayoutFlowContents.h:

10:52 AM Changeset in webkit [233529] by Kocsen Chung

1 copy in tags/Safari-606.1.24

Tag Safari-606.1.24.

10:49 AM Changeset in webkit [233528] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] WebKitPy-Tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187331

Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.

10:25 AM Changeset in webkit [233527] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] WebKitPy-Tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187331

Reviewed by David Kilzer.

BuildSlaveSupport/ews-build/steps.py:

(RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

10:22 AM Changeset in webkit [233526] by Kocsen Chung

7 edits in tags/Safari-605.3.8.1/Source

Versioning.

10:20 AM Changeset in webkit [233525] by n_wang@apple.com

3 edits
2 adds in trunk

AX: setValue on text controls should send out key events
https://bugs.webkit.org/show_bug.cgi?id=186690
<rdar://problem/41169985>

Reviewed by Chris Fleizach.

Source/WebCore:

Use Editor's insertText function when the text control element is being
focused, so that the InputEvent will be dispatched properly.

Test: accessibility/mac/set-value-editable-dispatch-events.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setValue):

LayoutTests:

accessibility/mac/set-value-editable-dispatch-events-expected.txt: Added.
accessibility/mac/set-value-editable-dispatch-events.html: Added.

10:09 AM Changeset in webkit [233524] by Kocsen Chung

1 copy in tags/Safari-605.3.8.1

New tag.

10:07 AM Changeset in webkit [233523] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test svg/animations/animateMotion-additive-2c.svg and svg/animations/animateMotion-additive-2d.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=187345

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-05

platform/mac-wk2/TestExpectations:

9:59 AM Changeset in webkit [233522] by Kocsen Chung

7 edits in branches/safari-605-branch/Source

Versioning.

9:05 AM Changeset in webkit [233521] by Chris Dumez

2 edits in trunk/Source/WebCore

ASSERT(m_dictionaryStack.size() == 1) assertion hit in ~KeyedDecoderCF() when decoding fails
https://bugs.webkit.org/show_bug.cgi?id=187152

Reviewed by Brent Fulgham.

Whenever a call to KeyedDecoderCF::beginArrayElement() succeeds (returns true), it
appends an item to m_dictionaryStack which is expected to get popped later on via
a matching call to KeyedDecoderCF::endArrayElement(). The ASSERT(m_dictionaryStack.size() == 1)
assertion in the destructor protects against a begin / end mismatch.

However, there was a bug in KeyedDecoder::decodeObjects(), which would cause us to return early
after a call to beginArrayElement() when the lambda function call returns false, causing us
not to call the matching endArrayElement() in this case. This patch addresses the issue by
calling endArrayElement() before returning early.

This bug was uncovered by r233309 which slightly changed the ITP encoding / decoding format.
Because empty HashCountedSets are now expected to be encoded as empty array, decoding of old
data fails and we hit the buggy code path.

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeObjects):

8:46 AM Changeset in webkit [233520] by Antti Koivisto

16 edits
2 adds in trunk/Source/WebCore

Move CSSParserContext to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=187342

Reviewed by Zalan Bujtas.

Move it out from CSSParserMode.h and CSSParser.cpp.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
contentextensions/ContentExtensionParser.cpp:
css/PropertySetCSSStyleDeclaration.h:
css/StyleProperties.h:
css/StyleSheetContents.h:
css/parser/CSSDeferredParser.h:
css/parser/CSSParser.cpp:

(WebCore::strictCSSParserContext): Deleted.
(WebCore::CSSParserContext::CSSParserContext): Deleted.
(WebCore::operator==): Deleted.

css/parser/CSSParser.h:
css/parser/CSSParserContext.cpp: Added.

(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

Also add the missing textAutosizingEnabled bit.

css/parser/CSSParserContext.h: Copied from Source/WebCore/css/parser/CSSParserMode.h.

(WebCore::CSSParserContextHash::hash):

Also add the missing bits to the hash function.

(WebCore::isQuirksModeBehavior): Deleted.
(WebCore::isUASheetBehavior): Deleted.
(WebCore::isUnitLessValueParsingEnabledForMode): Deleted.
(WebCore::isCSSViewportParsingEnabledForMode): Deleted.
(WebCore::strictToCSSParserMode): Deleted.
(WebCore::isStrictParserMode): Deleted.

css/parser/CSSParserIdioms.h:
css/parser/CSSParserImpl.h:
css/parser/CSSParserMode.h:

(WebCore::CSSParserContext::completeURL const): Deleted.
(WebCore::operator!=): Deleted.
(WebCore::CSSParserContextHash::hash): Deleted.
(WebCore::CSSParserContextHash::equal): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::constructDeletedValue): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::isDeletedValue): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::emptyValue): Deleted.

css/parser/CSSPropertyParserHelpers.h:
css/parser/CSSSelectorParser.cpp:
css/parser/CSSVariableParser.cpp:

7:56 AM Changeset in webkit [233519] by graouts@webkit.org

6 edits in trunk

[Web Animations] The ready promise should initially be resolved
https://bugs.webkit.org/show_bug.cgi?id=187341
<rdar://problem/41844711>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt:
web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt:

Source/WebCore:

The Web Animations spec mandates that the ready promise is initially resolved.

animation/WebAnimation.cpp:

(WebCore::WebAnimation::WebAnimation):

7:18 AM Changeset in webkit [233518] by commit-queue@webkit.org

4 edits
1 delete in trunk/Source/WebKit

[GTK] Remove soup/DownloadSoupErrors.h
https://bugs.webkit.org/show_bug.cgi?id=187339

This header is not used anymore.

Patch by Rob Buis <rbuis@igalia.com> on 2018-07-05
Reviewed by Frédéric Wang.

NetworkProcess/Downloads/soup/DownloadSoupErrors.h: Removed.
NetworkProcess/soup/NetworkDataTaskSoup.cpp:
PlatformGTK.cmake:

6:43 AM Changeset in webkit [233517] by Philippe Normand

2 edits in trunk/Tools

[Flatpak] Add gst-libav to dependencies
https://bugs.webkit.org/show_bug.cgi?id=187340

Reviewed by Žan Doberšek.

flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git

clones because the FFMPeg git server doesn't support shallow
clones.

5:41 AM Changeset in webkit [233516] by Carlos Garcia Campos

4 edits in trunk/Source/WebDriver

[GTK][WPE] Add --host option to WebDriver process
https://bugs.webkit.org/show_bug.cgi?id=187288

Reviewed by Žan Doberšek.

We currently allow to pass a port number and the server always listens for connections on localhost. We should
allow to optionally pass a host IP address to be able to use WebDriver remotely.

HTTPServer.h:
WebDriverService.cpp:

(WebDriver::printUsageStatement): Update usage to include --host option.
(WebDriver::WebDriverService::run): Parse --host option and pass it to HTTPServer::listen().

soup/HTTPServerSoup.cpp:

(WebDriver::soupServerListen): Helper to call soup_server_listen_local(), soup_server_listen_all() or
soup_server_listen() depending on the given host.
(WebDriver::HTTPServer::listen): Use soupServerListen() helper.

4:42 AM Changeset in webkit [233515] by svillar@igalia.com

3 edits in trunk/Source/WebCore

[WebVR] Fix VRDisplayEvent implementation
https://bugs.webkit.org/show_bug.cgi?id=187337

Reviewed by Žan Doberšek.

VRDisplayEvent implementation had two issues. First there were no attributes storing the
VRDisplay the event refers to. Secondly the VRDisplayEventReason is not mandatory so it
should be handled via an optional.

Modules/webvr/VRDisplayEvent.cpp:

(WebCore::VRDisplayEvent::VRDisplayEvent):
(WebCore::VRDisplayEvent::display const): Deleted.
(WebCore::VRDisplayEvent::reason const): Deleted.

Modules/webvr/VRDisplayEvent.h:

1:07 AM Changeset in webkit [233514] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
https://bugs.webkit.org/show_bug.cgi?id=187322

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-05
Reviewed by Žan Doberšek.

flatpak/flatpakutils.py:

(WebkitFlatpak.init):

12:40 AM Changeset in webkit [233513] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed, rolling out r233511.

Proper fix provided in bug #187322

Reverted changeset:

"Unreviewed. Fixing a call in flatpakutils.py to
PortFactory.get(),"
https://trac.webkit.org/changeset/233511

Jul 4, 2018:

11:54 PM Changeset in webkit [233512] by Carlos Garcia Campos

11 edits
2 adds in trunk

REGRESSION(r233325): [GTK] Broke 40 animations tests
https://bugs.webkit.org/show_bug.cgi?id=187264

Reviewed by Žan Doberšek.

Source/WebCore:

This is because DocumentAnimationScheduler uses DisplayRefreshMonitor, that is only used by GTK port when
accelerated compositing is enabled. Add a GTK display refresh monitor implementation to be used as the default.

PlatformGTK.cmake: Add new file to compilation.
platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor): Create DisplayRefreshMonitorGtk in GTK.

platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp: Added.

(WebCore::DisplayRefreshMonitorGtk::DisplayRefreshMonitorGtk):
(WebCore::DisplayRefreshMonitorGtk::~DisplayRefreshMonitorGtk):
(WebCore::onFrameClockUpdate):
(WebCore::DisplayRefreshMonitorGtk::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorGtk::displayLinkFired):

platform/graphics/gtk/DisplayRefreshMonitorGtk.h: Added.

(WebCore::DisplayRefreshMonitorGtk::create):

Source/WebKit:

Use a different PlatformDisplayID for compositing in the GTK port. This way, when entering AC a window screen
changed is emitted and the GTK default display refresh monitor is destroyed, ensuring the one created by the
threaded compositor is used.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::create): Remove unused WebPage parameter and add PlatformDisplayID.
(WebKit::ThreadedCompositor::ThreadedCompositor): Create the display refresh monitor with the given displayID.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor): Pass the given displayID to the parent constructor.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:

(WebKit::ThreadedDisplayRefreshMonitor::create): Add PlatformDisplayID parameter.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Use compositingDisplayID when
creating the threaded compositor and notify about the window screen change.
(WebKit::ThreadedCoordinatedLayerTreeHost::setIsDiscardable): Use primaryDisplayID when leaving AC and
compositingDisplayID when re-entering.

LayoutTests:

Remove expectations for tests that are passing now.

platform/gtk/TestExpectations:

10:48 PM Changeset in webkit [233511] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
enforcing the passed platform argument to always be lowercase, as is
expected from the PortFactory code.

flatpak/flatpakutils.py:

(WebkitFlatpak.clean_args):

8:50 PM Changeset in webkit [233510] by Antti Koivisto

7 edits
2 adds in trunk

Reparse user stylesheets when _useSystemAppearance changes
https://bugs.webkit.org/show_bug.cgi?id=187312
<rdar://problem/38565834>

Reviewed by Tim Horton.

Source/WebCore:

This setting may affect user stylesheet parsing. Reparse if it changes.

Test: fast/media/use-system-appearance-user-stylesheet-parsing.html

page/Page.cpp:

(WebCore::Page::setUseSystemAppearance):

page/Page.h:

(WebCore::Page::setUseSystemAppearance): Deleted.

testing/Internals.cpp:

(WebCore::Internals::setUseSystemAppearance):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/media/use-system-appearance-user-stylesheet-parsing-expected.txt: Added.
fast/media/use-system-appearance-user-stylesheet-parsing.html: Added.

1:12 PM Changeset in webkit [233509] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

RealtimeIncomingVideoSources: Call stop() directly in the destructor
https://bugs.webkit.org/show_bug.cgi?id=187303

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Youenn Fablet.

Avoiding to call stopProducingData when we are not actually producing data.

This fixes tests that will run once the WPE/GTK PeerConnection implementation is merged.

platform/mediastream/RealtimeIncomingVideoSource.h:

(WebCore::RealtimeIncomingVideoSource::~RealtimeIncomingVideoSource):

1:08 PM Changeset in webkit [233508] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=187304

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Philippe Normand.

We let parsebin build the StreamCollection for us and pass extra metadata through the
TAG_EVENT pushing the collection ourself is not bringing anything but adds extra work in the
MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.

MediaStream layout tests already test that code path.

platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(WebCore::webkitMediaStreamSrcPadProbeCb):

11:45 AM Changeset in webkit [233507] by aboya@igalia.com

3 edits in trunk/LayoutTests

Unreviewed GTK test gardening.
https://bugs.webkit.org/show_bug.cgi?id=187328

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

8:47 AM Changeset in webkit [233506] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/libwebrtc

[libwebrtc] Allow IP mismatch for local connections on localhost
https://bugs.webkit.org/show_bug.cgi?id=187302

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Youenn Fablet.

The rest of the code allows it, but there was an unecessary assert

Source/webrtc/p2p/base/tcpport.cc:

7:17 AM Changeset in webkit [233505] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 60

Added a tag for Safari Technology Preview release 60.

5:54 AM Changeset in webkit [233504] by guijemont@igalia.com

2 edits in trunk/Source/WTF

FunctionTraits: Make cCallArity() constant on 32-bits.
https://bugs.webkit.org/show_bug.cgi?id=187292

Reviewed by Yusuke Suzuki.

On X86, in Source/JavaScriptCore/jit/CCallHelpers.h we have a
static_assert that uses cCallArity(), so it needs to be constant to
avoid a compilation error. This is achieved by changing an ASSERT into
a static_assert.

wtf/FunctionTraits.h:

(WTF::slotsForCCallArgument):

2:49 AM Changeset in webkit [233503] by fred.wang@free.fr

2 edits in trunk/Source/WebCore

[WebIDL] Remove custom bindings for HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=173444

Unreviewed, add missing bugzilla link for FIXME comments.

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-04

dom/Document.cpp:

(WebCore::Document::closeForBindings):
(WebCore::Document::write):
(WebCore::Document::writeln):

2:43 AM Changeset in webkit [233502] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

A WKWebView in a UIViewController that is presented modally and uses a file picker will be incorrectly dismissed by the system
https://bugs.webkit.org/show_bug.cgi?id=185257
<rdar://problem/40819252>

Patch by Olivia Barnett <obarnett@apple.com> on 2018-07-04
Reviewed by Tim Horton.

Call to dismiss the presented modal was being called on the parent and not the child, which caused the file picker to be incorrectly dismissed along with the modal. A test for this bug-fix could not be completed without additional tools as TestWebKitAPI is not a UI application.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _dismissDisplayAnimated:]):

2:06 AM Changeset in webkit [233501] by timothy_horton@apple.com

67 edits in trunk

Introduce PLATFORM(IOSMAC)
https://bugs.webkit.org/show_bug.cgi?id=187315

Reviewed by Dan Bernstein.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/WebCore.xcconfig:
Modules/geolocation/ios/GeolocationPositionIOS.mm:

(WebCore::GeolocationPosition::GeolocationPosition):

page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::platformReleaseMemory):

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::routingContextUID const):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldDisableSleep):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):

platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderRegistrationInfoList itemProvider]):

Source/WebCore/PAL:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
pal/cf/CoreMediaSoftLink.cpp:
pal/cf/CoreMediaSoftLink.h:
pal/spi/mac/AVFoundationSPI.h:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/NetworkService.xcconfig:
Configurations/WebContentService.xcconfig:
Configurations/WebKit.xcconfig:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::sourceApplicationAuditData const):

NetworkProcess/ios/NetworkProcessIOS.mm:
NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::initializeProcessName):
(WebKit::overrideSystemProxies):

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForExternalHostingProcess):

Platform/spi/ios/UIKitSPI.h:
Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::initializeSandbox):

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setApplicationIsDaemon):
(WebKit::enableSandboxStyleFileQuarantine):

Shared/mac/CodeSigning.mm:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webViewPrintFormatter]):

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

UIProcess/_WKWebViewPrintFormatter.mm:
UIProcess/_WKWebViewPrintFormatterInternal.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _didExitStableState]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):
(-[WKContentView setSelectedTextRange:]):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView _updateChangedSelection:]):

UIProcess/ios/WKLegacyPDFView.mm:
UIProcess/ios/WKPDFView.mm:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox):

config.h:

Source/WebKitLegacy/ios:

Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
wtf/FeatureDefines.h:
wtf/Platform.h:

Tools:

TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:58 AM Changeset in webkit [233500] by graouts@webkit.org

7 edits in trunk

[Web Animations] Make WPT test at timing-model/timelines/timelines.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186508
<rdar://problem/41000260>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Record WPT test progressions.

web-platform-tests/web-animations/interfaces/Animation/finished-expected.txt:
web-platform-tests/web-animations/timing-model/timelines/timelines-expected.txt:

Source/WebCore:

The remaining failing assertion in this test assumes that the ready promise for an animation is fired
prior to requestAnimationFrame callbacks being fired in the current event loop such that registering
the requestAnimationFrame() call within the ready promise has its callback fired with the same timeline
time. To ensure that is true, we perform a microtask checkpoint as soon as we're done running pending
tasks, which will resolve the ready promise for any play-pending animations.

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations):

LayoutTests:

We're now passing this test reliably.

TestExpectations:

12:43 AM Changeset in webkit [233499] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

50 failing WebDriver tests after r233417
https://bugs.webkit.org/show_bug.cgi?id=187263

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-07-04
Reviewed by Frédéric Wang.

A std::optional value is used while being std::nullopt. This is because the wrong input source is used when
transitioning keyboard input states.

UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

Jul 3, 2018:

8:45 PM Changeset in webkit [233498] by beidson@apple.com

2 edits in trunk/Tools

WebKit.ResponsivenessTimerCrash sometimes fails.
https://bugs.webkit.org/show_bug.cgi?id=187314

Reviewed by Tim Horton.

Actually unregister observers from objects we're about to destroy before destroying them.

TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:

(-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]):

8:32 PM Changeset in webkit [233497] by youenn@apple.com

7 edits in trunk/Source/WebKit

Remove quarantine for Webex plugin
https://bugs.webkit.org/show_bug.cgi?id=187050
rdar://problem/41478189

Reviewed by Brent Fulgham.

Update the Plugin Info.plist to not do quarantine of downloaded files by default.
Update PluginProcess implementation to reenable quarantine for all plug-ins except cisco webex plug-in.

Platform/spi/mac/QuarantineSPI.h: Add qtn_proc_init.
PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
PluginProcess/PluginProcess.h:
PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::shouldOverrideQuarantine):

Shared/ChildProcess.h:

(WebKit::ChildProcess::shouldOverrideQuarantine):

Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

8:31 PM Changeset in webkit [233496] by rniwa@webkit.org

25 edits
2 adds in trunk

Nullptr crash accessing Document in GenericEventQueue::dispatchOneEvent()
https://bugs.webkit.org/show_bug.cgi?id=187284

Reviewed by Eric Carlson.

Source/WebCore:

The null pointer crash was caused by some GenericEventQueue dispatching an event in a stopped document,
which does not have a valid script execution context because some uses of GenericEventQueue in media code
was not closing the queue upon stopping of all active DOM objects.

Fixed all uses of GenericEventQueue which did not suspend or stop the queue with active DOM objects.
Made SourceBufferList and TrackListBase (along with AudioTrackList, TextTrackList, and VideoTrackList)
inherit from ActiveDOMObject instead of ContextDestructionObserver to do this.

Also fixed a bug that media elements inside a template element (and other cases where the document doesn't
have a browsing context) were scheduling events since this would hit the newly added debug assertion in
GenericEventQueue::dispatchOneEvent.

Test: media/track/video-track-addition-and-frame-removal.html

Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:

(WebCore::WebKitMediaKeySession::suspend): Assert that we never try to suspend when the document has
this object alive since canSuspendForDocumentSuspension always returns false.
(WebCore::WebKitMediaKeySession::resume): Ditto.
(WebCore::WebKitMediaKeySession::stop): Stop the event queue to avoid the crash.

Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer): Don't do any work to update tracks when the active DOM
objects are stopped since this MediaSource and the related media objects are about to be destructed.
(WebCore::MediaSource::suspend): Assert that m_asyncEventQueue is empty as canSuspendForDocumentSuspension
returns false whenever the queue is not empty.
(WebCore::MediaSource::resume): Ditto.

Modules/mediasource/MediaSource.h:
Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::suspend): Ditto.
(WebCore::SourceBuffer::resume): Ditto.
(WebCore::SourceBuffer::stop): Stop the event queue to avoid the crash.

Modules/mediasource/SourceBuffer.h:
Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList): Made this an active DOM object.
(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::canSuspendForDocumentSuspension const): Added. Return false when there are
pending events to match other media code.
(WebCore::SourceBufferList::suspend): Added. Assert that the event queue is empty here.
(WebCore::SourceBufferList::resume): Ditto.
(WebCore::SourceBufferList::stop): Added. Stop the event queue to avoid the crash.
(WebCore::SourceBufferList::activeDOMObjectName const): Added.

Modules/mediasource/SourceBufferList.h:

(WebCore::SourceBufferList): Made this an active DOM object.

Modules/mediasource/SourceBufferList.idl:
dom/Document.h:

(WebCore::Document::hasBrowsingContext const): Added.

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::dispatchOneEvent): Added an assertion to catch when an event is dispatched
inside a stopped document, which is never correct and causes this crash down the line.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal): Exit early when the document doesn't have a browsing context;
e.g. when the media element is inside a template element.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.

html/track/AudioTrackList.cpp:

(AudioTrackList::activeDOMObjectName const): Added.

html/track/AudioTrackList.h:
html/track/AudioTrackList.idl:
html/track/TextTrackList.cpp::

(TextTrackList::activeDOMObjectName const): Added.

html/track/TextTrackList.h:
html/track/TextTrackList.idl:
html/track/TrackListBase.cpp:

(WebCore::TrackListBase): Made this an active DOM object.
(WebCore::TrackListBase::TrackListBase):
(WebCore::TrackListBase::canSuspendForDocumentSuspension const): Added. Return false when there are pending events
to match other media code.
(WebCore::TrackListBase::suspend): Added. Assert that the event queue is empty here.
(WebCore::TrackListBase::resume): Ditto.
(WebCore::TrackListBase::stop): Added. Stop the event queue to avoid the crash.

html/track/TrackListBase.h:
html/track/VideoTrackList.cpp:

(VideoTrackList::activeDOMObjectName const): Added.

html/track/VideoTrackList.h:
html/track/VideoTrackList.idl:

LayoutTests:

Added a regression test which reliably hits the newly added debug assertion.

media/track/video-track-addition-and-frame-removal-expected.txt: Added.
media/track/video-track-addition-and-frame-removal.html: Added.

8:18 PM Changeset in webkit [233495] by Fujii Hironori

4 edits in trunk

[cairo] Doesn't paint box-shadow with zero blur-radius
https://bugs.webkit.org/show_bug.cgi?id=187244

Reviewed by Žan Doberšek.

Source/WebCore:

Cairo::ShadowState::isRequired() returned false if blur-radius is
zero.

No new tests (Covered by existing tests).

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::ShadowState::isRequired const): Do not check blur
is zero.

LayoutTests:

platform/gtk/fast/box-shadow/inset-expected.png: Updated.

8:14 PM Changeset in webkit [233494] by Fujii Hironori

2 edits in trunk/Tools

update-webkitgtk-flatpak fails if running with python2
https://bugs.webkit.org/show_bug.cgi?id=187240

Reviewed by Michael Catanzaro.

urllib.urlretrieve of Python2 sends invalid requests. Use
urllib2.urlopen instead.

flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,

urllib.request.urlopen for Python3.
(FlatpakRepo.repo_file): Copy the content of urlopen result to the
temporary file.

7:33 PM Changeset in webkit [233493] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Add a release assert to diagnose infinite recursions in removeAllEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=187287

Reviewed by Keith Miller.

Assert that we never re-enter removeAllEventListeners per thread.

dom/EventTarget.cpp:

(WebCore::EventTarget::removeAllEventListeners):

platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const):
(WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners):

6:56 PM Changeset in webkit [233492] by youenn@apple.com

4 edits in trunk

Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html
https://bugs.webkit.org/show_bug.cgi?id=187243

Reviewed by Chris Dumez.

Source/WebKit:

In case a caches object has an engine, it uses the engine to get the salt.
In case engine/caches are non persistent, no salt was set for the engine, hence the crashes.
Add an empty salt whenever initializing a non-persistent engine to remove the crash.

Covered by updated expectations for two tests.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::initialize):

LayoutTests:

TestExpectations:

5:24 PM Changeset in webkit [233491] by youenn@apple.com

2 edits in trunk/Source/WebKit

Fix regression introduced in r233335
https://bugs.webkit.org/show_bug.cgi?id=187282

Reviewed by Chris Dumez.

When checking for navigation loads, we need to return whether the request URL matches the service worker URL.
Before this patch, if the request URL was not matching the service worker URL, we were using the origin/referrer
which should only be used for subresource loads.

Covered by imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https.html
being no longer flaky.

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::isValidFetch):

5:11 PM Changeset in webkit [233490] by Chris Dumez

8 edits in trunk

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>

Reviewed by Simon Fraser.

Source/WebCore:

Add internals API to get the identifier of a document and to ask if the document with
a given identifier is still alive. This is helpful to write tests for document leaking
fixes.

testing/Internals.cpp:

(WebCore::Internals::documentIdentifier const):
(WebCore::Internals::isDocumentAlive const):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

Update test to stop relying on internals.numberOfLiveDocuments() and instead rely on the new
internals.documentIdentifier() / internals.isDocumentAlive(documentIdentifier) API in order
to address the flakiness. Relying on the number of live documents to check if a particular
document was destroyed is unreliable and flaky given that WebKit constructs documents for
various reasons.

TestExpectations:
performance-api/performance-observer-no-document-leak-expected.txt:
performance-api/performance-observer-no-document-leak.html:

5:06 PM Changeset in webkit [233489] by Chris Dumez

6 edits
10 adds in trunk

Improve window.event compliance: Should not be set when target is in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=186266

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Re-sync dom/events web-platform-tests from 59d4a411a8e to gain test coverage.

web-platform-tests/dom/events/Event-returnValue-expected.txt:
web-platform-tests/dom/events/Event-returnValue.html:
web-platform-tests/dom/events/event-global-expected.txt: Added.
web-platform-tests/dom/events/event-global-extra.window.js: Added.

(async_test.t.frame.onload.t.step_func_done):

web-platform-tests/dom/events/event-global.html: Added.
web-platform-tests/dom/events/event-global.worker-expected.txt: Added.
web-platform-tests/dom/events/event-global.worker.html: Added.
web-platform-tests/dom/events/event-global.worker.js: Added.
web-platform-tests/dom/events/relatedTarget.window.js: Added.

(test):
(test.t.input.oninput.t.step_func):

web-platform-tests/dom/events/resources/event-global-extra-frame.html: Added.
web-platform-tests/dom/events/resources/w3c-import.log: Added.
web-platform-tests/dom/events/w3c-import.log:

Source/WebCore:

Stop exposing window.event to Shadow DOM by not setting window.event if the event's target
is a Node inside a shadow tree. This is as per the latest DOM specification:

https://github.com/whatwg/dom/pull/407

This aligns our behavior with Blink as well:

https://bugs.chromium.org/p/chromium/issues/detail?id=779461

Tests: imported/w3c/web-platform-tests/dom/events/event-global.html

imported/w3c/web-platform-tests/dom/events/event-global.worker.html

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

5:05 PM Changeset in webkit [233488] by Chris Dumez

4 edits in trunk

Make CallbackMap::invalidate() safe to re-enter
https://bugs.webkit.org/show_bug.cgi?id=187298
<rdar://problem/41057167>

Reviewed by Geoffrey Garen.

Source/WebKit:

Made it safe to re-enter CallbackMap::invalidate(), GenericCallback::performCallbackWithReturnValue(),
GenericCallback::invalidate() & invalidateCallbackMap() since those execute client blocks which may
re-enter WebKit.

UIProcess/GenericCallback.h:

(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::invalidateCallbackMap):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:

(TEST):

4:54 PM Changeset in webkit [233487] by Chris Dumez

10 edits
2 adds in trunk

[Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
https://bugs.webkit.org/show_bug.cgi?id=187270
<rdar://problem/40674034>

Reviewed by Geoffrey Garen.

Source/WebCore:

Disable vnode guard related simulated crashes for WebSQL by setting the expected
environment variable, if not already set by WKTR / DRT.

Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::initialize):
(WebCore::DatabaseManager::platformInitialize):

Modules/webdatabase/DatabaseManager.h:
Modules/webdatabase/cocoa/DatabaseManagerCocoa.mm: Added.

(WebCore::DatabaseManager::paltformInitialize):

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/FileSystem.h:
platform/posix/FileSystemPOSIX.cpp:

(WebCore::FileSystem::realPath):

platform/win/FileSystemWin.cpp:

(WebCore::FileSystem::realPath):

Tools:

Disable vnode guard related simulated crashes for WKTR / DRT by setting the
expected environment variable in the test driver.

Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):

3:57 PM Changeset in webkit [233486] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Re-enabling canvas tests for canvas/philip/tests/initial.reset.gradient.html
https://bugs.webkit.org/show_bug.cgi?id=187307

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-03

platform/mac/TestExpectations:

3:57 PM Changeset in webkit [233485] by eric.carlson@apple.com

5 edits in trunk/Source/WebCore

Don't allow autoplay when the element is suspended
https://bugs.webkit.org/show_bug.cgi?id=187299
<rdar://problem/41044691>

Reviewed by Youenn Fablet.

Block autoplay when a media element is suspended. Add more release logging to the methods
that handle autoplay attempts to help diagnose future media playback problems.

html/HTMLMediaElement.cpp:

(WebCore::convertEnumerationToString): Convert PlaybackWithoutUserGesture to a string.
(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks): Add logging.
(WebCore::HTMLMediaElement::hardwareMutedStateDidChange): Ditto.
(WebCore::HTMLMediaElement::handleAutoplayEvent): Ditto.
(WebCore::HTMLMediaElement::userDidInterfereWithAutoplay): Ditto.
(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture): Ditto.

html/HTMLMediaElement.h:

(WTF::LogArgument<WebCore::HTMLMediaElement::PlaybackWithoutUserGesture>::toString):

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted const): Playback is not permitted when the
element is suspended.

html/MediaElementSession.h:

3:44 PM Changeset in webkit [233484] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Clean up sandbox warnings found during Public Beta
https://bugs.webkit.org/show_bug.cgi?id=187308
<rdar://problem/41203914>

Reviewed by Eric Carlson.

I made our sandbox overly restrictive during our iOS 12.0 development cycle, and have found a number of missing items.

This patch adds the missing IOKit properties, and removes a duplicate call to (play-media).

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:41 PM Changeset in webkit [233483] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

re-enable some canvas tests that are now consistently passing
https://bugs.webkit.org/show_bug.cgi?id=187305

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-03

platform/mac/TestExpectations:

3:28 PM Changeset in webkit [233482] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC] Generate anonymous inline box for text content.
https://bugs.webkit.org/show_bug.cgi?id=187301

Reviewed by Antti Koivisto.

Always have a inline container for text content (and no dedicated text renderer).

layout/layouttree/LayoutInlineBox.cpp:

(WebCore::Layout::InlineBox::InlineBox):

layout/layouttree/LayoutInlineBox.h:

(WebCore::Layout::InlineBox::setContent):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

2:38 PM Changeset in webkit [233481] by Basuke Suzuki

16 edits
1 copy in trunk/Source

[Curl] Embed certificate information into ResourceResponse.
https://bugs.webkit.org/show_bug.cgi?id=187102

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests but tested internally.

Collect certificate information from the communication and put them into
ResourceResponse for the sake of advanced security checking and information
providing to the user.

platform/Curl.cmake:
platform/network/curl/CertificateInfo.cpp: Copied from Source/WebCore/platform/network/curl/CertificateInfo.h.

(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::isolatedCopy const):
(WebCore::CertificateInfo::makeCertificate):

platform/network/curl/CertificateInfo.h:

(WebCore::CertificateInfo::verificationError const):
(WebCore::CertificateInfo::certificateChain const):
(WebCore::operator==):
(WebCore::CertificateInfo::CertificateInfo): Deleted.

platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didCompleteTransfer):

platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::getCertificateInfo const):
(WebCore::CurlRequest::getNetworkLoadMetrics const):
(WebCore::CurlRequest::getNetworkLoadMetrics): Deleted.

platform/network/curl/CurlResourceHandleDelegate.cpp:

(WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
(WebCore::CurlResourceHandleDelegate::curlDidComplete):

platform/network/curl/CurlSSLHandle.cpp:

(WebCore::CurlSSLHandle::setHostAllowsAnyHTTPSCertificate):
(WebCore::CurlSSLHandle::canIgnoredHTTPSCertificate):

platform/network/curl/CurlSSLHandle.h:
platform/network/curl/CurlSSLVerifier.cpp:

(WebCore::CurlSSLVerifier::CurlSSLVerifier):
(WebCore::CurlSSLVerifier::verifyCallback):
(WebCore::StackOfX509::StackOfX509): For RAII. Used in pemDataFromCtx().
(WebCore::StackOfX509::~StackOfX509): Ditto.
(WebCore::StackOfX509::count): Ditto.
(WebCore::StackOfX509::item): Ditto.
(WebCore::BIOHolder::BIOHolder): Ditto.
(WebCore::BIOHolder::~BIOHolder): Ditto.
(WebCore::BIOHolder::write): Ditto.
(WebCore::BIOHolder::asCertificate): Ditto.
(WebCore::pemDataFromCtx): Become simple static function.
(WebCore::convertToSSLCertificateFlags): Ditto.
(WebCore::CurlSSLVerifier::certVerifyCallback): Deleted.
(WebCore::CurlSSLVerifier::getPemDataFromCtx): Deleted.
(WebCore::CurlSSLVerifier::convertToSSLCertificateFlags): Deleted.

platform/network/curl/CurlSSLVerifier.h:

(WebCore::CurlSSLVerifier::verificationError):
(WebCore::CurlSSLVerifier::certificateChain const):

platform/network/curl/ResourceError.h:
platform/network/curl/ResourceErrorCurl.cpp:

(WebCore::ResourceError::isSSLConnectError const):
(WebCore::ResourceError::isSSLCertVerificationError const):
(WebCore::ResourceError::hasSSLConnectError const): Deleted.

platform/network/curl/ResourceResponse.h:
platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::setCertificateInfo):
(WebCore::ResourceResponse::setDeprecatedNetworkLoadMetrics):

Source/WebKit:

NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::curlDidComplete):.

2:04 PM Changeset in webkit [233480] by Simon Fraser

3 edits in trunk/Source/WebKit

[iOS WK2] We fail to make surfaces volatile when suspending, increasing memory impact
https://bugs.webkit.org/show_bug.cgi?id=187285
rdar://problem/41732391

Reviewed by Tim Horton.

The "Mach port as layer contents" code path used in iOS WK2 relies on replacing the
Mach port layer contents with the actual IOSurface on suspension (otherwise the
live Mach port will keep the surface in use). However, we were never hitting this
RemoteLayerTreeHost::mapAllIOSurfaceBackingStore() code path on iOS 11 and later
because UIKit stopped firing the notification we relied on.

To fix this, use the _UIApplicationDidFinishSuspensionSnapshotNotification notification
which is fired on UIApp.

Platform/spi/ios/UIKitSPI.h:
UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

2:04 PM Changeset in webkit [233479] by Simon Fraser

9 edits in trunk/Source

Clean up the layer volatility code and logging
https://bugs.webkit.org/show_bug.cgi?id=187286

Reviewed by Tim Horton.
Source/WebCore:

Export a function.

platform/graphics/cocoa/IOSurface.h:

Source/WebKit:

Fix the layer volatility logging so it doesn't say "succeeded" when it actually failed
and gave up.

Use a couple of lambda functions in RemoteLayerBackingStore::setBufferVolatility() to
make the code easier to read.

Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::setBufferVolatility):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::callVolatilityCompletionHandlers):
(WebKit::WebPage::layerVolatilityTimerFired):
(WebKit::WebPage::markLayersVolatile):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::markLayersVolatile):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):

WebProcess/WebProcess.h:

2:02 PM Changeset in webkit [233478] by eric.carlson@apple.com

2 edits in trunk/Tools

Video sometimes flickers when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=187193
<rdar://problem/40153865>

Unreviewed, fix test broken by r233435.

TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:

(TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session
category because it doesn't necessarily happen synchronously.
(TestWebKitAPI::TEST):

1:53 PM Changeset in webkit [233477] by tsaunier@gnome.org

2 edits in trunk/Tools

Unreviewed, add myself as a WebKit committer.

And canonicalize the file as suggested by check-webkit-style

Scripts/webkitpy/common/config/contributors.json:

1:50 PM Changeset in webkit [233476] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r233112.
https://bugs.webkit.org/show_bug.cgi?id=187300

this revision is causing crashes on iOS 11 simulator
(Requested by Truitt on #webkit).

Reverted changeset:

"[Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit
fullscreen handler after r231924"
https://bugs.webkit.org/show_bug.cgi?id=186945
https://trac.webkit.org/changeset/233112

1:46 PM Changeset in webkit [233475] by Chris Dumez

7 edits in trunk

Implement support for Element.toggleAttribute
https://bugs.webkit.org/show_bug.cgi?id=186883

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Import WPT test coverage from:
https://github.com/web-platform-tests/wpt/commit/c3db018b96681af3c73ec331ecc01d38e48b8b10

web-platform-tests/dom/nodes/attributes-expected.txt:
web-platform-tests/dom/nodes/attributes.html:

Source/WebCore:

Implement support for Element.toggleAttribute as per:

This was already implemented in Blink:

https://bugs.chromium.org/p/chromium/issues/detail?id=854960

Edge expressed public support:

https://github.com/whatwg/dom/issues/461#issuecomment-398206390

Gecko is working on it:

https://bugzilla.mozilla.org/show_bug.cgi?id=1469592

dom/Element.cpp:

(WebCore::Element::toggleAttribute):

dom/Element.h:
dom/Element.idl:

1:44 PM Changeset in webkit [233474] by Basuke Suzuki

2 edits in trunk/Tools

check-webkit-style: Run the tool without SVN client.
https://bugs.webkit.org/show_bug.cgi?id=187294

Reviewed by Daniel Bates.

When invoking check-webkit-style without SVN client, the exception was raised and terminated.
Using Git repository is acceptable workflow according to the wording on:
<https://webkit.org/getting-the-code/#checking-out-with-git>
and using Subversion is considered optional by following link:
<https://webkit.org/webkit-on-windows/#installing-developer-tools>.
This patch makes it so that people with only a Git checkout of WebKit that commit using
the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.in_working_directory):

12:25 PM Changeset in webkit [233473] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

[32-bit JSC tests] ASSERTION FAILED: !getDirect(offset)

!JSValue::encode(getDirect(offset)).

https://bugs.webkit.org/show_bug.cgi?id=187255
<rdar://problem/41785257>

Reviewed by Saam Barati.

The 32-bit JIT::emit_op_create_this() needs to initialize uninitialized properties
too: basically, do what the 64-bit code is doing. At present, this change only
serves to pacify an assertion. It is not needed for correctness because the
concurrent GC is not used on 32-bit builds.

This issue is already covered by the slowMicrobenchmarks/rest-parameter-allocation-elimination.js
test.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_create_this):

12:12 PM Changeset in webkit [233472] by aakash_jain@apple.com

2 edits in trunk/Tools

Remove old JSCTestsFactory

Follow-up fix to r233471.

11:59 AM Changeset in webkit [233471] by aakash_jain@apple.com

5 edits in trunk/Tools

[ews-build] Add support for JSC-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187201

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory): Added JSCTestsFactory.

BuildSlaveSupport/ews-build/steps.py:

(CompileJSCOnly): Command to compile JSC.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.

11:51 AM Changeset in webkit [233470] by Alan Bujtas

1 edit
1 add in trunk/Tools

[LFC] Add test-list file for regression testing
https://bugs.webkit.org/show_bug.cgi?id=187296

Reviewed by Antti Koivisto.

run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt

LayoutReloaded/misc/LFC-passing-tests.txt: Added.

11:29 AM Changeset in webkit [233469] by Alan Bujtas

19 edits in trunk/Source/WebCore

[LFC] Implement minimum/maximum content width logic.
https://bugs.webkit.org/show_bug.cgi?id=187241

Reviewed by Antti Koivisto.

Compute the minimum/maximum content width if needed and cache the values on the formatting state.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const):
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::shrinkToFitWidth): Deleted.

layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::FormattingState):

layout/FormattingState.h:

(WebCore::Layout::FormattingState::setMinimumMaximumContentWidth):
(WebCore::Layout::FormattingState::clearMinimumMaximumContentWidth):
(WebCore::Layout::FormattingState::minimumMaximumContentWidth const):

layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::establishedFormattingState):

layout/LayoutContext.h:
layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::createFormattingState const):
(WebCore::Layout::BlockFormattingContext::minimumMaximumContentWidth const):

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::minimumMaximumContentWidthNeedsChildrenWidth):
(WebCore::Layout::BlockFormattingContext::Geometry::minimumMaximumContentWidth):

layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::BlockFormattingState):

layout/blockformatting/BlockFormattingState.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::createFormattingState const):
(WebCore::Layout::InlineFormattingContext::minimumMaximumContentWidth const):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::InlineFormattingState):

layout/inlineformatting/InlineFormattingState.h:
page/FrameViewLayoutContext.cpp:

11:25 AM Changeset in webkit [233468] by wilander@apple.com

7 edits in trunk

Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
https://bugs.webkit.org/show_bug.cgi?id=187277
<rdar://problem/41745510>

Reviewed by Chris Dumez.

Source/WebKit:

Existing tests use this code. The change is for correctness.

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):

Now receives a WKWebView from its caller and gets the page ID from it.

(-[WKWebsiteDataStore _getAllStorageAccessEntries:]): Deleted.

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getAllStorageAccessEntries):

Now gets a page ID from its caller and gets the right network process
through it.

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::getAllStorageAccessEntries):

10:50 AM Changeset in webkit [233467] by Yusuke Suzuki

11 edits in trunk/Source/JavaScriptCore

[JSC] Move slowDownAndWasteMemory function to JSArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=187290

Reviewed by Saam Barati.

slowDownAndWasteMemory is just overridden by typed arrays. Since they are limited,
we do not need to add this function to MethodTable: just dispatching it in JSArrayBufferView
is fine. And slowDownAndWasteMemory only requires the sizeof(element), which can be
easily calculated from JSType.
This patch removes slowDownAndWasteMemory from MethodTable, and moves it to JSArrayBufferView.

runtime/ClassInfo.h:
runtime/JSArrayBufferView.cpp:

(JSC::elementSize):
(JSC::JSArrayBufferView::slowDownAndWasteMemory):

runtime/JSArrayBufferView.h:
runtime/JSArrayBufferViewInlines.h:

(JSC::JSArrayBufferView::possiblySharedBuffer):

runtime/JSCell.cpp:

(JSC::JSCell::slowDownAndWasteMemory): Deleted.

runtime/JSCell.h:
runtime/JSDataView.cpp:

(JSC::JSDataView::slowDownAndWasteMemory): Deleted.

runtime/JSDataView.h:
runtime/JSGenericTypedArrayView.h:
runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory): Deleted.

9:50 AM Changeset in webkit [233466] by Jonathan Bedard

11 edits in trunk

Unreviewed, rolling out r233461.

Assertions triggered during iOS 11 debug layout and API tests

Reverted changeset:

"[iOS] Add assert to catch improper use of WebCore::Timer in
UI Process"
https://bugs.webkit.org/show_bug.cgi?id=185330
https://trac.webkit.org/changeset/233461

9:20 AM Changeset in webkit [233465] by youenn@apple.com

2 edits in trunk/Source/WebKit

Update com.cmbchina.CMBSecurity.sb to make it functional
https://bugs.webkit.org/show_bug.cgi?id=187278

Reviewed by Brent Fulgham.

Resources/PlugInSandboxProfiles/com.cmbchina.CMBSecurity.sb:

9:15 AM Changeset in webkit [233464] by jer.noble@apple.com

4 edits in trunk/Source

Update Fullscreen anti-phishing alert text
https://bugs.webkit.org/show_bug.cgi?id=187199
<rdar://problem/41162543>

Reviewed by Brent Fulgham.

Source/WebCore:

English.lproj/Localizable.strings:

Source/WebKit:

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _showPhishingAlert]):

8:21 AM Changeset in webkit [233463] by commit-queue@webkit.org

5 edits
134 adds in trunk/LayoutTests

Import WPT infrastructure tests
https://bugs.webkit.org/show_bug.cgi?id=187095

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-03
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/infrastructure/META.yml: Added.
web-platform-tests/infrastructure/README.md: Added.
web-platform-tests/infrastructure/assumptions/META.yml: Added.
web-platform-tests/infrastructure/assumptions/ahem-expected.html: Added.
web-platform-tests/infrastructure/assumptions/ahem-notref.html: Added.
web-platform-tests/infrastructure/assumptions/ahem-ref-expected.html: Added.
web-platform-tests/infrastructure/assumptions/ahem-ref.html: Added.
web-platform-tests/infrastructure/assumptions/ahem.html: Added.
web-platform-tests/infrastructure/assumptions/canvas-background-expected.html: Added.
web-platform-tests/infrastructure/assumptions/canvas-background.html: Added.
web-platform-tests/infrastructure/assumptions/html-elements-expected.txt: Added.
web-platform-tests/infrastructure/assumptions/html-elements.html: Added.
web-platform-tests/infrastructure/assumptions/initial-color-expected.html: Added.
web-platform-tests/infrastructure/assumptions/initial-color.html: Added.
web-platform-tests/infrastructure/assumptions/medium-font-size-expected.html: Added.
web-platform-tests/infrastructure/assumptions/medium-font-size.html: Added.
web-platform-tests/infrastructure/assumptions/min-font-size-expected.html: Added.
web-platform-tests/infrastructure/assumptions/min-font-size.html: Added.
web-platform-tests/infrastructure/assumptions/non-secure-context.any-expected.txt: Added.
web-platform-tests/infrastructure/assumptions/non-secure-context.any.html: Added.
web-platform-tests/infrastructure/assumptions/non-secure-context.any.js: Added.

(test):

web-platform-tests/infrastructure/assumptions/non-secure-context.any.worker-expected.txt: Added.
web-platform-tests/infrastructure/assumptions/non-secure-context.any.worker.html: Added.
web-platform-tests/infrastructure/assumptions/tools/ahem-generate-table.py: Added.

(grouper):
(build_header):
(build_table):

web-platform-tests/infrastructure/assumptions/tools/build.sh: Added.
web-platform-tests/infrastructure/assumptions/tools/w3c-import.log: Added.
web-platform-tests/infrastructure/assumptions/w3c-import.log: Added.
web-platform-tests/infrastructure/browsers/firefox/prefs.html: Added.
web-platform-tests/infrastructure/browsers/firefox/w3c-import.log: Added.
web-platform-tests/infrastructure/expected-fail/failing-test.html: Added.
web-platform-tests/infrastructure/expected-fail/timeout.html: Added.
web-platform-tests/infrastructure/expected-fail/w3c-import.log: Added.
web-platform-tests/infrastructure/metadata/infrastructure/browsers/firefox/dir.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/browsers/firefox/prefs.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/browsers/firefox/w3c-import.log: Added.
web-platform-tests/infrastructure/metadata/infrastructure/expected-fail/failing-test.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/expected-fail/timeout.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/expected-fail/w3c-import.log: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_and_fail.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_cycle_fail.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_match_fail.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_mismatch_fail.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_ref_timeout.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/reftest_timeout.html.ini: Added.
web-platform-tests/infrastructure/metadata/infrastructure/reftest/w3c-import.log: Added.
web-platform-tests/infrastructure/reftest-wait-expected.html: Added.
web-platform-tests/infrastructure/reftest-wait.html: Added.
web-platform-tests/infrastructure/reftest/green-expected.html: Added.
web-platform-tests/infrastructure/reftest/green-ref-expected.html: Added.
web-platform-tests/infrastructure/reftest/green-ref.html: Added.
web-platform-tests/infrastructure/reftest/green.html: Added.
web-platform-tests/infrastructure/reftest/red.html: Added.
web-platform-tests/infrastructure/reftest/reftest.https-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest.https.html: Added.
web-platform-tests/infrastructure/reftest/reftest_and_fail-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_and_fail.html: Added.
web-platform-tests/infrastructure/reftest/reftest_and_fail_0-ref-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_and_fail_0-ref.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_0-ref-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_0-ref.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_1-ref-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_1-ref.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_fail-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_fail.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_fail_0-ref-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_cycle_fail_0-ref.html: Added.
web-platform-tests/infrastructure/reftest/reftest_match-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_match.html: Added.
web-platform-tests/infrastructure/reftest/reftest_match_fail-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_match_fail.html: Added.
web-platform-tests/infrastructure/reftest/reftest_mismatch-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_mismatch.html: Added.
web-platform-tests/infrastructure/reftest/reftest_mismatch_fail-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_mismatch_fail.html: Added.
web-platform-tests/infrastructure/reftest/reftest_or_0-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_or_0.html: Added.
web-platform-tests/infrastructure/reftest/reftest_ref_timeout-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_ref_timeout.html: Added.
web-platform-tests/infrastructure/reftest/reftest_timeout-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_timeout.html: Added.
web-platform-tests/infrastructure/reftest/reftest_wait_0-expected.html: Added.
web-platform-tests/infrastructure/reftest/reftest_wait_0.html: Added.
web-platform-tests/infrastructure/reftest/w3c-import.log: Added.
web-platform-tests/infrastructure/server/order-of-metas.any-expected.txt: Added.
web-platform-tests/infrastructure/server/order-of-metas.any.html: Added.
web-platform-tests/infrastructure/server/order-of-metas.any.js: Added.

(test):

web-platform-tests/infrastructure/server/order-of-metas.any.worker-expected.txt: Added.
web-platform-tests/infrastructure/server/order-of-metas.any.worker.html: Added.
web-platform-tests/infrastructure/server/order-of-metas.window.js: Added.

(test):

web-platform-tests/infrastructure/server/resources/expect-global.js: Added.

(test):

web-platform-tests/infrastructure/server/resources/expect-seen-testharness.js: Added.

(test):

web-platform-tests/infrastructure/server/resources/expect-title-meta.js: Added.

(self.GLOBAL.self.GLOBAL.isWindow):

web-platform-tests/infrastructure/server/resources/w3c-import.log: Added.
web-platform-tests/infrastructure/server/secure-context.https.any-expected.txt: Added.
web-platform-tests/infrastructure/server/secure-context.https.any.html: Added.
web-platform-tests/infrastructure/server/secure-context.https.any.js: Added.

(test):

web-platform-tests/infrastructure/server/secure-context.https.any.worker-expected.txt: Added.
web-platform-tests/infrastructure/server/secure-context.https.any.worker.html: Added.
web-platform-tests/infrastructure/server/title.any-expected.txt: Added.
web-platform-tests/infrastructure/server/title.any.html: Added.
web-platform-tests/infrastructure/server/title.any.js: Added.

(test.t.GLOBAL.isWindow):

web-platform-tests/infrastructure/server/title.any.worker-expected.txt: Added.
web-platform-tests/infrastructure/server/title.any.worker.html: Added.
web-platform-tests/infrastructure/server/w3c-import.log: Added.
web-platform-tests/infrastructure/server/wpt-server-http.sub-expected.txt: Added.
web-platform-tests/infrastructure/server/wpt-server-http.sub.html: Added.
web-platform-tests/infrastructure/server/wpt-server-websocket.sub.html: Added.
web-platform-tests/infrastructure/testdriver/click.html: Added.
web-platform-tests/infrastructure/testdriver/send_keys.html: Added.
web-platform-tests/infrastructure/testdriver/w3c-import.log: Added.
web-platform-tests/infrastructure/w3c-import.log: Added.
web-platform-tests/infrastructure/webdriver/tests/conftest.py: Added.
web-platform-tests/infrastructure/webdriver/tests/test_load_file.py: Added.

(test_load):

web-platform-tests/infrastructure/webdriver/tests/w3c-import.log: Added.

LayoutTests:

TestExpectations: Mark known failures.

8:01 AM Changeset in webkit [233462] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work
https://bugs.webkit.org/show_bug.cgi?id=186129

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-03
Reviewed by Antoine Quint.

Source/WebCore:

When the WebAnimationsCSSIntegration flag is enabled, animating the transform property with
a steps() timing function no longer works. This is because the WebAnimation code wrongly
assumes that the transform property can always be accelerated (for counterexamples, see
GraphicsLayerCA::animationCanBeAccelerated). For consistency with AnimationBase, we make
WebAnimation fallback to non-accelerated mode when RenderBoxModelObject::startAnimation
fails. This addresses the regression previously mentioned.

Test: http/wpt/css/css-animations/start-animation-001.html

animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions): Fallback to
non-accelerated mode if startAnimation failed.

LayoutTests:

Add a test to ensure that accelerated and non-accelerated animations are properly started
when WebAnimationsCSSIntegration is enabled. In particular, consider the case of animated
transform using steps() timing function.

http/wpt/css/css-animations/start-animation-001-expected.html: Added.
http/wpt/css/css-animations/start-animation-001.html: Added.

3:41 AM Changeset in webkit [233461] by ddkilzer@apple.com

10 edits in trunk/Source

[iOS] Add assert to catch improper use of WebCore::Timer in UI Process
<https://webkit.org/b/185330>
<rdar://problem/32816079>

Reviewed by Darin Adler.

Source/WebCore:

platform/RuntimeApplicationChecks.cpp:

(WebCore::s_webKitProcessType): Add. Global to track process
type.
(WebCore::setWebKitProcessType): Implement new function that is
called when initializing Web, Network, and Storage processes.
(WebCore::isInNetworkProcess): Add.
(WebCore::isInStorageProcess): Add.
(WebCore::isInWebProcess): Add.

Check value in s_webKitProcessType to determine which process is currently running.
platform/RuntimeApplicationChecks.h:

(WebCore::isInNetworkProcess): Add.
(WebCore::isInStorageProcess): Add.
(WebCore::isInWebProcess):

Make available for all platforms.

platform/Timer.cpp:

(WebCore::TimerBase::TimerBase): Add assert and os_log_fault.
This catches the unwanted behavior on iOS using isAllowed().
(WebCore::TimerBase::isAllowed): Add implementation.

platform/Timer.h:

(WebCore::TimerBase::isAllowed): Add declaration.

platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::isInWebProcess): Delete. Replace with method in
RuntimeApplicationChecks.cpp.

Source/WebKit:

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::StorageProcess):

WebProcess/WebProcess.cpp:

(WebKit::m_nonVisibleProcessCleanupTimer):

Call setWebKitProcessType() to se the global for the current process.

3:22 AM Changeset in webkit [233460] by fred.wang@free.fr

3 edits
3 adds in trunk

[iOS] Animations with Bézier timing function not suspended on UI process when animation-play-state is set to "paused"
https://bugs.webkit.org/show_bug.cgi?id=170784

Source/WebKit:

Reviewed by Antoine Quint.

In order to pause a running animation, GraphicsLayerCA::pauseCAAnimationOnLayer calls
PlatformCALayer::addAnimationForKey, assuming it will replace the current animation.
This patch fixes PlatformCALayerRemote::addAnimationForKey to ensure this assumption holds.

WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::addAnimationForKey): If the animation was already sent to
the UI process, make sure it is properly updated.

LayoutTests:

Add a reftest to visually check pausing of transform animations.

Reviewed by Antoine Quint.

http/wpt/css/css-animations/set-animation-play-state-to-paused-001-expected.html: Added.
http/wpt/css/css-animations/set-animation-play-state-to-paused-001.html: Added.

1:34 AM Changeset in webkit [233459] by graouts@webkit.org

5 edits
1 add in trunk/LayoutTests/imported

LayoutTests/imported/mozilla:
Unreviewed, rebaselining somes Web Animations test expectations.

css-animations/test_animations-dynamic-changes-expected.txt:
css-animations/test_document-get-animations-expected.txt:
css-animations/test_keyframeeffect-getkeyframes-expected.txt: Added.

LayoutTests/imported/w3c:
Unreviewed, rebaselining a Web Animations test expectation.

web-platform-tests/web-animations/interfaces/Animation/finished-expected.txt:

1:31 AM Changeset in webkit [233458] by graouts@webkit.org

2 edits in trunk/LayoutTests

Crash in WebCore::WebAnimation::timeToNextRequiredTick when running imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
https://bugs.webkit.org/show_bug.cgi?id=187145

Unreviewed. Forgot to remove the expectation change when fixing the bug in r233430.

TestExpectations:

12:05 AM Changeset in webkit [233457] by Michael Catanzaro

3 edits in trunk/Source/ThirdParty

[WPE][GTK] Another memory issue in xdgmime
https://bugs.webkit.org/show_bug.cgi?id=187239

Reviewed by Carlos Garcia Campos.

Sync the end of xdg_mime_get_mime_type_for_file() with _xdg_mime_cache_get_mime_type_for_file()
to avoid a memory issue.

I'm pretty sure this code is never executed by either Chromium or WebKit, but I'm not
comfortable with leaving it broken.

xdgmime/README.webkit:
xdgmime/src/xdgmime.c:

(xdg_mime_get_mime_type_for_file):

Jul 2, 2018:

8:55 PM Changeset in webkit [233456] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

Manifest.reset should clear static map for BugTracker and Bug objects.
https://bugs.webkit.org/show_bug.cgi?id=187186

Reviewed by Ryosuke Niwa

If static maps of BugTracker and Bug objects are not cleared up, updating singleton
of Bug object will fail assertion.

public/v3/models/manifest.js: Clear static map for BugTracker and Bug.

(Manifest.reset):

server-tests/api-manifest-tests.js: Added a unit test for this change.

8:55 PM Changeset in webkit [233455] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

Fix a bug in range bisector that start commit may be counted twice.
https://bugs.webkit.org/show_bug.cgi?id=187205

Reviewed by Darin Adler.

Range bisector counted start commit twice if start commit is the same as end commit.

public/v3/commit-set-range-bisector.js:

(CommitSetRangeBisector.async.commitSetClosestToMiddleOfAllCommits):

unit-tests/commit-set-range-bisector-tests.js: Added a unit test for this change.

6:07 PM Changeset in webkit [233454] by Adrian Perez de Castro

2 edits in trunk

[CMake] Use JOB_POOLS to avoid memory-hungry linker processes running at the same time
https://bugs.webkit.org/show_bug.cgi?id=187254

Reviewed by Michael Catanzaro.

Source/cmake/WebKitCommon.cmake: Set the maximum number of

concurrent link processes using job pools (four for release builds,
two otherwise) to avoid running out of memory during builds.

6:03 PM Changeset in webkit [233453] by Sukolsak Sakshuwong

5 edits in trunk

Regular expressions with ".?" expressions at the start and the end match the entire string
https://bugs.webkit.org/show_bug.cgi?id=119191

Reviewed by Michael Saboff.

Source/JavaScriptCore:

r90962 optimized regular expressions in the form of /.*abc.*/ by looking
for "abc" first and then processing the leading and trailing dot stars
to find the beginning and the end of the match. However, it erroneously
enabled this optimization for regular expressions whose leading or
trailing dots had quantifiers that were not of arbitrary length, e.g.,
/.?abc.*/, /.*abc.?/, /.{0,4}abc.*/, etc. This caused the expression to
match the entire string when it shouldn't. This patch disables the
optimization for those cases.

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

LayoutTests:

fast/regex/dotstar-expected.txt:
fast/regex/script-tests/dotstar.js:

5:51 PM Changeset in webkit [233452] by Antti Koivisto

5 edits in trunk

Tighter limit for canvas memory use on iOS
https://bugs.webkit.org/show_bug.cgi?id=187279
<rdar://problem/38420562>

Reviewed by Simon Fraser.

Source/WebCore:

We allowed 448MB of canvas buffer memory. This is still too much in some cases. Painting a large
canvas may also requires several other temporary canvas sized buffers getting us easily over
the process size limit.

html/HTMLCanvasElement.cpp:

(WebCore::maxActivePixelMemory):

Drop to (ramSize() / 4) which computes to 224MB on 2GB devices.

LayoutTests:

platform/ios-simulator/fast/canvas/canvas-crash-expected.txt:
platform/ios-simulator/fast/canvas/canvas-skia-excessive-size-expected.txt:

5:49 PM Changeset in webkit [233451] by Sukolsak Sakshuwong

7 edits
1 add in trunk

RegExp.exec returns wrong value with a long integer quantifier
https://bugs.webkit.org/show_bug.cgi?id=187042

Reviewed by Saam Barati.

JSTests:

stress/regexp-large-quantifier.js: Added.

(testRegExp):

stress/regress-159744.js:

Source/JavaScriptCore:

Prior to this patch, the Yarr parser checked for integer overflow when
parsing quantifiers in regular expressions by adding one digit at a time
to a number and checking if the result got larger. This is wrong;
The parser would fail to detect overflow when parsing, for example,
10,000,000,003 because (1000000000*10 + 3) % (2^{32) = 1410065411 > 1000000000.}

Another issue was that once it detected overflow, it stopped consuming
the remaining digits. Since it didn't find the closing bracket, it
parsed the quantifier as a normal string instead.

This patch fixes these issues by reading all the digits and checking for
overflow with Checked<unsigned, RecordOverflow>. If it overflows, it
returns the largest possible value (quantifyInfinite in this case). This
matches Chrome [1], Firefox [2], and Edge [3].

[1] https://chromium.googlesource.com/v8/v8.git/+/23222f0a88599dcf302ccf395883944620b70fd5/src/regexp/regexp-parser.cc#1042
[2] https://dxr.mozilla.org/mozilla-central/rev/aea3f3457f1531706923b8d4c595a1f271de83da/js/src/irregexp/RegExpParser.cpp#1310
[3] https://github.com/Microsoft/ChakraCore/blob/fc08987381da141bb686b5d0c71d75da96f9eb8a/lib/Parser/RegexParser.cpp#L1149

yarr/YarrParser.h:

(JSC::Yarr::Parser::consumeNumber):

LayoutTests:

fast/regex/overflow-expected.txt:
fast/regex/script-tests/overflow.js:

5:34 PM Changeset in webkit [233450] by youenn@apple.com

2 edits
1 move in trunk/Source/WebKit

Add sandbox to microdone plugin
https://bugs.webkit.org/show_bug.cgi?id=187149
<rdar://problem/41538057>

Unreviewed.

Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari.sb: Renamed from Source/WebKit/Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari.
WebKit.xcodeproj/project.pbxproj:

5:21 PM Changeset in webkit [233449] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Adjust now-incorrect animated resize logging after r232544
https://bugs.webkit.org/show_bug.cgi?id=187281
<rdar://problem/41645347>

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
_beginAnimatedResizeWithUpdate: and _didCompleteAnimatedResize are
not strictly paired; we could instead track the SPI, but it's a bit
tricky since resizeWithContentHidden has an implicit endAnimatedResize.
Instead, just log if we still have a resizeAnimationView when we're
committing outside of an animated resize, which seems to be the original concern,
and point toward the possibility of unpaired begin/end.
Also fix logging that has the wrong method name.

5:17 PM Changeset in webkit [233448] by Wenson Hsieh

2 edits in trunk/Tools

Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
https://bugs.webkit.org/show_bug.cgi?id=187280

Reviewed by Tim Horton.

Add a missing adoptNS().

TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::TEST):

5:15 PM Changeset in webkit [233447] by mmaxfield@apple.com

10 edits
2 adds in trunk

[Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
https://bugs.webkit.org/show_bug.cgi?id=187228
<rdar://problem/40967280>

Reviewed by Brent Fulgham.

Source/WebCore:

This is due to the local() items in the src: descriptor in the @font-family blocks.

This is because of a behavior difference between CSSFontFaceSource::load() and CSSFontFaceSource::font().
load() is supposed to set the status() to Success iff the font can be used, and then CSSFontFaceSource::font()
is supposed to return the font itself to use. load() works by constructing a dummy FontDescription and
performing a system lookup (to see if the local font really exists). However, this dummy FontDescription
doesn't set the ShouldAllowUserInstalledFonts flag. Then, in CSSFontFaceSource::font(), a similar lookup is
performed, except this one has the original FontDescription (with the correct value of the
ShouldAllowUserInstalledFonts flag set. Therefore, the two functions disagree about the state of the flag.

When the CSSFontFaceSource's status gets set to Success, that means "this is the font face source that
represents the @font-face block" but when CSSFontFaceSource::font() returns nullptr, that means "The font face
source can't be used for some reason" so we then continue searching down the font-family list (and render the
text in Helvetica or whatever comes next).

The solution is simple - just set the ShouldAllowUserInstalledFonts flag correctly in the dummy
FontDescription.

Test: fast/text/user-installed-fonts/local.html

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::allowUserInstalledFonts const):

css/CSSFontFace.h:
css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

Tools:

The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.

WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

fast/text/user-installed-fonts/local-expected.html: Added.
fast/text/user-installed-fonts/local.html: Added.

4:45 PM Changeset in webkit [233446] by rniwa@webkit.org

2 edits
1 copy
1 delete in trunk

Repository fix after r233427 and r233443.
.:

jstests: Removed.

JSTests:

Added back the test which got erroneously deleted in r233443.

stress/instanceof-non-object-prototype.js:

4:17 PM Changeset in webkit [233445] by rniwa@webkit.org

2 edits in trunk/Tools

run-benchmark should include the version number of MotionMark's results
https://bugs.webkit.org/show_bug.cgi?id=187274

Reviewed by Jon Lee.

Append the version number as a part of the suite name.

Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:

4:15 PM Changeset in webkit [233444] by youenn@apple.com

2 edits in trunk/Source/WebKit

Update com.apple.NPSafeInput.sb to make it functional
https://bugs.webkit.org/show_bug.cgi?id=187276

Reviewed by Brent Fulgham.

Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb:

3:54 PM Changeset in webkit [233443] by rniwa@webkit.org

14 edits
1 delete in trunk

Generate event and event target interface types directly instead of via macros
https://bugs.webkit.org/show_bug.cgi?id=187215

Reviewed by Chris Dumez.

Made make_event_factory.pl directly generate EventInterface enum values and toJSNewlyCreated for Event,
and EventTargetInterface enum values and toJS for EventTarget. Removed the code to generate EventFactory::create
since it was never even compiled or used anywhere.

This patch faithfully replicates what the macro used to generate but we should consider always generating either
toJS or toJSNewlyCreated for both interfaces in the future.

No new tests since there should be no observable behavioral changes.

DerivedSources.make: Generate EventTargetFactory.cpp, which is used to generate toJS function for EventTarget.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventCustom.cpp:

(WebCore::toJSNewlyCreated): Deleted. Now generated directly in EventFactory.cpp.

bindings/js/JSEventTargetCustom.cpp:

(WebCore::JSEventTarget::toWrapped): Removed the use of TRY_TO_UNWRAP_WITH_INTERFACE.
(WebCore::toJS): Deleted. Now generated directly in EventFactory.cpp.

bindings/scripts/InFilesCompiler.pm:

(generateInterfacesHeader): Use #pragma once. Generate enum values directly. Added the support for suffixing
each type name with namespace for EventTarget.

dom/Event.h: Removed the declaration of EventInterface enum. It's now directly generated in EventInterfaces.h
dom/EventNames.in: Generate toJSNewlyCreated.
dom/EventTarget.h: Removed the declaration of EventTargetInterface as it's now done in EventTargetInterfaces.h.
dom/EventTargetFactory.in: Generate toJS.
dom/make_event_factory.pl:

(defaultParameters): Added two new options. factoryFunction specifies whether toJS or toJSNewlyCreated is generated,
and useNamespaceAsSuffix specifies whether each entry should be suffixed by the namespace (used by EventTarget).
(generateCode): Added a missing semicolon.
(generateImplementation): Removed the early exit for EventTarget since we now need to generate its toJS function.
Replaced the code to generate EventFactory::create by the one to generate toJS / toJSNewlyCreated.

3:47 PM Changeset in webkit [233442] by Alan Bujtas

2 edits in trunk/Source/WebCore

HTML widget displays blank when playing on page
https://bugs.webkit.org/show_bug.cgi?id=187272
<rdar://problem/39317899>

Reviewed by Simon Fraser.

When a composited layer gains content (in this particular case, going from NoContentsLayer to ContentsLayerForMedia),
we need to size the associated graphics layer accordingly (NoContentsLayer means zero sized graphics layer).

Not testable on iOS.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

3:27 PM Changeset in webkit [233441] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

Refactor InlineTextBox::emphasisMarkExistsAndIsAbove()
<https://webkit.org/b/187204>

Reviewed by Darin Adler.

No new tests since there is no change in behavior.

Refactor emphasisMarkExistsAndIsAbove() to return a
std::optional<bool> instead of returning a bool and taking a
std::optional<bool> argument. The state returned is now:

std::nullopt => emphasis mark doesn't exist or is suppressed.
false => emphasis mark exists and is not suppressed, but is not above.
true => emphasis mark exists and is not suppressed, and is above.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):

Update for refactored method. Remove some redundant checks for TextEmphasisMark::None that already happen in emphasisMarkExistsAndIsAbove().
rendering/InlineTextBox.cpp:

(WebCore::emphasisPositionHasNeitherLeftNorRight): Delete.

Replaced by an OptionSet<TextEmphasisPosition>.

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

Refactor as described above.

(WebCore::InlineTextBox::paintMarkedTextForeground):

Update for refactored method.
rendering/InlineTextBox.h:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

Update for new method signature.

3:20 PM Changeset in webkit [233440] by youenn@apple.com

2 edits in trunk/Source/WebKit

Update com.cfca.npSecEditCtl.MAC.BOC.plugin.sb to make it functional
https://bugs.webkit.org/show_bug.cgi?id=187261

Reviewed by Brent Fulgham.

Resources/PlugInSandboxProfiles/com.cfca.npSecEditCtl.MAC.BOC.plugin.sb:

3:04 PM Changeset in webkit [233439] by Wenson Hsieh

11 edits in trunk

[WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
https://bugs.webkit.org/show_bug.cgi?id=187253

Reviewed by Tim Horton.

Tools:

Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.

DumpRenderTree/TestRunner.cpp:

(setSpellCheckerResultsCallback):

Rename setSpellCheckerTextReplacements to setSpellCheckerResults.

(TestRunner::staticFunctions):
(setSpellCheckerTextReplacementsCallback): Deleted.

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setSpellCheckerResults):
(TestRunner::setSpellCheckerTextReplacements): Deleted.

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setSpellCheckerResults):
(TestRunner::setSpellCheckerTextReplacements): Deleted.

TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:

(-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
(-[LayoutTestTextCheckingResult grammarDetails]):
(-[LayoutTestSpellChecker reset]):
(-[LayoutTestSpellChecker results]):
(-[LayoutTestSpellChecker setResults:]):
(-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):

Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.

(-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):

Tweaked to always call the superclass method. This ensures that we set the orthography and wordCount
outpointers if applicable.

(-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):

Added support for simulating asynchronous spell checking.

(-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
(-[LayoutTestSpellChecker replacements]): Deleted.
(-[LayoutTestSpellChecker setReplacements:]): Deleted.
(-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.

LayoutTests:

In recent builds of macOS Mojave, NSSpellChecker returns both grammar and spelling errors when asked to analyze
the string "I have a issue.". While arguably correct, the change causes this existing layout test to fail due
to one of the calls to verifyUnexpectedMarkers expecting either grammar markers and not spelling markers, or
vice versa.

To fix this, we can leverage the mechanism added in r233412 to simulate different results from the platform
spellchecker, such that the test now exercises all combinations of grammar and spelling corrections observed on
each macOS platform, regardless of the actual platform where the test is being run.

This patch also enhances the capabilities of LayoutTestSpellChecker. See Tools/ChangeLog for more details.

editing/spelling/markers-expected.txt:
editing/spelling/markers.html:
editing/spelling/text-replacement-after-typing-to-word.html:

Adjusted for a renamed TestRunner method.

3:02 PM Changeset in webkit [233438] by beidson@apple.com

3 edits in trunk/Tools

Another unreviewed followup to:
Crash notifying observers of responsiveness state change

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this

test on iOS for other reasons.

2:59 PM Changeset in webkit [233437] by Michael Catanzaro

2 edits
3 adds in trunk/LayoutTests

Unreviewed GTK gardening

platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt: Added.

2:52 PM Changeset in webkit [233436] by Megan Gardner

4 edits in trunk/Source/WebCore

Enable copy paste on iOS apps for Mac
https://bugs.webkit.org/show_bug.cgi?id=187194
<rdar://problem/41451148>

Reviewed by Darin Adler.

Difficult to test this platform.

UIKit doesn't support itemProviders for iOS apps for Mac, so we need to revert to the
older way of setting a dictionary of objects and keys for items. Not everything is
availble in this form, and we haven't cleaned up our itemProvider code yet, so we
need to case some things out for now. Hopefully in the future, this will be implmented
and can just work as expected, but for now, this is the best workaround.

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::readURL):

platform/ios/WebItemProviderPasteboard.h:
platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderRegistrationInfoList itemProvider]):

2:49 PM Changeset in webkit [233435] by eric.carlson@apple.com

9 edits in trunk

Video sometimes flickers when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=187193
<rdar://problem/40153865>

Reviewed by Jer Noble and Youenn Fablet.
Source/WebCore:

No new tests, existing test updated.

Delay 100ms before changing the iOS audio session category because it is an expensive and
potentially disruptive operation, and changing an audio or video element configuration
can result in several quick, ultimately unnecessary, category changes.

platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::clientWillBeginPlayback): Add logging.

platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::PlatformMediaSessionManager): Initialize timer.
(WebCore::PlatformMediaSessionManager::removeSession): Deactivate audio session when there
are no sessions.
(WebCore::PlatformMediaSessionManager::updateSessionStateTimerFired): New, update session now.
(WebCore::PlatformMediaSessionManager::updateSessionState): Add parameter.

platform/audio/PlatformMediaSessionManager.h:

platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState): Defer update if it isn't supposed to happen
immediately.

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory): Drive-by: setting the audio category to nil is a noop,
so don't waste time doing it.
(WebCore::AudioSession::tryToSetActive): Allow other apps to resume playback when we deactivate
the audio session.

platform/Timer.h:

(WebCore::DeferrableOneShotTimer): Add WTF_MAKE_FAST_ALLOCATED so it can be used in a unique_ptr.

LayoutTests:

platform/mac/media/audio-session-category-audio-autoplay.html: Update as audio category

doesn't change immediately.

1:56 PM Changeset in webkit [233434] by Wenson Hsieh

6 edits in trunk/Source/WebCore

Clean up some spellchecking code
https://bugs.webkit.org/show_bug.cgi?id=187238

Reviewed by Tim Horton.

A few minor tweaks to modernize some spellchecking code. No change in behavior.

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired):

editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord):

Use move semantics when passing Ranges to markAllMisspellingsAndBadGrammarInRanges.

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Change this to take RefPtr<Range>&& instead of Range*.

(WebCore::Editor::markMisspellingsAndBadGrammar):

Remove an unnecessary call to RefPtr::get().

editing/Editor.h:
editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::invalidateParagraphRangeValues):
(WebCore::TextCheckingParagraph::checkingStart const):
(WebCore::TextCheckingParagraph::checkingEnd const):
(WebCore::TextCheckingParagraph::checkingLength const):
(WebCore::TextCheckingParagraph::automaticReplacementStart const):
(WebCore::TextCheckingParagraph::automaticReplacementLength const):

Currently, all of these cached range offsets are ints, and use a value of -1 to denote that their values are
missing and must be recomputed. Instead, make these std::optionals and let std::nullopt represent the
missing value.

editing/TextCheckingHelper.h:

1:54 PM Changeset in webkit [233433] by beidson@apple.com

2 edits in trunk/Tools

Unreviewed followup to:
Crash notifying observers of responsiveness state change

TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.

1:52 PM Changeset in webkit [233432] by beidson@apple.com

6 edits
1 add in trunk

Crash notifying observers of responsiveness state change
<rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::callObserverCallback): Copy the container ahead of time.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.

(-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView typeCharacter:]):
(-[TestWKWebView hostWindow]):

1:50 PM Changeset in webkit [233431] by sihui_liu@apple.com

3 edits in trunk/Source/WebKit

Remove InitWebCoreThreadSystemInterface() in WKProcessPool _initWithConfiguration
https://bugs.webkit.org/show_bug.cgi?id=187252

Reviewed by Dan Bernstein.

Clean up after <rdar://problem/15256572>.

UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):

1:46 PM Changeset in webkit [233430] by graouts@webkit.org

2 edits in trunk/Source/WebCore

Reviewed by Dean Jackson.

Ensure we have a resolved time value before trying to use it.

animation/WebAnimation.cpp:

(WebCore::WebAnimation::timeToNextRequiredTick const):

1:45 PM Changeset in webkit [233429] by graouts@webkit.org

2 edits in trunk/Source/WebCore

[Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
https://bugs.webkit.org/show_bug.cgi?id=187139

Reviewed by Dean Jackson.

Ensure we have a resolved time value before trying to use it.

animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):

12:02 PM Changeset in webkit [233428] by Michael Catanzaro

2 edits in trunk/Tools

[WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
https://bugs.webkit.org/show_bug.cgi?id=187218

Reviewed by Philippe Normand.

Using the webkitpy Config module, if the build type is not passed on the command line, we
read it from WebKitBuild/Configuration and respect it.

flatpak/flatpakutils.py:

(WebkitFlatpak.init):
(WebkitFlatpak.clean_args):

11:04 AM Changeset in webkit [233427] by keith_miller@apple.com

3 edits
3 adds in trunk

InstanceOf IC should do generic if the prototype is not an object.
https://bugs.webkit.org/show_bug.cgi?id=187250

Reviewed by Mark Lam.

JSTests:

stress/instanceof-non-object-prototype.js: Added.

(let):
(test):
(i.catch):

Source/JavaScriptCore:

The old code was wrong for two reasons. First, the AccessCase expected that
the prototype value would be non-null. Second, we would end up returning
false instead of throwing an exception.

jit/Repatch.cpp:

(JSC::tryCacheInstanceOf):

10:51 AM Changeset in webkit [233426] by mark.lam@apple.com

5 edits
1 add in trunk

Builtins and host functions should get their own structures.
https://bugs.webkit.org/show_bug.cgi?id=187211
<rdar://problem/41646336>

Reviewed by Saam Barati.

JSTests:

stress/regress-187211.js: Added.

Source/JavaScriptCore:

JSFunctions do lazy reification of properties, but ordinary functions applies
different rules of property reification than builtin and host functions. Hence,
we should give builtins and host functions their own structures.

runtime/JSFunction.cpp:

(JSC::JSFunction::selectStructureForNewFuncExp):
(JSC::JSFunction::create):
(JSC::JSFunction::getOwnPropertySlot):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hostFunctionStructure const):
(JSC::JSGlobalObject::arrowFunctionStructure const):
(JSC::JSGlobalObject::sloppyFunctionStructure const):
(JSC::JSGlobalObject::strictFunctionStructure const):

10:29 AM Changeset in webkit [233425] by youenn@apple.com

6 edits in trunk/Source/WebCore

Reject getUserMedia promise if capture fails
https://bugs.webkit.org/show_bug.cgi?id=187190

Reviewed by Eric Carlson.

In case PendingActivationMediaStream is notified of a change,
Check whether any track failed to capture.
If so, reject the promise.
Add more release logging in error case.

Covered by manual testing.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::PendingActivationMediaStream::~PendingActivationMediaStream):
(WebCore::UserMediaRequest::PendingActivationMediaStream::characteristicsChanged):
(WebCore::UserMediaRequest::mediaStreamIsReady):
(WebCore::UserMediaRequest::mediaStreamDidFail):

Modules/mediastream/UserMediaRequest.h:
platform/mediastream/MediaStreamPrivate.h:
platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::captureFailed):

platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setupCaptureSession):

10:16 AM Changeset in webkit [233424] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] [l10n] Updated Ukrainian translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=187231

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2018-07-02
Rubber-stamped by Michael Catanzaro.

uk.po:

8:27 AM Changeset in webkit [233423] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

REGRESSION(r233381): Double WebResourceLoadStatisticsStore destructor invocation
https://bugs.webkit.org/show_bug.cgi?id=187247

Reviewed by Chris Dumez.

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
Don't call postTask() to dispatch this task, as that keeps a reference
to this WebResourceLoadStatisticsStore object and thus causes problems
when invoked from the destructor in the form of a second destructor
invocation that ends up crashing the process. Blocking nature of this
call should be enough to avoid WebResourceLoadStatisticsStore lifetime
issues.

7:35 AM Changeset in webkit [233422] by pvollan@apple.com

2 edits in trunk/Source/WebKit

Delete display link when closing page or the WebContent process has crashed.
https://bugs.webkit.org/show_bug.cgi?id=186895

Reviewed by Brent Fulgham.

If there is a running display link in the UI process, there is no need to keep it around if the
page is being closed or the WebContent process has crashed.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

4:51 AM Changeset in webkit [233421] by zandobersek@gmail.com

5 edits in trunk/Tools

[WPE] Add touch support to WindowViewBackend
https://bugs.webkit.org/show_bug.cgi?id=187245

Reviewed by Carlos Garcia Campos.

Add touch input support to the WindowViewBackend implementation,
plugging into the Wayland protocol in order to get properly notified
about these events, and then dispatching them against the appropriate
wpe_view_backend object so that WebKit can process them.

wpe/backends/ViewBackend.cpp:

(WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):

wpe/backends/ViewBackend.h:
wpe/backends/WindowViewBackend.cpp:
wpe/backends/WindowViewBackend.h:

4:41 AM Changeset in webkit [233420] by aboya@igalia.com

2 edits in trunk/Source/WTF

[Linux] Fix memory leak in WTF::forEachLine()
https://bugs.webkit.org/show_bug.cgi?id=187174

Reviewed by Žan Doberšek.

wtf/linux/MemoryFootprintLinux.cpp:

(WTF::forEachLine):

4:30 AM Changeset in webkit [233419] by zandobersek@gmail.com

2 edits
2 adds
1 delete in trunk/LayoutTests

Unreviewed WPE gardening.

Adjust or add a few test expectations. Remove a bad text baseline for
one W3C Fetch test, add a proper text baseline for another.

platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/fetch/api/headers: Added.
platform/wpe/imported/w3c/web-platform-tests/fetch/api/headers/header-values-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/fetch/security: Removed.

3:12 AM Changeset in webkit [233418] by fred.wang@free.fr

2 edits in trunk/LayoutTests

WTF's internal std::optional implementation should abort() on bad optional access
https://bugs.webkit.org/show_bug.cgi?id=186536

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-02

12:56 AM Changeset in webkit [233417] by commit-queue@webkit.org

5 edits in trunk

WTF's internal std::optional implementation should abort() on bad optional access
https://bugs.webkit.org/show_bug.cgi?id=186536

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-02
Reviewed by Michael Catanzaro.

Source/WTF:

Currently, some ports built with recent compilers will cause the program to abort when one
tries to access the value of an unset std:optional (i.e. std::nullopt) as specified by C++17.
However, most ports still use WTF's internal std::optional implementation, which does not
verify illegal access. Hence it's not possible for developers working on these ports to
detect issues like bugs #186189, #186535, #186752, #186753, #187139, #187145 or #187243.
WTF's version of std::optional was introduced in bug #164199 but it was not possible to
verify the availability of the value inside constexpr member functions because the assert
might involve asm declarations. This commit introduces a new
RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT macro (a simplified version of RELEASE_ASSERT that can
be used in constexpr context) and uses it in WTF's implementation of std::optional.

wtf/Assertions.h: Define RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT as a version of

RELEASE_ASSERT that can be used in constexpr context (in particular avoids asm declarations).

wtf/Optional.h:

(std::optional::operator ->): Add an assert to ensure the optional value is available.
(std::optional::operator *): Ditto.
(std::optional::value const): Ditto.
(std::optional::value): Ditto.
(std::optional<T::value const): Ditto.

LayoutTests:

TestExpectations: Mark two tests as crashing (bug #187145 and bug #187243).

12:49 AM Changeset in webkit [233416] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
https://bugs.webkit.org/show_bug.cgi?id=186838

This URL constructor expects canonicalized input, so fix the passed URL. I missed
this one some weeks ago since I had an older checkout.

Patch by Rob Buis <rbuis@igalia.com> on 2018-07-02
Reviewed by Michael Catanzaro.

TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Jul 1, 2018:

9:24 PM Changeset in webkit [233415] by Yusuke Suzuki

3 edits in trunk/Source/WTF

[WTF] RandomDevice should be initialized inside std::call_once
https://bugs.webkit.org/show_bug.cgi?id=186017

Reviewed by Darin Adler.

While Linux ports uses mutex-guarded static variables, Mac ports do not.
So we should guard static variables' initialization by using std::call_once.
This patch does it for RandomDevice.

wtf/OSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

wtf/RandomDevice.h: Small fix for OS(FUCHSIA).

7:50 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

7:48 PM WebKitGTK/Gardening/Calendar/2018Logs created by Michael Catanzaro

6:52 PM Changeset in webkit [233414] by Fujii Hironori

4 edits in trunk

[WK2] fast/parser/document-open-in-unload.html makes the following test crash
https://bugs.webkit.org/show_bug.cgi?id=98345
<rdar://problem/12474923>

Reviewed by Ryosuke Niwa.

Source/WebCore:

m_documentLoader can become null in the middle of
FrameLoader::commitProvisionalLoad by stopping the loading.

No new tests (Covered by existing tests).

loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Do null check of m_documentLoader.

LayoutTests:

platform/wk2/TestExpectations: Unskipped fast/parser/document-open-in-unload.html.

6:36 PM Changeset in webkit [233413] by mmaxfield@apple.com

7 edits
2 adds in trunk

[Cocoa] LastResort in the font family list causes emoji with joiners to be rendered as multiple .notdef characters
https://bugs.webkit.org/show_bug.cgi?id=187209
<rdar://problem/40920785>

Reviewed by Darin Adler.

Source/WebCore:

Inside our complex text codepath, we perform our own font fallback, which
includes a function that asks "can this font support this grapheme cluster?"
Because of the mechanics of how fonts work, the implementation of this
function is "Does the font's cmap table support every character of the
cluster?" We were using Font::glyphForCharacter() to determine this; however,
this function maps certain control characters to the zero width space
character (with the intention that these control characters shouldn't be
visible in the fast text codepath). That replacement, however, was causing
us to get false negatives, because Apple Color Emoji doesn't support zero
width space. Therefore, Apple Color Emoji was looking like it didn't support
emoji combining sequences.

The best solution to this would be to get Font::glyphForCharacter() to stop
performing these replacements (see https://bugs.webkit.org/show_bug.cgi?id=187166).
However, that is too risky of a change to be making right now. Instead,
a more localized solution is to implement a version of "Does the font's cmap
table support every character of the cluster" that doesn't perform the
substitutions. This patch does exactly that, and uses a bit vector to cache
the results. In order to not have a giant bit vector, we take the old code
path if we know the substitutions won't affect us (and uses ASSERT()s to
validate this) so the bit vector only holds at maximum 3 words of storage.

Test: fast/text/emoji-with-joiner.html

platform/graphics/Font.cpp:

(WebCore::codePointSupportIndex):
(WebCore::createAndFillGlyphPage):
(WebCore::Font::platformSupportsCodePoint const):
(WebCore::Font::supportsCodePoint const):
(WebCore::Font::canRenderCombiningCharacterSequence const):

platform/graphics/Font.h:
platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformSupportsCodePoint const):

Source/WTF:

wtf/unicode/CharacterNames.h:

LayoutTests:

fast/text/emoji-with-joiner-expected.txt: Added.
fast/text/emoji-with-joiner.html: Added.

5:47 PM Changeset in webkit [233412] by Wenson Hsieh

19 edits
1 move
4 adds
1 delete in trunk

[macOS] Text replacements that end with symbols are expanded immediately
https://bugs.webkit.org/show_bug.cgi?id=187225
<rdar://problem/41112433>

Reviewed by Darin Adler.

Source/WebCore:

In shipping Safari, enabling grammar correction causes text shortcuts that end with symbols or punctuation marks
to immediately trigger when typing; normally, when grammar correction is off, this is only triggered after the
user has additionally inserted a punctuation mark or whitespace character after the replaced text.

This bug happens because enabling grammar checking causes the spell checking range to expand to the range of the
full sentence, so any text checking results that replace an existing range are triggered as long as they end
anywhere in the sentence. In contrast, when grammar checking is disabled, the spell checking range is limited to
the nearest adjacent word, which prevents text replacement from occurring elsewhere in the sentence.

However, after r232530, we now always expand the spell checking range to the extent of the sentence when a word
is typed regardless of whether grammar checking is enabled, which means that the issue described above now
happens everywhere. To fix this recent regression and the existing bug, we:

Augment our spellchecking codepaths to include a new automatic text replacement range, alongside

spellchecking and paragraph ranges.

Let this automatic text replacement range be the range of the adjacent word in the case where the user has

finished typing a word.

When marking and replacing text checking results, consult this new automatic text replacement instead of the

spellchecking range.

This keeps the behavior grammar and sentence retro correction results intact, while limiting the scope in which
text replacement results are applied.

Test: editing/spelling/text-replacement-after-typing-to-word.html

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired):

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markMisspellingsAfterTypingToWord):

Pass in the adjacent word range for the automaticReplacementRange, instead of the spell checking range (which
may be extended to the full range of the sentence).

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Add an automaticReplacementRange argument to markAllMisspellingsAndBadGrammarInRanges, and adjust call sites
to pass in a range (generally the same as the spell checking range, but in the case where a word has been typed,
this is a narrower range).

(WebCore::correctSpellcheckingPreservingTextCheckingParagraph):
(WebCore::Editor::markAndReplaceFor):

When replacing text, only allow text replacement in the automatic replacement range rather than the spell
checking range.

(WebCore::Editor::markMisspellingsAndBadGrammar):

editing/Editor.h:
editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):

Add a new version of this constructor that takes a single Range representing both the spellchecking range and
the automatic text replacement range, for convenience.

(WebCore::SpellCheckRequest::create):

editing/SpellChecker.h:

Add plumbing for the automatic replacement range.

(WebCore::SpellCheckRequest::automaticReplacementRange const):

editing/TextCheckingHelper.cpp:

Add plumbing for the automatic replacement range, and new helpers to locate the range as offsets within the
text checking paragraph range.

(WebCore::TextCheckingParagraph::TextCheckingParagraph):
(WebCore::TextCheckingParagraph::invalidateParagraphRangeValues):
(WebCore::TextCheckingParagraph::automaticReplacementStart const):
(WebCore::TextCheckingParagraph::automaticReplacementLength const):

editing/TextCheckingHelper.h:

Tools:

Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
layout test for an example of its usage.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestRunner.cpp:

(setSpellCheckerTextReplacementsCallback):

Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
maps a string representing an input to the NSSpellChecker to some information describing the spell checking
result that LayoutTestSpellChecker will return.

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.

DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setSpellCheckerLoggingEnabled):
(TestRunner::setSpellCheckerTextReplacements):

These testRunner methods ensure that -[NSSpellChecker sharedSpellChecker] is swizzled to return our mock
LayoutTestSpellChecker instance before calling into it.

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setSpellCheckerTextReplacements):

TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.

Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
(modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.

(existingGlobalLayoutTestSpellChecker):
(ensureGlobalLayoutTestSpellChecker):
(stringForCorrectionResponse):
(nsTextCheckingType):
(-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
(-[LayoutTestTextCheckingResult range]):
(-[LayoutTestTextCheckingResult resultType]):
(-[LayoutTestTextCheckingResult replacementString]):
(-[LayoutTestTextCheckingResult description]):

LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
by the layout test.

(+[LayoutTestSpellChecker installIfNecessary]):
(+[LayoutTestSpellChecker uninstallAndReset]):

Helper methods to begin and end swizzling the shared NSSpellChecker.

(-[LayoutTestSpellChecker reset]):

Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
turning off logging for recorded spellchecking responses).

(-[LayoutTestSpellChecker replacements]):
(-[LayoutTestSpellChecker setReplacements:]):
(-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):

Helper method to take a JSObjectRef supplied by the test runner and transform it into a map of spell checking
string inputs to LayoutTestTextCheckingResults.

(-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):

Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
logic to perform spellchecking.

(-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):

Reimplement the original functionality in DumpRenderTreeSpellChecker to make -recordResponse:… print to stdout
by overriding the method and printing if the -spellCheckerLoggingEnabled property has been set to YES.

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

LayoutTests:

Adds a layout test to check that if a user has configured a text replacement that ends with punctuation, then:

Typing that text replacement won't immediately trigger replacement.
Text replacement is triggered after pressing enter.

editing/spelling/text-replacement-after-typing-to-word-expected.txt: Added.
editing/spelling/text-replacement-after-typing-to-word.html: Added.
platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

4:51 PM Changeset in webkit [233411] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
https://bugs.webkit.org/show_bug.cgi?id=187232

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-01
Reviewed by Michael Catanzaro.

The place where host tmp folder is mounted changed to /run/host/ we
need to take that into account.

Also explicitely close temporary files as relying on garbage collection to
remove them is a bad idea.

Also minor optimization avoiding to compile regex for each backtrace
retrieval.

Scripts/webkitpy/port/linux_get_crash_log.py:

(GDBCrashLogGenerator):
(GDBCrashLogGenerator._get_tmp_file_name):
(GDBCrashLogGenerator._get_trace_from_systemd):

3:38 PM Changeset in webkit [233410] by ddkilzer@apple.com

4 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Fix clang static analyzer warnings: Assigned value is garbage or undefined
<https://webkit.org/b/187233>

Reviewed by Mark Lam.

b3/air/AirEliminateDeadCode.cpp:

(JSC::B3::Air::eliminateDeadCode): Initialize changed.

parser/ParserTokens.h:

(JSC::JSTextPosition::JSTextPosition): Add struct member
initialization. Simplify default constructor.
(JSC::JSTokenLocation::JSTokenData): Move largest struct in the
union to the beginning to make it easy to zero out all fields.
(JSC::JSTokenLocation::JSTokenLocation): Add struct member
initialization. Simplify default constructor. Note that
endOffset was not being initialized previously.
(JSC::JSTextPosition::JSToken): Add struct member initialization
where necessary.

runtime/IntlObject.cpp:

(JSC::MatcherResult): Add struct member initialization.

11:23 AM Changeset in webkit [233409] by Darin Adler

20 edits
1 move
1 add in trunk/Source

[Cocoa] Improve ARC compatibility of more code in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=186973

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

API/JSContext.mm:

(WeakContextRef::WeakContextRef): Deleted.
(WeakContextRef::~WeakContextRef): Deleted.
(WeakContextRef::get): Deleted.
(WeakContextRef::set): Deleted.

API/JSContextInternal.h: Removed unneeded header guards since this is

an Objective-C++ header. Removed unused WeakContextRef class. Removed declaration
of method -[JSContext initWithGlobalContextRef:] and JSContext property wrapperMap
since neither is used outside the class implementation.

API/JSManagedValue.mm:

(-[JSManagedValue initWithValue:]): Use a bridging cast.
(-[JSManagedValue dealloc]): Ditto.
(-[JSManagedValue didAddOwner:]): Ditto.
(-[JSManagedValue didRemoveOwner:]): Ditto.
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots): Ditto.
(JSManagedValueHandleOwner::finalize): Ditto.

API/JSValue.mm:

(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]): Ditto.
(+[JSValue valueWithNewErrorFromMessage:inContext:]): Ditto.
(-[JSValue valueForProperty:]): Ditto.
(-[JSValue setValue:forProperty:]): Ditto.
(-[JSValue deleteProperty:]): Ditto.
(-[JSValue hasProperty:]): Ditto.
(-[JSValue invokeMethod:withArguments:]): Ditto.
(valueToObjectWithoutCopy): Ditto. Also removed unneeded explicit type names.
(valueToArray): Ditto.
(valueToDictionary): Ditto.
(objectToValueWithoutCopy): Ditto.
(objectToValue): Ditto.

API/JSVirtualMachine.mm:

(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]): Ditto.
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]): Ditto.
(-[JSVirtualMachine isOldExternalObject:]): Ditto.
(-[JSVirtualMachine addManagedReference:withOwner:]): Ditto.
(-[JSVirtualMachine removeManagedReference:withOwner:]): Ditto.
(-[JSVirtualMachine contextForGlobalContextRef:]): Ditto.
(-[JSVirtualMachine addContext:forGlobalContextRef:]): Ditto.
(scanExternalObjectGraph): Ditto.
(scanExternalRememberedSet): Ditto.

API/JSWrapperMap.mm:

(makeWrapper): Ditto.
(-[JSObjCClassInfo wrapperForObject:inContext:]): Ditto.
(-[JSWrapperMap objcWrapperForJSValueRef:inContext:]): Ditto.
(tryUnwrapObjcObject): Ditto.

API/ObjCCallbackFunction.mm:

(blockSignatureContainsClass): Ditto.
(objCCallbackFunctionForMethod): Switched from retain to CFRetain, but not
sure we will be keeping this the same way under ARC.
(objCCallbackFunctionForBlock): Use a bridging cast.

API/ObjcRuntimeExtras.h:

(protocolImplementsProtocol): Use a more specific type that includes the
explicit unsafe_unretained for copied protocol lists.
(forEachProtocolImplementingProtocol): Ditto.

inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::convertNSNullToNil): Added to replace the CONVERT_NSNULL_TO_NIL macro.
(Inspector::RemoteInspector::receivedSetupMessage): Use convertNSNullToNil.

inspector/remote/cocoa/RemoteInspectorXPCConnection.mm: Moved the

CFXPCBridge SPI to a header named CFXPCBridgeSPI.h.
(auditTokenHasEntitlement): Deleted. Moved to Entitlements.h/cpp in WTF.
(Inspector::RemoteInspectorXPCConnection::handleEvent): Use WTF::hasEntitlement.
(Inspector::RemoteInspectorXPCConnection::sendMessage): Use a bridging cast.

Source/WebKit:

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::hasEntitlement): Use WTF::hasEntitlement.

Shared/mac/SandboxUtilities.h: Removed connectedProcessHasEntitlement since

we can now use WTF::hasEntitlement instead.

Shared/mac/SandboxUtilities.mm: Ditto.

StorageProcess/ios/StorageProcessIOS.mm:

(WebKit::StorageProcess::parentProcessHasServiceWorkerEntitlement): Use
WTF::hasEntitlement.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement): Ditto.

Source/WTF:

WTF.xcodeproj/project.pbxproj: Added CFXPCBridgeSPI.h, fixed a few

other small problems in the project file, and let Xcode fix a few too.

wtf/cocoa/Entitlements.h: Added hasEntitlement function with overloads

for an audit token and an XPC connection.

wtf/cocoa/Entitlements.mm:

(WTF::hasEntitlement): Added, with overloads for a SecTask, an audit token,
and an XPC connection.
(WTF::processHasEntitlement): Refactored to use the function above.

wtf/spi/cocoa/CFXPCBridgeSPI.h: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed