Timeline
Jul 14, 2018:
- 9:26 PM Changeset in webkit [233840] by
-
- 3 edits in trunk/Source/WebCore
Shrink StyleFillData, StyleStrokeData and StyleMiscData
https://bugs.webkit.org/show_bug.cgi?id=187681
Reviewed by Anders Carlsson.
Shrink these data structures by making more enum classes one byte in size, and
re-ordering. StyleFillData goes from 56 to 48, StyleStrokeData from 80 to 72,
StyleMiscData from 40 to 32 bytes.
- rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleFillData::StyleFillData):
(WebCore::StyleFillData::operator== const):
(WebCore::StyleStrokeData::StyleStrokeData):
(WebCore::StyleStrokeData::operator== const):
(WebCore::StyleStopData::operator== const):
(WebCore::StyleMiscData::StyleMiscData):
- rendering/style/SVGRenderStyleDefs.h:
- 7:13 PM Changeset in webkit [233839] by
-
- 11 edits in trunk/Source/WebCore
Shrink CachedResource and subclasses
https://bugs.webkit.org/show_bug.cgi?id=187546
Reviewed by Daniel Bates.
Shrink CachedResource down from 1384 to 1336 bytes, CachedImage from 1480 to
1424 bytes, and CachedFont a little.
This saves about 23KB on cnn.com.
- loader/ResourceLoaderOptions.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
- loader/cache/CachedResource.h:
- platform/network/CacheValidation.h:
(WebCore::RedirectChainCacheStatus::RedirectChainCacheStatus):
- platform/network/NetworkLoadMetrics.h:
- platform/network/ParsedContentRange.h:
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- 5:29 PM Changeset in webkit [233838] by
-
- 11 edits in trunk/Source/WebCore
Shrink some style-related classes and enums
https://bugs.webkit.org/show_bug.cgi?id=187680
Reviewed by Antti Koivisto.
Make all the enum classes in RenderStyleConstants be one byte big (all have less
than 256 values).
Shrink DocumentRuleSet from 384 to 368 bytes by re-ordering, which also helps shrink
StyleResolver from 1024 to 952 bytes.
Shrink BorderValue by re-ordering (now that the layout of Color has changed) which
shrinks BorderData from 168 to 136 bytes.
Convert a couple of other enums to enum class so that they can have explicit size.
- css/DocumentRuleSets.h:
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::documentElementUserAgentStyle const):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium const):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::cascadedPropertiesForRollback):
(WebCore::StyleResolver::applyProperty):
(WebCore::cascadeLevelForIndex):
- css/StyleResolver.h:
- rendering/style/BorderValue.h:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyleConstants.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForElement):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::overrideComputedStyle):
- 4:44 PM Changeset in webkit [233837] by
-
- 14 edits in trunk/Source
Ensure WebKit stack is ad-hoc signed
https://bugs.webkit.org/show_bug.cgi?id=187667
Patch by Kocsen Chung <Kocsen Chung> on 2018-07-14
Reviewed by Alexey Proskuryakov.
- Configurations/Base.xcconfig:
- 9:59 AM Changeset in webkit [233836] by
-
- 2 edits in trunk/Source/WTF
Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h>
<https://webkit.org/b/187672>
Reviewed by Frédéric Wang.
- wtf/Optional.h:
(std::optional::operator -> const):
(std::optional::operator * const):
(std::optional<T::operator-> const):
(std::optional<T::operator* const):
- Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro with ASSERT_UNDER_CONSTEXPR_CONTEXT macro and return statement.
- 2:19 AM Changeset in webkit [233835] by
-
- 7 edits12 adds in trunk
[css-masking] Fully support -webkit-clip-path on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=185829
Reviewed by Simon Fraser.
Source/WebCore:
-webkit-clip-path contributes to SVG elements with boxes, shapes and now with
element references to <clipPath> elements as well. Make sure that all types
contribute to hit-testing of the SVG element as well as they should.
Tests: svg/clip-path/webkit-clip-path-after-expected.svg
svg/clip-path/webkit-clip-path-after.svg
svg/clip-path/webkit-clip-path-before-expected.svg
svg/clip-path/webkit-clip-path-before.svg
svg/dynamic-updates/SVGClipPath-prefixed-influences-hitTesting.html
svg/dynamic-updates/SVGClipPath-prefixed-path-influences-hitTesting.html
svg/dynamic-updates/SVGClipPathElement-prefixed-css-transform-influences-hitTesting.html
svg/dynamic-updates/SVGClipPathElement-prefixed-transform-influences-hitTesting.html
- rendering/svg/SVGRenderSupport.cpp: Share code as much as possible.
(WebCore::clipPathReferenceBox):
(WebCore::isPointInCSSClippingArea): Take -webkit-clip-path into account.
(WebCore::SVGRenderSupport::clipContextToCSSClippingArea):
(WebCore::SVGRenderSupport::pointInClippingArea):
- rendering/svg/SVGRenderSupport.h:
- rendering/svg/SVGRenderingContext.cpp: Clip to -webkit-clip-path boxes, shapes and references.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGResources.cpp: Add -webkit-clip-path references to cached resources. Mimic SVG clip-path.
(WebCore::SVGResources::buildCachedResources):
LayoutTests:
Test -webkit-clip-path element references on SVG elements. Make sure, -webkit-clip-path
contributes to hit testing for element references and basic shapes.
- svg/clip-path/webkit-clip-path-after-expected.svg: Added.
- svg/clip-path/webkit-clip-path-after.svg: Added.
- svg/clip-path/webkit-clip-path-before-expected.svg: Added.
- svg/clip-path/webkit-clip-path-before.svg: Added.
- svg/dynamic-updates/SVGClipPath-prefixed-influences-hitTesting-expected.txt: Added.
- svg/dynamic-updates/SVGClipPath-prefixed-influences-hitTesting.html: Added.
- svg/dynamic-updates/SVGClipPath-prefixed-path-influences-hitTesting-expected.txt: Added.
- svg/dynamic-updates/SVGClipPath-prefixed-path-influences-hitTesting.html: Added.
- svg/dynamic-updates/SVGClipPathElement-prefixed-css-transform-influences-hitTesting-expected.txt: Added.
- svg/dynamic-updates/SVGClipPathElement-prefixed-css-transform-influences-hitTesting.html: Added.
- svg/dynamic-updates/SVGClipPathElement-prefixed-transform-influences-hitTesting-expected.txt: Added.
- svg/dynamic-updates/SVGClipPathElement-prefixed-transform-influences-hitTesting.html: Added.
Jul 13, 2018:
- 11:48 PM Changeset in webkit [233834] by
-
- 3 edits in trunk/Tools
[WinCairo] run-api-tests is timing out for almost all test cases
https://bugs.webkit.org/show_bug.cgi?id=187547
Reviewed by Fujii Hironori.
- Scripts/webkitpy/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
- Scripts/webkitpy/port/server_process_unittest.py:
(TestServerProcess.test_read_after_process_exits):
Add test case.
- 7:15 PM Changeset in webkit [233833] by
-
- 3 edits in trunk/Source/WebCore
Avoid fetching visitedDependentColor() so many times in editing code
https://bugs.webkit.org/show_bug.cgi?id=187676
Reviewed by Zalan Bujtas.
editingAttributedStringFromRange called style.visitedDependentColor() twice for each property,
and fontAttributesForSelectionStart() called it two or three times. Use a local Color variable
to avoid so many calls. Also replace a call to alpha() with isVisible() which makes the usage more clear.
No behavior change.
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::fontAttributesForSelectionStart const):
- editing/cocoa/HTMLConverter.mm:
(WebCore::editingAttributedStringFromRange):
- 6:53 PM Changeset in webkit [233832] by
-
- 13 edits10 copies30 adds in trunk
Add TestExpectations and baselines for iOS 12
https://bugs.webkit.org/show_bug.cgi?id=187628
Reviewed by Alexey Proskuryakov.
Tools:
- Scripts/webkitpy/port/ios.py:
(IOSPort): Bump current version to 12.
LayoutTests:
- platform/ios-12/TestExpectations: Added.
- 6:16 PM Changeset in webkit [233831] by
-
- 172 edits171 copies74 adds in trunk
Add TestExpectations and baselines for Mojave.
https://bugs.webkit.org/show_bug.cgi?id=187620
Reviewed by Alexey Proskuryakov.
Tools:
- Scripts/webkitpy/port/mac.py:
(MacPort): Bump current version to 10.14.
LayoutTests:
- platform/mac/TestExpectations:
- 6:07 PM Changeset in webkit [233830] by
-
- 5 edits4 adds in trunk/LayoutTests
Flesh out WebSocket cookie tests to cover cookie policy for third-party resources
https://bugs.webkit.org/show_bug.cgi?id=187541
<rdar://problem/42048729>
Reviewed by Alex Christensen.
- http/tests/cookies/resources/cookie-utilities.js:
Added a function for setting a cookie in a WebSocket handshake.
- http/tests/websocket/tests/hybi/cookie_wsh.py:
(web_socket_do_extra_handshake):
Now sets the root path for new cookies so that they can be seen by
for example cookies/resources/echo-cookies.php.
- http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party-expected.txt: Added.
- http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html: Added.
- http/tests/websocket/tests/hybi/websocket-blocked-from-setting-cookie-as-third-party-expected.txt: Added.
- http/tests/websocket/tests/hybi/websocket-blocked-from-setting-cookie-as-third-party.html: Added.
- http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior-expected.txt:
- http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html:
Now tests under the condition where localhost as third-party is
allowed to set a new cookie as third party. It also makes sure to use
cookies with the path set to the root so that all cookies are visible.
- 5:04 PM Changeset in webkit [233829] by
-
- 10 edits3 adds1 delete in trunk
Support connecting a MediaStreamAudioDestinationNode to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=187627
<rdar://problem/35334400>
Reviewed by Jer Noble.
Source/WebCore:
When MediaStreamAudioSource is called to read new audio samples,
convert these samples to a WebAudioBufferList and call RealtimeMediaSource::audioSamplesAvailable.
This makes its observers to get the audio data.
Test: webrtc/peer-connection-createMediaStreamDestination.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create): Minor refactoring.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::createMediaStream):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSource.cpp:
(WebCore::MediaStreamAudioSource::MediaStreamAudioSource):
(WebCore::MediaStreamAudioSource::consumeAudio):
- Modules/webaudio/MediaStreamAudioSource.h:
- Modules/webaudio/MediaStreamAudioSourceCocoa.cpp: Added.
(WebCore::streamDescription):
(WebCore::MediaStreamAudioSource::consumeAudio):
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/AudioDestinationConsumer.h: Removed.
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::create):
- platform/mediastream/MediaStreamPrivate.h:
LayoutTests:
- webrtc/peer-connection-createMediaStreamDestination-expected.txt: Added.
- webrtc/peer-connection-createMediaStreamDestination.html: Added.
- 5:03 PM Changeset in webkit [233828] by
-
- 9 edits in trunk
Add _drawsBackground to WKWebViewConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=187665
rdar://problem/42182268
Reviewed by Tim Horton.
Source/WebKit:
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const): Copy m_drawsBackground, and some missing values.
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::drawsBackground const): Added.
(API::PageConfiguration::setDrawsBackground): Added.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Transfer _drawsBackground to page config.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]): Set _drawsBackground to YES.
(-[WKWebViewConfiguration encodeWithCoder:]): Encode _drawsBackground.
(-[WKWebViewConfiguration initWithCoder:]): Decode _drawsBackground.
(-[WKWebViewConfiguration copyWithZone:]): Copy _drawsBackground.
(-[WKWebViewConfiguration _drawsBackground]): Added.
(-[WKWebViewConfiguration _setDrawsBackground:]): Added.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/WebPageProxy.cpp: Set m_drawsBackground based on configuration.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
(TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
- 4:20 PM Changeset in webkit [233827] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Enable WebGL when Accelerated Compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=187664
Reviewed by Fujii Hironori.
AC was disabled for WinCairo in r233725 but it can still run WebGL without AC.
- html/HTMLCanvasElement.cpp:
- 4:15 PM Changeset in webkit [233826] by
-
- 7 edits in tags/Safari-606.1.25.1/Source
Versioning.
- 4:11 PM Changeset in webkit [233825] by
-
- 1 copy in tags/Safari-606.1.25.1
New tag.
- 4:11 PM Changeset in webkit [233824] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r195723): Improve support for resources with '\r' and '\r\n' line endings
https://bugs.webkit.org/show_bug.cgi?id=186453
<rdar://problem/39689180>
Reviewed by Joseph Pecoraro.
Now that the frontend no longer uses offsets from the original source
file to calculate positions within CodeMirror, it is possible to support
resources with '\r' and '\r\n' line endings in the editor.
- UserInterface/Views/CodeMirrorEditor.js:
(WI.CodeMirrorEditor.create):
(WI.CodeMirrorEditor):
- 3:54 PM Changeset in webkit [233823] by
-
- 3 edits in trunk/Source/WebCore
Crash under ApplicationCacheGroup::didFailLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187661
<rdar://problem/42179755>
Reviewed by Youenn Fablet.
If ApplicationCacheResourceLoader::create() fails synchronously with
ApplicationCacheResourceLoader::Error::CannotCreateResource error, then
m_entryLoader will be null when didFailLoadingEntry() is called. However,
didFailLoadingEntry() fails to null check m_entryLoader before using it.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFailLoadingEntry):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
- loader/appcache/ApplicationCacheGroup.h:
- 3:35 PM Changeset in webkit [233822] by
-
- 10 edits in trunk/Source/WebKit
WebKit sometimes holds WiFi/BT assertions while the Networking process is suspended
https://bugs.webkit.org/show_bug.cgi?id=187662
<rdar://problem/41999448>
Reviewed by Chris Dumez.
Inform WiFiAssertions when the Networking process is first going into the background,
so it has a chance of dropping its assertions even in cases where the system
suspends the process before we receive prepareToSuspend.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processDidTransitionToForeground):
(WebKit::NetworkProcess::processDidTransitionToBackground):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformProcessDidTransitionToForeground):
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformProcessDidTransitionToForeground):
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendProcessDidTransitionToForeground):
(WebKit::NetworkProcessProxy::sendProcessDidTransitionToBackground):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::updateProcessAssertions):
Plumb the foreground/background transition to NetworkProcess.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformPrepareToSuspend):
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
(WebKit::NetworkProcess::platformProcessDidTransitionToForeground):
Make use of SuspensionReason to explain to WiFiAssertions the
difference between prepareToSuspend and didTransitionToBackground,
so that it can adjust the timing of dropping the assertion.
- 3:33 PM Changeset in webkit [233821] by
-
- 2 edits in trunk/Source/WebCore
Add release assertion to check thread in TimerBase::setNextFireTime
https://bugs.webkit.org/show_bug.cgi?id=187666
Reviewed by Ryosuke Niwa.
This should give us insight into what is causing <rdar://problem/33352721>
- platform/Timer.cpp:
(WebCore::TimerBase::setNextFireTime):
- 3:27 PM Changeset in webkit [233820] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Basic blocks highlighting should use line/column locations instead of offsets
https://bugs.webkit.org/show_bug.cgi?id=187613
<rdar://problem/42131808>
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/BasicBlockAnnotator.js:
Basic blocks sent from the backend include offsets into the original
file, rather than line/column locations. In order to translate to positions
within CodeMirror, we need to calculate the original line and column
for each block.
(WI.BasicBlockAnnotator.prototype.insertAnnotations):
(WI.BasicBlockAnnotator.prototype._calculateBasicBlockPositions.offsetToPosition):
(WI.BasicBlockAnnotator.prototype._calculateBasicBlockPositions):
(WI.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges.):
(WI.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
(WI.BasicBlockAnnotator.prototype._highlightTextForBasicBlock):
- UserInterface/Models/SourceCodePosition.js:
(WI.SourceCodePosition.prototype.offsetColumn):
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.getTextInRange):
(WI.TextEditor.prototype.addStyleToTextRange):
Better encapsulation for CodeMirror positions.
- UserInterface/Workers/Formatter/FormatterUtilities.js:
(get if):
Update String.prototype.lineEndings to support additional line separators.
- 3:26 PM Changeset in webkit [233819] by
-
- 2 edits in trunk/LayoutTests
[ MacOS WK1 ] Layout Tests in media/media-fragments/ are flaky
https://bugs.webkit.org/show_bug.cgi?id=187557
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-07-13
- platform/mac-wk1/TestExpectations:
- 3:22 PM Changeset in webkit [233818] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r231676): watchOS WebKit usually doesn't load in the background
https://bugs.webkit.org/show_bug.cgi?id=187663
<rdar://problem/42181185>
Reviewed by Chris Dumez.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidEnterBackground):
"Screen lock" is very aggressive on watchOS; we want to do our usual
30 seconds of loading in the background when you drop your wrist,
so disable this power optimization on that platform.
- 2:53 PM Changeset in webkit [233817] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Execution highlighting in the frontend should be line/column-based
https://bugs.webkit.org/show_bug.cgi?id=187532
<rdar://problem/42035580>
Reviewed by Joseph Pecoraro.
Source code offsets from Esprima should not be used to calculate ranges
in CodeMirror for expression highlighting.
This also fixes a long standing bug when adjusting for the starting
position of an inline script. Previously the start offset from the script
TextRange was used for this purpose, but the value is often incorrect (see
https://bugs.webkit.org/show_bug.cgi?id=187532#c5). By using the starting
line/column instead, we avoid the problem.
- UserInterface/Models/ScriptSyntaxTree.js:
(WI.ScriptSyntaxTree.prototype.containersOfPosition):
(WI.ScriptSyntaxTree.prototype.containersOfOffset): Deleted.
- UserInterface/Models/SourceCodePosition.js:
(WI.SourceCodePosition.prototype.offsetColumn):
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange.toInlineScriptPosition):
(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange.fromInlineScriptPosition):
(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange.convertRangeOffsetsToSourceCodeOffsets): Deleted.
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype._updateExecutionRangeHighlight):
- 1:56 PM Changeset in webkit [233816] by
-
- 2 edits in trunk/Source/WebCore
[iOS] [WK1] Crash inside IOSurfacePool::platformGarbageCollectNow() in WebThread
https://bugs.webkit.org/show_bug.cgi?id=187635
<rdar://problem/34297065>
Reviewed by Simon Fraser.
r167717 added code to trigger a CA commit in the web process via platformGarbageCollectNow() in order to free IOSurface-related memory.
However, that code is also running in the web thread in apps using WebKit1, causing unwanted UIView layout on the web thread.
Fix by not triggering this CA commit if it's called on the web thread.
- platform/graphics/cocoa/IOSurfacePoolCocoa.mm:
(WebCore::IOSurfacePool::platformGarbageCollectNow):
- 1:40 PM Changeset in webkit [233815] by
-
- 3 edits in trunk/Source/WebKit
WebResourceLoader may try to send a IPC with a destination ID that is 0
https://bugs.webkit.org/show_bug.cgi?id=187654
<rdar://problem/39265927>
Reviewed by Brady Eidson.
WebResourceLoader may try to send a IPC with a destination ID that is 0 according to release
assertion hits we see in the wild. This can lead to HashMap corruption on recipient side when
trying to lookup a key that is 0.
As per the crash traces, we see it starts from WebLoaderStrategy::internallyFailedLoadTimerFired()
which is likely due to the Network process crashing. WebLoaderStrategy::networkProcessCrashed()
calls scheduleInternallyFailedLoad() on each ResourceLoader and clears the WebResourceLoaders in
m_webResourceLoaders. When a ResourceLoader is cancelled (marked as failed), we clear its identifier
and we normally null out the WebLoaderStrategy's coreLoader. However, if we cannot find the
WebResourceLoader in m_webResourceLoaders (because that map was already cleared) then the
WebResourceLoader's coreLoader may not get nulled out, even if the coreLoader's identifier has
been reset. We have 2 lambdas in WebResourceLoader which keep the WebResourceLoader alive and
try to send IPC and are merely doing a null check on the coreLoader before trying to send the
IPC.
To address the issue, we now clear the WebResourceLoader's coreLoader in
WebLoaderStrategy::networkProcessCrashed(). For robustness, we also check that a coreLoader's
identifier is not 0 before trying to send IPC.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::networkProcessCrashed):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
- 1:34 PM Changeset in webkit [233814] by
-
- 19 edits in trunk/Source/WebCore
Dark Mode: document markers are difficult to see
https://bugs.webkit.org/show_bug.cgi?id=187632
<rdar://problem/41099719>
Reviewed by Simon Fraser.
We update the way we draw the document markers for macOS and use more constrasting colors in dark mode.
Paving the way for future improvements, we move the drawLineForDocumentMarker() method from GraphicsContext
to RenderTheme and implement a first version in RenderThemeMac. The circles used for the underline are now
drawn directly with Core Graphics and we no longer use an image resource. To allow both GraphicsContext
and RenderTheme to have different versions of the drawLineForDocumentMarker() method, the DocumentMarkerLineStyle
enum is now an "enum class".
No new test due to webkit.org/b/105616, webkit.org/b/187655 was raised to track the creation of new tests
when it becomes possible again.
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextImpl.h:
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawLineForDocumentMarker):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextImplCairo.cpp:
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker):
- platform/graphics/cairo/GraphicsContextImplCairo.h:
- platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawLineForDocumentMarker::create):
(WebCore::DisplayList::DrawLineForDocumentMarker::DrawLineForDocumentMarker):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawLineForDocumentMarker):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawLineForDocumentMarker):
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call drawLineForDocumentMarker() on the RenderTheme on
macOS and on GraphicsContext in all other cases.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::drawLineForDocumentMarker):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::colorForStyle): Provide different colors for light and dark modes.
(WebCore::RenderThemeMac::drawLineForDocumentMarker): A new macOS-specific version of drawLineForDocumentMarker()
where we paint circles using Core Graphics directly.
- 1:17 PM Changeset in webkit [233813] by
-
- 2 edits in trunk/LayoutTests
[ WK2 ] Layout Test editing/selection/update-selection-by-style-change.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187649
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-07-13
- platform/mac-wk2/TestExpectations:
- 1:08 PM Changeset in webkit [233812] by
-
- 68 edits1 add in trunk/Source/ThirdParty/libwebrtc
libwebrtc.dylib Objective-C classes conflict with third-party frameworks
<https://webkit.org/b/187653>
Reviewed by Alex Christensen.
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
- Manually add an attribute to change the class name.
- Source/webrtc/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.h:
- Source/webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLI420Renderer.h:
- Source/webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h:
- Source/webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLRenderer.h:
- Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCDtmfSender+Private.h:
- Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter.h:
- Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoDecoder.h:
- Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCWrappedNativeVideoEncoder.h:
- Source/webrtc/sdk/objc/Framework/Classes/UI/RTCEAGLVideoView.m:
- Source/webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h:
- Source/webrtc/sdk/objc/Framework/Classes/Video/RTCDefaultShader.h:
- Source/webrtc/sdk/objc/Framework/Classes/Video/RTCI420TextureCache.h:
- Source/webrtc/sdk/objc/Framework/Classes/Video/RTCNV12TextureCache.h:
- Source/webrtc/sdk/objc/Framework/Classes/Video/objc_frame_buffer.h:
- Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h:
- Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSession.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioTrack.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannel.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDtmfSender.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFileLogger.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFileVideoCapturer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceCandidate.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIceServer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIntervalRange.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLNSVideoView.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaSource.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaStream.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactoryOptions.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpParameters.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCSessionDescription.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodecFactory.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodecH264.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoDecoderVP8.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoDecoderVP9.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoEncoderVP8.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoEncoderVP9.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoRenderer.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoSource.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoTrack.h:
- Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoViewShading.h:
- Apply two shell scripts (see bug) to add an attribute to change the name of all classes and protocols.
- WebKit/0012-Add-WK-prefix-to-Objective-C-classes-and-protocols.patch: Add.
- 12:41 PM Changeset in webkit [233811] by
-
- 2 edits in trunk/Source/WebKit
Allow BOCOM and ABC plug-ins to run unsandboxed
https://bugs.webkit.org/show_bug.cgi?id=187652
rdar://problem/42149182
Patch by Zach Li <zachli@apple.com> on 2018-07-13
Reviewed by Youenn Fablet.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldAllowPluginToRunUnsandboxed):
- 12:17 PM Changeset in webkit [233810] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
REGRESSION (r233155): Remove last references to click_annotate.cc and rtpcat.cc
- libwebrtc.xcodeproj/project.pbxproj: Let Xcode have its way
with the project file by removing orphaned entries.
- 12:17 PM Changeset in webkit [233809] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
REGRESSION (r222476): Add missing semi-colons to EXPORTED_SYMBOLS_FILE variables
- Configurations/libwebrtc.xcconfig:
(EXPORTED_SYMBOLS_FILE): Add missing semi-colons.
- 11:47 AM Changeset in webkit [233808] by
-
- 4 edits in trunk/Source/WebKit
Add more threading release assertions
https://bugs.webkit.org/show_bug.cgi?id=187647
Reviewed by Alex Christensen.
Add more threading release assertions to help debug <rdar://problem/39265927>.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
- UIProcess/WebProcessProxy.cpp:
(WebKit::m_isInPrewarmedPool):
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::didFinishLaunching):
- 11:28 AM Changeset in webkit [233807] by
-
- 5 edits in trunk/Source/WebKit
[WinCairo] Add windows storage process connection implementation
https://bugs.webkit.org/show_bug.cgi?id=187531
Reviewed by Fujii Hironori.
- NetworkProcess/NetworkProcess.cpp:
- Platform/IPC/Attachment.h:
- StorageProcess/StorageProcess.cpp:
- UIProcess/Storage/StorageProcessProxy.cpp:
- 11:20 AM Changeset in webkit [233806] by
-
- 3 edits in trunk/Source/JavaScriptCore
[32bit JSC tests] stress/cow-convert-double-to-contiguous.js and stress/cow-convert-int32-to-contiguous.js are failing
https://bugs.webkit.org/show_bug.cgi?id=187561
Reviewed by Darin Adler.
This patch fixes the issue that CoW array handling is not introduced in 32bit put_by_val code.
We clean up 32bit put_by_val code.
- We remove inline out-of-bounds recording code since it is done in C operation code. This change
aligns 32bit implementation to 64bit implementation.
- We add CoW array checking, which is done in 64bit implementation.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- 11:20 AM Changeset in webkit [233805] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Use smart pointers for GstByteReader
https://bugs.webkit.org/show_bug.cgi?id=187638
Reviewed by Xabier Rodriguez-Calvar.
- platform/graphics/gstreamer/GUniquePtrGStreamer.h: Add
specialisation for GstByteReader.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
Use the new smart pointer class to avoid needing to remember where
to call gst_byte_reader_free.
(webKitMediaClearKeyDecryptorDecrypt):
- 10:46 AM Changeset in webkit [233804] by
-
- 2 edits in trunk/Source/WebKit
[macOS] REGRESSION (r233536): Development WebContent service got opted back into Library Validation
https://bugs.webkit.org/show_bug.cgi?id=187640
Reviewed by Daniel Bates.
- Scripts/process-webcontent-entitlements.sh: Add the com.apple.security.cs.disable-library-validation to the Development service regardless of whether restricted entitlements are to be used, because that entitlement is not restricted.
- 10:28 AM Changeset in webkit [233803] by
-
- 7 edits in trunk/Source/WebCore
[Curl] Move HTTP Setup logic from CurlRequest to CurlHandle for reuse.
https://bugs.webkit.org/show_bug.cgi?id=187427
Reviewed by Fujii Hironori.
CurlContext will be used by Secure WebSocket client, but HTTP setup code is
in CurlRequest, which is only for regular HTTP/HTTPS transaction. This patch
allows wss client to setup CurlHandle for HTTPS communication, such as TLS,
proxy or authentication.
No new tests because there's no behavior change.
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::CurlHandle):
(WebCore::CurlHandle::enableSSLForHost):
(WebCore::CurlHandle::willSetupSslCtx):
(WebCore::CurlHandle::willSetupSslCtxCallback):
(WebCore::CurlHandle::sslErrors const):
(WebCore::CurlHandle::setUrl):
(WebCore::CurlHandle::enableHttp):
(WebCore::CurlHandle::enableConnectionOnly):
(WebCore::CurlHandle::certificateInfo const):
(WebCore::CurlHandle::enableStdErrIfUsed):
(WebCore::CurlHandle::initialize): Deleted.
- platform/network/curl/CurlContext.h:
(WebCore::CurlHandle::url const):
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::finalizeTransfer):
(WebCore::CurlRequest::willSetupSslCtx): Deleted.
(WebCore::CurlRequest::willSetupSslCtxCallback): Deleted.
- platform/network/curl/CurlRequest.h:
- platform/network/curl/CurlSSLVerifier.cpp:
(WebCore::CurlSSLVerifier::CurlSSLVerifier):
(WebCore::CurlSSLVerifier::verify):
- platform/network/curl/CurlSSLVerifier.h:
- 10:15 AM Changeset in webkit [233802] by
-
- 2 edits in trunk/LayoutTests
[ MacOS Debug ] Layout Test inspector/view/asynchronous-layout.html is a Flaky Timeout
https://bugs.webkit.org/show_bug.cgi?id=187622
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-07-13
- platform/mac/TestExpectations:
- 10:14 AM Changeset in webkit [233801] by
-
- 3 edits in trunk/Source/WebKit
NetworkConnectionToWebProcess::m_networkResourceLoaders should use Ref<> for its values
https://bugs.webkit.org/show_bug.cgi?id=187629
Reviewed by Youenn Fablet.
NetworkConnectionToWebProcess::m_networkResourceLoaders should use Ref<> for its values
since they cannot be null.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- 10:10 AM Changeset in webkit [233800] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: SourceCodePosition.js missing from Test.html
https://bugs.webkit.org/show_bug.cgi?id=187644
Reviewed by Brian Burg.
- UserInterface/Test.html:
- 9:19 AM Changeset in webkit [233799] by
-
- 2 edits in trunk/Tools
Add a FrameLoaderClient willInjectUserScriptForFrame callback
https://bugs.webkit.org/show_bug.cgi?id=187565
<rdar://problem/42095701>
Unreviewed WKTR fix after r233782.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- 9:13 AM Changeset in webkit [233798] by
-
- 3 edits1 move2 deletes in trunk/Tools
Reduce size of WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=186820
<rdar://problem/42087508>
Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
- TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
- TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 3:47 AM Changeset in webkit [233797] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer][MSE] Add GstFlowCombiner to handle non-linked inactive branches
https://bugs.webkit.org/show_bug.cgi?id=187636
Reviewed by Carlos Garcia Campos.
When we have more than one source buffer, only one will be
rendered and the inactive branch will report linking errors that
we have to deal with.
- platform/graphics/gstreamer/GUniquePtrGStreamer.h: Added GstFlowCombiner.
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webkitMediaSrcChain): Combine the flow in the flow combiner.
(webkit_media_src_init): Initialize the flow combiner.
(webKitMediaSrcLinkStreamToSrcPad): Add the proxypad to the
combiner and set the chain function.
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamerPrivate.h:
Declare the flow combiner.
- 1:10 AM Changeset in webkit [233796] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer] Add GstBufferMapped abstraction
https://bugs.webkit.org/show_bug.cgi?id=187600
Reviewed by Xabier Rodriguez-Calvar.
There is a similar abstraction called
mapGstBufferand friends,
which have a slightly different use-case: wanting a buffer that is
mapped for a longer lifetime without have to keep track of the map
infos separately. They could be subsumed by this abstraction, but
everytime they need to write to the buffer, they'd have to remap
the memory blocks.
This abstraction is more for one-short reads and writes saving the user
from remembering to unmap the buffer and having to manage to
auxiliary GstMapInfo structures.
- platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedBuffer::GstMappedBuffer):
(WebCore::GstMappedBuffer::~GstMappedBuffer):
(WebCore::GstMappedBuffer::data):
(WebCore::GstMappedBuffer::size const):
(WebCore::GstMappedBuffer::operator bool const):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorSetupCipher):
(webKitMediaClearKeyDecryptorDecrypt):
- 12:04 AM Changeset in webkit [233795] by
-
- 2 edits in trunk/Source/WTF
Signal.cpp's activeThreads() should only create its ThreadGroup once.
https://bugs.webkit.org/show_bug.cgi?id=187634
<rdar://problem/40662311>
Reviewed by Yusuke Suzuki.
registerThreadForMachExceptionHandling() is relying on the activeThreads()
ThreadGroup being a singleton.
- wtf/threads/Signals.cpp:
(WTF::activeThreads):
Jul 12, 2018:
- 11:22 PM Changeset in webkit [233794] by
-
- 9 edits1 copy in trunk
Make it easier to hit the significant rendered text layout milestone on pages with main article elements
https://bugs.webkit.org/show_bug.cgi?id=187578
<rdar://problem/42104637>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Our current heuristics for triggering the significant rendered text layout milestone are very conservative, with
the intention of avoiding false positives. In practice, we can relax some of these constraints when we've
detected the presence of a main article element on the page. (e.g. in New York Times articles). See per-method
changes below for more detail.
Test: RenderingProgressTests.DidRenderSignificantAmountOfText
- dom/Document.cpp:
(WebCore::Document::registerArticleElement):
(WebCore::Document::unregisterArticleElement):
(WebCore::Document::updateMainArticleElementAfterLayout):
As a post layout task, update the main article element by looping through the articles (up to a maximum limit of
10) in search of an article element that is several times larger than the second largest article element.
- dom/Document.h:
Store a set containing the article elements in the document, as well as the current main article on the page.
(WebCore::Document::hasMainArticleElement const):
- html/Element.cpp:
(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::removedFromAncestor):
Keep track of the article elements that exist in the document whenever elements with the article tag are added
to or removed from the document.
- page/FrameView.cpp:
Add new minimum thresholds for firing the significant rendered text milestone when there exists a main article.
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
Take the main article element into consideration when determining whether to fire the significant text
layout milestone.
Tools:
Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
articles).
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
- TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
- TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
(TEST):
- 8:13 PM Changeset in webkit [233793] by
-
- 2 edits in trunk/Source/WebCore
JavaScript URL gives incorrect result when frame is navigated
https://bugs.webkit.org/show_bug.cgi?id=187203
<rdar://problem/41438443>
Reviewed by David Kilzer.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestFrame):
- 7:06 PM Changeset in webkit [233792] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
https://bugs.webkit.org/show_bug.cgi?id=187612
<rdar://problem/42131910>
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WI.TypeTokenAnnotator.prototype.insertAnnotations):
(WI.TypeTokenAnnotator.prototype._insertTypeToken):
(WI.TypeTokenAnnotator.prototype._insertToken):
Use line/column locations, instead of offsets, from the AST when calculating
token positions for CodeMirror. Once in CodeMirror's string space, we
can safely convert to/from offsets.
- UserInterface/Models/ScriptSyntaxTree.js:
Retrieve line/column locations for AST nodes, in addition to offsets.
Offsets into the original file are still needed for getting type information
from the profiler in the backend.
(WI.ScriptSyntaxTree):
(WI.ScriptSyntaxTree.prototype.filterByRange):
Filter by positions, which can be safely used from CodeMirror, instead of offsets.
(WI.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WI.ScriptSyntaxTree.prototype.filterByRange.filterForNodesInRange): Deleted.
- UserInterface/Models/SourceCodePosition.js:
Add convenience methods for comparing line/column positions, and for
converting to the format expected by CodeMirror. SourceCodePosition could
be made to interoperate with CodeMirror by exposing propertiesline
andch, but making the conversion explicit improves code readability.
(WI.SourceCodePosition.prototype.equals):
(WI.SourceCodePosition.prototype.isBefore):
(WI.SourceCodePosition.prototype.isAfter):
(WI.SourceCodePosition.prototype.isWithin):
(WI.SourceCodePosition.prototype.toCodeMirror):
(WI.SourceCodePosition):
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.visibleRangePositions):
(WI.TextEditor.prototype.originalPositionToCurrentPosition):
(WI.TextEditor.prototype.currentOffsetToCurrentPosition):
(WI.TextEditor.prototype.currentPositionToCurrentOffset):
(WI.TextEditor.prototype.setInlineWidget):
- 6:20 PM Changeset in webkit [233791] by
-
- 2 edits in trunk/Tools
Change my status to be a WebKit reviewer.
Unreviewed status update.
- Scripts/webkitpy/common/config/contributors.json:
- 6:16 PM Changeset in webkit [233790] by
-
- 2 edits in trunk/Tools
Unreviewed contributors.json update
Just run "validate-committer-lists -c" to canonicalize the style.
- Scripts/webkitpy/common/config/contributors.json:
- 5:28 PM Changeset in webkit [233789] by
-
- 9 edits in trunk
Reduce size of WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=186820
Reviewed by Yusuke Suzuki and Youenn Fablet.
Source/WebCore:
We were using 32 bits for the length of the port, which is always between 0 and 5 inclusive
because port numbers are missing or between 0 and 65535. Let's just use 3 bits here.
We were using 32 bits for the length of the scheme, which is usually 3-5 characters and can be
longer for some custom schemes, but I've never seen one more than 20 characters. If we assume
schemes are always less than 64MB, we can save 8 bytes per URL!
No change in behavior, just less memory use!
To restore the IPC encoding to how it was before r221165, I just encode the string and reparse it.
- platform/URL.cpp:
(WebCore::URL::invalidate):
(WebCore::URL::lastPathComponent const):
(WebCore::URL::port const):
(WebCore::URL::protocolHostAndPort const):
(WebCore::URL::path const):
(WebCore::URL::removePort):
(WebCore::URL::setPort):
(WebCore::URL::setHostAndPort):
(WebCore::URL::setPath):
- platform/URL.h:
(WebCore::URL::encode const):
(WebCore::URL::decode):
(WebCore::URL::hasPath const):
(WebCore::URL::pathStart const):
- platform/URLParser.cpp:
(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):
(WebCore::URLParser::parsePort):
(WebCore::URLParser::parseHostAndPort):
(WebCore::URLParser::allValuesEqual):
(WebCore::URLParser::internalValuesConsistent):
- workers/service/server/RegistrationDatabase.cpp:
Increment the service worker registration schema version because of the URL encoding change.
Source/WebKit:
- NetworkProcess/cache/NetworkCacheStorage.h:
Increment cache version because of URL encoding change.
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 5:03 PM Changeset in webkit [233788] by
-
- 3 edits in trunk/Source/WebKit
[Cocoa] Make sure NetworkProcess::createNetworkConnectionToWebProcess() returns a valid mach port
https://bugs.webkit.org/show_bug.cgi?id=187625
Reviewed by Youenn Fablet.
Make sure NetworkProcess::createNetworkConnectionToWebProcess() returns a valid mach port to help
debug <rdar://problem/41995022>.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):
- 4:46 PM Changeset in webkit [233787] by
-
- 3 edits in trunk/Source/WebKit
PingLoad does not need to ref the NetworkConnectionToWebProcess
https://bugs.webkit.org/show_bug.cgi?id=187624
Reviewed by Youenn Fablet.
PingLoad does not need to ref the NetworkConnectionToWebProcess and keep it alive longer than it needs to be.
Instead, ref the IPC::Connection which is lighter weight and gets invalidated when the NetworkConnectionToWebProcess
is destroyed.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad): Deleted.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- 4:37 PM Changeset in webkit [233786] by
-
- 9 edits in trunk
Make process-swap-on-navigation an experimental feature.
<rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
Reviewed by Chris Dumez.
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetProcessSwapOnNavigationEnabled):
(WKPreferencesGetProcessSwapOnNavigationEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage): If the new web page has PSON enabled via WebPreferences,
absorb that setting into this process pool's configuration.
Tools:
Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetPreferencesToConsistentValues):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
- 4:29 PM Changeset in webkit [233785] by
-
- 2 edits in trunk/Source/WebKit
Simplify code in NetworkConnectionToWebProcess::didReceiveMessage()
https://bugs.webkit.org/show_bug.cgi?id=187621
Reviewed by Youenn Fablet.
Simplify code in NetworkConnectionToWebProcess::didReceiveMessage() by not using HashMap iterators and
calling get() directly.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
- 3:24 PM Changeset in webkit [233784] by
-
- 4 edits in trunk/Source
Make sure WebProcess::ensureNetworkProcessConnection() is always called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=187607
Reviewed by Alex Christensen.
Add release assertion to make sure that ensureNetworkProcessConnection() is always called on the main
thread. Calling it on a background thread would not be safe. It would not be safe because:
- We check if we have a network process connection and then create one if we don't without any locking.
- It is not safe to construct or use a NetworkProcessConnection object from a non-main thread
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
- 3:21 PM Changeset in webkit [233783] by
-
- 2 edits in trunk/Source/WebKit
Assert that the IPC::Connection is valid in Connection::dispatchMessage(Decoder&)
https://bugs.webkit.org/show_bug.cgi?id=187617
Reviewed by Youenn Fablet.
Assert that the IPC::Connection is valid in Connection::dispatchMessage(Decoder&) as
m_client would be stale otherwise.
- Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchMessage):
- 2:34 PM Changeset in webkit [233782] by
-
- 23 edits2 adds in trunk
Add a FrameLoaderClient willInjectUserScriptForFrame callback
https://bugs.webkit.org/show_bug.cgi?id=187565
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/contentextensions/injected-script-callback.html.
- loader/FrameLoaderClient.h:
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately):
Calling the new callback whenever being about to inject a new script.
Source/WebKit:
Introduce a new WKBundlePageLoaderClient callback that is called everytime a user script is injected.
Implement WebFrameLoaderClient::willInjectUserScript by calling this new callback.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
(API::InjectedBundle::PageLoaderClient::willInjectUserScriptForFrame):
- WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(setUpPageLoaderClient):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willInjectUserScriptForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::willInjectUserScript):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Tools:
Added new test runner API to check for willInjectUserScriptForFrame callback.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::resetUserScriptInjectedCount):
(WTR::InjectedBundle::increaseUserScriptInjectedCount):
(WTR::InjectedBundle::userScriptInjectedCount const):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::willInjectUserScriptForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::userScriptInjectedCount const):
(WTR::TestRunner::injectUserScript):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::injectUserScript):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::injectUserScript):
LayoutTests:
- http/tests/contentextensions/injected-script-callback-expected.txt: Added.
- http/tests/contentextensions/injected-script-callback.html: Added.
- 2:24 PM Changeset in webkit [233781] by
-
- 22 edits in trunk/Source/WebKit
[iOS] When bringing MobileSafari to the foreground, images are drawn asynchronously after removing a snapshot that included them
https://bugs.webkit.org/show_bug.cgi?id=187374
<rdar://problem/41249545>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-07-12
Reviewed by Tim Horton.
UIProcess should block committing all the layer tree transactions for
immediate update until it receives a one whose activityStateChangeID is
greater than or equal to the one it sends with SetActivityState message.
- Scripts/webkit/messages.py:
Fix the messages code generator to include DrawingAreaInfo.h for the WebKit
typedef ActivityStateChangeID.
- Shared/DrawingAreaInfo.h:
Define ActivityStateChangeID to be uint64_t. Add a definition for the case
when the UIProcess won't be blocked for a reply back from the WebProcess.
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::activityStateChangeID const):
(WebKit::RemoteLayerTreeTransaction::setActivityStateChangeID):
Add a member for activityStateChangeID in the LayerTreeTransaction.
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):
Make LayerTreeTransaction know how to encode and decode activityStateChangeID.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::waitForDidUpdateActivityState):
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
Make the DrawingArea in the UIProcess wait the layer tree with a certain
activityStateChangeID.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::waitForDidUpdateActivityState):
If m_activityStateChangeWantsSynchronousReply is true, generate a new
activityStateChangeID and send it in the SetActivityState message.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::takeNextActivityStateChangeID):
A simple way to generate a new activityStateChangeID.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateActivityState):
Fix the UIProcess functions' prototype for Mac.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::activityStateDidChange):
- WebProcess/WebPage/AcceleratedDrawingArea.h:
Fix the UIProcess functions' prototype for GTK.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::activityStateDidChange):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
Replace wantsDidUpdateActivityState with activityStateChangeID. Treat
activityStateChangeID == ActivityStateChangeAsynchronous as if
wantsDidUpdateActivityState == false.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Make the WebPrcess pass the activityStateChangeID which it receives from
the SetActivityState message to the LayerTreeTransaction.
(WebKit::RemoteLayerTreeDrawingArea::activityStateDidChange):
When receiving the SetActivityState, treat activityStateChangeID !=
ActivityStateChangeAsynchronous as if wantsDidUpdateActivityState == true.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setActivityState):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Replace the boolean wantsDidUpdateActivityState with activityStateChangeID
in the SetActivityState message.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired):
Fix the WebProcess functions' prototype for Mac.
- 1:11 PM Changeset in webkit [233780] by
-
- 4 edits in trunk/Source/WebKit
REGRESSION (r232356): After zooming a page in and out, it's possible to temporarily have missing tiles (google.com, apple.com)
https://bugs.webkit.org/show_bug.cgi?id=187553
<rdar://problem/41863803>
Reviewed by Simon Fraser.
We ignore zoom scale from UI process if it doesn't match the last remote layer tree transaction. However nothing
guarantees that we receive the real scale again until user interacts with the page. This means the web process
scale and the UI process scale can be wildly out of sync.
This problem becomes more likely to be visible when
- we are under memory pressure so we don't update tiles during zooming and rely on the one final update afterwards
- the page generates lots of layer tree transactions
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
Remember the last transaction where we actually changed the page scale.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::scaleFromUIProcess const):
Only reject the UI process scale if there has been a scale changing transaction meanwhile.
The transaction id test was added in r218149 and the problem it fixed remains fixed. This change also matches better
what it was purpoted to implement.
- 12:52 PM Changeset in webkit [233779] by
-
- 4 edits in trunk/LayoutTests/dom/xhtml/level3/core
UTF-16 XHTML files need svn:mime-type to be handled correctly by Windows SVN
https://bugs.webkit.org/show_bug.cgi?id=187571
Reviewed by Alex Christensen.
svn propsets cannot be committed withwebkit-patch land.
This commit actually does what the previous one claimed to.
- dom/xhtml/level3/core/documentgetinputencoding03.xhtml:
- dom/xhtml/level3/core/entitygetinputencoding02.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion02.xhtml:
- dom/xhtml/level3/core/external_foo.ent:
Added property svn:mime-type and removed property svn:eol-style (to align with documentgetxmlencoding03.xhtml).
- 12:46 PM Changeset in webkit [233778] by
-
- 7 edits in trunk/Source
Keep Selections within Shadow DOM boundaries
https://bugs.webkit.org/show_bug.cgi?id=187556
<rdar://problem/41664567>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Expose needed functionality to WebKit to help with determing editing and shadow dom boundries.
Only exposing functionality to WebKit.
- dom/TreeScope.h:
- editing/Editing.h:
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustPositionForEnd const):
(WebCore::VisibleSelection::adjustPositionForStart const):
(WebCore::adjustPositionForEnd): Deleted.
(WebCore::adjustPositionForStart): Deleted.
- editing/VisibleSelection.h:
Source/WebKit:
Update rangeForPosition to take into account both editing and shadow DOM boundries.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeForPoint):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::rangeForPosition): Deleted.
- 12:14 PM Changeset in webkit [233777] by
-
- 5 edits3 adds in trunk
IndexedDB: database file of subframe cannot be removed
https://bugs.webkit.org/show_bug.cgi?id=187564
Reviewed by Youenn Fablet.
Source/WebCore:
For IndexedDB, if openingOrigin is different from mainFrameOrigin, there will be another
layer in the database file path.
IDBServer should delete database files recursively to make sure all files are removed.
Covered by modified test: WebKit.WebsiteDataStoreCustomPaths.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::removeAllDatabasesForOriginPath):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 12:07 PM Changeset in webkit [233776] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
UTF-16 XHTML files need svn:mime-type to be handled correctly by Windows SVN
https://bugs.webkit.org/show_bug.cgi?id=187571
Reviewed by Alex Christensen.
- dom/xhtml/level3/core/documentgetinputencoding03.xhtml:
- dom/xhtml/level3/core/entitygetinputencoding02.xhtml:
- dom/xhtml/level3/core/entitygetxmlversion02.xhtml:
- dom/xhtml/level3/core/external_foo.ent:
Added property svn:mime-type and removed property svn:eol-style (to align with documentgetxmlencoding03.xhtml).
- 11:37 AM Changeset in webkit [233775] by
-
- 2 edits in trunk/Tools
Make WebKit.LinkColorWithSystemAppearance work across system versions.
https://bugs.webkit.org/show_bug.cgi?id=187573
Reviewed by Wenson Hsieh.
- TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
(TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
- 11:35 AM Changeset in webkit [233774] by
-
- 2 edits in trunk/Source/WTF
Revert: iOS port should define HAVE_RUNLOOP_TIMER
<https://webkit.org/b/187370>
- wtf/Platform.h: This is only needed on macOS when using
-[WebView scheduleInRunLoop:forMode:] and
-[WebView unscheduleFromRunLoop:forMode:] to make WK1 WebViews
load synchronously using -loadHTMLString: or -loadData:.
- 11:27 AM Changeset in webkit [233773] by
-
- 6 edits1 add in trunk/Source/bmalloc
Disable IsoHeaps when Gigacage is off
https://bugs.webkit.org/show_bug.cgi?id=187160
Reviewed by Saam Barati.
Relanding change sets 233547 and 233550 with the added fix that Gigacage is also
enabled for DumpRenderTree.
Updated determineMallocFallbackState to base enabling of Iso Heaps on Gigacage
being enabled. We do this because if Gigacage is disabled, it may be due to lack
of address space.
To work around a compiler issue uncovered by the change above, I added explicit
instantiation of PerThread's static variables. Defined the same explicit
instantiated static variables with export scope in the new file PerThread.cpp
to eliminate separate variables allocations in each linked framework / library.
- CMakeLists.txt:
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/IsoTLS.cpp:
(bmalloc::IsoTLS::determineMallocFallbackState):
- bmalloc/PerThread.cpp: Added.
- bmalloc/PerThread.h:
- bmalloc/ProcessCheck.mm:
(bmalloc::gigacageEnabledForProcess):
- 10:39 AM Changeset in webkit [233772] by
-
- 5 edits in trunk/Source/JavaScriptCore
Need to handle CodeBlock::replacement() being null.
https://bugs.webkit.org/show_bug.cgi?id=187569
<rdar://problem/41468692>
Reviewed by Saam Barati.
CodeBlock::replacement() may return a nullptr. Some of our code already checks
for this while others do not. We should add null checks in all the places that
need it.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::numberOfDFGCompiles):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
- dfg/DFGOperations.cpp:
- dfg/DFGToFTLDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
- jit/JITOperations.cpp:
- 10:03 AM Changeset in webkit [233771] by
-
- 9 edits in trunk/Source/WebKit
REGRESSION (r230163): Videos cannot be seen full screen in Complete Anatomy app
https://bugs.webkit.org/show_bug.cgi?id=187527
<rdar://problem/40511527>
Reviewed by Ryosuke Niwa.
Do not enable element fullscreen mode unless apps specifically opt-in. The Fullscreen API is
an experimental feature on iOS, but not on Mac, but we can't simply not return the ExperimentalFeature
object from the list of experimental features, as this keeps Safari from being able to apply a
NSUserDefault value for that feature. Instead, add a property to API::ExperimentalFeature and
_WKExperimentalFeature called "hidden", which signals to clients whether to display the feature
in their UI.
- Scripts/GeneratePreferences.rb:
- Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/API/APIExperimentalFeature.cpp:
(API::ExperimentalFeature::create):
(API::ExperimentalFeature::ExperimentalFeature):
- UIProcess/API/APIExperimentalFeature.h:
- UIProcess/API/Cocoa/_WKExperimentalFeature.h:
- UIProcess/API/Cocoa/_WKExperimentalFeature.mm:
(-[_WKExperimentalFeature isHidden]):
- 10:00 AM Changeset in webkit [233770] by
-
- 2 edits in trunk/Source/WebKit
[Mac] Run Unlock Keychain more reliably
https://bugs.webkit.org/show_bug.cgi?id=187604
Reviewed by Dan Bernstein.
Move unlocking to a separate target, and make it a dependency for all targets that
produce binaries.
This is more than strictly required to fix the build, but this way, we won't need
to remember about keychain when project structure changes. Another consideration that
wasn't initially apparent to me is that is should be possible to build any target,
not just "All", so projects aren't necessarily built in the same order even now.
- WebKit.xcodeproj/project.pbxproj:
- 9:02 AM Changeset in webkit [233769] by
-
- 17 edits in trunk/Source
Add compile guard for enabling NSRunLoop in the WebContent process.
https://bugs.webkit.org/show_bug.cgi?id=187563
Reviewed by Chris Dumez.
Source/WebCore:
No new tests, no change in behavior.
- platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle):
Source/WebKit:
Also, replace MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) where appropriate.
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForExternalHostingProcess):
- Shared/ChildProcess.h:
- Shared/mac/ChildProcessMac.mm:
- Shared/mac/HangDetectionDisablerMac.mm:
(WebKit::setClientsMayIgnoreEvents):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::shouldLeakBoost):
- UIProcess/WebProcessPool.h:
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::stopRunLoop):
Source/WTF:
- wtf/FeatureDefines.h:
- 8:02 AM WebKitGTK/Gardening/Calendar/2018Logs edited by
- (diff)
- 7:35 AM Changeset in webkit [233768] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK+ and WPE gardening after r233765.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 7:23 AM Changeset in webkit [233767] by
-
- 3 edits2 adds in trunk
Newly added float should trigger full layout on the block.
https://bugs.webkit.org/show_bug.cgi?id=187251
<rdar://problem/41726137>
Reviewed by David Kilzer.
Source/WebCore:
RenderBlockFlow::determineStartPosition() is one of the places where we decide the extent of the line layout for the current block.
In here we try to figure out the first line in the block that requires layout. In certain cases when floats are present,
(due to their intrusive behavior) we just trigger a full layout on the entire block.
One of the special cases is when a new float is added to the block. determineStartPosition() checks for such floats (floats inserted
after the "last known float") and marks the block for full layout. However it missed the case when other, unrelated mutations happened
in addition to this newly inserted float. This patch fixes this case by checking if the floats after the "last know float" actually need layout.
Test: fast/inline/new-float-needs-layout-when-line-is-dirty.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::determineStartPosition):
LayoutTests:
- fast/inline/new-float-needs-layout-when-line-is-dirty-expected.txt: Added.
- fast/inline/new-float-needs-layout-when-line-is-dirty.html: Added.
- 6:19 AM Changeset in webkit [233766] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Add pads to the GstFlowCombiner in MediaStreamSrc
https://bugs.webkit.org/show_bug.cgi?id=187552
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-12
Reviewed by Alejandro G. Castro.
This was overlooked and it is the way the API is supposed to be used.
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebCore::webkitMediaStreamSrcAddPad):
- 1:43 AM Changeset in webkit [233765] by
-
- 43 edits in trunk/Source
[JSC] Thread VM& to JSCell::methodTable(VM&)
https://bugs.webkit.org/show_bug.cgi?id=187548
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch threads VM& to methodTable(VM&) and remove methodTable().
We add VM& parameter to estimatedSize() to thread VM& in estimatedSize implementations.
- API/APICast.h:
(toJS):
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::className):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::estimatedSize):
- bytecode/CodeBlock.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::estimatedSize):
- bytecode/UnlinkedCodeBlock.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::className):
- debugger/DebuggerScope.h:
- heap/Heap.cpp:
(JSC::GatherHeapSnapshotData::GatherHeapSnapshotData):
(JSC::GatherHeapSnapshotData::operator() const):
(JSC::Heap::gatherExtraHeapSnapshotData):
- heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::json):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/ClassInfo.h:
- runtime/DirectArguments.cpp:
(JSC::DirectArguments::estimatedSize):
- runtime/DirectArguments.h:
- runtime/HashMapImpl.cpp:
(JSC::HashMapImpl<HashMapBucket>::estimatedSize):
- runtime/HashMapImpl.h:
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::estimatedSize):
- runtime/JSArrayBuffer.h:
- runtime/JSBigInt.cpp:
(JSC::JSBigInt::estimatedSize):
- runtime/JSBigInt.h:
- runtime/JSCell.cpp:
(JSC::JSCell::dump const):
(JSC::JSCell::estimatedSizeInBytes const):
(JSC::JSCell::estimatedSize):
(JSC::JSCell::className):
- runtime/JSCell.h:
- runtime/JSCellInlines.h:
- runtime/JSGenericTypedArrayView.h:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::estimatedSize):
- runtime/JSObject.cpp:
(JSC::JSObject::estimatedSize):
(JSC::JSObject::className):
(JSC::JSObject::toStringName):
(JSC::JSObject::calculatedClassName):
- runtime/JSObject.h:
- runtime/JSProxy.cpp:
(JSC::JSProxy::className):
- runtime/JSProxy.h:
- runtime/JSString.cpp:
(JSC::JSString::estimatedSize):
- runtime/JSString.h:
- runtime/RegExp.cpp:
(JSC::RegExp::estimatedSize):
- runtime/RegExp.h:
- runtime/WeakMapImpl.cpp:
(JSC::WeakMapImpl<WeakMapBucket>::estimatedSize):
- runtime/WeakMapImpl.h:
Source/WebCore:
- bindings/js/JSDOMConstructorBase.h:
(WebCore::JSDOMConstructorBase::className):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginElementCustomGetCallData):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::JSInterfaceName::estimatedSize):
- bindings/scripts/test/JS/JSInterfaceName.h:
- 1:40 AM Changeset in webkit [233764] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed, add myself as a WebKit committer.
- Scripts/webkitpy/common/config/contributors.json:
Jul 11, 2018:
- 10:56 PM Changeset in webkit [233763] by
-
- 9 edits in trunk
[WPE] Pass the backend library name as command line parameter to the web process
https://bugs.webkit.org/show_bug.cgi?id=186841
Reviewed by Žan Doberšek.
Source/WebKit:
- UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess): Add --backend-library parameter when launching the web process.
- WebProcess/wpe/WebProcessMainWPE.cpp: Call wpe_loader_init() with the library passed as --backend-library parameter.
Tools:
- MiniBrowser/wpe/main.cpp:
(main): Stop using WPE_BACKEND_LIBRARY env var.
- Scripts/run-wpe-tests:
(WPETestRunner.init): Ditto.
- Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server): Ditto.
- wpe/backends/ViewBackend.cpp:
(WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
- wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
- 10:40 PM Changeset in webkit [233762] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r233714.
https://bugs.webkit.org/show_bug.cgi?id=187579
it made tests time out (Requested by pizlo on #webkit).
Reverted changeset:
"Change the reoptimization backoff base to 1.3 from 2"
https://bugs.webkit.org/show_bug.cgi?id=187540
https://trac.webkit.org/changeset/233714
- 10:27 PM Changeset in webkit [233761] by
-
- 3 edits2 adds in trunk
MediaDevices should derive from EventTarget in its IDL
https://bugs.webkit.org/show_bug.cgi?id=187575
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/mediastream/MediaDevices-addEventListener.html
- Modules/mediastream/MediaDevices.idl:
LayoutTests:
- fast/mediastream/MediaDevices-addEventListener-expected.txt: Added.
- fast/mediastream/MediaDevices-addEventListener.html: Added.
- 10:18 PM Changeset in webkit [233760] by
-
- 10 edits in trunk
[GLIB] Add API to allow creating variadic functions
https://bugs.webkit.org/show_bug.cgi?id=187517
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
Add a _variadic alternate method for jsc_class_add_constructor, jsc_class_add_method and
jsc_value_new_function. In that case the callback always receives a GPtrArray of JSCValue.
- API/glib/JSCCallbackFunction.cpp:
(JSC::JSCCallbackFunction::create): Make the parameters optional.
(JSC::JSCCallbackFunction::JSCCallbackFunction): Ditto.
(JSC::JSCCallbackFunction::call): Handle the case of parameters being nullopt by creating a GPtrArray of
JSCValue for the arguments.
(JSC::JSCCallbackFunction::construct): Ditto.
- API/glib/JSCCallbackFunction.h:
- API/glib/JSCClass.cpp:
(jscClassCreateConstructor): Make the parameters optional.
(jsc_class_add_constructor_variadic): Pass nullopt as parameters to jscClassCreateConstructor.
(jscClassAddMethod): Make the parameters optional.
(jsc_class_add_method_variadic): Pass nullopt as parameters to jscClassAddMethod.
- API/glib/JSCClass.h:
- API/glib/JSCValue.cpp:
(jsc_value_object_define_property_accessor): Update now that parameters are optional.
(jscValueFunctionCreate): Make the parameters optional.
(jsc_value_new_function_variadic): Pass nullopt as parameters to jscValueFunctionCreate.
- API/glib/JSCValue.h:
- API/glib/docs/jsc-glib-4.0-sections.txt:
Tools:
Add test cases.
- TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
(testJSCFunction):
(fooCreateWithFooV):
(multiplyFooV):
- 10:13 PM Changeset in webkit [233759] by
-
- 6 edits in trunk
[GLIB] Add jsc_context_get_global_object() to GLib API
https://bugs.webkit.org/show_bug.cgi?id=187515
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
This wasn't exposed because we have convenient methods in JSCContext to get and set properties on the global
object. However, getting the global object could be useful in some cases, for example to give it a well known
name like 'window' in browsers and GJS.
- API/glib/JSCContext.cpp:
(jsc_context_get_global_object):
- API/glib/JSCContext.h:
- API/glib/docs/jsc-glib-4.0-sections.txt:
Tools:
Add test cases.
- TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
(testJSCGlobalObject):
(main):
- 10:11 PM Changeset in webkit [233758] by
-
- 7 edits in trunk
[GLIB] Handle G_TYPE_STRV in glib API
https://bugs.webkit.org/show_bug.cgi?id=187512
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
Add jsc_value_new_array_from_strv() and handle G_TYPE_STRV types in function parameters.
- API/glib/JSCContext.cpp:
(jscContextGValueToJSValue):
(jscContextJSValueToGValue):
- API/glib/JSCValue.cpp:
(jsc_value_new_array_from_strv):
- API/glib/JSCValue.h:
- API/glib/docs/jsc-glib-4.0-sections.txt:
Tools:
Add test cases.
- TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
(testJSCTypes):
(joinFunction):
(testJSCFunction):
- 9:08 PM Changeset in webkit [233757] by
-
- 4 edits in trunk/Tools
[ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
https://bugs.webkit.org/show_bug.cgi?id=187549
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/factories.py:
(JSCTestsFactory.init):
- BuildSlaveSupport/ews-build/steps.py:
(CompileJSCOnlyToT): Build ToT without patch.
(CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
(RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
(ReRunJavaScriptCoreTests): Re-runs JSC tests.
(ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
(ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
(RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
(RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 9:06 PM Changeset in webkit [233756] by
-
- 4 edits in trunk/Source
Update iOS fullscreen alert text
https://bugs.webkit.org/show_bug.cgi?id=187576
rdar://problem/42052284
Reviewed by Ryosuke Niwa.
Source/WebCore:
- English.lproj/Localizable.strings:
Source/WebKit:
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _showPhishingAlert]): Update text and string keys.
- 8:37 PM Changeset in webkit [233755] by
-
- 6 edits in trunk
Unreviewed, rolling out r233742.
https://bugs.webkit.org/show_bug.cgi?id=187577
Binary incompatible change with respect to Service Worker
registration map (Requested by dydz on #webkit).
Reverted changeset:
"Reduce size of WebCore::URL"
https://bugs.webkit.org/show_bug.cgi?id=186820
https://trac.webkit.org/changeset/233742
- 8:36 PM Changeset in webkit [233754] by
-
- 3 edits in trunk/LayoutTests
Layout Test editing/selection/navigation-clears-editor-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187389
Reviewed by Wenson Hsieh.
Use 200 iterations like we did before r233701 and mark it as SLOW.
- TestExpectations:
- editing/selection/navigation-clears-editor-state.html:
- 7:57 PM Changeset in webkit [233753] by
-
- 22 edits2 adds in trunk
REGRESSION (231276): Attempting to copy an image fails
https://bugs.webkit.org/show_bug.cgi?id=187212
Source/WebCore:
<rdar://problem/41540074>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
Renamed methods to make it clear that one URL and one title are being passed in.
Test: editing/mac/pasteboard/can-copy-url-without-title.html
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::setURL):
- platform/mac/PasteboardMac.mm:
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setURL):
Source/WebKit:
<rdar://problem/41540074>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
r210683 introduced logic to prevent file URLs from being copied to the clipboard
in unexpected cases. In order to achieve this functionality,
checkURLReceivedFromWebProcess was called on all items in the pathnames array
passed into WebPasteboardProxy::setPasteboardPathnamesForType. However, this
method is a misnomer, as the pathnames array always contains exactly one URL and
one title for the URL.
Renamed methods to make it clear that one URL and one title are being passed in
and updated logic to ensure that checkURLReceivedFromWebProcess is only called
on the URL and not the title.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<PasteboardURL>::encode):
(IPC::ArgumentCoder<PasteboardURL>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::setPasteboardURL):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::setURL):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Source/WebKitLegacy/mac:
<rdar://problem/41540074>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
Renamed methods to make it clear that one URL and one title are being passed in.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::setURL):
Tools:
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
<rdar://problem/41540074>
Augmented test to include a URL where the lastPathComponent looks similar to a
file URL.
- TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
- TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::TEST):
LayoutTests:
<rdar://problem/41540074>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
Added test to ensure that we can copy a URL without a title, and the URL's
lastPathComponent appears like a file URL.
- editing/mac/pasteboard/can-copy-url-without-title-expected.txt: Added.
- editing/mac/pasteboard/can-copy-url-without-title.html: Added.
- platform/mac-wk1/TestExpectations: The added test is WK2-only due to webkit.org/b/187230.
- 7:32 PM Changeset in webkit [233752] by
-
- 19 edits1 add in trunk
Add SPI for immediate injection of user scripts
https://bugs.webkit.org/show_bug.cgi?id=173342
<rdar://problem/29202285>
Patch by Alex Christensen <achristensen@webkit.org> on 2018-07-11
Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
Source/WebCore:
The new SPI is WKUserContentController._addUserScriptImmediately.
It is covered by new API tests.
Existing functionality remains unchanged unless the new SPI is adopted.
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptImmediately):
Move injection functionality to allow us to call it directly from the new SPI.
- page/Frame.h:
- page/Page.cpp:
(WebCore::Page::forEachPage):
- page/Page.h:
Source/WebKit:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserScript):
- UIProcess/API/C/WKUserContentControllerRef.cpp:
(WKUserContentControllerAddUserScript):
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController addUserScript:]):
(-[WKUserContentController _addUserScriptImmediately:]):
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::addUserScript):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserScripts):
(WebKit::WebUserContentController::addUserScriptInternal):
If we are to inject the script internally, inject it into the appropriate pages.
If we're injecting into the top frame only, there's no need to traverse the frame tree.
(WebKit::WebUserContentController::addUserScript):
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_cpuLimit):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(waitForMessage):
(TEST):
- 7:09 PM Changeset in webkit [233751] by
-
- 6 edits in trunk/Source/WebKit
[iOS WK2] Address a possible cause of missing tiles
https://bugs.webkit.org/show_bug.cgi?id=187570
rdar://problem/40941118
Reviewed by Tim Horton.
If the web process crashes, it's possible for the user to trigger a scroll before
the process is re-launched. The pre-commit handler will bail early on the _isValid
check without clearing _hasScheduledVisibleRectUpdate, so that remains YES and we
get stuck doing no more visible content rect updates.
Fix by adding -[WKWebView _didRelaunchProcess] (WKContentView got this already), and
in that clear state that could have been set in the UI process while the web process
connection was invalid.
Also add more release logging around process termination, crash and relaunch.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _processDidExit]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
(-[WKWebView _updateVisibleContentRects]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::processDidTerminate):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didRelaunchProcess):
- 6:35 PM Changeset in webkit [233750] by
-
- 1 edit1 delete in trunk/Tools
Move WHLSL spec work to the W3C GPUWeb GitHub repository
See https://github.com/gpuweb/WHLSL
- WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
- WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
- WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
- WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
- WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
- 5:52 PM Changeset in webkit [233749] by
-
- 2 edits in trunk/Source/WebKit
Release logging dumps "Cleaning up dragging state…" every time gesture recognizers are reset in WKContentView
https://bugs.webkit.org/show_bug.cgi?id=187562
Reviewed by Tim Horton.
Tweaks up a release logging statement, such that it only logs when performing a drag or drop.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpDragSourceSessionState]):
- 5:44 PM Changeset in webkit [233748] by
-
- 2 edits in trunk/Tools
Force WKTR to use the light appearance
https://bugs.webkit.org/show_bug.cgi?id=187572
<rdar://problem/42097805>
Reviewed by Simon Fraser.
Set the NSAppearance on the NSWindow to light mode.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
- 5:18 PM Changeset in webkit [233747] by
-
- 2 edits in trunk/LayoutTests
[WinCairo] Unreviewed test gardening.
- platform/wincairo/TestExpectations:
- 5:08 PM Changeset in webkit [233746] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed, rolling out r233741.
https://bugs.webkit.org/show_bug.cgi?id=187568
"WKTR vs exp features, booooooo" (Requested by bradee-oh on
#webkit).
Reverted changeset:
"Make process-swap-on-navigation an experimental feature."
https://bugs.webkit.org/show_bug.cgi?id=187558
https://trac.webkit.org/changeset/233741
- 4:30 PM Changeset in webkit [233745] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187420
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-07-11
- platform/mac/TestExpectations:
- 2:20 PM Changeset in webkit [233744] by
-
- 1 copy in tags/Safari-606.1.24.40.2
Tag Safari-606.1.24.40.2.
- 2:09 PM Changeset in webkit [233743] by
-
- 2 edits in trunk/JSTests
Skip JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js
https://bugs.webkit.org/show_bug.cgi?id=187559
Unreviewed test gardening.
- stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js:
- 1:48 PM Changeset in webkit [233742] by
-
- 6 edits in trunk
Reduce size of WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=186820
Patch by Alex Christensen <achristensen@webkit.org> on 2018-07-11
Reviewed by Yusuke Suzuki.
Source/WebCore:
We were using 32 bits for the length of the port, which is always between 0 and 5 inclusive
because port numbers are missing or between 0 and 65535. Let's just use 3 bits here.
We were using 32 bits for the length of the scheme, which is usually 3-5 characters and can be
longer for some custom schemes, but I've never seen one more than 20 characters. If we assume
schemes are always less than 64MB, we can save 8 bytes per URL!
No change in behavior, just less memory use!
- platform/URL.cpp:
(WebCore::URL::invalidate):
(WebCore::URL::lastPathComponent const):
(WebCore::URL::port const):
(WebCore::URL::protocolHostAndPort const):
(WebCore::URL::path const):
(WebCore::URL::removePort):
(WebCore::URL::setPort):
(WebCore::URL::setHostAndPort):
(WebCore::URL::setPath):
- platform/URL.h:
(WebCore::URL::encode const):
(WebCore::URL::decode):
(WebCore::URL::hasPath const):
(WebCore::URL::pathStart const):
- platform/URLParser.cpp:
(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):
(WebCore::URLParser::parsePort):
(WebCore::URLParser::parseHostAndPort):
(WebCore::URLParser::allValuesEqual):
(WebCore::URLParser::internalValuesConsistent):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 1:47 PM Changeset in webkit [233741] by
-
- 4 edits in trunk/Source/WebKit
Make process-swap-on-navigation an experimental feature.
<rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
Reviewed by Geoff Garen.
- Shared/WebPreferences.yaml:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage): If the new web page has PSON enabled via WebPreferences,
absorb that setting into this process pool's configuration.
- 1:29 PM Changeset in webkit [233740] by
-
- 10 edits1 add in trunk
Iterator of Array.keys() returns object in wrong order
https://bugs.webkit.org/show_bug.cgi?id=185197
Reviewed by Keith Miller.
JSTests:
We align the shape of our iterator result to the spec: {value,done} instead of {done,value}.
- stress/iterator-field-order.js: Added.
(shouldBe):
(shouldBe.JSON.stringify.array.values.next):
(shouldBe.JSON.stringify.array.keys.next):
(shouldBe.JSON.stringify.array.entries.next):
(async.asyncIterator):
(iterator.next.then):
(generator):
(shouldBe.JSON.stringify.generator.next):
(shouldBe.JSON.stringify.map.keys.next):
(shouldBe.JSON.stringify.map.values.next):
(shouldBe.JSON.stringify.map.entries.next):
(set new):
Source/JavaScriptCore:
- builtins/ArrayIteratorPrototype.js:
(globalPrivate.arrayIteratorValueNext):
(globalPrivate.arrayIteratorKeyNext):
(globalPrivate.arrayIteratorKeyValueNext):
- builtins/AsyncFromSyncIteratorPrototype.js:
- builtins/AsyncGeneratorPrototype.js:
(globalPrivate.asyncGeneratorResolve):
- builtins/GeneratorPrototype.js:
(globalPrivate.generatorResume):
- builtins/MapIteratorPrototype.js:
(globalPrivate.mapIteratorNext):
- builtins/SetIteratorPrototype.js:
(globalPrivate.setIteratorNext):
- builtins/StringIteratorPrototype.js:
(next):
- runtime/IteratorOperations.cpp:
(JSC::createIteratorResultObjectStructure):
(JSC::createIteratorResultObject):
- 12:36 PM Changeset in webkit [233739] by
-
- 14 edits2 adds15 deletes in trunk
Fix remaining Cross-Origin-Resource-Policy failures, if any
https://bugs.webkit.org/show_bug.cgi?id=186761
<rdar://problem/41209829>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Fixed some tests for correctness.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker-expected.txt:
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any-expected.txt:
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.js:
(promise_test):
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker-expected.txt:
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.js:
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any-expected.txt:
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker-expected.txt:
Source/WebCore:
Add case-sensitive check for CORP header value, as per fetch specification.
Add HTTP->HTTPS check for same-site case, as per fetch specification.
https://fetch.spec.whatwg.org/#cross-origin-resource-policy-check
Test: imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.html
- loader/CrossOriginAccessControl.cpp:
(WebCore::shouldCrossOriginResourcePolicyCancelLoad):
- platform/network/HTTPParsers.cpp:
(WebCore::parseCrossOriginResourcePolicyHeader):
Tools:
- TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
(TestWebKitAPI::TEST):
2018-07-11 Aakash Jain <aakash_jain@apple.com>
[ews-build] EWS should unapply the patch and build ToT when patch fails to build
https://bugs.webkit.org/show_bug.cgi?id=187358
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/factories.py:
(BuildFactory.init):
- BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
(CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
(CompileWebKitToT): Build ToT without patch.
(CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
LayoutTests:
Remove redundant tests with WPT.
- http/wpt/cross-origin-resource-policy/fetch-expected.txt: Removed.
- http/wpt/cross-origin-resource-policy/fetch-in-iframe-expected.txt: Removed.
- http/wpt/cross-origin-resource-policy/fetch-in-iframe.html: Removed.
- http/wpt/cross-origin-resource-policy/fetch.html: Removed.
- http/wpt/cross-origin-resource-policy/iframe-loads-expected.txt: Removed.
- http/wpt/cross-origin-resource-policy/iframe-loads.html: Removed.
- http/wpt/cross-origin-resource-policy/image-loads-expected.txt: Removed.
- http/wpt/cross-origin-resource-policy/image-loads.html: Removed.
- http/wpt/cross-origin-resource-policy/resources/hello.py: Removed.
- http/wpt/cross-origin-resource-policy/resources/iframe.py: Removed.
- http/wpt/cross-origin-resource-policy/resources/iframeFetch.html: Removed.
- http/wpt/cross-origin-resource-policy/resources/redirect.py: Removed.
- http/wpt/cross-origin-resource-policy/resources/script.py: Removed.
- http/wpt/cross-origin-resource-policy/script-loads-expected.txt: Removed.
- http/wpt/cross-origin-resource-policy/script-loads.html: Removed.
- 12:29 PM Changeset in webkit [233738] by
-
- 5 edits in trunk
Disable all network caching for HLS streams.
https://bugs.webkit.org/show_bug.cgi?id=187544
<rdar://problem/41863600>
Reviewed by Chris Dumez.
Source/WebKit:
Revert the behavior added in r215263 where Media responses are cached if they are from
a resource whose expected content length is <4MB.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeStoreDecision):
(WebKit::NetworkCache::expectedTotalResourceSizeFromContentRange): Deleted.
LayoutTests:
- http/tests/cache/disk-cache/disk-cache-media-small-expected.txt:
- http/tests/cache/disk-cache/disk-cache-media-small.html:
- 12:22 PM Changeset in webkit [233737] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] MIME type registry doesn't explicitly recognize *.xht
https://bugs.webkit.org/show_bug.cgi?id=187555
Reviewed by Konstantin Tokarev.
Follow-up to r233715 -- WinCairo bots are failing on *.xht layout tests as they lack a registry key for this filetype.
(Hopefully this is the last one to add.)
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
Add *.xht to the list of recognized filetypes.
- 11:50 AM Changeset in webkit [233736] by
-
- 1 copy in tags/Safari-606.1.25
Tag Safari-606.1.25.
- 11:34 AM Changeset in webkit [233735] by
-
- 7 edits in trunk/Source
Versioning.
- 11:10 AM Changeset in webkit [233734] by
-
- 4 edits in trunk/Tools
2018-07-11 Aakash Jain <aakash_jain@apple.com>
[ews-build] EWS should unapply the patch and build ToT when patch fails to build
https://bugs.webkit.org/show_bug.cgi?id=187358
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/factories.py:
(BuildFactory.init):
- BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
(CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
(CompileWebKitToT): Build ToT without patch.
(CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
- 10:29 AM Changeset in webkit [233733] by
-
- 3 edits in trunk/Tools
[WSL] WIP, some work on the spec.
- 10:13 AM Changeset in webkit [233732] by
-
- 7 edits in branches/safari-606.1.24.40-branch/Source
Versioning.
- 9:40 AM Changeset in webkit [233731] by
-
- 2 edits in trunk/Source/WebCore
[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>
Unreviewed build fix after r233729 and r233730.
- animation/KeyframeEffectReadOnly.cpp:
(WebCore::processIterableKeyframes):
- 9:34 AM Changeset in webkit [233730] by
-
- 2 edits in trunk/Source/WebCore
[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>
Unreviewed build fix after r233729.
- animation/KeyframeEffectReadOnly.cpp:
(WebCore::processIterableKeyframes):
- 8:54 AM Changeset in webkit [233729] by
-
- 6 edits in trunk
[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark 2 new WPT progressions.
- web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
Source/WebCore:
There were two remaining assertions that we were failing in this WPT test file, both related to processing iterable keyframes.
The first one was failing because didn't correctly propagate the TypeError exception in the forEachInIterable() callback. The
second one was failing because we didn't use the "process a keyframe-like object" procedure when processing iterable keyframes
and, as such, we didn't correctly sort property alphabetically before reading their values.
To fix this second issue, we make processIterableKeyframes() use processKeyframeLikeObject(). To do so, we update processKeyframeLikeObject()
to accept a new boolean flag to match the "allow lists" flag from the specification. We also ensure we sort the properties *before*
reading from them which we didn't use to do previously.
- animation/KeyframeEffectReadOnly.cpp:
(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
- animation/KeyframeEffectReadOnly.h:
- animation/KeyframeEffectReadOnly.idl:
- 6:30 AM Changeset in webkit [233728] by
-
- 2 edits in trunk/Source/WebCore
SimpleLineLayout::FlowContents wastes 54KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186709
<rdar://problem/41173793>
Reviewed by Simon Fraser.
The size of the m_segments vector in SimpleLineLayoutFlowContents is alway pre-computed and don't change after the initial append.
Not testable.
- rendering/SimpleLineLayoutFlowContents.h:
- 3:02 AM Changeset in webkit [233727] by
-
- 4 edits in trunk
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=187551
Unreviewed gardening.
WebDriverTests:
- TestExpectations.json:
LayoutTests:
- platform/gtk/TestExpectations: Mark new test as failing: it depends on mac-only code.
- 1:18 AM Changeset in webkit [233726] by
-
- 2 edits in trunk/Source/WebKit
[WPE] AC for fixed-position elements is not enabled
https://bugs.webkit.org/show_bug.cgi?id=187514
Reviewed by Carlos Garcia Campos.
Enable accelerated compositing for fixed-position elements when using
AcceleratedDrawingArea and AC is force-enabled. This effectively enables
this option for the WPE port which is using the AcceleratedDrawingArea
implementation and not DrawingAreaImpl like the GTK+ port.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::updatePreferences):
- 12:59 AM Changeset in webkit [233725] by
-
- 2 edits in trunk/Source/WebKit
[Win][WebKit] Disable accelerated compositing until it is supported
https://bugs.webkit.org/show_bug.cgi?id=187503
Reviewed by Žan Doberšek.
- UIProcess/win/WebView.cpp:
- 12:59 AM Changeset in webkit [233724] by
-
- 2 edits in trunk/JSTests
Unreviewed, clean up test262 expectations
- test262/expectations.yaml:
Jul 10, 2018:
- 11:22 PM Changeset in webkit [233723] by
-
- 7 edits in trunk/Source/WebKit
REGRESSION (r233480): Mail contents flash black when activating
https://bugs.webkit.org/show_bug.cgi?id=187504
<rdar://problem/41752351>
Reviewed by Simon Fraser.
The sequence of events to reproduce the bug originally fixed in r203371
is either:
A) the simple background/foreground case
1] app begins to suspend
2] app suspension snapshots are taken
3] WKWebView's surfaces are marked volatile
4] app completes suspension
... time goes by ...
5] WKWebView's volatile surfaces are purged
... time goes by ...
6] app begins to resume, shows (good) suspension snapshot
7] app removes suspension snapshot
8] WKWebView has sublayers with purged (black) surfaces
9] WKWebView sublayers are repaired by a new commit with nonvolatile surfaces
B) the re-snapshot while in the background case
1] app begins to suspend
2] app suspension snapshots are taken
3] WKWebView's surfaces are marked volatile
4] app completes suspension
... time goes by ...
5] WKWebView's volatile surfaces are purged
... time goes by ...
6] app wakes up in the background to update its snapshots
7] in the updated snapshots, WKWebView has sublayers with purged (black) surfaces
... time goes by ...
8] app begins to resume, shows (bad) suspension snapshot
9] WKWebView presents layers with purged (black) surfaces until new commit fixes them
10] WKWebView sublayers are repaired by a new commit with nonvolatile surfaces
WebKit's current approach to fix this problem is simply to hide the
WKWebView's sublayers at some point after A2/B2 (suspension snapshots),
but before A8/B7 (the first time the empty layers would be presented
or snapshotted).
Previously, we did this by hiding the layers when the window's CAContext
was created, which happened early enough in both cases (at A6/B6).
However, that notification was removed underneath us at some point.
However, in looking at the timelines, there's a better place to do this:
immediately after marking the surfaces volatile (A3/B3), which is always
strictly after the app suspension snapshots are taken, and also always
before the freshly-made-volatile layers could be presented or snapshotted.
- UIProcess/ApplicationStateTracker.h:
- UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::ApplicationStateTracker::applicationDidCreateWindowContext): Deleted.
- UIProcess/ios/WKApplicationStateTrackingView.h:
- UIProcess/ios/WKApplicationStateTrackingView.mm:
(-[WKApplicationStateTrackingView didMoveToWindow]):
(-[WKApplicationStateTrackingView _applicationDidCreateWindowContext]): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationDidCreateWindowContext]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground):
Remove the didCreateWindowContext notification, and hide content after
snapshotting after entering the background.
- 11:21 PM Changeset in webkit [233722] by
-
- 9 edits3 adds in trunk
constructArray() should always allocate the requested length.
https://bugs.webkit.org/show_bug.cgi?id=187543
<rdar://problem/41947884>
Reviewed by Saam Barati.
JSTests:
- stress/regress-187543-2.js: Added.
- stress/regress-187543-3.js: Added.
- stress/regress-187543.js: Added.
Source/JavaScriptCore:
Currently, it does not when we're having a bad time. We fix this by switching
back to using tryCreateUninitializedRestricted() exclusively in constructArray().
If we detect that a structure transition is possible before we can initialize
the butterfly, we'll go ahead and eagerly initialize the rest of the butterfly.
We will introduce JSArray::eagerlyInitializeButterfly() to handle this.
Also enhanced the DisallowScope and ObjectInitializationScope to support this
eager initialization when needed.
- dfg/DFGOperations.cpp:
- the client of operationNewArrayWithSizeAndHint() (in FTL generated code) expects the array allocation to always succeed. Adding this RELEASE_ASSERT here makes it clearer that we encountered an OutOfMemory condition instead of failing in FTL generated code, which will appear as a generic null pointer dereference.
- runtime/ArrayPrototype.cpp:
(JSC::concatAppendOne):
- the code here clearly wants to check for an allocation failure. Switched to using JSArray::tryCreate() instead of JSArray::create().
- runtime/DisallowScope.h:
(JSC::DisallowScope::disable):
- runtime/JSArray.cpp:
(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::eagerlyInitializeButterfly):
(JSC::constructArray):
- runtime/JSArray.h:
- runtime/ObjectInitializationScope.cpp:
(JSC::ObjectInitializationScope::notifyInitialized):
- runtime/ObjectInitializationScope.h:
(JSC::ObjectInitializationScope::notifyInitialized):
- 10:00 PM Changeset in webkit [233721] by
-
- 14 edits in trunk/Source/JavaScriptCore
[JSC] Remove getTypedArrayImpl
https://bugs.webkit.org/show_bug.cgi?id=187338
Reviewed by Mark Lam.
getTypedArrayImpl is overridden only by typed arrays and DataView. Since the number of these classes
are limited, we do not need to add this function to MethodTable: dispatching it in JSArrayBufferView is fine.
This patch removes getTypedArrayImpl from MethodTable, and moves it to JSArrayBufferView.
- runtime/ClassInfo.h:
- runtime/GenericTypedArrayView.h:
(JSC::GenericTypedArrayView::data const): Deleted.
(JSC::GenericTypedArrayView::set): Deleted.
(JSC::GenericTypedArrayView::setRange): Deleted.
(JSC::GenericTypedArrayView::zeroRange): Deleted.
(JSC::GenericTypedArrayView::zeroFill): Deleted.
(JSC::GenericTypedArrayView::length const): Deleted.
(JSC::GenericTypedArrayView::item const): Deleted.
(JSC::GenericTypedArrayView::set const): Deleted.
(JSC::GenericTypedArrayView::setNative const): Deleted.
(JSC::GenericTypedArrayView::getRange): Deleted.
(JSC::GenericTypedArrayView::checkInboundData const): Deleted.
(JSC::GenericTypedArrayView::internalByteLength const): Deleted.
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::possiblySharedImpl):
- runtime/JSArrayBufferView.h:
- runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::possiblySharedImpl): Deleted.
- runtime/JSCell.cpp:
(JSC::JSCell::getTypedArrayImpl): Deleted.
- runtime/JSCell.h:
- runtime/JSDataView.cpp:
(JSC::JSDataView::getTypedArrayImpl): Deleted.
- runtime/JSDataView.h:
- runtime/JSGenericTypedArrayView.h:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getTypedArrayImpl): Deleted.
- 7:50 PM Changeset in webkit [233720] by
-
- 16 edits6 adds in trunk
Make fetch() use "same-origin" credentials by default
https://bugs.webkit.org/show_bug.cgi?id=176023
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Tests updated according upstream WPT repo.
- web-platform-tests/fetch/api/request/request-init-003.sub.html:
- web-platform-tests/fetch/api/request/request-structure.html:
Source/WebCore:
Covered by updated tests.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::initializeWith):
Setting credentials mode to same-origin for FetchRequest by default.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
Handle correctly referrer in case we restart a load.
- page/PerformanceResourceTiming.cpp:
(WebCore::entryStartTime):
(WebCore::entryEndTime):
In case it is not allowed to disclose resource timing info, update as
https://www.w3.org/TR/resource-timing-1/#performanceresourcetiming
Source/WebKit:
Before the patch, when changing the credential mode in case of redirection,
we were not waiting for WebProcess response to restart the load.
This patch updates the implementation to ask the WebProcess whether to proceed as for other regular asynchronous loads.
This requires some refactoring in particular we now pass request, redirectRequest and redirectResponse to NetworkLoadChecker
that will send them back as part of the completion handler.
To do so, we change manual redirection handling and make it a successful case and not an error case as before.
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::redirectionError):
(WebKit::NetworkLoadChecker::checkRedirection):
- NetworkProcess/NetworkLoadChecker.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::restartNetworkLoad):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):
LayoutTests:
Resource timing does not work properly on WK1 when stopping fetch/XHR load to restart it without credentials.
Updated expected results accordingly.
- http/tests/inspector/network/resource-mime-type.html:
Update resource-mime-type.html to ensure we go to the network for every load.
- http/wpt/resource-timing/rt-cors.js:
(assertRedirectWithDisallowedTimingData):
Updated test according https://www.w3.org/TR/resource-timing-1/#performanceresourcetiming.
- platform/mac-wk1/http/wpt/resource-timing/rt-cors-expected.txt: Added.
- platform/mac-wk1/http/wpt/resource-timing/rt-cors.worker-expected.txt: Added.
- platform/win/http/wpt/resource-timing/rt-cors-expected.txt: Added.
- platform/win/http/wpt/resource-timing/rt-cors.worker-expected.txt: Added.
- 6:57 PM Changeset in webkit [233719] by
-
- 4 edits in trunk/Source/WebCore
"serviceworker.js" is fetched several times in a row
https://bugs.webkit.org/show_bug.cgi?id=187435
<rdar://problem/41940569>
Reviewed by Youenn Fablet.
Soft updates happen every time a fetch event is sent to a service worker for a main resource request.
This can happen many times during a page load and will cause us to spam the HTTP server with update
requests, especially considering that the default behavior is to bypass the HTTP cache. To address
the issue, we now do soft updates on a 1 second delay and we keep rescheduling this timer was long as
soft update requests keep coming. Based on my understanding of the Chromium code, this seems to be
what they are doing so this should align our behavior with them.
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::scheduleSoftUpdate):
- workers/service/ServiceWorkerRegistration.h:
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
- 6:28 PM Changeset in webkit [233718] by
-
- 3 edits1 add in trunk
hasOwnProperty returns true for out of bounds property index on TypedArray
https://bugs.webkit.org/show_bug.cgi?id=187520
Reviewed by Saam Barati.
JSTests:
getOwnPropertySlot returns true on out of bounds indicies for
TypedArrays, which is incorrect.
- stress/typedarray-hasOwnProperty-out-of-bounds.js: Added.
(test):
Source/JavaScriptCore:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
- 6:03 PM Changeset in webkit [233717] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r229932) Use of uninitialized value in subroutine entry at copy-user-interface-resources.pl
https://bugs.webkit.org/show_bug.cgi?id=187511
Reviewed by Brian Burg.
copy-user-interface-resources.pl output warning messages unless
BUILT_PRODUCTS_DIR and BUILT_PRODUCTS_DIR env vars are defined.
- Scripts/copy-user-interface-resources.pl:
(webInspectorUIAdditionsDir): Added. Return UNDEF if
BUILT_PRODUCTS_DIR and SDKROOT env vars aren't defined.
(combineOrStripResourcesForWebKitAdditions): Check
$webInspectorUIAdditionsDir is defined.
- 5:35 PM Changeset in webkit [233716] by
-
- 4 edits in trunk
DFG JIT: compileMathIC produces incorrect machine code
https://bugs.webkit.org/show_bug.cgi?id=187537
Reviewed by Saam Barati.
JSTests:
Added new test case.
- stress/arith-mul-with-constants.js:
(testArithMulWithTypeConfusedConstant.testMult):
(testArithMulWithTypeConfusedConstant):
Source/JavaScriptCore:
Added checks for constant multipliers in JITMulGenerator::generateInline(). If we have a constant multiplier,
fall back to the fast path generator which handles such cases.
- jit/JITMulGenerator.cpp:
(JSC::JITMulGenerator::generateInline):
- 5:27 PM Changeset in webkit [233715] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] MIME type registry doesn't explicitly recognize *.css
https://bugs.webkit.org/show_bug.cgi?id=187538
Reviewed by Yusuke Suzuki.
MIMETypeRegistryWin doesn't explicitly recognize *.css; it instead falls back to the registry key "Content Type"
under HKEY_CLASSES_ROOT\.css. This key doesn't exist on Windows Server unless an application actually registers
it -- as a result, WinCairo bots are currently viewing it as an unrecognized filetype!
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
Add *.css to the list of recognized filetypes.
- 5:16 PM Changeset in webkit [233714] by
-
- 4 edits in trunk/Source/JavaScriptCore
Change the reoptimization backoff base to 1.3 from 2
https://bugs.webkit.org/show_bug.cgi?id=187540
Reviewed by Saam Barati.
I have data that hints at this being a speed-up on JetStream, ARES-6, and Speedometer2.
I also have data that hints that a backoff base of 1 might be even better, but I think that
we want to keep *some* backoff in case we find ourselves in an unmitigated recomp loop.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::reoptimizationRetryCounter const):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::adjustedCounterValue):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 5:09 PM Changeset in webkit [233713] by
-
- 8 edits in trunk/Source/WebKit
[IOS] We should prevent WebProcess suspension while the UIProcess is waiting for a reply from its injected bundle
https://bugs.webkit.org/show_bug.cgi?id=187536
<rdar://problem/41931912>
Reviewed by Brady Eidson.
Update RemoteObjectRegistry to take a background process assertion for each pending reply on the
UIProcess side. Otherwise, the destination web process may get suspended and the reply block would
not get called. We already do this in WebPageProxy for callbacks waiting for an IPC from the
WebProcess.
- Shared/API/Cocoa/RemoteObjectRegistry.h:
- Shared/API/Cocoa/RemoteObjectRegistry.mm:
(WebKit::RemoteObjectRegistry::RemoteObjectRegistry):
(WebKit::RemoteObjectRegistry::sendInvocation):
(WebKit::RemoteObjectRegistry::callReplyBlock):
(WebKit::RemoteObjectRegistry::releaseUnusedReplyBlock):
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _initWithWebPage:]):
(-[_WKRemoteObjectRegistry _initWithWebPageProxy:]):
(-[_WKRemoteObjectRegistry _initWithMessageSender:]): Deleted.
- Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _remoteObjectRegistry]):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::remoteObjectRegistry):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _remoteObjectRegistry]):
- 4:59 PM Changeset in webkit [233712] by
-
- 1 copy in tags/Safari-606.1.24.40.1
Tag Safari-606.1.24.40.1.
- 4:57 PM Changeset in webkit [233711] by
-
- 1 copy in tags/Safari-606.1.24.20.1
Tag Safari-606.1.24.20.1.
- 4:51 PM Changeset in webkit [233710] by
-
- 2 edits in branches/safari-606.1.24.20-branch/Source/WebCore
Cherry-pick r233535. rdar://problem/41917649
Video sometimes flickers when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=187193
<rdar://problem/40153865>
Unreviewed, fix a broken API test.
- platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSession::setCategory): None should set the category to AVAudioSessionCategoryAmbient, because it signals that WebKit is not playing audio so we want allow other apps to play.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:48 PM Changeset in webkit [233709] by
-
- 7 edits in branches/safari-606.1.24.40-branch/Source
Versioning.
- 4:42 PM Changeset in webkit [233708] by
-
- 2 edits in trunk/Tools
[ews-build] Add build step to UnApply patch
https://bugs.webkit.org/show_bug.cgi?id=187357
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/steps.py:
(UnApplyPatchIfRequired.init): Pass alwaysUseLatest parameter in order to unapply the patch.
(UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
properties will be set by build-steps for build and test.
(UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
- 4:39 PM Changeset in webkit [233707] by
-
- 1 copy in branches/safari-606.1.24.40-branch
New branch.
- 4:38 PM Changeset in webkit [233706] by
-
- 7 edits in branches/safari-606.1.24.20-branch/Source
Versioning.
- 4:28 PM Changeset in webkit [233705] by
-
- 1 copy in branches/safari-606.1.24.20-branch
New branch.
- 4:19 PM Changeset in webkit [233704] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r233552): Find highlight has white text on yellow background
https://bugs.webkit.org/show_bug.cgi?id=187535
rdar://problem/42043371
Reviewed by Tim Horton.
Fixes existing image tests:
- fast/text/mark-matches-rendering.html
- fast/text/mark-matches-broken-line-rendering.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::resolveStyleForMarkedText): Remove incorect UseDarkAppearance.
- 3:41 PM Changeset in webkit [233703] by
-
- 2 edits in trunk/Source/WebKit
WebDriver: hang when running Selenium test correct_event_firing_tests.py::testShouldEmitOnChangeEventsWhenSelectingElements[Safari]
https://bugs.webkit.org/show_bug.cgi?id=187486
<rdar://problem/41987110>
Reviewed by Tim Horton.
This test takes the unusual step of doing Element Click directly on a <select> element,
despite the specification supporting clicking on <option> elements directly. It hangs
because we fire a nested run loop when the Carbon popup menu appears, and the nested runloop
is not exited until the popup menu is clicked or dismissed.
If a click is being simulated on the <select> via WebDriver, we should just not show
the popup menu but still deliver all of the events that are fired when clicking the element.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
- 3:01 PM Changeset in webkit [233702] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the build
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _internalDoAfterNextPresentationUpdate:withoutWaitingForPainting:withoutWaitingForAnimatedResize:]):
- 3:00 PM Changeset in webkit [233701] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/selection/navigation-clears-editor-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187389
<rdar://problem/41898822>
Rubber-stamped by Ryosuke Niwa.
Make this test less susceptible to timing out on debug builds by:
- lowering the number of iframes we add by a factor of two
- removing the tests own internal 18 second timeout
- editing/selection/navigation-clears-editor-state.html:
- 2:59 PM Changeset in webkit [233700] by
-
- 2 edits in trunk/Tools
Update ARES-6.patch file accordingly for r233631.
https://bugs.webkit.org/show_bug.cgi?id=187534
Reviewed by Saam Barati.
Update ARES-6.patch file acoordingly after ARES-6 plan file change to
avoid warning while applying the patch.
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
- 2:56 PM Changeset in webkit [233699] by
-
- 2 edits in trunk/Source/WebCore
AX: Crash in accessing AXObjectCache in textMarkerDataForVisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=187528
<rdar://problem/37231941>
Reviewed by Joanmarie Diggs.
Occasional crashes reported when running accessibility/mac/search-field-cancel-button.html.
Looks like the cache object retrieved was not valid and we weren't checking for it.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl):
- 2:29 PM Changeset in webkit [233698] by
-
- 6 edits in trunk
doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
https://bugs.webkit.org/show_bug.cgi?id=187500
<rdar://problem/41294139>
Reviewed by Simon Fraser.
Source/WebKit:
Clients generally expect that after doAfterNextPresentationUpdate, there's
something vaguely sensible on the screen. They use this to remove snapshots,
unhide web views, etc.
During some kinds of resize/rotation, we will hide the WKContentView,
and asynchronously hide it when the resize/rotation is complete. This
can cause clients to prematurely expose a blank WKWebView.
To fix this, avoid calling doAfterNextPresentationUpdate until the
animated resize completes. Add a variant that does not wait for this
(to be used for testing purposes).
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
Rename the vector of blocks that we call after animated resize completes
to be generic rather than just about snapshots.
(-[WKWebView _internalDoAfterNextPresentationUpdate:withoutWaitingForPainting:withoutWaitingForAnimatedResize:]):
Add this _internal variant of _doAfterNextPresentationUpdate that takes bits determining
which waits to perform or avoid, to reduce duplication.
(-[WKWebView _doAfterNextPresentationUpdate:]):
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeForTesting:]):
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForPainting:]):
Call _internalDoAfterNextPresentationUpdate with the appropriate bits set for each situation.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Add _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeForTesting to WKWebView(WKTesting).
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
(-[AnimatedResizeWebView _endAnimatedResize]):
Set didEndAnimatedResize before calling super, because it makes the
new test easier and doesn't affect any of the existing ones.
(AnimatedResizeBlocksViewportFitChanges):
This doAfterNextPresentationUpdate is always called during animated resize,
and then synchronously waited for, so it /must/ use
_doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
(AnimatedResizeBlocksDoAfterNextPresentationUpdate):
Add a test ensuring that doAfterNextPresentationUpdate is deferred
until endAnimatedResize is called.
- TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
(-[WKWebView _test_waitForDidFinishNavigation]):
_test_waitForDidFinishNavigation is sometimes called during animated resize,
and synchronously waits for a doAfterNextPresentationUpdate, so
it cannot wait for the animated resize to complete.
- 1:47 PM Changeset in webkit [233697] by
-
- 2 edits in trunk/Source/JavaScriptCore
[32-bit JSC tests] ASSERTION FAILED: !butterfly->propertyStorage()[-I - 1].get() under JSC::ObjectInitializationScope::verifyPropertiesAreInitialized.
https://bugs.webkit.org/show_bug.cgi?id=187362
<rdar://problem/42027210>
Reviewed by Saam Barati.
On 32-bit targets, a 0 valued JSValue is not the empty JSValue, but it is a valid
value to use for initializing unused properties. Updated an assertion to account
for this.
- runtime/ObjectInitializationScope.cpp:
(JSC::ObjectInitializationScope::verifyPropertiesAreInitialized):
- 1:35 PM Changeset in webkit [233696] by
-
- 5 edits2 adds in trunk
FragmentInterval, FragmentIntervalTree and FragmentSearchAdapter should hold not hold raw pointers to renderers.
https://bugs.webkit.org/show_bug.cgi?id=187249
<rdar://problem/41725869>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/multicol/crash-in-vertical-writing-mode.html
- rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::updateFragmentsFragmentedFlowPortionRect):
- rendering/RenderFragmentedFlow.h:
(WTF::ValueToString<WeakPtr<WebCore::RenderFragmentContainer>>::string):
LayoutTests:
- fast/multicol/crash-in-vertical-writing-mode-expected.txt: Added.
- fast/multicol/crash-in-vertical-writing-mode.html: Added.
- 1:09 PM Changeset in webkit [233695] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Layers inspector should allow control-dragging to pan the 3D render
https://bugs.webkit.org/show_bug.cgi?id=185109
Patch by Ross Kirsling <rkirsling@gmail.com> on 2018-07-10
Reviewed by Matt Baker.
Addressed in the three.js repo itself (https://github.com/mrdoob/three.js/pull/13972),
so this patch simply updates three.js and its OrbitControls module.
- UserInterface/External/three.js/LICENSE:
- UserInterface/External/three.js/three.js:
Update to r94.
- UserInterface/External/three.js/OrbitControls.js:
Update to latest.
- UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype.initialLayout):
(WI.Layers3DContentView.prototype._restrictPan):
Adapt to recent changes in three.js.
- 12:21 PM Changeset in webkit [233694] by
-
- 5 edits in trunk/Source/WebKit
REGRESSION (r231510): Dismissing PDFPlugin context menu automatically clicks the first item
https://bugs.webkit.org/show_bug.cgi?id=187507
<rdar://problem/42007155>
Reviewed by Per Arne Vollan.
WebPageProxy::showPDFContextMenu, introduced in r213510, assumes that
the user always chooses some item from the menu; it does not handle
the case where the context menu is dismissed without selecting anything.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(-[WKPDFMenuTarget selectedMenuItem]):
(-[WKPDFMenuTarget contextMenuAction:]):
(WebKit::WebPageProxy::showPDFContextMenu):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
Make showPDFContextMenu return an optional index, instead of always
returning an index. Don't perform any action if it is nullopt.
- 12:14 PM Changeset in webkit [233693] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused NavigationSidebarPanel.treeElementAddedOrChanged
https://bugs.webkit.org/show_bug.cgi?id=187508
Reviewed by Joseph Pecoraro.
- UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
(WI.NavigationSidebarPanel.prototype.treeElementAddedOrChanged): Deleted.
- 11:24 AM Changeset in webkit [233692] by
-
- 3 edits in trunk/Tools
[GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=184441
Reviewed by Michael Catanzaro.
All executables of TestWebKitAPI need the forwarding headers of
WebCore and PAL because config.h includes
<WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
The forwarding headers of WebCore are generated by
generate-forwarding-headers.pl in GTK and WPE ports. The
forwarding headers of PAL are generated by
WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
- TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
- TestWebKitAPI/PlatformWPE.cmake: Ditto.
- 11:22 AM Changeset in webkit [233691] by
-
- 7 edits in trunk
[WinCairo] Support display of webinspector ui on non-legacy minibrowser
https://bugs.webkit.org/show_bug.cgi?id=187415
Patch by Stephan Szabo <stephan.szabo@sony.com> on 2018-07-10
Reviewed by Brian Burg.
Source/WebKit:
- UIProcess/WebInspectorProxy.h:
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::getInspectedWindowInfo):
(WebKit::WebInspectorProxy::windowReceivedMessage):
(WebKit::WebInspectorProxy::wndProc):
(WebKit::WebInspectorProxy::registerWindowClass):
(WebKit::decidePolicyForNavigationAction):
(WebKit::webProcessDidCrash):
(WebKit::WebInspectorProxy::platformCreateFrontendPage):
(WebKit::WebInspectorProxy::platformCloseFrontendPageAndWindow):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformInspectedWindowWidth):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformBringInspectedPageToFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::platformCreateFrontendWindow):
(WebKit::WebInspectorProxy::platformDidCloseForCrash):
(WebKit::WebInspectorProxy::platformInvalidate):
(WebKit::WebInspectorProxy::platformStartWindowDrag):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::openFrontendConnection):
- WebProcess/WebPage/win/WebInspectorUIWin.cpp:
(WebKit::WebInspectorUI::localizedStringsURL):
(WebKit::RemoteWebInspectorUI::localizedStringsURL):
Tools:
- MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::WebKitBrowserWindow):
- 10:34 AM Changeset in webkit [233690] by
-
- 3 edits1 add in trunk
YARR: . doesn't match non-BMP Unicode characters in some cases
https://bugs.webkit.org/show_bug.cgi?id=187248
Reviewed by Geoffrey Garen.
JSTests:
New regression test.
- stress/regexp-with-nonBMP-any.js: Added.
Source/JavaScriptCore:
The safety check in optimizeAlternative() for moving character classes that only consist of BMP
characters did not take into account that the character class is inverted. In this case, we
represent '.' as "not a newline" using the newline character class with an inverted check.
Clearly that includes non-BMP characters.
The fix is to check that the character class doesn't have non-BMP characters AND it isn't an
inverted use of that character class.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::optimizeAlternative):
- 10:22 AM Changeset in webkit [233689] by
-
- 7 edits in branches/safari-606.1.24-branch/Source
Versioning.
- 10:09 AM Changeset in webkit [233688] by
-
- 67 edits in trunk
Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
https://bugs.webkit.org/show_bug.cgi?id=187499
<rdar://problem/41999431>
Reviewed by Chris Dumez.
Source/WebKit:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreStatisticsResetToConsistentState):
Now uses a WTF::CallbackAggregator to call its
completion handler when both the call to
WebResourceLoadStatisticsStore::scheduleClearInMemory()
and to
WebResourceLoadStatisticsStore::resetParametersToDefaultValues()
are complete.
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemory):
Now takes a WTF::CompletionHandler so that it can support the
completion handler in
WKWebsiteDataStoreStatisticsResetToConsistentState().
(WebKit::WebResourceLoadStatisticsStore::resetParametersToDefaultValues):
Now takes a WTF::CompletionHandler so that it can support the
completion handler in
WKWebsiteDataStoreStatisticsResetToConsistentState().
- UIProcess/WebResourceLoadStatisticsStore.h:
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::statisticsResetToConsistentState):
(WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::statisticsResetToConsistentState):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didResetStatisticsToConsistentState):
- WebKitTestRunner/TestInvocation.h:
LayoutTests:
These changes are to adopt and make use of the new completion handler in
testRunner.statisticsResetToConsistentState().
- http/tests/resourceLoadStatistics/add-blocking-to-redirect.html:
- http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html:
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics.html:
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins.html:
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-under-top-frame-origins.html:
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-unique-redirects-to.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-mixed-statistics.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-sub-frame-under-top-frame-origins.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-to-prevalent.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-under-top-frame-origins.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-unique-redirects-to.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-to-prevalent.html:
- http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-unique-redirects-to.html:
- http/tests/resourceLoadStatistics/classify-as-very-prevalent-based-on-mixed-statistics.html:
- http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html:
- http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store.html:
- http/tests/resourceLoadStatistics/grandfathering.html:
- http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html:
- http/tests/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html:
- http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html:
- http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html:
- http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
- http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html:
- http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html:
- http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html:
- http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html:
- http/tests/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html:
- http/tests/resourceLoadStatistics/prevalent-resource-with-user-interaction.html:
- http/tests/resourceLoadStatistics/prevalent-resource-without-user-interaction.html:
- http/tests/resourceLoadStatistics/prune-statistics.html:
- http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html:
- http/tests/resourceLoadStatistics/remove-partitioning-in-redirect.html:
- http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
- http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
- http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects.html:
- http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-requests.html:
- http/tests/resourceLoadStatistics/telemetry-generation.html:
- http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html:
- http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html:
- http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html:
- http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html:
- 9:53 AM Changeset in webkit [233687] by
-
- 12 edits in trunk
Disable cross-origin-window-policy by default
https://bugs.webkit.org/show_bug.cgi?id=187509
Reviewed by Chris Dumez.
Source/WebCore:
Disabled the feature by default.
- page/Settings.yaml:
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCrossOriginWindowPolicyEnabled):
(WKPreferencesGetCrossOriginWindowPolicyEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Tools:
Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 9:44 AM Changeset in webkit [233686] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
https://bugs.webkit.org/show_bug.cgi?id=187482
<rdar://problem/41989190>
Reviewed by Brian Burg.
Subclasses of NavigationSidebarPanel must process tree selection changes
even when collapsed. Sidebar panels perform critical controller tasks
for their tabs, such as updating the view when pausing in the debugger,
and when the hierarchical path component selection changes.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/SourcesSidebarPanel.js:
(WI.SourcesSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel._treeSelectionDidChange):
- 9:35 AM Changeset in webkit [233685] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
[Web Animations] Make WPT test at animation-model/keyframe-effects/effect-value-overlapping-keyframes.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186492
<rdar://problem/41000150>
Reviewed by Dean Jackson.
While we've fixed handling of overlapping keyframes in the fix for webkit.org/b/187498 (r233676), we weren't passing
the dedicated WPT test because it assumed absolute accuracy when reading the computed style opacity. This isn't correct
per the CSS spec and the WPT test has been updated (see https://github.com/web-platform-tests/wpt/pull/11880). We're
reflecting this change in our copy of this test which now passes.
- web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes-expected.txt:
- web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes.html:
- 9:33 AM Changeset in webkit [233684] by
-
- 3 edits in trunk/Source/WebCore
[GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC is not needed anymore
https://bugs.webkit.org/show_bug.cgi?id=187513
Patch by Alejandro G. Castro <alex@igalia.com> on 2018-07-10
Reviewed by Youenn Fablet.
We used the factory of the LibWebRTCProvider in
RealtimeMediaSourceCenterLibWebRTC as a singleton to make sure the
devices were correctly listed and used, we needed this when using
libwebrtc media devices management. We are now using GStreamer to handle
the media devices so this is not needed anymore.
No new tests, this change removed unused code.
- platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:
(WebCore::RealtimeMediaSourceCenterLibWebRTC::RealtimeMediaSourceCenterLibWebRTC):
- platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h:
- 9:24 AM Changeset in webkit [233683] by
-
- 2 edits in trunk/LayoutTests
[ MacOS Debug ] Layout Test media/media-fragments/TC0015.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187522
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-07-10
- platform/mac-wk1/TestExpectations:
- 6:44 AM Changeset in webkit [233682] by
-
- 2 edits in trunk/Source/WebCore
Rollout r233530: Candidate for Speedometer regression.
https://bugs.webkit.org/show_bug.cgi?id=187518
- rendering/SimpleLineLayoutFlowContents.h:
- 3:15 AM Changeset in webkit [233681] by
-
- 2 edits in trunk/Tools
[Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
https://bugs.webkit.org/show_bug.cgi?id=187470
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-10
Reviewed by Philippe Normand.
Never force building, the user is responsible to make that decision and the workflow is
now based on external scripts so it doesn't make sense anymore. Doing that leads
to ignoring the options the user passed in.
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_dev_env):
- 1:23 AM Changeset in webkit [233680] by
-
- 5 edits in trunk/Tools
[Flatpak] Fix running wpt tests inside flatpak
https://bugs.webkit.org/show_bug.cgi?id=187490
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-10
Reviewed by Philippe Normand.
Still not *all* passing but a big majority do.
- Scripts/webkitpy/w3c/wpt_runner.py:
(main): Generate the /etc/hosts and mount it in flatpak as required.
(WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
(WPTRunner._prepare_wpt_checkout): Deleted.
- flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
Stopped passing--device=allas it is not required since r233638 (Bug 187400).
- flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
- 1:21 AM Changeset in webkit [233679] by
-
- 2 edits in trunk/Tools
[Flatpak] Use logging to print debug information
https://bugs.webkit.org/show_bug.cgi?id=187496
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-10
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(WebkitFlatpak.load_from_args):
(WebkitFlatpak.clean_args):
(WebkitFlatpak.run_in_sandbox):
