Timeline
Aug 11, 2018:
- 9:13 PM Changeset in webkit [234785] by
-
- 3 edits in trunk/Tools
[ews-build] Separate queues for Builders and Testers - iOS
https://bugs.webkit.org/show_bug.cgi?id=188396
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
Also added ews121 and ews122 to match with current EWS configuration.
- BuildSlaveSupport/ews-build/factories.py:
(TestsFactory): Base classes for various Test factories.
(TestsFactory.getProduct): Download and extract the archive.
- 2:04 PM Changeset in webkit [234784] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable JIT on IA-32 without SSE2
https://bugs.webkit.org/show_bug.cgi?id=188476
Patch by Karo Gyoker <karogyoker2+webkit@gmail.com> on 2018-08-11
Reviewed by Yusuke Suzuki.
On IA-32 CPUs without SSE2 most of the webpages cannot load
if the JIT is turned on.
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- 7:04 AM Changeset in webkit [234783] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=188482
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2018-08-11
Rubber-stamped by Michael Catanzaro.
- pt_BR.po:
Aug 10, 2018:
- 11:47 PM Changeset in webkit [234782] by
-
- 3 edits in trunk/Source/WebCore
Use OptionSet for various RenderLayer flags
https://bugs.webkit.org/show_bug.cgi?id=188472
<rdar://problem/43153059>
Followup, fix some mistakes.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
- 7:55 PM Changeset in webkit [234781] by
-
- 3 edits in trunk/Source/WebKit
[Cocoa] WebKit::PlatformPopupMenuData should use member initialization
<https://webkit.org/b/188478>
<rdar://problem/43154363>
Reviewed by Joseph Pecoraro.
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
implementation. This constructor caused the warning by never
initializing its member variables.
- Shared/PlatformPopupMenuData.h:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
- Use default constructor.
(WebKit::PlatformPopupMenuData::shouldPopOver):
(WebKit::PlatformPopupMenuData::hideArrows):
(WebKit::PlatformPopupMenuData::menuSize):
- Add struct member initialization.
- 7:43 PM Changeset in webkit [234780] by
-
- 3 edits2 adds in trunk
Web Inspector: console.log fires getters for deep properties
https://bugs.webkit.org/show_bug.cgi?id=187542
<rdar://problem/42873158>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Saam Barati.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(RemoteObject.prototype._isPreviewableObject):
Avoid getters/setters when checking for simple properties to preview.
Here we avoid invokingobject[property]if it could be a user getter.
LayoutTests:
- inspector/injected-script/avoid-getter-invocation-expected.txt: Added.
- inspector/injected-script/avoid-getter-invocation.html: Added.
- 7:21 PM Changeset in webkit [234779] by
-
- 4 edits in trunk/LayoutTests
LayoutTest inspector/worker/debugger-pause.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164833
<rdar://problem/29295404>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Brian Burg.
- inspector/worker/debugger-pause.html:
Add a microtask turn to ensure the workerTarget's mainResource is setup.
There were times it might not get setup, but a single turn appears
reliable enough.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
This test always passes for me in Release and Debug. Reset expectations.
- 7:01 PM Changeset in webkit [234778] by
-
- 4 edits in trunk/Source
[macOS] Multiple third party apps crash due to the thread safety check in TimerBase::setNextFireTime
https://bugs.webkit.org/show_bug.cgi?id=188480
Reviewed by Simon Fraser.
Source/WebCore:
Suppress the release assert in WebKit1 on macOS (isInWebProcess is always true in non-Cocoa platforms).
In the future, we should consider throwing Objective-C exceptions when third party apps call WebKit1
or WebKit2 APIs in non-main threads.
- platform/Timer.cpp:
(WebCore::shouldSuppressThreadSafetyCheck): Extracted out of ~TimerBase and setNextFireTime.
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):
Source/WTF:
Added the SDK version for macOS Mojave.
- wtf/spi/darwin/dyldSPI.h:
- 4:31 PM Changeset in webkit [234777] by
-
- 6 edits in trunk
Slicing an ArrayBuffer with a long number returns an ArrayBuffer with byteLength zero
https://bugs.webkit.org/show_bug.cgi?id=185127
Reviewed by Saam Barati.
JSTests:
Rebaseline the expectations.
- test262/expectations.yaml:
Source/JavaScriptCore:
Previously, we would truncate the indicies passed to slice to an
int. This meant that the value was not getting properly clamped
later.
This patch also removes a non-spec compliant check that slice was
passed at least one argument.
- runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::clampIndex const):
(JSC::ArrayBuffer::slice const):
- runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::clampValue): Deleted.
(JSC::ArrayBuffer::clampIndex const): Deleted.
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice):
- 4:03 PM Changeset in webkit [234776] by
-
- 6 edits3 adds in trunk
Crash under NetworkResourceLoader::convertToDownload()
https://bugs.webkit.org/show_bug.cgi?id=188479
<rdar://problem/42201724>
Reviewed by Alex Christensen.
Source/WebKit:
In NetworkResourceLoader::convertToDownload(), if m_networkLoad is null then we're trying
to convert a load that came from the disk cache. Since we do not currently support converting
such a load, cancel the current load and start a fresh download.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::convertToDownload):
LayoutTests:
Add layout test coverage which reproduces the crash by:
- Loading a cacheable plugin while plugins are enabled so that the plugin goes into the disk cache
- Load the plugin again with plugins disabled so that we try to convert the load to a download
- http/tests/download/convert-cached-load-to-download-expected.txt: Added.
- http/tests/download/convert-cached-load-to-download.html: Added.
- http/tests/plugins/resources/mock-plugin-cacheable.pl: Added.
- 3:59 PM Changeset in webkit [234775] by
-
- 7 edits in branches/safari-606.1.36.0-branch/Source
Versioning.
- 3:58 PM Changeset in webkit [234774] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source
Versioning.
- 3:35 PM Changeset in webkit [234773] by
-
- 1 copy in tags/Safari-606.1.36.1.4
Tag Safari-606.1.36.1.4.
- 2:55 PM Changeset in webkit [234772] by
-
- 1 copy in tags/Safari-606.1.36.0.2
Tag Safari-606.1.36.0.2.
- 2:53 PM Changeset in webkit [234771] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()
https://bugs.webkit.org/show_bug.cgi?id=188459
Reviewed by Chris Dumez.
It is unnessary for CachedFrameBase::restore() to explicitly resume animations on the
document as it calls Document::resume(), which already does this.
No functionality changed. So, no new tests.
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- 2:48 PM Changeset in webkit [234770] by
-
- 2 edits in trunk/Tools
webkit-patch setup-git-clone should set Git core editor to commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=188473
Reviewed by Ryosuke Niwa.
Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
so that the Git commit message is generated from the ChangeLog for developers that manually
generate their ChangeLog using prepare-ChangeLog.
- Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone.execute):
- 1:29 PM Changeset in webkit [234769] by
-
- 2 edits in trunk/LayoutTests
[WinCairo] More unreviewed gardening.
- platform/wincairo/TestExpectations:
- 12:51 PM Changeset in webkit [234768] by
-
- 13 edits in trunk/Source
Use OptionSet for various RenderLayer flags
https://bugs.webkit.org/show_bug.cgi?id=188472
Reviewed by Simon Fraser.
Source/WebCore:
Typesafe flags.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
(WebCore::FrameView::paintContents):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::paint):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::filterPainter const):
(WebCore::RenderLayer::hasFilterThatIsPainting const):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(RenderLayer::paintLayerByApplyingTransform):
(RenderLayer::paintList):
(RenderLayer::updatePaintingInfoForFragments):
(RenderLayer::paintTransformedLayerIntoFragments):
(RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::paintLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::paintList): Deleted.
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree const): Deleted.
(WebCore::RenderLayer::collectFragments): Deleted.
(WebCore::RenderLayer::updatePaintingInfoForFragments): Deleted.
(WebCore::RenderLayer::paintTransformedLayerIntoFragments): Deleted.
(WebCore::RenderLayer::paintBackgroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Deleted.
(WebCore::RenderLayer::paintOutlineForFragments): Deleted.
(WebCore::RenderLayer::paintMaskForFragments): Deleted.
(WebCore::RenderLayer::paintChildClippingMaskForFragments): Deleted.
(WebCore::RenderLayer::paintOverflowControlsForFragments): Deleted.
(WebCore::RenderLayer::hitTest): Deleted.
(WebCore::RenderLayer::enclosingElement const): Deleted.
(WebCore::RenderLayer::enclosingFragmentedFlowAncestor const): Deleted.
(WebCore::computeZOffset): Deleted.
(WebCore::RenderLayer::createLocalTransformState const): Deleted.
(WebCore::isHitCandidate): Deleted.
(WebCore::RenderLayer::hitTestLayer): Deleted.
(WebCore::RenderLayer::hitTestContentsForFragments const): Deleted.
(WebCore::RenderLayer::hitTestResizerInFragments const): Deleted.
(WebCore::RenderLayer::hitTestTransformedLayerInFragments): Deleted.
(WebCore::RenderLayer::hitTestLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::hitTestContents const): Deleted.
(WebCore::RenderLayer::hitTestList): Deleted.
(WebCore::RenderLayer::updateClipRects): Deleted.
(WebCore::RenderLayer::clipRects const): Deleted.
(WebCore::RenderLayer::calculateClipRects const): Deleted.
(WebCore::showLayerTree): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
- rendering/RenderLayerCompositor.h:
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint):
Source/WTF:
- wtf/MathExtras.h:
(hasOneBitSet):
(hasZeroOrOneBitsSet):
(hasTwoOrMoreBitsSet):
Make constexpr.
- wtf/OptionSet.h:
(WTF::OptionSet::OptionSet):
Always use constexpr, no need for separate debug versions with C++14.
- 12:35 PM Changeset in webkit [234767] by
-
- 6 edits in trunk/LayoutTests
[LayoutTests] Suppress warning messages generated by the test scripts.
https://bugs.webkit.org/show_bug.cgi?id=188455
Reviewed by Fujii Hironori.
The messages such as warnings shouldn't be out on error log if that can be avoidable.
- http/tests/cookies/resources/cookie-utility.php:
- http/tests/xmlhttprequest/resources/access-control-allow-lists.php:
- http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
- http/tests/xmlhttprequest/resources/post-echo.cgi:
- http/tests/xmlhttprequest/web-apps/004-test.cgi:
- 12:05 PM Changeset in webkit [234766] by
-
- 2 edits in trunk/Source/WebCore
CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
https://bugs.webkit.org/show_bug.cgi?id=188461
<rdar://problem/33555052>
Reviewed by Chris Dumez.
When we try to schedule shutdown for database, we should cancel the timer so no
scheduleShutdownForClose will be running after this.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):
- 11:56 AM Changeset in webkit [234765] by
-
- 5 edits in trunk/Tools
Unreviewed, rolling out r234749.
Caused all perf tests to fail in Sierra
Reverted changeset:
"[webkitpy][Win] LayoutTests: test names should be Unix style,
separated by slash not backslash"
https://bugs.webkit.org/show_bug.cgi?id=187973
https://trac.webkit.org/changeset/234749
- 11:23 AM Changeset in webkit [234764] by
-
- 4 edits in trunk/PerformanceTests
Add ability to ignore process prewarming for launch time benchmark
https://bugs.webkit.org/show_bug.cgi?id=188462
Patch by Ben Richards <benton_richards@apple.com> on 2018-08-10
Reviewed by Ryosuke Niwa.
Added a flag to the new tab benchmark that will open a blank tab before the tab to be measured in order to ignore process prewarming.
- LaunchTime/launch_time.py:
(DefaultLaunchTimeHandler):
(DefaultLaunchTimeHandler.on_receive_stop_time): Deleted.
(DefaultLaunchTimeHandler.on_receive_stop_signal):
(DefaultLaunchTimeHandler.do_HEAD):
(DefaultLaunchTimeHandler.do_GET):
(DefaultLaunchTimeHandler.do_POST):
(LaunchTimeBenchmark):
(LaunchTimeBenchmark._standard_deviation): Fixed divide by zero bug when '-n' is set to 1
(LaunchTimeBenchmark.open_tab): Added option to open a blank tab
(LaunchTimeBenchmark.run):
- LaunchTime/new_tab.py:
(NewTabBenchmark.initialize):
(NewTabBenchmark.run_iteration):
(NewTabBenchmark.will_parse_arguments):
(NewTabBenchmark.did_parse_arguments):
(NewTabBenchmark.ResponseHandler.Handler.get_test_page):
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(NewTabBenchmark):
- LaunchTime/startup.py:
(StartupBenchmark.ResponseHandler.Handler.get_test_page):
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(StartupBenchmark):
- 10:42 AM Changeset in webkit [234763] by
-
- 5 edits2 adds in trunk
Date.UTC should not return NaN with only Year param
https://bugs.webkit.org/show_bug.cgi?id=188378
Reviewed by Keith Miller.
JSTests:
- ChakraCore.yaml:
- ChakraCore/test/Date/dateutc.baseline-jsc: Added.
- stress/date-utc-optional.js: Added.
(shouldBe):
- test262/expectations.yaml:
Source/JavaScriptCore:
Date.UTC requires one argument for |year|. But the other ones are optional.
This patch fix this handling.
- runtime/DateConstructor.cpp:
(JSC::millisecondsFromComponents):
- 10:39 AM Changeset in webkit [234762] by
-
- 3 edits5 adds in trunk
Once <object> is hidden, its content won't be displayed again if its URL has fragment identifier ("#").
https://bugs.webkit.org/show_bug.cgi?id=187990
Reviewed by Simon Fraser.
Source/WebCore:
Fixes an issue where an HTML object element that behaves like an iframe and references a resource
whose URL contains a fragment would not be repainted when its CSS display property changes.
Rendering of an <object> that behaves like an iframe is handled by a widget (FrameView). When
the CSS display property for an <object> is set to "none" we detach the widget from its renderer
as part of destroying the render tree for the <object>. Subsequently changing the CSS display
to a non-"none"/"contents" value will create a new renderer for <object> R. For an <object> that
behaves like an iframe, we navigate to the resource associated with the <object> reusing the
existing Frame F object created when we first displayed the <object>. Unlike the case where
the URL of the resource does not contain a fragment, navigating to a fragment in the same document
uses a different code path that does not re-associate the FrameView of F with R before it scrolls
the view; => the FrameView of F is not in the view hierarchy. Therefore we do not paint anything
for the content of the <object> and hence the scroll is not observable. Instead we need to ensure
that the FrameView of F installed in the view hierarchy when navigating to an anchor in the same
document.
As a side benefit of this fix we now also repaint an <object> that is programmatically navigated
to a different anchor in the same document.
Tests: fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html
fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
LayoutTests:
Add tests to ensure that we repaint an <object>, whose resource URL contains a fragment, when
its CSS display property changes as well as when its navigated to a different anchor in the same
document.
- fast/repaint/object-as-iframe-hide-and-show-document-at-anchor-expected.txt: Added.
- fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html: Added.
- fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint-expected.txt: Added.
- fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html: Added.
- fast/repaint/resources/red-square-on-top-of-green-square.html: Added.
- 10:08 AM Changeset in webkit [234761] by
-
- 10 edits in trunk
[IntersectionObserver] Implement rootMargin parsing
https://bugs.webkit.org/show_bug.cgi?id=188469
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update expectations for newly passing test cases.
- web-platform-tests/intersection-observer/observer-attributes-expected.txt:
- web-platform-tests/intersection-observer/observer-exceptions-expected.txt:
Source/WebCore:
Parse IntersectionObserver's rootMargin argument and throw an exception if it's invalid.
Change the stored rootMargin from a String to a LengthBox so that future patches can
use this value in intersection logic.
Tested by: imported/w3c/web-platform-tests/intersection-observer/observer-attributes.html
imported/w3c/web-platform-tests/intersection-observer/observer-exceptions.html
intersection-observer/intersection-observer-interface.html
- page/IntersectionObserver.cpp:
(WebCore::parseRootMargin):
(WebCore::IntersectionObserver::create):
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::rootMargin const):
- page/IntersectionObserver.h:
(WebCore::IntersectionObserver::create): Deleted.
(WebCore::IntersectionObserver::rootMargin const): Deleted.
- page/IntersectionObserver.idl:
LayoutTests:
- intersection-observer/intersection-observer-interface-expected.txt:
- intersection-observer/intersection-observer-interface.html:
- 9:46 AM Changeset in webkit [234760] by
-
- 10 edits in branches/safari-606.1.36.0-branch
Cherry-pick r234730. rdar://problem/43144157
REGRESSION (r232083): WKWebView loses first-party cookies on iOS
https://bugs.webkit.org/show_bug.cgi?id=188443
<rdar://problem/42991584>
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-08-09
Reviewed by Chris Dumez.
Source/WebKit:
Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::platformInitializeNetworkProcess):
Tools:
Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:45 AM Changeset in webkit [234759] by
-
- 2 edits in trunk/Source/WebKit
Incorrect log message in NetworkSession when creating NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=188463
Reviewed by Chris Dumez.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- 9:31 AM Changeset in webkit [234758] by
-
- 2 edits in trunk/Tools
Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
https://bugs.webkit.org/show_bug.cgi?id=188470.
Unreviewed test gardening, disabling the tests.
- TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):
- 9:26 AM Changeset in webkit [234757] by
-
- 4 edits in trunk/PerformanceTests
Unreviewed, rolling out r234750.
Caused 185 perf test failures.
Reverted changeset:
"Add ability to ignore process prewarming for launch time
benchmark"
https://bugs.webkit.org/show_bug.cgi?id=188462
https://trac.webkit.org/changeset/234750
- 9:10 AM Changeset in webkit [234756] by
-
- 7 edits in trunk
Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
https://bugs.webkit.org/show_bug.cgi?id=188458
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Alex Christensen.
Tools:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 9:02 AM Changeset in webkit [234755] by
-
- 2 edits in branches/safari-606.1.36.1-branch/Tools
Cherry-pick r234734. rdar://problem/42387347
REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
https://bugs.webkit.org/show_bug.cgi?id=188397
Reviewed by Tim Horton.
After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@234734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:52 AM Changeset in webkit [234754] by
-
- 2 edits in branches/safari-606-branch/Tools
Cherry-pick r234734. rdar://problem/42387347
REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
https://bugs.webkit.org/show_bug.cgi?id=188397
Reviewed by Tim Horton.
After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@234734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:17 AM Changeset in webkit [234753] by
-
- 4 edits in trunk/Source/WebDriver
[GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
https://bugs.webkit.org/show_bug.cgi?id=188465
Reviewed by Žan Doberšek.
We only want to use --automation when no options or no browser binary is provided, because we fallback to
MiniBrowser and we know it needs --automation flag.
- glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::launchBrowser): Handle the case of browser arguments being std::nullopt.
- gtk/WebDriverServiceGtk.cpp:
(WebDriver::WebDriverService::platformParseCapabilities const): Initialize browser arguments to std:nullopt if
browser binary was provided.
- wpe/WebDriverServiceWPE.cpp:
(WebDriver::WebDriverService::platformParseCapabilities const): Ditto.
- 12:57 AM Changeset in webkit [234752] by
-
- 4 edits21 adds in trunk/LayoutTests
[WinCairo] Unreviewed layout test gardening.
- platform/wincairo/TestExpectations:
- platform/wincairo/editing/selection/5057506-expected.png: Added.
- platform/wincairo/editing/selection/caret-ltr-right-expected.txt:
- platform/wincairo/editing/selection/caret-rtl-right-expected.txt:
- platform/wincairo/editing/selection/doubleclick-crash-expected.txt: Added.
- platform/wincairo/editing/selection/editable-links-expected.txt: Added.
- platform/wincairo/editing/selection/extend-by-character-006-expected.txt: Added.
- platform/wincairo/editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/wincairo/editing/selection/extend-by-word-001-expected.txt: Added.
- platform/wincairo/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
- platform/wincairo/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
- platform/wincairo/editing/selection/extend-selection-bidi-expected.txt: Added.
- platform/wincairo/editing/selection/focus-body-expected.txt: Added.
- platform/wincairo/editing/selection/move-by-line-001-expected.txt: Added.
- platform/wincairo/editing/selection/move-by-word-001-expected.txt: Added.
- platform/wincairo/editing/selection/select-all-001-expected.txt: Added.
- platform/wincairo/editing/selection/select-all-002-expected.txt: Added.
- platform/wincairo/editing/selection/select-all-003-expected.txt: Added.
- platform/wincairo/editing/selection/select-all-004-expected.txt: Added.
- platform/wincairo/editing/selection/unrendered-001-expected.txt: Added.
- platform/wincairo/editing/selection/unrendered-002-expected.txt: Added.
- platform/wincairo/editing/selection/unrendered-003-expected.txt: Added.
- platform/wincairo/editing/selection/unrendered-004-expected.txt: Added.
- platform/wincairo/editing/selection/unrendered-005-expected.txt: Added.
Aug 9, 2018:
- 10:13 PM Changeset in webkit [234751] by
-
- 3 edits in trunk/LayoutTests
[LayoutTests] Test case which committed on r175053 was wrong.
https://bugs.webkit.org/show_bug.cgi?id=188454
Reviewed by Fujii Hironori.
It was originally committed on https://bugs.webkit.org/show_bug.cgi?id=136938 and has kept unchanged,
but the test case uses non-existing redirect.php scripts which was removed a few months before than
this bug. Also result was compared to wrong values.
- http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:
- http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html:
- 9:53 PM Changeset in webkit [234750] by
-
- 4 edits in trunk/PerformanceTests
Add ability to ignore process prewarming for launch time benchmark
https://bugs.webkit.org/show_bug.cgi?id=188462
Patch by Ben Richards <benton_richards@apple.com> on 2018-08-09
Reviewed by Ryosuke Niwa.
Added a flag to the new tab benchmark that will open a blank tab before the tab to be measured in order to ignore process prewarming.
- LaunchTime/launch_time.py:
(DefaultLaunchTimeHandler):
(DefaultLaunchTimeHandler.on_receive_stop_time): Deleted.
(DefaultLaunchTimeHandler.on_receive_stop_signal):
(DefaultLaunchTimeHandler.do_HEAD):
(DefaultLaunchTimeHandler.do_GET):
(DefaultLaunchTimeHandler.do_POST):
(LaunchTimeBenchmark):
(LaunchTimeBenchmark._standard_deviation): Fixed divide by zero bug when '-n' is set to 1
(LaunchTimeBenchmark.open_tab): Added option to open a blank tab
(LaunchTimeBenchmark.run):
- LaunchTime/new_tab.py:
(NewTabBenchmark.initialize):
(NewTabBenchmark.run_iteration):
(NewTabBenchmark.will_parse_arguments):
(NewTabBenchmark.did_parse_arguments):
(NewTabBenchmark.ResponseHandler.Handler.get_test_page):
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(NewTabBenchmark):
- LaunchTime/startup.py:
(StartupBenchmark.ResponseHandler.Handler.get_test_page):
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(StartupBenchmark):
- 7:13 PM Changeset in webkit [234749] by
-
- 5 edits in trunk/Tools
[webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
https://bugs.webkit.org/show_bug.cgi?id=187973
Reviewed by Alex Christensen.
In LayoutTests, test names have been canonicalized in Unix style
since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
Bug 179572, Bug 180660 and Bug 181814 have changed to use
os.path.seq instead of slash if Windows Python is used.
Revert parts of those changes. Change relative_test_filename to
return a slash sperated test name as well as chromium_win.py used
to do.
This change fixes all 41 test-webkitpy failures in WinCairo port.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_line): Do not convert a test name by using normpath.
- Scripts/webkitpy/port/base.py:
(Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
(Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
(Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
- Scripts/webkitpy/port/driver.py:
(Driver): Use '/' instead of os.sep.
- Scripts/webkitpy/port/win.py:
(WinCairoPort): Do not override TEST_PATH_SEPARATOR.
- 6:18 PM Changeset in webkit [234748] by
-
- 2 edits in trunk/Tools
[WHLSL] Add individual test durations to output
https://bugs.webkit.org/show_bug.cgi?id=188448
Patch by Thomas Denney <tdenney@apple.com> on 2018-08-09
Reviewed by Myles C. Maxfield.
- WebGPUShadingLanguageRI/Test.js: Add timing output.
- 5:28 PM Changeset in webkit [234747] by
-
- 23 edits5 adds in trunk
We should cache the compiled sandbox profile in a data vault
https://bugs.webkit.org/show_bug.cgi?id=184991
Patch by Ben Richards <benton_richards@apple.com> on 2018-08-09
Reviewed by Ryosuke Niwa.
Source/WebCore:
Added functionality to FileHandle so that it can lock a file while open.
Added a function to FileSystem to delete non empty directories.
- platform/FileHandle.cpp:
(WebCore::FileHandle::FileHandle):
(WebCore::FileHandle::open):
(WebCore::FileHandle::close):
- platform/FileHandle.h:
- platform/FileSystem.h:
- platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::deleteNonEmptyDirectory):
Source/WebKit:
This patch changes a few things (note: data vaults and sandbox entitlements are only used in internal builds):
(1) Instead of compiling a sandbox every time a process is launched, processes now look for a cached sandbox
in a process specific data vault on macOS platforms. (ChildProcessMac.mm)
(2) If a valid cached sandbox is not found, a process will create the data vault (or ensure that it exists),
compile a sandbox, and cache it.
(3) In order to create process specific data vaults, each process now has their own <process name>-OSX-sandbox.entitlements
file which contains an entitlement with a process specific "storage class" which ensures that each process
can only ever access its own data vault. (See the article on confluence "Data Vaults and Restricted Files" for more info)
(4) The sandbox entitlements file for the Network, WebContent and Plugin services are loaded dynamically
through Scripts/<process name>-process-entitlements.sh which is triggered in a new build phase for each service.
The Storage process sandbox entitlements are loaded directly in Configurations/StorageService.xcconfig.
The reason that the sandbox entitlements are applied dynamically is so that these sandbox entitlements
are only applied when WK_USE_RESTRICTED_ENTITLEMENTS is YES. This means that open source builds will still work.
- Configurations/Network-OSX-sandbox.entitlements: Added.
- Configurations/Storage-OSX-sandbox.entitlements: Added.
- Configurations/StorageService.xcconfig:
- Configurations/WebContent-OSX-sandbox.entitlements: Added.
- Configurations/WebKit.xcconfig:
- NetworkProcess/NetworkProcess.h:
- PluginProcess/PluginProcess.h:
- Scripts/process-network-sandbox-entitlements.sh: Added.
- Scripts/process-webcontent-sandbox-entitlements.sh: Added.
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- Shared/SandboxInitializationParameters.h:
(WebKit::SandboxInitializationParameters::setOverrideSandboxProfilePath):
(WebKit::SandboxInitializationParameters::overrideSandboxProfilePath const):
(WebKit::SandboxInitializationParameters::setSandboxProfile):
(WebKit::SandboxInitializationParameters::sandboxProfile const):
(): Deleted.
- Shared/mac/ChildProcessMac.mm:
(WebKit::SandboxProfileDeleter::operator()):
(WebKit::SandboxParametersDeleter::operator()):
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::fileContents):
(WebKit::processStorageClass):
(WebKit::setAndSerializeSandboxParameters):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::sandboxDirectory):
(WebKit::sandboxFilePath):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::writeSandboxDataToCacheFile):
(WebKit::compileAndCacheSandboxProfile):
(WebKit::tryApplyCachedSandbox):
(WebKit::webKit2Bundle):
(WebKit::sandboxProfilePath):
(WebKit::compileAndApplySandboxSlowCase):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::ChildProcess::initializeSandbox):
- Shared/mac/SandboxInitialiationParametersMac.mm:
(WebKit::SandboxInitializationParameters::SandboxInitializationParameters):
- StorageProcess/StorageProcess.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.h:
Source/WTF:
Added trace points for sandbox initialization and exposed functions needed for sandbox caching
- wtf/SystemTracing.h:
- wtf/spi/darwin/SandboxSPI.h:
Tools:
Added trace points for sandbox initialization
- Tracing/SystemTracePoints.plist:
- 5:20 PM Changeset in webkit [234746] by
-
- 4 edits in trunk/LayoutTests
Remove ElCapitan specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=188457
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-09
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:18 PM Changeset in webkit [234745] by
-
- 2 edits4 adds in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188456
Unreviewed test gardening.
Unskip http/xmlhttprequest.
- platform/wincairo/TestExpectations:
- platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.png: Added.
- platform/wincairo/http/tests/multipart/invalid-image-data-expected.png: Added.
- platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
- platform/wincairo/http/tests/uri/css-href-expected.png: Added.
- 4:56 PM Changeset in webkit [234744] by
-
- 4 edits in trunk/Source/WebCore
InputType should not interact with an HTMLInputElement is no longer associated with
https://bugs.webkit.org/show_bug.cgi?id=188410
Reviewed by Ryosuke Niwa.
Clear InputType::m_element when the InputType is no longer associated with the HTMLInputElement
because the element changed type. We were already dealing with the InputType no longer being
associated with an element because the element died by using a WeakPtr. However, it is conceptually
better (more correct) to also clear this pointer if the element is still alive but associated with
another InputType.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/InputType.h:
(WebCore::InputType::detachFromElement):
- 4:49 PM Changeset in webkit [234743] by
-
- 12 edits4 adds in trunk
Video playback is using more power
https://bugs.webkit.org/show_bug.cgi?id=188452
Source/WebCore:
<rdar://problem/42298937>
Reviewed by Eric Carlson.
Test: TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm
When the meaning of PlatformMediaSession::Video changed to "video-only", we failed to update
MediaSessionManagerCocoa::updateSessionState() to use the new PlatformMediaSession::VideoAudio
enum, so Video-only sessions were getting the higher audio buffer size (where it's not needed)
and Video-and-Audio sessions were getting the default value.
To enable testing, add a preferredAudioBufferSize property to Internals. Also, the getter for
AudioSession::preferredBufferSize was using the wrong CoreAudio property address, and was
always returning 0.
- platform/audio/AudioSession.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(MediaSessionManagerCocoa::updateSessionState):
- platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::preferredBufferSize const):
- testing/Internals.cpp:
(WebCore::Internals::preferredAudioBufferSize const):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Reviewed by Eric Carlson.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setLowPowerVideoAudioBufferSizeEnabled:]):
(-[WKPreferences _lowPowerVideoAudioBufferSizeEnabled]):
Tools:
<rdar://problem/42298937>
Reviewed by Eric Carlson.
- TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(PreferredAudioBufferSize::createView):
(PreferredAudioBufferSize::preferredAudioBufferSize const):
(TEST_F):
- 4:30 PM Changeset in webkit [234742] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=188357
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:07 PM Changeset in webkit [234741] by
-
- 2 edits in trunk/Source/WebKit
Fix URLSchemeHandler.SyncXHR API test after r234735.
https://bugs.webkit.org/show_bug.cgi?id=188358
- UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
Return after appending data for synchronous loads. We used to send unused messages.
- 3:51 PM Changeset in webkit [234740] by
-
- 4 edits in tags/Safari-607.1.2
Cherry-pick r234739. rdar://problem/43102553
REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
https://bugs.webkit.org/show_bug.cgi?id=188453
<rdar://problem/43102553>
Source/WebKit:
Reviewed by Chris Dumez.
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::beginSafeBrowsingCheck):
Tools:
Reviewed by Chris Dumez
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (TEST): (+[NullLookupContext sharedLookupContext]): (TestWebKitAPI::TEST): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:37 PM Changeset in webkit [234739] by
-
- 4 edits in trunk
REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
https://bugs.webkit.org/show_bug.cgi?id=188453
<rdar://problem/43102553>
Source/WebKit:
Reviewed by Chris Dumez.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
Tools:
Reviewed by Chris Dumez
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
(+[NullLookupContext sharedLookupContext]):
(TestWebKitAPI::TEST): Deleted.
- 3:03 PM Changeset in webkit [234738] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source
Versioning.
- 2:53 PM Changeset in webkit [234737] by
-
- 1 copy in tags/Safari-606.1.36.1.3
Tag Safari-606.1.36.1.3.
- 2:47 PM Changeset in webkit [234736] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light
https://bugs.webkit.org/show_bug.cgi?id=188126
<rdar://problem/42674963>
Reviewed by Matt Baker.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.source-code.text-editor > .CodeMirror .issue-widget.warning,): Added.
(.source-code.text-editor > .CodeMirror .issue-widget.error,): Added.
- 2:43 PM Changeset in webkit [234735] by
-
- 5 edits in trunk
WKURLSchemeHandler crashes when sent errors with sync XHR
https://bugs.webkit.org/show_bug.cgi?id=188358
Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-09
Reviewed by Chris Dumez.
Source/WebKit:
- UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
(WebKit::WebURLSchemeTask::didComplete):
- UIProcess/WebURLSchemeTask.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
(-[SyncErrorScheme webView:startURLSchemeTask:]):
(-[SyncErrorScheme webView:stopURLSchemeTask:]):
(-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
- 1:43 PM Changeset in webkit [234734] by
-
- 2 edits in trunk/Tools
REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
https://bugs.webkit.org/show_bug.cgi?id=188397
Reviewed by Tim Horton.
After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.
- WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):
- 1:13 PM Changeset in webkit [234733] by
-
- 9 edits in trunk/Source
memoryFootprint should return size_t not optional<size_t>
https://bugs.webkit.org/show_bug.cgi?id=188444
Reviewed by Simon Fraser.
Source/WebCore:
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::ResourceUsageOverlay::platformDraw):
Source/WTF:
We're now going to return zero instead of returning nullopt on failure.
There was a lot of code dancing around memoryFootprint failing for no
good reason.
Users of this API were previously doing this on failure:
- Treating it as zero (this was the most common user).
- Crashing.
- Bailing out early and not changing our memory pressure state. This change
has the effect that instead of not changing our memory pressure state on
failure, we will go back to thinking we're not under memory pressure. Since
we relied on this API not failing to do anything useful (like kill the process
or release memory), this won't change our behavior here in a meaningful way.
- wtf/MemoryFootprint.h:
- wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::currentMemoryUsagePolicy):
(WTF::MemoryPressureHandler::shrinkOrDie):
(WTF::MemoryPressureHandler::measurementTimerFired):
- wtf/cocoa/MemoryFootprintCocoa.cpp:
(WTF::memoryFootprint):
- wtf/linux/MemoryFootprintLinux.cpp:
(WTF::memoryFootprint):
- wtf/linux/MemoryPressureHandlerLinux.cpp:
(WTF::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
- wtf/win/MemoryFootprintWin.cpp:
(WTF::memoryFootprint):
- 12:36 PM Changeset in webkit [234732] by
-
- 7 edits in trunk
Update IDL for IntersectionObserverEntry and IntersectionObserverEntryInit
https://bugs.webkit.org/show_bug.cgi?id=188445
Reviewed by Simon Fraser.
Source/WebCore:
Update IntersectionObserverEntry by making rootBounds nullable, and adding an
isIntersecting attribute. Make the same changes to IntersectionObserverEntryInit,
and also add an intersectionRatio attribute.
Tested by intersection-observer/intersection-observer-entry-interface.html
- page/IntersectionObserverEntry.cpp:
(WebCore::IntersectionObserverEntry::IntersectionObserverEntry):
- page/IntersectionObserverEntry.h:
(WebCore::IntersectionObserverEntry::isIntersecting const):
- page/IntersectionObserverEntry.idl:
LayoutTests:
- intersection-observer/intersection-observer-entry-interface-expected.txt:
- intersection-observer/intersection-observer-entry-interface.html:
- 12:02 PM Changeset in webkit [234731] by
-
- 4 edits3 moves1 add in trunk/Tools
[iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
https://bugs.webkit.org/show_bug.cgi?id=188439
Reviewed by Andy Estes and Megan Gardner.
Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
DragAndDropTests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
(testIconImage):
(testZIPArchive):
(-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
(-[TestWKWebView editorContainsImageElement]):
(-[TestWKWebView editorValue]):
(makeCGRectValue):
(checkCGRectIsEqualToCGRectWithLogging):
(checkSelectionRectsWithLogging):
(checkRichTextTypePrecedesPlainTextType):
(checkFirstTypeIsPresentAndSecondTypeIsMissing):
(checkTypeIdentifierIsRegisteredAtIndex):
(checkEstimatedSize):
(checkSuggestedNameAndEstimatedSize):
(checkStringArraysAreEqual):
(checkDragCaretRectIsContainedInRect):
(checkJSONWithLogging):
(testIconImageData):
(runTestWithTemporaryTextFile):
(runTestWithTemporaryFolder):
(TestWebKitAPI::TEST):
(TestWebKitAPI::setUpTestWebViewForDataTransferItems):
(TestWebKitAPI::testDragAndDropOntoTargetElements):
(TestWebKitAPI::testIconImageData):
- TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
(-[WKWebView dropInteractionDelegate]):
(-[WKWebView dragInteractionDelegate]):
(-[WKWebView dropInteraction]):
(-[WKWebView dragInteraction]):
(-[MockDragDropSession initWithItems:location:window:allowMove:]):
(-[MockDragDropSession allowsMoveOperation]):
(-[MockDragDropSession isRestrictedToDraggingApplication]):
(-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
(-[MockDragDropSession canLoadObjectsOfClass:]):
(-[MockDragDropSession canLoadObjectsOfClasses:]):
(-[MockDragDropSession items]):
(-[MockDragDropSession setItems:]):
(-[MockDragDropSession addItems:]):
(-[MockDragDropSession locationInView:]):
(-[MockDropSession initWithProviders:location:window:allowMove:]):
(-[MockDropSession isLocal]):
(-[MockDropSession progress]):
(-[MockDropSession setProgressIndicatorStyle:]):
(-[MockDropSession progressIndicatorStyle]):
(-[MockDropSession operationMask]):
(-[MockDropSession localDragSession]):
(-[MockDropSession hasItemsConformingToTypeIdentifier:]):
(-[MockDropSession canCreateItemsOfClass:]):
(-[MockDropSession loadObjectsOfClass:completion:]):
(-[MockDragSession initWithWindow:allowMove:]):
(-[MockDragSession localOperationMask]):
(-[MockDragSession externalOperationMask]):
(-[MockDragSession session]):
(-[MockDragSession localContext]):
(-[MockDragSession setLocalContext:]):
(dragAndDropEventNames):
(-[DragAndDropSimulatorApplication _cancelAllTouches]):
(-[DragAndDropSimulator initWithWebView:]):
(-[DragAndDropSimulator dealloc]):
(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator observedEventNames]):
(-[DragAndDropSimulator simulateAllTouchesCanceled:]):
(-[DragAndDropSimulator runFrom:to:]):
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator finalSelectionRects]):
(-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
(-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
(-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
(-[DragAndDropSimulator _advanceProgress]):
(-[DragAndDropSimulator _currentLocation]):
(-[DragAndDropSimulator _scheduleAdvanceProgress]):
(-[DragAndDropSimulator sourceItemProviders]):
(-[DragAndDropSimulator externalItemProviders]):
(-[DragAndDropSimulator setExternalItemProviders:]):
(-[DragAndDropSimulator phase]):
(-[DragAndDropSimulator liftPreviews]):
(-[DragAndDropSimulator lastKnownDragCaretRect]):
(-[DragAndDropSimulator waitForInputSession]):
(-[DragAndDropSimulator insertedAttachments]):
(-[DragAndDropSimulator removedAttachments]):
(-[DragAndDropSimulator endDataTransfer]):
(-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
(-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
(-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
(-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
(-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
(-[DragAndDropSimulator _webView:didInsertAttachment:]):
(-[DragAndDropSimulator _webView:didRemoveAttachment:]):
(-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
(-[DragAndDropSimulator _webView:didStartInputSession:]):
- TestWebKitAPI/ios/UIKitSPI.h:
- TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
(-[DragAndDropSimulator initWithWebView:]):
(-[DragAndDropSimulator dealloc]):
(-[DragAndDropSimulator runFrom:to:]):
(-[DragAndDropSimulator insertedAttachments]):
(-[DragAndDropSimulator removedAttachments]):
- 11:48 AM Changeset in webkit [234730] by
-
- 10 edits in trunk
REGRESSION (r232083): WKWebView loses first-party cookies on iOS
https://bugs.webkit.org/show_bug.cgi?id=188443
<rdar://problem/42991584>
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-08-09
Reviewed by Chris Dumez.
Source/WebKit:
Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
Tools:
Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
- 11:18 AM Changeset in webkit [234729] by
-
- 7 edits2 adds in branches/safari-606.1.36.1-branch
Cherry-pick r234718. rdar://problem/43102434
REGRESSION (r228260): Events handled by input method invoke default event handler
https://bugs.webkit.org/show_bug.cgi?id=188370
Reviewed by Wenson Hsieh.
Source/WebCore:
The bug was caused by the default event handler being invoked for the "virtual" keydown events
generated for input methods. Namely, when Japanese or Chinese input methods swallows TAB key,
WebKit should not invoke the default event handler and move the focus during input composition.
Fixed the bug by adding a new boolean on Event indicating whether the default event handler
should be invoked, and restoring the behavior prior to r228260 for these virtual keydown events.
Test: editing/input/press-tab-during-ime-composition.html
- dom/Event.h: (WebCore::Event::isDefaultEventHandlerIgnored const): Added. (WebCore::Event::setIsDefaultEventHandlerIgnored): Added.
- dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Don't invoke the default event handler if isDefaultEventHandlerIgnored is set.
- page/EventHandler.cpp: (WebCore::EventHandler::internalKeyEvent): Set isDefaultEventHandlerIgnored. This restores WebKit's behavior prior to r228260.
LayoutTests:
Added a regression test. Due to the lack of adequate support of textInputController in WebKitTestRunner,
the test is only enabled in WebKit1. The WTR fix is tracked by https://webkit.org/b/188428.
- editing/input/press-tab-during-ime-composition-expected.txt: Added.
- editing/input/press-tab-during-ime-composition.html: Added.
- platform/ios/TestExpectations:
- platform/wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 AM Changeset in webkit [234728] by
-
- 9 edits in trunk
Array.prototype.sort should call @toLength instead of ">>> 0"
https://bugs.webkit.org/show_bug.cgi?id=188430
Reviewed by Saam Barati.
JSTests:
- test262/expectations.yaml:
Source/JavaScriptCore:
Also add a new function to $vm that will fetch a private
property. This can be useful for running builtin helper functions.
- builtins/ArrayPrototype.js:
(sort):
- tools/JSDollarVM.cpp:
(JSC::functionGetPrivateProperty):
(JSC::JSDollarVM::finishCreation):
LayoutTests:
Remove invalid conformance test expectations. Array.prototype.sort calls toLength, which
does not truncate integers.
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T1.html:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T2.html:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.11_Array_prototype_sort/S15.4.4.11_A4_T3.html:
- 10:47 AM Changeset in webkit [234727] by
-
- 2 edits in tags/Safari-607.1.2/Source/WebCore
Cherry-pick r234717. rdar://problem/43075662
Prevent collectScreenProperties from crashing Base System
https://bugs.webkit.org/show_bug.cgi?id=188429
<rdar://problem/43075662>
Patch by Justin Fan <Justin Fan> on 2018-08-08
Reviewed by Simon Fraser.
Adding some error-checking and early returns to further prevent calling CGLDescribeRenderer with invalid parameters.
Existing WebGL tests should cover; no expected change in behavior. Crash happened primarily on Base System.
- platform/mac/PlatformScreenMac.mm: (WebCore::gpuIDForDisplayMask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:24 AM Changeset in webkit [234726] by
-
- 2 edits in trunk/Tools
Unreviewed follow-up fix for r234720.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.close_and_remove):
(BindingsTests.main):
Return to the original approach, since this seems to be the simplest cross-platform solution.
- 8:49 AM Changeset in webkit [234725] by
-
- 3 edits in trunk/Source/WebKit
DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
https://bugs.webkit.org/show_bug.cgi?id=186683
Reviewed by Brent Fulgham.
Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer.
Having a RefPtr could in theory create reference cycles. This potential problem has not been
observed in practice, but it is safer to use a weak pointer.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/DrawingAreaMac.cpp:
(WebKit::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::requestRefreshCallback):
- 7:37 AM WebKitGTK/Gardening/Calendar/2018Logs edited by
- (diff)
- 7:01 AM Changeset in webkit [234724] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK+ gardening after r234720.
- platform/gtk/TestExpectations:
- platform/gtk/http/tests/inspector/network/xhr-response-body-expected.txt:
- 6:36 AM Changeset in webkit [234723] by
-
- 9 edits66 adds in trunk
Import WPTs for IntersectionObserver
https://bugs.webkit.org/show_bug.cgi?id=188416
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/intersection-observer/META.yml: Added.
- web-platform-tests/intersection-observer/bounding-box-expected.txt: Added.
- web-platform-tests/intersection-observer/bounding-box.html: Added.
- web-platform-tests/intersection-observer/client-rect-expected.txt: Added.
- web-platform-tests/intersection-observer/client-rect.html: Added.
- web-platform-tests/intersection-observer/containing-block-expected.txt: Added.
- web-platform-tests/intersection-observer/containing-block.html: Added.
- web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Added.
- web-platform-tests/intersection-observer/cross-origin-iframe.html: Added.
- web-platform-tests/intersection-observer/disconnect-expected.txt: Added.
- web-platform-tests/intersection-observer/disconnect.html: Added.
- web-platform-tests/intersection-observer/display-none-expected.txt: Added.
- web-platform-tests/intersection-observer/display-none.html: Added.
- web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt: Added.
- web-platform-tests/intersection-observer/edge-inclusive-intersection.html: Added.
- web-platform-tests/intersection-observer/idlharness.window-expected.txt: Added.
- web-platform-tests/intersection-observer/idlharness.window.html: Added.
- web-platform-tests/intersection-observer/idlharness.window.js: Added.
(idl_array.self.observer.new.IntersectionObserver):
- web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Added.
- web-platform-tests/intersection-observer/iframe-no-root.html: Added.
- web-platform-tests/intersection-observer/inline-client-rect-expected.txt: Added.
- web-platform-tests/intersection-observer/inline-client-rect.html: Added.
- web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt: Added.
- web-platform-tests/intersection-observer/isIntersecting-change-events.html: Added.
- web-platform-tests/intersection-observer/multiple-targets-expected.txt: Added.
- web-platform-tests/intersection-observer/multiple-targets.html: Added.
- web-platform-tests/intersection-observer/multiple-thresholds-expected.txt: Added.
- web-platform-tests/intersection-observer/multiple-thresholds.html: Added.
- web-platform-tests/intersection-observer/observer-attributes-expected.txt: Added.
- web-platform-tests/intersection-observer/observer-attributes.html: Added.
- web-platform-tests/intersection-observer/observer-exceptions-expected.txt: Added.
- web-platform-tests/intersection-observer/observer-exceptions.html: Added.
- web-platform-tests/intersection-observer/observer-in-iframe.html: Added.
- web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt: Added.
- web-platform-tests/intersection-observer/observer-without-js-reference.html: Added.
- web-platform-tests/intersection-observer/remove-element-expected.txt: Added.
- web-platform-tests/intersection-observer/remove-element.html: Added.
- web-platform-tests/intersection-observer/resources/cross-origin-subframe.html: Added.
- web-platform-tests/intersection-observer/resources/iframe-no-root-subframe.html: Added.
- web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js: Added.
(waitForNotification):
(runTestCycle):
(contentBounds):
(borderBoxBounds):
(clientBounds):
(rectArea):
(checkRect):
(checkLastEntry):
(checkJsonEntry):
(checkJsonEntries):
- web-platform-tests/intersection-observer/resources/observer-in-iframe-subframe.html: Added.
- web-platform-tests/intersection-observer/resources/timestamp-subframe.html: Added.
- web-platform-tests/intersection-observer/resources/w3c-import.log: Added.
- web-platform-tests/intersection-observer/root-margin-expected.txt: Added.
- web-platform-tests/intersection-observer/root-margin.html: Added.
- web-platform-tests/intersection-observer/same-document-no-root-expected.txt: Added.
- web-platform-tests/intersection-observer/same-document-no-root.html: Added.
- web-platform-tests/intersection-observer/same-document-root-expected.txt: Added.
- web-platform-tests/intersection-observer/same-document-root.html: Added.
- web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt: Added.
- web-platform-tests/intersection-observer/same-document-zero-size-target.html: Added.
- web-platform-tests/intersection-observer/shadow-content-expected.txt: Added.
- web-platform-tests/intersection-observer/shadow-content.html: Added.
- web-platform-tests/intersection-observer/text-target-expected.txt: Added.
- web-platform-tests/intersection-observer/text-target.html: Added.
- web-platform-tests/intersection-observer/timestamp-expected.txt: Added.
- web-platform-tests/intersection-observer/timestamp.html: Added.
- web-platform-tests/intersection-observer/unclipped-root-expected.txt: Added.
- web-platform-tests/intersection-observer/unclipped-root.html: Added.
- web-platform-tests/intersection-observer/w3c-import.log: Added.
- web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt: Added.
- web-platform-tests/intersection-observer/zero-area-element-hidden.html: Added.
- web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt: Added.
- web-platform-tests/intersection-observer/zero-area-element-visible.html: Added.
Source/WebKit:
Make IntersectionObserver an experimental feature, so that it is enabled in
WebKitTestRunner.
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferencesPrivate.h:
Tools:
Enable IntersectionObserver in DumpRenderTree.
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 5:00 AM Changeset in webkit [234722] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK+ and WPE gardening. Add a reftest failure expectation.
Update a WPT EME test baseline for the WPE port.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:
- 4:50 AM Changeset in webkit [234721] by
-
- 3 edits in trunk/Source/WebCore
Fix copyright headers on new ISO parsing class
https://bugs.webkit.org/show_bug.cgi?id=188432
Unreviewed fix.
This was left off from a previous bug by mistake, retrospectively
adding the correct copyright headers.
No tests required.
- platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:
- platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h:
Aug 8, 2018:
- 10:42 PM Changeset in webkit [234720] by
-
- 4 edits in trunk
run-bindings-tests is not Win32-compatible
https://bugs.webkit.org/show_bug.cgi?id=188424
Reviewed by Fujii Hironori.
Source/WebCore:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Ensure that we fall back to cl.exe if CC env var is not set on Windows.
Tools:
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):
Stop leaking file descriptors.
(See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
- 9:36 PM Changeset in webkit [234719] by
-
- 2 edits in trunk/Source/WebKit
Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=188427
<rdar://problem/43064672>
Reviewed by Wenson Hsieh.
Speculatively fix more crashes seen under setSuggestions.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession isValid]):
(-[WKFormInputSession setSuggestions:]):
(-[WKFormInputSession invalidate]):
Belt-and-suspenders fix: use WeakObjCPtr for WKFormInputSession's WKContentView reference.
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
Invalidate the WKFormInputSession before replacing it; we theorize that
there is a path in which we get here without having previously called stopAssistingNode.
Most of the code is OK with this, but this leaves WKFormInputSession
with a raw reference to WKContentView which can later become stale.
- 9:32 PM Changeset in webkit [234718] by
-
- 7 edits2 adds in trunk
REGRESSION (r228260): Events handled by input method invoke default event handler
https://bugs.webkit.org/show_bug.cgi?id=188370
Reviewed by Wenson Hsieh.
Source/WebCore:
The bug was caused by the default event handler being invoked for the "virtual" keydown events
generated for input methods. Namely, when Japanese or Chinese input methods swallows TAB key,
WebKit should not invoke the default event handler and move the focus during input composition.
Fixed the bug by adding a new boolean on Event indicating whether the default event handler
should be invoked, and restoring the behavior prior to r228260 for these virtual keydown events.
Test: editing/input/press-tab-during-ime-composition.html
- dom/Event.h:
(WebCore::Event::isDefaultEventHandlerIgnored const): Added.
(WebCore::Event::setIsDefaultEventHandlerIgnored): Added.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Don't invoke the default event handler if
isDefaultEventHandlerIgnored is set.
- page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent): Set isDefaultEventHandlerIgnored. This restores WebKit's
behavior prior to r228260.
LayoutTests:
Added a regression test. Due to the lack of adequate support of textInputController in WebKitTestRunner,
the test is only enabled in WebKit1. The WTR fix is tracked by https://webkit.org/b/188428.
- editing/input/press-tab-during-ime-composition-expected.txt: Added.
- editing/input/press-tab-during-ime-composition.html: Added.
- platform/ios/TestExpectations:
- platform/wk2/TestExpectations:
- 8:53 PM Changeset in webkit [234717] by
-
- 2 edits in trunk/Source/WebCore
Prevent collectScreenProperties from crashing Base System
https://bugs.webkit.org/show_bug.cgi?id=188429
<rdar://problem/43075662>
Patch by Justin Fan <Justin Fan> on 2018-08-08
Reviewed by Simon Fraser.
Adding some error-checking and early returns to further prevent calling CGLDescribeRenderer with invalid parameters.
Existing WebGL tests should cover; no expected change in behavior. Crash happened primarily on Base System.
- platform/mac/PlatformScreenMac.mm:
(WebCore::gpuIDForDisplayMask):
- 8:13 PM Changeset in webkit [234716] by
-
- 4 edits in trunk
Array.prototype.sort should throw TypeError if param is a not callable object
https://bugs.webkit.org/show_bug.cgi?id=188382
Reviewed by Saam Barati.
JSTests:
- test262/expectations.yaml:
Source/JavaScriptCore:
Improve spec compatability by checking if the Array.prototype.sort comparator is a function
before doing anything else.
Also, refactor the various helper functions to use let instead of var.
- builtins/ArrayPrototype.js:
(sort.stringComparator):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort.merge):
(sort.mergeSort):
(sort.bucketSort):
(sort.comparatorSort):
(sort.stringSort):
(sort):
- 6:12 PM Changeset in webkit [234715] by
-
- 4 edits in trunk/Source
[Curl] Surface additional NetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=188391
Reviewed by Joseph Pecoraro.
Source/WebCore:
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::getNetworkLoadMetrics):
Source/WebKit:
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::curlDidReceiveResponse):
- 3:58 PM Changeset in webkit [234714] by
-
- 4 edits in trunk
Fix possible null dereference in WebBackForwardList::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=188418
<rdar://problem/42531726>
Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-08
Reviewed by Chris Dumez.
Source/WebKit:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
Null-check m_page like we do everywhere else in this file because it can be set to null when closing the page.
Tools:
- TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
(TestWebKitAPI::TEST):
- 3:42 PM Changeset in webkit [234713] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
Yarr JIT should include annotations with dumpDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=188415
Reviewed by Yusuke Suzuki.
Created a YarrDisassembler class that handles annotations similar to the baseline JIT.
Given that the Yarr creates matching code bu going through the YarrPattern ops forward and
then the backtracking code through the YarrPattern ops in reverse order, the disassembler
needs to do the same think.
Restructured some of the logging code in YarrPattern to eliminate redundent code and factor
out simple methods for what was needed by the YarrDisassembler.
Here is abbreviated sample output after this change.
Generated JIT code for 8-bit regular expression /ab*c/:
Code at [0x469561c03720, 0x469561c03840):
0x469561c03720: push %rbp
0x469561c03721: mov %rsp, %rbp
...
0x469561c03762: sub $0x40, %rsp
Matching
0:OpBodyAlternativeBegin minimum size 2
0x469561c03766: add $0x2, %esi
0x469561c03769: cmp %edx, %esi
0x469561c0376b: ja 0x469561c037fa
1:OpTerm TypePatternCharacter 'a'
0x469561c03771: movzx -0x2(%rdi,%rsi), %eax
0x469561c03776: cmp $0x61, %eax
0x469561c03779: jnz 0x469561c037e9
2:OpTerm TypePatternCharacter 'b' {0,...} greedy
0x469561c0377f: xor %r9d, %r9d
0x469561c03782: cmp %edx, %esi
0x469561c03784: jz 0x469561c037a2
...
0x469561c0379d: jmp 0x469561c03782
0x469561c037a2: mov %r9, 0x8(%rsp)
3:OpTerm TypePatternCharacter 'c'
0x469561c037a7: movzx -0x1(%rdi,%rsi), %eax
0x469561c037ac: cmp $0x63, %eax
0x469561c037af: jnz 0x469561c037d1
4:OpBodyAlternativeEnd
0x469561c037b5: add $0x40, %rsp
...
0x469561c037cf: pop %rbp
0x469561c037d0: ret
Backtracking
4:OpBodyAlternativeEnd
3:OpTerm TypePatternCharacter 'c'
2:OpTerm TypePatternCharacter 'b' {0,...} greedy
0x469561c037d1: mov 0x8(%rsp), %r9
...
0x469561c037e4: jmp 0x469561c037a2
1:OpTerm TypePatternCharacter 'a'
0:OpBodyAlternativeBegin minimum size 2
0x469561c037e9: mov %rsi, %rax
...
0x469561c0382f: pop %rbp
0x469561c03830: ret
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
- yarr/YarrDisassembler.cpp: Added.
(JSC::Yarr::YarrDisassembler::indentString):
(JSC::Yarr::YarrDisassembler::YarrDisassembler):
(JSC::Yarr::YarrDisassembler::~YarrDisassembler):
(JSC::Yarr::YarrDisassembler::dump):
(JSC::Yarr::YarrDisassembler::dumpHeader):
(JSC::Yarr::YarrDisassembler::dumpVectorForInstructions):
(JSC::Yarr::YarrDisassembler::dumpForInstructions):
(JSC::Yarr::YarrDisassembler::dumpDisassembly):
- yarr/YarrDisassembler.h: Added.
(JSC::Yarr::YarrJITInfo::~YarrJITInfo):
(JSC::Yarr::YarrDisassembler::setStartOfCode):
(JSC::Yarr::YarrDisassembler::setForGenerate):
(JSC::Yarr::YarrDisassembler::setForBacktrack):
(JSC::Yarr::YarrDisassembler::setEndOfGenerate):
(JSC::Yarr::YarrDisassembler::setEndOfBacktrack):
(JSC::Yarr::YarrDisassembler::setEndOfCode):
(JSC::Yarr::YarrDisassembler::indentString):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
- yarr/YarrJIT.h:
- yarr/YarrPattern.cpp:
(JSC::Yarr::dumpCharacterClass):
(JSC::Yarr::PatternTerm::dump):
(JSC::Yarr::YarrPattern::dumpPatternString):
(JSC::Yarr::YarrPattern::dumpPattern):
- yarr/YarrPattern.h:
- 3:18 PM Changeset in webkit [234712] by
-
- 6 edits in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188420
Unreviewed test gardening.
Fix test result after r234607 landed. Part 1 for http/tests
- platform/wincairo/TestExpectations:
- platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.txt:
- platform/wincairo/http/tests/multipart/invalid-image-data-expected.txt:
- platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.txt:
- platform/wincairo/http/tests/uri/css-href-expected.txt:
- 2:54 PM Changeset in webkit [234711] by
-
- 2 edits in trunk/Tools
run-builtins-generator-tests does not correctly handle CRLFs from stderr
https://bugs.webkit.org/show_bug.cgi?id=188392
Reviewed by Fujii Hironori.
Background:
file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
- Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
- 1:54 PM Changeset in webkit [234710] by
-
- 2 edits in trunk/Source/WebCore
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
https://bugs.webkit.org/show_bug.cgi?id=188405
<rdar://problem/43039520>
Unreviewed build fix.
- platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:
- 1:34 PM Changeset in webkit [234709] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to committers list.
- Scripts/webkitpy/common/config/contributors.json:
- 12:33 PM Changeset in webkit [234708] by
-
- 2 edits in tags/Safari-607.1.2/Tools
Revert r234321. rdar://problem/43057703
- 12:33 PM Changeset in webkit [234707] by
-
- 2 edits in tags/Safari-607.1.2/Tools
Revert r234320. rdar://problem/43057703
- 12:33 PM Changeset in webkit [234706] by
-
- 4 edits in tags/Safari-607.1.2/Source/WebKit
Revert r234314. rdar://problem/43057703
- 12:07 PM Changeset in webkit [234705] by
-
- 6 edits in trunk
Unreviewed, rolling out r234314, r234320, and r234321.
https://bugs.webkit.org/show_bug.cgi?id=188414
Caused email sign in issue (Requested by ryanhaddad on
#webkit).
Reverted changesets:
"Remove unused WKNavigationDelegatePrivate
decidePolicyForNavigationAction SPI"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234314
"Fix API tests after r234314"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234320
"Fix API tests after r234314"
https://bugs.webkit.org/show_bug.cgi?id=188077
https://trac.webkit.org/changeset/234321
- 12:06 PM Changeset in webkit [234704] by
-
- 10 edits1 add in trunk/Source
Add a WebKit2 logging channel for ActivityState
https://bugs.webkit.org/show_bug.cgi?id=188411
Reviewed by Tim Horton.
Source/WebCore:
Add logging for ActivityState changes and the entrypoints that affect ActivityState.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- page/ActivityState.cpp: Added.
(WebCore::activityStateFlagsToString):
- page/ActivityState.h:
Source/WebKit:
Add logging for ActivityState changes and the entrypoints that affect ActivityState.
- Platform/Logging.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::windowDidOrderOffScreen):
(WebKit::WebViewImpl::windowDidOrderOnScreen):
(WebKit::WebViewImpl::windowDidChangeOcclusionState):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::viewDidHide):
(WebKit::WebViewImpl::viewDidUnhide):
(WebKit::WebViewImpl::activeSpaceDidChange):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::isViewVisible):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setActivityState):
- 11:10 AM Changeset in webkit [234703] by
-
- 4 edits in trunk/Source/WebCore
Add LogArgument template for PlatformMediaSession::RemoteControlCommandType
https://bugs.webkit.org/show_bug.cgi?id=188314
Reviewed by Alex Christensen.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): Don't coerce to int for logging.
- platform/audio/PlatformMediaSession.cpp:
(WebCore::convertEnumerationToString): New.
(WebCore::PlatformMediaSession::didReceiveRemoteControlCommand): Log command.
- platform/audio/PlatformMediaSession.h:
(WTF::LogArgument<WebCore::PlatformMediaSession::RemoteControlCommandType>::toString):
- 10:59 AM Changeset in webkit [234702] by
-
- 7 edits in trunk
Web Inspector: XHR content sometimes shows as error even though load succeeded
https://bugs.webkit.org/show_bug.cgi?id=188385
<rdar://problem/42646160>
Source/WebCore:
Reviewed by Devin Rousso.
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::didReceiveData):
Avoid a double hash lookup in the common case.
Allow synchronous XHR to have text data appended in the normal case.
Allow synchronous XHR to set base64 encoded data right here for non-text data.
- inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::hasBufferedData const):
Getter to see if data is buffered or not for this resource.
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::maybeAddResourceData):
Return the updated ResourceData to avoid clients having to do a lookup.
LayoutTests:
Reviewed by Devin Rousso.
- http/tests/inspector/network/xhr-response-body-expected.txt:
- http/tests/inspector/network/xhr-response-body.html:
Extend this test to include synchronous XHR for text and non-text resources.
- 10:59 AM Changeset in webkit [234701] by
-
- 7 edits in branches/safari-606.1.36.0-branch/Source
Versioning.
- 10:57 AM Changeset in webkit [234700] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source
Versioning.
- 10:43 AM Changeset in webkit [234699] by
-
- 7 edits in branches/safari-606.1.36.2-branch/Source
Versioning.
- 10:29 AM Changeset in webkit [234698] by
-
- 7 edits in trunk/Source
Versioning.
- 10:28 AM Changeset in webkit [234697] by
-
- 7 edits in tags/Safari-607.1.2/Source
Versioning.
- 10:25 AM Changeset in webkit [234696] by
-
- 1 copy in tags/Safari-607.1.2
Tag Safari-607.1.2.
- 9:43 AM Changeset in webkit [234695] by
-
- 3 edits in trunk/LayoutTests
Adjusting test expectations for imported/blink/fast/text/international-iteration-simple-text.html
https://bugs.webkit.org/show_bug.cgi?id=179853
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 9:30 AM Changeset in webkit [234694] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=188409
Unreviewed test gardening.
- platform/gtk/TestExpectations: Remove expectations for now-passing tests.
- 9:20 AM Changeset in webkit [234693] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
- 8:54 AM Changeset in webkit [234692] by
-
- 2 edits in trunk/Source/WebCore
Assertion failed in Webcore::Process::setIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=188404
<rdar://problem/43029137>
Reviewed by Chris Dumez.
App using both WebKit1 and WebKit may crash in WebKit initialization.
- platform/Process.cpp:
(WebCore::Process::setIdentifier):
- 8:06 AM Changeset in webkit [234691] by
-
- 7 edits in trunk
[iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=188401
<rdar://problem/32542300>
Reviewed by Ryosuke Niwa.
Tools:
When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
is because each of the three steps of this test ends when UIScriptController'sdidHideKeyboardCallbackis
invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
skip over one of the steps in the layout test, resulting in a text diff failure.
To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
as a part of resetting test controller state, before moving on to the next layout test.
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView didStartFormControlInteraction]):
(-[TestRunnerWKWebView didEndFormControlInteraction]):
Use these hooks to keep track of whether the previous test is presenting any form input UI.
(-[TestRunnerWKWebView isInteractingWithFormControl]):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::handleKeyboardWillHideNotification):
(WTR::handleKeyboardDidHideNotification):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
of when the keyboard dismissal animation ends.
(WTR::TestController::platformResetStateToConsistentValues):
Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
finish. This includes any keyboard dismissal animations triggered as a result of step (1).
LayoutTests:
Minor tweaks to make this test a bit easier to follow. Use async-await for each step of the test, and pass in
the current autocapitalization type torunTestWithAutocapitalizeTyperather than the next type. See Tools
ChangeLog for more details.
- fast/events/ios/contenteditable-autocapitalize.html:
- platform/ios/TestExpectations:
Remove the failing test expecation.
- 5:07 AM Changeset in webkit [234690] by
-
- 2 edits1 add in trunk/Source/ThirdParty/libwebrtc
[libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable
<https://webkit.org/b/188337>
<rdar://problem/42882908>
Reviewed by Eric Carlson.
- Source/webrtc/pc/peerconnection.cc:
(webrtc::SafeSetError): Make static since it's not used outside
this translation unit.
(webrtc::SafeSetError): Ditto. Change first argument to
webrtc::RTCError&& to prevent unnecessary copying of std::move()
argument. Fix bug by saving value oferror.ok()before moving
to*error_out.
- WebKit/0013-Fix-SafeSetError-use-after-move.patch: Add patch.
- 3:45 AM Changeset in webkit [234689] by
-
- 6 edits2 adds in trunk
Add CENC sanitization
https://bugs.webkit.org/show_bug.cgi?id=188376
Reviewed by Xabier Rodriguez-Calvar.
LayoutTests/imported/w3c:
- web-platform-tests/encrypted-media/scripts/generate-request-disallowed-input.js:
(runTest): Fixed an incorrect test failure message, added more
invalid init data tests to check the new box parsing methods in
WebCore.
Source/WebCore:
This patch adds support for sanitizing the CENC initialization
data, to ensure there are no obviously bogus values in the
untrusted input from generateRequest, see
https://www.w3.org/TR/encrypted-media/#dom-mediakeysession-generaterequest
for more details on sanitization.
Tested by imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html
- Modules/encryptedmedia/InitDataRegistry.cpp: The diff looks a
bit wonky because I had to reorder extractKeyIDsCenc to come
before sanitizeCenc.
(WebCore::extractKeyIDsCenc): Added implementation, a nullopt
return value here indicates the parsing found an error in the box
values.
(WebCore::sanitizeCenc): Added implementation, if the box can be
parsed, return a copy of the buffer as before, otherwise an error
value.
- Sources.txt: Add the new PSSH box type.
- platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:
Added, parsing methods come from ISO/IEC 23001-7-2016 Section
8.1.1.
(WebCore::ISOProtectionSystemSpecificHeaderBox::parse): Ditto.
- platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h: Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::boxTypeName): Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::systemID const): Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::keyIDs const):
Ditto.
(WebCore::ISOProtectionSystemSpecificHeaderBox::data const): Ditto.
- 2:31 AM Changeset in webkit [234688] by
-
- 12 edits2 adds in trunk/Source/WebCore
[Nicosia] Add the Nicosia-specific PlatformLayer type alias
https://bugs.webkit.org/show_bug.cgi?id=188405
Reviewed by Carlos Garcia Campos.
Add a Nicosia-specific PlatformLayer type alias that points to the
Nicosia::PlatformLayer type. This is guarded by the USE(NICOSIA) macro,
which guards additional code in this patch but will be added to other
Nicosia-specific classes later.
To keep things buildable when USE(NICOSIA) is defined, additional
changes are made to classes that operate with platform layers.
Cairo-specific ImageBuffer implementation and the related
ImageBufferData class are modified to work with a Nicosia::ContentLayer
object. This object is using the TextureMapper-specific Impl class which
internally keeps a TextureMapperPlatformLayerProxy object. This way
we can reuse existing code that also works with an object of this type,
only difference is where the proxy object is kept. Main difference is in
the ImageBuffer::platformLayer() method, where pointer to the
Nicosia::ContentLayer object is returned when USE(NICOSIA) is enabled.
Similar approach is taked for the MediaPlayerPrivateGStreamerBase class.
When USE(NICOSIA) is enabled, a Nicosia::ContentLayer object is
constructed, and with the TextureMapper-specific Impl we again operate
on the TextureMapperPlatformLayerProxy object like before, so all of
the proxy-specific code is bundled into helper lambdas that operate on
the given proxy object. In the platformLayer() method, we again return
pointer to the Nicosia::ContentLayer object when USE(NICOSIA) is on.
For the GraphicsContext3D integration, we have to provide a separate
class that replicates most of the functionality currently present in the
TextureMapperGC3DPlatformLayer class. Main difference is that in the new
Nicosia::GC3DLayer class, a Nicosia::ContentLayer object is spawned with
the TextureMapper-specific Impl. The proxy object held by that Impl is
then again used to push new buffers into the rendering pipeline. As
before, pointer to the Nicosia::ContentLayer is returned in the
GraphicsContext3D::platformLayer() object.
Integration of the GraphicsContext3D class into Nicosia layering needs
further work in the future. Target should be providing a class that is
not specific to the TextureMapper layer. Additionally, when USE(NICOSIA)
is enabled, we remove the TextureMapperGC3DPlatformLayer class from
compilation since it depends on a PlatformLayer type alias to the
TextureMapperPlatformLayerProxyProvider class.
This patch also doesn't address the abundance of macros that this code
now uses. While USE(NICOSIA) is introduced, we have to work around
four additional macros in this code: USE(TEXTURE_MAPPER),
USE(TEXTURE_MAPPER_GL), USE(COORDINATED_GRAPHICS) and
USE(COORDINATED_GRAPHICS_THREADED). In a lot of places these are used
interchangeably, but they should be merged and simplified in use. I hope
to approach this once the USE(NICOSIA) functionality lands and is turned
on for ports that currently build with USE(COORDINATED_GRAPHICS).
- platform/TextureMapper.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/PlatformLayer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBufferData::~ImageBufferData):
(WebCore::ImageBufferData::swapBuffersIfNeeded):
(WebCore::ImageBuffer::platformLayer const):
- platform/graphics/cairo/ImageBufferDataCairo.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer const):
(WebCore::MediaPlayerPrivateGStreamerBase::swapBuffersIfNeeded):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp: Added.
(Nicosia::GC3DLayer::GC3DLayer):
(Nicosia::GC3DLayer::~GC3DLayer):
(Nicosia::GC3DLayer::makeContextCurrent):
(Nicosia::GC3DLayer::platformContext):
(Nicosia::GC3DLayer::swapBuffersIfNeeded):
- platform/graphics/nicosia/texmap/NicosiaGC3DLayer.h: Added.
(Nicosia::GC3DLayer::contentLayer const):
- platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer const):
- platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
- platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::syncPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer):
- 2:14 AM Changeset in webkit [234687] by
-
- 24 edits8 adds in trunk
[css-grid] Update behavior of percentage row tracks and gutters
https://bugs.webkit.org/show_bug.cgi?id=188403
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Import tests from WPT related to this issue.
- web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001-expected.txt: Added.
- web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001.html: Added.
- web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002-expected.txt: Added.
- web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002.html: Added.
- web-platform-tests/css/css-grid/alignment/w3c-import.log:
- web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html: Added.
- web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
- web-platform-tests/css/css-grid/grid-layout-properties.html: Update test to reflect the new behavior.
Source/WebCore:
The CSSWG decided to change how percentage row tracks and gutters
in a grid container with indefinite height are resolved.
The CSSWG issues are:
So far they were resolved as "auto", like it happens with
percentage heights in regular blocks. But now they're going to behave
similar to what happens in the columns axis, they would be ignored
to compute the intrinsic height.
This causes that we need to repeat the track sizing algorithm
when we have a grid container with indefinite height
that has some percentage rows using the intrinsic height
calculated on the first pass. Then the percentages will be resolved
against the intrinsic height.
Tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-001.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-second-pass-002.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridTrackSize const):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::GridTrackSizingAlgorithm::reset):
- rendering/GridTrackSizingAlgorithm.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::availableSpaceForGutters const):
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
LayoutTests:
Update tests as needed according to the new behavior.
- TestExpectations: Two grid gutters tests from WPT css-align suite are passing now.
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-gutters-as-percentage-expected.txt:
- fast/css-grid-layout/grid-gutters-as-percentage.html:
- fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows-expected.txt:
- fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/nested-grid-expected.html:
- fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
Aug 7, 2018:
- 9:41 PM Changeset in webkit [234686] by
-
- 2 edits in trunk/Source/WebCore
ResourceUsageOverlay should use physical footprint for its "Footprint" label
https://bugs.webkit.org/show_bug.cgi?id=188395
Reviewed by Simon Fraser.
Let's use physical footprint on Cocoa for the number we say is "footprint".
Before, we were just using the number of dirty pages multiplies by
page size. This number was an upper bound on footprint since it
doesn't take into account compressed memory.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::ResourceUsageOverlay::platformDraw):
- 7:39 PM Changeset in webkit [234685] by
-
- 79 edits1 copy1 move1 add in trunk
[Cocoa] More tweaks and refactoring to prepare for ARC
https://bugs.webkit.org/show_bug.cgi?id=188245
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- API/JSValue.mm: Use unsafe_unretained.
(JSContainerConvertor::convert): Use auto for compatibility with the above.
- API/JSWrapperMap.mm:
(allocateConstructorForCustomClass): Use CFTypeRef instead of Protocol *.
(-[JSWrapperMap initWithGlobalContextRef:]): Use unsafe_unretained.
- heap/Heap.cpp: Updated include for rename: FoundationSPI.h -> objcSPI.h.
Source/WebCore:
- bridge/objc/objc_instance.mm: Updated include for rename: FoundationSPI.h -> objcSPI.h.
- platform/ios/wak/WebCoreThread.mm: Ditto.
Source/WebKit:
- Platform/cocoa/WKCrashReporter.mm:
(WebKit::setCrashLogMessage): Refactor into a separate function for clarity.
(WebKit::setCrashReportApplicationSpecificInformation): Use a bridging cast.
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing): Use a bridging cast.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::convertToNPNNString): Added. Uses CFStringRef rather than NSString so we can
manually manage the autoreleasing.
(WebKit::initializeKeyboardEvent): Use convertToNPNNString.
(WebKit::NetscapePlugin::sendComplexTextInput): Ditto.
- WebProcess/Plugins/PDF/PDFPlugin.mm: Use unsafe_unretained explicitly
for a parent pointer. We could consider moving to weak after switching to ARC.
Source/WebKitLegacy/mac:
- Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
- Carbon/CarbonWindowFrame.m:
(-[CarbonWindowFrame dealloc]): Deleted. It was empty.
- DOM/DOM.mm:
(-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
(-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
garbage collection so this method isn't useful.
- DOM/DOMXPath.mm:
(-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
Objective-C garbage collection so this method isn't useful.
- History/WebHistory.mm:
(-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
- Misc/WebElementDictionary.mm:
(addLookupKey): Use a bridging cast.
(cacheValueForKey): Ditto.
(-[WebElementDictionary _fillCache]): Ditto.
(-[WebElementDictionary objectForKey:]): Ditto.
- Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
(-[NSString _web_widthWithFont:]): Ditto.
(-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
- Misc/WebLocalizableStrings.mm:
(WebLocalizedString): Use a bridging cast.
- Misc/WebNSDataExtras.mm:
(-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
and use CFBridgingRelease instead of calling autorelease directly.
(-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
of a mix of CFString and NSString. Also simplified logic a bit, and cut down
on the amount of explicit release and autorelease.
- Misc/WebNSDictionaryExtras.h: Deleted unused methods.
- Misc/WebNSDictionaryExtras.m:
(-[NSDictionary _webkit_intForKey:]): Deleted.
(-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
(-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
- Misc/WebStringTruncator.mm:
(fontFromNSFont): Use a bridging cast.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
(WebKit::NetscapePluginInstanceProxy::status): Ditto.
(WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames): Ditto.
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
- Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]): Ditto.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
(-[WebNetscapePluginView status:]): Use a bridging cast.
(-[WebNetscapePluginView popUpContextMenu:]): Ditto.
- Plugins/WebPluginController.mm:
(-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
- Plugins/WebPluginDatabase.mm:
(checkCandidate): Use explicit strong for out argument types.
- Plugins/npapi.mm:
(pluginViewForInstance): Use a bridging cast.
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
explicit NSNumber and NSDictionary calls.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleKeyboardEvent): Added a missing typecast.
(WebEditorClient::handleInputMethodKeydown): Ditto.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
- WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
as a struct rather than an Objective-C class, since that's how it's defined.
- WebInspector/WebNodeHighlighter.mm: Added missing includes.
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
Ditto.
(-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
go down to the document and then back to the frame.
(-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
- WebView/WebJSPDFDoc.mm:
(jsPDFDocInitialize): Removed some unneeded type casting.
(jsPDFDocFinalize): Ditto.
(jsPDFDocPrint): Use a bridging cast.
- WebView/WebPDFView.mm:
(_applicationInfoForMIMEType): Use bridging casts.
- WebView/WebPreferences.mm:
(-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
instead of methods from WebNSDictionaryExtras.
(-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
(-[WebPreferences _setFloatValue:forKey:]): Ditto.
(-[WebPreferences _setBoolValue:forKey:]): Ditto.
(-[WebPreferences _setLongLongValue:forKey:]): Ditto.
(-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
- WebView/WebView.mm:
(-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
(-[WebView _addToAllWebViewsSet]): Ditto.
(+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
(-[WebView _windowVisibilityChanged:]): Moved this into the internal category
so it can be called from WebViewData methods.
- WebView/WebViewData.mm: Added an import so we can call an internal WebView
method, _windowVisibilityChanged:.
- WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
called from WebViewData methods.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Updated for rename: FoundationSPI.h -> objcSPI.h.
- wtf/BlockPtr.h: Added missing include of "StdLibExtras.h".
Also re-sorted includes.
- wtf/HashFunctions.h: Add function for "unsafe_unretained id".
- wtf/HashTraits.h: Add traits for "unsafe_unretained id".
- wtf/PlatformMac.cmake: Updated for rename: FoundationSPI.h -> objcSPI.h.
- wtf/WeakObjCPtr.h: Use mutable instead of const_cast, and write a version
that uses weak explicitly under ARC. Also moved function declarations from
here to objcSPI.h.
- wtf/cocoa/AutodrainedPool.cpp: Updated include for rename: FoundationSPI.h -> objcSPI.h.
- wtf/spi/cocoa/objcSPI.h: Renamed from FoundationSPI.h and added the
additional functions used by WeakObjCPtr.h. Also changed to both include the
internal header and the function definitions when compiling with
USE(APPLE_INTERNAL_SDK), helping us check that function definitions match.
Tools:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
CFTypeRef instead of void*.
- DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
(createCoreAnimationLayer): Use CFBridgingRetain.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
(AccessibilityUIElement::textMarkerRangeForElement): Ditto.
(AccessibilityUIElement::selectedTextMarkerRange): Ditto.
(AccessibilityUIElement::textMarkerRangeLength): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
(AccessibilityUIElement::indexForTextMarker): Ditto.
(AccessibilityUIElement::textMarkerForIndex): Ditto.
(AccessibilityUIElement::isTextMarkerValid): Ditto.
(AccessibilityUIElement::previousTextMarker): Ditto.
(AccessibilityUIElement::nextTextMarker): Ditto.
(AccessibilityUIElement::stringForTextMarkerRange): Ditto.
(createJSStringRef): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
(AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
(AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
(AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
(AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
(AccessibilityUIElement::endTextMarkerForBounds): Ditto.
(AccessibilityUIElement::startTextMarkerForBounds): Ditto.
(AccessibilityUIElement::textMarkerForPoint): Ditto.
(AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
(AccessibilityUIElement::startTextMarker): Ditto.
(AccessibilityUIElement::endTextMarker): Ditto.
(AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Use bridging cast.
(dumpFramesAsText): Ditto.
(dumpBackForwardListForAllWindows): Use a modern for loop instead of
CFArray functions to iterate the array.
(dump): Use bridging cast.
(runTest): Ditto.
- DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
(+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
(toUTI): Return a RetainPtr<CFStringRef>.
(-[LocalPasteboard types]): Use the above and bridging casts.
(-[LocalPasteboard availableTypeFromArray:]): Ditto.
(-[LocalPasteboard setData:forType:]): Ditto.
(-[LocalPasteboard dataForType:]): Ditto.
(-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
instead of CFPropertyList.
(-[LocalPasteboard setString:forType:]): Use NSString method instead of
CFStringCreateExternalRepresentation.
- DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
instead of an Objective-C object pointer type.
- DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider registerWebView:]): Update for above.
(-[MockGeolocationProvider unregisterWebView:]): Ditto.
(-[MockGeolocationProvider timerFired]): Ditto.
- DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
HashMap and HashSet instead of an Objective-C object pointer type.
- DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider registerWebView:]): Update for above.
(-[MockWebNotificationProvider unregisterWebView:]): Ditto.
(-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
(-[MockWebNotificationProvider cancelNotification:]): Ditto.
(-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
- DumpRenderTree/mac/ObjCPlugin.m:
(-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL): Use bridging cast.
(TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
(TestRunner::clearApplicationCacheForOrigin): Ditto.
(originsArrayToJS): Ditto.
(TestRunner::copyDecodedHostName): Ditto.
(TestRunner::copyEncodedHostName): Ditto.
(TestRunner::queueLoad): Ditto.
(TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
(TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
(TestRunner::setUserStyleSheetLocation): Ditto.
(TestRunner::setValueForUser): Ditto.
(TestRunner::overridePreference): Ditto.
(TestRunner::execCommand): Ditto.
(TestRunner::findString): Ditto.
(TestRunner::isCommandEnabled): Ditto.
(TestRunner::addOriginAccessWhitelistEntry): Ditto.
(TestRunner::removeOriginAccessWhitelistEntry): Ditto.
(TestRunner::addUserScript): Ditto.
(TestRunner::addUserStyleSheet): Ditto.
(TestRunner::evaluateInWebInspector): Ditto.
(TestRunner::evaluateScriptInIsolatedWorld): Ditto.
(TestRunner::authenticateSession): Ditto.
(TestRunner::grantWebNotificationPermission): Ditto.
(TestRunner::denyWebNotificationPermission): Ditto.
- TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
(-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
(WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
(WTR::AccessibilityUIElement::previousTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextTextMarker): Ditto.
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
(WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
(WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
(WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
(WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
(WTR::AccessibilityUIElement::startTextMarker): Ditto.
(WTR::AccessibilityUIElement::endTextMarker): Ditto.
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
- WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
- WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow.
- WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
class into a separate file.
(WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
instead of have a second copy of the implementation.
- WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
(+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
- WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
(+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
(-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
(-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
(-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
instead of CFPropertyList.
(-[LocalPasteboard setString:forType:]): Use NSString method instead of
CFStringCreateExternalRepresentation.
- WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
WebKitTestRunnerWindow here so it can be included by files that need to know
what the type is and that it inherits from NSWindow.
- WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
(+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
messier implementation.
- 6:41 PM Changeset in webkit [234684] by
-
- 3 edits3 adds in trunk
navigator.sendBeacon does not work in pagehide callbacks
https://bugs.webkit.org/show_bug.cgi?id=188329
Reviewed by Alex Christensen.
Source/WebCore:
Add support for sending beacons from pagehide event handlers. We normally do not allow loads because we're
about to enter PageCache. However, in case of Beacon, this is fine since it uses PingLoad and does not
WebCore to do the load.
Test: http/wpt/beacon/sendBeacon-in-pagehide.html
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- Allow Beacon loads to go through even if the document's pageCacheState is AboutToEnterPageCache (i.e.
we're firing the 'pagehide' event)
- Allow Becon loads to go though even if the FrameLoader's state is provisional (i.e. a load is pending)
LayoutTests:
Add layout test coverage.
- http/wpt/beacon/sendBeacon-in-pagehide-expected.txt: Added.
- http/wpt/beacon/sendBeacon-in-pagehide.html: Added.
- http/wpt/beacon/support/sendBeacon-onpagehide-window.html: Added.
- 5:55 PM Changeset in webkit [234683] by
-
- 29 edits8 adds in trunk
Allow href attribute without xlink on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=153854
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-08-07
Reviewed by Dean Jackson.
Source/WebCore:
SVG 2 has moved the href attribute from xlink namespace to svg namespace.
Instead of using xlink:href, svg:href should be used or simply use href
if the svg namespace is defined.
See https://www.w3.org/TR/SVG2/linking.html#XLinkRefAttrs.
For backward compatibility, xlink:href will be treated as an alias to href
till it is acceptable to completely remove the support for the deprecated
xlink:href.
Tests: svg/custom/href-svg-namespace-animate.svg
svg/custom/href-svg-namespace-dynamic.svg
svg/custom/href-svg-namespace-elements.html
svg/custom/href-svg-namespace-expected.svg
svg/custom/href-svg-namespace-static.svg
- dom/Element.cpp:
(WebCore::Element::absoluteLinkURL const):
- dom/Element.h:
(WebCore::Element::getAttribute const): This new template function with
template pack parameter QualifiedNames is added to return the first none
empty attribute value given a set of attributes' names. This should be
useful for deprecated attributes. When we decide to remove the support
for the deprecated attribute, all we need is to remove it as a parameter
to getAttribute(). In this case, the none template function will be called.
- dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterScriptToken):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isURLAttribute const):
- svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements const):
- svg/SVGCursorElement.cpp:
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::rebuildElements):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):
- svg/SVGElement.cpp:
(WebCore::SVGElement::animatableAttributeForName):
- svg/SVGFEImageElement.cpp:
- svg/SVGFilterElement.cpp:
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::srcValue const):
(WebCore::SVGFontFaceUriElement::parseAttribute):
(WebCore::SVGFontFaceUriElement::loadFont):
- svg/SVGForeignObjectElement.cpp:
- svg/SVGGlyphRefElement.cpp:
(WebCore::SVGGlyphRefElement::hasValidGlyphElement const):
- svg/SVGGradientElement.cpp:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::imageSourceURL const):
- svg/SVGMPathElement.cpp:
- svg/SVGPatternElement.cpp:
- svg/SVGScriptElement.h:
- svg/SVGTRefElement.cpp:
- svg/SVGTextPathElement.cpp:
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::registerAttributes):
(WebCore::SVGURIReference::parseAttribute):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree const):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
(WebCore::SVGSMILElement::svgAttributeChanged):
- svg/svgattrs.in:
LayoutTests:
- fast/selectors/any-link-basics-2-expected.txt:
- fast/selectors/any-link-basics-2.html:
Re-baseline this test because it was assuming the bare href should not
work for the SVG <a> element.
- svg/custom/href-svg-namespace-animate-expected.svg: Added.
- svg/custom/href-svg-namespace-animate.svg: Added.
- svg/custom/href-svg-namespace-dynamic-expected.svg: Added.
- svg/custom/href-svg-namespace-dynamic.svg: Added.
- svg/custom/href-svg-namespace-elements-expected.txt: Added.
- svg/custom/href-svg-namespace-elements.html: Added.
- svg/custom/href-svg-namespace-static-expected.svg: Added.
- svg/custom/href-svg-namespace.static-svg: Added.
- 5:34 PM Changeset in webkit [234682] by
-
- 1 copy in tags/Safari-606.1.36.2.1
Tag Safari-606.1.36.2.1.
- 5:33 PM Changeset in webkit [234681] by
-
- 1 copy in tags/Safari-606.1.36.1.2
Tag Safari-606.1.36.1.2.
- 4:54 PM Changeset in webkit [234680] by
-
- 6 edits6 adds in trunk
document.open and document.write must throw while the HTML parser is synchronously constructing a custom element
https://bugs.webkit.org/show_bug.cgi?id=187319
<rdar://problem/42843012>
Reviewed by Frédéric Wang.
Source/WebCore:
Make document.open, document.write, document.writeln, and document.close throw InvalidStateError during
a synchronous custom element construction as specified:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter
Tests: fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::openForBindings): Throw InvalidStateError when m_throwOnDynamicMarkupInsertionCount is non-zero.
(WebCore::Document::closeForBindings): Ditto.
(WebCore::Document::write): Ditto.
(WebCore::Document::writeln): Ditto.
- dom/Document.h: Re-ordered the related instance variables in the order they appear in the spec, and updated spec URLs.
- dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h: Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer): Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::ThrowOnDynamicMarkupInsertionCountIncrementer):
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::~ThrowOnDynamicMarkupInsertionCountIncrementer):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate ThrowOnDynamicMarkupInsertionCountIncrementer.
LayoutTests:
Added W3C style testharness.js tests. The WPT test added by https://github.com/web-platform-tests/wpt/pull/12037
doesn't test nearly as many edge cases.
- fast/custom-elements/resources/navigation-destination.html: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Added.
- 4:46 PM Changeset in webkit [234679] by
-
- 4 edits in trunk/Source/WebCore
Use 1-byte enum class for Document::StandaloneStatus
https://bugs.webkit.org/show_bug.cgi?id=188352
Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-07
Reviewed by Chris Dumez.
- dom/Document.cpp:
(WebCore::Document::setXMLStandalone):
- dom/Document.h:
(WebCore::Document::xmlStandalone const):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration):
- 4:26 PM Changeset in webkit [234678] by
-
- 6 edits1 add in trunk
fetch() with subresource integrity crashes on zero length body
https://bugs.webkit.org/show_bug.cgi?id=184325
Patch by Rob Buis <rbuis@igalia.com> on 2018-08-07
Reviewed by Alex Christensen.
Source/WebCore:
Check that resourceBuffer() is non null before dereferencing.
Tests: http/tests/subresource-integrity/sri-fetch.js
http/tests/subresource-integrity/sri-fetch-worker.js
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didFinishLoading):
LayoutTests:
Add a subtest for zero length resources.
- http/tests/subresource-integrity/resources/empty-resource.txt: Added.
- http/tests/subresource-integrity/sri-fetch-expected.txt:
- http/tests/subresource-integrity/sri-fetch-worker-expected.txt:
- http/tests/subresource-integrity/sri-fetch.js:
- 4:21 PM Changeset in webkit [234677] by
-
- 7 edits1 add in trunk/Source
Shrink size of PropertyCondition by packing UniquedStringImpl* and Kind
https://bugs.webkit.org/show_bug.cgi?id=188328
Reviewed by Saam Barati.
Source/JavaScriptCore:
Shrinking the size of PropertyCondition can improve memory consumption by a lot.
For example, cnn.com can show 7000 persistent StructureStubClearingWatchpoint
and 6000 LLIntPrototypeLoadAdaptiveStructureWatchpoint which have PropertyCondition
as a member field.
This patch shrinks the size of PropertyCondition by packing UniquedStringImpl* and
PropertyCondition::Kind into uint64_t data in 64bit architecture. Since our address
are within 48bit, we can put PropertyCondition::Kind in this unused bits.
To make it easy, we add WTF::CompactPointerTuple<PointerType, Type>, which automatically
folds a pointer and 1byte type into 64bit data.
This change shrinks PropertyCondition from 24bytes to 16bytes.
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::dumpInContext const):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
- bytecode/PropertyCondition.h:
(JSC::PropertyCondition::PropertyCondition):
(JSC::PropertyCondition::presenceWithoutBarrier):
(JSC::PropertyCondition::absenceWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::PropertyCondition::equivalenceWithoutBarrier):
(JSC::PropertyCondition::hasPrototypeWithoutBarrier):
(JSC::PropertyCondition::operator bool const):
(JSC::PropertyCondition::kind const):
(JSC::PropertyCondition::uid const):
(JSC::PropertyCondition::hasOffset const):
(JSC::PropertyCondition::hasAttributes const):
(JSC::PropertyCondition::hasPrototype const):
(JSC::PropertyCondition::hasRequiredValue const):
(JSC::PropertyCondition::hash const):
(JSC::PropertyCondition::operator== const):
(JSC::PropertyCondition::isHashTableDeletedValue const):
(JSC::PropertyCondition::watchingRequiresReplacementWatchpoint const):
Source/WTF:
This patch adds CompactPointerTuple, which can pack a pointer and 8bit value into 8bytes.
In 32bit architecture, it just has two fields for a pointer and 8bit value. In 64bit architecture,
we use upper 5bits (zeros because of the effective width of virtual address) and lower 3bits (zeros
because of the alignment ensured by static_assert) to pack 8bit value into the pointer data. Since
even the 5-level page tables use 57bit effective address, this strategy works well.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/CompactPointerTuple.h: Added.
(WTF::CompactPointerTuple::encodeType):
(WTF::CompactPointerTuple::decodeType):
(WTF::CompactPointerTuple::CompactPointerTuple):
(WTF::CompactPointerTuple::pointer const):
(WTF::CompactPointerTuple::setPointer):
(WTF::CompactPointerTuple::type const):
(WTF::CompactPointerTuple::setType):
- wtf/Platform.h:
- 4:18 PM Changeset in webkit [234676] by
-
- 2 edits1 add in trunk/Tools
Add a test for using SafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188290
Reviewed by Chris Dumez.
Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
(-[SafeBrowsingDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):
- 4:13 PM Changeset in webkit [234675] by
-
- 1 copy in tags/Safari-606.1.36.0.1
Tag Safari-606.1.36.0.1.
- 3:17 PM Changeset in webkit [234674] by
-
- 2 edits in trunk/Source/WebCore
Prevent querying for renderer info for disconnected or uninitialized displays
https://bugs.webkit.org/show_bug.cgi?id=188387
<rdar://problem/42588769>
Patch by Justin Fan <Justin Fan> on 2018-08-07
Reviewed by Simon Fraser.
Calling CGL functions with a NULL displayMask crashes the process.
No tests; requires multiple displays.
- platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):
- 2:29 PM Changeset in webkit [234673] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source
Cherry-pick r234652. rdar://problem/43009927
[macOS] Scrollbars are not visible when using 3rd party mouse
https://bugs.webkit.org/show_bug.cgi?id=188372
Reviewed by Simon Fraser.
Source/WebCore/PAL:
Added declaration of NSScrollerImpPair class method. This method updates all NSScrollerImpPairs
with a new recommended scroller style.
- pal/spi/mac/NSScrollerImpSPI.h:
Source/WebKit:
The scrollbars are not visible because they are not updated with the recommended scroller style
when a 3rd party mouse is used. They still have the overlay style, but the system is
recommending the legacy style in this case. The UI process is currently notifying the WebProcess
about changes in the scroller style, but the current style is not set in the WebProcess on
startup. This patch sets the initial scroller style in the WebProcess by passing it as part of
the WebProcess creation parameters. Also, to make sure hot-plugging of a 3rd party mouse is
is visually changing the scroller style of the current page, a class method in NSScrollerImpPair
is called to update all NSScrollerImpPairs with the new recommended style. This method was
previously called by AppKit, but after blocking WindowServer access, AppKit is no longer calling
this method. This has been manually tested by using a 3rd party mouse.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::scrollerStylePreferenceChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:29 PM Changeset in webkit [234672] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source/WebKit
Cherry-pick r234626. rdar://problem/43009894
Regression(NetworkLoadChecker): CORS preflights are no longer able to deal with client certificate authentication
https://bugs.webkit.org/show_bug.cgi?id=188355
<rdar://problem/42546319>
Reviewed by Alex Christensen.
Before we started using the NetworkLoadChecker to do CORS-preflighting in the Network process, challenges would
use the NetworkLoad::completeAuthenticationChallenge() code path with isAllowedToAskUserForCredentials to set
to false. This would call:
- completionHandler(AuthenticationChallengeDisposition::UseCredential, { }); for TLS handshakes (server trust evaluation & client certification authentication)
- NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge() otherwise
However, NetworkCORSPreflightChecker::didReceiveChallenge() was behaving differently and calling:
- completionHandler(AuthenticationChallengeDisposition::RejectProtectionSpace, { }); for server trust evaluations
- completionHandler(AuthenticationChallengeDisposition::Cancel, { }); otherwise
Restore previous behavior by aligning NetworkCORSPreflightChecker::didReceiveChallenge() with
NetworkLoad::completeAuthenticationChallenge() when isAllowedToAskUserForCredentials is set to false. This means
we end up asking the AuthenticationManager for client certificate authentication instead or cancelling the
preflight.
This fixes CORS-preflighting on some internal sites.
- NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
- NetworkProcess/NetworkCORSPreflightChecker.h:
- NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::NetworkLoadChecker): (WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
- NetworkProcess/NetworkLoadChecker.h:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::PingLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:29 PM Changeset in webkit [234671] by
-
- 2 edits in branches/safari-606.1.36.1-branch/Source/WebKit
Cherry-pick r234611. rdar://problem/43009901
Fix IPC::Connection leak in StorageManager
https://bugs.webkit.org/show_bug.cgi?id=188321
<rdar://problem/42748485>
Reviewed by Alex Christensen.
When a StorageMap is destroyed on WebContent process side, StorageManager::destroyStorageMap()
gets called via IPC with a (IPC::Connection, StorageMapID) pair. Normally, it removes this
pair from m_storageAreasByConnection. However, if this is a *transient* StorageMap (sessionStorage),
then we keep the pair in the map and we merely remove the StorageMapID as a listener from the
StorageArea. We do this so that:
- The StorageArea stays alive so that it can be reused later on for the same security origin, on the same IPC::Connection (logic for this is in StorageManager::createTransientLocalStorageMap()
- Removing the StorageMapID as a listener from the StorageArea is important because StorageArea::m_eventListeners holds a strong reference to the IPC::Connection in a std::pair with the StorageMapID (HashSet<std::pair<RefPtr<IPC::Connection>, uint64_t>> m_eventListeners).
As mentioned in 1 above, in StorageManager::createTransientLocalStorageMap(), there is logic to
check if there is already an existing StorageArea for the given IPC::Connection that is transient
and is for the same security origin. In this case, we could avoid constructing a new StorageArea
and we would:
- Add a new entry to m_storageAreasByConnection with the key (connection, newStorageMapID), using same same StorageArea as value.
- Remove the previous (connection, oldStorageMapID) key from m_storageAreasByConnection.
Step 2 here is wrong and is updated in this patch. It is only safe to remove the previous
(connection, oldStorageMapID) if this oldStorageMapID no longer exists (i.e. destroyStorageMap()
was already called for it). This patch thus adds a check before removing (connection, oldStorageMapID)
from the HashMap to make sure that the oldStorageMapID is no longer a listener of the StorageArea).
This would cause leaks in the following case:
- We construct a StorageArea for (connection1, storageMapId1)
- We ask for a StorageArea for (connection1, storageMapId2) and decide to reuse the existing StorageArea since it has the same SecurityOrigin.
- As a result of step2, we would remove (connection1, storageMapId1) from m_storageAreasByConnection and add (connection1, storageMapId2), even though there is still a StorageMap with storageMapId1 on WebContent process side.
- Later on, we would try to call destroyStorageMap(connection1, storageMap1), it would fail to find it in m_storageAreasByConnection and return early. It would therefore fail to remove storageMapId1 as a listener of the StorageArea which still exists. -> This would leak the IPC::Connection that there would be a std::pair<RefPtr<IPC::Connection>, StorageMapID> with value (connection1, storageMap1) which would get leaked and it would ref the IPC::Connection.
This code should really be refactored to be less leak prone but I have kept the patch minimal for now
to facilitate cherry-picking.
Note that this would reproduce very easily on sina.com.cn, when clicking bold links at the top, which
opens new tabs to different pages in the same WebContent process. When closing all Safari windows, the
IPC::Connection for this WebContent process would stay alive.
- UIProcess/WebStorage/StorageManager.cpp: (WebKit::StorageManager::StorageArea::hasListener const): (WebKit::StorageManager::createTransientLocalStorageMap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:28 PM Changeset in webkit [234670] by
-
- 1 edit5 deletes in trunk/LayoutTests
Unreviewed, rolling out r234669.
https://bugs.webkit.org/show_bug.cgi?id=188390
Didn't commit the actual change (Requested by rniwa on
#webkit).
Reverted changeset:
"document.open and document.write must throw while the HTML
parser is synchronously constructing a custom element"
https://bugs.webkit.org/show_bug.cgi?id=187319
https://trac.webkit.org/changeset/234669
- 2:13 PM Changeset in webkit [234669] by
-
- 2 edits5 adds in trunk
document.open and document.write must throw while the HTML parser is synchronously constructing a custom element
https://bugs.webkit.org/show_bug.cgi?id=187319
<rdar://problem/42843012>
Reviewed by Frédéric Wang.
Source/WebCore:
Make document.open, document.write, document.writeln, and document.close throw InvalidStateError during
a synchronous custom element construction as specified:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#throw-on-dynamic-markup-insertion-counter
Tests: fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::openForBindings): Throw InvalidStateError when m_throwOnDynamicMarkupInsertionCount is non-zero.
(WebCore::Document::closeForBindings): Ditto.
(WebCore::Document::write): Ditto.
(WebCore::Document::writeln): Ditto.
- dom/Document.h: Re-ordered the related instance variables in the order they appear in the spec, and updated spec URLs.
- dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h: Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer): Added.
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::ThrowOnDynamicMarkupInsertionCountIncrementer):
(WebCore::ThrowOnDynamicMarkupInsertionCountIncrementer::~ThrowOnDynamicMarkupInsertionCountIncrementer):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate ThrowOnDynamicMarkupInsertionCountIncrementer.
LayoutTests:
Added W3C style testharness.js tests. The WPT test added by https://github.com/web-platform-tests/wpt/pull/12037
doesn't test nearly as many edge cases.
- fast/custom-elements/resources/navigation-destination.html: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Added.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Added.
- 2:04 PM Changeset in webkit [234668] by
-
- 16 edits in trunk/Source/WebKit
Add SPI for launching WebContent process with pre-linked injected bundle
https://bugs.webkit.org/show_bug.cgi?id=188367
Patch by Ben Richards <benton_richards@apple.com> on 2018-08-07
Reviewed by Ryosuke Niwa.
Added SPI to allow applications to set a "customWebContentServiceBundleIdentifier" which will be launched instead of the default WebContent XPC service.
The "customWebContentServiceBundleIdentifier" should be the bundle identifier for an XPC service that calls [WKProcessPool _webContentProcessXPCMain].
The new XPC service should be hard linked to the application's injected bundle in order to receive the intended performance benefit.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceMain):
(main):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetCustomWebContentServiceBundleIdentifier):
- UIProcess/API/C/WKContext.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _webContentProcessXPCMain]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration customWebContentServiceBundleIdentifier]):
(-[_WKProcessPoolConfiguration setCustomWebContentServiceBundleIdentifier:]):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
- WebKit.xcodeproj/project.pbxproj:
- 12:34 PM Changeset in webkit [234667] by
-
- 5 edits in branches/safari-606.1.36.0-branch/Source/JavaScriptCore
Cherry-pick r234649. rdar://problem/43009914
Use a more specific PtrTag for PlatformRegisters PC and LR.
https://bugs.webkit.org/show_bug.cgi?id=188366
<rdar://problem/42984123>
Reviewed by Keith Miller.
Also fixed a bug in linkRegister(), which was previously returning the PC instead
of LR. It now returns LR.
- runtime/JSCPtrTag.h:
- runtime/MachineContext.h: (JSC::MachineContext::instructionPointer): (JSC::MachineContext::linkRegister):
- runtime/VMTraps.cpp: (JSC::SignalContext::SignalContext):
- tools/SigillCrashAnalyzer.cpp: (JSC::SignalContext::SignalContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:28 PM Changeset in webkit [234666] by
-
- 5 edits in branches/safari-606.1.36.2-branch/Source/JavaScriptCore
Cherry-pick r234649. rdar://problem/43014010
Use a more specific PtrTag for PlatformRegisters PC and LR.
https://bugs.webkit.org/show_bug.cgi?id=188366
<rdar://problem/42984123>
Reviewed by Keith Miller.
Also fixed a bug in linkRegister(), which was previously returning the PC instead
of LR. It now returns LR.
- runtime/JSCPtrTag.h:
- runtime/MachineContext.h: (JSC::MachineContext::instructionPointer): (JSC::MachineContext::linkRegister):
- runtime/VMTraps.cpp: (JSC::SignalContext::SignalContext):
- tools/SigillCrashAnalyzer.cpp: (JSC::SignalContext::SignalContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:23 PM Changeset in webkit [234665] by
-
- 6 edits in branches/safari-606.1.36.2-branch/Source/WebKit
Cherry-pick r234651. rdar://problem/43009909
[Wi-Fi Assertions] suspendWiFiAssertions() should be able to delay sending ProcessReadyToSuspend
https://bugs.webkit.org/show_bug.cgi?id=188373
<rdar://problem/42857398>
Reviewed by Tim Horton.
- NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::actualPrepareToSuspend):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformPrepareToSuspend): (WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
- NetworkProcess/curl/NetworkProcessCurl.cpp: (WebKit::NetworkProcess::platformPrepareToSuspend):
- NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::platformPrepareToSuspend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:09 PM Changeset in webkit [234664] by
-
- 5 edits in trunk/Source/WebKit
StorageManager should stop ref'ing IPC::Connections as this is leak-prone
https://bugs.webkit.org/show_bug.cgi?id=188380
Patch by Chris Dumez <Chris Dumez> on 2018-08-07
Reviewed by Alex Christensen.
StorageManager should stop ref'ing IPC::Connections as this is leak-prone. Instead, assign a unique identifier
to each IPC::Connection and store this identifier intead of a RefPtr<IPC::Connection>. When the StorageManager
needs an actual IPC::Connection, it can look it up from the identifier.
- Platform/IPC/Connection.cpp:
(IPC::Connection::Connection):
(IPC::Connection::~Connection):
(IPC::Connection::connection):
- Platform/IPC/Connection.h:
(IPC::Connection::uniqueID const):
- UIProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
(WebKit::StorageManager::StorageArea::hasListener const):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::dispatchEvents const):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection const):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createTransientLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::applicationWillTerminate):
(WebKit::StorageManager::findStorageArea const):
- UIProcess/WebStorage/StorageManager.h:
- 11:46 AM Changeset in webkit [234663] by
-
- 7 edits1 add in trunk/Tools
If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
https://bugs.webkit.org/show_bug.cgi?id=188235
Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
- Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
- Scripts/webkitpy/tool/commands/upload.py:
(Upload): Teach the upload step how to add radar information when creating a new bug.
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/addradar.py: Added.
(AddRadar):
(AddRadar.run): Contains the logic to add the radar information to bugzilla.
- Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
- 11:33 AM Changeset in webkit [234662] by
-
- 2 edits in trunk/Source/WebKit
NotReadableError when calling getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=188309
<rdar://problem/42916838>
Reviewed by Brent Fulgham.
- UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream): Deal with audio and video sandbox
extensions being issued at different times. Use new ProcessState methods.
(WebKit::UserMediaProcessManager::endedCaptureSession): Use new ProcessState methods.
- 11:32 AM Changeset in webkit [234661] by
-
- 3 edits4 adds in trunk
REGRESSION (r233778): Text selection sometimes cannot be extended in iframes
https://bugs.webkit.org/show_bug.cgi?id=188374
<rdar://problem/42928657>
Reviewed by Simon Fraser.
Source/WebKit:
rangeForPoint contains logic for converting a selection handle location in root view coordinates to an updated
selection. In doing so, we first convert the selection handle location to content coordinates; however, the call
site to EventHandler::hitTestResultAtPoint still hit-tests using the location in root view coordinates rather
than content coordinates, which means that when the focused frame is a subframe, hit-testing will fail to find
nodes within the subframe under the selection handle. This manifests in behaviors such as snapping to a single
character when selecting text in subframes.
To fix this, we just need to pass in the point in the frame's content coordinates when hit-testing.
Tests: editing/selection/ios/selection-handles-in-iframe.html
editing/selection/ios/selection-handles-in-readonly-input.html
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeForPointInRootViewCoordinates):
Make a couple of other minor adjustments:
- Take a Frame& instead of a Frame*, since Frame& is assumed to be non-null here.
- Rename rangeForPoint to rangeForPointInRootViewCoordinates, as well as the point argument to
pointInRootViewCoordinates.
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::rangeForPoint): Deleted.
LayoutTests:
Add 2 new layout tests to cover the original bug that r233778 fixed, as well as the regression in this bug.
- editing/selection/ios/selection-handles-in-iframe-expected.txt: Added.
- editing/selection/ios/selection-handles-in-iframe.html: Added.
Add a test to verify that the user can select text in an iframe by dragging selection handles.
- editing/selection/ios/selection-handles-in-readonly-input-expected.txt: Added.
- editing/selection/ios/selection-handles-in-readonly-input.html: Added.
Add a test to verify that dragging a selection handle outside of a readonly input does not cause the selection
to jump outside of the input and clear out the selection in the input.
- 11:12 AM Changeset in webkit [234660] by
-
- 7 edits in branches/safari-606.1.36.1-branch/Source
Versioning.
- 11:07 AM Changeset in webkit [234659] by
-
- 6 edits in trunk/Source
Unreviewed, suppress warnings to fix the build.
Source/WebCore:
- crypto/CommonCryptoUtilities.cpp:
(WebCore::getCommonCryptoDigestAlgorithm):
Source/WebCore/PAL:
- pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
(PAL::CryptoDigest::create):
(PAL::CryptoDigest::addBytes):
(PAL::CryptoDigest::computeHash):
Source/WTF:
- wtf/SHA1.cpp:
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):
- 10:36 AM Changeset in webkit [234658] by
-
- 4 edits4 adds in trunk
Fix things after r234640
https://bugs.webkit.org/show_bug.cgi?id=188133
Source/WebKit:
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
Fix assertions as I had in r234552. Also fix a possible race condition with fragment navigations by only keeping the first "use" response.
- config.h:
Fix IOSMAC build.
LayoutTests:
- platform/mac-sierra-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Added.
Added test expectation for Sierra, which has no safe browsing framework.
- 10:21 AM Changeset in webkit [234657] by
-
- 2 edits in trunk/Tools
Post-review feedback after r234614.
https://bugs.webkit.org/show_bug.cgi?id=188322
<rdar://problem/42455270>
Reviewed by Sam Weinig.
Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
- TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(rounded):
- 10:16 AM Changeset in webkit [234656] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit
[GTK] [2.20.4] Occasional rendering artifacts
https://bugs.webkit.org/show_bug.cgi?id=188377
Unreviewed manual rollout of r234420, which is causing issues on this branch.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::handleDisplayRefreshMonitorUpdate):
- 10:15 AM Changeset in webkit [234655] by
-
- 1 edit14 deletes in trunk/Source/WebCore
Removed unused *AllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=188369
Reviewed by Yusuke Suzuki.
- accessibility/AccessibilityAllInOne.cpp: Removed.
- bindings/js/JSBindingsAllInOne.cpp: Removed.
- css/CSSAllInOne.cpp: Removed.
- dom/DOMAllInOne.cpp: Removed.
- editing/EditingAllInOne.cpp: Removed.
- html/HTMLElementsAllInOne.cpp: Removed.
- inspector/InspectorAllInOne.cpp: Removed.
- loader/appcache/ApplicationCacheAllInOne.cpp: Removed.
- mathml/MathMLAllInOne.cpp: Removed.
- platform/text/TextAllInOne.cpp: Removed.
- rendering/RenderingAllInOne.cpp: Removed.
- rendering/style/StyleAllInOne.cpp: Removed.
- rendering/svg/RenderSVGAllInOne.cpp: Removed.
- svg/SVGAllInOne.cpp: Removed.
- 9:29 AM Changeset in webkit [234654] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=188246
Unreviewed test gardening, marked test as flaky because the test is wrong.
- 9:19 AM Changeset in webkit [234653] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Web Inspector: Add another Protocol Version (iOS 12)
https://bugs.webkit.org/show_bug.cgi?id=188359
<rdar://problem/42981364>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-07
Reviewed by Brian Burg.
- UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-12.0.json: Added.
- 9:15 AM Changeset in webkit [234652] by
-
- 7 edits in trunk/Source
[macOS] Scrollbars are not visible when using 3rd party mouse
https://bugs.webkit.org/show_bug.cgi?id=188372
Reviewed by Simon Fraser.
Source/WebCore/PAL:
Added declaration of NSScrollerImpPair class method. This method updates all NSScrollerImpPairs
with a new recommended scroller style.
- pal/spi/mac/NSScrollerImpSPI.h:
Source/WebKit:
The scrollbars are not visible because they are not updated with the recommended scroller style
when a 3rd party mouse is used. They still have the overlay style, but the system is
recommending the legacy style in this case. The UI process is currently notifying the WebProcess
about changes in the scroller style, but the current style is not set in the WebProcess on
startup. This patch sets the initial scroller style in the WebProcess by passing it as part of
the WebProcess creation parameters. Also, to make sure hot-plugging of a 3rd party mouse is
is visually changing the scroller style of the current page, a class method in NSScrollerImpPair
is called to update all NSScrollerImpPairs with the new recommended style. This method was
previously called by AppKit, but after blocking WindowServer access, AppKit is no longer calling
this method. This has been manually tested by using a 3rd party mouse.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::scrollerStylePreferenceChanged):
- 9:08 AM Changeset in webkit [234651] by
-
- 6 edits in trunk/Source/WebKit
[Wi-Fi Assertions] suspendWiFiAssertions() should be able to delay sending ProcessReadyToSuspend
https://bugs.webkit.org/show_bug.cgi?id=188373
<rdar://problem/42857398>
Reviewed by Tim Horton.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::actualPrepareToSuspend):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformPrepareToSuspend):
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
- NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformPrepareToSuspend):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformPrepareToSuspend):
- 7:36 AM Changeset in webkit [234650] by
-
- 10 edits1 add in trunk/Tools
[MiniBrowser][Win] Allow selection of recent user agents
https://bugs.webkit.org/show_bug.cgi?id=188371
Reviewed by Fujii Hironori.
Updates the user agent spoofing strings to the latest released
versions and adds Microsoft Edge's user agent.
Moves the menu item selection to the common base class, BrowserWindow
to support user agent spoofing in a WebKitLegacyBrowserWindow and
WebKitBrowserWindow.
- MiniBrowser/win/BrowserWindow.cpp: Added.
(BrowserWindow::setUserAgent):
- MiniBrowser/win/BrowserWindow.h:
- MiniBrowser/win/CMakeLists.txt:
- MiniBrowser/win/MainWindow.cpp:
(MainWindow::toggleMenuItem):
- MiniBrowser/win/MiniBrowserLib.rc:
- MiniBrowser/win/MiniBrowserLibResource.h:
- MiniBrowser/win/WebKitBrowserWindow.cpp:
- MiniBrowser/win/WebKitBrowserWindow.h:
- MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
(WebKitLegacyBrowserWindow::setUserAgent):
- MiniBrowser/win/WebKitLegacyBrowserWindow.h:
- 6:11 AM Changeset in webkit [234649] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use a more specific PtrTag for PlatformRegisters PC and LR.
https://bugs.webkit.org/show_bug.cgi?id=188366
<rdar://problem/42984123>
Reviewed by Keith Miller.
Also fixed a bug in linkRegister(), which was previously returning the PC instead
of LR. It now returns LR.
- runtime/JSCPtrTag.h:
- runtime/MachineContext.h:
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::linkRegister):
- runtime/VMTraps.cpp:
(JSC::SignalContext::SignalContext):
- tools/SigillCrashAnalyzer.cpp:
(JSC::SignalContext::SignalContext):
- 5:50 AM Changeset in webkit [234648] by
-
- 4 edits in trunk/Source
Hardcoded LFENCE instruction
https://bugs.webkit.org/show_bug.cgi?id=188145
Patch by Karo Gyoker <karogyoker2+webkit@gmail.com> on 2018-08-07
Reviewed by Filip Pizlo.
Remove lfence instruction because it is crashing systems without SSE2 and
this is not the way how WebKit mitigates Spectre.
Source/JavaScriptCore:
- runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):
(JSC::JSLock::willReleaseLock):
Source/WTF:
- wtf/Atomics.h:
(WTF::crossModifyingCodeFence):
(WTF::speculationFence): Deleted.
(WTF::x86_lfence): Deleted.
- 3:59 AM Changeset in webkit [234647] by
-
- 2 edits in trunk/Tools
Unreviewed, add a new address to my configuration
- Scripts/webkitpy/common/config/contributors.json:
- 3:01 AM Changeset in webkit [234646] by
-
- 3 edits1 add in trunk/Source/WTF
Web process never leaves memory pressured state if caused by process size limit
https://bugs.webkit.org/show_bug.cgi?id=188299
<rdar://problem/42157442>
Reviewed by Darin Adler.
For vm memory pressure warnings we get notified when exiting the state and we can clear
the isUnderMemoryPressure bit. However as a compatibility behavior we were also notified using
the same event when approaching the process size limit. In this case there is no "all clear"
event so we'd stay in pressured state forever, leading to unnecessarily degraded user experience.
- WTF.xcodeproj/project.pbxproj:
- wtf/cocoa/MemoryPressureHandlerCocoa.mm:
(WTF::MemoryPressureHandler::install):
Install a handler for process size limit events. This disables the compatibility behavior,
vm pressure events will be received for vm pressure only.
Process size limit events are treated as one-shot. We do cleanups based on criticality but
don't enter the pressured state.
(WTF::MemoryPressureHandler::uninstall):
(WTF::MemoryPressureHandler::holdOff):
- wtf/spi/darwin/DispatchSPI.h: Added.
- 2:40 AM Changeset in webkit [234645] by
-
- 3 edits in trunk/Source/WebCore
[WPE][GTK] Handle some virtual keys commonly used on TVs
https://bugs.webkit.org/show_bug.cgi?id=188375
Reviewed by Žan Doberšek.
- platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):
- platform/wpe/PlatformKeyboardEventWPE.cpp:
(WebCore::PlatformKeyboardEvent::keyValueForWPEKeyCode):
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForWPEKeyCode):
- 2:08 AM Changeset in webkit [234644] by
-
- 3 edits2 adds in trunk/Source/WebCore
[Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl
https://bugs.webkit.org/show_bug.cgi?id=188348
Reviewed by Carlos Garcia Campos.
Add the Nicosia::CompositionLayerTextureMapperImpl class, the
TextureMapper-specific implementation that will extend the
CompositionLayer class.
The important deatil of this implementation is the TextureMapperLayer
object that's expected to be managed by the composition controller. As
such, it is placed inside the CompositionState struct to clearly
indicate its utility and expected place of management. In the current
setup, this place would be the CoordinatedGraphicsScene class.
The Nicosia::CompositionLayer object that's spawned for each
CoordinatedGraphicsLayer instance is now switched to using the
CompositionLayerTextureMapperImpl object, with the local temporary no-op
CompositionLayer::Impl class removed.
- platform/TextureMapper.cmake:
- platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.cpp: Added.
(Nicosia::CompositionLayerTextureMapperImpl::createFactory):
- platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h: Added.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(): Deleted.
- 2:03 AM Changeset in webkit [234643] by
-
- 2 edits3 adds in trunk/Source/WebCore
[Nicosia] Add the TextureMapper-specific ContentLayer::Impl derivative
https://bugs.webkit.org/show_bug.cgi?id=188344
Reviewed by Carlos Garcia Campos.
Add Nicosia::ContentLayerTextureMapperImpl class, providing the
TextureMapper-specific implementation that derives from the
ContentLayer::Impl class and which can be used by the
Nicosia::ContentLayer instances.
Internally a TextureMapperPlatformLayerProxy is created, and is
accessible to others through a getter. This way the content producers
can push new buffers into this proxy object, and the scene compositor
can take these buffers for display purposes.
Nicosia::ContentLayerTextureMapperImpl::swapBuffersIfNeeded() will be
called during layer flushes, and the call will cause the content layer
clients to take their texture, wrap it into a buffer, and push it into
the TextureMapperPlatformLayerProxy object. At the moment this operation
is required by the ImageBuffer and GraphicsContext3D producers.
The Client object is managed under its own lock. While the producers
will only live on the main thread, the thread-safe check in the
destructor is necessary in case the ContentLayerTextureMapperImpl object
ends up being destroyed on some other thread.
The patch only adds the class implementation. It will be integrated into
the layer tree later, once all the other pieces of the puzzle land.
- platform/TextureMapper.cmake:
- platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp: Added.
(Nicosia::ContentLayerTextureMapperImpl::createFactory):
(Nicosia::ContentLayerTextureMapperImpl::ContentLayerTextureMapperImpl):
(Nicosia::ContentLayerTextureMapperImpl::~ContentLayerTextureMapperImpl):
(Nicosia::ContentLayerTextureMapperImpl::invalidateClient):
(Nicosia::ContentLayerTextureMapperImpl::swapBuffersIfNeeded):
- platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.h: Added.
- 1:30 AM Changeset in webkit [234642] by
-
- 2 edits in trunk/Source/WebCore
Make DOMWindow::scrollBy rely on DOMWindow::scrollTo
https://bugs.webkit.org/show_bug.cgi?id=188343
Patch by Frederic Wang <fwang@igalia.com> on 2018-08-07
Reviewed by Darin Adler.
This patch makes DOMWindow::scrollBy rely on DOMWindow::scrollTo in order to perform actual
scrolling of the view. In particular, this reduces the number of code path to modify in order
to implement the ScrollBehavior option (bug 188043). The only change is an optimization when
scrolling to position (0, 0) but it is not observable.
No new tests, behavior unchanged and already tested.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollBy const): Add the current view position to the scrollBy offset in
order to obtain the scrollTo offset.
