Timeline



Nov 7, 2018:

9:29 PM Changeset in webkit [237981] by Justin Michaud
  • 17 edits
    13 copies
    3 adds in trunk

CSS Painting API should pass size, arguments and input properties to paint callback
​https://bugs.webkit.org/show_bug.cgi?id=191309

Reviewed by Chris Dumez.

Source/WebCore:

Call paint() callback with input properties and arguments. This patch adds a stub for
the CSS Typed OM StylePropertyMapReadOnly, and passes all the arguments as strings without
any syntax checking to the paint callback.

Test: fast/css-custom-paint/properties.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleValueCustom.cpp: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

  • bindings/js/WebCoreBuiltinNames.h:
  • css/CSSPaintCallback.h:
  • css/CSSPaintCallback.idl:
  • css/CSSPaintImageValue.cpp:

(WebCore::CSSPaintImageValue::image):

  • css/CSSPaintImageValue.h:
  • css/CSSPaintSize.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::CSSPaintSize::create):
(WebCore::CSSPaintSize::width const):
(WebCore::CSSPaintSize::height const):
(WebCore::CSSPaintSize::CSSPaintSize):

  • css/CSSPaintSize.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeCustomPaint):

  • css/typedom/CSSNumericValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
  • css/typedom/CSSNumericValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • css/typedom/CSSStyleValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::CSSStyleValue::isUnitValue):
(WebCore::CSSStyleValue::isUnparsedValue):

  • css/typedom/CSSStyleValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • css/typedom/CSSUnitValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
  • css/typedom/CSSUnitValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • css/typedom/CSSUnparsedValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
  • css/typedom/CSSUnparsedValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • css/typedom/StylePropertyMapReadOnly.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::StylePropertyMapReadOnly::create):
(WebCore::StylePropertyMapReadOnly::get):
(WebCore::StylePropertyMapReadOnly::StylePropertyMapReadOnly):

  • css/typedom/StylePropertyMapReadOnly.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
  • platform/graphics/CustomPaintImage.cpp:

(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):

  • platform/graphics/CustomPaintImage.h:

LayoutTests:

  • fast/css-custom-paint/properties-expected.html: Added.
  • fast/css-custom-paint/properties.html: Added.
  • fast/css-custom-paint/worklet.html:
9:15 PM Changeset in webkit [237980] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

Provide better Font fallbacks for DirectX backend
​https://bugs.webkit.org/show_bug.cgi?id=191412
<rdar://problem/45899207>

Reviewed by Zalan Bujtas.

Registration of custom fonts through GDI are not always visible
through the DirectWrite/GDI bridging layer. If a font is not located,
locate the closest matching avialable font rather than failing.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Use new font
fallback logic.

  • platform/graphics/win/FontPlatformDataDirect2D.cpp:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformIsEqual const):
(WebCore::FontPlatformData::createFallbackFont): Added.

8:18 PM Changeset in webkit [237979] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 69

Added a tag for Safari Technology Preview release 69.

7:33 PM Changeset in webkit [237978] by Alan Bujtas
  • 3 edits
    4 adds in trunk

Click and touch event listeners on the body don't work
​https://bugs.webkit.org/show_bug.cgi?id=191392
<rdar://problem/5844416>

Reviewed by Simon Fraser.

Source/WebCore:

Remove the old quirk of ignoring onclick handlers on the body and beyond.

Test: fast/events/click-handler-on-body-simple.html

  • page/ios/FrameIOS.mm:

(WebCore::Frame::nodeRespondingToClickEvents):

LayoutTests:

  • fast/events/click-handler-on-body-simple-expected.txt: Added.
  • fast/events/click-handler-on-body-simple.html: Added.
  • fast/events/touch/touch-handler-on-body-simple-expected.txt: Added.
  • fast/events/touch/touch-handler-on-body-simple.html: Added.
7:30 PM Changeset in webkit [237977] by Brent Fulgham
  • 14 edits in trunk/Source/WebCore

[Windows][DirectX] Update canvas code to pass more tests
​https://bugs.webkit.org/show_bug.cgi?id=191337
<rdar://problem/45878801>

Reviewed by Dean Jackson.

Update the Direct2D code paths to comply with our canvas tests, improving the
the test results scores to 579/770.

PathDirect2D was updated with an implementation of 'addArcTo' based on work by
Dirk Schulze <​vbs85@gmx.de> (see ​https://hg.mozilla.org/mozilla-central/rev/b116b49459f8).

Tests: canvas/philip/tests

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer): Direct2D needs access to the graphics
context to create the buffer.

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/Path.h:
  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPattern): Flush needed.
(WebCore::GraphicsContext::drawRect): Ditto.
(WebCore::GraphicsContextPlatformPrivate::setMiterLimit): Correct for Direct2D definition of miter limit.
(WebCore::GraphicsContextPlatformPrivate::strokeStyleProperties const): Added helper function.
(WebCore::GraphicsContextPlatformPrivate::recomputeStrokeStyle): Update for new helper.
(WebCore::GraphicsContext::drawLine): Ditto.
(WebCore::drawWithShadowHelper): Ditto.
(WebCore::GraphicsContext::fillRect): Add flush.
(WebCore::GraphicsContext::platformFillRoundedRect): Update for helper.
(WebCore::GraphicsContext::clipPath): Add flush.
(WebCore::GraphicsContext::strokeRect): Ditto.
(WebCore::GraphicsContext::drawLineForText): Update for upstream changes.
(WebCore::GraphicsContext::drawLinesForText): Ditto.

  • platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
  • platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::createCroppedImageIfNecessary): Add missing implementations.
(WebCore::createBitmapImageAfterScalingIfNeeded): Ditto.
(WebCore::ImageBuffer::copyImage const): Ditto.
(WebCore::ImageBuffer::sinkIntoImage): Ditto.
(WebCore::ImageBuffer::fastCopyImageMode): Ditto.
(WebCore::ImageBuffer::sinkIntoNativeImage): Ditto.
(WebCore::ImageBuffer::copyNativeImage const): Ditto.

  • platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::operator=):
(WebCore::Path::drawDidComplete): This should never have been const.
It manipulates the path!
(WebCore::Path::transform): Properly transform existing geometries.
(WebCore::Path::openFigureAtCurrentPointIfNecessary): Added.
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo): Make sure figure starts at a valid point.
(WebCore::Path::addQuadCurveTo): Ditto.
(WebCore::Path::addBezierCurveTo): Ditto.
(WebCore::Path::addArcTo): Add implementation.
(WebCore::Path::closeSubpath):
(WebCore::drawArcSection):
(WebCore::Path::addArc): Update to build large arcs out of small arc segments. If the
arc is effectively a complete circle, use the ellipse drawing routines.
(WebCore::Path::addRect): Make sure we start at a valid starting point.
(WebCore::Path::addEllipse): Correct for definition of D2D ellipse.
(WebCore::Path::drawDidComplete const): Deleted.

  • platform/graphics/win/SimpleFontDataDirect2D.cpp:

(WebCore::Font::platformWidthForGlyph const):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):

  • rendering/svg/SVGRenderingContext.h:
7:14 PM Changeset in webkit [237976] by Wenson Hsieh
  • 11 edits
    8 adds in trunk

Add an editing command for creating and inserting child lists
​https://bugs.webkit.org/show_bug.cgi?id=191335
<rdar://problem/45814050>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, insertOrderedList and insertUnorderedList only toggle or change list state (i.e. if the selection is
in an ordered or unordered list, reinserting the same list type removes the current list, and inserting a
different list type changes the enclosing list).

However, for certain internal clients (e.g. Mail), if the start of the selection is enclosed by a list item, we
instead create a new list item and insert it after the enclosing list item, and then create a new list within
that list item. Currently, this logic is implemented in Mail for legacy-WebKit-based Mail compose. This patch
brings this logic into WebKit in the form of a new editing command.

Tests: editing/execCommand/insert-nested-lists-in-table.html

editing/execCommand/insert-nested-lists-with-pre.html
editing/execCommand/insert-nested-lists.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::insertOrderedList):
(WebCore::Editor::insertUnorderedList):

  • editing/EditorCommand.cpp:

(WebCore::executeInsertOrderedList):
(WebCore::executeInsertUnorderedList):
(WebCore::executeInsertNestedUnorderedList):
(WebCore::executeInsertNestedOrderedList):
(WebCore::createCommandMap):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):
(WebCore::InsertListCommand::editingAction const):

  • editing/InsertListCommand.h:

Change a couple of enums into enum classes.

  • editing/InsertNestedListCommand.cpp: Added.

(WebCore::InsertNestedListCommand::insertUnorderedList):
(WebCore::InsertNestedListCommand::insertOrderedList):
(WebCore::InsertNestedListCommand::doApply):

  • editing/InsertNestedListCommand.h: Added.

Add a new edit command to insert a new list (as a child of any containing list). If the start of the selection
is in a list item, we create a new list item, move the selection into the list item, and increment its list
level; otherwise, simply fall back to inserting a list.

  • editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

  • editing/ModifySelectionListLevel.h:

Expose this constructor, allowing other edit commands to change selection list level as a composite edit
command. Also, change an enum into an enum class.

(WebCore::IncreaseSelectionListLevelCommand::create):

LayoutTests:

Add a new layout tests that exercise the "InsertNested(Un)orderedList" editing commands in several scenarios
including undo, redo, executing the edit command with a ranged selection, outdenting to decrease list level,
inserting lists in and around tables and table cells, and inserting lists in and around pre elements.

  • editing/execCommand/insert-nested-lists-expected.txt: Added.
  • editing/execCommand/insert-nested-lists-in-table-expected.txt: Added.
  • editing/execCommand/insert-nested-lists-in-table.html: Added.
  • editing/execCommand/insert-nested-lists-with-pre-expected.txt: Added.
  • editing/execCommand/insert-nested-lists-with-pre.html: Added.
  • editing/execCommand/insert-nested-lists.html: Added.
7:11 PM Changeset in webkit [237975] by Chris Dumez
  • 3 edits
    2 adds in trunk

ASSERT(renderer()) under HTMLTextAreaElement::updateValue()
​https://bugs.webkit.org/show_bug.cgi?id=191391
<rdar://problem/34219633>

Reviewed by Geoffrey Garen.

Source/WebCore:

Update HTMLTextFormControlElement::didEditInnerTextValue() to not call subtreeHasChanged()
if the element has no renderer, similarly to what is already done in
HTMLTextFormControlElement::setRangeText() and HTMLInputElement::setEditingValue().

Test: editing/inserting/inset-html-textarea-without-renderer.html

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):

LayoutTests:

Add layout test coverage. I have verified that this test passes in Firefox and Chrome.
It used to crash before this change in debug.

  • editing/inserting/inset-html-textarea-without-renderer-expected.txt: Added.
  • editing/inserting/inset-html-textarea-without-renderer.html: Added.
6:12 PM Changeset in webkit [237974] by youenn@apple.com
  • 8 edits in trunk

Allow setting RTCRtpTransceiver.direction
​https://bugs.webkit.org/show_bug.cgi?id=191346

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-remote-track-mute.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
  • web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Remove readonly from the direction attribute.
Keep setDirection for now as it is in use, with an intent to remove it.
Driven-by fix as in some cases, the rtc source track might be changed
and current implementation is not expecting that.
In such a case, stop observing the old track (which should no longer call us)
before observing the new one.

Covered by rebased tests.

  • Modules/mediastream/RTCRtpTransceiver.idl:
  • platform/mediastream/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::setSourceTrack):

  • platform/mediastream/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::setSourceTrack):

6:00 PM Changeset in webkit [237973] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r236705): Web Inspector: wrong text color for selected DataGrid row
​https://bugs.webkit.org/show_bug.cgi?id=191405
<rdar://problem/45893283>

Reviewed by Matt Baker.

Selection background color for both Dark Mode mode and Light Mode is dark blue.
The text color for both cases should be white.

  • UserInterface/Views/DataGrid.css:

(body:not(.window-inactive, .window-docked-inactive) .data-grid:focus tr.editable.selected .cell-content > input):

5:47 PM Changeset in webkit [237972] by Caio Lima
  • 19 edits
    7 adds in trunk

[BigInt] Add support to BigInt into ValueAdd
​https://bugs.webkit.org/show_bug.cgi?id=186177

Reviewed by Keith Miller.

JSTests:

  • stress/big-int-negate-jit.js:
  • stress/value-add-big-int-and-string.js: Added.
  • stress/value-add-big-int-prediction-propagation.js: Added.
  • stress/value-add-big-int-untyped.js: Added.

PerformanceTests:

The idea of BigIntBench is to provide a set of microbenchmarks and
benchmarks to evaluate how fast BigInt computations are happening on
JSC implementation.

Now, we are adding microbenchmarks in this set,
but the plan is to move these tests to "JSTest/microbenchmarks" when
BigInt is enabled by default. After that, the focus of Bigint bench is
to provide a set of tests that represents real use cases of BigInt in
JS programs.

  • BigIntBench/big-int-add-prediction-propagation.js: Added.
  • BigIntBench/big-int-simple-add.js: Added.
  • BigIntBench/big-int-simple-sub.js: Added.

Source/JavaScriptCore:

We are adding a very primitive specialization case of BigInts into ValueAdd.
When compiling a speculated version of this node to BigInt, we are currently
calling 'operationAddBigInt', a function that expects only BigInts as
parameter and effectly add numbers using JSBigInt::add. To properly
speculate BigInt operands, we changed ArithProfile to observe when
its result is a BigInt. With this new observation, we are able to identify
when ValueAdd results into a String or BigInt.

Here are some numbers for this specialization running
microbenchmarks:

big-int-simple-add 21.5411+-1.1096 15.3502+-0.7027 definitely 1.4033x faster
big-int-add-prediction-propagation 13.7762+-0.5578 10.8117+-0.5330 definitely 1.2742x faster

  • bytecode/ArithProfile.cpp:

(JSC::ArithProfile::emitObserveResult):
(JSC::ArithProfile::shouldEmitSetNonNumeric const):
(JSC::ArithProfile::shouldEmitSetBigInt const):
(JSC::ArithProfile::emitSetNonNumeric const):
(JSC::ArithProfile::emitSetBigInt const):
(WTF::printInternal):
(JSC::ArithProfile::shouldEmitSetNonNumber const): Deleted.
(JSC::ArithProfile::emitSetNonNumber const): Deleted.

  • bytecode/ArithProfile.h:

(JSC::ArithProfile::observedUnaryInt):
(JSC::ArithProfile::observedUnaryNumber):
(JSC::ArithProfile::observedBinaryIntInt):
(JSC::ArithProfile::observedBinaryNumberInt):
(JSC::ArithProfile::observedBinaryIntNumber):
(JSC::ArithProfile::observedBinaryNumberNumber):
(JSC::ArithProfile::didObserveNonInt32 const):
(JSC::ArithProfile::didObserveNonNumeric const):
(JSC::ArithProfile::didObserveBigInt const):
(JSC::ArithProfile::setObservedNonNumeric):
(JSC::ArithProfile::setObservedBigInt):
(JSC::ArithProfile::observeResult):
(JSC::ArithProfile::didObserveNonNumber const): Deleted.
(JSC::ArithProfile::setObservedNonNumber): Deleted.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::mayHaveNonNumericResult):
(JSC::DFG::Node::mayHaveBigIntResult):
(JSC::DFG::Node::mayHaveNonNumberResult): Deleted.

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

  • dfg/DFGNodeFlags.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):

  • runtime/CommonSlowPaths.cpp:

(JSC::updateArithProfileForUnaryArithOp):
(JSC::updateArithProfileForBinaryArithOp):

Tools:

  • Scripts/run-jsc-benchmarks:
5:43 PM Changeset in webkit [237971] by Alan Coon
  • 4 edits in branches/safari-606.3.4.1-branch/Source

Apply patch. rdar://problem/45837753

5:34 PM Changeset in webkit [237970] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

webrtc/datachannel/basic-tcp.html will crash with an invalid crash
​https://bugs.webkit.org/show_bug.cgi?id=178285
<rdar://problem/34985374>

Reviewed by Eric Carlson.

Reintroduce change made to libwebrtc and erroneously removed when refreshing libwebrtc.

  • Source/webrtc/rtc_base/physicalsocketserver.cc:
5:31 PM Changeset in webkit [237969] by sihui_liu@apple.com
  • 7 edits
    2 adds in trunk

RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
​https://bugs.webkit.org/show_bug.cgi?id=191326
<rdar://problem/45769269>

Reviewed by Geoffrey Garen.

Source/WebCore:

UniqueIDBDatabase should ignore incoming requests or operations when it is already marked as
hardClosedForUserDelete.

Test: IndexedDB.IndexedDBUserDelete.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::didPerformActivateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::deleteTransaction):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::commit):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.

(-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

5:30 PM Changeset in webkit [237968] by Alan Coon
  • 125 edits
    4 adds
    29 deletes in tags/Safari-607.1.13

Revert r237547. rdar://problem/45895377

5:29 PM Changeset in webkit [237967] by Alan Coon
  • 3 edits
    1 delete in tags/Safari-607.1.13

Revert r237553. rdar://problem/45895377

5:29 PM Changeset in webkit [237966] by Alan Coon
  • 2 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237576. rdar://problem/45895377

5:29 PM Changeset in webkit [237965] by Alan Coon
  • 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237627. rdar://problem/45895377

5:29 PM Changeset in webkit [237964] by Alan Coon
  • 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237638. rdar://problem/45895377

5:29 PM Changeset in webkit [237963] by Alan Coon
  • 3 edits
    1 delete in tags/Safari-607.1.13

Revert r237641. rdar://problem/45895377

5:29 PM Changeset in webkit [237962] by Alan Coon
  • 2 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237645. rdar://problem/45895377

5:29 PM Changeset in webkit [237961] by Alan Coon
  • 3 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237728. rdar://problem/45895377

5:29 PM Changeset in webkit [237960] by Alan Coon
  • 4 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237734. rdar://problem/45895377

5:29 PM Changeset in webkit [237959] by Alan Coon
  • 12 edits in tags/Safari-607.1.13

Revert r237803. rdar://problem/45895377

5:29 PM Changeset in webkit [237958] by Alan Coon
  • 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237823. rdar://problem/45895377

5:29 PM Changeset in webkit [237957] by Alan Coon
  • 142 edits
    1 add
    25 deletes in tags/Safari-607.1.13

Revert r237919. rdar://problem/45895377

5:28 PM Changeset in webkit [237956] by Alan Coon
  • 12 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237933. rdar://problem/45895377

5:08 PM Changeset in webkit [237955] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Positioned text underline can look like a strike-through
​https://bugs.webkit.org/show_bug.cgi?id=191341

Reviewed by Simon Fraser.

Source/WebCore:

We should just clamp the value so it can't go above the baseline.

We shouldn't do this at parse time because it's totally reasonable for text-underline-position: under to want
a negative text-underline-offset. Instead, we just do it at used value time.

Test: fast/css3-text/css3-text-decoration/text-underline-negative.html

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

LayoutTests:

  • fast/css3-text/css3-text-decoration/text-underline-negative-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-negative.html: Added.
4:46 PM Changeset in webkit [237954] by Kocsen Chung
  • 4 edits in branches/safari-606-branch/Source

Revert "Apply patch. rdar://problem/45523764"

4:39 PM Changeset in webkit [237953] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

"/api/report" does not check commit time correctly.
​https://bugs.webkit.org/show_bug.cgi?id=191351

Reviewed by Ryosuke Niwa.

Test result report API does not convert formated time string to timestamp correctly
which result in not checking commit time correctly.

  • public/include/report-processor.php: Use 'strtotime' instead of 'floatval'.

Accepts the time delta within 1 seconds.

  • server-tests/api-report-tests.js: Added unit tests.

(reportWitMismatchingCommitTime):
(reportWithOneSecondCommitTimeDifference):

4:36 PM Changeset in webkit [237952] by Chris Dumez
  • 4 edits in trunk/Source

Unreviewed, fix iOS build with recent SDKs.

Source/WebCore:

  • platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

Source/WebKit:

  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _EVOrganizationName]):

4:32 PM Changeset in webkit [237951] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix iOS build with recent SDKs.

  • platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

4:30 PM Changeset in webkit [237950] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

Custom test group form should use commit set map before customization as the behavior of radio buttons.
​https://bugs.webkit.org/show_bug.cgi?id=191347

Reviewed by Ryosuke Niwa.

The radio button behavior should always set the same revision while editing the revision input.
That means we should not use the intermediate commit set map but use the commit set map before
"Customize" link is clicked.

  • browser-tests/customizable-test-group-form-tests.js: Added a unit test for this bug.
  • public/v3/components/customizable-test-group-form.js: Pass uncustomized commit set so that the radio button

behavoir preserves.
(CustomizableTestGroupForm):
(CustomizableTestGroupForm.prototype.setCommitSetMap):
(CustomizableTestGroupForm.prototype.didConstructShadowTree):
(CustomizableTestGroupForm.prototype.render):
(CustomizableTestGroupForm.prototype._renderCustomRevisionTable):
(CustomizableTestGroupForm.prototype._constructTableBodyList):
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithoutOwner):
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithOwner):
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons):

4:15 PM Changeset in webkit [237949] by wilander@apple.com
  • 4 edits in trunk/Source/WebKit

Resource Load Statistics: Enable cap on partitioned cache max age
​https://bugs.webkit.org/show_bug.cgi?id=191395
<rdar://problem/45885977>

Reviewed by Chris Dumez.

This change does not bump the network cache revision number.
It's not needed since it was done just a week ago.

  • UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::setCacheMaxAgeCap):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCacheMaxAgeCap):

  • UIProcess/ResourceLoadStatisticsMemoryStore.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess):

4:10 PM Changeset in webkit [237948] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

Dotted underlines that skip descenders are invisible
​https://bugs.webkit.org/show_bug.cgi?id=191403

Reviewed by Simon Fraser.

Source/WebCore:

Turns out our underline bounding boxes had negative width. When drawing the full
underline that was fine because it was handled by the 2D graphics engine, but when
we try to split up the box into dots, our "for" loop was taking 0 iterations (because
the end was before the start).

Test: fast/css3-text/css3-text-decoration/text-underline-style.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawLineForText):

LayoutTests:

  • fast/css3-text/css3-text-decoration/text-underline-style-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-style.html: Added.
3:49 PM Changeset in webkit [237947] by aestes@apple.com
  • 5 edits in trunk

Crash in WebCore::PaymentRequest::canMakePayment when Apple Pay payment method data is missing
​https://bugs.webkit.org/show_bug.cgi?id=191331

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Apple Pay requires merchants specify an ApplePayRequest (which contains several required
fields) as payment method data when constructing a new PaymentRequest. If the
ApplePayRequest is missing required fields, or is missing entirely, canMakePayment() should
resolve to false.

We would properly resolve to false when an ApplePayRequest was specified with missing
required fields, but we would crash when the ApplePayRequest was missing entirely.

This patch fixes the crash by checking for an empty JSValue before trying to convert it to
an ApplePayRequest struct. Because we stringify ApplePayRequests in the PaymentRequest
constructor then parse them again in canMakePayments, an undefined or null payment method
data stringifies to a null String, which then parses to an empty JSValue.

Added test case to http/tests/paymentrequest/payment-request-canmakepayment-method.https.html.

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::convertData):

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

  • http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
3:02 PM Changeset in webkit [237946] by Simon Fraser
  • 3 edits
    2 deletes in trunk

Revert 237849: it breaks MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=191398

Reviewed by Simon Fraser.

Source/WebCore:

This change broke painting while the test is running.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):

LayoutTests:

  • fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Removed.
  • fast/scrolling/ios/update-scroll-coordinated-status.html: Removed.
2:14 PM Changeset in webkit [237945] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

[iOS] Support deleting to the start of the line and to the end of the line
​https://bugs.webkit.org/show_bug.cgi?id=191389
<rdar://problem/45883972>

Reviewed by Wenson Hsieh.

Add support for the key commands Command + Delete and Control + K to delete to the start
of the line and to delete to the end of the line, respectively.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deleteToStartOfLine]): Added.
(-[WKContentView _deleteToEndOfLine]): Added.

2:12 PM Changeset in webkit [237944] by don.olmstead@sony.com
  • 4 edits in trunk/Source/WebCore

Simplify macros in platform
​https://bugs.webkit.org/show_bug.cgi?id=191378

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Modifies a few cases where a platform macro could be simplified.

  • page/EventHandler.cpp:
  • platform/network/DNS.h:
  • platform/network/NetworkStateNotifier.h:
2:11 PM Changeset in webkit [237943] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

[iOS] Option + Delete should delete previous word
​https://bugs.webkit.org/show_bug.cgi?id=191381
<rdar://problem/23681351>

Reviewed by Wenson Hsieh.

Implement support for pressing Option + Delete to delete the previous word. This makes text editing
in WebKit more closely match the platform conventions.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deleteByWord]):

1:46 PM Changeset in webkit [237942] by Simon Fraser
  • 6 edits
    1 add in trunk

Some WK1 repaint tests are flakey
​https://bugs.webkit.org/show_bug.cgi?id=190627

Reviewed by Zalan Bujtas.
Source/WebCore:

Repaint tracking in GraphicsLayerCA was sensitive to whether there were already dirty
rects on the layer, since tracking happened after checks against existing dirty rects.
This caused some WK1 repaint tests to be flakey, since there's no guarantee that
no repaints happen between the last layer flush and a test calling startTrackingRepaints().

Fix by moving the repaint tracking to before the checks against existing dirty rects.
This is more similar to how repaint tracking on FrameView works.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):

LayoutTests:

New baseline.

  • compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
1:23 PM Changeset in webkit [237941] by Ross Kirsling
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

  • platform/wincairo/TestExpectations:
1:12 PM Changeset in webkit [237940] by dino@apple.com
  • 4 edits
    2 adds in trunk

[iOS] WebGL leaks exact GPU type
​https://bugs.webkit.org/show_bug.cgi?id=191393
Source/WebCore:

Reviewed by Tim Horton.

The fully exposed renderer info shouldn't be necessary
on iOS, where the GPUs and drivers are consistent
enough that people shouldn't need to write code specifically
for them. Reduce the ability to fingerprint by simply
returning "Apple GPU".

The other option would have been to disable the extension,
but I think it might still be useful to know you're on
an iOS device.

Test: fast/canvas/webgl/hide-some-renderer-info.html

  • html/canvas/WebGL2RenderingContext.cpp: Return "Apple GPU"

on iOS.
(WebCore::WebGL2RenderingContext::getParameter):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

<rdar://problem/45788297>

Reviewed by Tim Horton.

A test that checks that when the GPU vendor is Apple we're
returning a generic renderer name.

  • fast/canvas/webgl/hide-some-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/hide-some-renderer-info.html: Added.
1:00 PM Changeset in webkit [237939] by ajuma@chromium.org
  • 3 edits in trunk/LayoutTests

IntersectionObserver GC-dependent tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=191387

Reviewed by Chris Dumez.

Make these tests more robust by triggering GC repeatedly inside a setInterval(). Having only a single call to
GC is potentially flaky, since that call will early-out and return immediately if a GC is already underway.

  • intersection-observer/root-element-deleted.html:
  • intersection-observer/target-deleted.html:
12:59 PM Changeset in webkit [237938] by Kocsen Chung
  • 7 edits in trunk/Source

Versioning.

12:55 PM Changeset in webkit [237937] by Alan Coon
  • 12 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Cherry-pick r237933. rdar://problem/45739094

Align wide opcodes in the instruction stream
​https://bugs.webkit.org/show_bug.cgi?id=191254

Reviewed by Keith Miller.

Pad the bytecode with nops to ensure that wide opcodes are 4-byte
aligned on platforms that don't like unaligned memory access.

For that, add a new type to represent jump targets, BoundLabel, which
delays computing the offset in case we need to emit nops for padding.
Extra padding is also emitted before op_yield and at the of each
BytecodeWriter fragment, to ensure that the bytecode remains aligned
after the rewriting.

As a side effect, we can longer guarantee that the point immediately
before emitting an opcode is the start of that opcode, since nops
might be emitted in between if the opcode needs to be wide. To fix
that, we only take the offset of opcodes after they have been emitted,
using m_lastInstruction.offset().

  • bytecode/BytecodeDumper.h: (JSC::BytecodeDumper::dumpValue):
  • bytecode/BytecodeGeneratorification.cpp: (JSC::BytecodeGeneratorification::run):
  • bytecode/BytecodeList.rb:
  • bytecode/BytecodeRewriter.h: (JSC::BytecodeRewriter::Fragment::align): (JSC::BytecodeRewriter::insertFragmentBefore): (JSC::BytecodeRewriter::insertFragmentAfter):
  • bytecode/Fits.h:
  • bytecode/InstructionStream.h: (JSC::InstructionStreamWriter::ref):
  • bytecode/PreciseJumpTargetsInlines.h: (JSC::updateStoredJumpTargetsForInstruction):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::Label::setLocation): (JSC::BoundLabel::target): (JSC::BoundLabel::saveTarget): (JSC::BoundLabel::commitTarget): (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::recordOpcode): (JSC::BytecodeGenerator::alignWideOpcode): (JSC::BytecodeGenerator::emitProfileControlFlow): (JSC::BytecodeGenerator::emitResolveScope): (JSC::BytecodeGenerator::emitGetFromScope): (JSC::BytecodeGenerator::emitPutToScope): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitDirectGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitDirectPutById): (JSC::BytecodeGenerator::emitGetByVal): (JSC::BytecodeGenerator::emitCreateThis): (JSC::BytecodeGenerator::beginSwitch): (JSC::BytecodeGenerator::endSwitch): (JSC::BytecodeGenerator::emitRequireObjectCoercible): (JSC::BytecodeGenerator::emitYieldPoint): (JSC::BytecodeGenerator::emitToThis): (JSC::Label::bind): Deleted.
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::recordOpcode): Deleted.
  • bytecompiler/Label.h: (JSC::BoundLabel::BoundLabel): (JSC::BoundLabel::operator int): (JSC::Label::bind):
  • generator/Opcode.rb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:50 PM Changeset in webkit [237936] by Alan Coon
  • 1 copy in tags/Safari-607.1.13

Tag Safari-607.1.13.

12:12 PM Changeset in webkit [237935] by dbates@webkit.org
  • 12 edits in trunk

Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=190141

Reviewed by Darin Adler.

Source/WebCore:

Remove the runtime application check for WebKitTestRunner as we no longer need this
now that WebKitTestRunner and DumpRenderTree override +[UIKeyboard isInHardwareKeyboardMode].

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isWebKitTestRunner): Deleted.

Source/WebKit:

Directly use +[UIKeyboard isInHardwareKeyboardMode]. We will override this class method
in DumpRenderTree and WebKitTestRunner to always return NO so as to make test runs
deterministic regardless of whether a hardware keyboard is attached.

  • Shared/NativeWebKeyboardEvent.h:
  • Shared/ios/NativeWebKeyboardEventIOS.mm:

(WebKit::isInHardwareKeyboardMode): Deleted.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Tools:

Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
runs deterministic regardless of whether a hardware keyboard is attached.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(overrideIsInHardwareKeyboardMode): Added.
(prepareConsistentTestingEnvironment):

  • TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(overrideIsInHardwareKeyboardMode): Added.
(WTR::TestController::platformInitialize):

11:48 AM Changeset in webkit [237934] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol generated objects
​https://bugs.webkit.org/show_bug.cgi?id=191340

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-07
Reviewed by Devin Rousso.

Source/JavaScriptCore:

  • inspector/ConsoleMessage.cpp:

(Inspector::messageSourceValue):
Use new enum name.

  • inspector/scripts/codegen/generator.py:

Correct the casing of "JavaScript".

Source/WebCore:

  • inspector/agents/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):
Use new enum name.

Source/WebInspectorUI:

  • UserInterface/Models/Canvas.js:

(WI.Canvas.fromPayload):
Insert a missing break statement for the WebGPU case.

  • UserInterface/Models/MemoryTimelineRecord.js:

(WI.MemoryTimelineRecord.memoryCategoriesFromProtocol):
Use new enum name.

  • UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

Update enums with new generator.

11:38 AM Changeset in webkit [237933] by Tadeu Zagallo
  • 12 edits in trunk/Source/JavaScriptCore

Align wide opcodes in the instruction stream
​https://bugs.webkit.org/show_bug.cgi?id=191254

Reviewed by Keith Miller.

Pad the bytecode with nops to ensure that wide opcodes are 4-byte
aligned on platforms that don't like unaligned memory access.

For that, add a new type to represent jump targets, BoundLabel, which
delays computing the offset in case we need to emit nops for padding.
Extra padding is also emitted before op_yield and at the of each
BytecodeWriter fragment, to ensure that the bytecode remains aligned
after the rewriting.

As a side effect, we can longer guarantee that the point immediately
before emitting an opcode is the start of that opcode, since nops
might be emitted in between if the opcode needs to be wide. To fix
that, we only take the offset of opcodes after they have been emitted,
using m_lastInstruction.offset().

  • bytecode/BytecodeDumper.h:

(JSC::BytecodeDumper::dumpValue):

  • bytecode/BytecodeGeneratorification.cpp:

(JSC::BytecodeGeneratorification::run):

  • bytecode/BytecodeList.rb:
  • bytecode/BytecodeRewriter.h:

(JSC::BytecodeRewriter::Fragment::align):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):

  • bytecode/Fits.h:
  • bytecode/InstructionStream.h:

(JSC::InstructionStreamWriter::ref):

  • bytecode/PreciseJumpTargetsInlines.h:

(JSC::updateStoredJumpTargetsForInstruction):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC::BoundLabel::target):
(JSC::BoundLabel::saveTarget):
(JSC::BoundLabel::commitTarget):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::recordOpcode):
(JSC::BytecodeGenerator::alignWideOpcode):
(JSC::BytecodeGenerator::emitProfileControlFlow):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitDirectGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCreateThis):
(JSC::BytecodeGenerator::beginSwitch):
(JSC::BytecodeGenerator::endSwitch):
(JSC::BytecodeGenerator::emitRequireObjectCoercible):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitToThis):
(JSC::Label::bind): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::recordOpcode): Deleted.

  • bytecompiler/Label.h:

(JSC::BoundLabel::BoundLabel):
(JSC::BoundLabel::operator int):
(JSC::Label::bind):

  • generator/Opcode.rb:
11:33 AM Changeset in webkit [237932] by mitz@apple.com
  • 12 edits
    2 adds in trunk

Add a pseudoclass that matches img elements that are backed by an attachment
​https://bugs.webkit.org/show_bug.cgi?id=191286
<rdar://problem/45823554>

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css/has-attachment.html

Added a :has-attachment pseudoclass, enabled only when the attachment element is enabled at
runtime, that matches elements (currently only img elements qualify) that have an attachment
element in their shadow DOM.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const): Handle the new PseudoClassHasAttachment value.

  • css/CSSSelector.h: Added a new value to the PseudoClassType enum.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const): Check the new PseudoClassHasAttachment value

using the new hasAttachment test function.

  • css/SelectorCheckerTestFunctions.h:

(WebCore::hasAttachment): Added. Tests if the element is an img element that has an

attachment.

  • css/SelectorPseudoClassAndCompatibilityElementMap.in: Added has-attachment.
  • css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::CSSParserContext): Initialize new attachmentEnabled member based

on RuntimeEnabledFeatures.

(WebCore::operator==): Compare new attachmentEnabled member.

  • css/parser/CSSParserContext.h:

(WebCore::CSSParserContextHash::hash): Include new attachmentEnabled member.

  • css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo): Reject :has-attachment if the attachment

element is not enabled.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType): Handle PseudoClassHasAttachment.

LayoutTests:

  • fast/css/has-attachment-expected.txt: Added.
  • fast/css/has-attachment.html: Added.
  • platform/win/TestExpectations:
11:25 AM Changeset in webkit [237931] by Jonathan Bedard
  • 3 edits in trunk/Tools

Unreviewed, rolling out r237913.

Breaks running tests on Mac without iOS SDK installed

Reverted changeset:

"webkitpy: Generalize trailing SDK specifier (Part 2)"
​https://bugs.webkit.org/show_bug.cgi?id=191275
​https://trac.webkit.org/changeset/237913

10:49 AM Changeset in webkit [237930] by don.olmstead@sony.com
  • 4 edits
    1 delete in trunk/Source/WebCore

Make generic MainThreadSharedTimer implementation
​https://bugs.webkit.org/show_bug.cgi?id=191327

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Moves generic implementation for MainThreadSharedTimerGlib.cpp into
MainThreadSharedTimer.cpp.

  • platform/MainThreadSharedTimer.cpp:

(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::invalidate):

  • platform/MainThreadSharedTimer.h:
  • platform/SourcesGLib.txt:
  • platform/glib/MainThreadSharedTimerGLib.cpp: Removed.
10:30 AM Changeset in webkit [237929] by ajuma@chromium.org
  • 5 edits
    2 adds in trunk

IntersectionObserverEntry doesn't keep JS wrappers of rects alive
​https://bugs.webkit.org/show_bug.cgi?id=191330

Reviewed by Chris Dumez.

Source/WebCore:

Retain wrappers of each rect in an IntersectionObserverEntry as long as the entry's wrapper
is alive, by adding these wrappers as opaque roots.

Test: intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive.html

  • bindings/js/JSIntersectionObserverEntryCustom.cpp:

(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren):

  • dom/DOMRectReadOnly.idl:
  • page/IntersectionObserverEntry.h:

(WebCore::IntersectionObserverEntry::rootBounds const): Make this return a raw pointer instead of a RefPtr so that it
can be called in JSIntersectionObserverEntry::visitAdditionalChildren, which can be called from non-main threads.
(WebCore::IntersectionObserverEntry::boundingClientRect const): Ditto.
(WebCore::IntersectionObserverEntry::intersectionRect const): Ditto.

LayoutTests:

Add test coverage.

  • intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive-expected.txt: Added.
  • intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive.html: Added.
9:30 AM Changeset in webkit [237928] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Unreviewed, update test expectations for fast/events/pointer.

  • TestExpectations: Skip this directory.
  • platform/ios/TestExpectations: Remove skip since it is now skipped globally.
9:04 AM Changeset in webkit [237927] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/text/international/khmer-selection.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=191368

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:57 AM Changeset in webkit [237926] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/block/basic/quirk-mode-percent-height.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=191366

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:21 AM Changeset in webkit [237925] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

TileController::tileSize() should not have side effects
​https://bugs.webkit.org/show_bug.cgi?id=191349

Reviewed by Zalan Bujtas.

Calling TileController::tileSize() would recompute a new tile size and set m_tileSizeLocked,
which caused test failures if logging was enabled when running tests.

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileSize const):
(WebCore::TileController::computeTileSize):

  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::revalidateTiles):

6:57 AM Changeset in webkit [237924] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

Source/WebKit:
Force a gregorian calendar to show for credit card expiration date inputs
(autocomplete='cc-exp'*) regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Added some plumbing code to expose the calendar identifier of the calendar used by a
presented date picker. Added shouldPresentGregorianCalendar:, to be used for
determining what property values a date input control must present a Gregorian
calendar for.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView formInputPeripheral]):

  • UIProcess/ios/forms/WKFormInputControl.mm:

Tools:
Force a gregorian calendar to show for credit card expiration date inputs
(autocomplete='cc-exp'*) regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Implemented simulateForeignDefaultCalendar and calendarType to be used
for changing the default calendar returned by the system (ie. [NSCalendar
currentCalendar]) and getting the calendar type identifier of a presented date
picker.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isShowingDataListSuggestions const):
(WTR::UIScriptController::calendarType const):
(WTR::UIScriptController::setDefaultCalendarType):

  • DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::calendarType const):
(WTR::UIScriptController::setDefaultCalendarType):

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::calendarType const): Deleted.

  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::calendarType const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::swizzledCalendar):
(WTR::TestController::getOverriddenCalendarIdentifier const):
(WTR::TestController::setDefaultCalendarType):
(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::calendarType const): Deleted.

LayoutTests:
Created a layout test to ensure that date controls marked as credit card expiry
fields present a Gregorian calendar regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Added two new methods to UIHelper, helping to facilitate this. calendarType
returns the calendar identifier of the NSCalendar instance used by the presented
date picker and setDefaultCalendarType accepts a calendar identifier as an
argument for changing the default system settings.

  • fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html:
  • platform/win/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.calendarType):
(window.UIHelper.setDefaultCalendarType):

6:49 AM Changeset in webkit [237923] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK/WPE build when memfd is not available after r237922.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::createSharedMemory):

6:24 AM Changeset in webkit [237922] by Carlos Garcia Campos
  • 4 edits in trunk

[Linux] Use memfd_create when available in SharedMemory implementation
​https://bugs.webkit.org/show_bug.cgi?id=189741

Reviewed by Michael Catanzaro.

.:

Add include check for linux/memfd.h header.

  • Source/cmake/OptionsCommon.cmake:

Source/WebKit:

If memfd is available, use it instead of shm_open.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::createSharedMemory): Helper to create the shared memory, trying first with memfd and falling back to
shm if it's not available.
(WebKit::SharedMemory::create): Use createSharedMemory() helper.

3:50 AM Changeset in webkit [237921] by cturner@igalia.com
  • 5 edits in trunk/Source/WebCore

[EME][GStreamer] Ensure key id buffers are present and simplify lifetime management of ClearKey class.
​https://bugs.webkit.org/show_bug.cgi?id=191157

Reviewed by Xabier Rodriguez-Calvar.

This is in preparation for moving the clearkey decryptor behind a
new decrypt API in CDMInstance, which will be sent into the
pipeline to handle key management and decryption. This is for a
later patch.

Covered by existing clear key tests in media/encrypted-media.

  • platform/graphics/gstreamer/GStreamerCommon.h:

(WebCore::GstMappedBuffer::data const): Add a const data accessor,
since we are now providing operator=='s on const objects of this
class that need const access to the data pointer.
(WebCore::GstMappedBuffer::operator==): Add a swap of the new
equality operator so you don't have to remember to have the
GstBuffer on the RHS of the equality all the time.
(WebCore::operator==): Define an equality operator between Gst
buffers and WebCore's mapped buffers. Gst creates a ref and a
separate read view under the covers in the memcmp call, so we do
not need to map the buffer ourselves.

  • platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init): Remove setup/release
bindings.
(webkit_media_clear_key_decrypt_init): Initialize gcrypt cipher
here once instead of for every buffer to be decrypted.
(webKitMediaClearKeyDecryptorFinalize): And destroy the cipher
context when the decryptor is destroyed.
(webKitMediaClearKeyDecryptorFindAndSetKey): Factor out the key
retrieval and context setting in this method, call it for each
sample.
(webKitMediaClearKeyDecryptorDecrypt): Base key id buffer into
this function, and remove cipher creation / destroy methods.

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init): Remove
setup/release bindings.
(webkitMediaCommonEncryptionDecryptTransformInPlace): Ensure a key
id is present and pass it to the decrypt class method.
(webKitMediaCommonEncryptionDecryptDefaultSetupCipher): Deleted.
(webKitMediaCommonEncryptionDecryptDefaultReleaseCipher): Deleted.

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
3:29 AM Changeset in webkit [237920] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179610

Unreviewed build fix.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-07

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Add missing include.
1:05 AM Changeset in webkit [237919] by Tadeu Zagallo
  • 69 edits in trunk

REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
​https://bugs.webkit.org/show_bug.cgi?id=191184

Reviewed by Saam Barati.

JSTests:

Most tests were failing due to timeouts, since they are too slow to
run on CLoop. The exceptions are:

proxy-get-set-correct-receiver.js: Had to reduce the recursion depth not to overflow on CLoop
dont-crash-on-stack-overflow-when-parsing-builtin.js and
dont-crash-on-stack-overflow-when-parsing-default-constructor.js: had
to change the stack size since CLoop requires it to be page aligned.

  • microbenchmarks/array-push-1.js:
  • microbenchmarks/array-push-2.js:
  • microbenchmarks/elidable-new-object-dag.js:
  • microbenchmarks/elidable-new-object-roflcopter.js:
  • microbenchmarks/elidable-new-object-tree.js:
  • microbenchmarks/getter-richards.js:
  • microbenchmarks/sinkable-new-object-dag.js:
  • microbenchmarks/string-concat-long-convert.js:
  • microbenchmarks/typed-array-get-set-by-val-profiling.js:
  • slowMicrobenchmarks/array-push-3.js:
  • slowMicrobenchmarks/large-map-iteration-with-additions.js:
  • slowMicrobenchmarks/spread-small-array.js:
  • slowMicrobenchmarks/undefined-property-access.js:
  • stress/activation-sink-default-value-tdz-error.js:
  • stress/activation-sink-default-value.js:
  • stress/activation-sink-osrexit-default-value-tdz-error.js:
  • stress/activation-sink-osrexit-default-value.js:
  • stress/activation-sink-osrexit.js:
  • stress/activation-sink.js:
  • stress/allow-math-ic-b3-code-duplication.js:
  • stress/array-push-multiple-int32.js:
  • stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js:
  • stress/arrowfunction-lexical-this-activation-sink-osrexit.js:
  • stress/arrowfunction-lexical-this-activation-sink.js:
  • stress/dont-crash-on-stack-overflow-when-parsing-builtin.js:
  • stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js:
  • stress/elide-new-object-dag-then-exit.js:
  • stress/materialize-regexp-cyclic.js:
  • stress/new-regex-inline.js:
  • stress/op_add.js:
  • stress/op_bitand.js:
  • stress/op_bitor.js:
  • stress/op_bitxor.js:
  • stress/op_div-ConstVar.js:
  • stress/op_div-VarConst.js:
  • stress/op_div-VarVar.js:
  • stress/op_lshift-ConstVar.js:
  • stress/op_lshift-VarConst.js:
  • stress/op_lshift-VarVar.js:
  • stress/op_mod-ConstVar.js:
  • stress/op_mod-VarConst.js:
  • stress/op_mod-VarVar.js:
  • stress/op_mul-ConstVar.js:
  • stress/op_mul-VarConst.js:
  • stress/op_mul-VarVar.js:
  • stress/op_rshift-ConstVar.js:
  • stress/op_rshift-VarConst.js:
  • stress/op_rshift-VarVar.js:
  • stress/op_sub-ConstVar.js:
  • stress/op_sub-VarConst.js:
  • stress/op_sub-VarVar.js:
  • stress/op_urshift-ConstVar.js:
  • stress/op_urshift-VarConst.js:
  • stress/op_urshift-VarVar.js:
  • stress/proxy-get-set-correct-receiver.js:
  • stress/regress-179562.js:
  • stress/rest-parameter-many-arguments.js:
  • stress/sampling-profiler-richards.js:
  • stress/splay-flash-access-1ms.js:
  • stress/tailCallForwardArguments.js:
  • stress/typed-array-get-by-val-profiling.js:
  • typeProfiler/getter-richards.js:

PerformanceTests:

Skip test when the JIT is disabled, it takes too long to run on CLoop.

  • JetStream/cdjs/main.js:

Source/JavaScriptCore:

Fix API test on CLoop: we can only disable the LLInt when the JIT is enabled.

  • API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

LayoutTests:

Skip test when the JIT is disabled since it's too slow to run on CLoop.

  • js/script-tests/regress-139548.js:

Nov 6, 2018:

11:43 PM Changeset in webkit [237918] by youenn@apple.com
  • 4 edits
    1 delete in trunk/LayoutTests

Reenable imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ontrack.https.html
​https://bugs.webkit.org/show_bug.cgi?id=191343

Unreviewed.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-ontrack.https-expected.txt:

LayoutTests:

  • TestExpectations: Unskipping test.
  • platform/ios-wk2/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-ontrack.https-expected.txt: Removed.
11:32 PM Changeset in webkit [237917] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating 'resource.target.addResource')
​https://bugs.webkit.org/show_bug.cgi?id=191339

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-06
Reviewed by Matt Baker.

  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
Use the Service Worker's identifier, not this static but otherwise unknown identifier.

10:05 PM Changeset in webkit [237916] by youenn@apple.com
  • 7 edits in trunk

sender.replaceTrack() fails with InvalidStateError if the transceiver.direction is "inactive"
​https://bugs.webkit.org/show_bug.cgi?id=191202

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Changes made upstreamed.

  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html:

Source/WebCore:

Covered by updated test.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::removeTrack):
Update as per spec, in particular make sure to not stop the sender when removing the track.

LayoutTests:

It is already timing out but is also flaky.

9:58 PM Changeset in webkit [237915] by Dewei Zhu
  • 3 edits
    1 add in trunk/Websites/perf.webkit.org

Customizable test group form should not reset manually edited commit value sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=190863

Reviewed by Ryosuke Niwa.

After changing the radio button and manually editing the commit value, commit value should not be reset
while changing the name of the test group.
Add the logic to prompt warning when manually typed commit does not exist.

  • browser-tests/customizable-test-group-form-tests.js: Added a unit test for this bug.
  • browser-tests/index.html:
  • public/v3/components/customizable-test-group-form.js: Should always update commit set as long as

the repository of that row does not have a owner repository.
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithoutOwner):
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithOwner):
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons):

9:06 PM Changeset in webkit [237914] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Boot a single worker for custom devices
​https://bugs.webkit.org/show_bug.cgi?id=191312
<rdar://problem/45848717>

Rubber-stamped by Aakash Jain.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): Custom devices only run a hand-full of tests. Booting multiple
simulators is expensive and unneeded for these tests.

  • Scripts/webkitpy/port/ios.py:

(IOSPort. child_processes): No reason to memoize this call, and it prevents
overriding the number of child processes when booting custom devices.

9:01 PM Changeset in webkit [237913] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Generalize trailing SDK specifier (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Reviewed by Aakash Jain.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort): Use normalized SDK.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Use normalized SDK.
(IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.

8:37 PM Changeset in webkit [237912] by Justin Fan
  • 36 edits
    17 copies
    5 adds in trunk

[WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
​https://bugs.webkit.org/show_bug.cgi?id=191291

Reviewed by Myles Maxfield.

Source/JavaScriptCore:

Properly disable WEBGPU on all non-Metal platforms for now.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Test: webgpu/render-pipelines.html
Also update test webgpu/webgpu-basics.html to create a WebGPURenderPipeline.

Begin implementation of WebGPURenderPipeline and WebGPUSwapChain. A WebGPURenderPipeline is backed by a
GPURenderPipeline, created lazily using the properties of the passed-in WebGPURenderPipelineDescriptor.
On Metal-supported systems, GPURenderPipeline is an interface to a MTLRenderPipelineState.
The MTLRenderPipelineState is created with the WebGPUDevice currently configured on the WebGPURenderingContext.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • Modules/webgpu/GPUDevice.cpp:

(WebCore::GPUDevice::createRenderPipeline const):

  • Modules/webgpu/GPUDevice.h:
  • Modules/webgpu/GPUPipelineDescriptorBase.h:
  • Modules/webgpu/GPUPipelineStageDescriptor.h:
  • Modules/webgpu/GPURenderPipelineDescriptor.h:

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):
(WebCore::GPURenderPipelineDescriptor::primitiveTopology):

  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createRenderPipeline const):

  • Modules/webgpu/WebGPUDevice.h:

(WebCore::WebGPUDevice::adapter const):
(WebCore::WebGPUDevice::device const):

  • Modules/webgpu/WebGPUDevice.idl:
  • Modules/webgpu/WebGPUPipelineDescriptorBase.h:
  • Modules/webgpu/WebGPUPipelineDescriptorBase.idl:
  • Modules/webgpu/WebGPUPipelineStageDescriptor.h:
  • Modules/webgpu/WebGPUPipelineStageDescriptor.idl:
  • Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):

  • Modules/webgpu/WebGPURenderPipeline.h:
  • Modules/webgpu/WebGPURenderPipeline.idl:
  • Modules/webgpu/WebGPURenderPipelineDescriptor.h:
  • Modules/webgpu/WebGPURenderPipelineDescriptor.idl:
  • Modules/webgpu/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::create):
(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • Modules/webgpu/WebGPURenderingContext.h:
  • Modules/webgpu/WebGPUShaderModule.h:

(WebCore::WebGPUShaderModule::module const):

  • Modules/webgpu/WebGPUShaderStage.h:
  • Modules/webgpu/WebGPUShaderStage.idl:
  • Modules/webgpu/WebGPUSwapChain.cpp:

(WebCore::WebGPUSwapChain::configure):
(WebCore::WebGPUSwapChain::reshape):
(WebCore::WebGPUSwapChain::markLayerComposited):

  • Modules/webgpu/WebGPUSwapChain.h:

(WebCore::WebGPUSwapChain::WebGPUSwapChain):

  • Modules/webgpu/WebGPUSwapChain.idl:
  • Modules/webgpu/cocoa/GPURenderPipeline.h:

(WebCore::GPURenderPipeline::platformRenderPipeline const):

  • Modules/webgpu/cocoa/GPURenderPipelineMetal.mm: Added.

(WebCore::setFunctionsForPipelineDescriptor):
(WebCore::GPURenderPipeline::create):
(WebCore::GPURenderPipeline::GPURenderPipeline):

  • Modules/webgpu/cocoa/GPUSwapChain.h:

(WebCore::GPUSwapChain::platformLayer const):

  • Modules/webgpu/cocoa/GPUSwapChainMetal.mm:

(WebCore::GPUSwapChain::create):
(WebCore::GPUSwapChain::GPUSwapChain):
(WebCore::GPUSwapChain::setDevice):
(WebCore::GPUSwapChain::reshape):
(WebCore::GPUSwapChain::present):

  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:

Source/WebCore/PAL:

Properly disable WEBGPU on all non-Metal platforms for now.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Properly disable WEBGPU on all non-Metal platforms for now.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Properly disable WEBGPU on all non-Metal platforms for now.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Properly disable WEBGPU on all non-Metal platforms for now.

  • wtf/Platform.h:

Tools:

Properly disable WEBGPU on all non-Metal platforms for now.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • webgpu/js/set-up-webgpu-contexts.js: Added helper script for running different webgpu tests.

(runWebGPUTests):
(async.runWebGPUTestsOnCanvas):
(async.setUpContexts):

  • webgpu/render-pipelines-expected.txt: Added.
  • webgpu/render-pipelines.html: Added.
  • webgpu/shader-modules-expected.txt:
  • webgpu/shader-modules.html: Updated to use functions in set-up-webgpu-contexts.js.
  • webgpu/webgpu-basics-expected.txt:
  • webgpu/webgpu-basics.html: Updated through creating a WebGPURenderPipeline.
8:01 PM Changeset in webkit [237911] by youenn@apple.com
  • 20 edits
    2 adds in trunk

Add support for sender/receiver getCapabilities
​https://bugs.webkit.org/show_bug.cgi?id=191192

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCRtpCapabilities-helper.js:

(string_appeared_here.validateRtpCapabilities): Change already made upstream.

  • web-platform-tests/webrtc/RTCRtpReceiver-getCapabilities-expected.txt:
  • web-platform-tests/webrtc/RTCRtpSender-getCapabilities-expected.txt:
  • web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences-expected.txt:

Source/WebCore:

Expose sender/receiver RTCRtpCapabilities to JS.
Add corresponding IDL and plumbing down to libwebrtc peer connection factory.
Covered by rebased tests.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::receiverCapabilities):
(WebCore::PeerConnectionBackend::senderCapabilities):

  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCRtpCapabilities.idl: Added.
  • Modules/mediastream/RTCRtpReceiver.cpp:

(WebCore::RTCRtpReceiver::getCapabilities):

  • Modules/mediastream/RTCRtpReceiver.h:
  • Modules/mediastream/RTCRtpReceiver.idl:
  • Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::getCapabilities):

  • Modules/mediastream/RTCRtpSender.h:
  • Modules/mediastream/RTCRtpSender.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::receiverCapabilities):
(WebCore::PeerConnectionBackend::senderCapabilities):

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/RTCPMuxPolicy.h:
  • platform/mediastream/RTCRtpCapabilities.h: Added.
  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::typeFromKind):
(WebCore::fromStdString):
(WebCore::toChannels):
(WebCore::toRTCRtpCapabilities):
(WebCore::LibWebRTCProvider::receiverCapabilities):
(WebCore::LibWebRTCProvider::senderCapabilities):

  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:
7:23 PM Changeset in webkit [237910] by youenn@apple.com
  • 10 edits in trunk

Calling sender.replaceTrack() twice produces a new transceiver and its corresponding m= section
​https://bugs.webkit.org/show_bug.cgi?id=191261

Reviewed by Eric Carlson.

Source/WebCore:

Handle the case of replacing a track in a sender that has no track.
In particular, do not create a new m-section as was implied by plan B implementation.
Instead, set the track directly on the rtc sender.
Covered by webrtc/video-addTransceiver.html.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::createSourceAndRTCTrack):
(WebCore::LibWebRTCMediaEndpoint::addTransceiver):
(WebCore::LibWebRTCMediaEndpoint::setSenderSourceFromTrack):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::setSenderSourceFromTrack):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

LayoutTests:

  • webrtc/video-addTransceiver-expected.txt:
  • webrtc/video-addTransceiver.html:
7:12 PM Changeset in webkit [237909] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Post too much text to iFrame could crash webkit
​https://bugs.webkit.org/show_bug.cgi?id=190947
<rdar://problem/45678231>

Reviewed by Geoffrey Garen.

Optimize SuffixTree (Which is used by XSSAuditor) to stop storing each Node's
children as a static array of 128 pointers and use a dynamic array (vector)
instead. This uses way less memory. Also make SuffixTree and SuffixTree::Node
as fast allocated for performance. This part of the change is based on the
following Blink change:

Also update the XSSAuditor to construct the SuffixTree lazily since there are
many cases (including the one in this bug) where we were spending a significant
amount of time building the SuffixTree and then never querying it.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::decodedHTTPBodySuffixTree):
(WebCore::XSSAuditor::isContainedInRequest):

  • html/parser/XSSAuditor.h:
  • platform/text/SuffixTree.h:

(WebCore::SuffixTree::mightContain):
(WebCore::SuffixTree::Node::Node):
(WebCore::SuffixTree::Node::~Node):
(WebCore::SuffixTree::Node::find):
(WebCore::SuffixTree::Node::end):
(WebCore::SuffixTree::build):
(WebCore::SuffixTree<Codebook>::Node::childAt):
(WebCore::SuffixTree::Node::at): Deleted.

6:31 PM Changeset in webkit [237908] by youenn@apple.com
  • 5 edits in trunk

Support onremovetrack for RTCPeerConnection removed tracks
​https://bugs.webkit.org/show_bug.cgi?id=191299

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:

Source/WebCore:

When applying SDP, LibWebRTCMediaEndpoint gets notified of a removed track.
In that case, make sure to remove it from its remote stream(s) so as
to notify the application of the changes.
Work around the receiver missing the list of streams by storing in a map
the list of the remote streams for a given remote track.

Covered by rebased test.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::stop):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
6:08 PM Changeset in webkit [237907] by aakash_jain@apple.com
  • 2 edits
    1 add in trunk/Tools

[ews-app] Add URL configuration for OpenSource EWS Django app
​https://bugs.webkit.org/show_bug.cgi?id=191132

Rubber-stamped by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
  • BuildSlaveSupport/ews-app/ews/urls.py: Added.
5:59 PM Changeset in webkit [237906] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r237878): css-dark-mode/supported-color-schemes.html is failing on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=191338

Reviewed by Dean Jackson.

  • page/Page.cpp:

(WebCore::Page::appearanceDidChange): Add back call to didChangeStyleSheetEnvironment().
It was dropped by mistake when I moved code to appearanceDidChange(). This is needed to
update styles for semantic colors and from controls when the media prefers-color-scheme
media query is not used on the page.

5:57 PM Changeset in webkit [237905] by youenn@apple.com
  • 13 edits in trunk

Make mDNS ICE Candidate an experimental flag again
​https://bugs.webkit.org/show_bug.cgi?id=191262

Reviewed by Dean Jackson.

Source/WebCore:

Rename mdnsICECandidatesEnabled to webRTCICECandidatesEnabled.
This allows grouping the WebRTC runtime flags.
No change of behavior.

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::newICECandidate):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webRTCMDNSICECandidatesEnabled const):
(WebCore::RuntimeEnabledFeatures::setWebRTCMDNSICECandidatesEnabled):
(WebCore::RuntimeEnabledFeatures::mdnsICECandidatesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMDNSICECandidatesEnabled): Deleted.

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebRTCMDNSICECandidatesEnabled):
(WKPreferencesGetWebRTCMDNSICECandidatesEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
(WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

  • webrtc/datachannel/mdns-ice-candidates.html:
5:44 PM Changeset in webkit [237904] by aakash_jain@apple.com
  • 2 edits
    3 adds in trunk/Tools

[ews-app] Add views for OpenSource EWS Django app
​https://bugs.webkit.org/show_bug.cgi?id=191131

Rubber-stamped by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/index.py: Added.
  • BuildSlaveSupport/ews-app/ews/views/patch.py:
  • BuildSlaveSupport/ews-app/ews/views/results.py: Added.
  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
5:22 PM Changeset in webkit [237903] by mmaxfield@apple.com
  • 12 edits
    28 adds in trunk

Implement text-underline-offset and text-decoration-thickness
​https://bugs.webkit.org/show_bug.cgi?id=190774

Reviewed by Dean Jackson.

Source/WebCore:

Because of our existing infrastructure for text decorations, adding support for these
is fairly simple. This patch updates our existing functions to handle thick & placed
underlines, as well as updating our repaint code to correcly handle repainting them.
It also handles animations.

Tests: animations/text-decoration-thickness.html

animations/text-underline-offset.html
fast/css3-text/css3-text-decoration/text-decoration-offset-2.html
fast/css3-text/css3-text-decoration/text-decoration-offset-3.html
fast/css3-text/css3-text-decoration/text-decoration-offset-auto-length.html
fast/css3-text/css3-text-decoration/text-decoration-offset-baseline.html
fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-auto.html
fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-length.html
fast/css3-text/css3-text-decoration/text-decoration-offset-repaint.html
fast/css3-text/css3-text-decoration/text-decoration-offset-under-auto.html
fast/css3-text/css3-text-decoration/text-decoration-offset-under-length.html
fast/css3-text/css3-text-decoration/text-decoration-offset.html
fast/css3-text/css3-text-decoration/text-decoration-thickness-length.html
fast/css3-text/css3-text-decoration/text-decoration-thickness-repaint.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • platform/graphics/FontMetrics.h:

(WebCore::FontMetrics::underlinePosition const):
(WebCore::FontMetrics::setUnderlinePosition):
(WebCore::FontMetrics::underlineThickness const):
(WebCore::FontMetrics::setUnderlineThickness):

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):

  • rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeAffectsVisualOverflow const):

  • rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness::resolve const):

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

  • style/InlineTextBoxStyle.h:

(WebCore::textDecorationStrokeThickness): Deleted.

LayoutTests:

  • animations/text-decoration-thickness-expected.txt: Added.
  • animations/text-decoration-thickness.html: Added.
  • animations/text-underline-offset-expected.txt: Added.
  • animations/text-underline-offset.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-2-expected-mismatch.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-2.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-3-expected-mismatch.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-3.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-auto-length-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-auto-length.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-baseline-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-baseline.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-expected-mismatch.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-auto-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-auto.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-length-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-from-font-length.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-repaint-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-repaint.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-under-auto-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-under-auto.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-under-length-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset-under-length.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-offset.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-length-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-length.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-repaint-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-repaint.html: Added.
4:46 PM Changeset in webkit [237902] by dino@apple.com
  • 2 edits
    6 adds in trunk/LayoutTests

Add some basic pointer events tests
​https://bugs.webkit.org/show_bug.cgi?id=191336
<rdar://problem/45858574>

Reviewed by Wenson Hsieh.

Generate some fake touches for pointer events testing.

  • fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt: Added.
  • fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html: Added.
  • fast/events/pointer/ios/tap-gives-pointerdown-pointerup-expected.txt: Added.
  • fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html: Added.
  • platform/ios/TestExpectations:
4:19 PM Changeset in webkit [237901] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Don’t use the main queue to create an XPC connection.
​https://bugs.webkit.org/show_bug.cgi?id=191160
<rdar://problem/45736262>

Patch by Suresh Koppisetty <​skoppisetty@apple.com> on 2018-11-06
Reviewed by Geoffrey Garen.

Don't use the main queue to create an XPC connection. xpc_connection_set_bootstrap does
dispatch_mach_send_barrier_f on this queue which delays the sending of the subsequent
bootstrap message (sent to launchd for launching a new target process) when the main queue is busy.

Now that the XPC connection runs on the default concurrent queue, errorHandler could be invoked
by any thread. The job of errorHandler is to dispatch errorHandlerImpl to the main thread,
where errorHandlerImpl is responsible for the actual handling of errors if any.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

4:07 PM Changeset in webkit [237900] by aakash_jain@apple.com
  • 3 edits
    3 adds in trunk/Tools

[ews-app] Add models for OpenSource EWS Django app
​https://bugs.webkit.org/show_bug.cgi?id=191123

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/models/init.py:
  • BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
  • BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
  • BuildSlaveSupport/ews-app/ews/models/patch.py:
  • BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
3:57 PM Changeset in webkit [237899] by timothy@apple.com
  • 2 edits
    4 deletes in trunk/LayoutTests

Skip css-dark-mode tests on older macOS platforms
​https://bugs.webkit.org/show_bug.cgi?id=191334

Reviewed by Brian Burg.

  • platform/mac-highsierra/css-dark-mode/prefers-color-scheme-expected.txt: Removed.
  • platform/mac-highsierra/css-dark-mode/supported-color-schemes-expected.txt: Removed.
  • platform/mac-sierra/css-dark-mode/prefers-color-scheme-expected.txt: Removed.
  • platform/mac-sierra/css-dark-mode/supported-color-schemes-expected.txt: Removed.
  • platform/mac/TestExpectations: Skip css-dark-mode for Sierra and HighSierra.
3:54 PM Changeset in webkit [237898] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Add missing iOS availability macro to _WKAutomationSessionConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=191320

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
3:24 PM Changeset in webkit [237897] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Fix Invalid HTTP_HOST header
​https://bugs.webkit.org/show_bug.cgi?id=191325

Reviewed by Lucas Forschler.

Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.

  • BuildSlaveSupport/ews-app/ews-app/settings.py:
3:16 PM Changeset in webkit [237896] by aakash_jain@apple.com
  • 5 edits
    1 move in trunk/Tools

[ews-app] Rename EWS_app to ews-app - part 2
​https://bugs.webkit.org/show_bug.cgi?id=191317

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/EWS_app: Removed.
  • BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
  • BuildSlaveSupport/ews-app/ews-app/settings.py:
  • BuildSlaveSupport/ews-app/ews-app/urls.py:
  • BuildSlaveSupport/ews-app/ews-app/wsgi.py:
  • BuildSlaveSupport/ews-app/manage.py:
3:10 PM Changeset in webkit [237895] by wilander@apple.com
  • 16 edits in trunk

Resource Load Statistics: Remove cap on partitioned cache max age if it matches a network reload (redirect-only)
​https://bugs.webkit.org/show_bug.cgi?id=189760
<rdar://problem/44612242>

Reviewed by Youenn Fablet and Antti Koivisto.

Source/WebCore:

No new tests. Existing test fleshed out.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isRedirection const):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isRedirection const): Deleted.

Moved to the implementation file so that I can export it without warning.

Source/WebKit:

When a redirect cache entry for a prevalent resource reaches its max
age cap, it is loaded again from the network and the network response
is compared with what's in the cache. If it's a match, the cache entry
is fully accepted. If not, a new capped cache entry is created.

This feature is still off by default.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::canUseCachedRedirect const):

Now checks the new member m_cacheEntryForMaxAgeCapValidation.

(WebKit::NetworkResourceLoader::retrieveCacheEntry):

New case handled for entry->hasReachedPrevalentResourceAgeCap().

(WebKit::NetworkResourceLoader::validateCacheEntryForMaxAgeCapValidation):

This is where the new logic compares the incoming redirect with the
cached one. If they match, an uncapped entry is allowed to be stored.
If they don't match, a new capped entry will be stored.

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):

Now calls the new
NetworkResourceLoader::validateCacheEntryForMaxAgeCapValidation()
function.

  • NetworkProcess/NetworkResourceLoader.h:

Added the m_cacheEntryForMaxAgeCapValidation member.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):

Restored to previous behavior which means
UseDecision::NoDueToPrevalentResourceAgeCap was removed.

(WebKit::NetworkCache::Cache::retrieve):

Restored to previous behavior.

(WebKit::NetworkCache::Cache::storeRedirect):

Now takes the optional maxAgeCap and caps the entry's max age if it's set.

(WebKit::NetworkCache::hasReachedPrevalentResourceAgeCap): Deleted.

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::encodeAsStorageRecord const):

Now encodes m_maxAgeCap.

(WebKit::NetworkCache::Entry::decodeStorageRecord):

Now decodes m_maxAgeCap.

(WebKit::NetworkCache::Entry::hasReachedPrevalentResourceAgeCap const):

Added.

(WebKit::NetworkCache::Entry::capMaxAge):

Added.

  • NetworkProcess/cache/NetworkCacheEntry.h:

Added the optional m_maxAgeCap.

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):

Now gets the optional max age cap from the NetworkStorageSession and sends it
to Cache::storeRedirect().

  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::cachedEntryReuseFailureToDiagnosticKey):

Removed handling of UseDecision::NoDueToPrevalentResourceAgeCap.

LayoutTests:

  • http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource-expected.txt:
  • http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html:

The test now performs:

  • an initial Fetch request with a permanent redirect to ID 1234. Capped max age.
  • a second Fetch request with a permanent redirect to ID 4321. Capped max age.
  • a third Fetch request with a permanent redirect to and empty ID. Capped max age.
  • a fourth Fetch request with a permanent redirect to and empty ID. Max age cap removed.
  • a fifth Fetch request with a permanent redirect to and empty ID. Regular cache hit.
  • http/tests/resourceLoadStatistics/resources/cached-permanent-redirect.php:

Now returns an HTTP 500 if the request contains validation headers.

3:08 PM Changeset in webkit [237894] by aakash_jain@apple.com
  • 1 edit
    1 move in trunk/Tools

[ews-app] Rename EWS_app to ews-app - part 1
​https://bugs.webkit.org/show_bug.cgi?id=191317

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/EWS_app: Removed.
  • BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
3:06 PM Changeset in webkit [237893] by mmaxfield@apple.com
  • 21 edits
    9 adds in trunk

Spelling dots are drawn in the wrong place
​https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

  • Dots should not be clipped.
  • Dots should be horizontally centered.
  • Dots should be drawn behind the text.
  • Distance from the baseline to the top of the dot should be 11.035% of font size.
  • Dot diameter should be 13.247% of the font size.
  • Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
  • The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html

editing/spelling/spelling-dots-position-3.html
editing/spelling/spelling-dots-position.html
editing/spelling/spelling-dots-repaint.html

  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,

because there is no guarantee the spelling dots will lie inside the layout rect of the element.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.

  • rendering/InlineFlowBox.h: Comments should explain why, not say what.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.

  • rendering/InlineTextBox.h: Declare the helper methods.
  • rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of

spelling dots opt us out of SLL.

(WebCore::SimpleLineLayout::canUseForWithReason):

  • rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printReason):

  • rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

  • editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,

this is a version of Ahem with a very small descent, so that the dots don't intersect
with the text itself.

  • editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-expected.html: Added.
  • editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in

the wrong place.

  • editing/spelling/spelling-dots-repaint-expected.html: Added.
  • editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element

with spelling dots, and then deleting the element from the document. The spelling
dots should be removed too.

  • fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
  • fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate

for new spelling dot positions.

2:51 PM Changeset in webkit [237892] by Kocsen Chung
  • 1 copy in tags/Safari-606.3.4.0.2

Tag Safari-606.3.4.0.2.

2:49 PM Changeset in webkit [237891] by Ross Kirsling
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

  • platform/wincairo/TestExpectations:
2:48 PM Changeset in webkit [237890] by Kocsen Chung
  • 7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

2:11 PM Changeset in webkit [237889] by Adrian Perez de Castro
  • 1 copy in releases/WPE WebKit/webkit-2.22.1

WPE WebKit 2.22.1

2:10 PM Changeset in webkit [237888] by Adrian Perez de Castro
  • 4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.1 release.

.:

  • Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

  • wpe/NEWS: Add release notes for 2.22.1.
2:10 PM Changeset in webkit [237887] by don.olmstead@sony.com
  • 4 edits in trunk/Tools

Feature flags not present for Visual Studio when using build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=191288

Reviewed by Fujii Hironori.

Passes feature flags to Visual studio builds within build-webkit.
Removes cmakeBasedPortArguments as it is no longer in use.

  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(cmakeBasedPortArguments): Deleted.

1:58 PM Changeset in webkit [237886] by pvollan@apple.com
  • 25 edits
    3 adds in trunk

REGRESSION (r230523): Caps lock indicator not shown in password field
​https://bugs.webkit.org/show_bug.cgi?id=190056

Reviewed by Ryosuke Niwa.

Source/WebCore:

When WindowServer access is blocked, GetCurrentModifiers() always returns 0. Instead of calling
GetCurrentModifiers(), store the current modifiers from the key event argument in the method
WebKit::WebPage::keyEvent, and use the stored value to detect if Caps lock is on. Additionally,
the modifiers needs to be updated when the window becomes active.

Test: fast/events/detect-caps-lock.html

  • Sources.txt:
  • platform/PlatformKeyboardEvent.h:
  • platform/graphics/FontTaggedSettings.cpp:
  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

  • testing/Internals.cpp:

(WebCore::Internals::capsLockIsOn):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

Update cached modifier state in the WebProcess when WebKit::WebPage::keyEvent is called, and
when the window becomes active.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::updateCurrentModifierState):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):
(WebKit::WebPage::updateCurrentModifierState):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::toggleCapsLock):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::toggleCapsLock):

LayoutTests:

  • TestExpectations:
  • fast/events/detect-caps-lock-expected.txt: Added.
  • fast/events/detect-caps-lock.html: Added.
  • platform/mac/TestExpectations:
1:53 PM Changeset in webkit [237885] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Add ObjC SPI equivalent of WKContextHandlesSafeBrowsing
​https://bugs.webkit.org/show_bug.cgi?id=191329

Reviewed by Tim Horton.

Like WKContextHandlesSafeBrowsing, this is so I can make one change in WebKit and enable safe browsing
in WKWebView and disable it in Safari at the same time without broken revisions between landing two changes
in two repositories.

  • UIProcess/API/Cocoa/WKWebView.mm:

(+[WKWebView handlesSafeBrowsing]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
1:45 PM Changeset in webkit [237884] by jfernandez@igalia.com
  • 7 edits
    8 adds in trunk

CSS grid elements with justify-content: space-around have extra whitespace, sometimes a lot
​https://bugs.webkit.org/show_bug.cgi?id=191308

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Imported WPT to cover the behavior changes added in this patch.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004-expected.txt: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

Source/WebCore:

The CSS WG resolved [1] that Content Alignment should account to the
track sizing algorithm.

The sizing algorithm has been modified so that two new steps (1.5
and 2.5) were added to compute the Content Alignment offsets after
resolving the columns' and rows' sizes respectively.

This change decouples the Content Alignment logic from the tracks
position, so that we can use it as part of the track sizing algorithm.

I also had to store the whole ContentAlignmentData structure in two
class attributes. We need both, position and distribution offsets, to
be used in different parts of the layout logic.

[1] ​https://github.com/w3c/csswg-drafts/issues/2557

Tests: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html

imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridItemOffset const):
(WebCore::RenderGrid::trackSizesForComputedStyle const):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
(WebCore::RenderGrid::nonCollapsedTracks const):

  • rendering/RenderGrid.h:

(WebCore::ContentAlignmentData::isValid):
(WebCore::ContentAlignmentData::defaultOffsets):

1:34 PM Changeset in webkit [237883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION: Web Inspector: Popovers drawing incorrectly in Network Tab (clicking between a few items)
​https://bugs.webkit.org/show_bug.cgi?id=191323

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-06
Reviewed by Devin Rousso.

  • UserInterface/Views/Popover.js:

(WI.Popover.prototype._drawBackground):
Save and restore the context state between updates. Something
was affecting the clearRect, making it so that it didn't actually
clear the entire rect each time.

12:56 PM Changeset in webkit [237882] by sihui_liu@apple.com
  • 4 edits
    3 adds in trunk

IndexedDB: WAL file keeps growing
​https://bugs.webkit.org/show_bug.cgi?id=191294
<rdar://problem/41333493>

Reviewed by Chris Dumez.

Source/WebCore:

When we quit apps, the database connection may not be shut down properly, and WAL file will be retained on disk.
On the next open of database connection, new logs will be appended to the original WAL file, which keeps
increasing size of the WAL file. We should do a manual checkpoint when we open a IndexedDB to make sure previous
log is written to database and truncate WAL file.

Test: IndexedDB.IndexedDBTempFileSize

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.

(-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

12:54 PM Changeset in webkit [237881] by Keith Rollin
  • 3 edits in trunk/Source/JavaScriptCore

Adjust handling of Include paths that need quoting
​https://bugs.webkit.org/show_bug.cgi?id=191314
<rdar://problem/45849143>

Reviewed by Dan Bernstein.

There are several places in the JavaScriptCore Xcode project where the
paths defined in HEADER_SEARCH_PATHS are quoted. That is, the
definitions look like:

HEADER_SEARCH_PATHS = (

"\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
"\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${ARCHS}\"",
"\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
"$(inherited)",

);

The idea here is presumably to have the resulting $(CPP) command have
-I options where the associated paths are themselves quoted,
protecting against space characters in the paths.

This approach to quote management can break under Xcode 9. If
.xcfilelist files are added to the project, the 'objectVersion' value
in the Xcode project file is changed from 46 to 51. If a project with
objectVersion=51 is presented to Xcode 9 (as can happen when we build
for older OS's), it produces build lines where the quotes are escaped,
thereby becoming part of the path. The build then fails because a
search for a file normally found in a directory called "Foo" will be
looked for in "\"Foo\"", which doesn't exist.

Simply removing the escaped quotes from the HEADER_SEARCH_PATHS
definition doesn't work, leading to paths that need quoting due to
space characters but that don't get this quoting (the part of the path
after the space appears to simply go missing).

Removing the escaped quotes from the HEADER_SEARCH_PATHS and moving
the definitions to the .xcconfig fixes this problem.

  • Configurations/ToolExecutable.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
12:52 PM Changeset in webkit [237880] by ajuma@chromium.org
  • 10 edits
    1 copy
    6 adds in trunk

IntersectionObserver doesn't keep target's JS wrapper alive
​https://bugs.webkit.org/show_bug.cgi?id=190235

Reviewed by Ryosuke Niwa.

Source/WebCore:

Retain JS wrappers of targets in queued entries using a vector of GCReachableRef owned by
IntersectionObserver, which gets cleared after the entries have been delivered.

Make IntersectionObserver::takeRecords return a struct which has both the vector of GCReachableRefs
for targets and the vector of intersection observer entries, so that the GCReachableRefs survive
until the creation of JS wrappers for the entries.

Modify IntersectionObserver::hasPendingActivity to keep the observer alive while it has
entries to deliver.

Tests: intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive.html

intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive.html
intersection-observer/target-deleted.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIntersectionObserverEntryCustom.cpp:

(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren): Keep the target element's wrapper alive while the
IntersectionObserverEntry's wrapper is alive.

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::takeRecords): Change return type to include GCReachableRefs for each record's target, so that
each target can be kept until a JS wrapper is constructed for its IntersectionObserverEntry.
(WebCore::IntersectionObserver::appendQueuedEntry):
(WebCore::IntersectionObserver::notify): Erase GCReachableRefs for targets after delivering the corresponding records.
(WebCore::IntersectionObserver::hasPendingActivity const): Keep the IntersectionObserver alive until queued entries are delivered.
(WebCore::IntersectionObserver::stop):

  • page/IntersectionObserver.h:
  • page/IntersectionObserver.idl:
  • page/IntersectionObserverEntry.h:

(WebCore::IntersectionObserverEntry::target const): Make this return a raw pointer instead of a RefPtr so that it
can be called in JSIntersectionObserverEntry::visitAdditionalChildren, which runs on the GC thread (it's illegal to ref a Node
on a non-main thread).

  • page/IntersectionObserverEntry.idl:

LayoutTests:

Add test coverage.

Update test that depends on a target getting GC'd to call takeRecords() since
targets with pending entries are no logner GC'd.

  • intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive-expected.txt: Added.
  • intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive.html: Added.
  • intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive-expected.txt: Added.
  • intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive.html: Added.
  • intersection-observer/root-element-deleted.html:
  • intersection-observer/target-deleted-expected.txt: Added.
  • intersection-observer/target-deleted.html: Added.
12:12 PM Changeset in webkit [237879] by eric.carlson@apple.com
  • 5 edits in trunk

[MediaStream] User should not be prompted again after denying getDisplayMedia request
​https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:

LayoutTests:

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

11:53 AM Changeset in webkit [237878] by timothy@apple.com
  • 15 edits
    4 adds in trunk

<picture> container doesn't update when prefers-color-scheme media query changes
​https://bugs.webkit.org/show_bug.cgi?id=190913
rdar://problem/45608456

Reviewed by Dean Jackson.

Source/WebCore:

Test: css-dark-mode/prefers-color-scheme-picture-element.html

  • css/MediaQueryEvaluator.cpp:

(WebCore::isAppearanceDependent): Added.
(WebCore::MediaQueryEvaluator::evaluate const): Keep track of appearanceDependentResults.

  • css/MediaQueryEvaluator.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::addAppearanceDependentMediaQueryResult): Added.
(WebCore::StyleResolver::hasMediaQueriesAffectedByAppearanceChange const): Added.

  • css/StyleResolver.h:

(WebCore::StyleResolver::hasAppearanceDependentMediaQueries const): Added.

  • dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList): Call checkAppearanceDependentPictures.
(WebCore::Document::checkAppearanceDependentPictures): Added.
(WebCore::Document::addAppearanceDependentPicture): Added.
(WebCore::Document::removeAppearanceDependentPicture): Added.

  • dom/Document.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Call addAppearanceDependentPicture.

  • html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::~HTMLPictureElement): Call removeAppearanceDependentPicture.
(WebCore::HTMLPictureElement::didMoveToNewDocument): Ditto.
(WebCore::HTMLPictureElement::appearanceChangeAffectedPicture const): Added.

  • html/HTMLPictureElement.h:
  • page/Page.cpp:

(WebCore::Page::appearanceDidChange): Added.
(WebCore::Page::setUseSystemAppearance): Call appearanceDidChange.
(WebCore::Page::setUseDarkAppearance): Call appearanceDidChange.

  • page/Page.h:
  • style/StyleScope.cpp:

(WebCore::Style::Scope::evaluateMediaQueriesForAppearanceChange): Added.

  • style/StyleScope.h:

LayoutTests:

  • css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.
  • css-dark-mode/prefers-color-scheme-picture-element.html: Added.
  • platform/mac-highsierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.
  • platform/mac-sierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.
11:19 AM Changeset in webkit [237877] by msaboff@apple.com
  • 6 edits in trunk

Multiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and Release JSC testers.
​https://bugs.webkit.org/show_bug.cgi?id=191271

Reviewed by Saam Barati.

JSTests:

Added more test cases and made all test cases run with the same deeply recursive stack
instead of finding that same point for each test case.

  • stress/regexp-compile-oom.js:

(prototype.runTest):
(recurseAndTest):
(testList.push.new.TestAndExpectedException):

Source/JavaScriptCore:

Fixed use of ThrowScope my adding release() calls. Found a few places where we needed
RETURN_IF_EXCEPTION(). After some code inspections determined that we need to cover the
exception bubbling for String.match() with a global RegExp as well as String.replace()
and String.search().

  • runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::matchInline):
(JSC::collectMatches):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncSearchFast):

  • runtime/StringPrototype.cpp:

(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):

11:03 AM Changeset in webkit [237876] by achristensen@apple.com
  • 3 edits
    1 copy
    1 add in trunk

Fix tests after r237863
​https://bugs.webkit.org/show_bug.cgi?id=191315

Reviewed by Chris Dumez.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it. I updated the test
to verify that main2.html eventually loads, making this test less timing dependent.

LayoutTests:

  • platform/mac-wk2/http/tests/navigation: Added.
  • platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.

This test is timing related, and I need to update its WK2 expectations every time I enable or disable safe browsing checks during navigation.
See r237149.

11:01 AM Changeset in webkit [237875] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.1.2

Tag Safari-606.3.4.1.2.

10:52 AM Changeset in webkit [237874] by Alan Coon
  • 1 delete in tags/Safari-606.3.4.1.2

Delete tag

10:48 AM Changeset in webkit [237873] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.1.2

New tag.

10:33 AM Changeset in webkit [237872] by Alan Coon
  • 4 edits in branches/safari-606.3.4.1-branch/Source

Revert r237528. rdar://problem/45847130

10:33 AM Changeset in webkit [237871] by Alan Coon
  • 1 edit in branches/safari-606.3.4.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

Revert r237840. rdar://problem/45837753

10:23 AM Changeset in webkit [237870] by Ryan Haddad
  • 20 edits
    9 deletes in trunk

Unreviewed, rolling out r237834.

Tests for this change crash on iOS Simulator

Reverted changeset:

"Spelling dots are drawn in the wrong place"
​https://bugs.webkit.org/show_bug.cgi?id=190764
​https://trac.webkit.org/changeset/237834

10:14 AM Changeset in webkit [237869] by Alan Coon
  • 7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

9:44 AM Changeset in webkit [237868] by graouts@webkit.org
  • 5 edits in trunk/Source/WebCore

[Web Animations] transitions/remove-transition-style.html crashes with GuardMalloc on
​https://bugs.webkit.org/show_bug.cgi?id=191304
<rdar://problem/45819476>

Reviewed by Dean Jackson.

Ensure we remove animations from the m_allAnimations ListHashSet upon destruction.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::forgetAnimation):
(WebCore::AnimationTimeline::cancelDeclarativeAnimation):

  • animation/AnimationTimeline.h:
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::getAnimations const):

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::~WebAnimation):

8:14 AM Changeset in webkit [237867] by youenn@apple.com
  • 6 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSourceCocoa should unobserve its source at destruction time
​https://bugs.webkit.org/show_bug.cgi?id=191295

Reviewed by Eric Carlson.

Make RealtimeOutgoingAudioSource subclasses unobserve their source
inside their destructor instead of RealtimeOutgoingAudioSource.
This is consistent with how starting to observe works.
Covered by existing tests.

  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::unobserveSource):

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::~RealtimeOutgoingAudioSourceLibWebRTC):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::~RealtimeOutgoingAudioSourceCocoa):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
7:56 AM Changeset in webkit [237866] by youenn@apple.com
  • 3 edits
    2 adds in trunk

Make sure RTCIceCandidateStats address is undefined for host and peer reflexive case
​https://bugs.webkit.org/show_bug.cgi?id=191263

Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/datachannel/getStats-no-prflx-remote-candidate.html

  • Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::fillRTCIceCandidateStats):

LayoutTests:

  • webrtc/datachannel/getStats-no-prflx-remote-candidate-expected.txt: Added.
  • webrtc/datachannel/getStats-no-prflx-remote-candidate.html: Added.
7:54 AM Changeset in webkit [237865] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Handle setting max number of frame between keyframes
​https://bugs.webkit.org/show_bug.cgi?id=190682

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-06
Reviewed by Philippe Normand.

That has been manually checked.

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:

(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(gst_webrtc_video_encoder_class_init):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::InitEncode):

7:46 AM Changeset in webkit [237864] by youenn@apple.com
  • 5 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=191278

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Updating test according upstreamed WPT.
Rebased test accordingly.

  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:

LayoutTests:

7:26 AM Changeset in webkit [237863] by achristensen@apple.com
  • 23 edits
    10 adds in trunk

[Mac] Implement safe browsing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=188871

Reviewed by Tim Horton.

Source/WebCore:

  • en.lproj/Localizable.strings:

Source/WebKit:

  • Platform/spi/Cocoa/SafeBrowsingSPI.h:
  • Resources/SafeBrowsing.xcassets: Added.
  • Resources/SafeBrowsing.xcassets/Contents.json: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningBackground.colorset: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningBackground.colorset/Contents.json: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningText.colorset: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningText.colorset/Contents.json: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningTitle.colorset: Added.
  • Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningTitle.colorset/Contents.json: Added.
  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextHandlesSafeBrowsing):

  • UIProcess/Cocoa/SafeBrowsingResultCocoa.mm:

(WebKit::malwareDetailsBase):
(WebKit::learnMore):
(WebKit::reportAnErrorBase):
(WebKit::localizedProvider):
(WebKit::SafeBrowsingResult::SafeBrowsingResult):

  • UIProcess/Cocoa/WKSafeBrowsingWarning.h: Added.
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm: Added.

(confirmMalwareSentinel):
(visitUnsafeWebsiteSentinel):
(colorNamed):
(replace):
(addLinkAndReplace):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(-[WKSafeBrowsingExclamationPoint intrinsicContentSize]):
(reportAnErrorURL):
(malwareDetailsURL):
(titleText):
(warningText):
(detailsText):
(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingResult:completionHandler:]):
(-[WKSafeBrowsingWarning dealloc]):
(-[WKSafeBrowsingWarning goBackClicked]):
(-[WKSafeBrowsingWarning clickedOnLink:]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(+[WKSafeBrowsingTextView viewWithAttributedString:linkTarget:]):
(+[WKSafeBrowsingTextView viewWithString:]):
(-[WKSafeBrowsingTextView intrinsicContentSize]):
(-[WKSafeBrowsingTextView clickedOnLink:atIndex:]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::WebViewImpl::clearSafeBrowsingWarning):
(WebKit::WebViewImpl::setFrameSize):

  • UIProcess/PageClient.h:

(WebKit::PageClient::showSafeBrowsingWarning):
(WebKit::PageClient::clearSafeBrowsingWarning):

  • UIProcess/SafeBrowsingResult.h:

(WebKit::SafeBrowsingResult::url const):
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::localizedProviderName const):
(WebKit::SafeBrowsingResult::malwareDetailsURLBase const):
(WebKit::SafeBrowsingResult::reportAnErrorURLBase const):
(WebKit::SafeBrowsingResult::learnMoreURL const):
(WebKit::SafeBrowsingResult::needsSafeBrowsingWarning const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setImpl):
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
(+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
(-[TestLookupContext lookUpURL:completionHandler:]):
(simpleURL):
(safeBrowsingView):
(TEST):
(-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
(+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
(-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.

  • TestWebKitAPI/Utilities.h:
6:59 AM Changeset in webkit [237862] by ajuma@chromium.org
  • 4 edits in trunk

[IntersectionObserver] Account for CSS zoom when computing client rects
​https://bugs.webkit.org/show_bug.cgi?id=191282

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test case that now passes.

  • web-platform-tests/intersection-observer/bounding-box-expected.txt:

Source/WebCore:

When computing rects for an IntersectionObserverEntry, account for the effective zoom when
converting from absolute to client coordinates.

Test: web-platform-tests/intersection-observer/bounding-box.html

  • dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):

6:47 AM Changeset in webkit [237861] by commit-queue@webkit.org
  • 6 edits in trunk

[GStreamer][WebRTC] Implement black frame generation
​https://bugs.webkit.org/show_bug.cgi?id=190684

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-06
Reviewed by Xabier Rodriguez-Calvar.

Avoiding webrtc/video-mute-vp8.html to crash but it still fails because
we are missing the canvas bridging code.

Source/WebCore:

  • platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingVideoSourceLibWebRTC::createBlackFrame):

  • platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.h:

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
6:23 AM Changeset in webkit [237860] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder
​https://bugs.webkit.org/show_bug.cgi?id=190683

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-06
Reviewed by Philippe Normand.

This has to already be handled in capturing pipeline or in libwebrtc itself.

No other encoder implementation do that, and libwebrtc is not happy with encoder that do not output the exact number of frames that have been passed in.

No regressions detected and libwebrtc is happier this way, less warning output and no more frame corruption in H264 streams found.

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::InitEncode):

3:37 AM Changeset in webkit [237859] by fred.wang@free.fr
  • 3 edits in trunk/Source/WebCore

Unreviewed, follow-up of previous commit.

Actually move OptionSet in the header since it's used there too.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-06

  • page/WindowFeatures.cpp:
  • page/WindowFeatures.h:
3:30 AM Changeset in webkit [237858] by fred.wang@free.fr
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-06

  • page/WindowFeatures.cpp: Add missing header for OptionSet.
  • platform/graphics/FontTaggedSettings.cpp: Add missing header for IntegerHash.
3:16 AM Changeset in webkit [237857] by graouts@webkit.org
  • 74 edits
    10 moves
    23 adds
    30 deletes in trunk/LayoutTests

[Web Animations] Update all tests to match the latest API changes
​https://bugs.webkit.org/show_bug.cgi?id=191302
<rdar://problem/41000438>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

  • css-animations/test_animation-computed-timing.html:
  • css-animations/test_effect-target.html:
  • css-animations/test_keyframeeffect-getkeyframes-expected.txt:
  • css-animations/test_keyframeeffect-getkeyframes.html:
  • css-animations/test_pseudoElement-get-animations.html:
  • css-transitions/test_effect-target.html:
  • css-transitions/test_keyframeeffect-getkeyframes-expected.txt:
  • css-transitions/test_keyframeeffect-getkeyframes.html:

LayoutTests/imported/w3c:

  • web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html:
  • web-platform-tests/web-animations/META.yml: Added.
  • web-platform-tests/web-animations/README.md: Added.
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html:
  • web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
  • web-platform-tests/web-animations/animation-model/animation-types/property-types.js:
  • web-platform-tests/web-animations/animation-model/combining-effects/applying-the-composited-result-expected.txt: Added.
  • web-platform-tests/web-animations/animation-model/combining-effects/applying-the-composited-result.html: Added.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-interval-distance-expected.txt: Added.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-interval-distance.html: Added.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html:
  • web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animatable/animate.html:
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html:
  • web-platform-tests/web-animations/interfaces/Animation/cancel.html:
  • web-platform-tests/web-animations/interfaces/Animation/constructor.html:
  • web-platform-tests/web-animations/interfaces/Animation/effect.html:
  • web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/finish.html: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/finished.html:
  • web-platform-tests/web-animations/interfaces/Animation/idlharness-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/idlharness.html: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/idlharness.window.js: Added.
  • web-platform-tests/web-animations/interfaces/Animation/onfinish.html:
  • web-platform-tests/web-animations/interfaces/Animation/playbackRate-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/playbackRate.html: Removed.
  • web-platform-tests/web-animations/interfaces/Animation/ready.html:
  • web-platform-tests/web-animations/interfaces/AnimationEffect/getComputedTiming-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming-expected.txt.
  • web-platform-tests/web-animations/interfaces/AnimationEffect/getComputedTiming.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming.html.
  • web-platform-tests/web-animations/interfaces/AnimationEffect/updateTiming-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffect/updateTiming.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.html: Removed.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window.js: Added.
  • web-platform-tests/web-animations/interfaces/Document/getAnimations-expected.txt:
  • web-platform-tests/web-animations/interfaces/Document/getAnimations.html:
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.html: Removed.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window.js: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor.html:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt: Removed.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.html: Removed.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window.js: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite.html:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html:
  • web-platform-tests/web-animations/resources/keyframe-tests.js:
  • web-platform-tests/web-animations/resources/timing-tests.js: Added.
  • web-platform-tests/web-animations/resources/timing-utils.js: Added.
  • web-platform-tests/web-animations/testcommon.js:
  • web-platform-tests/web-animations/timing-model/animation-effects/phases-and-states.html:
  • web-platform-tests/web-animations/timing-model/animations/canceling-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/canceling-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/finishing-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/finishing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/pausing-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/play-states-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/play-states.html:
  • web-platform-tests/web-animations/timing-model/animations/playing-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html:
  • web-platform-tests/web-animations/timing-model/animations/seamlessly-updating-the-playback-rate-of-an-animation-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/animations/seamlessly-updating-the-playback-rate-of-an-animation.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-playback-rate-of-an-animation-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-playback-rate-of-an-animation.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time.html.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-target-effect-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-target-effect-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/the-current-time-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/the-current-time-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time.html.
  • web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state.html:
  • web-platform-tests/web-animations/timing-model/timelines/document-timelines.html:
  • web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html: Added.

LayoutTests:

  • TestExpectations:
  • platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
  • platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
  • platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • webanimations/css-animations.html:
  • webanimations/left-and-opacity-animation-yields-no-compositing.html:
  • webanimations/opacity-animation-no-longer-composited-upon-completion.html:
  • webanimations/width-and-opacity-separate-animation-yields-no-compositing.html:
3:15 AM Changeset in webkit [237856] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Don't reset pending tasks when setting a null effect
​https://bugs.webkit.org/show_bug.cgi?id=191301
<rdar://problem/45838422>

Reviewed by Dean Jackson.

The issue ​https://github.com/w3c/csswg-drafts/issues/2077 has changed the Web Animations API such that
we no longer reset pending tasks when setting a null effect on an animation.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setEffect):

3:15 AM Changeset in webkit [237855] by graouts@webkit.org
  • 8 edits
    2 copies in trunk/Source/WebCore

[Web Animations] Update the API to allow the "auto" composite value
​https://bugs.webkit.org/show_bug.cgi?id=191300
<rdar://problem/45838373>

Reviewed by Dean Jackson.

The Web Animations API has been changed such that the various "composite" properties are no longer optional and instead
allow an "auto" value in their enumeration.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/CompositeOperationOrAuto.h: Copied from Source/WebCore/animation/KeyframeEffect.idl.
  • animation/CompositeOperationOrAuto.idl: Copied from Source/WebCore/animation/KeyframeEffect.idl.
  • animation/KeyframeEffect.cpp:

(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
(WebCore::KeyframeEffect::getKeyframes):

  • animation/KeyframeEffect.h:
  • animation/KeyframeEffect.idl:
3:15 AM Changeset in webkit [237854] by graouts@webkit.org
  • 4 edits in trunk/Source/WebCore

[Web Animations] Update the API to implement Animation.updatePlaybackRate()
​https://bugs.webkit.org/show_bug.cgi?id=186510
<rdar://problem/41000641>

Reviewed by Dean Jackson.

The Web Animations API has been changed to allow for changes to an animation's playback rate both synchronously,
with the existing "playbackRate" property, and asynchronously, with the new updatePlaybackRate() method. In this
patch we update the various procedures to account for pending playback rate changes and the notion of an "effective
playback rate".

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::setCurrentTime):
(WebCore::WebAnimation::effectivePlaybackRate const):
(WebCore::WebAnimation::setPlaybackRate):
(WebCore::WebAnimation::updatePlaybackRate):
(WebCore::WebAnimation::applyPendingPlaybackRate):
(WebCore::WebAnimation::playState const):
(WebCore::WebAnimation::resetPendingTasks):
(WebCore::WebAnimation::finish):
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::reverse):
(WebCore::WebAnimation::runPendingPauseTask):

  • animation/WebAnimation.h:

(WebCore::WebAnimation::playbackRate const):

  • animation/WebAnimation.idl:
3:15 AM Changeset in webkit [237853] by graouts@webkit.org
  • 18 edits
    2 moves
    5 deletes in trunk/Source/WebCore

[Web Animations] Implement getTiming() and updateTiming()
​https://bugs.webkit.org/show_bug.cgi?id=186511
<rdar://problem/41000677>

Reviewed by Dean Jackson.

The Web Animations API has been further simplified by removing the AnimationEffectTiming and AnimationEffectTimingReadOnly
interfaces, removing the "timing" property on AnimationEffect replacing it with getTiming() and updateTiming() methods. This
does not change the features of the API but simply how they are exposed.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationEffect.cpp:

(WebCore::AnimationEffect::AnimationEffect):
(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::phase const):
(WebCore::AnimationEffect::activeTime const):
(WebCore::AnimationEffect::overallProgress const):
(WebCore::AnimationEffect::simpleIterationProgress const):
(WebCore::AnimationEffect::currentIteration const):
(WebCore::AnimationEffect::currentDirection const):
(WebCore::AnimationEffect::transformedProgress const):
(WebCore::AnimationEffect::getTiming):
(WebCore::AnimationEffect::getComputedTiming):
(WebCore::AnimationEffect::updateTiming):
(WebCore::AnimationEffect::setIterationStart):
(WebCore::AnimationEffect::setIterations):
(WebCore::AnimationEffect::endTime const):
(WebCore::AnimationEffect::setDelay):
(WebCore::AnimationEffect::setEndDelay):
(WebCore::AnimationEffect::setFill):
(WebCore::AnimationEffect::setIterationDuration):
(WebCore::AnimationEffect::setDirection):
(WebCore::AnimationEffect::setTimingFunction):
(WebCore::AnimationEffect::activeDuration const):

  • animation/AnimationEffect.h:

(WebCore::AnimationEffect::delay const):
(WebCore::AnimationEffect::endDelay const):
(WebCore::AnimationEffect::fill const):
(WebCore::AnimationEffect::iterationStart const):
(WebCore::AnimationEffect::iterations const):
(WebCore::AnimationEffect::iterationDuration const):
(WebCore::AnimationEffect::direction const):
(WebCore::AnimationEffect::timingFunction const):

  • animation/AnimationEffect.idl:
  • animation/AnimationEffectTiming.idl: Removed.
  • animation/AnimationEffectTimingReadOnly.cpp: Removed.
  • animation/AnimationEffectTimingReadOnly.h: Removed.
  • animation/AnimationEffectTimingReadOnly.idl: Removed.
  • animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):

  • animation/CSSTransition.cpp:

(WebCore::CSSTransition::setTimingProperties):

  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::invalidateDOMEvents):

  • animation/DocumentTimeline.cpp:
  • animation/EffectTiming.idl:
  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):

  • animation/KeyframeEffect.h:
  • animation/OptionalEffectTiming.h: Renamed from Source/WebCore/animation/AnimationEffectTiming.h.
  • animation/OptionalEffectTiming.idl: Renamed from Source/WebCore/animation/AnimationEffectTiming.cpp.
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::effectTimingDidChange):
(WebCore::WebAnimation::updatePlaybackRate):

  • animation/WebAnimation.h:

(WebCore::WebAnimation::isRelevant const):

  • bindings/js/JSAnimationEffectTimingReadOnlyCustom.cpp: Removed.
  • bindings/js/WebCoreBuiltinNames.h:
3:15 AM Changeset in webkit [237852] by graouts@webkit.org
  • 23 edits
    8 moves
    3 deletes in trunk/Source/WebCore

[Web Animations] Update the Web Animations API to remove all the ReadOnly interfaces
​https://bugs.webkit.org/show_bug.cgi?id=186512
<rdar://problem/41000691>

Reviewed by Dean Jackson.

The Web Animations API has been simplified by removing its various ReadOnly interfaces. In this patch,
we make the following changes, not adding code but merely merging and renaming files:

  • AnimationEffectReadOnly and AnimationEffect are now a single AnimationEffect interface
  • KeyframeEffectReadOnly and KeyframeEffect are now a single KeyframeEffect interface
  • ComputedTimingProperties is now named ComputedEffectTiming
  • AnimationEffectTimingProperties is now named EffectTiming
  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationEffect.cpp: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.cpp.

(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::timingDidChange):
(WebCore::AnimationEffect::localTime const):
(WebCore::AnimationEffect::phase const):
(WebCore::AnimationEffect::activeTime const):
(WebCore::AnimationEffect::overallProgress const):
(WebCore::AnimationEffect::simpleIterationProgress const):
(WebCore::AnimationEffect::currentIteration const):
(WebCore::AnimationEffect::currentDirection const):
(WebCore::AnimationEffect::directedProgress const):
(WebCore::AnimationEffect::transformedProgress const):
(WebCore::AnimationEffect::iterationProgress const):
(WebCore::AnimationEffect::getComputedTiming):

  • animation/AnimationEffect.h: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.h.

(WebCore::AnimationEffect::isKeyframeEffect const):

  • animation/AnimationEffect.idl: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.idl.
  • animation/AnimationEffectTimingReadOnly.cpp:
  • animation/AnimationEffectTimingReadOnly.h:

(WebCore::AnimationEffectTimingReadOnly::setEffect):

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::removeAnimation):
(WebCore::AnimationTimeline::cssAnimationForElementAndProperty):

  • animation/CSSTransition.cpp:
  • animation/ComputedEffectTiming.h: Renamed from Source/WebCore/animation/ComputedTimingProperties.h.
  • animation/ComputedEffectTiming.idl: Renamed from Source/WebCore/animation/ComputedTimingProperties.idl.
  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::flushPendingStyleChanges const):
(WebCore::DeclarativeAnimation::phaseWithoutEffect const):
(WebCore::DeclarativeAnimation::invalidateDOMEvents):

  • animation/DeclarativeAnimation.h:
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::getAnimations const):
(WebCore::DocumentTimeline::transitionDidComplete):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement):
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
(WebCore::DocumentTimeline::resolveAnimationsForElement):

  • animation/EffectTiming.h: Renamed from Source/WebCore/animation/AnimationEffectTimingProperties.h.
  • animation/EffectTiming.idl: Renamed from Source/WebCore/animation/AnimationEffectTimingProperties.idl.
  • animation/KeyframeEffect.cpp:

(WebCore::invalidateElement):
(WebCore::CSSPropertyIDToIDLAttributeName):
(WebCore::IDLAttributeNameToAnimationPropertyName):
(WebCore::computeMissingKeyframeOffsets):
(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::forceLayoutIfNeeded):
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::checkForMatchingTransformFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists const):
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingBackdropFilterFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingColorFilterFunctionLists):
(WebCore::KeyframeEffect::computeDeclarativeAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
(WebCore::KeyframeEffect::computedNeedsForcedLayout):
(WebCore::KeyframeEffect::computeStackingContextImpact):
(WebCore::KeyframeEffect::setTarget):
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::invalidate):
(WebCore::KeyframeEffect::computeShouldRunAccelerated):
(WebCore::KeyframeEffect::getAnimatedStyle):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::timingFunctionForKeyframeAtIndex):
(WebCore::KeyframeEffect::updateAcceleratedAnimationState):
(WebCore::KeyframeEffect::addPendingAcceleratedAction):
(WebCore::KeyframeEffect::animationDidSeek):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
(WebCore::KeyframeEffect::renderer const):
(WebCore::KeyframeEffect::currentStyle const):
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
(WebCore::containsRotation):
(WebCore::KeyframeEffect::computeTransformedExtentViaTransformList const):
(WebCore::KeyframeEffect::computeTransformedExtentViaMatrix const):

  • animation/KeyframeEffect.h:

(WebCore::KeyframeEffect::ParsedKeyframe::ParsedKeyframe):
(WebCore::KeyframeEffect::target const):
(WebCore::KeyframeEffect::iterationComposite const):
(WebCore::KeyframeEffect::composite const):
(WebCore::KeyframeEffect::isRunningAccelerated const):
(WebCore::KeyframeEffect::hasPendingAcceleratedAction const):
(WebCore::KeyframeEffect::hasBlendingKeyframes const):
(WebCore::KeyframeEffect::animatedProperties const):

  • animation/KeyframeEffect.idl:
  • animation/KeyframeEffectOptions.h:
  • animation/KeyframeEffectOptions.idl:
  • animation/KeyframeEffectReadOnly.cpp: Removed.
  • animation/KeyframeEffectReadOnly.h: Removed.
  • animation/KeyframeEffectReadOnly.idl: Removed.
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::applyPendingAcceleratedActions):
(WebCore::WebAnimation::computeRelevance):

  • animation/WebAnimation.h:

(WebCore::WebAnimation::effect const):

  • animation/WebAnimation.idl:
  • bindings/js/JSAnimationEffectCustom.cpp: Renamed from Source/WebCore/bindings/js/JSAnimationEffectReadOnlyCustom.cpp.

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

  • bindings/js/JSWebAnimationCustom.cpp:

(WebCore::constructJSWebAnimation):

  • bindings/js/WebCoreBuiltinNames.h:
  • dom/Document.cpp:
2:26 AM Changeset in webkit [237851] by zandobersek@gmail.com
  • 7 edits
    28 adds in trunk/LayoutTests

Unreviewed WPE gardening. Handle a bunch of test failures under the
directories containing imported W3C wpt tests. A few test expectations
are added, but mostly the corresponding baselines are provided.

  • platform/wpe/TestExpectations:
  • platform/wpe/http/tests/dom: Added.
  • platform/wpe/http/tests/dom/same-origin-detached-window-properties-expected.txt: Added.
  • platform/wpe/http/wpt: Added.
  • platform/wpe/http/wpt/mediarecorder: Added.
  • platform/wpe/http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added.
  • platform/wpe/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/idlharness.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/mimesniff: Added.
  • platform/wpe/imported/w3c/web-platform-tests/mimesniff/mime-types: Added.
  • platform/wpe/imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/extension: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/service-workers: Added.
  • platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker: Added.
  • platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw-manual.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/shadow-dom: Added.
  • platform/wpe/imported/w3c/web-platform-tests/shadow-dom/input-element-list-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/formdata-blob-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/formdata-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/xhr/setrequestheader-content-type-expected.txt:
2:01 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro
(diff)
1:44 AM Changeset in webkit [237850] by commit-queue@webkit.org
  • 5 edits in trunk

Some minor X-Content-Type-Options parsing issues
​https://bugs.webkit.org/show_bug.cgi?id=191107

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-06
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved result.

  • web-platform-tests/fetch/nosniff/parsing-nosniff-expected.txt:

Source/WebCore:

Implement new parsing rules for X-Content-Type-Options [1]:
​https://github.com/whatwg/fetch/pull/818

[1] ​https://fetch.spec.whatwg.org/#x-content-type-options-header

Test: web-platform-tests/fetch/nosniff/parsing-nosniff.html

  • platform/network/HTTPParsers.cpp:

(WebCore::isHTTPTabOrSpace):
(WebCore::parseContentTypeOptionsHeader):

12:19 AM Changeset in webkit [237849] by fred.wang@free.fr
  • 3 edits
    2 adds in trunk

Overlay with -webkit-overflow-scrolling:touch doesn't become scrollable after added text makes it taller
​https://bugs.webkit.org/show_bug.cgi?id=158342

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-06
Reviewed by Simon Fraser.

Source/WebCore:

Resizing the content of a -webkit-overflow-scrolling:touch overflow node on iOS may make it
scrollable. However, the RenderLayerBacking's scrolling layer is not properly created
when RenderLayerCompositor::updateScrollCoordinatedLayer is called and hence the UIProcess
receives a null UIScrollView pointer when ScrollingTreeScrollingNodeDelegateIOS performs the
associated update. In debug mode this hits an ASSERT and in release mode the overflow node
remains unscrollable from the user's point of view. This patch fixes this issue by ensuring
the RenderLayerBacking's scrolling layer is created during updateScrollCoordinatedStatus.

Test: fast/scrolling/ios/update-scroll-coordinated-status.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus): Call updateConfiguration()
to ensure the scrolling layer is present and indicate whether a rebuild is necessary.

LayoutTests:

Add a test to ensure the change of scrolling status is reflected in the layer and scrolling
trees. This test should also ASSERT in debug mode without the associated code change.

  • fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Added.
  • fast/scrolling/ios/update-scroll-coordinated-status.html: Added.

Nov 5, 2018:

11:11 PM Changeset in webkit [237848] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[WPE] Remove BackingStore, BackingStoreCairo implementation files from build
​https://bugs.webkit.org/show_bug.cgi?id=191269

Reviewed by Michael Catanzaro.

  • SourcesWPE.txt: Drop the BackingStore.cpp and BackingStoreCairo.cpp

files from the WPE build. These are not used at all in WPE configuration
as they are only used by the GTK+ port for non-AC functionality.

11:09 PM Changeset in webkit [237847] by zandobersek@gmail.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Place Fontconfig-specific RefPtr specializations in RefPtrFontconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=191267

Reviewed by Michael Catanzaro.

Move the Fontconfig-specific RefPtr specialization declarations from
RefPtrCairo.h to RefPtrFontconfig.h, with definitions moved to the new
RefPtrFontconfig.cpp implementation file. These specializations are
not tied to Cairo in any way.

  • platform/FreeType.cmake:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cairo/RefPtrCairo.cpp:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:
  • platform/graphics/freetype/RefPtrFontconfig.cpp: Added.

(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/graphics/freetype/RefPtrFontconfig.h: Copied from Source/WebCore/platform/graphics/cairo/RefPtrCairo.h.
11:01 PM Changeset in webkit [237846] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

[CMake] Fix WebCore/Modules includes
​https://bugs.webkit.org/show_bug.cgi?id=191287

Reviewed by Fujii Hironori.

No new tests. No change in behavior.

Add in applicationmanifest to the list of includes and sort the
modules directory.

  • CMakeLists.txt:
8:35 PM Changeset in webkit [237845] by mmaxfield@apple.com
  • 17 edits in trunk

Cache glyph paths and share underline skipping code between all the ports
​https://bugs.webkit.org/show_bug.cgi?id=191239

Reviewed by Alex Christensen.

PerformanceTests:

Measures the performance of drawing a whole lot of underlines

  • Layout/underline.html: Added.

Source/WebCore:

I was hoping that caching the glyph paths was going to be a performance progression,
but it turns out that the additional overhead of WebCore::Path compensated for it.
In total, the performance is the same (my testing says that this patch is a 1%
progression, but that's within the noise).

Because the ink skipping logic is now shared among all ports, Windows now gets it for
free.

Test: PerformanceTests/Layout/underline.html

  • platform/graphics/Font.cpp:

(WebCore::Font::pathForGlyph const):

  • platform/graphics/Font.h:
  • platform/graphics/FontCascade.cpp:

(WebCore::computeUnderlineType):
(WebCore::GlyphIterationState::GlyphIterationState):
(WebCore::findIntersectionPoint):
(WebCore::updateX):
(WebCore::findPathIntersections):
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
(WebCore::GlyphToPathTranslator::containsMorePaths):
(WebCore::GlyphToPathTranslator::path):
(WebCore::GlyphToPathTranslator::extents):
(WebCore::GlyphToPathTranslator::underlineType):
(WebCore::GlyphToPathTranslator::advance):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap::existingMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::existingMetricsForGlyph const):
(WebCore::GlyphMetricsMap<std::optional<Path>>::unknownMetrics):

  • platform/graphics/TextRun.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformPathForGlyph const):
(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::CairoGlyphToPathTranslator::path): Deleted.
(WebCore::CairoGlyphToPathTranslator::extents): Deleted.
(WebCore::CairoGlyphToPathTranslator::underlineType): Deleted.
(WebCore::CairoGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::MacGlyphToPathTranslator::path): Deleted.
(WebCore::MacGlyphToPathTranslator::extents): Deleted.
(WebCore::MacGlyphToPathTranslator::underlineType): Deleted.
(WebCore::MacGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformPathForGlyph const):

  • rendering/TextDecorationPainter.cpp:

(WebCore::drawSkipInkUnderline):
(WebCore::TextDecorationPainter::paintTextDecoration):

Source/WTF:

Remove CSS3_TEXT_DECORATION_SKIP_INK. It's now interoperable and part of the Web Platform.

  • wtf/Platform.h:
8:32 PM Changeset in webkit [237844] by mmaxfield@apple.com
  • 23 edits in trunk/Source/WebCore

Clean up text decoration drawing code
​https://bugs.webkit.org/show_bug.cgi?id=191245

Reviewed by Zalan Bujtas.

This is some general clean up of the text decorations code. There is no behavior change.

This patch modifies GraphicsContext::drawLineForText() & friends to accept a FloatRect instead of a FloatPoint + float width.
This is helpful because it allows for easier bounding box calculations.
This patch also removes some redundant computations that the skip:ink codepath was performing.
This patch also refactors the wavy decoration parameters to not use out params.

No new tests because there is no behavior change.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::computeUnderlineBoundsForText):
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextImpl.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawLinesForText::apply const):
(WebCore::DisplayList::DrawLinesForText::localBounds const):
(WebCore::DisplayList::operator<<):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawLinesForText::create):
(WebCore::DisplayList::DrawLinesForText::thickness const):
(WebCore::DisplayList::DrawLinesForText::DrawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintMarkedTextDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline const):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

  • rendering/TextDecorationPainter.cpp:

(WebCore::strokeWavyTextDecoration):
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::drawSkipInkUnderline): Deleted.

  • rendering/TextDecorationPainter.h:

(WebCore::TextDecorationPainter::setInlineTextBox):
(WebCore::TextDecorationPainter::setWidth):
(WebCore::TextDecorationPainter::setFont): Deleted.
(WebCore::TextDecorationPainter::setBaseline): Deleted.

  • style/InlineTextBoxStyle.cpp:

(WebCore::getWavyStrokeParameters):
(WebCore::visualOverflowForDecorations):

  • style/InlineTextBoxStyle.h:
8:30 PM Changeset in webkit [237843] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after r237835
​https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

  • rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness::operator== const):

8:07 PM Changeset in webkit [237842] by Wenson Hsieh
  • 10 edits
    2 adds in trunk

[iOS] Swatch appears squished and off-center in inputs of type color
​https://bugs.webkit.org/show_bug.cgi?id=191279
<rdar://problem/45816319>

Reviewed by Tim Horton.

Source/WebCore:

This patch makes some small adjustments to color inputs on iOS to bring them closer to the intended design.
See comments below for more details.

Tests: fast/forms/color/color-input-uses-color-well-appearance.html

fast/forms/color/input-appearance-color.html

  • css/html.css:

Adjust the UA stylesheet for color inputs on iOS.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintDecorations):

When painting decorations for ColorWellPart, treat it as a standard button instead of the square button
appearance.

(WebCore::RenderTheme::colorInputStyleSheet const):

Add -webkit-appearance: color-well; to the stylesheet for color inputs. Previously, this was special-cased on
iOS, where color input elements had appearances of textfield; however, this patch makes some adjustments to
RenderThemeIOS, allowing us to use color-well on iOS.

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::platformUsesColorWellAppearance const): Deleted.

Remove this from RenderTheme. This is no longer necessary, since all platforms now use
-webkit-appearance: color-well;.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustButtonStyle const):

When painting buttons for color inputs, don't add rounded corners that are present by default for regular
buttons.

LayoutTests:

  • fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html: Added.
  • fast/forms/color/color-input-uses-color-well-appearance.html: Added.

Add a test to verify that setting -webkit-appearance: textfield; on a color input causes the color input to
render differently from a color input with a default appearance.

  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:

In the WebKit2 port of iOS, enable a handful of color input tests that are currently disabled.

  • platform/ios/fast/forms/color/input-appearance-color-expected.txt:

Rebaseline an existing test on iOS.

6:30 PM Changeset in webkit [237841] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.1.1

Tag Safari-606.3.4.1.1.

5:59 PM Changeset in webkit [237840] by Alan Coon
  • 1 edit in branches/safari-606.3.4.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

Apply patch. rdar://problem/45523764.

5:03 PM Changeset in webkit [237839] by bshafiei@apple.com
  • 8 edits
    2 adds in branches/safari-606.3.4.0-branch

Cherry-pick r237837. rdar://problem/45811371

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::setInterruptedForTesting):
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::beginInterruption): (WebCore::CoreAudioCaptureSource::endInterruption):
  • testing/Internals.cpp: (WebCore::Internals::setMediaStreamSourceInterrupted):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [237838] by bshafiei@apple.com
  • 7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

4:45 PM Changeset in webkit [237837] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setInterruptedForTesting):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::beginInterruption):
(WebCore::CoreAudioCaptureSource::endInterruption):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaStreamSourceInterrupted):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.
4:21 PM Changeset in webkit [237836] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Generalize trailing SDK specifier (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo):
(TestPlatformInfo.test_available_sdks):

4:11 PM Changeset in webkit [237835] by mmaxfield@apple.com
  • 18 edits
    6 adds in trunk

Parsing support for text-underline-offset and text-decoration-thickness
​https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

Source/WebCore:

Before we can implement the properties properly, we have to parse them.

​https://github.com/w3c/csswg-drafts/issues/3118#issuecomment-432297480 describes the grammar:

text-underline-position: auto | [ [ under | from-font]
[ left | right ] ]

text-underline-offset: auto | <length>
text-decoration-thickness: auto | from-font | <length>

This patch also takes the opportunity to update the grammar of text-underline-position to match the spec,
and to add an alias to the unprefixed version.

We still don't support the left and right values on text-underline-position. We should add those eventually.

Tests: fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html

fast/css3-text/css3-text-decoration/text-underline-offset-parse.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::textUnderlineOffsetToCSSValue):
(WebCore::textDecorationThicknessToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition const):
(WebCore::CSSPrimitiveValue::operator OptionSet<TextUnderlinePosition> const): Deleted.

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
(WebCore::StyleBuilderConverter::convertTextUnderlineOffset):
(WebCore::StyleBuilderConverter::convertTextDecorationThickness):

  • css/StyleResolver.cpp:

(WebCore::shouldApplyPropertyInParseOrder):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTextUnderlineOffset):
(WebCore::consumeTextDecorationThickness):
(WebCore::CSSPropertyParser::parseSingleValue):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textUnderlinePosition const):
(WebCore::RenderStyle::textUnderlineOffset const):
(WebCore::RenderStyle::textDecorationThickness const):
(WebCore::RenderStyle::setTextUnderlinePosition):
(WebCore::RenderStyle::setTextUnderlineOffset):
(WebCore::RenderStyle::setTextDecorationThickness):
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::initialTextUnderlineOffset):
(WebCore::RenderStyle::initialTextDecorationThickness):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/TextDecorationThickness.h: Added.

(WebCore::TextDecorationThickness::createWithAuto):
(WebCore::TextDecorationThickness::createFromFont):
(WebCore::TextDecorationThickness::createWithLength):
(WebCore::TextDecorationThickness::isAuto const):
(WebCore::TextDecorationThickness::isFromFont const):
(WebCore::TextDecorationThickness::isLength const):
(WebCore::TextDecorationThickness::setLengthValue):
(WebCore::TextDecorationThickness::lengthValue const):
(WebCore::TextDecorationThickness::operator== const):
(WebCore::TextDecorationThickness::operator!= const):
(WebCore::TextDecorationThickness::TextDecorationThickness):
(WebCore::operator<<):

  • rendering/style/TextUnderlineOffset.h: Added.

(WebCore::TextUnderlineOffset::createWithAuto):
(WebCore::TextUnderlineOffset::createWithLength):
(WebCore::TextUnderlineOffset::isAuto const):
(WebCore::TextUnderlineOffset::isLength const):
(WebCore::TextUnderlineOffset::setLengthValue):
(WebCore::TextUnderlineOffset::lengthValue const):
(WebCore::TextUnderlineOffset::lengthOr const):
(WebCore::TextUnderlineOffset::operator== const):
(WebCore::TextUnderlineOffset::operator!= const):
(WebCore::TextUnderlineOffset::TextUnderlineOffset):
(WebCore::operator<<):

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

  • style/InlineTextBoxStyle.h:

LayoutTests:

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html: Update the

test for the new grammar of text-underline-position

  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse.html: Added.
4:09 PM Changeset in webkit [237834] by mmaxfield@apple.com
  • 20 edits
    9 adds in trunk

Spelling dots are drawn in the wrong place
​https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

  • Dots should not be clipped.
  • Dots should be horizontally centered.
  • Dots should be drawn behind the text.
  • Distance from the baseline to the top of the dot should be 11.035% of font size.
  • Dot diameter should be 13.247% of the font size.
  • Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
  • The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html

editing/spelling/spelling-dots-position-3.html
editing/spelling/spelling-dots-position.html
editing/spelling/spelling-dots-repaint.html

  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,

because there is no guarantee the spelling dots will lie inside the layout rect of the element.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.

  • rendering/InlineFlowBox.h: Comments should explain why, not say what.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.

  • rendering/InlineTextBox.h: Declare the helper methods.
  • rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of

spelling dots opt us out of SLL.

(WebCore::SimpleLineLayout::canUseForWithReason):

  • rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printReason):

  • rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

  • editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,

this is a version of Ahem with a very small descent, so that the dots don't intersect
with the text itself.

  • editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-expected.html: Added.
  • editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in

the wrong place.

  • editing/spelling/spelling-dots-repaint-expected.html: Added.
  • editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element

with spelling dots, and then deleting the element from the document. The spelling
dots should be removed too.

  • fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
  • fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate

for new spelling dot positions.

3:59 PM Changeset in webkit [237833] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
​https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:
3:11 PM Changeset in webkit [237832] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=191278

Unreviewed test gardening.

2:03 PM Changeset in webkit [237831] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: turn off Start button when all tests are removed
​https://bugs.webkit.org/show_bug.cgi?id=191235

Reviewed by Matt Baker.

  • UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):

1:38 PM Changeset in webkit [237830] by Chris Dumez
  • 7 edits in trunk

Use same limit for page cache and suspended pages
​https://bugs.webkit.org/show_bug.cgi?id=191266

Reviewed by Geoffrey Garen.

Source/WebKit:

Use same limit for page cache and suspended pages as they serve the same purpose.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _maximumSuspendedPageCount]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateMaxSuspendedPageCount):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::addSuspendedPageProxy):

  • UIProcess/WebProcessPool.h:

Tools:

Update API tests accordingly.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12:43 PM Changeset in webkit [237829] by ajuma@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests/imported/w3c

[IntersectionObserver] Update WPTs to the latest upstream version
​https://bugs.webkit.org/show_bug.cgi?id=191274

Reviewed by Simon Fraser.

  • web-platform-tests/intersection-observer/bounding-box-expected.txt:
  • web-platform-tests/intersection-observer/bounding-box.html:
  • web-platform-tests/intersection-observer/target-in-different-window-expected.txt: Added.
  • web-platform-tests/intersection-observer/target-in-different-window.html: Added.
  • web-platform-tests/intersection-observer/w3c-import.log:
12:36 PM Changeset in webkit [237828] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp

Another attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:26 PM Changeset in webkit [237827] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:03 PM Changeset in webkit [237826] by Basuke Suzuki
  • 2 edits in trunk/Tools

[style] Exclude style check for auto generated files.
​https://bugs.webkit.org/show_bug.cgi?id=191118

Reviewed by Eric Carlson.

Some files checked in to the repository are generated by other tools. In this patch,
"MiniBrowserLibResource.h" is the file generated and managed by resource editor of
VisualStudio.

There's no need to check these files because it's not practical to fix the style errors
or it's hard to maintain those fixes.

  • Scripts/webkitpy/style/checkers/cpp.py:

(is_generated_file):
(CppChecker.check):

11:58 AM Changeset in webkit [237825] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash under DOMWindow::postMessageTimerFired()
​https://bugs.webkit.org/show_bug.cgi?id=191217
<rdar://problem/40888466>

Reviewed by Geoffrey Garen.

Source/WebCore:

Protect the frame in DOMWindow::postMessageTimerFired() before calling dispatchEvent() as dispatching the
event may cause JS to run and this JS may cause the frame to be destroyed, in which case we will crash
when trying to use the frame on the next line.

Test: fast/dom/Window/remove-frame-in-message-event-handler.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/remove-frame-in-message-event-handler-expected.txt: Added.
  • fast/dom/Window/remove-frame-in-message-event-handler.html: Added.
11:38 AM Changeset in webkit [237824] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=190680

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

  • flatpak/org.webkit.WebKit.yaml:
11:35 AM Changeset in webkit [237823] by don.olmstead@sony.com
  • 6 edits in trunk/Source/JavaScriptCore

Fix typos in closing ENABLE guards
​https://bugs.webkit.org/show_bug.cgi?id=191273

Reviewed by Keith Miller.

  • ftl/FTLForOSREntryJITCode.h:
  • ftl/FTLJITCode.h:
  • jsc.cpp:
  • wasm/WasmMemoryInformation.h:
  • wasm/WasmPageCount.h:
11:35 AM Changeset in webkit [237822] by dbates@webkit.org
  • 2 edits in trunk/Tools

[lldb-webkit] Fix formatting nits in Document and Frame summary strings
​https://bugs.webkit.org/show_bug.cgi?id=191094

Reviewed by Andy Estes.

Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
Document summary and add closing brace '}' to both Frame and Document summary strings to make
them look pretty.

  • lldb/lldb_webkit.py:

(WebCoreFrame_SummaryProvider):
(WebCoreDocument_SummaryProvider):

11:21 AM Changeset in webkit [237821] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make static_asserts in APICast into bitwise_cast
​https://bugs.webkit.org/show_bug.cgi?id=191272

Reviewed by Filip Pizlo.

  • API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

11:18 AM Changeset in webkit [237820] by Wenson Hsieh
  • 6 edits in trunk

[iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
​https://bugs.webkit.org/show_bug.cgi?id=191240
<rdar://problem/44872806>

Reviewed by Tim Horton.

Source/WebKit:

Allow WKWebView clients to override WKContentView's default input assistant item by plumbing the call to
-inputAssistantItem through -[WKWebView inputAssistantItem], such that if a client asks WKWebView for its
input assistant item and changes its leading or trailing bar button groups, the changes will be reflected by
WKContentView; additionally, this allows clients to achieve the same effect by overriding -inputAssistantItem
on WKWebView.

Test: KeyboardInputTests.ModifyInputAssistantItemBarButtonGroups

KeyboardInputTests.OverrideInputAssistantItemBarButtonGroups

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView inputAssistantItem]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAssistantItem]):

Route the call to [super inputAssistantItem] through -[WKWebView inputAssistantItem], so that the input
assistant item may be overridden via WKWebView.

(-[WKContentView inputAssistantItemForWebView]):

Tools:

Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
overriding -[WKWebView inputAssistantItem].

  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
(-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
(+[InputAssistantItemTestingWebView barButtonIcon]):
(+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
(+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
(-[InputAssistantItemTestingWebView inputAssistantItem]):
(TestWebKitAPI::TEST):

11:15 AM Changeset in webkit [237819] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects
​https://bugs.webkit.org/show_bug.cgi?id=190035

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

We can't rely on GStreamer timestamps to pass to EncodedImages after encoding
because libWebRTC doesn't use the timestamp we fed it but does
some computation on the input timestamp in the images we pass in before it passes
them back to the encoder. Then internally LibWebRTC relies on those exact timestamps
passed into the encoder to do checks and compute RTP timestamps so we need to carefully
pass the exact timestamps to LibWebRTC (in practice we still use GStreamer timestamps in
all the GStreamer processing pipelines as the WebRTC object basically wraps the "same"
GstSample all around, but we are not synced on the clock anyway).

  • platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:

(WebCore::LibWebRTCVideoFrameFromGStreamerSample):

  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::newSampleCallback):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::newSampleCallback):

11:12 AM Changeset in webkit [237818] by Wenson Hsieh
  • 6 edits
    2 adds in trunk

[iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
​https://bugs.webkit.org/show_bug.cgi?id=191226
<rdar://problem/45781765>

Reviewed by Tim Horton.

Source/WebCore:

When _setViewScale: SPI is used to adjust the layout scale factor of the page, we multiply minimum, initial
and maximum scales by the given layout scale factor to adjust for a larger or smaller minimum layout size.
However, in the case where the layout size scale factor is greater than 1 and we're also forcing the viewport to
be scalable, we override the default minimum scale with 1 (i.e. forceAlwaysUserScalableMinimumScale). This
means that the might be off by a small margin due to rounding error when computing the content width and view
width (see: r237743).

This means that in the case where (1) the viewport is forced to be user-scalable, and (2) we're ignoring meta
viewport parameters, and (3) _viewScale exceeds 1, we may end up computing a slightly different minimum scale
than the default minimum scale multiplied by the layout size scale factor; subsequently, the page scale factor
will be slightly different from initial scale, such that we'll no longer zoom to the new initial scale when
changing view scale.

This patch adjusts forceAlwaysUserScalableMinimumScale and forceAlwaysUserScalableMaximumScale to take the
current layout scale factor into account when computing min and max scales when the viewport is forced to be
always scalable.

Test: fast/viewport/ios/minimum-scale-after-changing-view-scale.html

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::minimumScale const):

  • page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::maximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMaximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMinimumScale const):

Turn these from constant values to const functions on ViewportConfiguration, which factor in the current
viewport layout size scale factor.

Tools:

Add a missing check for shouldIgnoreMetaViewport when comparing TestOptions, to ensure that "ignore meta
viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Add a new layout test that sets the view scale to several values greater than or equal to 1 and verifies that
the minimum scale and resulting scroll view scale are exactly the same as the view scale, when (1) the "ignores
meta viewport" preference is enabled, and (2) the viewport is forced to be always scalable.

  • fast/viewport/ios/minimum-scale-after-changing-view-scale-expected.txt: Added.
  • fast/viewport/ios/minimum-scale-after-changing-view-scale.html: Added.
11:01 AM Changeset in webkit [237817] by Matt Baker
  • 5 edits in trunk

Web Inspector: Table selection should not require that rows be in the cache
​https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

  • inspector/table/table-selection-expected.txt:
  • inspector/table/table-selection.html:
10:37 AM Changeset in webkit [237816] by dino@apple.com
  • 6 edits
    1 add in trunk/Source/WebCore

Expose a constructor for PointerEvent from PlatformTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=191238
<rdar://problem/45795682>

Reviewed by Antoine Quint.

Implement a constructor that takes a PlatformTouchEvent to
create a PointerEvent. At the moment the code to call this
constructor will live in WebKitAdditions, so no new tests
yet.

  • SourcesCocoa.txt: Add PointerEventIOS.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventNames.h: Add macros for pointerdown, pointermove,

pointerup, pointercancel.

  • dom/PointerEvent.cpp: Remove JSC namespace.
  • dom/PointerEvent.h: Add create and constructor that takes

a PlatformTouchEvent.

  • dom/ios/PointerEventIOS.cpp: Added.
10:09 AM Changeset in webkit [237815] by Alan Coon
  • 9 edits
    2 adds in tags/Safari-607.1.12.2

Cherry-pick r237774. rdar://problem/45377609

Mac production builds should sign the network process xpc service with entitlements
​https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
  • Configurations/NetworkService.xcconfig: Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process, except with the corresponoding network process entitlements file.
  • UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _networkProcessHasEntitlementForTesting:]):
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):
  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj: Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [237814] by Alan Coon
  • 4 edits
    1 add in tags/Safari-607.1.12.2

Cherry-pick r237711. rdar://problem/44176965

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
​https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

  • loader/ResourceLoadObserver.cpp: (WebCore::ResourceLoadObserver::logSubresourceLoading): (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added. (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]): (-[KeyboardEventListener handleEvent:]): (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:07 AM Changeset in webkit [237813] by Ryan Haddad
  • 17 edits in trunk/Source

Unreviewed, rolling out r237785.

Introduced layout test and API test failures on macOS and iOS.

Reverted changeset:

"[iOS] Issue initial paint soon after the visuallyNonEmpty
milestone is fired."
​https://bugs.webkit.org/show_bug.cgi?id=191078
​https://trac.webkit.org/changeset/237785

10:03 AM Changeset in webkit [237812] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r237784 and r237788.
​https://bugs.webkit.org/show_bug.cgi?id=191270

Caused mediastream layout test failures (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
​https://bugs.webkit.org/show_bug.cgi?id=191227
​https://trac.webkit.org/changeset/237784

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
​https://bugs.webkit.org/show_bug.cgi?id=191227
​https://trac.webkit.org/changeset/237788

9:54 AM Changeset in webkit [237811] by Chris Dumez
  • 10 edits
    4 adds in trunk/LayoutTests

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=191214

Reviewed by Geoff Garen.

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests from
upstream c583bcd7eb.

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.js: Added.

(test.frame.contentWindow.onpagehide):
(test.frame.contentDocument.onvisibilitychange):
(test.frame.contentWindow.onbeforeunload):
(test.frame.contentWindow.onunload):
(test):
(async_test):

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:
9:47 AM Changeset in webkit [237810] by Lucas Forschler
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

9:43 AM Changeset in webkit [237809] by msaboff@apple.com
  • 2 edits in trunk/JSTests

Unreviewed build fix for linux.

  • stress/regexp-compile-oom.js: Disabled for non-darwin OSes.
9:34 AM Changeset in webkit [237808] by Devin Rousso
  • 12 edits
    1 add in trunk

Web Inspector: show save/restore stack for recorded 2D Canvases
​https://bugs.webkit.org/show_bug.cgi?id=175283
<rdar://problem/34040756>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Instead of using plain objects for holding the WI.Recording's state, use a model object
so that more data can be passed around. When visualizing the state, show any previously
saved states in a WI.DetailsSection underneath the current state. If there are no saved
states (meaning there is only the current state), don't use a WI.DetailsSection.

  • UserInterface/Models/RecordingState.js: Added.

(WI.RecordingState):
(WI.RecordingState.fromContext):
(WI.RecordingState.async swizzleInitialState):
(WI.RecordingState.prototype.get source):
(WI.RecordingState.prototype.has):
(WI.RecordingState.prototype.get return):
(WI.RecordingState.prototype.toJSON):
(WI.RecordingState.prototype.[Symbol.iterator]):

  • UserInterface/Models/Recording.js:

(WI.Recording.prototype.async _process):
(WI.Recording.prototype.async _swizzleState): Deleted.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):
(WI.RecordingAction.deriveCurrentState): Deleted.

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement):
(WI.RecordingStateDetailsSidebarPanel.prototype.sizeDidChange): Added.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.isColorProperty): Deleted.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.createInlineSwatch): Deleted.

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.css:

(.sidebar > .panel.details.recording-state > .content .details-section > .header .source): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr.modified): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected).non-standard .name-column): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected) .unavailable): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid .inline-swatch): Added.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected).non-standard): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected) .unavailable): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid .inline-swatch): Deleted.

  • UserInterface/Main.html:
  • UserInterface/Test.html:
  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • inspector/canvas/recording-2d.html:
  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.log):
(TestPage.registerInitializer.async logRecording):

9:33 AM Changeset in webkit [237807] by Alan Coon
  • 7 edits in tags/Safari-607.1.12.2/Source

Versioning.

9:27 AM Changeset in webkit [237806] by Alan Coon
  • 1 copy in tags/Safari-607.1.12.2

New tag.

8:45 AM Changeset in webkit [237805] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test runner fails to respect default build type
​https://bugs.webkit.org/show_bug.cgi?id=190247

Reviewed by Carlos Garcia Campos.

Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.

  • glib/api_test_runner.py:

(TestRunner.init):

8:16 AM WebKitGTK/2.22.x edited by Michael Catanzaro
(diff)
8:08 AM Changeset in webkit [237804] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer][WebRTC] Error out when simulcast is activated
​https://bugs.webkit.org/show_bug.cgi?id=190678

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Implementing it is not for now yet.
Source/WebCore:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::InitEncode):

LayoutTests:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
8:07 AM Changeset in webkit [237803] by dinfuehr@igalia.com
  • 12 edits in trunk

Enable LLInt on ARMv7/Linux
​https://bugs.webkit.org/show_bug.cgi?id=191190

Reviewed by Yusuke Suzuki.

After enabling the new bytecode format in r237547, C_LOOP was
forced on all 32-bit platforms. Now enable LLInt again on
.:

ARMv7-Thumb2/Linux by default.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

ARMv7-Thumb2/Linux.

This adds a callee-saved register in ARMv7/Linux for the metadataTable and
stores/restores it on LLInt function calls. It also introduces the globaladdr-
instruction for the ARM-offlineasm to access the opcode-table.

  • jit/GPRInfo.h:
  • jit/RegisterSet.cpp:

(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • offlineasm/arm.rb:
  • offlineasm/asm.rb:
  • offlineasm/instructions.rb:

Source/WTF:

ARMv7-Thumb2/Linux by default.

  • wtf/Platform.h:
7:32 AM Changeset in webkit [237802] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
​https://bugs.webkit.org/show_bug.cgi?id=191241

Reviewed by Eric Carlson.

Moving the logic to observe the audio source to the point where the
RealtimeOutgoingAudioSource subclass is fully initialized.
Covered by existing tests.

  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::observeSource):

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::RealtimeOutgoingAudioSourceLibWebRTC):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):

7:09 AM Changeset in webkit [237801] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
​https://bugs.webkit.org/show_bug.cgi?id=190674

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
it can use to implement encoding for different formats exposing a trimmed down unified API.

It also adds proper handling of H264 profiles.

The added files follow GStreamer coding style as we aim at upstreaming the element
in the future.

Source/WebCore:

This is a refactoring so current tests already cover it.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: Added.

(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_bitrate):
(gst_webrtc_video_encoder_set_format):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(setup_x264enc):
(setup_vp8enc):
(setup_openh264enc):
(set_bitrate_kbit_per_sec):
(set_bitrate_bit_per_sec):
(gst_webrtc_video_encoder_class_init):
(gst_webrtc_video_encoder_init):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.h: Added.
  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::ImplementationName const):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):

Tools:

Reviewed by Philippe Normand.

  • Scripts/webkitpy/style/checker.py:
7:05 AM Changeset in webkit [237800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
​https://bugs.webkit.org/show_bug.cgi?id=190676

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Avoiding to have h264parse make assumption (which might be wrong at some
point).

  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

6:50 AM Changeset in webkit [237799] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Do not sync libwerbtc stream on the clock
​https://bugs.webkit.org/show_bug.cgi?id=190677

The approach here is basically to let libwebrtc do all the
synchronisation for us, and the same way as it is done in apple ports,
we basically try to display what libwebrtc outputs as fast as possible.

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Manually tested

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setSyncOnSink):
(WebCore::MediaPlayerPrivateGStreamer::syncOnClock):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
6:47 AM Changeset in webkit [237798] by ajuma@chromium.org
  • 4 edits in trunk

[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
​https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

  • web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

  • dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):

5:55 AM Changeset in webkit [237797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove some virtual methods in CachedRawResource
​https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

  • loader/cache/CachedRawResource.h:
4:19 AM Changeset in webkit [237796] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

2:46 AM Changeset in webkit [237795] by Michael Catanzaro
  • 2 edits in trunk/Tools

REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191225

Reviewed by Alejandro G. Castro.

Fix a memory leak causing this test to fail.

  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):

2:00 AM Changeset in webkit [237794] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

[GStreamer] Move elements registration to GStreamerCommon
​https://bugs.webkit.org/show_bug.cgi?id=191189

Reviewed by Xabier Rodriguez-Calvar.

It was a bit odd to have this in the base player class and to have
sub-classes calling a static function of the super-class.

Covered by existing tests.

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamerAndRegisterWebKitElements):

  • platform/graphics/gstreamer/GStreamerCommon.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

1:34 AM Changeset in webkit [237793] by Fujii Hironori
  • 2 edits in trunk/Source/JavaScriptCore

[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
​https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

  • jit/JIT.h: Changed is64BitType from a template class method to a

template inner class.

1:08 AM Changeset in webkit [237792] by zandobersek@gmail.com
  • 10 edits
    14 adds in trunk/LayoutTests

Unreviewed WPE gardening. Updating or adding various baselines. Also
adding new failure expectations for tests that need a closer look.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • platform/wpe/fast/block/basic/height-percentage-simple-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-image-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
  • platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • platform/wpe/fast/history: Added.
  • platform/wpe/fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Added.
  • platform/wpe/fast/inline-block/14498-positionForCoordinates-expected.txt:
  • platform/wpe/fast/inline/simple-inline-block-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-float1-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats2-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats3-expected.txt: Added.
  • platform/wpe/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/context/context-hidden-alpha-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/get-extension-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-image-data-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:
12:03 AM Changeset in webkit [237791] by Michael Catanzaro
  • 2 edits in trunk

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
​https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:

Nov 4, 2018:

10:50 PM Changeset in webkit [237790] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[webkitpy] Support WPE in the run-web-platform-tests script
​https://bugs.webkit.org/show_bug.cgi?id=191183

Reviewed by Alex Christensen.

  • Scripts/webkitpy/w3c/wpt_runner.py:

(parse_args): Support --wpe as an argument that specifies WPE as the
target port. Additionally, the --display-server flag now accepts
headless as a valid value, enabling the WPE WebDriver to run in
headless mode.

8:38 PM Changeset in webkit [237789] by Fujii Hironori
  • 6 edits in trunk

[Win] Use C++14, not C++17
​https://bugs.webkit.org/show_bug.cgi?id=191101

Reviewed by Alex Christensen.

.:

Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
<​https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>

  • Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.

Source/WTF:

  • wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version

instead of _MSC_FULL_VER.

Tools:

std::basic_string::data() returns a read-only const buffer in
C++14.

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.

8:29 PM Changeset in webkit [237788] by Fujii Hironori
  • 3 edits in trunk/Source/WebKit

[MediaStream] User should not be prompted again after denying getDisplayMedia request
​https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
  • UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.
6:15 PM Changeset in webkit [237787] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove ENABLE_OPENCL fully
​https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::applyAll): Deleted.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

1:19 PM Changeset in webkit [237786] by Wenson Hsieh
  • 6 edits in trunk/Tools

[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
​https://bugs.webkit.org/show_bug.cgi?id=191231

Reviewed by Simon Fraser.

Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
it can be shared between iOS-family and macOS platforms. See below for more details.

No change in behavior.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::overridePreference):

Add a method stub for DumpRenderTree.

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:
  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):

Unify these method implementations.

(WTR::UIScriptController::removeViewFromWindow):
(WTR::UIScriptController::addViewToWindow):

Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.

(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::findString):
(WTR::UIScriptController::contentsOfUserInterfaceItem const):

Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::overridePreference): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.

8:38 AM Changeset in webkit [237785] by Alan Bujtas
  • 17 edits in trunk/Source

[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
​https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

  1. Improve visuallyNonEmpty milestone confidence level.

Ignore whitespace and non visible text content.
Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
Check if the html/body is actually visible.

  1. Issue initial paint soon after the milestone fires.

Use a 0ms timer to flush the initial paint.
Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling)

  1. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint.
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.

  • platform/graphics/FontCascade.h:
  • rendering/RenderText.cpp: Check whether the text is actually visible at this point.

(WebCore::RenderText::RenderText):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):

  • WebProcess/WebPage/AcceleratedDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

8:04 AM Changeset in webkit [237784] by eric.carlson@apple.com
  • 5 edits in trunk

[MediaStream] User should not be prompted again after denying getDisplayMedia request
​https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

7:46 AM Changeset in webkit [237783] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][BFC] Add support for percentage height in quirks mode.
​https://bugs.webkit.org/show_bug.cgi?id=191232

Reviewed by Antti Koivisto.

Source/WebCore:

In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.

Test: fast/block/basic/quirk-mode-percent-height.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):

  • layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • fast/block/basic/quirk-mode-percent-height.html: Added.
  • platform/ios/TestExpectations:
7:44 AM Changeset in webkit [237782] by Alan Bujtas
  • 8 edits
    2 adds in trunk

[LFC][BCF] Add support for block level non-replaced inflow height percentage
​https://bugs.webkit.org/show_bug.cgi?id=191229

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/basic/child-block-level-box-with-height-percent.html

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • fast/block/basic/child-block-level-box-with-height-percent.html: Added.
  • platform/ios/TestExpectations:
7:30 AM Changeset in webkit [237781] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource should use DestructionThread::Main
​https://bugs.webkit.org/show_bug.cgi?id=191230

Reviewed by Eric Carlson.

Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
7:05 AM Changeset in webkit [237780] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore

[GTK] Cannot make debug builds of JSC using release 2.22.3
​https://bugs.webkit.org/show_bug.cgi?id=191233

Unreviewed build fix.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
Use context.asStructureForInContext() instead of explicit cast and
remove the unneeded assertion, which is already done in the helper
function.

2:28 AM Changeset in webkit [237779] by youenn@apple.com
  • 10 edits
    3 adds in trunk

IDB should allow storing RTCCertificate
​https://bugs.webkit.org/show_bug.cgi?id=191077

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added.
  • web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added.

Source/WebCore:

Add support for serialization/deserialization of RTCCertificate.
Store the origin in RTCCertificate and make sure that a certificate
with a different origin cannot be used to create a RTCPeerConnection.

Test: imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::generateCertificate):

  • Modules/mediastream/RTCCertificate.cpp:

(WebCore::RTCCertificate::create):
(WebCore::RTCCertificate::RTCCertificate):

  • Modules/mediastream/RTCCertificate.h:

(WebCore::RTCCertificate::origin const):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::certificatesFromConfiguration):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:

(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):

  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::CachedString::takeString):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

Nov 4, 2018:

12:55 AM Changeset in webkit [237778] by youenn@apple.com
  • 11 edits
    1 add in trunk

Add support for RTCMuxPolicy
​https://bugs.webkit.org/show_bug.cgi?id=191188

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt:
  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/WebCore:

Add support for RTCMuxPolicy dictionary option for both constructor and setConfiguration.
Make sure setConfiguration throws if trying to change this policy.
Pipe this parameter up to libwebrtc.
Covered by rebased test.

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::rtcpMuxPolicyfromConfiguration):
(WebCore::configurationFromMediaEndpointConfiguration):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mediastream/RTCPMuxPolicy.h: Added.

Nov 3, 2018:

4:24 PM Changeset in webkit [237777] by Devin Rousso
  • 19 edits in trunk

Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context
​https://bugs.webkit.org/show_bug.cgi?id=190854

Reviewed by Matt Baker.

Source/WebCore:

Updated existing tests: inspector/canvas/recording-2d.html

inspector/canvas/recording-bitmaprenderer.html
inspector/canvas/recording-webgl.html

  • html/HTMLCanvasElement.idl:

Apply CallTracingCallback=recordCanvasAction to the width and height attributes so
that they are recorded through the same path as CanvasRenderingContext.

  • html/CanvasBase.h:
  • html/CanvasBase.cpp:

(WebCore::CanvasBase::callTracingActive const): Added.

  • bindings/js/CallTracer.h:
  • bindings/js/CallTracer.cpp:

(WebCore::CallTracer::recordCanvasAction):

Source/WebInspectorUI:

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction.prototype.get contextReplacer): Added.
(WI.RecordingAction.prototype.async.swizzle):
(WI.RecordingAction.prototype.apply):
Create a constant list of actions for each recording type that need to replace the context
with a different value before being applied (e.g. width should be applied to the
context's canvas instead of directly to the context).

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D.actionModifiesPath): Added.
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView._actionModifiesPath): Deleted.
Generate the path context after the actions are applied to the preview context so that the
final width/height are known and can be used. This is needed because changing the
width/height causes the content to be erased.

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._classNameForAction):

  • UserInterface/Views/RecordingActionTreeElement.css:

(.tree-outline:focus .item.action.selected:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.item.action > .titles .context-replacer::after): Added.
(.item.action.has-context-replacer > .icon): Added.
(@media (prefers-dark-interface) .item.action:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.tree-outline:focus .item.action.selected:not(.initial-state, .invalid) > .icon): Deleted.
(@media (prefers-dark-interface) .item.action:not(.initial-state) > .icon): Deleted.
(@media (prefers-dark-interface) .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon): Deleted.
Add the context replacer text to the beginning of the action's name if it exists.

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._refreshPixelSize):
(WI.CanvasContentView.prototype._updatePixelSize): Deleted.
Update preview image when the canvas' size changes.

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:
  • inspector/canvas/recording-bitmaprenderer-expected.txt:
  • inspector/canvas/recording-bitmaprenderer.html:
  • inspector/canvas/recording-webgl-expected.txt:
  • inspector/canvas/recording-webgl.html:
11:45 AM Changeset in webkit [237776] by aestes@apple.com
  • 5 edits in trunk

[Payment Request] PaymentResponse.retry()'s errorFields should be optional
​https://bugs.webkit.org/show_bug.cgi?id=191212

Reviewed by Youenn Fablet.

Source/WebCore:

Per WebIDL, the errorFields argument to PaymentResponse.retry() should be optional. See
<​https://github.com/w3c/payment-request/issues/804> for details.

Added test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

  • Modules/paymentrequest/PaymentResponse.idl:

LayoutTests:

  • http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
  • http/tests/paymentrequest/payment-response-retry-method.https.html:
10:57 AM Changeset in webkit [237775] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][BFC] Resolve percentage height values.
​https://bugs.webkit.org/show_bug.cgi?id=191224

Reviewed by Antti Koivisto.

Source/WebCore:

10.5 Content height: the 'height' property
The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height),
and this element is not absolutely positioned, the used height is calculated as if 'auto' was specified.

​https://www.w3.org/TR/CSS22/visudet.html#propdef-height

Test: fast/block/basic/height-percentage-simple.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::isHeightAuto):
(WebCore::Layout::computedHeightValue):
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/height-percentage-simple-expected.txt: Added.
  • fast/block/basic/height-percentage-simple.html: Added.
  • platform/ios/TestExpectations:
8:22 AM Changeset in webkit [237774] by achristensen@apple.com
  • 9 edits
    2 adds in trunk

Mac production builds should sign the network process xpc service with entitlements
​https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
  • Configurations/NetworkService.xcconfig:

Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):

  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj:

Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.

(TEST):

7:57 AM Changeset in webkit [237773] by youenn@apple.com
  • 88 edits
    2 copies
    4 moves
    43 adds
    3 deletes in trunk/LayoutTests

Refresh WPT webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=191133

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/: Refreshed.
  • web-platform-tests/webrtc/w3c-import.log:

LayoutTests:

7:29 AM Changeset in webkit [237772] by Philippe Normand
  • 2 edits in trunk/Source/WebKit

[WPE] Add the WebKitVersion.h header
​https://bugs.webkit.org/show_bug.cgi?id=191015
<rdar://problem/45647211>

Reviewed by Michael Catanzaro.

  • PlatformWPE.cmake: Install the generated header as well.
7:04 AM Changeset in webkit [237771] by Michael Catanzaro
  • 2 edits in trunk/WebDriverTests

Unreviewed, fix WebDriver expectations syntax after previous commit

6:30 AM Changeset in webkit [237770] by eric.carlson@apple.com
  • 9 edits
    3 adds in trunk

[MediaStream] enumerateDevices should not expose devices that are not available to getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=191177
<rdar://problem/45747873>

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html

  • Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start): Only expose devices that are available to gUM.

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::isSecure): Moved from UserMediaRequest.cpp.
(WebCore::isAllowedToUse): Ditto.
(WebCore::UserMediaController::canCallGetUserMedia): Modified from UserMediaRequest.cpp.
(WebCore::UserMediaController::logGetUserMediaDenial): Log reason for denial.

  • Modules/mediastream/UserMediaController.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start): Use UserMediaController::canCallGetUserMedia.
(WebCore::isSecure): Deleted.
(WebCore::isAllowedToUse): Deleted.
(WebCore::canCallGetUserMedia): Deleted.

LayoutTests:

  • http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt: Added.
  • http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html: Added.
  • http/tests/media/media-stream/resources/enumerate-devices-iframe.html: Added.
  • http/tests/ssl/media-stream/get-user-media-different-host-expected.txt: Rebased for updated logging.
  • http/tests/ssl/media-stream/get-user-media-nested-expected.txt: Ditto.
Note: See TracTimeline for information about the timeline view.