Timeline
Jan 15, 2019:
- 10:40 PM Changeset in webkit [240032] by
-
- 4 edits in trunk/Source
Unreviewed WinCairo build fix.
Source/WebCore:
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::createCurlRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::getCredential):
Source/WebKit:
- WebProcess/WebPage/WebPageInspectorTargetController.cpp:
(WebKit::WebPageInspectorTargetController::connectInspector): Use 'auto' instead of unprefixed InspectorTarget.
(WebKit::WebPageInspectorTargetController::disconnectInspector): Ditto.
(WebKit::WebPageInspectorTargetController::sendMessageToTargetBackend): Ditto.
- 9:03 PM Changeset in webkit [240031] by
-
- 16 edits in trunk/Source
Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
https://bugs.webkit.org/show_bug.cgi?id=193368
Reviewed by Geoff Garen.
Source/WebCore:
The NetworkStorageSession ownership needs to move to the WebKit/WebKitLegacy layer instead of being a process-global static map.
- loader/EmptyClients.cpp:
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::defaultCredentialStorage): Deleted.
- platform/network/CredentialStorage.h:
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::ensureSession):
- platform/network/cf/NetworkStorageSessionCFNetWin.cpp:
(WebCore::createPrivateStorageSession):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::getCredential):
Source/WebKit:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::getAuthenticationInfo):
Source/WebKitLegacy/mac:
- Misc/WebCache.mm:
(+[WebCache clearCachedCredentials]):
- Misc/WebDownload.mm:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
- Plugins/WebBaseNetscapePluginView.mm:
(WebKit::getAuthenticationInfo):
Source/WebKitLegacy/win:
- WebDownloadCFNet.cpp:
(WebDownload::didReceiveAuthenticationChallenge):
- 8:57 PM Changeset in webkit [240030] by
-
- 5 edits in trunk/Source/WebKit
Remove more NetworkProcess::singleton use
https://bugs.webkit.org/show_bug.cgi?id=193484
Reviewed by Geoffrey Garen.
This removes the use of NetworkProcess::singleton in the LegacyCustomProtocolManager.
This is the kind of awful duct tape code that keeps me awake at night, but it's necessary
because we can't quite remove LegacyCustomProtocolManager yet but we need to allow more than
one NetworkProcess object. To make it work well enough until we remove LegacyCustomProtocolManager,
use the last NetworkProcess object that has been created.
- NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
(newestNetworkProcess):
(LegacyCustomProtocolManager::networkProcessCreated):
(+[WKCustomProtocol canInitWithRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
- NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
- NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
- 8:27 PM Changeset in webkit [240029] by
-
- 2 edits in trunk/Source/WebKit
Fix WinCairo build after r240014
https://bugs.webkit.org/show_bug.cgi?id=161106
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
- 8:20 PM Changeset in webkit [240028] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
Fix Windows build after r240014
https://bugs.webkit.org/show_bug.cgi?id=161106
- WebView.cpp:
- 7:35 PM Changeset in webkit [240027] by
-
- 7 edits2 adds in trunk
VisualViewport API should be updated upon opening of keyboard
https://bugs.webkit.org/show_bug.cgi?id=193475
Reviewed by Simon Fraser.
Source/WebCore:
Added a function to update the visual viewport API and schedule a resize event to FrameView.
Test: fast/visual-viewport/ios/resize-event-for-keyboard.html
- page/FrameView.cpp:
(WebCore::FrameView::didUpdateViewportOverrideRects):
- page/FrameView.h:
Source/WebKit:
The bug was caused by the changes to unobscuredContentRectRespectingInputViewBounds not updating the visual viewport
unless it caused a layout to happen. Added a code to update the visual viewport in WebPage::updateVisibleContentRects.
Also fixed the bug that VisibleContentRectUpdateInfo::operator== was not checking differences in
unobscuredContentRectRespectingInputViewBounds which resulted in the visual viewport override not getting updated
while the keyboard is getting brought up.
- Shared/VisibleContentRectUpdateInfo.h:
(WebKit::operator==):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
LayoutTests:
Added a regression test.
- fast/visual-viewport/ios/resize-event-for-keyboard-expected.txt: Added.
- fast/visual-viewport/ios/resize-event-for-keyboard.html: Added.
- 7:27 PM Changeset in webkit [240026] by
-
- 3 edits in trunk/Source/WebCore
Fix build after r240018
https://bugs.webkit.org/show_bug.cgi?id=193434
Unreviewed.
- Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp:
(WebCore::WHLSL::checkLoops):
(WebCore::WHLSL::findHighZombies): Deleted.
- Modules/webgpu/WHLSL/WHLSLLoopChecker.h:
- 7:09 PM Changeset in webkit [240025] by
-
- 3 edits in trunk/Tools
Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
https://bugs.webkit.org/show_bug.cgi?id=193451
Reviewed by Geoffrey Garen.
- TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
- 6:17 PM Changeset in webkit [240024] by
-
- 5 edits2 adds in trunk
[JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String)
https://bugs.webkit.org/show_bug.cgi?id=193438
<rdar://problem/45581249>
Reviewed by Saam Barati and Keith Miller.
JSTests:
Under the heavy load (like, compiling WebKit), AI in this code can broaden type information after the 1st run.
Then, GetByVal(String) crashed.
- stress/string-get-by-val-lowering.js: Added.
(shouldBe):
(test):
- stress/type-for-get-by-val-can-be-widen-after-ai.js: Added.
(Hello):
(foo):
Source/JavaScriptCore:
GetByVal(Array::String) emits Check(String) before that. But AI can broaden type constraint in the second run.
After the first run removes Check(String), it would happen that AI starts saying the type of 1st child is not String.
To claim that it *is* a String type, we should use KnownStringUse here.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode): StringCharAt and GetByVal(Array::String) share the underlying compiler code. We should
change StringUse => KnownStringUse for StringCharAt too. And StringCharAt and StringCharCodeAt potentially have the same
problem. This patch fixes it too.
- dfg/DFGSSALoweringPhase.cpp:
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt):
- 5:41 PM Changeset in webkit [240023] by
-
- 46 edits12 deletes in trunk/Source/JavaScriptCore
Try ripping out inferred types because it might be a performance improvement
https://bugs.webkit.org/show_bug.cgi?id=190906
Reviewed by Yusuke Suzuki.
This patch removes inferred types from JSC. Initial evidence shows that
this might be around a ~1% speedup on Speedometer2 and JetStream2.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
- bytecode/Fits.h:
- bytecode/PutByIdFlags.cpp:
(WTF::printInternal):
- bytecode/PutByIdFlags.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::dumpInContext const):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::requiredType const): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::isType const): Deleted.
- dfg/DFGAbstractValue.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
- dfg/DFGDesiredInferredType.h: Removed.
- dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid const):
(JSC::DFG::DesiredWatchpoints::dumpInContext const):
(JSC::DFG::InferredTypeAdaptor::add): Deleted.
- dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::DesiredWatchpoints::isWatched):
(JSC::DFG::InferredTypeAdaptor::hasBeenInvalidated): Deleted.
(JSC::DFG::InferredTypeAdaptor::dumpInContext): Deleted.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::inferredValueForProperty):
(JSC::DFG::Graph::inferredTypeFor): Deleted.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::registerInferredType): Deleted.
(JSC::DFG::Graph::inferredTypeForProperty): Deleted.
- dfg/DFGInferredTypeCheck.cpp: Removed.
- dfg/DFGInferredTypeCheck.h: Removed.
- dfg/DFGNode.h:
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::checkInferredType): Deleted.
- generator/DSL.rb:
- heap/Heap.cpp:
(JSC::Heap::finalizeUnconditionalFinalizers):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::branchIfNotType): Deleted.
- jit/AssemblyHelpers.h:
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/InferredStructure.cpp:
(JSC::InferredStructure::InferredStructure): Deleted.
- runtime/InferredStructure.h:
(): Deleted.
- runtime/InferredStructureWatchpoint.cpp:
(JSC::InferredStructureWatchpoint::fireInternal): Deleted.
- runtime/InferredType.cpp: Removed.
- runtime/InferredType.h: Removed.
- runtime/InferredTypeInlines.h: Removed.
- runtime/InferredTypeTable.cpp: Removed.
- runtime/InferredTypeTable.h: Removed.
- runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectInternal):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyTable):
(JSC::Structure::addNewPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::willStoreValueSlow):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 5:35 PM Changeset in webkit [240022] by
-
- 2 edits in trunk/Tools
webkitpy: Support boolean simctl isAvailable
https://bugs.webkit.org/show_bug.cgi?id=193472
<rdar://problem/47296150>
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._create_runtimes):
(SimulatedDeviceManager._create_device_with_runtime):
- 5:19 PM Changeset in webkit [240021] by
-
- 12 edits in trunk/Source
Add Reveal support in iOSMac
https://bugs.webkit.org/show_bug.cgi?id=193408
<rdar://problem/47300699>
Reviewed by Tim Horton.
Source/WebCore:
iOSMac and Reveal are currently not testable.
Add support for the reveal SPI specifically for iOSMac.
Show the controller when called, and implement the delegate to
correctly re-paint the content with the auto-generated highlight from
the reveal framework.
- Configurations/WebCore.xcconfig:
- editing/cocoa/DictionaryLookup.mm:
(-[WebRevealHighlight initWithHighlightRect:view:]):
(-[WebRevealHighlight setImage:]):
(-[WebRevealHighlight highlightRectsForItem:]):
(-[WebRevealHighlight startHighlightingItem:]):
(-[WebRevealHighlight highlightItem:withProgress:]):
(-[WebRevealHighlight completeHighlightingItem:]):
(-[WebRevealHighlight stopHighlightingItem:]):
(-[WebRevealHighlight highlightRangeChangedForItem:]):
(-[WebRevealHighlight highlighting]):
(-[WebRevealHighlight drawHighlightContentForItem:context:]):
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
- editing/mac/DictionaryLookup.h:
Source/WebCore/PAL:
Add additional needed SPI.
- pal/spi/cocoa/RevealSPI.h:
Source/WebKit:
Add calls to DictionaryLookup from the appropriate places.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didPerformDictionaryLookup):
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
- 5:14 PM Changeset in webkit [240020] by
-
- 24 edits in trunk/Source/WebCore
[WHLSL] Add ending namespace comments to make namespace boundaries more clear
https://bugs.webkit.org/show_bug.cgi?id=193471
Reviewed by Saam Barati.
This patch only adds the comments to the files that are too long to fit on a single screen in my editor.
No new tests because there is no behavior change.
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
- Modules/webgpu/WHLSL/WHLSLLexer.cpp:
- Modules/webgpu/WHLSL/WHLSLLexer.h:
- Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
- Modules/webgpu/WHLSL/WHLSLNameResolver.h:
- Modules/webgpu/WHLSL/WHLSLParser.h:
- Modules/webgpu/WHLSL/WHLSLProgram.h:
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
- Modules/webgpu/WHLSL/WHLSLVisitor.h:
- 4:35 PM Changeset in webkit [240019] by
-
- 3 edits in trunk/Source/WebKit
[SOUP] Remove usage of NetworkProcess::singleton()
https://bugs.webkit.org/show_bug.cgi?id=193444
Patch by Claudio Saavedra <Claudio Saavedra> on 2019-01-15
Reviewed by Michael Catanzaro.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::download):
(WebKit::NetworkDataTaskSoup::didWriteDownload):
(WebKit::NetworkDataTaskSoup::didFinishDownload):
(WebKit::NetworkDataTaskSoup::didFailDownload):
- NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::NetworkSessionSoup):
- 4:27 PM Changeset in webkit [240018] by
-
- 4 edits2 adds in trunk/Source/WebCore
[WHLSL] Implement the loop checker
https://bugs.webkit.org/show_bug.cgi?id=193434
Reviewed by Saam Barati.
This is a translation of https://github.com/gpuweb/WHLSL/blob/master/Source/LoopChecker.mjs into C++.
No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
of test. When enough of the compiler is present, I'll port the reference implementation's test suite.
- Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp: Added.
(WebCore::WHLSL::findHighZombies):
- Modules/webgpu/WHLSL/WHLSLLoopChecker.h: Added.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 4:08 PM Changeset in webkit [240017] by
-
- 2 edits in trunk/Source/WebKit
Fix incorrect ASSERT added in r239840
https://bugs.webkit.org/show_bug.cgi?id=193466
<rdar://problem/47095142>
Reviewed by Youenn Fablet.
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::Source):
- 3:55 PM Changeset in webkit [240016] by
-
- 2 edits in trunk/Source/WebKit
Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=193468
<rdar://problem/38645869>
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
I'm not sure why this got *worse*, but we should null-check RenderView.
It's OK to bail from scaleViewToFitDocumentIfNeeded, we'll re-do it
the next time we paint (which will surely happen if we gain a RenderView).
- 3:48 PM Changeset in webkit [240015] by
-
- 24 edits2 deletes in trunk
Unreviewed, rolling out r239993, r239995, r239997, and
r239999.
Caused assertions under
ViewGestureController::disconnectFromProcess()
Reverted changesets:
"Regression(PSON) View becomes blank after click a cross-site
download link"
https://bugs.webkit.org/show_bug.cgi?id=193361
https://trac.webkit.org/changeset/239993
"Unreviewed iOS build fix after r239993."
https://trac.webkit.org/changeset/239995
"Fix iOS build after r239993"
https://bugs.webkit.org/show_bug.cgi?id=193361
https://trac.webkit.org/changeset/239997
"Unreviewed, revert part of r239997 as it is not needed to fix
the build."
https://trac.webkit.org/changeset/239999
- 3:31 PM Changeset in webkit [240014] by
-
- 78 edits2 adds1 delete in trunk/Source
Stop using CookiesStrategy
https://bugs.webkit.org/show_bug.cgi?id=161106
Reviewed by Don Olmstead and Antti Koivisto.
Source/WebCore:
CookiesStrategy is process-global and makes it difficult to switch NetworkStorageSession from having a process-global map.
Instead, use a CookieJar object in the WebProcess. This has the additional benefit of making it more clear which code
is used in the WebProcess and which code is used in the NetworkProcess.
- Modules/beacon/NavigatorBeacon.cpp:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processBuffer):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeRequest const):
(WebCore::WebSocketHandshake::clientHandshakeCookieRequestHeaderFieldProxy const):
- WebCore.xcodeproj/project.pbxproj:
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
- dom/Document.cpp:
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerGetRawCookies const):
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
- loader/CookieJar.cpp:
(WebCore::CookieJar::shouldIncludeSecureCookies):
(WebCore::CookieJar::sameSiteInfo):
(WebCore::CookieJar::create):
(WebCore::CookieJar::cookies const):
(WebCore::CookieJar::cookieRequestHeaderFieldProxy):
(WebCore::CookieJar::setCookies):
(WebCore::CookieJar::cookiesEnabled const):
(WebCore::CookieJar::cookieRequestHeaderFieldValue const):
(WebCore::CookieJar::getRawCookies const):
(WebCore::CookieJar::deleteCookie):
(WebCore::shouldIncludeSecureCookies): Deleted.
(WebCore::sameSiteInfo): Deleted.
(WebCore::cookies): Deleted.
(WebCore::cookieRequestHeaderFieldProxy): Deleted.
(WebCore::setCookies): Deleted.
(WebCore::cookiesEnabled): Deleted.
(WebCore::cookieRequestHeaderFieldValue): Deleted.
(WebCore::getRawCookies): Deleted.
(WebCore::deleteCookie): Deleted.
- loader/CookieJar.h:
- loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- loader/cache/CachedApplicationManifest.cpp:
(WebCore::CachedApplicationManifest::CachedApplicationManifest):
- loader/cache/CachedApplicationManifest.h:
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
- loader/cache/CachedImage.h:
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
- loader/cache/CachedRawResource.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::varyHeaderValuesMatch):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::cookieJar const):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument):
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::CachedSVGFont):
- loader/cache/CachedSVGFont.h:
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
- loader/cache/CachedScript.h:
- loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::CachedTextTrack):
- loader/cache/CachedTextTrack.h:
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
- loader/cache/CachedXSLStyleSheet.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::addImageToCache):
- loader/cache/MemoryCache.h:
- page/Navigator.cpp:
(WebCore::Navigator::cookieEnabled const):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::cookieJar):
- page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
- page/PageConfiguration.h:
- platform/CookiesStrategy.h: Removed.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::cookiesStrategy): Deleted.
- platform/network/CacheValidation.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::collectVaryingRequestHeaders):
(WebCore::verifyVaryingRequestHeaders):
- platform/network/CacheValidation.h:
- platform/network/CookieRequestHeaderFieldProxy.h:
- platform/network/cf/NetworkStorageSessionCFNetWin.cpp:
- platform/network/cocoa/NetworkStorageSessionCocoa.mm:
- platform/network/curl/ResourceHandleCurl.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
- testing/Internals.cpp:
(WebCore::Internals::getCookies const):
Source/WebKit:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createCookiesStrategy): Deleted.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
- Scripts/webkit/messages.py:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::getCookiesForFrame):
(WebKit::WebAutomationSessionProxy::deleteCookie):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createCookiesStrategy): Deleted.
(WebKit::WebPlatformStrategies::cookiesForDOM): Deleted.
(WebKit::WebPlatformStrategies::setCookiesFromDOM): Deleted.
(WebKit::WebPlatformStrategies::cookiesEnabled): Deleted.
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
(WebKit::WebPlatformStrategies::getRawCookies): Deleted.
(WebKit::WebPlatformStrategies::deleteCookie): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebPage/WebCookieJar.cpp: Added.
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesEnabled const):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):
(WebKit::WebCookieJar::getRawCookies const):
(WebKit::WebCookieJar::deleteCookie):
- WebProcess/WebPage/WebCookieJar.h: Added.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
Source/WebKitLegacy/mac:
- Misc/WebCache.mm:
(+[WebCache addImageToCache:forURL:forFrame:]):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::setCookies):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createCookiesStrategy): Deleted.
(WebPlatformStrategies::cookiesForDOM): Deleted.
(WebPlatformStrategies::setCookiesFromDOM): Deleted.
(WebPlatformStrategies::cookiesEnabled): Deleted.
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
(WebPlatformStrategies::getRawCookies): Deleted.
(WebPlatformStrategies::deleteCookie): Deleted.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKitLegacy/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createBlobRegistry):
(WebPlatformStrategies::createCookiesStrategy): Deleted.
(WebPlatformStrategies::cookiesForDOM): Deleted.
(WebPlatformStrategies::setCookiesFromDOM): Deleted.
(WebPlatformStrategies::cookiesEnabled): Deleted.
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
(WebPlatformStrategies::getRawCookies): Deleted.
(WebPlatformStrategies::deleteCookie): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
- WebView.cpp:
(WebView::initWithFrame):
- 3:13 PM Changeset in webkit [240013] by
-
- 2 edits in trunk/Source/WebKit
Remove reporting for iOS mach lookups confirmed in-use
https://bugs.webkit.org/show_bug.cgi?id=193455
<rdar://problem/47259551>
Reviewed by Brent Fulgham.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:06 PM Changeset in webkit [240012] by
-
- 9 edits in trunk/Source/WebCore
Animations should only trigger layer recomposite when necessary
https://bugs.webkit.org/show_bug.cgi?id=193450
Reviewed by Antoine Quint.
Animations only need to trigger compositing updates when their states change in a way
that affects compositing. RenderLayerCompositor::requiresCompositingForAnimation() checks for
running animations of properties that can be accelerated, so this patch fixes the legacy
animation logic to only set 'shouldRecompositeLayer' in TreeResolver::createAnimatedElementUpdate()
when the running state of such an animation changes.
ImplicitAnimation::animate() and KeyframeAnimation::animate() now return OptionSet<AnimateChange>.
This contains information about whether the running state changed, so CompositeAnimation::animate()
asks about whether the running state of an accelerated property changed, and returns this in
the AnimationUpdate result.
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::isPausedState):
(WebCore::AnimationBase::isRunningState):
(WebCore::AnimationBase::inPausedState const):
(WebCore::AnimationBase::inRunningState const):
(WebCore::AnimationBase::isAnimatingProperty const):
- page/animation/CSSAnimationController.h:
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::animate):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::affectsAcceleratedProperty const):
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::computeStackingContextImpact): Deleted.
- page/animation/KeyframeAnimation.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
- 2:57 PM Changeset in webkit [240011] by
-
- 8 edits in trunk/Source/WebCore
Clean up code related to the updating of Dashboard and touch event regions
https://bugs.webkit.org/show_bug.cgi?id=193460
Reviewed by Zalan Bujtas.
In preparation for layout testing that can count the number of event region
updates, move the code related to updating "annotated" (Dashboard) regions, and
touch event regions into bottleneck functions in Document.
Updating these two kinds of regions is generally similar, but there are some code paths
that eagerly update annotated regions.
No behavior change.
- dom/Document.cpp:
(WebCore::Document::updateAnnotatedRegions): Moved from FrameView.
(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::invalidateScrollbarDependentRegions):
(WebCore::Document::updateZOrderDependentRegions):
- dom/Document.h:
(WebCore::Document::setAnnotatedRegionsDirty):
(WebCore::Document::annotatedRegionsDirty const):
(WebCore::Document::hasAnnotatedRegions const):
- page/FrameView.cpp:
(WebCore::FrameView::didLayout):
(WebCore::FrameView::didPaintContents):
(WebCore::FrameView::updateAnnotatedRegions): Deleted.
- page/FrameView.h:
- rendering/RenderElement.cpp: Drive-by header cleanup.
(WebCore::RenderElement::styleWillChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setHasVerticalScrollbar):
- 2:53 PM Changeset in webkit [240010] by
-
- 21 edits2 copies1 add in trunk
Cannot tab out of WKWebView on macOS
https://bugs.webkit.org/show_bug.cgi?id=161448
<rdar://problem/28100085>
Reviewed by Dean Jackson.
Source/WebCore/PAL:
- pal/spi/mac/NSViewSPI.h:
- pal/spi/mac/NSWindowSPI.h:
Move some SPI declarations in here from WebKitLegacy.
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::takeFocus):
If the UIDelegate doesn't implement takeFocus, provide a simple default
implementation that just uses AppKit's key view loop to move the focus.
- UIProcess/API/APIUIClient.h:
(API::UIClient::takeFocus):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::takeFocus):
Make API::UIClient's takeFocus return a bool indicating whether the
client implements it or not.
- UIProcess/PageClient.h:
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::takeFocus):
Plumb takeFocus to WebViewImpl.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::takeFocus):
Borrow the relevant portion of WebKitLegacy's implementation of takeFocus,
shifting focus to the next/previous key view in the window.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebChromeClient.mm:
- WebView/WebView.mm:
Make use of SPI headers.
Tools:
Add a test that tabbing into and out of WKWebView works correctly.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
(WebKit2_CommandBackForwardTest::SetUp):
(-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
(-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
(-[FocusableView canBecomeKeyView]):
(TEST):
- TestWebKitAPI/mac/OffscreenWindow.h: Added.
- TestWebKitAPI/mac/OffscreenWindow.mm: Added.
(-[OffscreenWindow initWithSize:]):
(-[OffscreenWindow isKeyWindow]):
(-[OffscreenWindow isVisible]):
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::initialize):
(-[ActiveOffscreenWindow isKeyWindow]): Deleted.
(-[ActiveOffscreenWindow isVisible]): Deleted.
Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
- 2:34 PM Changeset in webkit [240009] by
-
- 2 edits in trunk/Source/WebKit
Remove the specific handling of ephemeral sessions from CacheStorage::Engine::from
https://bugs.webkit.org/show_bug.cgi?id=193400
Reviewed by Alex Christensen.
It is no longer needed as we correctly handle ephemeral sessions removal.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::from):
- 2:21 PM Changeset in webkit [240008] by
-
- 1 copy in tags/Safari-607.1.22
Tag Safari-607.1.22.
- 2:19 PM Changeset in webkit [240007] by
-
- 1 delete in tags/Safari-607.1.22
Delete tag Safari-607.1.22.
- 2:17 PM Changeset in webkit [240006] by
-
- 2 edits in trunk/Tools
Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
https://bugs.webkit.org/show_bug.cgi?id=193459
Reviewed by Mark Lam.
- BuildSlaveSupport/build.webkit.org-config/steps.py:
(Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
- 2:13 PM Changeset in webkit [240005] by
-
- 2 edits in trunk/Source/WebCore
Let Xcode have its way with the WebCore project
- WebCore.xcodeproj/project.pbxproj:
- Change the lastKnownFileType for *.gperf and *.idl files from "file" to "text".
- Resort source files into UUID order.
- 2:13 PM Changeset in webkit [240004] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
REGRESSION (r239510): Remove duplicate copy of srtpsession.cc from 'webrtcpcrtc' target in Xcode project
Fixes the following Xcode warning:
warning: Skipping duplicate build file in Compile Sources build phase: Source/ThirdParty/libwebrtc/Source/webrtc/pc/srtpsession.cc (in target 'webrtcpcrtc')
- libwebrtc.xcodeproj/project.pbxproj: Remove duplicate copy of
srtpsession.cc from 'webrtcpcrtc' target.
- 2:10 PM Changeset in webkit [240003] by
-
- 1 copy in tags/Safari-607.1.22
Tag Safari-607.1.22.
- 2:09 PM Changeset in webkit [240002] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 1:47 PM Changeset in webkit [240001] by
-
- 4 edits in trunk/Source/ThirdParty/ANGLE
clang-tidy: Fix unnecessary copy of for loop variables in ANGLE
<https://webkit.org/b/193443>
Reviewed by Alex Christensen.
Fix unwanted copying of loop variables by making them const
references.
- src/compiler/preprocessor/MacroExpander.cpp:
(pp::MacroExpander::ScopedMacroReenabler::~ScopedMacroReenabler):
- Prevents copy and reference churn of std::shared_ptr<Macro> objects.
- src/compiler/translator/Compiler.cpp:
(sh::TCompiler::useAllMembersInUnusedStandardAndSharedBlocks):
- Prevents copy of sh::InterfaceBlock structs.
(sh::TCompiler::initializeOutputVariables):
- Prevents copy of sh::Varying structs.
- src/libANGLE/Program.cpp:
(gl::(anonymous namespace)::IncludeSameArrayElement):
- Prevents copy of std::string objects.
- 1:21 PM Changeset in webkit [240000] by
-
- 3 edits in trunk/Source/WebCore
Correctly handle rotation for local video playback
https://bugs.webkit.org/show_bug.cgi?id=193412
Reviewed by Eric Carlson.
Update AVVideoCaptureSource to compute the size given to settings after rotating the sample.
This ensures computing the size of video elements appropriately.
Also makes sure to notify observers of size change whenever rotation happens as settings() call will provide a different size.
Covered by manual testing as we do not have yet emulation of local capture with rotation.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::setIntrinsicSize):
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::computeSampleRotation):
- 1:16 PM Changeset in webkit [239999] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, revert part of r239997 as it is not needed to fix the build.
- wtf/RefCounter.h:
- 12:34 PM Changeset in webkit [239998] by
-
- 4 edits in branches/safari-607-branch/Source/WebKit
Apply patch. rdar://problem/47260255
- 12:29 PM Changeset in webkit [239997] by
-
- 5 edits in trunk/Source
Fix iOS build after r239993
https://bugs.webkit.org/show_bug.cgi?id=193361
Source/WebKit:
- UIProcess/ProvisionalPageProxy.h:
- UIProcess/SuspendedPageProxy.h:
Source/WTF:
- wtf/RefCounter.h:
- 12:28 PM Changeset in webkit [239996] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Adjust logging policy in WebKit's sandbox
https://bugs.webkit.org/show_bug.cgi?id=193454
<rdar://problem/47256325>
Reviewed by Brent Fulgham.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:04 PM Changeset in webkit [239995] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed iOS build fix after r239993.
- UIProcess/SuspendedPageProxy.h:
- 11:34 AM Changeset in webkit [239994] by
-
- 4 edits in trunk/Source/WebKit
Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent
https://bugs.webkit.org/show_bug.cgi?id=193453
<rdar://problem/47268166>
Reviewed by Brent Fulgham.
- PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 11:01 AM Changeset in webkit [239993] by
-
- 24 edits2 adds in trunk
Regression(PSON) View becomes blank after click a cross-site download link
https://bugs.webkit.org/show_bug.cgi?id=193361
<rdar://problem/47099573>
Reviewed by Geoff Garen.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
When restoring from PageCache, make sure we notify the client that the load was committed
*before* we tell it that the navigation is complete. This would confuse the ProvisionalPageProxy
logic in the UIProcess.
Source/WebKit:
The issue tracked by rdar://problem/47099573 is that a provisional load may get
canceled (or converted into a download) *after* we've decided to process-swap.
In such cases, the view should keep displaying the current site and it should
still be interactive. However, with the previous PSON model, the view (pageProxy)
would have already swapped to the new process and would end up displaying the
initially empty document.
To address the issue, this patch introduces the concept of a provisional load
in the UIProcess, handled by a ProvisionalPageProxy which has its own privisional
process. The WebPageProxy owns the ProvisionalPageProxy but we do not commit the
provisional page until after the load was committed in the new process. This means
that the view / WebPageProxy keeps using the old process and displays the current
content until a load has committed in the provisional page. If no load commits
in the provisional process (e.g. because the load is cancelled or converted into
a download), then we merely destroy the ProvisionalPageProxy and terminate its
process, without impacting the WebPageProxy.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Rename isSwapFromSuspended to isProcessSwap for clarity as we always want to
delay attaching the drawing area in case of a process-swap, no matter what
now that the previous process is kept alive until the provisional load is
committed in the new process.
- Shared/WebPolicyAction.h:
Drop Suspend policy action. At decidePolicyForNavigationAction time, in case of
process-swap, we now tell the previous process to simply ignore the load, while
we create a ProvisionalPageProxy to do the new load in a new process.
Suspension of the previous page in the old process, happens later, when a load
is actually committed in the new process.
- Sources.txt:
Add new ProvisionalPageProxy file.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _killWebContentProcessAndResetState]):
When calling _killWebContentProcessAndResetState on a WKWebView, kill both the current
process and the provisional one, to maintain previous behavior in our API tests.
- UIProcess/PageClient.h:
Tiny build fix.
- UIProcess/ProvisionalPageProxy.cpp: Added.
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::~ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::takeDrawingArea):
(WebKit::ProvisionalPageProxy::cancel):
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::loadDataWithNavigation):
(WebKit::ProvisionalPageProxy::loadRequestWithNavigation):
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
(WebKit::ProvisionalPageProxy::didReceiveMessage):
(WebKit::ProvisionalPageProxy::didReceiveSyncMessage):
- UIProcess/ProvisionalPageProxy.h: Added.
(WebKit::ProvisionalPageProxy::page):
(WebKit::ProvisionalPageProxy::mainFrame const):
(WebKit::ProvisionalPageProxy::process):
(WebKit::ProvisionalPageProxy::processSwapRequestedByClient const):
(WebKit::ProvisionalPageProxy::navigationID const):
Add new ProvisionalPageProxy class to wrap the provisional load in the new process
after a swap. The provisional page is owned by the WebPageProxy and we only commit
the provisional page when the load is committed. Until then, the WebPageProxy keeps
using the old process and displaying the current content.
- UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
(WebKit::SuspendedPageProxy::unsuspend):
(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
Unregister the SuspendedPageProxy as an IPC message receiver a little bit earlier
when we're going to unsuspend it. This avoids conflicting with the ProvisionalPageProxy
which tries to register itself as an IPC message receiver for the same pageID when
a process-swap occurs and we're switching to a suspended page.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isMainFrame const):
WebFrameProxy::isMainFrame() relies on checking that the frame is the WebPageProxy's m_mainFrame.
Now that the WebPageProxy can have a ProvisionalPageProxy, also check if it is the ProvisionalPageProxy's
m_mainFrame to maintain previous behavior.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToWebProcess):
swapToWebProcess() no longer takes care of unsuspending the SuspendedPage because we now call swapToWebProcess()
later, when a load is actually committed in the provisional page / process. swapToWebProcess() now also needs
to initialize some data members such as the drawing area and the main frame as it is transferring them over from
the ProvisionalPageProxy which started the provisional load.
(WebKit::WebPageProxy::finishAttachingToWebProcess):
We no longer need IsSwapFromSuspended parameter as this is called later now, after a load has actually been
committed in the provisional process.
(WebKit::WebPageProxy::initializeWebPage):
- We no longer need IsSwapFromSuspended parameter as this is called later now, after a load has actually been committed in the provisional process.
- Factor some code out to WebPageProxy::setDrawingArea() so that it can be shared with swapToWebProcess().
(WebKit::WebPageProxy::loadRequestWithNavigation):
Only call setPendingAPIRequestURL() in loadRequestWithNavigation() only if ShouldTreatAsContinuingLoad is not
Yes. This avoids hitting some assertions as this was already called during the first API call if needed.
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
In case of process swap, tell the previous process to ignore the load instead of suspending it right away.
Suspension now happens later, only if we end up committing the provisional load in the new process.
Also discard the SuspendedPage if it failed to suspend (we only reuse its process in this case). This used
to happen a bit later but it is clearer if we do this as early as possible I think.
(WebKit::WebPageProxy::commitProvisionalPage):
When the load is committed in the new process, we call WebPageProxy::commitProvisionalPage(). It takes care of:
- Actually swapping the WebPageProxy to the new process by calling processDidTerminate() / swapToWebProcess().
- Suspending the current page.
- Letting the client know the load is comitted
- Destroy the ProvisionalPageProxy.
This work used to happen earlier in continueNavigationInNewProcess().
(WebKit::WebPageProxy::continueNavigationInNewProcess):
Moved some of the logic to commitProvisionalPage(). We now merely start the load in a new ProvisionalPageProxy,
without actually having the WebPageProxy switch to the new process yet.
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateWindow):
Drop some code that is no longer needed, now that the ProvisionalPageProxy takes care of this.
(WebKit::WebPageProxy::didDestroyNavigation):
On process-swap, when telling the previous process to ignore the load and starting the new load in a new
ProvisionalPageProxy, the previous WebPage attempts to destroy the navigation. In this case, we ignore
the call since the navigation is merely taken over by the ProvisionalPageProxy.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
Moved some PSON logic to the ProvisionalPageProxy instead.
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
When didFailProvisionalLoadForFrame() is called for a ProvisionalPageProxy, destroy it.
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForResponse):
Capture the process in the lambda, to make sure we send the policy decision to the same process that
asked for it, so as to not get confused by process swaps.
(WebKit::WebPageProxy::resetState):
Drop some code that is no longer needed.
(WebKit::WebPageProxy::creationParameters):
Move the hasRegisteredServiceWorkers flag initialization from the call site to here now that we have
more than one call site. This was just some bad factoring.
(WebKit::WebPageProxy::PageProcessOverride::PageProcessOverride):
(WebKit::WebPageProxy::PageProcessOverride::~PageProcessOverride):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::temporarilyOverrideProcess):
Add utility class to temporarily override the WebPageProxy's m_process with the provisional one when
the ProvisionalPageProxy interacts with the WebPageProxy.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::hasProvisionalPageWithID const):
(WebKit::WebProcessProxy::updateBackForwardItem):
Before updating a BackForwardListItem, we normally make sure the process has a WebPageProxy with the
item's pageID. We have to tweak the logic because there may now be no WebPageProxy with this pageID
associated with this process yet, because it is still a ProvisionalPageProxy.
(WebKit::WebProcessProxy::canTerminateChildProcess):
Do not terminate the WebProcess if there are ProvisionalPageProxy objects using it.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::addProvisionalPageProxy):
(WebKit::WebProcessProxy::removeProvisionalPageProxy):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::toPolicyAction):
(WebKit::WebFrame::didReceivePolicyDecision):
Stop dealing with WebPolicyAction::Suspend as it no longer exists.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::didReceivePolicyDecision):
(WebKit::WebPage::setIsSuspended):
Suspend the Page when setIsSuspended(true) is called, now that there is no longer a WebPolicyAction::Suspend.
setIsSuspended(true) IPC is sent when we actually commit the provisional page.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
LayoutTests:
Skip test testing the cross-process DOMWindow API as I broke it with this patch.
The feature is far from ready and off by default anyway. I will add support back
in a follow-up.
- platform/wk2/TestExpectations:
- 10:28 AM Changeset in webkit [239992] by
-
- 2 edits in branches/safari-607-branch/Source/WebKit
Revert r239446. rdar://problem/47125351
- 10:27 AM Changeset in webkit [239991] by
-
- 5 edits2 adds in trunk
[LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
https://bugs.webkit.org/show_bug.cgi?id=193448
Reviewed by Antti Koivisto.
Source/WebCore:
Add missing check. We should only resolve auto values.
Test: fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow-expected.txt: Added.
- fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html: Added.
- 10:03 AM Changeset in webkit [239990] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test fix after r239976.
- inspector/model/remote-object-expected.txt:
- 9:46 AM Changeset in webkit [239989] by
-
- 19 edits in trunk/Tools
webkitpy: Implement device type specific expected results (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=192162
Reviewed by Lucas Forschler.
Device type specific expected results covers two related ideas. The first (covered by this change)
is where to search for -expected.* files. The second is which tests to run based on the
TestExpectations.txt file.
After this change, the baseline search path will be determined by the type of device running a
test. Device type will be passed into any function which picks a file based on the baseline search
path.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._update_test_input): Pass device_type to self._port.reference_files(...).
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Print baseline search path for each round of devices.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init): Pass device_type into expected_*(...).
(SingleTestRunner._expected_driver_output): Ditto.
(SingleTestRunner._driver_input): Ditto.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config): Move printing of baseline search path to a separate function.
(Printer.print_baseline_search_path): Moved from Printer.print_config.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_config):
(Testprinter.test_print_baseline_search_path):
- Scripts/webkitpy/port/base.py:
(Port.baseline_search_path): Pass device_type through.
(Port._expected_baselines_for_suffixes): Ditto.
(Port.expected_baselines): Ditto.
(Port.expected_filename): Ditto.
(Port.expected_checksum): Ditto.
(Port.expected_image): Ditto.
(Port.expected_audio): Ditto.
(Port.expected_text): Ditto.
(Port.reference_files): Ditto.
(Port.tests): Ditto.
(Port._expanded_paths): Ditto.
(Port.skipped_layout_tests): Ditto.
(Port.expectations_dict): Ditto.
(Port._port_specific_expectations_files): Ditto.
(Port.expectations_files): Ditto.
(Port.test_search_path): Ditto.
(Port._tests_for_other_platforms): Ditto.
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
(PortTest.test_nonexistant_expectations): Ditto.
(test_ref_tests_platform_directory): Ditto.
- Scripts/webkitpy/port/darwin.py:
(DarwinPort._port_specific_expectations_files): Accept device_type.
- Scripts/webkitpy/port/driver.py:
(DriverProxy):
(DriverProxy.host): Expose _target_host for device_type information.
- Scripts/webkitpy/port/gtk.py:
(GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
- Scripts/webkitpy/port/ios.py:
(IOSPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/mac.py:
(MacPort. default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/port_testcase.py:
(TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/port/watch.py:
(WatchPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/win.py:
(WinPort.test_search_path): Accept, but do not use, device_type.
- Scripts/webkitpy/port/wpe.py:
(WPEPort._port_specific_expectations_files): Ditto.
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
- 9:15 AM Changeset in webkit [239988] by
-
- 8 edits in trunk/Source/WebKit
WebDriver: update Create Window implementation to support newest specification
https://bugs.webkit.org/show_bug.cgi?id=193333
<rdar://problem/45649489>
Reviewed by Carlos Garcia Campos.
Spec link: https://w3c.github.io/webdriver/#create-window
The command as specified returns a value indicating whether the new browsing context
was presented as a new tab or new window. Add a new delegate method to query the current
'presentation' of the browsing context. The presentation can change over time due to
things such as screen orientation, so the value that is returned by the command only
reflects how the browsing context was initially presented to the user.
This is covered by existing WPT and internal tests. More will be added when Selenium
exposes this command in its various bindings.
- UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:
Add new SPI delegate method to query the 'presentation' (tab or window) for an automated WKWebView.
- UIProcess/API/APIAutomationSessionClient.h:
(API::AutomationSessionClient::currentPresentationOfPage):
- UIProcess/Cocoa/AutomationSessionClient.h:
- UIProcess/Cocoa/AutomationSessionClient.mm:
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::toImpl):
(WebKit::AutomationSessionClient::currentPresentationOfPage):
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::toProtocol):
(WebKit::WebAutomationSession::createBrowsingContext):
Add plumbing between ObjC delegate and C++.
- UIProcess/Automation/Automation.json:
Include the initial presentation in the createBrowsingContext command result.
- 8:31 AM Changeset in webkit [239987] by
-
- 5 edits2 adds in trunk
Web Inspector: Audit: provide a way to determine whether a give node has event listeners
https://bugs.webkit.org/show_bug.cgi?id=193226
<rdar://problem/46800005>
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/audit/run-dom.html
- inspector/InspectorAuditDOMObject.idl:
- inspector/InspectorAuditDOMObject.h:
- inspector/InspectorAuditDOMObject.cpp:
(WebCore::InspectorAuditDOMObject::hasEventListeners): Added.
LayoutTests:
- inspector/audit/run-dom.html: Added.
- inspector/audit/run-dom-expected.txt: Added.
- 8:28 AM Changeset in webkit [239986] by
-
- 5 edits2 adds in trunk
Web Inspector: Audit: provide a way to query for all nodes with a given computed Accessibility role
https://bugs.webkit.org/show_bug.cgi?id=193228
<rdar://problem/46787787>
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/audit/run-accessibility.html
- inspector/InspectorAuditAccessibilityObject.idl:
- inspector/InspectorAuditAccessibilityObject.h:
- inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::accessiblityObjectForNode): Added.
(WebCore::InspectorAuditAccessibilityObject::getElementsByComputedRole): Added.
LayoutTests:
- inspector/audit/run-accessibility.html: Added.
- inspector/audit/run-accessibility-expected.txt: Added.
- 8:24 AM Changeset in webkit [239985] by
-
- 10 edits in trunk/Source/WebCore
Simplify isRunningAnimationOnRenderer()
https://bugs.webkit.org/show_bug.cgi?id=193435
Reviewed by Darin Adler.
All callers of CSSAnimationController::isRunningAnimationOnRenderer() pass AnimationBase::Running | AnimationBase::Paused,
so we can remove the parameter and just hardcode this behavior.
This will simplify a later patch that needs to consider state changes between running and not running.
No behavior change.
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::isAnimatingProperty const):
- page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::isRunningAnimationOnRenderer const):
(WebCore::CSSAnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::CSSAnimationControllerPrivate::computeExtentOfAnimation const):
(WebCore::CSSAnimationController::isRunningAnimationOnRenderer const):
(WebCore::CSSAnimationController::isRunningAcceleratedAnimationOnRenderer const):
- page/animation/CSSAnimationController.h:
- page/animation/CSSAnimationControllerPrivate.h:
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::isAnimatingProperty const):
- page/animation/CompositeAnimation.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):
- 7:46 AM Changeset in webkit [239984] by
-
- 6 edits in trunk/Source/WebCore
Remove unused fields from Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=193442
Reviewed by Zalan Bujtas.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h:
(WebCore::Scrollbar::isCustomScrollbar const):
Make virtual so it doesn't need a bit.
(WebCore::Scrollbar::isAlphaLocked const): Deleted.
(WebCore::Scrollbar::setIsAlphaLocked): Deleted.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldScrollbarParticipateInHitTesting):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
- rendering/RenderScrollbar.h:
- 6:48 AM Changeset in webkit [239983] by
-
- 6 edits2 adds in trunk
[LFC] Use the containing block's padding box to position out-of-flow elements.
https://bugs.webkit.org/show_bug.cgi?id=193431
Reviewed by Antti Koivisto.
Source/WebCore:
If the element has 'position: absolute', the containing block is established by the nearest ancestor
with a 'position' of 'absolute', 'relative' or 'fixed', in the following way:
- In the case that the ancestor is an inline element, the containing block is the bounding box around the padding
boxes of the first and the last inline boxes generated for that element. In CSS 2.2, if the inline element is split
across multiple lines, the containing block is undefined.
- Otherwise, the containing block is formed by the padding edge of the ancestor.
This patch covers #2.
Test: fast/block/block-only/out-of-flow-with-containing-block-border-padding.html
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::width const):
(WebCore::Display::Box::height const):
(WebCore::Display::Box::contentBoxTop const):
(WebCore::Display::Box::contentBoxLeft const):
(WebCore::Display::Box::paddingBoxTop const):
(WebCore::Display::Box::paddingBoxLeft const):
(WebCore::Display::Box::paddingBoxBottom const):
(WebCore::Display::Box::paddingBoxRight const):
(WebCore::Display::Box::paddingBoxHeight const):
(WebCore::Display::Box::paddingBoxWidth const):
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/block-only/out-of-flow-with-containing-block-border-padding-expected.txt: Added.
- fast/block/block-only/out-of-flow-with-containing-block-border-padding.html: Added.
- 5:14 AM Changeset in webkit [239982] by
-
- 2 edits in trunk/JSTests
Unreviewed, skip JIT tests if it's not enabled
- stress/bit-op-with-object-returning-int32.js:
- 4:34 AM Changeset in webkit [239981] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed: Fix the -Wformat compiler warnings
- jsc.cpp:
(jscmain):
- 2:14 AM Changeset in webkit [239980] by
-
- 7 edits1 add in trunk
DFGByteCodeParser rules for bitwise operations should consider type of their operands
https://bugs.webkit.org/show_bug.cgi?id=192966
Reviewed by Yusuke Suzuki.
JSTests:
- stress/bit-op-with-object-returning-int32.js: Added.
Source/JavaScriptCore:
This patch is changing the logic how we lower bitwise operations, to
consider only the type of input nodes and fix them during FixupPhase,
if necessary. We are also changing the prediction propagation rules
for ValueBitOp to usegetHeapPrediction().
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberOrAnyIntResult):
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGPredictionPropagationPhase.cpp:
- 1:51 AM Changeset in webkit [239979] by
-
- 4 edits in trunk
Skip a slow test and a flakey test on arm
Unreviewed gardening.
JSTests:
- typeProfiler/getter-richards.js:
this test always times out, it used to be always skipped on arm and
mips, but got accidentally enabled by r237919 now that we have DFG on
arm. Also skipping on mips as we plan to soon enable DFG for it too.
LayoutTests:
- js/script-tests/stack-overflow-regexp.js: flakey on arm.
- 12:30 AM Changeset in webkit [239978] by
-
- 14 edits1 add in trunk/Source/WebCore
Support parsing of additional values for the touch-action property
https://bugs.webkit.org/show_bug.cgi?id=193314
<rdar://problem/47176519>
Reviewed by Dean Jackson.
We add parsing support for the "none", "pan-x", "pan-y" and "pinch-zoom" values of the CSS "touch-action" property.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::touchActionFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator OptionSet<TouchAction> const):
(WebCore::CSSPrimitiveValue::operator TouchAction const): Deleted.
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertTouchAction):
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTouchAction):
- dom/Element.cpp:
(WebCore::Element::allowsDoubleTapGesture const):
- platform/TouchAction.h: Added.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::touchActions const):
(WebCore::RenderStyle::setTouchActions):
(WebCore::RenderStyle::initialTouchActions):
(WebCore::RenderStyle::touchAction const): Deleted.
(WebCore::RenderStyle::setTouchAction): Deleted.
(WebCore::RenderStyle::initialTouchAction): Deleted.
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
- rendering/style/StyleRareNonInheritedData.h:
- 12:27 AM Changeset in webkit [239977] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Generate the DOMDebugger domain for Augmenting Agents (ObjC protocol)
https://bugs.webkit.org/show_bug.cgi?id=193409
<rdar://problem/44349411>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-15
Reviewed by Devin Rousso.
- inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator):
Generate DOMDebugger domain ObjC interfaces.
- 12:25 AM Changeset in webkit [239976] by
-
- 39 edits21 adds in trunk
Web Inspector: Audit: create new IDL type for exposing special functionality in test context
https://bugs.webkit.org/show_bug.cgi?id=193149
<rdar://problem/46801218>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Create a new
AuditAgent(and various subclasses for different inspection targets)
- inspector/protocol/Audit.json: Added.
Add a
runcommand that is a simpler version ofRuntime.evaluate, except that it expects
a function string instead of an arbitrary JavaScript expression.
Addsetupandteardowncommands that create a JavaScript object that will be passed in
to the test as an argument. Keep this object alive so that tests can add to the object and
have later tests use what was added.
- inspector/agents/InspectorAuditAgent.h: Added.
- inspector/agents/InspectorAuditAgent.cpp: Added.
(Inspector::InspectorAuditAgent::InspectorAuditAgent):
(Inspector::InspectorAuditAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAuditAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorAuditAgent::setup):
(Inspector::InspectorAuditAgent::run):
(Inspector::InspectorAuditAgent::teardown):
(Inspector::InspectorAuditAgent::hasActiveAudit):
(Inspector::InspectorAuditAgent::populateAuditObject):
- inspector/agents/JSGlobalObjectAuditAgent.h: Added.
- inspector/agents/JSGlobalObjectAuditAgent.cpp: Added.
(Inspector::JSGlobalObjectAuditAgent::JSGlobalObjectAuditAgent):
(Inspector::JSGlobalObjectAuditAgent::injectedScriptForEval):
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::jsAgentContext): Added.
(Inspector::JSGlobalObjectInspectorController::createLazyAgents): Added.
- inspector/InjectedScript.h:
- inspector/InjectedScript.cpp:
(Inspector::InjectedScript::execute): Added.
(Inspector::InjectedScript::arrayFromVector): Added.
Create a version ofevaluatethat accepts a list of values to be passed in as arguments
to the function that was created by theevalof the givenfunctionString.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype.execute): Added.
(InjectedScript.prototype.evaluate):
(InjectedScript.prototype.evaluateOnCallFrame):
(InjectedScript.prototype._evaluateAndWrap):
(InjectedScript.prototype._wrapAndSaveCall): Added.
(InjectedScript.prototype._wrapCall): Added.
(InjectedScript.prototype._evaluateOn):
Refactor theevalandsaveResultlogic to allow for more flexibility for other callers.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- UnifiedSources-input.xcfilelist:
Source/WebCore:
Tests: inspector/audit/run.html
inspector/audit/setup.html
inspector/audit/teardown.html
Create a new
AuditAgent(and various subclasses for different inspection targets), as well
asInspectorAuditAccessibilityObjectandInspectorAuditDOMObjectobjects that will
be injected into the test function to allow for more advanced testing.
- inspector/InspectorAuditAccessibilityObject.idl: Added.
- inspector/InspectorAuditAccessibilityObject.h: Added.
(WebCore::InspectorAuditAccessibilityObject::create):
- inspector/InspectorAuditAccessibilityObject.cpp: Added.
(WebCore::InspectorAuditAccessibilityObject::InspectorAuditAccessibilityObject):
- inspector/InspectorAuditDOMObject.idl: Added.
- inspector/InspectorAuditDOMObject.h: Added.
(WebCore::InspectorAuditDOMObject::create):
- inspector/InspectorAuditDOMObject.cpp: Added.
(WebCore::InspectorAuditDOMObject::InspectorAuditDOMObject):
- inspector/agents/page/PageAuditAgent.h: Added.
- inspector/agents/page/PageAuditAgent.cpp: Added.
(WebCore::PageAuditAgent::PageAuditAgent):
(WebCore::PageAuditAgent::injectedScriptForEval):
(WebCore::PageAuditAgent::populateAuditObject):
(WebCore::PageAuditAgent::muteConsole):
(WebCore::PageAuditAgent::unmuteConsole):
- inspector/agents/worker/WorkerAuditAgent.h: Added.
- inspector/agents/worker/WorkerAuditAgent.cpp: Added.
(WebCore::WorkerAuditAgent::WorkerAuditAgent):
(WebCore::WorkerAuditAgent::injectedScriptForEval):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::createLazyAgents):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::createLazyAgents):
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- UnifiedSources-input.xcfilelist:
- WebCore.xcodeproj/project.pbxproj:
Source/WebInspectorUI:
Add
AuditAgentgetters and plumbing.
- UserInterface/Protocol/Target.js:
(WI.Target.prototype.get AuditAgent): Added.
- UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.prototype.async run):
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.async start):
- .eslintrc:
LayoutTests:
- inspector/audit/resources/audit-utilities.js:
(TestPage.registerInitializer.InspectorTest.Audit.setupAudit): Added.
(TestPage.registerInitializer.InspectorTest.Audit.teardownAudit): Added.
- inspector/audit/run.html: Added.
- inspector/audit/run-expected.txt: Added.
- inspector/audit/setup.html: Added.
- inspector/audit/setup-expected.txt: Added.
- inspector/audit/teardown.html: Added.
- inspector/audit/teardown-expected.txt: Added.
- inspector/canvas/create-context-2d-expected.txt:
- inspector/canvas/create-context-bitmaprenderer-expected.txt:
- inspector/canvas/create-context-webgl-expected.txt:
- inspector/canvas/create-context-webgl2-expected.txt:
- inspector/canvas/create-context-webmetal-expected.txt:
- inspector/canvas/recording-2d-expected.txt:
- inspector/canvas/recording-webgl-expected.txt:
- inspector/canvas/recording-webgl-snapshots-expected.txt:
- inspector/model/remote-object-expected.txt:
- inspector/model/stack-trace-expected.txt:
Jan 14, 2019:
- 10:01 PM Changeset in webkit [239975] by
-
- 3 edits4 adds in trunk/Source/WebCore
[WHLSL] Implement the Type Checker
https://bugs.webkit.org/show_bug.cgi?id=193080
Reviewed by Dean Jackson.
This is a translation of https://github.com/gpuweb/WHLSL/blob/master/Source/Checker.mjs into C++.
The Checker passes types between nested expressions. An inner expression figures out what type it is, and
passes that information up to an outer expression. This is done via reading/writing into a HashMap,
because all the type information needs to be saved so that the Metal codegen can emit the correct types.
These types can have two forms: A regular type (like "int[]") or a ResolvableType. ResolvableTypes
represent literals, since a literal needs to know its context before it knows what type it should be. So,
if you have a function like "void foo(int x)" and you have a call like "foo(3)", the 3's ResolvableType
gets passed to the CallExpression, which then unifies it with the function's parameter type, thereby
resolving the 3 to be an int.
There are a few examples where multiple expressions will have the same type: "return (foo, 3)." If those
types are regular types, then it's no problem; we can just clone() the type and stick both in the HashMap.
However, if the type is a ResolvableType, an outer expression will only resolve that type once, so the two
ResolvableTypes can't be distinct. The Checker solves this problem by making a reference-counted wrapper
around ResolvableTypes and using that in the HashMap instead.
Once all the ResolvableTypes have been resolved, a second pass runs through the entire HashMap and assigns
the known types to all the expressions. LValues and their associated address spaces are held in a parallel
HashMap, and are assigned to the expression at the same time. The type is an Optional<AddressSpace> because
address spaces are only relevant if the value is an lvalue; if it's nullopt then that means the expression
is an rvalue.
No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
of test. When enough of the compiler is present, I'll port the reference implementation's test suite.
- Modules/webgpu/WHLSL/WHLSLChecker.cpp: Added.
(WebCore::WHLSL::resolveWithOperatorAnderIndexer):
(WebCore::WHLSL::resolveWithOperatorLength):
(WebCore::WHLSL::resolveWithReferenceComparator):
(WebCore::WHLSL::resolveByInstantiation):
(WebCore::WHLSL::checkSemantics):
(WebCore::WHLSL::checkOperatorOverload):
(WebCore::WHLSL::Checker::Checker):
(WebCore::WHLSL::Checker::visit):
(WebCore::WHLSL::Checker::assignTypes):
(WebCore::WHLSL::Checker::checkShaderType):
(WebCore::WHLSL::matchAndCommit):
(WebCore::WHLSL::Checker::recurseAndGetInfo):
(WebCore::WHLSL::Checker::getInfo):
(WebCore::WHLSL::Checker::assignType):
(WebCore::WHLSL::Checker::forwardType):
(WebCore::WHLSL::getUnnamedType):
(WebCore::WHLSL::Checker::finishVisitingPropertyAccess):
(WebCore::WHLSL::Checker::recurseAndWrapBaseType):
(WebCore::WHLSL::Checker::isBoolType):
(WebCore::WHLSL::Checker::recurseAndRequireBoolType):
(WebCore::WHLSL::check):
- Modules/webgpu/WHLSL/WHLSLChecker.h: Added.
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp: Added.
(WebCore::WHLSL::Gatherer::Gatherer):
(WebCore::WHLSL::Gatherer::reset):
(WebCore::WHLSL::Gatherer::takeEntryPointItems):
(WebCore::WHLSL::Gatherer::visit):
(WebCore::WHLSL::gatherEntryPointItems):
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h: Added.
(WebCore::WHLSL::EntryPointItem::EntryPointItem):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 9:15 PM Changeset in webkit [239974] by
-
- 6 edits in trunk/Source
Split headerValueForVary into specialized functions for NetworkProcess and WebProcess/WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=193429
Reviewed by Joseph Pecoraro.
Source/WebCore:
headerValueForVary is a strange function that is causing trouble with my NetworkProcess global state removal project.
It currently accesses the cookie storage to see if there's a match in two different ways currently written as fallbacks.
In the WebProcess or in WebKitLegacy, it uses cookiesStrategy to access cookies via IPC or directly, respectively,
depending on the PlatformStrategies implementation of cookiesStrategy for that process.
In the NetworkProcess, it uses WebCore::NetworkStorageSession to access cookies directly.
Both of these cookie accessing methods use global state in the process, and I must split them to refactor them separately.
This patch does the split by passing in the method of cookie access: a CookiesStrategy& or a NetworkStorageSession&.
Further refactoring will be done in bug 193368 and bug 161106 to build on this and replace the global state with
member variables of the correct containing objects.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::varyHeaderValuesMatch):
- platform/network/CacheValidation.cpp:
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::headerValueForVary):
(WebCore::collectVaryingRequestHeaders):
(WebCore::verifyVaryingRequestHeaders):
- platform/network/CacheValidation.h:
Source/WebKit:
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::makeEntry):
(WebKit::NetworkCache::Cache::makeRedirectEntry):
(WebKit::NetworkCache::Cache::update):
- 8:11 PM Changeset in webkit [239973] by
-
- 2 edits in trunk/Tools
Move a test implementation file that got misplaced in the Xcode project
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 8:03 PM Changeset in webkit [239972] by
-
- 2 edits in trunk/Source/WebKit
Fix a style mistake in PageClientImplMac
- UIProcess/mac/PageClientImplMac.h:
Somehow these methods ended up above the members.
- 7:31 PM Changeset in webkit [239971] by
-
- 2 edits in trunk/Source/WebCore
Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
https://bugs.webkit.org/show_bug.cgi?id=193416
Reviewed by Wenson Hsieh.
The code inside the m_selection.firstRange() clause needs to only run for non-collapsed selections, and
it shows up on Speedometer profiles so optimize to only run this code if we have a selection range.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
- 7:26 PM Changeset in webkit [239970] by
-
- 2 edits in trunk/Source/WTF
Use unorm2_normalize instead of precomposedStringWithCanonicalMapping in userVisibleString
https://bugs.webkit.org/show_bug.cgi?id=192945
Reviewed by Alex Christensen.
Replace use of the nice NSString function precomposedStringWithCanonicalMapping with the ICU
API unorm2_normalize. This is to prep the code for translation to cross-platform C++. Of
course this is much worse than the preexisting code, but this is just a transitional
measure and not the final state of the code. It wouldn't make sense to do this if the code
were to remain Objective C++.
- wtf/cocoa/NSURLExtras.mm:
(WTF::toNormalizationFormC):
(WTF::userVisibleString):
- 7:01 PM Changeset in webkit [239969] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add option to JSC to dump memory footprint on script completion
https://bugs.webkit.org/show_bug.cgi?id=193422
Reviewed by Mark Lam.
Added the --footprint option to dump peak and current memory usage. This uses the same
OS calls added in r2362362.
- jsc.cpp:
(printUsageStatement):
(CommandLine::parseArguments):
(jscmain):
- 6:37 PM Changeset in webkit [239968] by
-
- 2 edits in trunk/JSTests
Skip type-check-hoisting-phase-hoist... with no jit
https://bugs.webkit.org/show_bug.cgi?id=193421
Reviewed by Mark Lam.
It's timing out the 32-bit bots and takes 330 seconds
on my machine when run by itself.
- stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js:
- 6:14 PM Changeset in webkit [239967] by
-
- 5 edits in trunk
Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
https://bugs.webkit.org/show_bug.cgi?id=193411
<rdar://problem/47215929>
Reviewed by Alexey Proskuryakov.
Source/WTF:
- wtf/cocoa/NSURLExtras.mm:
(WTF::allCharactersAllowedByTLDRules):
LayoutTests:
- fast/url/user-visible/cyrillic-NFD-expected.txt:
- fast/url/user-visible/cyrillic-NFD.html:
- 5:51 PM Changeset in webkit [239966] by
-
- 3 edits in trunk/LayoutTests
Restructure http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html to address flakiness
https://bugs.webkit.org/show_bug.cgi?id=191211
<rdar://problem/45818606>
Unreviewed test gardening.
This test is flaky on the MacOS WK2 bot. The patch avoids a page navigation and
redirect which may avoid the code that changed in
https://trac.webkit.org/changeset/237735/webkit and made the test more flaky.
- http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt:
- http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html:
- 5:31 PM Changeset in webkit [239965] by
-
- 12 edits in trunk
Animation and other code is too aggressive about invalidating layer composition
https://bugs.webkit.org/show_bug.cgi?id=193343
Reviewed by Antoine Quint.
Source/WebCore:
We used to have the concept of a "SyntheticStyleChange", which was used to trigger
style updates for animation, and also to get compositing updated.
That morphed into a call to Element::invalidateStyleAndLayerComposition(), which causes
a style update to result in a "RecompositeLayer" diff, which in turn triggers compositing work,
and dirties DOM touch event regions (which can be expensive to update).
However, not all the callers of Element::invalidateStyleAndLayerComposition() need to trigger
compositing, and doing so from animations caused excessive touch event regions on yahoo.com,
which has several visibility:hidden elements with background-position animation.
So fix callers of invalidateStyleAndLayerComposition() which don't care about compositing to instead
call just invalidateStyle().
Also fix KeyframeAnimation::animate to correctly return true when animation state changes—it failed to
do so, because fireAnimationEventsIfNeeded() can run the state machine and change state.
- animation/KeyframeEffect.cpp:
(WebCore::invalidateElement):
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::setNeedsStyleRecalc):
- page/animation/CSSAnimationController.cpp:
(WebCore::CSSAnimationControllerPrivate::updateAnimations):
(WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::CSSAnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::CSSAnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::CSSAnimationController::cancelAnimations):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
- svg/SVGAnimateElementBase.cpp:
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
LayoutTests:
This test was clobbering the 'box' class on the animating element and therefore making it disappear.
- legacy-animation-engine/compositing/animation/animation-compositing.html:
- 5:26 PM Changeset in webkit [239964] by
-
- 4 edits1 add in trunk
[JSC] AI should check the given constant's array type when folding GetByVal into constant
https://bugs.webkit.org/show_bug.cgi?id=193413
<rdar://problem/46092389>
Reviewed by Keith Miller.
JSTests:
This test is super flaky. It causes crash in r238109, but it does not crash with
--useConcurrentJIT=false.
It does not cause any crashes on the latest revision too. Basically, it highly depends on the timing, and
without this patch, the root cause is not fixed yet. If GetLocal is turned into JSConstant in AI,
but GetByVal does not have appropriate ArrayModes, JSC crashes.
- stress/ai-should-perform-array-check-on-get-by-val-constant-folding.js: Added.
(compareArray):
Source/JavaScriptCore:
If GetByVal's DFG::ArrayMode's type is Array::Double, we expect that the result of GetByVal is Double, since we already performed CheckStructure or CheckArray
to ensure this array type. But this assumption on the given value becomes wrong in AI, since CheckStructure may not perform filtering. And the proven AbstractValue
in GetByVal would not be expected one.
We have the graph before performing constant folding.
53:<!0:-> GetLocal(Check:Untyped:@77, JS|MustGen|UseAsOther, Array, arg2(C<Array>/FlushedCell), R:Stack(7), bc#37, ExitValid) predicting Array
54:< 1:-> JSConstant(JS|PureNum|UseAsOther|UseAsInt|ReallyWantsInt, BoolInt32, Int32: 0, bc#37, ExitValid)
93:<!0:-> CheckStructure(Cell:@53, MustGen, [%C7:Array], R:JSCell_structureID, Exits, bc#37, ExitValid)
94:< 1:-> GetButterfly(Check:Cell:@53, Storage|PureInt, R:JSObject_butterfly, Exits, bc#37, ExitValid)
55:<!0:-> GetByVal(Check:KnownCell:@53, Check:Int32:@54, Check:Untyped:@94, Double|MustGen|VarArgs|PureInt, AnyIntAsDouble|NonIntAsdouble, Double+OriginalCopyOnWriteArray+SaneChain+AsIs+Read, R:Butterfly_publicLength,IndexedDoubleProperties, Exits, bc#37, ExitValid) predicting StringIdent|NonIntAsdouble
And 53 is converted to JSConstant in the constant folding. It leads to constant folding attempt in GetByVal.
53:< 1:-> JSConstant(JS|UseAsOther, Array, Weak:Object: 0x117fb4370 with butterfly 0x8000e4050 (Structure %BV:Array), StructureID: 104, bc#37, ExitValid)
54:< 1:-> JSConstant(JS|PureNum|UseAsOther|UseAsInt|ReallyWantsInt, BoolInt32, Int32: 0, bc#37, ExitValid)
93:<!0:-> CheckStructure(Cell:@53, MustGen, [%C7:Array], R:JSCell_structureID, Exits, bc#37, ExitValid)
94:< 1:-> GetButterfly(Check:Cell:@53, Storage|PureInt, R:JSObject_butterfly, Exits, bc#37, ExitValid)
55:<!0:-> GetByVal(Check:KnownCell:@53, Check:Int32:@54, Check:Untyped:@94, Double|MustGen|VarArgs|PureInt, AnyIntAsDouble|NonIntAsdouble, Double+OriginalCopyOnWriteArray+SaneChain+AsIs+Read, R:Butterfly_publicLength,IndexedDoubleProperties, Exits, bc#37, ExitValid) predicting StringIdent|NonIntAsdouble
GetByVal gets constant Array from @53, and attempt to perform constant folding by leverating CoW state: if the given array's butterfly is CoW and we performed CoW array check for this GetByVal, the array would not be changed as long as the check works.
However, CheckStructure for @53 does not filter anything at AI. So, if @53 is CopyOnWrite | Contiguous array (not CopyOnWrite | Double array!), GetByVal will get a JSValue. But it does not meet the requirement of GetByVal since it has Double Array mode, and says it returns Double.
Here, CheckStructure is valid because structure of the constant object would be changed. What we should do is additional CoW & ArrayShape check in GetByVal when folding since this node leverages CoW's interesting feature,
"If CoW array check (CheckStructure etc.) is emitted by GetByVal's DFG::ArrayMode, the content is not changed from the creation!".
This patch adds ArrayShape check in addition to CoW status check in GetByVal.
Unfortunately, this crash is very flaky. In the above case, if @53 stays GetLocal after the constant folding phase, this issue does not occur. We can see this crash in r238109, but it is really hard to reproduce it in the current ToT.
I verified this fix works in r238109 with the attached test.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::fixTypeForRepresentation):
- 4:55 PM Changeset in webkit [239963] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Remove reporting for mach lookups confirmed in-use
https://bugs.webkit.org/show_bug.cgi?id=193415
<rdar://problem/47266542>
Reviewed by Brent Fulgham.
Also, start denying the services which have not been confirmed to be in use.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:49 PM Changeset in webkit [239962] by
-
- 7 edits in tags/Safari-607.1.20.2/Source
Versioning.
- 4:39 PM Changeset in webkit [239961] by
-
- 3 edits1 add in trunk
[BigInt] Literal parsing is crashing when used inside a Object Literal
https://bugs.webkit.org/show_bug.cgi?id=193404
Reviewed by Yusuke Suzuki.
JSTests:
- stress/big-int-literal-inside-literal-object.js: Added.
Source/JavaScriptCore:
Former implementation was relying into token.m_data.radix after the
call ofnext()into Parser.cpp. This is not safe because next
clobbers token.m_data.radix in some cases (e.g is CLOSEBRACE).
Now we get radix value before callingnext()into parser and store
in a local variable.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
- 4:19 PM Changeset in webkit [239960] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: When deleting databases, some open databases might be missed
https://bugs.webkit.org/show_bug.cgi?id=193090
Reviewed by Brady Eidson.
We should close all databases with an open backing store instead of looking at which ones have an open database
connection. This is because a database might be in the process of getting a backing store before its connection
has been created.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
- 4:00 PM Changeset in webkit [239959] by
-
- 19 edits1 copy3 moves35 adds4 deletes in trunk/LayoutTests
Import current Resource-Timing WPTs
https://bugs.webkit.org/show_bug.cgi?id=193302
Patch by Charles Vazac <cvazac@akamai.com> on 2019-01-14
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- web-platform-tests/resource-timing/SyntheticResponse.py:
(main):
- web-platform-tests/resource-timing/buffer-full-add-after-full-event-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-add-after-full-event.html: Added.
- web-platform-tests/resource-timing/buffer-full-add-entries-during-callback-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-add-entries-during-callback-that-drop.html: Added.
- web-platform-tests/resource-timing/buffer-full-add-entries-during-callback.html: Added.
- web-platform-tests/resource-timing/buffer-full-add-then-clear-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-add-then-clear.html: Added.
- web-platform-tests/resource-timing/buffer-full-decrease-buffer-during-callback.html: Added.
- web-platform-tests/resource-timing/buffer-full-increase-buffer-during-callback-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-increase-buffer-during-callback.html: Added.
- web-platform-tests/resource-timing/buffer-full-inspect-buffer-during-callback-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-inspect-buffer-during-callback.html: Added.
- web-platform-tests/resource-timing/buffer-full-set-to-current-buffer-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-set-to-current-buffer.html: Added.
- web-platform-tests/resource-timing/buffer-full-store-and-clear-during-callback-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-store-and-clear-during-callback.html: Added.
- web-platform-tests/resource-timing/buffer-full-then-increased-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-then-increased.html: Added.
- web-platform-tests/resource-timing/buffer-full-when-populate-entries-expected.txt: Added.
- web-platform-tests/resource-timing/buffer-full-when-populate-entries.html: Added.
- web-platform-tests/resource-timing/document-domain-no-impact-loader.sub-expected.txt: Added.
- web-platform-tests/resource-timing/document-domain-no-impact-loader.sub.html: Added.
- web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub-expected.txt: Added.
- web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub.html: Added.
- web-platform-tests/resource-timing/resource-timing-level1.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource-timing.js.
(assertInvariants):
(window.onload):
- web-platform-tests/resource-timing/resource-timing-level1.sub-expected.txt: Added.
- web-platform-tests/resource-timing/resource-timing-level1.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource-timing.html.
- web-platform-tests/resource-timing/resource_connection_reuse.html:
- web-platform-tests/resource-timing/resource_timing.worker.js:
- web-platform-tests/resource-timing/resource_timing_buffer_full_when_populate_entries-expected.txt: Removed.
- web-platform-tests/resource-timing/resource_timing_buffer_full_when_populate_entries.html: Removed.
- web-platform-tests/resource-timing/resource_timing_store_and_clear_during_callback-expected.txt: Removed.
- web-platform-tests/resource-timing/resource_timing_store_and_clear_during_callback.html: Removed.
- web-platform-tests/resource-timing/resources/buffer-full-utilities.js: Added.
(let.appendScript):
(let.waitForNextTask):
(let.waitForEventToFire.return.new.Promise):
(let.waitForEventToFire):
- web-platform-tests/resource-timing/resources/document-domain-no-impact.sub.html: Added.
- web-platform-tests/resource-timing/resources/iframe-setdomain.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/iframe-setdomain.sub.html.
- web-platform-tests/resource-timing/resources/w3c-import.log:
- web-platform-tests/resource-timing/resources/webperftestharness.js:
(wp_test):
(test_namespace):
- web-platform-tests/resource-timing/resources/webperftestharnessextension.js:
(test_resource_entries):
(performance_entrylist_checker): Deleted.
- web-platform-tests/resource-timing/single-entry-per-resource.html:
- web-platform-tests/resource-timing/supported_resource_type.any-expected.txt: Added.
- web-platform-tests/resource-timing/supported_resource_type.any.html: Added.
- web-platform-tests/resource-timing/supported_resource_type.any.js: Added.
(test):
- web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt: Added.
- web-platform-tests/resource-timing/supported_resource_type.any.worker.html: Added.
- web-platform-tests/resource-timing/test_resource_timing.https-expected.txt: Added.
- web-platform-tests/resource-timing/test_resource_timing.https.html: Added.
- web-platform-tests/resource-timing/test_resource_timing.js:
(resource_load):
- web-platform-tests/resource-timing/w3c-import.log:
LayoutTests:
- TestExpectations:
- tests-options.json:
- 3:45 PM Changeset in webkit [239958] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, test fixes after r239852.
- http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
- http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
- http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
- http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
- 3:24 PM Changeset in webkit [239957] by
-
- 9 edits in releases/WebKitGTK/webkit-2.22/Source
Merge r239787 - Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292
<rdar://problem/46485450>
Reviewed by Yusuke Suzuki.
Source/bmalloc:
Previously, when GIGACAGE_ALLOCATION_CAN_FAIL is true, we allow the Gigacage to
be disabled if we fail to allocate memory for it. However, Gigacage::primitiveGigacageDisabled()
still always assumes that the Gigacage is always enabled after ensureGigacage() is
called.
This patch updates Gigacage::primitiveGigacageDisabled() to allow the Gigacage to
already be disabled if GIGACAGE_ALLOCATION_CAN_FAIL is true and wasEnabled() is
false.
In this patch, we also put the wasEnabled flag in the 0th slot of the
g_gigacageBasePtrs buffer to ensure that it is also protected against writes just
like the Gigacage base pointers.
To achieve this, we do the following:
- Added a reservedForFlags field in struct BasePtrs.
- Added a ReservedForFlagsAndNotABasePtr Gigacage::Kind.
- Added assertions to ensure that the BasePtrs::primitive is at the offset matching the offset computed from Gigacage::Primitive. Ditto for BasePtrs::jsValue and Gigacage::JSValue.
- Added assertions to ensure that Gigacage::ReservedForFlagsAndNotABasePtr is not used for fetching a Gigacage base pointer.
- Added RELEASE_BASSERT_NOT_REACHED() to implement such assertions in bmalloc.
No test added because this issue requires Gigacage allocation to fail in order to
manifest. I've tested it manually by modifying the code locally to force an
allocation failure.
- bmalloc/BAssert.h:
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::primitiveGigacageDisabled):
- bmalloc/Gigacage.h:
(Gigacage::wasEnabled):
(Gigacage::setWasEnabled):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::size):
- bmalloc/HeapKind.h:
(bmalloc::heapKind):
Source/JavaScriptCore:
- runtime/VM.h:
(JSC::VM::gigacageAuxiliarySpace):
Source/WTF:
Update the USE_SYSTEM_MALLOC version of Gigacage.h to match the bmalloc version.
- wtf/Gigacage.h:
- 3:24 PM Changeset in webkit [239956] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/bmalloc
Merge r239245 - Gigacage runway should immediately follow the primitive cage
https://bugs.webkit.org/show_bug.cgi?id=192733
Reviewed by Saam Barati.
This patch makes sure that the Gigacage runway is always
immediately after the primitive cage. Since writing outside the
primitive gigacage is likely to be more dangerous than the JSValue
cage. The ordering of the cages is still random however.
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
- 3:22 PM Changeset in webkit [239955] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
https://bugs.webkit.org/show_bug.cgi?id=193384
Reviewed by Joseph Pecoraro.
- UserInterface/Views/EventBreakpointPopover.js:
(WI.EventBreakpointPopover.prototype.show):
- 2:59 PM Changeset in webkit [239954] by
-
- 1 copy in tags/Safari-607.1.20.2
New tag.
- 2:52 PM Changeset in webkit [239953] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Event breakpoints: text field and completion popover fonts should match
https://bugs.webkit.org/show_bug.cgi?id=193249
Reviewed by Matt Baker.
- UserInterface/Views/EventBreakpointPopover.css:
(.popover .event-breakpoint-content > .event-type > input): Added.
(.popover .event-breakpoint-content > .event-type > input::placeholder): Added.
- UserInterface/Views/EventBreakpointPopover.js:
(WI.EventBreakpointPopover.prototype.show):
(WI.EventBreakpointPopover.prototype._showSuggestionsView):
Subtract the <input> border and padding from the bounds position so the <input> text lines
up with theWI.CompletionSuggestionsViewtext.
- UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView):
Drive-by: forcedir=ltrto match thetext-align: left;CSS styling.
- 2:51 PM Changeset in webkit [239952] by
-
- 15 edits in trunk/Source/WebCore
Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides
https://bugs.webkit.org/show_bug.cgi?id=193410
Reviewed by Simon Fraser.
Removed redundant checks for check for alignAttr and hiddenAttr in isPresentationAttribute overrides
in HTMLElement subclasses since HTMLElement::isPresentationAttribute already checks for those attributes.
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::isPresentationAttribute const): Deleted.
- html/HTMLDivElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isPresentationAttribute const): Deleted.
- html/HTMLEmbedElement.h:
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::isPresentationAttribute const):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute const):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isPresentationAttribute const):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPresentationAttribute const):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::isPresentationAttribute const): Deleted.
- html/HTMLParagraphElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::isPresentationAttribute const): Deleted.
- html/HTMLTableCaptionElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isPresentationAttribute const):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::isPresentationAttribute const):
- 2:31 PM Changeset in webkit [239951] by
-
- 13 edits1 add in trunk
[JSC] Do not use asArrayModes() with Structures because it discards TypedArray information
https://bugs.webkit.org/show_bug.cgi?id=193372
Reviewed by Saam Barati.
JSTests:
- stress/typed-array-array-modes-profile.js: Added.
(foo):
Source/JavaScriptCore:
When RegisteredStructureSet is filtered with AbstractValue, we use structure, SpeculationType, and ArrayModes.
However, we use asArrayModes() function with IndexingMode to compute the ArrayModes in AbstractValue. This is
wrong since this discards TypedArray ArrayModes. As a result, if RegisteredStructureSet with TypedArrays is
filtered with ArrayModes of AbstractValue populated from TypedArrays, we filter all the structures out since
AbstractValue's ArrayModes become NonArray, which is wrong with the TypedArrays' ArrayModes. This leads to
incorrect FTL code generation with MultiGetByOffset etc. nodes because,
- AI think that this MultiGetByOffset never succeeds since all the values of RegisteredStructureSet are filtered out by the AbstractValue.
- AI says the state of MultiGetByOffset is invalid since AI think it never succeeds.
- So subsequent code becomes FTL crash code since AI think the execution should do OSR exit.
- Then, FTL emits the code for MultiGetByOffset, and emits crash after that.
- But in reality, the incoming value can match to the one of the RegisteredStructureSet value since (1)'s structures are incorrectly filtered by the incorrect ArrayModes.
- Then, the execution goes on, and falls into the FTL crash.
This patch fixes the incorrect ArrayModes calculation by the following changes
- Rename asArrayModes to asArrayModesIgnoringTypedArrays.
- Fix incorrect asArrayModesIgnoringTypedArrays use in our code. Use arrayModesFromStructure instead.
- Fix OSR exit code which stores incorrect ArrayModes to the profiles.
- bytecode/ArrayProfile.cpp:
(JSC::dumpArrayModes):
(JSC::ArrayProfile::computeUpdatedPrediction):
- bytecode/ArrayProfile.h:
(JSC::asArrayModesIgnoringTypedArrays):
(JSC::arrayModesFromStructure):
(JSC::arrayModesIncludeIgnoringTypedArrays):
(JSC::shouldUseSlowPutArrayStorage):
(JSC::shouldUseFastArrayStorage):
(JSC::shouldUseContiguous):
(JSC::shouldUseDouble):
(JSC::shouldUseInt32):
(JSC::asArrayModes): Deleted.
(JSC::arrayModeFromStructure): Deleted.
(JSC::arrayModesInclude): Deleted.
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::observeTransitions):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::mergeOSREntryValue):
(JSC::DFG::AbstractValue::contains const):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::observeTransition):
(JSC::DFG::AbstractValue::validate const):
(JSC::DFG::AbstractValue::observeIndexingTypeTransition):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::alreadyChecked const):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape const):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::OSRExit::compileExit):
- dfg/DFGRegisteredStructureSet.cpp:
(JSC::DFG::RegisteredStructureSet::filterArrayModes):
(JSC::DFG::RegisteredStructureSet::arrayModesFromStructures const):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/JITInlines.h:
(JSC::JIT::chooseArrayMode):
(JSC::arrayProfileSaw): Deleted.
- runtime/JSType.h:
(JSC::isTypedArrayType):
- 2:23 PM Changeset in webkit [239950] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WTF
Merge r239873 - WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350
Reviewed by Brent Fulgham.
The non COCOA version of WorkQueue::concurrentApply() creates a temporary
String for the threadName and passes the raw pointer of this String to
Thread::create(). After freeing this String, Thread::entryPoint() uses
the raw char pointer to internally initialize the thread.
The fix is to use a single literal string for all the threads' names since
they are created for a thread-pool.
- wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply):
- 2:23 PM Changeset in webkit [239949] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.22
Merge r239642 - Parsed protocol of javascript URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=193155
<rdar://problem/40230982>
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/loader/comment-only-javascript-url.html
Make a special case for URLs beginning with 'javascript:'. We should always
treat these as JS URLs, even if the content contained within the URL
string might match other parts of the URL parsing spec.
- html/URLUtils.h:
(WebCore::URLUtils<T>::protocol const):
LayoutTests:
- fast/loader/comment-only-javascript-url-expected.txt: Added.
- fast/loader/comment-only-javascript-url.html: Added.
- 2:19 PM Changeset in webkit [239948] by
-
- 49 edits in trunk
Unreviewed, rolling out r239901, r239909, r239910, r239912,
r239913, and r239914.
https://bugs.webkit.org/show_bug.cgi?id=193407
These revisions caused an internal failure (Requested by
Truitt on #webkit).
Reverted changesets:
"[Cocoa] Avoid importing directly from subumbrella frameworks"
https://bugs.webkit.org/show_bug.cgi?id=186016
https://trac.webkit.org/changeset/239901
"Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
https://trac.webkit.org/changeset/239909
"Tried to fix the build."
https://trac.webkit.org/changeset/239910
"Fixed iOS builds after r239910."
https://trac.webkit.org/changeset/239912
"More build fixing."
https://trac.webkit.org/changeset/239913
"Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
https://trac.webkit.org/changeset/239914
- 2:16 PM Changeset in webkit [239947] by
-
- 14 edits in trunk
Re-enable ability to build --cloop builds.
https://bugs.webkit.org/show_bug.cgi?id=192955
Source/JavaScriptCore:
<rdar://problem/46882363>
Reviewed by Saam barati and Keith Miller.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Saam barati and Keith Miller.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
<rdar://problem/46882363>
Reviewed by Saam barati and Keith Miller.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
<rdar://problem/46882363>
Reviewed by Saam barati and Keith Miller.
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
<rdar://problem/46882363>
Reviewed by Saam barati and Keith Miller.
- Configurations/FeatureDefines.xcconfig:
Tools:
<rdar://problem/46882363>
Reviewed by Saam barati and Keith Miller.
The --cloop build option was being ignored this whole time since r236381.
This patch makes it possible to build CLoop builds again.
- Scripts/build-jsc:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 2:10 PM Changeset in webkit [239946] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=193403
<rdar://problem/46750743>
Continue fix in r239711 by using WeakPtr in SourceBufferPrivateAVFObjC.
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::setCDMSession):
- 2:02 PM Changeset in webkit [239945] by
-
- 6 edits in trunk/Tools
webkitpy: Expose device_type from host-like objects
https://bugs.webkit.org/show_bug.cgi?id=193406
<rdar://problem/47262305>
Reviewed by Lucas Forschler.
Devices should expose device_type. As a result, all host objects should
provide a device_type property, even if they do not yet define a device_type.
- Scripts/webkitpy/common/system/systemhost.py:
(SystemHost):
(SystemHost.device_type):
- Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost):
(MockSystemHost.device_type):
- Scripts/webkitpy/port/device.py:
(Device):
(Device.device_type):
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._find_exisiting_device_for_request):
(SimulatedDeviceManager._disambiguate_device_type):
(SimulatedDeviceManager._does_fulfill_request):
(SimulatedDeviceManager.device_count_for_type):
(SimulatedDeviceManager.initialize_devices):
- Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_available_devices):
(test_swapping_devices):
- 1:56 PM Changeset in webkit [239944] by
-
- 8 edits in trunk
[WebGPU] Map WebGPUBindGroupLayoutBindings from the BindGroupLayoutDescriptor for error checking and later referencing
https://bugs.webkit.org/show_bug.cgi?id=193405
Reviewed by Dean Jackson.
Source/WebCore:
When creating a WebGPUBindGroupLayout, cache the WebGPUBindGroupLayoutDescriptor's list of BindGroupLayoutBindings
in a HashMap, keyed by binding number, for quick reference during the WebGPUProgrammablePassEncoder::setBindGroups
implementation to follow. Also add error-checking e.g. detecting duplicate binding numbers in the same WebGPUBindGroupLayout
and non-existent binding numbers when creating the WebGPUBindGroup.
No new tests. BindGroups and BindGroupLayouts reflect the (canonical?) strategy of returning empty
objects upon creation failure and reporting errors elswhere. Since error reporting is not yet implemented,
the error checks aren't testable from LayoutTests right now. Expected behavior unchanged and covered by existing tests.
- Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createBindGroup const):
Number of bindings must be consistent between bindings and layout bindings.
BindGroupBindings should only refer to existing BindGroupLayoutBindings.
- platform/graphics/gpu/GPUBindGroup.h:
- platform/graphics/gpu/GPUBindGroupLayout.h:
(WebCore::GPUBindGroupLayout::bindingsMap const): Added. Cache map of BindGroupLayoutBindings.
- platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm: Disallow duplicate binding numbers in BindGroupLayoutBindings.
(WebCore::GPUBindGroupLayout::tryCreate):
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout):
LayoutTests:
Small fixes that do not alter behavior.
- webgpu/bind-groups.html:
- webgpu/pipeline-layouts.html:
- 1:44 PM Changeset in webkit [239943] by
-
- 1 copy in tags/Safari-606.4.5.3.1
Tag Safari-606.4.5.3.1.
- 1:41 PM Changeset in webkit [239942] by
-
- 7 edits in branches/safari-606.4.5.3-branch/Source
Versioning.
- 1:35 PM Changeset in webkit [239941] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r239939. rdar://problem/47255372
webkitpy: Support alternate simctl device list output (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=193362
<rdar://problem/47122965>
Rubber-stamped by Lucas Forschler.
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager.populate_available_devices):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:34 PM Changeset in webkit [239940] by
-
- 9 edits in trunk
Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).
https://bugs.webkit.org/show_bug.cgi?id=193402
<rdar://problem/46012309>
Reviewed by Keith Miller.
JSTests:
- stress/regexp-compile-oom.js:
- Skip this test for !$jitTests because it is tuned for stack usage when the JIT is enabled. As a result, it will fail on cloop builds though there is no bug.
Source/JavaScriptCore:
The CLoop builds via build-jsc were previously completely disabled after our
change to enable ASM LLInt build without the JIT. As a result, JSC tests have
regressed on CLoop builds. The CLoop builds and tests will be re-enabled when
the fix for https://bugs.webkit.org/show_bug.cgi?id=192955 lands. This patch
fixes all the regressions (and some old bugs) so that the CLoop test bots won't
be red when CLoop build gets re-enabled.
In this patch, we do the following:
- Change CLoopStack::grow() to set the new CLoop stack top at the maximum allocated capacity (after discounting the reserved zone) as opposed to setting it only at the level that the client requested.
This fixes a small performance bug that I happened to noticed when I was
debugging a stack issue. It does not affect correctness.
- In LowLevelInterpreter32_64.asm:
- Fix loadConstantOrVariableTag() to use subi for computing the constant index because the VirtualRegister offset and FirstConstantRegisterIndex values it is operating on are both signed ints. This is just to be pedantic. The previous use of subu will still produce a correct value.
- Fix llintOpWithReturn() to use getu (instead of get) for reading OpIsCellWithType::type because it is of type JSType, which is a uint8_t.
- Fix llintOpWithMetadata() to use loadis for loading OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t5] because it is of type PropertyOffset, which is a signed int.
- Fix commonCallOp() to use getu for loading fields argv and argc because they are of type unsigned for OpCall, OpConstruct, and OpTailCall, which are the clients of commonCallOp.
- Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading OpGetFromScope::Metadata::operand because it is of type uintptr_t.
- In LowLevelInterpreter64.asm:
- Fix llintOpWithReturn() to use getu for reading OpIsCellWithType::type because it is of type JSType, which is a uint8_t.
- Fix llintOpWithMetadata() to use loadi for loading OpGetById::Metadata::modeMetadata.protoLoadMode.structure[t2] because it is of type StructureID, which is a uint32_t.
Fix llintOpWithMetadata() to use loadis for loading
OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t2] because it
is of type PropertyOffset, which is a signed int.
- commonOp() should reload the metadataTable for op_catch because unlike for the ASM LLInt, the exception unwinding code is not able to restore "callee saved registers" for the CLoop interpreter because the CLoop uses pseudo-registers (see the CLoopRegister class).
This was the source of many exotic Cloop failures after the bytecode format
change (which introduced the metadataTable callee saved register). Hence,
we fix it by reloading metadataTable's value on re-entry via op_catch for
exception handling. We already take care of restoring it in op_ret.
- Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading OpGetFromScope::Metadata::operand because it is of type uintptr_t.
- In LowLevelInterpreter.asm:
Fix metadata() to use loadi for loading metadataTable offsets because they are
of type unsigned. This was also a source of many exotic CLoop test failures.
- Change CLoopRegister into a class with a uintptr_t as its storage element. Previously, we were using a union to convert between various value types that we would store in this pseudo-register. This method of type conversion is undefined behavior according to the C++ spec. As a result, the C++ compiler may choose to elide some CLoop statements, thereby resulting in some exotic bugs.
We fix this by now always using accessor methods and assignment operators to
ensure that we use bitwise_cast to do the type conversions. Since bitwise_cast
uses a memcpy, this ensures that there's no undefined behavior, and that CLoop
statements won't get elided willy-nilly by the compiler.
Ditto for the CloopDobleRegisters.
Similarly, use bitwise_cast for ints2Double() and double2Ints() utility
functions.
Also use bitwise_cast (instead of reinterpret_cast) for the CLoop CAST macro.
- Fix cloop.rb to use the new CLoopRegister and CLoopDoubleRegister classes.
Add a clLValue accessor for offlineasm operand types to distinguish
LValue use of the operands from RValue uses.
Replace the use of clearHighWord() with simply casting to uint32_t. This is
more efficient for the C++ compiler (and help speed up debug build runs).
Also fix 32-bit arithmetic operations to only set the lower 32-bit value of
the pseudo registers. This fixes some CLoop JSC test failures.
This patch has been manually tested with the JSC tests on the following builds:
64bit X86 ASM LLLint (without JIT), 64bit and 32bit X86 CLoop, and ARMv7 Cloop.
- interpreter/CLoopStack.cpp:
(JSC::CLoopStack::grow):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoopRegister::i const):
(JSC::CLoopRegister::u const):
(JSC::CLoopRegister::i32 const):
(JSC::CLoopRegister::u32 const):
(JSC::CLoopRegister::i8 const):
(JSC::CLoopRegister::u8 const):
(JSC::CLoopRegister::ip const):
(JSC::CLoopRegister::i8p const):
(JSC::CLoopRegister::vp const):
(JSC::CLoopRegister::cvp const):
(JSC::CLoopRegister::callFrame const):
(JSC::CLoopRegister::execState const):
(JSC::CLoopRegister::instruction const):
(JSC::CLoopRegister::vm const):
(JSC::CLoopRegister::cell const):
(JSC::CLoopRegister::protoCallFrame const):
(JSC::CLoopRegister::nativeFunc const):
(JSC::CLoopRegister::i64 const):
(JSC::CLoopRegister::u64 const):
(JSC::CLoopRegister::encodedJSValue const):
(JSC::CLoopRegister::opcode const):
(JSC::CLoopRegister::operator ExecState*):
(JSC::CLoopRegister::operator const Instruction*):
(JSC::CLoopRegister::operator JSCell*):
(JSC::CLoopRegister::operator ProtoCallFrame*):
(JSC::CLoopRegister::operator Register*):
(JSC::CLoopRegister::operator VM*):
(JSC::CLoopRegister::operator=):
(JSC::CLoopRegister::bitsAsDouble const):
(JSC::CLoopRegister::bitsAsInt64 const):
(JSC::CLoopDoubleRegister::operator T const):
(JSC::CLoopDoubleRegister::d const):
(JSC::CLoopDoubleRegister::bitsAsInt64 const):
(JSC::CLoopDoubleRegister::operator=):
(JSC::LLInt::ints2Double):
(JSC::LLInt::double2Ints):
(JSC::LLInt::decodeResult):
(JSC::CLoop::execute):
(JSC::LLInt::Ints2Double): Deleted.
(JSC::LLInt::Double2Ints): Deleted.
(JSC::CLoopRegister::CLoopRegister): Deleted.
(JSC::CLoopRegister::clearHighWord): Deleted.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- 1:32 PM Changeset in webkit [239939] by
-
- 2 edits in trunk/Tools
webkitpy: Support alternate simctl device list output (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=193362
<rdar://problem/47122965>
Rubber-stamped by Lucas Forschler.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.populate_available_devices):
- 1:27 PM Changeset in webkit [239938] by
-
- 2 edits in trunk/Source/WebKit
Remove unused networking entitlement from iOS WebProcess entitlements
https://bugs.webkit.org/show_bug.cgi?id=193267
Patch by Alex Christensen <achristensen@webkit.org> on 2019-01-14
Reviewed by Dean Jackson.
- Configurations/WebContent-iOS.entitlements:
This gave access to VPN stuff. It's not needed any more.
- 1:17 PM Changeset in webkit [239937] by
-
- 1 copy in branches/safari-606.4.5.3-branch
New branch.
- 1:13 PM Changeset in webkit [239936] by
-
- 2 edits in trunk/Source/WebKit
Enable MDNS ICE candidate support by default
https://bugs.webkit.org/show_bug.cgi?id=193358
Reviewed by Geoffrey Garen.
- Shared/WebPreferences.yaml:
- 1:07 PM Changeset in webkit [239935] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover
https://bugs.webkit.org/show_bug.cgi?id=193098
<rdar://problem/47016036>
Reviewed by Devin Rousso.
Hide CompletionSuggestionsView when SpreadsheetTextField moves, e.g. by scrolling or resizing the sidebar.
Update CompletionSuggestionsView position after pressing Up or Down key, because SpreadsheetTextField may
move from wrapping text.
- UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView.prototype.hide):
(WI.CompletionSuggestionsView.prototype.show):
(WI.CompletionSuggestionsView.prototype.showUntilAnchorMoves): Removed.
(WI.CompletionSuggestionsView.prototype.hideWhenElementMoves): Added.
(WI.CompletionSuggestionsView.prototype._stopMoveTimer): Added.
(WI.CompletionSuggestionsView):
- UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype.set suggestionHint):
(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._showSuggestionsView): Added.
(WI.SpreadsheetTextField.prototype._reAttachSuggestionHint):
Drive-by: abstract out repeating code into a private method.
- 1:01 PM Changeset in webkit [239934] by
-
- 3 edits in trunk/Source/WebKit
Expose preference for site-specific quirks on iOS
https://bugs.webkit.org/show_bug.cgi?id=193353
Reviewed by Dean Jackson.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setNeedsSiteSpecificQuirks:]):
(-[WKPreferences _needsSiteSpecificQuirks]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 12:27 PM Changeset in webkit [239933] by
-
- 22 edits3 copies5 adds in trunk/Source/JavaScriptCore
JSC should have a module loader API
https://bugs.webkit.org/show_bug.cgi?id=191121
Reviewed by Michael Saboff.
This patch adds a new delegate to JSContext that is called to fetch
any resolved module. The resolution of a module identifier is computed
as if it were a URL on the web with the caveat that it must be a file URL.
A new class JSScript has also been added that is similar to JSScriptRef.
Right now all JSScripts are copied into memory. In the future we should
mmap the provided file into memory so the OS can evict it to disk under
pressure. Additionally, the API does not make use of the code signing path
nor the bytecode caching path, which we will add in subsequent patches.
Lastly, a couple of new convenience methods have been added. C API
conversion, can now toRef a JSValue with just a vm rather than
requiring an ExecState. Secondly, there is now a call wrapper that
does not require CallData and CallType since many places don't
care about this.
- API/APICast.h:
(toRef):
- API/JSAPIGlobalObject.cpp: Copied from Source/JavaScriptCore/API/JSVirtualMachineInternal.h.
- API/JSAPIGlobalObject.h: Added.
(JSC::JSAPIGlobalObject::create):
(JSC::JSAPIGlobalObject::createStructure):
(JSC::JSAPIGlobalObject::JSAPIGlobalObject):
- API/JSAPIGlobalObject.mm: Added.
(JSC::JSAPIGlobalObject::moduleLoaderResolve):
(JSC::JSAPIGlobalObject::moduleLoaderImportModule):
(JSC::JSAPIGlobalObject::moduleLoaderFetch):
(JSC::JSAPIGlobalObject::moduleLoaderCreateImportMetaProperties):
- API/JSAPIValueWrapper.h:
(JSC::jsAPIValueWrapper): Deleted.
- API/JSContext.h:
- API/JSContext.mm:
(-[JSContext moduleLoaderDelegate]):
(-[JSContext setModuleLoaderDelegate:]):
- API/JSContextInternal.h:
- API/JSContextPrivate.h:
- API/JSContextRef.cpp:
(JSGlobalContextCreateInGroup):
- API/JSScript.h: Added.
- API/JSScript.mm: Added.
(+[JSScript scriptWithSource:inVirtualMachine:]):
(fillBufferWithContentsOfFile):
(+[JSScript scriptFromUTF8File:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
(getJSScriptSourceCode):
- API/JSScriptInternal.h: Copied from Source/JavaScriptCore/API/JSVirtualMachineInternal.h.
- API/JSValueInternal.h:
- API/JSVirtualMachineInternal.h:
- API/tests/testapi.mm:
(+[JSContextFetchDelegate contextWithBlockForFetch:]):
(-[JSContextFetchDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):
(checkModuleCodeRan):
(checkModuleWasRejected):
(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testLoaderRejectsNilScriptURL):
(testLoaderRejectsFailedFetch):
(testImportModuleTwice):
(+[JSContextFileLoaderDelegate newContext]):
(resolvePathToScripts):
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):
(testLoadBasicFile):
(testObjectiveCAPI):
- API/tests/testapiScripts/basic.js: Copied from Source/JavaScriptCore/API/JSVirtualMachineInternal.h.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- SourcesCocoa.txt:
- config.h:
- postprocess-headers.sh:
- runtime/CallData.cpp:
(JSC::call):
- runtime/CallData.h:
- runtime/Completion.cpp:
(JSC::loadAndEvaluateModule):
- runtime/Completion.h:
- runtime/JSCast.h:
(JSC::jsSecureCast):
- runtime/JSGlobalObject.cpp:
(JSC::createProxyProperty):
- 12:17 PM Changeset in webkit [239932] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Settings: group titles should vertically align with the first editor
https://bugs.webkit.org/show_bug.cgi?id=193391
Reviewed by Dean Jackson.
- UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
- 12:09 PM Changeset in webkit [239931] by
-
- 10 edits in trunk
[iOS] Expose SPI to access the current sentence boundary and selection state
https://bugs.webkit.org/show_bug.cgi?id=193398
<rdar://problem/45893108>
Reviewed by Dean Jackson.
Source/WebKit:
Expose SPI on WKWebView for internal clients to grab information about attributes at the current selection; so
far, this only includes whether the selection is a caret or a range, and whether or not the start of the
selection is at the start of a new sentence.
Test: EditorStateTests.ObserveSelectionAttributeChanges
- Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
Add a new bit in EditorState on iOS to compute whether or not the start of the selection is at the start of a
new sentence. This is computed and set when sending post-layout data inWebPageIOS.mm.
- UIProcess/API/Cocoa/WKWebView.mm:
(selectionAttributes):
(-[WKWebView _didChangeEditorState]):
(-[WKWebView _selectionAttributes]):
Make the new SPI property support KVO by invoking
-willChangeValueForKey:and-didChangeValueForKey:
whenever the selection attributes change.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState const):
Tools:
Add an API test to verify that an SPI client can observe changes in the
@"_selectionAttributes"key path on
WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
expected.
- TestWebKitAPI/EditingTestHarness.h:
- TestWebKitAPI/EditingTestHarness.mm:
(-[EditingTestHarness moveBackward]):
(-[EditingTestHarness moveForward]):
(-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
Add a couple of new helper methods on EditingTestHarness.
- TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
(-[SelectionChangeObserver initWithWebView:]):
(-[SelectionChangeObserver webView]):
(-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
(-[SelectionChangeObserver currentSelectionAttributes]):
- 11:21 AM Changeset in webkit [239930] by
-
- 55 edits2 copies1 delete in trunk/Source/WebCore
[WHLSL] Assorted cleanup
https://bugs.webkit.org/show_bug.cgi?id=193389
Reviewed by Dean Jackson.
This is a bunch of non-behavior-changing cleanup.
- The compiler uses UniqueRef all over the place, and UniqueRef has an implicit operator T&. Therefore, we don't need to static_cast<T&> everywhere.
- ConstantExpressionEnumerationMemberReference is the exact same thing as EnumerationMemberLiteral, so this patch deletes the longer-named class in favor of the shorter-named class.
- Because of the header dependency tree, this patch moves EntryPointType into its own file so it can be used by files that FunctionDeclaration depends on. Same thing for AddressSpace.
- EnumTypes have to have non-null base types. The parser will make sure this is always true.
No new tests because there is no behavior change.
- Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h.
- Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
(WebCore::WHLSL::AST::ArrayType::type const):
(WebCore::WHLSL::AST::ArrayType::type):
- Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
(WebCore::WHLSL::AST::AssignmentExpression::left):
(WebCore::WHLSL::AST::AssignmentExpression::right):
- Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableForShaderItemDirection const):
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
(WebCore::WHLSL::AST::ConstantExpression::ConstantExpression):
(WebCore::WHLSL::AST::ConstantExpression::clone const):
(WebCore::WHLSL::AST::ConstantExpression::matches const):
- Modules/webgpu/WHLSL/AST/WHLSLConstantExpressionEnumerationMemberReference.h: Removed.
- Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
(WebCore::WHLSL::AST::DereferenceExpression::pointer):
- Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
(WebCore::WHLSL::AST::DoWhileLoop::body):
(WebCore::WHLSL::AST::DoWhileLoop::conditional):
- Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
(WebCore::WHLSL::AST::EffectfulExpressionStatement::effectfulExpression):
- Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h.
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
(WebCore::WHLSL::AST::EnumerationDefinition::EnumerationDefinition):
(WebCore::WHLSL::AST::EnumerationDefinition::type):
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
(WebCore::WHLSL::AST::EnumerationMemberLiteral::EnumerationMemberLiteral):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::wrap):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::left const):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::right const):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::clone const):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::enumerationDefinition):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::enumerationDefinition const):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::enumerationMember):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::enumerationMember const):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::setEnumerationMember):
- Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
(WebCore::WHLSL::AST::Expression::type):
(WebCore::WHLSL::AST::Expression::setType):
(WebCore::WHLSL::AST::Expression::addressSpace const):
(WebCore::WHLSL::AST::Expression::setAddressSpace):
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp:
(WebCore::WHLSL::AST::FloatLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
(WebCore::WHLSL::AST::FloatLiteralType::preferredType):
- Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
(WebCore::WHLSL::AST::ForLoop::condition):
(WebCore::WHLSL::AST::ForLoop::increment):
(WebCore::WHLSL::AST::ForLoop::body):
- Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
(WebCore::WHLSL::AST::FunctionDeclaration::type const):
(WebCore::WHLSL::AST::FunctionDeclaration::type):
- Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
(WebCore::WHLSL::AST::IfStatement::conditional):
(WebCore::WHLSL::AST::IfStatement::body):
(WebCore::WHLSL::AST::IfStatement::elseBody):
- Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
(WebCore::WHLSL::AST::IndexExpression::indexExpression):
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
(WebCore::WHLSL::AST::IntegerLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
(WebCore::WHLSL::AST::IntegerLiteralType::preferredType):
- Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
(WebCore::WHLSL::AST::LogicalExpression::left):
(WebCore::WHLSL::AST::LogicalExpression::right):
- Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
(WebCore::WHLSL::AST::LogicalNotExpression::operand):
- Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::lValue):
- Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
(WebCore::WHLSL::AST::MakePointerExpression::lValue):
- Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
(WebCore::WHLSL::AST::PropertyAccessExpression::base):
- Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
(WebCore::WHLSL::AST::ReadModifyWriteExpression::lValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::resultExpression):
- Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
(WebCore::WHLSL::AST::ReferenceType::elementType const):
(WebCore::WHLSL::AST::ReferenceType::elementType):
- Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
(WebCore::WHLSL::AST::ResolvableType::resolvedType const):
(WebCore::WHLSL::AST::ResolvableType::resolvedType):
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableForShaderItemDirection const):
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
(WebCore::WHLSL::AST::Return::value):
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableForShaderItemDirection const):
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableForShaderItemDirection const):
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
(WebCore::WHLSL::AST::StructureElement::type):
- Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
(WebCore::WHLSL::AST::SwitchStatement::value):
- Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
(WebCore::WHLSL::AST::TernaryExpression::predicate):
(WebCore::WHLSL::AST::TernaryExpression::bodyExpression):
(WebCore::WHLSL::AST::TernaryExpression::elseExpression):
- Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
(WebCore::WHLSL::AST::TypeDefinition::type):
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::preferredType):
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
(WebCore::WHLSL::AST::VariableDeclaration::type):
(WebCore::WHLSL::AST::VariableDeclaration::initializer):
(WebCore::WHLSL::AST::VariableDeclaration::isAnonymous const):
- Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
(WebCore::WHLSL::AST::WhileLoop::conditional):
(WebCore::WHLSL::AST::WhileLoop::body):
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
(WebCore::WHLSL::checkDuplicateFunctions):
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
(WebCore::WHLSL::commit):
(WebCore::WHLSL::inferTypesForTypeArguments):
(WebCore::WHLSL::inferTypesForCall):
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
(WebCore::WHLSL::NameResolver::visit):
(WebCore::WHLSL::resolveNamesInTypes):
(WebCore::WHLSL::resolveNamesInFunctions):
- Modules/webgpu/WHLSL/WHLSLNameResolver.h:
- Modules/webgpu/WHLSL/WHLSLParser.h:
- Modules/webgpu/WHLSL/WHLSLProgram.h:
(WebCore::WHLSL::Program::append):
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
(WebCore::WHLSL::synthesizeEnumerationFunctions):
- Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:
(WebCore::WHLSL::synthesizeStructureAccessors):
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
(WebCore::WHLSL::Visitor::visit):
- Modules/webgpu/WHLSL/WHLSLVisitor.h:
- WebCore.xcodeproj/project.pbxproj:
- 10:41 AM Changeset in webkit [239929] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix property access on ARM with the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=193393
Reviewed by Yusuke Suzuki.
Code was still using currentInstruction[4] to access the instruction's metadata.
Updated to use metadata.getPutInfo and metadata.resolveType.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
- 10:00 AM Changeset in webkit [239928] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r239878. rdar://problem/47255372
webkitpy: Support alternate simctl device list output
https://bugs.webkit.org/show_bug.cgi?id=193362
<rdar://problem/47122965>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager.populate_available_devices):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:51 AM Changeset in webkit [239927] by
-
- 2 edits in trunk/Source/WebCore
DOMCacheStorage: use-after-move in doSequentialMatch()
https://bugs.webkit.org/show_bug.cgi?id=193396
Reviewed by Youenn Fablet.
Depending on the platform- and compiler-specific calling conventions,
the doSequentialMatch() code can move out the Vector<Ref<DOMCache>>
object into the callback lambda before the DOMCache object at the
specified index is retrieved for the DOMCache::doMatch() invocation.
This problem is now avoided by retrieving reference to the target
DOMCache object in an earlier expression.
- Modules/cache/DOMCacheStorage.cpp:
(WebCore::doSequentialMatch):
- 7:42 AM Changeset in webkit [239926] by
-
- 6 edits2 adds in trunk
[LFC][BFC] Add basic box-sizing support.
https://bugs.webkit.org/show_bug.cgi?id=193392
Reviewed by Antti Koivisto.
Source/WebCore:
No min/max support yet.
Test: fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/block-only/box-sizing-inflow-out-of-flow-simple-expected.txt: Added.
- fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html: Added.
- 7:22 AM Changeset in webkit [239925] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
https://bugs.webkit.org/show_bug.cgi?id=193397
This was necessary but wasn't done.
Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-01-14
Reviewed by Philippe Normand.
No test required as this fixes a regression in all WebRTC tests when built in debug mode.
- platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
- 7:09 AM Changeset in webkit [239924] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed WPE debug build fix after r239921.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorDecrypt): Fix the assert that checks the
size of the mapped buffer containing IV data.
- 4:41 AM Changeset in webkit [239923] by
-
- 67 edits5 adds in trunk/LayoutTests
Unreviewed WPE gardening. Updating baselines for failures that in
majority of cases can be tracked down to the test fonts bump in r239436.
- platform/wpe/animations/lineheight-animation-expected.txt:
- platform/wpe/animations/simultaneous-start-transform-expected.txt:
- platform/wpe/animations/width-using-ems-expected.txt:
- platform/wpe/css1/font_properties/font-expected.txt:
- platform/wpe/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/wpe/fast/css/line-height-determined-by-primary-font-expected.txt:
- platform/wpe/fast/css/rtl-ordering-expected.txt:
- platform/wpe/fast/css/text-overflow-ellipsis-bidi-expected.txt:
- platform/wpe/fast/css/text-overflow-ellipsis-expected.txt:
- platform/wpe/fast/css/text-overflow-ellipsis-strict-expected.txt:
- platform/wpe/fast/css/word-space-extra-expected.txt:
- platform/wpe/fast/dom/34176-expected.txt:
- platform/wpe/fast/dom/52776-expected.txt:
- platform/wpe/fast/inline/inline-box-background-expected.txt:
- platform/wpe/fast/inline/inline-box-background-long-image-expected.txt:
- platform/wpe/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/wpe/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/wpe/fast/inline/inline-content-with-float-and-margin-expected.txt: Added.
- platform/wpe/fast/inline/simple-inline-inflow-positioned-expected.txt: Added.
- platform/wpe/fast/inline/simple-inline-with-out-of-flow-descendant-expected.txt: Added.
- platform/wpe/fast/inline/simple-inline-with-out-of-flow-descendant2-expected.txt: Added.
- platform/wpe/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
- platform/wpe/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/wpe/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- platform/wpe/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/wpe/svg/custom/svg-fonts-fallback-expected.txt:
- platform/wpe/svg/hixie/perf/007-expected.txt:
- platform/wpe/svg/text/bidi-embedded-direction-expected.txt:
- platform/wpe/svg/text/bidi-reorder-value-lists-expected.txt: Added.
- platform/wpe/svg/text/bidi-text-anchor-direction-expected.txt:
- platform/wpe/svg/text/text-tselect-02-f-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/wpe/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- 4:41 AM Changeset in webkit [239922] by
-
- 2 edits in trunk/Tools
[WPE] API test gardening
https://bugs.webkit.org/show_bug.cgi?id=193319
Reviewed by Michael Catanzaro.
- TestWebKitAPI/glib/TestExpectations.json: Remove some now
passing tests.
- 4:31 AM Changeset in webkit [239921] by
-
- 16 edits4 adds in trunk
[GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
https://bugs.webkit.org/show_bug.cgi?id=192977
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Add a utility method on GstMappedBuffer to return a SharedBuffer
view over the mapped data with no copies.
This patch also introduces a new gstreamer port API test
directory, and includes some tests for GstMappedBuffer.
New tests in the API section.
- platform/SharedBuffer.cpp: Add a new overload for
GstMappedBuffer that allows sharing the mapped GStreamer buffers
with zero copies.
(WebCore::SharedBuffer::create):
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::DataSegment::data const):
(WebCore::SharedBuffer::DataSegment::size const):
- platform/SharedBuffer.h:
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcAllocateBuffersAndRenderAudio): Update to new
API.
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::GstMappedBuffer::createSharedBuffer): Return a shared
buffer sharing this mapped buffer. The buffer must be shareable to
use this method.
- platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedBuffer::create): Make GstMappedBuffer RefCounted
(WebCore::GstMappedBuffer::~GstMappedBuffer):
(WebCore::GstMappedBuffer::data):
(WebCore::GstMappedBuffer::data const):
(WebCore::GstMappedBuffer::size const):
(WebCore::GstMappedBuffer::isSharable const): New predicate to
check whether this buffer can be shared (i.e., is not writable)
(WebCore::GstMappedBuffer::GstMappedBuffer):
(WebCore::GstMappedBuffer::operator bool const): Deleted.
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
Update to use new API.
- platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
(WebCore::InitData::InitData): Ditto.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorFindAndSetKey): Ditto.
(webKitMediaClearKeyDecryptorDecrypt): Ditto.
- platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp:
(WebCore::WrappedMockRealtimeAudioSource::render): Ditto.
- platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData): Ditto.
- platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingVideoSourceLibWebRTC::createBlackFrame): Ditto.
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::Fragmentize): Ditto.
Tools:
- TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
- TestWebKitAPI/PlatformWPE.cmake: Ditto.
- TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
(TestWebKitAPI::GStreamerTest::SetUp):
(TestWebKitAPI::GStreamerTest::TearDown):
- TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
- TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
(TestWebKitAPI::TEST_F):
- 2:59 AM Changeset in webkit [239920] by
-
- 2 edits in trunk/Tools
[WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
https://bugs.webkit.org/show_bug.cgi?id=193332
Reviewed by Michael Catanzaro.
- TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
defined as a char16_t, which changed in ICU 59, the
StringTypeAdapter<UnsignedInt, ...> overload catches casts to
unsigned short. This test is relying on the behaviour that
UChar=unsigned short, which doesn't hold across platforms and ICU
library versions. The full fix would be a special syntax for
literal characters so that these ambiguities do not arise. That
work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
(TestWebKitAPI::TEST):
- 2:32 AM Changeset in webkit [239919] by
-
- 3 edits11 adds in trunk
[GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
https://bugs.webkit.org/show_bug.cgi?id=193239
Patch by Karl Leplat <karl.leplat_ext@softathome.com> on 2019-01-14
Reviewed by Žan Doberšek.
Source/WebCore:
Test: compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers): Use enclosed dirty rect values
when invalidating the CoordinatedBackingStore areas.
LayoutTests:
- compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added.
- platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
- platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
- platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
- platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
- platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
- platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
- platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
- platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
- 1:29 AM Changeset in webkit [239918] by
-
- 1 copy in releases/WebKitGTK/webkit-2.23.3
WebKitGTK+ 2.23.3
- 1:28 AM Changeset in webkit [239917] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.3 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers
Source/WebKit:
- gtk/NEWS: Add release notes for 2.23.3.
- 12:24 AM Changeset in webkit [239916] by
-
- 2 edits in trunk/Tools
Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
- Scripts/make-dist:
(Distcheck.configure):
Jan 13, 2019:
- 11:59 PM Changeset in webkit [239915] by
-
- 5 edits in trunk
[FreeType] Support emoji modifiers
https://bugs.webkit.org/show_bug.cgi?id=177040
Reviewed by Myles C. Maxfield.
Source/WebCore:
The problem only happens with emojis having the zero with joiner (U+200D) in the sequence. The sequence is
broken because createAndFillGlyphPage() in Font.cpp overwrites zero with joiner with zero width space (U+200B),
but the emoji font actually supports zero with joiner. This patch moves the control characters override from
createAndFillGlyphPage() to GlyphPage::fill() only for FreeType based ports. This way we can do the override
only for the cases where the code point is not supported by the font.
- platform/graphics/Font.cpp:
(WebCore::overrideControlCharacters): Helper function to override the control characters.
(WebCore::createAndFillGlyphPage): Call overrideControlCharacters() only when not using FreeType.
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill): Use zero width space as fallback when the font doesn't support characters with
Default_Ignorable Unicode property.
LayoutTests:
Mark several emoji tests as passing now.
- platform/gtk/TestExpectations:
- 9:55 PM Changeset in webkit [239914] by
-
- 2 edits in trunk/Source/WebCore/PAL
Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds.
- pal/spi/mac/QuickDrawSPI.h:
- 9:51 PM Changeset in webkit [239913] by
-
- 2 edits in trunk/Source/WebCore
More build fixing.
- editing/cocoa/DictionaryLookup.mm:
- 4:34 PM Changeset in webkit [239912] by
-
- 2 edits in trunk/Source/WebKit
Fixed iOS builds after r239910.
- Platform/spi/ios/PDFKitSPI.h:
- 4:07 PM Changeset in webkit [239911] by
-
- 2 edits in trunk/Source/WebCore
Minor optimization to RenderText::setRenderedText()
https://bugs.webkit.org/show_bug.cgi?id=193388
Reviewed by Ryosuke Niwa.
Avoid the call to applyTextTransform() if TextTransform is None, so that we don't
have to call previousCharacter() and reassign m_text.
Similar optimization in RenderText::textWithoutConvertingBackslashToYenSymbol().
Speedometer profiles show a few samples here, but this isn't going to win any prizes.
- rendering/RenderText.cpp:
(WebCore::RenderText::setRenderedText):
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol const):
- 3:19 PM Changeset in webkit [239910] by
-
- 4 edits in trunk/Source
Tried to fix the build.
Source/WebCore:
- editing/cocoa/DictionaryLookup.mm:
Source/WebKit:
- Platform/spi/ios/PDFKitSPI.h:
- 3:13 PM Changeset in webkit [239909] by
-
- 12 edits in trunk/Source
Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
Patch by Keith Rollin.
Source/WebCore:
- accessibility/mac/AXObjectCacheMac.mm:
Source/WebCore/PAL:
- pal/spi/cocoa/LaunchServicesSPI.h:
- pal/spi/mac/HIServicesSPI.h:
- pal/spi/mac/MetadataSPI.h:
- pal/spi/mac/SpeechSynthesisSPI.h:
Source/WebKit:
- Platform/IPC/mac/ConnectionMac.mm:
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::launchServicesCheckIn):
Source/WebKitLegacy/mac:
- WebView/PDFViewSPI.h:
- 1:45 PM Changeset in webkit [239908] by
-
- 2 edits in trunk/Tools
[ews-build] Update macOS queue configurations
https://bugs.webkit.org/show_bug.cgi?id=193365
<rdar://problem/47221073>
Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
- BuildSlaveSupport/ews-build/config.json:
- 8:39 AM Changeset in webkit [239907] by
-
- 4 edits in trunk
[LFC] Adjust assert for statically positioned fixed elements
https://bugs.webkit.org/show_bug.cgi?id=193385
Reviewed by Antti Koivisto.
Source/WebCore:
While computing the static position and traversing the ancestor chain, we can surely hit a positioned container
(since we need to go all the way up to the initial containing block).
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 8:06 AM Changeset in webkit [239906] by
-
- 2 edits in trunk/Tools
[WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
https://bugs.webkit.org/show_bug.cgi?id=193387
Reviewed by Carlos Garcia Campos.
- MiniBrowser/wpe/main.cpp:
(main):
- 5:15 AM Changeset in webkit [239905] by
-
- 5 edits in trunk
Release assert with <img usemap> in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=193378
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a shadow host that has <img usemap> in the shadow tree is removed from the document, we try
to remove the map from the scope of the host.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
Tree scope changes are relevant, not the connection to the document.
LayoutTests:
- fast/shadow-dom/image-map-tree-scope.html:
Jan 12, 2019:
- 9:54 PM Changeset in webkit [239904] by
-
- 27 edits7 adds in trunk
Have prefers-color-scheme: light always match on macOS versions before Mojave.
https://bugs.webkit.org/show_bug.cgi?id=191655
rdar://problem/46074680
Reviewed by Megan Gardner.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
Source/WebCore:
Tests: css-dark-mode/older-systems/prefers-color-scheme.html
css-dark-mode/older-systems/supported-color-schemes-css.html
css-dark-mode/older-systems/supported-color-schemes.html
Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code.
Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems.
- Configurations/FeatureDefines.xcconfig:
- dom/Document.cpp:
(WebCore::Document::useDarkAppearance const):
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::enable):
- page/Page.cpp:
(WebCore::Page::setUseDarkAppearance):
(WebCore::Page::useDarkAppearance const):
(WebCore::Page::setUseDarkAppearanceOverride):
- platform/mac/LocalDefaultSystemAppearance.h:
(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const):
- platform/mac/LocalDefaultSystemAppearance.mm:
(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):
- platform/mac/ScrollAnimatorMac.mm:
- rendering/RenderThemeMac.mm:
(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
(-[WebListButtonCell drawWithFrame:inView:]):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::systemColor const):
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
Source/WebKit:
- Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::effectiveAppearanceIsDark):
- UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
- WebView/WebView.mm:
(-[WebView _effectiveAppearanceIsDark]):
Source/WTF:
- wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
- TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
LayoutTests:
- css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added.
- css-dark-mode/older-systems/prefers-color-scheme.html: Added.
- css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added.
- css-dark-mode/older-systems/supported-color-schemes-css.html: Added.
- css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added.
- css-dark-mode/older-systems/supported-color-schemes.html: Added.
- platform/mac/TestExpectations:
- 3:52 PM WebKitGTK/2.22.x edited by
- (diff)
- 1:28 PM Changeset in webkit [239903] by
-
- 8 edits in trunk/Source/WebCore
[LFC] Block/InlinFormattingContext should take Block/InlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=193383
Reviewed by Antti Koivisto.
This is just a downcast really.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::formattingState const): Deleted.
- layout/FormattingContext.h:
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::createFormattingContext):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::BlockFormattingContext):
- layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::formattingState const):
(WebCore::Layout::BlockFormattingContext::blockFormattingState const): Deleted.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::createFinalRuns const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
- layout/inlineformatting/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::formattingState const):
(WebCore::Layout::InlineFormattingContext::inlineFormattingState const): Deleted.
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
- 12:56 PM Changeset in webkit [239902] by
-
- 11 edits7 copies7 adds in trunk/Source/WebCore
[WHLSL] Add native function synthesis passes
https://bugs.webkit.org/show_bug.cgi?id=193360
Reviewed by Dean Jackson.
This patch includes all the passes in prepare() that are between the name resolver and the
type checker. It involves a few small pieces:
- CheckDuplicateFunctions which makes sure the same function isn't defined twice
- Intrinsics, which remembers all of the native types so they can be referred to by the rest of the compiler
- RecursiveTypeChecker which makes sure types don't refer to themselves
- SynthesizeArrayOperatorLength which creates operator.length() functions for arrays
- SynthesizeConstructors which creates copy constructors and default constructors for all types
- SynthesizeEnumerationFunctions which provides cast operators between enum types and their base types
- SynthesizeStructureAccessors which provides getters, setters, and anders for each member of a struct
No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
of test. When enough of the compiler is present, I'll port the reference implementation's test suite.
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp: Added.
(WebCore::WHLSL::checkDuplicateFunctions):
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp: Added.
(WebCore::WHLSL::Intrinsics::Intrinsics):
(WebCore::WHLSL::Intrinsics::add):
(WebCore::WHLSL::Intrinsics::addPrimitive):
(WebCore::WHLSL::Intrinsics::addVector):
(WebCore::WHLSL::Intrinsics::addMatrix):
(WebCore::WHLSL::Intrinsics::addFullTexture):
(WebCore::WHLSL::Intrinsics::addDepthTexture):
(WebCore::WHLSL::Intrinsics::addTexture):
- Modules/webgpu/WHLSL/WHLSLIntrinsics.h: Added.
(WebCore::WHLSL::Intrinsics::voidType const):
(WebCore::WHLSL::Intrinsics::boolType const):
(WebCore::WHLSL::Intrinsics::intType const):
(WebCore::WHLSL::Intrinsics::uintType const):
(WebCore::WHLSL::Intrinsics::samplerType const):
(WebCore::WHLSL::Intrinsics::floatType const):
(WebCore::WHLSL::Intrinsics::float3Type const):
(WebCore::WHLSL::Intrinsics::float4Type const):
- Modules/webgpu/WHLSL/WHLSLProgram.h:
(WebCore::WHLSL::Program::append):
(WebCore::WHLSL::Program::intrinsics):
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp: Added.
(WebCore::WHLSL::checkRecursiveTypes):
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp: Added.
(WebCore::WHLSL::FindArrayTypes::takeArrayTypes):
(WebCore::WHLSL::synthesizeArrayOperatorLength):
- Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp: Added.
(WebCore::WHLSL::FindAllTypes::takeUnnamedTypes):
(WebCore::WHLSL::FindAllTypes::takeNamedTypes):
(WebCore::WHLSL::synthesizeConstructors):
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp: Added.
(WebCore::WHLSL::synthesizeEnumerationFunctions):
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp: Added.
(WebCore::WHLSL::synthesizeStructureAccessors):
- Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 12:36 PM Changeset in webkit [239901] by
-
- 39 edits in trunk
[Cocoa] Avoid importing directly from subumbrella frameworks
https://bugs.webkit.org/show_bug.cgi?id=186016
<rdar://problem/40591038>
Reviewed by Sam Weinig.
Source/WebCore:
- Configurations/WebCore.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- editing/mac/DictionaryLookupLegacy.mm: Import Quartz.h instead of a PDFKit header.
- platform/mac/PlatformEventFactoryMac.mm: Import Carbon.h instead of HIToolbox headers.
- platform/text/mac/TextEncodingRegistryMac.mm: Import Carbon.h instead of CarbonCore.h.
Source/WebCore/PAL:
- Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
- pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
- pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.
Source/WebKit:
- Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- UIProcess/Automation/mac/WebAutomationSessionMac.mm: Import Carbon.h instead of an HIToolbox header.
- UIProcess/Cocoa/WebViewImpl.mm: Ditto.
- UIProcess/mac/WKPrintingView.mm: Import Quartz.h instead of a PDFKit header.
- UIProcess/mac/WKTextInputWindowController.mm: Import Carbon.h instead of an HIToolbox header.
- WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h: Import Quartz.h instead of a PDFKit header.
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h: Ditto.
- WebProcess/Plugins/PDF/PDFPlugin.mm: Ditto.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: Ditto.
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: Ditto.
- WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Ditto.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: Ditto.
- WebProcess/WebPage/mac/WebPageMac.mm: Ditto.
Source/WebKitLegacy/mac:
- Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
- Carbon/CarbonWindowAdapter.mm: Ditto.
- Carbon/CarbonWindowFrame.m: Ditto.
- Carbon/HIViewAdapter.h: Ditto.
- Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS_COCOA_TOUCH_NO.
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
- WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
- WebView/WebPDFView.h: Ditto.
Tools:
- DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a LaunchServices header.
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
- TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
- WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a LaunchServices header.
- 8:56 AM Changeset in webkit [239900] by
-
- 12 edits in trunk/Source/WebCore
[LFC] Move formatting context creation from FormattingState to LayoutState
https://bugs.webkit.org/show_bug.cgi?id=193381
Reviewed by Antti Koivisto.
layoutState().createFormattingStateForFormattingRootIfNeeded(root).createFormattingContext(root) is not only mouthful
but also feels unintuitive. Use layoutState().createFormattingContext(root) instead.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::~FormattingContext):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
- layout/FormattingState.h:
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::createFormattingContext):
- layout/LayoutState.h:
(WebCore::Layout::LayoutState::deregisterFormattingContext):
(WebCore::Layout::LayoutState::registerFormattingContext):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):
- layout/blockformatting/BlockFormattingState.cpp:
(WebCore::Layout::BlockFormattingState::createFormattingContext): Deleted.
- layout/blockformatting/BlockFormattingState.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
- layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::createFormattingContext): Deleted.
- layout/inlineformatting/InlineFormattingState.h:
- 7:30 AM Changeset in webkit [239899] by
-
- 6 edits in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] Move estimatedMarginBefore flag from state/display box to BlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=193375
Reviewed by Antti Koivisto.
The estimated marginBefore is a pre-computed, temporary value. We need to keep it around until the final vertical margin value is computed.
Neither BlockFormattingState nor Display should hold temporary values.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const):
(WebCore::Layout::BlockFormattingContext::hasPrecomputedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::setEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::hasEstimatedMarginBefore const):
(WebCore::Layout::hasPrecomputedMarginBefore): Deleted.
- layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::removeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::estimatedMarginBefore const):
- layout/blockformatting/BlockFormattingState.h:
(WebCore::Layout::BlockFormattingState::setHasEstimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingState::clearHasEstimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingState::hasEstimatedMarginBefore const): Deleted.
- layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::Box):
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::setHasEstimatedMarginBefore):
(WebCore::Display::Box::invalidateEstimatedMarginBefore):
(WebCore::Display::Box::top const):
(WebCore::Display::Box::topLeft const):
(WebCore::Display::Box::setEstimatedMarginBefore): Deleted.
(WebCore::Display::Box::estimatedMarginBefore const): Deleted.
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
- 1:49 AM Changeset in webkit [239898] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, fix scope check assertions
https://bugs.webkit.org/show_bug.cgi?id=193308
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::notifyLexicalBindingShadowing):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::notifyLexicalBindingShadowing):
- runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
Jan 11, 2019:
- 11:42 PM Changeset in webkit [239897] by
-
- 4 edits in trunk/Source
Enable visual viewport API by default
https://bugs.webkit.org/show_bug.cgi?id=193376
Reviewed by Simon Fraser.
Source/WebKit:
Enable this feature by default since the remaining issue on iOS is mostly about test failures,
not an issue with the core functionality of the API.
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- 10:26 PM Changeset in webkit [239896] by
-
- 12 edits5 copies4 adds in trunk/Source/WebCore
[WHLSL] Implement the NameResolver
https://bugs.webkit.org/show_bug.cgi?id=193007
Reviewed by Dean Jackson.
This is the base implementation for WHLSL's name resolver. The name resolver matches three kinds of things:
- It matches VariableRefs to VariableDecls
- It matches TypeRefs to NamedTypes
- It matches CallExpressions to FunctionDeclarations
No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
of test. When enough of the compiler is present, I'll port the reference implementation's test suite.
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp: Now that InferTypes.h exists, we can implement these
functions.
(WebCore::WHLSL::AST::FloatLiteralType::canResolve const):
(WebCore::WHLSL::AST::FloatLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h: Remove unnecessary function.
(WebCore::WHLSL::AST::FloatLiteralType::value const): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp: Now that InferTypes.h exists, we can implement these
functions.
(WebCore::WHLSL::AST::IntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::IntegerLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h: Remove unnecessary function.
(WebCore::WHLSL::AST::IntegerLiteralType::value const): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp: Modifying Sources.txt caused the sources
to get shuffled around, so the #includes need to be fixed.
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp: Now that InferTypes.h exists, we can implement
these functions.
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::conversionCost const):
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h: Remove unnecessary function.
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::value const): Deleted.
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp: Added. This is the replacement for UnificationContext in the
reference compiler. It's much simpler (and we should remove UnificationContext in the reference compiler in
favor of this design). It has three sets of functions: Tell if two types are the same, tell if two types are
the same and commit the resolvable type, and run the above functions on type references or function arguments.
(WebCore::WHLSL::matches):
(WebCore::WHLSL::matchAndCommit):
(WebCore::WHLSL::commit):
(WebCore::WHLSL::inferTypesForTypeArguments):
(WebCore::WHLSL::inferTypesForCall):
- Modules/webgpu/WHLSL/WHLSLInferTypes.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp.
- Modules/webgpu/WHLSL/WHLSLNameContext.cpp: Added. This is the data structure that remembers NamedTypes,
FunctionDeclarations, and VariableDeclarations so NameResolver can work.
(WebCore::WHLSL::NameContext::NameContext):
(WebCore::WHLSL::NameContext::add):
(WebCore::WHLSL::NameContext::getTypes):
(WebCore::WHLSL::NameContext::getFunctions):
(WebCore::WHLSL::NameContext::getVariable):
(WebCore::WHLSL::NameContext::exists):
- Modules/webgpu/WHLSL/WHLSLNameContext.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h.
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp: Added. Use the NameContext to match up the three types of names.
(WebCore::WHLSL::NameResolver::NameResolver):
(WebCore::WHLSL::NameResolver::visit):
(WebCore::WHLSL::resolveNamesInTypes):
(WebCore::WHLSL::resolveNamesInFunctions):
- Modules/webgpu/WHLSL/WHLSLNameResolver.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h.
(WebCore::WHLSL::NameResolver::setCurrentFunctionDefinition):
- Modules/webgpu/WHLSL/WHLSLProgram.h:
(WebCore::WHLSL::Program::append): The parser needs to add all global declarations to the name context so the
name resolver is ready to go as soon as parsing is finished.
(WebCore::WHLSL::Program::nameContext):
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp: Added. Pick the appropriate FunctionDeclaration or
NamedType for a particular CallExpression or TypeReference.
(WebCore::WHLSL::conversionCost):
(WebCore::WHLSL::resolveFunctionOverloadImpl):
(WebCore::WHLSL::resolveTypeOverloadImpl):
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp.
- Modules/webgpu/WHLSL/WHLSLResolvingType.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp. This describes the two states that a type in the type resolver can be in: either an owned
UnnamedType, or a reference to a ResolvableType. This is because every expression needs to have a type
associated with it, but those types might be the type of a literal (aka a ResolvableType). Multiple
expressions might need to reference the same ResolvableType so when it gets resolved, all the expressions
get the result.
(WebCore::WHLSL::ResolvableTypeReference::ResolvableTypeReference):
(WebCore::WHLSL::ResolvableTypeReference::resolvableType):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 7:40 PM Changeset in webkit [239895] by
-
- 2 edits in trunk/Source/WebKit
Allow WebContent process access to some drawing-related IOKit properties
https://bugs.webkit.org/show_bug.cgi?id=193086
<rdar://problem/46568088>
Reviewed by Eric Carlson.
Add one missing IOKit property, and revise the regexp used for another.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 7:07 PM Changeset in webkit [239894] by
-
- 2 edits in trunk/Source/WTF
Follow-up: WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350
- wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply): Fix whitespace.
- 6:46 PM Changeset in webkit [239893] by
-
- 3 edits2 adds in trunk/Source/WebCore
[WHLSL] Add a Visitor class
https://bugs.webkit.org/show_bug.cgi?id=192826
Reviewed by Dean Jackson.
This patch exposes a bunch of the private members of WHLSL's AST nodes so that Visitor can recurse on constituent nodes.
It also writes the recursion in Visitor.h. This is a virtual base class that gets subclassed for compiler passes.
I've split this part into its own patch to aid reviewing of the compiler.
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp: Added.
(WebCore::WHLSL::Visitor::visit):
(WebCore::WHLSL::Visitor::checkErrorAndVisit):
- Modules/webgpu/WHLSL/WHLSLVisitor.h: Added.
(WebCore::WHLSL::Visitor::setError):
(WebCore::WHLSL::Visitor::error const):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 5:50 PM Changeset in webkit [239892] by
-
- 10 edits1 add in tags/Safari-607.1.20.1/Source
Cherry-pick r239792. rdar://problem/46627875
Expand use of sourceApplicationAuditData
https://bugs.webkit.org/show_bug.cgi?id=192995
<rdar://problem/46627875>
Reviewed by Brady Eidson.
Source/WebKit:
sourceApplicationAuditData has been used for a long time on iOS, but it's needed on more platforms.
I also made it return an Optional instead of a bool and returning by reference. Ahhh. So much nicer.
The NetworkProcess needed an additional entitlement on Mac to continue to load anything, which is desirable.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::sourceApplicationAuditData const):
- Platform/IPC/Connection.h:
- Platform/IPC/mac/ConnectionMac.mm: (IPC::Connection::getAuditToken):
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::sourceApplicationAuditData const):
Source/WTF:
- wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:49 PM Changeset in webkit [239891] by
-
- 7 edits in tags/Safari-607.1.20.1/Source
Versioning.
- 5:25 PM Changeset in webkit [239890] by
-
- 1 copy in tags/Safari-607.1.20.1
New tag.
- 5:22 PM Changeset in webkit [239889] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r239419): Crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC()
https://bugs.webkit.org/show_bug.cgi?id=193342
<rdar://problem/47119836>
Reviewed by Eric Carlson.
Make the TapStorage used by AudioSourceProviderAVFObjC thread-safe RefCounted.
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::initCallback):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
- 5:13 PM Changeset in webkit [239888] by
-
- 19 edits in trunk
Compile out Web API Statistics Collection
https://bugs.webkit.org/show_bug.cgi?id=193370
<rdar://problem/45388584>
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Defined ENABLE_WEB_API_STATISTICS, off by default.
Source/WebCore:
No new tests. This patch disables functionality. The associated tests
are skipped.
These functions are now no-ops unless web API statistics is enabled.
- Configurations/FeatureDefines.xcconfig:
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logFontLoad):
(WebCore::ResourceLoadObserver::logCanvasRead):
(WebCore::ResourceLoadObserver::logCanvasWriteOrMeasure):
(WebCore::ResourceLoadObserver::logNavigatorAPIAccessed):
(WebCore::ResourceLoadObserver::logScreenAPIAccessed):
- loader/ResourceLoadStatistics.cpp:
(WebCore::ResourceLoadStatistics::encode const):
(WebCore::ResourceLoadStatistics::decode):
(WebCore::ResourceLoadStatistics::toString const):
(WebCore::ResourceLoadStatistics::merge):
- loader/ResourceLoadStatistics.h:
The associated struct members are skipped unless web API
statistics is enabled.
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Defined ENABLE_WEB_API_STATISTICS, off by default.
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Defined ENABLE_WEB_API_STATISTICS, off by default.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceLoadStatistics>::encode):
Skipped encoding of web API statistics.
(IPC::ArgumentCoder<ResourceLoadStatistics>::decode):
Skipped decoding of web API statistics.
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Defined ENABLE_WEB_API_STATISTICS, off by default.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Defined ENABLE_WEB_API_STATISTICS, off by default.
LayoutTests:
- platform/ios-wk2/TestExpectations:
http/tests/webAPIStatistics skipped.
- platform/mac-wk2/TestExpectations:
http/tests/webAPIStatistics skipped.
- 5:11 PM Changeset in webkit [239887] by
-
- 8 edits in trunk/Source
IndexedDB: leak WebIDBConnectionToClient for retain cycle
https://bugs.webkit.org/show_bug.cgi?id=193097
<rdar://problem/46899601>
Reviewed by Brady Eidson.
Source/WebCore:
Let IDBConnectionToClient hold a WeakPtr of IDBConnectionToClientDelegate.
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::IDBConnectionToClient):
(WebCore::IDBServer::IDBConnectionToClient::identifier const):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteDatabase):
(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):
(WebCore::IDBServer::IDBConnectionToClient::didAbortTransaction):
(WebCore::IDBServer::IDBConnectionToClient::didCreateObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didRenameObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didClearObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didCreateIndex):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteIndex):
(WebCore::IDBServer::IDBConnectionToClient::didRenameIndex):
(WebCore::IDBServer::IDBConnectionToClient::didPutOrAdd):
(WebCore::IDBServer::IDBConnectionToClient::didGetRecord):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllRecords):
(WebCore::IDBServer::IDBConnectionToClient::didGetCount):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteRecord):
(WebCore::IDBServer::IDBConnectionToClient::didOpenCursor):
(WebCore::IDBServer::IDBConnectionToClient::didIterateCursor):
(WebCore::IDBServer::IDBConnectionToClient::didCommitTransaction):
(WebCore::IDBServer::IDBConnectionToClient::fireVersionChangeEvent):
(WebCore::IDBServer::IDBConnectionToClient::didStartTransaction):
(WebCore::IDBServer::IDBConnectionToClient::didCloseFromServer):
(WebCore::IDBServer::IDBConnectionToClient::notifyOpenDBRequestBlocked):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNames):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
Source/WebKit:
Let WebIDBConnectionToClient hold reference to IPC::Connection instead of NetworkConnectionToWebProcess to break
the cycle.
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::messageSenderConnection):
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):
- 5:02 PM Changeset in webkit [239886] by
-
- 3 edits in trunk/Tools
[WPE] Add gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=178900
Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2019-01-11
Reviewed by Michael Catanzaro.
Add Tools/gtkdoc to manifest.txt.in files.
This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
- gtk/manifest.txt.in: Add Tools/gtkdoc directory.
- wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
- 5:00 PM Changeset in webkit [239885] by
-
- 2 edits in trunk/Source/WebKit
Make "Disable Web SQL" on by default
https://bugs.webkit.org/show_bug.cgi?id=193354
<rdar://problem/46524584>
Reviewed by Geoffrey Garen.
- Shared/WebPreferences.yaml:
- 4:40 PM Changeset in webkit [239884] by
-
- 6 edits in trunk/Source
Fix style CFNetworkSPI style checker warnings from r239698
https://bugs.webkit.org/show_bug.cgi?id=193369
Reviewed by Joseph Pecoraro.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):
Source/WTF:
- wtf/Platform.h:
- 4:39 PM Changeset in webkit [239883] by
-
- 5 edits in trunk/Source/WebCore
Fix the build after r239844
https://bugs.webkit.org/show_bug.cgi?id=192991
Unreviewed.
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:
- 4:26 PM Changeset in webkit [239882] by
-
- 5 edits1 add in trunk
DFG combined liveness can be wrong for terminal basic blocks
https://bugs.webkit.org/show_bug.cgi?id=193304
<rdar://problem/45268632>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/dfg-combined-liveness-consider-terminal-blocks-bytecode-liveness.js: Added.
Source/JavaScriptCore:
If a block doesn't have any successors, it can't rely on the typical
backwards liveness propagation that CombinedLiveness was doing. The phase
first got what was live in bytecode and IR at the heads of each block. Then
for each block, it made the live at tail the union of the live at head for
each successor. For a terminal block though, this could be wrong. We could
end up saying nothing is live even though many things may be live in bytecode.
We must account for what's bytecode live at the end of the block. Consider a
block that ends with:
`
ForceOSRExit
Unreachable
`
Things may definitely be live in bytecode at the tail. However, we'll
report nothing as being alive. This probably subtly breaks many analyses,
but we have a test case of it breaking the interference analysis that
the ArgumentsEliminationPhase performs.
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::last const):
- dfg/DFGCombinedLiveness.cpp:
(JSC::DFG::addBytecodeLiveness):
(JSC::DFG::liveNodesAtHead):
(JSC::DFG::CombinedLiveness::CombinedLiveness):
- dfg/DFGCombinedLiveness.h:
- 4:21 PM Changeset in webkit [239881] by
-
- 11 edits in trunk
[iOS] Precision drop state thrashes when dragging near the top edge of an editable element
https://bugs.webkit.org/show_bug.cgi?id=193364
<rdar://problem/47214117>
Reviewed by Tim Horton.
Source/WebCore:
Add a new helper method on DragCaretController to compute the bounds of the editable element around the drop
caret position. This is either the enclosing form control (in the case of text fields and text areas), or the
highest editable root. See WebKit ChangeLog for more details.
Test: DragAndDropTests.AvoidPreciseDropNearTopOfTextArea
- editing/FrameSelection.cpp:
(WebCore::DragCaretController::editableElementRectInRootViewCoordinates const):
- editing/FrameSelection.h:
Source/WebKit:
On iOS, marking a UIDropProposal as precise offsets the hit-testing location of the drop by a small distance
either upwards or downwards from the actual location of the user's finger. When dragging over an editable
element, WebKit currently marks the drop proposal as precise; however, when dragging over the top edge of an
editable element, what happens is that the hit-testing location is offset to a location outside of the editable
element, which causes us to turn off precision drop mode; subsequently, turning off precision drop mode removes
the offset, which causes us to hit-test within the editable element once again and re-enable precision mode, and
the cycle continues.
In order to mitigate this, bail out of precision drop mode when dragging near the top or bottom edges of the
highest editable root that contains the current drop caret position (or, if the drop caret is inside of a text
form control, use the form control as the editable element instead).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didPerformDragControllerAction):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::currentDragCaretEditableElementRect const):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidUpdate:]):
Avoid precise mode when we're less than 25pt away from the top and bottom edge of the editable element rect.
Since the drag location offset amount is a fixed offset in window coordinates, we first convert this minimum
distance to the content view's coordinate space by dividing by the content scale factor.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
Tools:
Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
precise, whereas dragging near the middle of the textarea does.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::TEST):
- 3:30 PM Changeset in webkit [239880] by
-
- 7 edits in trunk/Source
REGRESSION (PSON): Firefox app lacks Open in New Tab in menu
https://bugs.webkit.org/show_bug.cgi?id=193366
<rdar://problem/46097212>
Reviewed by Simon Fraser.
Source/WebCore:
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isFirefox):
Add a Firefox Mobile bundle check.
Source/WebKit:
A pair of unrelated changes broke Firefox's use of WKWebView internals
to override the long-press menu. Maintain binary compatibility by
introducing linked-on-or-after checks.
- UIProcess/Cocoa/VersionChecks.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):
Disable PSON in Firefox when linked against an SDK where PSON wasn't enabled by default.
Because gestures are very stateful, we always swap them out when swapping
processes (changing that behavior is fairly risky). Also, we don't always
inform the client when we swap processes (only when the process actually crashes),
so they currently don't re-adjust the gesture recognizers when a PSON swap occurs.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Synchronously install gesture recognizers under -init when linked against
an SDK before the version that introduces lazy gesture recognizer installation.
r237331 is an optimization that made us lazily install gestures when the
view is parented, but Firefox (and potentially other clients) depend
on them being installed synchronously in order to find and override them.
- 3:10 PM Changeset in webkit [239879] by
-
- 16 edits15 adds in trunk
[JSC] Global lexical bindings can shadow global variables if it is
configurable = true
https://bugs.webkit.org/show_bug.cgi?id=193308
<rdar://problem/45546542>
Reviewed by Saam Barati.
JSTests:
- stress/const-lexical-binding-shadow-existing-global-property-ftl.js: Added.
(shouldThrow):
(shouldBe):
(foo):
(get shouldThrow):
- stress/const-lexical-binding-shadow-existing-global-property-tdz-ftl.js: Added.
(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):
(get return):
- stress/const-lexical-binding-shadow-existing-global-property-tdz.js: Added.
(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):
- stress/const-lexical-binding-shadow-existing-global-property.js: Added.
(shouldThrow):
(shouldBe):
(foo):
- stress/const-lexical-binding-shadowing-global-properties-and-eval-injection.js: Added.
(shouldThrow):
(shouldBe):
(foo):
- stress/global-add-function-should-not-be-shadowed-by-lexical-bindings.js: Added.
(shouldThrow):
- stress/global-static-variables-should-not-be-shadowed-by-lexical-bindings.js: Added.
(shouldThrow):
- stress/let-lexical-binding-shadow-existing-global-property-ftl.js: Added.
(shouldThrow):
(shouldBe):
(foo):
- stress/let-lexical-binding-shadow-existing-global-property-tdz-ftl.js: Added.
(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):
(get return):
- stress/let-lexical-binding-shadow-existing-global-property-tdz.js: Added.
(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):
- stress/let-lexical-binding-shadow-existing-global-property.js: Added.
(shouldThrow):
(shouldBe):
(foo):
- stress/let-lexical-binding-shadowing-global-properties-and-eval-injection.js: Added.
(shouldThrow):
(shouldBe):
(foo):
Source/JavaScriptCore:
Previously, we assumed that lexical bindings in JSGlobalLexicalEnvironment cannot shadow existing global properties.
However, it is wrong. According to the spec, we can shadow global properties if a property's attribute is configurable = true.
For example, we execute two scripts.
script1.js
bar = 42;
function load() { return bar; }
print(bar); 42
print(load()); 42
script2.js
let bar = 0; This lexical binding can shadow the global.bar defined in script1.js
print(bar); 0
print(load()); 0
In JSC, we cache GlobalProperty resolve type and its associated information in op_resolve_type, op_get_from_scope, and op_put_to_scope.
They attempt to load a property from JSGlobalObject directly. However, once the newly added lexical binding starts shadowing this, our existing instructions
become invalid since they do not respect JSGlobalLexicalEnvironment.
In this patch, we fix this issue by introducing the following mechanisms.
- We have a HashMap<property name, watchpoint set> in JSGlobalObject. DFG and FTL create a watchpoint set with the property name if the generated code
depends on GlobalProperty condition of op_resolve_scope etc. These watchpoint will be fired when the shadowing happens, so that our generated DFG and FTL
code will be invalidated if it depends on the condition which is no longer valid.
- When we detect shadowing, we iterate all the live CodeBlocks which globalObject is the target one. And we rewrite instructions in them from GlobalProperty
to GlobalLexicalVar (or Dynamic precisely). So, the subsequent LLInt code just works well. "Dynamic" conversion happens when your op_put_to_scope attempts to
put a value onto a const lexical binding. This fails and it should throw a type error.
- GlobalProperty scope operations in Baseline JIT start checking ResolveType in metadata, and emit code for GlobalProperty and GlobalLexicalVar. Once the rewrite
happens, baseline JIT continues working because it checks the rewritten metadata's ResolveType.
We use this mechanism (which is similar to haveABadTime() thing) because,
- Shadowing should be super rare. Before r214145, we made these cases as SytaxError. Thus, before r214145, this type of code cannot be executed in WebKit.
And the number of the live CodeBlocks for the given JSGlobalObject should be small. This supports introducing rather simple (but not so efficient) mechanism
instead of the complicated one.
- Rewriting instructions immediately forces GlobalProperty => GlobalLexicalVar / Dynamic conversion in all the possible CodeBlock. This allows us to avoid
compilation failure loop in DFG and FTL: DFG and FTL codes are invalidated by the watchpoint, but we may attempt to compile the code with the invalidated watchpoint
and GlobalProperty status if we do not rewrite it. One possible other implementation is having and checking a counter in instruction, and every time we introduce
a new shadow binding, bump the counter. And eventually executed instruction will go to the slow path and rewrite itself. However, this way leaves the not-executed-again-yet
instructions as is, and DFG and FTL repeatedly fail to compile if we just watch the invalidated watchpoint for that. Rewriting all the existing GlobalProperty immediately
avoids this situation easily.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::notifyLexicalBindingShadowing):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::scriptMode const):
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::create):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGDesiredGlobalProperties.cpp: Added.
(JSC::DFG::DesiredGlobalProperties::isStillValidOnMainThread):
(JSC::DFG::DesiredGlobalProperties::reallyAdd):
- dfg/DFGDesiredGlobalProperties.h: Added.
(JSC::DFG::DesiredGlobalProperties::addLazily):
We need this DesiredGlobalProperties mechanism since we do not want to ref() the UniquedStringImpl in DFG and FTL thread.
We keep JSGlobalObject* and identifierNumber, and materialize WatchpointSets for each JSGlobalObject's property referenced
from DFG and FTL and inject CodeBlock jettison watchpoints in the main thread.
- dfg/DFGDesiredGlobalProperty.h: Added.
(JSC::DFG::DesiredGlobalProperty::DesiredGlobalProperty):
(JSC::DFG::DesiredGlobalProperty::globalObject const):
(JSC::DFG::DesiredGlobalProperty::identifierNumber const):
(JSC::DFG::DesiredGlobalProperty::operator== const):
(JSC::DFG::DesiredGlobalProperty::operator!= const):
(JSC::DFG::DesiredGlobalProperty::isHashTableDeletedValue const):
(JSC::DFG::DesiredGlobalProperty::hash const):
(JSC::DFG::DesiredGlobalProperty::dumpInContext const):
(JSC::DFG::DesiredGlobalProperty::dump const):
(JSC::DFG::DesiredGlobalPropertyHash::hash):
(JSC::DFG::DesiredGlobalPropertyHash::equal):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::globalProperties):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::isStillValidOnMainThread):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::cancel):
- dfg/DFGPlan.h:
(JSC::DFG::Plan::globalProperties):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::notifyLexicalBindingShadowing):
(JSC::JSGlobalObject::getReferencedPropertyWatchpointSet):
(JSC::JSGlobalObject::ensureReferencedPropertyWatchpointSet):
- runtime/JSGlobalObject.h:
- runtime/ProgramExecutable.cpp:
(JSC::hasRestrictedGlobalProperty):
(JSC::ProgramExecutable::initializeGlobalProperties):
- 2:48 PM Changeset in webkit [239878] by
-
- 2 edits in trunk/Tools
webkitpy: Support alternate simctl device list output
https://bugs.webkit.org/show_bug.cgi?id=193362
<rdar://problem/47122965>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.populate_available_devices):
- 2:38 PM Changeset in webkit [239877] by
-
- 3 edits2 adds in trunk
Release assert when removing element with a map element in the shadow tree
https://bugs.webkit.org/show_bug.cgi?id=193351
<rdar://problem/47208807>
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a shadow host that has a map element in the shadow tree is removed from the document, we try
to remove the map from the scope of the host.
Test: fast/shadow-dom/image-map-tree-scope.html
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedIntoAncestor):
(WebCore::HTMLMapElement::removedFromAncestor):
Add and remove image maps when the scope changes, not when the document changes.
This matches how id/name/etc updates work in the HTMLElement.
LayoutTests:
- fast/shadow-dom/image-map-tree-scope-expected.txt: Added.
- fast/shadow-dom/image-map-tree-scope.html: Added.
- 2:36 PM Changeset in webkit [239876] by
-
- 2 edits in trunk/Tools
[ews-build] Update macOS queue configurations
https://bugs.webkit.org/show_bug.cgi?id=193365
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/config.json:
- 2:26 PM Changeset in webkit [239875] by
-
- 10 edits in trunk/Tools
webkitpy: Incorporate device type into baseline search path
https://bugs.webkit.org/show_bug.cgi?id=193356
<rdar://problem/47215515>
Reviewed by Lucas Forschler.
We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
- Scripts/webkitpy/port/base.py:
(Port.default_baseline_search_path): Allow device type to be passed in.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/ios.py:
(IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
(IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
- Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest):
- Scripts/webkitpy/port/ios_simulator_unittest.py:
(IOSSimulatorTest):
- Scripts/webkitpy/port/mac.py:
(MacPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/watch.py:
(WatchPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/win.py:
(WinPort.default_baseline_search_path): Ditto.
(WinCairoPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/wpe.py:
(WPEPort.default_baseline_search_path): Ditto.
- 2:25 PM Changeset in webkit [239874] by
-
- 3 edits in trunk/Tools
webkitpy: Print abbreviated baseline search path that includes only folders that exist
https://bugs.webkit.org/show_bug.cgi?id=193352
<rdar://problem/47210736>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config): Print list on only baseline search paths which exist.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_config):
- 2:01 PM Changeset in webkit [239873] by
-
- 2 edits in trunk/Source/WTF
WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350
Reviewed by Brent Fulgham.
The non COCOA version of WorkQueue::concurrentApply() creates a temporary
String for the threadName and passes the raw pointer of this String to
Thread::create(). After freeing this String, Thread::entryPoint() uses
the raw char pointer to internally initialize the thread.
The fix is to use a single literal string for all the threads' names since
they are created for a thread-pool.
- wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply):
- 1:57 PM Changeset in webkit [239872] by
-
- 2 edits in trunk/Source/WebCore
Fix an assertion in UniqueIDBDatabase
https://bugs.webkit.org/show_bug.cgi?id=193096
Reviewed by Brady Eidson.
m_objectStoreTransactionCounts.count(objectStore) == 1 in UniqueIDBDatabase::operationAndTransactionTimerFired()
is not necessarily true because m_objectStoreTransactionCounts may be cleared in immediateCloseForUserDelete.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired):
- 1:04 PM Changeset in webkit [239871] by
-
- 4 edits in trunk/Tools
Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=193340
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-11
Reviewed by David Kilzer.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
Pull the strings out into a WKRetainPtr.
- WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::closeWebNotification):
Adopt the created value into the WKRetainPtr.
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::generateWhitelist):
Immediately adopt a created value to avoid potential mistakes.
- 1:02 PM Changeset in webkit [239870] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
https://bugs.webkit.org/show_bug.cgi?id=192917
<rdar://problem/46875285>
Reviewed by Devin Rousso.
SelectionController should not be notified of removed children until the
child items have been removed from the TreeOutline. Doing so at this stage
is unsafe, since this method checksthis.selectedTreeElement, which could
return the adjusted index from the SelectionController before anything has
actually been removed from the TreeOutline.
The number of calls to SelectionController.prototype.didRemoveItems is also
reduced somewhat, since we're no longer calling it for every TreeElement.
- UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.removeChildAtIndex):
(WI.TreeOutline.prototype.removeChildren):
(WI.TreeOutline.prototype._forgetTreeElement):
(WI.TreeOutline.prototype._indexesForSubtree): Added.
- 1:01 PM Changeset in webkit [239869] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Garbled rendering on Youtube while scrolling under X11.
https://bugs.webkit.org/show_bug.cgi?id=192982
Reviewed by Carlos Garcia Campos.
When creating a GLX window context, try to get a GLXFBConfig that has depth and stencil buffers for
the default framebuffer.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::compatibleVisuals):
(WebCore::GLContextGLX::createWindowContext):
- 1:00 PM Changeset in webkit [239868] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 12:41 PM Changeset in webkit [239867] by
-
- 23 edits in trunk
Enable DFG on ARM/Linux again
https://bugs.webkit.org/show_bug.cgi?id=192496
Reviewed by Yusuke Suzuki.
JSTests:
Test wasn't really skipped before moving the line with skip
to the top.
- stress/regress-192717.js:
Source/JavaScriptCore:
After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Do not use register
r11 in compiled DFG mode since it is already used in LLInt as metadataTable
register. Also clean up code since ARM traditional isn't supported anymore.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
- jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::CallFrameShuffler):
- jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
- llint/LowLevelInterpreter32_64.asm:
- offlineasm/arm.rb:
Source/WTF:
After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux.
- wtf/Platform.h:
Tools:
After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
on ARM by default.
- Scripts/run-jsc-stress-tests:
LayoutTests:
After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Disable tests that
run out of executable memory with LLInt disabled.
- js/script-tests/dfg-float32array.js:
- js/script-tests/dfg-float64array.js:
- js/script-tests/dfg-int16array.js:
- js/script-tests/dfg-int32array-overflow-values.js:
- js/script-tests/dfg-int32array.js:
- js/script-tests/dfg-int8array.js:
- js/script-tests/dfg-uint16array.js:
- js/script-tests/dfg-uint32array.js:
- js/script-tests/dfg-uint8array.js:
- 12:37 PM Changeset in webkit [239866] by
-
- 2 edits in trunk/Tools
Unreviewed, fix #ifdef in API test added in r239851.
https://bugs.webkit.org/show_bug.cgi?id=193327
rdar://problem/47093222
- TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
- 12:21 PM Changeset in webkit [239865] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: leak IDBTransaction, TransactionOperation and IDBRequest in layout tests
https://bugs.webkit.org/show_bug.cgi?id=193167
<rdar://problem/46891688>
Reviewed by Geoffrey Garen.
Do some cleanup to break retain cycle when context is stopped.
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::cancelForStop):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::abortOnServerAndCancelRequests):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::removeRequest):
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::doComplete):
- 10:28 AM Changeset in webkit [239864] by
-
- 27 edits5 copies5 adds in trunk
Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=193109
<rdar://problem/44807048>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adds new IDL files and stubs for UndoManager and UndoItem. This is an experimental DOM API that (in the near
future) is intended only for use in internal WebKit text editing clients. This API allows the page to
participate in the processes of undoing and redoing by defining custom undo and redo handlers, to be executed
when undo or redo is triggered.
Tests: editing/undo-manager/undo-manager-interfaces.html
editing/undo-manager/undo-manager-keeps-wrapper-alive.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- UnifiedSources-input.xcfilelist:
- WebCore.xcodeproj/project.pbxproj:
Add new source files.
- bindings/js/WebCoreBuiltinNames.h:
Add "UndoManager" and "UndoItem" names.
- dom/Document.cpp:
(WebCore::m_undoManager):
Have the document own a UndoManager.
- dom/Document.h:
(WebCore::Document::undoManager const):
- dom/Document.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled):
(WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const):
Guard the new bindings behind a runtime-enabled feature flag.
- page/UndoItem.h: Added.
(WebCore::UndoItem::create):
(WebCore::UndoItem::label const):
(WebCore::UndoItem::undoHandler const):
(WebCore::UndoItem::redoHandler const):
(WebCore::UndoItem::UndoItem):
- page/UndoItem.idl: Added.
- page/UndoManager.cpp: Added.
(WebCore::UndoManager::addItem):
- page/UndoManager.h: Added.
(WebCore::UndoManager::create):
(WebCore::UndoManager::document):
(WebCore::UndoManager::UndoManager):
- page/UndoManager.idl: Added.
- page/mac/WheelEventDeltaFilterMac.h:
Necessary (albeit unrelated) build fix to appease unified sources.
Source/WebKit:
Add a new SPI configuration flag to enable the UndoManager API. This is off by default.
- Shared/WebPreferences.yaml:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]):
(-[WKWebViewConfiguration _undoManagerAPIEnabled]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Tools:
Introduce and respect a test option to enable the UndoManager API.
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
LayoutTests:
Add UndoManager tests to exercise new bindings, and verify that the JS wrapper for Document's UndoManager
survives garbage collection.
- TestExpectations:
- editing/undo-manager/undo-manager-interfaces-expected.txt: Added.
- editing/undo-manager/undo-manager-interfaces.html: Added.
- editing/undo-manager/undo-manager-keeps-wrapper-alive-expected.txt: Added.
- editing/undo-manager/undo-manager-keeps-wrapper-alive.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 8:19 AM Changeset in webkit [239863] by
-
- 8 edits2 adds in trunk
[LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
https://bugs.webkit.org/show_bug.cgi?id=193346
Reviewed by Antti Koivisto.
Source/WebCore:
If the top and bottom margins of a box are adjoining, then it is possible for margins to collapse through it.
In this case, the position of the element depends on its relationship with the other elements whose margins are being collapsed.
- If the element's margins are collapsed with its parent's top margin, the top border edge of the box is defined to be the same as the parent's.
- Otherwise, either the element's parent is not taking part in the margin collapsing, or only the parent's bottom margin is involved. The position of the element's top border edge is the same as it would have been if the element had a non-zero bottom border.
Test: fast/block/block-only/collapsed-through-with-parent.html
- layout/MarginTypes.h:
(WebCore::Layout::EstimatedMarginBefore::usedValue const):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/block-only/collapsed-through-with-parent-expected.txt: Added.
- fast/block/block-only/collapsed-through-with-parent.html: Added.
- 5:17 AM Changeset in webkit [239862] by
-
- 8 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaseline several tests after r239822.
- platform/gtk/css2.1/t1202-counter-04-b-expected.png:
- platform/gtk/css2.1/t1202-counter-04-b-expected.txt:
- platform/gtk/css2.1/t1202-counters-04-b-expected.png:
- platform/gtk/css2.1/t1202-counters-04-b-expected.txt:
- platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:
- platform/gtk/fast/text/fallback-traits-fixup-expected.png:
- platform/gtk/fast/text/fallback-traits-fixup-expected.txt:
