Timeline
Mar 1, 2020:
- 8:29 PM Changeset in webkit [257701] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix for non-unified builds after r257507.
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginValue const):
(WebCore::Layout::marginValue): Deleted.
- 7:20 PM Changeset in webkit [257700] by
-
- 3 edits in trunk/Source/WebKit
[GTK] Fix the build when Wayland target is disabled
https://bugs.webkit.org/show_bug.cgi?id=208407
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2020-03-01
Reviewed by Darin Adler.
Values in the enum WebCore::PlatformDisplay::Type are only defined when
their corresponding platform targets are enabled, so we need #if checks
around uses of them.
- UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU):
- UIProcess/API/glib/WebKitUIClient.cpp:
(UIClient::windowConfigureEventCallback):
- 5:25 PM Changeset in webkit [257699] by
-
- 66 edits21 adds in trunk/LayoutTests
[WPE] Gardening, update TestExpectations and baselines
https://bugs.webkit.org/show_bug.cgi?id=208433
Unreviewed gardening.
- platform/wpe/TestExpectations:
- platform/wpe/accessibility/media-emits-object-replacement-expected.txt:
- platform/wpe/css3/flexbox/button-expected.txt:
- platform/wpe/fast/block/float/float-avoidance-expected.txt:
- platform/wpe/fast/canvas/fallback-content-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/drawElements-empty-vertex-data-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/webgl-drawarrays-crash-2-expected.txt: Added.
- platform/wpe/fast/canvas/webgl/webgl-drawarrays-crash-expected.txt: Added.
- platform/wpe/fast/css/continuationCrash-expected.txt:
- platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt:
- platform/wpe/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/wpe/fast/css/non-standard-checkbox-size-expected.txt:
- platform/wpe/fast/css/rtl-ordering-expected.txt:
- platform/wpe/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/wpe/fast/css/text-overflow-input-expected.txt:
- platform/wpe/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/wpe/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/wpe/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt:
- platform/wpe/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/wpe/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/wpe/fast/dom/Range/getBoundingClientRect-expected.txt:
- platform/wpe/fast/html/details-replace-summary-child-expected.txt:
- platform/wpe/fast/html/details-replace-text-expected.txt:
- platform/wpe/fast/layers/video-layer-expected.txt:
- platform/wpe/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/wpe/fast/overflow/scrollRevealButton-expected.txt:
- platform/wpe/fast/replaced/replaced-breaking-expected.txt:
- platform/wpe/fast/replaced/table-percent-height-expected.txt:
- platform/wpe/fast/replaced/width100percent-button-expected.txt:
- platform/wpe/fast/replaced/width100percent-checkbox-expected.txt:
- platform/wpe/fast/replaced/width100percent-radio-expected.txt:
- platform/wpe/fast/replaced/width100percent-searchfield-expected.txt:
- platform/wpe/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
- platform/wpe/fetch/fetch-url-serialization-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/css/css-sizing/button-min-width-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-transitions/before-load-001-expected.txt:
- platform/wpe/storage/domstorage/sessionstorage/blocked-file-access-expected.txt: Added.
- platform/wpe/svg/custom/foreign-object-skew-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug138725-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug18359-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug26178-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug28928-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug33855-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug39209-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug4429-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug51037-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug51727-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug52505-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug52506-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug60749-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug7342-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/wpe/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/wpe/tables/mozilla/dom/tableDom-expected.txt:
- platform/wpe/tables/mozilla/other/move_row-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/wpe/webanimations/partly-accelerated-transition-by-removing-property-expected.txt:
- platform/wpe/webgl/1.0.3/conformance/context/context-lost-restored-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
- platform/wpe/webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt:
- platform/wpe/webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt:
- platform/wpe/webgl/2.0.0/conformance2/transform_feedback/unwritten-output-defaults-to-zero-expected.txt:
- 4:43 PM Changeset in webkit [257698] by
-
- 9 edits in trunk/Source/WebCore
Slim down some CSS parsing code
https://bugs.webkit.org/show_bug.cgi?id=208418
Reviewed by Anders Carlsson.
- css/CSSPrimitiveValue.h: Remove unused createAllowingMarginQuirk function
and the FIXME-NEWPARSER that said we wouldn't need it any more and the
no-longer-needed isQuirkValue function.
- css/CSSValue.h: Remove m_isQuirkValue.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSelector): Call parseCSSSelector instead of
CSSSelectorParser::parseSelector, because that's the public function now.
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeStyleRule): Ditto.
- css/parser/CSSPropertyParserHelpers.h: Removed a FIXME-NEWPARSER that is
now obsolete.
- css/parser/CSSSelectorParser.cpp: Moved the entire CSSSelectorParser class here from
the header, because the only thing used outside this file is the entry point, the
now renamed parseCSSSelector function.
(WebCore::CSSSelectorParser::DisallowPseudoElementsScope::DisallowPseudoElementsScope):
Changed this class to use a reference instead of a pointer.
(WebCore::parseCSSSelector): Renamed CSSSelectorParser::parseSelector to this.
(WebCore::CSSSelectorParser::consumeComplexSelectorList): Use auto to make some
unique_ptr code less verbose.
(WebCore::CSSSelectorParser::consumeCompoundSelectorList): Ditto. Removed the check of
m_failed. Only the parser entry point function needs that check, and that is the
consumeComplexSelectorList function above.
(WebCore::extractCompoundFlags): Use static instead of anonymous namespace. Use enum
class instead of enum, and use OptionSet instead of unsigned.
(WebCore::CSSSelectorParser::consumeComplexSelector): Updated for the above. This
refactoring exposed a strangeness in the simple selector loop; for now maintained
behavior rather than changing it to do something more logical.
(WebCore::isScrollbarPseudoClass): Use static instead of anonymous namespace.
(WebCore::isUserActionPseudoClass): Ditto.
(WebCore::isPseudoClassValidAfterPseudoElement): Ditto.
(WebCore::isSimpleSelectorValidAfterPseudoElement): Ditto.
(WebCore::CSSSelectorParser::consumeCompoundSelector): Use auto to make unique_ptr
code less verbose. Also inlined the one line applySimpleSelectorToCompound function,
because that name didn't document much thus having a function obscured rather than
clarifying what was going on. Also use makeUnique instead of new.
(WebCore::CSSSelectorParser::consumeId): Use makeUnique instead of new.
(WebCore::CSSSelectorParser::consumeClass): Ditto.
(WebCore::CSSSelectorParser::consumeAttribute): Ditto.
(WebCore::isOnlyPseudoElementFunction): Tweaked a comment.
(WebCore::CSSSelectorParser::consumePseudo): Update use of DisallowPseudoElementsScope
to use a reference, use auto to make unique_ptr code less verbose, use makeUnique
instead of new.
(WebCore::consumeANPlusB): Converted to a file-level static function rather than
a static member function.
(WebCore::CSSSelectorParser::prependTypeSelectorIfNeeded): Changed type from
pointer to reference
(WebCore::CSSSelectorParser::addSimpleSelectorToCompound): Deleted.
- css/parser/CSSSelectorParser.h: Removed most of the contents of this file, leaving
only the function that is the parser entry point.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLength): This si the one place that sets
the quirk on a Length value. It now checks for CSS_QUIRKY_EMS directly rather than
using a helper function.
- 4:42 PM Changeset in webkit [257697] by
-
- 8 edits1 delete in trunk/Source/WebCore
Tighten up CSSPendingSubstitutionValue
https://bugs.webkit.org/show_bug.cgi?id=208421
Reviewed by Anders Carlsson.
- Sources.txt: Removed CSSPendingSubstitutionValue.cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSPendingSubstitutionValue.cpp: Removed.
- css/CSSPendingSubstitutionValue.h:
(WebCore::CSSPendingSubstitutionValue::shorthandValue const): Return a reference
instead of a pointer.
(WebCore::CSSPendingSubstitutionValue::equals const): Updated since m_shorthandValue
is now a Ref instead of RefPtr.
(WebCore::CSSPendingSubstitutionValue::customCSSText): Made this a static member
function that always returns an empty string.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const): Use auto, scoped variables
so they don't live until the end of the function. Simplified the code and the
comments while retaining as much clarity as possible. Also call getPropertyCSSValue
directly instead of calling getPropertyCSSValueInternal.
(WebCore::StyleProperties::asText const): Use is<> to make the code simpler.
Also updated to use reference instead of pointer from CSSPendingSubstitutionValue.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::borderSpacingValue const): Call getPropertyCSSValue
instead of getPropertyCSSValueInternal.
(WebCore::StyleProperties::getLayeredShorthandValue const): Ditto.
(WebCore::StyleProperties::getShorthandValue const): Ditto.
(WebCore::StyleProperties::getCommonValue const): Ditto.
(WebCore::StyleProperties::pageBreakPropertyValue const): Ditto. Also added a
missing null check.
(WebCore::StyleProperties::getPropertyCSSValue const): Merged with the function
below since all this did was call getPropertyCSSValueInternal.
(WebCore::StyleProperties::getPropertyCSSValueInternal const): Renamed to take
away the word internal and merged with the function above.
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const): Removed
incorrectly copied and pasted comment.
(WebCore::MutableStyleProperties::findCustomPropertyIndex const): Ditto.
(WebCore::StyleProperties::copyPropertiesInSet const): Call getPropertyCSSValue
instead of getPropertyCSSValueInternal.
- css/StyleProperties.h: Removed getPropertyCSSValueInternal.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences): Use is<> and fewer locals.
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValueStart): Removed a local and made this use
more Ref and less RefPtr.
- 4:40 PM Changeset in webkit [257696] by
-
- 14 edits in trunk/Source/WebCore
Move some vectors around instead of heap-allocating them and moving the pointers
https://bugs.webkit.org/show_bug.cgi?id=208422
Reviewed by Sam Weinig.
- css/CSSKeyframeRule.cpp:
(WebCore::StyleRuleKeyframe::StyleRuleKeyframe): Take Vector&& instead of
unique_ptr<Vector>.
(WebCore::StyleRuleKeyframe::create): Moved these here from the header.
Take Vector&& instead of unique_ptr<Vector>.
(WebCore::StyleRuleKeyframe::setKeyText): Update since the result is a
Vector rather than a unique_ptr<Vector>.
- css/CSSKeyframeRule.h: Updated for the above.
- css/CSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::findKeyframeIndex const): Return Optional<size_t>
so we don't depend on notFound. This is our better modern pattern, since
notFound can work wrong if we mix size_t and unsigned, for example. Also
updatd since result of parseKeyFrameKeyList is now a Vector rather than
a unique_ptr<Vector>.
(WebCore::CSSKeyframesRule::deleteRule): Updated for the above.
(WebCore::CSSKeyframesRule::findRule): Ditto.
- css/CSSKeyframesRule.h: Updated for the above.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseKeyframeKeyList): Return Vector instead of
unique_ptr<Vector>.
- css/parser/CSSParser.h: Updated for the above.
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::parseKeyframeKeyList): Return Vector instead of
unique_ptr<Vector>.
(WebCore::CSSParserImpl::consumeKeyframeStyleRule): Updated for the
above change.
(WebCore::CSSParserImpl::consumeKeyframeKeyList): Return Vector instead
of unique_ptr<Vector>.
- css/parser/CSSParserImpl.h: Updated for the above.
- platform/graphics/FloatPolygon.cpp:
(WebCore::FloatPolygon::FloatPolygon): Take Vector&& instead of
unique_ptr<Vector>.
- platform/graphics/FloatPolygon.h: Take Vector&& instead of unique_ptr<Vector>.
Also changed m_vertices to a Vector instead of a unique_ptr<Vector>.
- rendering/shapes/PolygonShape.h: Take Vector&& instead of unique_ptr<Vector>.
- rendering/shapes/Shape.cpp:
(WebCore::createPolygonShape): Take Vector&& instead of unique_ptr<Vector>.
(WebCore::Shape::createShape): Use a Vector instead of a unique_ptr<Vector>.
- 4:06 PM Changeset in webkit [257695] by
-
- 2 edits in trunk/Source/JavaScriptCore
undefined reference to `JSC::ExecutableBase::hasJITCodeForCall() const'
https://bugs.webkit.org/show_bug.cgi?id=207890
Reviewed by Yusuke Suzuki.
Encountered on arm-buildroot-linux-gnueabihf with GCC 9.2.0.
- runtime/NativeExecutable.cpp: Inclusion of
ExecutableBaseInlines.h resolves the issue for me.
- 3:36 PM Changeset in webkit [257694] by
-
- 4 edits in trunk
Unreviewed, rolling out r257618.
This allegedly causes Safari to crash when closing a window
(see rdar://problem/59922725).
Reverted changeset:
"UIProcess crash after using _prepareForMoveToWindow, then
deallocating the WKWebView before moving to the window"
https://bugs.webkit.org/show_bug.cgi?id=208365
https://trac.webkit.org/changeset/257618
- 3:13 PM Changeset in webkit [257693] by
-
- 2 edits in trunk/Source/WebKit
Many tests in canvas and fast/canvas are asserting after r257677
https://bugs.webkit.org/show_bug.cgi?id=208431
<rdar://problem/59911910>
Reviewed by Tim Horton.
RemoteRenderingBackend asserts that it should never be created with a RenderingMode that isn't either
RemoteAccelerated or RemoteUnaccelerated. This was previously the case before r257677, because
ImageBuffer::create() would only call into the host window (i.e. the chrome and, in turn, chrome client) to
create the remote image buffer if the rendering mode is RemoteAccelerated or RemoteUnaccelerated. However, since
we want to move away from any references to RemoteAccelerated or RemoteUnaccelerated rendering modes in WebCore,
we should instead fix this by adding a similar check in the client (WebKit) layer.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createImageBuffer const):
Don't bother creating a RemoteRenderingBackend and telling it to create an image buffer, if the given
RenderingMode isn't one of RemoteAccelerated or RemoteUnaccelerated.
- 12:46 PM Changeset in webkit [257692] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208430
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 10:24 AM Changeset in webkit [257691] by
-
- 2 edits2 adds in trunk/Source/ThirdParty
Re-add the patch used to work around gtest linking failure on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=208409
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2020-03-01
Reviewed by Michael Catanzaro.
The patch was added in https://bugs.webkit.org/show_bug.cgi?id=138420 to
fix gtest linking error on FreeBSD. However, it was accidentally dropped
in r235613, the commit updating gtest, causing the error to happen
again. Re-add it to fix the build on FreeBSD.
- gtest/src/gtest-death-test.cc:
- 9:55 AM Changeset in webkit [257690] by
-
- 6 edits in trunk/Source/WebCore
[LFC][MarginCollapsing] Do not re-compute PositiveAndNegativeVerticalMargin values
https://bugs.webkit.org/show_bug.cgi?id=208419
<rdar://problem/59923666>
Reviewed by Antti Koivisto.
MarginCollapse::collapsedVerticalValues() already computes the positive/negative before/after pairs.
- layout/MarginTypes.h:
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::resolvedPositiveNegativeMarginValues): Deleted.
- 9:19 AM Changeset in webkit [257689] by
-
- 3 edits in trunk/Source/WebCore
Convert m_scrollingNodeToLayerMap to use WeakPtr<RenderLayer>
https://bugs.webkit.org/show_bug.cgi?id=208403
Reviewed by Zalan Bujtas.
Use WeakPtr<> in m_scrollingNodeToLayerMap.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayerWithRole):
(WebCore::RenderLayerCompositor::scrollableAreaForScrollLayerID const):
- rendering/RenderLayerCompositor.h:
Feb 29, 2020:
- 9:01 PM Changeset in webkit [257688] by
-
- 61 edits in trunk
Remove std::lock_guard
https://bugs.webkit.org/show_bug.cgi?id=206451
Reviewed by Anders Carlsson.
Source/bmalloc:
- bmalloc/Mutex.h:
Source/JavaScriptCore:
- API/JSVirtualMachine.mm:
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):
- API/glib/JSCVirtualMachine.cpp:
(addWrapper):
(removeWrapper):
- heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::analyzeNode):
(JSC::HeapSnapshotBuilder::analyzeEdge):
(JSC::HeapSnapshotBuilder::analyzePropertyNameEdge):
(JSC::HeapSnapshotBuilder::analyzeVariableNameEdge):
(JSC::HeapSnapshotBuilder::analyzeIndexEdge):
(JSC::HeapSnapshotBuilder::setOpaqueRootReachabilityReasonForCell):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStacks):
- runtime/JSRunLoopTimer.cpp:
(JSC::JSRunLoopTimer::timerDidFire):
Source/WebCore:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelScheduledValues):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::reset):
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::setPeriodicWave):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::setOversample):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::closeDatabase):
(WebCore::Database::getCachedVersion const):
(WebCore::Database::setCachedVersion):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::CryptoAlgorithmRegistry::identifier):
(WebCore::CryptoAlgorithmRegistry::name):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- inspector/agents/WebHeapAgent.cpp:
(WebCore::SendGarbageCollectionEventsTask::addGarbageCollection):
(WebCore::SendGarbageCollectionEventsTask::reset):
(WebCore::SendGarbageCollectionEventsTask::timerFired):
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/generic/ScrollingThreadGeneric.cpp:
(WebCore::ScrollingThread::initializeRunLoop):
- page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::initializeRunLoop):
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::~ReverbConvolver):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
(WebCore::AudioSourceProviderAVFObjC::prepareCallback):
(WebCore::AudioSourceProviderAVFObjC::unprepareCallback):
(WebCore::AudioSourceProviderAVFObjC::processCallback):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontDatabase::collectionForFamily):
(WebCore::FontDatabase::clear):
- platform/ios/wak/WebCoreThreadRun.cpp:
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):
- platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::loaderRunLoop):
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setIsDatabaseOpeningForbidden):
(WebCore::SQLiteDatabase::open):
- platform/sql/SQLiteDatabaseTracker.cpp:
(WebCore::SQLiteDatabaseTracker::setClient):
(WebCore::SQLiteDatabaseTracker::incrementTransactionInProgressCount):
(WebCore::SQLiteDatabaseTracker::decrementTransactionInProgressCount):
(WebCore::SQLiteDatabaseTracker::hasTransactionInProgress):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
(WebCore::newTextCodec):
(WebCore::atomCanonicalTextEncodingName):
Source/WebKit:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::traverse):
- Platform/IPC/Connection.cpp:
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::SyncMessageState::dispatchMessages):
(IPC::Connection::SyncMessageState::dispatchMessagesAndResetDidScheduleDispatchMessagesForConnection):
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::addThreadMessageReceiver):
(IPC::Connection::removeThreadMessageReceiver):
(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::installIncomingSyncMessageCallback):
(IPC::Connection::uninstallIncomingSyncMessageCallback):
(IPC::Connection::hasIncomingSyncMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::sendOutgoingMessages):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::dispatchMessageToWorkQueueReceiver):
(IPC::Connection::dispatchMessageToThreadReceiver):
(IPC::Connection::dispatchOneIncomingMessage):
(IPC::Connection::dispatchIncomingMessages):
- Shared/BlockingResponseMap.h:
(BlockingResponseMap::didReceiveResponse):
- UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(prepareDataForPrintingOnSecondaryThread):
Source/WebKitLegacy/mac:
- DOM/DOMInternal.mm:
(getDOMWrapper):
(addDOMWrapper):
(removeDOMWrapper):
Source/WTF:
Remove use of std::lock_guard. This is deprecated in C++17.
- For particularly low-level usage (like, bmalloc, std::mutex), use std::scoped_lock.
- For the other purpose, use holdLock.
- benchmarks/ConditionSpeedTest.cpp:
- wtf/CryptographicallyRandomNumber.cpp:
- wtf/HashTable.cpp:
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
- wtf/HashTable.h:
(WTF::KeyTraits>::invalidateIterators):
(WTF::addIterator):
(WTF::removeIterator):
- wtf/Language.cpp:
(WTF::userPreferredLanguages):
- wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
(WTF::callOnMainAndWait):
- wtf/StackStats.cpp:
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):
- wtf/WordLock.cpp:
(WTF::WordLock::unlockSlow):
- wtf/cf/LanguageCF.cpp:
(WTF::languagePreferencesDidChange):
(WTF::platformUserPreferredLanguages):
- wtf/text/StringView.cpp:
(WTF::StringView::invalidate):
(WTF::StringView::adoptUnderlyingString):
(WTF::StringView::setUnderlyingString):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::Collator):
(WTF::Collator::~Collator):
- wtf/win/LanguageWin.cpp:
(WTF::platformLanguage):
Tools:
Add std::lock_guard lint rule to prevent from using it.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_lock_guard):
(check_style):
(CppChecker):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_lock_guard):
- TestWebKitAPI/Tests/WTF/Condition.cpp:
- TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
- TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
(assertHasObjects):
(assertHasOnlyObjects):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AXThread::dispatch):
(WTR::AXThread::dispatchFunctionsFromAXThread):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AXThread::initializeRunLoop):
- 7:32 PM Changeset in webkit [257687] by
-
- 14 edits1 add in trunk
[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
https://bugs.webkit.org/show_bug.cgi?id=208415
Reviewed by Brent Fulgham.
Source/WebCore:
This is currently done in the WebContent process, but since this is using a system service which will be closed,
this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
and send it to the WebContent process.
API test: WebKit.UTIFromMIMEType
- platform/network/mac/UTIUtilities.h:
- platform/network/mac/UTIUtilities.mm:
(WebCore::mapUTIFromMIMEType):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::cacheUTIFromMimeType):
(WebCore::UTIFromMIMEType):
(WebCore::mimeTypes):
(WebCore::createUTIFromMIMETypeMap):
(WebCore::setUTIFromMIMETypeMap):
- testing/Internals.cpp:
(WebCore::Internals::getUTIFromMIMEType):
- testing/Internals.mm:
(WebCore::Internals::getUTIFromMIMEType):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Send the mapping between MIME types and UTI types to the WebContent process as part of the Web
process creation parameters.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
(TEST):
- 5:36 PM Changeset in webkit [257686] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed unified build fix; add include macro for LayerHostingContext.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
- 10:12 AM Changeset in webkit [257685] by
-
- 3 edits in trunk/Source/WebCore
[LFC][BFC] Consolidate precomputeVerticalPositionForAncestors and precomputeVerticalPosition
https://bugs.webkit.org/show_bug.cgi?id=208414
<rdar://problem/59919467>
Reviewed by Antti Koivisto.
BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors takes care of both the box and its ancestors now.
This is also in preparation for making precompute logic a bit simpler.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPosition): Deleted.
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRoot): Deleted.
- layout/blockformatting/BlockFormattingContext.h:
- 10:05 AM Changeset in webkit [257684] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
Fix the Windows build after r257645.
- WebView.cpp:
(WebView::setAcceleratedCompositing):
- 8:24 AM Changeset in webkit [257683] by
-
- 3 edits2 adds in trunk
[LFC][Floats] FloatingState::top should return topmost logical vertical position
https://bugs.webkit.org/show_bug.cgi?id=208412
<rdar://problem/59918798>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/block-only/block-root-top-should-start-from-float-top.html
When computing the used height for an auto: height formatting root block level container, we have to take both the non-floating and floating
in-flow boxes into account. This patch ensures that in case of multiple floats, we use the topmost float's logical top position.
- layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::top const):
LayoutTests:
- fast/layoutformattingcontext/block-only/block-root-top-should-start-from-float-top-expected.html: Added.
- fast/layoutformattingcontext/block-only/block-root-top-should-start-from-float-top.html: Added.
- 7:20 AM Changeset in webkit [257682] by
-
- 3 edits2 adds in trunk
[LFC][Floats] The used available width for float avoider with clear always matches the containing block's constraint
https://bugs.webkit.org/show_bug.cgi?id=208411
<rdar://problem/59918356>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/block-only/float-clear-with-auto-width.html
Float clear pushes the block level box either below the floats, or just one side below but the other side could overlap.
What it means is that the used available width always matches the containing block's constraint.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
LayoutTests:
- fast/layoutformattingcontext/block-only/float-clear-with-auto-width-expected.html: Added.
- fast/layoutformattingcontext/block-only/float-clear-with-auto-width.html: Added.
- 2:00 AM WebKitGTK/2.28.x edited by
- (diff)
- 12:04 AM Changeset in webkit [257681] by
-
- 19 edits in trunk/Source
[JSC] BuiltinNames' HashMap should be small
https://bugs.webkit.org/show_bug.cgi?id=208404
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch converts public-to-private-name-map from HashMap<RefPtr<UniquedStringImpl>, SymbolImpl*> to HashSet<String> to save half of memory.
The key is that private names have the same string content to the public names. We can just query with string content to the HashSet of
private names, and we can get private names.
The problem is that we also have a hack inserting string <-> non-private well-known Symbol mappings into this table. These symbols do not have
the same content to the public string. So the above assumption is broken.
To make the above assumption valid, we have a separate small HashMap which holds string <-> non-private well-known Symbol mappings. Since # of
well-known Symbols are only 13, this new HashMap is taking at most 512B for entries, which is much smaller compared to the saved memory by
converting HashMap to HashSet for private names (32KB).
To allow it, we introduce new well-known Symbol identifier syntax to builtin JS, which is "@@iterator" format. If there is two "@", we parse this
identifier as a well-known Symbol.
- builtins/ArrayConstructor.js:
(from.wrapper.iterator):
(from):
(from.wrapper.iteratorSymbol): Deleted.
- builtins/ArrayPrototype.js:
(globalPrivate.concatSlowPath):
(concat):
- builtins/BuiltinNames.cpp:
(JSC::BuiltinNames::BuiltinNames):
(JSC::CharBufferSeacher::hash):
(JSC::CharBufferSeacher::equal):
(JSC::lookUpPrivateNameImpl):
(JSC::lookUpWellKnownSymbolImpl):
(JSC::BuiltinNames::lookUpPrivateName const):
(JSC::BuiltinNames::lookUpWellKnownSymbol const):
- builtins/BuiltinNames.h:
(JSC::BuiltinNames::lookUpPrivateName const):
(JSC::BuiltinNames::lookUpWellKnownSymbol const):
(JSC::BuiltinNames::checkPublicToPrivateMapConsistency):
(JSC::BuiltinNames::appendExternalName):
(JSC::BuiltinNames::getPublicName const): Deleted.
- builtins/GlobalOperations.js:
(globalPrivate.speciesConstructor):
- builtins/IteratorHelpers.js:
(performIteration):
- builtins/StringPrototype.js:
(match):
(matchAll):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(replaceAll):
(search):
(split):
- builtins/TypedArrayConstructor.js:
(from.wrapper.iterator):
(from):
(from.wrapper.iteratorSymbol): Deleted.
- builtins/TypedArrayPrototype.js:
(globalPrivate.typedArraySpeciesConstructor):
(map):
(filter):
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getByIdDirectPrivate):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putByIdDirectPrivate):
- parser/Lexer.cpp:
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
- runtime/CachedTypes.cpp:
(JSC::CachedUniquedStringImplBase::encode):
(JSC::CachedUniquedStringImplBase::decode const):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
(JSC::CommonIdentifiers::lookUpPrivateName const): Deleted.
(JSC::CommonIdentifiers::getPublicName const): Deleted.
- runtime/CommonIdentifiers.h:
- tools/JSDollarVM.cpp:
(JSC::functionGetPrivateProperty):
Source/WTF:
- wtf/text/AtomStringImpl.cpp:
(WTF::HashTranslatorCharBuffer::HashTranslatorCharBuffer): Deleted.
- wtf/text/StringImpl.h:
(WTF::HashTranslatorCharBuffer::HashTranslatorCharBuffer):
Feb 28, 2020:
- 11:21 PM Changeset in webkit [257680] by
-
- 28 edits1 add in trunk/Source
[Media in GPU process] Implement the video fullscreen and Picture-in-Picture support
https://bugs.webkit.org/show_bug.cgi?id=208252
Reviewed by Simon Fraser.
Source/WebCore:
Covered by existing tests.
This patch moves the creation of the CALayer for video fullscreen and picture-in-picture from
VideoFullscreenManager to MediaPlayerPrivate classes. With this change, we can support
video fullscreen and picture-in-picture no matter the "Media in GPU process"
feature is enabled or not. The function createVideoFullscreenLayer() is added to
MediaPlayer and MediaPlayerPrivate for that purpose.
There are duplicated code snippets to create a CALayer in MediaPlayerPrivateAVFoundationObjC,
MediaPlayerPrivateMediaSourceAVFObjC, and MediaPlayerPrivateMediaStreamAVFObjC.
That will be fixed in a future refactoring (webkit.org/b/208342).
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createVideoFullscreenLayer):
- html/HTMLMediaElement.h:
- platform/cocoa/VideoFullscreenModelVideoElement.h:
- platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::createVideoFullscreenLayer):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createVideoFullscreenLayer):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::createVideoFullscreenLayer):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoFullscreenLayer):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createVideoFullscreenLayer):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createVideoFullscreenLayer):
Source/WebKit:
The RemoteMediaPlayerProxy in the GPU process creates a LayerHostingContext and
share the context ID with the MediaPlayerPrivateRemote in the Web process,
which in turn creates a remote layer used by the VideoFullscreenManager.
Those functions regarding video fullscreen and picture-in-picture have been
moved to RemoteMediaPlayerProxy.
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::updateVideoFullscreenInlineImage): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenFrame): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenGravity): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenMode): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::setVolume): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::setBufferingPolicy): Deleted.
(WebKit::RemoteMediaPlayerManagerProxy::videoFullscreenStandbyChanged): Deleted.
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
[GPU process]
Add two asynchronous IPC messages (EnterFullscreen and ExitFullscreen) in RemoteMediaPlayerProxy
and replace the message SetVideoFullscreenFrame with SetVideoFullscreenFrameFenced.
Create the CALayer for the video fullscreen and picture-in-picture features.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::prepareForPlayback): Deleted.
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenFrame): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged): Deleted.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
(WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeFenced):
(WebKit::RemoteMediaPlayerProxy::enterFullscreen):
(WebKit::RemoteMediaPlayerProxy::exitFullscreen):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenFrameFenced):
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
[Web process]
Create a hosting layer in the Web process corresponding to the CALayer in the
GPU process for video fullscreen and picture-in-picture.
Synchronize the properties of the layers cross process boundary with MachSendRight.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrameFenced):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenGravity):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame): Deleted.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm: Added.
(WebKit::MediaPlayerPrivateRemote::createVideoFullscreenLayer):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
- WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
(WebKit::createVideoLayerRemote):
- WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
Fix unified build failures.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- 11:03 PM Changeset in webkit [257679] by
-
- 6 edits in trunk
Unreviewed, rolling out r257565.
It broke WinCairo MiniBrowser
Reverted changeset:
"[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
https://bugs.webkit.org/show_bug.cgi?id=206894
https://trac.webkit.org/changeset/257565
- 9:52 PM Changeset in webkit [257678] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed unified build fix; Add include header for IPC::DataReference.
- WebProcess/Network/WebResourceLoader.cpp:
- 7:00 PM Changeset in webkit [257677] by
-
- 18 edits in trunk/Source
Add an internal setting to enable or disable canvas rendering in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208375
Reviewed by Tim Horton.
Source/WebCore:
Adds an internal setting to enable or disable the GPU process when rendering canvases. To do this, we add a
codepath for creating a new ImageBuffer, given enum types that indicate whether to try and enable acceleration,
and also whether to use display lists.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer const):
Use the new ImageBuffer::create method.
- page/Chrome.cpp:
(WebCore::Chrome::createImageBuffer const):
- page/Chrome.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::createImageBuffer const):
- platform/HostWindow.h:
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::create):
Add a new version of ImageBuffer::create that does not directly take a RenderingMode, but instead takes the
a few pieces of information that the client layer will need to decide what kind of ImageBuffer it should create.
- platform/graphics/ImageBuffer.h:
- platform/graphics/RenderingMode.h:
Add some new enum types to represent hints provided by WebCore when it asks the client layer for a new
ImageBuffer.
Source/WebKit:
See WebCore ChangeLog for more details.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Consult the new internal feature when creating a new web process.
- Shared/WebPreferences.yaml:
Add a new internal setting to enable using the GPU process for rendering canvases.
- UIProcess/WebPageProxy.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createImageBuffer const):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::shouldUseRemoteRenderingFor):
Add a helper method that WebChromeClient can use to determine whether it should opt into either
RemoteAccelerated or RemoteUnaccelerated.
- WebProcess/WebPage/WebPage.h:
- 5:48 PM Changeset in webkit [257676] by
-
- 7 edits2 adds in trunk
Garbage collection prevents FontFace.loaded promise from getting resolved
https://bugs.webkit.org/show_bug.cgi?id=208382
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make sure the FontFace JS wrapper stays alive long enough to resolve the
loaded promise when it is observable by the page's script.
Test: fast/text/font-promises-gc.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::document const):
- css/CSSFontFace.h:
- css/FontFace.cpp:
(WebCore::FontFace::FontFace):
(WebCore::FontFace::fontStateChanged):
(WebCore::FontFace::loadForBindings):
(WebCore::FontFace::loadedForBindings):
(WebCore::FontFace::activeDOMObjectName const):
(WebCore::FontFace::hasPendingActivity const):
(WebCore::FontFace::load): Deleted.
- css/FontFace.h:
- css/FontFace.idl:
LayoutTests:
Add layout test coverage. Thanks to Alexey Proskuryakov for writing the test.
- fast/text/font-promises-gc-expected.txt: Added.
- fast/text/font-promises-gc.html: Added.
- 5:25 PM Changeset in webkit [257675] by
-
- 2 edits in trunk/Source/WebKit
[iOS 13] Crash in NetworkProcessProxy::takeUploadAssertion
https://bugs.webkit.org/show_bug.cgi?id=204796
Reviewed by Alex Christensen.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setWebProcessHasUploads):
If the network process has previously crashed, WebProcessPool::m_networkProcess may be null
when WebProcessPool::setWebProcessHasUploads() is called. As a result, we should call
ensureNetworkProcess() instead of dereferencing m_networkProcess unconditionally.
- 5:06 PM Changeset in webkit [257674] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] compositing/absolute-inside-out-of-view-fixed.html is flaky timing out and crashing.
https://bugs.webkit.org/show_bug.cgi?id=208401
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 4:58 PM Changeset in webkit [257673] by
-
- 1 copy in tags/Safari-609.1.20.4.3
Tag Safari-609.1.20.4.3.
- 4:54 PM Changeset in webkit [257672] by
-
- 3 edits in branches/safari-609.1.20.4-branch
Cherry-pick r257595. rdar://problem/59853955
[Win] Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=208330
Reviewed by Don Olmstead.
Set framework headers directory for AppleWin build.
- Source/cmake/target/TargetJavaScriptCore.cmake:
- Source/cmake/target/TargetWTF.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:54 PM Changeset in webkit [257671] by
-
- 3 edits4 adds in branches/safari-609.1.20.4-branch
Apply patch. rdar://problem/59870336
- 4:50 PM Changeset in webkit [257670] by
-
- 2 edits in branches/safari-609-branch
Cherry-pick r257288. rdar://problem/59908834
[Win] Fix AppleWin build.
https://bugs.webkit.org/show_bug.cgi?id=208164
Unreviewed build fix.
Allow a warning which happens when building with older SDKs.
- Source/cmake/OptionsMSVC.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:47 PM Changeset in webkit [257669] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208245
Unreviewed test gardenign.
- platform/ios-wk2/TestExpectations: Remove flaky expectation since the test has been fixed.
- 4:47 PM Changeset in webkit [257668] by
-
- 8 edits in branches/safari-609.1.20.4-branch/Source
Versioning.
- 4:32 PM Changeset in webkit [257667] by
-
- 21 edits in trunk/Source/WebKit
[GPUP] Implement Modern EME API in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208090
Reviewed by Alex Christensen.
IPC::SharedBufferDataReference is made more efficient by using the same encode/decode path as is used in
WebCoreArgumentCoders: the SharedBuffer is copied into shared memory, and only a handle is passed across
the XPC boundary. This requires existing users to handle receiving a IPC::SharedBufferDataHandle on the
remote side of the XPC boundary, but this is trivial, and many call sites require a SharedBuffer on the
remote side in the first place. This code could be improved by allowing the SharedMemory object be adopted
by the SharedBuffer object at creation time, potentially leading to zero-copy decoding, but is not done in
this patch.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::didReceiveSharedBuffer):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Platform/IPC/HandleMessage.h:
- Platform/IPC/SharedBufferDataReference.h:
(IPC::SharedBufferDataReference::SharedBufferDataReference):
(IPC::SharedBufferDataReference::buffer):
(IPC::SharedBufferDataReference::buffer const):
(IPC::SharedBufferDataReference::data const):
(IPC::SharedBufferDataReference::size const):
(IPC::SharedBufferDataReference::isEmpty const):
(IPC::SharedBufferDataReference::encode const):
(IPC::SharedBufferDataReference::decode):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<RefPtr<WebCore::SharedBuffer>>::encode):
(IPC::ArgumentCoder<RefPtr<WebCore::SharedBuffer>>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveSharedBuffer):
(WebKit::WebResourceLoader::didReceiveData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoadingIcon):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::drawPagesToPDF):
(WebKit::WebPage::urlSchemeTaskDidReceiveData):
(WebKit::WebPage::updateAttachmentAttributes):
- WebProcess/WebPage/WebPage.h:
- 4:18 PM Changeset in webkit [257666] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed non-unified soures builds fix.
- NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::readOrMakeSalt): Add missing namespace to FileSystem::fileExists() call.
- 4:04 PM Changeset in webkit [257665] by
-
- 1 copy in tags/Safari-609.1.20.0.8
Tag Safari-609.1.20.0.8.
- 4:03 PM Changeset in webkit [257664] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] imported/w3c/web-platform-tests/dom/nodes/Document-characterSet-normalization.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=208394
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:00 PM Changeset in webkit [257663] by
-
- 1 copy in tags/Safari-609.1.20.111.7
Tag Safari-609.1.20.111.7.
- 3:59 PM Changeset in webkit [257662] by
-
- 4 edits in trunk/Source
Clean up code with how we choose Gigacage sizes and whether or not to use Wasm fast memory
https://bugs.webkit.org/show_bug.cgi?id=208392
Reviewed by Yusuke Suzuki.
Source/bmalloc:
- bmalloc/Gigacage.h:
Source/JavaScriptCore:
- runtime/OptionsList.h:
- 3:39 PM Changeset in webkit [257661] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208396
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:20 PM Changeset in webkit [257660] by
-
- 47 edits1 copy in trunk/Source
[GPUP] Implement Modern EME API in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208090
Reviewed by Eric Carlson.
Source/WebCore:
To enable caching of certain CDM properties, allow them to be fetched rather than queries. As such,
CDMPrivate::supportsInitDataType -> supportedInitDataTypes, supportsRobustness -> supportedRobustnesses.
To enable CDM types to be passed across XPC, add explicit sizes to the enumerations, and add encode and
decode templates to the data types.
To enable async messaging form the GPU process's MediaPlayer, send the MediaPlayer the information it
needs when both legacy- and modern-EME APIs are both enabled, rather than allow the MediaPlayerPrivate
to query the MediaPlayer.
Move most of the algorithimic implementation from CDM into CDMPrivate, allowing it to be run from within
the GPU process. Similmarly, make most of the synchronous methods in CDMInstance instead take a callback
parameter, allowing them to be implemented in a remote process.
- Headers.cmake:
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::getSupportedConfiguration):
(WebCore::CDM::supportsInitDataType const):
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::update):
- Modules/encryptedmedia/MediaKeySystemAccess.cpp:
(WebCore::MediaKeySystemAccess::createMediaKeys):
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::setServerCertificate):
- Modules/encryptedmedia/MediaKeys.h:
- Modules/encryptedmedia/MediaKeys.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateShouldContinueAfterNeedKey):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::mediaEngineWasUpdated):
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::removeEventListener):
- html/HTMLMediaElement.h:
- platform/encryptedmedia/CDMEncryptionScheme.h:
- platform/encryptedmedia/CDMFactory.cpp:
(WebCore::CDMFactory::resetFactories):
- platform/encryptedmedia/CDMFactory.h:
- platform/encryptedmedia/CDMInstance.h:
- platform/encryptedmedia/CDMInstanceSession.h:
- platform/encryptedmedia/CDMKeyStatus.h:
- platform/encryptedmedia/CDMKeySystemConfiguration.h:
(WebCore::CDMKeySystemConfiguration::encode const):
(WebCore::CDMKeySystemConfiguration::decode):
- platform/encryptedmedia/CDMMediaCapability.h:
(WebCore::CDMMediaCapability::encode const):
(WebCore::CDMMediaCapability::decode):
- platform/encryptedmedia/CDMMessageType.h:
- platform/encryptedmedia/CDMPrivate.cpp:
(WebCore::CDMPrivate::getSupportedConfiguration):
(WebCore::CDMPrivate::doSupportedConfigurationStep):
(WebCore::CDMPrivate::isPersistentType):
(WebCore::CDMPrivate::getSupportedCapabilitiesForAudioVideoType):
(WebCore::CDMPrivate::getConsentStatus):
- platform/encryptedmedia/CDMPrivate.h:
- platform/encryptedmedia/CDMRequirement.h:
- platform/encryptedmedia/CDMRestrictions.h:
(WebCore::CDMRestrictions::encode const):
(WebCore::CDMRestrictions::decode):
- platform/encryptedmedia/CDMSessionType.h:
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMPrivateClearKey::supportedInitDataTypes const):
(WebCore::CDMPrivateClearKey::supportsSessionTypeWithConfiguration const):
(WebCore::CDMPrivateClearKey::supportedRobustnesses const):
(WebCore::CDMInstanceClearKey::initializeWithConfiguration):
(WebCore::CDMInstanceClearKey::setServerCertificate):
(WebCore::CDMInstanceClearKey::setStorageDirectory):
(WebCore::CDMInstanceSessionClearKey::updateLicense):
- platform/encryptedmedia/clearkey/CDMClearKey.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setShouldContinueAfterKeyNeeded):
(WebCore::MediaPlayer::keyNeeded):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setShouldContinueAfterKeyNeeded):
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMPrivateFairPlayStreaming::supportedInitDataTypes const):
(WebCore::CDMPrivateFairPlayStreaming::supportsSessionTypeWithConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportedRobustnesses const):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitData const):
- platform/graphics/avfoundation/CDMFairPlayStreaming.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::shouldWaitForLoadingOfResource):
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::sessionIdentifierChanged):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
- testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::setSupportedRobustness):
(WebCore::MockCDM::supportedInitDataTypes const):
(WebCore::MockCDM::supportedRobustnesses const):
(WebCore::MockCDM::supportsSessionTypeWithConfiguration const):
(WebCore::MockCDM::supportsInitData const):
(WebCore::MockCDMInstance::initializeWithConfiguration):
(WebCore::MockCDMInstance::setServerCertificate):
(WebCore::MockCDMInstance::setStorageDirectory):
(WebCore::MockCDMInstanceSession::updateLicense):
- testing/MockCDMFactory.h:
(WebCore::MockCDMFactory::supportedRobustness const):
Source/WebKit:
Adopt changes to MediaPlayerProxy.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerKeyNeeded):
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- WebProcess/GPU/media/WebMediaStrategy.cpp:
(WebKit::WebMediaStrategy::registerCDMFactories):
- WebProcess/GPU/media/WebMediaStrategy.h:
Source/WebKitLegacy/mac:
Adopt changes to PlatformStrategies.
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerKeyNeeded):
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- WebCoreSupport/WebPlatformStrategies.mm:
- 2:24 PM Changeset in webkit [257659] by
-
- 3 edits in trunk/Source/WebKit
macCatalyst: 'Open' context menu item doesn't work
https://bugs.webkit.org/show_bug.cgi?id=208388
<rdar://problem/59820273>
Reviewed by Wenson Hsieh.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _attemptClickAtLocation:modifierFlags:]):
(-[WKContentView _mouseGestureRecognizerChanged:]):
In r178980, a mechanism was introduced to ensure that synthetic clicks are
only dispatched to the page that the user originally touched.
macCatalyst's WKMouseGestureRecognizer unintentionally entirely bypassed
this mechanism, never setting _layerTreeTransactionIdAtLastTouchStart,
because the touch event gesture recognizer is disabled. This was generally
fine because in this case, we don't need to send synthetic clicks,
instead sending proper mouse events.
However, the "Open" context menu item works by sending a synthetic click
at the original interaction location. Since we did not set
_layerTreeTransactionIdAtLastTouchStart, the Web Content process will
ignore the click, and perform no action.
Fix this by also setting _layerTreeTransactionIdAtLastTouchStart
on mouseDown.
- 1:42 PM Changeset in webkit [257658] by
-
- 2 edits in trunk/LayoutTests
[ Mojave wk2 Debug ] fast/css-custom-paint/delay-repaint.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208390
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:39 PM Changeset in webkit [257657] by
-
- 2 edits in trunk/Source/WebCore
Clear FontDatabase when low-memory-warning happens
https://bugs.webkit.org/show_bug.cgi?id=208389
Reviewed by Chris Dumez.
FontDatabase can monotonically increase. We should clear it when low-memory-warning happens.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::platformPurgeInactiveFontData):
- 1:35 PM Changeset in webkit [257656] by
-
- 8 edits in trunk
[Curl] Add TLS debugging feature to log encryption keys
https://bugs.webkit.org/show_bug.cgi?id=208192
Patch by Takashi Komori <Takashi.Komori@sony.com> on 2020-02-28
Reviewed by Fujii Hironori.
This patch enables recording encryption keys on curl port.
When you set key log file path to environment variable SSLKEYLOGFILE on curl port, network process writes encryption keys into the path.
The key log file follows the NSS key log format and this feature is as same as Chrome and Firefox have.
See also: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format
Test: No tests for this debugging feature. We have to check manually if the log file is generate.
.:
- Source/cmake/OptionsPlayStation.cmake:
- Source/cmake/OptionsWin.cmake:
Source/WebCore:
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlContext::CurlContext):
- platform/network/curl/CurlContext.h:
(WebCore::CurlContext::shouldLogTLSKey const):
(WebCore::CurlContext::tlsKeyLogFilePath const):
- platform/network/curl/CurlSSLVerifier.cpp:
(WebCore::CurlSSLVerifier::CurlSSLVerifier):
(WebCore::CurlSSLVerifier::infoCallback):
(WebCore::CurlSSLVerifier::logTLSKey):
- platform/network/curl/CurlSSLVerifier.h:
- 1:23 PM Changeset in webkit [257655] by
-
- 4 edits in trunk/Source/WebCore
MediaResourceLoader leaks resource responses
https://bugs.webkit.org/show_bug.cgi?id=208267
Reviewed by Eric Carlson.
MediaResourceLoader leaks resource responses when browsing in Safari, even though these responses are
only used for testing. AVAssetCustomURLBridgeForNSURLSession holds on to the WebCoreNSURLSession, which
keeps the MediaResourceLoader alive, even if there is no media on the current page. In turn, the
MediaResourceLoader always keeps in memory the last 5 HTTP responses.
To address the issue, we now only record these responses when running the tests.
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::recordResponsesForTesting):
(WebCore::MediaResourceLoader::addResponseForTesting):
- loader/MediaResourceLoader.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
- 1:07 PM Changeset in webkit [257654] by
-
- 2 edits in trunk/Tools
EWS fails to retry build in case of kill-old-processes exception
https://bugs.webkit.org/show_bug.cgi?id=208003
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(KillOldProcesses.evaluateCommand):
(KillOldProcesses.getResultSummary):
- 12:23 PM Changeset in webkit [257653] by
-
- 2 edits in trunk/Tools
[ews] commit-queue should update the ChangeLog with Reviewer name
https://bugs.webkit.org/show_bug.cgi?id=206535
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(ApplyPatch.start): Update the patch with the patch reviewer name if available.
- 12:21 PM Changeset in webkit [257652] by
-
- 7 edits in trunk/LayoutTests
Deflake animations/font-variations tests
https://bugs.webkit.org/show_bug.cgi?id=208383
Reviewed by Ryosuke Niwa.
Use document.fonts.ready to work around https://bugs.webkit.org/show_bug.cgi?id=208382,
and to simplify the tests.
- animations/font-variations/font-stretch.html:
- animations/font-variations/font-style.html:
- animations/font-variations/font-variation-settings-order.html:
- animations/font-variations/font-variation-settings-unlike.html:
- animations/font-variations/font-variation-settings.html:
- animations/font-variations/font-weight.html:
- 12:11 PM Changeset in webkit [257651] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208245
<rdar://problem/59856625>
The test was still actually passing, it was just displaying differently.
Change the test to be more robust.
Unreviewed test gardening.
- fast/text-autosizing/ios/idempotentmode/viewport-change-relayout-expected.html: Removed.
- fast/text-autosizing/ios/idempotentmode/viewport-change-relayout-expected.txt: Added.
- fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html:
- 11:57 AM Changeset in webkit [257650] by
-
- 3 edits in trunk/Source/WebKit
[iOS] Remove access to the "com.apple.lsd.open" mach service from the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=207708
<rdar://problem/56995506>
Reviewed by Per Arne Vollan.
Now that we dynamically create the sandbox extension to the 'com.apple.lsd.open' mach service,
we can remove the global allow rule from the sandbox.
Reviewed by Per Arne Vollan.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 11:55 AM Changeset in webkit [257649] by
-
- 2 edits in trunk
Fix issue in cmake build for checking ccache
https://bugs.webkit.org/show_bug.cgi?id=208377
Reviewed by Carlos Alberto Lopez Perez.
If either of the "readlink" or "which" commands fail when looking for the ccache prefix
the output variables will be empty and an invalid expression will be provided to CMake.
e.g. we will get something like:
if ("0" "EQUAL" "0" "AND" "1" "EQUAL" "0" "AND" "STREQUAL" "/usr/local/bin/ccache")
The fix is to wrap the output variables in the quotes when unboxing them in the if.
- Source/cmake/WebKitCCache.cmake:
- 11:43 AM Changeset in webkit [257648] by
-
- 13 edits in trunk/Source
Convert frame address in logging statements to pageID+frameID
https://bugs.webkit.org/show_bug.cgi?id=208325
<rdar://problem/59850768>
Reviewed by Alex Christensen.
Some old logging prints the address of the associated frame object.
Annotating logging statements this way makes it difficult to match up
that logging with other logging that uses pageID+frameID. Update the
logging to consistently use the latter format.
Source/WebCore:
No new tests -- no new or changed functionality.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setRequest):
(WebCore::DocumentLoader::setMainDocumentError):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::tryLoadingSubstituteData):
(WebCore::DocumentLoader::disallowDataRequest const):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::loadMainResource):
(WebCore::DocumentLoader::cancelMainResourceLoad):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::pageID const):
(WebCore::FrameLoader::frameID const):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
- loader/FrameLoader.h:
- loader/ResourceLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/Frame.cpp:
(WebCore::Frame::pageID const):
(WebCore::Frame::frameID const):
- page/Frame.h:
- page/FrameView.cpp:
Source/WebKit:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResource):
- 11:31 AM Changeset in webkit [257647] by
-
- 3 edits1 add in trunk/Tools
run-javascriptcore-tests: Make upload format valid
https://bugs.webkit.org/show_bug.cgi?id=208341
Rubber-stamped by Aakash Jain.
- Scripts/run-javascriptcore-tests:
(uploadResults): Remove. FIXME.
- Scripts/webkitdirs.pm:
(splitVersionString): Handle case where the subminor version number has a - in it.
- Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
- 11:29 AM Changeset in webkit [257646] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] imported/w3c/web-platform-tests/requestidlecallback/callback-timeout-when-busy.html is flakey failing.
https://bugs.webkit.org/show_bug.cgi?id=208384
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 11:23 AM Changeset in webkit [257645] by
-
- 10 edits in trunk/Source
Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
https://bugs.webkit.org/show_bug.cgi?id=208358
Reviewed by Tim Horton.
We used -[CAlayer setValue:forKey:@"WKPlatformCALayer"] to store associate PlatformCALayer*
with CALayers. However, this has some performance cost, and won't work for a near-future world
where the scrolling thread needs to get at PlatformCALayers.
Replace with a static HashMap<> of CALayer* to PlatformCALayer*. Also rename platformCALayer()
to platformCALayerForLayer() so it's easier to find.
Source/WebCore:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsToPlatformLayer):
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::layerToPlatformLayerMap):
(WebCore::PlatformCALayer::platformCALayerForLayer):
(WebCore::PlatformCALayerCocoa::create):
(WebCore::PlatformCALayerCocoa::commonInit):
(WebCore::PlatformCALayerCocoa::~PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::superlayer const):
(WebCore::PlatformCALayer::platformCALayer): Deleted.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::platformCALayerForLayer):
(layoutSublayersProc):
(PlatformCALayerWin::superlayer const):
(PlatformCALayer::platformCALayer): Deleted.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::getSublayers const):
(PlatformCALayerWinInternal::sublayerAtIndex const):
- platform/graphics/cocoa/WebGLLayer.mm:
(-[WebGLLayer display]):
- platform/graphics/mac/WebLayer.mm:
(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplay]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):
(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):
Source/WebKitLegacy/win:
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
(FullscreenVideoController::enterFullscreen):
- 11:18 AM Changeset in webkit [257644] by
-
- 8 edits in trunk/Source
No port uses USE_NATIVE_FULLSCREEN_VIDEO, remove it
https://bugs.webkit.org/show_bug.cgi?id=208378
<rdar://problem/59892497>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, unused code removed.
- dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::willEnterFullscreen):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen): Deleted.
(WebCore::MediaPlayer::exitFullscreen): Deleted.
(WebCore::MediaPlayer::canEnterFullscreen const): Deleted.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen): Deleted.
(WebCore::MediaPlayerPrivateInterface::exitFullscreen): Deleted.
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen const): Deleted.
Source/WebKit:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setClosedCaptionsVisible):
(WebKit::MediaPlayerPrivateRemote::enterFullscreen): Deleted.
(WebKit::MediaPlayerPrivateRemote::exitFullscreen): Deleted.
(WebKit::MediaPlayerPrivateRemote::canEnterFullscreen const): Deleted.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- 11:12 AM Changeset in webkit [257643] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Unblock read access to aes_0 device
https://bugs.webkit.org/show_bug.cgi?id=208344
<rdar://problem/59746108>
Reviewed by Alexey Proskuryakov.
Logging needs access to /dev/aes_0 to generate random identifiers. We should unblock this service.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 10:49 AM Changeset in webkit [257642] by
-
- 11 edits in trunk
[MacOS/iOS] Enable audio/video capture in GPUProcess by default
https://bugs.webkit.org/show_bug.cgi?id=208130
Reviewed by Eric Carlson.
Source/WebKit:
Covered by existing tests.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.h:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::cloneVideoSource):
Make sure to select the process of the source to clone it.
Tools:
- WebKitTestRunner/TestOptions.h:
Use GPU process to capture by default.
We will remove this option once done verifying that every test works smoothly.
LayoutTests:
Disable video capture in GPUProcess as cloning mechanism does not work well with the idea of a single video or audio source in a process.
A follow-up patch should fix this.
- fast/mediastream/MediaStream-clone.html:
- fast/mediastream/MediaStreamTrack-clone.html:
- fast/mediastream/mediastreamtrack-video-clone.html:
- webrtc/multi-video.html:
- 10:14 AM Changeset in webkit [257641] by
-
- 2 edits in trunk/Source/WebCore
Regression r257612: Windows build broken
https://bugs.webkit.org/show_bug.cgi?id=208372
<rdar://problem/59885001>
Unreviewed Windows build fix.
- platform/graphics/InbandGenericCue.cpp:
(WebCore::InbandGenericCue::toJSONString const):
- 9:33 AM Changeset in webkit [257640] by
-
- 2 edits in trunk/Source/WebCore
updateCSSTransitionsForElementAndProperty should clone RenderStyles
https://bugs.webkit.org/show_bug.cgi?id=208356
rdar://59869560
Reviewed by Antti Koivisto.
Make ownership of the local variable clear by cloning the RenderStyles
used in updateCSSTransitionsForElementAndProperty rather than referencing
different versions.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
- 8:47 AM Changeset in webkit [257639] by
-
- 3 edits in trunk/Source/WebCore
Retain cycle between CSSFontSelector -> CSSFontFaceSet -> CSSFontFace -> CSSFontSelector
https://bugs.webkit.org/show_bug.cgi?id=196437
<rdar://problem/46598332>
Reviewed by Alex Christensen.
Break the reference cycle using a WeakPtr. The leak was reproducible by browsing CNN.com
and then navigating to about:blank (those objects would stay around, even after memory
pressure signal).
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::fontLoadEventOccurred):
- css/CSSFontFace.h:
- 7:48 AM Changeset in webkit [257638] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Unreviewed. Fix unused parameter warning
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::getRawCookies const):
- 7:21 AM Changeset in webkit [257637] by
-
- 4 edits in trunk/Source/WebCore
Shrink-to-fit Display::LineBox/Display::Run vectors.
https://bugs.webkit.org/show_bug.cgi?id=208343
Reviewed by Antti Koivisto.
From the collected data in PLT5, 95% of Runs / LineBoxes are <= 4, while we are having 10 and 5 inlineCapacity.
We adjust this inlineCapacity to 4 based on this number. It also covers almost all of Speedometer2.0 content (in it, 99.9% is 1).
We also callshrinkToFitto make it the exact size after baking Display::InlineContent. It should be no-op in 95% cases.
- layout/displaytree/DisplayInlineContent.h:
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
- 6:11 AM Changeset in webkit [257636] by
-
- 3 edits in trunk/Tools
[ews] commit queue should skip building and testing for rollout patches
https://bugs.webkit.org/show_bug.cgi?id=208329
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
(CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
(RunWebKit1Tests.doStepIf): Ditto.
- BuildSlaveSupport/ews-build/steps_unittest.py:
(TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
(TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
- 5:32 AM Changeset in webkit [257635] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Unreviewed. Fix build warning.
queueSize is of type size_t so it should use the proper format
specifier.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(restartLoaderIfNeeded):
(stopLoaderIfNeeded):
- 5:01 AM Changeset in webkit [257634] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208371
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 3:28 AM Changeset in webkit [257633] by
-
- 9 edits in trunk/Source
Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
https://bugs.webkit.org/show_bug.cgi?id=208240
Reviewed by Eric Carlson.
Source/WebCore:
Update RemoteVideoSample to have surface getter be const.
Add a new routine to convert a RemoteVideoSample in a MediaSample, with proper rotation and mirrored information.
Covered by manual testing.
- platform/graphics/RemoteVideoSample.cpp:
(WebCore::RemoteVideoSample::surface const):
- platform/graphics/RemoteVideoSample.h:
(WebCore::RemoteVideoSample::mirrored const):
- platform/graphics/cv/ImageTransferSessionVT.h:
- platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::createMediaSample):
Source/WebKit:
Use new routine that preserves rotation.
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSample):
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::remoteVideoSampleAvailable):
- 2:55 AM Changeset in webkit [257632] by
-
- 144 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaseline tests after fixes for new style regressions
- platform/gtk/TestExpectations:
- platform/gtk/css3/flexbox/button-expected.png:
- platform/gtk/css3/flexbox/button-expected.txt:
- platform/gtk/editing/selection/3690703-2-expected.png:
- platform/gtk/editing/selection/3690703-2-expected.txt:
- platform/gtk/editing/selection/3690703-expected.png:
- platform/gtk/editing/selection/3690703-expected.txt:
- platform/gtk/editing/selection/3690719-expected.png:
- platform/gtk/editing/selection/3690719-expected.txt:
- platform/gtk/editing/selection/4397952-expected.png:
- platform/gtk/editing/selection/4397952-expected.txt:
- platform/gtk/editing/selection/5240265-expected.png:
- platform/gtk/editing/selection/5240265-expected.txt:
- platform/gtk/editing/selection/selection-button-text-expected.png:
- platform/gtk/editing/selection/selection-button-text-expected.txt:
- platform/gtk/fast/block/float/float-avoidance-expected.png:
- platform/gtk/fast/block/float/float-avoidance-expected.txt:
- platform/gtk/fast/css/continuationCrash-expected.png:
- platform/gtk/fast/css/continuationCrash-expected.txt:
- platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/gtk/fast/css/non-standard-checkbox-size-expected.png:
- platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
- platform/gtk/fast/css/rtl-ordering-expected.png:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/gtk/fast/forms/001-expected.png:
- platform/gtk/fast/forms/001-expected.txt:
- platform/gtk/fast/forms/basic-buttons-expected.png:
- platform/gtk/fast/forms/basic-buttons-expected.txt:
- platform/gtk/fast/forms/basic-selects-expected.png:
- platform/gtk/fast/forms/basic-selects-expected.txt:
- platform/gtk/fast/forms/blankbuttons-expected.png:
- platform/gtk/fast/forms/blankbuttons-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.png:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/button-positioned-expected.png:
- platform/gtk/fast/forms/button-positioned-expected.txt:
- platform/gtk/fast/forms/button-sizes-expected.png:
- platform/gtk/fast/forms/button-sizes-expected.txt:
- platform/gtk/fast/forms/button-style-color-expected.png:
- platform/gtk/fast/forms/button-style-color-expected.txt:
- platform/gtk/fast/forms/button-table-styles-expected.png:
- platform/gtk/fast/forms/button-table-styles-expected.txt:
- platform/gtk/fast/forms/button-text-transform-expected.png:
- platform/gtk/fast/forms/button-text-transform-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.png:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/file/file-input-direction-expected.png:
- platform/gtk/fast/forms/file/file-input-direction-expected.txt:
- platform/gtk/fast/forms/file/file-input-disabled-expected.png:
- platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.png:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.png:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.png:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-button-sizes-expected.png:
- platform/gtk/fast/forms/input-button-sizes-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/targeted-frame-submission-expected.png:
- platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
- platform/gtk/fast/html/details-replace-summary-child-expected.png:
- platform/gtk/fast/html/details-replace-summary-child-expected.txt:
- platform/gtk/fast/html/details-replace-text-expected.png:
- platform/gtk/fast/html/details-replace-text-expected.txt:
- platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/gtk/fast/overflow/scrollRevealButton-expected.png:
- platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-expected.png:
- platform/gtk/fast/replaced/replaced-breaking-expected.txt:
- platform/gtk/fast/replaced/width100percent-button-expected.png:
- platform/gtk/fast/replaced/width100percent-button-expected.txt:
- platform/gtk/fast/replaced/width100percent-checkbox-expected.png:
- platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
- platform/gtk/fast/replaced/width100percent-radio-expected.png:
- platform/gtk/fast/replaced/width100percent-radio-expected.txt:
- platform/gtk/fast/text/international/hindi-spacing-expected.png:
- platform/gtk/fast/text/international/hindi-spacing-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/svg/custom/foreign-object-skew-expected.png:
- platform/gtk/svg/custom/foreign-object-skew-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
- platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
- platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/gtk/tables/mozilla/dom/tableDom-expected.png:
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
- platform/gtk/tables/mozilla/other/move_row-expected.png:
- platform/gtk/tables/mozilla/other/move_row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- 1:57 AM Changeset in webkit [257631] by
-
- 8 edits in trunk/Source/WebCore
REGRESSION(r257299): [GTK] Test imported/w3c/web-platform-tests/css/css-sizing/button-min-width.html is failing since r257299
https://bugs.webkit.org/show_bug.cgi?id=208296
Reviewed by Adrian Perez de Castro.
We are no longer honoring the style min width/height of buttons.
- platform/Theme.cpp:
(WebCore::Theme::minimumControlSize const): Add zoomedSize parameter.
- platform/Theme.h:
- platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::minimumControlSize const): Use the style min size unless it's intrinsic or auto.
- platform/adwaita/ThemeAdwaita.h:
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::minimumControlSize const): Add zoomedSize parameter.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle): Pass style min size to Theme::minimumControlSize().
- 1:37 AM Changeset in webkit [257630] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r257299): [GTK] Check and radio buttons don't keep the aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=208302
Reviewed by Adrian Perez de Castro.
When different width and height is used, we should use the lower value and render the button centered.
- platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::paintCheckbox):
(WebCore::ThemeAdwaita::paintRadio):
- 1:36 AM Changeset in webkit [257629] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r257299): [GTK] Test fast/replaced/table-percent-height.html is failing since r257299
https://bugs.webkit.org/show_bug.cgi?id=208295
Reviewed by Adrian Perez de Castro.
We are now hardcoding the size of check and radio buttons, except when width and height are both specified.
- platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::controlSize const): Only set width and height of check and radio buttons when they are
intrinsic or auto.
- 1:33 AM Changeset in webkit [257628] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r257299): [GTK] Test fast/forms/menulist-restrict-line-height.html is failing since r257299
https://bugs.webkit.org/show_bug.cgi?id=208241
Reviewed by Adrian Perez de Castro.
We should not honor line-height for styled combo buttons.
- rendering/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::adjustMenuListStyle const):
(WebCore::RenderThemeAdwaita::adjustMenuListButtonStyle const):
- rendering/RenderThemeAdwaita.h:
- 1:31 AM Changeset in webkit [257627] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r257299): [GTK] box shadow is no longer ignored for search field decorations
https://bugs.webkit.org/show_bug.cgi?id=208239
Reviewed by Adrian Perez de Castro.
Since we no longer use RenderTheme to paint the search field decorations we need to ensure a box shadow isn't
used for them in the CSS.
- css/themeAdwaita.css:
(input[type="search"]::-webkit-search-results-button,): Add -webkit-box-shadow: none !important;
(input[type="search"]::-webkit-search-cancel-button): Ditto.
(body[dir="rtl"] input[type="search"]::-webkit-search-cancel-button): Ditto.
- 1:30 AM Changeset in webkit [257626] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r257299): Test fast/css/button-height.html is failing since r257299
https://bugs.webkit.org/show_bug.cgi?id=208237
Reviewed by Adrian Perez de Castro.
The new theming code doesn't use the same border size for button and input[type="button"].
- platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::controlBorder const): Use the same border for all buttons.
- platform/adwaita/ThemeAdwaita.h:
- 1:26 AM Changeset in webkit [257625] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix hover effects broken for GTK port after r257592
Add missing braces to if that now has two lines in the body. This was causing all mouse events to be considered
read only when building with TOUCH_EVENTS enabled.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
- 12:50 AM Changeset in webkit [257624] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Remove platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html
This tested the behavior of spin buttons with the old GTK theming code.
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Removed.
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Removed.
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html: Removed.
- 12:48 AM Changeset in webkit [257623] by
-
- 5 edits in trunk
Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=190613
Reviewed by Wenson Hsieh.
Source/WebCore:
Check the input is a range control before trying to paint slider ticks.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
LayoutTests:
Remove test expectations.
- TestExpectations:
- platform/gtk/TestExpectations:
- 12:44 AM Changeset in webkit [257622] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r257411): Web Inspector: Can't add a breakpoint by pressing the plus button
https://bugs.webkit.org/show_bug.cgi?id=208359
<rdar://problem/59870712>
Reviewed by Brian Burg.
In r257411 I added event.stop() (which is a shortcut for event.preventDefault() and
event.stopImmediatePropagation()) to mousedown handler. Calling event.stopImmediatePropagation()
prevented other mousedown event handlers from running.
This patch no longer calls event.stopImmediatePropagation().
- UserInterface/Views/ButtonNavigationItem.js:
(WI.ButtonNavigationItem.prototype._handleMouseDown):
- 12:33 AM Changeset in webkit [257621] by
-
- 3 edits in trunk/Tools
Update my watch list preferences and contributor's entry.
- Scripts/webkitpy/common/config/contributors.json:
- Scripts/webkitpy/common/config/watchlist:
Feb 27, 2020:
- 11:56 PM Changeset in webkit [257620] by
-
- 10 edits in trunk/Source
Web Inspector: allow use of dark mode theme independently from system-wide theme
https://bugs.webkit.org/show_bug.cgi?id=186308
<rdar://problem/40785895>
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setForcedAppearance): Added.
Expose a way to callPage::setUseDarkAppearanceOverridefrom the Web Inspector frontend.
Source/WebInspectorUI:
- UserInterface/Base/Setting.js:
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Create a setting for controlling/preserving the theme of the frontend UI.
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
Apply the created setting when Web Inspector is opened or if its value changes.
- UserInterface/Views/SettingEditor.js:
(WI.SettingEditor.prototype._createEditorElement):
Allow horizontal dividers in<select>setting editors.
- Localizations/en.lproj/localizedStrings.js:
- 10:25 PM Changeset in webkit [257619] by
-
- 21 edits4 deletes in trunk
Fix WebCore export macros for declspec
https://bugs.webkit.org/show_bug.cgi?id=208363
Reviewed by Konstantin Tokarev.
Source/WebCore:
Modified the PlatformExportMacros to match the other export macros. Originally
Windows ports were treated differently and they had to set their own export macros.
This isn't ideal because how WebCore is built is really dependent on the CMake
definition of the library type.
- CMakeLists.txt:
- WebCorePrefix.h:
- platform/PlatformExportMacros.h:
- testing/js/WebCoreTestSupportPrefix.h:
Source/WebKit:
Add compilation definitions for static linking of PAL and WebCore in WebKit.
- PlatformFTW.cmake:
- PlatformWin.cmake:
- config.h:
Source/WebKitLegacy:
Add compilation definitions for static linking of PAL and WebCore in WebKitLegacy.
- PlatformFTW.cmake:
- PlatformWin.cmake:
Source/WebKitLegacy/win:
Remove setting of WEBCORE_EXPORT from the header files.
- WebKitPrefix.h:
Tools:
Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
files. Removed precompiled headers that were empty.
- DumpRenderTree/DumpRenderTreePrefix.h:
- DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
- MiniBrowser/win/stdafx.h:
- TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
- TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
- WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
- WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
- WebKitTestRunner/PlatformFTW.cmake:
- WebKitTestRunner/PlatformWin.cmake:
- WebKitTestRunner/WebKitTestRunnerPrefix.h:
- 10:21 PM Changeset in webkit [257618] by
-
- 4 edits in trunk
UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
https://bugs.webkit.org/show_bug.cgi?id=208365
Reviewed by Alex Christensen.
Source/WebKit:
New test: WKWebView.PrepareForMoveToWindowCrashAfterNotMovingToWindow
- UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver setWindowToObserve:]):
(WebKit::WebViewImpl::viewWillMoveToWindow):
Two small changes to make WKWindowVisibilityObserver safer to use, which
fix the aforementioned bug:
- Instead of exposing startObserving/stopObserving and making clients
be careful about pairing them, and remembering which window to stopObserving,
just add "setWindowToObserve", and keep track (weakly) of the current
NSWindow being observed. This avoids double-adding observers.
- Always stopObserving when WKWindowVisibilityObserver is deallocated.
In the "normal" case, WKWebView will always be removed from the view
hierarchy before it is deallocated (and thus before the
WKWindowVisibilityObserver is deallocated), because otherwise its superview
holds a reference to it. But in the _prepareForMoveToWindow case, we do
not have this guarantee, and can end up deallocating the WKWebView without
getting a willMoveToWindow:nil. Make sure to clean up the observers in
that case, if the window is still around, otherwise when NSWindow sends
notifications, it will try to message a deallocated WKWebView.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
(TEST):
Add a test! It was a 100% repro crash before this change.
- 9:53 PM Changeset in webkit [257617] by
-
- 2 edits in trunk/Source/WebCore
MemoryRelease logging uses a unique_ptr with unclear lifetime
https://bugs.webkit.org/show_bug.cgi?id=208361
Reviewed by Alex Christensen.
The logging here was getting a unique_ptr inside the loop, which
causes newer versions of clang to complain with an error:
object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling-gsl]
Using a temporary local variable fixes the problem.
- page/MemoryRelease.cpp:
(WebCore::logMemoryStatisticsAtTimeOfDeath):
- 8:15 PM Changeset in webkit [257616] by
-
- 3 edits2 adds in trunk
Hit test with clipPath referencing parent element causes infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=208279
Patch by Doug Kelly <Doug Kelly> on 2020-02-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add an early return for SVG hit tests which have a child element referencing a parent clipPath.
This change breaks the cycle, although it unfortunately runs on every hit test, for each node which
is a child of the clipPath element.
Test: svg/hittest/svg-clip-path-child-element.html
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
LayoutTests:
- svg/hittest/svg-clip-path-child-element-expected.txt: Added.
- svg/hittest/svg-clip-path-child-element.html: Added.
- 7:50 PM Changeset in webkit [257615] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Remove logging for sysctl access to properties used by NSURLSession
https://bugs.webkit.org/show_bug.cgi?id=208346
<rdar://problem/59862967>
Reviewed by Alexey Proskuryakov.
Telemetry and logging indicate that two sysctl calls are needed by [NSURLSession sessionWithConfiguration].
We no longer need to log these well understood uses.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 7:43 PM Changeset in webkit [257614] by
-
- 19 edits2 adds in trunk/Tools
TestWebKitAPI and WebKitTestRunner should have bundle identifiers
https://bugs.webkit.org/show_bug.cgi?id=208260
<rdar://problem/59820107>
Reviewed by Tim Horton.
Followed instructions for adding an Info.plist for Single-File Tools
found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
The default WebsiteDataStore file path will change with this test to
reflect the new bundleID so we must change expectations for any api
tests which rely on knowing the path.
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
(TEST):
(defaultWebsiteCacheDirectory):
- TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
(TEST):
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::resetTestState):
Now that we set a bundleID, we have to reset the cache model between
tests, otherwise it gets stored between tests.
(TestWebKitAPI::TEST):
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 7:37 PM Changeset in webkit [257613] by
-
- 5 edits in trunk
TextManipulationController should not generate a new item for content in manipulated paragraphs
https://bugs.webkit.org/show_bug.cgi?id=208286
Reviewed by Wenson Hsieh.
Source/WebCore:
This patch makes TextManipulationController to ignore any content change in previously manipulated paragraphs.
Added an early exist to observeParagraphs when the observed content has an element that has already been manipulated
as an ancestor. Note that the only case in which this logic matters is when it's called by scheduleObservartionUpdate,
which calls this function on each paragraph separately, unlike startObservingParagraphs which calls it on
the entire document, we can simply exit early instead of ignoring just the current paragraph.
Renamed TextManipulationController's m_recentlyInsertedElements to m_manipulatedElements and made it persist
forever so that we can track any element that has already been manipulated. Als renamed m_mutatedElements
to m_elementsWithNewRenderer for clarity.
Test: TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::isInManipulatedElement): Added. Has a fast path for when
m_manipulatedElements's capacity is 0, which happens when observeParagraphs is called by startObservingParagraphs.
(WebCore::TextManipulationController::observeParagraphs): Added an early exit when there is a content that has
already been manipulated.
(WebCore::TextManipulationController::didCreateRendererForElement): Added the same check to fail early.
(WebCore::TextManipulationController::scheduleObservartionUpdate):
(WebCore::TextManipulationController::replace): Removed the code to clear m_recentlyInsertedElements.
- editing/TextManipulationController.h:
Tools:
Added a regression test.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
- 7:05 PM Changeset in webkit [257612] by
-
- 23 edits3 adds in trunk
Support in-band generic cues when loading media in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208080
<rdar://problem/59687943>
Reviewed by Youenn Fablet.
Source/WebCore:
No new tests, existing tests enabled for GPU process.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- html/track/InbandGenericTextTrack.cpp:
(WebCore::GenericTextTrackCueMap::add):
(WebCore::GenericTextTrackCueMap::findIndexOfPair):
(WebCore::GenericTextTrackCueMap::find):
(WebCore::GenericTextTrackCueMap::remove):
(WebCore::InbandGenericTextTrack::updateCueFromCueData):
(WebCore::InbandGenericTextTrack::addGenericCue):
(WebCore::InbandGenericTextTrack::updateGenericCue):
(WebCore::InbandGenericTextTrack::removeGenericCue):
- html/track/InbandGenericTextTrack.h:
- html/track/InbandTextTrack.h:
- html/track/TextTrackCueGeneric.h:
- platform/graphics/InbandGenericCue.h: Added.
(WebCore::GenericCueData::decode):
(WebCore::GenericCueData::encode const):
(WebCore::InbandGenericCue::create):
(WebCore::InbandGenericCue::startTime const):
(WebCore::InbandGenericCue::setStartTime):
(WebCore::InbandGenericCue::endTime const):
(WebCore::InbandGenericCue::setEndTime):
(WebCore::InbandGenericCue::id const):
(WebCore::InbandGenericCue::setId):
(WebCore::InbandGenericCue::content const):
(WebCore::InbandGenericCue::setContent):
(WebCore::InbandGenericCue::line const):
(WebCore::InbandGenericCue::setLine):
(WebCore::InbandGenericCue::position const):
(WebCore::InbandGenericCue::setPosition):
(WebCore::InbandGenericCue::size const):
(WebCore::InbandGenericCue::setSize):
(WebCore::InbandGenericCue::align const):
(WebCore::InbandGenericCue::setAlign):
(WebCore::InbandGenericCue::fontName const):
(WebCore::InbandGenericCue::setFontName):
(WebCore::InbandGenericCue::baseFontSize const):
(WebCore::InbandGenericCue::setBaseFontSize):
(WebCore::InbandGenericCue::relativeFontSize const):
(WebCore::InbandGenericCue::setRelativeFontSize):
(WebCore::InbandGenericCue::foregroundColor const):
(WebCore::InbandGenericCue::setForegroundColor):
(WebCore::InbandGenericCue::backgroundColor const):
(WebCore::InbandGenericCue::setBackgroundColor):
(WebCore::InbandGenericCue::highlightColor const):
(WebCore::InbandGenericCue::setHighlightColor):
(WebCore::InbandGenericCue::status):
(WebCore::InbandGenericCue::setStatus):
(WebCore::InbandGenericCue::cueData const):
(WebCore::InbandGenericCue::InbandGenericCue):
(WebCore::InbandGenericCue::toJSONString const):
(WebCore::InbandGenericCue::doesExtendCueData const):
(WTF::LogArgument<WebCore::InbandGenericCue>::toString):
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::create): Deleted.
(WebCore::GenericCueData::startTime const): Deleted.
(WebCore::GenericCueData::setStartTime): Deleted.
(WebCore::GenericCueData::endTime const): Deleted.
(WebCore::GenericCueData::setEndTime): Deleted.
(WebCore::GenericCueData::id const): Deleted.
(WebCore::GenericCueData::setId): Deleted.
(WebCore::GenericCueData::content const): Deleted.
(WebCore::GenericCueData::setContent): Deleted.
(WebCore::GenericCueData::line const): Deleted.
(WebCore::GenericCueData::setLine): Deleted.
(WebCore::GenericCueData::position const): Deleted.
(WebCore::GenericCueData::setPosition): Deleted.
(WebCore::GenericCueData::size const): Deleted.
(WebCore::GenericCueData::setSize): Deleted.
(): Deleted.
(WebCore::GenericCueData::align const): Deleted.
(WebCore::GenericCueData::setAlign): Deleted.
(WebCore::GenericCueData::fontName const): Deleted.
(WebCore::GenericCueData::setFontName): Deleted.
(WebCore::GenericCueData::baseFontSize const): Deleted.
(WebCore::GenericCueData::setBaseFontSize): Deleted.
(WebCore::GenericCueData::relativeFontSize const): Deleted.
(WebCore::GenericCueData::setRelativeFontSize): Deleted.
(WebCore::GenericCueData::foregroundColor const): Deleted.
(WebCore::GenericCueData::setForegroundColor): Deleted.
(WebCore::GenericCueData::backgroundColor const): Deleted.
(WebCore::GenericCueData::setBackgroundColor): Deleted.
(WebCore::GenericCueData::highlightColor const): Deleted.
(WebCore::GenericCueData::setHighlightColor): Deleted.
(WebCore::GenericCueData::status): Deleted.
(WebCore::GenericCueData::setStatus): Deleted.
(WebCore::GenericCueData::toJSONString const): Deleted.
(WebCore::GenericCueData::doesExtendCueData const): Deleted.
(WTF::LogArgument<WebCore::GenericCueData>::toString): Deleted.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
Source/WebKit:
- GPUProcess/media/RemoteTextTrackProxy.cpp:
(WebKit::RemoteTextTrackProxy::addGenericCue):
(WebKit::RemoteTextTrackProxy::updateGenericCue):
(WebKit::RemoteTextTrackProxy::removeGenericCue):
- GPUProcess/media/RemoteTextTrackProxy.h:
- Scripts/webkit/messages.py:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::addGenericCue):
(WebKit::MediaPlayerPrivateRemote::updateGenericCue):
(WebKit::MediaPlayerPrivateRemote::removeGenericCue):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
- WebProcess/GPU/media/TextTrackPrivateRemote.cpp:
(WebKit::TextTrackPrivateRemote::addGenericCue):
(WebKit::TextTrackPrivateRemote::updateGenericCue):
(WebKit::TextTrackPrivateRemote::removeGenericCue):
- WebProcess/GPU/media/TextTrackPrivateRemote.h:
LayoutTests:
- gpu-process/TestExpectations:
- 6:44 PM Changeset in webkit [257611] by
-
- 9 edits in trunk
[iOS] Issue mach sandbox extensions to the WebContent process for a set of specific services
https://bugs.webkit.org/show_bug.cgi?id=208146
Reviewed by Brent Fulgham.
Source/WebKit:
We are still seeing some accesses from the WebContent process to a small set of services. Since we do not currently have
backtraces for these accesses, make a speculative patch, where we issue these extension for all apps except Safari.
Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup-mail.html:
- 6:41 PM Changeset in webkit [257610] by
-
- 19 edits in trunk/Source/WebKit
[iOS] The GPU process never runs as a foreground process
https://bugs.webkit.org/show_bug.cgi?id=208250
Reviewed by Chris Dumez.
Currently, the GPU process always runs in the background, and never goes into the foreground mode, which is required for media
playback on iOS. This is addressed by creating a layer in the GPU process, whose context ID is used to create a visibility
propagation view in the UI process. This is done in the same way as it is done for the WebContent process. This makes it
possible for the system to determine the visibility of the GPU process. In addition, create foreground process assertions
when media is being played.
No new tests, covered by existing tests.
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
- GPUProcess/GPUProcess.h:
- GPUProcess/ios/GPUProcessIOS.mm:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didCreateContextInGPUProcessForVisibilityPropagation):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::GPUProcessProxy::openGPUProcessConnection):
(WebKit::GPUProcessProxy::didCreateContextForVisibilityPropagation):
(WebKit::GPUProcessProxy::contextIDForVisibilityPropagation const):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/GPU/GPUProcessProxy.messages.in:
- UIProcess/PageClient.h:
(WebKit::PageClient::didCreateContextInGPUProcessForVisibilityPropagation):
(WebKit::PageClient::gpuProcessCrashed):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::gpuProcessCrashed):
(WebKit::WebProcessPool::setWebProcessIsPlayingAudibleMedia):
(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::gpuProcessCrashed):
(WebKit::WebProcessProxy::didCreateContextInGPUProcessForVisibilityPropagation):
- UIProcess/WebProcessProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didCreateContextInGPUProcessForVisibilityPropagation):
(WebKit::PageClientImpl::gpuProcessCrashed):
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView _setupVisibilityPropagationViewForGPUProcess]):
(-[WKContentView _removeVisibilityPropagationViewForGPUProcess]):
(-[WKContentView _gpuProcessCrashed]):
(-[WKContentView _gpuProcessDidCreateContextForVisibilityPropagation]):
- 6:27 PM Changeset in webkit [257609] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix debug arm64 Wasm tests
https://bugs.webkit.org/show_bug.cgi?id=208362
Reviewed by Yusuke Suzuki.
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::emitChecksForModOrDiv):
We were assuming that "-1" is a valid imm on arm64, but it's not, we need
to use big imm.
- 5:46 PM Changeset in webkit [257608] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r257391-257396): [ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order.html is failing
https://bugs.webkit.org/show_bug.cgi?id=208323
Unreviewed test gardening.
scroll-restoration-order.html has always failed on iOS. Before r257394, we didn't properly
restore the scroll position before the hashchange event. After r257394, we now properly
restore the scroll position, but do it too early (it's restored before popstate, rather than
between popstate and hashchange). If anything, the new state seems less broken than before,
so this just updates the expected results to reflect the current status of our tests.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order-expected.txt:
- 5:42 PM Changeset in webkit [257607] by
-
- 2 edits3 deletes in trunk/LayoutTests
[GTK] Layout test gardening
https://bugs.webkit.org/show_bug.cgi?id=208360
Unreviewed test gardening.
Removed some deprecated baselines after new form styles.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt: Removed.
- platform/gtk/fast/forms/input-number-click-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Removed.
- 5:35 PM Changeset in webkit [257606] by
-
- 13 edits3 copies5 adds in trunk/Source
Implement ImageBuffer shareable backends
https://bugs.webkit.org/show_bug.cgi?id=207233
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-02-27
Reviewed by Simon Fraser.
Source/WebCore:
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/PlatformImageBufferBackend.h: Added.
Define the base ImageBufferBackend for each platform.
ImageBufferShareableBitmapBackend in WebKit needs to have access to basic
ImageBufferBackend functionalities specific to the platform.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::create):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Use WTF::makeUnique and make the constructor public.
Source/WebKit:
RemoteImageBufferProxy will create a shareable backend in the GPUProcess.
Then it will give access to this backend to RemoteImageBuffer in the
WebProcess by sending an ImageBufferBackendHandle.
- Sources.txt:
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/ImageBufferBackendHandle.h: Added.
This is variant of shareable handles to the ImageBufferBackend data.
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp: Added.
(WebKit::ImageBufferShareableBitmapBackend::create):
The first create method will be called to create the backend of
RemoteImageBufferProxy GPUProcess. The second create method will be called
to create the backend of RemoteImageBuffer in the WebProcess.
(WebKit::ImageBufferShareableBitmapBackend::ImageBufferShareableBitmapBackend):
(WebKit::ImageBufferShareableBitmapBackend::createImageBufferBackendHandle const):
Creates an ImageBufferBackendHandle which will be sent from the GPUProcess
to the WebProcess.
(WebKit::ImageBufferShareableBitmapBackend::copyNativeImage const):
(WebKit::ImageBufferShareableBitmapBackend::copyImage const):
(WebKit::ImageBufferShareableBitmapBackend::toBGRAData const):
(WebKit::ImageBufferShareableBitmapBackend::getImageData const):
(WebKit::ImageBufferShareableBitmapBackend::putImageData):
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h: Added.
- WebProcess/GPU/graphics/PlatformImageBufferShareableBackend.h: Added.
Defines the platform shareable ImageBufferBackend types.
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp: Added.
(WebKit::ImageBufferShareableIOSurfaceBackend::create):
(WebKit::ImageBufferShareableIOSurfaceBackend::createImageBufferBackendHandle const):
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h: Added.
Because ImageBufferBackendHandle has to be defined in WebKit, sharing
the IOSurface backend has to be implemented in WebKit.
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
- WebProcess/Network/WebSocketChannel.cpp:
- WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h:
Unified sources gardening.
- 5:34 PM Changeset in webkit [257605] by
-
- 3 edits4 adds in trunk
Poly proto should work with property delete transitions
https://bugs.webkit.org/show_bug.cgi?id=208261
Reviewed by Saam Barati.
JSTests:
- stress/delete-property-poly-proto.js: Added.
(A.prototype.set x):
(A):
(B):
Source/JavaScriptCore:
This patch fixes a bug where the combination of inline caching
and poly proto cause us to cache a setter call along a prototype chain that
is no longer the correct setter to call. This is exposed as a result of
https://bugs.webkit.org/show_bug.cgi?id=206430 since DefineOwnProperty used
to transition to uncacheable dictionary.
The case looks like this:
A - setter for x redefines x
|
B
|
C
We set (new C).x
Right now, we first call A's setter, then we try to figure out what the state of things
were before it was called in order to cache it. We just assume that A's setter still exists, and we cache it
without ever checking, In this patch, we ensure that the property exists and the attributes match in order to prevent crashing.
In the code, A = target, C = base.
Get is correct because it collects caching information before any calls.
The bug https://bugs.webkit.org/show_bug.cgi?id=208337 tracks the remaining semantic bugs around this code.
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- 5:32 PM Changeset in webkit [257604] by
-
- 3 edits4 adds in branches/safari-609.1.20.111-branch
Apply patch. rdar://problem/59870336
- 5:30 PM Changeset in webkit [257603] by
-
- 3 edits4 adds in branches/safari-609.1.20.0-branch
Apply patch. rdar://problem/59870344
- 5:25 PM Changeset in webkit [257602] by
-
- 8 edits in branches/safari-609.1.20.0-branch/Source
Versioning.
- 5:23 PM Changeset in webkit [257601] by
-
- 8 edits in branches/safari-609.1.20.111-branch/Source
Versioning.
- 5:01 PM Changeset in webkit [257600] by
-
- 2 edits in trunk/LayoutTests
[ iOS Debug wk2 ] imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=208355
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 4:13 PM Changeset in webkit [257599] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] LayoutTest/fast/animation/request-animation-frame-time-unit.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=171957
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 4:06 PM Changeset in webkit [257598] by
-
- 7 edits in trunk/Source
[WinCairo] Fix RemoteInspector reconnect issue
https://bugs.webkit.org/show_bug.cgi?id=208256
Reviewed by Devin Rousso.
Source/JavaScriptCore:
Call target's disconnection sequence asynchronously to avoid deadlock.
- inspector/remote/RemoteConnectionToTarget.cpp:
(Inspector::RemoteConnectionToTarget::close):
- inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
Source/WTF:
Added wakeupCallback to RunLoop. In case of RunLook::iterate, we need to wake up worker thread
when RunLoop is waking up.
- wtf/RunLoop.h:
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::setWakeUpCallback):
(WTF::RunLoop::wakeUp):
- wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::setWakeUpCallback):
(WTF::RunLoop::wakeUp):
- 4:05 PM Changeset in webkit [257597] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests: Make upload format valid
https://bugs.webkit.org/show_bug.cgi?id=208341
Reviewed by Aakash Jain.
- Scripts/run-javascriptcore-tests:
(uploadResults): Print json blob for upload after failure for debugging.
- 3:59 PM Changeset in webkit [257596] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] webgpu/whlsl/return-local-variable.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207700
Unreviewed test gardening
- platform/mac-wk2/TestExpectations: Correcting test expectations.
- 3:45 PM Changeset in webkit [257595] by
-
- 3 edits in trunk
[Win] Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=208330
Reviewed by Don Olmstead.
Set framework headers directory for AppleWin build.
- Source/cmake/target/TargetJavaScriptCore.cmake:
- Source/cmake/target/TargetWTF.cmake:
- 3:42 PM Changeset in webkit [257594] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r256910?) [ Mac wk1 ] fast/canvas/webgl/canvas-webgl-page-cache.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=208345
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 3:39 PM Changeset in webkit [257593] by
-
- 9 edits in trunk
Unreviewed, rolling out r257575.
Broke the watchOS build.
Reverted changeset:
"[iOS] Issue mach sandbox extensions to the WebContent process
for a set of specific services"
https://bugs.webkit.org/show_bug.cgi?id=208146
https://trac.webkit.org/changeset/257575
- 3:27 PM Changeset in webkit [257592] by
-
- 37 edits in trunk/Source
Change HitTestRequestType to an OptionSet
https://bugs.webkit.org/show_bug.cgi?id=208334
Reviewed by Wenson Hsieh.
Source/WebCore:
The majority of this change is replacing usage of HitTestRequestType with an OptionSet<HitTestRequest::RequestType>.
Though I was tempted and did in some circumstances modernize code around HitTestRequestType call sites.
I've annotated important changes below.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint const): Updated code as needed.
Added FIXME comment: the code should be written without a loop and instead use HitTestRequest::AllowVisibleChildFrameContentOnly
to achieve the goal.
(WebCore::AccessibilityRenderObject::accessibilityHitTest const):
- dom/TreeScope.cpp:
(WebCore::TreeScope::elementsFromPoint):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::isReplacementObscured): Update code as needed. Use IntRect::center()
convenience function instead of computing the center point manually.
- html/MediaElementSession.cpp:
(WebCore::isElementMainContentForPurposesOfAutoplay): Update code as needed. Move check for whether
the main frame has a document earlier in the function to avoid unncessary work. In practice, this
check will never fail because the main frame always has a document. Though to be precise the main
frame may not have a document during frame initialization. However, it does not make sense for this
code to ever be called then.
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateAutoscrollRenderer):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::maybeCreateContextMenu):
- page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag const):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint const):
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseForceEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar const):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::hitTestResultInFrame):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
- page/EventHandler.h:
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint const):
(WebCore::Frame::documentAtPoint):
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::cancelPointer): Added FIXME about correctness issue.
The local variable named target will always be nullptr even after calling hitTestResultAtPoint().
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::tryToBeginDragAtPoint):
- page/ios/FrameIOS.mm:
(WebCore::Frame::renderRectForPoint const):
(WebCore::Frame::betterApproximateNode):
(WebCore::Frame::hitTestResultAtViewportLocation):
(WebCore::Frame::qualifyingNodeAtViewportLocation):
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::HitTestRequest):
(WebCore::HitTestRequest::readOnly const):
(WebCore::HitTestRequest::active const):
(WebCore::HitTestRequest::move const):
(WebCore::HitTestRequest::release const):
(WebCore::HitTestRequest::ignoreClipping const):
(WebCore::HitTestRequest::svgClipContent const):
(WebCore::HitTestRequest::touchEvent const):
(WebCore::HitTestRequest::disallowsUserAgentShadowContent const):
(WebCore::HitTestRequest::allowsFrameScrollbars const):
(WebCore::HitTestRequest::allowsChildFrameContent const):
(WebCore::HitTestRequest::allowsVisibleChildFrameContent const):
(WebCore::HitTestRequest::isChildFrameHitTest const):
(WebCore::HitTestRequest::resultIsElementList const):
(WebCore::HitTestRequest::includesAllElementsUnderPoint const):
(WebCore::HitTestRequest::type const):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect const):
- testing/Internals.mm:
(WebCore::Internals::rangeForDictionaryLookupAtLocation):
Source/WebKit:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest const):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::WebPage::characterIndexForPointAsync):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rectForElementAtInteractionLocation const):
(WebKit::WebPage::handleStylusSingleTapAtPoint):
(WebKit::rangeForPointInRootViewCoordinates):
(WebKit::WebPage::setFocusedFrameBeforeSelectingTextAtLocation):
(WebKit::selectionPositionInformation):
(WebKit::textInteractionPositionInformation):
(WebKit::WebPage::positionInformation):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
Source/WebKitLegacy/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame elementRectAtPoint:]):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary const):
- WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController performHitTestAtPoint:]):
Source/WebKitLegacy/win:
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
- WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::gestureNotify):
(WebView::elementAtPoint):
- 3:12 PM Changeset in webkit [257591] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208328
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 3:04 PM Changeset in webkit [257590] by
-
- 75 edits37 copies105 adds44 deletes in trunk/JSTests
Update test262 (2020.02.26)
https://bugs.webkit.org/show_bug.cgi?id=208280
Reviewed by Yusuke Suzuki.
- test262/config.yaml:
- test262/expectations.yaml:
- test262/harness/async-gc.js:
- test262/latest-changes-summary.txt:
- test262/test/:
- test262/test262-Revision.txt:
- 2:59 PM Changeset in webkit [257589] by
-
- 10 edits in trunk/Source/WebCore
AXIsolatedObject support for table rows and ARIA tree/grid rows.
https://bugs.webkit.org/show_bug.cgi?id=208335
Reviewed by Chris Fleizach.
Covered by existing tests.
- Exposes the AccessibilityTableRow and AccessibilityARIAGridRow
interfaces through AXCoreObject.
- Eliminates the need of downcasting in the platform wrapper code, so
that it now works for both AXObjects and AXIsolatedObjects.
- Implements the above mentioned interfaces in AXIsolatedObject.
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::disclosedRows):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows): Became disclosedRows.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityTableRow.h:
(WebCore::AccessibilityTableRow::setRowIndex):
(WebCore::AccessibilityTableRow::rowIndex const): Deleted.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 2:55 PM Changeset in webkit [257588] by
-
- 1 copy in tags/Safari-610.1.5
Tag Safari-610.1.5.
- 2:37 PM Changeset in webkit [257587] by
-
- 11 edits1 add in trunk
[CMake] Add WebKit::PAL target
https://bugs.webkit.org/show_bug.cgi?id=198493
Reviewed by Michael Catanzaro.
.:
Define WebKit::PAL target for Apple internal Windows builds.
- Source/cmake/target/PAL.cmake: Added.
Source/WebCore:
Use WebKit::PAL target.
- CMakeLists.txt:
Source/WebCore/PAL:
Define WebKit::PAL target.
- pal/CMakeLists.txt:
- pal/PlatformFTW.cmake:
- pal/PlatformWinCairo.cmake:
Source/WebKitLegacy:
Add include of PAL target for Apple internal Windows builds.
- CMakeLists.txt:
Tools:
Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
- DumpRenderTree/PlatformWin.cmake:
- 2:21 PM Changeset in webkit [257586] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] webgpu/whlsl/textures-sample.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208340
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:08 PM Changeset in webkit [257585] by
-
- 3 edits in trunk/LayoutTests
Fix flaky enter/exit PIP test
https://bugs.webkit.org/show_bug.cgi?id=208272
Unreviewed test gardening.
This test sometimes fails because it presses the PIP control before the video starts
playing. Fix this by waiting for the playing event before pressing the control.
- media/modern-media-controls/pip-support/pip-support-click.html:
- platform/mac-wk2/TestExpectations:
- 1:53 PM Changeset in webkit [257584] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Adding myself to contributors.json
Unreviewed
- Scripts/webkitpy/common/config/contributors.json:
- 1:50 PM Changeset in webkit [257583] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed unified source builds fix.
https://bugs.webkit.org/show_bug.cgi?id=207198
Include header files for types referenced in RemoteRenderingBackend.h.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-02-27
- GPUProcess/graphics/RemoteRenderingBackendProxy.h:
- WebProcess/GPU/graphics/RemoteRenderingBackend.h:
- 1:43 PM Changeset in webkit [257582] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208245
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations: Mark test as flaky.
- 12:12 PM Changeset in webkit [257581] by
-
- 3 edits in trunk/Source/WebCore
MediaResourceLoader objects are leaking on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=208273
Reviewed by Jer Noble.
We retain the WebCoreNSURLSession delegate. There will be a retain cycle
if that delegate retains the session. This patch fixes the retain cycle problem
by referencing the delegate with a weak pointer.
Manually tested.
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession delegate]):
- 11:49 AM Changeset in webkit [257580] by
-
- 3 edits in trunk/LayoutTests
REGRESSION: (257072) [ Mac wk2 Release ] fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208264
<rdar://problem/59821552>
Reviewed by Simon Fraser.
- fast/harness/uiscriptcontroller/concurrent-ui-side-scripts-expected.txt:
- fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html:
There is no guarantee that two independent async UI scripts finish in particular order. Order the output instead.
- 11:38 AM Changeset in webkit [257579] by
-
- 1 copy in tags/Safari-609.1.20.0.7
Tag Safari-609.1.20.0.7.
- 11:30 AM Changeset in webkit [257578] by
-
- 14 edits in trunk/Source
Add ENABLE(SCROLLING_THREAD) and use it to turn off some code we don't need for iOS
https://bugs.webkit.org/show_bug.cgi?id=208282
Reviewed by Tim Horton.
Source/WebCore:
Protect ThreadedScrollingTree and ScrollingCoordinatorMac with ENABLE(SCROLLING_THREAD).
- page/scrolling/ThreadedScrollingTree.cpp:
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- page/scrolling/mac/ScrollingTreeMac.cpp:
- page/scrolling/mac/ScrollingTreeMac.h:
Source/WebKit:
Protect scrolling-thread related code in EventDispatcher with ENABLE(SCROLLING_THREAD),
and don't register pages with EventDispatcher unless ENABLE(SCROLLING_THREAD) is true.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
Source/WTF:
Define ENABLE_SCROLLING_THREAD PLATFORM(MAC) and USE(NICOSIA).
- wtf/PlatformEnable.h:
- wtf/PlatformEnableCocoa.h:
- 11:14 AM Changeset in webkit [257577] by
-
- 8 edits in trunk/Source/WebKit
Add GPU Process support for accessLog et al.
https://bugs.webkit.org/show_bug.cgi?id=207007
Patch by Tim Monroe <timmon@apple.com> on 2020-02-27
Reviewed by Jon Lee.
No tests included here.
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenFrame):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerManagerProxy::setVolume):
(WebKit::RemoteMediaPlayerManagerProxy::setBufferingPolicy):
(WebKit::RemoteMediaPlayerManagerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerManagerProxy::accessLog):
(WebKit::RemoteMediaPlayerManagerProxy::errorLog):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::setBufferingPolicy):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerProxy::accessLog):
(WebKit::RemoteMediaPlayerProxy::errorLog):
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::updateVideoFullscreenInlineImage):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenMode):
(WebKit::MediaPlayerPrivateRemote::videoFullscreenStandbyChanged):
(WebKit::MediaPlayerPrivateRemote::accessLog const):
(WebKit::MediaPlayerPrivateRemote::errorLog const):
(WebKit::MediaPlayerPrivateRemote::setBufferingPolicy):
- 11:03 AM Changeset in webkit [257576] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] crypto/subtle/rsa-indexeddb-non-exportable-private.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=207660
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 10:48 AM Changeset in webkit [257575] by
-
- 9 edits in trunk
[iOS] Issue mach sandbox extensions to the WebContent process for a set of specific services
https://bugs.webkit.org/show_bug.cgi?id=208146
Reviewed by Brent Fulgham.
Source/WebKit:
We are still seeing some accesses from the WebContent process to a small set of services. Since we do not currently have
backtraces for these accesses, make a speculative patch, where we issue these extension for all apps except Safari.
Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup-mail.html:
- 10:18 AM Changeset in webkit [257574] by
-
- 1 edit in branches/safari-609-branch/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
Unreviewed follow-up build fix, rdar://problem/59793496
- 10:15 AM Changeset in webkit [257573] by
-
- 2 edits in trunk/LayoutTests
[CSS Backgrounds] Skip WPT tests always crashing in Debug.
Unreviewed gardening. See https://webkit.org/b/206579#c1
- 10:08 AM Changeset in webkit [257572] by
-
- 23 edits58 adds in trunk
Add referrerpolicy attribute support for images
https://bugs.webkit.org/show_bug.cgi?id=207901
Patch by Rob Buis <rbuis@igalia.com> on 2020-02-27
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update improved test results.
- web-platform-tests/html/dom/idlharness.https-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt:
Source/WebCore:
This patch adds 'referrerpolicy' attribute support for img elements.
If set, the value is restricted to the ReferrerPolicy enum, and
if valid it is used for the script fetch.
If not set or invalid, the current behavior is kept.
Tests: http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http-http.html
http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http.https.html
http/tests/referrer-policy-img/no-referrer-when-downgrade/same-origin.html
http/tests/referrer-policy-img/no-referrer/cross-origin-http-http.html
http/tests/referrer-policy-img/no-referrer/cross-origin-http.https.html
http/tests/referrer-policy-img/no-referrer/same-origin.html
http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-img/origin-when-cross-origin/same-origin.html
http/tests/referrer-policy-img/origin/cross-origin-http-http.html
http/tests/referrer-policy-img/origin/cross-origin-http.https.html
http/tests/referrer-policy-img/origin/same-origin.html
http/tests/referrer-policy-img/same-origin/cross-origin-http-http.html
http/tests/referrer-policy-img/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-img/same-origin/same-origin.html
http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-img/strict-origin-when-cross-origin/same-origin.html
http/tests/referrer-policy-img/strict-origin/cross-origin-http-http.html
http/tests/referrer-policy-img/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy-img/strict-origin/same-origin.html
http/tests/referrer-policy-img/unsafe-url/cross-origin-http-http.html
http/tests/referrer-policy-img/unsafe-url/cross-origin-http.https.html
http/tests/referrer-policy-img/unsafe-url/same-origin.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setReferrerPolicyForBindings):
(WebCore::HTMLImageElement::referrerPolicyForBindings const):
(WebCore::HTMLImageElement::referrerPolicy const):
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
LayoutTests:
Add tests for images with various referrerpolicy attribute values.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer-when-downgrade/same-origin.html: Added.
- http/tests/referrer-policy-img/no-referrer/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/no-referrer/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/no-referrer/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/no-referrer/same-origin.html: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/origin-when-cross-origin/same-origin.html: Added.
- http/tests/referrer-policy-img/origin/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/origin/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/origin/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/origin/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/origin/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/origin/same-origin.html: Added.
- http/tests/referrer-policy-img/same-origin/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/same-origin/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/same-origin/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/same-origin/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/same-origin/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/same-origin/same-origin.html: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin-when-cross-origin/same-origin.html: Added.
- http/tests/referrer-policy-img/strict-origin/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/strict-origin/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/strict-origin/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/strict-origin/same-origin.html: Added.
- http/tests/referrer-policy-img/unsafe-url/cross-origin-http-http-expected.txt: Added.
- http/tests/referrer-policy-img/unsafe-url/cross-origin-http-http.html: Added.
- http/tests/referrer-policy-img/unsafe-url/cross-origin-http.https-expected.txt: Added.
- http/tests/referrer-policy-img/unsafe-url/cross-origin-http.https.html: Added.
- http/tests/referrer-policy-img/unsafe-url/same-origin-expected.txt: Added.
- http/tests/referrer-policy-img/unsafe-url/same-origin.html: Added.
- http/tests/referrer-policy-script/unsafe-url/cross-origin-http-http.html:
- http/tests/referrer-policy/resources/image.php: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/win/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
- 10:07 AM Changeset in webkit [257571] by
-
- 53 edits1 delete in trunk
Add SPI to query WKFrameInfos in a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=208212
Reviewed by Brady Eidson.
Source/WebKit:
This adds WKWebView._allFrames and SPI on WKFrameInfo to look at parent and child frames.
This will help with rdar://problem/59783184 and other similar tasks.
In order to do this, I needed to make API::FrameInfo::create take a WebKit::FrameInfoData,
which I pass from the WebProcess. Where we used to pass only a SecurityOriginData,
we now pass a FrameInfoData which contains a SecurityOriginData and more information.
I needed to deprecate WKFrameCreateFrameInfo which had its last use removed in rdar://problem/59768710
because there was not enough information in its parameters to create a WKFrameInfo with this new data.
I also replaced the test-only SPI WKFrameInfoGetFrameHandleRef with WKFrameInfoCreateFrameHandleRef
so we don't need to keep a strong reference to the handle and other new members in API::FrameInfo.
New functionality covered by API tests and I removed the last tests' use of now-deprecated WKFrameCreateFrameInfo.
- Shared/FrameInfoData.cpp:
(WebKit::FrameInfoData::encode const):
(WebKit::FrameInfoData::decode):
- Shared/FrameInfoData.h:
- UIProcess/API/APIFrameInfo.cpp:
(API::FrameInfo::FrameInfo):
(API::FrameInfo::handle const):
(API::FrameInfo::parentFrameHandle const):
(API::FrameInfo::childFrameHandles const):
(): Deleted.
- UIProcess/API/APIFrameInfo.h:
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didFailProvisionalLoadInSubframeWithError):
- UIProcess/API/APIUIClient.h:
(API::UIClient::runJavaScriptAlert):
(API::UIClient::runJavaScriptConfirm):
(API::UIClient::runJavaScriptPrompt):
(API::UIClient::runBeforeUnloadConfirmPanel):
(API::UIClient::runOpenPanel):
(API::UIClient::decidePolicyForGeolocationPermissionRequest):
(API::UIClient::runWebAuthenticationPanel):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameInfo):
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKFrameInfoRef.cpp:
(WKFrameInfoCreateFrameHandleRef):
(WKFrameInfoGetFrameHandleRef): Deleted.
- UIProcess/API/C/WKFrameInfoRef.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
(WKPageSetPageNavigationClient):
- UIProcess/API/Cocoa/WKFrameInfo.mm:
(-[WKFrameInfo securityOrigin]):
(-[WKFrameInfo _handle]):
(-[WKFrameInfo _parentFrameHandle]):
(-[WKFrameInfo _childFrameHandles]):
- UIProcess/API/Cocoa/WKFrameInfoPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allFrames:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::didFailProvisionalLoadInSubframeWithError):
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm:
(WebKit::SOAuthorizationCoordinator::tryAuthorize):
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::continueStartAfterDecidePolicy):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
(WebKit::UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel):
(WebKit::UIDelegate::UIClient::runOpenPanel):
(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
- UIProcess/PageClient.h:
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::ProvisionalPageProxy::decidePolicyForResponse):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync):
- UIProcess/ProvisionalPageProxy.h:
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::runPanel):
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrames):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runOpenPanel):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::runOpenPanel):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrameIDs const):
(WebKit::WebFrame::info const):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getAllFrames):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::saltForOrigin):
- 10:04 AM Changeset in webkit [257570] by
-
- 7 edits in branches/safari-609-branch
Unreviewed build fix, rdar://problem/59793496
- 9:34 AM Changeset in webkit [257569] by
-
- 3 edits in trunk/Source/WebCore
Cleanup HitTestResult.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=208269
<rdar://problem/59824186>
Reviewed by Alex Christensen.
Use modern C++ features to remove duplicate code.
- rendering/HitTestLocation.cpp:
(WebCore::HitTestLocation::HitTestLocation):
- rendering/HitTestLocation.h:
- rendering/HitTestResult.cpp: Remove unnecessary #includes.
- rendering/HitTestResult.h: Remove unnecessary #includes.
(WebCore::HitTestResult::setIsOverWidget):
- 8:52 AM Changeset in webkit [257568] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix for non-unified builds after r257507.
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedPositiveAndNegativeMargin const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateMarginAfterForPreviousSibling):
(WebCore::Layout::computedPositiveAndNegativeMargin): Deleted.
- 8:31 AM Changeset in webkit [257567] by
-
- 53 edits1 copy in trunk
Unreviewed, rolling out r257530.
This commit seems to have broke the build internally for
watchOS
Reverted changeset:
"Add SPI to query WKFrameInfos in a WKWebView"
https://bugs.webkit.org/show_bug.cgi?id=208212
https://trac.webkit.org/changeset/257530
- 8:19 AM WebKitGTK/2.28.x edited by
- (diff)
- 8:18 AM WebKitGTK/2.26.x edited by
- (diff)
- 8:02 AM Changeset in webkit [257566] by
-
- 10 edits in trunk/Source/WebCore
Load async scripts with low priority
https://bugs.webkit.org/show_bug.cgi?id=208298
Reviewed by Anders Carlsson.
They are assumed to be non-critical and don't delay DOMContentLoaded.
This matches other browsers. See https://addyosmani.com/blog/script-priorities/ for Chrome behavior.
- bindings/js/CachedScriptFetcher.cpp:
(WebCore::CachedScriptFetcher::requestModuleScript const):
(WebCore::CachedScriptFetcher::requestScriptWithCache const)
Pass around the priority.
- bindings/js/CachedScriptFetcher.h:
- dom/LoadableClassicScript.cpp:
(WebCore::LoadableClassicScript::create):
(WebCore::LoadableClassicScript::load):
Deprioritize async script load.
- dom/LoadableClassicScript.h:
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestClassicScript):
Pass around the information that this is an async script.
- dom/ScriptElementCachedScriptFetcher.cpp:
(WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
Parse async attribute in preload scanner.
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::resourceRequest):
Deprioritize async script preload.
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::setScriptIsAsync):
- 6:36 AM Changeset in webkit [257565] by
-
- 6 edits in trunk
[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=206894
Reviewed by Adrian Perez de Castro.
.:
Add a MiniBrowser derived sources directory.
- Source/cmake/WebKitFS.cmake:
Tools:
Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
MiniBrowsers.
- MiniBrowser/gtk/CMakeLists.txt:
- MiniBrowser/win/CMakeLists.txt:
- MiniBrowser/wpe/CMakeLists.txt:
- 6:16 AM Changeset in webkit [257564] by
-
- 1 copy in releases/WPE WebKit/webkit-2.27.91
WPE WebKit 2.27.91
- 6:15 AM Changeset in webkit [257563] by
-
- 4 edits in releases/WebKitGTK/webkit-2.28
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.91 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.27.91.
- 6:07 AM Changeset in webkit [257562] by
-
- 3 edits in trunk
[LFC][Integration] Build and enable for the WPE and GTK ports
https://bugs.webkit.org/show_bug.cgi?id=208289
Reviewed by Carlos Garcia Campos.
Enable LFC for the WPE and GTK ports.
- Source/cmake/OptionsGTK.cmake: LFC enabled as experimental feature.
- Source/cmake/OptionsWPE.cmake: Ditto.
- 1:59 AM Changeset in webkit [257561] by
-
- 1 copy in releases/WebKitGTK/webkit-2.27.91
WebKitGTK 2.27.91
- 1:59 AM Changeset in webkit [257560] by
-
- 4 edits in releases/WebKitGTK/webkit-2.28
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.91 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.27.91.
- 1:14 AM Changeset in webkit [257559] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257536 - Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode
https://bugs.webkit.org/show_bug.cgi?id=208115
<rdar://problem/56685655>
Patch by Jack Lee <Jack Lee> on 2020-02-26
Reviewed by Ryosuke Niwa.
When inserting a list at an element with a non-list-item child, if the element is uneditable, skip creating list item for the child.
Source/WebCore:
Test: fast/lists/insert-list-uneditable-element-with-non-li-child.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):
LayoutTests:
- fast/lists/insert-list-uneditable-element-with-non-li-child-expected.txt: Added.
- fast/lists/insert-list-uneditable-element-with-non-li-child.html: Added.
- 1:14 AM Changeset in webkit [257558] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/JavaScriptCore
Merge r257529 - Enhance JSObjectGetProperty() to mitigate against null object pointers.
https://bugs.webkit.org/show_bug.cgi?id=208275
<rdar://problem/59826325>
Reviewed by Robin Morisset.
- API/JSObjectRef.cpp:
(JSObjectGetProperty):
- 12:25 AM Changeset in webkit [257557] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: localize the placeholder "Header" and "value" when editing a local override
https://bugs.webkit.org/show_bug.cgi?id=208276
<rdar://problem/59763619>
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.show):
Feb 26, 2020:
- 9:22 PM Changeset in webkit [257556] by
-
- 7 edits9 deletes in trunk/LayoutTests
Web platform tests for Web Share API fail incorrectly
https://bugs.webkit.org/show_bug.cgi?id=208083
Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2020-02-26
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Fixed expected for updated wpts.
- web-platform-tests/web-share/share-without-user-gesture.https-expected.txt:
- web-platform-tests/web-share/canShare-files.https-expected.txt:
- web-platform-tests/web-share/canShare.https-expected.txt:
- web-platform-tests/web-share/idlharness.https.window-expected.txt:
LayoutTests:
Removed duplicate tests for corresponding wpts, fixed expected
for new wpts. Modified TestExpectations to now run all web-share
wpts except for those testing secure context behavior, which is not
supported by the current wpt infrastructure.
- TestExpectations:
- fast/web-share/canShare-expected.txt: Removed.
- fast/web-share/canShare-files-expected.txt: Removed.
- fast/web-share/canShare-files.html: Removed.
- fast/web-share/canShare.html: Removed.
- fast/web-share/share-empty-expected.txt: Removed.
- fast/web-share/share-empty.html: Removed.
- fast/web-share/share-url-invalid-expected.txt: Removed.
- fast/web-share/share-without-user-gesture-expected.txt: Removed.
- fast/web-share/share-without-user-gesture.html: Removed.
- 9:17 PM Changeset in webkit [257555] by
-
- 2 edits in trunk/Source/WebKit
Annotate mediaType with an availability macro.
https://bugs.webkit.org/show_bug.cgi?id=208284
Reviewed by Alex Christensen.
- UIProcess/API/Cocoa/WKWebView.h:
- 8:56 PM Changeset in webkit [257554] by
-
- 2 edits in trunk/Source/bmalloc
[bmalloc][PlayStation] Set Scavenger's thread name.
https://bugs.webkit.org/show_bug.cgi?id=208268
Reviewed by Alex Christensen.
We also need to have our thread with proper name.
- bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::setThreadName):
- 8:43 PM Changeset in webkit [257553] by
-
- 10 edits in trunk
Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206456
Reviewed by Brady Eidson.
Source/WebKit:
The replacement on WebsiteDataStoreConfiguration has been adopted.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::sourceApplicationBundleIdentifier const):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 8:35 PM Changeset in webkit [257552] by
-
- 35 edits2 deletes in trunk
_WKUserContentWorld should be a wrapper around WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=208274
Reviewed by Brady Eidson.
Source/WebKit:
Various SPIs were getting confused between the two.
Updated API tests which expected pointer equality, which is no longer true or important.
- Shared/API/APIObject.h:
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Sources.txt:
- UIProcess/API/APIContentWorld.cpp:
(API::ContentWorld::ContentWorld):
(API::ContentWorldBase::ContentWorldBase): Deleted.
- UIProcess/API/APIContentWorld.h:
(API::ContentWorldBase::identifier const): Deleted.
(API::ContentWorldBase::name const): Deleted.
(API::ContentWorldBase::worldData const): Deleted.
(API::ContentWorldBase::ContentWorldBase): Deleted.
- UIProcess/API/APIUserContentWorld.cpp: Removed.
- UIProcess/API/APIUserContentWorld.h: Removed.
- UIProcess/API/APIUserScript.cpp:
(API::UserScript::UserScript):
- UIProcess/API/APIUserScript.h:
- UIProcess/API/APIUserStyleSheet.cpp:
(API::UserStyleSheet::UserStyleSheet):
- UIProcess/API/APIUserStyleSheet.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):
- UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):
- UIProcess/API/Cocoa/WKContentWorld.mm:
(-[WKContentWorld _userContentWorld]):
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController addScriptMessageHandler:name:]):
(-[WKUserContentController removeScriptMessageHandlerForName:]):
(-[WKUserContentController _removeAllUserScriptsAssociatedWithUserContentWorld:]):
(-[WKUserContentController _removeAllUserStyleSheetsAssociatedWithUserContentWorld:]):
(-[WKUserContentController _addScriptMessageHandler:name:userContentWorld:]):
(-[WKUserContentController _removeScriptMessageHandlerForName:userContentWorld:]):
(-[WKUserContentController _removeAllScriptMessageHandlersAssociatedWithUserContentWorld:]):
- UIProcess/API/Cocoa/WKUserScript.mm:
(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:userContentWorld:]):
(-[WKUserScript _userContentWorld]):
- UIProcess/API/Cocoa/_WKUserContentWorld.mm:
(-[_WKUserContentWorld _initWithName:]):
(-[_WKUserContentWorld _init]):
(-[_WKUserContentWorld _initWithContentWorld:]):
(+[_WKUserContentWorld worldWithName:]):
(+[_WKUserContentWorld normalWorld]):
(-[_WKUserContentWorld name]):
(-[_WKUserContentWorld _apiObject]):
(-[_WKUserContentWorld dealloc]): Deleted.
- UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):
- UIProcess/UserContent/WebScriptMessageHandler.cpp:
(WebKit::WebScriptMessageHandler::create):
(WebKit::WebScriptMessageHandler::WebScriptMessageHandler):
- UIProcess/UserContent/WebScriptMessageHandler.h:
(WebKit::WebScriptMessageHandler::world):
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addContentWorldUse):
(WebKit::WebUserContentControllerProxy::shouldSendRemoveContentWorldsMessage):
(WebKit::WebUserContentControllerProxy::removeContentWorldUses):
(WebKit::WebUserContentControllerProxy::addUserScript):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::addUserScriptMessageHandler):
(WebKit::WebUserContentControllerProxy::removeUserMessageHandlerForName):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
(WebKit::WebUserContentControllerProxy::addUserContentWorldUse): Deleted.
(WebKit::WebUserContentControllerProxy::shouldSendRemoveUserContentWorldsMessage): Deleted.
(WebKit::WebUserContentControllerProxy::removeUserContentWorldUses): Deleted.
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addContentWorld):
(WebKit::WebUserContentController::addContentWorlds):
(WebKit::WebUserContentController::removeContentWorlds):
(WebKit::WebUserContentController::addUserScripts):
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeAllUserScripts):
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::removeUserStyleSheet):
(WebKit::WebUserContentController::removeAllUserStyleSheets):
(WebKit::WebUserContentController::addUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeUserScriptMessageHandler):
(WebKit::WebUserContentController::removeAllUserScriptMessageHandlers):
(WebKit::WebUserContentController::addUserContentWorld): Deleted.
(WebKit::WebUserContentController::addUserContentWorlds): Deleted.
(WebKit::WebUserContentController::removeUserContentWorlds): Deleted.
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_processDisplayName):
(WebKit::WebPage::runJavaScriptInMainFrameScriptWorld):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
(TEST):
- 7:51 PM Changeset in webkit [257551] by
-
- 33 edits11 adds in trunk/Source
Create AudioDestination in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=208179
Reviewed by Jer Noble.
Source/WebCore:
Add an abstraction around the creation of AudioDestination using newly introduced mediaStrategy.
- Headers.cmake:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::createDestination): Use MediaStrategy::createAudioDestination
- WebCore.xcodeproj/project.pbxproj:
- platform/MediaStrategy.h: Added.
(WebCore::MediaStrategy): Added.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::mediaStrategy): Added.
- platform/audio/AudioBus.h:
- platform/audio/AudioDestination.h:
Source/WebKit:
Create AudioDestination in the GPU process instead of the WebContent process for WebAudio API when
the Media-in-GPU-process feature is enabled.
To do this, WebMediaStrategy, a concrete implementation of MediaStrategy, in the WebContent process gets
a boolean flag indicating whether the GPU process should be used for AudioDestination or not. When the flag
is set, we create RemoteAudioDestinationProxy instead of AudioDestination in WebContent process.
Each RemoteAudioDestinationProxy talks to RemoteAudioDestinationManager in the GPU process and creates
a corresponding RemoteAudioDestination which in turn creates WebCore's AudioDestination in the GPU process.
RemoteAudioDestination is itself an AudioIOCallback for AudioDestination it creates, and delegates
its callback to WebContent process' RemoteAudioDestinationProxy as needed.
In this initial patch, we send RemoteAudioDestinationProxy::RenderBuffer IPC call to the WebContent process
for each render call we get from CoreAudio for simplicity using newly introduced RemoteAudioBusData,
which holds a SharedMemory for each channel in the audio bus.
We will eliminate this IPC overhead in a follow up patch using CARingBuffer.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::remoteAudioDestinationManager): Added.
(WebKit::GPUConnectionToWebProcess::didReceiveMessage): Added the code to dispatch messages to
RemoteAudioDestinationManager.
(WebKit::GPUConnectionToWebProcess::didReceiveSyncMessage): Ditto.
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/media/RemoteAudioDestinationManager.cpp: Added.
(WebKit::RemoteAudioDestination): Added. This class is the backing object which creates WebCore's
AudioDestination and actually talks to CoreAudio in GPU process.
(WebKit::RemoteAudioDestination::create): Added.
(WebKit::RemoteAudioDestination::~RemoteAudioDestination): Added.
(WebKit::RemoteAudioDestination::scheduleGracefulShutdownIfNeeded): Delays the deletion of this object
until the audio threads stops running.
(WebKit::RemoteAudioDestination::start): Added.
(WebKit::RemoteAudioDestination::stop): Added.
(WebKit::RemoteAudioDestination::isPlaying): Added.
(WebKit::RemoteAudioDestination::RemoteAudioDestination): Added.
(WebKit::RemoteAudioDestination::render): Sends a sync IPC to the WebContent process'
RemoteAudioDestinationProxy to fill the audio buffer. Note that this function gets called in audio thread.
(WebKit::RemoteAudioDestination::isPlayingDidChange): Added.
(WebKit::RemoteAudioDestinationManager): Added. This class manages all RemoteAudioDestination objects owned
by a single WebContent process.
(WebKit::RemoteAudioDestinationManager::RemoteAudioDestinationManager): Added.
(WebKit::RemoteAudioDestinationManager::~RemoteAudioDestinationManager): Added.
(WebKit::RemoteAudioDestinationManager::createAudioDestination): Added.
(WebKit::RemoteAudioDestinationManager::deleteAudioDestination): Added.
(WebKit::RemoteAudioDestinationManager::startAudioDestination): Added.
(WebKit::RemoteAudioDestinationManager::stopAudioDestination): Added.
- GPUProcess/media/RemoteAudioDestinationManager.h: Added.
(WebKit::RemoteAudioDestinationManager): Added.
(WebKit::RemoteAudioDestinationManager::didReceiveSyncMessageFromWebProcess): Added.
(WebKit::RemoteAudioDestinationManager::didReceiveMessageFromWebProcess): Added.
- GPUProcess/media/RemoteAudioDestinationManager.messages.in: Added.
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createMediaStrategy): Added. Returns nullptr since Networking
process has no business running AudioDestination.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
(WebKit::NetworkProcessPlatformStrategies):
- PlatformMac.cmake:
- Scripts/webkit/messages.py:
- Shared/RemoteAudioDestinationIdentifier.h: Added.
(WebKit::RemoteAudioDestinationIdentifierType): Added.
(WebKit::RemoteAudioDestinationIdentifier): Added. The identifier for each RemoteAudioDestination
and RemoteAudioDestinationProxy (corresponding objects of each class use the same ID to communicate).
- Sources.txt:
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/media/RemoteAudioBusData.h: Added.
(WebKit::RemoteAudioBusData): Added. Encodes the information about each render call.
(WebKit::RemoteAudioBusData::encode const): Added.
(WebKit::RemoteAudioBusData::decode): Added.
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp: Added.
(WebKit::RemoteAudioDestinationProxy): Added.
(WebKit::RemoteAudioDestinationProxy::create): Added.
(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy): Added.
(WebKit::RemoteAudioDestinationProxy::~RemoteAudioDestinationProxy): Added.
(WebKit::RemoteAudioDestinationProxy::start): Added.
(WebKit::RemoteAudioDestinationProxy::stop): Added.
(WebKit::RemoteAudioDestinationProxy::renderBuffer): Added. Calls WebCore's AudioIOCallback to fill
the audio buffer given by the GPU process.
(WebKit::RemoteAudioDestinationProxy::didChangeIsPlaying):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.h: Added.
(WebKit::RemoteAudioDestinationProxy::didReceiveMessageFromGPUProcess): Added.
(WebKit::RemoteAudioDestinationProxy::isPlaying): Added.
(WebKit::RemoteAudioDestinationProxy::sampleRate): Added.
- WebProcess/GPU/media/RemoteAudioDestinationProxy.messages.in: Added.
- WebProcess/GPU/media/TextTrackPrivateRemote.cpp: Fixed the unified builds.
- WebProcess/GPU/media/TextTrackPrivateRemote.h: Ditto.
- WebProcess/GPU/media/WebMediaStrategy.cpp: Added.
(WebKit::WebMediaStrategy::createAudioDestination): Added.
- WebProcess/GPU/media/WebMediaStrategy.h: Added.
(WebKit::WebMediaStrategy): Added.
(WebKit::WebMediaStrategy::setUseGPUProcess): Added.
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp: Fixed the unified builds.
- WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp: Fixed the unified builds.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createMediaStrategy): Added.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Sets WebMediaStrategy's flag to use GPU process.
Source/WebKitLegacy/mac:
Added WebMediaStrategy which is a wrapper around AudioDestination::create.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebMediaStrategy): Added.
(WebPlatformStrategies::createMediaStrategy):
Source/WebKitLegacy/win:
Added WebMediaStrategy which is a wrapper around AudioDestination::create.
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebMediaStrategy): Added.
(WebPlatformStrategies::createMediaStrategy):
- WebCoreSupport/WebPlatformStrategies.h:
- 7:18 PM Changeset in webkit [257550] by
-
- 9 edits2 adds in trunk
[iPadOS] REGRESSION(r247667): Autosizing style changes don't invalidate RenderText's preferred logical widths
https://bugs.webkit.org/show_bug.cgi?id=208084
<rdar://problem/59463898>
Reviewed by Darin Adler.
Source/WebCore:
Just use RenderElement::setStyle(), which handles all the invalidations, instead of RenderElement::setNeedsLayout().
Do a little refactoring so we don't clone RenderStyles unless we need to.
Test: fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html
- page/Page.cpp:
(WebCore::Page::recomputeTextAutoSizingInAllFrames):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isIdempotentTextAutosizingCandidate const):
- rendering/style/RenderStyle.h:
- rendering/style/TextSizeAdjustment.cpp:
(WebCore::AutosizeStatus::computeStatus):
(WebCore::AutosizeStatus::updateStatus):
- rendering/style/TextSizeAdjustment.h:
(WebCore::AutosizeStatus::operator== const):
(WebCore::AutosizeStatus::operator!= const):
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustmentForTextAutosizing):
(WebCore::Style::Adjuster::adjustForTextAutosizing):
- style/StyleAdjuster.h:
(WebCore::Style::Adjuster::AdjustmentForTextAutosizing::operator bool const):
LayoutTests:
- fast/text-autosizing/ios/idempotentmode/viewport-change-relayout-expected.html: Added.
- fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html: Added.
- 6:56 PM Changeset in webkit [257549] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r257507): [ macOS ] ASSERTION FAILED: blockFormattingState.hasPositiveAndNegativeVerticalMargin(layoutBox)
https://bugs.webkit.org/show_bug.cgi?id=208278
<rdar://problem/59828533>
Fix mismatching call after r257507.
- layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const):
- 6:31 PM Changeset in webkit [257548] by
-
- 15 edits in trunk/Source/WebCore
AXIsolatedObject support for table cells.
https://bugs.webkit.org/show_bug.cgi?id=208263
Reviewed by Chris Fleizach.
Covered by existing tests.
- Exposed the AccessibilityTableCell interface through AXCoreObject.
- This way there is no need to downcast in client code and the same
platform wrapper code works for AccessibilityObjects and
AXIsolatedObjects.
- Completed caching of table cell properties in AXIsolatedObject.
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange const):
(WebCore::AccessibilityARIAGridCell::axRowSpanWithRowIndex const):
(WebCore::AccessibilityARIAGridCell::columnIndexRange const):
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::isColumnHeaderCell const):
(WebCore::AccessibilityTableCell::isRowHeaderCell const):
(WebCore::AccessibilityTableCell::isTableCellInSameColGroup):
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableRow.h:
- accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:
(webkitAccessibleTableCellGetColumnSpan):
(webkitAccessibleTableCellGetRowSpan):
(webkitAccessibleTableCellGetPosition):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::pairAttributeValue const):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 6:12 PM Changeset in webkit [257547] by
-
- 1 copy in tags/Safari-609.1.20.111.6
Tag Safari-609.1.20.111.6.
- 6:03 PM Changeset in webkit [257546] by
-
- 1 copy in tags/Safari-609.1.20.4.2
Tag Safari-609.1.20.4.2.
- 5:57 PM Changeset in webkit [257545] by
-
- 1 copy in tags/Safari-609.1.20.3.4
Tag Safari-609.1.20.3.4.
- 5:55 PM Changeset in webkit [257544] by
-
- 8 edits in branches/safari-609.1.20.0-branch/Source
Versioning.
- 5:53 PM Changeset in webkit [257543] by
-
- 1 copy in tags/Safari-609.1.20.2.4
Tag Safari-609.1.20.2.4.
- 5:51 PM Changeset in webkit [257542] by
-
- 30 edits4 copies6 adds in trunk/Source
Implement the remote RenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=207198
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-02-26
Reviewed by Simon Fraser.
Source/WebCore:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer const):
Make HTMLCanvasElement be able to create a remote ImageBuffer.
Source/WebKit:
RemoteRenderingBackend and RemoteRenderingBackendProxy will be responsible
for creating the two parts of the ImageBuffer: RemoteImageBuffer and
RemoteImageBufferProxy. They will also be responsible for sending and
receiving the messages for the remote the ImageBuffers.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::createRenderingBackend):
(WebKit::GPUConnectionToWebProcess::releaseRenderingBackend):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
(WebKit::GPUConnectionToWebProcess::dispatchSyncMessage):
(WebKit::GPUConnectionToWebProcess::didReceiveMessage): Deleted.
(WebKit::GPUConnectionToWebProcess::didReceiveSyncMessage): Deleted.
- GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::messageReceiverMap):
(WebKit::GPUConnectionToWebProcess::webProcessIdentifier const):
GPUConnectionToWebProcess dispatches messages to RemoteRenderingBackendProxy.
- GPUProcess/GPUConnectionToWebProcess.messages.in:
Adding the 'WantsDispatchMessage' attribute will force the messages.py
to generate code which calls dispatchMessage() and didReceiveSyncMessage()
when messages are received.
- GPUProcess/graphics: Added.
- GPUProcess/graphics/RemoteRenderingBackendProxy.cpp: Added.
(WebKit::RemoteRenderingBackendProxy::create):
(WebKit::RemoteRenderingBackendProxy::RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::messageSenderConnection const):
(WebKit::RemoteRenderingBackendProxy::messageSenderDestinationID const):
(WebKit::RemoteRenderingBackendProxy::createImageBuffer):
(WebKit::RemoteRenderingBackendProxy::releaseImageBuffer):
- GPUProcess/graphics/RemoteRenderingBackendProxy.h: Added.
- GPUProcess/graphics/RemoteRenderingBackendProxy.messages.in: Added.
RemoteRenderingBackendProxy is responsible for creating the remote
ImageBuffer proxy in the GPUProcess side. It holds it in a HashMap of
std::unique_ptr<ImageBuffer> indexed by the ImageBufferIdentifier.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
Unified sources gardening.
- Scripts/webkit/messages.py:
Handle 'WantsDispatchMessage' attribute.
- Shared/WebCoreArgumentCoders.h:
- Sources.txt:
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
(WebKit::GPUProcessConnection::dispatchSyncMessage):
(WebKit::GPUProcessConnection::didReceiveMessage): Deleted.
- WebProcess/GPU/GPUProcessConnection.h:
(WebKit::GPUProcessConnection::messageReceiverMap):
- WebProcess/GPU/GPUProcessConnection.messages.in:
GPUConnection dispatches messages to RemoteRenderingBackend.
- WebProcess/GPU/graphics: Added.
- WebProcess/GPU/graphics/ImageBufferIdentifier.h: Added.
- WebProcess/GPU/graphics/RemoteRenderingBackend.cpp: Added.
(WebKit::RemoteRenderingBackend::create):
(WebKit::RemoteRenderingBackend::RemoteRenderingBackend):
(WebKit::RemoteRenderingBackend::~RemoteRenderingBackend):
(WebKit::RemoteRenderingBackend::messageSenderConnection const):
(WebKit::RemoteRenderingBackend::messageSenderDestinationID const):
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::releaseImageBuffer):
- WebProcess/GPU/graphics/RemoteRenderingBackend.h: Added.
- WebProcess/GPU/graphics/RemoteRenderingBackend.messages.in: Added.
- WebProcess/GPU/graphics/RenderingBackendIdentifier.h: Added.
RemoteRenderingBackend is responsible for creating the remote ImageBuffer
in the WebProcess side. It holds it in a HashMap of ImageBuffer* indexed
by the ImageBufferIdentifier.
- WebProcess/GPU/media/TextTrackPrivateRemote.cpp:
- WebProcess/GPU/media/TextTrackPrivateRemote.h:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
- WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
- WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp:
Unified sources gardening.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createDisplayRefreshMonitor const):
(WebKit::WebChromeClient::createImageBuffer const):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Create the remote ImageBuffer.
- 5:48 PM Changeset in webkit [257541] by
-
- 1 copy in tags/Safari-609.1.20.0.6
Tag Safari-609.1.20.0.6.
- 5:38 PM Changeset in webkit [257540] by
-
- 5 edits2 deletes in trunk/Tools
Unreviewed, rolling out r257522.
Caused 16 API test failures on the bots
Reverted changeset:
"TestWebKitAPI and WebKitTestRunner should have bundle
identifiers"
https://bugs.webkit.org/show_bug.cgi?id=208260
https://trac.webkit.org/changeset/257522
- 5:18 PM Changeset in webkit [257539] by
-
- 4 edits in trunk/Source/WebKit
Remove WebsiteDataStore::setSourceApplicationSecondaryIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206452
Reviewed by Chris Dumez.
Its replacement on WebsiteDataStoreConfiguration was adopted in rdar://problem/58671704
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier const):
- 5:15 PM Changeset in webkit [257538] by
-
- 5 edits in trunk/Source/WebKit
Remove WebsiteDataStore setters for allowsCellularAccess, proxyConfiguration, and boundInterfaceIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206390
Reviewed by Chris Dumez.
The WKWebsiteDataStore SPI was deprecated with replacement on _WKWebsiteDataStoreConfiguration,
and the replacements were adopted in rdar://problem/58359766
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _setBoundInterfaceIdentifier:]):
(-[WKWebsiteDataStore _boundInterfaceIdentifier]):
(-[WKWebsiteDataStore _setAllowsCellularAccess:]):
(-[WKWebsiteDataStore _allowsCellularAccess]):
(-[WKWebsiteDataStore _setProxyConfiguration:]):
(-[WKWebsiteDataStore _proxyConfiguration]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::paymentCoordinatorBoundInterfaceIdentifier):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::networkingHasBegun):
(WebKit::WebsiteDataStore::setBoundInterfaceIdentifier): Deleted.
(WebKit::WebsiteDataStore::boundInterfaceIdentifier): Deleted.
(WebKit::WebsiteDataStore::setAllowsCellularAccess): Deleted.
(WebKit::WebsiteDataStore::allowsCellularAccess): Deleted.
(WebKit::WebsiteDataStore::setProxyConfiguration): Deleted.
(WebKit::WebsiteDataStore::proxyConfiguration): Deleted.
- 5:08 PM Changeset in webkit [257537] by
-
- 7 edits in trunk/Source
Unreviewed unified source builds fix.
Source/WebCore:
layout\FormattingContextGeometry.cpp(564): error C2027: use of undefined type 'WebCore::Layout::ReplacedBox
Modules\websockets\WebSocket.cpp(335): error C2027: use of undefined type 'WebCore::WorkerThread'
layout\integration\LayoutIntegrationBoxTree.cpp(63): error C2039: 'InlineTextBox': is not a member of 'WebCore::Layout'
workers\service\context\ServiceWorkerFetch.cpp(143): error C2027: use of undefined type 'WebCore::ServiceWorkerThread'
- Modules/websockets/WebSocket.cpp:
- layout/FormattingContextGeometry.cpp:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
- layout/integration/LayoutIntegrationBoxTree.cpp:
- workers/service/context/ServiceWorkerFetch.cpp:
Source/WebKit:
NetworkProcess\WebStorage\LocalStorageDatabase.cpp(59): error C2653: 'RunLoop': is not a class or namespace name
- NetworkProcess/WebStorage/LocalStorageDatabase.cpp:
- 5:01 PM Changeset in webkit [257536] by
-
- 3 edits2 adds in trunk
Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode
https://bugs.webkit.org/show_bug.cgi?id=208115
<rdar://problem/56685655>
Patch by Jack Lee <Jack Lee> on 2020-02-26
Reviewed by Ryosuke Niwa.
When inserting a list at an element with a non-list-item child, if the element is uneditable, skip creating list item for the child.
Source/WebCore:
Test: fast/lists/insert-list-uneditable-element-with-non-li-child.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):
LayoutTests:
- fast/lists/insert-list-uneditable-element-with-non-li-child-expected.txt: Added.
- fast/lists/insert-list-uneditable-element-with-non-li-child.html: Added.
- 4:53 PM Changeset in webkit [257535] by
-
- 2 edits in trunk/LayoutTests
[mac-sierra] LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=165311
Unreviewed test gardening.
I have removed this expectation because the issue appears to be resolved.
- platform/mac/TestExpectations:
- 4:47 PM Changeset in webkit [257534] by
-
- 9 edits in trunk
Unreviewed, rolling out r257508.
This commit broke the watchos build
Reverted changeset:
"[iOS] Issue mach sandbox extensions to the WebContent process
for a set of specific services"
https://bugs.webkit.org/show_bug.cgi?id=208146
https://trac.webkit.org/changeset/257508
- 4:42 PM Changeset in webkit [257533] by
-
- 4 edits in branches/safari-610.1.5-branch
Cherry-pick r257364. rdar://problem/59826931
REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
https://bugs.webkit.org/show_bug.cgi?id=208199
<rdar://problem/59746887>
Reviewed by Alex Christensen.
Source/WebKit:
Make sure we launch the initial WKWebView's WebProcess when a drag enters the view, so that the drag & drop
logic still works on empty views.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:42 PM Changeset in webkit [257532] by
-
- 25 edits1 add in branches/safari-610.1.5-branch
Revert r256784. rdar://problem/59818035
- 4:30 PM Changeset in webkit [257531] by
-
- 1 delete in tags/Safari-609.1.20.4.2
Delete tag.
- 4:29 PM Changeset in webkit [257530] by
-
- 53 edits1 delete in trunk
Add SPI to query WKFrameInfos in a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=208212
Reviewed by Brady Eidson.
Source/WebKit:
This adds WKWebView._allFrames and SPI on WKFrameInfo to look at parent and child frames.
This will help with rdar://problem/59783184 and other similar tasks.
In order to do this, I needed to make API::FrameInfo::create take a WebKit::FrameInfoData,
which I pass from the WebProcess. Where we used to pass only a SecurityOriginData,
we now pass a FrameInfoData which contains a SecurityOriginData and more information.
I needed to deprecate WKFrameCreateFrameInfo which had its last use removed in rdar://problem/59768710
because there was not enough information in its parameters to create a WKFrameInfo with this new data.
I also replaced the test-only SPI WKFrameInfoGetFrameHandleRef with WKFrameInfoCreateFrameHandleRef
so we don't need to keep a strong reference to the handle and other new members in API::FrameInfo.
New functionality covered by API tests and I removed the last tests' use of now-deprecated WKFrameCreateFrameInfo.
- Shared/FrameInfoData.cpp:
(WebKit::FrameInfoData::encode const):
(WebKit::FrameInfoData::decode):
- Shared/FrameInfoData.h:
- UIProcess/API/APIFrameInfo.cpp:
(API::FrameInfo::FrameInfo):
(API::FrameInfo::handle const):
(API::FrameInfo::parentFrameHandle const):
(API::FrameInfo::childFrameHandles const):
(): Deleted.
- UIProcess/API/APIFrameInfo.h:
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didFailProvisionalLoadInSubframeWithError):
- UIProcess/API/APIUIClient.h:
(API::UIClient::runJavaScriptAlert):
(API::UIClient::runJavaScriptConfirm):
(API::UIClient::runJavaScriptPrompt):
(API::UIClient::runBeforeUnloadConfirmPanel):
(API::UIClient::runOpenPanel):
(API::UIClient::decidePolicyForGeolocationPermissionRequest):
(API::UIClient::runWebAuthenticationPanel):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameInfo):
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKFrameInfoRef.cpp:
(WKFrameInfoCreateFrameHandleRef):
(WKFrameInfoGetFrameHandleRef): Deleted.
- UIProcess/API/C/WKFrameInfoRef.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
(WKPageSetPageNavigationClient):
- UIProcess/API/Cocoa/WKFrameInfo.mm:
(-[WKFrameInfo securityOrigin]):
(-[WKFrameInfo _handle]):
(-[WKFrameInfo _parentFrameHandle]):
(-[WKFrameInfo _childFrameHandles]):
- UIProcess/API/Cocoa/WKFrameInfoPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allFrames:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::didFailProvisionalLoadInSubframeWithError):
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm:
(WebKit::SOAuthorizationCoordinator::tryAuthorize):
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::continueStartAfterDecidePolicy):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
(WebKit::UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel):
(WebKit::UIDelegate::UIClient::runOpenPanel):
(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
- UIProcess/PageClient.h:
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::ProvisionalPageProxy::decidePolicyForResponse):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync):
- UIProcess/ProvisionalPageProxy.h:
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::runPanel):
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrames):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runOpenPanel):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::runOpenPanel):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrameIDs const):
(WebKit::WebFrame::info const):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getAllFrames):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::saltForOrigin):
- 4:29 PM Changeset in webkit [257529] by
-
- 2 edits in trunk/Source/JavaScriptCore
Enhance JSObjectGetProperty() to mitigate against null object pointers.
https://bugs.webkit.org/show_bug.cgi?id=208275
<rdar://problem/59826325>
Reviewed by Robin Morisset.
- API/JSObjectRef.cpp:
(JSObjectGetProperty):
- 4:27 PM Changeset in webkit [257528] by
-
- 7 edits in branches/safari-609.1.20.4-branch
Fix incomplete patch. rdar://problem/59793495
- 4:24 PM Changeset in webkit [257527] by
-
- 8 edits in branches/safari-609.1.20.0-branch
Unreviewed build fix, rdar://problem/59773377
- 4:12 PM Changeset in webkit [257526] by
-
- 7 edits in branches/safari-609.1.20.111-branch
Unreviewed build fix, rdar://problem/59793495
- 3:59 PM Changeset in webkit [257525] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] media/modern-media-controls/pip-support/pip-support-click.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=208272
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:59 PM Changeset in webkit [257524] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make testair pass on arm64
https://bugs.webkit.org/show_bug.cgi?id=208258
Reviewed by Tadeu Zagallo.
testElideMoveThenRealloc and testElideSimpleMove were never tested
on arm64. This patch makes those tests work.
- testElideMoveThenRealloc was using a BitImm that is invalid on arm64
- testElideSimpleMove was testing for the wrong disassembly
- b3/air/testair.cpp:
- 3:36 PM Changeset in webkit [257523] by
-
- 2 edits in trunk/LayoutTests
[WebGL] Unskip runnable WebGL 2.0.0 conformance suite for mac
https://bugs.webkit.org/show_bug.cgi?id=208078
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:30 PM Changeset in webkit [257522] by
-
- 5 edits2 adds in trunk/Tools
TestWebKitAPI and WebKitTestRunner should have bundle identifiers
https://bugs.webkit.org/show_bug.cgi?id=208260
<rdar://problem/59820107>
Reviewed by Tim Horton.
Followed instructions for adding an Info.plist for Single-File Tools
found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/Info.plist: Added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- WebKitTestRunner/Info.plist: Added.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 3:27 PM Changeset in webkit [257521] by
-
- 20 edits in trunk/Source
Allow setting of stack sizes for threads
https://bugs.webkit.org/show_bug.cgi?id=208223
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
Specify ThreadType at the Thread::create callsite.
- heap/Heap.cpp:
(JSC::Heap::notifyIsSafeToCollect):
Source/WebCore:
Specify ThreadType at the Thread::create callsite.
- Modules/webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::startRendering):
- bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
- platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::loaderRunLoop):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::getRunLoop):
- platform/network/curl/CurlRequestScheduler.cpp:
(WebCore::CurlRequestScheduler::startThreadIfNeeded):
- platform/network/curl/CurlStreamScheduler.cpp:
(WebCore::CurlStreamScheduler::startThreadIfNeeded):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::start):
Source/WebKit:
Specify ThreadType at the Thread::create callsite.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::createRunLoop):
Source/WTF:
Introduce ThreadType which is used internally to specify a stack size for a particular
type of thread. Platforms can make their own decisions on what the stack size should be
based on their own observations. Additionally a default stack size can be specified
by defining DEFAULT_THREAD_STACK_SIZE_IN_KB if the default stack for a platform is
insufficient in all cases, or when investigating the stack size for tuning.
Both the pthread and Windows thread implementations are modified to set the stack size
if provided.
- wtf/Threading.cpp:
(WTF::stackSize):
(WTF::Thread::create):
- wtf/Threading.h:
- wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::establishHandle):
- wtf/win/ThreadingWin.cpp:
(WTF::Thread::establishHandle):
- 2:52 PM Changeset in webkit [257520] by
-
- 2 edits in trunk/Websites/webkit.org
Prevented text selection on logo and header navigation
https://bugs.webkit.org/show_bug.cgi?id=208157
Reviewed by Devin Rousso.
- wp-content/themes/webkit/style.css:
(.site-logo):
(header nav):
- 2:44 PM Changeset in webkit [257519] by
-
- 5 edits in trunk
Tests should each use a unique ResourceLoadStatistics file path for its database store
https://bugs.webkit.org/show_bug.cgi?id=208206
<rdar://problem/59690272>
Reviewed by Brady Eidson.
Source/WebKit:
The ResourceLoadStatistics directory was being set to a non-unique
default value before being created at the temporary path generated by
WebKitTestRunner. This was causing crashes and concurrency issues in tests
when multiple database stores at the same path are accessed
simultaneously.
This patch updates WebProcessPool.cpp to treat the
resourceLoadStatisticsDirectory parameter like it does with IndexedDB
to avoid initializing multiple databases at the same file path.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::openAndDropOldDatabaseIfNecessary):
We should use SQLiteFileSystem::deleteDatabaseFile because it takes
care of additional SQLite files automatically.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::populateMemoryStoreFromDisk):
Checks if the path is empty because we no longer
guarantee that the resourceLoadStatisticsDirectory is set. Also checks
if m_statisticsStore is initialized before trying to grandfather
statistics.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
Checks if a default WebsiteDataStore exists before setting the
parameter to the default value. This way, the parameter is empty if
WebKitTestRunner hasn't yet set the temporary directory and we won't
create a new database.
Tools:
Initialize a default website data store before checking for the ITP
store to ensure the directory exists after the file has been deleted.
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 2:41 PM Changeset in webkit [257518] by
-
- 19 edits in trunk
[Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
https://bugs.webkit.org/show_bug.cgi?id=197684
<rdar://problem/59467397>
Reviewed by Yusuke Suzuki.
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
Ensure that the CacheStorage directory is actually being created.
- NetworkProcess/cache/NetworkCacheData.cpp:
- NetworkProcess/cache/NetworkCacheData.h:
- NetworkProcess/cache/NetworkCacheDataCocoa.mm:
- NetworkProcess/cache/NetworkCacheDataSoup.cpp:
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
Use more FileSystem functionality to share code across platforms.
- NetworkProcess/cache/NetworkCacheDataCurl.cpp:
Use Optional<Vector> for m_buffer since we need to differentiate isEmpty and isNull.
Source/WTF:
- wtf/FileSystem.cpp:
- wtf/FileSystem.h:
Added FileAccessPermission flag when opening files.
Remove default argument for the listDirectory filter since the defaut
String() filter doesn't match all files on Mac and Windows.
Added FileOpenMode::ReadWrite to be used with ReadWrite MappedFileData.
Added failIfFileExists flag to openFile.
- wtf/glib/FileSystemGlib.cpp:
- wtf/posix/FileSystemPOSIX.cpp:
Added (S_IRUSR | S_IWUSR) file open modes.
- wtf/win/FileSystemWin.cpp:
Implement getVolumeFreeSpace since some of the tests use it when toggling cache.
- wtf/win/PathWalker.cpp:
Tools:
Add test for FileSystem::createFile
- TestWebKitAPI/Tests/WTF/FileSystem.cpp:
LayoutTests:
- platform/wincairo/TestExpectations:
- 2:39 PM Changeset in webkit [257517] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 Release ] fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208264
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:32 PM Changeset in webkit [257516] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208245
Unreviewed test gardening.
Removed the test expectations.
- platform/ios-wk2/TestExpectations:
- 1:58 PM Changeset in webkit [257515] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208253
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 1:56 PM Changeset in webkit [257514] by
-
- 1 copy in tags/Safari-609.1.20.4.2
Tag Safari-609.1.20.4.2.
- 1:55 PM Changeset in webkit [257513] by
-
- 1 edit in branches/safari-609.1.20.4-branch/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
Unreviewed build fix. rdar://problem/59793495
- 1:50 PM Changeset in webkit [257512] by
-
- 1 delete in tags/Safari-609.1.20.0.6
Delete tag.
- 1:49 PM Changeset in webkit [257511] by
-
- 1 delete in tags/Safari-609.1.20.4.2
Delete tag.
- 1:47 PM Changeset in webkit [257510] by
-
- 1 edit in branches/safari-609.1.20.111-branch/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
Unreviewed build fix, rdar://problem/59793495
- 1:39 PM Changeset in webkit [257509] by
-
- 14 edits in trunk/LayoutTests
[WebGL] Garden dedicated queue
https://bugs.webkit.org/show_bug.cgi?id=204547
Unreviewed test gardening.
One more pass to stabilize the WebGL bot.
- platform/ios/TestExpectations: Remove reference to non-existent test.
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/acos-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/acosh-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/cosh-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/fract-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/pow-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/reflect-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/builtinprecision/sinh-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/pixelbufferobject-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/texturefiltering/2d_combinations_01-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/texturefiltering/cube_combinations_01-expected.txt:
- webgl/2.0.0/deqp/functional/gles3/texturespecification/basic_copyteximage2d-expected.txt:
- webgl/TestExpectations:
- 1:38 PM Changeset in webkit [257508] by
-
- 9 edits in trunk
[iOS] Issue mach sandbox extensions to the WebContent process for a set of specific services
https://bugs.webkit.org/show_bug.cgi?id=208146
Reviewed by Brent Fulgham.
Source/WebKit:
We are still seeing some accesses from the WebContent process to a small set of services. Since we do not currently have
backtraces for these accesses, make a speculative patch, where we issue these extension for all apps except Safari.
Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup-mail.html:
- 1:30 PM Changeset in webkit [257507] by
-
- 6 edits1 add in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] Decouple regular and pre-computed margin collapsing logic
https://bugs.webkit.org/show_bug.cgi?id=208247
<rdar://problem/59808951>
Reviewed by Antti Koivisto.
The pre-computed path is so peculiar it deserves a dedicated file.
This is in preparation for fixing a flaw in the pre-computed logic where we end up
accessing a not-yet-computed horizontal constraint. No change in functionality at this point.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedMarginBefore): Deleted.
- layout/blockformatting/PrecomputedBlockMarginCollapse.cpp: Added.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeMarginBefore const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedMarginBefore):
- layout/integration/LayoutIntegrationBoxTree.cpp:
- 1:21 PM Changeset in webkit [257506] by
-
- 1 edit1 add in trunk/LayoutTests
Regression r257289: fast/web-share/share-with-files.html is missing expected results
https://bugs.webkit.org/show_bug.cgi?id=208191
Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2020-02-26
Reviewed by Tim Horton.
Added expected for new test.
- fast/web-share/share-with-files-expected.txt: Added.
- 1:12 PM Changeset in webkit [257505] by
-
- 10 edits in trunk/Source
Add logging to help diagnose redirect issue
https://bugs.webkit.org/show_bug.cgi?id=207916
<rdar://problem/59567875>
Reviewed by Chris Dumez.
We're seeing an issue where communication between the WebContent
process and the Network process seems to come to a stop between
NetworkResourceLoader::continueWillSendRedirectedRequest and
NetworkResourceLoader::continueWillSendRequest. We do see a
WebResourceLoader::willSendRequest log line between those two
NetworkResourceLoader logging lines, but nothing else. Add a bunch of
logging in this area to help determine what's happening.
Source/WebCore:
No new tests -- no new or changed functionality.
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::init):
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::redirectReceived):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::redirectReceived):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequestAfterRedirection const):
Source/WebKit:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
- 1:10 PM Changeset in webkit [257504] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing
https://bugs.webkit.org/show_bug.cgi?id=208251
<rdar://problem/59812765>
Reviewed by Timothy Hatcher.
- UserInterface/Models/SourceCode.js:
(WI.SourceCode):
The test failed because it expectedurlto be an empty string ("") instead ofnull.
Use the givenurlparameter exactly as provided instead of trying to add a fallback in the
case of a falsy value. Given the prevalence of usage ofWI.SourceCode, it's better to
match the existing behavior of before r257410 than change it and risk other subtle bugs.
- 12:57 PM Changeset in webkit [257503] by
-
- 3 edits in trunk/Source/WebKit
Make sure a client cannot cause a whole DOM tree to get leaked by simply holding on to a WKBundleNodeHandle
https://bugs.webkit.org/show_bug.cgi?id=208218
Reviewed by Ryosuke Niwa.
Make sure a client cannot cause a whole DOM tree to get leaked by simply holding on to a WKBundleNodeHandle.
Previously, WKBundleNodeHandle would ref its node, which would keep the whole HTML document alive. To protect
against this, InjectedBundleNodeHandle is now an ActiveDOMObject which nulls out its node RefPtr when the
document is getting ready for destruction (i.e. ActiveDOMObject::stop() is called).
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::InjectedBundleNodeHandle):
(WebKit::InjectedBundleNodeHandle::~InjectedBundleNodeHandle):
(WebKit::InjectedBundleNodeHandle::coreNode):
(WebKit::InjectedBundleNodeHandle::document):
(WebKit::InjectedBundleNodeHandle::elementBounds):
(WebKit::InjectedBundleNodeHandle::renderRect):
(WebKit::InjectedBundleNodeHandle::renderedImage):
(WebKit::InjectedBundleNodeHandle::visibleRange):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementSpellcheckEnabled):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFilled const):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFilledAndViewable const):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFilledAndViewable):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFillButtonEnabled const):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFillButtonEnabled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementAutoFillButtonType const):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastAutoFillButtonType const):
(WebKit::InjectedBundleNodeHandle::isAutoFillAvailable const):
(WebKit::InjectedBundleNodeHandle::setAutoFillAvailable):
(WebKit::InjectedBundleNodeHandle::htmlInputElementAutoFillButtonBounds):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField const):
(WebKit::InjectedBundleNodeHandle::htmlTableCellElementCellAbove):
(WebKit::InjectedBundleNodeHandle::documentFrame):
(WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::stop):
(WebKit::InjectedBundleNodeHandle::activeDOMObjectName const):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- 12:05 PM Changeset in webkit [257502] by
-
- 3 edits in trunk/Source/WebCore
Clean up HitTestLocation.h
https://bugs.webkit.org/show_bug.cgi?id=208254
<rdar://problem/59815136>
Reviewed by Jer Noble.
Use modern C++ features to remove duplicate code.
- rendering/HitTestLocation.cpp:
(WebCore::HitTestLocation::HitTestLocation):
- rendering/HitTestLocation.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
- rendering/HitTestResult.h: Remove unnecessary #includes. This file only needs
to include RoundedRect.h: RoundedRect.h includes FloatQuad.h and LayoutRect.h
and FloatQuad.h will include FloatRect.h. We do not make use of have declarations
in <wtf/Forward.h> so remove that as well.
- 11:54 AM Changeset in webkit [257501] by
-
- 3 edits in trunk/LayoutTests
Update WPT tests for Intersection Observer
https://bugs.webkit.org/show_bug.cgi?id=208053.
Unreviewed test gardening
Skipping tests that do not have an expected file.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 11:45 AM Changeset in webkit [257500] by
-
- 2 edits in branches/safari-609-branch/Source/WebKit
Apply patch. rdar://problem/59793496
- 11:45 AM Changeset in webkit [257499] by
-
- 1 edit in branches/safari-609-branch/Source/JavaScriptCore/runtime/StructureTransitionTable.h
Apply patch. rdar://problem/59739154
- 11:42 AM Changeset in webkit [257498] by
-
- 2 edits in trunk/Tools
[ews] commit-queue should verify patch committer and reviewer
https://bugs.webkit.org/show_bug.cgi?id=206532
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
(ValidateCommiterAndReviewer._addToLog):
(ValidateCommiterAndReviewer.getResultSummary):
(ValidateCommiterAndReviewer.fail_build):
(ValidateCommiterAndReviewer.load_contributors): Load contributors information.
(ValidateCommiterAndReviewer.is_reviewer):
(ValidateCommiterAndReviewer.is_committer):
(ValidateCommiterAndReviewer.full_name_from_email):
(ValidateCommiterAndReviewer.start):
- 11:39 AM Changeset in webkit [257497] by
-
- 2 edits in branches/safari-609.1.20.3-branch/Source/WebKit
Cherry-pick r257013. rdar://problem/59789399
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:38 AM Changeset in webkit [257496] by
-
- 1 copy in tags/Safari-609.1.20.0.6
Tag Safari-609.1.20.0.6.
- 11:35 AM Changeset in webkit [257495] by
-
- 8 edits in branches/safari-609.1.20.3-branch/Source
Versioning.
- 11:34 AM Changeset in webkit [257494] by
-
- 2 edits in branches/safari-609.1.20.0-branch/Source/WebKit
Apply patch. rdar://problem/59773377
- 11:30 AM Changeset in webkit [257493] by
-
- 8 edits in branches/safari-609.1.20.0-branch/Source
Versioning.
- 11:22 AM Changeset in webkit [257492] by
-
- 2 edits in branches/safari-609.1.20.2-branch/Source/WebKit
Cherry-pick r257013. rdar://problem/59789392
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:21 AM Changeset in webkit [257491] by
-
- 1 copy in tags/Safari-609.1.20.4.2
Tag Safari-609.1.20.4.2.
- 11:19 AM Changeset in webkit [257490] by
-
- 8 edits in branches/safari-609.1.20.2-branch/Source
Versioning.
- 11:19 AM Changeset in webkit [257489] by
-
- 2 edits in branches/safari-609.1.20.4-branch/Source/WebKit
Apply patch. rdar://problem/59793495
- 11:19 AM Changeset in webkit [257488] by
-
- 2 edits in branches/safari-609.1.20.4-branch/Source/WebKit
Cherry-pick r257013. rdar://problem/59789394
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:19 AM Changeset in webkit [257487] by
-
- 9 edits in trunk
[iOS] Send focus update immediately on becoming or resigning first responder
https://bugs.webkit.org/show_bug.cgi?id=208082
<rdar://problem/59688413>
Rubber-stamped by Jer Noble.
Source/WebKit:
Send an activity state change immediately to the web process when the WKWebView becomes first
responder or resigns first responder.
Currently -becomeFirstResponderForWebView and -resignFirstResponderForWebView schedule an activity
state change message to be sent to the web process. This message will never be delivered within the
same event loop iteration. As a result, performing operations that requires the page to be focused
(e.g. selecting a position at a point) in the same event loop iteration as a call to -[WKWebView becomeFirstResponder])
will not work.
While I am in this area of the code simplify callers of activityStateDidChange() by changing its
parameter order such that it takes a dispatch mode before wantsSynchronousReply. The latter is
almost always defaulted to false to schedule an async message to the web process. Additionally,
changed wantsSynchronousReply from a boolean to an enumeration, ActivityStateChangeReplyMode, and
renamed the param to replyMode. The enumerators are self-documenting at the call site unlike the
boolean.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::prepareForMoveToWindow):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activityStateDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKApplicationStateTrackingView.mm:
(-[WKApplicationStateTrackingView _applicationWillEnterForeground]):
Update code for new parameter ordering and pass a ActivityStateChangeReplyMode enumerator.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView becomeFirstResponderForWebView]):
(-[WKContentView resignFirstResponderForWebView]):
Pass WebKit::WebPageProxy::ActivityStateChangeDispatchMode::Immediate to activityStateDidChange()
to dispatch the update immediately to the web process.
Tools:
Add a test to ensure that selecting a position at a point after the web view
becomes first responder is allowed. Such an operation is only allowed if the
web view is focused.
- TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
(-[TestWKWebView selectPositionAtPoint:]):
(TEST):
- TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
- 11:07 AM Changeset in webkit [257486] by
-
- 2 edits in branches/safari-609.1.20.111-branch/Source/WebKit
Apply patch. rdar://problem/59793495
- 11:07 AM Changeset in webkit [257485] by
-
- 2 edits in branches/safari-609.1.20.111-branch/Source/WebKit
Cherry-pick r257013. rdar://problem/59789394
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:06 AM Changeset in webkit [257484] by
-
- 8 edits in branches/safari-609.1.20.4-branch/Source
Versioning.
- 11:00 AM Changeset in webkit [257483] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, rolling out r257471.
Causes crashes on the bots
Reverted changeset:
"Unreviewed, fix debug asserts on the bots after r257389."
https://trac.webkit.org/changeset/257471
- 10:58 AM Changeset in webkit [257482] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, rolling out r257389.
Reverted changeset:
"Make sure a client cannot cause a whole DOM tree to get
leaked by simply holding on to a WKBundleNodeHandle"
https://bugs.webkit.org/show_bug.cgi?id=208218
https://trac.webkit.org/changeset/257389
- 10:45 AM Changeset in webkit [257481] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r257373.
This commit introduced one test that is a flaky failure on ios
bots and broke another test
Reverted changeset:
"[iPadOS] REGRESSION(r247667): Autosizing style changes don't
invalidate RenderText's preferred logical widths"
https://bugs.webkit.org/show_bug.cgi?id=208084
https://trac.webkit.org/changeset/257373
- 10:34 AM Changeset in webkit [257480] by
-
- 8 edits in branches/safari-609.1.20.111-branch/Source
Versioning.
- 9:53 AM Changeset in webkit [257479] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r257470.
This broke the build for tvOS and watchOS
Reverted changeset:
"Conversion between MediaSample and RemoteVideoSample should
preserve the rotation information"
https://bugs.webkit.org/show_bug.cgi?id=208240
https://trac.webkit.org/changeset/257470
- 9:15 AM Changeset in webkit [257478] by
-
- 9 edits in trunk/Source/WebKit
GPUProcess should be made aware of device orientation for correct video capture frame rotation computation
https://bugs.webkit.org/show_bug.cgi?id=208242
Reviewed by Eric Carlson.
Pipe orientation information to GPUProcess whenever a page has a user media capture manager proxy.
This is used by AVVideoCaptureSource to compute the correct video sample rotation value.
Manually tested.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::setOrientationForMediaCapture):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::setMockCaptureDevicesEnabled):
(WebKit::GPUProcess::setOrientationForMediaCapture):
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::setOrientationForMediaCapture):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/WebPageProxy.cpp:
- 9:13 AM Changeset in webkit [257477] by
-
- 2 edits in trunk/Tools
Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
The test was added for macOS and times out on iOS.
- TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
(TEST):
- 9:13 AM Changeset in webkit [257476] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208245
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 9:10 AM Changeset in webkit [257475] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257474 - Unreviewed build fix for non-unified builds with assertions enabled.
- css/CSSImageSetValue.cpp: Add missing include.
- 9:04 AM Changeset in webkit [257474] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for non-unified builds with assertions enabled.
- css/CSSImageSetValue.cpp: Add missing include.
- 8:16 AM Changeset in webkit [257473] by
-
- 10 edits in trunk/Source/WebCore
AXIsolatedObject support for table column objects.
https://bugs.webkit.org/show_bug.cgi?id=208215
Reviewed by Chris Fleizach.
Covered by existing tests.
- AccessibilityTableColumn interface is now exposed through
AXCoreObject.
- Separated isTableColumn from isAccessibilityTableColumnInstance.
- This eliminates to need to downcast in the wrapper code, and hence
makes it possible that the same code works for both AccessibilityObjects
and AXIsolatedObjects.
- Completed the caching of table column properties in AXIsolatedObject.
- Some minor code cleanup.
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren): Removed unnecessary cast.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren): Removed unnecessary cast.
(WebCore::AccessibilityTable::columnHeaders):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::columnHeader):
(WebCore::AccessibilityTableColumn::headerObject): Renamed columnHeader.
- accessibility/AccessibilityTableColumn.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::isAccessibilityTableColumnInstance const):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 7:57 AM Changeset in webkit [257472] by
-
- 12 edits in trunk
Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
https://bugs.webkit.org/show_bug.cgi?id=208238
Reviewed by Eric Carlson.
Source/WebKit:
We can use page preferences instead of pool preferences for audio/video capture.
This allows removing code and is more up to date.
Manually tested.
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/C/WKContextConfigurationRef.cpp:
- UIProcess/API/C/WKContextConfigurationRef.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::updateBoolValueForInternalDebugFeatureKey):
(WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
(TEST):
Remove use of deleted parameter.
- 7:56 AM Changeset in webkit [257471] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix debug asserts on the bots after r257389.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::create):
- 7:29 AM Changeset in webkit [257470] by
-
- 9 edits in trunk/Source
Conversion between MediaSample and RemoteVideoSample should preserve the rotation information
https://bugs.webkit.org/show_bug.cgi?id=208240
Reviewed by Eric Carlson.
Source/WebCore:
Update RemoteVideoSample to have surface getter be const.
Add a new routine to convert a RemoteVideoSample in a MediaSample, with proper rotation and mirrored information.
Covered by manual testing.
- platform/graphics/RemoteVideoSample.cpp:
(WebCore::RemoteVideoSample::surface const):
- platform/graphics/RemoteVideoSample.h:
(WebCore::RemoteVideoSample::mirrored const):
- platform/graphics/cv/ImageTransferSessionVT.h:
- platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::createMediaSample):
Source/WebKit:
Use new routine that preserves rotation.
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSample):
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::remoteVideoSampleAvailable):
- 7:05 AM Changeset in webkit [257469] by
-
- 3 edits2 adds in trunk
[LFC][IFC][Floats] ASSERT(committedInlineItemCount line.hasIntrusiveFloat()) in LineLayoutContext::close https://bugs.webkit.org/show_bug.cgi?id=208230
<rdar://problem/59791249>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/float-and-br-inline-content-only.html
Expand the ASSERT to include all the valid cases
- Inline content is added to the line
- Only float(s) got processed (no inline content)
- Neither floats not inline content got processed due to intrusive floats.
(This patch slightly rearranges the body of LineLayoutContext::commitFloats and also fixes an off-by-1 error in LineLayoutContext::close.)
- layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::commitFloats):
LayoutTests:
- fast/layoutformattingcontext/float-and-br-inline-content-only-expected.html: Added.
- fast/layoutformattingcontext/float-and-br-inline-content-only.html: Added.
- 6:45 AM Changeset in webkit [257468] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Correctly remove webvttenc on WebKitTextCombiner pad release
https://bugs.webkit.org/show_bug.cgi?id=208234
Reviewed by Xabier Rodriguez-Calvar.
The implementation of webkitTextCombinerReleasePad() was wrong in that
it was checking the peer pad of webkittextcombinerpad to check if it
belonged a webvttenc element and remove it... But since this is a
ghostpad, the peer is upstream, not downstream. When the release pad
function is called, upstream is already disconnected, so the branch
was never hit.
To actually remove the webvttenc element we must check the target pad
instead of the peer pad, which corresponds to the element downstream.
Also, we need to set the element state to NULL before removing it,
which the previous code didn't.
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerReleasePad):
- 6:12 AM Changeset in webkit [257467] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Update fast/forms/number/number-size.html after r257299
Since r257299 the GTK port specific behavior is no longer needed, so we can remove the widthSpecified function
and use the specified value directly.
- fast/forms/number/number-size-expected.txt:
- fast/forms/number/number-size.html:
- 6:06 AM Changeset in webkit [257466] by
-
- 6 edits in trunk
[JSC][MIPS] Adding support to Checkpoints
https://bugs.webkit.org/show_bug.cgi?id=208196
Reviewed by Yusuke Suzuki.
JSTests:
- microbenchmarks/memcpy-typed-loop.js:
Source/JavaScriptCore:
This patch is adding changes to properly support OSR to
checkpoints on MIPS. It required fixes on JIT probe and some
adjustment on Offlineasm to correct generate$gpload when executing
checkpoint_osr_exit_from_inlined_call_trampoline.
- assembler/MacroAssemblerMIPS.cpp:
Probe trampoline needs to allocate 16 bytes for 4 arguments to
properly follow C calling conventions. This space is used by callee
when the JSC is compiled with-O0flags
(Check "DEFAULT C CALLING CONVENTION (O32)" section on
https://www.mips.com/downloads/mips32-instruction-set-quick-reference-v1-01).
- llint/LowLevelInterpreter.asm:
As we need to do on ARMv7, 64-bits arguments needs to be passed in
register pairs$a1:$a0or$a3:$a2(little-endian mode). Since$a0
contaisCallFrame*, we need to passEncodedJSValueon$a3:$a2
pair.
- offlineasm/mips.rb:
Following the same reason for return locations on OSR to LLInt, we
need to adjust$gpusing$rainstead of$t9on
checkpoint_osr_exit_from_inlined_call_trampoline, given it is only
reachable throughretoperations. For detailed explanation, check
ChangeLog of https://trac.webkit.org/changeset/252713.
- 5:37 AM Changeset in webkit [257465] by
-
- 20 edits in trunk/Source
Remove throttling code from RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=208135
<rdar://problem/59765410>
Unreviewed partial revert.
Source/WebCore:
Keep using the "flush" naming in GraphicsLayerClient.
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::notifyFlushRequired):
(WebCore::PageOverlayController::notifyRenderingUpdateRequired): Deleted.
- page/PageOverlayController.h:
- page/linux/ResourceUsageOverlayLinux.cpp:
- page/mac/ServicesOverlayController.h:
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):
(WebCore::ServicesOverlayController::Highlight::notifyRenderingUpdateRequired): Deleted.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::notifyRenderingUpdateRequired): Deleted.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
(WebCore::RenderLayerBacking::notifyRenderingUpdateRequired): Deleted.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::notifyFlushRequired):
(WebCore::RenderLayerCompositor::notifyRenderingUpdateRequired): Deleted.
- rendering/RenderLayerCompositor.h:
Source/WebKit:
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::notifyFlushRequired):
(WebKit::CompositingCoordinator::notifyRenderingUpdateRequired): Deleted.
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::notifyFlushRequired):
(WebView::notifyRenderingUpdateRequired): Deleted.
- WebView.h:
- 5:12 AM Changeset in webkit [257464] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257416 - Unreviewed build fix for non-unified builds.
- bindings/js/JSAnimationTimelineCustom.cpp: Add missing header include.
- 4:35 AM Changeset in webkit [257463] by
-
- 6 edits1 add in trunk/Source/WebCore
[GL][GStreamer] Instantiate GstGLContext when the shared GLContext is created
https://bugs.webkit.org/show_bug.cgi?id=200626
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-02-26
Reviewed by Carlos Garcia Campos.
This patch adds GstGLContext and GstGLDisplay as part of
PlatformDisplay.
Right now one GstGLContext is created per video tag, which is a
wrapper of the GL shared context. Every time this wrapper is
created the GL context has to be current in order to initialize
the wrapper's internal state.
A better approach would be to have a single GstGLContext per GL
context, to instantiate it when the GL context is created and
current. This GstGLContext would be used for all media players.
GstGLContext and GstGLDisplay are instantiated as singletons by
PlatformDisplay. When the media player request for the
GstGLContext a GL context is instantiated, if it wasn't before,
and wraps it. PlatformDisplay adds two getters, one for
GstGLContext object, and other for GstGLDisplay. Both are used to
configure the internal GStreamer GL context in the multimedia
pipeline.
No new tests are needed.
- platform/GStreamer.cmake:
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::terminateEGLDisplay):
- platform/graphics/PlatformDisplay.h:
- platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(requestGLContext):
(webKitGLVideoSinkChangeState):
(webKitGLVideoSinkProbePlatform):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp: Added.
(createGstGLDisplay):
(PlatformDisplay::tryEnsureGstGLContext):
(PlatformDisplay::gstGLDisplay const):
(PlatformDisplay::gstGLContext const):
- 3:50 AM Changeset in webkit [257462] by
-
- 5 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257417 - DocumentTimeline / CSSTransition objects are leaking on CNN.com
https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>
Reviewed by Antoine Quint.
Break reference cycle between DocumentTimeline and WebAnimation by using WeakPtr.
- animation/AnimationTimeline.h:
- animation/DocumentTimeline.h:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::timeline const):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::enqueueAnimationEvent):
(WebCore::WebAnimation::acceleratedStateDidChange):
- animation/WebAnimation.h:
(WebCore::WebAnimation::timeline const): Deleted.
- 2:58 AM Changeset in webkit [257461] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257408 - ASSERTION FAILURE in AppendNodeCommand::AppendNodeCommand when inserting list with read-only user-modify
https://bugs.webkit.org/show_bug.cgi?id=208045
<rdar://problem/39023383>
Patch by Jack Lee <Jack Lee> on 2020-02-25
Reviewed by Ryosuke Niwa.
When inserting a list (InsertListCommand) around enclosed list items, if new list is not editable, skip moving list items in function doApplyForSingleParagraph.
Source/WebCore:
Test: fast/lists/insert-list-user-modify-read-only-enclosed-li.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
LayoutTests:
- fast/lists/insert-list-user-modify-read-only-enclosed-li-expected.txt: Added.
- fast/lists/insert-list-user-modify-read-only-enclosed-li.html: Added.
- 2:58 AM Changeset in webkit [257460] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257407 - Nullptr crash in CompositeEditCommand::splitTreeToNode
https://bugs.webkit.org/show_bug.cgi?id=208039
<rdar://problem/52011355>
Patch by Jack Lee <Jack Lee> on 2020-02-25
Reviewed by Ryosuke Niwa.
When inserting a list (InsertListCommand) around orphaned list items, if unordered list is not editable, skip moving list items in function fixOrphanedListChild.
Source/WebCore:
Test: fast/lists/insert-list-user-modify-read-only-orphaned-li.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::fixOrphanedListChild):
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- editing/InsertListCommand.h:
LayoutTests:
- fast/lists/insert-list-user-modify-read-only-orphaned-li-expected.txt: Added.
- fast/lists/insert-list-user-modify-read-only-orphaned-li.html: Added.
- 2:58 AM Changeset in webkit [257459] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257361 - Assertion failed: currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate) https://bugs.webkit.org/show_bug.cgi?id=208144
Reviewed by Ryosuke Niwa.
Change a release assertion to release error log to gather information about bug. This is also the pattern of
handling error during schema update in SQLiteIDBBackingStore.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidObjectStoreInfoTable):
- 2:58 AM Changeset in webkit [257458] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WTF
Merge r257304 - [WPE] Enable BACKTRACE_SYMBOLS
https://bugs.webkit.org/show_bug.cgi?id=208187
Reviewed by Žan Doberšek.
- wtf/PlatformHave.h: Enable backtrace_symbols, to be combined
with dladdr() the stacktrace dumps will be improved.
- 2:58 AM Changeset in webkit [257457] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WTF
Merge r257298 - [Linux] StackTrace symbols are not demangled
https://bugs.webkit.org/show_bug.cgi?id=207933
Reviewed by Yusuke Suzuki.
Demangle symbols provided by backtrace_symbols.
- wtf/StackTrace.cpp:
(WTF::StackTrace::dump const):
- 2:58 AM Changeset in webkit [257456] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257292 - PS-2019-006: [GTK] WebKit - AXObjectCache - m_deferredFocusedNodeChange - UaF
https://bugs.webkit.org/show_bug.cgi?id=204342
Reviewed by Carlos Garcia Campos.
m_deferredFocusedNodeChange keeps pairs of a old node and a new one
to update a focused node later. When a node is removed in the document,
it is also removed from the pair vector. The problem is only comparing
the new node in each pair with a removed node decides the removal.
In the case where the removed node lives in m_deferredFocusedNodeChange
as an old node, a crash happens while we get a renderer of the removed node
to handle focused elements. To fix this, we find all entries of which old node
is matched to the removed node, and set their first value null.
No new tests since no functionality changed.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
- 2:58 AM Changeset in webkit [257455] by
-
- 5 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257235 - Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions
https://bugs.webkit.org/show_bug.cgi?id=208145
Reviewed by Antoine Quint.
Break reference cycles using WeakPtr so that CSSTransitions can no longer cause whole document / DOM trees to
get leaked.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
- animation/DocumentTimeline.h:
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::setTarget):
- animation/KeyframeEffect.h:
- 2:58 AM Changeset in webkit [257454] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r257222 - Protect WebProcessPool from null weak pointers in m_serviceWorkerProcesses map
https://bugs.webkit.org/show_bug.cgi?id=208143
rdar://problem/58285589
Reviewed by Alex Christensen.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateServiceWorkerUserAgent):
(WebKit::WebProcessPool::updateProcessAssertions):
When iterating through the map, make sure it does not have a null entry.
- 2:58 AM Changeset in webkit [257453] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257207 - RenderLayerBacking::notifyAnimationStarted calls directly into the old animation controller
https://bugs.webkit.org/show_bug.cgi?id=207979
Reviewed by Simon Fraser.
Only call into CSSAnimationController if the "Web Animations for CSS Animations" flag is disabled.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyAnimationStarted):
- 2:57 AM Changeset in webkit [257452] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257202 - [GStreamer][WPE] Add GstGLMemoryEGL support for the video-plane-display
https://bugs.webkit.org/show_bug.cgi?id=208046
Reviewed by Žan Doberšek.
The glupload element might fill EGL memories in some cases, so for
the video sink we can then directly access the corresponding
EGLImage and export it to DMABuf, instead of using the more
general GLMemory code path.
With this patch we also ensure that both DMABuf FD and stride are valid.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::handoffVideoDmaBuf):
- 2:57 AM Changeset in webkit [257451] by
-
- 4 edits in releases/WebKitGTK/webkit-2.28
Merge r257139 - [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
https://bugs.webkit.org/show_bug.cgi?id=207984
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-02-21
Reviewed by Daniel Bates.
Source/WebCore:
Fix the check for googleapis.com. Since it's now a public suffix, we can no longer check the
URL's base domain here. Instead, we can check endsWith().
I considered switching to endsWith() for all the checks in this file, to make our user agent
quirks robust to future changes in the public suffix list, but checking the base domain is
nicer and it seems unnecessary. We can continue to adjust our quirks in the future as
necessary.
The public suffix list:
https://github.com/publicsuffix/list/blob/7922d7c20e246552be418e8f72e577899fd30d99/public_suffix_list.dat#L11922
- platform/UserAgentQuirks.cpp:
(WebCore::isGoogle):
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- 2:57 AM Changeset in webkit [257450] by
-
- 9 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257138 - [Web Animations] Repeated animations on pseudo elements will fail to run after a while
https://bugs.webkit.org/show_bug.cgi?id=207993
Source/WebCore:
<rdar://problem/59428472>
Reviewed by Zalan Bujtas.
We failed to clear PseudoElement* from AnimationTimeline's various HashMaps on destruction,
causing animations to fail to run when those pointer addresses were reused.
Make DeclarativeAnimation::owningElement() be a WeakPtr<>.
Test: animations/many-pseudo-animations.html
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::willDestoryRendererForElement):
(WebCore::AnimationTimeline::elementWasRemoved):
- animation/AnimationTimeline.h:
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):
- animation/DeclarativeAnimation.h:
(WebCore::DeclarativeAnimation::owningElement const):
- dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::clearHostElement):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
LayoutTests:
Reviewed by Zalan Bujtas.
- animations/many-pseudo-animations-expected.txt: Added.
- animations/many-pseudo-animations.html: Added.
- 2:57 AM Changeset in webkit [257449] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257133 - [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14
https://bugs.webkit.org/show_bug.cgi?id=208041
Reviewed by Xabier Rodriguez-Calvar.
Replace usage of gst_clear_object and gst_clear_tag_list with previous
*_unref functions. The clear versions were added in 1.16 while Ubuntu
18.04 (current LTS) and Debian stable uses 1.14.
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerPadDispose):
- 2:57 AM Changeset in webkit [257448] by
-
- 11 edits in releases/WebKitGTK/webkit-2.28
Merge r257132 - Value sanitization for input[type=text] should not truncate a value at a control character
https://bugs.webkit.org/show_bug.cgi?id=207900
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline the tests. Below its a summary of the number of FAIL and PASS lines changed for each test:
- web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt: FAIL from 7312 to 374 PASS from 17 to 6955
- web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-han-expected.txt: FAIL from 21216 to 477 PASS from 53 to 20792
- web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-hangul-expected.txt: FAIL from 11155 to 0 PASS from 28 to 11183
- web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc-expected.txt: FAIL from 3422 to 46 PASS from 9 to 3385
- web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt: FAIL from 7375 to 374 PASS from 17 to 7018
- web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: FAIL from 20 to 10 PASS from 22 to 32
Source/WebCore:
Stop truncating value at a control character. The new behavior is compatible with Chrome and Firefox.
Inspired on Chromium patch https://codereview.chromium.org/189843008
Covered by existing tests: affected layout tests are modified to reflect the new behaviour.
This improves WPT pass-rate in around 49K new subtest passes for Japanesse encoding tests.
- html/TextFieldInputType.cpp:
(WebCore::limitLength):
LayoutTests:
Update layout tests to reflect the new behaviour.
- fast/forms/input-value-sanitization-expected.txt:
- fast/forms/input-value-sanitization.html:
- fast/forms/paste-multiline-text-input.html:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- 2:57 AM Changeset in webkit [257447] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257129 - Nullptr crash in RenderStyle::isFlippedBlocksWritingMode when fragment flow gains a new in-flow descendant
https://bugs.webkit.org/show_bug.cgi?id=207296
<rdar://problem/49687828>
Patch by Jack Lee <Jack Lee> on 2020-02-21
Reviewed by Antti Koivisto.
When a multi-column fragment flow gains a new in-flow descendant, we need to call
multiColumnDescendantInserted so RenderMultiColumnSet would be created for the new
descendant.
Source/WebCore:
Test: fast/multicol/fragflow-gains-new-in-flow-descendant-crash.html
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
LayoutTests:
- TestExpectations:
- fast/multicol/fragflow-gains-new-in-flow-descendant-crash-expected.txt: Added.
- fast/multicol/fragflow-gains-new-in-flow-descendant-crash.html: Added.
- 2:57 AM Changeset in webkit [257446] by
-
- 6 edits in releases/WebKitGTK/webkit-2.28
Merge r257128 - [GTK] Improve user agent quirk for Google Docs and Google Drive
https://bugs.webkit.org/show_bug.cgi?id=206506
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-02-20
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Stop using our macOS platform quirk for Google Docs and Google Drive. It is not successfully
suppressing the unsupported browser warnings that it was added to avoid. It is also
responsible for complaints from users who do not like seeing macOS-style shortcuts with
the Command key rather than Ctrl.
Replace it with a new Firefox browser quirk. We can avoid the unsupported browser warning in
Google Docs by using this quirk on accounts.youtube.com. There's no need for any other quirk
specific to Google Docs (although removing the macOS platform quirk means we'll instead
begin using the x86_64 Linux quirk that we send to other Google domains). Google Drive will
also use this new quirk.
Also, remove a stale comment instructing developers to test downloading the Hangouts browser
plugin. We no longer support NPAPI, so Google Hangouts is a lost cause until we get WebRTC
working.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresFirefoxBrowser):
(WebCore::urlRequiresMacintoshPlatform):
(WebCore::urlRequiresLinuxDesktopPlatform):
(WebCore::UserAgentQuirks::quirksForURL):
(WebCore::UserAgentQuirks::stringForQuirk):
- platform/UserAgentQuirks.h:
- platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
(TestWebKitAPI::TEST):
- 2:57 AM Changeset in webkit [257445] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257123 - Fix crash in Page::updateRendering when document has no domWindow
https://bugs.webkit.org/show_bug.cgi?id=207975
<rdar://56999099>
Patch by Sunny He <sunny_he@apple.com> on 2020-02-20
Reviewed by Ryosuke Niwa.
When a subframe is navigated, a new document is created and
the window is transfered asynchronously. It is possible to have
a call to updateRendering in the middle of this process, resulting
in an attempt to update a document with no window. Add a check for
this case and skip such documents.
No test, since this crash relies on sensitive timing that cannot be
consistently replicated in a test case.
- page/Page.cpp:
(WebCore::Page::updateRendering):
- 2:57 AM Changeset in webkit [257444] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r257103 - WebIDBServer resume should return early if suspend does not happen
https://bugs.webkit.org/show_bug.cgi?id=208027
<rdar://problem/59617654>
Reviewed by Geoffrey Garen.
We should not try releasing a lock that is not held.
- NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::resume):
- 2:57 AM Changeset in webkit [257443] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r257090 - [GStreamer] Fix race in TextCombinerGStreamer
https://bugs.webkit.org/show_bug.cgi?id=208001
Reviewed by Xabier Rodriguez-Calvar.
TextCombinerGStreamer uses the CAPS event to determine whether adding
a webvttenc between the text track pad and the funnel element used to
be able to display several subtitles at the same time.
The way this was done previously had a race though: all text track
pads were preemptively linked directly to the funnel, only adding the
webvttenc element later in the middle when receiving the CAPS event.
When two or more text tracks were present, it wasn't infrequent that
one track had its CAPS event processed (causing the webvttenc element
to be added) and propagated (fixating the funnel caps) before another
track attempted caps negotiation. Because the pads were connected to
the funnel preemptively, and because without the webvttenc element the
caps of the text pad don't match the funnel's, this causes a caps
mismatch error, stopping playback completely. The CAPS event is
therefore never sent.
To avoid this race, we must avoid linking elements until we get the
CAPS events, when we actually know where we should link them to,
therefore avoiding early caps negotiation errors.
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerPadDispose):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerReleasePad):
(webkit_text_combiner_class_init):
(webkitTextCombinerPadFinalize): Deleted.
- 2:56 AM Changeset in webkit [257442] by
-
- 3 edits in releases/WebKitGTK/webkit-2.28
Merge r257077 - REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
https://bugs.webkit.org/show_bug.cgi?id=208015
<rdar://problem/59591630>
Reviewed by Geoffrey Garen.
Source/WebKit:
Make sure we only restart the tryClose timer after the beforeunload prompt if the timer was actually
active before the prompt (i.e. tryClose was actually called). On Reload, tryClose is not called
but beforeunload prompt may still happen.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
(TEST):
- 2:56 AM Changeset in webkit [257441] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28
Merge r257067 - [GTK][WPE] Not set ccache compiler prefix if ccache its already the compiler binary in path.
https://bugs.webkit.org/show_bug.cgi?id=208007
Reviewed by Tim Horton.
Detect if the compiler binary already points to the ccache binary and in that case don't
set the ccache compiler prefix. Also export CCACHE_SLOPPINESS=time_macros if its not
defined to other thing on the environment and add a some logging of related messages.
- Source/cmake/WebKitCCache.cmake:
- 2:56 AM Changeset in webkit [257440] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257046 - ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=151030
<rdar://problem/27711142>
Patch by Jack Lee <Jack Lee> on 2020-02-19
Reviewed by Darin Adler.
Track if m_accumulatedOffset ever becomes saturated, and if so, do not assert on unexpected rendererMappedResult.
Source/WebCore:
Test: fast/layers/geometry-map-saturated-offset-assert.html
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::mightBeSaturated const):
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer const):
(WebCore::RenderGeometryMap::stepInserted):
(WebCore::RenderGeometryMap::stepRemoved):
- rendering/RenderGeometryMap.h:
LayoutTests:
- fast/layers/geometry-map-saturated-offset-assert-expected.txt: Added.
- fast/layers/geometry-map-saturated-offset-assert.html: Added.
- 2:56 AM Changeset in webkit [257439] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r257042 - Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
https://bugs.webkit.org/show_bug.cgi?id=207974
<rdar://problem/59606705>
Reviewed by Darin Adler.
According to the spec, negative origin values are supported:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
- 2:56 AM Changeset in webkit [257438] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r257036 - Fix crash when Node::normalize() triggers mutation event that modifies child order
https://bugs.webkit.org/show_bug.cgi?id=207875
<rdar://58976682>
Patch by Sunny He <sunny_he@apple.com> on 2020-02-19
Reviewed by Ryosuke Niwa.
When Node::normalize() merges two text nodes, it calls appendData
before textNodesMerged. If there is a mutator event registered, it
will fire on the call to appendData, potentially changing the child
order and causing a nullptr crash due to incorrect sibling pointers.
Reverse the order of these calls to ensure order gets correctly
updated.
Source/WebCore:
Test: fast/dom/Node/normalize-mutation-event.html
- dom/Node.cpp:
(WebCore::Node::normalize):
LayoutTests:
- fast/dom/Node/normalize-mutation-event-expected.txt: Added.
- fast/dom/Node/normalize-mutation-event.html: Added.
- 2:56 AM Changeset in webkit [257437] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r257013 - Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
- 2:56 AM Changeset in webkit [257436] by
-
- 10 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r256967 - Regression(r247567) HTTP Disk cache capacity is no longer set
https://bugs.webkit.org/show_bug.cgi?id=207959
<rdar://problem/59603972>
Reviewed by Alex Christensen.
NetworkProcess::initializeNetworkProcess() was setting the cache model, which
would iterate over all network sessions to update their network cache capacity.
The issue was that network sessions were not constructed yet at this point.
When the network session(s) would get created later on, they would construct
their NetworkCache and it would use the default capacity (i.e.
std::numeric_limits<size_t>::max()).
To make this safer, I have moved the capacity computation to the Cache::open()
method and now pass the capacity when constructing the network cache storage.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setCacheModelSynchronouslyForTesting):
(WebKit::NetworkProcess::setCacheModel):
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::cacheModel const):
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::initialize):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::computeCapacity):
(WebKit::NetworkCache::Cache::open):
(WebKit::NetworkCache::Cache::capacity const):
(WebKit::NetworkCache::Cache::updateCapacity):
(WebKit::NetworkCache::Cache::setCapacity): Deleted.
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::setCapacity):
- NetworkProcess/cache/NetworkCacheStorage.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setCacheModel):
- 2:56 AM Changeset in webkit [257435] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r256932 - Disable the process cache when process-per-tab is disabled in the debug menu
https://bugs.webkit.org/show_bug.cgi?id=207949
<rdar://problem/57094837>
Reviewed by Geoffrey Garen.
Disable the process cache when process-per-tab is disabled in the debug menu. The process cache is a
process-swap-on-navigation optimization and process-swap-on-navigation is already disabled when
process-per-tab is disabled. The process cache is not useful with such configuration and actually
leads to crashes too.
- UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::updateCapacity):
- 2:56 AM Changeset in webkit [257434] by
-
- 5 edits in releases/WebKitGTK/webkit-2.28/Source
Merge r256925 - Re-disable top-level data URL navigations
https://bugs.webkit.org/show_bug.cgi?id=207917
<rdar://problem/59568037>
Reviewed by Darin Adler.
Source/WebCore:
Calls to WKPage and WKWebView API used to load data and strings directly should be recognized by
the loading code as being from client API calls. This brings these API behaviors into alignment
with similar API for loading URLs and URLRequests directly. This change also allows us to enforce
stricter handling of Data URLs, and to remove the need to explicitly permit top-level data URL
navigation when client APIs are used.
Tested by TestWebKitAPI Navigation tests.
- page/Settings.yaml:
Source/WebKit:
In Bug 207719 we allowed top-level navigations to data URLs by default. This
patch updates client loading API calls so that we can go back to a default
block of these loads without breaking WebKit clients.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadDataImpl): Recognize direct data loads started from client API.
- WebProcess/WebPage/WebPage.h:
- 2:56 AM Changeset in webkit [257433] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28
Merge r256917 - [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support
https://bugs.webkit.org/show_bug.cgi?id=207838
Reviewed by Carlos Alberto Lopez Perez.
This change allows for more granular control over the compiler
launcher configuration. The build host should no longer need to
set ccache symbolic links. Additionally optional support for
sccache is added, enabled when the WEBKIT_USE_SCCACHE environment
variable is set to YES.
- Source/cmake/WebKitCCache.cmake:
- 2:56 AM Changeset in webkit [257432] by
-
- 6 edits in releases/WebKitGTK/webkit-2.28
Merge r256913 - [WPE] Support 2D axis, smooth-motion events
https://bugs.webkit.org/show_bug.cgi?id=207881
Reviewed by Carlos Garcia Campos.
Source/WebKit:
WPE's WebEventFactory should also handle axis events that are capable
of providing information about axis change in both dimensions. In case
of smooth motion, the delta values should be preserved and not
transformed into line-steps.
Similarly, the ScrollGestureController should also adopt the 2D axis
event type, producing smooth-motion events when dispatching handling
a scroll gesture.
The changes are guarded and only enabled when building against at least
libwpe 1.5.0 since that's when the new API was added.
- Shared/libwpe/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- UIProcess/API/wpe/ScrollGestureController.cpp:
(WebKit::ScrollGestureController::handleEvent):
- UIProcess/API/wpe/ScrollGestureController.h:
(WebKit::ScrollGestureController::axisEvent):
Tools:
- wpe/jhbuild.modules: Bump to a newer libwpe commit.
- 2:56 AM Changeset in webkit [257431] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/JavaScriptCore
Merge r256850 - Fix order (in MIPS) under which CS-registers are saved/restored
https://bugs.webkit.org/show_bug.cgi?id=207752
Patch by Paulo Matos <Paulo Matos> on 2020-02-18
Reviewed by Keith Miller.
This has been causing several segfaults on MIPS with JIT enabled
because during an OSR to baseline, the order in which LLInt was
saving the registers was not in sync with the way baseline was
restoring them.
- llint/LowLevelInterpreter.asm:
- 2:56 AM Changeset in webkit [257430] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r256831 - ASSERT_NOT_REACHED() under WebPageProxy::suspendCurrentPageIfPossible()
https://bugs.webkit.org/show_bug.cgi?id=207868
<rdar://problem/59464606>
Reviewed by John Wilander.
Source/WebCore:
Test: http/tests/navigation/process-swap-on-client-side-redirect-private.html
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateForSameDocumentNavigation):
Methods in HistoryController avoids updating visited links and calling updateGlobalHistory()
on the FrameLoaderClient when in an ephemeral session. However, updateForSameDocumentNavigation()
was returning early in ephemeral sessions, which was overly aggressive and bypasses things we
really need to do, like updating the current HistoryItem's url.
LayoutTests:
Add layout test that was hitting the assertion before my change.
- http/tests/navigation/process-swap-on-client-side-redirect-private-expected.txt: Added.
- http/tests/navigation/process-swap-on-client-side-redirect-private.html: Added.
- 2:55 AM Changeset in webkit [257429] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r256764 - Null Ptr Deref @ WebCore::Node::Treescope
https://bugs.webkit.org/show_bug.cgi?id=207748
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-02-17
Reviewed by Darin Adler.
Source/WebCore:
Added a check for isTextField after updateLayoutIgnorePendingStylesheets as that could cause modification of input element type.
Test: editing/selection/ignore-selection-range-on-input-style-change.html
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):
LayoutTests:
Added a regression test provided by Ryosuke Niwa to verify the fix.
- editing/selection/ignore-selection-range-on-input-style-change-expected.txt: Added.
- editing/selection/ignore-selection-range-on-input-style-change.html: Added.
- 2:55 AM Changeset in webkit [257428] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r256738 - IndexedDB: index cursor iteration is slow when there are a lot of index records from different object stores
https://bugs.webkit.org/show_bug.cgi?id=207377
<rdar://problem/59288679>
Reviewed by Brady Eidson.
Make the Index of IndexRecords table include indexID since we always perform search with indexID.
This would let SQLite optimize the index statement in SQLiteCursor with Covering Index and fix the slowness.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsIndex):
(WebCore::IDBServer::v1IndexRecordsIndexSchema): Deleted.
- 2:55 AM Changeset in webkit [257427] by
-
- 5 edits in releases/WebKitGTK/webkit-2.28
Merge r256727 - [WPE] Change the QML plugin install path
https://bugs.webkit.org/show_bug.cgi?id=207761
Reviewed by Philippe Normand.
Source/WebKit:
This way there's no need to set QML2_IMPORT_PATH manually.
- PlatformWPE.cmake:
Tools:
- Scripts/run-qt-wpe-minibrowser:
- glib/api_test_runner.py:
(TestRunner._run_test_qt):
- 2:55 AM Changeset in webkit [257426] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/gtk/po
Merge r256723 - Updated Simplified Chinese translation
https://bugs.webkit.org/show_bug.cgi?id=207685
Patch by Yuchen Guo <egyc@live.com> on 2020-02-17
Rubber-stamped by Carlos Garcia Campos.
- zh_CN.po:
- 2:55 AM Changeset in webkit [257425] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r256719 - Log WebSocket failure in case of network crash
https://bugs.webkit.org/show_bug.cgi?id=207801
Reviewed by Darin Adler.
Covered by http/tests/websocket/tests/hybi/network-process-crash-error.html.
- WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::didReceiveMessageError):
(WebKit::WebSocketChannel::networkProcessCrashed):
Add a console log message in case of error coming from network process.
- 2:55 AM Changeset in webkit [257424] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/JavaScriptCore
Merge r256718 - Remove nonArgGPR1 for ARMv7 and ARM64 (unused)
https://bugs.webkit.org/show_bug.cgi?id=207753
Patch by Paulo Matos <Paulo Matos> on 2020-02-16
Reviewed by Darin Adler.
Cleanup commit - nonArgGPR1 is unused for both ARMv7
and ARM64.
- jit/GPRInfo.h:
- 2:55 AM Changeset in webkit [257423] by
-
- 3 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r256705 - Unreviewed build fix for non-unified builds.
No new tests needed.
- animation/AnimationEventBase.cpp: Add missing include.
- animation/DeclarativeAnimation.cpp: Ditto.
- 2:55 AM Changeset in webkit [257422] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit
Merge r256703 - [Geoclue] Avoid usage of provider in callbacks after it has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=207420
GeoclueGeolocationProvider was making non-cancelable g_dbus_proxy_call(s) with
bare |this| pointer.
Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2020-02-15
Reviewed by Carlos Garcia Campos.
- UIProcess/geoclue/GeoclueGeolocationProvider.cpp:
(WebKit::GeoclueGeolocationProvider::start):
(WebKit::GeoclueGeolocationProvider::stop):
(WebKit::GeoclueGeolocationProvider::setupManager):
(WebKit::GeoclueGeolocationProvider::createClient):
(WebKit::GeoclueGeolocationProvider::startClient):
(WebKit::GeoclueGeolocationProvider::didFail):
- UIProcess/geoclue/GeoclueGeolocationProvider.h:
- 2:55 AM Changeset in webkit [257421] by
-
- 26 edits2 adds in releases/WebKitGTK/webkit-2.28
Merge r256659 - new FontFace() should not throw when failing to parse arguments
https://bugs.webkit.org/show_bug.cgi?id=205770
Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2020-02-14
Reviewed by Myles Maxfield.
Source/WebCore:
Change FontFace constructor to conform to API specification:
https://drafts.csswg.org/css-font-loading/#dom-fontface-fontface.
No longer throws. For parsing failure, now rejects promise, sets
status to error, and sets FontFace members to default string.
Test: http/tests/css/font-face-constructor.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::setErrorState):
- css/CSSFontFace.h:
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::addToFacesLookupTable):
(WebCore::CSSFontFaceSet::remove):
(WebCore::CSSFontFaceSet::fontFace):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontRanges):
- css/FontFace.cpp:
(WebCore::FontFace::setErrorState):
(WebCore::FontFace::create):
(WebCore::FontFace::family const):
(WebCore::FontFace::style const):
(WebCore::FontFace::weight const):
(WebCore::FontFace::stretch const):
(WebCore::FontFace::unicodeRange const):
(WebCore::FontFace::featureSettings const):
(WebCore::FontFace::display const):
(WebCore::FontFace::fontStateChanged):
- css/FontFace.h:
- css/FontFace.idl:
LayoutTests:
Tests that constructor doesn't throw, sets members to corresponding default strings.
- http/tests/css/font-face-constructor-expected.txt: Added.
- http/tests/css/font-face-constructor.html: Added.
- 2:54 AM Changeset in webkit [257420] by
-
- 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore
Merge r256636 - [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
https://bugs.webkit.org/show_bug.cgi?id=207784
<rdar://problem/59251858>
Patch by Antoine Quint <graouts@webkit.org> on 2020-02-14
Reviewed by Dean Jackson.
After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
call should the Web Animations flag be on.
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- 2:54 AM Changeset in webkit [257419] by
-
- 4 edits in releases/WebKitGTK/webkit-2.28
Merge r256629 - Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
https://bugs.webkit.org/show_bug.cgi?id=207360
<rdar://problem/57825317>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-02-14
Reviewed by Ryosuke Niwa.
Source/WTF:
- wtf/URLHelpers.cpp:
(WTF::URLHelpers::mapHostName):
Tools:
- TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- 2:54 AM Changeset in webkit [257418] by
-
- 15 edits in releases/WebKitGTK/webkit-2.28
Merge r256627 - [Web Animations] Style changes due to Web Animations should not trigger CSS Transitions
https://bugs.webkit.org/show_bug.cgi?id=207760
<rdar://problem/59458111>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Mark Web Platform Tests progressions.
- web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
- web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt:
- web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt:
- web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt:
Source/WebCore:
While we would consider the unanimated style of CSS Animations specifically when considering what the "start" style values (before-change style in spec terminology)
should be when considering whether to start a CSS Transition during style resolution, we would not consider other types of animations, specifically JS-created Web
Animations. However, Web Platform Tests specifically test whether changes made using the Web Animations API may trigger transitions, and until now they would because
the RenderStyle used to determine the before-change style was the style from the previous resolution, which would include animated values.
To fix this, we make it so that KeyframeEffect objects now keep a copy of the unanimated style used when blending animated values for the very first time. That style
is cleared each time keyframes change, which is rare, but may happen through the Web Animations API. Then in AnimationTimeline::updateCSSTransitionsForElementAndProperty(),
we look for a KeyframeEffect currently affecting the property for which we're considering starting a CSS Transition, and use its unanimated style.
If that unanimated style has not been set yet, this is because the KeyframeEffect has not had a chance to apply itself with a non-null progress. In this case, the before-change
and after-change styles should be the same in order to prevent a transition from being triggered as the unanimated style for this keyframe effect will most likely be this
after-change style, or any future style change that may happen before the keyframe effect starts blending animated values.
Finally, tracking the unanimated style at the KeyframeEffect level means we no longer to track it specifically for CSSAnimation.
- animation/AnimationTimeline.cpp:
(WebCore::keyframeEffectForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
- animation/AnimationTimeline.h:
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::create):
(WebCore::CSSAnimation::CSSAnimation):
- animation/CSSAnimation.h:
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animatesProperty const): Because the backing KeyframeList object may not have been created by the first time we query a KeyframeEffect during
CSS Transitions resolution, we provide a method that will check the values provided by the Web Animations API to determine whether it targets a given CSS property.
(WebCore::KeyframeEffect::clearBlendingKeyframes):
(WebCore::KeyframeEffect::computeDeclarativeAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::apply):
- animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::unanimatedStyle const):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
LayoutTests:
Mark that a couple of tests are no longer flaky.
- 2:44 AM WebKitGTK/2.28.x edited by
- (diff)
- 2:44 AM WebKitGTK/2.28.x edited by
- (diff)
- 2:21 AM Changeset in webkit [257417] by
-
- 5 edits in trunk/Source/WebCore
DocumentTimeline / CSSTransition objects are leaking on CNN.com
https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>
Reviewed by Antoine Quint.
Break reference cycle between DocumentTimeline and WebAnimation by using WeakPtr.
- animation/AnimationTimeline.h:
- animation/DocumentTimeline.h:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::timeline const):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::enqueueAnimationEvent):
(WebCore::WebAnimation::acceleratedStateDidChange):
- animation/WebAnimation.h:
(WebCore::WebAnimation::timeline const): Deleted.
- 2:07 AM Changeset in webkit [257416] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for non-unified builds.
- bindings/js/JSAnimationTimelineCustom.cpp: Add missing header include.
- 1:16 AM Changeset in webkit [257415] by
-
- 2 edits in trunk
Unreviewed. Bump GTK version numbers
- Source/cmake/OptionsGTK.cmake:
- 12:47 AM Changeset in webkit [257414] by
-
- 2 edits in trunk/Source/WebCore
Custom element caching should be aware of different worlds.
https://bugs.webkit.org/show_bug.cgi?id=208228
<rdar://problem/57881013>
Reviewed by Ryosuke Niwa.
Even though a custom element is cached in one world, we should return an unknown
HTMl element in a different world.
Test to be added in https://bugs.webkit.org/show_bug.cgi?id=208229.
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- 12:38 AM Changeset in webkit [257413] by
-
- 2 edits in trunk/Source/WebKit
Call pending m_unregisterJobs completion handlers when WebSWServerConnection goes away
https://bugs.webkit.org/show_bug.cgi?id=208208
<rdar://problem/59747016>
Reviewed by Alex Christensen.
Covered by existing tests in debug.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::~WebSWServerConnection):
Make sure to call pending completion handlers at destruction time.
They will do nothing since their goal is to send back an IPC message
on a dead IPC connection.
