Timeline
Apr 4, 2020:
- 11:17 PM Changeset in webkit [259545] by
-
- 2 edits in trunk/Source/JavaScriptCore
copy jsc CLI into JavaScriptCore.framework earlier
https://bugs.webkit.org/show_bug.cgi?id=210018
Reviewed by Mark Lam.
Some of our test scripts only copy the JavaScriptCore.framework
into the test directory and try to run jsc from there. We should
copy the jsc CLI ASAP so we don't need to build all the other test
binaries unless we actually need them.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 10:09 PM Changeset in webkit [259544] by
-
- 3 edits in trunk/Source/WebCore
Remove LockHistory parameter from loadWithNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=210007
Patch by Rob Buis <rbuis@igalia.com> on 2020-04-04
Reviewed by Darin Adler.
Remove LockHistory parameter from loadWithNavigationAction since NavigationAction
has a member for this. Where needed explicitly set the LockHistory on the actions.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoader.h:
- 9:16 PM Changeset in webkit [259543] by
-
- 2 edits in trunk/Source/WebCore
Build fix v2: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
https://bugs.webkit.org/show_bug.cgi?id=209925
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
(WebCore::HTMLFormElement::addToPastNamesMap):
- 8:44 PM Changeset in webkit [259542] by
-
- 3 edits in trunk/LayoutTests
[GTK] Update test baseline after r259438 and garden crashes
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt:
- 5:42 PM Changeset in webkit [259541] by
-
- 7 edits in trunk
Add a fourth round of logging to help diagnose <webkit.org/b/209685>
https://bugs.webkit.org/show_bug.cgi?id=210011
Reviewed by Darin Adler.
Source/WebCore:
Augment logging in WebItemProviderPasteboard to additionally dump a backtrace when registering item providers
when initiating a drag on iOS. Logging thus far suggests that this is due to an IPC dispatch race when sending
the following messages to the UI process:WebPasteboardProxy::writeCustomDataand
WebPasteboardProxy::writeStringToPasteboard. WhilewriteCustomDatais dispatched synchronously,
writeStringToPasteboardis dispatched asynchronously; this means that it is possible for the call to
writeCustomDatato be dispatched beforewriteStringToPasteboardeven if the web process sends the
writeCustomDatamessage later, due to the UI-process-side mechanism for immediately dispatching incoming sync
IPC if it is currently processing sync IPC itself.
A backtrace here should help to confirm this theory.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard stageRegistrationLists:]):
Source/WebKit:
Remove all logging previously added to WKContentView and DragDropInteractionState.
- UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::clearStagedDragSource):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleDragStartRequest:]):
Tools:
Remove all logging previously added to DragAndDropSimulator.
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
- 5:03 PM Changeset in webkit [259540] by
-
- 20 edits in trunk
[iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
https://bugs.webkit.org/show_bug.cgi?id=209984
<rdar://problem/61273941>
Reviewed by Darin Adler.
Source/WebKit:
Simplify ProcessAssertion class in preparation for switch to RunningBoard. There
is a slight mismatch between the way BKS and RunningBoard process assertion API.
This refactoring makes it so that we can use the same ProcessAssertion class in
WebKit to work with either BKS or RunningBoard. Support for RunningBoard will
come later.
In particular, the following changes were made:
- Replace AssertionState & AssertionReason enums with a single ProcessAssertionType one since RunningBoard does not have 2 separate concepts.
- Drop ProcessAssertion::setState() since it is not possible to change the flags on an existing RunningBoard assertion. Instead, we are expected to create a brand new process assertion of the expected type.
- NetworkProcess/Downloads/DownloadMap.cpp:
(WebKit::DownloadMap::add):
- Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
- UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
- UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _setAssertionTypeForTesting:]):
(-[WKWebView _setAssertionStateForTesting:]): Deleted.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendProcessDidResume):
(WebKit::NetworkProcessProxy::takeUploadAssertion):
(WebKit::NetworkProcessProxy::didSetAssertionState): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::setState): Deleted.
- UIProcess/ProcessAssertion.h:
(WebKit::ProcessAssertion::type const):
(WebKit::ProcessAssertion::state const): Deleted.
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::expectedAssertionType):
(WebKit::ProcessThrottler::updateAssertionTypeNow):
(WebKit::ProcessThrottler::setAssertionType):
(WebKit::ProcessThrottler::updateAssertionIfNeeded):
(WebKit::ProcessThrottler::didConnectToProcess):
(WebKit::ProcessThrottler::prepareToSuspendTimeoutTimerFired):
(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):
(WebKit::ProcessThrottler::expectedAssertionState): Deleted.
(WebKit::ProcessThrottler::updateAssertionStateNow): Deleted.
(WebKit::ProcessThrottler::setAssertionState): Deleted.
- UIProcess/ProcessThrottler.h:
- UIProcess/ProcessThrottlerClient.h:
(WebKit::ProcessThrottlerClient::didSetAssertionType):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setWebProcessHasUploads):
(WebKit::WebProcessPool::setWebProcessIsPlayingAudibleMedia):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didSetAssertionType):
(WebKit::WebProcessProxy::didSetAssertionState): Deleted.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::setAssertionTypeForTesting):
(WebKit::WebProcessProxy::setAssertionStateForTesting): Deleted.
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::flagsForAssertionType):
(WebKit::toBKSProcessAssertionReason):
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::flagsForState): Deleted.
(WebKit::reasonForState): Deleted.
(WebKit::ProcessAssertion::setState): Deleted.
(WebKit::ProcessAndUIAssertion::setState): Deleted.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- 4:44 PM Changeset in webkit [259539] by
-
- 4 edits in trunk/Source/WebKit
[GPUP] Remove unnecessary RemoteCDMInstanceSessionIdentifier argument from RemoteCDMFactory::addSession()
<https://webkit.org/b/210006>
Reviewed by Darin Adler.
- WebProcess/GPU/media/RemoteCDMFactory.cpp:
(WebKit::RemoteCDMFactory::addSession):
- Remove argument. Use
sessionparameter to retrieve the ID. - WebProcess/GPU/media/RemoteCDMFactory.h:
(WebKit::RemoteCDMFactory::addSession):
- Remove argument.
- WebProcess/GPU/media/RemoteCDMInstance.cpp:
(WebKit::RemoteCDMInstance::createSession):
- Remove argument.
- 3:39 PM Changeset in webkit [259538] by
-
- 2 edits in trunk/Source/WebCore
Additional sanity checks in compareAnimationsByCompositeOrder()
https://bugs.webkit.org/show_bug.cgi?id=209996
Reviewed by Geoffrey Garen.
compareAnimationsByCompositeOrder() is used by std::sort() which requires strict weak ordering.
This adds additional checks to ensure strict weak ordering is maintained, first by ensuring
the transitionProperty string is different before returning that comparison, then by only using
if the animation is a CSSTransition or CSSAnimation if the left hand and right hand sides differ.
This should leave all remaining cases to sort by the global animation list.
No new tests; this should be covered by existing tests and should not change functionality
otherwise.
- animation/WebAnimationUtilities.cpp:
(WebCore::compareAnimationsByCompositeOrder):
- 2:42 PM Changeset in webkit [259537] by
-
- 3 edits in trunk/Source/WTF
[Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in WTF
https://bugs.webkit.org/show_bug.cgi?id=209955
Reviewed by Darin Adler.
Clang 10 reports a compilation warning for int to float
conversions losing the precision. The warning is often reported
for code converting a floating point value to an integer value.
For example:
Optional<int> positive_float_to_int(float f) {
if (f > INT_MAX)
return nullopt;
return static_cast<int>(f);
}
INT_MAX is implicitly converted float, but float can't keep the
precision of such large value. And, C++ spec doesn't specify
whether it would be rounded up or down. Above code should be
rewritten to:
Optional<int> positive_float_to_int(float f) {
if (f >= pow(2, 31))
return nullopt;
return static_cast<int>(f);
}
Instead of using pow, this change added a template variable
maxPlusOne<T>.
- wtf/MathExtras.h:
(powerOfTwo): Added.
(doubleToInteger): Added.
(maxPlusOne): Added.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
- 12:36 PM Changeset in webkit [259536] by
-
- 10 edits in trunk
'\u' should throw an early SyntaxError exception, but instead evaluates to 'u'
https://bugs.webkit.org/show_bug.cgi?id=198790
Reviewed by Yusuke Suzuki.
JSTests:
- mozilla/ecma/Array/15.4.5.1-1.js:
- mozilla/ecma/LexicalConventions/7.7.4.js:
- test262/expectations.yaml: Mark 4 test cases as passing.
Source/JavaScriptCore:
This change removes special-case for '\u', invoking parseUnicodeEscape() right away,
aligning string literals with ES6 template literals. parseComplexEscape() method
signature is greatly simplified, JSC is aligned with V8 and SpiderMonkey.
Grammar: https://tc39.es/ecma262/#prod-UnicodeEscapeSequence
(Hex4Digits or '{' is required, otherwise parsing fails)
- parser/Lexer.cpp:
(JSC::Lexer<T>::parseComplexEscape):
(JSC::Lexer<T>::parseStringSlowCase):
(JSC::Lexer<T>::parseTemplateLiteral):
- parser/Lexer.h:
LayoutTests:
- js/script-tests/unicode-escape-sequences.js:
- js/unicode-escape-sequences-expected.txt:
- 11:56 AM Changeset in webkit [259535] by
-
- 2 edits in trunk/JSTests
Unreviewed, skip stress/typed-array-subarray-can-throw-oom-error.js on memory-limited archs, and mark it slow
https://bugs.webkit.org/show_bug.cgi?id=209974
- stress/typed-array-subarray-can-throw-oom-error.js:
- 11:52 AM Changeset in webkit [259534] by
-
- 7 edits in trunk
Add even more logging to try and diagnose <webkit.org/b/209685>
https://bugs.webkit.org/show_bug.cgi?id=210008
Reviewed by Tim Horton.
Source/WebCore:
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard stageRegistrationLists:]):
Source/WebKit:
Revert all (except one) of the logging statements added in r259518, and add several new ones. This last logging
pass demonstrated that DragController had failed to start a drag, since -[WKContentView _didHandleDragStartRequest:]
receives word that the drag has started, yet there are no staged drag items.
- UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::clearStagedDragSource):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _prepareToDragPromisedAttachment:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:canHandleSession:]):
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):
Tools:
Replace old logging with new logging (in different places).
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator _advanceProgress]):
(-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
Rule out the possibility that the WebKit client (in this case, the drag and drop simulator) is overriding the
list of drag items by logging the given NSItemProvider that will be used to start the drag.
- 11:38 AM Changeset in webkit [259533] by
-
- 2 edits in trunk/Source/WebCore
Ahom text is busted
https://bugs.webkit.org/show_bug.cgi?id=209898
<rdar://problem/60571257>
Reviewed by Tim Horton.
https://en.wikipedia.org/wiki/Ahom_language
The Ahom language, U+11700 - U+1173F, requires the complex text codepath.
This patch also makes some languages adjacent in codepoint-space (Dogra,
Dives Akuru, Nandinagari, Zanabazar Square, Soyombo, Warang Citi, and
Pau Cin Hau) use the complex path too.
At some point, we really need to make the fast text codepath opt-in instead
of opt-out. This patch is a simple band-aid fix until we can do that.
No new tests because I can't find an appropriately licenced font.
There is Noto Serif Ahom, but that's licenced under SIL OFL, and I'm
not sure if that's an acceptable license to be committed to WebKit.
https://github.com/googlefonts/noto-fonts/tree/master/hinted/NotoSerifAhom
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::characterRangeCodePath):
- 11:16 AM Changeset in webkit [259532] by
-
- 20 edits1 copy8 deletes in trunk
Implement the css-color-4 behavior for inheritance of currentColor
https://bugs.webkit.org/show_bug.cgi?id=193171
<rdar://problem/47287516>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-text-decor/parsing/text-decoration-color-computed-expected.txt:
- web-platform-tests/css/css-transitions/currentcolor-animation-001-expected.txt:
- web-platform-tests/svg/pservers/scripted/stop-color-inheritance-currentcolor-expected.txt:
Source/WebCore:
In CSS3/4 'currentcolor' inherits as 'currentcolor' instead of as a resolved color value.
Value 'currentcolor' is represented in RenderStyle as invalid Color object. This has been true
even before the explicit property value for it was added. Fallback to 'color' has always been
the default behavior of most color properties.
As a result the correct behavior falls pretty easily from WebKit code. It essentially amounts to allowing
color properties to inherit normally even when they are invalid/currentcolor.
In future we might want to wrap RenderStyle color values into a type that makes 'currentcolor' more explicit.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSProperties.json:
- Remove 'no-default-color' which triggered to old inheritance behavior.
- Rename initial value invalidColor to currentColor for clarity.
- css/makeprop.pl:
Code for 'no-default-color' generation is not needed anymore.
(generateInheritValueSetter):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback const):
Resolve 'background-color' like the rest so setting it to 'currentcolor' works correctly.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::currentColor):
(WebCore::RenderStyle::invalidColor): Deleted.
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyTextOrBoxShadowValue):
- style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::createFilterOperations):
(WebCore::Style::BuilderState::colorFromPrimitiveValue const):
Don't resolve 'currentcolor', instead return it as a value.
(WebCore::Style::BuilderState::colorFromPrimitiveValueWithResolvedCurrentColor const):
Helper for a few cases where we still resolve current color during style building time. It is
used for filters and generated images.
- style/StyleBuilderState.h:
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::stopColorIncludingOpacity const):
Resolve 'currentcolor' during use time for svg color stops.
LayoutTests:
- TestExpectations:
- fast/borders/border-color-inherit-expected.html: Copied from LayoutTests/fast/borders/border-color-inherit.html.
- fast/borders/border-color-inherit.html:
Fix for the new behavior and make it a reftest.
- fast/css/webkit-text-fill-color-inherit.html:
- platform/gtk/fast/borders/border-color-inherit-expected.png: Removed.
- platform/gtk/fast/borders/border-color-inherit-expected.txt: Removed.
- platform/ios/fast/borders/border-color-inherit-expected.txt: Removed.
- platform/mac/fast/borders/border-color-inherit-expected.png: Removed.
- platform/mac/fast/borders/border-color-inherit-expected.txt: Removed.
- platform/win/fast/borders/border-color-inherit-expected.txt: Removed.
- platform/wincairo/fast/borders/border-color-inherit-expected.txt: Removed.
- platform/wpe/fast/borders/border-color-inherit-expected.txt: Removed.
- 10:06 AM Changeset in webkit [259531] by
-
- 10 edits2 adds in trunk
REGRESSION (r259095): ASSERTION FAILED: m_videoFullscreenMode != VideoFullscreenModeNone seen with TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
https://bugs.webkit.org/show_bug.cgi?id=209680
Reviewed by Jer Noble.
Source/WebCore:
API test: WebKitLegacy.PreemptVideoFullscreen
Call fullscreenModeChanged(VideoFullscreenModeNone) right before calling the
functions of ChromeClient to make sure the state (m_videoFullscreenMode)
has the expected value when some callbacks come back to the video element.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::dispatchEvent):
(WebCore::HTMLMediaElement::exitFullscreen):
Add null pointer checkings to fix two crashes found in stress tests.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::requestVideoContentLayer):
(VideoFullscreenControllerContext::returnVideoContentLayer):
Source/WebKitLegacy/mac:
With this patch, the WebKit-Legacy can support multiple video elements request
to enter video fullscreen almost at the same time, and only the last one will succeed.
Also, this patch fixes webkit.org/b/209610 for WebKit-Legacy.
- WebView/WebView.mm:
- WebView/WebViewData.h:
Tools:
Add an API test for the video fullscreen support of WebKitLegacy on iOS.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm: Added.
(-[VideoFullscreenStressUIWebViewDelegate webViewDidFinishLoad:]):
(-[VideoFullscreenStressUIWebViewDelegate uiWebView:didCommitLoadForFrame:]):
(-[VideoFullscreenStressUIWebViewDelegate handleEvent:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitLegacy/ios/two-videos.html: Added.
LayoutTests:
Remove the crashing expectation for media/media-fullscreen-return-to-inline.html
- platform/mac/TestExpectations:
- 9:14 AM Changeset in webkit [259530] by
-
- 2 edits in trunk/JSTests
Gardening: skip test for ARMv7 and MIPS to green the bots until the failure can be investigated.
https://bugs.webkit.org/show_bug.cgi?id=210003
Not reviewed.
- stress/typed-array-subarray-can-throw-oom-error.js:
Apr 3, 2020:
- 11:13 PM Changeset in webkit [259529] by
-
- 16 edits4 moves139 adds8 deletes in trunk/JSTests
Update test262 to commit 62b8fce38971
https://bugs.webkit.org/show_bug.cgi?id=209979
Reviewed by Ross Kirsling.
- .gitattributes: Added.
- test262/config.yaml: Skip "logical-assignment-operators" and "Promise.any" features.
- test262/expectations.yaml:
- test262/harness/*: Updated.
- test262/latest-changes-summary.txt:
- test262/test/*: Updated.
- test262/test262-Revision.txt:
- 10:22 PM Changeset in webkit [259528] by
-
- 2 edits in trunk/Source/WebKit
WebPlatformStrategies::{readBufferFromPasteboard,bufferForType} should validate their
sizeparameter
<https://webkit.org/b/209997>
<rdar://problem/60890565>
Reviewed by Wenson Hsieh.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
- Validate the
sizeparameter.
- 10:06 PM Changeset in webkit [259527] by
-
- 2 edits in trunk/Source/WebCore
Build fix: HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
https://bugs.webkit.org/show_bug.cgi?id=209925
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
- Apply macros consistently. Regressed in r259513.
- 7:42 PM Changeset in webkit [259526] by
-
- 3 edits in trunk/Source/WebKit
The IPC message “registerAttachmentsFromSerializedData" should be capitalized
https://bugs.webkit.org/show_bug.cgi?id=209995
<rdar://problem/61283172>
Reviewed by Tim Horton.
Tweak the name of this IPC message so that it begins with a capital letter. No change in behavior.
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerAttachments):
- 6:04 PM Changeset in webkit [259525] by
-
- 3 edits in trunk/Source/WebCore
Protect contentFrame in SubframeLoader::loadOrRedirectSubframe with RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=127096
<rdar://problem/61221941>
Reviewed by Alex Christensen.
ContentFrame is used throughout loadOrRedirectSubframe so it needs to be protected with RefPtr.
And if loader changes frame in SubframeLoader::loadSubframe, return nullptr to notify the caller.
No new tests, covered by existing test.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadOrRedirectSubframe):
(WebCore::SubframeLoader::loadSubframe):
- loader/SubframeLoader.h:
- 6:01 PM Changeset in webkit [259524] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Sources: disclosure arrows should be shown if a folder is added to the navigation sidebar
https://bugs.webkit.org/show_bug.cgi?id=209937
Reviewed by Timothy Hatcher.
- UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype.treeElementForRepresentedObject):
(WI.SourcesNavigationSidebarPanel.prototype._addStyleSheet):
(WI.SourcesNavigationSidebarPanel.prototype._addScript):
- 5:44 PM Changeset in webkit [259523] by
-
- 47 edits in trunk
Add SPI to make WKUserScripts wait for a notification
https://bugs.webkit.org/show_bug.cgi?id=209845
<rdar://problem/60342299>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-03
Reviewed by Chris Dumez.
Source/WebCore:
There's also SPI on WKWebView to provide this notification, and on WKWebViewConfiguration to start out with this notification.
- dom/ExtensionStyleSheets.cpp:
(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptImmediately):
- page/Page.cpp:
(WebCore::m_deviceOrientationUpdateProvider):
(WebCore::Page::notifyToInjectUserScripts):
(WebCore::Page::addUserScriptAwaitingNotification):
(WebCore::Page::injectUserStyleSheet):
(WebCore::Page::removeInjectedUserStyleSheet):
- page/Page.h:
(WebCore::Page::hasBeenNotifiedToInjectUserScripts const):
- page/PageConfiguration.h:
- page/UserContentTypes.h:
(): Deleted.
- page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::waitForNotificationBeforeInjecting const):
(WebCore::UserScript::encode const):
(WebCore::UserScript::decode):
- page/UserScriptTypes.h:
(): Deleted.
- page/UserStyleSheet.h:
(WebCore::UserStyleSheet::UserStyleSheet):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WebKit:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toUserScriptInjectionTime):
(WebKit::toWKUserScriptInjectionTime):
(WebKit::toUserContentInjectedFrames):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Shared/WebUserContentControllerDataTypes.cpp:
(WebKit::WebUserScriptData::decode):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::userScriptsShouldWaitUntilNotification const):
(API::PageConfiguration::setUserScriptsShouldWaitUntilNotification):
- UIProcess/API/APIUserScript.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserScript):
- UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):
(WKUserScriptGetMainFrameOnly):
- UIProcess/API/Cocoa/WKUserScript.mm:
(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:]):
(-[WKUserScript isForMainFrameOnly]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:userContentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:contentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:contentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:contentWorld:waitForNotification:]):
- UIProcess/API/Cocoa/WKUserScriptInternal.h:
(API::toWebCoreUserScriptInjectionTime):
(API::toWKUserScriptInjectionTime):
- UIProcess/API/Cocoa/WKUserScriptPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _notifyUserScripts]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _userScriptsShouldWaitUntilNotification]):
(-[WKWebViewConfiguration _setUserScriptsShouldWaitUntilNotification:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(-[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):
(-[_WKUserStyleSheet isForMainFrameOnly]):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserScriptInternal):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_processDisplayName):
(WebKit::WebPage::notifyUserScripts):
(WebKit::WebPage::addUserScript):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
(TEST):
- 5:16 PM Changeset in webkit [259522] by
-
- 2 edits in trunk/Source/WebCore
Use-after-move of
formStatein WebCore::PolicyChecker::checkNavigationPolicy()
https://bugs.webkit.org/show_bug.cgi?id=209987
Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-03
Reviewed by Chris Dumez.
Use std::exchange because formState is used later.
No change in behavior, but this will allow use-after-move hunts to continue.
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
- 4:45 PM Changeset in webkit [259521] by
-
- 8 edits in trunk/Source/WebKit
Use AuthenticationChallenge instead of AuthenticationChallengeProxy for ResourceLoadDelegate
https://bugs.webkit.org/show_bug.cgi?id=207639
Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-03
Reviewed by David Kilzer.
In r254345 my younger and more naive self used AuthenticationChallengeProxy instead of AuthenticationChallenge
because he didn't know about the WebCore::mac function, which is called by AuthenticationChallengeProxy, and it's
all I needed to get an NSURLAuthenticationChallenge. Skipping the AuthenticationChallengeProxy step cleans up
AuthenticationChallengeProxy by removing the unnecessary ability to have a null CompletionHandler.
Covered by existing tests.
- UIProcess/API/APIResourceLoadClient.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
(): Deleted.
- UIProcess/Cocoa/ResourceLoadDelegate.h:
- UIProcess/Cocoa/ResourceLoadDelegate.mm:
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didReceiveChallenge const):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::resourceLoadDidReceiveChallenge):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- 4:39 PM Changeset in webkit [259520] by
-
- 8 edits in trunk
Prevent non app-bound domain cookies from being read or set using API calls
https://bugs.webkit.org/show_bug.cgi?id=209926
<rdar://problem/61071428>
Reviewed by Brady Eidson.
Source/WebKit:
This patch filters out setting and fetching of cookies via API call
to only set or return app-bound cookies.
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::filterAppBoundCookies):
This function queries the websiteDataStore for the WKAppBoundDomains
entries and filters out non app-bound domains.
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::cookiesForURL):
(API::HTTPCookieStore::setCookies):
These functions were updated to set/return the cookies after they've
been filtered through the WKAppBoundDomains.
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _appBoundDomains:]):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::getAppBoundDomains const):
(WebKit::WebsiteDataStore::appBoundDomainsForTesting const): Deleted.
Utilize a function formerly used for testing only to be used in the
HTTPCookieStore.
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Added 3 new API tests to test that non app-bound cookies are not being
set or returned via API calls. Also added a function to reset state
between tests for internal debugging.
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(setUpCookieTest):
(TEST):
- 3:55 PM Changeset in webkit [259519] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: objectStoreInfo in SQLiteIDBBackingStore::getRecord
https://bugs.webkit.org/show_bug.cgi?id=209976
<rdar://problem/55005363>
Reviewed by Geoffrey Garen.
Return error if objectStoreInfo is null in SQLiteIDBBackingStore::getRecord, because there is a possibility
SQLiteIDBBackingStore does not have requested objectStoreInfo.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
- 3:45 PM Changeset in webkit [259518] by
-
- 7 edits in trunk
Add more logging to help diagnose <webkit.org/b/209685>
https://bugs.webkit.org/show_bug.cgi?id=209988
Reviewed by Timothy Hatcher.
Source/WebCore:
Remove logging that was previously added in r259465.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):
Source/WebKit:
Replace logging that was previously added in r259465 with different logging. The fact that the prior logging
never showed up in the failing tests suggests that the problem happens earlier than I had expected, so we need
to ensure that codepaths for preparing and beginning a drag session are logged instead.
This turns several existing
RELEASE_LOGs in WKContentView intoNSLogs, so that they will show up in test
failure output when run on the bots.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView _didHandleDragStartRequest:]):
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _prepareToDragPromisedAttachment:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:canHandleSession:]):
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):
Tools:
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
Fix a few stray style mistakes (unnecessary
.get()s).
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator _advanceProgress]):
- 3:14 PM Changeset in webkit [259517] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Give RunningBoard entitlement to all our child processes
https://bugs.webkit.org/show_bug.cgi?id=209986
<rdar://problem/61275270>
Reviewed by Geoffrey Garen.
Give RunningBoard entitlement to all our child processes on iOS. As we are
transitioning to RunningBoard process assertions, it is important for the
target process of those assertion to have the
com.apple.runningboard.assertions.webkit entitlement.
- Scripts/process-entitlements.sh:
- 3:04 PM Changeset in webkit [259516] by
-
- 20 edits4 deletes in trunk
Unreviewed, reverting r259440.
Introduced 2 failing tests on Mac and iOS
Reverted changeset:
"Add SPI to configure WebsiteDataStores with a URL for
standalone web applications and use it to disable first-party
website data removal in ITP"
https://bugs.webkit.org/show_bug.cgi?id=209634
https://trac.webkit.org/changeset/259440
- 2:11 PM Changeset in webkit [259515] by
-
- 1 copy in tags/Safari-610.1.8.2
Tag Safari-610.1.8.2.
- 2:09 PM Changeset in webkit [259514] by
-
- 2 edits in branches/safari-610.1.8-branch/Source/ThirdParty/libwebrtc
Cherry-pick r259397. rdar://problem/61273057
Build fix after r259385.
Reviewed by David Kilzer, Youenn Fablet.
Convert isStandardFrameSize() into a lambda function since it only has one call site.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: (-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]): (isStandardFrameSize): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:05 PM Changeset in webkit [259513] by
-
- 3 edits in trunk/Source/WebCore
HTMLFormElement should use WeakPtr to keep track of its FormNamedItem
https://bugs.webkit.org/show_bug.cgi?id=209925
Reviewed by Wenson Hsieh.
Like r259393, this patch replaces the HashMap of AtomString to the raw pointer of a FormNamedItem
by a HashMap of AtomString to WeakPtr of a FormNamedItem.
It also replaces a bunch of ASSERT_WITH_SECURITY_IMPLICATIONs with ASSERTs since there are no more
security implications left after this patch.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap const):
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
(WebCore::HTMLFormElement::addToPastNamesMap):
(WebCore::HTMLFormElement::removeFromPastNamesMap):
- html/HTMLFormElement.h:
- 1:55 PM Changeset in webkit [259512] by
-
- 9 edits2 adds in trunk/Source
Add a visual debug indicator for locating and identifying all kinds of WebViews
https://bugs.webkit.org/show_bug.cgi?id=209982
<rdar://problem/60339870>
Reviewed by Simon Fraser.
Source/WebCore:
Add a debug overlay that can be enabled with a single switch for all
*WebView variants, which indicates the type of *WebView in an unmissable,
gaudy fashion.
This is intended to address some shortcomings of existing mechanisms
that people use to answer the "what kind of web view is X app using?"
question. Specifically:
- it will appear even if the Web Content process does not launch or crashes
- it will appear even if a custom content view is being used (e.g. PDF)
- it will appear even if compositing is not enabled (e.g. in a legacy WebView on macOS)
- it explicitly states in written text the class name of the web view, with no need for interpreting colors
- it covers the entire web view, so cannot be accidentally obscured
No new tests, just debugging UI.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- testing/cocoa/WebViewVisualIdentificationOverlay.h: Added.
- testing/cocoa/WebViewVisualIdentificationOverlay.mm: Added.
(+[WebViewVisualIdentificationOverlay shouldIdentifyWebViews]):
Use a single default across all kinds of WebViews, instead of using
WebPreferences and friends, in order to make it extremely easy to turn on,
and because it's intended to be set globally, and is not useful on a
per-view basis.
(+[WebViewVisualIdentificationOverlay installForWebViewIfNeeded:kind:deprecated:]):
(-[WebViewVisualIdentificationOverlay initWithWebView:kind:deprecated:]):
(-[WebViewVisualIdentificationOverlay dealloc]):
(-[WebViewVisualIdentificationOverlay observeValueForKeyPath:ofObject:change:context:]):
(-[WebViewVisualIdentificationOverlay drawLayer:inContext:]):
Draw a wash and the class name over the entire face of the web view.
The wash is blue for WKWebView and red for all of the deprecated web views (WKView, WebView, UIWebView).
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processPool:configuration:]):
Adopt in WKWebView and WKView.
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Adopt for WebView on macOS (UIWebView will install it itself on iOS).
- WebView/WebViewPrivate.h:
Expose _installVisualIdentificationOverlayForViewIfNeeded:kind: for UIWebView's use.
It is slightly unfortunate to expose SPI that uses UIView from a framework
underneath UIKit, but there is no other single place where this code can live
and not be a minor layering problem. Since it's debug UI, it seems passable.
- 1:40 PM Changeset in webkit [259511] by
-
- 2 edits in branches/safari-609-branch/Source/WebCore
Cherry-pick r259378. rdar://problem/61269720
Crash in WebCore::HTMLDocumentParser::insert
https://bugs.webkit.org/show_bug.cgi?id=209892
Reviewed by Darin Adler.
Speculative fix to check that the parser hasn't been detached before running preload scanner.
No new tests since there is no reproduction and I couldn't come up with one.
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 PM Changeset in webkit [259510] by
-
- 70 edits in branches/safari-609-branch/Source
Cherry-pick r259355. rdar://problem/61269744
Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors
https://bugs.webkit.org/show_bug.cgi?id=209762
Reviewed by Darin Adler.
Source/JavaScriptCore:
Change indexingType to indexingModeIncludingHistory to more
clearly indicate the expected range of possible valid values.
- runtime/StructureInlines.h: (JSC::Structure::create):
Source/WebCore:
There may be places where we rely on this for semantic
correctness. I couldn't find any right now but we might as
well be conservative since this isn't a performance regression.
- bindings/js/JSDOMWindowProperties.h:
- bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader):
- bindings/scripts/test/JS/JSInterfaceName.h: (WebCore::JSInterfaceName::createStructure):
- bindings/scripts/test/JS/JSMapLike.h: (WebCore::JSMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlyMapLike.h: (WebCore::JSReadOnlyMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlySetLike.h: (WebCore::JSReadOnlySetLike::createStructure):
- bindings/scripts/test/JS/JSSetLike.h: (WebCore::JSSetLike::createStructure):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h: (WebCore::JSTestActiveDOMObject::createStructure):
- bindings/scripts/test/JS/JSTestCEReactions.h: (WebCore::JSTestCEReactions::createStructure):
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.h: (WebCore::JSTestCEReactionsStringifier::createStructure):
- bindings/scripts/test/JS/JSTestCallTracer.h: (WebCore::JSTestCallTracer::createStructure):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h: (WebCore::JSTestClassWithJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestDOMJIT.h: (WebCore::JSTestDOMJIT::createStructure):
- bindings/scripts/test/JS/JSTestEnabledBySetting.h: (WebCore::JSTestEnabledBySetting::createStructure):
- bindings/scripts/test/JS/JSTestEnabledForContext.h: (WebCore::JSTestEnabledForContext::createStructure):
- bindings/scripts/test/JS/JSTestEventConstructor.h: (WebCore::JSTestEventConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventTarget.h: (WebCore::JSTestEventTarget::createStructure):
- bindings/scripts/test/JS/JSTestException.h: (WebCore::JSTestException::createStructure):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h: (WebCore::JSTestGenerateIsReachable::createStructure):
- bindings/scripts/test/JS/JSTestGlobalObject.h: (WebCore::JSTestGlobalObject::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h: (WebCore::JSTestIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h: (WebCore::JSTestIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h: (WebCore::JSTestIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h: (WebCore::JSTestInterfaceLeadingUnderscore::createStructure):
- bindings/scripts/test/JS/JSTestIterable.h: (WebCore::JSTestIterable::createStructure):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h: (WebCore::JSTestJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h: (WebCore::JSTestNamedAndIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedConstructor.h: (WebCore::JSTestNamedConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h: (WebCore::JSTestNamedDeleterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h: (WebCore::JSTestNamedDeleterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h: (WebCore::JSTestNamedDeleterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h: (WebCore::JSTestNamedDeleterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.h: (WebCore::JSTestNamedGetterCallWith::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h: (WebCore::JSTestNamedGetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h: (WebCore::JSTestNamedGetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h: (WebCore::JSTestNamedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h: (WebCore::JSTestNamedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h: (WebCore::JSTestNamedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h: (WebCore::JSTestNamedSetterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h: (WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h: (WebCore::JSTestNamedSetterWithOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h: (WebCore::JSTestNamedSetterWithUnforgableProperties::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h: (WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObj::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h: (WebCore::JSTestOverloadedConstructors::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h: (WebCore::JSTestOverloadedConstructorsWithSequence::createStructure):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h: (WebCore::JSTestOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestPluginInterface.h: (WebCore::JSTestPluginInterface::createStructure):
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h: (WebCore::JSTestPromiseRejectionEvent::createStructure):
- bindings/scripts/test/JS/JSTestSerialization.h: (WebCore::JSTestSerialization::createStructure):
- bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h: (WebCore::JSTestSerializationIndirectInheritance::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInherit.h: (WebCore::JSTestSerializationInherit::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.h: (WebCore::JSTestSerializationInheritFinal::createStructure):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore::JSTestSerializedScriptValueInterface::createStructure):
- bindings/scripts/test/JS/JSTestStringifier.h: (WebCore::JSTestStringifier::createStructure):
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h: (WebCore::JSTestStringifierAnonymousOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.h: (WebCore::JSTestStringifierNamedOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h: (WebCore::JSTestStringifierOperationImplementedAs::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h: (WebCore::JSTestStringifierOperationNamedToString::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h: (WebCore::JSTestStringifierReadOnlyAttribute::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h: (WebCore::JSTestStringifierReadWriteAttribute::createStructure):
- bindings/scripts/test/JS/JSTestTypedefs.h: (WebCore::JSTestTypedefs::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:39 PM Changeset in webkit [259509] by
-
- 2 edits in branches/safari-609-branch/Source/WebKit
Cherry-pick r257209. rdar://problem/61269710
Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=208127
rdar://problem/57937917
Reviewed by Chris Dumez.
In case of a data task whose session is destroyed, do not follow redirection early on.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:39 PM Changeset in webkit [259508] by
-
- 16 edits in branches/safari-609-branch/Source
Cherry-pick r256900. rdar://problem/61269733
SWServer::claim should check for the service worker to be active
https://bugs.webkit.org/show_bug.cgi?id=207739
<rdar://problem/45441129>
Reviewed by Alex Christensen.
Source/WebCore:
claim is only working for service workers that are active.
But there might be a time when a service worker is active in its web process but redundant in networking process.
Thus, we need to move the check from WebProcess to NetworkProcess.
- workers/service/ServiceWorkerClients.cpp: (WebCore::ServiceWorkerClients::claim):
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp: (WebCore::SWServer::claim):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.cpp: (WebCore::SWServerToContextConnection::claim):
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::claim): Deleted.
- workers/service/server/SWServerWorker.h: (WebCore::SWServerWorker::isActive const):
Source/WebKit:
Use Async Reply to remove the need for a map and passing integers around.
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::claimCompleted): Deleted.
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::claim): (WebKit::WebSWContextManagerConnection::claimCompleted): Deleted.
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:33 PM Changeset in webkit [259507] by
-
- 11 edits in trunk
Remove _setIsNavigatingToAppBoundDomain testing SPI
https://bugs.webkit.org/show_bug.cgi?id=209973
<rdar://problem/61264350>
Reviewed by David Kilzer.
This SPI is no longer needed to set a webView as navigating to an
app-bound domain. We can now load a local file instead.
Source/WebKit:
No new tests, confirmed behavior by existing tests.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setIsNavigatingToAppBoundDomain:completionHandler:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainTesting): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsNavigatingToAppBoundDomainTesting): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
- 1:28 PM Changeset in webkit [259506] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed sandbox compile fix.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:13 PM Changeset in webkit [259505] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] Update MESSAGE_CHECK macros used in WebProcessProxy::didCreateSleepDisabler/WebProcessProxy::didDestroySleepDisabler
<https://webkit.org/b/209981>
<rdar://problem/61237674>
Reviewed by Darin Adler.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didCreateSleepDisabler):
- Remove MESSAGE_CHECK for
identifiersince decoding detects invalid values. - Add MESSAGE_CHECK for
reasonsince a NULL string would cause CFStringCreateWithCString() to crash later.
(WebKit::WebProcessProxy::didDestroySleepDisabler):
- Remove MESSAGE_CHECK for
identifiersince decoding detects invalid values.
- 1:12 PM Changeset in webkit [259504] by
-
- 8 edits in branches/safari-609-branch/Source
Versioning.
- 1:06 PM Changeset in webkit [259503] by
-
- 8 edits in branches/safari-610.1.8-branch/Source
Versioning.
- 12:58 PM Changeset in webkit [259502] by
-
- 70 edits in branches/safari-609.2.1.2-branch/Source
Cherry-pick r259355. rdar://problem/61269741
Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors
https://bugs.webkit.org/show_bug.cgi?id=209762
Reviewed by Darin Adler.
Source/JavaScriptCore:
Change indexingType to indexingModeIncludingHistory to more
clearly indicate the expected range of possible valid values.
- runtime/StructureInlines.h: (JSC::Structure::create):
Source/WebCore:
There may be places where we rely on this for semantic
correctness. I couldn't find any right now but we might as
well be conservative since this isn't a performance regression.
- bindings/js/JSDOMWindowProperties.h:
- bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader):
- bindings/scripts/test/JS/JSInterfaceName.h: (WebCore::JSInterfaceName::createStructure):
- bindings/scripts/test/JS/JSMapLike.h: (WebCore::JSMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlyMapLike.h: (WebCore::JSReadOnlyMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlySetLike.h: (WebCore::JSReadOnlySetLike::createStructure):
- bindings/scripts/test/JS/JSSetLike.h: (WebCore::JSSetLike::createStructure):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h: (WebCore::JSTestActiveDOMObject::createStructure):
- bindings/scripts/test/JS/JSTestCEReactions.h: (WebCore::JSTestCEReactions::createStructure):
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.h: (WebCore::JSTestCEReactionsStringifier::createStructure):
- bindings/scripts/test/JS/JSTestCallTracer.h: (WebCore::JSTestCallTracer::createStructure):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h: (WebCore::JSTestClassWithJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestDOMJIT.h: (WebCore::JSTestDOMJIT::createStructure):
- bindings/scripts/test/JS/JSTestEnabledBySetting.h: (WebCore::JSTestEnabledBySetting::createStructure):
- bindings/scripts/test/JS/JSTestEnabledForContext.h: (WebCore::JSTestEnabledForContext::createStructure):
- bindings/scripts/test/JS/JSTestEventConstructor.h: (WebCore::JSTestEventConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventTarget.h: (WebCore::JSTestEventTarget::createStructure):
- bindings/scripts/test/JS/JSTestException.h: (WebCore::JSTestException::createStructure):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h: (WebCore::JSTestGenerateIsReachable::createStructure):
- bindings/scripts/test/JS/JSTestGlobalObject.h: (WebCore::JSTestGlobalObject::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h: (WebCore::JSTestIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h: (WebCore::JSTestIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h: (WebCore::JSTestIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h: (WebCore::JSTestInterfaceLeadingUnderscore::createStructure):
- bindings/scripts/test/JS/JSTestIterable.h: (WebCore::JSTestIterable::createStructure):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h: (WebCore::JSTestJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h: (WebCore::JSTestNamedAndIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedConstructor.h: (WebCore::JSTestNamedConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h: (WebCore::JSTestNamedDeleterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h: (WebCore::JSTestNamedDeleterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h: (WebCore::JSTestNamedDeleterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h: (WebCore::JSTestNamedDeleterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.h: (WebCore::JSTestNamedGetterCallWith::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h: (WebCore::JSTestNamedGetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h: (WebCore::JSTestNamedGetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h: (WebCore::JSTestNamedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h: (WebCore::JSTestNamedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h: (WebCore::JSTestNamedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h: (WebCore::JSTestNamedSetterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h: (WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h: (WebCore::JSTestNamedSetterWithOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h: (WebCore::JSTestNamedSetterWithUnforgableProperties::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h: (WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObj::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h: (WebCore::JSTestOverloadedConstructors::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h: (WebCore::JSTestOverloadedConstructorsWithSequence::createStructure):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h: (WebCore::JSTestOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestPluginInterface.h: (WebCore::JSTestPluginInterface::createStructure):
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h: (WebCore::JSTestPromiseRejectionEvent::createStructure):
- bindings/scripts/test/JS/JSTestSerialization.h: (WebCore::JSTestSerialization::createStructure):
- bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h: (WebCore::JSTestSerializationIndirectInheritance::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInherit.h: (WebCore::JSTestSerializationInherit::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.h: (WebCore::JSTestSerializationInheritFinal::createStructure):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore::JSTestSerializedScriptValueInterface::createStructure):
- bindings/scripts/test/JS/JSTestStringifier.h: (WebCore::JSTestStringifier::createStructure):
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h: (WebCore::JSTestStringifierAnonymousOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.h: (WebCore::JSTestStringifierNamedOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h: (WebCore::JSTestStringifierOperationImplementedAs::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h: (WebCore::JSTestStringifierOperationNamedToString::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h: (WebCore::JSTestStringifierReadOnlyAttribute::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h: (WebCore::JSTestStringifierReadWriteAttribute::createStructure):
- bindings/scripts/test/JS/JSTestTypedefs.h: (WebCore::JSTestTypedefs::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259501] by
-
- 3 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r259305. rdar://problem/61231978
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=209786
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-03-31
Reviewed by Ryosuke Niwa.
No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::handleSubstituteDataLoadNow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259500] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r259244. rdar://problem/61231864
Assertion failure in HTMLFormElement::formElementIndex
https://bugs.webkit.org/show_bug.cgi?id=209643
Reviewed by Darin Adler.
The bug was caused by FormAssociatedElement::findAssociatedForm finding a wrong form element
when it's called on an element which appears later in the removed subtree.
When we find the new form element to associate this element with, check to make sure its root
element is that of the tree scope. This condition will be false if this element is in in the midst
of being removed.
- html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::findAssociatedForm):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259499] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r259056. rdar://problem/61231908
Force Touch preview on file:/// URL works while clicking on the URL is blocked
https://bugs.webkit.org/show_bug.cgi?id=209589
<rdar://57687893>
Reviewed by Antoine Quint.
The immediate action for links should never trigger on file: URLs.
- UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController _defaultAnimationController]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259498] by
-
- 3 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r258902. rdar://problem/61231866
IPC::Decoder::decodeFixedLengthData() should be marked WARN_UNUSED_RETURN
<https://webkit.org/b/209448>
<rdar://problem/60797998>
Reviewed by Chris Dumez.
- Platform/IPC/ArgumentCoders.h: (struct VectorArgumentCoder::decode):
- Check the return value of Decoder::decodeFixedLengthData().
- Platform/IPC/Decoder.h: (IPC::Decoder::decodeFixedLengthData): Add WARN_UNUSED_RETURN.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259497] by
-
- 8 edits in branches/safari-609.2.1.2-branch/Source/JavaScriptCore
Cherry-pick r258901. rdar://problem/61231922
HasIndexedProperty should know about sane chain
https://bugs.webkit.org/show_bug.cgi?id=209457
Reviewed by Saam Barati.
This patch makes it so HasIndexedProperty is aware of
sane chain. This is useful because, most of the time we do an
indexed in it is on an array. If the array has a sane chain (i.e.
no indexed properties on it's prototypes and has the default
prototype chain) then we can just test for the index being a hole.
Note, we could also just convert OOB indices into false but that
should happen in another patch.
https://bugs.webkit.org/show_bug.cgi?id=209456
I didn't add any tests because it turns out we already have a ton.
I know this because I broke most of them repeatedly... >.>
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h: (JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::setSaneChainIfPossible): (JSC::DFG::FixupPhase::convertToHasIndexedProperty):
- dfg/DFGNodeType.h:
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
- ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty): (JSC::FTL::DFG::LowerDFGToB3::speculateAndJump):
- jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::isEmpty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:58 PM Changeset in webkit [259496] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r258814. rdar://problem/61231972
decodeSharedBuffer() in WebCoreArgumentCoders.cpp should validate
bufferSize
<https://webkit.org/b/209373>
<rdar://problem/60610919>
Reviewed by Darin Adler.
- Shared/WebCoreArgumentCoders.cpp: (IPC::decodeSharedBuffer):
- Return early if
bufferSizeis too big.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259495] by
-
- 5 edits2 adds in branches/safari-609.2.1.2-branch
Cherry-pick r258799. rdar://problem/61231946
Content-Type & Nosniff Ignored on XML External Entity Resources
<https://webkit.org/b/191171>
<rdar://problem/45763222>
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml
- platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.
- platform/MIMETypeRegistry.h: (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.
- Checks for XML external entity MIME types.
- xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::externalEntityMimeTypeAllowedByNosniff): Add.
- Checks whether the MIME type is valid based on the presence of the "X-Content-Type-Options: nosniff" header. (WebCore::openFunc):
- Drop the contents of the resource that was returned and print an error message to the Web Inspector console if externalEntityMimeTypeAllowedByNosniff() says the MIME type is not allowed.
LayoutTests:
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity-expected.txt: Add.
- http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml: Add.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259494] by
-
- 5 edits in branches/safari-609.2.1.2-branch
Cherry-pick r258741. rdar://problem/61231885
Sanitize suggested download filename received from web process
https://bugs.webkit.org/show_bug.cgi?id=209300
<rdar://problem/59487723>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-19
Reviewed by Chris Dumez.
Source/WebKit:
- UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash-expected.txt:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259493] by
-
- 3 edits in branches/safari-609.2.1.2-branch/Source/ThirdParty/libwebrtc
Cherry-pick r258690. rdar://problem/61231915
Cherry pick usrsctp commit 790a7a2555aefb392a5a69923f1e9d17b4968467
https://bugs.webkit.org/show_bug.cgi?id=209204
<rdar://problem/59362671>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-19
Reviewed by Youenn Fablet.
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_auth.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_pcb.c:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259492] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r258559. rdar://problem/61231877
Terminate the WebContent process when receiving invalid IPC from a WebInspector session
https://bugs.webkit.org/show_bug.cgi?id=209157
<rdar://problem/58961055>
Reviewed by Chris Dumez.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::backForwardGoToItemShared): Add a message check that we are not receiving the request from a WebInspector page. (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): Switch to a release assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259491] by
-
- 3 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r258464. rdar://problem/61231891
Call SVGTRefElement::buildPendingResource in SVGElement::didFinishInsertingNode
https://bugs.webkit.org/show_bug.cgi?id=208981
Reviewed by Antti Koivisto.
This patch moves the call to SVGTRefElement::buildPendingResource from SVGElement::insertedIntoAncestor
to SVGElement::didFinishInsertingNode.
- svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoAncestor): Return true when the element has a pending resource ID. (WebCore::SVGElement::didFinishInsertingNode): Added. Calls buildPendingResourcesIfNeeded.
- svg/SVGElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259490] by
-
- 4 edits2 adds in branches/safari-609.2.1.2-branch
Cherry-pick r258459. rdar://problem/61231983
SVGMatrix should have the access right of its owner SVGTransform always
https://bugs.webkit.org/show_bug.cgi?id=207462
Reviewed by Simon Fraser.
Source/WebCore:
The SVGMatrix needs to be reattached to its owner SVGTransform when the
access right of this owner changes. The access right of the owner changes
when it gets attached to or detached from a higher level owner.
Test: svg/dom/SVGTransformList-anim-read-only.html
- svg/SVGTransform.h:
- svg/properties/SVGProperty.h: (WebCore::SVGProperty::attach): (WebCore::SVGProperty::detach): (WebCore::SVGProperty::reattach):
LayoutTests:
- svg/dom/SVGTransformList-anim-read-only-expected.txt: Added.
- svg/dom/SVGTransformList-anim-read-only.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259489] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r258401. rdar://problem/61231940
WebPageProxy::SetPromisedDataForImage should validate its
imageSizeandarchiveSizeparameters
<https://webkit.org/b/209029>
<rdar://problem/60181394>
Reviewed by Youenn Fablet.
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setPromisedDataForImage):
- Validate
imageSizeandarchiveSizeusing MESSAGE_CHECK(). - Add static_cast<size_t>() to
imageSizeandarchiveSizeparameters to denote type change. - Add nullptr check for SharedMemory::map() result with
archiveHandle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259488] by
-
- 5 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r258278. rdar://problem/61231870
SVG filter triggers unstable layout.
https://bugs.webkit.org/show_bug.cgi?id=207444
rdar://problem/59297004
Reviewed by Simon Fraser.
SVG filter code marks DOM nodes dirty and schedules style recalc outside of the SVG root
while in layout. This could lead to unstable layout and cause battery drain.
(See webkit.org/b/208903)
- rendering/RenderLayer.cpp: Remove filterNeedsRepaint(). It's a dangerously misleading name and should not be part of RenderLayer. (WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayer.h:
- rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::notifyFinished):
- rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation): (WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259487] by
-
- 3 edits1 add in branches/safari-609.2.1.2-branch
Cherry-pick r256766. rdar://problem/61231942
[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
https://bugs.webkit.org/show_bug.cgi?id=207849
Reviewed by Mark Lam.
JSTests:
- wasm/regress/regress-256665.js: Added. (f):
Source/JavaScriptCore:
When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.
- wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::calleeSaves const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259486] by
-
- 3 edits in branches/safari-609.2.1.2-branch/JSTests
Cherry-pick r256698. rdar://problem/61231902
Unreviewed: fix broken tests added in r256665
https://bugs.webkit.org/show_bug.cgi?id=207727
Our inline WAT doesn't seem to like named blocks/branch targets.
- wasm/regress/llint-callee-saves-with-fast-memory.js:
- wasm/regress/llint-callee-saves-without-fast-memory.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259485] by
-
- 9 edits2 adds in branches/safari-609.2.1.2-branch
Cherry-pick r256665. rdar://problem/61231902
[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
https://bugs.webkit.org/show_bug.cgi?id=207727
JSTests:
Reviewed by Mark Lam.
- wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
- wasm/regress/llint-callee-saves-without-fast-memory.js: Added.
Source/JavaScriptCore:
Reviewed by Mark Lam.
The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:
- When entering Wasm from JS, the wrapper must:
- Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode)
- Preserve the memory base in either mode, and the size for BoundsChecking.
- Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize.
- Changes to memoryBase and memorySize are visible to the caller. This means that:
- Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it.
- Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow).
- A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks.
- llint/WebAssembly.asm:
- wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall):
- wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall):
- wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters):
- wasm/WasmCallingConvention.h:
- wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation):
- wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:57 PM Changeset in webkit [259484] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebKit
Cherry-pick r254724. rdar://problem/61231960
IPC hardening for WebPageProxy::SetPromisedDataForImage message
https://bugs.webkit.org/show_bug.cgi?id=206380
<rdar://problem/58625196>
Reviewed by Geoffrey Garen.
IPC hardening for WebPageProxy::SetPromisedDataForImage message. Make sure the shared memory handle sent over IPC is not null
and null check the SharedMemory object after calling SharedMemory::map().
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setPromisedDataForImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:50 PM Changeset in webkit [259483] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r8412): Use RetainPtr<> for NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]
<https://webkit.org/b/209980>
Reviewed by Darin Adler.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Make use of RetainPtr<>.
- 12:25 PM Changeset in webkit [259482] by
-
- 5 edits in trunk/Source
Fix bugs related to VideoTextureCopierCV and ANGLE roll script
https://bugs.webkit.org/show_bug.cgi?id=209943
Patch by Kenneth Russell <kbr@chromium.org> on 2020-04-03
Reviewed by Dean Jackson.
Source/ThirdParty/ANGLE:
Update the update-angle.sh script to take into account the new
procedure for generating ANGLE's commit ID header file. This
enables ANGLE rolls into WebKit again.
- update-angle.sh:
Source/WebCore:
Fixed longstanding preexisting bugs related to creation and
deletion of OpenGL objects inside VideoTextureCopierCV, including
in which context its internal framebuffer was created. Unbind the
output texture after hooking it up to the framebuffer to avoid any
appearance of rendering feedback loops.
Stop setting the WebGL compatibility context creation attribute
for VideoTextureCopier's context.
Covered by preexisting layout tests.
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
- platform/graphics/cv/VideoTextureCopierCV.cpp:
(WebCore::VideoTextureCopierCV::VideoTextureCopierCV):
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture):
- 11:40 AM Changeset in webkit [259481] by
-
- 3 edits1 add in trunk
[JSC] canonicalizeLocaleList should gracefully throw OOM error if input + error message is too large
https://bugs.webkit.org/show_bug.cgi?id=209971
<rdar://problem/61258621>
Reviewed by Mark Lam.
JSTests:
- stress/intl-canonicalize-locale-list-error-oom.js: Added.
(shouldThrow):
Source/JavaScriptCore:
canonicalizeLocaleList generates error-message with input. If input is too large, error-message string
generation could fail due to OOM. We should gracefully throw OOM error instead of crashing. This strategy
follows tocreateError's error-message generation: if error-message generation fails, throwing OOM error.
- runtime/IntlObject.cpp:
(JSC::canonicalizeLocaleList):
- 11:34 AM Changeset in webkit [259480] by
-
- 8 edits13 adds39 deletes in trunk
Move Intl tests from LayoutTests to JSTests
https://bugs.webkit.org/show_bug.cgi?id=209922
Reviewed by Yusuke Suzuki.
JSTests:
Intl doesn't depend on WebCore, so these tests shouldn't be layout tests.
(They do, however, require one method to be added to $vm.)
Since LayoutTests/js has its own test harness, I've also migrated each test case to use simpler assertions.
- stress/array-to-locale-string.js: Removed -- subsumed by the following test.
- stress/array-toLocaleString.js: Added.
- stress/date-toLocaleString.js: Added.
- stress/intl-collator.js: Added.
- stress/intl-datetimeformat.js: Added.
- stress/intl-default-locale.js: Added.
- stress/intl-numberformat-format-to-parts.js: Added.
- stress/intl-numberformat.js: Added.
- stress/intl-object.js: Added.
- stress/intl-pluralrules.js: Added.
- stress/number-toLocaleString.js: Added.
- stress/string-localeCompare.js: Added.
- stress/string-toLocaleLowerCase.js: Added.
- stress/string-toLocaleUpperCase.js: Added.
Source/JavaScriptCore:
- tools/JSDollarVM.cpp:
(JSC::functionSetUserPreferredLanguages):
(JSC::JSDollarVM::finishCreation):
Add $vm.setUserPreferredLanguages, as needed by stress/intl-default-locale.js.
LayoutTests:
- js/array-toLocaleString-expected.txt: Removed.
- js/array-toLocaleString.html: Removed.
- js/date-toLocaleString-expected.txt: Removed.
- js/date-toLocaleString.html: Removed.
- js/intl-collator-expected.txt: Removed.
- js/intl-collator.html: Removed.
- js/intl-datetimeformat-expected.txt: Removed.
- js/intl-datetimeformat.html: Removed.
- js/intl-default-locale-expected.txt: Removed.
- js/intl-default-locale.html: Removed.
- js/intl-expected.txt: Removed.
- js/intl-numberformat-expected.txt: Removed.
- js/intl-numberformat-format-to-parts-expected.txt: Removed.
- js/intl-numberformat-format-to-parts.html: Removed.
- js/intl-numberformat.html: Removed.
- js/intl-pluralrules-expected.txt: Removed.
- js/intl-pluralrules.html: Removed.
- js/intl.html: Removed.
- js/number-toLocaleString-expected.txt: Removed.
- js/number-toLocaleString.html: Removed.
- js/script-tests/array-toLocaleString.js: Removed.
- js/script-tests/date-toLocaleString.js: Removed.
- js/script-tests/intl-collator.js: Removed.
- js/script-tests/intl-datetimeformat.js: Removed.
- js/script-tests/intl-numberformat-format-to-parts.js: Removed.
- js/script-tests/intl-numberformat.js: Removed.
- js/script-tests/intl-pluralrules.js: Removed.
- js/script-tests/intl.js: Removed.
- js/script-tests/number-toLocaleString.js: Removed.
- js/script-tests/string-localeCompare.js: Removed.
- js/script-tests/string-toLocaleLowerCase.js: Removed.
- js/script-tests/string-toLocaleUpperCase.js: Removed.
- js/string-localeCompare-expected.txt: Removed.
- js/string-localeCompare.html: Removed.
- js/string-toLocaleLowerCase-expected.txt: Removed.
- js/string-toLocaleLowerCase.html: Removed.
- js/string-toLocaleUpperCase-expected.txt: Removed.
- js/string-toLocaleUpperCase.html: Removed.
- platform/ios-simulator/TestExpectations: Removed expectations.
- platform/ios/TestExpectations: Removed expectations.
- platform/mac/TestExpectations: Removed expectations.
- platform/win/TestExpectations: Removed expectations.
- 11:30 AM Changeset in webkit [259479] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: increase the auto-inspect debugger timeout delay to account for slower networks/devices
https://bugs.webkit.org/show_bug.cgi?id=209940
<rdar://problem/61120919>
Reviewed by Joseph Pecoraro.
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
- 11:29 AM Changeset in webkit [259478] by
-
- 3 edits1 add in trunk
[JSC] TypedArray#subarray should throw OOM error gracefully
https://bugs.webkit.org/show_bug.cgi?id=209974
<rdar://problem/61253901>
Reviewed by Mark Lam.
JSTests:
- stress/typed-array-subarray-can-throw-oom-error.js: Added.
(foo):
(canThrow):
(bar):
(get bar):
Source/JavaScriptCore:
After r259069 change, possiblySharedBuffer can return nullptr if OOM happens.
However, TypedArray#subarray didn't handle this case properly. This patch throws
an OOM error appropriately if possiblySharedBuffer returns nullptr in TypedArray#subarray.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):
- 11:22 AM Changeset in webkit [259477] by
-
- 3 edits2 adds in trunk
Filter some capture device names
https://bugs.webkit.org/show_bug.cgi?id=209941
<rdar://problem/59141886>
Reviewed by Youenn Fablet.
Source/WebCore:
Test: fast/mediastream/anonymize-device-name.html
- platform/mediastream/CaptureDevice.h:
(WebCore::CaptureDevice::label const):
LayoutTests:
- fast/mediastream/anonymize-device-name-expected.txt: Added.
- fast/mediastream/anonymize-device-name.html: Added.
- 11:06 AM Changeset in webkit [259476] by
-
- 2 edits in trunk/Source/WebKit
Color Form Control does not come up on second selection in macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=209939
<rdar://problem/61131345>
Reviewed by Wenson Hsieh.
On selection and manual dismissal of the form, we need to also call accessoryDone,
as the UIKit callbacks are not called on manual dismissal.
- UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker colorMatrixView:didTapColorButton:]):
- 11:00 AM Changeset in webkit [259475] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Do not link with OpenGL on Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=209946
<rdar://problem/61237956>
Reviewed by Sam Weinig.
OpenGL is not used in our build of ANGLE. Attempting to link with it
causes warnings, which can turn into errors in some cases (in
particular, when building with Xcode's "new" build system).
- ANGLE.xcodeproj/project.pbxproj:
- 10:55 AM Changeset in webkit [259474] by
-
- 3 edits in trunk/Source/WebKit
[macOS] Update sandbox rules for correct sanitizer paths in current OS releases
https://bugs.webkit.org/show_bug.cgi?id=209818
<rdar://problem/58422996>
Unreviewed follow-up based on feedback from the sanitizer team.
The change in r259317 left the original, incorrect, 'literal' form of the path, rather
than the correct 'subpath' form. This corrects that issue.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:54 AM Changeset in webkit [259473] by
-
- 1 copy in tags/Safari-610.1.8.1
Tag Safari-610.1.8.1.
- 10:53 AM Changeset in webkit [259472] by
-
- 2 edits1 delete in branches/safari-610.1.8-branch/Source/ThirdParty/libwebrtc
Cherry-pick r259458. rdar://problem/61265583
Remove rtpplay.exe from the libwebrtc source folder
https://bugs.webkit.org/show_bug.cgi?id=209957
Reviewed by Eric Carlson.
- .gitignore:
- Source/webrtc/data/voice_engine/stereo_rtp_files/rtpplay.exe: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:53 AM Changeset in webkit [259471] by
-
- 8 edits in branches/safari-610.1.8-branch/Source
Versioning.
- 10:43 AM Changeset in webkit [259470] by
-
- 3 edits in trunk/Source/WebKit
Remove unneeded sandbox access to some file paths
https://bugs.webkit.org/show_bug.cgi?id=209938
<rdar://problem/59529620>
Reviewed by Per Arne Vollan.
Remove unnecessary access to some locations in /etc. These may have been needed in
the past, but the WebContent process no longer requires this access. We should
remove it.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:37 AM Changeset in webkit [259469] by
-
- 5 edits in trunk
[iOS] Deny mach lookup access to the runningboard service in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=209933
Source/WebKit:
<rdar://problem/56995639>
Reviewed by Brent Fulgham.
On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard"
can be denied in the WebContent process.
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
Reviewed by Brent Fulgham.
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 9:54 AM Changeset in webkit [259468] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r259401): [GTK] Check surroundingRange is not null
https://bugs.webkit.org/show_bug.cgi?id=209966
Reviewed by Darin Adler & Philippe Normand.
- WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::getPlatformEditorState const):
- 9:53 AM Changeset in webkit [259467] by
-
- 3 edits in trunk/Source/WebCore
Remove unused parameter from loadWithNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=209959
Patch by Rob Buis <rbuis@igalia.com> on 2020-04-03
Reviewed by Darin Adler.
Remove unused parameter from loadWithNavigationAction.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoader.h:
- 9:51 AM Changeset in webkit [259466] by
-
- 36 edits in trunk
[Xcode] Replace ASAN_OTHER_CFLAGS and ASAN_OTHER_CPLUSPLUSFLAGS with $(inherited)
<https://webkit.org/b/209963>
<rdar://problem/61257504>
Reviewed by Alexey Proskuryakov.
Source/bmalloc:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/ToolExecutable.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/ThirdParty/libwebrtc:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WebCore:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WebCore/PAL:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WebKit:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WebKitLegacy/mac:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Source/WTF:
- Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
Tools:
- asan/asan.xcconfig:
- Use $(inherited) to get rid of custom ASAN_OTHER_CFLAGS and ASAN_OTHER_CPLUSPLUSFLAGS. Note that ASAN_OTHER_LDFLAGS had been previously removed in r179312, but not in the other *.xcconfig files.
- ContentExtensionTester/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- ImageDiff/cg/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MobileMiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebEditingTester/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- lldb/lldbWebKitTester/Configurations/Base.xcconfig:
- Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and ASAN_OTHER_LDFLAGS.
- 9:43 AM Changeset in webkit [259465] by
-
- 4 edits in trunk/Source
Add logging to help diagnose <webkit.org/b/209685>
https://bugs.webkit.org/show_bug.cgi?id=209967
Reviewed by Darin Adler.
Source/WebCore:
Add logging to try and diagnose a handful of API test failures on iOS 13.4 test runners. The failures seem to
only reproduce in release builds on one particular bot; even then, the problem still doesn't reproduce when
running the API tests on this failing bot.
As such, add some logging to try and verify whether...
(1) the UI process is even attempting to update its supported item provider types, which should happen after
each drag session update.
(2) WKContentView is receiving calls to update the drag session in the first place.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):
Source/WebKit:
See WebCore/ChangeLog.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidUpdate:]):
- 9:26 AM Changeset in webkit [259464] by
-
- 3 edits in trunk/Tools
[ews] Improve error message when patch fails to apply to trunk
https://bugs.webkit.org/show_bug.cgi?id=209965
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(ApplyPatch.getResultSummary): Improved error message.
(ApplyPatch.evaluateCommand): Ditto.
- BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
- 8:58 AM Changeset in webkit [259463] by
-
- 28 edits in trunk/Source/JavaScriptCore
Unreviewed, partially reverting Structure change due to Speedometer2 regression
https://bugs.webkit.org/show_bug.cgi?id=207827
Not reverting WTF changes.
- bytecode/AccessCase.cpp:
(JSC::AccessCase::createTransition):
(JSC::AccessCase::createDelete):
(JSC::AccessCase::propagateTransitions const):
- bytecode/AccessCase.h:
(JSC::AccessCase::structure const):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileObjectKeys):
(JSC::DFG::SpeculativeJIT::compileCreateThis):
(JSC::DFG::SpeculativeJIT::compileCreatePromise):
(JSC::DFG::SpeculativeJIT::compileCreateInternalFieldObject):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeys):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
(JSC::FTL::DFG::LowerDFGToB3::loadStructureClassInfo): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::loadStructureCachedPrototypeChainOrRareData): Deleted.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitLoadClassInfoFromStructure): Deleted.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_this):
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheDeleteBy):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createStructure):
- runtime/ConcurrentJSLock.h:
(JSC::ConcurrentJSLockerBase::ConcurrentJSLockerBase):
(JSC::GCSafeConcurrentJSLocker::GCSafeConcurrentJSLocker):
(JSC::GCSafeConcurrentJSLocker::~GCSafeConcurrentJSLocker):
(JSC::ConcurrentJSLocker::ConcurrentJSLocker):
(JSC::GCSafeConcurrentJSLockerImpl::GCSafeConcurrentJSLockerImpl): Deleted.
(JSC::GCSafeConcurrentJSLockerImpl::~GCSafeConcurrentJSLockerImpl): Deleted.
(JSC::ConcurrentJSLockerImpl::ConcurrentJSLockerImpl): Deleted.
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
(JSC::JSObject::shiftButterflyAfterFlattening):
- runtime/JSObject.h:
(JSC::JSObject::getDirectConcurrently const):
- runtime/JSObjectInlines.h:
(JSC::JSObject::prepareToPutDirectWithoutTransition):
- runtime/JSType.cpp:
(WTF::printInternal):
- runtime/JSType.h:
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains const):
(JSC::StructureTransitionTable::get const):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::create):
(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::materializePropertyTable):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::addNewPropertyTransition):
(JSC::Structure::removePropertyTransitionFromExistingStructureConcurrently):
(JSC::Structure::removeNewPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransitionSlow):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::pinForCaching):
(JSC::Structure::allocateRareData):
(JSC::Structure::ensurePropertyReplacementWatchpointSet):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::visitChildren):
(JSC::Structure::canCachePropertyNameEnumerator const):
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::get):
(JSC::Structure::forEachPropertyConcurrently):
(JSC::Structure::transitivelyTransitionedFrom):
(JSC::Structure::prototypeChain const):
(JSC::Structure::propertyReplacementWatchpointSet):
(JSC::Structure::checkOffsetConsistency const):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::setPropertyTable):
(JSC::Structure::setPreviousID):
(JSC::Structure::ruleOutUnseenProperty const): Deleted.
(JSC::Structure::seenProperties const): Deleted.
(JSC::Structure::addPropertyHashAndSeenProperty): Deleted.
(JSC::Structure::cachedPrototypeChain const): Deleted.
(JSC::Structure::setCachedPrototypeChain): Deleted.
(JSC::Structure::clearPropertyTable): Deleted.
(JSC::Structure::setOutOfLineTypeFlags): Deleted.
(JSC::Structure::setInlineCapacity): Deleted.
(JSC::Structure::setClassInfo): Deleted.
(JSC::Structure::clearPreviousID): Deleted.
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h:
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::setCachedPrototypeChain): Deleted.
- runtime/StructureTransitionTable.h:
- tools/JSDollarVM.cpp:
(JSC::JSDollarVMHelper::functionGetStructureTransitionList):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
- 8:50 AM Changeset in webkit [259462] by
-
- 4 edits in trunk/LayoutTests
Flaky Test: storage/indexeddb/cursor-request-cycle.html
https://bugs.webkit.org/show_bug.cgi?id=209796
<rdar://problem/60171737>
Reviewed by Geoffrey Garen.
gc() does not guarantee all objects to be collected in our current implementation. So, instead of verifying all
cursor and request objects are released, we now only check if any of them is collected, which is enough to show
there is no ref cycle.
- storage/indexeddb/cursor-request-cycle-expected.txt:
- storage/indexeddb/cursor-request-cycle-private-expected.txt:
- storage/indexeddb/resources/cursor-request-cycle.js:
(checkCursor):
(isAnyCollected):
(onOpen.otherRequest.onsuccess.otherRequestSuccess.finalRequest.onsuccess):
(onOpen.otherRequest.onsuccess):
(onOpen):
(onOpen.cursorRequest.onsuccess): Deleted.
(onOpen.otherRequest.onsuccess.otherRequestSuccess.cursorRequest.onsuccess): Deleted.
- 8:43 AM Changeset in webkit [259461] by
-
- 5 edits2 adds in trunk
ASSERTION FAILED: m_delegate in IDBConnectionToClient::identifier()
https://bugs.webkit.org/show_bug.cgi?id=209891
<rdar://problem/59293891>
Reviewed by Geoffrey Garen.
Source/WebCore:
IDBConnectionToClient::connectionToClientClosed() can lead UniqueIDBDatabase to start processing new requests,
and we should make sure it ignores the requests from the closed connection. Otherwise, the connection can be
held alive by the request being processed. We can do that by marking connection closed before calling
connectionToClientClosed on UniqueIDBDatabaseConnection.
API Test: IndexedDB.KillWebProcessWithOpenConnection
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::connectionToClientClosed):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-2.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
(TEST):
- 8:21 AM Changeset in webkit [259460] by
-
- 2 edits in trunk/Source/WebKit
ServiceWorkerFetchTask::timeoutTimerFired should not call contextClosed
https://bugs.webkit.org/show_bug.cgi?id=209906
<rdar://problem/61207801>
Reviewed by Chris Dumez.
Covered by http/tests/workers/service/basic-timeout.https.html no longer crashing.
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):
We should not call contextClosed now that we are nullying m_swServerConnection in contextClosed.
Instead, we should just call cannotHandle since the timer can only fire if we have not yet received any response.
- 7:57 AM Changeset in webkit [259459] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed fix after r259382
Rubber-stamped by Carlos Garcia Campos.
No new tests needed.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_register_uri_scheme): Change g_return_if_fail()
calls to actually check that the passed scheme is not one of the
special ones.
- 7:35 AM Changeset in webkit [259458] by
-
- 2 edits1 delete in trunk/Source/ThirdParty/libwebrtc
Remove rtpplay.exe from the libwebrtc source folder
https://bugs.webkit.org/show_bug.cgi?id=209957
Reviewed by Eric Carlson.
- .gitignore:
- Source/webrtc/data/voice_engine/stereo_rtp_files/rtpplay.exe: Removed.
- 7:17 AM Changeset in webkit [259457] by
-
- 2 edits in trunk/Tools
[ews] Display list of test failures along-with the layout-test build step
https://bugs.webkit.org/show_bug.cgi?id=209912
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTests._addToLog):
(RunWebKitTests.commandComplete): Add list of test failures to 'test-failures' log which is displayed in UI.
(ReRunWebKitTests.commandComplete): Ditto.
(RunWebKitTestsWithoutPatch.commandComplete): Ditto.
- 7:11 AM Changeset in webkit [259456] by
-
- 2 edits in trunk/Tools
REGRESSION(r259453): [Flatpak SDK] Build directory no longer bind-mounted when running tests
https://bugs.webkit.org/show_bug.cgi?id=209960
Reviewed by Carlos Alberto Lopez Perez.
The bind-mount is always needed, not only when running build-webkit.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
- 6:56 AM Changeset in webkit [259455] by
-
- 3 edits2 adds in trunk
[MultiColumn] Infinite loop in RenderBlockFlow::pushToNextPageWithMinimumLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=209948
<rdar://problem/59331899>
Reviewed by Antti Koivisto.
Source/WebCore:
pushToNextPageWithMinimumLogicalHeight is supposed to find the next page/column with enough space for the content.
However we keep finding the same column because it is not balanced properly yet (while in layout, they have the initial height of LayoutUnit::max).
Test: fast/multicol/infinite-loop-with-unbalanced-column.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::pushToNextPageWithMinimumLogicalHeight const):
LayoutTests:
- fast/multicol/infinite-loop-with-unbalanced-column-expected.txt: Added.
- fast/multicol/infinite-loop-with-unbalanced-column.html: Added.
- 5:09 AM Changeset in webkit [259454] by
-
- 9 edits in trunk/JSTests
Re-enable previously skipped arm tests
https://bugs.webkit.org/show_bug.cgi?id=209958
Patch by Paulo Matos <Paulo Matos> on 2020-04-03
Reviewed by Adrian Perez de Castro.
In the past year, some arm tests were skipped to keep the bots green.
All known issues affecting these tests were fixed and now can be unskipped.
- stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
- stress/dont-range-based-iterate-vector-that-is-mutated.js:
- stress/generator-cell-with-type.js:
- stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:
- stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
- stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js:
- stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
- stress/toctou-having-a-bad-time-new-array.js:
- 4:10 AM Changeset in webkit [259453] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Create platform/Release directory only when build-webkit is called
https://bugs.webkit.org/show_bug.cgi?id=209954
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(WebkitFlatpak.clean_args): Remove creation of self.build_path.
(WebkitFlatpak.run_in_sandbox): Create self.build_path if command is
build-webkit.
- 3:46 AM Changeset in webkit [259452] by
-
- 55 edits4 copies25 adds in trunk
Add initial support for WebRTC HEVC
https://bugs.webkit.org/show_bug.cgi?id=204283
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Add H265 packetization/depacketization and ObjC H265 encoder/decoder.
Support is switchable using a boolean given to the decoder/encoder factories.
- Source/webrtc/api/video/video_codec_type.h:
- Source/webrtc/api/video_codecs/video_codec.cc:
- Source/webrtc/api/video_codecs/video_codec.h:
(webrtc::VideoCodecH265::operator!= const):
- Source/webrtc/api/video_codecs/video_encoder.cc:
- Source/webrtc/api/video_codecs/video_encoder.h:
- Source/webrtc/api/video_codecs/video_encoder_config.cc:
- Source/webrtc/api/video_codecs/video_encoder_config.h:
- Source/webrtc/build_overrides/build.gni:
- Source/webrtc/call/rtp_payload_params.cc:
- Source/webrtc/common_video/BUILD.gn:
- Source/webrtc/common_video/h265/h265_common.cc: Added.
- Source/webrtc/common_video/h265/h265_common.h: Added.
- Source/webrtc/common_video/h265/h265_pps_parser.cc: Added.
- Source/webrtc/common_video/h265/h265_pps_parser.h: Added.
- Source/webrtc/common_video/h265/h265_sps_parser.cc: Added.
- Source/webrtc/common_video/h265/h265_sps_parser.h: Added.
- Source/webrtc/common_video/h265/h265_vps_parser.cc: Added.
- Source/webrtc/common_video/h265/h265_vps_parser.h: Added.
- Source/webrtc/media/base/media_constants.cc:
- Source/webrtc/media/base/media_constants.h:
- Source/webrtc/modules/rtp_rtcp/BUILD.gn:
- Source/webrtc/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc:
- Source/webrtc/modules/rtp_rtcp/source/h265_sps_parser.cc: Added.
- Source/webrtc/modules/rtp_rtcp/source/h265_sps_parser.h: Added.
(webrtc::H265SpsParser::width):
(webrtc::H265SpsParser::height):
- Source/webrtc/modules/rtp_rtcp/source/rtp_format.cc:
- Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.cc: Added.
- Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.h: Added.
(webrtc::RtpPacketizerH265::Packet::Packet):
(webrtc::RtpPacketizerH265::PacketUnit::PacketUnit):
(webrtc::VideoRtpDepacketizerH265::~VideoRtpDepacketizerH265):
- Source/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:
- Source/webrtc/modules/rtp_rtcp/source/rtp_video_header.h:
- Source/webrtc/modules/video_coding/BUILD.gn:
- Source/webrtc/modules/video_coding/codecs/h265/include/h265_globals.h: Added.
- Source/webrtc/modules/video_coding/encoded_frame.cc:
- Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.cc: Added.
- Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.h: Added.
- Source/webrtc/modules/video_coding/include/video_codec_interface.h:
- Source/webrtc/modules/video_coding/jitter_buffer_common.h:
- Source/webrtc/modules/video_coding/packet.cc:
- Source/webrtc/modules/video_coding/packet_buffer.cc:
- Source/webrtc/modules/video_coding/session_info.cc:
- Source/webrtc/modules/video_coding/session_info.h:
- Source/webrtc/rtc_base/experiments/min_video_bitrate_experiment.cc:
- Source/webrtc/sdk/WebKit/WebKitUtilities.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::createWebKitEncoderFactory):
(webrtc::createWebKitDecoderFactory):
- Source/webrtc/sdk/objc/components/video_codec/RTCCodecSpecificInfoH265+Private.h: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.h.
- Source/webrtc/sdk/objc/components/video_codec/RTCCodecSpecificInfoH265.h: Added.
- Source/webrtc/sdk/objc/components/video_codec/RTCCodecSpecificInfoH265.mm: Added.
(-[RTCCodecSpecificInfoH265 nativeCodecSpecificInfo]):
- Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.h:
- Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.m:
(-[RTCDefaultVideoDecoderFactory initWithH265:]):
(-[RTCDefaultVideoDecoderFactory supportedCodecs]):
(-[RTCDefaultVideoDecoderFactory createDecoder:]):
- Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h:
- Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:
(-[RTCDefaultVideoEncoderFactory initWithH265:]):
(+[RTCDefaultVideoEncoderFactory supportedCodecs]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):
(-[RTCDefaultVideoEncoderFactory supportedCodecs]):
- Source/webrtc/sdk/objc/components/video_codec/RTCH265ProfileLevelId.h: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.h.
- Source/webrtc/sdk/objc/components/video_codec/RTCH265ProfileLevelId.mm: Added.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.h: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.h.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm: Added.
(RTCH265FrameDecodeParams::RTCH265FrameDecodeParams):
(h265DecompressionOutputCallback):
(-[RTCVideoDecoderH265 init]):
(-[RTCVideoDecoderH265 dealloc]):
(-[RTCVideoDecoderH265 startDecodeWithNumberOfCores:]):
(-[RTCVideoDecoderH265 decode:missingFrames:codecSpecificInfo:renderTimeMs:]):
(-[RTCVideoDecoderH265 setCallback:]):
(-[RTCVideoDecoderH265 releaseDecoder]):
(-[RTCVideoDecoderH265 resetDecompressionSession]):
(-[RTCVideoDecoderH265 configureDecompressionSession]):
(-[RTCVideoDecoderH265 destroyDecompressionSession]):
(-[RTCVideoDecoderH265 setVideoFormat:]):
(-[RTCVideoDecoderH265 implementationName]):
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.h: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoDecoderFactory.h.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.mm: Added.
(-[RTCVideoEncoderH265 initWithCodecInfo:]):
(-[RTCVideoEncoderH265 dealloc]):
(-[RTCVideoEncoderH265 startEncodeWithSettings:numberOfCores:]):
(-[RTCVideoEncoderH265 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH265 setCallback:]):
(-[RTCVideoEncoderH265 setBitrate:framerate:]):
(-[RTCVideoEncoderH265 releaseEncoder]):
(-[RTCVideoEncoderH265 resetCompressionSession]):
(-[RTCVideoEncoderH265 configureCompressionSession]):
(-[RTCVideoEncoderH265 destroyCompressionSession]):
(-[RTCVideoEncoderH265 implementationName]):
(-[RTCVideoEncoderH265 setBitrateBps:]):
(-[RTCVideoEncoderH265 setEncoderBitrateBps:]):
(-[RTCVideoEncoderH265 frameWasEncoded:flags:sampleBuffer:width:height:renderTimeMs:timestamp:rotation:]):
(-[RTCVideoEncoderH265 scalingSettings]):
- Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc:
- Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.h:
- Source/webrtc/sdk/objc/native/src/objc_video_decoder_factory.mm:
(webrtc::ObjCVideoDecoderFactory::CreateVideoDecoder):
- Source/webrtc/sdk/objc/native/src/objc_video_encoder_factory.mm:
(webrtc::ObjCVideoEncoderFactory::CreateVideoEncoder):
- Source/webrtc/video/rtp_video_stream_receiver.cc:
- Source/webrtc/video/rtp_video_stream_receiver.h:
- Source/webrtc/video/send_statistics_proxy.cc:
- Source/webrtc/video/video_receive_stream.cc:
- Source/webrtc/video/video_stream_encoder.cc:
- libwebrtc.xcodeproj/project.pbxproj:
Source/WebCore:
Add a runtime flag for H265 in lieu of VP8 and pipe it to libwebrtc factories.
Test: webrtc/h265.html
- page/Page.cpp:
(WebCore::m_deviceOrientationUpdateProvider):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webRTCH265CodecEnabled const):
(WebCore::RuntimeEnabledFeatures::setWebRTCH265CodecEnabled):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProviderCocoa::createDecoderFactory):
(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Source/WebKit:
Remove VP8 runtime flag and add a H365 runtime flag instead.
- Shared/WebPreferences.yaml:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
- TestExpectations:
- webrtc/h265-expected.txt: Added.
- webrtc/h265.html: Added.
- 2:21 AM Changeset in webkit [259451] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
https://bugs.webkit.org/show_bug.cgi?id=209648
Reviewed by Žan Doberšek.
This patch removes redundant options from webkit-flatpak,
correctly handles the cmakeargs option and reduces the amount of
flatpak listcalls performed.
- flatpak/flatpakutils.py:
(check_flatpak):
(FlatpakPackages.init):
(FlatpakPackage.is_installed):
(WebkitFlatpak.load_from_args):
(WebkitFlatpak.init):
(WebkitFlatpak.clean_args):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.main):
(WebkitFlatpak.setup_dev_env):
(WebkitFlatpak.run_gdb):
- 2:13 AM Changeset in webkit [259450] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Call setup_icecc only if use_icecream is defined
https://bugs.webkit.org/show_bug.cgi?id=209956
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_dev_env):
- 1:38 AM Changeset in webkit [259449] by
-
- 4 edits in trunk/Source
FileSystem handle leaks in CurlCacheManager and NetworkCacheData when failed to open a file
https://bugs.webkit.org/show_bug.cgi?id=209949
Reviewed by Fujii Hironori.
A file handle of FileSystem is not closed when the file handle doesn't
return its status. The handle should be released before returning.
No new tests, no behavior change.
Source/WebCore:
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex):
Source/WebKit:
- NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::mapFile):
- 12:24 AM Changeset in webkit [259448] by
-
- 2 edits in trunk/JSTests
stress/ftl-gettypedarrayoffset-wasteful.js times out on arm/linux
https://bugs.webkit.org/show_bug.cgi?id=198754
Patch by Paulo Matos <Paulo Matos> on 2020-04-03
Reviewed by Žan Doberšek.
Unskip test.
- stress/ftl-gettypedarrayoffset-wasteful.js:
- 12:21 AM Changeset in webkit [259447] by
-
- 6 edits in trunk/Source
WebCore::HTMLMediaElement::mediaCanStart crashes
https://bugs.webkit.org/show_bug.cgi?id=209950
Reviewed by Jer Noble.
Source/WebCore:
Use WeakHashSet instead of HashSet to record MediaCanStartListeners in Document.
- dom/Document.cpp:
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):
- dom/Document.h:
- page/MediaCanStartListener.h:
Source/WebKit:
UserMediaPermissionRequestManager does not need to inherit from
CanMakeWeakPtr<UserMediaPermissionRequestManager> because its
parent class MediaCanStartListener supports WeakPtr now.
- WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
- 12:08 AM Changeset in webkit [259446] by
-
- 3 edits in trunk/Tools
[Windows] Ignore render tree dump based results on Windows
https://bugs.webkit.org/show_bug.cgi?id=209897
Reviewed by Darin Adler.
Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
default on Apple Windows port.
With the option set the render tree dump tests are still run (so crashes are detected) but their
output is treated as if it always passed. Missing results are not written to disk.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_text):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 12:04 AM Changeset in webkit [259445] by
-
- 4 edits in trunk/Source/WebCore
Flesh out enclosingScrollableArea() implementations
https://bugs.webkit.org/show_bug.cgi?id=209953
Reviewed by Timothy Hatcher.
enclosingScrollableArea() is a virtual function on ScrollableArea. It's currently
only called in an unused iOS WebKit1 code path, but will soon be used for scroll
latching, so flesh out implementations.
Will be tested by future scroll latching tests.
- page/FrameView.cpp:
(WebCore::FrameView::enclosingScrollableArea const):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingScrollableArea const):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::enclosingScrollableArea const):
Apr 2, 2020:
- 10:57 PM Changeset in webkit [259444] by
-
- 5 edits in trunk
TypedArray's DefineOwnProperty? is incorrect with partial descriptors
https://bugs.webkit.org/show_bug.cgi?id=188875
Reviewed by Ross Kirsling.
JSTests:
- stress/typedarray-configure-index.js:
- test262/expectations.yaml: Mark 10 test cases as passing.
Source/JavaScriptCore:
This change implements steps 3.b.iv-v of TypedArray's DefineOwnProperty? method [1],
preventing type errors from being thrown if descriptor lacks Enumerable? or Writable?
field and aligning JSC with V8 and SpiderMonkey.
[1]: https://tc39.es/ecma262/#sec-integer-indexed-exotic-objects-defineownproperty-p-desc
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
- 10:46 PM Changeset in webkit [259443] by
-
- 5 edits in trunk/Source/WebCore
Rename widgetDidHandleWheelEvent back to passWheelEventToWidget and make some functions private
https://bugs.webkit.org/show_bug.cgi?id=209951
Reviewed by Zalan Bujtas.
Revert the rename from r199331, and make private wheel-event related functions that
are internal to EventHandler.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::widgetDidHandleWheelEvent): Deleted.
- page/EventHandler.h:
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::widgetDidHandleWheelEvent): Deleted.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::widgetDidHandleWheelEvent): Deleted.
- 9:56 PM Changeset in webkit [259442] by
-
- 2 edits in trunk/Tools
Add myself, as a committer, to contributors.json.
https://bugs.webkit.org/show_bug.cgi?id=209952.
- Scripts/webkitpy/common/config/contributors.json:
- 9:51 PM Changeset in webkit [259441] by
-
- 2 edits in trunk/Tools
Add myself to contributors.json.
https://bugs.webkit.org/show_bug.cgi?id=209952.
- Scripts/webkitpy/common/config/contributors.json:
- 8:56 PM Changeset in webkit [259440] by
-
- 20 edits4 adds in trunk
Add SPI to configure WebsiteDataStores with a URL for standalone web applications and use it to disable first-party website data removal in ITP
https://bugs.webkit.org/show_bug.cgi?id=209634
<rdar://problem/60943970>
Reviewed by Alex Christensen.
Source/WebKit:
This change adds a new property to _WKWebsiteDataStoreConfiguration.h called
standaloneApplicationURL with which the hosting application can inform the
website data store that it's running as a standalone web application.
This change also forwards an existing standaloneApplicationURL as a
WebCore::RegistrableDomain into ITP so that explicit exemptions can be made
to first parties of standalone web applications. The exemptions made here
all for all of ITP's website data removal. This part of the change is
covered by the new layout tests.
Tests: http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database.html
http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
(WebKit::ResourceLoadStatisticsStore::setStandaloneApplicationDomain):
(WebKit::ResourceLoadStatisticsStore::standaloneApplicationDomain const):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setStandaloneApplicationDomain):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::forwardResourceLoadStatisticsSettings):
- NetworkProcess/NetworkSession.h:
- Shared/ResourceLoadStatisticsParameters.h:
(WebKit::ResourceLoadStatisticsParameters::encode const):
(WebKit::ResourceLoadStatisticsParameters::decode):
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration standaloneApplicationURL]):
(-[_WKWebsiteDataStoreConfiguration setStandaloneApplication:]):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::copy const):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::standaloneApplicationURL const):
(WebKit::WebsiteDataStoreConfiguration::setStandaloneApplicationURL):
Tools:
Added a new test option called standaloneWebApplicationURL so that layout tests can
configure the website data store accordingly. Picking it up and using it requires
creating a new website data store with a configuration that has the standalone web
application URL.
- WebKitTestRunner/TestController.cpp:
(WTR::parseStringTestHeaderValueAsURL):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
LayoutTests:
- http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database-expected.txt: Added.
- http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database.html: Added.
- http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-expected.txt: Added.
- http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html: Added.
- 7:49 PM Changeset in webkit [259439] by
-
- 3 edits in trunk/LayoutTests
Rebase expectation files for anchor tag tests with line number output
https://bugs.webkit.org/show_bug.cgi?id=209945
<rdar://problem/61237662>
Unreviewed test gardening.
- http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
Rebased since the lines of the console output have changed.
- http/tests/security/anchor-download-block-crossorigin-expected.txt:
Rebased since the lines of the console output have changed.
- 6:51 PM Changeset in webkit [259438] by
-
- 6 edits1 add in trunk
Crash in RenderMenuList::didUpdateActiveOption.
https://bugs.webkit.org/show_bug.cgi?id=208867
<rdar://problem/60035390>
Reviewed by Chris Fleizach.
Source/WebCore:
Enabled test accessibility/menu-list-sends-change-notification.html.
- Check the type of the AccessibilityObject before downcasting in RenderMenuList.
- Fixed handling of the AXMenuListValueChanged notification on the Mac.
This notification was previously ignored and hence the LayoutTest was failing.
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- rendering/RenderMenuList.cpp:
(RenderMenuList::didUpdateActiveOption):
LayoutTests:
Enabled accessibility/menu-list-sends-change-notification.html test
and added the expected.txt file for it.
- accessibility/menu-list-sends-change-notification-expected.txt: Added.
- accessibility/menu-list-sends-change-notification.html:
- 6:24 PM Changeset in webkit [259437] by
-
- 3 edits in trunk/Source/WebInspectorUI
Context menu for local storage puts quotes around key and value
https://bugs.webkit.org/show_bug.cgi?id=209868
Reviewed by Joseph Pecoraro.
There are only two
WI.DataGridthat support editing right now. Both of them use obvious
names for their columns (e.g. "Key", "Name", "Value", etc.), so rather than quote the column
name in the context menu, just display it as is.
- UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype._contextMenuInDataTable):
- Localizations/en.lproj/localizedStrings.js:
- 5:37 PM Changeset in webkit [259436] by
-
- 9 edits2 deletes in trunk
Unreviewed, reverting r259390.
https://bugs.webkit.org/show_bug.cgi?id=209944
It broke WinCairo builds (Requested by fujihiro on #webkit).
Reverted changeset:
"Enable offlineasm debug annotations for GCC"
https://bugs.webkit.org/show_bug.cgi?id=207119
https://trac.webkit.org/changeset/259390
- 5:37 PM Changeset in webkit [259435] by
-
- 21 edits2 adds10 deletes in trunk/Source/WebCore
Remove unused media controls code
https://bugs.webkit.org/show_bug.cgi?id=209875
<rdar://problem/61172738>
Remove code for the, now unused, C++ based media controls.
Reviewed by Daniel Bates.
No new tests, no functional change.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::textTrackContainer):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/plugins/QuickTimePluginReplacement.mm:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
- accessibility/AccessibilityMediaControls.cpp: Removed.
- accessibility/AccessibilityMediaControls.h: Removed.
- dom/Node.h:
(WebCore::Node::isMediaControlElement const): Deleted.
(WebCore::Node::isMediaControls const): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::childShouldCreateRenderer const):
(WebCore::HTMLMediaElement::pauseAfterDetachedTask):
(WebCore::HTMLMediaElement::updateRenderer):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::ensureMediaControlsShadowRoot):
(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::layoutSizeChanged):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::didBecomeFullscreenElement):
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::updateTextTrackDisplay):
(WebCore::HTMLMediaElement::updateTextTrackRepresentationImageIfNeeded):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureMediaControls):
(WebCore::HTMLMediaElement::captionPreferencesChanged):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
(WebCore::HTMLMediaElement::closeCaptionTracksChanged): Deleted.
(WebCore::HTMLMediaElement::mediaControls const): Deleted.
(WebCore::HTMLMediaElement::hasMediaControls const): Deleted.
(WebCore::HTMLMediaElement::createMediaControls): Deleted.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaControlsHost):
- html/shadow/MediaControlElementTypes.cpp: Removed.
- html/shadow/MediaControlElementTypes.h: Removed.
- html/shadow/MediaControlElements.cpp: Removed.
- html/shadow/MediaControlElements.h: Removed.
- html/shadow/MediaControlTextTrackContainerElement.cpp: Added.
(WebCore::MediaControlTextTrackContainerElement::create):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):
(WebCore::compareCueIntervalForDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationImageIfNeeded):
(WebCore::MediaControlTextTrackContainerElement::processActiveVTTCue):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
(WebCore::MediaControlTextTrackContainerElement::updateTextStrokeStyle):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationIfNeeded):
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackStyle):
(WebCore::MediaControlTextTrackContainerElement::enteredFullscreen):
(WebCore::MediaControlTextTrackContainerElement::exitedFullscreen):
(WebCore::MediaControlTextTrackContainerElement::updateVideoDisplaySize):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
(WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged):
(WebCore::MediaControlTextTrackContainerElement::hide):
(WebCore::MediaControlTextTrackContainerElement::show):
(WebCore::MediaControlTextTrackContainerElement::isShowing const):
(WebCore::MediaControlTextTrackContainerElement::logger const):
(WebCore::MediaControlTextTrackContainerElement::logIdentifier const):
(WebCore::MediaControlTextTrackContainerElement::logChannel const):
- html/shadow/MediaControlTextTrackContainerElement.h: Added.
- html/shadow/MediaControls.cpp: Removed.
- html/shadow/MediaControls.h: Removed.
- page/CaptionUserPreferencesMediaAF.cpp:
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setUserInterfaceLayoutDirection):
- rendering/RenderMediaControls.cpp: Removed.
- rendering/RenderMediaControls.h: Removed.
- rendering/RenderSlider.cpp:
- rendering/RenderTheme.cpp:
- rendering/RenderThemeAdwaita.cpp:
- rendering/RenderThemeCocoa.h:
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsStyleSheet):
(WebCore::RenderThemeIOS::modernMediaControlsStyleSheet):
(WebCore::RenderThemeIOS::mediaControlsScript):
(WebCore::RenderThemeIOS::mediaControlsBase64StringForIconNameAndType):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsStyleSheet):
(WebCore::RenderThemeMac::modernMediaControlsStyleSheet):
(WebCore::RenderThemeMac::mediaControlsScript):
(WebCore::RenderThemeMac::mediaControlsBase64StringForIconNameAndType):
- testing/Internals.cpp:
(WebCore::Internals::getCurrentMediaControlsStatusForElement):
- 5:19 PM Changeset in webkit [259434] by
-
- 3 edits in trunk/LayoutTests
[ iOS wk2 ] fast/images/exif-orientation-background-image-repeat.html is flaky failing.
<rdar://problem/60921187>
Unreviewed test gardening.
Add "image-rendering: pixelated;" to the elements which render images to avoid unintended anti-aliasing.
- fast/images/exif-orientation-background-image-repeat-expected.html:
- fast/images/exif-orientation-background-image-repeat.html:
- 5:18 PM Changeset in webkit [259433] by
-
- 8 edits in trunk/Source
Versioning.
- 5:16 PM Changeset in webkit [259432] by
-
- 8 edits in branches/safari-610.1.7-branch/Source
Versioning.
- 5:16 PM Changeset in webkit [259431] by
-
- 8 edits in branches/safari-609.2.1.2-branch/Source
Versioning.
- 5:13 PM Changeset in webkit [259430] by
-
- 3 edits in trunk/Source/WebCore
Don't call -[AVCapture startRunning] when interruption ends
https://bugs.webkit.org/show_bug.cgi?id=209919
<rdar://problem/61090625>
Calling -[AVCaptureSession startRunning] after a VideoNotAllowedInSideBySide interruption
ends triggers a bug in AVCapture that hangs the app for several seconds, but restarting the
capture session isn't necessary because it will restart automatically in that case.
Reviewed by Youenn Fablet.
Tested manually.
- platform/mediastream/mac/AVVideoCaptureSource.h: Remove InterruptionReason enum, convert
m_interruption to m_interrupted bool
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource): Remove InterruptionReason enum checking.
(WebCore::AVVideoCaptureSource::stopProducingData): m_interruption -> m_interrupted.
(WebCore::AVVideoCaptureSource::interrupted const): Ditto.
(WebCore::AVVideoCaptureSource::captureSessionBeginInterruption): Ditto.
(WebCore::AVVideoCaptureSource::captureSessionEndInterruption): Ditto. Don't restart the session.
(-[WebCoreAVVideoCaptureSourceObserver observeValueForKeyPath:ofObject:change:context:]):
Drive-by fix: always log notifications to help with debugging.
- 5:05 PM Changeset in webkit [259429] by
-
- 1 copy in tags/Safari-609.2.1.2.11
Tag Safari-609.2.1.2.11.
- 4:52 PM Changeset in webkit [259428] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r258525): Leak of NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]
<https://webkit.org/b/209932>
<rdar://problem/61228565>
Reviewed by Chris Fleizach.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Move early return to avoid leaking NSMutableAttributedString.
- 4:41 PM Changeset in webkit [259427] by
-
- 1 copy in tags/Safari-609.2.3
Tag Safari-609.2.3.
- 4:36 PM Changeset in webkit [259426] by
-
- 1 copy in tags/Safari-610.1.7.7
Tag Safari-610.1.7.7.
- 4:25 PM Changeset in webkit [259425] by
-
- 4 edits in trunk/Source
Unreviewed build fix after r259396.
Source/WebCore/PAL:
- pal/spi/cocoa/LaunchServicesSPI.h:
Source/WebKit:
- Shared/mac/AuxiliaryProcessMac.mm:
- 4:22 PM Changeset in webkit [259424] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] RecordedStatuses's assignment should be guarded by CodeBlock's lock
https://bugs.webkit.org/show_bug.cgi?id=209935
<rdar://problem/59443383>
Reviewed by Mark Lam.
Previously RecordedStatuses are not touched by GC. But now, GC visits RecordedStatuses.
This means that modifying RecordedStatuses should be guarded by CodeBlock's lock if
it is reachable from CodeBlock.
In DFG::Plan::reallyAdd, we already installed DFG::JITCode into the CodeBlock so that
RecordedStatuses is reachable from CodeBlock. We should lock CodeBlock's lock while
performingWTFMove(RecordedStatuses).
We do not need to emit write-barrier here because (1) DFG::Plan::reallyAdd is executed
while GC is deferred and (2) we emit write-barrier to CodeBlock before deferred GC is executed.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reallyAdd):
- 4:18 PM Changeset in webkit [259423] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network tab summary bar jiggles
https://bugs.webkit.org/show_bug.cgi?id=209927
Reviewed by Timothy Hatcher.
- UserInterface/Views/NetworkTableContentView.css:
(.network-table > .statistics > .statistic > .text):
- 3:52 PM Changeset in webkit [259422] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Sort libwebrtc Xcode project file
- libwebrtc.xcodeproj/project.pbxproj:
- 2:58 PM Changeset in webkit [259421] by
-
- 2 edits in trunk/Source/WebKit
WebPageProxy attachment methods should return early if attachment element is not enabled
<https://webkit.org/b/209451>
<rdar://problem/60253260>
Reviewed by Chris Dumez.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::registerAttachmentIdentifierFromFilePath):
(WebKit::WebPageProxy::registerAttachmentIdentifier):
(WebKit::WebPageProxy::registerAttachmentsFromSerializedData):
(WebKit::WebPageProxy::cloneAttachmentData):
(WebKit::WebPageProxy::serializedAttachmentDataForIdentifiers):
(WebKit::WebPageProxy::didInsertAttachmentWithIdentifier):
- Add a message check for the attachment element being enabled.
(WebKit::WebPageProxy::didRemoveAttachmentWithIdentifier): Ditto.
- Also add a missing message check to validate
identifier.
- 2:51 PM Changeset in webkit [259420] by
-
- 2 edits in trunk/LayoutTests
[iOS wk2 Debug] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207077
Remove the flaky failing expectation since the test appears to be passing now.
- platform/ios-wk2/TestExpectations:
- 2:49 PM Changeset in webkit [259419] by
-
- 16 edits in trunk/Source/WebCore
ActiveDOMObject::hasPendingActivity() should stop preventing wrapper collection after ActiveDOMObject::stop() has been called
https://bugs.webkit.org/show_bug.cgi?id=209886
Reviewed by Ryosuke Niwa.
ActiveDOMObject::stop() gets called when the script execution context is about to be destroyed.
ActiveDOMObject objects should no longer run script after that and there is therefore no point
in keeping the JS wrapper alive once stop() has been called. Worse, depending on the
implementation of virtualHasPendingActivity(), keeping the wrapper alive past this point may
actually cause JS wrapper leaks. Some of the virtualHasPendingActivity() were properly checking
if the context was stopped but not all of them. To address the issue, we now check
ActiveDOMObject::isContextStopped() in the JS bindings, in addition to
ActiveDOMObject::hasPendingActivity(), so that it is no longer possible to keep a JS wrapper
alive past the point where the script execution context has been stopped. This new approach
is a lot less leak/error prone.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::virtualHasPendingActivity const):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::requestCompleted):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::virtualHasPendingActivity const):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::virtualHasPendingActivity const):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::notifyDidAbort):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::dispatchEvent):
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::virtualHasPendingActivity const):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
- css/FontFace.cpp:
(WebCore::FontFace::virtualHasPendingActivity const):
- dom/ActiveDOMObject.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::virtualHasPendingActivity const):
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::getOrCreate):
(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):
(WebCore::ServiceWorkerRegistration::queueTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerRegistration::stop):
(WebCore::ServiceWorkerRegistration::virtualHasPendingActivity const):
- workers/service/ServiceWorkerRegistration.h:
- 2:48 PM Changeset in webkit [259418] by
-
- 3 edits in trunk/Source/JavaScriptCore
HeapSnapshotBuilder::analyzeNode() should filter out duplicate cells.
https://bugs.webkit.org/show_bug.cgi?id=209929
<rdar://problem/60974478>
Reviewed by Keith Miller.
HeapSnapshot::finalize() assumes that its list of cells contain no duplicate cells.
HeapSnapshot::appendNode() expects to only be called once for a cell. It doesn't
check for duplicates.
However, with the concurrent GC marker, there’s a racy chance that the same cell
is visited more than once by SlotVisitor, and therefore, SlotVisitor may call
HeapSnapshotBuilder::analyzeNode() (and HeapSnapshot::appendNode()) more than once
for the same cell.
The easiest and cleanest fix for this is to simply keep a HashSet of appended
cells in HeapSnapshotBuilder while it is building the snapshot. We can then use
the hash set to filter out already appended cells, and avoid adding duplicates to
the HeapSnapshot.
- heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::buildSnapshot):
(JSC::HeapSnapshotBuilder::analyzeNode):
- heap/HeapSnapshotBuilder.h:
- 2:35 PM Changeset in webkit [259417] by
-
- 2 edits10 adds in trunk/LayoutTests
Add some more scroll-latching tests
https://bugs.webkit.org/show_bug.cgi?id=209924
Reviewed by Zalan Bujtas.
Add three scroll latching tests.
iframe-latch-small-deltas.html tests that starting a second scroll where the dominant
direction can't be determined re-uses the previous latching. This test currently fails.
overflow-in-iframe-latching.html tests a wheel over a scrolled-to-top overflow inside
a not-scrolled-to-top iframe; the iframe should scroll. This test currently fails.
latching-and-wheel-events.html tests that wheel events always go to the innermost target,
even if not latched, and don't propagate across frame boundaries. This test passes
the event propagation part, but fails in a similar way to overflow-in-iframe-latching.html .
- fast/scrolling/latching/iframe-latch-small-deltas-expected.txt: Added.
- fast/scrolling/latching/iframe-latch-small-deltas.html: Added.
- fast/scrolling/latching/latching-and-wheel-events-expected.txt: Added.
- fast/scrolling/latching/latching-and-wheel-events.html: Added.
- fast/scrolling/latching/overflow-in-iframe-latching-expected.txt: Added.
- fast/scrolling/latching/overflow-in-iframe-latching.html: Added.
- platform/mac-wk1/fast/scrolling/latching/iframe-latch-small-deltas-expected.txt: Added.
- platform/mac-wk1/fast/scrolling/latching/latching-and-wheel-events-expected.txt: Added.
- platform/mac-wk1/fast/scrolling/latching/overflow-in-iframe-latching-expected.txt: Added.
- resources/ui-helper.js:
(window.UIHelper.async mouseWheelScrollAt):
(window.UIHelper.async waitForScrollCompletion):
- 2:35 PM Changeset in webkit [259416] by
-
- 4 edits in trunk/Source/WebCore
Rename some wheel-event related functions
https://bugs.webkit.org/show_bug.cgi?id=209918
Reviewed by Zalan Bujtas.
Rename some functions to describe what they do, rather than being generic "platform" things, to make
the code easier to read.
Similarly, rename m_clearLatchingStateTimer for what it does.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearLatchedStateTimerFired):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::recordWheelEventForDeltaFilter):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::EventHandler::completeWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::platformPrepareForWheelEvents): Deleted.
(WebCore::EventHandler::platformRecordWheelEvent): Deleted.
(WebCore::EventHandler::platformCompleteWheelEvent): Deleted.
(WebCore::EventHandler::platformNotifyIfEndGesture): Deleted.
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::clearOrScheduleClearingLatchedStateIfNeeded):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::recordWheelEventForDeltaFilter):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::EventHandler::platformPrepareForWheelEvents): Deleted.
(WebCore::EventHandler::platformRecordWheelEvent): Deleted.
(WebCore::EventHandler::platformCompleteWheelEvent): Deleted.
(WebCore::EventHandler::platformNotifyIfEndGesture): Deleted.
- 1:52 PM Changeset in webkit [259415] by
-
- 2 edits in trunk/Source/WebCore/PAL
Unreviewed build fix after r259396.
- pal/spi/cocoa/LaunchServicesSPI.h:
- 1:49 PM Changeset in webkit [259414] by
-
- 5 edits in trunk/Source
[iOS] Replace UIKit background task with a RunningBoard FinishTaskInterruptable assertion
https://bugs.webkit.org/show_bug.cgi?id=209825
<rdar://problem/61118503>
Reviewed by Geoffrey Garen.
Source/WebKit:
Replace UIKit background task with a RunningBoard FinishTaskInterruptable assertion on iOS.
Our UIProcess gets terminated too frequently when the UIKit background task expires when
the UIProcess holds it for longer than 30 seconds in the background. The RunningBoard
FinishTaskInterruptable assertion is supposed to be equivalent but would cause suspension
of our UIProcess on expiration, instead of termination.
- UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _scheduleReleaseTask]):
(-[WKProcessAssertionBackgroundTaskManager _cancelPendingReleaseTask]):
(-[WKProcessAssertionBackgroundTaskManager _hasBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager assertionWillInvalidate:]):
(-[WKProcessAssertionBackgroundTaskManager assertion:didInvalidateWithError:]):
(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
Source/WTF:
Add build-time flag for WebKit-specific assertion in RunningBoard.
- wtf/PlatformHave.h:
- 1:45 PM Changeset in webkit [259413] by
-
- 1 copy in tags/Safari-610.1.8
Tag Safari-610.1.8.
- 1:44 PM Changeset in webkit [259412] by
-
- 1 delete in tags/Safari-610.1.8
Delete tag.
- 1:41 PM Changeset in webkit [259411] by
-
- 1 copy in branches/safari-610.1.8-branch
New branch.
- 1:41 PM Changeset in webkit [259410] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Allow use of syscall from the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=209920
<rdar://problem/58743778>
Reviewed by Darin Adler.
Add syscall to the WebContent sandbox on iOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 1:38 PM Changeset in webkit [259409] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Remove use of 'apple-signed-executable?' from Sandbox
https://bugs.webkit.org/show_bug.cgi?id=209914
<rdar://problem/45088481>
Reviewed by Per Arne Vollan.
Some of the rules imported from the system sandbox make decisions based on whether the software is
an apple-signed executable or not. This predicate is not relevant for the WebKit processes, and
should be removed (it is always apple-signed).
This patch makes the following changes:
- Removes all uses of 'apple-signed-executable?' (since it is always true for WebKit).
- Removed two iCloud preference reads that are not used in WebKit.
- Switches from the deprecated 'com.apple.ReportCrash.SimulateCrash' XPC service to its
correct name 'com.apple.osanalytics.osanalyticshelper'.
Covered by existing regression tests.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 1:33 PM Changeset in webkit [259408] by
-
- 3 edits4 adds in trunk
Traverse float descendants when computing event and touch-action regions
https://bugs.webkit.org/show_bug.cgi?id=209896
<rdar://problem/61196287>
Reviewed by Antti Koivisto.
Source/WebCore:
Consider floating objects when computing the event region and touch-action region.
For touch-action hit testing this means that CSS touch-action is honored on floating
objects.
Tests: fast/scrolling/ios/event-region-float.html
pointerevents/ios/touch-action-region-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
LayoutTests:
Add tests to ensure that floating objects are considered when computing the
event region and touch-action regions. Without this change, event-region-float.html
would not create an event region at all and touch-action-region-float.html
would not list the floating objects with "touch-action: none".
- fast/scrolling/ios/event-region-float-expected.txt: Added.
- fast/scrolling/ios/event-region-float.html: Added.
- pointerevents/ios/touch-action-region-float-expected.txt: Added.
- pointerevents/ios/touch-action-region-float.html: Added.
- 1:28 PM Changeset in webkit [259407] by
-
- 1 copy in tags/Safari-610.1.8
Tag Safari-610.1.8.
- 1:20 PM Changeset in webkit [259406] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 Debug ] inspector/css/add-css-property.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209921
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 1:05 PM Changeset in webkit [259405] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Mark http/tests/inspector/network/har/har-page-aggressive-gc.html
as slow for mac-wk1 debug.
- 12:58 PM Changeset in webkit [259404] by
-
- 4 edits in trunk/Source/WebCore
Hulu.com gets stuck in a "loading" state when seeking
https://bugs.webkit.org/show_bug.cgi?id=209916
<rdar://problem/55041979>
Reviewed by Eric Carlson.
Hulu.com depends on the "canplay" event firing after a seek to hide their loading indicator.
The HTML spec says that "canplay" should only be fired when moving from the HAVE_CURRENT_DATA
to HAVE_FUTURE_DATA or greater, but when seeking within the buffered range, the readyState
never drops below HAVE_FUTURE_DATA. To work around this behavior, add a quirk for Hulu.com
that always fires "canplay" after a seek completes, so long as the readyState is HAVE_FUTURE_DATA
or higher.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::finishSeek):
- page/Quirks.cpp:
(WebCore::Quirks::needsCanPlayAfterSeekedQuirk const):
- page/Quirks.h:
- 12:16 PM Changeset in webkit [259403] by
-
- 2 edits in trunk/Tools
REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm
<https://webkit.org/b/209915>
Reviewed by Darin Adler.
- DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
(createCoreAnimationLayer): Use RetainPtr<> to fix leak.
- 12:06 PM Changeset in webkit [259402] by
-
- 10 edits2 adds in trunk
Avoid null deref after inserting a text field with a list attribute
https://bugs.webkit.org/show_bug.cgi?id=209909
<rdar://problem/60742229>
Reviewed by Ryosuke Niwa.
Source/WebCore:
On macOS, when painting a text field with an associated datalist (i.e.
HTMLInputElement::list()is non-null),
we assume that the datalist suggestions dropdown button has a renderer (in other words, it does not have a style
ofdisplay: none).
Existing logic in
TextFieldInputTypeis responsible for upholding this invariant -- when the list attribute
changes on an input field (e.g. when we parse the list attribute, or when it is set by JavaScript), we update
the inline display style ofm_dataListDropdownIndicator, such that it is set todisplay: noneonly if there
is either no list attribute, or the list attribute is empty, or the list does not refer to a connected datalist
element. However, there is one scenario in which this invariant is violated. Consider the following:
- An input field is created, and its list attribute is set to "foo". Importantly, it is not connected yet.
- A datalist element with id "foo" is then created and then added to the document.
- The input field created in (1) is then added to the document.
In this scenario,
listAttributeTargetChanged()is invoked after (1), but since it is not connected, it has no
datalist yet, and som_dataListDropdownIndicatorwill remain non-rendered. When it is later added to the DOM,
nothing attempts tom_dataListDropdownIndicatoreven though its list attribute now refers to a datalist, so
it remains hidden. When we later go to paint the input's datalist dropdown button in
RenderThemeMac::paintListButtonForInput, we assume that the dropdown button must be rendered because the input
has a datalist and subsequently crash sincebuttonElement->renderer()remains null.
To fix this, we add logic to update the datalist dropdown button's inline display style when it is connected to
the document with an existing, non-empty list attribute.
Test: fast/forms/datalist/append-input-with-list-attribute.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::didFinishInsertingNode):
Notify the InputType subclass that the datalist element may have changed after an input element is connected
to the document with a non-empty list attribute.
(WebCore::HTMLInputElement::dataListMayHaveChanged):
(WebCore::ListAttributeTargetObserver::idTargetChanged):
(WebCore::HTMLInputElement::listAttributeTargetChanged): Deleted.
Rename listAttributeTargetChanged to dataListMayHaveChanged, since it is no longer called only when the list
attribute changes value, but rather when the input's datalist element may have changed.
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::dataListMayHaveChanged):
(WebCore::InputType::listAttributeTargetChanged): Deleted.
- html/InputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::dataListMayHaveChanged):
(WebCore::RangeInputType::listAttributeTargetChanged): Deleted.
- html/RangeInputType.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::dataListMayHaveChanged):
(WebCore::TextFieldInputType::listAttributeTargetChanged): Deleted.
- html/TextFieldInputType.h:
LayoutTests:
Add a layout test to exercise the crashing scenario, and verify that the end result of programmatically
inserting the text field is identical to simply putting an input field with a datalist in the markup.
- fast/forms/datalist/append-input-with-list-attribute-expected.html: Added.
- fast/forms/datalist/append-input-with-list-attribute.html: Added.
- 11:57 AM Changeset in webkit [259401] by
-
- 52 edits in trunk
Remove all uses of live ranges from TextIterator
https://bugs.webkit.org/show_bug.cgi?id=209723
Reviewed by Antti Koivisto.
Source/WebCore:
- Replaced TextIterator::getLocationAndLengthFromRange with a function named characterRange that computes a CharacterRange given a scope and a range.
- Removed the overload of plainText that takes a pointer to a live range.
- Update the many callers of plainText that pass a pointer to a live range to pass a reference instead, adding null checks as needed to preserve behavior.
- Rewrote some call sites to not use live ranges at all, or use them minimally.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::nextSentenceEndPosition const): Streamlined
the logic in this function, using a smaller number of null checks since the
functions we are calling also do null checks, simpler variable names and
fewer local variables. Pass a reference to a live range rather than a
pointer to the plainText function.
(WebCore::AccessibilityObject::previousSentenceStartPosition const): Ditto.
(WebCore::AccessibilityObject::nextParagraphEndPosition const): Ditto.
(WebCore::AccessibilityObject::previousParagraphStartPosition const): Ditto.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement const): Ditto.
(WebCore::boundsForRects): Converted this to a file-local function and changed
it to take a SimpleRange instead of a live range.
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const): Pass
a reference to a live range instead of a pointer.
(WebCore::AccessibilityRenderObject::boundsForRange const): Ditto.
- accessibility/AccessibilityRenderObject.h: Removed boundsForRects.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Rewrote to use
characterRange instead of TextIterator::getLocationAndLengthFromRange.
- dom/BoundaryPoint.h:
(WebCore::makeBoundaryPointBeforeNodeContents): Added.
- dom/Element.cpp:
(WebCore::Element::innerText): Pass a SimpleRange instead of a live range
to the plainText function.
- dom/Range.cpp:
(WebCore::Range::text const): Pass a reference to a live range instead of a
pointer to the plainText function.
- dom/SimpleRange.cpp:
(WebCore::makeBoundaryPointAfterNodeContents): Added.
(WebCore::makeRangeSelectingNodeContents): Use makeBoundaryPointBeforeNodeContents
and makeBoundaryPointAfterNodeContents
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyPendingCorrection): Pass a reference
to a live range to plainText.
(WebCore::AlternativeTextController::show): Ditto.
(WebCore::AlternativeTextController::timerFired): Ditto.
(WebCore::AlternativeTextController::handleAlternativeTextUIResult): Ditto.
(WebCore::AlternativeTextController::recordAutocorrectionResponse): Ditto. Also
take a SimpleRange argument.
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
Ditto.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):Ditto.
- editing/AlternativeTextController.h: Update for the above changes.
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord): Pass a reference
to a live range to plainText.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Ditto.
Also refactor for simplicity and clarity.
(WebCore::Editor::markAndReplaceFor): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
(WebCore::Editor::transpose): Ditto.
(WebCore::Editor::addRangeToKillRing): Ditto.
(WebCore::Editor::stringForCandidateRequest const): Ditto.
- editing/ReplaceRangeWithTextCommand.cpp:
(WebCore::ReplaceRangeWithTextCommand::doApply): Ditto.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment): Ditto.
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply): Ditto.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::text const): Ditto.
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): Ditto.
- editing/TextIterator.cpp: Use more constexpr.
(WebCore::characterSubrange): Deleted. Moved the logic from this function
into the one place using it, the rangeForMatch function.
(WebCore::resolveCharacterLocation): Deleted. Moved to the header file.
(WebCore::TextIterator::getLocationAndLengthFromRange): Deleted.
(WebCore::plainText): Deleted the overload that takes a live range pointer.
(WebCore::plainTextUsingBackwardsTextIteratorForTesting): Deleted. Moved
the implementation to Internals. There's nothing special about the algorithm,
it uses SimplifiedBackwardsTextIterator in a simple way.
(WebCore::collapsedToBoundary): Deleted. Moved the code to the one place
it's used, the rangeForMatch function.
(WebCore::forEachMatch): Renamed from findPlainTextMatches and changed to
work without any use of live ranges and to use CharacterRange.
(WebCore::rangeForMatch): Rewrote to include more of the logic, removing
the collapsedToBoundary and characterSubrange functions, and to not use
any live ranges.
(WebCore::findClosestPlainText): Rewrote to tighten up the algorithm a
bit, break ties based on the search direction, and have less repetitive code.
(WebCore::findPlainText): Rewrote for clarity.
- editing/TextIterator.h: Removed the forward declaration of Range.
Removed the overload of plainText that takes a live range pointer. Moved
the functions that work with character ranges up to the top of the file,
grouped the other functions more logically. Deleted the
TextIterator::getLocationAndLengthFromRange function. Put some inline
function definitions here.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Pass a reference
to a live range to plainText.
- editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition): Pass a SimpleRange to plainText
rather than a live range.
- editing/cocoa/DataDetection.mm:
(WebCore::detectItemAtPositionWithRange): Pass a reference to a live
range to plainText.
- editing/cocoa/DictionaryLookup.mm:
(WebCore::DictionaryLookup::rangeForSelection): Ditto.
- editing/cocoa/HTMLConverter.h: Tweaked #if a bit.
- editing/mac/DictionaryLookupLegacy.mm:
(WebCore::DictionaryLookup::rangeForSelection): Pass a reference to a
live range to plainText. Also rewrote logic to use mostly SimpleRange.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedTextRespectingRange): Ditto.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent const): Ditto.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::toString): Ditto.
- page/Page.cpp:
(WebCore::Page::replaceRangesWithText): Rewrote to replaces use of
TextIterator::getLocationAndLengthFromRange with characterRange.
- page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Pass a
reference to a live range to plainText.
- testing/Internals.cpp:
(WebCore::Internals::locationFromRange): Use characterRange.
(WebCore::Internals::lengthFromRange): Ditto.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator):
USe SimplifiedBackwardsTextIterator directly since we no longer have
the function plainTextUsingBackwardsTextIteratorForTesting.
Source/WebKit:
- Shared/EditingRange.cpp:
(WebKit::EditingRange::fromRange): Use characterRange.
- Shared/mac/AttributedString.h: Added a constructor that takes rvalue
references so we can initialize this slightly more efficiently.
- Shared/mac/AttributedString.mm:
(IPC::ArgumentCoder<WebKit::AttributedString>::decode): Pass rvalue
references when creating an AttributedString.
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::updateSpellingUIWithGrammarString): Simplify the
code to remove some local variables that weren't helpful.
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Made the
annotatedSubstringBetweenPositions a static member function. Also used
const& argument types to cut down on reference count churn a bit.
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::rangeAndOffsetRelativeToSelection):
Streamlined and made this use characterCount instead of
TextIterator::getLocationAndLengthFromRange.
(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Tweaked
the argument type.
(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection):
Ditto. Also removed some unnecessary use of NSString.
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
Rewrote to no longer use live ranges.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getContentsAsAttributedString): Use construction and
rvalue references to tigten things up a bit.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentsAsString const): Use a SimpleRange instead of
a live range to pass to plainText.
- WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::getPlatformEditorState const): Pass references to
live ranges to plainText.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateSelectionWithDelta): Rewrote to minimize use of
live ranges.
(WebKit::WebPage::requestDocumentEditingContext): Ditto.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getPlatformEditorState const): Pass reference to
a live range to plainText.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::updateSpellingUIWithGrammarString): Remove some unnecessary
use of local variabels for NSString.
(WebEditorClient::requestCandidatesForSelection): Pass a reference to a live
range to plainText.
- WebView/WebFrame.mm:
(-[WebFrame _stringForRange:]): Ditto.
(-[WebFrame _convertToNSRange:]): Use characterRange instead of
TextIterator::getLocationAndLengthFromRange.
Source/WebKitLegacy/win:
- WebFrame.cpp:
(WebFrame::string): Use a SimpleRange instead of a live range
to call plainText.
- WebView.cpp:
(WebView::selectedRangeForTesting): Use a SimpleRange instead
of a live range to call characterRange instead of
TextIterator::getLocationAndLengthFromRange.
LayoutTests:
- editing/text-iterator/find-string-on-flat-tree-expected.txt:
- editing/text-iterator/find-string-on-flat-tree.html:
Updated test for a progress where we properly find strings across a shadow boundary.
- 11:44 AM Changeset in webkit [259400] by
-
- 2 edits in trunk/Source/WTF
Address static analysis warning in DataLog.cpp: Value stored to 'pathCharactersAvailable' is never read
https://bugs.webkit.org/show_bug.cgi?id=202153
<rdar://problem/55671845>
Reviewed by David Kilzer.
Bug 168914 introduced some code that will initialize a variable to
zero, but then never use that variable afterwards. Address this by
removing the assignment.
- wtf/DataLog.cpp:
(WTF::setDataFile):
- 11:37 AM Changeset in webkit [259399] by
-
- 20 edits in trunk
API::PageConfiguration may have conflicting preference values between WebPreferences and WebPreferencesStore::ValueMap instance variables
<https://webkit.org/b/209678>
<rdar://problem/60981271>
Reviewed by Brent Fulgham.
Source/WebKit:
We fix this bug by removing
API::PageConfiguration::m_preferenceValues and
WebPageProxy::m_configurationPreferenceValues, and instead set
values directly on the WebPreferences object, which holds values
in its WebPreferencesStore instance variable. This change only
requires that the API::PageConfiguration object has
m_preferences set to a valid WebPreferences object before using
the settings APIs.
Covered by WKAttachment TestWebKitAPI tests and
editing/undo-manager layout tests, among others.
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
- Remove use of m_preferenceValues instance variable.
- UIProcess/API/APIPageConfiguration.h:
- Update headers after removing WebPreferencesStore.h.
(API::PageConfiguration::preferenceValues): Delete.
- Remove use of m_preferenceValues instance variable.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
- Switch to use WebPreferences methods for settings.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- Create WebPreferences object for API::PageConfiguration object. This is what WebProcessPool::createWebPage() does when creating a WebPageProxy object.
- Switch to use WebPreferences method to set SystemLayoutDirection.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- Remove initialization of m_configurationPreferenceValues.
- Switch to use WebPreferences method to set DisableScreenSizeOverride.
(WebKit::WebPageProxy::preferencesStore const):
- Simplify this method after removing m_configurationPreferenceValues.
- UIProcess/WebPageProxy.h:
- Remove m_configurationPreferenceValues.
Tools:
- TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
(TestWebKitAPI::TEST):
- Fix WKView constructor to pass a valid WKPageGroupRef.
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
- Remove support for custom "enableUndoManagerAPI" setting since layout tests should use "internal:UndoManagerAPIEnabled" instead.
LayoutTests:
- editing/undo-manager/undo-manager-add-item-exceptions.html:
- editing/undo-manager/undo-manager-add-item.html:
- editing/undo-manager/undo-manager-delete-stale-undo-items.html:
- editing/undo-manager/undo-manager-interfaces.html:
- editing/undo-manager/undo-manager-item-labels.html:
- editing/undo-manager/undo-manager-keeps-wrapper-alive.html:
- editing/undo-manager/undo-manager-undo-redo-after-garbage-collection.html:
- Fix tests to use "internal:UndoManagerAPIEnabled=true" instead of custom "enableUndoManagerAPI=true" setting, which is being removed since it doesn't work after the changes to WebKit.
- 11:37 AM Changeset in webkit [259398] by
-
- 3 edits in trunk/Source/WebCore/PAL
Unreviewed build fix.
- pal/spi/cocoa/CoreServicesSPI.h:
- pal/spi/cocoa/LaunchServicesSPI.h:
- 11:27 AM Changeset in webkit [259397] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Build fix after r259385.
Reviewed by David Kilzer, Youenn Fablet.
Convert isStandardFrameSize() into a lambda function since it only has one call site.
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
(isStandardFrameSize): Deleted.
- 11:26 AM Changeset in webkit [259396] by
-
- 6 edits1 add in trunk/Source
[macOS] Remove redundant call to check in with Launch Services
https://bugs.webkit.org/show_bug.cgi?id=209911
Reviewed by Darin Adler.
Source/WebCore/PAL:
Move declarations to SPI header files.
- PAL.xcodeproj/project.pbxproj:
- pal/spi/cocoa/CoreServicesSPI.h: Added.
- pal/spi/cocoa/LaunchServicesSPI.h:
Source/WebKit:
There is no need to explicitly check in with Launch Services or call RegisterApplication in the WebContent process,
since this is handled when calling [NSApplication _accessibilityInitialize].
No new tests, since this only removes a redundant call, and should be covered by existing tests.
- Shared/mac/AuxiliaryProcessMac.mm:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::platformInitializeProcess):
- 11:12 AM Changeset in webkit [259395] by
-
- 3 edits in trunk/LayoutTests
[ Mac wk1 ] fast/loader/child-frame-add-after-back-forward.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209621
<rdar://problem/60937276>
Reviewed by Jonathan Bedard.
Update empty-document-goes-back.html to schedule the history.back() call *after* the load
event has been fired, so that a HistoryItem has actually been created.
- fast/loader/resources/empty-document-goes-back.html:
- platform/mac-wk1/TestExpectations:
- 11:07 AM Changeset in webkit [259394] by
-
- 2 edits in trunk/Source/WebCore
Remove a superflous blank line added in the previous commit as pointed out during the code review.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::copyAssociatedElementsVector const):
- 11:04 AM Changeset in webkit [259393] by
-
- 13 edits in trunk/Source
HTMLFormElement should use WeakPtr to keep track of its associated elements
https://bugs.webkit.org/show_bug.cgi?id=209894
Reviewed by Wenson Hsieh.
Source/WebCore:
Replaced the vector of raw pointers to FormAssociatedElement in HTMLFormElement by a vector
of WeakPtr to the equivalent HTMLElement. Most of code changes below are due to type of elements
in the vector changing from FormAssociatedElement to HTMLElement and needing conversion.
This patch also moves clearing of m_form from ~FormAssociatedElement to its subclasses'
destructors since we need to make a virtual function call to get HTMLElement* out of
FormAssociatedElement, which would be too late inside ~FormAssociatedElement.
No new tests since there should be no behavioral change.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::~FormAssociatedElement): Assert that m_form had been cleared
instead of clearing it here.
- html/FormAssociatedElement.h:
(WebCore::FormAssociatedElement::clearForm): Added.
- html/FormController.cpp:
(WebCore::recordFormStructure):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::~HTMLFormControlElement): Now calls clearForm. Also removed
the redundant comment.
- html/HTMLFormControlsCollection.cpp:
(WebCore::findFormAssociatedElement):
(WebCore::HTMLFormControlsCollection::unsafeFormControlElements const): Deleted.
(WebCore::HTMLFormControlsCollection::copyFormControlElementsVector const): Deleted.
(WebCore::HTMLFormControlsCollection::customElementAfter const):
(WebCore::HTMLFormControlsCollection::updateNamedElementCache const):
- html/HTMLFormControlsCollection.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::removedFromAncestor):
(WebCore::HTMLFormElement::length const):
(WebCore::HTMLFormElement::textFieldValues const):
(WebCore::HTMLFormElement::resetAssociatedFormControlElements):
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
(WebCore::HTMLFormElement::registerFormElement):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap const):
(WebCore::HTMLFormElement::unsafeAssociatedElements const):
(WebCore::HTMLFormElement::copyAssociatedElementsVector const):
- html/HTMLFormElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::~HTMLObjectElement): Added. Calls clearForm.
- html/HTMLObjectElement.h:
Source/WebKitLegacy/mac:
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]):
(-[WebHTMLRepresentation controlsInForm:]):
- 10:51 AM Changeset in webkit [259392] by
-
- 20 edits in trunk
Add SPI to restrict loading to main resources or non-network loads
https://bugs.webkit.org/show_bug.cgi?id=209893
Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-02
Reviewed by Tim Horton.
Source/WebCore:
This will allow two projects that currently use the injected bundle SPI to use these instead.
Covered by API tests.
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::validateURL):
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
- loader/ResourceLoadNotifier.h:
- page/Page.cpp:
(WebCore::m_loadsFromNetwork):
(WebCore::m_deviceOrientationUpdateProvider): Deleted.
- page/Page.h:
(WebCore::Page::loadsSubresources const):
(WebCore::Page::loadsFromNetwork const):
- page/PageConfiguration.h:
Source/WebKit:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::loadsSubresources const):
(API::PageConfiguration::setLoadsSubresources):
(API::PageConfiguration::loadsFromNetwork const):
(API::PageConfiguration::setLoadsFromNetwork):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setLoadsFromNetwork:]):
(-[WKWebViewConfiguration _loadsFromNetwork]):
(-[WKWebViewConfiguration _setLoadsSubresources:]):
(-[WKWebViewConfiguration _loadsSubresources]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/WebPageProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_processDisplayName):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
- TestWebKitAPI/cocoa/HTTPServer.h:
(TestWebKitAPI::HTTPServer::totalRequests const):
- TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::respondToRequests):
- 10:36 AM Changeset in webkit [259391] by
-
- 4 edits in trunk/LayoutTests
[ Mac wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209878
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 9:39 AM Changeset in webkit [259390] by
-
- 7 edits2 adds in trunk/Source
Enable offlineasm debug annotations for GCC
https://bugs.webkit.org/show_bug.cgi?id=207119
Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-04-02
Reviewed by Darin Adler.
This simply reuses the existing code that generates debug
annotations, adding two workarounds for limitations in GCC and
GDB.
First, the .file directives that offlineasm inserts in inline asm
use file slots that conflict with those in the compilation unit
that includes LLIntAssembly.h (specifically,
LowLevelInterpreter.cpp). Clang's built-in assembler will
transparently fix that for us, but for GCC we need to
post-process the generated assembler.
Unfortunately, cmake doesn't allow us to introduce a compiler wrapper for a
single source file, so we need to create a separate target for it. This
wrapping only happens when building with GCC and the user has explicitly
requested debug information, either by selecting a Debug/RelWithDebInfo build
or setting GCC_OFFLINEASM_SOURCE_MAP.
Second, GDB will only look at the line table for a compilation unit if
it can first resolve the address to one of the known symbols in the
file. Introduce marker symbols to work around this bug.
- CMakeLists.txt:
- 9:12 AM Changeset in webkit [259389] by
-
- 3 edits in trunk/LayoutTests
[ Mac and iOS ] svg/custom/animate-initial-pause-unpause.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209908
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 8:59 AM Changeset in webkit [259388] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Allow WebKit to use camera in multi-tasking mode
https://bugs.webkit.org/show_bug.cgi?id=209904
Reviewed by Youenn Fablet.
Source/WebCore:
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setupSession):
Source/WebCore/PAL:
- pal/cocoa/AVFoundationSoftLink.h:
- pal/cocoa/AVFoundationSoftLink.mm:
- 8:58 AM Changeset in webkit [259387] by
-
- 4 edits in trunk/Source/WebCore
Video previews on shutterstock.com don't play when tapped on iPadOS
https://bugs.webkit.org/show_bug.cgi?id=209903
<rdar://problem/58844166>
Reviewed by Wenson Hsieh.
When tapping on a video preview after searching for a video on shutterstock.com, for instance on https://www.shutterstock.com/video/search/people,
we correctly enter the hover state thanks to our content observation heuristics, but the <video> preview inserted fails to play and show due to a
style rule setting a "display: none" style if the media-query "pointer: coarse" evaluates to true.
In order to improve this website's behavior on iPadOS, we add a new quirk that prevents the "pointer: coarse" media query from evaluating to true.
This new quirk, shouldPreventPointerMediaQueryFromEvaluatingToCoarse(), evaluates to true only for this this website.
- css/MediaQueryEvaluator.cpp:
(WebCore::pointerEvaluate):
- page/Quirks.cpp:
(WebCore::Quirks::shouldPreventPointerMediaQueryFromEvaluatingToCoarse const):
- page/Quirks.h:
- 8:44 AM Changeset in webkit [259386] by
-
- 2 edits in trunk/Tools
Add additional WKAppBoundDomains to TestWebKitAPI's expectations after initializing eTLD+1 by default
https://bugs.webkit.org/show_bug.cgi?id=209889
<rdar://problem/61184539>
Reviewed by Brent Fulgham.
Additional domains will now be included in TestWebKitAPI's
WKAppBoundDomains list after
https://bugs.webkit.org/show_bug.cgi?id=209839 (Allow WKAppBoundDomains
to be initialized with eTLD+1 only (no protocol)).
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(TEST):
- 7:03 AM Changeset in webkit [259385] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Temporarily restrict kVTVideoEncoderSpecification_RequiredLowLatency use to iOS
https://bugs.webkit.org/show_bug.cgi?id=209902
Reviewed by Eric Carlson.
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
Our setup with this key does not work yet on MacOS, disable it for now on MacOS.
- 5:34 AM WebKitGTK/2.28.x edited by
- (diff)
- 5:07 AM Changeset in webkit [259384] by
-
- 3 edits3 adds in trunk
Debug crash: ASSERTION FAILED: m_ongoingFetches.contains(task.fetchIdentifier())
https://bugs.webkit.org/show_bug.cgi?id=209743
Reviewed by Darin Adler.
Source/WebKit:
When context gets closed, we make ServiceWorkerFetchTask::m_serviceWorkerConnection null as it no longer
needs to send messages and does not need to unregister itself.
Test: http/wpt/service-workers/service-worker-crashing-while-fetching.https.html
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::contextClosed):
LayoutTests:
- http/wpt/service-workers/service-worker-crashing-while-fetching.https-expected.txt: Added.
- http/wpt/service-workers/service-worker-crashing-while-fetching.https.html: Added.
- http/wpt/service-workers/service-worker-lengthy-worker.js: Added.
(fetchTest):
- 4:00 AM Changeset in webkit [259383] by
-
- 30 edits in trunk
Remove synchronous termination of service workers
https://bugs.webkit.org/show_bug.cgi?id=209666
Reviewed by Chris Dumez.
Source/WebCore:
Instead of supporting synchronous IPC to terminate a service worker, SWServerWorker will asynchronously ask for the service worker to terminate.
If it is not terminated after some time, SWServerWorker will then ask to terminate the process running the service worker.
Time is kept to 10 seconds.
We can then remove all synchronous related code related to termination.
We migrate the terminateServiceWorker internal API to be Promise based.
Covered by existing tests.
- testing/Internals.cpp:
(WebCore::Internals::terminateServiceWorker):
- testing/Internals.h:
- testing/Internals.idl:
- workers/service/ServiceWorkerProvider.h:
- workers/service/SWClientConnection.h:
- workers/service/WorkerSWClientConnection.cpp:
- workers/service/WorkerSWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::unregisterServiceWorkerClient):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp:
(WebCore::m_terminationTimer):
(WebCore::SWServerWorker::~SWServerWorker):
(WebCore::SWServerWorker::terminate):
(WebCore::SWServerWorker::startTermination):
(WebCore::SWServerWorker::terminateCompleted):
(WebCore::SWServerWorker::callTerminationCallbacks):
(WebCore::SWServerWorker::terminationTimerFired):
(WebCore::SWServerWorker::setState):
(WebCore::SWServerWorker::didFailHeartBeatCheck):
- workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::terminate):
Source/WebKit:
Update IPC code according removal of synchronous termination of service worker.
Implement async-with-reply termination instead.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::terminateWorkerFromClient):
(WebKit::WebSWServerConnection::fetchTaskTimedOut):
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::terminateDueToUnresponsiveness):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
- WebProcess/Storage/WebServiceWorkerProvider.h:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::terminateWorkerForTesting):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
LayoutTests:
- http/tests/workers/service/resources/postmessage-after-sw-process-crash.js:
(async event):
- http/tests/workers/service/resources/postmessage-after-terminate.js:
(async event):
- http/tests/workers/service/resources/postmessage-after-terminating-hung-worker.js:
(async event):
- 3:26 AM Changeset in webkit [259382] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Public API should not allow trying to register a special URI scheme
https://bugs.webkit.org/show_bug.cgi?id=209900
Reviewed by Carlos Garcia Campos.
No new tests needed.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_register_uri_scheme): Use g_return_if_fail() to
check at the public API level whether the passed URI scheme is
special and bail out early.
- 3:09 AM Changeset in webkit [259381] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Unreviewed, fix libwebrtc build with GCC 9 after the M82 bump.
GCC 9 fails to process the FrameGeneratorCapturerConfig::ImageSlides::Crop
class, throwing an error due to the default member initializer for the
scroll_durationmember being required before the end of the
encapsulating FrameGeneratorCapturerConfig::ImageSlides class.
This can be avoided by default-initializing the
FrameGeneratorCapturerConfig::ImageSlides::Crop member variable instead
of specific members of that class.
Similar fix will be pushed to the upstream repository.
- Source/webrtc/test/frame_generator_capturer.h:
- 2:12 AM WebKitGTK/2.28.x edited by
- (diff)
- 1:45 AM Changeset in webkit [259380] by
-
- 2 edits in trunk/Source/WebKit
[GTK] [2.28.0] The Yelp build crashes if DISPLAY is not set
https://bugs.webkit.org/show_bug.cgi?id=209431
Reviewed by Carlos Alberto Lopez Perez.
Remove the assert when display is not X11 nor Wayland, and simply return false to ensure acceleration is not used.
- UIProcess/gtk/AcceleratedBackingStore.cpp:
(WebKit::AcceleratedBackingStore::checkRequirements):
- 12:43 AM Changeset in webkit [259379] by
-
- 4 edits in trunk/Source/WebCore
Remove FrameLoader::addExtraFieldsToMainResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=209853
Patch by Rob Buis <rbuis@igalia.com> on 2020-04-02
Reviewed by Darin Adler.
Remove FrameLoader::addExtraFieldsToMainResourceRequest since the call is
not needed in DocumentLoader and can be inlined in FrameLoader. The call
in DocumentLoader is no longer needed since adding the User-Agent header
is decoupled from addExtraFields functionality and the User-Agent header
will be added in CachedResourceLoader after any custom setting of the
user agent (setCustomUserAgent API).
Test: http/tests/navigation/useragent-reload.php
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest): Deleted.
- loader/FrameLoader.h:
Apr 1, 2020:
- 10:22 PM Changeset in webkit [259378] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::HTMLDocumentParser::insert
https://bugs.webkit.org/show_bug.cgi?id=209892
Reviewed by Darin Adler.
Speculative fix to check that the parser hasn't been detached before running preload scanner.
No new tests since there is no reproduction and I couldn't come up with one.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
- 8:55 PM Changeset in webkit [259377] by
-
- 2 edits in trunk/LayoutTests
[iOS] svg/as-background-image/tiled-background-image.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=209885
Unreviewed test gardening.
- platform/ios/TestExpectations: Mark test as flaky.
- 7:31 PM Changeset in webkit [259376] by
-
- 2 edits in trunk/Source/WebCore
Remove the unnecessary null check for document
https://bugs.webkit.org/show_bug.cgi?id=209819
Reviewed by Ryosuke Niwa.
No new tests, covered by existing test.
- dom/Node.cpp:
(WebCore::Node::removedFromAncestor):
- 5:35 PM Changeset in webkit [259375] by
-
- 3 edits in trunk/Source/WebCore
Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=209883
Reviewed by Darin Adler.
Refactor what is currently a compile-time IOS_FAMILY guard into a runtime check behind a private helper method
on TextFieldInputType. This makes the intention behind the iOS-specific logic more self-evident; no change in
behavior.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleFocusEvent):
(WebCore::TextFieldInputType::handleBlurEvent):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::TextFieldInputType::shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited const):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
(WebCore::TextFieldInputType::listAttributeTargetChanged):
- html/TextFieldInputType.h:
- 5:19 PM Changeset in webkit [259374] by
-
- 14 edits1 delete in trunk
[Cocoa] UTI from MIME type cache can be removed after r258915
https://bugs.webkit.org/show_bug.cgi?id=209787
Unreviewed rollout of r257828.
Source/WebCore:
In r257828, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the
WebContent process, but after <https://trac.webkit.org/changeset/258915> this cache is not strictly needed
anymore, since r258915 solves the problem of avoiding to connect to the daemon in a general way.
- platform/network/mac/UTIUtilities.h:
- platform/network/mac/UTIUtilities.mm:
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::mapUTIFromMIMEType): Deleted.
(WebCore::additionalMIMETypes): Deleted.
(WebCore::createUTIFromMIMETypeMap): Deleted.
(WebCore::setUTIFromMIMETypeMap): Deleted.
- testing/Internals.cpp:
(WebCore::Internals::getUTIFromMIMEType): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
- testing/Internals.mm:
(WebCore::Internals::getUTIFromMIMEType): Deleted.
Source/WebKit:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Removed.
- 5:16 PM Changeset in webkit [259373] by
-
- 2 edits in trunk/Source/WebCore/PAL
Fix the build.
- pal/spi/ios/ManagedConfigurationSPI.h:
- 5:13 PM Changeset in webkit [259372] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests: runJSCStressTests shouldn't exit the program
https://bugs.webkit.org/show_bug.cgi?id=209887
Reviewed by Darin Adler.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): Exit the function, not the program.
- 4:47 PM Changeset in webkit [259371] by
-
- 2 edits in trunk/Websites/webkit.org
Removed the update nag from the old WebKit Nightly start page
https://bugs.webkit.org/show_bug.cgi?id=179214
Reviewed by Darin Adler.
- wp-content/themes/webkit/nightly-start.php:
- 4:15 PM Changeset in webkit [259370] by
-
- 8 edits in trunk
Intl.NumberFormat.prototype.format must preserve sign of -0
https://bugs.webkit.org/show_bug.cgi?id=209880
Reviewed by Keith Miller.
JSTests:
- test262/config.yaml:
This test was skipped as ICU version-dependent, but it shouldn't be.
- test262/expectations.yaml:
Mark four test cases as passing.
Source/JavaScriptCore:
The spec changed here two years ago:
https://github.com/tc39/ecma402/pull/232
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::formatNumber):
Do NOT throw away the sign of -0.
LayoutTests:
- js/intl-numberformat-expected.txt:
- js/script-tests/intl-numberformat.js:
Fix test accordingly.
- 4:03 PM Changeset in webkit [259369] by
-
- 2 edits in trunk/Source/WebCore/PAL
Use ManagedConfiguration umbrella instead of including specific headers
https://bugs.webkit.org/show_bug.cgi?id=209884
<rdar://problem/59244126>
Reviewed by Wenson Hsieh.
- pal/spi/ios/ManagedConfigurationSPI.h:
- 3:50 PM Changeset in webkit [259368] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: Use ECMAScript Numeric Separators for numbers with 5 or more digits
https://bugs.webkit.org/show_bug.cgi?id=209879
Reviewed by Joseph Pecoraro.
Instead of
1000000write1_000_000so it's easier to read.
- UserInterface/Base/Utilities.js:
- UserInterface/Controllers/JavaScriptLogViewController.js:
- UserInterface/Controllers/TimelineManager.js:
- UserInterface/Models/Gradient.js:
(WI.Gradient.prototype.stringFromStops):
- UserInterface/Models/HeapAllocationsInstrument.js:
(WI.HeapAllocationsInstrument.prototype.startInstrumentation):
- UserInterface/Protocol/Connection.js:
(InspectorBackend.Connection.prototype._dispatchResponse):
- UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype.initialLayout):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._updateLoadTimeStatistic):
- 3:32 PM Changeset in webkit [259367] by
-
- 3 edits in trunk/Source/WebCore
http/tests/navigation/page-cache-fontfaceset.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=209881
<rdar://problem/61114827>
Reviewed by Darin Adler.
Make sure CSSFontSelector::m_beginLoadingTimer uses a SuspendableTimer instead of a regular
timer so that it cannot fire while in the back/forward cache and start a load.
No new tests, covered by existing test.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::clearDocument):
- css/CSSFontSelector.h:
- 3:29 PM Changeset in webkit [259366] by
-
- 8 edits in trunk
[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
https://bugs.webkit.org/show_bug.cgi?id=209814
Reviewed by Darin Adler.
Source/WebKit:
This was done for iOS in <https://trac.webkit.org/changeset/258915>, and in order to be able to do this
on macOS, checking in with Launch Services and updating the process name needs to be done after the
Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
previous call to RegisterApplication has been replaced with a call to launchServicesCheckIn, since
RegisterApplication is an AppKit function, and should be avoided since the WebContent process is not
a NSApplication anymore.
Test: fast/sandbox/mac/sandbox-mach-lookup.html
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::launchServicesCheckIn):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::platformInitializeProcess):
- WebProcess/com.apple.WebProcess.sb.in:
LayoutTests:
- fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
- fast/sandbox/mac/sandbox-mach-lookup.html:
- 2:52 PM Changeset in webkit [259365] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209882
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:51 PM Changeset in webkit [259364] by
-
- 5 edits in trunk/Source/WebCore
ASSERTION FAILED: m_wrapper on webgl/max-active-contexts-webglcontextlost-prevent-default.html
https://bugs.webkit.org/show_bug.cgi?id=209863
<rdar://problem/61164936>
Reviewed by Darin Adler.
The HTMLCanvasElement JS wrapper needs to stay alive as long as JS events may need to be fired.
When the canvas has a WebGL context, the WebGL context may cause contextlost / contextrestored
/ contextchanged events at any point, unless the context is unrecoverably lost. To fix the
issue, we now override virtualHasPendingActivity() in HTMLCanvasElement and return true if
it has a WebGL context that is not unrecoverably lost and if relevant WebGL event listeners
are registed.
No new tests, covered by existing test.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::virtualHasPendingActivity const):
(WebCore::HTMLCanvasElement::stop):
(WebCore::HTMLCanvasElement::eventListenersDidChange):
- html/HTMLCanvasElement.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::isContextUnrecoverablyLost const):
- html/canvas/WebGLRenderingContextBase.h:
- 2:15 PM Changeset in webkit [259363] by
-
- 8 edits in trunk/Source/WebCore
CRASH in MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer(), uncaught ObjC exception
https://bugs.webkit.org/show_bug.cgi?id=209827
<rdar://problem/61113080>
Reviewed by Eric Carlson.
-[AVSampleBufferAudioRenderer init] can, in exceptional conditions, return nil. Passing a
nil object, or another object that AVSampleBufferRenderSynchronizer considers "invalid", into
-[AVSampleBufferRenderSynchronizer addRenderer:] will throw an exception. Protect against this
scenario in two ways:
- Check the return value of -[AVSampleBufferAudioRenderer init], and if nil, log an error, log to console, and set the network state to "DecodeError".
- Wrap calls to -addRenderer: in @try/@catch blocks, which if caught, log an error, assert, and set the network state to "DecodeError".
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::failedToCreateRenderer):
- Modules/mediasource/MediaSource.h:
- platform/graphics/MediaSourcePrivateClient.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::failedToCreateAudioRenderer):
(WebCore::MediaSourcePrivateAVFObjC::failedToCreateVideoRenderer):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
- 2:01 PM Changeset in webkit [259362] by
-
- 4 edits in trunk
Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
https://bugs.webkit.org/show_bug.cgi?id=209873
<rdar://problem/61132068>
Reviewed by Alex Christensen.
Source/WebKit:
ProvisionalPageProxy::cancel() was calling didFailProvisionalLoadForFrame() was not passing a valid
FrameInfoData struct as parameter. As a result, FrameInfoData::isMainFrame ended up being false
instead of true. This was an issue because NavigationState::NavigationClient::didFailProvisionalNavigationWithError()
was relying on this flag to decide whether to call webViewDidFailProvisionalNavigationWithError or
webViewNavigationDidFailProvisionalLoadInSubframeWithError, since r257963.
Change is covered by new API tests.
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::cancel):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 1:59 PM Changeset in webkit [259361] by
-
- 3 edits in trunk/LayoutTests
[ Mac wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209878
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 1:40 PM Changeset in webkit [259360] by
-
- 4 edits9 adds in trunk
[GPUP][PlayStation] Enable GPU Process
https://bugs.webkit.org/show_bug.cgi?id=209865
Reviewed by Eric Carlson.
.:
Enable GPU Process for development builds as an experimental feature.
- Source/cmake/OptionsPlayStation.cmake:
Source/WebKit:
A generic LayerHostingContext is provided in this patch. It may make sense for
this to be platform specific but it may also be possible to have some shared
implementation with Cocoa ports. Once there are more implementations that
can be decided.
Add stubs for building out the GPU Process on the PlayStation port. No
implementation is provided at this time but the GPU Process will compile
and link with these changes.
- GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp: Added.
(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
(WebKit::RemoteMediaPlayerProxy::enterFullscreen):
(WebKit::RemoteMediaPlayerProxy::exitFullscreen):
- GPUProcess/playstation/GPUProcessMainPlayStation.cpp: Added.
(WebKit::initializeAuxiliaryProcess<GPUProcess>):
(WebKit::GPUProcessMain):
- GPUProcess/playstation/GPUProcessPlayStation.cpp: Added.
(WebKit::GPUProcess::initializeProcess):
(WebKit::GPUProcess::initializeProcessName):
(WebKit::GPUProcess::initializeSandbox):
- Platform/generic/LayerHostingContext.h: Added.
- PlatformPlayStation.cmake:
- WebProcess/GPU/media/playstation/VideoLayerRemotePlayStation.cpp: Added.
(WebKit::createVideoLayerRemote):
- 12:30 PM Changeset in webkit [259359] by
-
- 4 edits in trunk
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
https://bugs.webkit.org/show_bug.cgi?id=209684
<rdar://problem/60987285>
Reviewed by Darin Adler.
Source/WebCore:
Make sure the JS wrapper does not get collected while the HTMLMediaElement is in a state where
is may still fire events (and there are JS event listeners registered). In particular, it used
to be possible for the wrapper to get collected because media playback had started and we would
crash trying to fire the very early 'canplay' JS event.
No new tests, covered by existing test.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
LayoutTests:
Unmark the test as crashing.
- platform/mac/TestExpectations:
- 12:15 PM Changeset in webkit [259358] by
-
- 10 edits1 copy in trunk
[PlayStation] Use OBJECT libraries for WebCore and PAL
https://bugs.webkit.org/show_bug.cgi?id=209835
Reviewed by Ross Kirsling.
.:
When compiling WebCore in debug mode ranlib was having issues with the size of
libWebCore.a. This is similar to what happened with Visual Studio and WinCairo.
Additionally hidden visibility defaults are added for the port.
- Source/cmake/OptionsPlayStation.cmake:
Source/WebCore:
After moving to object libraries MediaStrategy's constructor and destructor were
being reported as linker errors despite being set to default. Moving the definitions
to a source file stopped these issues.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/MediaStrategy.cpp: Copied from Source/WebCore/platform/MediaStrategy.h.
- platform/MediaStrategy.h:
Source/WebKit:
Use the object libraries when building WebKit.
- PlatformPlayStation.cmake:
Tools:
Use the object libraries when compiling TestWebCore.
- TestWebKitAPI/PlatformPlayStation.cmake:
- 12:10 PM Changeset in webkit [259357] by
-
- 4 edits1 add in trunk
Delete IC incorrectly caches for proxies
https://bugs.webkit.org/show_bug.cgi?id=209777
Patch by Justin Michaud <justin@justinmichaud.com> on 2020-04-01
Reviewed by Mark Lam.
JSTests:
- stress/delete-property-ic-proxy.js: Added.
(obj1.this.foo1):
(foo1.foo2):
(foo1):
(foo2.foo3):
(foo2):
- stress/delete-property-inline-cache.js:
Source/JavaScriptCore:
Proxy's do not change their structure ID when properties are added, so we cannot cache deletes
for them.
- jit/Repatch.cpp:
(JSC::tryCacheDeleteBy):
- 11:47 AM Changeset in webkit [259356] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] crypto/subtle/rsa-indexeddb-non-exportable-private.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209869
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 11:42 AM Changeset in webkit [259355] by
-
- 70 edits in trunk/Source
Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors
https://bugs.webkit.org/show_bug.cgi?id=209762
Reviewed by Darin Adler.
Source/JavaScriptCore:
Change indexingType to indexingModeIncludingHistory to more
clearly indicate the expected range of possible valid values.
- runtime/StructureInlines.h:
(JSC::Structure::create):
Source/WebCore:
There may be places where we rely on this for semantic
correctness. I couldn't find any right now but we might as
well be conservative since this isn't a performance regression.
- bindings/js/JSDOMWindowProperties.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSInterfaceName.h:
(WebCore::JSInterfaceName::createStructure):
- bindings/scripts/test/JS/JSMapLike.h:
(WebCore::JSMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlyMapLike.h:
(WebCore::JSReadOnlyMapLike::createStructure):
- bindings/scripts/test/JS/JSReadOnlySetLike.h:
(WebCore::JSReadOnlySetLike::createStructure):
- bindings/scripts/test/JS/JSSetLike.h:
(WebCore::JSSetLike::createStructure):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::createStructure):
- bindings/scripts/test/JS/JSTestCEReactions.h:
(WebCore::JSTestCEReactions::createStructure):
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.h:
(WebCore::JSTestCEReactionsStringifier::createStructure):
- bindings/scripts/test/JS/JSTestCallTracer.h:
(WebCore::JSTestCallTracer::createStructure):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:
(WebCore::JSTestClassWithJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestDOMJIT.h:
(WebCore::JSTestDOMJIT::createStructure):
- bindings/scripts/test/JS/JSTestEnabledBySetting.h:
(WebCore::JSTestEnabledBySetting::createStructure):
- bindings/scripts/test/JS/JSTestEnabledForContext.h:
(WebCore::JSTestEnabledForContext::createStructure):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::createStructure):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::createStructure):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::createStructure):
- bindings/scripts/test/JS/JSTestGlobalObject.h:
(WebCore::JSTestGlobalObject::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:
(WebCore::JSTestIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:
(WebCore::JSTestIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:
(WebCore::JSTestIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h:
(WebCore::JSTestInterfaceLeadingUnderscore::createStructure):
- bindings/scripts/test/JS/JSTestIterable.h:
(WebCore::JSTestIterable::createStructure):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
(WebCore::JSTestNamedAndIndexedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
(WebCore::JSTestNamedDeleterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
(WebCore::JSTestNamedDeleterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
(WebCore::JSTestNamedDeleterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
(WebCore::JSTestNamedDeleterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:
(WebCore::JSTestNamedGetterCallWith::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:
(WebCore::JSTestNamedGetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:
(WebCore::JSTestNamedGetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
(WebCore::JSTestNamedSetterNoIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
(WebCore::JSTestNamedSetterThrowingException::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
(WebCore::JSTestNamedSetterWithIdentifier::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
(WebCore::JSTestNamedSetterWithIndexedGetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
(WebCore::JSTestNamedSetterWithOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
(WebCore::JSTestNamedSetterWithUnforgableProperties::createStructure):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h:
(WebCore::JSTestOverloadedConstructorsWithSequence::createStructure):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::createStructure):
- bindings/scripts/test/JS/JSTestPluginInterface.h:
(WebCore::JSTestPluginInterface::createStructure):
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h:
(WebCore::JSTestPromiseRejectionEvent::createStructure):
- bindings/scripts/test/JS/JSTestSerialization.h:
(WebCore::JSTestSerialization::createStructure):
- bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h:
(WebCore::JSTestSerializationIndirectInheritance::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInherit.h:
(WebCore::JSTestSerializationInherit::createStructure):
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.h:
(WebCore::JSTestSerializationInheritFinal::createStructure):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::createStructure):
- bindings/scripts/test/JS/JSTestStringifier.h:
(WebCore::JSTestStringifier::createStructure):
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h:
(WebCore::JSTestStringifierAnonymousOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.h:
(WebCore::JSTestStringifierNamedOperation::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h:
(WebCore::JSTestStringifierOperationImplementedAs::createStructure):
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h:
(WebCore::JSTestStringifierOperationNamedToString::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h:
(WebCore::JSTestStringifierReadOnlyAttribute::createStructure):
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h:
(WebCore::JSTestStringifierReadWriteAttribute::createStructure):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::createStructure):
- 11:22 AM Changeset in webkit [259354] by
-
- 2 edits in trunk/LayoutTests
[ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209866
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:02 AM Changeset in webkit [259353] by
-
- 3 edits in trunk/Source/WebCore
Don't use raw pointers in ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=209843
<rdar://problem/61069603>
Reviewed by Brent Fulgham.
- dom/Element.cpp:
(WebCore::Element::addShadowRoot):
- dom/ShadowRoot.h:
- 9:48 AM Changeset in webkit [259352] by
-
- 8 edits in trunk
Unreviewed, reverting r259328.
https://bugs.webkit.org/show_bug.cgi?id=209861
Introduced API test failures (Requested by perarne on
#webkit).
Reverted changeset:
"[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in
sandbox"
https://bugs.webkit.org/show_bug.cgi?id=209814
https://trac.webkit.org/changeset/259328
- 9:33 AM Changeset in webkit [259351] by
-
- 2 edits in trunk/Source/WebKit
Convert app-bound domain categorization parameter to a method
https://bugs.webkit.org/show_bug.cgi?id=209842
<rdar://problem/61128744>
Reviewed by John Wilander.
SSIA.
Covered by existing TestWebKitAPI tests.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 9:21 AM Changeset in webkit [259350] by
-
- 2 edits in trunk/Source/WebKit
Deprecate WKWebsiteDataStore._indexedDBDatabaseDirectory
https://bugs.webkit.org/show_bug.cgi?id=209243
Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-01
Reviewed by David Kilzer.
Luckily it's read-only, but we have a way to get the configuration, so let's encourage that instead.
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- 9:18 AM Changeset in webkit [259349] by
-
- 2 edits in trunk/Tools
Unreviewed, add new committer to contributors.json
- Scripts/webkitpy/common/config/contributors.json:
- 9:13 AM Changeset in webkit [259348] by
-
- 2 edits in trunk/Source/WebCore
Notify accessibility when a node is removed from its ancestor.
https://bugs.webkit.org/show_bug.cgi?id=209819
Reviewed by Chris Fleizach.
Covered by existing tests in LayoutTests/accessibility.
- dom/Node.cpp:
(WebCore::Node::removedFromAncestor):
- 9:04 AM Changeset in webkit [259347] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, reverting r259282.
https://bugs.webkit.org/show_bug.cgi?id=209860
Caused memory corruption (Requested by ap on #webkit).
Reverted changeset:
"Scroll latching state is not a stack"
https://bugs.webkit.org/show_bug.cgi?id=209790
https://trac.webkit.org/changeset/259282
- 9:01 AM Changeset in webkit [259346] by
-
- 2 edits in trunk/Source/WebKit
Make WebPasteboardProxy::didModifyContentsOfPasteboard robust when pasteboardName is null
https://bugs.webkit.org/show_bug.cgi?id=209848
<rdar://problem/61121810>
Reviewed by Megan Gardner and David Kilzer.
Add more IPC message checks in WebPasteboardProxy; see below for more detail.
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
Rename what is currently MESSAGE_CHECK to MESSAGE_CHECK_COMPLETION, and introduce two more message check macros:
MESSAGE_CHECK_WITH_RETURN_VALUE, which supports a return value, and MESSAGE_CHECK, which returns with no value.
(WebKit::WebPasteboardProxy::canAccessPasteboardData const):
Replace the early returns when pasteboardName is empty or when the web process for the given connection is null
withMESSAGE_CHECKs. When the web content process is well-behaved, these early returns should never be hit.
(WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard):
Similarly, replace this early return with a message check, and additionally
MESSAGE_CHECKwhen the pasteboard
name is empty. This addresses the main issue caught by this radar.
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
- 8:31 AM Changeset in webkit [259345] by
-
- 2024 edits453 adds1091 deletes in trunk
Bump libwebrtc to M82
https://bugs.webkit.org/show_bug.cgi?id=209542
Source/ThirdParty/libwebrtc:
Patch by youenn fablet <youenn@apple.com> and Victor M. Jaquez <vjaquez@igalia.com> on 2020-04-01
Reviewed by Eric Carlson.
- CMakeLists.txt:
- Source/webrtc: Updated.
- Source/webrtc/audio/utility/channel_mixer.cc: Added cstring.h include.
- Source/webrtc/modules/audio_processing/aec3/reverb_model_estimator.h: Added memoty.h include.
- libwebrtc.xcodeproj/project.pbxproj:
Source/WebCore:
Patch by youenn fablet <youenn@apple.com> on 2020-04-01
Reviewed by Eric Carlson.
Removed dtx/rtx support since this is no longer MTI and associatedStatId as obsolete.
Update mock connection according new virtual pure methods.
Covered by existing tests.
- Modules/mediastream/RTCStatsReport.h:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::fillRTCRTPStreamStats):
- Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::toRTCEncodingParameters):
(WebCore::toRTCHeaderExtensionParameters):
(WebCore::fromRTCHeaderExtensionParameters):
(WebCore::toRTCRtpSendParameters):
(WebCore::toRTCRtpTransceiverDirection):
- testing/MockLibWebRTCPeerConnection.h:
Source/WebKit:
Patch by Victor M. Jaquez <vjaquez@igalia.com> on 2020-04-01
Reviewed by Eric Carlson and Youenn Fablet.
Update include paths to latest libwebrtc paths.
- WebProcess/Network/webrtc/LibWebRTCResolver.h:
- WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
LayoutTests:
Patch by youenn fablet <youenn@apple.com> on 2020-04-01
Reviewed by Eric Carlson.
This test is no longer feasible since TCP private IP address candidates are now no longer allowed.
- webrtc/datachannel/basic-tcp-expected.txt: Removed.
- webrtc/datachannel/basic-tcp.html: Removed.
- 8:28 AM Changeset in webkit [259344] by
-
- 2 edits in trunk/Source/bmalloc
Update check for aarch64
https://bugs.webkit.org/show_bug.cgi?id=209322
<rdar://problem/61135818>
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-04-01
Reviewed by Mark Lam.
Update BPlatform.h to follow the corresponding change in WTF's PlatformCPU.h.
- bmalloc/BPlatform.h:
- 7:44 AM Changeset in webkit [259343] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, failures in EWS GTK-WK2
https://bugs.webkit.org/show_bug.cgi?id=209855
Unreviewed gardening.
Garden failures happening in EWS GTK-WK2 but not in GTK test bot.
- platform/gtk/TestExpectations:
- 6:31 AM Changeset in webkit [259342] by
-
- 25 edits in trunk/JSTests
[JSC] Reenable non-cloop LLint, JIT and DFG on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=191163
Patch by Paulo Matos <Paulo Matos> on 2020-04-01
Reviewed by Adrian Perez de Castro.
Re-enable tests for 32bits.
- stress/op_add.js:
- stress/op_bitand.js:
- stress/op_bitor.js:
- stress/op_bitxor.js:
- stress/op_lshift-ConstVar.js:
- stress/op_lshift-VarConst.js:
- stress/op_lshift-VarVar.js:
- stress/op_mod-ConstVar.js:
- stress/op_mod-VarConst.js:
- stress/op_mod-VarVar.js:
- stress/op_mul-ConstVar.js:
- stress/op_mul-VarConst.js:
- stress/op_mul-VarVar.js:
- stress/op_rshift-ConstVar.js:
- stress/op_rshift-VarConst.js:
- stress/op_rshift-VarVar.js:
- stress/op_sub-ConstVar.js:
- stress/op_sub-VarConst.js:
- stress/op_sub-VarVar.js:
- stress/op_urshift-ConstVar.js:
- stress/op_urshift-VarConst.js:
- stress/op_urshift-VarVar.js:
- stress/spread-forward-call-varargs-stack-overflow.js:
- stress/value-to-boolean.js:
- 6:27 AM Changeset in webkit [259341] by
-
- 4 edits in trunk
[Flatpak SDK] Migration to version 0.2
https://bugs.webkit.org/show_bug.cgi?id=209850
Reviewed by Carlos Alberto Lopez Perez.
Tools:
Version 0.2 of the SDK is now built with Buildstream instead of
flatpak-builder. With this new version it will be easier to add
new dependencies and hack on dependencies shipped by the SDK.
Sadly I haven't found a nice way to upgrade smoothly without
removing the UserFlatpak directory. In theory this shouldn't be
needed but then old SDK branches would accumulate there, wasting
disk-space.
- flatpak/flatpakutils.py:
(Console):
(Console.colored_message):
(Console.error_message):
(Console.warning_message):
(check_flatpak):
(FlatpakObject.flatpak):
(FlatpakRepo.init):
(FlatpakRepo):
(FlatpakRepo.is_app_installed):
(FlatpakPackage.init):
(FlatpakPackage.install):
(FlatpakPackage.update):
(WebkitFlatpak.init):
(WebkitFlatpak.clean_args):
(WebkitFlatpak._reset_repository):
(WebkitFlatpak.setup_gstbuild):
(WebkitFlatpak.main):
(WebkitFlatpak.run):
(WebkitFlatpak.setup_dev_env):
(WebkitFlatpak._get_packages):
LayoutTests:
- http/conf/flatpak-httpd.conf: Switch back to /usr/lib/apache2
path for modules. The 0.1 version of the SDK installed those in
/usr/ but in retrospective, this was a mistake.
- 6:16 AM Changeset in webkit [259340] by
-
- 5 edits in trunk/LayoutTests
[GTK] Gardening, update baselines
https://bugs.webkit.org/show_bug.cgi?id=209852
Unreviewed gardening.
Update GTK baselines after r259296.
- platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/gtk/fast/forms/form-hides-table-expected.txt:
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- 5:15 AM Changeset in webkit [259339] by
-
- 2 edits in trunk/Tools
[GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
https://bugs.webkit.org/show_bug.cgi?id=209471
Reviewed by Adrian Perez de Castro.
This is because we need to remove the weak pointer added in child windows to their parent.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowDispose): Remove the parentWindow weak ref.
(browser_window_class_init): Add dispose.
- 2:08 AM Changeset in webkit [259338] by
-
- 6 edits in trunk/Source
Support resolution of IPv6 STUN/TURN addresses
https://bugs.webkit.org/show_bug.cgi?id=209808
Reviewed by Eric Carlson.
Source/WebCore:
Add family access to IPAddress to support both IPv4 and IPv6.
Store IPAddress internal value as IPv6 and cast them to IPv4 on demand.
- platform/network/DNS.h:
- platform/network/soup/DNSResolveQueueSoup.cpp:
(WebCore::resolvedWithObserverCallback):
Source/WebKit:
Update code to support IPv6 addresses when doing DNS resolution of TURN/STUN servers.
Refactor code to share more code between Cocoa ports and non Cocoa ports.
Manually tested with external IPv6 TURN servers.
- NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
- NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp:
(WebKit::resolvedName):
- 12:54 AM Changeset in webkit [259337] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncoderList_EncoderID
https://bugs.webkit.org/show_bug.cgi?id=209800
Reviewed by Eric Carlson.
For recent OS versions, disable use of VCP.
Instead, use VTB compression session with kVTVideoEncoderSpecification_RequiredLowLatency set to true.
We keep MacOS code path checking frame size for public builds running on devices without hardware encoders.
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
(isStandardFrameSize): Deleted.
Mar 31, 2020:
- 8:19 PM Changeset in webkit [259336] by
-
- 4 edits in trunk/Source/WebKit
Dismiss color picker on color selection on MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=209840
<rdar://problem/46793808>
Reviewed by Darin Adler.
To have correct behavior on mac, we need to dismiss the color picker popover once
a color has been selected.
- UIProcess/ios/forms/WKFormColorControl.mm:
(-[WKColorPopover initWithView:]):
- UIProcess/ios/forms/WKFormColorPicker.h:
- UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker initWithView:]):
(-[WKColorPicker initWithView:inPopover:]):
(-[WKColorPicker colorMatrixView:didTapColorButton:]):
- 7:49 PM Changeset in webkit [259335] by
-
- 5 edits in trunk/Source/WebCore
Make FrameView and Frame TextStream-loggable
https://bugs.webkit.org/show_bug.cgi?id=209826
Reviewed by Darin Adler.
Provide operator<<(TextStream&, ...) for Frame and FrameView so they can be logged.
Only basic data logging currently; this can be adjusted as necessary.
- page/Frame.cpp:
(WebCore::operator<<):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::operator<<):
- page/FrameView.h:
- 7:32 PM Changeset in webkit [259334] by
-
- 3 edits2 adds in trunk
[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
https://bugs.webkit.org/show_bug.cgi?id=209816
<rdar://problem/60742191>
Reviewed by Antti Koivisto.
Source/WebCore:
Just because an element goes from out-of-flow to in-flow, it does not necessarily mean that the enclosing flow is going to change.
This patch ensure that we only call RenderTreeBuilder::multiColumnDescendantInserted when the flow actually gains new content.
Test: fast/multicol/absolute-to-static-change-same-enclosing-flow.html
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
LayoutTests:
- fast/multicol/absolute-to-static-change-same-enclosing-flow-expected.txt: Added.
- fast/multicol/absolute-to-static-change-same-enclosing-flow.html: Added.
- 7:29 PM Changeset in webkit [259333] by
-
- 11 edits in trunk/Source
Add type traits for ScrollableArea, and other cleanup
https://bugs.webkit.org/show_bug.cgi?id=209838
Reviewed by Chris Dumez.
Source/WebCore:
Make it possible to use type casts on ScrollableArea so that EventHandler code can stop
passing around so many different types.
Because ScrollView inherits from both Widget and ScrollableArea, expand out its SPECIALIZE_TYPE_TRAITS macros.
Mark RenderLayer and RenderListBox ScrollableArea overrides as final.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents): Null-check page and return early.
- platform/ScrollView.h:
(isType):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::isScrollView const):
(WebCore::ScrollableArea::isRenderLayer const):
(WebCore::ScrollableArea::isListBox const):
(WebCore::ScrollableArea::isPDFPlugin const):
- rendering/RenderLayer.h:
(isType):
- rendering/RenderListBox.h:
(isType):
Source/WebCore/../WebKit:
Because PDFPlugin inherits from both Plugin and ScrollableArea, expand out its SPECIALIZE_TYPE_TRAITS macros
and change the macros to use the isFoo() pattern.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.h:
(isType):
- WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::isPluginProxy const):
(WebKit::Plugin::isNetscapePlugin const):
(WebKit::Plugin::isPDFPlugin const):
- WebProcess/Plugins/PluginProxy.h:
- 7:06 PM Changeset in webkit [259332] by
-
- 2 edits in trunk/Source/WTF
Update check for aarch64
https://bugs.webkit.org/show_bug.cgi?id=209322
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-31
Reviewed by Mark Lam.
CPU(ARM64) is used on Linux, so checking to avoid Apple platforms doesn't make much sense.
The comment implying that this is an Apple architecture also no longer makes sense.
- wtf/PlatformCPU.h:
- 6:42 PM Changeset in webkit [259331] by
-
- 5 edits in trunk
Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
https://bugs.webkit.org/show_bug.cgi?id=209836
<rdar://problem/61071607>
Reviewed by Brent Fulgham.
Source/WebCore:
Ignore calls for WebKitNamespace::messageHandlers() and add release
logging if the domain is not app-bound.
- page/WebKitNamespace.cpp:
(WebCore::WebKitNamespace::messageHandlers):
Tools:
Most of this patch is changes to the tests, which formerly relied
on message handlers to test script injection protections. I rewrote
three tests to remove the use of message handlers which were used to
confirm normal script injection behavior before enabling In-App
Browser Privacy. Since normal script injection behavior is tested in
WKUserContentController.mm already it is unecessary to test here.
I removed one test, IgnoreAppBoundDomainsAcceptsUserScripts, which
fully relied on message handler use and could not be tested without
somehow disabling this feature.
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(TEST):
(-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
Add a message handler to this page to demonstrate that message
handlers work for app-bound navigations (file:// protocol is always
app-bound).
- 6:22 PM Changeset in webkit [259330] by
-
- 18 edits4 adds in trunk
Datalist option's label not used
https://bugs.webkit.org/show_bug.cgi?id=201768
<rdar://problem/55361186>
Reviewed by Darin Adler.
Source/WebCore:
Refactor DataListSuggestionInformation's suggestions to include label text as well as values, and then adjust
TextFieldInputType::suggestions() to match label text as well as values for ports that are capable of showing
label text in datalist suggestion UI.
Test: fast/forms/datalist/datalist-option-labels.html
- html/DataListSuggestionInformation.h:
Introduce DataListSuggestion, a wrapper around a value and label. Currently, the list of datalist suggestions
is only aVector<String>; change it to be aVector<DataListSuggestion>instead.
(WebCore::DataListSuggestion::encode const):
(WebCore::DataListSuggestion::decode):
(WebCore::DataListSuggestionInformation::encode const):
(WebCore::DataListSuggestionInformation::decode):
Move encoding and decoding for DataListSuggestionInformation out of WebCoreArgumentCoders and into WebCore.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::listAttributeTargetChanged):
(WebCore::TextFieldInputType::suggestions):
When computing suggestions, match label text in addition to values on ports that display label text in the
chrome; for the time being, this is only the case for macOS, but will be extended to iOS as well in a future
patch. Note that we don't plumb label text if it is already the same as the value, to avoid duplicate strings
from showing up.
(WebCore::TextFieldInputType::didCloseSuggestions):
- html/TextFieldInputType.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
Add a chrome client hook to return whether or not the client shows label text in its datalist UI.
- platform/DataListSuggestionsClient.h:
Source/WebKit:
Add support on macOS for showing option labels in datalist suggestions.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<DataListSuggestionInformation>::encode): Deleted.
(IPC::ArgumentCoder<DataListSuggestionInformation>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
Remove WebCoreArgumentCoders logic for encoding and decoding DataListSuggestionInformation. See
DataListSuggestionInformation.h in WebCore for more detail.
- UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
(WebKit::WebDataListSuggestionsDropdownGtk::show):
Tweak GTK code to adjust for the change from
StringtoDataListSuggestion.
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsControl didSelectOptionAtIndex:]):
(-[WKDataListSuggestionsControl textSuggestions]):
(-[WKDataListSuggestionsControl suggestionAtIndex:]):
Adjust some iOS codepaths to use DataListSuggestion::value as the value string to display.
- UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
Tweak several UI constants. A suggestion cell may now be either 20 or 40pt tall, depending on whether it has
label text to show.
Currently, the maximum combined height of the table view cells is 120 (not including spacing between cells and
vertical padding around the top and bottom of the table view), since the maximum number of cells to show is 6
and each cell is 20pt tall. Maintain this constant by making the maximum cell height 120, which accomodates
either three labeled cells, or 6 unlabeled cells (i.e. to match shipping behavior).
(-[WKDataListSuggestionView initWithFrame:]):
(-[WKDataListSuggestionView layout]):
Maintain two text fields or value and (optionally) label text:
_valueFieldand_labelField. The value field
fills the bounds of the cell in the case where there is no label text, but fills only the top half of the cell
in the case where there is label text. The label field takes the bottom half of the cell in this case.
Additionally, add a divider view that may appear at the very bottom of each cell. This divider view is present
when one or more suggestions in the datalist are labeled.
(-[WKDataListSuggestionView setValue:label:]):
Renamed from -setText:. Add a label string argument as well.
(-[WKDataListSuggestionView setShouldShowBottomDivider:]):
Add getters and setters for the -shouldShowBottomDivider property, which can be used to make the divider view
visible or hidden.
(-[WKDataListSuggestionView shouldShowBottomDivider]):
(-[WKDataListSuggestionView setBackgroundStyle:]):
Use -[NSColor secondaryLabelColor] for the label text field.
(shouldShowDividersBetweenCells):
Add a helper method to determine whether the table view should be showing clear dividers between each item.
We only do so if there are one or more labels to be shown.
(-[WKDataListSuggestionsController initWithInformation:inView:]):
(-[WKDataListSuggestionsController currentSelectedString]):
(-[WKDataListSuggestionsController updateWithInformation:]):
(-[WKDataListSuggestionsController moveSelectionByDirection:]):
Drive-by fix: scroll to reveal each selected row when using the arrow keys to navigate between items.
(-[WKDataListSuggestionsController dropdownRectForElementRect:]):
(-[WKDataListSuggestionsController tableView:heightOfRow:]):
Return either
dropdownRowHeightWithoutLabelordropdownRowHeightWithLabel, depending on whether there is
label text to be shown in that suggestion cell.
(-[WKDataListSuggestionsController tableView:viewForTableColumn:row:]):
(-[WKDataListSuggestionView setText:]): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canShowDataListSuggestionLabels const):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Source/WebKitLegacy/mac:
See WebCore/ChangeLog and WebKit/ChangeLog for more details.
- WebCoreSupport/WebChromeClient.h:
LayoutTests:
Add a test to verify that when datalist suggestions incorporate option labels into the displayed text
suggestions, they are matched against when changing the value of the input field, and can be selected. This is
expected to be the case on macOS, but not on other platforms (for the time being).
- fast/forms/datalist/datalist-option-labels-expected.txt: Added.
- fast/forms/datalist/datalist-option-labels.html: Added.
- platform/gtk/fast/forms/datalist/datalist-option-labels-expected.txt: Added.
- platform/ios/fast/forms/datalist/datalist-option-labels-expected.txt: Added.
- 5:55 PM Changeset in webkit [259329] by
-
- 3 edits in trunk/Source/WebInspectorUI
Added new WebSocket icon
https://bugs.webkit.org/show_bug.cgi?id=209433
Reviewed by Joseph Pecoraro.
Drive-by: remove unused #doc-orig
- UserInterface/Images/DocumentIcons.svg:
- UserInterface/Views/ResourceIcons.css:
(.resource-icon.resource-type-websocket .icon):
(@media (prefers-color-scheme: dark) .resource-icon.resource-type-websocket .icon):
- 5:45 PM Changeset in webkit [259328] by
-
- 8 edits in trunk
[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
https://bugs.webkit.org/show_bug.cgi?id=209814
Reviewed by Darin Adler.
Source/WebKit:
This was done for iOS in <https://trac.webkit.org/changeset/258915>, and in order to be able to do this
on macOS, checking in with Launch Services and updating the process name needs to be done after the
Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
previous call to RegisterApplication has been replaced with a call to launchServicesCheckIn, since
RegisterApplication is an AppKit function, and should be avoided since the WebContent process is not
a NSApplication anymore.
Test: fast/sandbox/mac/sandbox-mach-lookup.html
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::launchServicesCheckIn):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::platformInitializeProcess):
- WebProcess/com.apple.WebProcess.sb.in:
LayoutTests:
- fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
- fast/sandbox/mac/sandbox-mach-lookup.html:
- 5:31 PM Changeset in webkit [259327] by
-
- 3 edits in branches/safari-609-branch/Source/WebCore
Cherry-pick r259305. rdar://problem/61131083
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=209786
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-03-31
Reviewed by Ryosuke Niwa.
No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::handleSubstituteDataLoadNow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:31 PM Changeset in webkit [259326] by
-
- 2 edits in branches/safari-609-branch/Source/WebCore
Cherry-pick r259244. rdar://problem/61131078
Assertion failure in HTMLFormElement::formElementIndex
https://bugs.webkit.org/show_bug.cgi?id=209643
Reviewed by Darin Adler.
The bug was caused by FormAssociatedElement::findAssociatedForm finding a wrong form element
when it's called on an element which appears later in the removed subtree.
When we find the new form element to associate this element with, check to make sure its root
element is that of the tree scope. This condition will be false if this element is in in the midst
of being removed.
- html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::findAssociatedForm):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:12 PM Changeset in webkit [259325] by
-
- 5 edits in trunk/Source
[PlayStation] Fix build breaks after r259112
https://bugs.webkit.org/show_bug.cgi?id=209830
Unreviewed build fix.
Source/WebCore:
Add USE(GLIB) guards around RunLoopSourcePriority usage.
- platform/ScrollAnimationKinetic.cpp:
(WebCore::ScrollAnimationKinetic::ScrollAnimationKinetic):
Source/WebKit:
Replace PLATFORM(WPE) with USE(LIBWPE) within WebWheelEvent.
- Shared/WebEvent.h:
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):
- 5:09 PM Changeset in webkit [259324] by
-
- 10 edits in trunk
Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
https://bugs.webkit.org/show_bug.cgi?id=209833
Reviewed by Tim Hatcher.
Source/WebKit:
Covered by an API test. I knew something was broken in r259307 and this was it.
- Shared/UserContentControllerParameters.cpp:
(WebKit::UserContentControllerParameters::encode const):
(WebKit::UserContentControllerParameters::decode):
- Shared/UserContentControllerParameters.h:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::parameters const):
- UIProcess/WebPageProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
- 5:05 PM Changeset in webkit [259323] by
-
- 4 edits in trunk/Source/WebKit
Deduplicate WebsiteDataStore::parameters() of Cocoa port and non-Cocoa port
https://bugs.webkit.org/show_bug.cgi?id=209644
Reviewed by Youenn Fablet.
WinCairo WTR was failing an assertion ensuring
ResourceLoadStatistics was enabled in
NetworkSession::setThirdPartyCookieBlockingMode while running
LayoutTests with useEphemeralSession=true becuase
ResourceLoadStatisticsParameters was not set in
WebsiteDataStoreParameters.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters): Added.
(WebKit::WebsiteDataStore::parameters): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 4:58 PM Changeset in webkit [259322] by
-
- 4 edits in trunk
Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
https://bugs.webkit.org/show_bug.cgi?id=209839
<rdar://problem/61129400>
Reviewed by Darin Adler.
Source/WebKit:
Create a convenience mode for WKAppBoundDomains that assumes https if the user does
not supply the full URL. This doesn't effect the behavior of the app-bound domains
because we only deal in RegistrableDomains.
Tested by TestWebKitAPI.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::initializeAppBoundDomains): If the protocol is missing from
a domain supplied by WKAppBoundDomains, assume it was https.
Tools:
- TestWebKitAPI/Info.plist:
- 4:47 PM Changeset in webkit [259321] by
-
- 2 edits in trunk/LayoutTests
[ Catalina ] editing/mac/selection/context-menu-select-editability.html is failing on Catalina
https://bugs.webkit.org/show_bug.cgi?id=204246
Unreviewed test gardening.
- platform/mac/TestExpectations: Remove failure expectation since the test is now passing.
- 4:41 PM Changeset in webkit [259320] by
-
- 15 edits in trunk/Source/JavaScriptCore
[JSC] Introduce UCPUStrictInt32 for result type of DFG operations
https://bugs.webkit.org/show_bug.cgi?id=209832
Reviewed by Saam Barati.
Let's introduce UCPUStrictInt32 to DFG operations to offload StrictInt32 code into operations C++ code.
UCPUStrictInt32 is the same size to UCPURegister, and it is used for StrictInt32, which requires upper 32-bits
are zeroed.
- assembler/CPU.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult):
(JSC::DFG::SpeculativeJIT::compileBitwiseNot):
(JSC::DFG::SpeculativeJIT::compileBitwiseOp):
(JSC::DFG::SpeculativeJIT::compileShiftOp):
(JSC::DFG::SpeculativeJIT::compileArithAdd):
(JSC::DFG::SpeculativeJIT::compileArithAbs):
(JSC::DFG::SpeculativeJIT::compileArithClz32):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compileArithRounding):
(JSC::DFG::SpeculativeJIT::compileArithMinMax):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileVarargsLength):
(JSC::DFG::SpeculativeJIT::compileGetRestLength):
(JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
(JSC::DFG::SpeculativeJIT::compileGetEnumerableLength):
(JSC::DFG::SpeculativeJIT::compileGetArgumentCountIncludingThis):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::strictInt32Result):
(JSC::DFG::SpeculativeJIT::int32Result): Deleted.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileStringCodePointAt):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithClz32):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength):
(JSC::FTL::DFG::LowerDFGToB3::mapHashString):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::doubleToInt32):
(JSC::FTL::DFG::LowerDFGToB3::sensibleDoubleToInt32):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationSwitchStringAndGetBranchOffset):
(JSC::FTL::operationTypeOfObjectAsTypeofType):
- ftl/FTLOperations.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- runtime/MathCommon.cpp:
(JSC::operationToInt32):
(JSC::operationToInt32SensibleSlow):
- runtime/MathCommon.h:
(JSC::toUCPUStrictInt32):
- 4:03 PM Changeset in webkit [259319] by
-
- 2 edits in trunk/LayoutTests
[ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=209837
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 3:41 PM Changeset in webkit [259318] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 Debug] inspector/injected-script/avoid-getter-invocation.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209073
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 3:38 PM Changeset in webkit [259317] by
-
- 4 edits in trunk/Source/WebKit
[macOS] Update sandbox rules for correct sanitizer paths in current OS releases
https://bugs.webkit.org/show_bug.cgi?id=209818
<rdar://problem/58422996>
Reviewed by Per Arne Vollan.
Update the sandbox rules to allow access to the new system Asan library
locations.
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Note: Don't bother leaving
the old location in this sandbox, since it is not being used on any shipping
software.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 3:19 PM Changeset in webkit [259316] by
-
- 11 edits in trunk/Source
IndexedDB: destroy WebIDBServer when session is removed in network process
https://bugs.webkit.org/show_bug.cgi?id=209606
<rdar://problem/59310081>
Reviewed by Geoffrey Garen.
Source/WebCore:
Rename immediateCloseForUserDelete to immediateClose as we now use it in destructor of IDBServer to make sure
everything in database finishes correctly.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::~IDBServer):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::immediateClose):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
Source/WebKit:
Tested manually to verify WebIDBServer is removed and its thread ends when session is removed.
- NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::~WebIDBServer):
(WebKit::WebIDBServer::addConnection):
(WebKit::WebIDBServer::removeConnection):
(WebKit::WebIDBServer::close):
- NetworkProcess/IndexedDB/WebIDBServer.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::connectionToWebProcessClosed):
Source/WTF:
Add function to kill CrossThreadTaskHandler and make thread finish. Also add a callback to be called before
thread finishes.
- wtf/CrossThreadTaskHandler.cpp:
(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::setCompletionCallback):
(WTF::CrossThreadTaskHandler::kill):
- wtf/CrossThreadTaskHandler.h:
- 3:09 PM Changeset in webkit [259315] by
-
- 12 edits in trunk/Source
Regression(r253357) DeviceMotionEvent acceleration and rotationRate are null
https://bugs.webkit.org/show_bug.cgi?id=209831
<rdar://problem/60720953>
Reviewed by Darin Adler.
Source/WebCore:
The issue was that DeviceMotionClientIOS::motionChanged() would only initialize the
acceleration and rotationRate if [m_motionManager gyroAvailable] returned YES. After
r253357, m_motionManager is nil because we get motion data from the UIProcess so
[m_motionManager gyroAvailable] would always resolve to NO.
To address the issue, I made the rotationRate parameters to motionChanged() optional
and we rely on them being set to know if gyro data is available. Note that I did not
make the acceleration optional because according to [1], all devices have an
accelerometer.
[1] https://developer.apple.com/documentation/coremotion/cmmotionmanager/1616094-devicemotionavailable?language=objc
- platform/ios/DeviceMotionClientIOS.h:
- platform/ios/DeviceMotionClientIOS.mm:
(WebCore::DeviceMotionClientIOS::motionChanged):
- platform/ios/DeviceOrientationUpdateProvider.h:
- platform/ios/MotionManagerClient.h:
(WebCore::MotionManagerClient::motionChanged):
- platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager sendAccelerometerData:]):
Source/WebKit:
- UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.h:
- UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.mm:
(WebKit::WebDeviceOrientationUpdateProviderProxy::motionChanged):
- WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp:
(WebKit::WebDeviceOrientationUpdateProvider::deviceMotionChanged):
- WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h:
- WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.messages.in:
- 3:07 PM Changeset in webkit [259314] by
-
- 11 edits in branches/safari-610.1.7-branch
Cherry-pick r258436. rdar://problem/61125864
[ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
https://bugs.webkit.org/show_bug.cgi?id=209016
<rdar://problem/60329530>
Reviewed by Chris Dumez.
Source/WebKit:
This patch adds a function to re-initialize app bound domains for
in-app-browser-privacy tests, since they are only initialized once
when the WebsiteDataStore is created. This causes issues if the tests
are run in parallel with other tests with different app-bound domains.
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreReinitializeAppBoundDomains):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::clearAppBoundDomains): (WebKit::WebsiteDataStore::reinitializeAppBoundDomains):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Re-initialize the app-bound domains when the correct
TestOptions parameter is set.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions): (WTR::TestController::reinitializeAppBoundDomains):
- WebKitTestRunner/TestController.h:
LayoutTests:
Use TestOptions to trigger the re-initialization of app-bound domains.
- http/tests/in-app-browser-privacy/app-bound-domain.html:
- http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:29 PM Changeset in webkit [259313] by
-
- 2 edits in trunk/Source/WebCore
[iPadOS] Unable to scrub videos on nba.com
https://bugs.webkit.org/show_bug.cgi?id=209829
<rdar://problem/58804360>
Patch by Antoine Quint <Antoine Quint> on 2020-03-31
Reviewed by Dean Jackson.
Opt nba.com into the simulated mouse events dispatch quirk.
- page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
- 2:25 PM Changeset in webkit [259312] by
-
- 4 edits in trunk/LayoutTests
Unreviewed test gardening for iOS and macOS.
- platform/ios-simulator-wk2/TestExpectations: Skip a test that is consistently timing out.
- platform/ios/TestExpectations: Skip a crashing test, add failure expectation for webkit.org/b/208023
- platform/mac/TestExpectations: Add failure expectation for webkit.org/b/208023
- 2:11 PM Changeset in webkit [259311] by
-
- 3 edits in branches/safari-609-branch/Source/WebCore
Cherry-pick r258326. rdar://problem/61113047
Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
https://bugs.webkit.org/show_bug.cgi?id=208919
Reviewed by Eric Carlson.
These stream APIs are legacy now and not useful anymore.
Stop implementing the corresponding callbacks and remove related code.
Coverd by existing tests.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::addRemoteStream): Deleted. (WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): Deleted. (WebCore::LibWebRTCMediaEndpoint::OnAddStream): Deleted.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:57 PM Changeset in webkit [259310] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION: ASSERTION FAILED: regExpObjectNode in JSC::DFG::StrengthReductionPhase::handleNode
https://bugs.webkit.org/show_bug.cgi?id=209824
Reviewed by Mark Lam.
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
It's true that we need to verify lastIndex even when a RegExp is neither global nor sticky,
but if DFG's already converted RegExpExec to RegExpExecNonGlobalOrSticky, that means we've thrown away
the RegExpObject node, so we shouldn't try to reverify lastIndex when we reconsider folding to constant.
- 1:38 PM Changeset in webkit [259309] by
-
- 4 edits in branches/safari-610.1.7-branch/Source/WebKit
Cherry-pick r258600. rdar://problem/61082995
Add internal debugging when initializing an app-bound session
https://bugs.webkit.org/show_bug.cgi?id=209190
<rdar://problem/60371620>
Reviewed by Brent Fulgham.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::SessionWrapper::initialize): (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): (WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession): (WebKit::NetworkSessionCocoa::sessionWrapperForTask): (WebKit::NetworkSessionCocoa::appBoundSession): (WebKit::NetworkSessionCocoa::isolatedSession):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:21 PM Changeset in webkit [259308] by
-
- 5 edits in trunk/Source/WebCore
Append Upgrade-Insecure-Requests header in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=209664
Patch by Rob Buis <rbuis@igalia.com> on 2020-03-31
Reviewed by Youenn Fablet.
Append Upgrade-Insecure-Requests header in CachedResourceLoader, following
the fetch spec [1, step 3].
[1] https://fetch.spec.whatwg.org/#concept-main-fetch
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::populateFrameLoadRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):
(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded): Deleted.
- loader/FrameLoader.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 1:13 PM Changeset in webkit [259307] by
-
- 30 edits4 adds in trunk
Add SPI WKWebpagePreferences._userContentController
https://bugs.webkit.org/show_bug.cgi?id=209795
Reviewed by Tim Hatcher.
Source/WebKit:
This will allow us to switch which WKUserContentController we are using at decidePolicyForNavigationAction time
like we do WKWebsiteDataStores. This is only allowed with main frame navigations.
To do this I moved UserContentControllerParameters into their own struct.
I remove unused WebsitePoliciesData.websiteDataStoreParameters.
I pass an API::WebsitePolicies* further down the chain instead of switching to Optional<WebsitePoliciesData>,
which allows us to access the WebUserContentControllerProxy* from the former in WebPageProxy::creationParameters.
I removed an unused WebsitePolicies constructor.
I added a missing copied member variable in WebsitePolicies::copy.
- NetworkProcess/NetworkSession.cpp:
- Shared/UserContentControllerParameters.cpp: Added.
(WebKit::UserContentControllerParameters::encode const):
(WebKit::UserContentControllerParameters::decode):
- Shared/UserContentControllerParameters.h: Added.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
- Shared/WebsitePoliciesData.h:
- Sources.txt:
- UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
(API::WebsitePolicies::setUserContentController):
(API::WebsitePolicies::data):
(API::WebsitePolicies::WebsitePolicies): Deleted.
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageUpdateWebsitePolicies):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateWebpagePreferences:]):
- UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _userContentController]):
(-[WKWebpagePreferences _setUserContentController:]):
- UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
- UIProcess/ProvisionalPageProxy.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::parameters const):
(WebKit::WebUserContentControllerProxy::contentRuleListData const):
(WebKit::WebUserContentControllerProxy::contentRuleListData): Deleted.
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addWebUserContentControllerProxy):
- UIProcess/WebProcessProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_processDisplayName):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Tools:
- TestWebKitAPI/SourcesCocoa.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
- TestWebKitAPI/cocoa/TestUIDelegate.h: Added.
- TestWebKitAPI/cocoa/TestUIDelegate.mm: Added.
(-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[TestUIDelegate waitForAlert]):
- 1:08 PM Changeset in webkit [259306] by
-
- 2 edits in trunk/Source/WebKit
Remove call to PageConfiguration::setUserContentController added in r225765
https://bugs.webkit.org/show_bug.cgi?id=209828
<rdar://problem/61114052>
Reviewed by Brian Weinstein.
r225765 added a way for a certain Mac application to use WKWebViewConfiguration._pageGroup to set its WKUserContentController.
That Mac application has transitioned to setting the WKUserContentController manually, and this workaround needs to be removed
for that application's WKUserContentControllers to continue working as desired. I verified this fixes that application, and
it is the only user of WKWebViewConfiguration._pageGroup and all other applications will have no change in behavior.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
- 12:56 PM Changeset in webkit [259305] by
-
- 3 edits in trunk/Source/WebCore
Invalid memory access @ WebCore::FrameLoader::dispatchDidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=209786
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-03-31
Reviewed by Ryosuke Niwa.
No new tests. Reduced test would be added later. Currently issue is verified with the original testcase in associated radar-58416328.
Webkit1 only issue, where m_client.dispatchDidCommitLoad in FrameLoader::dispatchDidCommitLoad could cause the frame
to be destroyed, and m_frame still being accessed outside. Changes made to protect the DocumentLoader and Frame.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
- 12:55 PM Changeset in webkit [259304] by
-
- 3 edits in trunk/Source/WebCore
Buildfix after r259928.
Replace outer function with its virtual implementation in
child class.
Unreviewed build fix.
- workers/WorkerAnimationController.cpp:
(WebCore::WorkerAnimationController::virtualHasPendingActivity const):
(WebCore::WorkerAnimationController::hasPendingActivity const): Deleted.
- workers/WorkerAnimationController.h:
- 12:40 PM Changeset in webkit [259303] by
-
- 16 edits in trunk/Source/WebCore
[iPad] Use AVAudioSession to detect AirPlay route changes
https://bugs.webkit.org/show_bug.cgi?id=209789
<rdar://problem/58065279>
Reviewed by Jer Noble.
Source/WebCore:
No new tests: changes only affect playback on device to an actual AirPlay device, which
is not testable on our current testing infrastructure.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::checkPlaybackTargetCompatablity): Drive-by fix: pass log identifier
into lambda so the method name is logged.
(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget): Ditto.
(WebCore::HTMLMediaElement::setWirelessPlaybackTarget): Update logging.
(WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget): Call setIsPlayingToWirelessTarget
so we kick off a media player compatibility check.
- platform/audio/PlatformMediaSessionManager.h: Remove unused instance variables.
- platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelperiOS::activeAudioRouteDidChange): Change parameter to bool as it is always
present.
(MediaSessionHelperiOS::activeVideoRouteDidChange): Remove parameters, use the new
MediaPlaybackTargetCocoa create method and ask it if the target supports AirPlay.
(-[WebMediaSessionHelper initWithCallback:]): Listen for AVAudioSessionRouteChangeNotification.
(-[WebMediaSessionHelper activeOutputDeviceDidChange:]): Update for new notification source.
(-[WebMediaSessionHelper activeAudioRouteDidChange:]): Deleted.
- platform/audio/ios/MediaSessionManagerIOS.h:
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback): Set playback target on session
that is about to begin playback.
(WebCore::MediaSessionManageriOS::activeVideoRouteDidChange): Save the target and state.
- platform/graphics/MediaPlaybackTarget.h:
- platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h:
- platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:
(WebCore::MediaPlaybackTargetCocoa::create): Create a target from the application's currently
active AVOutputContext.
(WebCore::MediaPlaybackTargetCocoa::supportsAirPlayVideo const): New.
(WebCore::MediaPlaybackTargetCocoa::hasActiveRoute const): Use new API if available instead
of just checking for the AVOutputContext name.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setWirelessPlaybackTarget): Log.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setShouldPlayToPlaybackTarget):
- platform/mock/MediaPlaybackTargetMock.h:
Source/WebCore/PAL:
- pal/cocoa/AVFoundationSoftLink.h:
- pal/cocoa/AVFoundationSoftLink.mm:
- pal/spi/cocoa/AVFoundationSPI.h:
- 12:19 PM Changeset in webkit [259302] by
-
- 5 edits in trunk
REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer
https://bugs.webkit.org/show_bug.cgi?id=209668
<rdar://problem/60976297>
Reviewed by Darin Adler.
Source/WebCore:
Null check m_player and m_videoElement before calling createVideoFullscreenLayer().
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createVideoFullscreenLayer):
- platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::createVideoFullscreenLayer):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 11:22 AM Changeset in webkit [259301] by
-
- 2 edits in trunk/LayoutTests
[ Mac Debug ] ASSERTION FAILED: m_videoFullscreenMode on media/media-fullscreen-return-to-inline.html
https://bugs.webkit.org/show_bug.cgi?id=209823
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:40 AM Changeset in webkit [259300] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Add additional IPC permission needed by Security.framework
https://bugs.webkit.org/show_bug.cgi?id=209815
<rdar://problem/60892378>
Reviewed by Per Arne Vollan.
Add missing permission needed for recent macOS releases.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 10:39 AM Changeset in webkit [259299] by
-
- 7 edits in trunk/Source/WebCore
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
https://bugs.webkit.org/show_bug.cgi?id=209684
<rdar://problem/60987285>
Reviewed by Darin Adler.
I have not been able to reproduce so this is a speculative fix. HTMLMediaElement::virtualHasPendingActivity()
was checking MainThreadGenericEventQueue::hasPendingEvents() but this would return false for a short amount
of time where we've removed the last event from the queue and before we've actually fired the event. To
address the issue, we now rely on MainThreadGenericEventQueue::hasPendingActivity() which keeps returning
true after we've dequeued the last event, until we've fired it.
No new tests, covered by imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::virtualHasPendingActivity const):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::virtualHasPendingActivity const):
- dom/GenericEventQueue.cpp:
(WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
(WebCore::MainThreadGenericEventQueue::hasPendingActivity const):
(WebCore::MainThreadGenericEventQueue::hasPendingEvents const): Deleted.
- dom/GenericEventQueue.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
- html/track/TrackListBase.cpp:
(WebCore::TrackListBase::virtualHasPendingActivity const):
- 10:35 AM Changeset in webkit [259298] by
-
- 18 edits6 adds in trunk
requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=202525
Reviewed by Simon Fraser.
Source/WebCore:
Implement AnimationFrameProvider on DedicatedWorkerGlobalScope,
This allows use of requestAnimationFrame and cancelAnimationFrame
inside a dedicated worker thread. This is useful to control animation
when using OffscreenCanvas, and this implementation is only enabled
with the OffscreenCanvas build flag and runtime setting.
Specification: https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#animation-frames
No new tests. Covered by existing tests.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- dom/RequestAnimationFrameCallback.h:
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::requestAnimationFrame):
(WebCore::DedicatedWorkerGlobalScope::cancelAnimationFrame):
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/WorkerAnimationController.cpp: Added.
- workers/WorkerAnimationController.h: Added.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::requestAnimationFrameEnabled const):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerParameters::isolatedCopy const):
- workers/WorkerThread.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
LayoutTests:
Add PASS expectations for DedicatedWorkerGlobalScope.AnimationFrameProvider on platforms where
OffscreenCanvas is enabled.
- platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added.
- 10:28 AM Changeset in webkit [259297] by
-
- 3 edits in trunk/Source/WebKit
Silence preference write sandbox violations in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=209806
Reviewed by Brent Fulgham.
When CFPrefs direct mode is enabled in the WebContent process, the UI process will notify the WebContent about preference changes.
When receiving these notifications, the WebContent process will use the CFPrefs API to update the value of these preferences
in-process, which will also attempt to write these values to disk. Writing the preference values to disk is unnecessary, and will
also be denied by the sandbox, so the sandbox violations should be silenced.
No new tests, no behavior change.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:03 AM Changeset in webkit [259296] by
-
- 16 edits2 adds in trunk
[Tables] Infinite recursion in RenderTreeBuilder::attach
https://bugs.webkit.org/show_bug.cgi?id=209771
<rdar://problem/59923112>
Reviewed by Simon Fraser.
Source/WebCore:
Let's construct a COLGROUP wrapper when a COL element is inserted into a <table>. The rest of the table code assumes such structure.
(https://www.w3.org/TR/html52/tabular-data.html#the-col-element)
Test: fast/table/anonymous-colgroup-simple.html
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
(WebCore::RenderTableCol::updateFromElement):
- rendering/RenderTableCol.h:
- rendering/updating/RenderTreeBuilderTable.cpp:
(WebCore::RenderTreeBuilder::Table::findOrCreateParentForChild):
LayoutTests:
- fast/table/anonymous-colgroup-simple-expected.txt: Added.
- fast/table/anonymous-colgroup-simple.html: Added.
- 9:52 AM Changeset in webkit [259295] by
-
- 3 edits in trunk/Tools
Delete code for security EWS from old EWS (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=209683
Revert 233220.
Unreviewed follow-up fix.
- Scripts/webkitpy/common/net/statusserver_mock.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 9:10 AM Changeset in webkit [259294] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209812
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 9:09 AM Changeset in webkit [259293] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage
https://bugs.webkit.org/show_bug.cgi?id=209810
<rdar://problem/61106971>
Unreviewed, covered by existing tests.
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage):
Remove the assertion sincedebugBroadcastConsoleMessageis also called when turning off
debug logging mode viasetResourceLoadStatisticsDebugMode. Fundamentally, it's just a
wrapper function forbroadcastConsoleMessageanyways, so it doesn't need to be gated.
- 8:40 AM Changeset in webkit [259292] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/track/track-in-band-metadata-display-order.html
https://bugs.webkit.org/show_bug.cgi?id=206226
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Mark test as flaky.
- 8:13 AM Changeset in webkit [259291] by
-
- 1 edit15 adds in trunk/LayoutTests
[WPE] Gardening, add missing expectation files
https://bugs.webkit.org/show_bug.cgi?id=209807
Unreviewed gardening.
- platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt: Added.
- platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt: Added.
- platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt: Added.
- platform/wpe/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt: Added.
- platform/wpe/fast/html/details-marker-style-mixed-expected.txt: Added.
- platform/wpe/fast/html/details-writing-mode-mixed-expected.txt: Added.
- platform/wpe/fast/multicol/tall-image-behavior-lr-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/background-vertical-lr-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/background-vertical-rl-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/basic-vertical-line-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/vertical-baseline-alignment-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/vertical-lr-replaced-selection-mixed-expected.txt: Added.
- platform/wpe/fast/writing-mode/vertical-rl-replaced-selection-mixed-expected.txt: Added.
- 8:01 AM Changeset in webkit [259290] by
-
- 5 edits in trunk
Fix SDP filtering after https://trac.webkit.org/changeset/258545
https://bugs.webkit.org/show_bug.cgi?id=209799
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated test.
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::filterSDP const):
Do not return early in case of filtering of mDNS candidate inlined in SDP description.
LayoutTests:
- webrtc/datachannel/mdns-ice-candidates-expected.txt:
- webrtc/datachannel/mdns-ice-candidates.html:
- 7:53 AM Changeset in webkit [259289] by
-
- 2 edits in trunk/Source/WebCore
Ensure that RealtimeMediaSource::setShouldApplyRotation is called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=209797
Reviewed by Eric Carlson.
Hop to the main thread before calling setShouldApplyRotation on the source.
- platform/mediastream/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::applyRotation):
- 7:52 AM Changeset in webkit [259288] by
-
- 5 edits in trunk/Source/WebCore
The relative frame and hit test of isolated objects must be dispatched to the main thread.
https://bugs.webkit.org/show_bug.cgi?id=209792
Reviewed by Chris Fleizach.
The relative frame of isolated objects must be calculated on the main
thread because it requires the scroll ancestor to convert to the
appropriate scroll offset. The relative frame cannot be cached because
the scroll offset can change.
Accordingly, the hit test cannot rely on a cached relative frame and
must be dispatched to be computed on the main thread as well.
- accessibility/AXObjectCache.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData): Do not cache the relative frame any longer.
(WebCore::AXIsolatedObject::accessibilityHitTest const): Dispatched to the main thread.
(WebCore::AXIsolatedObject::relativeFrame const): Dispatched to the main thread.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
- 7:20 AM Changeset in webkit [259287] by
-
- 2 edits in trunk/Source/WebKit
Several refactorings done in the MemoryPressureMonitor.cpp
https://bugs.webkit.org/show_bug.cgi?id=209464
Reviewed by Adrian Perez de Castro.
1) toIntegralType() parses the C-string str interpreting its content
as anunsigned long long intwhich is more appropriate for
the size_t (unsigned integer type) variables used by the
MemoryPressureMonitor functions in counterpoint of atoll() what
returns along long int.
This change also controls if the parsing was succesful. In negative
case returnsnotSet.
2) Added the getCgroupFileValue() function what encapsulates the
manipulation of the opened files in the/sys/fs/cgrouphierarchy.
This change simplify the code avoding unnecessary code repetion.
3) getCgroupControllerPath() now checks if there is a
name=systemd
controller listed in the/proc/self/cgroup. This important for
cgroup v2 activated withsystemd.unified_cgroup_hierarchy=yes
through the Linux kernel cmdline. The unified hierarchy simplies
path of the controllers under the same directory (check the
"Deprecated v1 Core Features" section in the Linux Kernel
documentation fir cgroup v2 [1]):
Multiple hierarchies including named ones are not supported
[1] https://www.kernel.org/doc/Documentation/cgroup-v2.txt
4) Because 3) the patch composited for cgroupV2 changes
getMemoryUsageWithCgroup() slightly. The name of the controller
is not needed anymore.
5) For cgroup v2, the MemoryTotal is calculated as the minimum
between memory.high and memory.max.
- UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::lowWatermarkPages):
(WebKit::getCgroupFileValue):
(WebKit::getMemoryTotalWithCgroup):
(WebKit::getMemoryUsageWithCgroup):
(WebKit::getCgroupControllerPath):
(WebKit::systemMemoryUsedAsPercentage):
(WebKit::getCgroupController): Deleted.
- 7:13 AM Changeset in webkit [259286] by
-
- 3 edits2 adds in trunk
Nullptr crash in InlineTextBox::emphasisMarkExistsAndIsAbove
https://bugs.webkit.org/show_bug.cgi?id=207034
Reviewed by Zalan Bujtas.
Source/WebCore:
The repro case was fixed in https://bugs.webkit.org/show_bug.cgi?id=209695.
Test: editing/selection/selection-update-during-anonymous-inline-teardown.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
Also add a null check to be sure.
LayoutTests:
- editing/selection/selection-update-during-anonymous-inline-teardown-expected.txt: Added.
- editing/selection/selection-update-during-anonymous-inline-teardown.html: Added.
- 5:58 AM Changeset in webkit [259285] by
-
- 2 edits2 adds in trunk/LayoutTests
[GTK] Gardening, update TestExpectations and add baseline
https://bugs.webkit.org/show_bug.cgi?id=209803
Unreviewed gardening.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: Added.
- 2:38 AM Changeset in webkit [259284] by
-
- 16 edits in trunk/Source
[GTK][WPE] Jumpy rendering of fixed-element layers while scrolling
https://bugs.webkit.org/show_bug.cgi?id=209466
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Avoid intermittent state application that can occur when asynchronous
scrolling is done on the dedicated thread while the general scene update
is being done in parallel on the composition thread, leading to partial
scrolling updates that visually present themselves as e.g. fixed
elements "jumping" around the view.
Instead of the staging state of a given Nicosia::CompositionLayer, the
scrolling nodes now update the base state with the given scrolling
change. At the end of the update, inside the UpdateScope descructor,
the updated states inside the scene are flushed into the staging phase
before they are adopted by the composition thread.
- page/scrolling/nicosia/ScrollingTreeFixedNode.cpp:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
- page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers):
- page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp:
(WebCore::ScrollingTreeOverflowScrollProxyNode::applyLayerPositions):
- page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers):
- page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:
(WebCore::ScrollingTreePositionedNode::applyLayerPositions):
- page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:
(WebCore::ScrollingTreeStickyNode::applyLayerPositions):
- platform/graphics/nicosia/NicosiaPlatformLayer.h:
(Nicosia::CompositionLayer::accessStaging): Deleted.
- platform/graphics/nicosia/NicosiaSceneIntegration.cpp:
(Nicosia::SceneIntegration::SceneIntegration):
(Nicosia::SceneIntegration::invalidate):
(Nicosia::SceneIntegration::UpdateScope::~UpdateScope):
- platform/graphics/nicosia/NicosiaSceneIntegration.h:
(Nicosia::SceneIntegration::create):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncPosition):
Don't signal the related attribute delta flag since this change is now
strictly applied by the scrolling thread.
(WebCore::CoordinatedGraphicsLayer::syncBoundsOrigin): Ditto.
Source/WebKit:
Move the Nicosia::SceneIntegration ownership into the
CompositingCoordinator class, along with the SceneIntegration::Client
inheritance. LayerTreeHost in turn now implements the updateScene()
method that triggers a scene update when invoked.
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::invalidate):
(WebKit::CompositingCoordinator::attachLayer):
(WebKit::CompositingCoordinator::requestUpdate):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::LayerTreeHost):
(WebKit::LayerTreeHost::~LayerTreeHost):
(WebKit::LayerTreeHost::updateScene):
(WebKit::LayerTreeHost::sceneIntegration): Deleted.
(WebKit::LayerTreeHost::requestUpdate): Deleted.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
- 2:10 AM Changeset in webkit [259283] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r258829): [CoordinatedGraphics] Web view not updated after cross site navigation with PSON enabled
https://bugs.webkit.org/show_bug.cgi?id=209741
Reviewed by Žan Doberšek.
Since r258829, the drawing area proxy of a provisional page ignores all messages until the load is
committed. This is causing 2 problems for coordinated graphics drawing area. When not in accelerated compositing
mode, Update message is sent before the commit is loaded, and the web process keeps waiting for the DidUpdate
response message forever. When accelerated compositing mode is forced, the EnterAcceleratedCompositing message
is also sent before the load is committed and ignored, so the UI process doesn't know it's in accelerated mode.
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::scheduleRenderingUpdate): Return early if layer tree is frozen. This
ensures that Update messages are not sent to the UI process while layer tree is frozen.
(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Disable layer flush on the newly
created LayerTreeHost if layer tree is frozen. This ensures that EnterAcceleratedCompositing message is sent
after the first layer flush once the layer tree is no longer frozen.
