Context Navigation

← Previous Period
Next Period →

Timeline

Mar 19, 2021:

4:59 PM Changeset in webkit [274750] by achristensen@apple.com

7 edits in trunk/Source/WebCore

Link against the ANGLE Shared Library
https://bugs.webkit.org/show_bug.cgi?id=218539
<rdar://problem/69062211>

Patch by Dean Jackson <dino@apple.com> on 2021-03-19
Reviewed by Tim Horton.

Weak link against libANGLE-shared.dylib.

Configurations/WebCore.xcconfig:
Configurations/WebCoreTestSupport.xcconfig:
Sources.txt:
SourcesGTK.txt:
SourcesWPE.txt:
platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::isANGLEAvailable):
(WebCore::GraphicsContextGLOpenGL::create):

4:53 PM Changeset in webkit [274749] by Lauro Moura

2 edits in trunk/Source/WebCore

Unreviewed. WPE Debug build fix after r274695

platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::submitFrame):

4:41 PM Changeset in webkit [274748] by Chris Dumez

9 edits
6 adds in trunk/LayoutTests

Resync webaudio web-platform-tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=223537

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

esync webaudio web-platform-tests from upstream a8cbe9c712ad032d36.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/nan-param-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/nan-param.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-param-getter-overridden.https.html: Added.
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/invalid-param-array-processor.js: Added.

(InvalidParamArrayProcessor.get parameterDescriptors):
(InvalidParamArrayProcessor):
(InvalidParamArrayProcessor.prototype.process):
(string_appeared_here):

web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator.html:

LayoutTests:

Skip test that is crashing (will investigate in a follow-up).

TestExpectations:

4:36 PM Changeset in webkit [274747] by Ruben Turcios

7 edits in branches/safari-612.1.7-branch

Revert r274596. rdar://problem/75635768

4:27 PM Changeset in webkit [274746] by Kate Cheney

13 edits in trunk/Source

Cannot login to microsoftonline.com without allowing storage access
https://bugs.webkit.org/show_bug.cgi?id=223510
<rdar://problem/75619058>

Reviewed by John Wilander.

Source/WebCore:

This patch introduces two changes:

Activate the storage access quirks for default browsers only. This

is the main place we test them, and can lead to unexpected behavior in
apps otherwise.

Doesn't cancel the click even if the user denies storage access.

Previously we we were not allowing the click because it produces
unexpected behavior. But, sites like login.microsoftonline.com are used
by multiple Microsoft login flows. Since only a subset require storage
access, canceling the click across the board could be considered
regressing behavior.

Since storage access data is stored in the network process, we
currently cancel the user's click on quirked sites while we wait
asyncronously for the IPC response. If the user grants storage access,
we store this in the web content process and dispatch a synthetic
click. In this case, when the click triggers another storage access
check, we can allow the click because we no longer need to wait for
information from the network process.

We need some heuristic in the web content process to handle the case
of the user denying storage access to know whether to allow a
synthetic click to happen. This patch introduces
hasDeniedCrossPageStorageAccess which stores domains in the web
content process which have been denied storage access via quirk. If
a user has previously denied storage access in that web content
process, we don't prompt again. A new web content process will give them
another opportunity to allow/deny storage access.

dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

loader/FrameLoaderClient.h:

Add a client function to check if the parent process is a full web
browser, and pass this to the place we apply the quirks.

loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::setHasDeniedCrossPageStorageAccess):
(WebCore::ResourceLoadObserver::hasDeniedCrossPageStorageAccess const):

page/Quirks.cpp:

(WebCore::hasDeniedCrossPageStorageAccess):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

page/Quirks.h:

Source/WebKit:

Disable the storage access quirk for non-default web browsers and
don't cancel the login click on sites even if the user denies storage
access. See WebCore changelog for more details.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::isParentProcessAFullWebBrowser const):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::hasDeniedCrossPageStorageAccess const):
(WebKit::WebResourceLoadObserver::setHasDeniedCrossPageStorageAccess):

WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageIsParentProcessAFullWebBrowser):
(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/WebPage.h:

4:25 PM Changeset in webkit [274745] by Ruben Turcios

1 copy in tags/Safari-611.1.21.1.13

Tag Safari-611.1.21.1.13.

3:44 PM Changeset in webkit [274744] by BJ Burg

2 edits in trunk/Tools

Update filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=223528

Reviewed by Simon Fraser.

Remove a bunch of informational messages that clog up output.
Remove some linker/loader warnings that are non-actionable.
Generalize a few existing filters to work with more targets.
Remove super-noisy and meaningless device preparation warnings.

Scripts/filter-build-webkit:

(shouldIgnoreLine):

3:32 PM Changeset in webkit [274743] by Chris Gambrell

3 edits
1 add
1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/gzip-content-encoding convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=223524
<rdar://problem/75625615>

Reviewed by Alex Christensen.

http/tests/gzip-content-encoding/gzip-encoded-script.html:
http/tests/gzip-content-encoding/gzip-encoded-stylesheet.html:
http/tests/gzip-content-encoding/resources/echo-data-encoding-with-gzip.php: Removed.
http/tests/gzip-content-encoding/resources/echo-data-encoding-with-gzip.py: Added.

3:19 PM Changeset in webkit [274742] by achristensen@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
https://bugs.webkit.org/show_bug.cgi?id=223499

Reviewed by Dean Jackson.

INSTALL_PATH was empty, so no dylib was being included in the root.
This is needed to fix the Catalyst build after bug 218539

Configurations/ANGLE-dynamic.xcconfig:

3:12 PM Changeset in webkit [274741] by Alan Bujtas

7 edits in trunk

Unreviewed, reverting r274596.

Google logo is not visible on google.com

Reverted changeset:

"[css-grid] Incorrect track sizing when using relative sized
items in 'auto' column tracks"
https://bugs.webkit.org/show_bug.cgi?id=191627
https://commits.webkit.org/r274596

3:05 PM Changeset in webkit [274740] by commit-queue@webkit.org

2 edits in trunk/Tools

update-webgl-conformance-tests script should use webgl/1.0.x and webgl/2.0.y directories
https://bugs.webkit.org/show_bug.cgi?id=223516

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-03-19
Reviewed by Kenneth Russell.

Import the tests to 1.0.x/2.0.y instead of 1.0.4/2.0.1 since we track the development
versions, not the upcoming snapshots.

Scripts/webkitpy/update_webgl_conformance_tests_lib/main.py:

(_generate_webkit_webgl_tests):
(main):

2:45 PM Changeset in webkit [274739] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore:
Anonymous table rows do not collapse if there are any other non-anonymous table row siblings.
https://bugs.webkit.org/show_bug.cgi?id=223490

Patch by Cameron McCormack <Cameron McCormack> on 2021-03-19
Reviewed by Zalan Bujtas.

Currently, when a RenderTableRow is detached from its parent, we will
check whether all of the remaining RenderTableRow siblings are anonymous
before deciding to merge them. This means that if removing the
RenderTableRow would produce a sequence of anonymous RenderTableRows
that could be collapsed, but we have some other non-anonymous
RenderTableRow as a sibling, then we'll incorrectly skip the collapsing.

Instead we should look only to the previous and next sibling, and
collapse them together if they're both anonymous.

Test: fast/table/table-anonymous-row-collapse.html

rendering/updating/RenderTreeBuilderTable.cpp:

(WebCore::RenderTreeBuilder::Table::collapseAndDestroyAnonymousSiblingRows):
Change from requiring all siblings after the detachment to be anonymous, to
looking only at the previous and following siblings.

LayoutTests:
Anonymous table rows do not collapse if there are any other non-anonymous table row siblings
https://bugs.webkit.org/show_bug.cgi?id=223490

Patch by Cameron McCormack <Cameron McCormack> on 2021-03-19
Reviewed by Zalan Bujtas.

fast/table/table-anonymous-row-collapse-expected.html: Added.
fast/table/table-anonymous-row-collapse.html: Added.

2:25 PM Changeset in webkit [274738] by Ruben Turcios

6 edits in branches/safari-611.1.21.1-branch

Cherry-pick r273875. rdar://problem/75635901

WKRemoteObjectCoder should be able to handle NSErrors from TLS failures
https://bugs.webkit.org/show_bug.cgi?id=222401
Source/WebKit:

<rdar://problem/72103865>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-03-03
Reviewed by Chris Dumez.

NSErrors from TLS failures contain values like a SecTrustRef or a SecCertificateRef,
which are not ObjC objects, and they don't like it when you call encodeWithCoder: on them.
Until r273141 it would crash when we do, but even after that we just decode a nil NSError.
Add a special case like we did in encodeNSError to successfully encode and decode these errors.

Shared/API/Cocoa/WKRemoteObjectCoder.mm: (decodeObjCObject): (transformCertificatesToData): (transformTrustToData): (encodeError): (transformDataToCertificates): (transformDataToTrust): (decodeError): (encodeObject): (decodeObject):

Tools:

Patch by Alex Christensen <achristensen@webkit.org> on 2021-03-03
Reviewed by Chris Dumez.

TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm: (TEST):
TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm: (-[RemoteObjectRegistryPlugIn sendError:completionHandler:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:20 PM Changeset in webkit [274737] by BJ Burg

2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: RangeError: Array size is not a small enough positive integer.
https://bugs.webkit.org/show_bug.cgi?id=223532
<rdar://problem/75635080>

Reviewed by Devin Rousso.

This patch fixes the broken CPU instrument when viewing a JSON timeline recordng.

This exception is thrown when viewing a timeline recording that has been
imported from JSON file. Aside from the exception, the code is functionally
broken in this situation since passing a negative number to Array() doesn't work.

I tested this change manually and selection ranges now behave as expected, and
have not regressed in other instruments / UI.

UserInterface/Views/CPUTimelineView.js:

Based on my investigation, the visibleEndTime is incorrectly computed when
showing a JSON timeline recording because the currentTime property is always '0'.
If this is the case, then let's assume that the entire range should be displayed.

1:20 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

1:19 PM Changeset in webkit [274736] by Brent Fulgham

2 edits in trunk/Source/WebKit

[macOS] Allow opendirectoryd access in base system
https://bugs.webkit.org/show_bug.cgi?id=223527
<rdar://problem/75492699>

Reviewed by Per Arne Vollan.

Allow the WebContent process to communicate with opendirectoryd when running in the base system.

WebProcess/com.apple.WebProcess.sb.in:

1:18 PM Changeset in webkit [274735] by BJ Burg

8 edits in trunk/Source/WebKit

Web Inspector: remove unnecessary inspectorBaseURL() and assumed read access
https://bugs.webkit.org/show_bug.cgi?id=223526

Reviewed by Devin Rousso.

inspectorBaseURL() is only used to call WebProcess::assumeReadAccessToBaseURL, which
generates a sandbox extension. However, after r274697, all ports now use non-file:///
schemes to load inspector resources, so any needed sandbox extensions are handled in
port-specific code or by the URL scheme handler.

UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):

UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createFrontendPage):
(WebKit::WebInspectorProxy::inspectorBaseURL): Deleted.

UIProcess/Inspector/WebInspectorProxy.h:
UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL): Deleted.

UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorBaseURL): Deleted.

UIProcess/Inspector/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL): Deleted.

mac/WebKit2.order:

12:55 PM Changeset in webkit [274734] by jer.noble@apple.com

7 edits in trunk

Many media/media-fragments/ tests are crashing due to other tests that run before them.
https://bugs.webkit.org/show_bug.cgi?id=223277
<rdar://problem/75492360>

Reviewed by Eric Carlson.

Source/WebCore:

Work around the crashing function by pre-conforming the fragment identifier according
to the format required by the crashing function.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::hasBrokenFragmentSupport):
(WebCore::conformFragmentIdentifierForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):

Source/WebCore/PAL:

pal/cocoa/AVFoundationSoftLink.h:
pal/cocoa/AVFoundationSoftLink.mm:

LayoutTests:

platform/mac/TestExpectations:

12:30 PM Changeset in webkit [274733] by youenn@apple.com

6 edits
3 adds in trunk

Custom scheme handled origins should be considered secure
https://bugs.webkit.org/show_bug.cgi?id=223423

Reviewed by Alex Christensen.

Source/WebCore:

If an app registers 'custom' as scheme handler, 'custom://localhost/page.html' is considered secure context
but 'custom://test/page.html' is not.
This patch makes it so that any 'custom://XXX/' origin will be considered secure context if 'custom' is a registered scheme handler.
Covered by API test and new test.

Test: http/tests/events/device-orientation-motion-insecure-context.html

WebCore.xcodeproj/project.pbxproj:
page/SecurityOrigin.cpp:

(WebCore::shouldTreatAsPotentiallyTrustworthy):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

(-[URLSchemeHandlerMessageHandler userContentController:didReceiveScriptMessage:]):

LayoutTests:

Add a new test to check device orientation in insecure context now that we cannot do that anymore with custom schemes.

http/tests/events/device-orientation-motion-insecure-context-expected.txt: Added.
http/tests/events/device-orientation-motion-insecure-context.html: Added.
platform/ios/http/tests/events/device-orientation-motion-insecure-context-expected.txt: Added.

12:22 PM Changeset in webkit [274732] by jer.noble@apple.com

9 edits in trunk

[GPUP] platform/mac/media/encrypted-media/fps-clearkey-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=221687
<rdar://problem/74438911>

Reviewed by Eric Carlson.

Source/WebKit:

Add support for passing the value of MediaPlayerPrivate::waitingForKey() across the process boundary.

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerWaitingForKeyChanged):

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::waitingForKeyChanged):
(WebKit::MediaPlayerPrivateRemote::waitingForKey const):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:

LayoutTests:

platform/mac-wk2/TestExpectations:

12:21 PM Changeset in webkit [274731] by Peng Liu

8 edits in trunk

[GPUP] Test imported/w3c/web-platform-tests/fetch/range/general.window.html fails when media in GPU process is enabled.
https://bugs.webkit.org/show_bug.cgi?id=221817

Reviewed by Jer Noble.

Source/WebKit:

The didLoadingProgress() function of MediaPlayerPrivateAVFoundation
and MediaPlayerPrivateMediaSourceAVFObjC changes their mutable member
variables, so a caller (e.g., RemoteMediaPlayerProxy::didLoadingProgress())
will get false eventually if it calls the function repeatedly. As a result,
MediaPlayerPrivateRemote::didLoadingProgress() will always return false.
This patch fixes this issue with a new synchronous message in RemoteMediaPlayerProxy.

No new tests. Fix a test failure.

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::didLoadingProgress):
(WebKit::RemoteMediaPlayerProxy::updateCachedState):

GPUProcess/media/RemoteMediaPlayerProxy.h:
GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::didLoadingProgress const):
(WebKit::MediaPlayerPrivateRemote::updateCachedState):

WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

LayoutTests:

platform/wk2/TestExpectations:

12:00 PM Changeset in webkit [274730] by Russell Epstein

2 edits in branches/safari-611.1.21.1-branch/Source/WebKit

Apply patch. rdar://problem/75625529

11:59 AM Changeset in webkit [274729] by Russell Epstein

8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.13

11:02 AM Changeset in webkit [274728] by ChangSeok Oh

8 edits
8 adds in trunk

Animated AVIF support
https://bugs.webkit.org/show_bug.cgi?id=222804
<rdar://problem/75362181>

Reviewed by Philippe Normand.

This change implements animation of the avif sequence. The decoding approach
is similar to ones for other image formats, i.e., decoding frames in BGRA pixels
then bit-copying them into ScalableImageDecoderFrame. The decoded frames are cached
for future use. The repetition is missing in this change. It will be addressed
in separate patches.

The added avif animation test compares the last frame of each avifs and a static
avif image. The embeded avifs images are originated from corresponding webp images
for animated-webp.html, and encoded with timescale 100 (i.e., the duration of each frame
is 0.01s). The total duration and the track duration are same so the added avifs samples
are supposed to be played one time.

Source/WebCore:

Test: fast/images/animated-avif.html

platform/image-decoders/avif/AVIFImageDecoder.cpp:

(WebCore::AVIFImageDecoder::repetitionCount const):
(WebCore::AVIFImageDecoder::findFirstRequiredFrameToDecode):
(WebCore::AVIFImageDecoder::frameBufferAtIndex):
(WebCore::AVIFImageDecoder::isComplete):
(WebCore::AVIFImageDecoder::tryDecodeSize):
(WebCore::AVIFImageDecoder::decode):

platform/image-decoders/avif/AVIFImageDecoder.h:
platform/image-decoders/avif/AVIFImageReader.cpp:

(WebCore::AVIFImageReader::decodeFrame):
(WebCore::AVIFImageReader::imageCount const):
(WebCore::AVIFImageReader::~AVIFImageReader): Deleted.

platform/image-decoders/avif/AVIFImageReader.h:

LayoutTests:

TestExpectations:
fast/images/animated-avif-expected.html: Added.
fast/images/animated-avif.html: Added.
fast/images/resources/avifs00-ref.avif: Added.
fast/images/resources/avifs00.avifs: Added.
fast/images/resources/avifs01-ref.avif: Added.
fast/images/resources/avifs01.avifs: Added.
fast/images/resources/avifs02-ref.avif: Added.
fast/images/resources/avifs02.avifs: Added.
platform/gtk/TestExpectations:

10:48 AM Changeset in webkit [274727] by mark.lam@apple.com

4 edits
1 add in trunk

BrandedStructure should keep its members alive.
https://bugs.webkit.org/show_bug.cgi?id=223495
rdar://75565765

Reviewed by Saam Barati.

JSTests:

stress/BrandedStructure-should-keep-its-members-alive.js: Added.

Source/JavaScriptCore:

Normally, each type of JSCell would have its own structure (and therefore, its own
ClassInfo, MethodTable, etc), which would have handled visiting m_parentBrand.
Similarly, it would have its own destructor, which would deref m_brand.

However, the design of BrandedStructure is not like other JSCells. As present,
we have chosen to go with having BrandedStructure look exactly like a regular
Structure, except that its isBrandedStructure flag is set to true.

This design has advantages because we do checks all over the system for whether
a cell is a Structure by simply comparing its structureID to structureStructure's
structureID. By virtue of BrandedStructure having the same structure as Structure,
none of this code need to change.

The downside is that we need to enhance Structure's methods to check if it is
actually working on an instance of BrandedStructure, and do some additional work.

This patch fixes 2 bugs:

m_parentBrand was not visited by visitChildren().

Structure::visitChildrenImpl() now calls BrandedStructure::visitAdditionalChildren()
to handle this.

m_brand needs to be ref'ed.

In Structure::setBrandTransition(), if the BrandedStructure is a dictionary,
then its m_transitionPropertyName will be cleared. m_transitionPropertyName
was the only means by which the UniqueStringImpl pointed to by m_brand was
ref'ed. The fix is to make m_brand a RefPtr.

Hence, it follows that we also need to deref m_brand on destruction.
Structure's destructor now calls BrandedStructure::destruct() to handle this.

runtime/BrandedStructure.h:
runtime/Structure.cpp:

(JSC::Structure::~Structure):
(JSC::Structure::visitChildrenImpl):

10:48 AM Changeset in webkit [274726] by commit-queue@webkit.org

3 edits
2 adds in trunk

scroll-snap-stop: always not respected during momentum scrolling
https://bugs.webkit.org/show_bug.cgi?id=223406

Patch by Martin Robinson <mrobinson@igalia.com> on 2021-03-19
Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/scroll-snap/scroll-snap-stop-momentum-scroll.html

platform/ScrollSnapAnimatorState.cpp:

(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const): Enable directional scroll
snapping when handling momentum scrolling. This turns on scroll-snap-stop as well as a few other
features.

LayoutTests:

tiled-drawing/scrolling/scroll-snap/scroll-snap-stop-momentum-scroll-expected.txt: Added.
tiled-drawing/scrolling/scroll-snap/scroll-snap-stop-momentum-scroll.html: Added.

10:40 AM Changeset in webkit [274725] by Simon Fraser

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=223141
Runtime-disabled CSS features still still appear enabled via two-arg CSS.supports()

Address post-landing review comments from Darin.

css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

10:24 AM Changeset in webkit [274724] by weinig@apple.com

39 edits in trunk/Source

Add PropertyName parameter to custom setters to allow shared implementations to do late name lookup
https://bugs.webkit.org/show_bug.cgi?id=223413

Reviewed by Alexey Shvayka.

Source/JavaScriptCore:

Make custom setters match custom getters by adding a PropertyName parameter.

This will be used by the CSSStyleDeclaration bindings to avoid > 1000 copies
of the same getter/setter code, which will instead be able to differentiate
using the name.

bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

jsc.cpp:

(JSC_DEFINE_CUSTOM_SETTER):

runtime/CustomGetterSetter.cpp:

(JSC::callCustomSetter):

runtime/CustomGetterSetter.h:
runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

runtime/JSCustomSetterFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSCustomSetterFunction::JSCustomSetterFunction):
(JSC::JSCustomSetterFunction::create):

runtime/JSCustomSetterFunction.h:
runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

runtime/Lookup.h:

(JSC::putEntry):

runtime/PropertySlot.h:
runtime/RegExpConstructor.cpp:

(JSC::JSC_DEFINE_CUSTOM_SETTER):

runtime/RegExpObject.cpp:

(JSC::JSC_DEFINE_CUSTOM_SETTER):

tools/JSDollarVM.cpp:

Source/WebCore:

Update bindings to account for new PropertyName parameter being passed to custom setters.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterTrampolineDefinition):

bindings/scripts/test/JS/JSDOMWindow.cpp: