Timeline
Jun 20, 2021:
- 7:51 PM Changeset in webkit [279062] by
-
- 2 edits1 delete in trunk/Source/WTF
Replace Span implementation with one from libc++, which is more spec complient
https://bugs.webkit.org/show_bug.cgi?id=227197
Reviewed by Darin Adler.
- wtf/Span.h:
The tcb span implementation had some SFINAE issues when converting containers
had data() and size() member functions but were not span compatible that were
causing failures. Rather than trying to fix those, this adopts a modified version
of the libc++ span implementation which is more up-to-date.
To fix MSVC compile issues, the as_bytes/as_writable_bytes functions have been
re-implemented to not work around a compile issue seen where using the dynamic_extent
specicialization from the static extent specicialization was failing to compile.
- 6:19 PM Changeset in webkit [279061] by
-
- 4 edits in trunk/Source/WebCore
HitTestLocation::m_boundingBox should be able hold subpixel values
https://bugs.webkit.org/show_bug.cgi?id=227185
Reviewed by Sam Weinig.
This is in preparation for supporting non-integral area hi-testing (e.g. on 2x displays).
No functionality change yet.
- rendering/HitTestLocation.cpp:
(WebCore::rectForPoint):
- rendering/HitTestLocation.h:
(WebCore::HitTestLocation::boundingBox const):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
- 4:22 PM Changeset in webkit [279060] by
-
- 11 edits2 moves in trunk/Source
[macOS] Rename WKVisualSearchPreviewController to WKQuickLookPreviewController
https://bugs.webkit.org/show_bug.cgi?id=227193
Reviewed by Sam Weinig.
Source/WebCore/PAL:
Fix up some compiler flags in this SPI header. Instead of using
HAVE(VK_IMAGE_ANALYSIS)to guard SPI
declarations, use the newHAVE(QUICKLOOK_PREVIEW_ITEM_DATA_PROVIDER),HAVE(QUICKLOOK_ITEM_PREVIEW_OPTIONS)
andHAVE(QUICKLOOK_PREVIEW_ACTIVITY)flags.
- pal/spi/mac/QuickLookMacSPI.h:
Source/WebKit:
Rename WKVisualSearchPreviewController to WKQuickLookPreviewController, with the intention of using this logic
to implement a new context menu action for opening images in a QuickLook preview panel. See below for more
details.
- SourcesCocoa.txt:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::handleContextMenuLookUpImage): Deleted.
Move this into WebPageProxyMac.mm, since this is (1) only relevant to macOS, and (2) this logic now requires
WKQuickLookPreviewController.h, which WebPageProxyMac.mm already imports.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::acceptsPreviewPanelControl):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WKQuickLookPreviewController.h: Renamed from Source/WebKit/UIProcess/mac/WKVisualSearchPreviewController.h.
- UIProcess/mac/WKQuickLookPreviewController.mm: Renamed from Source/WebKit/UIProcess/mac/WKVisualSearchPreviewController.mm.
(-[WKQuickLookPreviewController initWithPage:imageData:title:imageURL:activity:]):
Add QuickLookPreviewActivity, a flag to indicate whether or not WKQuickLookPreviewController should
start with QLPreviewActivityVisualSearch or QLPreviewActivityNone. For the time being, we only use this helper
object for visual search, so we only pass in QuickLookPreviewActivity::VisualSearch.
(-[WKQuickLookPreviewController beginControl:]):
(-[WKQuickLookPreviewController endControl:]):
(-[WKQuickLookPreviewController closePanelIfNecessary]):
(-[WKQuickLookPreviewController isControlling:]):
(-[WKQuickLookPreviewController provideDataForItem:]):
(-[WKQuickLookPreviewController numberOfPreviewItemsInPreviewPanel:]):
(-[WKQuickLookPreviewController previewPanel:previewItemAtIndex:]):
(-[WKQuickLookPreviewController previewPanel:initialActivityForItem:]):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::beginPreviewPanelControl):
(WebKit::WebPageProxy::endPreviewPanelControl):
(WebKit::WebPageProxy::closeSharedPreviewPanelIfNecessary):
(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::showImageInQuickLookPreviewPanel):
(WebKit::WebPageProxy::showImageInVisualSearchPreviewPanel): Deleted.
- WebKit.xcodeproj/project.pbxproj:
Source/WTF:
Add some compile-time flags to guard QuickLook SPI declarations.
- wtf/PlatformHave.h:
- 2:31 PM Changeset in webkit [279059] by
-
- 7 edits in trunk/Source
[Live Text] Mouse events should only trigger text recognition if the cursor is moving
https://bugs.webkit.org/show_bug.cgi?id=227181
rdar://79469827
Reviewed by Tim Horton.
Source/WebCore:
Make a slight adjustment to how we trigger the text recognition timer when hovering over images; instead of
allowing any non-synthetic mouse event to kick off the timer, limit it to only mouse events with horizontal or
vertical movement deltas.
To implement this, we remove some
ENABLE(POINTER_LOCK)guards around PlatformMouseEvent's movement delta, and
check whether the movement delta is nonzero in EventHandler when determining whether to start the text
recognition timer.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
Check for a nonzero movement delta in place of the synthetic click type; since all synthetic mouse events are
created with no horizontal or vertical delta, since new movement delta check obviates the need for checking the
synthetic click type.
Additionally, we invert the conditional here so that if any mouse events are detected over content that is not
an image, we'll immediately stop the timer; however, if the mouse event is over an image, we'll only kick off
the timer if the movement delta is additionally nonzero.
- platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::globalPosition const):
(WebCore::PlatformMouseEvent::movementDelta const):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
Source/WebKit:
Populate the
deltaXanddeltaYmembers of the platform mouse event on iOS, when using a trackpad. This
allows the adjusted logic in EventHandler to apply to iPadOS when using a trackpad as well (see WebCore
ChangeLog for more information).
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
- UIProcess/ios/WKMouseGestureRecognizer.mm:
(-[WKMouseGestureRecognizer createMouseEventWithType:wasCancelled:]):
- 1:33 PM Changeset in webkit [279058] by
-
- 3 edits in trunk/Source/WTF
Adopt Span in SHA1.h
https://bugs.webkit.org/show_bug.cgi?id=227184
Reviewed by Chris Dumez.
Replaces overload of addBytes taking a Vector with ones taking
a Span and add overloads for Span<const std::byte> which all the
others are now implemented in terms of. This is useful since
any Span can be turned into one of type Span<const std::byte>
just by calling asBytes(existingSpan).
This leaves most of the existing overloads in place (though
simplifies them by implementing them as Span contructions),
though we should consider removing some in a separate pass.
- wtf/SHA1.cpp:
- wtf/SHA1.h:
- 12:46 PM Changeset in webkit [279057] by
-
- 5 edits in trunk/Source/WebCore
Move rectForPoint() static function out from the HitTestLocation class
https://bugs.webkit.org/show_bug.cgi?id=227182
Reviewed by Sam Weinig.
This function implicitly enlarges the hit test area which may trigger unexpected behavior.
It's better to not have it on the class's public interface.
- rendering/HitTestLocation.cpp:
(WebCore::rectForPoint):
(WebCore::HitTestLocation::rectForPoint): Deleted.
- rendering/HitTestLocation.h:
- rendering/LegacyEllipsisBox.cpp:
(WebCore::LegacyEllipsisBox::nodeAtPoint): While this may be a functionality change where we
replace the previously set area padding with 0 (actually 1px), I don't think that's what this is about.
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect const):
- 11:17 AM Changeset in webkit [279056] by
-
- 8 edits in trunk/Source/WebCore
Remove HitTestLocation(FloatPoint) c'tor
https://bugs.webkit.org/show_bug.cgi?id=227179
Reviewed by Sam Weinig.
FloatPoint are used to store pixed snapped coordinate values in the rendering code.
This is in preparation for supporting non-integral HitTestLocation intersect.
- rendering/HitTestLocation.cpp:
- rendering/HitTestLocation.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtFloatPoint):
- 10:31 AM Changeset in webkit [279055] by
-
- 11 edits in trunk
CSS counter style improvements for Armenian, Tamil, and some CJK styles
https://bugs.webkit.org/show_bug.cgi?id=227190
Reviewed by Sam Weinig.
Source/WebCore:
- css/CSSPrimitiveValueMappings.h: Added CJKDecimal and Tamil.
Also updated for name changes of Cjk to CJK.
- css/CSSValueKeywords.in: Added cjk-decimal and tamil.
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::isPredefinedCounterStyle):
Updated since the last predefined counter style is now Tamil.
- rendering/RenderListMarker.cpp: Tweak coding style a bit, using
constexpr and auto and removing some unneeded explicit type names.
(WebCore::effectiveListMarkerType): Added Tamil. Corrected range
for Armenian, LowerArmenian, and UpperArmenian to be 1-9999.
Added CJKDecimal. Updated for name changes of Cjk to CJK.
(WebCore::listMarkerSuffix): Addded Tamil. Corrected suffix for
multiple types to be ideographic comma instead of period.
(WebCore::suffixRequiresSpace): Added. Used so we don't add a space
after all suffixes.
(WebCore::listMarkerText): Added CJKDecimal and Tamil.
(WebCore::RenderListMarker::paint): Removed all the cases for the
many list style types that just paint as text, using default instead.
Call suffixRequiresSpace and don't add a space if not needed.
(WebCore::RenderListMarker::updateContent): Removed all the cases for
the many list style types that are text based, using default instead.
(WebCore::RenderListMarker::computePreferredLogicalWidths): Removed
all the cases for the many list style types that are text based, using
default instead. Call suffixRequiresSpace and don't include the space
if not needed.
(WebCore::RenderListMarker::suffix const): Call suffixRequiresSpace
and don't include a space if not needed.
(WebCore::RenderListMarker::getRelativeMarkerRect): Removed all the
cases for the many list style types that are text based, using default
instead. Call suffixRequiresSpace and don't include the space if not
needed.
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<): Added CJKDecimal and Tamil. Also sorted the
list styles alphabetically.
- rendering/style/RenderStyleConstants.h: Added CJKDecimal and
Tamil and use CJK instead of Cjk in names of the other styles.
LayoutTests:
- TestExpectations: Remove failure expectations for 26 tests.
- fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Expect 9999 limit instead
of 99999999 for Armenian, and success rather than failure for Tamil.
- fast/lists/w3-css3-list-styles-fallback-style.html: Ditto.
- 3:53 AM Changeset in webkit [279054] by
-
- 17 edits6 adds in trunk
Skip shadow-root creation for input element if it is not necessary
https://bugs.webkit.org/show_bug.cgi?id=227189
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/forms/checkbox-child-hidden.html
Cherry-pick Chromium optimizations[1,2] for input element and extend the coverage for more types.
Some of input element (e.g. checkbox) do not need to create a shadow-root since they do not have shadow-subtree.
This patch optimizes input element creation by skipping creation of shadow-root for these input types.
Since HTMLTextFormControlElement::childShouldCreateRenderer creates renderer only for children under shadow-root,
we do not need to consider about the case appending an element to checkbox etc. They will not get renderers.
We also replace HTMLInputElement related class' override with final if they are final to make class-hierarchy more explicit
and not to miss the change that needs to be done in the derived classes.
On M1 MBP, this patch improves Speedometer2 by 0.8%.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/773180
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/826426 (but this is not necessary in WebKit since HTMLTextFormControlElement::childShouldCreateRenderer does the right thing elegantly)
- dom/Element.cpp:
(WebCore::Element::ensureUserAgentShadowRoot):
(WebCore::Element::createUserAgentShadowRoot):
- dom/Element.h:
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/BaseDateAndTimeInputType.h:
(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/ColorInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType):
(WebCore::FileInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::create):
(WebCore::HTMLInputElement::createShadowSubtreeAndUpdateInnerTextElementEditability):
(WebCore::HTMLInputElement::updateType): It is possible that shadow root is already created for the previous InputType.
So we should use ensureUserAgentShadowRoot.
(WebCore::HTMLInputElement::initializeInputType): Since this is called at initialization time, we can use createUserAgentShadowRoot
instead of ensureUserAgentShadowRoot.
(WebCore::HTMLInputElement::didAddUserAgentShadowRoot): Deleted. Clean up the logic instead of relying on this callback.
Since HTMLInputElement can replace InputType, while we need to create shadow-subtree when InputType is replaced,
this callback could not be called since shadow-root is already created for the previous InputType. Not relying on this
callback makes the logic much simpler: explicitly create shadow-root and shadow-subtree.
- html/HTMLInputElement.h:
- html/InputType.h:
(WebCore::InputType::needsShadowSubtree const): Since this is in the critical path, we need this super optimized implementation.
Button, checkbox, hidden, image, radio, reset, and submit do not require shadow root.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::RangeInputType):
(WebCore::RangeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
LayoutTests:
- fast/forms/checkbox-and-pseudo-expected.txt: Added.
- fast/forms/checkbox-and-pseudo.html: Added.
- fast/forms/checkbox-child-hidden-expected.html: Added.
- fast/forms/checkbox-child-hidden.html: Added.
- 2:48 AM Changeset in webkit [279053] by
-
- 4 edits1 add in trunk
[JSC] Add ValueOf fast path in toPrimitive
https://bugs.webkit.org/show_bug.cgi?id=226948
Reviewed by Ross Kirsling.
JSTests:
- microbenchmarks/valueof-via-toprimitive.js: Added.
Source/JavaScriptCore:
Add fast path for Object.prototype.valueOf function call since we
sometimes encounter this case in Speedometer2/EmberJS-Debug-TodoMVC.
ToT Patched
value-of-call 65.7169+-0.6192 45.0986+-0.0830 definitely 1.4572x faster
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toStringSlowCase const):
- runtime/JSObject.cpp:
(JSC::callToPrimitiveFunction):
- 12:37 AM Changeset in webkit [279052] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix speculated type in the one-argument overload of speculateNeitherDoubleNorHeapBigIntNorString
https://bugs.webkit.org/show_bug.cgi?id=227119
Reviewed by Yusuke Suzuki.
Same problem as bug 226786: a missing check for HeapBigInt in the speculateNeitherDoubleNorHeapBigIntNorString function introduced in 226676.
I also rewrote the SpeculatedType for NeitherDoubleNorHeapBigIntNorString in typeFilterFor for readability. The old and the new SpeculatedType are perfectly identical, it is just a different (and in my view more readable) way of writing it.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateNeitherDoubleNorHeapBigIntNorString):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
Jun 19, 2021:
- 7:05 PM Changeset in webkit [279051] by
-
- 5 edits in trunk/Source/WTF
Adopt Span in Base64.h
https://bugs.webkit.org/show_bug.cgi?id=227132
Reviewed by Chris Dumez.
Replaces overloads taking Vectors with ones taking Spans
and add overloads for Span<const std::byte> which all the
others are now implemented in terms of. This is useful since
any Span can be turned into one of type Span<const std::byte>
just by calling asBytes(existingSpan).
This leaves most of the existing overloads in place (though
simplifies them by implementing them as Span contructions)
though we should consider removing some in a separate pass.
- wtf/Vector.h:
Add value_type typedef so that Vector<T> can be automatically
deduced as Span<T>.
- wtf/text/CString.h:
Add bytes() and bytesInludingNullTerminator() (only the former
is used in this patch, but the later will be needed shortly)
which return Span<const uint8_t> of the CString. I chose to use
an explicit function, rather than making it converible to Span
like Vector, because some callers will want the null terminator
and some will not.
- wtf/text/Base64.cpp:
- wtf/text/Base64.h:
Canonicalize all input buffers either as a Span<const std::byte> or
a StringView, making all the other overloads just forward to one of
those two (String -> StringView, everything else -> Span<const std::byte>).
Clean up the header a bit by putting all the declarations at the top of
the file.
- 1:31 PM Changeset in webkit [279050] by
-
- 40 edits in trunk
Fix CSS serialization issues affecting css-counter-styles tests
https://bugs.webkit.org/show_bug.cgi?id=226708
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-counter-styles/counter-style-additive-symbols-syntax-expected.txt:
- web-platform-tests/css/css-counter-styles/counter-style-symbols-syntax-expected.txt:
- web-platform-tests/css/css-syntax/url-whitespace-consumption-expected.txt:
Updated to reflect progressions.
Source/WebCore:
Fix two serialization isssues affecting css-counter-styles tests:
1) URLs were serializing the full resolved URL, rather than the
partial URL string from the style sheet.
2) Items in additive-symbols that had both an integer and a string
would incorrectly serialize with a comma within the item.
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::valueWithStylesResolved): Added.
Calls resolveImageStyles on the image values.
- css/CSSCrossfadeValue.h: Updated for the above.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::CSSCursorImageValue): Changed the hot spot
to use std::optional instead of a separate boolean.
(WebCore::CSSCursorImageValue::create): Moved this out of the header
because it's not better for inlining to have it there.
(WebCore::CSSCursorImageValue::customCSSText const): Updated for the
m_hotSpot changes.
(WebCore::CSSCursorImageValue::updateCursorElement): Removed unneeded
check of hasFragmentIdentifier, which is already done by the
SVGURIReference::targetElementFromIRIString function. Updated to use
m_originalSpecifiedURLString, and added a FIXME about the strange way
this just keeps accumulating more and more clients in a set, but did
not change that behavior.
(WebCore::CSSCursorImageValue::cursorElementRemoved): Added a FIXME.
(WebCore::CSSCursorImageValue::cursorElementChanged): Updated for the
change to m_hotSpot and addded some FIXME.
(WebCore::CSSCursorImageValue::equals const): Updated for the m_hotSpot
change; much simpler since std::optional does the right thing.
(WebCore::CSSCursorImageValue::valueWithStylesResolved): Added.
Calls resolveImageStyles on the image value.
- css/CSSCursorImageValue.h: Updated for the above changes.
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::valueWithStylesResolved): Added.
Calls resolveImageStyles on the image value and also calls
createFilterOperations.
- css/CSSFilterImageValue.h: Updated for the above.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::valueWithStylesResolved): Renamed from
gradientWithStylesResolved.
- css/CSSGradientValue.h: Updated for the above.
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::valueWithStylesResolved): Renamed from
imageSetWithStylesResolved. Optimized the case where the resolved
version is not different to re-use the original CSSImageSetValue.
- css/CSSImageSetValue.h: Updated for the above.
- css/CSSImageValue.cpp:
(WebCore::operator==): Added. Check if two ResolvedURL are equal.
(WebCore::makeResolvedURL): Added. Make a ResolvedURL from an
existing URL without the original specified string.
(WebCore::CSSImageValue::CSSImageValue): Take ResolvedURL instead
of a URL. Also updated to use std::optional instead of a separate
m_accessedImage boolean.
(WebCore::CSSImageValue::create): Added an overload that takes
ResolvedURL argument and also moved here from the header since we
don't get any benefit from inlining.
(WebCore::CSSImageValue::isPending const): Updates since m_cachedImage
is now a std::optional, and the std::nullopt case is used for this.
(WebCore::CSSImageValue::reresolvedURL const): Added. Used so we can
share code between the following functions.
(WebCore::CSSImageValue::valueWithStylesResolved): Added. Computes
the fully resolved URL and makes a new image value if needed that
always uses it. Also points the new value at the old one so we can
update m_cachedImage in both.
(WebCore::CSSImageValue::loadImage): Use the new reresolvedURL function.
Also update m_cachedImage in any underlying objects.
(WebCore::CSSImageValue::traverseSubresources): Updated for change
to m_cachedImage.
(WebCore::CSSImageValue::equals const): Updated for change to use
ResolvedURL.
(WebCore::CSSImageValue::customCSSText const): Ditto. This is the
only place where we use specifiedURLString.
(WebCore::CSSImageValue::createDeprecatedCSSOMWrapper const): Updated
for change from m_url.
(WebCore::CSSImageValue::knownToBeOpaque const): Updated for change
to m_cachedImage.
- css/CSSImageValue.h: Added ResolvedURL, new create
overloads. Replaced url() function with location() function, which
returns a string. Note that this always returns the resolved string,
only customCSSText returns the original string. Replaced m_url with
m_location, eliminated m_accessedImage and made m_cachedImage use
std::optional instead. Added m_unresolvedValue.
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::completeURL const): Deleted unused function.
- css/StyleSheetContents.h: Ditto.
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::completeURL const): Updated to return
ResolvedURL instead of a URL.
- css/parser/CSSParserContext.h: Ditto.
- css/parser/CSSParserIdioms.cpp:
(WebCore::completeURL): Deleted unused function.
- css/parser/CSSParserIdioms.h: Ditto.
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeCursor): Use std::optional for the hot spot.
(WebCore::consumeCounterStyleAdditiveSymbols): Put the integer/symbol
pair into a separate space-separated list instead of appending both
to the top level command-separated list. Also removed support for
non-standard "image without symbol" and "symbol without image".
Neither the specification nor the web platform tests currently call
for that.
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeImage): Call the new
overload of CSSImageValue::create, passing a ResolvedURL.
- css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI):
Update for the change to completeURL and refactor a bit. Later we could
make the same kind of fix for CSSFontFaceSrcValue that we did in this
patch for CSSImageValue, but did not try that for now.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCursor): Updated to take a std::optional for
the hot spot.
- rendering/style/RenderStyle.h: Ditto.
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageURL): Updated for CSSImageValue::imageURL.
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContent): Call
resolveImageStyles consistently.
- style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::resolveImageStyles): Call the new
valueWithStylesResolved function on all the different image value
types. This unifies the approach across all 6 classes.
(WebCore::Style::BuilderState::createStyleImage): Tweaked style.
LayoutTests:
- fast/css/parse-border-image-repeat-null-crash-expected.txt: Update to reflect correct
path; the path is not really relevant to what was being tested here either way.
- fast/css/uri-token-parsing-expected.txt: Updated to expect behavior that is sensible
and also matches Firefox.
- fast/css/uri-token-parsing.html: Ditto.
- fast/fast/css/url-with-multi-byte-unicode-escape-expected.txt: Updated to expect that
URL is still encoded as UTF-8, not yet re-URL-encoded as it will be for loading. The
one that will be used for loading can still be seen in computed style. The test still
covers correclty parsig this URL.
- fast/fast/css/url-with-multi-byte-unicode-escape.html: Ditto.
- fast/filter-image/parse-filter-image-expected.txt: Updated to no longer test addition
of trailing slashes to peculiar URLs that are made by using filenames as host names.
Now this checks URLs that just contain filenames, which makes more logical sense, and
no trailing slash addition is expected.
- fast/filter-image/parse-filter-image.html: Ditto.
- fast/innerHTML/innerHTML-uri-resolution.html: Updated test to use computed style so
it no longer depends on WebKit-only behavior to run correctly.
- 1:25 AM Changeset in webkit [279049] by
-
- 13 edits in trunk/Source/JavaScriptCore
[Revert r278576] Put the Baseline JIT prologue and op_loop_hint code in JIT thunks.
https://bugs.webkit.org/show_bug.cgi?id=226375
Not reviewed.
Suspect regresses Speedometer2.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::untagReturnAddress):
(JSC::AbstractMacroAssembler::untagReturnAddressWithoutExtraValidation): Deleted.
- assembler/MacroAssemblerARM64E.h:
(JSC::MacroAssemblerARM64E::untagReturnAddress):
(JSC::MacroAssemblerARM64E::untagReturnAddressWithoutExtraValidation): Deleted.
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::offsetOfInstructionsRawPointer):
(JSC::CodeBlock::offsetOfNumCalleeLocals): Deleted.
(JSC::CodeBlock::offsetOfNumVars): Deleted.
(JSC::CodeBlock::offsetOfArgumentValueProfiles): Deleted.
(JSC::CodeBlock::offsetOfShouldAlwaysBeInlined): Deleted.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveCalleeSavesForBaselineJIT): Deleted.
(JSC::AssemblyHelpers::emitRestoreCalleeSavesForBaselineJIT): Deleted.
- jit/JIT.cpp:
(JSC::JIT::compileAndLinkWithoutFinalizing):
(JSC::JIT::privateCompileExceptionHandlers):
(JSC::prologueGeneratorSelector): Deleted.
(JSC::JIT::prologueGenerator): Deleted.
(JSC::JIT::arityFixupPrologueGenerator): Deleted.
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::emitNakedNearCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::op_ret_handlerGenerator):
(JSC::JIT::emit_op_enter):
(JSC::JIT::op_enter_handlerGenerator):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::op_enter_Generator): Deleted.
(JSC::JIT::op_enter_canBeOptimized_Generator): Deleted.
(JSC::JIT::op_enter_cannotBeOptimized_Generator): Deleted.
(JSC::JIT::op_loop_hint_Generator): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
- jit/ThunkGenerators.cpp:
(JSC::popThunkStackPreservesAndHandleExceptionGenerator):
- 12:19 AM Changeset in webkit [279048] by
-
- 6 edits in trunk
Unreviewed, reverting r278699.
https://bugs.webkit.org/show_bug.cgi?id=227174
Regressed JetStream2/WSL
Reverted changeset:
"[JSC] Remove useDataICInOptimizingJIT option"
https://bugs.webkit.org/show_bug.cgi?id=226862
https://trac.webkit.org/changeset/278699
Jun 18, 2021:
- 7:16 PM Changeset in webkit [279047] by
-
- 9 edits in trunk
[WebIDL] Assigning a value outside the float range to a 'float' attribute should throw a TypeError
https://bugs.webkit.org/show_bug.cgi?id=227146
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now fully passing.
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-setposition-throws-expected.txt:
Source/WebCore:
Assigning a value outside the float range to a 'float' attribute should throw a TypeError, as per:
Blink follows the specification but WebKit was just casting the double to a float. This patch
addresses this issue.
This patch also makes sure that values outside the float range properly get resolved to -Infinity
or Infinity if the attribute is of type 'unrestricted float', as per:
No new tests, updated existing tests.
- bindings/js/JSDOMConvertNumbers.h:
(WebCore::Converter<IDLFloat>::convert):
(WebCore::Converter<IDLUnrestrictedFloat>::convert):
- testing/TypeConversions.h:
(WebCore::TypeConversions::testFloat const):
(WebCore::TypeConversions::setTestFloat):
(WebCore::TypeConversions::testUnrestrictedFloat const):
(WebCore::TypeConversions::setTestUnrestrictedFloat):
- testing/TypeConversions.idl:
LayoutTests:
Add layout test coverage.
- js/dom/webidl-type-mapping-expected.txt:
- js/dom/webidl-type-mapping.html:
- 1:41 PM Changeset in webkit [279046] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Add curl option CURLOPT_NOSIGNAL to omit numerous sigaction calls
https://bugs.webkit.org/show_bug.cgi?id=227118
Patch by Soujyu TANAKA <soujyu.tanaka@access-company.com> on 2021-06-18
Reviewed by Fujii Hironori.
As we increase file handles registered by curl_multi_add_handle(),
number of times of sigaction executions in Curl grows rapidly. That can
cause unignorable download speed drop.
With a curl option CURLOPT_NOSIGNAL enabled, Curl doesn't use the
syscall to ignore SIGPIPE signals. It's safe as long as we configure to
prevent SIGPIPE from being triggered.
No new tests.
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::CurlHandle):
- 1:36 PM Changeset in webkit [279045] by
-
- 2 edits in trunk/Source/WebKit
Clear state after process crash so that we know to re-issue sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=227103
<rdar://problem/77588760>
Reviewed by Tim Horton.
Follow-up patch that corrects a problem when switching between processes (for example, when
a provisional load moves to a committed load.) The parameters for the new process would fail
to pass the necessary sandbox extensions for the <attachment> element if they had been vended
to the provisional load. Instead, we should be checking if the new process has been given
the necessary extensions.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Use the new process, not the process state we are
copying from when deciding whether we need to extend sandbox powers to the new process.
- 12:44 PM Changeset in webkit [279044] by
-
- 7 edits in trunk
[css-logical] Fix cssom "set a CSS declaration" for logical properties
https://bugs.webkit.org/show_bug.cgi?id=226461
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
This test is now passing.
- web-platform-tests/css/cssom/cssstyledeclaration-setter-logical-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-setter-logical.html
Before this patch, setting a value to a property already in the list of
declarations, would just update its value, without reordering.
The problem was that the order is important when there is a mix of
logical and physical properties:
el.style.paddingTop = "1px";
el.style.paddingBlockStart = "2px";
el.style.cssText; "padding-top: 1px; padding-block-start: 2px"
el.style.paddingTop = "3px";
el.style.cssText; "padding-top: 3px; padding-block-start: 2px"
getComputedStyle(el).paddingTop; "2px" -- no effect!
Therefore, this patch implements this part of the spec:
If there are CSS declarations in declarations whose property name is
in the same logical property group as property, but has a different
mapping logic, target declaration must be at an index after all of
those CSS declarations.
This change is based on this Chromium CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2575081/
- css/CSSProperty.h:
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::canUpdateInPlace const):
(WebCore::MutableStyleProperties::setProperty):
- css/StyleProperties.h:
- css/makeprop.pl:
- 12:15 PM Changeset in webkit [279043] by
-
- 19 edits in trunk/Source
[iOS] Fullscreen video playback gets stuck after interacting with the playback controls
https://bugs.webkit.org/show_bug.cgi?id=227047
Reviewed by Eric Carlson.
When we scrub a playing video, the video element may enter a temporarily stalled
state - the player is still playing, but it does not have enough data. In WebKit,
therateof the player will be 0. But we cannot set the rate ofWebAVPlayerController
to 0 in this case, because AVKit will believe the video playback is paused when
its rate is 0. In r261587, we defined a magic rate (0.00000001f) for this case.
Unfortunately, with the changes in r275956,
WebAVPlayerControllerwill
align itsdefaultPlaybackRatewithratewhenrateis not 0. Under stress
tests, e.g., keep scrubbing a video, a video element will eventually enter a state
in which bothdefaultPlaybackRateandrateare the magic rate. And the video
appears to be stuck for users.
To fix the issue, this patch removes the magic rate and defines a new state:
stalled.
A video will be in the stalled state when it is playing but does not have enough data.
WebKit will only change the rate ofWebAVPlayerControllerwhen the video
is not stalled.
To avoid potential problems due to the conversions between "float" and "double"
back and forth, this patch updates the types ofplaybackRateanddefaultPlaybackRate.
Source/WebCore:
- platform/cocoa/PlaybackSessionModel.h:
(WebCore::PlaybackSessionModelClient::rateChanged):
- platform/cocoa/PlaybackSessionModelMediaElement.h:
- platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::updateForEventName):
(WebCore::PlaybackSessionModelMediaElement::setDefaultPlaybackRate):
(WebCore::PlaybackSessionModelMediaElement::setPlaybackRate):
(WebCore::PlaybackSessionModelMediaElement::defaultPlaybackRate const):
(WebCore::PlaybackSessionModelMediaElement::playbackRate const):
- platform/ios/PlaybackSessionInterfaceAVKit.h:
- platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::rateChanged):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::rateChanged):
(VideoFullscreenControllerContext::setDefaultPlaybackRate):
(VideoFullscreenControllerContext::setPlaybackRate):
(VideoFullscreenControllerContext::isStalled const):
(VideoFullscreenControllerContext::defaultPlaybackRate const):
(VideoFullscreenControllerContext::playbackRate const):
- platform/mac/PlaybackSessionInterfaceMac.h:
- platform/mac/PlaybackSessionInterfaceMac.mm:
(WebCore::PlaybackSessionInterfaceMac::rateChanged):
- platform/mac/VideoFullscreenInterfaceMac.h:
- platform/mac/VideoFullscreenInterfaceMac.mm:
(WebCore::VideoFullscreenInterfaceMac::rateChanged):
Source/WebKit:
- Scripts/webkit/messages.py:
(headers_for_type):
- UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
- UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
- UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::setDefaultPlaybackRate):
(WebKit::PlaybackSessionModelContext::setPlaybackRate):
(WebKit::PlaybackSessionModelContext::rateChanged):
(WebKit::PlaybackSessionManagerProxy::rateChanged):
(WebKit::PlaybackSessionManagerProxy::setDefaultPlaybackRate):
(WebKit::PlaybackSessionManagerProxy::setPlaybackRate):
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
- WebProcess/cocoa/PlaybackSessionManager.h:
- WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionInterfaceContext::rateChanged):
(WebKit::PlaybackSessionManager::rateChanged):
- 11:25 AM Changeset in webkit [279042] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add a new pattern to B3ReduceStrength based on Bug 226984
https://bugs.webkit.org/show_bug.cgi?id=227138
Patch by Yijia Huang <Yijia Huang> on 2021-06-18
Reviewed by Filip Pizlo.
In the previous patch bug 226984, a new pattern could be introduced to
B3ReduceStrength.cpp for further optimization, which is that:
dest = (src >> shiftAmount) & mask
is equivalent to
src >> shiftAmount
under these constraints:
- shiftAmount >= 0
- mask has a binary format in contiguous ones starting from the least significant bit.
- shiftAmount + bitCount(mask) == maxBitWidth
For instance (32-bit):
(src >> 12) & 0x000fffff == src >> 12
This reduction is more beneficial than UBFX in this case.
B3 IR
Int @0 = ArgumentReg(%0)
Int @1 = 12
Int @2 = ZShr(@0, @1)
Int @3 = 0x000fffff
Int @4 = BitAnd(@2, @3))
Void@5 = Return(@4, Terminal)
w/o the pattern:
Old optimized AIR
Ubfx %0, $12, $20, %0, @4
Ret %0, @5
w/ the pattern:
New optimized AIR
Urshift %0, $12, %0, @3
Ret32 %0, @6
- b3/B3ReduceStrength.cpp:
- b3/testb3.h:
- b3/testb3_2.cpp:
(testBitAndZeroShiftRightImmMask32):
(testBitAndZeroShiftRightImmMask64):
(addBitTests):
- 10:17 AM Changeset in webkit [279041] by
-
- 3 edits in trunk/Source/JavaScriptCore
[DFG] Untyped branches should eliminate checks based on results from the AbstractInterpreter
https://bugs.webkit.org/show_bug.cgi?id=227159
Reviewed by Filip Pizlo.
We currently emit a ton of code for Untyped branches, as we use branchIfTruthy which does not know anything about the abstract interpreter.
Even worse: we call branchIfTruthy after emitting some fast paths, and branchIfTruthy replicates these fast paths (Int32 and Booleans).
While I plan to reduce the number of Untyped branches in some separate patches, there is a very long tail of predicted types visible in benchmarks, so I expect some of them to remain no matter what, justifying making the code emitted in that case more reasonable.
The implementation in this patch is fairly straightforward, as it follows very closely branchOnValue() from AssemblyHelpers (which was previously called through branchIfTruthy).
It was tested on the JSC stress tests, as well as on JetStream2.
On JetStream2, it reduced the average number of bytes emitted for Branch by the DFG from 30.1 to 27.5 (highly significant, it only changes by about 0.1 between runs).
Since only about 1.5k branches are untyped out of 34k in that benchmark, it means that this patch reduces the amount of code emitted for untyped branches by about 50 bytes on average.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::branchDoubleZeroOrNaN):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitUntypedBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
- 10:10 AM WebKitGTK/2.32.x edited by
- (diff)
- 9:45 AM Changeset in webkit [279040] by
-
- 2 edits in trunk/LayoutTests
[iOS 14-Simulator WK2] editing/deleting/smart-delete-paragraph-004.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=226906
Unreviewed test gardening.
- platform/ios/TestExpectations: Mark test as flaky.
- 9:21 AM Changeset in webkit [279039] by
-
- 4 edits in trunk
[MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419
Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-18
Reviewed by Michael Catanzaro.
Source/WebCore:
When MSE is used the player receives broken audio fragments, perhaps because the server
expects the client to repair them. Not much we can do about this on GStreamer side though,
so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): Add a test for the soundcloud quirk.
- 9:13 AM Changeset in webkit [279038] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=227168
Updated glib baseline/expectations.
Patch by Eleni Maria Stea <hikiko> on 2021-06-18
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Removed.
- 7:58 AM WebKitGTK/2.32.x edited by
- (diff)
- 7:01 AM Changeset in webkit [279037] by
-
- 5 edits2 moves in trunk/Source/WebKit
[WPE] Rework touch-based gesture controller
https://bugs.webkit.org/show_bug.cgi?id=226456
Patch by Zan Dobersek <zdobersek@igalia.com> on 2021-06-18
Reviewed by Alejandro G. Castro.
Rename WPE's ScrollGestureController to TouchGestureController since now
it also handles production of touch-based click events.
TouchGestureController now internally manages all the related state,
tracking the touch interaction and determining whether it progresses
into a scrolling gesture or whether, upon finishing, it should be
translated into a simple click event.
In PageClientImpl, any unhandled event is pushed into
TouchGestureController and a variant of different outcomes is returned.
No-event result is ignored, and click or axis events are dispatched as
appropriate.
In WPEView, where the touch events arrive into the engine, we keep the
shortcut where touch events are piped directly into the controller if
said controller is already gesturing scrolling behavior. In that case
the touch events are not dispatched into the engine, with the exception
of touch-up events which are, to provide matching closure for the
touch-down events.
- SourcesWPE.txt:
- UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::doneWithTouchEvent):
- UIProcess/API/wpe/TouchGestureController.cpp: Renamed from Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp.
(WebKit::TouchGestureController::handleEvent):
- UIProcess/API/wpe/TouchGestureController.h: Renamed from Source/WebKit/UIProcess/API/wpe/ScrollGestureController.h.
(WebKit::TouchGestureController::gesturedEvent const):
- UIProcess/API/wpe/WPEView.cpp:
(WKWPE::View::View):
(WKWPE::m_backend):
- UIProcess/API/wpe/WPEView.h:
(WKWPE::View::touchGestureController const):
(WKWPE::View::scrollGestureController const): Deleted.
- 6:37 AM Changeset in webkit [279036] by
-
- 2 edits in trunk/Source/WebCore
[LFC][WPE] Build failure with GCC 8.x
https://bugs.webkit.org/show_bug.cgi?id=227166
Reviewed by Alan Bujtas.
The build fails with the error: converting to 'std::in_place_t' from initializer list
would use explicit constructor 'constexpr std::in_place_t::in_place_t()'
No new tests, is a build fix.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::prepareLayoutState):
- 3:58 AM Changeset in webkit [279035] by
-
- 2 edits in trunk
Ignore clangd's directory with index files
https://bugs.webkit.org/show_bug.cgi?id=227162
Reviewed by Žan Doberšek.
clangd stores its indexes in a .cache directory. Let git ignore it.
- .gitignore:
- 3:35 AM Changeset in webkit [279034] by
-
- 4 edits2 adds in trunk
[GStreamer] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html is failing since r273645
https://bugs.webkit.org/show_bug.cgi?id=223508
Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-18
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Per spec, prevent seeks, playback rate changes and preload state updates on media elements backed by
the GStreamer MediaStream source element.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setPreload):
(WebCore::MediaPlayerPrivateGStreamer::maxMediaTimeSeekable const):
LayoutTests:
Unflag and add glib baseline for test now passing.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt: Added.
- 1:37 AM WebKitGTK/2.32.x edited by
- (diff)
- 1:29 AM Changeset in webkit [279033] by
-
- 4 edits in trunk
[WebRTC][GStreamer] fast/mediastream/MediaStream-video-element-remove-track.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191886
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Trigger source pad removal in the mediastream source element when a track has been removed.
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebKitMediaStreamObserver::didRemoveTrack):
LayoutTests:
- platform/glib/TestExpectations: Unflag test now passing.
- 1:05 AM Changeset in webkit [279032] by
-
- 6 edits in trunk
[SOUP] Add Timing-Allow-Origin checks to NetworkDataTaskSoup
https://bugs.webkit.org/show_bug.cgi?id=227008
<rdar://problem/79384792>
Reviewed by Adrian Perez de Castro.
Source/WebKit:
Add missing TAO checks to Soup backend.
- NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create):
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
- NetworkProcess/soup/NetworkDataTaskSoup.h:
LayoutTests:
- platform/glib/TestExpectations:
Jun 17, 2021:
- 10:35 PM Changeset in webkit [279031] by
-
- 55 edits10 copies9 moves27 adds in trunk/LayoutTests
[GTK][WPE] Unreviewed test gardening. Update baselines after r278974.
There are GTK and WPE tests that have the same text baseline but the
corresponding PNG image is different. In this case, I have preferred
to keep a specific text baseline for each port, instead of
promoting the text baseline to GLIB.
- platform/gtk/svg/text/foreignObject-repaint-expected.txt: Copied from LayoutTests/platform/glib/svg/text/foreignObject-repaint-expected.txt.
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
- platform/gtk/svg/text/text-align-01-b-expected.png:
- platform/gtk/svg/text/text-align-01-b-expected.txt:
- platform/gtk/svg/text/text-align-02-b-expected.png:
- platform/gtk/svg/text/text-align-02-b-expected.txt:
- platform/gtk/svg/text/text-align-03-b-expected.png:
- platform/gtk/svg/text/text-align-03-b-expected.txt:
- platform/gtk/svg/text/text-align-04-b-expected.png:
- platform/gtk/svg/text/text-align-04-b-expected.txt:
- platform/gtk/svg/text/text-align-05-b-expected.png:
- platform/gtk/svg/text/text-align-05-b-expected.txt:
- platform/gtk/svg/text/text-align-06-b-expected.png:
- platform/gtk/svg/text/text-align-06-b-expected.txt:
- platform/gtk/svg/text/text-deco-01-b-expected.png:
- platform/gtk/svg/text/text-deco-01-b-expected.txt:
- platform/gtk/svg/text/text-fonts-01-t-expected.png:
- platform/gtk/svg/text/text-fonts-01-t-expected.txt:
- platform/gtk/svg/text/text-fonts-02-t-expected.png:
- platform/gtk/svg/text/text-fonts-02-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-fonts-02-t-expected.txt.
- platform/gtk/svg/text/text-intro-05-t-expected.png:
- platform/gtk/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-intro-05-t-expected.txt.
- platform/gtk/svg/text/text-path-01-b-expected.png:
- platform/gtk/svg/text/text-path-01-b-expected.txt:
- platform/gtk/svg/text/text-spacing-01-b-expected.png:
- platform/gtk/svg/text/text-spacing-01-b-expected.txt:
- platform/gtk/svg/text/text-text-01-b-expected.png:
- platform/gtk/svg/text/text-text-01-b-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-01-b-expected.txt.
- platform/gtk/svg/text/text-text-03-b-expected.png:
- platform/gtk/svg/text/text-text-03-b-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-03-b-expected.txt.
- platform/gtk/svg/text/text-text-05-t-expected.png:
- platform/gtk/svg/text/text-text-05-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-text-05-t-expected.txt.
- platform/gtk/svg/text/text-text-07-t-expected.png:
- platform/gtk/svg/text/text-text-07-t-expected.txt:
- platform/gtk/svg/text/text-text-08-b-expected.png:
- platform/gtk/svg/text/text-text-08-b-expected.txt:
- platform/gtk/svg/text/text-tref-01-b-expected.png:
- platform/gtk/svg/text/text-tref-01-b-expected.txt:
- platform/gtk/svg/text/text-tselect-01-b-expected.png:
- platform/gtk/svg/text/text-tselect-01-b-expected.txt:
- platform/gtk/svg/text/text-tspan-01-b-expected.png:
- platform/gtk/svg/text/text-tspan-01-b-expected.txt:
- platform/gtk/svg/text/text-ws-01-t-expected.png:
- platform/gtk/svg/text/text-ws-01-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-ws-01-t-expected.txt.
- platform/gtk/svg/text/text-ws-02-t-expected.png:
- platform/gtk/svg/text/text-ws-02-t-expected.txt: Copied from LayoutTests/platform/glib/svg/text/text-ws-02-t-expected.txt.
- platform/gtk/svg/text/textPathBoundsBug-expected.txt: Copied from LayoutTests/platform/glib/svg/text/textPathBoundsBug-expected.txt.
- platform/wpe/svg/text/foreignObject-repaint-expected.png: Added.
- platform/wpe/svg/text/foreignObject-repaint-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/foreignObject-repaint-expected.txt.
- platform/wpe/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
- platform/wpe/svg/text/foreignObject-text-clipping-bug-expected.txt:
- platform/wpe/svg/text/text-align-01-b-expected.png: Added.
- platform/wpe/svg/text/text-align-01-b-expected.txt:
- platform/wpe/svg/text/text-align-02-b-expected.png: Added.
- platform/wpe/svg/text/text-align-02-b-expected.txt:
- platform/wpe/svg/text/text-align-03-b-expected.png: Added.
- platform/wpe/svg/text/text-align-03-b-expected.txt:
- platform/wpe/svg/text/text-align-04-b-expected.png: Added.
- platform/wpe/svg/text/text-align-04-b-expected.txt:
- platform/wpe/svg/text/text-align-05-b-expected.png: Added.
- platform/wpe/svg/text/text-align-05-b-expected.txt:
- platform/wpe/svg/text/text-align-06-b-expected.png: Added.
- platform/wpe/svg/text/text-align-06-b-expected.txt:
- platform/wpe/svg/text/text-deco-01-b-expected.png: Added.
- platform/wpe/svg/text/text-deco-01-b-expected.txt:
- platform/wpe/svg/text/text-fonts-01-t-expected.png: Added.
- platform/wpe/svg/text/text-fonts-01-t-expected.txt:
- platform/wpe/svg/text/text-fonts-02-t-expected.png: Added.
- platform/wpe/svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-fonts-02-t-expected.txt.
- platform/wpe/svg/text/text-intro-05-t-expected.png: Added.
- platform/wpe/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-intro-05-t-expected.txt.
- platform/wpe/svg/text/text-path-01-b-expected.png: Added.
- platform/wpe/svg/text/text-path-01-b-expected.txt:
- platform/wpe/svg/text/text-spacing-01-b-expected.png: Added.
- platform/wpe/svg/text/text-spacing-01-b-expected.txt:
- platform/wpe/svg/text/text-text-01-b-expected.png: Added.
- platform/wpe/svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-01-b-expected.txt.
- platform/wpe/svg/text/text-text-03-b-expected.png: Added.
- platform/wpe/svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-03-b-expected.txt.
- platform/wpe/svg/text/text-text-05-t-expected.png: Added.
- platform/wpe/svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-text-05-t-expected.txt.
- platform/wpe/svg/text/text-text-07-t-expected.png: Added.
- platform/wpe/svg/text/text-text-07-t-expected.txt:
- platform/wpe/svg/text/text-text-08-b-expected.png: Added.
- platform/wpe/svg/text/text-text-08-b-expected.txt:
- platform/wpe/svg/text/text-tref-01-b-expected.png: Added.
- platform/wpe/svg/text/text-tref-01-b-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-tref-01-b-expected.txt.
- platform/wpe/svg/text/text-tselect-01-b-expected.png: Added.
- platform/wpe/svg/text/text-tselect-01-b-expected.txt:
- platform/wpe/svg/text/text-tspan-01-b-expected.png: Added.
- platform/wpe/svg/text/text-tspan-01-b-expected.txt:
- platform/wpe/svg/text/text-ws-01-t-expected.png: Added.
- platform/wpe/svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-ws-01-t-expected.txt.
- platform/wpe/svg/text/text-ws-02-t-expected.png: Added.
- platform/wpe/svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/text-ws-02-t-expected.txt.
- platform/wpe/svg/text/textPathBoundsBug-expected.png: Added.
- platform/wpe/svg/text/textPathBoundsBug-expected.txt: Renamed from LayoutTests/platform/glib/svg/text/textPathBoundsBug-expected.txt.
- platform/wpe/tables/mozilla/bugs/bug106795-expected.png: Added.
- platform/wpe/tables/mozilla/bugs/bug82946-2-expected.png: Added.
- 9:09 PM Changeset in webkit [279030] by
-
- 20 edits4 adds in trunk
[Cocoa] Disable hardware decoding in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=226869
<rdar://77548905>
Reviewed by Per Arne Vollan and Simon Fraser.
Source/WebCore:
Pass kCGImageSourceEnableRestrictedDecoding : kCFBooleanTrue when decoding
an image frame.
Test: fast/images/heic-as-background-image.html
- platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::createImageSourceOptions):
Source/WebCore/PAL:
SoftLink
- VTRestrictVideoDecoders from VideoToolbox
- FigPhotoSupportsHEVCHWDecode from MediaToobox
- PAL.xcodeproj/project.pbxproj:
- pal/cf/VideoToolboxSoftLink.cpp:
- pal/cf/VideoToolboxSoftLink.h:
- pal/cocoa/MediaToolboxSoftLink.cpp:
- pal/cocoa/MediaToolboxSoftLink.h:
- pal/spi/cg/ImageIOSPI.h:
- pal/spi/cocoa/VideoToolboxSPI.h: Added.
Source/WebKit:
Restrict video decoders and disable hardware image decoders.
A temp extension is created for the service "com.apple.trustd.agent" to
allow temporarily calling FigPhotoSupportsHEVCHWDecode(). This function
needs access this service but we have recently closed access to it.
FigPhotoSupportsHEVCHWDecode() sets a local static variable by using the
service "com.apple.trustd.agent" when it is called for the first time.
Our purpose of calling it in this context is to initialize the static
variable only. And this is why we do not use its return value.
This solution is fragile. If MediaToolbox is changed such that it needs
'com.apple.trustd.agent' while decoding an image, the decoding will fail.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::restrictImageAndVideoDecoders):
(WebKit::WebProcess::initializeSandbox):
Source/WTF:
Add have macros for using:
- kCGImageSourceEnableRestrictedDecoding
- VTRestrictVideoDecoders()
- wtf/PlatformHave.h:
LayoutTests:
Add a reference test for rendering the HEIF images.
- TestExpectations:
- fast/images/heic-as-background-image-expected.html: Added.
- fast/images/heic-as-background-image.html: Added.
- fast/images/resources/green-400x400.heic: Added.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 7:06 PM Changeset in webkit [279029] by
-
- 7 edits in trunk/Source
Rename numberOfPACBits to maxNumberOfAllowedPACBits.
https://bugs.webkit.org/show_bug.cgi?id=227156
Reviewed by Saam Barati.
Source/JavaScriptCore:
Just renaming the constant to better describe what it represents. There are no
behavior changes.
- assembler/MacroAssemblerARM64E.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::cageWithoutUntagging):
(JSC::AssemblyHelpers::cageConditionallyAndUntag):
- llint/LowLevelInterpreter64.asm:
Source/WTF:
- wtf/CagedPtr.h:
- 6:44 PM Changeset in webkit [279028] by
-
- 20 edits in trunk
Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).
https://bugs.webkit.org/show_bug.cgi?id=227147
rdar://78785309
Reviewed by Saam Barati.
Source/bmalloc:
For OS(DARWIN), define BOS_EFFECTIVE_ADDRESS_WIDTH in terms of MACH_VM_MAX_ADDRESS,
which is provided by the SDK. This ensures that it is correct for each target
OS(DARWIN) platform.
- bmalloc/Algorithm.h:
(bmalloc::clzConstexpr):
(bmalloc::getMSBSetConstexpr):
- bmalloc/BPlatform.h:
- bmalloc/Gigacage.h:
- bmalloc/ObjectTypeTable.h:
- bmalloc/Packed.h:
Source/JavaScriptCore:
- assembler/MacroAssemblerARM64E.h:
- bytecode/CodeOrigin.h:
- runtime/JSString.h:
- runtime/OptionsList.h:
Source/WTF:
For OS(DARWIN), define OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) in terms of
MACH_VM_MAX_ADDRESS, which is provided by the SDK. This ensures that it is
correct for each target OS(DARWIN) platform.
Also update an assertion in WTFAssertions.cpp to verify that address bits are
less than 48. The purpose of this assertion is to ensure that our 64-bit NaN
boxing encoding for JSValues will work. Hence, we should use the encoding limit
for pointers of 48 bits. It no longer makes sense to assert based on
OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH), because OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)
is defined in terms of MACH_VM_MAX_ADDRESS.
- wtf/CagedPtr.h:
- wtf/CompactPointerTuple.h:
- wtf/PlatformOS.h:
- wtf/WTFAssertions.cpp:
- wtf/threads/Signals.cpp:
Tools:
- TestWebKitAPI/Tests/WTF/Packed.cpp:
- 6:27 PM Changeset in webkit [279027] by
-
- 4 edits in trunk
[Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
https://bugs.webkit.org/show_bug.cgi?id=227090
Reviewed by Yusuke Suzuki.
Source/WTF:
ArithmeticOperations::sub unexpectedly reported an overflow for
the result of std::numeric_limits<ResultType>::min() in MSVC code path.
For example, Checked<int, RecordOverflow>(INT_MIN + 1) - 1 was reported an overflow.
In the case of calculating (lhs - rhs), and lhs < 0 and rhs > 0,
the original code reported an overflow if (rhs > max() + lhs).
Mathematically, this condition checks (lhs - rhs < -max()).
It should use min() instead of max() in this case. It should be
(lhs - rhs < min()) mathematically.
- wtf/CheckedArithmetic.h:
Tools:
- TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI::AllowMixedSignednessTest::run):
- 5:26 PM Changeset in webkit [279026] by
-
- 7 edits in trunk
Add support for IDBCursor.request
https://bugs.webkit.org/show_bug.cgi?id=227152
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline some WPT tests now that they are passing.
- web-platform-tests/IndexedDB/idbcursor-request.any-expected.txt:
- web-platform-tests/IndexedDB/idbcursor-request.any.worker-expected.txt:
- web-platform-tests/IndexedDB/idlharness.any-expected.txt:
- web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:
Source/WebCore:
Add support for IDBCursor.request:
Both Blink and Gecko already support this.
No new tests, rebaselined existing tests.
- Modules/indexeddb/IDBCursor.idl:
- 5:00 PM Changeset in webkit [279025] by
-
- 2 edits in trunk/Source/WTF
Add assertion in RunLoop::dispatch
https://bugs.webkit.org/show_bug.cgi?id=227154
<rdar://79243769>
Reviewed by Geoff Garen.
This should help us find what is scheduling null functions.
- wtf/RunLoop.cpp:
(WTF::RunLoop::dispatch):
(WTF::RunLoop::dispatchAfter):
- 4:39 PM Changeset in webkit [279024] by
-
- 2 edits in trunk/LayoutTests
Skip WebXR tests on iOS
https://bugs.webkit.org/show_bug.cgi?id=227151
Patch by Ada Chan <ada.chan@apple.com> on 2021-06-17
Reviewed by Tim Horton.
- platform/ios/TestExpectations:
- 4:21 PM Changeset in webkit [279023] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
Unreviewed, reverting r279011.
https://bugs.webkit.org/show_bug.cgi?id=227153
broke ios build
Reverted changeset:
"[Mac] libwebrtc CMBaseClass objects need alignment fixup"
https://bugs.webkit.org/show_bug.cgi?id=227137
https://trac.webkit.org/changeset/279011
- 4:02 PM Changeset in webkit [279022] by
-
- 5 edits in branches/safari-611-branch/Source/WebKit
Apply patch. rdar://problem/79474174
- 3:59 PM Changeset in webkit [279021] by
-
- 3 edits in branches/safari-611-branch/Source/ThirdParty/libwebrtc
Cherry-pick r279011. rdar://problem/79474211
[Mac] libwebrtc CMBaseClass objects need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=227137
Reviewed by Youenn Fablet.
- Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp: (webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64 so function pointers are naturally aligned. Add static_asserts to ensure alignment and sizes are correct.
- Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp: (webrtc::createWebKitVP9Decoder): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:59 PM Changeset in webkit [279020] by
-
- 2 edits in branches/safari-611-branch/Source/WebCore
Cherry-pick r278975. rdar://problem/79474077
Make FontFaceSet::Iterator's bounds check more robust
https://bugs.webkit.org/show_bug.cgi?id=227048
<rdar://problem/78871890>
Reviewed by Simon Fraser.
We were checking for one specific bad value, when we should have been checking for all bad values.
- css/FontFaceSet.cpp: (WebCore::FontFaceSet::Iterator::next):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:59 PM Changeset in webkit [279019] by
-
- 4 edits in branches/safari-611-branch/Source
Cherry-pick r278870. rdar://problem/79473993
[Mac] CoreMedia WrapperClass does not need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=226978
rdar://78864290
Reviewed by Geoffrey Garen and Dan Bernstein.
Source/WebCore:
- platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::enqueueSample): static_assert CMBufferQueueRef callback struct alignment and version size.
Source/WebKit:
- Shared/mac/MediaFormatReader/CoreMediaWrapped.h: (WebKit::CoreMediaWrapped<Wrapped>::vTable): Don't add padding to WrapperClass, it isn't necessary. static_assert CMBaseClass and WrapperClass alignment and .version sizes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:46 PM Changeset in webkit [279018] by
-
- 8 edits in branches/safari-611-branch/Source
Versioning.
WebKit-7611.3.9
- 3:40 PM Changeset in webkit [279017] by
-
- 10 edits in trunk/Source
Enable some more release logging in for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=227142
Reviewed by Eric Carlson.
Enable some more release logging in for ephemeral sessions, to faciliate debugging.
Source/WebCore:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::SWServer):
Source/WebKit:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::isAlwaysOnLoggingAllowed const): Deleted.
- GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::sessionID const):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::logger):
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::insertObservedDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::relationshipExists const):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainID const):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
(WebKit::ResourceLoadStatisticsDatabaseStore::populateFromMemoryStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistic):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistics):
(WebKit::ResourceLoadStatisticsDatabaseStore::incrementRecordsDeletedCountForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::grandfatherDataForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensurePrevalentResourcesForDebugMode):
(WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsDatabaseStore::logCrossSiteLoadWithLinkDecoration):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearTopFrameUniqueRedirectsToSinceSameSiteStrictEnforcement):
(WebKit::ResourceLoadStatisticsDatabaseStore::setUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::setPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setDomainsAsPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::predicateValueForDomain const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setGrandfathered):
(WebKit::ResourceLoadStatisticsDatabaseStore::setIsScheduledForAllButCookieDataRemoval):
(WebKit::ResourceLoadStatisticsDatabaseStore::getMostRecentlyUpdatedTimestamp const):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubframeUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensureResourceStatisticsForRegistrableDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::removeDataForDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasUserGrantedStorageAccessThroughPrompt):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearGrandfathering):
(WebKit::ResourceLoadStatisticsDatabaseStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setVeryPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateDataRecordsRemoved):
(WebKit::ResourceLoadStatisticsDatabaseStore::isCorrectSubStatisticsCount):
(WebKit::ResourceLoadStatisticsDatabaseStore::getDomainStringFromDomainID const):
(WebKit::ResourceLoadStatisticsDatabaseStore::appendSubStatisticList const):
(WebKit::ResourceLoadStatisticsDatabaseStore::resourceToString const):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainIDExistsInDatabase):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):
(WebKit::ResourceLoadStatisticsDatabaseStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):
(WebKit::ResourceLoadStatisticsDatabaseStore::findPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAllUnattributedPrivateClickMeasurementAsExpiredForTesting):
(WebKit::ResourceLoadStatisticsDatabaseStore::removeUnattributed):
(WebKit::ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearExpiredPrivateClickMeasurement):
(WebKit::ResourceLoadStatisticsDatabaseStore::privateClickMeasurementToString):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearSentAttribution):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAttributedPrivateClickMeasurementsAsExpiredForTesting):
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getNetworkProcessConnection):
- WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:
(WebKit::WebURLSchemeTaskProxy::startLoading):
(WebKit::WebURLSchemeTaskProxy::stopLoading):
(WebKit::WebURLSchemeTaskProxy::didPerformRedirection):
(WebKit::WebURLSchemeTaskProxy::didReceiveResponse):
(WebKit::WebURLSchemeTaskProxy::didReceiveData):
(WebKit::WebURLSchemeTaskProxy::didComplete):
- 3:35 PM Changeset in webkit [279016] by
-
- 3 edits2 adds in trunk
[Metal ANGLE] Shaders with reserved metal keywords do not translate, nor do shaders with struct and variable names that are the same except prefixed by an underscore
https://bugs.webkit.org/show_bug.cgi?id=226660
Source/ThirdParty/ANGLE:
Fix keyword translation problem by correcting symbol space. This avoids renaming structs unnecessarily
Reviewed by Dean Jackson.
- src/compiler/translator/TranslatorMetalDirect/RewriteKeywords.cpp:
(sh::Rewriter::createRenamed):
LayoutTests:
Reviewed by Dean Jackson.
- fast/canvas/webgl/shader-with-reserved-keyword-expected.txt: Added.
- fast/canvas/webgl/shader-with-reserved-keyword.html: Added.
- 3:20 PM Changeset in webkit [279015] by
-
- 30 edits2 copies3 moves26 adds1 delete in trunk/LayoutTests
Resync DOM WPT tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=227144
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Resync DOM WPT tests from upstream ec5c1fc86b65142e7b.
- resources/resource-files.json:
- web-platform-tests/dom/*: Updated.
- web-platform-tests/interfaces/dom.idl:
LayoutTests:
- TestExpectations:
- tests-options.json:
- 3:14 PM Changeset in webkit [279014] by
-
- 2 edits in trunk/Source/WebKit
Clear state after process crash so that we know to re-issue sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=227103
<rdar://problem/77588760>
Reviewed by Per Arne Vollan.
We dynamically extend access to certain mach services when the ATTACHMENT_ELEMENT feature
is enabled. If a process with this feature activated crashes and WebKit relaunches it, we
don't grant the new process the same extensions because we believe they were already
previously sent.
This patch clears the state after a process crash so that it properly handles the restart case.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shutDown): Clear state.
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch): Clear state.
- 3:12 PM Changeset in webkit [279013] by
-
- 2 edits in trunk/JSTests
Make microbenchmarks/delete-property-from-prototype-chain not time out on debug builds
https://bugs.webkit.org/show_bug.cgi?id=227148
Reviewed by Mark Lam.
- microbenchmarks/delete-property-from-prototype-chain.js:
- 3:03 PM Changeset in webkit [279012] by
-
- 5 edits2 moves1 add in trunk/Tools
[resultsdbpy] Adopt autoinstaller
https://bugs.webkit.org/show_bug.cgi?id=227096
<rdar://problem/79418080>
Rubber-stamped by Aakash Jain.
- Scripts/libraries/resultsdbpy/container: Moved from insdie library.
- Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Register required libraries.
- Scripts/libraries/resultsdbpy/resultsdbpy/container: Moved to containing folder.
- Scripts/libraries/resultsdbpy/resultsdbpy/example/main.py:
- Scripts/libraries/resultsdbpy/resultsdbpy/run: Moved to containing folder.
- Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Use specific imports
- Scripts/libraries/resultsdbpy/run: Moved from insdie library.
- Scripts/libraries/resultsdbpy/run-tests: Use autoinstalled libraries.
- Scripts/libraries/resultsdbpy/setup.py: Bump version.
- 3:01 PM Changeset in webkit [279011] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
[Mac] libwebrtc CMBaseClass objects need alignment fixup
https://bugs.webkit.org/show_bug.cgi?id=227137
Reviewed by Youenn Fablet.
- Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
(webrtc::createWebKitVP8Decoder): Add padding to the CMBaseClass object on x86_64
so function pointers are naturally aligned. Add static_asserts to ensure alignment
and sizes are correct.
- Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
(webrtc::createWebKitVP9Decoder): Ditto.
- 2:55 PM Changeset in webkit [279010] by
-
- 5 edits2 adds in trunk
Crash in WebCore::SlotAssignment::assignedNodesForSlot
https://bugs.webkit.org/show_bug.cgi?id=224408
<rdar://problem/76805764>
Reviewed by Michael Catanzaro.
Source/WebCore:
Like webkit.org/b/225684, the release assertion failure was caused by RenderTreeUpdater::tearDownRenderers
traversing the slot element for which we're currently calling Element::insertedIntoAncestor but had not yet
called SlotAssignment::addSlotElementByName.
Fixed the bug by returning early in SlotAssignment::assignedNodesForSlot when this condition holds,
which is when the shadow root is connected to a document and HTMLSlotElement is in the middle of
HTMLSlotElement::insertedIntoAncestor.
It's not the most elegant solution but staying safe for now.
Test: fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash.html
- dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::assignedNodesForSlot):
- html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::insertedIntoAncestor):
- html/HTMLSlotElement.h:
(WebCore::HTMLSlotElement::isInInsertedIntoAncestor): Added.
LayoutTests:
Added a regression test.
- fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash-expected.txt: Added.
- fast/shadow-dom/insert-slot-child-of-shadow-host-render-tree-invalidation-crash.html: Added.
- 2:27 PM Changeset in webkit [279009] by
-
- 4 edits in trunk/Tools
[webkitcorepy] Retry downloads in Autoinstall
https://bugs.webkit.org/show_bug.cgi?id=227134
<rdar://problem/79462182>
Reviewed by Aakash Jain.
- Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archive.download): Retry failed downloads
(AutoInstall): Allow for a single retry by default
- 2:12 PM Changeset in webkit [279008] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile and FileSystem::MappedFileData::leakHandle
https://bugs.webkit.org/show_bug.cgi?id=227014
Reviewed by Yusuke Suzuki.
r247542 (Bug 199759) added FileSystem::unmapViewOfFile and
FileSystem::MappedFileData::leakHandle for JSC::CachePayload to
get the mapped address and to free the address.
However, Bug 227011 is going to add a file mapping handle to
FileSystem::MappedFileData for Windows port to create a
SharedMemory from a MappedFileData. Destruction of MappedFileData
should be done only by MappedFileData dtor.
- runtime/CachePayload.cpp:
(JSC::CachePayload::makeMappedPayload):
(JSC::CachePayload::makeMallocPayload):
(JSC::CachePayload::makeEmptyPayload):
(JSC::CachePayload::CachePayload):
(JSC::CachePayload::data const):
(JSC::CachePayload::size const):
(JSC::CachePayload::~CachePayload): Deleted.
(JSC::CachePayload::operator=): Deleted.
(JSC::CachePayload::freeData): Deleted.
- runtime/CachePayload.h: Use Variant for data.
(JSC::CachePayload::data const): Deleted.
(JSC::CachePayload::size const): Deleted.
(JSC::CachePayload::CachePayload): Deleted.
- 1:49 PM Changeset in webkit [279007] by
-
- 9 edits1 move1 delete in trunk/Source
Remove Mac-specific CPUTime functions
https://bugs.webkit.org/show_bug.cgi?id=227109
Reviewed by Yusuke Suzuki.
Source/WebKit:
Permit calling thread_selfusage, since it is used by clock_gettime(CLOCK_THREAD_CPUTIME_ID, tp).
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
Source/WTF:
There's no reason for the Mac-specific CPU time functions to exist, since getrusage and
clock_gettime work fine on Mac. It's actually slightly more efficient to use the POSIX calls
since getrusage returns CPU time for both current and terminated threads in a single
syscall, while using task_info requires two syscalls to do the same thing.
- WTF.xcodeproj/project.pbxproj:
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformPlayStation.cmake:
- wtf/PlatformWPE.cmake:
- wtf/cocoa/CPUTimeCocoa.cpp: Removed.
- wtf/posix/CPUTimePOSIX.cpp: Renamed from Source/WTF/wtf/unix/CPUTimeUnix.cpp.
- 1:48 PM Changeset in webkit [279006] by
-
- 4 edits in trunk
Trying to take empty snapshots of the view should not cause crashes
https://bugs.webkit.org/show_bug.cgi?id=227133
Reviewed by Tim Horton.
Source/WebKit:
Trying to take empty snapshots of the view should not cause crashes. We would previously
see crashes because:
- We would end up doing divisions by zero
- We would hit the ASSERT(size) in SharedMemory::allocate().
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
(TEST):
- 1:07 PM Changeset in webkit [279005] by
-
- 3 edits2 adds in trunk/Tools
[iOS 15] Add iOS 15 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226779
Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS15.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS15Simulator.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references to iOS 15 device + simulator, shifted ordering down
- CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references to iOS 15 device + simulator
(table.queue-grid tr.platform.ios-simulator-15 img.logo):
(table.queue-grid tr.platform.ios-15 img.logo):
- 1:03 PM Changeset in webkit [279004] by
-
- 11 edits in trunk/Source
Storage Access quirks should prompt up to twice if a user does not allow storage access
https://bugs.webkit.org/show_bug.cgi?id=227099
<rdar://problem/79409843>
Reviewed by John Wilander.
Source/WebCore:
Remove hasDeniedCrossPageStorageAccess functions. They are not needed
now that we are aligning storage access quirks with non-quirks by
using maxNumberOfTimesExplicitlyDeniedStorageAccess.
- dom/DocumentStorageAccess.cpp:
(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):
(WebCore::DocumentStorageAccess::requestStorageAccessForNonDocumentQuirk):
- dom/DocumentStorageAccess.h:
- dom/Element.cpp:
(WebCore::Element::dispatchMouseEvent):
- dom/Element.h:
- loader/ResourceLoadObserver.h:
(WebCore::ResourceLoadObserver::hasHadUserInteraction const):
(WebCore::ResourceLoadObserver::setHasDeniedCrossPageStorageAccess): Deleted.
(WebCore::ResourceLoadObserver::hasDeniedCrossPageStorageAccess const): Deleted.
- page/Quirks.cpp:
(WebCore::isStorageAccessQuirkDomainAndElement):
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
(WebCore::hasDeniedCrossPageStorageAccess): Deleted.
- page/Quirks.h:
Source/WebKit:
We should allow storage access prompts twice per document for quirks
just like for non-quirk cases. Previously we were only presenting
the quirk prompt once per web content process if the user denied. This
patch removes this code and utilizes maxNumberOfTimesExplicitlyDeniedStorageAccess
instead.
- WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
(WebKit::WebResourceLoadObserver::hasDeniedCrossPageStorageAccess const): Deleted.
(WebKit::WebResourceLoadObserver::setHasDeniedCrossPageStorageAccess): Deleted.
- WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
- 1:00 PM Changeset in webkit [279003] by
-
- 2 edits in trunk/Source/WTF
Adopt WKHoverGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=227116
<rdar://79442027>
Reviewed by Wenson Hsieh.
- wtf/PlatformEnableCocoa.h:
- 11:57 AM Changeset in webkit [279002] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (r277067): Incorrect text color for default-button appearance
https://bugs.webkit.org/show_bug.cgi?id=227129
<rdar://problem/79032808>
Reviewed by Tim Horton.
Buttons styled with '-webkit-appearance: default-button' currently rely
on the CSS value 'activebuttontext' for their text color. r277067
updated the color to use system colors, for consistency with the rest
of the platform.
In macOS Monterey, the 'activebuttontext' color and the default button
text color are not equivalent. 'Active' buttons no longer use
NSBackgroundStyleEmphasized, while default buttons still do.
Consequently, default buttons are rendered with an incorrect text color.
To fix, use the correct system color for the text color of default
buttons. To avoid changing the behavior of platforms other than
macOS, the 'activebuttontext' color remains the default text color
specified in RenderTheme.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::defaultButtonTextColor const):
(WebCore::RenderTheme::platformDefaultButtonTextColor const):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::platformDefaultButtonTextColor const):
- rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
- 11:43 AM Changeset in webkit [279001] by
-
- 3 edits2 adds in trunk/Tools
[watchOS 8] Add watchOS 8 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226781
Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS8.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator8.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references for watchOS 8 device + simulator; shifted order down for Windows platforms to make room
- CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references for watchOS 8 device + simulator
(table.queue-grid tr.platform.watchos-simulator-8 img.logo):
(table.queue-grid tr.platform.watchos-8 img.logo):
- 11:41 AM Changeset in webkit [279000] by
-
- 3 edits2 adds in trunk/Tools
[tvOS 15] Add tvOS 15 simulator/device to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226782
Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS15.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS15Simulator.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added references to tvOS 15 device + simulator
- CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added references to tvOS 15 device + simulator
(table.queue-grid tr.platform.tvos-simulator-15 img.logo):
(table.queue-grid tr.platform.tvos-15 img.logo):
- 11:38 AM Changeset in webkit [278999] by
-
- 3 edits1 add in trunk/Tools
[Monterey] Add Seed 1 to bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226747
Patch by W.D. Xiong <w_xiong@apple.com> on 2021-06-17
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/public_html/dashboard/Images/Monterey.png: Added.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: Added Monterey
- CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Added Monterey
(table.queue-grid tr.platform.macos-monterey img.logo):
- 11:24 AM Changeset in webkit [278998] by
-
- 2 edits in trunk/Tools
[Win] Exception running layout tests
https://bugs.webkit.org/show_bug.cgi?id=227114
Reviewed by Jonathan Bedard.
Catch exception and print warning message.
- Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:
(TaskPool.exit):
- 11:18 AM Changeset in webkit [278997] by
-
- 3 edits in trunk/Source/WebKit
Adopt WKHoverGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=227116
<rdar://79442027>
Reviewed by Wenson Hsieh.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
(-[WKContentView gestureRecognizer:shouldReceivePress:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView setUpHoverGestureRecognizer]):
(-[WKContentView hoverGestureRecognizerChanged:]):
Plumb mouse events from WKHoverGestureRecognizer to the page.
- 10:23 AM Changeset in webkit [278996] by
-
- 1 copy in tags/Safari-612.1.19
Tag Safari-612.1.19.
- 10:17 AM Changeset in webkit [278995] by
-
- 2 edits in trunk/Source/WebKit
Fix crashes in ContentRuleListStore::lookupContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=227100
<rdar://78816611>
Reviewed by Chris Dumez.
To be extra careful, instead of just assuming that moveFile will always succeed,
when moveFile fails, try to delete the legacy path (which has a ContentExtension- instead of ContentRuleList- prefix)
and fail the lookup. This will only happen in Safari, which was the only client of _WKUserContentExtensionStore.
The legacy file is not useful to us because in r275078 I incremented CurrentContentRuleListFileVersion so the bytes on disk
need to be recompiled anyways. Safari already has logic to recompile it. This was just an attempt to use what we have and
not leave anything behind.
Also, to be extra careful, try deleting a file before moving a file on top of it.
- UIProcess/API/APIContentRuleListStore.cpp:
compiledToFile:
(API::ContentRuleListStore::lookupContentRuleList):
- 10:16 AM Changeset in webkit [278994] by
-
- 7 edits in trunk/Source/JavaScriptCore
Add a new pattern to instruction selector to utilize UBFX supported by ARM64
https://bugs.webkit.org/show_bug.cgi?id=226984
Patch by Yijia Huang <Yijia Huang> on 2021-06-17
Reviewed by Filip Pizlo.
UBFX, supported by ARM64, copies adjacent bits from the source register into
the least significant bits of a destination register in zero extension. The
instruction selector can utilize this to lowering certain patterns in B3 IR
before further Air optimization.
ubfx dest, src, lsb, width
tmp, tmp, imm, imm
This is equivalent to "dest = (src >> lsb) & ((1 << width) - 1)". Since wasm
introduces constant folding, then the pattern would be:
dest = (src >> lsb) & mask
where the mask should have a binary format in contiguous ones starting from
the least significant bit. For example:
0b00111111
To make the pattern matching in instruction selection beneficial to JIT, these
constraints should be introduced:
- lsb >= 0
- width > 0
- lsb + width <= bit field limit (32 or 64)
Given:
B3 IR
Int @0 = ArgumentReg(%0)
Int @1 = lsb
Int @2 = 0b0011
Int @3 = ZShr(@0, @1)
Int @4 = BitAnd(@3, @2)
Void@5 = Return(@4, Terminal)
w/o UBFX Pattern:
Old optimized AIR
Urshift %x0, lsb, %x0, @3
And 0b0011, %x0, %x0, @4
Ret %x0, @5
w/ UBFX Pattern:
New optimized AIR
Ubfx %x0, lsb, 2, %x0, @4
Ret %x0, @5
Note:
Suppose a 32-bit version of (src >> 20) & 0x0FFF, it is equivalent to src >> 20.
In this case, Logical Shift Right should be utilized instead when:
lsb + width == bit field limit (32 or 64)
This case/pattern should be added and upadated in the future patch.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::ubfx32):
(JSC::MacroAssemblerARM64::ubfx64):
- assembler/testmasm.cpp:
(JSC::testUbfx32):
(JSC::testUbfx64):
- b3/B3LowerToAir.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.h:
- b3/testb3_2.cpp:
(testUbfx64PatternMatch):
(testUbfx32PatternMatch):
(addBitTests):
- 10:05 AM Changeset in webkit [278993] by
-
- 27 edits1 delete in trunk
Remove empty header WebTypesInternal.h
https://bugs.webkit.org/show_bug.cgi?id=227094
Reviewed by Fujii Hironori.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj:
Source/WebKitLegacy/mac:
- DefaultDelegates/WebDefaultUIDelegate.mm:
- History/WebBackForwardList.mm:
- History/WebHistory.mm:
- History/WebHistoryItem.mm:
- Misc/WebDownload.mm:
- Misc/WebElementDictionary.mm:
- Misc/WebNSDataExtras.h:
- Misc/WebTypesInternal.h: Removed.
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginPackage.mm:
- WebView/WebArchive.mm:
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebHTMLRepresentation.mm:
- WebView/WebHTMLView.mm:
- WebView/WebPDFDocumentExtras.mm:
- WebView/WebPDFRepresentation.mm:
- WebView/WebTextCompletionController.mm:
- WebView/WebTextIterator.mm:
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
Tools:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/mac/DumpRenderTreePasteboard.h:
- DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
- DumpRenderTree/mac/TextInputControllerMac.m:
- 9:52 AM Changeset in webkit [278992] by
-
- 4 edits in trunk
WKScriptMessageHandlerWithReply should raise an exception if replyHandler is called twice
https://bugs.webkit.org/show_bug.cgi?id=226863
Reviewed by Chris Dumez.
Source/WebKit:
We currently dereference null inside CompletionHandlerWithFinalizer.
This makes it more obvious what is going on.
Related to rdar://78865409 but not solving it.
- UIProcess/API/Cocoa/WKUserContentController.mm:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
(-[AsyncScriptMessageHandler userContentController:didReceiveScriptMessage:replyHandler:]):
- 9:36 AM Changeset in webkit [278991] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Work around apparent miscompilation on ARM/GCC >=8.4
https://bugs.webkit.org/show_bug.cgi?id=227125
Reviewed by Filip Pizlo.
This seems to be a GCC miscompilation, revealed by
https://bugs.webkit.org/show_bug.cgi?id=227078. Introduce a
workaround for the GCC versions that seem to be affected.
- jit/RegisterSet.h:
- 9:34 AM Changeset in webkit [278990] by
-
- 2 edits in trunk/Tools
[Mac EWS] TestWebKitAPI.WebKit.AudioBufferSize is flaky timing out on EWS
https://bugs.webkit.org/show_bug.cgi?id=227046
<rdar://problem/79360787>
Unreviewed, fix broken test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add audio-buffer-size.html
to the Copy Resources step so tests can use it.
- 9:04 AM Changeset in webkit [278989] by
-
- 3 edits in trunk/Tools
[ews] Improve build summary about finding flaky test in ReRunWebKitTests
https://bugs.webkit.org/show_bug.cgi?id=227123
Reviewed by Jonathan Bedard.
- CISupport/ews-build/steps.py:
(ReRunWebKitTests.evaluateCommand):
- CISupport/ews-build/steps_unittest.py:
- 8:57 AM Changeset in webkit [278988] by
-
- 9 edits in trunk
[GTK] Unexpected timeout in http/tests/media/video-play-stall-seek.html
https://bugs.webkit.org/show_bug.cgi?id=196198
Reviewed by Philippe Normand.
Source/WebCore:
Increased default GstDowloadBuffer size to prevent a race condition. To do that, we need
to set the buffer-size of GstUriDecodebin (that will set the GstMultiQueue size, so we use
the default value that would be used if no changes had been made, and also leaves
GstDownloadBuffer size untouched, which wouldn't happen if no buffer-size had been set)
and then set the desired max-size-bytes on GstDownloadBuffer.
The race condition was that some times the player private readyState went up to
HAVE_ENOUGH_DATA and then back to HAVE_CURRENT_DATA (triggering the expected waiting event),
and some others times went directly to HAVE_CURRENT_DATA (no waiting event, test stalled).
Increasing the buffer size gave more time for the double transition to happen.
Still, these changes weren't enough to get the test passing, as with these changes the
multiqueue sucked all the data, downloadbuffer fell to a low percentage and updateStates()
paused the pipeline for rebuffering. The pipeline won't ever be unpaused because at that
point WebKitWebSrc has reached EOS (no more file to download, a side effect of the current
libsoup behaviour) and the buffering won't ever go up again (and trigger the unpause).
This was solved by setting the downloadbuffer high-percent property to 0 when a seek
is done after EOS has been received by WebKitWebSrc. This effectively forces the
downloadbuffer to report 100% buffered, which unpauses the pipeline and lets the playback
continue after seek.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::doSeek): Set high-percent when seeking after WebKitWebSrc EOS.
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup): Manually set buffer-size to its default value.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Receive the custom EOS message from WebKitWebSrc and remember it.
(WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback): Manully set max-size-bytes to a higher than default value.
(WebCore::MediaPlayerPrivateGStreamer::downloadBufferFileCreatedCallback): Don't clean the reference to the downloadbuffer, as it'll be needed later.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Added m_hasWebKitWebSrcSentEOS to remember the EOS condition.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcCreate): Notify the EOS condition using the bus, so the player private can handle it.
(CachedResourceStreamingClient::loadFailed): Extra useful logs.
(CachedResourceStreamingClient::loadFinished): Ditto.
LayoutTests:
Make test more stable and don't expect NETWORK_LOADING, because some network implementations,
like libsoup, just report end-of-stream and finish the download.
- http/tests/media/video-play-stall-seek-expected.txt: Removed NETWORK_LOADING expectation.
- http/tests/media/video-play-stall-seek.html: Stabilize the test by not listening to waiting events once the relevant one has been handled, and by pausing the video after the test has finished. Also re
- 8:53 AM Changeset in webkit [278987] by
-
- 2 edits in trunk/Tools
REGRESSION (r278536): Wrong comment character used in coverage.xcconfig
- coverage/coverage.xcconfig:
- Change '#' to '' to fix the comment.
- 7:53 AM Changeset in webkit [278986] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GStreamer mediastream gardening
- platform/glib/TestExpectations: Unflag fast/mediastream/media-stream-renders-first-frame.html
- platform/wpe/TestExpectations: Move getDisplayMedia expectations to glib file.
- 6:13 AM Changeset in webkit [278985] by
-
- 8 edits in trunk
[css-logical] Implement logical property groups
https://bugs.webkit.org/show_bug.cgi?id=226878
Reviewed by Antti Koivisto.
Source/WebCore:
In order to have proper CSSOM support for logical properties, we will
need to determine whether two properties belong to the same logical
property group but with a different mapping logic.
Before this patch, we only knew the physical properties belonging to the
same logical property group as a given logical property. But given a
physical property, we didn't know if there were logical properties that
could map to it.
Therefore this patch changes CSSProperties.json so that both logical and
physical properties specify their logical property group.
The code for resolving a logical property into its physical equivalent
is now automatically generated.
The CSSOM fix will be done in a follow-up (bug 226461).
This patch introduces no behavior changes.
- css/CSSProperties.json:
- css/CSSProperty.cpp:
- css/makeprop.pl:
(nameToId):
(addProperty):
- platform/RectEdges.h:
(WebCore::RectEdges::before):
(WebCore::RectEdges::after):
(WebCore::RectEdges::start):
(WebCore::RectEdges::end):
(WebCore::RectEdges::before const):
(WebCore::RectEdges::after const):
(WebCore::RectEdges::start const):
(WebCore::RectEdges::end const):
- platform/text/WritingMode.h:
(WebCore::mapLogicalAxisToPhysicalAxis):
Tools:
Add validator for new codegen property "logical-property-group",
replacing the old "direction-aware-property".
- Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.validate_logical_property_group):
(JSONCSSPropertiesChecker.check_codegen_properties):
- 6:05 AM Changeset in webkit [278984] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GStreamer mediastream gardening
- platform/glib/TestExpectations: Unflag 3 tests consistently passing.
- 5:59 AM Changeset in webkit [278983] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686
Unreviewed WPE/GTK debug build fix.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): Removed assert left there from a previous version of the patch.
- 5:38 AM Changeset in webkit [278982] by
-
- 4 edits3 adds in trunk
Fix RTCDataChannelInit::decode
https://bugs.webkit.org/show_bug.cgi?id=226968
Source/WebCore:
Reviewed by Eric Carlson.
Test: imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html
- platform/mediastream/RTCDataChannelHandler.h:
(WebCore::RTCDataChannelInit::decode):
Make sure to use optionals of optionals.
LayoutTests:
<rdar://problem/79300038>
Reviewed by Eric Carlson.
- http/wpt/webrtc/transfer-datachannel-service-worker.https-expected.txt: Added.
- http/wpt/webrtc/transfer-datachannel-service-worker.https.html: Added.
- http/wpt/webrtc/transfer-datachannel-service-worker.js: Added.
(onmessage):
- platform/mac-wk1/TestExpectations:
- 5:00 AM Changeset in webkit [278981] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686
Reviewed by Philippe Normand.
Refactored the notifyPlayerOf{Audio,Video,Text} family of methods into a single notifyPlayerOfTrack() one.
Some Variant variables are needed in order to make several incompatible types work together and to auto-detect the type of track as an enum.
Covered by existing tests.
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
(WebCore::InbandTextTrackPrivateGStreamer::create): Added method with a signature similar to the ones used by {Audio,Video}TrackPrivateGStreamer, so that it fits into the notifyPlayerOfTrack() template code.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): Template method that unifies the old notifyPlayerOf{Audio,Video,Text}() implementations.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Deleted. Refactored into notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::audioChangedCallback): Call the new notifyPlayerOfTrack() refactored implementation.
(WebCore::MediaPlayerPrivateGStreamer::textChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidAudioTracks): Deleted. Now implemented directly inside notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidTextTracks): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Deleted notifyPlayerOf{Audio,Video,Text}(), added notifyPlayerOfTrack(), deleted purgeInvalid{Audio,Video,Text}Tracks().
- 3:50 AM Changeset in webkit [278980] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Close open connections
https://bugs.webkit.org/show_bug.cgi?id=227068
Reviewed by Brent Fulgham.
On macOS, close open connections in initializeSandboxParameters.
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::initializeSandboxParameters):
- 2:49 AM Changeset in webkit [278979] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, reverting r278978.
https://bugs.webkit.org/show_bug.cgi?id=227115
The patch seems to be breaking the Debian and Ubuntu builds.
Reverted changeset:
"[GStreamer] Refactor
MediaPlayerPrivateGStreamer::notifyPlayerOf*"
https://bugs.webkit.org/show_bug.cgi?id=204686
https://trac.webkit.org/changeset/278978
- 2:18 AM Changeset in webkit [278978] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686
Reviewed by Philippe Normand.
Refactored the notifyPlayerOf{Audio,Video,Text} family of methods into a single notifyPlayerOfTrack() one.
Some Variant variables are needed in order to make several incompatible types work together and to auto-detect the type of track as an enum.
Covered by existing tests.
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
(WebCore::InbandTextTrackPrivateGStreamer::create): Added method with a signature similar to the ones used by {Audio,Video}TrackPrivateGStreamer, so that it fits into the notifyPlayerOfTrack() template code.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack): Template method that unifies the old notifyPlayerOf{Audio,Video,Text}() implementations.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Deleted. Refactored into notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::audioChangedCallback): Call the new notifyPlayerOfTrack() refactored implementation.
(WebCore::MediaPlayerPrivateGStreamer::textChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoChangedCallback): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidAudioTracks): Deleted. Now implemented directly inside notifyPlayerOfTrack().
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidTextTracks): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Deleted notifyPlayerOf{Audio,Video,Text}(), added notifyPlayerOfTrack(), deleted purgeInvalid{Audio,Video,Text}Tracks().
- 1:38 AM Changeset in webkit [278977] by
-
- 2 edits in trunk/Tools
[GLIB] Pass a GTlsCertificate to soup_server_new()
https://bugs.webkit.org/show_bug.cgi?id=227023
Reviewed by Michael Catanzaro.
Instead of using soup_server_set_ssl_cert_file() that will be removed from libsoup soon.
- TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
(WebKitTestServer::WebKitTestServer):
- 12:00 AM Changeset in webkit [278976] by
-
- 2 edits in trunk/Tools
[Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing
https://bugs.webkit.org/show_bug.cgi?id=227102
Reviewed by Ryosuke Niwa.
A heap corruption was detected while a Derived class object was
destroyed as a Base class object.
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::Base::~Base): Made Base class dtor virtual.
(TestWebKitAPI::Derived::~Derived):
Jun 16, 2021:
- 11:19 PM Changeset in webkit [278975] by
-
- 2 edits in trunk/Source/WebCore
Make FontFaceSet::Iterator's bounds check more robust
https://bugs.webkit.org/show_bug.cgi?id=227048
<rdar://problem/78871890>
Reviewed by Simon Fraser.
We were checking for one specific bad value, when we should have been checking for all bad values.
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::Iterator::next):
- 10:39 PM Changeset in webkit [278974] by
-
- 96 edits2 adds2 deletes in trunk
Document's execCommand() / queryCommand*() should throw an exception on non-HTML/XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=227016
Reviewed by Darin Adler.
Source/WebCore:
Update Document's execCommand() / queryCommand*() to throw an InvalidStateError when the document
is not an HTML/XHTML document. This matches Blink's behavior. Firefox is even stricter and throws
for all non HTML documents (including XHTML).
Test: fast/dom/Document/document-execcommand.html
- dom/Document.cpp:
(WebCore::Document::execCommand):
(WebCore::Document::queryCommandEnabled):
(WebCore::Document::queryCommandIndeterm):
(WebCore::Document::queryCommandState):
(WebCore::Document::queryCommandSupported):
(WebCore::Document::queryCommandValue):
- dom/Document.h:
Source/WebKitLegacy/mac:
Update ObjC bindings since the WebCore API now returns ExceptionOr<> types.
- DOM/DOMDocument.mm:
(-[DOMDocument execCommand:userInterface:value:]):
(-[DOMDocument queryCommandEnabled:]):
(-[DOMDocument queryCommandIndeterm:]):
(-[DOMDocument queryCommandState:]):
(-[DOMDocument queryCommandSupported:]):
(-[DOMDocument queryCommandValue:]):
LayoutTests:
- fast/dom/Document/document-execcommand-expected.txt: Added.
- fast/dom/Document/document-execcommand.html: Added.
Add layout test coverage.
- editing/pasteboard/createMarkup-assert-expected.txt: Removed.
- editing/pasteboard/createMarkup-assert.xml: Removed.
- platform/mac/svg/text/foreignObject-repaint-expected.txt:
- platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
- platform/mac/svg/text/text-align-01-b-expected.txt:
- platform/mac/svg/text/text-align-02-b-expected.txt:
- platform/mac/svg/text/text-align-03-b-expected.txt:
- platform/mac/svg/text/text-align-04-b-expected.txt:
- platform/mac/svg/text/text-align-05-b-expected.txt:
- platform/mac/svg/text/text-align-06-b-expected.txt:
- platform/mac/svg/text/text-deco-01-b-expected.txt:
- platform/mac/svg/text/text-fonts-01-t-expected.txt:
- platform/mac/svg/text/text-fonts-02-t-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-path-01-b-expected.txt:
- platform/mac/svg/text/text-spacing-01-b-expected.txt:
- platform/mac/svg/text/text-text-01-b-expected.txt:
- platform/mac/svg/text/text-text-03-b-expected.txt:
- platform/mac/svg/text/text-text-04-t-expected.txt:
- platform/mac/svg/text/text-text-05-t-expected.txt:
- platform/mac/svg/text/text-text-07-t-expected.txt:
- platform/mac/svg/text/text-text-08-b-expected.txt:
- platform/mac/svg/text/text-tref-01-b-expected.txt:
- platform/mac/svg/text/text-tselect-01-b-expected.txt:
- platform/mac/svg/text/text-tselect-02-f-expected.txt:
- platform/mac/svg/text/text-tspan-01-b-expected.txt:
- svg/custom/bug78838-expected.txt:
- svg/custom/bug79798-expected.txt:
- svg/custom/delete-modified-text-in-defs-crash.svg:
- svg/custom/layout-loop-expected.txt:
- svg/text/text-positioning-remove-child-crash.svg:
Rebaseline / update existing tests due to behavior change.
- 8:45 PM Changeset in webkit [278973] by
-
- 2 edits in trunk/Source/WebKit
Passkeys don't work in Simulator
https://bugs.webkit.org/show_bug.cgi?id=227076
<rdar://79366832>
Patch by Garrett Davidson <garrett_davidson@apple.com> on 2021-06-16
Reviewed by Brent Fulgham.
Simulator does not support LAAccessControlOperationUseKeySign, so
-evaluateAccessControl:... returns an error. However, this check isn't actually necessary in
the simulator when using passkeys, so just skip it.
Tested registration and assertion in an app in Simulator.
- UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::verifyUser):
- 8:26 PM Changeset in webkit [278972] by
-
- 2 edits in trunk/Source/WTF
[JSC] Disable JITCage on macOS until we evaluate performance throughly
https://bugs.webkit.org/show_bug.cgi?id=227104
Reviewed by Mark Lam.
This patch disables JITCage on macOS until we evaluate performance throughly.
- wtf/PlatformEnable.h:
- 8:09 PM Changeset in webkit [278971] by
-
- 6 edits1 add in trunk
[JSC] Optimize JSON.parse with small data by changing Identifier pool mechanism
https://bugs.webkit.org/show_bug.cgi?id=227101
Reviewed by Mark Lam.
Found that std::array<Identifier, 128> pool in LiteralParser is too costly for construction and destruction
if JSON.parse is invoked for small data. This patch changes this pool mechanism so that we do not waste effort
allocating null Identifiers to pre-populate the recent identifiers pool. Instead, we now use a m_recentIdentifiersIndex
uint8_t array to indicate whether there's a cached recent identifier for each given first character.
We also use KeywordLookup.h's COMPARE_XCHARS to perform "true" / "false" / "null" lexing in JSON parser.
Roughly 20% improvement in microbenchmark. And roughly 2-3% improvement in Speedometer2/Flight-TodoMVC.
ToT Patched
flight-todomvc-json 67.8755+-1.1202 56.7114+-0.5048 definitely 1.1969x faster
- runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::add8):
- runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::add):
- runtime/IdentifierInlines.h:
(JSC::Identifier::add):
(JSC::Identifier::fromString):
- runtime/LiteralParser.cpp:
(JSC::compare3Chars):
(JSC::compare4Chars):
(JSC::LiteralParser<CharType>::makeIdentifier):
(JSC::LiteralParser<CharType>::Lexer::lex):
- runtime/LiteralParser.h:
- 5:46 PM Changeset in webkit [278970] by
-
- 4 edits in trunk/Source
takeSnapshotWithConfiguration() should wait for the next flush before it does callSnapshotRect()
https://bugs.webkit.org/show_bug.cgi?id=226257
<rdar://76411685>
Reviewed by Simon Fraser and Tim Horton.
Source/WebCore/PAL:
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
This will ensure the latest IOSurfaces are pushed to backboardd before
taking the snapshot. Also we need create an implicit transaction to ensure
a commit will happen.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
- 5:27 PM Changeset in webkit [278969] by
-
- 3 edits2 adds in trunk
Make RenderLayer::hitTestLayer not assume its renderer is a RenderBox
https://bugs.webkit.org/show_bug.cgi?id=227004
<rdar://79265788>
Reviewed by Simon Fraser.
Source/WebCore:
An inline box might have a clip-path on it, so we can't assume that
the layer's renderer is a RenderBox. Avoid the assertion by hit testing
incorrectly for now.
Test: css3/masking/clip-path-hit-test-on-inline-iframe-parent.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
LayoutTests:
- css3/masking/clip-path-hit-test-on-inline-iframe-parent-expected.txt: Added.
- css3/masking/clip-path-hit-test-on-inline-iframe-parent.html: Added.
- 5:15 PM Changeset in webkit [278968] by
-
- 1 copy in tags/Safari-612.1.18.1.3
Tag Safari-612.1.18.1.3.
- 4:39 PM Changeset in webkit [278967] by
-
- 2 edits19 moves40 deletes in trunk/Tools
Clean up how platform images are handled in the bot watchers' dashboard
https://bugs.webkit.org/show_bug.cgi?id=226989
Patch by W.D. Xiong.
Renamed the _@2x.png files to _.png and removed old platforms that don't have queues anymore. Also renamed WatchOSSimulator7 to WatchOS7Simulator
- CISupport/build-webkit-org/public_html/dashboard/Images/BigSur.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/BigSur@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/BigSur@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Catalina.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Catalina@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/Catalina@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/ElCapitan.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/ElCapitan@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/GTK.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/GTK@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/GTK@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/HighSierra.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/HighSierra@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS10.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS10@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS10Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS10Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS11.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS11@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS11Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS11Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS12.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS12@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS12Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS12Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS13.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS13@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS13Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS13Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS14.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS14@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS14@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS14Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS9.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS9@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS9Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOS9Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Mavericks.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Mavericks@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Mojave.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Mojave@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/Mojave@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/MountainLion@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/PlatformRing@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Sierra.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Sierra@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/SquirrelFish@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13Simulator.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS13Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/TvOS14Simulator@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WPE.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WPE@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/WPE@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS6.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS6@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS7Simulator.png: Copied from Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator7@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows10.png: Replaced with Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Windows10@2x.png.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows10@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows7.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows7@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows8.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Windows8@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WindowsXP.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/WindowsXP@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Yosemite.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Images/Yosemite@2x.png: Removed.
- CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: Applied above changes
(table.queue-grid td.logo img.ring):
(table.queue-grid tr.platform.ios-simulator-14 img.logo):
(table.queue-grid tr.platform.ios-14 img.logo):
(table.queue-grid tr.platform.tvos-simulator-14 img.logo):
(table.queue-grid tr.platform.tvos-14 img.logo):
(table.queue-grid tr.platform.watchos-simulator-7 img.logo):
(table.queue-grid tr.platform.watchos-7 img.logo):
(table.queue-grid tr.platform.macos-catalina img.logo):
(table.queue-grid tr.platform.macos-bigsur img.logo):
(table.queue-grid tr.platform.wincairo-windows-10 img.logo):
(table.queue-grid tr.platform.windows-10 img.logo):
(table.queue-grid tr.platform.windows-7 img.logo):
(table.queue-grid tr.platform.linux-gtk img.logo):
(table.queue-grid tr.platform.linux-wpe img.logo):
(table.queue-grid tr.platform.linux-jsconly img.logo):
- 4:37 PM Changeset in webkit [278966] by
-
- 4 edits in trunk/Source
Adopt com.apple.security.cs.jit-write-allowlist on internal builds.
https://bugs.webkit.org/show_bug.cgi?id=222148
rdar://74284026
Reviewed by Per Arne Vollan.
Source/JavaScriptCore:
This will prevent various pthread permissions switching APIs from working.
We only want to adopt this for internal builds where we use the fast permission
switching macro instead. We can't adopt it for open source builds, where we
still rely on the pthread API.
- Scripts/process-entitlements.sh:
Source/WebKit:
- Scripts/process-entitlements.sh:
- 4:26 PM Changeset in webkit [278965] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Skip another WebGL 2 test.
https://bugs.webkit.org/show_bug.cgi?id=227093
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-16
- platform/glib/TestExpectations:
- 4:09 PM Changeset in webkit [278964] by
-
- 5 edits in trunk/Source/WebCore
Protect Element before calling dispatchMouseEvent() on it
https://bugs.webkit.org/show_bug.cgi?id=226767
<rdar://problem/79009112>
Reviewed by Ryosuke Niwa.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::dispatchLockedMouseEvent):
- page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
- 3:41 PM Changeset in webkit [278963] by
-
- 5 edits in trunk/Tools
[webkitscmpy] Support branch queries in mock git log
https://bugs.webkit.org/show_bug.cgi?id=225889
<rdar://problem/78122705>
Reviewed by Stephanie Lewis.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Add support for branches in
git logcommands.
- Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log):
(TestGit.test_branch_log):
- 3:39 PM Changeset in webkit [278962] by
-
- 12 edits1 copy21 moves81 adds17 deletes in trunk/LayoutTests
Resync FileAPI tests from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=227089
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Resync FileAPI tests from upstream WPT b5949c67c948bc452e3.
- web-platform-tests/FileAPI/*: Updated.
LayoutTests:
- tests-options.json:
- 3:37 PM Changeset in webkit [278961] by
-
- 18 edits8 adds in trunk/LayoutTests/imported/w3c
Resync webaudio tests from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=227091
Reviewed by Geoffrey Garen.
Resync webaudio tests from upstream WPT b5949c67c948bc452e3.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-cancel-and-hold.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-nominal-range-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-nominal-range.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values.html:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion.html:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-throw-onmessage.https-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-throw-onmessage.https.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation.html:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode.html:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv.html:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-setposition-throws-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-setposition-throws.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-periodicwave-interface/periodicWave.html:
- 3:27 PM Changeset in webkit [278960] by
-
- 1 copy in tags/Safari-611.3.8
Tag Safari-611.3.8.
- 3:26 PM Changeset in webkit [278959] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't look at the (non-existent) child2 of DelById
https://bugs.webkit.org/show_bug.cgi?id=227095
Reviewed by Mark Lam.
Trivial fix to a broken rebase: while it is ok to share most code between DelById and DelByVal, only the latter has a child2(), so it should not be accessed if we are compiling the former.
No new test, as it was caught by one of our existing tests.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
- 3:22 PM Changeset in webkit [278958] by
-
- 2 edits in trunk/Source/WebCore
Some http/tests/ are crashing with ASSERTION FAILED: isInRoutingArbitrationForToken(token) m_setupArbitrationOngoing https://bugs.webkit.org/show_bug.cgi?id=226896
Reviewed by Darin Adler.
A follow-up patch to fix an issue in r278922. Remove the call to
contains()
beforeremove()on aWeakHashSet.
- platform/audio/mac/SharedRoutingArbitrator.mm:
(WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken):
- 3:18 PM Changeset in webkit [278957] by
-
- 15 edits1 move1 delete in trunk
[watchOS] Reenable modern text input UI for non-numeric text input types
https://bugs.webkit.org/show_bug.cgi?id=226988
rdar://78102953
Reviewed by Tim Horton.
Source/WebKit:
Refactor text input logic on watchOS such that we're able to present the new ("modern") UI for scribble text
input on watchOS 8, rather than legacy (in-process) scribble UI. Overall, this patch removes
WKQuickboardListViewController altogether. This had two subclasses: WKSelectMenuListViewController (used for
focused single and multiple select elements) and WKTextInputListViewController (used for text input types).
WKSelectMenuListViewController now inherits directly from PUICQuickboardListViewController, and
WKTextInputListViewController now inherits from PUICQuickboardMessageViewController; this inheritance from
PUICQuickboardMessageViewController instead of PUICQuickboardListViewController allows the
WKTextInputListViewController to show text suggestions using-setMessages:on
PUICQuickboardMessageViewController, instead of relying on custom WebKit code to insert text suggestions.
This means that we move the following pieces of functionality out of WKQuickboardListViewController, and into
either WKSelectMenuListViewController or WKTextInputListViewController:
- Support for inserting and updating context views (i.e. the domain name header view in Quickboard) =>
WKTextInputListViewController.
- Logic for determining whether or not we should show language selection UI => WKTextInputListViewController.
- Support for laying out custom collection view cells in Quickboard => WKSelectMenuListViewController.
- Platform/spi/watchos/PepperUICoreSPI.h:
- SourcesCocoa.txt:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView createQuickboardTextInputContext]):
(-[WKContentView _createQuickboardController:]):
Refactor logic to create a PUICTextInputContext from the current focused element information out into a separate
helper method,-createQuickboardTextInputContext, and use it when both directly launching into
PUICQuickboardController and WKTextInputListViewController.
(canUseQuickboardControllerFor):
Remove a comment, now that we intend to continue using WKTextInputListViewController for non-keychain-AutoFill-
compatible text fields moving forward.
(-[WKContentView focusedFormControllerDidUpdateSuggestions:]):
(-[WKContentView allowsLanguageSelectionForListViewController:]):
(-[WKContentView textInputContextForListViewController:]):
(-[WKContentView textContentTypeForTesting]):
(-[WKContentView viewController:inputContextViewHeightForSize:]): Deleted.
Remove this delegate method, which was (effectively) unused since we just ask for
-inputContextViewForViewController:from the input delegate anyways.
(-[WKContentView allowsLanguageSelectionMenuForListViewController:]): Deleted.
Rename this to
-allowsLanguageSelectionForListViewController:.
(-[WKContentView textContentTypeForListViewController:]): Deleted.
Replace this with
-textInputContextForListViewController:, which returns a whole PUICTextInputContext instead
of just a text content type.
(-[WKContentView textSuggestionsForListViewController:]): Deleted.
(-[WKContentView listViewController:didSelectTextSuggestion:]): Deleted.
Remove several delegate methods that are no longer needed.
- UIProcess/ios/forms/WKDatePickerViewController.h:
- UIProcess/ios/forms/WKDatePickerViewController.mm:
(-[WKDatePickerViewController viewWillAppear:]):
Remove some (defunct) logic for overriding the status bar when showing Quickboard input view controllers. This
status bar mechanism (which was previously used to show label text for form controls) hasn't worked since
watchOS 6, and we need to implement this in a way that doesn't use PUICStatusBarGlobalContextViewAssertion.
- UIProcess/ios/forms/WKQuickboardListViewController.mm: Removed.
- UIProcess/ios/forms/WKQuickboardViewControllerDelegate.h: Renamed from Source/WebKit/UIProcess/ios/forms/WKQuickboardListViewController.h.
- UIProcess/ios/forms/WKSelectMenuListViewController.h:
- UIProcess/ios/forms/WKSelectMenuListViewController.mm:
(-[WKSelectMenuItemCell topToLabelBaselineSpecValue]):
(-[WKSelectMenuItemCell baselineToBottomSpecValue]):
(-[WKSelectMenuCollectionViewItemCell topToLabelBaselineSpecValue]):
(-[WKSelectMenuCollectionViewItemCell baselineToBottomSpecValue]):
(-[WKSelectMenuListViewController initWithDelegate:]):
See above comment for more details.
- UIProcess/ios/forms/WKTextInputListViewController.h:
- UIProcess/ios/forms/WKTextInputListViewController.mm:
(-[WKTextInputListViewController initWithDelegate:]):
(-[WKTextInputListViewController reloadContextView]):
(-[WKTextInputListViewController updateContextViewIfNeeded]):
Move logic for showing and updating the context view out of WKQuickboardListViewController, and into
WKTextInputListViewController. See comments above.
(-[WKTextInputListViewController requiresNumericInput]):
(-[WKTextInputListViewController additionalTrayButtons]):
(-[WKTextInputListViewController updateTextSuggestions:]):
(-[WKTextInputListViewController headerContentViewHeight]):
(-[WKTextInputListViewController headerContentView]):
(-[WKTextInputListViewController shouldShowLanguageButton]):
(-[WKTextInputListViewController supportsDictationInput]):
(-[WKTextInputListViewController shouldShowTrayView]):
(-[WKTextInputListViewController shouldShowTextField]):
Override this and return YES for text input types that don't require an additional numeric input tray button.
This allows PUICQuickboardMessageViewController to show a native text field containing the input text inside
quickboard, which (when tapped) presents modern text input UI.
Since showing the text field is apparently mutually exclusive to showing a tray view, we additionally override
-shouldShowTrayViewand return NO for non-numeric text inputs.
(-[WKTextInputListViewController supportsArouetInput]):
(-[WKTextInputListViewController viewDidLoad]): Deleted.
(-[WKTextInputListViewController willPresentArouetViewController:]): Deleted.
There's no need to override this delegate method anymore, since the PUICTextInputContext's
-initialTextis
sufficient to ensure that the scribble text input UI is prepopulated with the focused text field's initial text
content.
(-[WKTextInputListViewController reloadTextSuggestions]): Deleted.
Rename this to
-updateTextSuggestions:, and make it take a list of UITextSuggestions. This makes the code a
bit easier to follow and allows us to remove the-textSuggestionsForListViewController:delegate method.
(-[WKTextInputListViewController didSelectListItemAtIndexPath:]): Deleted.
(-[WKTextInputListViewController didSelectListItem:]): Deleted.
(-[WKTextInputListViewController _didSelectListItem:]): Deleted.
(-[WKTextInputListViewController numberOfListItems]): Deleted.
(-[WKTextInputListViewController heightForListItem:width:]): Deleted.
(-[WKTextInputListViewController cellForListItem:]): Deleted.
(-[WKTextInputListViewController listItemCellReuseIdentifier]): Deleted.
(-[WKTextInputListViewController listItemCellClass]): Deleted.
(-[WKTextInputListViewController itemCellForListItem:forIndexPath:]): Deleted.
Remove all this code for showing text suggestions in Quickboard UI. Since WKTextInputListViewController is now a
subclass of PUICQuickboardMessageViewController, we can now simply use the-messagesproperty of to populate
quickboard with text suggestions.
- UIProcess/ios/forms/WKTimePickerViewController.h:
- WebKit.xcodeproj/project.pbxproj:
WebKitLibraries:
- WebKitPrivateFrameworkStubs/watchos/7/PepperUICore.framework/PepperUICore.tbd:
- WebKitPrivateFrameworkStubs/watchos/8/PepperUICore.framework/PepperUICore.tbd:
- 3:04 PM Changeset in webkit [278956] by
-
- 8 edits in branches/safari-612.1.18.1-branch/Source
Versioning.
WebKit-7612.1.18.1.3
- 2:34 PM Changeset in webkit [278955] by
-
- 4 edits in trunk/Tools
[webkitscmpy] Cache more Git commands
https://bugs.webkit.org/show_bug.cgi?id=227082
<rdar://problem/79405244>
Reviewed by Stephanie Lewis.
- Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.init): Reset branch cache.
(Git.default_branch): Memoize default_branch call.
(Git.branch): Prefer branch cache.
(Git.checkout): Reset branch cache.
- 1:51 PM Changeset in webkit [278954] by
-
- 61 edits58 copies21 adds in trunk/LayoutTests
Allow WebXR tests to be run on Mac
https://bugs.webkit.org/show_bug.cgi?id=227054
Patch by Ada Chan <ada.chan@apple.com> on 2021-06-16
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Updated expected results.
- web-platform-tests/webxr/events_input_source_recreation.https-expected.txt:
- web-platform-tests/webxr/events_input_sources_change.https-expected.txt:
- web-platform-tests/webxr/events_referenceSpace_reset_immersive.https-expected.txt: Added.
- web-platform-tests/webxr/events_referenceSpace_reset_inline.https-expected.txt: Added.
- web-platform-tests/webxr/events_session_select.https-expected.txt:
- web-platform-tests/webxr/events_session_select_subframe.https-expected.txt:
- web-platform-tests/webxr/events_session_squeeze.https-expected.txt:
- web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt:
- web-platform-tests/webxr/getInputPose_handedness.https-expected.txt:
- web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt:
- web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt:
- web-platform-tests/webxr/render_state_update.https-expected.txt:
- web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt:
- web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt:
- web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt:
- web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt:
- web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt:
- web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt:
- web-platform-tests/webxr/xrDevice_disconnect_ends.https-expected.txt: Added.
- web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt:
- web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt:
- web-platform-tests/webxr/xrFrame_getPose.https-expected.txt:
- web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt:
- web-platform-tests/webxr/xrFrame_getViewerPose_getPose_identities.https-expected.txt: Added.
- web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt:
- web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt:
- web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt:
- web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt:
- web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt:
- web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt:
- web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt:
- web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt:
- web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt:
- web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt:
- web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt:
- web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt:
- web-platform-tests/webxr/xrSession_end.https-expected.txt:
- web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt:
- web-platform-tests/webxr/xrSession_requestSessionDuringEnd.https-expected.txt: Added.
- web-platform-tests/webxr/xrSession_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt:
- web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt:
- web-platform-tests/webxr/xrView_eyes.https-expected.txt:
- web-platform-tests/webxr/xrView_match.https-expected.txt:
- web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt:
- web-platform-tests/webxr/xrView_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrViewport_valid.https-expected.txt:
- web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt:
- web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt:
- web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt:
- web-platform-tests/webxr/xr_viewport_scale.https-expected.txt: Added.
LayoutTests:
Updated expected results and TestExpectations.
Copied old versions of expected results that were in imported/w3c/web-platform-tests/webxr
to platform/wpe/imported/w3c/web-platform-tests/webxr so test runs on wpe should not be
affected.
- TestExpectations:
- http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt:
- http/wpt/webxr/xrSession_ended_by_system.https-expected.txt:
- http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/webxr/getInputPose_pointer.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/webxr_feature_policy.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrSession_visibilityState.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/webxr/xr_viewport_scale.https-expected.txt: Added.
- platform/wpe/http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_end_device_reports_shutdown.https-expected.txt.
- platform/wpe/http/wpt/webxr/xrSession_ended_by_system.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_ended_by_system.https-expected.txt.
- platform/wpe/http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt: Copied from LayoutTests/http/wpt/webxr/xrSession_reject_multiple_end.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_input_source_recreation.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_input_source_recreation.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_input_sources_change.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_input_sources_change.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_immersive.https-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_inline.https-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_select.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_select.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_select_subframe.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_select_subframe.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/events_session_squeeze.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/events_session_squeeze.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/getInputPose_handedness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/getInputPose_handedness.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_update.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_update.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_immersive.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_disconnect_ends.https-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_getPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_getPose.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_session_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_add_remove.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_emulatedPosition.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_profiles.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrInputSource_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_relationships.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_constructor.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_inverse.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_end.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_end.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_viewer_referenceSpace.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_eyes.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_eyes.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_match.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_match.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_oneframeupdate.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrViewport_valid.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewport_valid.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https-expected.txt.
- platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_viewports.https-expected.txt.
- 1:44 PM Changeset in webkit [278953] by
-
- 17 edits in trunk/Source/WebKit
Enable release logging in the network process for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=227087
Reviewed by Geoffrey Garen.
Enable release logging in the network process for ephemeral sessions, to facilitate debugging. No domains
or other sensitive information is logged by WebKit.
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::cancel):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/DownloadMonitor.cpp:
(WebKit::DownloadMonitor::applicationWillEnterForeground):
(WebKit::DownloadMonitor::applicationDidEnterBackground):
(WebKit::DownloadMonitor::timerFired):
- NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponse):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):
(WebKit::NetworkCORSPreflightChecker::wasBlockedByRestrictions):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::hasUploadStateChanged):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::resolveBlobReferences):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::serverToContextConnectionNoLongerNeeded):
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::continueCheckingRequest):
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::retrieveCacheEntryInternal):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::convertToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::didBlockAuthenticationChallenge):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
(WebKit::NetworkResourceLoader::restartNetworkLoad):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveMainResourceResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::validateCacheEntry):
(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
(WebKit::NetworkResourceLoader::logSlowCacheRetrieveIfNeeded):
(WebKit::NetworkResourceLoader::startWithServiceWorker):
(WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponse):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::wasBlockedByRestrictions):
(WebKit::PingLoad::timeoutTimerFired):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::start):
(WebKit::ServiceWorkerFetchTask::contextClosed):
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::cannotHandle):
(WebKit::ServiceWorkerFetchTask::cancelFromClient):
(WebKit::ServiceWorkerFetchTask::continueDidReceiveFetchResponse):
(WebKit::ServiceWorkerFetchTask::continueFetchTaskWith):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):
(WebKit::ServiceWorkerFetchTask::softUpdateIfNeeded):
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::createFetchTask):
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::scheduleJobInServer):
(WebKit::WebSWServerConnection::scheduleUnregisterJobInServer):
- NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):
- NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):
- NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::NetworkRTCMonitor::startUpdatingIfNeeded):
(WebKit::NetworkRTCMonitor::stopUpdating):
(WebKit::NetworkRTCMonitor::onNetworksChanged):
- NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::createSocket):
- NetworkProcess/webrtc/NetworkRTCProvider.h:
- 1:12 PM Changeset in webkit [278952] by
-
- 9 edits in trunk/Source/WebKit
Sandbox profiles need to allow loading from /usr/appleinternal/lib on internal builds
https://bugs.webkit.org/show_bug.cgi?id=227079
<rdar://problem/79390957>
Reviewed by Per Arne Vollan.
We allow the specific directory "/usr/appleinternal/lib/sanitizers", but we actually need
access to "/usr/appleinternal/lib" in certain development environments.
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 12:58 PM Changeset in webkit [278951] by
-
- 5 edits2 adds in trunk
FileReader.readAsArrayBuffer misses checking for the type of blob param
https://bugs.webkit.org/show_bug.cgi?id=226640
<rdar://problem/79193198>
Reviewed by Youenn Fablet.
Source/WebCore:
The Blob parameter to FileReader.readAsArrayBuffer / readAsBinaryString / readAsText / readAsDataURL
should not be nullable as per the specification:
This patch aligns us with the specification and with the behavior of both Blink and Gecko.
Test: fast/files/filereader-invalid-blob.html
- fileapi/FileReader.cpp:
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
- fileapi/FileReader.h:
- fileapi/FileReader.idl:
LayoutTests:
Add layout test coverage. I have verified that this test is passing in Firefox and Chrome as well.
- fast/files/filereader-invalid-blob-expected.txt: Added.
- fast/files/filereader-invalid-blob.html: Added.
- 12:14 PM Changeset in webkit [278950] by
-
- 8 edits in trunk/Source/JavaScriptCore
Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and select this instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=226937
Patch by Yijia Huang <Yijia Huang> on 2021-06-16
Reviewed by Yusuke Suzuki.
Previously, Air arm64 sub32/64 utilize sub(Imm, Tmp) at optlevel = 0 and
add(Tmp, -Imm) at optlevel > 0 to perform and optimize sub(Tmp, Imm, Tmp).
The issue with this is that we were not eliding redundant operations.
For example:
B3 IR
@0 = Trunc(ArgumentReg(0))
@1 = Const
@2 = Sub(@0, @1)
@3 = Return(@2)
Old optimized Air IR
OptLevel = 0
Move %x0, %tmp1, @0
Move $Const, %tmp2, @1
Move %tmp1, %tmp0, @2 Redundant
Sub $Const, %tmp0, @2
Move %tmp0, %x0, @3
Ret32 %x0, @3
To remove those redundant instructions, Air arm64 sub32/64 opcode should
indicate a new form sub(Tmp, Imm, Tmp).
New optimized Air IR
OptLevel = 0
Move %x0, %tmp1, @0
Move $Const, %tmp2, @1
Sub %tmp1, $Const, %tmp0, @2
Move %tmp0, %x0, @3
Ret32 %x0, @3
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::sub32):
(JSC::MacroAssemblerARM64::sub64):
- assembler/testmasm.cpp:
(JSC::testSub32Args):
(JSC::testSub32Imm):
(JSC::testSub32ArgImm):
(JSC::testSub64Imm32):
(JSC::testSub64ArgImm32):
(JSC::testSub64Imm64):
(JSC::testSub64ArgImm64):
- b3/B3ReduceStrength.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.h:
- b3/testb3_2.cpp:
(testSubArgs32ZeroExtend):
- b3/testb3_3.cpp:
(addArgTests):
- 12:12 PM Changeset in webkit [278949] by
-
- 2 edits in trunk/LayoutTests
[EWS MacOS WK1] imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-snap-003.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=227085
Unreviewed test gardening.
Updating test expectations to clear EWS warning.
- platform/mac-wk1/TestExpectations:
- 12:12 PM Changeset in webkit [278948] by
-
- 2 edits in trunk/Source/WebCore
Add lock for static cursorMap in MemoryCursor
https://bugs.webkit.org/show_bug.cgi?id=226806
Reviewed by Chris Dumez.
As cursorMap can be accessed from multiple WorkQueues.
- Modules/indexeddb/server/MemoryCursor.cpp:
(WebCore::IDBServer::MemoryCursor::MemoryCursor):
(WebCore::IDBServer::MemoryCursor::~MemoryCursor):
(WebCore::IDBServer::MemoryCursor::cursorForIdentifier):
- 12:01 PM Changeset in webkit [278947] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r273329): Logging of most errors like CSP and promise rejections fail logging to the system console
https://bugs.webkit.org/show_bug.cgi?id=227080
Unreviewed, reverting r273329.
- dom/Document.cpp:
(WebCore::Document::didLogMessage):
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::addMessage):
- 11:44 AM Changeset in webkit [278946] by
-
- 1 edit in branches/safari-611-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentSecurityPolicy.mm
Unreviewed API Test fix.
Fix API test breakage after changes in https://trac.webkit.org/changeset/275702/webkit
- 11:34 AM Changeset in webkit [278945] by
-
- 7 edits in trunk/Source/JavaScriptCore
Drop the FTL(DFG) graph after lowering to B3
https://bugs.webkit.org/show_bug.cgi?id=226556
Reviewed by Phil Pizlo.
This patch originally landed as r278463, was reverted in r278463.
I believe that the bug for which it was reverted actually comes from r278371, which was also reverted at the same time. So I am now relanding this.
The challenge in this patch was dealing with all of the Patchpoints created by FTLLowerDFGToB3: they get a lambda at that time, which they execute at the end of Air, and many of these lambdas were capturing a pointer to some parts of the DFG graph and reading through it when being executed.
In all cases but one it was easily fixed: they were only reading a few bits from a given node, so I just read these bits in FTLLowerDFGToB3, and captured them (by value) instead of the pointer to the node.
The exception was compileCallOrConstructVarargsSpread(): its patchpoint generator was walking through the graph, flattening a tree of PhantomSpread/PhantomNewArrayWithSpread/PhantomNewArrayBuffer/PhantomCreateRest, emitting some code along the way.
We now do this flattening of the tree in FTLLowerDFGToB3, store just enough information to later emit the required code in a vector, and capture that vector in the lambda (through a move capture, which is allowed since C++14). Seestruct VarargsSpreadArgumentToEmitfor the information that we need to store in that vector.
I tested this change by completing a full run of JetStream2 with ASAN.
I also ran the stress tests with "spread" in their name in Debug mode.
- b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::clearAll):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::freeDFGIRAfterLowering):
- dfg/DFGGraph.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::getPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::compilePrivateBrandAccess):
(JSC::FTL::DFG::LowerDFGToB3::cachedPutById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::VarargsSpreadArgumentToEmit::VarargsSpreadArgumentToEmit):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileInById):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):
(JSC::FTL::DFG::LowerDFGToB3::getById):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::emitBinarySnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitBinaryBitOpSnippet):
(JSC::FTL::DFG::LowerDFGToB3::emitRightShiftSnippet):
(JSC::FTL::DFG::LowerDFGToB3::crash):
- 11:26 AM Changeset in webkit [278944] by
-
- 2 edits in trunk/Source/WebCore
WebGL2 clientWaitSync does not flush when requested
https://bugs.webkit.org/show_bug.cgi?id=227064
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Kenneth Russell.
Flush when clientWaitSync is called with SYNC_FLUSH_COMMANDS_BIT.
Theoretically the sync object might not be inserted to the command
buffer unless the wait flushes or client ensures flush by other
means.
No new tests, hard to observe externally.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::clientWaitSync):
- 11:10 AM Changeset in webkit [278943] by
-
- 2 edits in trunk/Source/WebCore
[Hardening] Better protect against overflows in the WebAudioBufferList constructor
https://bugs.webkit.org/show_bug.cgi?id=227077
<rdar://problem/78222665>
Reviewed by Geoffrey Garen.
Make sure
sizeof(AudioBuffer) * std::max(1U, bufferCount)doesn't overflow.
- platform/audio/cocoa/WebAudioBufferList.cpp:
(WebCore::WebAudioBufferList::WebAudioBufferList):
- 11:08 AM Changeset in webkit [278942] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
RegisterSet should be smaller
https://bugs.webkit.org/show_bug.cgi?id=227078
Reviewed by Geoff Garen.
Previously, every RegisterSet would have an extra 64-bit word in it just to hold state
relevant to hashtable keys.
But RegisterSet is almost never used as a hashtable key.
This patch moves the hashtable key support into a subclass, HashableRegisterSet. That class
ends up only being used in one place.
On ARM64, this makes RegisterSet use 64 bits instead of 128 bits.
On X86_64, this makes RegisterSet use 32 bits instead of 64 bits.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLSlowPathCallKey.h:
(JSC::FTL::SlowPathCallKey::SlowPathCallKey):
- jit/HashableRegisterSet.h: Added.
(JSC::HashableRegisterSet::HashableRegisterSet):
(JSC::HashableRegisterSet::isEmptyValue const):
(JSC::HashableRegisterSet::isDeletedValue const):
(JSC::RegisterSetHash::hash):
(JSC::RegisterSetHash::equal):
- jit/RegisterSet.h:
(): Deleted.
(JSC::RegisterSet::isEmptyValue const): Deleted.
(JSC::RegisterSet::isDeletedValue const): Deleted.
(JSC::RegisterSetHash::hash): Deleted.
(JSC::RegisterSetHash::equal): Deleted.
- 11:00 AM Changeset in webkit [278941] by
-
- 13 edits3 deletes in trunk/Source/WebKit
Clean up WebCookieManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=227074
Reviewed by Brady Eidson.
Remove dead code. WKCookieManagerSetClient is deprecated and doesn't do anything, so we don't need a client here.
Use smart pointers instead of raw pointers to be on the safe side.
- Shared/API/APIObject.h:
- Sources.txt:
- SourcesCocoa.txt:
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/APIInspectorExtension.cpp:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::initializeClient): Deleted.
(WebKit::WebCookieManagerProxy::setCookieObserverCallback): Deleted.
- UIProcess/WebCookieManagerProxy.h:
(WebKit::WebCookieManagerProxy::create): Deleted.
- UIProcess/WebCookieManagerProxy.messages.in:
- UIProcess/WebCookieManagerProxyClient.cpp: Removed.
- UIProcess/WebCookieManagerProxyClient.h: Removed.
- UIProcess/mac/WebCookieManagerProxyMac.mm: Removed.
- WebKit.xcodeproj/project.pbxproj:
- 10:57 AM Changeset in webkit [278940] by
-
- 2 edits in branches/safari-612.1.19-branch/Source/ThirdParty/libwebrtc
Cherry-pick r278886. rdar://problem/79405770
REGRESSION: [ BigSur iOS wk1 Debug ] imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=226928
<rdar://problem/79205526>
Reviewed by Eric Carlson.
- Source/webrtc/rtc_base/task_queue_stdlib.cc: thread_ is created in TaskQueueStdlib constructor before other members pending_queue_ or delayed_queue_. It might happen that thread_ will start executing its callback which will read delayed_queue_ before it is initialized by TaskQueueStdlib constructor. Update to create thread_ before all other members.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:40 AM Changeset in webkit [278939] by
-
- 2 edits in trunk/LayoutTests
Fix test expectations for plugin tests on arm64
https://bugs.webkit.org/show_bug.cgi?id=226783
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:16 AM Changeset in webkit [278938] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r274461): [macOS wk1] fast/repaint/canvas-object-fit.html is flakey text failing
https://bugs.webkit.org/show_bug.cgi?id=223283
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Re-add a flaky expectation.
- 9:09 AM Changeset in webkit [278937] by
-
- 4 edits1 add in trunk
AssemblyHelpers should save/restore callee save FPRs
https://bugs.webkit.org/show_bug.cgi?id=227052
<rdar://77080162>
Reviewed by Mark Lam.
JSTests:
- stress/callee-save-fpr.js: Added.
(_f):
(_g):
(_h):
(_i):
(assertEqual):
Source/JavaScriptCore:
We have 3 functions in AssemblyHelpers to save and restore callee save registers that were filtering
out any FPRs. This is an issue since we do have callee save FPRs in arm64 and these functions can be
called from the FTL, and FTL uses those callee saves. The test case shows how that's an issue with tail
calls on FTL: the callee saves are correctly stored in the prologue and restored in the epilogue, but
when emitting a tail call we use AssemblyHelpers::emitRestoreCalleeSaves to restore the callee saves,
which doesn't restore FPRs. This results in the callee save FPRs being trashed. To fix this we just need
to stop filtering out the FPRs, if they are listed as used by the code block they should be saved/restored
accordingly. I also changed DFGOSREntry to stop filtering out the callee save FPRs and instead assert
there aren't any, since they aren't currently used in the DFG, but it could help avoid the same issue in
the future.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveOrCopyCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
- 8:41 AM Changeset in webkit [278936] by
-
- 4 edits in trunk
[WTF] DataMutex: Assert on double locking on the same thread
https://bugs.webkit.org/show_bug.cgi?id=227069
Reviewed by Xabier Rodriguez-Calvar.
Source/WTF:
DataMutex used to use OwnerAwareLock to track what thread is holding
the mutex and emit assertion errors if a thread is found attempting to
lock a mutex held by that same thread. This turns deadlocks into
runtime errors.
OwnerAwareLock was removed when DataMutex got clang thread safety
annotations. This patch reintroduces the same logic, while keeping
thread-safety annotations.
This fixes WTF_DataMutex.DoubleLockDeathTest, which tested this
functionality and was previously regressed.
- wtf/DataMutex.h:
Tools:
Update expectations to include the fixed test.
- TestWebKitAPI/glib/TestExpectations.json:
- 8:16 AM Changeset in webkit [278935] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] gst_element_get_request_pad deprecated in 1.20
https://bugs.webkit.org/show_bug.cgi?id=226974
Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-16
Reviewed by Xabier Rodriguez-Calvar.
In GStreamer 1.20 gst_element_get_request_pad() was renamed to gst_element_request_pad_simple(),
so create an alias for older versions.
- platform/graphics/gstreamer/GStreamerAudioMixer.cpp:
(WebCore::GStreamerAudioMixer::registerProducer):
- platform/graphics/gstreamer/GStreamerCommon.h:
- 8:14 AM Changeset in webkit [278934] by
-
- 6 edits in trunk/Source/WebKit
Clean up API::HTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=227058
Reviewed by Anders Carlsson.
This removes code that has been unused since r267763.
I also use smart pointers instead of raw pointers just to be on the safe side.
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookiesDidChange):
(API::HTTPCookieStore::cookieManagerDestroyed): Deleted.
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::generateListenerIdentifier): Deleted.
(WebKit::processPoolCreationListenerFunctionMap): Deleted.
(WebKit::WebProcessPool::registerProcessPoolCreationListener): Deleted.
(WebKit::WebProcessPool::unregisterProcessPoolCreationListener): Deleted.
(WebKit::WebProcessPool::notifyThisWebProcessPoolWasCreated): Deleted.
- UIProcess/WebProcessPool.h:
- 7:37 AM Changeset in webkit [278933] by
-
- 8 edits in trunk
Make CSS.supports() return false for internal CSS properties
https://bugs.webkit.org/show_bug.cgi?id=224930
Reviewed by Antti Koivisto.
Test: LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html
Examples that are now rejected:
CSS.supports("background-repeat-x: inherit")
CSS.supports("background-repeat-x", "inherit")
CSS.supports("background-repeat-y: inherit")
CSS.supports("background-repeat-y", "inherit")
Source/WebCore:
- css/DOMCSSNamespace.cpp:
(WebCore::DOMCSSNamespace::supports):
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeDeclaration):
LayoutTests:
- fast/backgrounds/background-repeat-x-y-parse-expected.txt:
- fast/backgrounds/background-repeat-x-y-parse.html:
- fast/css/webkit-mask-crash-implicit-expected.txt:
- fast/css/webkit-mask-crash-implicit.html:
- 7:27 AM Changeset in webkit [278932] by
-
- 3 edits2 adds in trunk
[MSE] Crash when getting audioTracks, videoTracks, textTracks of sourceBuffer after executing MediaSource::removeSourceBuffer()
https://bugs.webkit.org/show_bug.cgi?id=227018
Patch by Toshio Ogasawara <toshio.ogasawara@access-company.com> on 2021-06-16
Reviewed by Eric Carlson.
Source/WebCore:
Fixed not to refer to m_source when isRemoved() is true in SourceBuffer::videoTracks(),
SourceBuffer::audioTracks(), SourceBuffer::textTracks().
Test: media/media-source/media-source-get-tracks-crash.html
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):
LayoutTests:
- media/media-source/media-source-get-tracks-crash-expected.txt: Added.
- media/media-source/media-source-get-tracks-crash.html: Added.
- 6:44 AM Changeset in webkit [278931] by
-
- 20 edits4 adds in trunk
Content moves up when hovering over a link on Hacker News
https://bugs.webkit.org/show_bug.cgi?id=226852
<rdar://78537231>
Reviewed by Antti Koivisto.
Source/WebCore:
Legacy line layout integral-rounds the root inline box's vertical position and this integral position
gets propagated down to the descendant inline boxes when descendantsHaveSameLineHeightAndBaseline() is true.
See LegacyInlineFlowBox::addToLine and LegacyInlineFlowBox::placeBoxesInBlockDirection for more details.
This patch attempts to mirror this behavior in IFC.
Test: fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):
LayoutTests:
- fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes-expected.html: Added.
- fast/inline/hidpi-legacy-integral-rounding-on-inline-boxes.html: Added.
- 6:36 AM Changeset in webkit [278930] by
-
- 3 edits2 adds in trunk
Nullptr crash in positionInParentBeforeNode via InsertTextCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=226870
Patch by Frederic Wang <fwang@igalia.com> on 2021-06-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
deleteSelection call In InsertTextCommand::doApply() can make the endingSelection() orphan.
If that happens, exit early to avoid dereferencing a nullptr pointer later.
Test: fast/editing/insert-text-orphaned-summary-crash.html
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
LayoutTests:
Add regression test.
- fast/editing/insert-text-orphaned-summary-crash-expected.txt: Added.
- fast/editing/insert-text-orphaned-summary-crash.html: Added.
- 4:52 AM Changeset in webkit [278929] by
-
- 4 edits in trunk/Source
ANGLE Metal gl sync objects do not work in case of listener being needed
https://bugs.webkit.org/show_bug.cgi?id=227024
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Per Arne Vollan.
Source/ThirdParty/ANGLE:
Add an assert to notice when MTLSharedEventListener instantiation
fails. Without this, the fence implementation would not signal
the completion until the timeout would pass.
- src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::DisplayMtl::getOrCreateSharedEventListener):
Source/WebKit:
Make MTLSharedEventListener instantiatable by adding IOKit messages
39 and 40 to IOSurfaceRootUserClientMessageFilter.
The MTLSharedEventListener init would fail, and ANGLE would fail to
make the shared event signal the event listener. This would cause
all glClientWaitSync calls to wait the full timeout time.
No new tests, WebGL2 sync object implementation does not support
non-zero timeout values that would be needed to detect the failure.
Standalone test-cases would need the test runner being sandboxed,
which is not implemented currently.
- WebProcess/com.apple.WebProcess.sb.in:
- 2:45 AM Changeset in webkit [278928] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r278846.
https://bugs.webkit.org/show_bug.cgi?id=227060
Speculative revert based on failure history of Speedometer2
Reverted changeset:
"Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and
select this instruction in Air"
https://bugs.webkit.org/show_bug.cgi?id=226937
https://trac.webkit.org/changeset/278846
- 1:56 AM Changeset in webkit [278927] by
-
- 10 edits in trunk/Source
Update Media Accessibility preferences in the WebContent process from the UI process
https://bugs.webkit.org/show_bug.cgi?id=227031
<rdar://78614882>
Reviewed by Eric Carlson.
Due to stricter sandboxing in the WebContent process, Media Accessibility preferences should be updated from the UI process.
Source/WebCore:
The preferences for caption display mode and preferred caption languages are being cached, and the cached value will be used
if it has been set.
- WebCore.xcodeproj/project.pbxproj:
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::cachedCaptionDisplayMode):
(WebCore::cachedPreferredLanguages):
(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode const):
(WebCore::CaptionUserPreferencesMediaAF::platformCaptionDisplayMode):
(WebCore::CaptionUserPreferencesMediaAF::setCachedCaptionDisplayMode):
(WebCore::CaptionUserPreferencesMediaAF::preferredLanguages const):
(WebCore::CaptionUserPreferencesMediaAF::platformPreferredLanguages):
(WebCore::CaptionUserPreferencesMediaAF::setCachedPreferredLanguages):
- page/CaptionUserPreferencesMediaAF.h:
Source/WebKit:
The preferences for caption display mode and preferred caption languages will be sent to the WebContent process on process
startup and when the preference has been changed.
- Shared/AccessibilityPreferences.cpp:
(IPC::ArgumentCoder<WebKit::AccessibilityPreferences>::encode):
(IPC::ArgumentCoder<WebKit::AccessibilityPreferences>::decode):
- Shared/AccessibilityPreferences.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
- 1:40 AM Changeset in webkit [278926] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
ANGLE Metal AutoObjCPtr == nullptr comparison is inverted
https://bugs.webkit.org/show_bug.cgi?id=227026
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-06-16
Reviewed by Anders Carlsson.
Make it more correct and add != nullptr variant for
consistency.
Use std::nullptr_t instead of const std::nullptr_t &
in all functions for consistency.
- src/libANGLE/renderer/metal/mtl_common.h:
(rx::mtl::AutoObjCPtr::operator== const):
(rx::mtl::AutoObjCPtr::operator!= const):
- 1:15 AM Changeset in webkit [278925] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] clang analysis: Unlocked access in ImageDecoderGStreamer.cpp
https://bugs.webkit.org/show_bug.cgi?id=226495
Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-16
Reviewed by Adrian Perez de Castro.
Remove unlocked access to the the m_messageDispatched instance variable. Also there is no
need to wait on the condition if the dispatching happens synchronously in the current
thread. No need to notify the condition either before dispatching, the only call to wait()
is after the asynchronous dispatch has been scheduled.
- platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::InnerDecoder::preparePipeline):
- 1:11 AM Changeset in webkit [278924] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening, add some new Timing-Allow-Origin failures
https://bugs.webkit.org/show_bug.cgi?id=227008
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-06-16
- platform/glib/TestExpectations:
- 12:37 AM Changeset in webkit [278923] by
-
- 34 edits in trunk/Source
Replace invalidSnapOffsetIndex with std::optional<unsigned>
https://bugs.webkit.org/show_bug.cgi?id=226654
Reviewed by Simon Fraser.
Use std::optional<unsigned> in order to represent the situation
where we do not have a snap point selected rather than UINT_MAX.
Source/WebCore:
No new tests. This should not change behavior.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setActiveScrollSnapIndices):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::indicesOfNearestSnapOffsets): Return a std::pair instead of splitting the
return values into the argument list.
(WebCore::closestSnapOffsetWithInfoAndAxis):
(WebCore::LayoutScrollSnapOffsetsInfo::closestSnapOffset const):
(WebCore::FloatScrollSnapOffsetsInfo::closestSnapOffset const):
- page/scrolling/ScrollSnapOffsetsInfo.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setCurrentHorizontalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::setCurrentVerticalSnapPointIndex):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::currentHorizontalSnapPointIndex const):
(WebCore::ScrollingStateScrollingNode::currentVerticalSnapPointIndex const):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::setActiveScrollSnapIndices):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::dumpProperties const):
- page/scrolling/ScrollingTreeScrollingNode.h: Move some methods into the
source file to satisfy the style checker. WEBCORE_EXPORT is applied to the
entire class declaration.
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::activeScrollSnapIndexForAxis const):
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::activeScrollSnapIndexForAxis const):
(WebCore::ScrollAnimator::setActiveScrollSnapIndexForAxis):
- platform/ScrollAnimator.h:
- platform/ScrollController.cpp:
(WebCore::ScrollController::activeScrollSnapIndexForAxis const):
(WebCore::ScrollController::setActiveScrollSnapIndexForAxis): When there is no new
snap index, we need to actively change the value to std::nullopt. This wasn't
necessary because ScrollableArea was covering up this case in the past as a side-effect.
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):
(WebCore::ScrollController::resnapAfterLayout): Also resnap if the snapped index is
greater than the current one. This case was being covered up by a side-effect in
ScrollableArea.
- platform/ScrollController.h:
- platform/ScrollSnapAnimatorState.cpp:
(WebCore::ScrollSnapAnimatorState::setupAnimationForState):
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset const): Return a std::pair
instead of splitting the output values into the argument list.
- platform/ScrollSnapAnimatorState.h:
(WebCore::ScrollSnapAnimatorState::activeSnapIndexForAxis const):
(WebCore::ScrollSnapAnimatorState::setActiveSnapIndexForAxis):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::currentHorizontalSnapPointIndex const):
(WebCore::ScrollableArea::currentVerticalSnapPointIndex const):
(WebCore::ScrollableArea::setCurrentHorizontalSnapPointIndex):
(WebCore::ScrollableArea::setCurrentVerticalSnapPointIndex):
(WebCore::ScrollableArea::resnapAfterLayout):
- platform/ScrollableArea.h:
Source/WebKit:
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::currentSnapPointIndicesDidChange):
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::currentSnapPointIndicesDidChange):
- UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
- UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping):
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling const):
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange const):
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::currentSnapPointIndicesChangedForNode):
