Timeline



Aug 18, 2021:

9:04 PM Changeset in webkit [281223] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process
<​https://webkit.org/b/229264>
<rdar://problem/82101153>

Reviewed by Anders Carlsson.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

  • platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::initialize):

  • Use adoptCF() to fix the leak since CMBufferQueueCreate() returns a retained object.
8:42 PM Changeset in webkit [281222] by ysuzuki@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

[JSC] Remove op_has_indexed_property related code
​https://bugs.webkit.org/show_bug.cgi?id=229271

Reviewed by Saam Barati.

After our new for-in protocol, op_has_indexed_property is removed.
As a result, we can remove many ByValInfo code that is used only
for op_has_indexed_property.

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitLoadForArrayMode): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileHasIndexedProperty): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileHasIndexedProperty): Deleted.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad): Deleted.
(JSC::JIT::emitContiguousLoad): Deleted.
(JSC::JIT::emitArrayStorageLoad): Deleted.

8:40 PM Changeset in webkit [281221] by ddkilzer@apple.com
  • 6 edits in trunk

Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process
<​https://webkit.org/b/229265>
<rdar://problem/82101453>

Reviewed by Alex Christensen.

Source/WebKit:

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetGPUProcessIdentifier): Add.

  • UIProcess/API/C/WKPagePrivate.h:

(WKPageGetGPUProcessIdentifier): Add.

  • Add function to return the PID for the GPU process.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::findAndDumpWebKitProcessIdentifiers):

  • Include the GPU process PID if it's enabled when sending a list of PIDs back to run-webkit-tests.

(WTR::TestController::gpuProcessName): Add.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::databaseProcessName): Delete.

  • The implementation was removed a while ago.

(WTR::TestController::gpuProcessName): Add.

8:34 PM Changeset in webkit [281220] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process
<​https://webkit.org/b/229262>
<rdar://problem/82076765>

Reviewed by Darin Adler.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

  • platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:

(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):

  • Update signature to return RetainPtr<CMSampleBufferRef>.
  • platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):

  • Update signature to return RetainPtr<CMSampleBufferRef>.
  • Rename sampleBuffer to rawSampleBuffer to match similar pattern used in other code, then use sampleBuffer to store rawSampleBuffer wrapped in a RetainPtr<>.

(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):

  • Add get() to buffer variable since it is now a RetainPtr<>.
6:15 PM Changeset in webkit [281219] by clopez@igalia.com
  • 3 edits
    11 adds in trunk/LayoutTests

[GTK][WPE] Gardening of layout tests

Unreviewed test gardening.

Mark expected failures after r281108 and others and update list of flaky tests.
Rebaseline tests after r281136, r281127 and r281097.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
5:34 PM Changeset in webkit [281218] by Fujii Hironori
  • 5 edits in trunk/LayoutTests

[Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing
​https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

WebKit1 doesn't properly support keepalive fetch. Marked it as
flaky. Increased the number of fetches for testing WebKit2 more.

  • http/tests/fetch/keepalive-fetch-2.html:
  • http/tests/fetch/resources/keepalive-fetch-2-window.html:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
5:20 PM Changeset in webkit [281217] by rniwa@webkit.org
  • 2 edits in trunk/Source/WTF

[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
​https://bugs.webkit.org/show_bug.cgi?id=229250

Reviewed by Wenson Hsieh.

Disable the assertion when Web Thread is enabled for now.

  • wtf/CheckedRef.h:

(WTF::SingleThreadIntegralWrapper::assertThread const):

5:20 PM Changeset in webkit [281216] by Jonathan Bedard
  • 3 edits in trunk/Tools

[run-webkit-tests] Remember failures when repeating test
​https://bugs.webkit.org/show_bug.cgi?id=229217
<rdar://problem/81919223>

Reviewed by Ryan Haddad.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.update_summary_with_result): Replace existing result with unexpected result so
that unexpected results always take precedence over expected ones.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.add): Do not replace existing result.

4:14 PM Changeset in webkit [281215] by Chris Dumez
  • 7 edits in trunk

Unreviewed, reverting r281206.

Reverting because of branching, will re-land soon

Reverted changeset:

"Implement Crypto.randomUUID()"
​https://bugs.webkit.org/show_bug.cgi?id=229240
​https://commits.webkit.org/r281206

3:04 PM Changeset in webkit [281214] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Revert "Cherry-pick r280463. rdar://problem/82088775"

This reverts commit r281207.

3:04 PM Changeset in webkit [281213] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Revert "Cherry-pick r280505. rdar://problem/82088775"

This reverts commit r281208.

3:00 PM Changeset in webkit [281212] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1 Debug] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229252.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:41 PM Changeset in webkit [281211] by Lauro Moura
  • 2 edits in trunk/Tools

REGRESSION(r279169) [WebDriver] WPT Tools now requires python3 to launch the server
​https://bugs.webkit.org/show_bug.cgi?id=229248

Reviewed by Chris Dumez.

239066@main updated the layout test WPT tools to
94d018bb5d7c0d46df7ba1 and this version requires Python3 to run the
WPT server.

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:

(WebDriverW3CWebServer.start):

2:17 PM Changeset in webkit [281210] by Megan Gardner
  • 5 edits in trunk/Source

Remove unneeded UIKitSPI declarations
​https://bugs.webkit.org/show_bug.cgi?id=210075

Reviewed by Wenson Hsieh.

Source/WebKit:

No code changes, just using the now fully public API.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(gestureRecognizerModifierFlags): Deleted.

Source/WTF:

Remove unneeded feature define.

  • wtf/PlatformHave.h:
1:21 PM Changeset in webkit [281209] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[Win] http/tests/fetch/keepalive-fetch-2.html is randomly failing
​https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

  • platform/win/TestExpectations: Marked it as flaky.
  • platform/wincairo-wk1/TestExpectations: Ditto.
12:51 PM Changeset in webkit [281208] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Cherry-pick r280505. rdar://problem/82088775

putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
​https://bugs.webkit.org/show_bug.cgi?id=227963

Reviewed by Alexey Shvayka.

JSTests:

  • stress/reflect-set-custom-value.js:

Source/JavaScriptCore:

Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
test both the reified and non-reified cases.

  • runtime/JSObject.cpp: (JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
  • tools/JSDollarVM.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:51 PM Changeset in webkit [281207] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch

Cherry-pick r280463. rdar://problem/82088775

definePropertyOnReceiver should check if receiver canPerformFastPutInline
​https://bugs.webkit.org/show_bug.cgi?id=227963
<rdar://80259710>

Reviewed by Alexey Shvayka.

JSTests:

  • stress/reflect-set-custom-value.js: Added.

Source/JavaScriptCore:

definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
transitively putDirectInternal<PutModePut>). The issue is that putDirectInternal does not
handle customValues correctly: it just overwrites the property without changing the attributes.
To fix that, we should first check if the property might be a custom value, and if that's the case
we now call definePropertyOnReceiverSlow, which has been updated to handle custom values correctly.
I also added assertions to putInlineFastReplacingStaticPropertyIfNeeded and putDirectInternal
to make sure we don't accidentally overwrite custom values in the future.

  • runtime/JSObject.cpp: (JSC::definePropertyOnReceiverSlow): (JSC::JSObject::definePropertyOnReceiver): (JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
  • runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@280463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:13 PM Changeset in webkit [281206] by Chris Dumez
  • 7 edits in trunk

Implement Crypto.randomUUID()
​https://bugs.webkit.org/show_bug.cgi?id=229240

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

  • web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
  • web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:

Source/WebCore:

Implement Crypto.randomUUID():

Chrome already implements this and Firefox seems to be working on it
(​https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).

No new tests, rebaselined existing tests.

  • page/Crypto.cpp:

(WebCore::Crypto::randomUUID const):

  • page/Crypto.h:
  • page/Crypto.idl:
12:05 PM Changeset in webkit [281205] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac Debug] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=229244.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:32 AM Changeset in webkit [281204] by Russell Epstein
  • 1 edit
    2 adds in branches/safari-612.1.27.0-branch/LayoutTests

Cherry-pick r281195. rdar://problem/82083653

Add a layout test for webkit.org/b/229200
​https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:31 AM Changeset in webkit [281203] by Russell Epstein
  • 2 edits in branches/safari-612.1.27.0-branch/Source/WebKit

Cherry-pick r281186. rdar://problem/82083653

REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
​https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in ​https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a useCount counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment useCount in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of useCount will fall out of sync with the GPU process' notion of useCount.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where f is a cached
web font, A_f is a drawing command that uses f, and B_f is another drawing command that uses f).

WEB GPU
==============================================================

  1. Cache f
  2. Append A_f
    1. Cache f
    2. Play back A_f
  3. Append B_f
  4. Release f (use count was 1 here)
    1. Release f (use count dropped from 1 to 0)
    2. Play back B_f ...and then display list playback stops due to f not being in the cache.

To address this, we simply move the useCount increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for useCount to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::recordFontUse):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:31 AM Changeset in webkit [281202] by Russell Epstein
  • 4 edits in branches/safari-612.1.27.0-branch/Source/JavaScriptCore

Cherry-pick r281178. rdar://problem/82083485

Add an option for canonicalizePrePostIncrements
​https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
​https://bugs.webkit.org/show_bug.cgi?id=228538

  • b3/B3Generate.cpp: (JSC::B3::generateToAir):
  • b3/testb3_3.cpp: (addShrTests):
  • runtime/OptionsList.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:04 AM Changeset in webkit [281201] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

[MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229238

Reviewed by Eric Carlson.

Manually tested.

  • GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureAudioInGPUProcessEnabled):
Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.

10:57 AM Changeset in webkit [281200] by Andres Gonzalez
  • 9 edits
    2 adds in trunk

Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.
​https://bugs.webkit.org/show_bug.cgi?id=229220
<rdar://problem/82057459>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/line-index-for-textmarker.html

There was not a layout test that exercised directly the handler for the
AXLineForTextMarker attribute in [WebAccessibilityObjectWrapper
accessibilityAttributeValue:withParameter:].
This patch adds the above test to exercise this method for textarea and
contenteditable elements. The text in these elements includes soft and
hard linebreaks, which are important test cases for this API.
The handler for AXLineForTextMarker in turn calls
AccessibilityObject::lineForPosition, and analyzing this method, made a
minor optimization by getting rid off of an unnecessary local variable
and object copy.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::lineForPosition const):

Tools:

Added AccessibilityUIElement::lineIndexForTextMarker.

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::lineIndexForTextMarker const):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::lineIndexForTextMarker const):

LayoutTests:

  • accessibility/mac/line-index-for-textmarker-expected.txt: Added.
  • accessibility/mac/line-index-for-textmarker.html: Added.
  • platform/mac-wk1/TestExpectations:
10:45 AM Changeset in webkit [281199] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Do not terminate relaunched network process when getting network process connection
​https://bugs.webkit.org/show_bug.cgi?id=229236

Reviewed by Chris Dumez.

When UI process fails to get network process connection for the first time, it will retry on next runloop
iteration. On the retry, it terminates existing network process and relaunch a network process, because the
failure may indicate something is wrong in the network process. If existing network process is different from
the one on first try, the existing process can be functional and we should not terminate it.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

10:42 AM Changeset in webkit [281198] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Update feature statuses in features.json
​https://bugs.webkit.org/show_bug.cgi?id=229212

Reviewed by Wenson Hsieh.

Update the status of various features in features.json to reflect their current state.

Remove "enabled-by-default": true from features that are marked as Supported.

  • features.json:
10:19 AM Changeset in webkit [281197] by Jonathan Bedard
  • 4 edits in trunk/Tools

[git-webkit] "IndexError: list index out of range" using log
​https://bugs.webkit.org/show_bug.cgi?id=229232

Reviewed by Ryan Haddad.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand.pager):

10:16 AM Changeset in webkit [281196] by Megan Gardner
  • 2 edits in trunk/Source/WebCore

Add Highlight API to features.json
​https://bugs.webkit.org/show_bug.cgi?id=208226

Reviewed by Simon Fraser.

  • features.json:
9:58 AM Changeset in webkit [281195] by Wenson Hsieh
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for webkit.org/b/229200
​https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
  • fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.
9:58 AM Changeset in webkit [281194] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1] css/css-position/position-relative-table* tests fail.
​https://bugs.webkit.org/show_bug.cgi?id=203449.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:50 AM Changeset in webkit [281193] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r280723): Protected HLS + EME playback fails with "temporary error"
​https://bugs.webkit.org/show_bug.cgi?id=229201
<rdar://81807216>

Reviewed by Eric Carlson.

In r280723, we stopped unconditionally creating an AVPlayerLayer when we create an AVPlayer. However,
we will still create an AVPlayerItemVideoOutput when we create an AVPlayerItem. This leaves our
AVPlayer in a state where AVFoundation will throw a "temporary error; try again later" when given
an otherwise valid protected HLS stream and key data through EME.

To work around this behavior, delay creating the AVPlayerItemVideoOutput until explicitly told to
create video renderers, typically simultaneous to creating an AVPlayerLayer.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):

9:46 AM Changeset in webkit [281192] by commit-queue@webkit.org
  • 11 edits in trunk

REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files
​https://bugs.webkit.org/show_bug.cgi?id=229152

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-08-18
Reviewed by Philippe Normand.

Source/JavaScriptCore:

  • PlatformGTK.cmake:
  • javascriptcoregtk.pc.in:

Source/WebKit:

CMake is expanding templates in the pkg-config files that are not supposed to be expanded.
Oops! Let's switch back to using @SVN_REVISION@ instead of ${SVN_REVISION} as the template
for inserting the SVN revision into the pkg-config file, so we can tell CMake to leave the
${} variables alone.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • Shared/glib/BuildRevision.h.in:
  • gtk/webkit2gtk-web-extension.pc.in:
  • gtk/webkit2gtk.pc.in:

Tools:

  • glib/apply-build-revision-to-files.py:

(main):

9:34 AM Changeset in webkit [281191] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[webkitcorepy] Add CallByNeed object
​https://bugs.webkit.org/show_bug.cgi?id=229148
<rdar://problem/81817705>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version, export Defer object.
  • Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py: Added.

(CallByNeed):
(CallByNeed.init):
(CallByNeed.getattribute): Depending on the request attribute, either return it or attempt to
resolve the underlying value before returning the attribute of the resolved value.
(CallByNeed.value): Resolve and return underlying object.
(CallByNeed.call): Ditto.
(CallByNeed.repr): Resolve object and return representation.
(CallByNeed.str): Resolve object and return string conversion.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/call_by_need_unittest.py: Added.

(TestCallByNeed):
(TestCallByNeed.test_basic):
(TestCallByNeed.test_string_conversion):
(TestCallByNeed.test_attribute_forwarding):
(TestCallByNeed.test_failed_attribute_forwarding):

9:22 AM Changeset in webkit [281190] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ MacOS EWS ] inspector/canvas/recording-2d-memoryLimit.html is flaky crashing..
​https://bugs.webkit.org/show_bug.cgi?id=229237

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:59 AM Changeset in webkit [281189] by Martin Robinson
  • 6 edits in trunk

[css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls
​https://bugs.webkit.org/show_bug.cgi?id=227949
<rdar://problem/80895783>

Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt: This bidirectional

scrolling test no longer snaps because we don't have support for choosing between two candidates
properly yet.

  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt: Updated to show newly passing test.
  • web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt: Ditto.

Source/WebCore:

No new tests. This is covered by two existing WPT tests.

  • page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::componentForAxis): Added this helper.
(WebCore::hasCompatibleSnapArea): Added this helper that checks to see if any of the snap areas
at a given scroll snap position are compatible with the viewport.
(WebCore::adjustPreviousAndNextForOnscreenSnapAreas): Adjusts the selected previous and next snap
positions by looking backward and forward for the first compatible snap position.
(WebCore::closestSnapOffsetWithInfoAndAxis): Use the new helper.

8:25 AM Changeset in webkit [281188] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Crash under JSIntersectionObserverCallback::handleEvent()
​https://bugs.webkit.org/show_bug.cgi?id=229196
<rdar://82016054>

Reviewed by Geoffrey Garen.

Early return in IntersectionObserver::notify() if the callback has already been destroyed.
This is not supposed to happen as we're supposed to be keeping the JSIntersectionObserver
wrapper alive as long as the IntersectionObserver may fire events, which should keep the
callback alive too. However, despite Ryosuke's fix in r280549, the crash is still happening
in the wild. To address the crash, I am simply doing an early return for now, similarly to
what we already do in MutationObserver::deliver(), while keeping a debug assertion around
in hope of finding the root cause at some point.

No new tests, we do not not how this is happening yet.

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::notify):

8:10 AM Changeset in webkit [281187] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.4

6:42 AM Changeset in webkit [281186] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
​https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in ​https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a useCount counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment useCount in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of useCount will fall out of sync with the GPU process' notion of useCount.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where f is a cached
web font, A_f is a drawing command that uses f, and B_f is another drawing command that uses f).

WEB GPU
==============================================================

  1. Cache f
  2. Append A_f
    1. Cache f
    2. Play back A_f
  3. Append B_f
  4. Release f (use count was 1 here)
    1. Release f (use count dropped from 1 to 0)
    2. Play back B_f ...and then display list playback stops due to f not being in the cache.

To address this, we simply move the useCount increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for useCount to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

  • WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::recordFontUse):

6:30 AM Changeset in webkit [281185] by Martin Robinson
  • 6 edits in trunk

position: sticky with display: inline-block
​https://bugs.webkit.org/show_bug.cgi?id=224415
<rdar://problem/76811968>

Reviewed by Simon Fraser.

Source/WebCore:

Improve sticky positioning applied to inline items. The first improvement is to
skip anonymous RenderBlock parents of inline display items when looking for the
containing block used to calculate sticky constraints. These anonymous parents
are not the containing block that constrains the movement of these kind of stickily
positioned items. Instead look for containing block for the anonymous parent,
which does limit the scroll boundaries of inline stickily position items.

Previously, when converting the frame rect from the coordinate space of the stickily
positioned item to that of the scrolling container, the code used to apply the offset
from the containing block to the scrolling ancestor directly to the frame rect. That
doesn't work when the containing block that determines sticky constraints is not the
direct containing block of the stickily positioned items (as it is for inlines).

Instead, the code now just maps the frame rect directly from the item parent to
the scrolling ancestor. This simplifies things a bit and allows it to work with
inline stickily positioned items.

Finally, this change adds comments to make it clearer what this method is doing.

No new tests. This is covered by existing WPT tests. Specifically the following
tests are now passing:

imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-hyperlink.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-table.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-parts.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-th-bottom.html
imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-thead-th.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::positionOffsetValue): enclosingClippingBoxForStickyPosition now returns a pair
to avoid passing in a pointer. Only look at the first part of the pair here.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Modified this method
to return a pair in order to avoid dealing with input parameters. This allows simplifying this
method, making the code a bit simpler.
(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const): Deleted.
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Make two changes
to this method to improve sticky positioning for inline elements. The first change is
to be a bit better about finding the appropriate containing block for calculating sticky
constraints. The second is to more resiliently move from coordinate systems. In addition,
improve the comments for this method to make it clearer what is happening at each step.

  • rendering/RenderBoxModelObject.h: Updated method declaration.

LayoutTests:

a false pass previously.

2:13 AM Changeset in webkit [281184] by Martin Robinson
  • 2 edits in trunk/Tools

[Flatpak SDK] Increase the startup performance of webkit-flatpak
​https://bugs.webkit.org/show_bug.cgi?id=229185

Reviewed by Philippe Normand.

Improve flatpakutils.py by ensuring that we don't make redundant
calls to flatpak during initialization of the data structures. This
saves 5 seconds on every call to build-webkit and run-webkit-tests.

Before:

$ time ./Tools/Scripts/webkit-flatpak -c true
real 0m6,297s
user 0m0,786s
sys 0m0,513s

After:

$ time ./Tools/Scripts/webkit-flatpak -c true
real 0m1,243s
user 0m0,375s
sys 0m0,162s

  • flatpak/flatpakutils.py:

(FlatpakPackages.init): Separate the update into another
method so that it can be called directly when a package is installed.
Add new packages directly to self.packages.
(FlatpakRepos.init): Ensure that we only update our repositories
and package list once we've initialized our list of repositories.
(FlatpakRepos.add): Return True if this method actually changed anything
and accept a parameter determining whether an update is done to
the repository and package list.
(FlatpakRepos.is_package_installed): Added this method which replaces
FlatpakRepo.is_app_installed.
(FlatpakRepo.init): Remove the app registry because it is duplicated
by FlatpakPackages.
(FlatpakPackage.is_installed): Now call FlatpakRepos.is_package_installed.
(WebkitFlatpak._reset_repository): Set up both repositories here and
pass then as part of the FlatpakRepos constructor.
(WebkitFlatpak.main): Separate out the check which deletes the Flatpak
repository from the one that checks if the packages are installed. This
makes sure we don't install packages and then immediately delete them.
(WebkitFlatpak.check_installed_packages): rename _get_packages to _get_dependency_packages
in order to make it clear that it doesn't return installed packages.
(WebkitFlatpak._get_dependency_packages): Ditto.
(WebkitFlatpak.install_all): Ditto.
(FlatpakRepo.is_app_installed): Deleted.
(WebkitFlatpak._get_packages): Deleted.

1:26 AM Changeset in webkit [281183] by calvaris@igalia.com
  • 5 edits
    1 add in trunk/Source

[GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests
​https://bugs.webkit.org/show_bug.cgi?id=229145

Reviewed by Alicia Boya Garcia.

Source/WebCore:

Added GStreamerEMEUtilities to include implementation of
InitData::extractCencIfNeeded. This tries to parse the possible
XML inside an init data that could come from MPD manifests. If it
succeeds, it keeps the parsed init data, if not, it returns the
original one.

Based on a patch by Philippe Normand.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.

(WebCore::markupStartElement):
(WebCore::markupEndElement):
(WebCore::markupText):
(WebCore::markupPassthrough):
(WebCore::markupError):
(WebCore::InitData::extractCencIfNeeded):

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):

Source/WTF:

  • wtf/glib/GUniquePtr.h: Added deleter for GMarkupParseContext.

Aug 17, 2021:

11:50 PM Changeset in webkit [281182] by Devin Rousso
  • 9 edits in trunk/Source

Web Inspector: match the undocked tab bar style when docked bottom/side
​https://bugs.webkit.org/show_bug.cgi?id=212398

Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::platformVersionName const):
Add macOS Monterey.

Source/WebInspectorUI:

This will avoid confusion when switching from docked to undocked (and vice versa) as the tab
bar UI will no longer be significantly different.

  • UserInterface/Views/TabBar.js:

(WI.TabBar):
(WI.TabBar.prototype.layout):
(WI.TabBar.prototype.layout.measureWidth):
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WI.TabBar.prototype._applyTabBarItemSizesAndPositions):
(WI.TabBar.prototype._clearTabBarItemSizesAndPositions):
(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleMouseMoved):
(WI.TabBar.get horizontalPadding): Deleted.
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions.add): Deleted.

  • UserInterface/Views/TabBar.css:

(.tab-bar):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar): Added.
(.tab-bar > .tabs > .item):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(.tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)):
(.tab-bar > .tabs > .item:nth-child(n + 2 of :not(.hidden)), .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(1 of :not(.hidden)), .tab-bar > .tabs.dragging-tab > .item.selected):
(.tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(.tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover, .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover + .item):
(.tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover):
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(body.window-inactive .tab-bar > .tabs > .item):
(body.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):
(.tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(body.window-inactive .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body.window-inactive .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body.window-inactive .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body.big-sur .tab-bar): Deleted.
(body:not(.docked) .tab-bar): Deleted.
(body.big-sur:not(.docked) .tab-bar): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar): Deleted.
(body.big-sur:not(.docked).window-inactive .tab-bar, body:not(.big-sur):not(.docked).window-inactive .tab-bar): Deleted.
(body.docked.window-inactive .tab-bar): Deleted.
(body.docked.bottom .tab-bar > .border.top): Deleted.
(body.big-sur.docked .tab-bar > .border.bottom): Deleted.
(body.docked .tab-bar .tabs): Deleted.
(body.docked .tab-bar > .tabs > .flexible-space): Deleted.
(body.docked.bottom .tab-bar > .tabs > .flexible-space): Deleted.
(body:not(.docked) .tab-bar > .tabs > .item): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs > .item): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)): Deleted.
(body.docked .tab-bar > .tabs > .item): Deleted.
(body:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)), body:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(2 of :not(.hidden)), .tab-bar > .tabs.dragging-tab > .item.selected): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))): Deleted.
(body.docked .tab-bar > .tabs > .item.pinned): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.docked .tab-bar > .tabs > .item:not(.disabled):matches(.selected, :hover)): Deleted.
(body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body.docked .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover, body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover + .item): Deleted.
(body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item, body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body.docked.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(body:not(.docked) .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body:not(.docked) .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body:not(.docked) .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected): Deleted.
(body:not(.docked).window-inactive .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body:not(.docked).window-inactive .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body:not(.docked).window-inactive .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur .tab-bar, body:not(.big-sur) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.docked.bottom .tab-bar > .border.top): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Deleted.
(@media (prefers-color-scheme: dark) body.docked .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body.docked.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover > .icon): Deleted.
(@media (prefers-color-scheme: dark) body:not(.docked).window-inactive .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar, body:not(.big-sur):not(.docked).window-inactive .tab-bar): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected): Deleted.

  • UserInterface/Views/TabBarItem.js:

(WI.TabBarItem.get horizontalMargin): Deleted.

  • remove the flexible space filler elements (and associated CSS) before and after the tabs
  • remove any .docked CSS
  • remove the (now unnecessary) :not(.docked) from all CSS related to the WI.TabBar
  • replace .big-sur with .mac-platform.big-sur for clarity
  • add .mac-platform.monterey alongside any .mac-platform.big-sur
  • UserInterface/Base/Main.js:

(WI.undockedTitleAreaHeight):

  • UserInterface/Views/Main.css:

(body:is(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive #undocked-title-area): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive #undocked-title-area): Added.
(body.big-sur #undocked-title-area): Deleted.
(body:not(.big-sur) #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur) #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur.window-inactive #undocked-title-area): Deleted.
(@media (prefers-color-scheme: dark) body:not(.big-sur).window-inactive #undocked-title-area): Deleted.

  • UserInterface/Views/Variables.css:

(body:is(.mac-platform.monterey, .mac-platform.big-sur)): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur):not(.docked)): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur):not(.docked)): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur)): Added.
(body.big-sur): Deleted.
(body.mac-platform:not(.big-sur):not(.docked)): Deleted.
(body.mac-platform.big-sur:not(.docked)): Deleted.
(@media (prefers-color-scheme: dark) body.big-sur): Deleted.
Add support for macOS Monterey.

11:26 PM Changeset in webkit [281181] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
​https://bugs.webkit.org/show_bug.cgi?id=229181

r281147 changed this test from flaky to differently flaky.
It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
object to update as the document loaded. r281147 fixed that, making it basically always pass when loaded over the real internet.
Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
by the tests. In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
I'll propose a fix for the web platform test, but for now I mark it as flaky.

8:55 PM Changeset in webkit [281180] by Russell Epstein
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning.

WebKit-7612.1.27.0.26

8:30 PM Changeset in webkit [281179] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GLIB] test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html is a flaky timeout since r278004
​https://bugs.webkit.org/show_bug.cgi?id=229219

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-17

  • platform/glib/TestExpectations:
7:27 PM Changeset in webkit [281178] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add an option for canonicalizePrePostIncrements
​https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
​https://bugs.webkit.org/show_bug.cgi?id=228538

  • b3/B3Generate.cpp:

(JSC::B3::generateToAir):

  • b3/testb3_3.cpp:

(addShrTests):

  • runtime/OptionsList.h:
7:20 PM Changeset in webkit [281177] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[curl] Kept alive NetworkResourceLoaders should be cancelled by NetworkLoad::didCompleteWithError on PolicyAction::Ignore of didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=228095
<rdar://problem/81393898>

Unreviewed test failure fix.

  • http/tests/fetch/resources/get-set-temp-file.py: chmod +x.
5:57 PM Changeset in webkit [281176] by Russell Epstein
  • 1 copy in tags/Safari-612.1.28.3

Tag Safari-612.1.28.3.

5:55 PM Changeset in webkit [281175] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash in TestWebKitAPI.NetworkProcess.CrashWhenNotAssociatedWithDataStore
​https://bugs.webkit.org/show_bug.cgi?id=229209
rdar://82040197

Reviewed by Geoffrey Garen.

When getting network process connection fails, we don't need to retry or crash UI process if web process is
already gone.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

5:12 PM Changeset in webkit [281174] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ MacOS wk2 Debug ] http/wpt/webrtc/sframe-transform-error.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229206

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:05 PM Changeset in webkit [281173] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ Win EWS ] Rebaselining 2 http/tests/security/contentSecurityPolicy/worker-* tests.
​https://bugs.webkit.org/show_bug.cgi?id=229216

Unreviewed test gardening.

  • platform/win/http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
  • platform/win/http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt:
4:56 PM Changeset in webkit [281172] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac Guard-Malloc] imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-2.html is a flaky failure.
rdar://82053210.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:26 PM Changeset in webkit [281171] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] http/tests/security/no-javascript-refresh-percent-escaped.py is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229215

Unreviewed test gardening.

  • platform/win/TestExpectations:
4:20 PM Changeset in webkit [281170] by Robert Jenner
  • 2 edits in trunk/LayoutTests

REGRESSION (r271146): [ iOS ] editing/selection/ios/scrolling-to-focused-element-inside-iframe.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=228200

Unreviewed test gardening.

  • platform/ios/TestExpectations:
4:10 PM Changeset in webkit [281169] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] performance-api/performance-timeline-api.html needs to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=229214

Unreviewed test gardening.

  • platform/win/performance-api/performance-timeline-api-expected.txt:
3:54 PM Changeset in webkit [281168] by Robert Jenner
  • 1 edit
    4 adds in trunk/LayoutTests

REBASELINE : [ iOS ] 3X imported/w3c/web-platform-t ests/css/css-typed-om layout-tests are constant text failures
​https://bugs.webkit.org/show_bug.cgi?id=229207

Unreviewed test gardening/ iOS rebaseline.

  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
3:16 PM Changeset in webkit [281167] by Jonathan Bedard
  • 4 edits in trunk/Tools

[webkitcorepy] Return SourceFileLoader in find_module
​https://bugs.webkit.org/show_bug.cgi?id=229172
<rdar://problem/82006256>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.find_module): Return SourceFileLoader object in Python 3.

2:42 PM Changeset in webkit [281166] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Mac wk2 ] http/tests/webAPIStatistics/screen-functions-accessed-data-collection.html is a flaky timeout.
rdar://82047046

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:22 PM Changeset in webkit [281165] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.3

2:14 PM Changeset in webkit [281164] by Russell Epstein
  • 1 copy in tags/Safari-612.1.27.0.25

Tag Safari-612.1.27.0.25.

2:14 PM Changeset in webkit [281163] by Russell Epstein
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning

WebKit-7612.1.27.0.25

1:44 PM Changeset in webkit [281162] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

Rebaselining [ Win EWS ] http/tests/misc/webtiming-slow-load.py.
​https://bugs.webkit.org/show_bug.cgi?id=229099

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/http/tests/misc/webtiming-slow-load-expected.txt:
1:37 PM Changeset in webkit [281161] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https.html is a constant failure.
rdar://82044002.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:32 PM Changeset in webkit [281160] by ddkilzer@apple.com
  • 9 edits in trunk/Source/ThirdParty/ANGLE

[Metal ANGLE] Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leaks
<​https://webkit.org/b/229128>
<rdar://problem/81964007>

Reviewed by Alex Christensen.

  • src/libANGLE/renderer/metal/DisplayMtl.h:

(rx::DisplayMtl::getMetalDeviceMatchingAttribute):

  • Change to return mtl::AutoObjCPtr<> to make ownership clear.

(rx::DisplayMtl::mMetalDevice):

  • No need to initialize to nil.
  • src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::initializeImpl):

  • Update for changes to getMetalDeviceMatchingAttribute().

(rx::DisplayMtl::getMetalDeviceMatchingAttribute):

  • Change to return mtl::AutoObjCPtr<> to make ownership clear.
  • Fix leak of deviceList, externalGPUs, integratedGPUs, and discreteGPUs.
  • Use mtl::adoptObjCObj<>() to prevent leak of MTLCreateSystemDefaultDevice().
  • src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:
  • Fix leak of captureDescriptor in two different if blocks.
  • src/libANGLE/renderer/metal/ProgramMtl.mm:
  • Fix leak of funcConstants in early return on error path.
  • src/libANGLE/renderer/metal/ProvokingVertexHelper.mm:

(rx::ProvokingVertexHelper::getSpecializedShader):

  • Fix leak of fcValues.
  • src/libANGLE/renderer/metal/SurfaceMtl.mm:
  • Fix leak of captureDescriptor in two different if blocks.
  • src/libANGLE/renderer/metal/mtl_common.h:

(rx::mtl::WrappedObject::retainAssign):

  • Move statement inside #if/#endif that isn't needed for ARC.

(rx::mtl::WrappedObject::unretainAssign): Add.
(rx::mtl::AutoObjCPtr::AutoObjCPtr): Add.
(rx::mtl::adoptObjCObj): Add.

  • Add a helper method to adopt an Objective-C object to eliminate the need to autorelease a +1 retained object before an mtl::AutoObjCPtr<> object wraps it. Modeled after WTF::RetainPtr<> in WebKit.
  • src/libANGLE/renderer/metal/mtl_state_cache.mm:

(rx::mtl::RenderPipelineCache::createRenderPipelineState):
(rx::mtl::ProvokingVertexComputePipelineCache::createComputePipelineState):

  • Use adoptObjCObj<>() to fix potential leak on the early return path since these methods return an mtl::AutoObjCPtr<>.
1:19 PM Changeset in webkit [281159] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Debug arm64,iOS 15 wk2] imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.html is a flaky failure.
rdar://82043074.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:57 PM Changeset in webkit [281158] by Fujii Hironori
  • 3 edits
    4 adds in trunk

[curl] Kept alive NetworkResourceLoaders should be cancelled by NetworkLoad::didCompleteWithError on PolicyAction::Ignore of didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=228095
<rdar://problem/81393898>

Reviewed by Don Olmstead.

Source/WebKit:

If a page dispatches a keepalive fetch and the page is navigated
away, the alive NetworkResourceLoader is transferred to the
NetworkSession by NetworkConnectionToWebProcess::transferKeptAliveLoad.
After the NetworkResourceLoader receives a response, it is canceled
by PolicyAction::Ignore.

However, NetworkDataTaskCurl didn't properly cancel the kept alive
NetworkResourceLoader. They remained in m_keptAliveLoads of
NetworkSession even after the requests were canceled.

Test: http/tests/fetch/keepalive-fetch-2.html

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): Call didCompleteWithError on PolicyAction::Ignore.

LayoutTests:

  • http/tests/fetch/keepalive-fetch-2-expected.txt: Added.
  • http/tests/fetch/keepalive-fetch-2.html: Added.
  • http/tests/fetch/resources/get-set-temp-file.py: Added.
  • http/tests/fetch/resources/keepalive-fetch-2-window.html: Added.
12:34 PM Changeset in webkit [281157] by jer.noble@apple.com
  • 6 edits in trunk/Source

De-duplicate the Cocoa-specific MediaPlayerPrivateRemote constructor
​https://bugs.webkit.org/show_bug.cgi?id=229193

Reviewed by Eric Carlson.

Source/WebCore:

Don't include a Objective-C header in a file which will be included by C++ source; forward-declare
the class instead.

  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

Source/WebKit:

Rather than have two, separate implementations of the MediaPlayerPrivateRemote constructor (one for Cocoa),
just wrap the initializer for the Cocoa-specific ivar in PLATFORM(COCOA) guards.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):

  • WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): Deleted.

12:23 PM Changeset in webkit [281156] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed. Skip failing MIPS tests
​https://bugs.webkit.org/show_bug.cgi?id=229198

Patch by Mikhail R. Gadelha <Mikhail R. Gadelha> on 2021-08-17

JSTests:

  • ChakraCore.yaml:

LayoutTests:

  • platform/wpe/TestExpectations:
12:11 PM Changeset in webkit [281155] by Lauro Moura
  • 2 edits in trunk/Tools

[GLIB] Avoid getting stuck searching for revision in some cases
​https://bugs.webkit.org/show_bug.cgi?id=229199

Reviewed by Philippe Normand.

With an empty .git/svn, the git svn info command might get stuck.

  • glib/apply-build-revision-to-files.py:

(get_build_revision):

12:02 PM Changeset in webkit [281154] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk1 Debug Intel] inspector/css/getMatchedStylesForNodeMarkerPseudoId.html is a flaky failure).
rdar://82039967.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:48 AM Changeset in webkit [281153] by Russell Epstein
  • 1 copy in tags/Safari-612.1.28.2

Tag Safari-612.1.28.2.

11:48 AM Changeset in webkit [281152] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk1 Debug] inspector/timeline/timeline-event-TimerInstall.html is a flaky crash.
rdar://82039288.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:41 AM Changeset in webkit [281151] by Russell Epstein
  • 2 edits in branches/safari-612.1.28-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj

Cherry-pick r281121. rdar://problem/82038333

Apply patch. rdar://problem/81915461

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@281121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:41 AM Changeset in webkit [281150] by Russell Epstein
  • 6 edits in branches/safari-612.1.28-branch/Source

Cherry-pick r280597. rdar://problem/82038333

Speculative build fix. rdar://79147214.

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [281149] by Russell Epstein
  • 8 edits in branches/safari-612.1.28-branch/Source

Versioning.

WebKit-7612.1.28.2

10:46 AM Changeset in webkit [281148] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Release] performance-api/paint-timing/paint-timing-with-worker.html is a flaky crash.
rdar://82036119.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:30 AM Changeset in webkit [281147] by commit-queue@webkit.org
  • 12 edits in trunk

Document load events should update timing in PerformanceNavigationTiming even after its instantiation
​https://bugs.webkit.org/show_bug.cgi?id=229181

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-17
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/navigation-timing/nav2_test_attributes_values-expected.txt:

Source/WebCore:

When we make a PerformanceNavigationTiming object, we copy the DocumentLoadTiming and DocumentEventTiming values.
If PerformanceNavigationTiming is accessed before the document has finished loading, we still need to update the timing values.

Covered by a newly passing WPT test, which Chrome and Firefox already pass.

  • dom/Document.cpp:

(WebCore::Document::documentEventTimingFromNavigationTiming):
(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

  • dom/Document.h:
  • loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::setLoadEventStart):
(WebCore::DocumentLoadTiming::setLoadEventEnd):
(WebCore::DocumentLoadTiming::markLoadEventStart): Deleted.
(WebCore::DocumentLoadTiming::markLoadEventEnd): Deleted.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

  • page/Performance.h:
  • page/PerformanceNavigationTiming.h:

LayoutTests:

This test now always passes in WK2.

10:25 AM Changeset in webkit [281146] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Star wk2 Release] performance-api/performance-observer-no-document-leak.html is a flaky crash.
rdar://82035182.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:05 AM Changeset in webkit [281145] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Monterey wk2 Release] security/contentSecurityPolicy/image-with-file-url-allowed-by-img-src-star.html is flaky image-only fail.
rdar://82034073.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:41 AM Changeset in webkit [281144] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Mark webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=229192

This test now consistently either passes or fails and no longer times out.

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-17

  • platform/gtk/TestExpectations:
9:38 AM Changeset in webkit [281143] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] webanimations/translate-property-and-translate-animation-with-delay-on-forced-layer.html is a flaky image-only fail.
rdar://82032946.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:36 AM Changeset in webkit [281142] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] fast/forms/number/number-spinbutton-state.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229194

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:28 AM Changeset in webkit [281141] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] svg/custom/animate-initial-pause-unpause.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=229195

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:07 AM Changeset in webkit [281140] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests/imported/w3c

Remove unused test expectation file

  • web-platform-tests/resource-timing/idlharness-expected.txt: Removed.
9:01 AM Changeset in webkit [281139] by Razvan Caliman
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not show contextual documentation popup in the Changes panel
​https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>

Reviewed by Devin Rousso.

Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.

  • UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):

8:42 AM Changeset in webkit [281138] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Debug wk2 ] ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData).
​https://bugs.webkit.org/show_bug.cgi?id=223750

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:14 AM Changeset in webkit [281137] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Win10 wk1] animations/shadow-host-child-change.html is a constant failure.
​https://bugs.webkit.org/show_bug.cgi?id=229191.

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:11 AM Changeset in webkit [281136] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Incorrect repaint when inline level box style change triggers line height change
​https://bugs.webkit.org/show_bug.cgi?id=229140
<rdar://problem/81980863>

Reviewed by Alan Bujtas.

Source/WebCore:

If an existing block shrinks vertically as a result of layout we fail to invalidate the
old content area for repaint, thus potentially leaving painting artefacts behind.
This is often hidden by the content shift triggering other repaints.

Test: fast/repaint/line-layout-block-shrink.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutModernLines):

Adjust the repaint area to include the content size before the layout.

LayoutTests:

  • fast/repaint/line-layout-block-shrink-expected.txt: Added.
  • fast/repaint/line-layout-block-shrink.html: Added.
6:47 AM Changeset in webkit [281135] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

REGRESSION(r218083): [GStreamer] webrtc unexpected failures
​https://bugs.webkit.org/show_bug.cgi?id=229187

Reviewed by Xabier Rodriguez-Calvar.

The stream-collection messages actually don't need to be handled synchronously in the
mediastream cases. The limitations of the MSE backend do not apply there.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

6:09 AM Changeset in webkit [281134] by Jean-Yves Avenard
  • 11 edits
    2 adds in trunk

Implement API to ensure MediaRemote key mapping is correct
​https://bugs.webkit.org/show_bug.cgi?id=229070
<rdar://problem/81894480>

Reviewed by Eric Carlson.

Source/WebCore:

This change adds Internals entries to test bug 229068.
While we do not mock the MediaRemote service, we still go one step further in
ensuring that the mappings between MediaSession action handlers and
PlatformMediaSession are correct.

Test: media/media-session/actionHandlerInternalMappings.html

  • platform/NowPlayingManager.cpp:

(WebCore::NowPlayingManager::supportedCommands const):

  • platform/NowPlayingManager.h:
  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::supportedCommands const):

  • platform/audio/cocoa/MediaSessionManagerCocoa.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::supportedCommands const):

  • testing/Internals.cpp:

(WebCore::Internals::platformSupportedCommands const):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/media-session/actionHandlerInternalMappings-expected.txt: Added.
  • media/media-session/actionHandlerInternalMappings.html: Added.
3:16 AM Changeset in webkit [281133] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
​https://bugs.webkit.org/show_bug.cgi?id=229123
<rdar://problem/81978494>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-17
Reviewed by Xabier Rodriguez-Calvar.

Implement a dummy id() method for InbandTextTrackPrivateGStreamer.

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
12:22 AM Changeset in webkit [281132] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

LayoutTests imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-* are flakey
​https://bugs.webkit.org/show_bug.cgi?id=229169

Reviewed by Eric Carlson.

When a data:// URL is passed to AVFoundation, the loading of that URL is handled by WebCoreAVFResourceLoader,
which in turn relies on a PlatformMediaResourceLoader to turn the data URL into a data buffer. However, in the
case of the GPU process, this means dispatching the request from GPU, to WebContent, to Network process and to
send the data back from the Network, to WebContent, to GPU process. If a synchronous operation (like painting)
is underway, the data response can block until that synchronous operation completes. If that operation is a
paint, and the data requested is required to complete that paint, the paint will fail.

For the narrow case of a data:// URL, it's not necessary to dispatch to another process to turn that URL into
data; it can happen locally, avoiding the hop to another process and the subsequent deadlock.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

(WebCore::WebCoreAVFResourceLoader::logger const):

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::startLoading):

Aug 16, 2021:

11:59 PM Changeset in webkit [281131] by Diego Pino Garcia
  • 4 edits
    1 move in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines after r277970.

This change removes the remaining test failures filed under webkit.org/b/186638.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt:
11:50 PM Changeset in webkit [281130] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Reassign bugs filed under webkit.org/b/186638.

webkit.org/b/186638 was used to track tests failing in EWS-GTK, but
all the current tests filed under this bug are actually failing in the
post-commit bot. The failing tests should be filed under their own bug.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
11:43 PM Changeset in webkit [281129] by Lauro Moura
  • 2 edits in trunk/Tools

REGRESSION(r281079) [GLIB] API test WebKitWebsiteData/deviceidhashsalt is not waiting for title change
​https://bugs.webkit.org/show_bug.cgi?id=229174

Reviewed by Carlos Garcia Campos.

r281079 changed the helper method waitUntilTitleChangedTo to
immediately return if the current title is already the expected one.

While this is working fine in other tests, the deviceidhashsalt tries
to load the same page twice. As the title does not change, the call
returns right away, before the expected side effects of the load
happen.

This commit adds a dummy "about:blank" call between both original
calls to make sure we track the title change correctly.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(testWebsiteDataDeviceIdHashSalt):

10:34 PM Changeset in webkit [281128] by Antti Koivisto
  • 5 edits
    2 adds in trunk

REGRESSION (r275756): Accelerated animations freeze when invalidating layout with shadow dom
​https://bugs.webkit.org/show_bug.cgi?id=228954
<rdar://problem/81750217>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: animations/shadow-host-child-change.html

Tearing down the host renderer after slot assignments change cancels animations on it.

  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::didChangeSlot):

  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):

Add a version that keeps the animations going on the teardown root.

(WebCore::RenderTreeUpdater::tearDownRenderers):

  • rendering/updating/RenderTreeUpdater.h:

LayoutTests:

Original test by Liam DeBeasi

  • animations/shadow-host-child-change-expected.html: Added.
  • animations/shadow-host-child-change.html: Added.
9:52 PM Changeset in webkit [281127] by achristensen@apple.com
  • 1 edit
    714 adds in trunk/LayoutTests/imported/w3c

Imported CSS Typed OM from w3c
​https://bugs.webkit.org/show_bug.cgi?id=229177

Patch by Johnson Zhou <​qiaosong_zhou@apple.com> on 2021-08-16
Reviewed by Alex Christensen.

  • web-platform-tests/css/css-typed-om/CSSMatrixComponent-DOMMatrix-mutable-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/CSSMatrixComponent-DOMMatrix-mutable.html: Added.
  • web-platform-tests/css/css-typed-om/META.yml: Added.
  • web-platform-tests/css/css-typed-om/declared-styleMap-accepts-inherit-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/declared-styleMap-accepts-inherit.html: Added.
  • web-platform-tests/css/css-typed-om/factory-absolute-length-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/factory-absolute-length.html: Added.
  • web-platform-tests/css/css-typed-om/factory-duration-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/factory-duration.html: Added.
  • web-platform-tests/css/css-typed-om/factory-frequency-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/factory-frequency.html: Added.
  • web-platform-tests/css/css-typed-om/idlharness-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/idlharness.html: Added.
  • web-platform-tests/css/css-typed-om/resources/testhelper.js: Added.

(epsilonForUnitType):
(assert_color_channel_approx_equals):
(assert_style_value_equals):
(assert_style_value_array_equals):
(createDivWithStyle):
(createInlineStyleMap):
(createElementWithInlineStyleMap):
(createComputedStyleMap):
(createElementWithComputedStyleMap):
(createDeclaredStyleMap):
(createRuleWithDeclaredStyleMap):
(loadImageResource):
(assert_matrix_approx_equals):

  • web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/rotate-by-added-angle-ref.html: Added.
  • web-platform-tests/css/css-typed-om/rotate-by-added-angle.html: Added.
  • web-platform-tests/css/css-typed-om/set-var-reference-thcrash-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/set-var-reference-thcrash.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-ident.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-ident.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-image-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-image.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-numeric.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-numeric.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-tokens.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/normalize-tokens.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/positionvalue-normalization.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/positionvalue-normalization.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parse-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parse-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parse-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parse.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/crashtests/cssTransform-Internal-value-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/crashtests/cssTransform-Internal-value.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssImageValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssImageValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssKeywordValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssKeywordValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssMathValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssMathValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssPositionValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssPositionValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-cssom-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-cssom.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssStyleValue-string.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnitValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnitValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnparsedValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-serialization/cssUnparsedValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssColorValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssColorValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-value-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue-value.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssKeywordValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssMatrixComponent.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssMatrixComponent.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPerspective.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPerspective.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPositionValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPositionValue-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPositionValue-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssPositionValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRGB-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRGB.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssScale.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssScale.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkew.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkew.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewX.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewX.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix-relative-units-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix-relative-units.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue-toMatrix-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue-toMatrix.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTranslate.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTranslate.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-empty-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-empty.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-indexed-getter-setter-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-indexed-getter-setter.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-iterable-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-iterable.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-length-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue-length.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssUnparsedValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-variable-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue-variable.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssVariableReferenceValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/add-two-types.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/add-two-types.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/create-a-type.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/create-a-type.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathInvert-type-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathInvert-type.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathNegate-type-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathNegate-type.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-value-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue-value.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssnumericvalue-multiply-two-types.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssnumericvalue-multiply-two-types.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/equals.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/equals.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-factory.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/numeric-factory.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/resources/testhelper.js: Added.

(assert_numeric_type_equals):

  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/computed.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/computed.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-auto-min-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-auto-min-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/get.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/getAll.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/has.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/has.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/iterable.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/computed/iterable.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/append.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/append.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/clear-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/clear.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/declared.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/declared.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/delete.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/get.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/getAll-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/getAll-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/getAll.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/getAll.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/has.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/has.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/iterable.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/iterable.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/declared/set.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/append.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/clear-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/clear.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/delete.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get-invalid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get-invalid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/get.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/getAll.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/has.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/has.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/iterable.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/iterable.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set-shorthand-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set-shorthand.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set.tentative-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/inline/set.tentative.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/accent-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/accent-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/all-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/all.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-delay-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-delay.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-fill-mode-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-fill-mode.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-play-state-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-play-state.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-timing-function-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-timing-function.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backface-visibility-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/backface-visibility.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-attachment-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-attachment.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-blend-mode-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-blend-mode.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-clip-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-clip.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-image-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-origin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-origin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-repeat.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/background.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/baseline-shift-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/baseline-shift.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-collapse-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-collapse.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-outset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-outset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-repeat-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-repeat.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-slice-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-slice.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-source-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-source.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-image-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-radius-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-radius.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/bottom-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/bottom.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/box-shadow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/box-shadow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/box-sizing-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/box-sizing.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/break-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/break.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/caption-side-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/caption-side.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/caret-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/caret-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/center-coordinate-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/center-coordinate.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clear-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clear.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip-path-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip-path.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip-rule-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip-rule.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/clip.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-count.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-span-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-span.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/contain-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/contain.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/coordinate-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/coordinate.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-increment-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-increment.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-reset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-reset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-set-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/counter-set.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/cursor-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/cursor.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/d-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/d.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/direction-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/direction.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/display-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/display.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/dominant-baseline-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/dominant-baseline.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/empty-cells-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/empty-cells.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-opacity-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-opacity.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-rule-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill-rule.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/fill.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/filter-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/filter.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-direction-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-direction.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-flow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-flow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-wrap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-wrap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/float-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/float.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flood-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flood-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flood-opacity-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flood-opacity.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-family-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-family.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-feature-settings-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-feature-settings.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-kerning-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-kerning.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-language-override-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-language-override.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-palette-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-palette.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-presentation-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-presentation.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-synthesis-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-synthesis.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-caps-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-caps.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-east-asian-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-east-asian.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-ligatures-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-ligatures.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-numeric-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-numeric.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variation-settings-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variation-settings.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-weight.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-area-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-area.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-gap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-gap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-start-end-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-start-end.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-areas-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-areas.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-columns-rows-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-columns-rows.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/height-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/height.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/hyphens-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/hyphens.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/image-rendering-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/image-rendering.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/inline-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/inline-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/isolation-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/isolation.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/left-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/left.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/lighting-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/lighting-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-break-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-break.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-height-step-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-height-step.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-height.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-image-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-image.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/margin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/margin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/marker-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/marker.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask-image-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask-type-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask-type.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mask.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mix-blend-mode-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/mix-blend-mode.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/object-fit-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/object-fit.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/object-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/object-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-anchor-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-anchor.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-distance-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-distance.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-path-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-path.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-rotate-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset-rotate.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/offset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/opacity-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/opacity.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/order-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/order.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/orphans-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/orphans.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-offset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-offset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow-anchor-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow-anchor.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow-wrap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow-wrap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overflow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overscroll-behavior-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/overscroll-behavior.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/padding-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/padding.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/paint-order-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/paint-order.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/perspective-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/perspective-origin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/perspective-origin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/perspective.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/quotes-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/quotes.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/radius-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/radius.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/resize-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/resize.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js: Added.

(assert_is_unit):
(assert_is_calc_sum):
(assert_is_equal_with_range_handling):
(assert_is_unsupported):
(input.new.CSSKeywordValue):
(const.gTestSyntaxExamples.string_appeared_here.input.new.CSSUnitValue):
(const.gTestSyntaxExamples.string_appeared_here.assert_is_unit):
(const.gTestSyntaxExamples.string_appeared_here.new.CSSUnitValue):
(testPropertyValid):
(set testIsImageValidForProperty):
(set testPropertyInvalid):
(get createKeywordExample):
(runPropertyTests):
(runListValuedPropertyTests):
(runUnsupportedPropertyTests):

  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/right-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/right.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-behavior-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-behavior.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-margin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-margin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-padding-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-padding.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-align-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-align.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-stop-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-stop.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-type-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-type.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scrollbar-gutter-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scrollbar-gutter.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scrollbar-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scrollbar-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-outside-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-outside.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/speak-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/speak.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dashoffset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dashoffset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-linecap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-linecap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-miterlimit-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-miterlimit.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/tab-size-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/tab-size.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/table-layout-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/table-layout.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-align-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-align-last-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-align-last.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-align.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-anchor-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-anchor.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-ink-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-ink.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-thickness-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-thickness.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-indent-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-indent.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-justify-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-justify.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-orientation-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-orientation.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-overflow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-overflow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-shadow-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-shadow.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-size-adjust-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-size-adjust.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-transform.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-offset-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-offset.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-position-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-position.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/top-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/top.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/touch-action-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/touch-action.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-box-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-box.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-interpolated-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-interpolated.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-style-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform-style.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transform.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-delay-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-delay.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-property-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-property.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-timing-function-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition-timing-function.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/transition.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/unicode-bidi-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/unicode-bidi.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/user-select.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/vector-effect-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/vector-effect.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/vertical-align-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/vertical-align.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/visibility-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/visibility.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/white-space-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/white-space.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/widows-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/widows.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/will-change-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/will-change.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-break-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-break.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-spacing-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-spacing.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-wrap-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/word-wrap.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/writing-mode-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/writing-mode.html: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/z-index-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/z-index.html: Added.
  • web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/width-by-max-px-em.html: Added.
  • web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
  • web-platform-tests/css/css-typed-om/width-by-min-px-em.html: Added.
9:32 PM Changeset in webkit [281126] by Devin Rousso
  • 4 edits in trunk

Web Share CanShare() should be called after transient activation check
​https://bugs.webkit.org/show_bug.cgi?id=229132

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/web-share/share-consume-activation.https-expected.txt:

Source/WebCore:

Test: web-platform-tests/web-share/share-consume-activation.https.html

  • page/Navigator.cpp:

(WebCore::Navigator::share):

7:43 PM Changeset in webkit [281125] by commit-queue@webkit.org
  • 10 edits in trunk

Report resource timing when SubresourceLoader::checkForHTTPStatusCodeError returns true
​https://bugs.webkit.org/show_bug.cgi?id=229167

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-16
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/resource-timing/buffer-full-add-then-clear-expected.txt:
  • web-platform-tests/resource-timing/buffer-full-store-and-clear-during-callback-expected.txt:
  • web-platform-tests/resource-timing/buffer-full-then-increased-expected.txt:
  • web-platform-tests/resource-timing/buffer-full-when-populate-entries-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_cross_origin_redirect_chain-expected.txt:

Source/WebCore:

Since r281110 we report timing data for loads which "fail" because of HTTP status codes in the 400-599 range.
This matches the behavior of Chrome, Firefox, and the spec, but there was a code path where we still weren't reporting
those resources' timing data. This wasn't a problem before r281110 because we would've discarded it anyways, but
this code path needs to report the timing data before calling SubresourceLoader::cancel.

Covered by several newly passing WPT tests, which Chrome and Firefox already pass.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):

5:04 PM Changeset in webkit [281124] by dino@apple.com
  • 8 edits
    2 adds in trunk

WebXR contexts have to use high-power GPUs
​https://bugs.webkit.org/show_bug.cgi?id=229111
<rdar://81658893>

Reviewed by Sam Weinig.

Source/WebCore:

The WebGL context used by WebXR needs to be using the same GPU
as the headset it is talking to. However, the API allows for the
creation of the WebGL context before initializing the WebXR
session.

For now, assume this will trigger the high-performance GPU
on any dual-GPU system. i.e. when the WebGL is created, look
for the "webXRCompatible" creation attribute and force
the high-power GPU if available.

Test: webxr/high-performance.html

  • html/canvas/WebGLRenderingContextBase.h: Export the method to retrieve attributes.
  • platform/graphics/GraphicsContextGLAttributes.h: Add a flag for forcing the

high performance gpu.

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::InitializeEGLDisplay):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

  • testing/Internals.cpp: New internals method to check what GPU was requested.

(WebCore::Internals::requestedGPU):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • webxr/high-performance-expected.txt: Added.
  • webxr/high-performance.html: Added.
4:58 PM Changeset in webkit [281123] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix null crash after r281110
​https://bugs.webkit.org/show_bug.cgi?id=225737

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportResourceTiming):
I saw a nullptr crash here in EWS from bug 229167.
Looks like there's a case where we can call reportResourceTiming without a resource.
Early return if m_resource is null.

4:51 PM Changeset in webkit [281122] by Alan Coon
  • 1 copy in tags/Safari-612.1.15.4.17

Tag Safari-612.1.15.4.17.

4:47 PM Changeset in webkit [281121] by Alan Coon
  • 2 edits in branches/safari-612.1.15.4-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj

Apply patch. rdar://problem/81915461

4:47 PM Changeset in webkit [281120] by Alan Coon
  • 2 edits in branches/safari-612.1.15.4-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj

Revert r280993 rdar://problem/81915461

This reverts the patch applied at r280993.

4:41 PM Changeset in webkit [281119] by Alan Coon
  • 8 edits in branches/safari-612.1.15.4-branch/Source

Versioning.

WebKit-7612.1.15.4.17

4:36 PM Changeset in webkit [281118] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Star] webaudio/codec-tests/mp3/128kbps-44khz.html is a constant failure.
rdar://82003714.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:22 PM Changeset in webkit [281117] by Alan Coon
  • 1 copy in tags/Safari-612.1.27.0.24

Tag Safari-612.1.27.0.24.

4:17 PM Changeset in webkit [281116] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[GPU Process] Demote the release assertion in RemoteResourceCache::ensureResourceUseCounter
​https://bugs.webkit.org/show_bug.cgi?id=229164
rdar://81999835

Reviewed by Simon Fraser.

Replace the RELEASE_ASSERT with a regular debug assertion. See bug description for more information.

  • GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::ensureResourceUseCounter):

4:11 PM Changeset in webkit [281115] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Ensure that unused LLInt opcodes are not inadvertently used.
​https://bugs.webkit.org/show_bug.cgi?id=229161

Reviewed by Robin Morisset.

The op macro is used for generating LLInt asm code for some entry points to the
LLInt, where we don't need 16 bits and 32 bit wide versions of the entry point.
For example, we use it for llint_program_prologue.

Note that llint_program_prologue is generated using:

op(llint_program_prologue, macro () ...

where op is:

macro op(l, fn)

commonOp(l, macro () end, macro (size)

size(fn, macro() end, macro() end, macro(gen) gen() end)
# ----- wide32 generator
# `------------------ wide16 generator

end)

end

Note that the generators for the wide16 and wide32 versions of the entry point
currently emit nothing. As a result, if we ever have a bug that ends up
dispatching to llint_program_prologue_wide16 or llint_program_prologue_wide32,
we'll end up falling thru to llint_module_program_prologue, which just happens
to be the entry point positioned after those labels.

This patch adds breakpoints in those 2 unused generators so that we won't
inadvertently execute code for something else.

  • llint/LowLevelInterpreter.asm:
3:57 PM Changeset in webkit [281114] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Monterey wk2 Release ] css3/blending/background-blend-mode-background-clip-content-box.html is flaky image failing.
rdar://82002352

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:23 PM Changeset in webkit [281113] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] webrtc/utf8-sdp.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229166.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:06 PM Changeset in webkit [281112] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Monterey wk2 Release ] 2 css3/background/* tests are flaky image failing.
rdar://82000141

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:45 PM Changeset in webkit [281111] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Enable PerformanceNavigationAPI by default
​https://bugs.webkit.org/show_bug.cgi?id=227336

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-16
Reviewed by Chris Dumez.

It passes WPT tests except the following:

navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html and navigation-timing/nav2_test_redirect_xserver.html pass when run from wpt.live,
and other browsers also don't pass when run from our local hosting infrastructure, which doesn't have a good cross-domain redirect.

nav2_test_attributes_values.html fails in Chrome and Firefox. There's something wrong with the port detection in the test.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
2:43 PM Changeset in webkit [281110] by achristensen@apple.com
  • 13 edits in trunk

Resource Timing: Duration is 0 in many cases
​https://bugs.webkit.org/show_bug.cgi?id=225737

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/resource-timing/cors-preflight.any-expected.txt:
  • web-platform-tests/resource-timing/crossorigin-sandwich-no-TAO.sub-expected.txt:
  • web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub-expected.txt:
  • web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain-expected.txt:
  • web-platform-tests/resource-timing/status-codes-create-entry-expected.txt:

Source/WebCore:

This fixes two problems with our PerformanceResourceTiming implementation:

  1. ResourceTimingInformation::shouldAddResourceTiming wasn't adding timing data if CachedResource::errorOccurred returned true,

which includes when the server responds with an HTTP 404. We want loadFailedOrCanceled instead, which only returns true if
there's a network error or if the load is cancelled. This matches the behavior of other browsers.

  1. ResourceTiming::fromMemoryCache was assuming that it never had network information to report because we pulled from the cache,

not the network. However, a common case is that HTMLPreloadScanner::scan calls HTMLResourcePreloader::preload which loads the resource
while the HTML parser is blocked on loading scripts or other things, then CachedResourceLoader::requestResource pulls it out of the
memory cache. In this case, use the network metrics that we are already storing if it's the first time we are pulling this resource
out of the memory cache. After that, 0 load time is quite accurate.

Covered by newly passing Web Platform Tests, which Chrome and Firefox already passed.

  • loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::fromMemoryCache):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::initServerTiming): Deleted.

  • loader/ResourceTiming.h:

(WebCore::ResourceTiming::ResourceTiming):

  • loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::shouldAddResourceTiming):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::takeNetworkLoadMetrics):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::deprecatedNetworkLoadMetricsOrNull const):
(WebCore::ResourceResponseBase::takeNetworkLoadMetrics):

2:39 PM Changeset in webkit [281109] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] webrtc/video-addTransceiver.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229163.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:04 PM Changeset in webkit [281108] by Andres Gonzalez
  • 12 edits
    2 moves
    1 add in trunk

Expose [WebAccessibilityObjectWrapper lineRectsAndText] on MacOS.
​https://bugs.webkit.org/show_bug.cgi?id=229045
<rdar://81819301>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/element-line-rects-and-text.html

Moved the [WebAccessibilityObjectWrapper lineRectsAndText] method, and
supporting methods and functions, from the iOS subclass to the base
(Cocoa) class so that it can be used in both iOS and MacOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

Moved the following methods and functions to WebAccessibilityObjectWrapperBase.mm.
(-[WebAccessibilityObjectWrapper _prepareAccessibilityCall]): Deleted.
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]): Deleted.
(blockquoteLevel): Deleted.
(AXAttributeStringSetLanguage): Deleted.
(AXAttributeStringSetBlockquoteLevel): Deleted.
(AXAttributeStringSetHeadingLevel): Deleted.
(AXAttributeStringSetFont): Deleted.
(AXAttributeStringSetNumber): Deleted.
(AXAttributeStringSetStyle): Deleted.
(AXAttributedStringAppendText): Deleted.
(-[WebAccessibilityObjectWrapper contentForSimpleRange:attributed:]): Deleted.
(-[WebAccessibilityObjectWrapper lineRectsAndText]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase _prepareAccessibilityCall]):
(addObjectWrapperToArray):
(blockquoteLevel):
(AXAttributeStringSetLanguage):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetFont):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapperBase contentForSimpleRange:attributed:]):
(-[WebAccessibilityObjectWrapperBase lineRectsAndText]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Added handling of the attribute "AXLineRectsAndText".

Tools:

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::attributedStringForElement):
(WTR::AccessibilityUIElement::lineRectsAndText const):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::lineRectsAndText const):

LayoutTests:

  • accessibility/element-line-rects-and-text.html: Renamed from LayoutTests/accessibility/ios-simulator/element-line-rects-and-text.html.
  • platform/ios/TestExpectations:
  • platform/ios/accessibility/element-line-rects-and-text-expected.txt: Renamed from LayoutTests/accessibility/ios-simulator/element-line-rects-and-text-expected.txt.
  • platform/mac/accessibility/element-line-rects-and-text-expected.txt: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
1:53 PM Changeset in webkit [281107] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Unreviewed, reverting r281093.
​https://bugs.webkit.org/show_bug.cgi?id=229159

broke many GTK media tests

Reverted changeset:

"REGRESSION(r278981): [GStreamer][Debug] Assert crashes when
running media/track tests"
​https://bugs.webkit.org/show_bug.cgi?id=229123
​https://commits.webkit.org/r281093

1:43 PM Changeset in webkit [281106] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Monterey wk1 GuardMalloc ] fast/borders/hidpi-3x-input-hairline-border.html is timing out.
rdar://81996454

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
1:42 PM Changeset in webkit [281105] by rniwa@webkit.org
  • 4 edits in trunk

Add thread safe version of CanMakeCheckedPtr
​https://bugs.webkit.org/show_bug.cgi?id=229018

Reviewed by Geoffrey Garen.

Source/WTF:

Introduce CanMakeThreadSafeCheckedPtr which is a thread safe version of CanMakeCheckedPtr.

  • wtf/CheckedRef.h:

(WTF::CanMakeCheckedPtrBase): Extracted from CanMakeCheckedPtr.
(WTF::CanMakeCheckedPtrBase::~CanMakeCheckedPtrBase):
(WTF::CanMakeCheckedPtrBase::ptrCount const):
(WTF::SingleThreadIntegralWrapper): Added.
(WTF::SingleThreadIntegralWrapper::SingleThreadIntegralWrapper):
(WTF::SingleThreadIntegralWrapper::operator IntegralType const):
(WTF::SingleThreadIntegralWrapper::operator! const):
(WTF::SingleThreadIntegralWrapper::operator++):
(WTF::SingleThreadIntegralWrapper::operator--):
(WTF::SingleThreadIntegralWrapper::assertThread const):
(WTF::CanMakeCheckedPtr): Redefined using CanMakeCheckedPtrBase and SimpleNonAtomicType.
(WTF::CanMakeThreadSafeCheckedPtr): Added.

Tools:

Added a unit test for CanMakeThreadSafeCheckedPtr

  • TestWebKitAPI/Tests/WTF/CheckedPtr.cpp:

(TestWebKitAPI.ThreadSafeCheckedPtrObject)
(WTF_CheckedPtr.CanMakeThreadSafeCheckedPtr): Added.

1:08 PM Changeset in webkit [281104] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] webrtc/video-setDirection.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229158.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:58 PM Changeset in webkit [281103] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

REGRESSION (r281054): [ iOS14 ] fast/events/touch/ios/long-press-then-drag-to-select-text.html is a constant text failure
​https://bugs.webkit.org/show_bug.cgi?id=229157
<rdar://problem/81993820>

Unreviewed, mark this test as passing on iOS 14 again.

  • platform/ios-14/TestExpectations:
12:57 PM Changeset in webkit [281102] by Fujii Hironori
  • 6 edits in trunk/Source/WebKit

[WinCairo][GraphicsLayerTextureMapper] DrawingAreaProxyCoordinatedGraphics doesn't enter accelerated compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=228100

Reviewed by Don Olmstead.

Even if DrawingAreaCoordinatedGraphics entered AC mode in web
process side, DrawingAreaProxyCoordinatedGraphics didn't enter AC
mode in UI process side. They should sync.

There were two problems.

LayerTreeHost::layerTreeContext() always returned an empty
LayerTreeContext that means non-AC mode.
LayerTreeHost::m_layerTreeContext.contextID should be initialized.

DrawingAreaCoordinatedGraphics::layerHostDidFlushLayers should be
called after setShouldNotifyAfterNextScheduledLayerFlush(true) to
submit the current AC mode state.

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:

(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::LayerTreeHost):
(WebKit::LayerTreeHost::setShouldNotifyAfterNextScheduledLayerFlush):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h:
  • WebProcess/WebPage/DrawingArea.h:
12:41 PM Changeset in webkit [281101] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[ BigSur+ ] webrtc/video-addTrack.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229156.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:26 PM Changeset in webkit [281100] by Wenson Hsieh
  • 4 edits in trunk/LayoutTests

[iOS 15] editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=229147
rdar://80384447

Reviewed by Tim Horton.

This test verifies that we clear the text selection when tapping on an element that prevents the click event
on iOS (which matches behavior on macOS as well). To do this, the test:

  1. Long presses a piece of text to select it
  2. Taps the text we just selected (for reasons that are unclear to me)
  3. Taps the button with the click event listener, and then
  4. Waits for the platform text selection to disappear.

Currently, this test occasionally times out after step (3), and the selection is never cleared. In the success
case, the selection is cleared when UIKit's internal UITextTapRecognizer fires. Similar to the flaky timeout of
editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html that was fixed in bug #229126, we
fail in the case where the text tap gesture is not reset before the synthetic touches in (3) are dispatched.

While the mitigations in #229126 sometimes kick in and keep this test from timing out, this test may still time
out after that change because the touches in steps (2) and (3) are synthesized so quickly that the text tap
gesture is still in Possible state when sending touches in (3), because the HID events created in step (2)
haven't been delivered to the UIWindow yet in the form of UITouchEvents.

As such, one potential way to fix this is to teach HIDEventGenerator to wait until the HID events synthesized
underneath -sendTaps:location:withNumberOfTouches:withNumberOfTouches:delay:completionBlock: have been
delivered to the window. However, in the context of this test failure, there's a much less intrusive way to
avoid this race.

In the failure case, we avoid resetting UITextTapRecognizer immediately after the touches in step (2) are
processed because the tap-and-a-half gesture for selecting a range of text has not failed or ended yet; this
happens because the long press in step (1) followed by the tap in the same location in step (2) causes
UITapAndAHalfRecognizer to *sometimes* remain in Possible state with gesture failure requirements that connect
it to the other text interactions (including UITextTapRecognizer) in the same gesture dependency subgraph; this
in turn causes UITapAndAHalfRecognizer to defer reset of UITextTapRecognizer *just* long enough for the tap in
step (3) not be delivered to UITextTapRecognizer.

Interestingly, it's not clear that the tap in step (2) is necessary for the purposes of this test, and
importantly, removing it prevents the UITapAndAHalfRecognizer from remaining in Possible state when tapping on
the button after the long press, which ensures that the gesture subgraph containing UITextTapRecognizer is reset
in time for the touches to be delivered to the window. Thus, we can fix this bug simply by removing step (2).

  • editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html:
  • platform/ios-14/TestExpectations:
  • platform/ios/TestExpectations:
12:16 PM Changeset in webkit [281099] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Monterey wk2 Guard-Malloc arm64 ] fast/text/canvas-color-fonts/* tests are image failing.
rdar://81988829

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:11 PM Changeset in webkit [281098] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] fast/inline/incorrect-middle-baseline-alignment-with-line-height.html is passing since r277325
​https://bugs.webkit.org/show_bug.cgi?id=225293

Unreviewed test gardening

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-16

  • platform/gtk/TestExpectations:
12:01 PM Changeset in webkit [281097] by Brent Fulgham
  • 9 edits in trunk

REGRESSION (r281012): WebInspector console no longer shows script integrity information
​https://bugs.webkit.org/show_bug.cgi?id=229097
<rdar://problem/81915909>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt:

Source/WebCore:

  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished): Add full console message during promise rejection.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError): Treat integrity mismatch as
a ResourceError::Type::AccessControl so that it gets detailed console logging.

LayoutTests:

  • http/tests/subresource-integrity/sri-fetch-expected.txt:
  • http/tests/subresource-integrity/sri-module-expected.txt:
  • js/dom/modules/module-fetch-failure-not-cached-expected.txt:
11:27 AM Changeset in webkit [281096] by sihui_liu@apple.com
  • 7 edits in trunk/Source/WebKit

Add logging for failure in getting network process connection
​https://bugs.webkit.org/show_bug.cgi?id=229102

Reviewed by Geoffrey Garen.

UI process knows more about why network connection cannot be created compared to web process, so let's add
logging in UI process to help debug rdar://80760179.

  • UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::stateString const):

  • UIProcess/AuxiliaryProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getNetworkProcessConnection):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebProcess/WebProcess.cpp:

(WebKit::getNetworkProcessConnection):

11:20 AM Changeset in webkit [281095] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[iOS wk2 Release] webrtc/peer-connection-audio-mute2.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229154.

Unreviewed test gardening.

  • platform/ios/TestExpectations:
11:15 AM Changeset in webkit [281094] by Kocsen Chung
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning.

WebKit-7612.1.27.0.24

11:14 AM Changeset in webkit [281093] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
​https://bugs.webkit.org/show_bug.cgi?id=229123

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Xabier Rodriguez-Calvar.

The TrackPrivateBaseGStreamer class now includes all the common code that is used by its
subclasses. InbandTextTrackPrivateGStreamer now returns valid track IDs (fixing the issue of
this regression: ASSERTs). The patch also includes coding style fixes, removal of un-needed
includes and a few other clean-ups related with the Track support in the GStreamer platform
layer.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect): Deleted.
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged): Deleted.
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfStreamChanged): Deleted.

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

(WebCore::InbandTextTrackPrivateGStreamer::create):
(WebCore::InbandTextTrackPrivateGStreamer::streamId const): Deleted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack):
(WebCore::MediaPlayerPrivateGStreamer::handleTextSample):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::generateUniquePlaybin2StreamID):
(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer):
(WebCore::TrackPrivateBaseGStreamer::setPad):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfStreamChanged):
(WebCore::TrackPrivateBaseGStreamer::streamChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

(WebCore::TrackPrivateBaseGStreamer::setIndex):
(WebCore::TrackPrivateBaseGStreamer::stream):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
9:51 AM Changeset in webkit [281092] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] fast/forms/* tests are flaky crashing FAULTING_IP: WebKit!WebCore::FontCache::lastResortFallbackFont+ec [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\win\FontCacheWin.cpp @ 424].
​https://bugs.webkit.org/show_bug.cgi?id=229009

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:49 AM Changeset in webkit [281091] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

ThreadSanitizer: ignore uninteresting data races for reference counting of static WTF::StringImpl objects
<​https://webkit.org/b/229113>

Reviewed by Chris Dumez.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::isStatic const):

  • Add SUPPRESS_TSAN attribute since the 0x1 bit is set at construction and refcounting occurs in increments of 0x2, so the static bit never changes.

(WTF::StringImpl::ref):
(WTF::StringImpl::deref):

  • Return early for static WTF::StringImpl objects to prevent TSan from reporting data races for m_refCount.
9:36 AM Changeset in webkit [281090] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Fix Catalyst TestWebKitAPI build
​https://bugs.webkit.org/show_bug.cgi?id=229091

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-16
Reviewed by Wenson Hsieh.

  • TestWebKitAPI/Configurations/Base.xcconfig:

Search the correct SDK paths.

  • TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::TEST):
Use soft linking for VisionKitCore like we do elsewyere.

9:34 AM Changeset in webkit [281089] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WPE][GTK] Clean build broken with python3 after r280382
​https://bugs.webkit.org/show_bug.cgi?id=228628

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Adrian Perez de Castro.

The webkitpy autoinstall doesn't reliably work when it's triggered from concurrent
processes. Replace webkitpy usage in apply-build-revision-to-files.py script with explicit
calls to svnversion, git svn info or git log -1, depending on the kind of SCM checkout.

  • glib/apply-build-revision-to-files.py:

(get_build_revision):
(main):

9:31 AM Changeset in webkit [281088] by ddkilzer@apple.com
  • 14 edits in trunk

"make analyze" should run clang static analyzer in deep mode
<​https://webkit.org/b/229127>
<rdar://problem/81960587>

Reviewed by Alexey Proskuryakov.

.:

  • Makefile.shared:
  • Add "analyze" argument to xcodebuild command when invoking "make analyze" to run clang static analyzer in deep mode. Simplify "make analyze" since $(PATH_TO_SCAN_BUILD) does not need to be set.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj:
  • Treat "analyze" the same as "build" for "ACTION" environment variable.

Source/WebCore:

  • Scripts/generate-derived-sources.sh:
  • Treat "analyze" the same as "build" for "ACTION" environment variable.

Source/WebKit:

  • Scripts/generate-derived-sources.sh:
  • WebKit.xcodeproj/project.pbxproj:
  • Treat "analyze" the same as "build" for "ACTION" environment variable.

Source/WebKitLegacy/mac:

  • migrate-headers.sh:
  • Treat "analyze" the same as "build" for "ACTION" environment variable.

Tools:

  • DumpRenderTree/Scripts/generate-derived-sources.sh:
  • WebKitTestRunner/Scripts/generate-derived-sources.sh:
  • Treat "analyze" the same as "build" for "ACTION" environment variable.
9:23 AM Changeset in webkit [281087] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Win10 wk1 Release] http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=229146.

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:23 AM Changeset in webkit [281086] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] fast/forms/input-appearance-spinbutton-size.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229143

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:18 AM Changeset in webkit [281085] by commit-queue@webkit.org
  • 4 edits in trunk

[GLib] Enable mediastream setting if it's enabled at build-time
​https://bugs.webkit.org/show_bug.cgi?id=229134

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Adrian Perez de Castro.

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsConstructed):

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

9:14 AM Changeset in webkit [281084] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Unreviewed, reverting r281078.
​https://bugs.webkit.org/show_bug.cgi?id=229144

broke GTK/WPE mediastream tests

Reverted changeset:

"REGRESSION(r278981): [GStreamer][Debug] Assert crashes when
running media/track tests"
​https://bugs.webkit.org/show_bug.cgi?id=229123
​https://commits.webkit.org/r281078

8:57 AM Changeset in webkit [281083] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WPE] Test fast/mediastream/mediastreamtrack-video-clone.html is flaky timeout since r280775
​https://bugs.webkit.org/show_bug.cgi?id=229063

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Ignore redundant stream collections also in the mediastream case. Both the mediastream and
MSE source elements behave similarly regarding stream collections.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

LayoutTests:

  • platform/glib/TestExpectations:
8:23 AM Changeset in webkit [281082] by ddkilzer@apple.com
  • 2 edits
    1 add in trunk/Tools

Fix ASan+UBSan builds with Xcode 13
<​https://webkit.org/b/229122>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitdirs.pm:

(XcodeOptions):

  • Use asan+ubsan.xcconfig when both are enabled.
  • sanitizer/asan+ubsan.xcconfig: Add.
7:45 AM Changeset in webkit [281081] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/mac

-[WebView initWithCoder:] should use -[NSCoder decodeValueOfObjCType:at:size:]
<​https://webkit.org/b/229121>
<rdar://problem/81956163>

Reviewed by Anders Carlsson.

  • WebView/WebView.mm:

(-[WebView initWithCoder:]):

  • Switch to -[NSCoder decodeValueOfObjCType:at:size:].
7:12 AM Changeset in webkit [281080] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, reverting r281077.
​https://bugs.webkit.org/show_bug.cgi?id=229137

broke GTK/WPE builds

Reverted changeset:

"[WPE][GTK] Clean build broken with python3 after r280382"
​https://bugs.webkit.org/show_bug.cgi?id=228628
​https://commits.webkit.org/r281077

6:56 AM Changeset in webkit [281079] by Carlos Garcia Campos
  • 4 edits in trunk/Tools

[GTK] Test WebKitWebView/page-visibility is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=214804

Reviewed by Adrian Perez de Castro.

Do not wait for title change if the title already changed.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewPageVisibility):

  • TestWebKitAPI/glib/TestExpectations.json:
  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::waitUntilTitleChangedTo):
(WebViewTest::waitUntilTitleChanged):

6:37 AM Changeset in webkit [281078] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
​https://bugs.webkit.org/show_bug.cgi?id=229123

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Xabier Rodriguez-Calvar.

The TrackPrivateBaseGStreamer class now includes all the common code that is used by its
subclasses. InbandTextTrackPrivateGStreamer now returns valid track IDs (fixing the issue of
this regression: ASSERTs). The patch also includes coding style fixes, removal of un-needed
includes and a few other clean-ups related with the Track support in the GStreamer platform
layer.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect): Deleted.
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged): Deleted.
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfStreamChanged): Deleted.

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

(WebCore::InbandTextTrackPrivateGStreamer::create):
(WebCore::InbandTextTrackPrivateGStreamer::streamId const): Deleted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack):
(WebCore::MediaPlayerPrivateGStreamer::handleTextSample):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::generateUniquePlaybin2StreamID):
(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer):
(WebCore::TrackPrivateBaseGStreamer::setPad):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfStreamChanged):
(WebCore::TrackPrivateBaseGStreamer::streamChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

(WebCore::TrackPrivateBaseGStreamer::setIndex):
(WebCore::TrackPrivateBaseGStreamer::stream):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
6:34 AM Changeset in webkit [281077] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WPE][GTK] Clean build broken with python3 after r280382
​https://bugs.webkit.org/show_bug.cgi?id=228628

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Adrian Perez de Castro.

The webkitpy autoinstall doesn't reliably work when it's triggered from concurrent
processes. Replace webkitpy usage in apply-build-revision-to-files.py script with explicit
calls to svnversion, git svn info or git log -1, depending on the kind of SCM checkout.

  • glib/apply-build-revision-to-files.py:

(get_build_revision):
(main):

6:33 AM Changeset in webkit [281076] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit

[GTK] MiniBrowser crashes when closed while capturing desktop
​https://bugs.webkit.org/show_bug.cgi?id=228232
<rdar://problem/81093648>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-16
Reviewed by Adrian Perez de Castro.

Remove explicit detach call from the UIClient. Resetting the page state in the proxy *after*
the clients have been cleared is a better fix for this crash.

  • UIProcess/API/glib/WebKitUIClient.cpp:

(attachUIClientToView):
(detachUIClientFromView): Deleted.

  • UIProcess/API/glib/WebKitUIClient.h:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewDispose):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

3:31 AM Changeset in webkit [281075] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.33.3

WebKitGTK 2.33.3

3:30 AM Changeset in webkit [281074] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.3 release

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.33.3.
3:18 AM Changeset in webkit [281073] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK distcheck build

  • webkitglib-symbols.map: Remove symbols that are not in the library anymore.
2:39 AM Changeset in webkit [281072] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK distcheck build

2:08 AM Changeset in webkit [281071] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Move WebMAudioUtilitiesCocoa.h from Headers.cmake to PlatformMac.cmake
​https://bugs.webkit.org/show_bug.cgi?id=229129

Unreviewed. Fix GTK/WPE distcheck build.

  • Headers.cmake:
  • PlatformMac.cmake:

Aug 15, 2021:

11:55 PM Changeset in webkit [281070] by magomez@igalia.com
  • 19 edits in trunk

[GTK][WPE] Add API to pass WebKitMemoryPressureHandler parameters to the network processes
​https://bugs.webkit.org/show_bug.cgi?id=228227

Reviewed by Carlos Garcia Campos.

Source/WebKit:

Added webkit_website_data_manager_set_memory_pressure_settings() API function to pass a
WebKitMemoryPressureSettings instance as the settings to use by all the network processes.

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

  • UIProcess/API/glib/WebKitMemoryPressureSettings.cpp:
  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkit_website_data_manager_set_memory_pressure_settings):

  • UIProcess/API/gtk/WebKitWebsiteDataManager.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/wpe/WebKitWebsiteDataManager.h:
  • UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didExceedMemoryLimit):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/WebProcessPool.h:
  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::memoryPressureMonitorDisabled):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Source/WTF:

Added a new method to MemoryPressureHandler to set the configuration by copying the parameter
instead of moving it.

  • wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::setConfiguration):

Tools:

Added an API test for webkit_website_data_manager_set_memory_pressure_settings().

  • TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(MemoryPressureTest::setup):
(MemoryPressureTest::teardown):
(MemoryPressureTest::loadFailedCallback):
(MemoryPressureTest::waitUntilLoadFailed):
(testMemoryPressureSettings):
(beforeAll):

11:51 PM Changeset in webkit [281069] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

French translation of webkit.HEAD
​https://bugs.webkit.org/show_bug.cgi?id=229119

Rubber-stamped by Carlos Garcia Campos.

  • fr.po:
8:34 PM Changeset in webkit [281068] by Wenson Hsieh
  • 10 edits in trunk

[iOS 15] editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=229126
rdar://80384801

Reviewed by Tim Horton.

Source/WebKit:

Remove the (now-unused) testing SPI -[WKWebView _doAfterResettingSingleTapGesture:]. See Tools/ChangeLog for
more information.

  • UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _doAfterResettingSingleTapGesture:]): Deleted.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _doAfterResettingSingleTapGesture:]): Deleted.

Tools:

This test exercises the ability to cause platform selection views to show up after tapping the web view while a
DOM selection is set. In this codepath, selection views are installed when the web view becomes first responder,
when we call into -[UIWKTextInteractionAssistant activateSelection]; the call to -becomeFirstResponder, in
turn, comes from UIKit's internal UITextTapRecognizer gesture, which recognizes the single tap and makes the
content view first responder.

In the case where this test fails, the synthesized tap gesture fails to activate the text tap recognizer; this
happens because the timing of when the UITextTapRecognizer gets reset (i.e. -_resetGestureRecognizer) races
against the timing of when the synthesized touch event is sent to the gesture recognizer. When the touch is
delivered to the gesture *before* the text tap gesture is reset, we end up timing out because the text tap
gesture's action never fires and makes the content view first responder.

To ensure that we don't lose this race and time out, we augment the existing mechanism in
UIScriptControllerIOS::waitForSingleTapToReset() to wait for *all* enabled single tap (and single touch)
gestures to reset, instead of only waiting for the web view's synthetic click gesture. Importantly, this
includes UITextTapRecognizer, which ensures that the touches are delivered to the gesture only after the text
tap gesture has been reset (and transitions to Possible state).

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::waitForSingleTapToReset const):

Instead of using testing SPI (-_doAfterResettingSingleTapGesture:) to wait for the single tap to reset, we can
just directly iterate through all the gestures on the content view and wait for all enabled single tap gestures
to transition back to Possible state.

LayoutTests:

Update test expectations for this flaky test.

  • platform/ios-14/TestExpectations:
  • platform/ios/TestExpectations:
1:46 PM Changeset in webkit [281067] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

[LFC Display] Make Display::ImageBox a CachedImageClient to get image repaint working
​https://bugs.webkit.org/show_bug.cgi?id=229125

Reviewed by Anders Carlsson.

Make Display::ImageBox hold a CachedResourceHandle<CachedImage> so it can register
as a client and get notified about image changes, for repainting.

  • display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::displayBoxForLayoutBox const):

  • display/css/DisplayImageBox.cpp:

(WebCore::Display::ImageBox::ImageBox):
(WebCore::Display::m_cachedImage):
(WebCore::Display::ImageBox::~ImageBox):
(WebCore::Display::ImageBox::image const):
(WebCore::Display::ImageBox::imageChanged):
(WebCore::Display::ImageBox::debugDescription const):
(WebCore::Display::m_image): Deleted.

  • display/css/DisplayImageBox.h:

(WebCore::Display::ImageBox::image const): Deleted.

1:05 PM Changeset in webkit [281066] by ddkilzer@apple.com
  • 5 edits in trunk/Source

Bug 229112: ThreadSanitizer: data races of WTF::String in WebResourceLoadStatisticsStore
<​https://webkit.org/b/229112>
<rdar://problem/81940951>

Reviewed by Kate Cheney.

Source/WebCore:

Covered by running layout tests with TSan in:

http/tests/privateClickMeasurement/

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):

  • Add WTFMove() for updated SourceSite constructor. Verified that this doesn't create a use-after-move issue.
  • loader/PrivateClickMeasurement.h:

(WebCore::PrivateClickMeasurement::SourceSite::SourceSite):

  • Change to take rvalue reference for efficiency and to match AttributionDestinationSite constructor.

(WebCore::PrivateClickMeasurement::SourceSite::isolatedCopy const): Add.
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::isolatedCopy const): Add.

  • Add isolatedCopy() methods to use in multi-threaded scenarios.

Source/WebKit:

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::attributePrivateClickMeasurement):

  • Make isolated copies of sourceSite and destinationSite to fix data races.

(WebKit::WebResourceLoadStatisticsStore::privateClickMeasurementToString):

  • Make isolated copy of WTF::String to fix data race.
12:02 PM Changeset in webkit [281065] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[GLIB] Update test expectations after r280077
​https://bugs.webkit.org/show_bug.cgi?id=229124

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-15

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
11:38 AM Changeset in webkit [281064] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Remove shadow related SVG functionality
​https://bugs.webkit.org/show_bug.cgi?id=228870

Patch by Rob Buis <​rbuis@igalia.com> on 2021-08-15
Reviewed by Simon Fraser.

Remove shadow related SVG functionality since it was added
for the removed property -webkit-svg-shadow (see r238071).

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator== const):
(WebCore::SVGRenderStyle::copyNonInheritedFrom):
(WebCore::SVGRenderStyle::diff const):

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialLightingColor):
(WebCore::SVGRenderStyle::baselineShiftValue const):
(WebCore::SVGRenderStyle::isolatesBlending const):
(WebCore::SVGRenderStyle::initialShadow): Deleted.
(WebCore::SVGRenderStyle::setShadow): Deleted.
(WebCore::SVGRenderStyle::shadow const): Deleted.

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeFloatVisibleRectInContainer const):
(WebCore::RenderSVGRoot::updateCachedBoundaries):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatVisibleRectInContainer):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:
10:44 AM Changeset in webkit [281063] by Kocsen Chung
  • 1 copy in tags/Safari-612.1.27.0.23

Tag Safari-612.1.27.0.23.

10:41 AM Changeset in webkit [281062] by Yijia Huang
  • 5 edits in trunk/Source/JavaScriptCore

[ARM64] Add Pre/Post-Indexed Address Mode to Air for ARM64 (Store Instruction)
​https://bugs.webkit.org/show_bug.cgi?id=228538

Reviewed by Filip Pizlo.

The previous patch has introduced the pre/post-index address mode for Load instruction,
which benefits loop program. Here, this patch adds the corresponding mode for Store
instruction. Store Register (immediate) stores a word or a doubleword from a register
to memory. The address that is used for the store is calculated from a base register
and an immediate offset.

######################################
## Pre-Index Address Mode For Store ##
######################################

STR Wt, [Xn, #imm]!

In B3 Reduction Strength, since we have this reduction rule:

Turns this: Store(value, Add(address, offset1), offset = offset2)
Into this: Store(value, address, offset = offset1 + offset2)

The equivalent pattern is:

address = Add(base, offset)
...
memory = Store(value, base, offset)

Here, we only consider the pattern:

address = Add(base, offset)
memory = Store(value, base, offset)

And, this patch directly treats it as the canonical form. Ideally, we should move
memory to just after the address like what we did for PreIndex Load in the previous
patch. But, we cannot provide a better way to do that since the value may be
used between address and memory. To move value upward, we must move all descendants
of the value along with it to prevent B3 IR index violations, which is risky and expensive.

Next, lower to Air:

Move %base, %address
Move %value, (%address, prefix(offset))

######################################
## Post-Index Address Mode For Load ##
######################################

STR Wt, [Xn], #imm

Then, the equivalent pattern is:

memory = Store(value, base, 0)
...
address = Add(base, offset)

First, we convert it to the canonical form:

newOffset = Constant
newAddress = Add(base, offset)
memory = Store(value, base, 0) move the offset and address to just before the memory
...
offset = Identity(newOffset)
address = Identity(newAddress)

Next, lower to Air:

Move %base, %newAddress
Move %value, (%newAddress, postfix(offset))

##############################################
## Test for Pre/Post-Increment Address Mode ##
##############################################

B3 IR:

Int64 b@0 = ArgumentReg(%x0)
Int64 b@1 = ArgumentReg(%x1)
Int64 b@2 = Const64(8)
Int64 b@3 = Add(b@0, $8(b@2))
Void b@4 = Store(b@1, b@3, ControlDependent|Writes:Top)
Void b@5 = Return(b@3, Terminal)

W/O Pre-Increment Address Mode:

Move %x0, %x2, b@0
Add64 $8, %x2, %x0, b@3
Move %x1, 8(%x2), b@4
Ret64 %x0, b@5

W/ Pre-Increment Address Mode:

MoveWithIncrement64 %x1, (%x0,Pre($8)), b@4
Ret64 %x0, b@5

B3 IR:

Int64 b@0 = ArgumentReg(%x0)
Int64 b@1 = ArgumentReg(%x1)
Void b@2 = Store(b@1, b@0, ControlDependent|Writes:Top)
Int64 b@3 = Const64(8)
Int64 b@4 = Add(b@0, $8(b@3))
Void b@5 = Return(b@4, Terminal)

W/O Post-Increment Address Mode:

Move %x1, (%x0), b@2
Add64 $8, %x0, %x0, b@4
Ret64 %x0, b@5

W/ Post-Increment Address Mode:

MoveWithIncrement64 %x1, (%x0,Post($8)), b@2
Ret64 %x0, b@5

  • b3/B3CanonicalizePrePostIncrements.cpp:

(JSC::B3::canonicalizePrePostIncrements):

  • b3/B3LowerToAir.cpp:
  • b3/testb3.h:
  • b3/testb3_3.cpp:

(testStorePreIndex32):
(testStorePreIndex64):
(testStorePostIndex32):
(testStorePostIndex64):
(addShrTests):

8:44 AM Changeset in webkit [281061] by Simon Fraser
  • 22 edits
    1 copy in trunk/Source/WebCore

[LFC Display] Introduce type-safe rect types for the display tree
​https://bugs.webkit.org/show_bug.cgi?id=220214

Reviewed by Alan Bujtas.

Introduce AbsoluteFloatRect, UnadjustedAbsoluteFloatRect and ViewFloatRect which are
type-safe float rect types for the display tree.

AbsoluteFloatRect is relative to document origin. UnadjustedAbsoluteFloatRect is similar,
but is computed before scrolling and transforms are taken into account.

ViewFloatRect is relative to the view.

  • WebCore.xcodeproj/project.pbxproj:
  • display/DisplayGeometryTypes.h: Copied from Source/WebCore/display/css/DisplayReplacedBox.h.

(WebCore::Display::intersection):
(WebCore::Display::unionRect):

  • display/DisplayTree.cpp:

(WebCore::Display::Tree::setBoxNeedsDisplay const):

  • display/DisplayTree.h:
  • display/DisplayTreeBuilder.cpp:
  • display/css/DisplayBox.cpp:

(WebCore::Display::Box::Box):
(WebCore::Display::Box::setNeedsDisplay):

  • display/css/DisplayBox.h:

(WebCore::Display::Box::Box):
(WebCore::Display::Box::absoluteBoxRect const):
(WebCore::Display::Box::absolutePaintingExtent const):

  • display/css/DisplayBoxClip.cpp:

(WebCore::Display::BoxClip::pushClip):
(WebCore::Display::BoxClip::pushRoundedClip):

  • display/css/DisplayBoxClip.h:

(WebCore::Display::BoxClip::clipRect const):

  • display/css/DisplayBoxDecorationPainter.cpp:

(WebCore::Display::BoxDecorationPainter::paintFillLayer const):

  • display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::displayBoxForRootBox const):
(WebCore::Display::BoxFactory::displayBoxForLayoutBox const):
(WebCore::Display::BoxFactory::displayBoxForTextRun const):
(WebCore::Display::BoxFactory::setupBoxGeometry const):

  • display/css/DisplayBoxModelBox.cpp:

(WebCore::Display::BoxModelBox::BoxModelBox):
(WebCore::Display::BoxModelBox::clipForDescendants const):
(WebCore::Display::BoxModelBox::absolutePaintingExtent const):

  • display/css/DisplayBoxModelBox.h:

(WebCore::Display::BoxModelBox::BoxModelBox):
(WebCore::Display::BoxModelBox::absoluteBorderBoxRect const):
(WebCore::Display::BoxModelBox::absolutePaddingBoxRect const):
(WebCore::Display::BoxModelBox::absoluteContentBoxRect const):
(WebCore::Display::BoxModelBox::setAbsolutePaddingBoxRect):
(WebCore::Display::BoxModelBox::setAbsoluteContentBoxRect):

  • display/css/DisplayContainerBox.cpp:

(WebCore::Display::ContainerBox::ContainerBox):

  • display/css/DisplayContainerBox.h:
  • display/css/DisplayImageBox.cpp:

(WebCore::Display::ImageBox::ImageBox):

  • display/css/DisplayImageBox.h:
  • display/css/DisplayReplacedBox.cpp:

(WebCore::Display::ReplacedBox::ReplacedBox):

  • display/css/DisplayReplacedBox.h:

(WebCore::Display::ReplacedBox::replacedContentRect const):
(WebCore::Display::ReplacedBox::setReplacedContentRect):

  • display/css/DisplayStackingItem.h:

(WebCore::Display::StackingItem::paintedContentBounds const):
(WebCore::Display::StackingItem::paintedBoundsIncludingDescendantItems const):
(WebCore::Display::StackingItem::setPaintedContentBounds):
(WebCore::Display::StackingItem::setPaintedBoundsIncludingDescendantItems):

  • display/css/DisplayTextBox.cpp:

(WebCore::Display::TextBox::TextBox):

  • display/css/DisplayTextBox.h:
8:43 AM Changeset in webkit [281060] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

[LFC Display] Add a Display::Box flag for HasTransfrom
​https://bugs.webkit.org/show_bug.cgi?id=229115

Reviewed by Alan Bujtas.

It's possible for a non-box model box to have a RenderStyle with a transform, but that
style isn't applied because transforms only apply to atomic inline or block boxes,
so store a bit on Box for boxes that have transforms.

  • display/css/DisplayBox.h:

(WebCore::Display::Box::setHasTransform):
(WebCore::Display::Box::hasTransform const):

  • display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::constructBoxRareGeometry const):
(WebCore::Display::BoxFactory::setupBoxModelBox const):

  • display/css/DisplayCSSPainter.cpp:

(WebCore::Display::CSSPainter::paintAtomicallyPaintedBox):

Aug 14, 2021:

10:25 PM Changeset in webkit [281059] by Kocsen Chung
  • 5 edits in branches/safari-612.1.27.0-branch/Source

Cherry-pick r281058. rdar://problem/81947517

[GPU Process] REGRESSION: WebContent often crashes when opening a Google spreadsheet with charts
​https://bugs.webkit.org/show_bug.cgi?id=229106
<rdar://81806877>

Reviewed by Wenson Hsieh.

Source/WebCore:

Add a method to return the backend of the ImageBuffer.

  • platform/graphics/ConcreteImageBuffer.h:
  • platform/graphics/ImageBuffer.h:

Source/WebKit:

Don't resume processing the DisplayList of an ImageBuffer until its
backend is created.

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::didAppendData):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:22 PM Changeset in webkit [281058] by Said Abou-Hallawa
  • 5 edits in trunk/Source

[GPU Process] REGRESSION: WebContent often crashes when opening a Google spreadsheet with charts
​https://bugs.webkit.org/show_bug.cgi?id=229106
<rdar://81806877>

Reviewed by Wenson Hsieh.

Source/WebCore:

Add a method to return the backend of the ImageBuffer.

  • platform/graphics/ConcreteImageBuffer.h:
  • platform/graphics/ImageBuffer.h:

Source/WebKit:

Don't resume processing the DisplayList of an ImageBuffer until its
backend is created.

  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::didAppendData):

10:38 AM Changeset in webkit [281057] by commit-queue@webkit.org
  • 2 edits
    3 deletes in trunk/LayoutTests

[GLIB] Update baselines after r281012
​https://bugs.webkit.org/show_bug.cgi?id=229108

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-14

  • platform/glib/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any.worker-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/fetch/h1-parsing/status-code.window-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.