Timeline
Feb 12, 2022:
- 11:11 PM Changeset in webkit [289705] by
-
- 2 edits in trunk/LayoutTests
Skip imported/w3c/web-platform-tests/url/toascii.window.html on Catalina/Big Sur
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:42 PM Changeset in webkit [289704] by
-
- 2 edits in trunk/Source/bmalloc
Fix typos in libpas docs
https://bugs.webkit.org/show_bug.cgi?id=236550
Patch by Brandon Stewart <Brandon> on 2022-02-12
Reviewed by Yusuke Suzuki.
Fix several typos in libpas documentation.
- libpas/Documentation.md:
- 5:18 PM Changeset in webkit [289703] by
-
- 2 edits in trunk/Tools
[run-webkit-tests] Do not try and read from /dev/null
https://bugs.webkit.org/show_bug.cgi?id=236528
<rdar://problem/88836868>
Reviewed by Alexey Proskuryakov.
While writing to /dev/null is well defined, reading from it is not. Do not
read from /dev/null.
- Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket.init): Delete _wsin.
(PyWebSocket._prepare_config): Ditto.
(PyWebSocket._spawn_process): Use executive.PIPE instead of os.devnull.
(PyWebSocket._stop_running_server): Delete _wsin.
- 5:05 PM Changeset in webkit [289702] by
-
- 10 edits3 adds in trunk/Source/WebKit
Update preference location used for CaptivePortalMode.
https://bugs.webkit.org/show_bug.cgi?id=236135
<rdar://problem/88486544>
Patch by Gavin Phillips <gavin.p@apple.com> on 2022-02-12
Reviewed by Geoffrey Garen.
- PlatformMac.cmake:
- SourcesCocoa.txt:
- UIProcess/API/Cocoa/_WKSystemPreferences.h: Added.
- UIProcess/API/Cocoa/_WKSystemPreferences.mm: Added.
(+[_WKSystemPreferences isCaptivePortalModeEnabled]):
(+[_WKSystemPreferences setCaptivePortalModeEnabled:]):
(+[_WKSystemPreferences isCaptivePortalModeIgnored:]):
(+[_WKSystemPreferences setCaptivePortalModeIgnored:ignore:]):
- UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h: Added.
- UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKUserDefaults findPreferenceChangesAndNotifyForKeys:toValuesForKeys:]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::captivePortalModeConfigUpdateCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
(WebKit::isCaptivePortalModeEnabledBySystemIgnoringCaching):
(WebKit::WebProcessPool::notifyPreferencesChanged):
- UIProcess/WebProcessPool.h:
- UIProcess/mac/DisplayCaptureSessionManager.h:
- UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia):
- WebKit.xcodeproj/project.pbxproj:
- 2:57 PM Changeset in webkit [289701] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Use system window and screen picker when available
https://bugs.webkit.org/show_bug.cgi?id=236531
rdar://87111816
Unreviewed build fix.
- platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm:
(WebCore::ScreenCaptureKitSharingSessionManager::takeSharingSessionForFilter):
- 2:44 PM Changeset in webkit [289700] by
-
- 4 edits2 adds in trunk
WebGL2 AllowShared TypedArray should be accepted
https://bugs.webkit.org/show_bug.cgi?id=232662
Reviewed by Dean Jackson.
Source/WebCore:
Test: webgl/webgl-allow-shared-typed-array.html
TypedArray with [AllowShared] annotation is not handled properly, which results in handling it as Sequence<T>,
invoking iteration protocol to copy them. This patch adds that as the same to [AllowShared] ArrayBuffer / ArrayBufferView.
- bindings/IDLTypes.h:
- bindings/js/JSDOMConvertUnion.h:
LayoutTests:
- webgl/webgl-allow-shared-typed-array-expected.txt: Added.
- webgl/webgl-allow-shared-typed-array.html: Added.
- 1:33 PM Changeset in webkit [289699] by
-
- 4 edits1 delete in trunk/LayoutTests
Unreviewed test gardening: imported/w3c/web-platform-tests/url/toascii.window.html
LayoutTests/imported/w3c:
- web-platform-tests/url/toascii.window-expected.txt:
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/url/toascii.window-expected.txt: Removed.
- platform/mac/TestExpectations:
- 11:25 AM Changeset in webkit [289698] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: [Flexbox] Show item bounds, gaps, and free space in flex overlays
https://bugs.webkit.org/show_bug.cgi?id=236410
Reviewed by Devin Rousso.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::flexibleBoxRendererBeganLayoutImpl):
(WebCore::InspectorInstrumentation::flexibleBoxRendererWrappedToNextLineImpl):
(WebCore::InspectorInstrumentation::instrumentingAgents):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::flexibleBoxRendererBeganLayout):
(WebCore::InspectorInstrumentation::flexibleBoxRendererWrappedToNextLine):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::flexibleBoxRendererBeganLayout):
(WebCore::InspectorDOMAgent::flexibleBoxRendererWrappedToNextLine):
(WebCore::InspectorDOMAgent::flexibleBoxRendererCachedItemsAtStartOfLine):
- inspector/agents/InspectorDOMAgent.h:
- Add instrumentation points specifically for flexbox renderers to keep track of which items start a new line
inside flex containers. The start of the first line is not recorded because it will always be zero.
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
- Force a layout of the document to ensure that our collection of flexbox line starts is correctly populated
when attaching an inspector, since without an inspector this information is not kept beyond layout.
- inspector/InspectorOverlay.cpp:
(WebCore::drawLayoutPattern):
- Generalize
drawLayoutHatchingto support different line styles in order to support the new stippling fill. - In order to support "flipping" the pattern we now use a rectangle encompassing the provided quad as the edges
we follow for filling the pattern (the existing clipping ensures that the final product is still within the
quad). This also resolves an issue that could occur in transformed containers (non-rectangular) where the
spacing was inconsistent at different rotations/perspectives.
(WebCore::drawLayoutStippling):
- A new dot-pattern effect similar to hatching, but using small dots to fill the space instead.
(WebCore::drawLayoutHatching):
- Updated to use the new generic
drawLayoutPatternhelper.
(WebCore::InspectorOverlay::drawFlexOverlay):
(WebCore::InspectorOverlay::buildFlexOverlay):
- Handle iterating through the flex children to show their bounds as well as the spacing/gaps between them.
Almost all this work is done in relative terms, like leading/trailing/cross-axis/main-axis to make it easier to
reason about what should happen for different writing modes, text direction, flex direction, and flex wrapping.
To accomplish this coordinates of children are read through specialcorrected*helper functions that take in
to account the determined direction, main-axis reversal, and cross axis-reversal from all of the relevant
properties. This means there are only 8 (23) actual permutations of flex layout (since the layout inside each
individual child is irrelevant here). Throughout we are working with flex children frames that are relative to
their parent, which saves us from having to deal with transforms until after we have constructed most of our
overlay representation, only needing to be passed throughchildQuadToRootQuadbefore being added to the
appropriate part of the highlight object.
- inspector/InspectorOverlay.h:
(WebCore::InspectorOverlay::Highlight::FlexHighlightOverlay::encode const):
(WebCore::InspectorOverlay::Highlight::FlexHighlightOverlay::decode):
- rendering/RenderBox.h:
(WebCore::RenderBox::marginBox const):
- Add a way to get the entire margin box instead of its individual components.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
- rendering/RenderFlexibleBox.h:
- Make getting the computed inter-item and inter-line gap public so we can use them in the overlay.
- Add instrumentation calls to keep track of the indexes of items that start a new line during layout when an
Inspector is attached.
- platform/LayoutUnit.h:
(WebCore::operator!=):
- 10:16 AM Changeset in webkit [289697] by
-
- 33 edits11 adds in trunk
Add settings to restrict media containers and codecs when in Captive Portal mode
https://bugs.webkit.org/show_bug.cgi?id=236245
Reviewed by Eric Carlson.
Source/WebCore:
Tests: media/media-allowed-codecs.html
media/media-allowed-containers.html
media/media-source/media-source-allowed-codecs.html
media/media-source/media-source-allowed-containers.html
Add settings at the WebCore level to optionally declare a list of container types,
video codecs, audio codecs, and caption formats to allow when loading media through
HTMLMediaElement and MediaSource.
There are some cases where the codec ID, typically a four-character-code embedded
in the container itself, does not match the RFC4281 codec string. Notably, this is the case
with "mp4a.40" and 'aac '. So the settings must include both the codec ID and the codec
type in string form.
Query these lists in HTMLMediaElement::canPlayType() and MediaSource::isTypeSupported()
and reject ContentTypes which do not conform to the allowed types.
Query these lists in MediaSource::changeType() to disallow switching to an unsupported
ContentType.
If these lists are set, pass them into AVURLAsset as creation options.
When a new AVAssetTrack is loaded, query these lists and if the track's type does not
conform to the allowed types, synthesize an error and block further loading.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::changeType):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::HTMLMediaElement::allowedMediaContainerTypes const):
(WebCore::HTMLMediaElement::allowedMediaCodecTypes const):
(WebCore::HTMLMediaElement::allowedMediaVideoCodecTypes const):
(WebCore::HTMLMediaElement::allowedMediaAudioCodecTypes const):
(WebCore::HTMLMediaElement::allowedMediaCaptionFormatTypes const):
- html/HTMLMediaElement.h:
- page/SettingsBase.cpp:
(WebCore::SettingsBase::setAllowedMediaContainerTypes):
(WebCore::SettingsBase::setAllowedMediaVideoCodecTypes):
(WebCore::SettingsBase::setAllowedMediaAudioCodecTypes):
(WebCore::SettingsBase::setAllowedMediaCaptionFormatTypes):
- page/SettingsBase.h:
(WebCore::SettingsBase::setAllowedMediaContainerTypes):
(WebCore::SettingsBase::allowedMediaContainerTypes const):
(WebCore::SettingsBase::setAllowedMediaVideoCodecTypes):
(WebCore::SettingsBase::allowedMediaVideoCodecTypes const):
(WebCore::SettingsBase::setAllowedMediaAudioCodecTypes):
(WebCore::SettingsBase::allowedMediaAudioCodecTypes const):
(WebCore::SettingsBase::setAllowedMediaCaptionFormatTypes):
(WebCore::SettingsBase::allowedMediaCaptionFormatTypes const):
- platform/graphics/ContentTypeUtilities.cpp: Added.
(WebCore::contentTypesToCodecs):
(WebCore::contentTypeMeetsContainerAndCodecTypeRequirements):
- platform/graphics/ContentTypeUtilities.h: Added.
- platform/graphics/FourCC.h:
(WebCore::FourCC::encode const):
(WebCore::FourCC::decode):
- platform/graphics/MediaPlayer.cpp:
(WebCore::nullOptionalStringVector):
(WebCore::nullOptionalFourCCVector):
(WebCore::MediaPlayer::nextBestMediaEngine):
(WebCore::MediaPlayer::allowedMediaContainerTypes const):
(WebCore::MediaPlayer::allowedMediaVideoCodecTypes const):
(WebCore::MediaPlayer::allowedMediaAudioCodecTypes const):
(WebCore::MediaPlayer::allowedMediaCaptionFormatTypes const):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaEngineSupportParameters::encode const):
(WebCore::MediaEngineSupportParameters::decode):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::loadingMetadata const):
- platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
(WebCore::contentTypesToCodecs): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::allTracksArePlayable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::trackIsPlayable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsTypeAndCodecs):
(WebCore::assetTrackMetadataKeyNames):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setAllowedMediaContainerTypes):
(WebCore::InternalSettings::setAllowedMediaVideoCodecTypes):
(WebCore::InternalSettings::setAllowedMediaAudioCodecTypes):
(WebCore::InternalSettings::setAllowedMediaCaptionFormatTypes):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebCore/PAL:
- pal/cocoa/AVFoundationSoftLink.h:
- pal/cocoa/AVFoundationSoftLink.mm:
Source/WebKit:
RemoteMediaPlayerManager caches the results of supportsTypeAndCodecs() calls, which
is problematic when those results can change due to a change in settings. So enforce
the allowed codec and containers settings at the RemoteMediaPlayerManager level. Also,
pass those settings across the GPU process boundary via RemoteMediaPlayerProxyConfiguration.
Drive-by fix: refactor RemoteMediaPlayerProxyConfiguration::decode() so as not to require
re-declaring the types of every ivar, and greatly simplify the implementation.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::supportsTypeAndCodecs):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
LayoutTests:
- media/media-allowed-codecs-expected.txt: Added.
- media/media-allowed-codecs.html: Added.
- media/media-allowed-containers-expected.txt: Added.
- media/media-allowed-containers.html: Added.
- media/media-source/media-source-allowed-codecs-expected.txt: Added.
- media/media-source/media-source-allowed-codecs.html: Added.
- media/media-source/media-source-allowed-containers-expected.txt: Added.
- media/media-source/media-source-allowed-containers.html: Added.
- 8:08 AM Changeset in webkit [289696] by
-
- 17 edits3 adds in trunk/Source
[macOS] Use system window and screen picker when available
https://bugs.webkit.org/show_bug.cgi?id=236531
rdar://87111816
Reviewed by Jer Noble.
Source/WebCore:
Tested manually.
- SourcesCocoa.txt: Add new files.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- en.lproj/Localizable.strings: Update prompts.
- platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::capturerConfigurationChanged): Allow a capturer
to notify the source of a configuration change.
- platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:
(WebCore::CapturerObserver::capturerConfigurationChanged):
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(-[WebCoreScreenCaptureKitHelper stream:didStopWithError:]): Forward delegate callbacks
to the capture source.
(-[WebCoreScreenCaptureKitHelper sessionDidEnd:]): Ditto.
(-[WebCoreScreenCaptureKitHelper sessionDidChangeContent:]): Ditto.
(-[WebCoreScreenCaptureKitHelper pickerCanceledForSession:]): Ditto.
(WebCore::ScreenCaptureKitCaptureSource::sessionDidChangeContent): React to a
reconfiguration.
(WebCore::ScreenCaptureKitCaptureSource::sessionDidEnd):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream): Use the sharing
session manager when available.
(WebCore::ScreenCaptureKitCaptureSource::intrinsicSize const): Get the size from
the content when possible.
- platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h: Added.
(WebCore::ScreenCaptureKitSharingSessionManager::SharingSessionObserver::operator== const):
- platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm: Added.
(-[WebDisplayMediaPromptHelper initWithCallback:]):
(-[WebDisplayMediaPromptHelper disconnect]):
(-[WebDisplayMediaPromptHelper startObservingSession:]):
(-[WebDisplayMediaPromptHelper stopObservingSession:]):
(-[WebDisplayMediaPromptHelper sessionDidEnd:]):
(-[WebDisplayMediaPromptHelper sessionDidChangeContent:]):
(-[WebDisplayMediaPromptHelper pickerCanceledForSession:]):
(WebCore::ScreenCaptureKitSharingSessionManager::isAvailable):
(WebCore::ScreenCaptureKitSharingSessionManager::singleton):
(WebCore::ScreenCaptureKitSharingSessionManager::ScreenCaptureKitSharingSessionManager):
(WebCore::ScreenCaptureKitSharingSessionManager::~ScreenCaptureKitSharingSessionManager):
(WebCore::ScreenCaptureKitSharingSessionManager::pickerCanceledForSession):
(WebCore::ScreenCaptureKitSharingSessionManager::sessionDidEnd):
(WebCore::ScreenCaptureKitSharingSessionManager::sessionDidChangeContent):
(WebCore::ScreenCaptureKitSharingSessionManager::showWindowPicker):
(WebCore::ScreenCaptureKitSharingSessionManager::showScreenPicker):
(WebCore::ScreenCaptureKitSharingSessionManager::promptForGetDisplayMedia):
(WebCore::ScreenCaptureKitSharingSessionManager::takeSharingSessionForFilter):
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/mac/ScreenCaptureKitSoftLink.h:
- pal/mac/ScreenCaptureKitSoftLink.mm:
- pal/spi/mac/ScreenCaptureKitSPI.h: Added.
Source/WebKit:
- Platform/spi/Cocoa/SafeBrowsingSPI.h:
- UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::alertForGetDisplayMedia): Update prompt strings.
(WebKit::DisplayCaptureSessionManager::showWindowPicker): Use capture session
manager when available.
(WebKit::DisplayCaptureSessionManager::showScreenPicker): Ditto.
Source/WTF:
- wtf/PlatformHave.h: Define HAVE_SC_CONTENT_SHARING_SESSION.
- 7:48 AM Changeset in webkit [289695] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] REGRESSION(r289611): Debug builds fail linking binaries with ld.lld
https://bugs.webkit.org/show_bug.cgi?id=236506
Reviewed by Yusuke Suzuki.
- jit/ThunkGenerators.cpp: Use .previous in inline assembler for thunks in order to ensure
that mixed emission of assembler code and variable definitions correctly puts each of them
in their rightful sections in the output object code.
- 7:42 AM Changeset in webkit [289694] by
-
- 10 edits in trunk
Invoke mouse hover delegate callback on iOS
https://bugs.webkit.org/show_bug.cgi?id=233018
Patch by Kevin Turner <kevin_turner@apple.com> on 2022-02-12
Reviewed by Tim Horton.
Source/WebKit:
Allow mouseDidMoveOverElement: callbacks on iOS with pointer support.
Test: iOSMouseSupport.MouseDidMoveOverElement
- Shared/API/Cocoa/_WKHitTestResult.h:
- Shared/API/Cocoa/_WKHitTestResult.mm:
- Shared/API/Cocoa/_WKHitTestResultInternal.h:
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
Convert the modifier flags from the hover event to UIKeyModifierFlags if not on macOS.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(-[MouseSupportUIDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
(-[MouseSupportUIDelegate setMouseDidMoveOverElementHandler:]):
(TEST):
- 7:34 AM Changeset in webkit [289693] by
-
- 7 edits2 adds in trunk
Suppress style invalidation when matching :checked
https://bugs.webkit.org/show_bug.cgi?id=235910
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
Suppress style invalidation when matching :checked for option elements.
Test: fast/selectors/has-select-option-crash.html
- css/SelectorCheckerTestFunctions.h:
(WebCore::isChecked):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::selected const):
(WebCore::HTMLOptionElement::setSelectedState):
- html/HTMLOptionElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateListItemSelectedStates):
(WebCore::HTMLSelectElement::recalcListItems const):
- html/HTMLSelectElement.h:
LayoutTests:
- fast/selectors/has-select-option-crash-expected.txt: Added.
- fast/selectors/has-select-option-crash.html: Added.
- 7:29 AM Changeset in webkit [289692] by
-
- 3 edits in trunk/Source/WebCore
Make WidgetHierarchyUpdatesSuspensionScope cheaper if it has nothing to do
https://bugs.webkit.org/show_bug.cgi?id=236486
Reviewed by Simon Fraser.
With content that does a lot of DOM manipulation, we can create and
destroy a WidgetHierarchyUpdatesSuspensionScope on the stack many times.
When this object has nothing to do, it calls an out of line function.
This patch pulls out the check for whether it needs to call
moveWidgets() into the inline destructor.
This is a 1% saving on the jQuery-TodoMVC subtest of Speedometer 2,
though the effect on the top line score is minimal.
- rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
- rendering/RenderWidget.h:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
- 7:08 AM Changeset in webkit [289691] by
-
- 2 edits in trunk/Source/WebCore
Look up InputTypeFactoryMap with an ASCII lowercase string instead of using a ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=236532
Reviewed by Myles C. Maxfield.
InputType::create looks up the InputTypeFactoryMap based on the
AtomString value of the <input type> attribute. The HashMap uses an
ASCIICaseInsensitiveHash, but the AtomStrings stored in the map are all
ASCII lowercase to begin with. This means that we spend time doing an
ASCII case insensitive hash computation on the query string. Most
content already supplies an ASCII lowercase type value, so it's less
work to ASCII lowercase the type value and then look up the HashMap
using the regular hash for AtomStrings (i.e., pulling the hash out of
AtomString).
Doing this is a 0.5% improvement on a couple of Speedometer 2 subtests,
and a 0.1% improvement to the overall score.
- html/InputType.cpp:
(WebCore::InputType::create):
- 6:20 AM Changeset in webkit [289690] by
-
- 12 edits in trunk/Tools
Unreviewed, reverting r289687.
https://bugs.webkit.org/show_bug.cgi?id=236539
broke commit queue
Reverted changeset:
"git-webkit setup should allow changing the credentials"
https://bugs.webkit.org/show_bug.cgi?id=235297
https://commits.webkit.org/r289687
Patch by Commit Queue <commit-queue@webkit.org> on 2022-02-12
Feb 11, 2022:
- 6:29 PM Changeset in webkit [289689] by
-
- 3 edits in trunk/Source/JavaScriptCore
Allow structureHeapAddressSize to be set during build
https://bugs.webkit.org/show_bug.cgi?id=236527
Reviewed by Yusuke Suzuki.
Add
STRUCTURE_HEAP_ADDRESS_SIZE_IN_MBas a way to set the size of
structureHeapAddressSize at build time. Set a default for the PlayStation port.
- PlatformPlayStation.cmake:
- runtime/JSCConfig.h:
- 6:04 PM Changeset in webkit [289688] by
-
- 1 copy in tags/Safari-614.1.3
Tag Safari-614.1.3.
- 6:04 PM Changeset in webkit [289687] by
-
- 12 edits in trunk/Tools
git-webkit setup should allow changing the credentials
https://bugs.webkit.org/show_bug.cgi?id=235297
<rdar://problem/87988794>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.credentials): Pass validater into webkitscmpy.credentials if caller requests validation.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.credentials): Pass validater into webkitscmpy.credentials if caller requests validation.
- Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials): Allow caller to provide a callback which will validate credentials to ensure
they work, re-prompt user if credentials fail validation.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Request validation of GitHub credentials.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.credentials): Pass validation flag.
Canonical link: https://commits.webkit.org/247173@main
- 5:52 PM Changeset in webkit [289686] by
-
- 4 edits2 adds in trunk
contain:contentbreaks fullscreen
https://bugs.webkit.org/show_bug.cgi?id=236470
<rdar://88689388>
Reviewed by Simon Fraser.
Source/WebCore:
Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
positioned descendants anchored (contained) to this layout container.
This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
do for other, "layout scope changing" properties, see canContainFixedPositionObjects).
Test: fullscreen/fullscreen-prevented-by-containment.html
- css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
LayoutTests:
- fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
- fullscreen/fullscreen-prevented-by-containment.html: Added.
- 5:46 PM Changeset in webkit [289685] by
-
- 14 edits2 copies in trunk/Source/WebKit
Implement Reveal methods
https://bugs.webkit.org/show_bug.cgi?id=236478
Reviewed by Wenson Hsieh.
Respond to protocol methods that request RVItems for selection.
- Platform/IPC/ArgumentCoder.h:
- Platform/IPC/DataReference.h:
- Shared/Cocoa/SandboxExtensionCocoa.mm:
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
- SourcesCocoa.txt:
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestRVItemInSelectedRangeWithCompletionHandler:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::requestRVItemInCurrentSelectedRange):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestRVItemInCurrentSelectedRange):
- 5:45 PM Changeset in webkit [289684] by
-
- 5 edits in trunk/Tools
[git-webkit] Link issue to pull requests
https://bugs.webkit.org/show_bug.cgi?id=236339
<rdar://problem/88657772>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): Add link to pull request in issue comments, assign issue to
pull request author.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/247170@main
- 5:35 PM Changeset in webkit [289683] by
-
- 2 edits in trunk/Source/WTF
Turn overscroll-behavior on by default
https://bugs.webkit.org/show_bug.cgi?id=236060
Reviewed by Tim Nguyen.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 5:15 PM Changeset in webkit [289682] by
-
- 5 edits4 deletes in trunk
Unreviewed, reverting r289498.
https://bugs.webkit.org/show_bug.cgi?id=236534
Speedometer2 2% regression
Reverted changeset:
"Dialog element only animates once"
https://bugs.webkit.org/show_bug.cgi?id=236274
https://commits.webkit.org/r289498
- 5:12 PM Changeset in webkit [289681] by
-
- 18 edits1 add in trunk/Source
[iOS] Add a "Copy Cropped Image" context menu item when long pressing images
https://bugs.webkit.org/show_bug.cgi?id=236511
rdar://88817219
Reviewed by Devin Rousso.
Source/WebKit:
Add support for a new context menu item on iOS that allows the user to copy a cropped version of the source
image, after invoking markup UI. See below for more details.
- Configurations/WebKit.xcconfig:
Link against UniformTypeIdentifiers on macOS 11+, rather than macOS 12+.
- Platform/cocoa/CocoaImage.h:
- Platform/cocoa/CocoaImage.mm:
(WebKit::transcode):
(WebKit::transcodeWithPreferredMIMEType):
Move a helper function that transcodes an image to a given UTI into CocoaImage.h, as a standalone function.
Also, add a separate helper function here that transcodes an image to a given MIME type (with a fallback UTI, in
case the MIME type cannot be mapped to a suitable UTI that conforms to any image UTI). The new call sites of
this function are in WKContentViewInteraction.mm.
- Platform/cocoa/TextRecognitionUtilities.mm:
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):
Add a new
imageMIMETypemember to represent the MIME type of the source image used to generate the bitmap
image data inimage.
- SourcesCocoa.txt: Add CocoaImage.mm.
- UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:
(-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:userInfo:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:imageMIMEType:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:imageMIMEType:userInfo:]):
(-[_WKActivatedElementInfo imageMIMEType]):
Add plumbing for
imageMIMETypefrom InteractionInformationAtPosition (position information) into
_WKActivatedElementInfo, as an internal method. We use this information below, to transcode the resulting image
back to the source image format after applying markup, when invoking the new "Copy Cropped Image" item.
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:]): Deleted.
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:userInfo:]): Deleted.
- UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:
- UIProcess/API/Cocoa/_WKElementAction.h:
- UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):
(+[_WKElementAction imageForElementActionType:]):
Add support for the new "Copy Cropped Image" item tag (
_WKElementActionTypeCopyCroppedImage).
(elementActionTypeToUIActionIdentifier):
(uiActionIdentifierToElementActionType):
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant handleElementActionWithType:element:needsInteraction:]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showAttachmentSheet]):
(-[WKContentView performImageAnalysisMarkup:]):
Use the new
transcodeWithPreferredMIMETypehelper method here.
(-[WKContentView doAfterComputingImageAnalysisResultsForMarkup:]):
Remove the TIFF transcoding workaround from this method (see associated changes in Radar for more information).
(-[WKContentView actionSheetAssistant:copyCroppedImage:sourceMIMEType:]):
Handle the new action by calling into VisionKit to adjust the source image as needed, and then transcode the
resulting CGImageRef back to a format that matches the source image; finally, write this transcoded
representation to the general pasteboard.
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
Pass
imageMIMETypefrom position information into the activated element info initializer in several places.
(WebKit::transcode): Deleted.
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::imagePositionInformation):
(WebKit::elementPositionInformation):
Populate
imageMIMETypein position information.
Source/WTF:
Add a compile-time flag to guard availability of the UniformTypeIdentifiers framework. See WebKit/ChangeLog for
more information.
- wtf/PlatformHave.h:
- 4:42 PM Changeset in webkit [289680] by
-
- 3 edits in trunk/Source/WebKit
[GPU Process] [CG] Add an ArgumentCoder for CFCharacterSetRef
https://bugs.webkit.org/show_bug.cgi?id=236507
Reviewed by Sam Weinig.
CFCharacterSetRef is used for encoding and decoding the system fonts.
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef):
(IPC::ArgumentCoder<CFTypeRef>::encode):
(IPC::ArgumentCoder<RetainPtr<CFTypeRef>>::decode):
(IPC::ArgumentCoder<CFCharacterSetRef>::encode):
(IPC::ArgumentCoder<RetainPtr<CFCharacterSetRef>>::decode):
- Shared/cf/ArgumentCodersCF.h:
- 3:54 PM Changeset in webkit [289679] by
-
- 1 copy in tags/Safari-613.1.17.0.1
Tag Safari-613.1.17.0.1.
- 3:53 PM Changeset in webkit [289678] by
-
- 1 copy in tags/Safari-613.1.17.1.1
Tag Safari-613.1.17.1.1.
- 3:35 PM Changeset in webkit [289677] by
-
- 2 edits in trunk/LayoutTests
Marking expectations for compositing/iframes/border-radius-composited-frame.html as it is failing on EWS
rdar://80333071
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:26 PM Changeset in webkit [289676] by
-
- 4 edits in trunk/Tools
[EWS] Rebase PRs on tip of branch
https://bugs.webkit.org/show_bug.cgi?id=236389
<rdar://problem/88705147>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/master.cfg: Add github.base.ref to properties.
- Tools/CISupport/ews-build/steps.py:
(CheckOutSource.run): Set branch from github properties, if available.
(ShowIdentifier.start): Use 'got_revision' instead of github properties.
(CheckOutPullRequest.run): Rebase PRs if we have enough information to. To support
rebasing, we need to handle conflicts in changelogs.
(RevertPullRequestChanges.run): Revert to whatever revision we rebased on.
(Trigger.propertiesToPassToTriggers): Pass github.base.ref to triggered build.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/247164@main
- 3:23 PM Changeset in webkit [289675] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] fast/text/otsvg-canvas.html failing constantly
https://bugs.webkit.org/show_bug.cgi?id=236530
Unreviewed test gardening
- platform/mac-wk1/TestExpectations:
- 3:10 PM Changeset in webkit [289674] by
-
- 2 edits in trunk/LayoutTests
update expectations for webrtc/h264-baseline.html and webrtc/h264-high.html
webkit.org/b/223043
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:03 PM Changeset in webkit [289673] by
-
- 6 edits in trunk/Source
Enable grammar checking on Mac Catalyst.
https://bugs.webkit.org/show_bug.cgi?id=236479
Reviewed by Devin Rousso.
Source/WebCore:
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
- platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::grammarColor):
(WebCore::colorForMarkerLineStyle):
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/TextCheckerIOS.mm:
(WebKit::mutableState):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::checkTextOfParagraph):
- 2:57 PM Changeset in webkit [289672] by
-
- 24 edits2 adds in trunk
Fix MIME type check for classic worker script fetches
https://bugs.webkit.org/show_bug.cgi?id=236411
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/workers/Worker_script_mimetype-expected.txt:
- web-platform-tests/workers/importscripts_mime.any.sharedworker-expected.txt:
- web-platform-tests/workers/importscripts_mime.any.worker-expected.txt:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/workers/constructors/SharedWorker/Infinity.headers: Added.
- web-platform-tests/workers/constructors/SharedWorker/NaN.headers: Added.
Merge upstream fix from https://github.com/web-platform-tests/wpt/pull/32782.
Source/WebCore:
Fix MIME type check for classic worker script fetches and classic worker script imports, so that we are
now aligned with the specification:
- https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script (Step 5)
- https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-imported-script (Step 5)
This was causing us to fail some Web Platform Tests.
No new tests, rebaselined existing tests.
- bindings/js/WorkerModuleScriptLoader.cpp:
(WebCore::WorkerModuleScriptLoader::load):
- loader/FetchOptions.h:
(WebCore::isScriptLikeDestination):
- workers/Worker.cpp:
(WebCore::Worker::create):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::constructJavaScriptMIMETypeError):
(WebCore::WorkerScriptLoader::validateWorkerResponse):
(WebCore::WorkerScriptLoader::didReceiveResponse):
- workers/WorkerScriptLoader.h:
- workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
- workers/shared/SharedWorkerScriptLoader.cpp:
(WebCore::SharedWorkerScriptLoader::load):
Source/WebKit:
- NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:
(WebKit::ServiceWorkerSoftUpdateLoader::processResponse):
LayoutTests:
Fix existing layout tests to make sure that worker scripts are served with a JavaScript mime type.
- http/tests/resourceLoadStatistics/resources/script-revealing-cookies.py:
- http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-allowed.py:
- http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-blocked.py:
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-allowed.py:
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-allowed.py:
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-blocked.py:
- http/tests/security/contentSecurityPolicy/resources/worker.py:
- http/tests/workers/resources/subworker-encoded.py:
- 2:46 PM Changeset in webkit [289671] by
-
- 4 edits in trunk
[CMake] Check for MAP_ALIGNED support
https://bugs.webkit.org/show_bug.cgi?id=236522
Reviewed by Keith Miller.
.:
Add a symbol check for MAP_ALIGNED in the CMake.
- Source/cmake/OptionsCommon.cmake:
Source/WTF:
Use the HAVE(MAP_ALIGNED) check in tryReserveUncommittedAligned. Mark unused parameters in
the function. Also define MAP_NORESERVE if its undefined which seems to be the case in
FreeBSD.
- wtf/posix/OSAllocatorPOSIX.cpp:
(WTF::OSAllocator::tryReserveUncommittedAligned):
- 1:48 PM Changeset in webkit [289670] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Sources: double clicking a breakpoint icon should show the edit popover
https://bugs.webkit.org/show_bug.cgi?id=236524
Reviewed by Patrick Angle.
This is a more convenient way to access(/discover) the breakpoint's configuration details.
- UserInterface/Views/BreakpointTreeElement.js:
(WI.BreakpointTreeElement):
(WI.BreakpointTreeElement.prototype._handleStatusImageElementDoubleClicked): Added.
- UserInterface/Views/BreakpointPopover.js:
(WI.BreakpointPopover.show): Added.
(WI.BreakpointPopover.appendContextMenuItems):
Add a convenience method to create aWI.BreakpointPopover(or subclass) for the given
breakpoint andshowit over the given target element.
- 1:46 PM Changeset in webkit [289669] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: click to re-enable breakpoint clears automatic continue
https://bugs.webkit.org/show_bug.cgi?id=236465
Reviewed by Patrick Angle.
This is not very convenient for developers as it means that they have to click more than
once when re-enabling an auto-continue breakpoint (i.e. once to enable it (which currently
disables auto-continue), and once to re-enable auto-continue). Separating these behaviors is
preferable because it's unlikely that a developer would want to disable auto-continue when
re-enabling a breakpoint if they've taken the time to previously configure auto-continue.
- UserInterface/Views/BreakpointTreeElement.js:
(WI.BreakpointTreeElement.prototype.onenter):
(WI.BreakpointTreeElement.prototype.onspace):
(WI.BreakpointTreeElement.prototype._statusImageElementClicked):
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):
ReplacecycleToNextNodewithdisabled = !disabled.
- UserInterface/Models/Breakpoint.js:
(WI.Breakpoint.prototype.cycleToNextMode): Deleted.
Remove this method now that it's no longer used.
- 1:43 PM Changeset in webkit [289668] by
-
- 3 edits in trunk/LayoutTests
[model] rewrite http/tests/model/model-document.html using testharness.js
https://bugs.webkit.org/show_bug.cgi?id=236494
Reviewed by Dean Jackson.
- http/tests/model/model-document-expected.txt:
- http/tests/model/model-document.html:
- 1:39 PM Changeset in webkit [289667] by
-
- 2 edits in trunk/LayoutTests
css/css-writing-modes/direction-propagation-body-contain-root.html asserts
https://bugs.webkit.org/show_bug.cgi?id=234763
<rdar://problem/87243336>
Unreviewed gardening.
- TestExpectations: it looks to have progressed.
- 1:16 PM WebKitGTK/2.34.x edited by
- (diff)
- 1:12 PM Changeset in webkit [289666] by
-
- 3 edits2 adds in trunk
[model] standalone model documents should be interactive
https://bugs.webkit.org/show_bug.cgi?id=236493
Reviewed by Dean Jackson.
Source/WebCore:
We made <model> elements not be interactive by default in bug 227621,
so we need to opt into interactivity for standalone <model> documents.
All this requires is setting the "interactive" attribute, which we set
instead of the "controls" attribute which does not exist for <model>.
Test: http/tests/model/model-document-interactive.html
- html/ModelDocument.cpp:
(WebCore::ModelDocumentParser::createDocumentStructure):
LayoutTests:
Add a test that checks that the <model> element created for standalone
documents has the "interactive" attribute.
- http/tests/model/model-document-interactive-expected.txt: Added.
- http/tests/model/model-document-interactive.html: Added.
- 1:09 PM Changeset in webkit [289665] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix the Apple TV build
Don't try to import
AVKitSPI.hon Apple TV.
- UIProcess/ios/WKContentViewInteraction.mm:
- 1:00 PM Changeset in webkit [289664] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Cocoa2d-HTLM5 game apepars to use wrong vertex buffer data
https://bugs.webkit.org/show_bug.cgi?id=236427
<rdar://problem/87136345>
Reviewed by Kimmo Kinnunen.
Render encoder appears to carry stale state when a vertex array's element
buffer is updated, but no other parts of the buffer are updated. Reassign
vertex buffer bindings in this case, which clears up corruption
(Squished rendering elements, incorrect UV's)
- src/libANGLE/renderer/metal/VertexArrayMtl.h:
- src/libANGLE/renderer/metal/VertexArrayMtl.mm:
(rx::VertexArrayMtl::syncState):
(rx::VertexArrayMtl::setupDraw):
- 12:35 PM Changeset in webkit [289663] by
-
- 4 edits in branches/safari-613.1.17.1-branch/Source/WebCore
Cherry-pick r289493. rdar://problem/88321921
Register strings in CSSTokenizer created from preprocessing
https://bugs.webkit.org/show_bug.cgi?id=236309
Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2022-02-09
Reviewed by Michael Saboff.
Register strings in CSSTokenizer created from preprocessing. This will align with
what is currently done for strings with escapes in CSSTokenizer::consumeName().
- css/parser/CSSTokenizer.cpp: (WebCore::CSSTokenizer::preprocessString): (WebCore::CSSTokenizer::tryCreate): (WebCore::CSSTokenizer::CSSTokenizer): (WebCore::preprocessString): Deleted.
- css/parser/CSSTokenizer.h:
- css/parser/CSSTokenizerInputStream.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [289662] by
-
- 4 edits in branches/safari-613.1.17.0-branch/Source/WebCore
Cherry-pick r289493. rdar://problem/88321921
Register strings in CSSTokenizer created from preprocessing
https://bugs.webkit.org/show_bug.cgi?id=236309
Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2022-02-09
Reviewed by Michael Saboff.
Register strings in CSSTokenizer created from preprocessing. This will align with
what is currently done for strings with escapes in CSSTokenizer::consumeName().
- css/parser/CSSTokenizer.cpp: (WebCore::CSSTokenizer::preprocessString): (WebCore::CSSTokenizer::tryCreate): (WebCore::CSSTokenizer::CSSTokenizer): (WebCore::preprocessString): Deleted.
- css/parser/CSSTokenizer.h:
- css/parser/CSSTokenizerInputStream.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:31 PM Changeset in webkit [289661] by
-
- 14 edits2 adds in branches/safari-613.1.17.1-branch
Cherry-pick r289462. rdar://problem/88580935
Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject
https://bugs.webkit.org/show_bug.cgi?id=236318
<rdar://88580935>
Reviewed by Mark Lam.
Source/WebCore:
This patch makes it so we might not accidentally return the empty value to
JavaScript code from JSValueInWrappedObject. Previously, JSValueInWrappedObject
had an "operator JSValue()" method. This patch removes that, adds a new
conversion method for converting between JSValueInWrappedObject and JSValue,
and makes JSValueInWrappedObject return undefined inside this method
when it used to return the empty value. This fixes a crash where we'd return
the empty value to JS JIT code, and crash dereferencing a nullptr. It's never
valid for a JS function call (or getter, etc) to return the empty value.
Test: fast/dom/AbortSignal-reason-crash-2.html
- Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::getChannelData):
- Modules/webaudio/AudioWorkletProcessor.cpp: (WebCore::toJSArray): (WebCore::toJSObject): (WebCore::AudioWorkletProcessor::buildJSArguments):
- bindings/js/JSCustomEventCustom.cpp: (WebCore::JSCustomEvent::detail const):
- bindings/js/JSDOMConvertAny.h: (WebCore::JSConverter<IDLAny>::convert):
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::data const):
- bindings/js/JSPaymentMethodChangeEventCustom.cpp: (WebCore::JSPaymentMethodChangeEvent::methodDetails const):
- bindings/js/JSPopStateEventCustom.cpp: (WebCore::JSPopStateEvent::state const):
- bindings/js/JSValueInWrappedObject.h: (WebCore::JSValueInWrappedObject::getValue const): (WebCore::JSValueInWrappedObject::operator bool const): (WebCore::cachedPropertyValue): (WebCore::JSValueInWrappedObject::operator JSC::JSValue const): Deleted.
- dom/AbortSignal.cpp: (WebCore::AbortSignal::signalFollow): (WebCore::AbortSignal::throwIfAborted):
- dom/ErrorEvent.cpp: (WebCore::ErrorEvent::error): (WebCore::ErrorEvent::trySerializeError):
- dom/PopStateEvent.cpp: (WebCore::PopStateEvent::trySerializeState):
- page/History.cpp: (WebCore::History::cachedState):
LayoutTests:
- fast/dom/AbortSignal-reason-crash-2-expected.txt: Added.
- fast/dom/AbortSignal-reason-crash-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:31 PM Changeset in webkit [289660] by
-
- 14 edits2 adds in branches/safari-613.1.17.0-branch
Cherry-pick r289462. rdar://problem/88580935
Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject
https://bugs.webkit.org/show_bug.cgi?id=236318
<rdar://88580935>
Reviewed by Mark Lam.
Source/WebCore:
This patch makes it so we might not accidentally return the empty value to
JavaScript code from JSValueInWrappedObject. Previously, JSValueInWrappedObject
had an "operator JSValue()" method. This patch removes that, adds a new
conversion method for converting between JSValueInWrappedObject and JSValue,
and makes JSValueInWrappedObject return undefined inside this method
when it used to return the empty value. This fixes a crash where we'd return
the empty value to JS JIT code, and crash dereferencing a nullptr. It's never
valid for a JS function call (or getter, etc) to return the empty value.
Test: fast/dom/AbortSignal-reason-crash-2.html
- Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::getChannelData):
- Modules/webaudio/AudioWorkletProcessor.cpp: (WebCore::toJSArray): (WebCore::toJSObject): (WebCore::AudioWorkletProcessor::buildJSArguments):
- bindings/js/JSCustomEventCustom.cpp: (WebCore::JSCustomEvent::detail const):
- bindings/js/JSDOMConvertAny.h: (WebCore::JSConverter<IDLAny>::convert):
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::data const):
- bindings/js/JSPaymentMethodChangeEventCustom.cpp: (WebCore::JSPaymentMethodChangeEvent::methodDetails const):
- bindings/js/JSPopStateEventCustom.cpp: (WebCore::JSPopStateEvent::state const):
- bindings/js/JSValueInWrappedObject.h: (WebCore::JSValueInWrappedObject::getValue const): (WebCore::JSValueInWrappedObject::operator bool const): (WebCore::cachedPropertyValue): (WebCore::JSValueInWrappedObject::operator JSC::JSValue const): Deleted.
- dom/AbortSignal.cpp: (WebCore::AbortSignal::signalFollow): (WebCore::AbortSignal::throwIfAborted):
- dom/ErrorEvent.cpp: (WebCore::ErrorEvent::error): (WebCore::ErrorEvent::trySerializeError):
- dom/PopStateEvent.cpp: (WebCore::PopStateEvent::trySerializeState):
- page/History.cpp: (WebCore::History::cachedState):
LayoutTests:
- fast/dom/AbortSignal-reason-crash-2-expected.txt: Added.
- fast/dom/AbortSignal-reason-crash-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:25 PM Changeset in webkit [289659] by
-
- 6 edits in trunk/Tools
[git-webkit] Handle local commit on production branch
https://bugs.webkit.org/show_bug.cgi?id=235974
<rdar://problem/88346615>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Handle moving
branches to remote reference.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): Move local branch ref to remote reference.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/247151@main
- 12:19 PM Changeset in webkit [289658] by
-
- 5 edits in trunk/Source
Regression(r287684) Microsoft teams meeting URLs fail to open the app
https://bugs.webkit.org/show_bug.cgi?id=236516
<rdar://88678598>
Reviewed by Geoffrey Garen.
Add a quirk for Microsoft teams.
Source/WebCore:
- page/Quirks.cpp:
(WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):
- page/Quirks.h:
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- 12:10 PM Changeset in webkit [289657] by
-
- 3 edits in branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE
Apply patch. rdar://problem/87136345
- 12:07 PM Changeset in webkit [289656] by
-
- 2 edits in trunk/Tools
Git commit message hook should allow source = 'template' case
https://bugs.webkit.org/show_bug.cgi?id=236504
<rdar://problem/88787806>
Reviewed by Tim Horton.
- Scripts/hooks/prepare-commit-msg: 'template' should be handled like 'commit'
- 12:05 PM Changeset in webkit [289655] by
-
- 6 edits2 adds in branches/safari-613.1.17.1-branch
Cherry-pick r289526. rdar://problem/87061239
[:has() pseudo-class] Nullptr crash with non-function :has
https://bugs.webkit.org/show_bug.cgi?id=236431
rdar://87061239
Reviewed by Cameron McCormack.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/parsing/parse-has-expected.txt:
- web-platform-tests/css/selectors/parsing/parse-has.html:
Source/WebCore:
Test: fast/selectors/malformed-has.html
- css/parser/CSSSelectorParser.cpp: (WebCore::isOnlyPseudoClassFunction):
:has() is legal, plain :has is not.
LayoutTests:
- fast/selectors/malformed-has-expected.txt: Added.
- fast/selectors/malformed-has.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:04 PM Changeset in webkit [289654] by
-
- 3 edits2 adds in branches/safari-613.1.17.1-branch
Cherry-pick r289443. rdar://problem/88593617
REGRESSION (15.4): Angular virtual scrollers no longer work (because of contain:strict)
https://bugs.webkit.org/show_bug.cgi?id=236260
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-08
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-paint-049-expected.txt: Added.
- web-platform-tests/css/css-contain/contain-paint-049.html: Added.
Source/WebCore:
Paint containment did not allow collecting scrollable overflow, breaking scrolling
of the container contents, this patch fixes that.
Test: imported/w3c/web-platform-tests/css/css-contain/contain-paint-049.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:04 PM Changeset in webkit [289653] by
-
- 2 edits in branches/safari-613.1.17.1-branch/Source/WebKit
Cherry-pick r289380. rdar://problem/86904276
Reduce allocations and increase thread safety of constructedPath
https://bugs.webkit.org/show_bug.cgi?id=236286
<rdar://86904276>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-08
Reviewed by Chris Dumez.
- UIProcess/API/APIContentRuleListStore.cpp: (API::constructedPathPrefix): (API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:04 PM Changeset in webkit [289652] by
-
- 6 edits in branches/safari-613.1.17.1-branch
Cherry-pick r289377. rdar://problem/88178304
Return 'none' for the computed style of mask when there are no mask images
https://bugs.webkit.org/show_bug.cgi?id=236265
<rdar://88178304>
Patch by Matt Woodrow <Matt Woodrow> on 2022-02-08
Reviewed by Dean Jackson.
Source/WebCore:
Rather than returning all the longhand properties, return 'none' if there are no
mask images. This no longer matches the behaviour of the 'background' property, but
better matches what other UAs do.
Ideally we'd return the smallest possible canonical representation of the non-initial
property values, but this is a much simpler change to fix a compat regression.
Test: fast/masking/parsing-mask.html
Updates expected results to match new behavior.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::getLayerCount): (WebCore::ComputedStyleExtractor::getFillLayerPropertyShorthandValue): (WebCore::ComputedStyleExtractor::getBackgroundShorthandValue): (WebCore::ComputedStyleExtractor::getMaskShorthandValue):
- css/CSSComputedStyleDeclaration.h:
LayoutTests:
- fast/masking/parsing-mask-expected.txt:
- fast/masking/parsing-mask.html:
Updated expected results to expect 'none' for all cases where there isn't an actual mask
image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [289651] by
-
- 3 edits in branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE
Apply patch. rdar://problem/87136345
- 11:58 AM Changeset in webkit [289650] by
-
- 6 edits2 adds in branches/safari-613.1.17.0-branch
Cherry-pick r289526. rdar://problem/87061239
[:has() pseudo-class] Nullptr crash with non-function :has
https://bugs.webkit.org/show_bug.cgi?id=236431
rdar://87061239
Reviewed by Cameron McCormack.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/parsing/parse-has-expected.txt:
- web-platform-tests/css/selectors/parsing/parse-has.html:
Source/WebCore:
Test: fast/selectors/malformed-has.html
- css/parser/CSSSelectorParser.cpp: (WebCore::isOnlyPseudoClassFunction):
:has() is legal, plain :has is not.
LayoutTests:
- fast/selectors/malformed-has-expected.txt: Added.
- fast/selectors/malformed-has.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [289649] by
-
- 4 edits in branches/safari-613.1.17.0-branch
Cherry-pick r289502. rdar://problem/88528286
WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
https://bugs.webkit.org/show_bug.cgi?id=236401
rdar://88528286
Reviewed by Brent Fulgham.
Source/WebCore:
https://webkit.org/b/203302 added support for Range requests to AVAssetResourceLoadingDataRequest,
but it incorrectly used '*' instead of for "last-byte-pos:" for a request to the end of the resource.
API test URLSchemeHandler.Ranges was updated.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: (WebCore::WebCoreAVFResourceLoader::startLoading):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [289648] by
-
- 3 edits2 adds in branches/safari-613.1.17.0-branch
Cherry-pick r289443. rdar://problem/88593617
REGRESSION (15.4): Angular virtual scrollers no longer work (because of contain:strict)
https://bugs.webkit.org/show_bug.cgi?id=236260
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-08
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-paint-049-expected.txt: Added.
- web-platform-tests/css/css-contain/contain-paint-049.html: Added.
Source/WebCore:
Paint containment did not allow collecting scrollable overflow, breaking scrolling
of the container contents, this patch fixes that.
Test: imported/w3c/web-platform-tests/css/css-contain/contain-paint-049.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [289647] by
-
- 2 edits in branches/safari-613.1.17.0-branch/Source/WebKit
Cherry-pick r289380. rdar://problem/86904276
Reduce allocations and increase thread safety of constructedPath
https://bugs.webkit.org/show_bug.cgi?id=236286
<rdar://86904276>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-08
Reviewed by Chris Dumez.
- UIProcess/API/APIContentRuleListStore.cpp: (API::constructedPathPrefix): (API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:58 AM Changeset in webkit [289646] by
-
- 6 edits in branches/safari-613.1.17.0-branch
Cherry-pick r289377. rdar://problem/88178304
Return 'none' for the computed style of mask when there are no mask images
https://bugs.webkit.org/show_bug.cgi?id=236265
<rdar://88178304>
Patch by Matt Woodrow <Matt Woodrow> on 2022-02-08
Reviewed by Dean Jackson.
Source/WebCore:
Rather than returning all the longhand properties, return 'none' if there are no
mask images. This no longer matches the behaviour of the 'background' property, but
better matches what other UAs do.
Ideally we'd return the smallest possible canonical representation of the non-initial
property values, but this is a much simpler change to fix a compat regression.
Test: fast/masking/parsing-mask.html
Updates expected results to match new behavior.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::getLayerCount): (WebCore::ComputedStyleExtractor::getFillLayerPropertyShorthandValue): (WebCore::ComputedStyleExtractor::getBackgroundShorthandValue): (WebCore::ComputedStyleExtractor::getMaskShorthandValue):
- css/CSSComputedStyleDeclaration.h:
LayoutTests:
- fast/masking/parsing-mask-expected.txt:
- fast/masking/parsing-mask.html:
Updated expected results to expect 'none' for all cases where there isn't an actual mask
image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:57 AM Changeset in webkit [289645] by
-
- 9 edits in branches/safari-613.1.17.1-branch/Source
Versioning.
WebKit-7613.1.17.1.1
- 11:55 AM Changeset in webkit [289644] by
-
- 3 edits1 delete in trunk/Source/WTF
Fix headers in install builds and add untracked headers
https://bugs.webkit.org/show_bug.cgi?id=235744
Reviewed by Alexey Proskuryakov.
Relands native Xcode build phases for "Copy WTF Headers", again.
Adds a slash prefix, so that PRIVATE_HEADERS_FOLDER_PATH is always an absolute path.
Otherwise, when WTF_INSTALL_PATH_PREFIX is not set, it's relative and incorrectoly copied
into the INSTALL_PATH (/usr/local/lib).
Uses separate path variables for Copy Files phases that create header subdirectories. Unlike
the native "Headers" phase, copying to "/usr/local/include" is not automatically relative to
the SYMROOT or DSTROOT, respective of build action type.
Adds SignedPtr.h to WTF's Headers phase. It was added recently and missed integration in
r289256.
Sets INSTALLHDRS_COPY_PHASE so that nested header directories are copied during installhdrs.
- Configurations/WTF.xcconfig:
- WTF.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [289643] by
-
- 4 edits in trunk/Tools
[git-webkit] Reset target branch when landing fails
https://bugs.webkit.org/show_bug.cgi?id=236110
<rdar://problem/88463164>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.revert_branch): Move branch to specified remote's representation of the branch.
(Land.main): If we fail to land a change after moving a branch's local ref to include that
change, we should return that local ref to what the branch's remote reports.
Canonical link: https://commits.webkit.org/247147@main
- 11:47 AM Changeset in webkit [289642] by
-
- 9 edits2 adds in trunk/Source/WebKit
Introduce a RemoteLayerBackingStoreCollection subclass for GPU Process-based rendering
https://bugs.webkit.org/show_bug.cgi?id=236468
Reviewed by Tim Horton.
Add RemoteLayerWithRemoteRenderingBackingStoreCollection, a subclass of RemoteLayerBackingStoreCollection
which is instantiated by RemoteLayerTreeContext when DOM rendering in GPU process is enabled.
Delegate buffer allocation to this now polymorphic class; RemoteLayerBackingStore no longer
consults shouldUseRemoteRenderingFor().
RemoteLayerWithRemoteRenderingBackingStoreCollection needs a back pointer to RemoteLayerTreeContext
to get to the RemoteRenderingBackendProxy.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::backingStoreCollection const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
(WebKit::RemoteLayerBackingStoreCollection::layerTreeContext const):
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::RemoteLayerBackingStoreCollection):
(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore):
- Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h: Added.
- Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: Added.
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::RemoteLayerWithRemoteRenderingBackingStoreCollection):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::remoteRenderingBackendProxy):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::allocateBufferForBackingStore):
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
(WebKit::RemoteLayerTreeContext::backingStoreCollection):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
- 11:45 AM Changeset in webkit [289641] by
-
- 9 edits in branches/safari-613.1.17.0-branch/Source
Versioning.
WebKit-7613.1.17.0.1
- 11:36 AM Changeset in webkit [289640] by
-
- 2 edits in trunk/Source/WebCore
Keep promise in scope when calling DeferredPromise::reject
https://bugs.webkit.org/show_bug.cgi?id=236454
Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2022-02-11
Reviewed by Youenn Fablet.
Keep promise in scope when calling DeferredPromise::reject, as createDOMException
could go through a path that invokes GC on its owner and the promise.
- bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::reject):
- 11:34 AM Changeset in webkit [289639] by
-
- 2 edits in trunk/Source/WebKit
The GPU process should not check in with Launch Services
https://bugs.webkit.org/show_bug.cgi?id=236457
Reviewed by Geoffrey Garen.
Since the GPU process is not an application in the normal sense, there is no need to call _LSApplicationCheckIn.
The function _CSCheckFixDisable should still be called.
- GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::initializeProcess):
- 11:10 AM Changeset in webkit [289638] by
-
- 2 edits in trunk/Tools
[EWS] Enable WPE and WinCairo queues for PRs
https://bugs.webkit.org/show_bug.cgi?id=236517
<rdar://problem/88823117>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/config.json:
Canonical link: https://commits.webkit.org/247143@main
- 10:24 AM Changeset in webkit [289637] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix: revert r289616
- WebCore.xcodeproj/project.pbxproj:
- 10:12 AM Changeset in webkit [289636] by
-
- 1 copy in tags/Safari-614.1.2.1
Tag Safari-614.1.2.1.
- 10:10 AM Changeset in webkit [289635] by
-
- 1 copy in branches/safari-613.1.17.3-branch
New branch.
- 10:10 AM Changeset in webkit [289634] by
-
- 1 copy in branches/safari-613.1.17.2-branch
New branch.
- 10:10 AM Changeset in webkit [289633] by
-
- 1 copy in branches/safari-613.1.17.1-branch
New branch.
- 10:10 AM Changeset in webkit [289632] by
-
- 1 copy in branches/safari-613.1.17.0-branch
New branch.
- 9:55 AM Changeset in webkit [289631] by
-
- 5 edits in trunk/LayoutTests
Unreviewed gardening.
Update fuzzy data based on EWS results to support b231828.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-1.html:
LayoutTests:
- css3/color-filters/color-filter-text-decoration-shadow.html:
- fast/text/system-font-fallback.html:
- 9:53 AM Changeset in webkit [289630] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed followup: address Youenn's feedback for PDFDocument.
- html/PDFDocument.cpp:
(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocument::createDocumentStructure):
(WebCore::PDFDocument::updateDuringParsing):
(WebCore::PDFDocument::finishedParsing):
(WebCore::PDFDocument::injectContentScript):
- html/PDFDocument.h:
- 9:47 AM Changeset in webkit [289629] by
-
- 5 edits in trunk/LayoutTests
Unreviewed gardening.
Update fuzzy data based on EWS results to support b231828.
- css3/blending/background-blend-mode-body-transparent-color-and-image.html:
- css3/calc/border-radius.html:
- svg/gradients/spreadMethodDiagonal3.svg:
- svg/gradients/spreadMethodDiagonal4.svg:
- 9:40 AM Changeset in webkit [289628] by
-
- 75 edits3 copies2 adds in trunk
Support remote video frames in WebRTC video pipeline
https://bugs.webkit.org/show_bug.cgi?id=236356
Reviewed by Kimmo Kinnunen.
Source/ThirdParty/libwebrtc:
Introduce a way for ObjCFrameBuffer to not directly own a CVPixelBufferRef but a pointer
that can be used to get a CVPixelBufferRef. This is used to allow remote frames to be sent over to libwebrtc.
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Source/webrtc/sdk/WebKit/WebKitDecoder.h:
- Source/webrtc/sdk/WebKit/WebKitDecoder.mm:
- Source/webrtc/sdk/WebKit/WebKitUtilities.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
- Source/webrtc/sdk/objc/native/src/objc_frame_buffer.h:
- Source/webrtc/sdk/objc/native/src/objc_frame_buffer.mm:
Source/WebCore:
Allow to receive/send remote frames as webrtc VideoFrame buffers.
We are not yet optimizing remove video frame sending as this requires moving remote video frame to WebCore.
This will be done as a follow-up.
Covered by existing tests and updated tests to enable the experimental flag.
- platform/MediaSample.h:
- platform/VideoFrame.cpp:
- platform/VideoFrame.h:
- platform/graphics/RemoteVideoSample.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
- platform/mediastream/RealtimeVideoSource.cpp:
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
Source/WebKit:
Allow receiving remote samples from camera or HW decoders.
In that case, we create remote video frames and allow piping them to our existing pipeline.
We update MediaRecorder and LibWebRTC HW encoders to deal with this.
Since we have a code path that requires getting access to the raw pixels, we introduce RemoteVideoFrameObjectHeapProxy
to allow getting that data through shared memory asynchronously.
RemoteVideoFrameProxy will then use a semaphore to block on the async IPC result.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
- Shared/ThreadSafeObjectHeap.h:
- Sources.txt:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.cpp:
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
- WebProcess/GPU/media/RemoteVideoFrameIdentifier.h:
- WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
- WebProcess/GPU/media/RemoteVideoFrameProxy.h:
- WebProcess/GPU/media/RemoteVideoFrameProxyIdentifier.h: Added.
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h: Added.
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp: Added.
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h: Added.
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.messages.in: Added.
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
- WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.messages.in:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
- WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
- WebProcess/cocoa/UserMediaCaptureManager.h:
Source/WTF:
Introduce an experimental flag to make use of remote frames in WebRTC code paths.
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
Allow switching on the new remote video frame flag.
- WebKitTestRunner/TestOptions.cpp:
LayoutTests:
Enabling remote video frames for below tests.
- webrtc/video-mute-vp8.html:
- webrtc/video-mute.html:
- webrtc/video-rotation.html:
- webrtc/video.html:
- 9:30 AM Changeset in webkit [289627] by
-
- 5 edits1 copy5 adds in trunk/Source/WebCore
Inject custom styles into PDF.js to make it look like PDFKit
https://bugs.webkit.org/show_bug.cgi?id=236510
Reviewed by Tim Horton.
This introduces a pdfjs-extras directory that is copied in the pdfjs/extras resource subdirectory at build-time.
In that directory contains a content-script.js file that is executed when the PDFJS iframe loads. Currently, that
content script only injects the PDFKit styling, but it may be used for other types of interaction in the future
(e.g. loading a blob, hooking with find-in-page messages, etc.).
In PDFDocument, we add m_iframe, a ref to the PDFDocument iframe, that we can re-use when the iframe loads,
to inject the content script.
PDFDocumentEventListener handles the iframe load event listener.
m_viewerRendered which was set once the <iframe> was added to the document, is now no longer needed, since we can
check for m_iframe directly.
- Modules/pdfjs-extras/arrow.down.circle@2x.png: Added.
- Modules/pdfjs-extras/content-script.js:
(const.PDFJSContentScript.injectStyle):
(const.PDFJSContentScript.init):
- Modules/pdfjs-extras/minus.magnifyingglass@2x.png: Added.
- Modules/pdfjs-extras/plus.magnifyingglass@2x.png: Added.
- Modules/pdfjs-extras/style-cocoa.css: Added.
(body):
(@keyframes fade-out):
(to):
(#loadingBar):
(#toolbarContainer):
(#toolbarViewer):
(#toolbarViewer:hover):
(#toolbarViewerMiddle,):
(#toolbarViewerLeft,):
(#toolbarViewer .toolbarButton):
(#toolbarViewer .toolbarButton:active):
(#toolbarViewer .toolbarButton::before):
(#zoomOut):
(#zoomIn):
(#zoomOut + .splitToolbarButtonSeparator):
(#download):
(#viewerContainer):
(#findbar):
(#findbar:not(.hidden) ~ #viewerContainer):
(#findbar::before,):
(#findbarOptionsTwoContainer):
(#findResultsCount,):
(#findbar .splitToolbarButton > .toolbarButton::before):
(#findInput:focus):
(#findInput[data-status="notFound"]):
- WebCore.xcodeproj/project.pbxproj:
- dom/EventListener.h:
- html/PDFDocument.cpp:
(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocumentEventListener::operator== const):
(WebCore::PDFDocument::PDFDocument):
(WebCore::PDFDocument::createDocumentStructure):
(WebCore::PDFDocument::updateDuringParsing):
(WebCore::PDFDocument::finishedParsing):
(WebCore::PDFDocument::injectContentScript):
(WebCore::m_viewerRendered): Deleted.
- html/PDFDocument.h:
- 9:24 AM Changeset in webkit [289626] by
-
- 9 edits in branches/safari-614.1.2-branch/Source
Versioning.
WebKit-7614.1.2.1
- 9:23 AM Changeset in webkit [289625] by
-
- 3 edits in trunk/Tools
[EWS] Support PRs in UploadTestResults and ExtractTestResults
https://bugs.webkit.org/show_bug.cgi?id=236446
<rdar://problem/88756592>
Reviewed by Aakash Jain.
- CISupport/ews-build/steps.py:
(ConfigureBuild.add_pr_details): Shorten hash to 8 characters.
(UploadTestResults.init): Use change_id instead of patch_id.
(ExtractTestResults.init): Ditto.
- CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/247136@main
- 9:11 AM Changeset in webkit [289624] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, non-unified build fixes in WKPaymentAuthorizationDelegate
Include several missing headers.
- Platform/cocoa/WKPaymentAuthorizationDelegate.h:
- Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
- 9:01 AM Changeset in webkit [289623] by
-
- 17 edits in trunk/Source
[iOS] Add support for a "markup image" item in the callout bar when selecting a single image
https://bugs.webkit.org/show_bug.cgi?id=236415
rdar://88714333
Reviewed by Aditya Keerthi.
Source/WebCore:
Export a couple of functions; see WebKit/ChangeLog for more details.
- platform/graphics/Image.h:
- platform/graphics/cg/UTIRegistry.h:
Source/WebKit:
This patch introduces support for a new "Markup Image" callout menu item, which is only shown when the user has
selected exactly one image. If the image is suitable for "Markup Image" (that is, the relevant VisionKit API
returns a non-null image), then we show a new item in the callout bar which, when activated, replaces the
current selection with the image returned by the aforementioned VisionKit API.
See below for more details.
- Platform/cocoa/TextRecognitionUtilities.h:
- Platform/cocoa/TextRecognitionUtilities.mm:
(WebKit::isImageAnalysisMarkupSystemFeatureEnabled):
Add a new helper method to return whether or not the corresponding system feature flag is enabled.
- Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
Add an optional
ElementContextthat's populated only if the user's selection spans a single HTMLImageElement.
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView didMoveToWindow]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestImageBitmap):
Add a new async IPC message that allows the UI process to grab a ShareableBitmap handle (along with the MIME
type of the source image) given an ElementContext that identifies an image element.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.h:
Cache the last result from requesting "Image Markup" data from VisionKit in
_imageAnalysisMarkupResults, and
use this information when invoking the new selector,-performImageAnalysisMarkup:.
- UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::transcode):
Add a helper method that takes a CGImageRef, transcodes it to the given uniform type identifier, and finally
returns a blob of image data. Used by the two new call sites for Image Markup below, as well as an existing call
site for Visual Look Up in-provideDataForItem:
(-[WKContentView targetForAction:withSender:]):
Add a check for the new Image Markup action selector.
(-[WKContentView requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]):
Use this existing UIKit delegate hook to defer callout bar presentation only in the case where a single image
element is selected, such that we only show the callout bar in this scenario once VisionKit has determined
whether or not the "Image Markup" action is suitable for the data of the selected image.
The initial purpose of this delegate hook was to allow WebKit to defer callout bar presentation for a short,
hard-coded delay to wait for the web page to layout out or add clickable items that might underlap the callout
bar; as such, we still perform this logic with a hard-coded delay of 250 ms (including whatever time was taken
during image analysis).
(-[WKContentView updateImageAnalysisMarkupMenuItems:]):
Append the new menu item only if the system feature flag is enabled, and we've selected an editable image. Note
that this intentionally does not consult_imageAnalysisMarkupResultsto ensure that the state of additional
menu items in the shared menu controller is consistent between Markup Image and Quick Note, and updated in the
same lifecycle as editor state updates.
(-[WKContentView canPerformImageAnalysisMarkup]):
This is consulted when we're actually about to show the callout bar action for "Image Markup" (importantly,
after callout bar presentation deferral), and depends on the state of_imageAnalysisMarkupResults.
(-[WKContentView performImageAnalysisMarkup:]):
Add logic to handle the new action by calling into WebPageProxy to (basically) paste the modified image data
after transcoding it to match the image element's original source type. After #236406, this codepath is now
available on all Cocoa platforms (as opposed to macOS-only).
(-[WKContentView doAfterComputingImageAnalysisResultsForMarkup:]):
Use the new
requestImageBitmapIPC message to grab a bitmap for the currently selected image, call out to
VisionKit to perform image analysis, and then cache the resulting image. After all of this is done, we proceed
with showing the callout bar.
In a followup, we should enforce some (reasonable) upper bound on the amount of time by which the callout bar
can be delayed.
(-[WKContentView _selectionChanged]):
(-[WKContentView setUpAdditionalMenuControllerActions]):
Refactor existing logic for supplying additional callout bar menu items, such that we update items as needed for
both Quick Note as well as Image Markup. Note that we need to preserve any existing menu items in the shared
UIMenuController, since the WebKit client (e.g. Mail) may have already supplied custom menu items. This
currently doees not affect Quick Note since the only internal client that enables Quick Note is Safari, which
does not attempt to add any of its own items; however, "Markup Image" needs to be available in Mail on iOS as
well, which does use custom menu items.
(findMenuItemWithAction):
(-[WKContentView updateAppHighlightMenuItems:]):
Make this adjust the given mutable array of UIMenuItems, which are then combined with any markup menu items
when setting custom items on the shared menu controller.
(-[WKContentView provideDataForItem:]):
Adjust this to use the new
transcodehelper function, declared above.
(-[WKContentView _setUpImageAnalysis]):
(-[WKContentView _tearDownImageAnalysis]):
(-[WKContentView setUpAppHighlightMenusIfNeeded]): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestImageBitmap):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const):
Compute and populate the new
selectedEditableImageelement context; to achieve this, we useTextIteratorto
scan for an image element, and bail immediately if we either find anything that is not an image, or find more
than one image.
- 8:08 AM Changeset in webkit [289622] by
-
- 45 edits3 copies7 adds in trunk
Introduce a RemoteMediaSampleProxy to represent captured video frames used in Media Streams and present in GPUP
https://bugs.webkit.org/show_bug.cgi?id=236099
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-11
Reviewed by Youenn Fablet.
Source/WebCore:
Add VideoFrame : public MediaStream, base class for Media Stream video frames.
Currently inherits from MediaSample, but later will remove the MediaSample.
The WebCore::VideoFrame is intended to be used in various entry-points that
currently are currently typed as:
void videoSampleAvailable(MediaSample&, VideoSampleMetadata, ...).
The new class WebKit::RemoteVideoFrameProxy : public VideoFrame can be passed to these APIs.
The API entrypoints are not yet changed in order to partially roll the changes in.
Later on, the entrypoints will be similar to:
void videoSampleAvailable(VideoFrame&, VideoSampleMetadata, ...).
Removes MediaSample::setTrackID as that is not used.
Changes MediaSample::platformSample() to const, so that it can be called from
const context.
No new tests, refactor.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/MediaSample.h:
- platform/VideoFrame.cpp: Added.
(WebCore::VideoFrame::decodeTime const):
(WebCore::VideoFrame::duration const):
(WebCore::VideoFrame::trackID const):
(WebCore::VideoFrame::sizeInBytes const):
(WebCore::VideoFrame::presentationSize const):
(WebCore::VideoFrame::offsetTimestampsBy):
(WebCore::VideoFrame::setTimestamps):
(WebCore::VideoFrame::isDivisable const):
(WebCore::VideoFrame::divide):
(WebCore::VideoFrame::createNonDisplayingCopy const):
(WebCore::VideoFrame::flags const):
(WebCore::VideoFrame::byteRange const):
(WebCore::VideoFrame::dump const):
- platform/VideoFrame.h: Added.
- platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::enqueueSampleBuffer):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateCurrentFrameImage):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
(isType):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::platformSample const):
- platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::platformSample const):
- platform/graphics/gstreamer/MediaSampleGStreamer.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockMediaSample::platformSample const):
Source/WebKit:
Changes after revert:
- For now, create the RemoteVideoFrame in GPUP using synchronous message. This way RemoteVideoFrameProxy does not need to receive messages. It cannot easily do that, as it is referenced in multiple threads and thus we cannot remove the message destination for the instance from GPUProcess instance, as that operation is main thread only. The type cannot be DestructionThread::Main, as we do not (yet) control the base class (MediaSample).
WebContent process:
Add WebKit::RemoteVideoFrameProxy, WebContent process side proxy object that
WebCore::MediaPlayerPrivateMediaStreamAVFObjC can use.
RemoteVideoFrameProxy can be sent to the GPUP and the the SampleBufferDisplayLayer. So
the captured content shows in compositing through video element.
At the moment MediaPlayerPrivateMediaStreamAVFObjC cannot paint RemoteVideoFrameProxy to the
document CSS painted content, Context2D or WebGL canvas.
GPUP:
RemoteVideoFrameObjectHeap is a mapping
RemoteVideoFrameIdentifier -> MediaSample. Currently all objects
map to normal MediaSampleAVFObjC.
Add an example implementation where a remote MediaSample is returned by IPC:
RemoteGraphicsContextGL::paintCompositedResultsToMediaSample().
The GPUP object pointed by RemoteVideoFrameIdentifier is:
- created in RemoteGraphicsContextGL::paintCompositedResultsToMediaSample() in RemoteGraphicsContextGL thread
- consumed in RemoteSampleBufferDisplayLayer::enqueueSample in RemoteSampleBufferDisplayLayerManager thread
- released in RemoteVideoFrameObjectHeap::releaseVideoFrame in GPUP main thread
All of these messages are asynchronous and can arrive to their destination in any order.
For example, request to release the video frame can happen before the message to create the video frame has been
received.
To solve the ordering issue, introduce readers-writers reference counting method via following classes:
- ObjectIdentifierReadReference
- ObjectIdentifierWriteReference
- ObjectIdentifierReferenceTracker
ObjectIdentifier identifies the object.
ObjectIdentifierWriteReference identifies a new version of the content pointed by the identifier.
Pseudocode examples:
WriteReference { identifier = 1, pendingReads = 0, version = 0 } means:
"End the life-time of identifier 1, version 0. Create version = 1"
This is how initial object is assigned to the reference.
WriteReference { identifier = 1, pendingReads = 77, version = 32 } means
"End the life-time of identifier 1, version 32 when all 77 reads have completed. Create version = 33"
ObjectIdentifierReadReference declares a read dependency to a specific version of the content pointed by the identifier.
Pseudocode examples:
ReadReference { identifier = 1, version = 32 } means
"Complete one read of identifier 1, version 32".
Creates, updates and destructions are WriteReferences.
Reads are ReadReferences.
The ObjectIdentifierReferenceTracker creates write and read references in the Proxy -using process (WebContent process).
The added ThreadSafeObjectHeap resolves the read and write references in the real object process (GPUP in this case).
Reads and writes are blocking the requesting thread appropriately:
- Read of unknown version of the identifier blocks until the write creates the version
- Write of new version of the identifier blocks until the reads have retired, or creates parallel, new version of the content in case of copy-on-write schemes.
In this commit objects pointed by RemoteVideoFrameIdentifier are immutable until destroyed, so there is no update or
copy-on-write scheme here.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::videoFrameObjectHeap const):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::RemoteGraphicsContextGL):
(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToMediaSample):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp: Added.
(WebKit::RemoteVideoFrameObjectHeap::create):
(WebKit::RemoteVideoFrameObjectHeap::RemoteVideoFrameObjectHeap):
(WebKit::RemoteVideoFrameObjectHeap::~RemoteVideoFrameObjectHeap):
(WebKit::RemoteVideoFrameObjectHeap::stopListeningForIPC):
(WebKit::RemoteVideoFrameObjectHeap::releaseVideoFrame):
- GPUProcess/media/RemoteVideoFrameObjectHeap.h: Copied from Source/WebKit/Shared/IPCTester.h.
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in: Copied from Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in.
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::create):
(WebKit::RemoteSampleBufferDisplayLayer::RemoteSampleBufferDisplayLayer):
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSample):
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSampleCV):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
- Shared/IPCTester.cpp:
(WebKit::IPCTester::startMessageTesting):
(WebKit::isTestingIPC):
- Shared/IPCTester.h:
(WebKit::isTestingIPC):
- Shared/ObjectIdentifierReferenceTracker.h: Added.
(WebKit::ObjectIdentifierReference::ObjectIdentifierReference):
(WebKit::ObjectIdentifierReference::identifier const):
(WebKit::ObjectIdentifierReference::version const):
(WebKit::ObjectIdentifierReference::operator== const):
(WebKit::ObjectIdentifierReference::isHashTableDeletedValue const):
(WebKit::ObjectIdentifierReference::encode const):
(WebKit::ObjectIdentifierReference::decode):
(WebKit::ObjectIdentifierReadReference::ObjectIdentifierReadReference):
(WebKit::ObjectIdentifierReadReference::identifier const):
(WebKit::ObjectIdentifierReadReference::version const):
(WebKit::ObjectIdentifierReadReference::reference const):
(WebKit::ObjectIdentifierReadReference::encode const):
(WebKit::ObjectIdentifierReadReference::decode):
(WebKit::ObjectIdentifierWriteReference::generateForAdd):
(WebKit::ObjectIdentifierWriteReference::ObjectIdentifierWriteReference):
(WebKit::ObjectIdentifierWriteReference::identifier const):
(WebKit::ObjectIdentifierWriteReference::version const):
(WebKit::ObjectIdentifierWriteReference::pendingReads const):
(WebKit::ObjectIdentifierWriteReference::reference const):
(WebKit::ObjectIdentifierWriteReference::retiredReference const):
(WebKit::ObjectIdentifierWriteReference::encode const):
(WebKit::ObjectIdentifierWriteReference::decode):
(WebKit::ObjectIdentifierReferenceTracker::ObjectIdentifierReferenceTracker):
(WebKit::ObjectIdentifierReferenceTracker::read const):
(WebKit::ObjectIdentifierReferenceTracker::write const):
(WebKit::ObjectIdentifierReferenceTracker::identifier const):
(WebKit::add):
(WebKit::operator<<):
(WTF::DefaultHash<WebKit::ObjectIdentifierReference<T>>::hash):
(WTF::DefaultHash<WebKit::ObjectIdentifierReference<T>>::equal):
- Shared/ThreadSafeObjectHeap.h: Added.
(WebKit::ThreadSafeObjectHeap::ReferenceState::ReferenceState):
(WebKit::HeldType>::retire):
(WebKit::HeldType>::retireRemove):
(WebKit::HeldType>::clear):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::platformSample const):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.h:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToMediaSample):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:
- WebProcess/GPU/media/RemoteVideoFrameIdentifier.h: Copied from Source/WebKit/Shared/IPCTester.h.
- WebProcess/GPU/media/RemoteVideoFrameProxy.cpp: Added.
(WebKit::RemoteVideoFrameProxy::properties):
(WebKit::RemoteVideoFrameProxy::create):
(WebKit::RemoteVideoFrameProxy::releaseUnused):
(WebKit::RemoteVideoFrameProxy::RemoteVideoFrameProxy):
(WebKit::RemoteVideoFrameProxy::~RemoteVideoFrameProxy):
(WebKit::RemoteVideoFrameProxy::identifier const):
(WebKit::RemoteVideoFrameProxy::write const):
(WebKit::RemoteVideoFrameProxy::read const):
(WebKit::RemoteVideoFrameProxy::presentationTime const):
(WebKit::RemoteVideoFrameProxy::platformSample const):
(WebKit::RemoteVideoFrameProxy::videoRotation const):
(WebKit::RemoteVideoFrameProxy::videoMirrored const):
(WebKit::RemoteVideoFrameProxy::videoPixelFormat const):
(WebKit::RemoteVideoFrameProxy::videoFrame const):
(WebKit::RemoteVideoFrameProxy::release):
- WebProcess/GPU/media/RemoteVideoFrameProxy.h: Added.
(WebKit::RemoteVideoFrameProxy::Properties::encode const):
(WebKit::RemoteVideoFrameProxy::Properties::decode):
(isType):
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::~SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::enqueueSample):
(WebKit::SampleBufferDisplayLayer::gpuProcessConnectionDidClose):
(WebKit::SampleBufferDisplayLayer::disconnectGPUProcessConnectionIfNeeded):
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
Tools:
- Scripts/generate-gpup-webgl:
- TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
LayoutTests:
Captured WebGL to another context2d or WebGL not implemented yet, mark few tests as timing out.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 7:53 AM Changeset in webkit [289621] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
Unreviewed, fix build with the latest iOS SDK.
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage isNativeLibraryData:]):
- 7:09 AM WebKitGTK/2.34.x edited by
- (diff)
- 6:53 AM Changeset in webkit [289620] by
-
- 3 edits in trunk/Source/WebCore
[GTK] WebKit browser scrollbars not always correctly displayed if overlay scrollbars are disabled
https://bugs.webkit.org/show_bug.cgi?id=234874
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-02-11
Reviewed by Carlos Garcia Campos.
If overlay scrollbars are disabled, and there is not enough content for the page to be
scrollable, and scrollbars are forced using overflow:scroll, then we currently fail to
paint the scrollbars properly. At minimum, we need to paint the scrollbar background, which
is what the macOS port does. Do so.
In the future, we might want to additionally paint the rest of the scrollbars, similar to
the GTK_POLICY_ALWAYS scrollbar policy type, but this would require more work.
- platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::paint):
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paint):
- 5:30 AM Changeset in webkit [289619] by
-
- 2 edits in trunk/Source/WebKit
[SOUP] Fix memory leak in WebKitDirectoryInputStream
https://bugs.webkit.org/show_bug.cgi?id=236498
Reviewed by Adrian Perez de Castro.
- NetworkProcess/soup/WebKitDirectoryInputStream.cpp:
(webkitDirectoryInputStreamRead): Use adoptGRef() for g_bytes_new_from_bytes().
- 5:02 AM Changeset in webkit [289618] by
-
- 2 edits in trunk/Tools/buildstream
[Flatpak SDK] Enable GStreamer webrtcdsp support
https://bugs.webkit.org/show_bug.cgi?id=236175
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-11
Reviewed by Martin Robinson.
- elements/sdk/gst-plugins-bad.bst: Enable webrtcdsp, needed for VAD handling.
- 4:47 AM Changeset in webkit [289617] by
-
- 5 edits in trunk
[CSS Container Queries] Implement container name matching
https://bugs.webkit.org/show_bug.cgi?id=236495
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/container-name-invalidation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-selection-expected.txt:
Source/WebCore:
Find the right container to evaluate against.
- style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluate const):
- 4:05 AM Changeset in webkit [289616] by
-
- 2 edits in trunk/Source/WebCore
Add build phase to copy PDF.js resources to WebCore.framework resources
https://bugs.webkit.org/show_bug.cgi?id=235981
Reviewed by Youenn Fablet.
This adds a new "Run Script" phase that simply copies Source/ThirdParty/pdfjs to
WebCore.framework/Resources/pdfjs, it excludes .svn and .DS_Store files too.
- WebCore.xcodeproj/project.pbxproj:
- 2:52 AM Changeset in webkit [289615] by
-
- 5 edits in trunk
Clicking on an <input type="image"> will submit the form with null submitter
https://bugs.webkit.org/show_bug.cgi?id=236324
LayoutTests/imported/w3c:
Add a test to make sure that when the form is submitted through an <input type="image">
control, thesubmitterfield of the submit event is that control.
Patch by Andreu Botella <andreu@andreubotella.com> on 2022-02-11
Reviewed by Carlos Garcia Campos.
- web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt:
- web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html:
Source/WebCore:
Patch by Andreu Botella <andreu@andreubotella.com> on 2022-02-11
Reviewed by Carlos Garcia Campos.
If you submit a form by clicking on an <input type="image"> control, the control will be in
the form's entry list, but the submitter field in the submit event will be null. This is
wrong per the spec, and caused because the call toHTMLFormElement::submitIfPossible()in
ImageInputType::handleDOMActivateEvent()calls it with one argument, rather than passing
the element as the submitter.
Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html
- html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
- 2:14 AM Changeset in webkit [289614] by
-
- 3 edits in releases/WebKitGTK/webkit-2.34/Source/WebKit
Merge r289608 - [WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
https://bugs.webkit.org/show_bug.cgi?id=201771
Reviewed by Michael Catanzaro.
xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
explicitly close the sync fd.
- UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
(WebKit::XDGDBusProxy::launch const): Return the sync fd.
- UIProcess/Launcher/glib/XDGDBusProxy.h:
- 2:14 AM Changeset in webkit [289613] by
-
- 5 edits1 copy1 add in releases/WebKitGTK/webkit-2.34/Source/WebKit
Merge r289528 - [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
https://bugs.webkit.org/show_bug.cgi?id=236437
Reviewed by Adrian Perez de Castro.
Source/WebKit:
This patch moves the XDGDBusProxy launcher implementation to its own file and fixes the following issues:
- r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need to ensure we only bind the original socket for the a11y socket and not the session bus one.
- bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
- The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XXXXXX, it helps to use a different one.
- The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the PlatformDisplay to get the address.
- SourcesGTK.txt:
- SourcesWPE.txt:
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::argumentsToFileDescriptor):
(WebKit::bindDBusSession):
(WebKit::bindA11y):
(WebKit::bubblewrapSpawn):
(WebKit::argsToFd): Deleted.
(WebKit::XDGDBusProxyLauncher::setAddress): Deleted.
(WebKit::XDGDBusProxyLauncher::isRunning const): Deleted.
(WebKit::XDGDBusProxyLauncher::path const): Deleted.
(WebKit::XDGDBusProxyLauncher::proxyPath const): Deleted.
(WebKit::XDGDBusProxyLauncher::setPermissions): Deleted.
(WebKit::XDGDBusProxyLauncher::launch): Deleted.
(WebKit::XDGDBusProxyLauncher::makeProxyPath): Deleted.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Deleted.
(): Deleted.
- UIProcess/Launcher/glib/BubblewrapLauncher.h:
- UIProcess/Launcher/glib/XDGDBusProxy.cpp: Added.
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::makeProxy const):
(WebKit::XDGDBusProxy::launch const):
- UIProcess/Launcher/glib/XDGDBusProxy.h: Added.
(WebKit::XDGDBusProxy::proxyPath const):
(WebKit::XDGDBusProxy::path const):
- 1:49 AM Changeset in webkit [289612] by
-
- 33 edits3 copies1 add in trunk
Add support to query camera and microphone permissions
https://bugs.webkit.org/show_bug.cgi?id=236138
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/permissions/nfc-permission-expected.txt:
- web-platform-tests/permissions/test-background-fetch-permission-expected.txt:
Source/WebCore:
Update queryPermission to be async as it may require to check to UIProcess.
Covered by API test.
- Modules/permissions/PermissionController.h:
- Modules/permissions/Permissions.cpp:
Source/WebKit:
Add new SPI to query for permission (without requesting anything to user).
Use this to implement camera/microphone permission.
In case of permisssion persistently denied, only expose it if web page already called getUserMedia.
In case of permission not persistently set, compute the permission state according past getUserMedia requests.
Also add geolocation mapping as applications might want to support it and it makes existing WPT tests happy.
Add C API as well so that WTR can control permission querying.
Covered by API test.
- Headers.cmake:
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- Sources.txt:
- UIProcess/API/APIUIClient.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/API/C/WKSpeechRecognitionPermissionCallback.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebPermissionController.cpp:
- WebProcess/WebCoreSupport/WebPermissionController.h:
Tools:
- TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.mm:
(-[UserMediaCaptureUIDelegate _webView:queryPermission:forOrigin:completionHandler:]):
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
- TestWebKitAPI/Tests/WebKit/getUserMediaPermission.html: Added.
- TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.h:
- TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.mm:
- WebKitTestRunner/TestController.cpp:
(WTR::queryPermission):
(WTR::TestController::createWebViewWithOptions):
- 1:16 AM Changeset in webkit [289611] by
-
- 2 edits in trunk
[CMake] Use ld.lld by default for development builds where available
https://bugs.webkit.org/show_bug.cgi?id=235979
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsCommon.cmake: Enable USE_LD_LLD by default for developers builds
when ld.lld is available. While at it, improve the match on LD_VERSION to be more robust.
- 12:44 AM Changeset in webkit [289610] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: [Flexbox] Show flex badge next to flex containers in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=235924
Reviewed by Patrick Angle.
Elements with
display: flexanddisplay: inline-flexshould include a "flex" badge.
Clicking the badge should toggle the overlay for the corresponding element.
- UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.setup):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype._handleGridOverlayShown):
- UserInterface/Controllers/GridOverlayDiagnosticEventRecorder.js:
(WI.GridOverlayDiagnosticEventRecorder.prototype.setup):
(WI.GridOverlayDiagnosticEventRecorder.prototype.teardown):
(WI.GridOverlayDiagnosticEventRecorder.prototype._handleGridOverlayShown):
(WI.GridOverlayDiagnosticEventRecorder):
- UserInterface/Controllers/OverlayManager.js:
(WI.OverlayManager):
(WI.OverlayManager.prototype.showOverlay):
(WI.OverlayManager.prototype.hideOverlay):
(WI.OverlayManager.prototype.hasVisibleGridOverlays):
(WI.OverlayManager.prototype.hasVisibleOverlay):
(WI.OverlayManager.prototype.toggleOverlay):
(WI.OverlayManager.prototype.getColorForNode):
(WI.OverlayManager.prototype.setColorForNode):
(WI.OverlayManager.prototype._handleLayoutContextTypeChanged):
(WI.OverlayManager.prototype._handleGridSettingChanged):
(WI.OverlayManager.prototype._handleMainResourceDidChange):
(WI.OverlayManager.prototype.showGridOverlay): Deleted.
(WI.OverlayManager.prototype.hideGridOverlay): Deleted.
(WI.OverlayManager.prototype.isGridOverlayVisible): Deleted.
(WI.OverlayManager.prototype.toggleGridOverlay): Deleted.
(WI.OverlayManager.prototype.getGridColorForNode): Deleted.
(WI.OverlayManager.prototype.setGridColorForNode): Deleted.
Remove grid-specific methods (such as showGridOverlay) and introduce methods that work with
both Grid and Flexbox (such as showOverlay).
- UserInterface/Views/CSSGridSection.js:
(WI.CSSGridSection.prototype.attached):
(WI.CSSGridSection.prototype.detached):
(WI.CSSGridSection.prototype._handleToggleAllCheckboxChanged):
(WI.CSSGridSection.prototype.layout):
(WI.CSSGridSection.prototype._handleGridOverlayStateChanged):
(WI.CSSGridSection.prototype._updateToggleAllCheckbox):
(WI.CSSGridSection):
- UserInterface/Views/DOMTreeElement.css:
(.tree-outline.dom .layout-badge):
(.tree-outline.dom .layout-badge.activated):
(body:not(.window-inactive, .window-docked-inactive) .tree-outline.dom:focus-within li.selected .layout-badge):
(@media (prefers-color-scheme: dark) .tree-outline.dom .layout-badge):
(.tree-outline.dom .badge-css-grid): Deleted.
(.tree-outline.dom .badge-css-grid.activated): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline.dom:focus-within li.selected .badge-css-grid): Deleted.
(@media (prefers-color-scheme: dark) .tree-outline.dom .badge-css-grid): Deleted.
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement):
(WI.DOMTreeElement.prototype.onattach):
(WI.DOMTreeElement.prototype.ondetach):
(WI.DOMTreeElement.prototype.updateTitle):
(WI.DOMTreeElement.prototype._updateLayoutBadge):
(WI.DOMTreeElement.prototype._layoutBadgeClicked):
(WI.DOMTreeElement.prototype._updateLayoutBadgeStatus):
(WI.DOMTreeElement.prototype._handleLayoutContextTypeChanged):
(WI.DOMTreeElement.prototype._updateGridBadge): Deleted.
(WI.DOMTreeElement.prototype._gridBadgeClicked): Deleted.
(WI.DOMTreeElement.prototype._gridBadgeDoubleClicked): Deleted.
(WI.DOMTreeElement.prototype._updateGridBadgeStatus): Deleted.
Renamed_gridBadgeElementto_layoutBadgeElement. We can't have both "flex" and "grid" badge on the same element,
so I called it "layoutBadge". I didn't call it simply "badge" because we may have other badges in the future.
- 12:40 AM Changeset in webkit [289609] by
-
- 14 edits6 adds in trunk
Tab characters and ch units do not obey synthetic bold width adjustments correctly
https://bugs.webkit.org/show_bug.cgi?id=236172
Reviewed by Alan Bujtas.
Source/WebCore:
It turns out we have a lot of places where code wants to know the synthetic-bold-expanded
width of characters. One place is 'tab-width: <integer>' and another is the 'ch' unit.
However, WidthIterator and ComplexTextController don't want the synthetic-bold-expanded
widths, because they explicitly apply synthetic bold after shaping.
This patch adds a 2-value enum argument to the Font::widthForGlyph() function, so callers
can pass in which behavior they want. The function has a default value to include the
synthetic bold expansion.
I then audited every call site of this function, and passed in the correct enum value.
Doing this led me to discover two bugs where the wrong behavior was being used, and this
patch fixes them and adds tests for them.
Tests: fast/text/ch-unit-synthetic-bold.html
fast/text/tab-width-synthetic-bold-complex.html
fast/text/tab-width-synthetic-bold.html
- layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::fallbackFontsForRunWithIterator):
- platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
- platform/graphics/Font.cpp:
(WebCore::Font::platformGlyphInit):
- platform/graphics/Font.h:
(WebCore::Font::spaceWidth const):
(WebCore::Font::widthForGlyph const):
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthForSimpleText const):
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::tabWidth const):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::calculateAdditionalWidth const):
LayoutTests:
3 new tests. Also, the changes in ignored-properties-001-expected.txt are a revert of the rebaseline in
r281687. That rebaseline was wrong, so this undoes it.
- fast/text/ch-unit-synthetic-bold-expected.html: Added.
- fast/text/ch-unit-synthetic-bold.html: Added.
- fast/text/tab-width-synthetic-bold-complex-expected.html: Added.
- fast/text/tab-width-synthetic-bold-complex.html: Added.
- fast/text/tab-width-synthetic-bold-expected.html: Added.
- fast/text/tab-width-synthetic-bold.html: Added.
- platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
- platform/mac-mojave/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt:
- 12:32 AM Changeset in webkit [289608] by
-
- 3 edits in trunk/Source/WebKit
[WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
https://bugs.webkit.org/show_bug.cgi?id=201771
Reviewed by Michael Catanzaro.
xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
explicitly close the sync fd.
- UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
(WebKit::XDGDBusProxy::launch const): Return the sync fd.
- UIProcess/Launcher/glib/XDGDBusProxy.h:
- 12:25 AM Changeset in webkit [289607] by
-
- 5 edits32 deletes in trunk/LayoutTests
LayoutTests/imported/w3c:
[WPE] Several WPT offscreen canvas tests are failing after r287846
https://bugs.webkit.org/show_bug.cgi?id=236474
Reviewed by Carlos Alberto Lopez Perez.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.coordinatespace.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.coordinatespace.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.missingargs.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.missingargs.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.voidreturn.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/conformance-requirements/2d.voidreturn.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.spacing-expected.txt:
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.spacing.measure.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.spacing.measure.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.spacing.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/text/2d.text.drawing.style.spacing.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.combined.3d.transforms.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.combined.3d.transforms.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.x.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.x.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.y.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.y.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.z.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotate3d.z.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotateAxis.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.rotateAxis.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.scale.3d.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.scale.3d.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.setTransform.3d.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.setTransform.3d.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.transform.3d.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.transform.3d.worker.html: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.translate.3d.worker-expected.txt: Removed.
- web-platform-tests/html/canvas/offscreen/transformations/2d.transformation.translate.3d.worker.html: Removed.
LayoutTests:
[GTK] Remove several stale WPT offscreen canvas tests
https://bugs.webkit.org/show_bug.cgi?id=236474
Reviewed by Carlos Alberto Lopez Perez.
r287846 re-sync WPT html/ tests, including offscreen canvas tests.
Some already imported offscreen canvas tests are no longer part of WPT tests.
These tests were marked as Failure but should have actually be removed
instead. Two of these tests needed to update their baseline.
- platform/gtk/TestExpectations:
- 12:04 AM Changeset in webkit [289606] by
-
- 13 edits in trunk/Source/WebCore
[LBSE] Begin stub implementation of transform support for SVG layers
https://bugs.webkit.org/show_bug.cgi?id=236185
Reviewed by Rob Buis.
RenderLayer / RenderLayerBacking use RenderStyle::applyTransform()
to compute a TransformationMatrix from the CSS Transform properties.
To hook in SVG transform support, which goes beyond pure CSS properties
that influence the "effective transform" for a certain SVG element,
RenderStyle is not the right place to place the applyTransform()
implementation for SVG specific requirements.
Therefore introduce a virtual RenderLayerModelObject::applyTransform()
function, that is implemented in RenderBox / RenderSVGModelObject.
In this patch RenderSVGModelObject::applyTransform() stays a stub
and RenderBox::applyTransform() simply forwards to RenderStyle,
preserving the current behavior.
This allows SVG to add additional transformations to the transformation
stack, which is useful to implement 'viewBox' support among other things.
Covered by existing tests, no change in behaviour.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::applyTransform const):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::applyTransform const):
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::currentTransform const):
(WebCore::RenderLayer::perspectiveTransform const):
(WebCore::RenderLayer::perspectiveOrigin const):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::rendererBorderBoxRect const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::transformMatrixForProperty const):
(WebCore::rendererBorderBoxRect): Deleted.
- rendering/RenderLayerModelObject.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::applyTransform const):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::applyTransform const):
- rendering/svg/RenderSVGRoot.h:
Feb 10, 2022:
- 10:55 PM Changeset in webkit [289605] by
-
- 4 edits in trunk/LayoutTests
[web-animations] additive animations should prevent other animations from running accelerated
https://bugs.webkit.org/show_bug.cgi?id=236447
Unreviewed gardening, the patch for this bug was cq'd before I could fix test expectations for
GTK and Windows and remove an incorrect comment in the newly added test.
- platform/glib/TestExpectations:
- platform/win/TestExpectations:
- webanimations/accelerated-animations-and-composite.html:
- 9:40 PM Changeset in webkit [289604] by
-
- 9 edits in trunk/Source
Separate out setVolatile() from setNonVolatile() on IOSurface-backed buffers
https://bugs.webkit.org/show_bug.cgi?id=236475
Reviewed by Tim Horton.
setVolatile(true) and setVolatile(false) are quite different in their needs, so
separate them out into separate functions.
setVolatile(true) can be done asynchronously (as a future patch will). The
return value tells if you succeeded in making the surfaced volatile, i.e. if it
was not in-use.
setVolatile(false) has to be synchronous, and the return value tells you whether
you need to repaint the entire surface.
Source/WebCore:
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::releaseGraphicsContext):
(WebCore::ImageBufferBackend::setVolatile):
(WebCore::ImageBufferBackend::setNonVolatile):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::setBufferVolatility):
- 9:36 PM Changeset in webkit [289603] by
-
- 5 edits in trunk/Source/WebKit
Have RemoteLayerBackingStore talk to RemoteLayerBackingStoreCollection directly
https://bugs.webkit.org/show_bug.cgi?id=236463
Reviewed by Tim Horton.
There doesn't seem to be any benefit to going via RemoteLayerTreeContext.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::~RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::backingStoreCollection const):
(WebKit::RemoteLayerBackingStore::display):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::backingStoreWasCreated): Deleted.
(WebKit::RemoteLayerTreeContext::backingStoreWillBeDestroyed): Deleted.
(WebKit::RemoteLayerTreeContext::backingStoreWillBeDisplayed): Deleted.
- 9:17 PM Changeset in webkit [289602] by
-
- 3 edits in trunk/Source/WTF
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit
<https://webkit.org/b/236459>
<rdar://problem/88772313>
Reviewed by Darin Adler.
- wtf/IteratorAdaptors.h:
(WTF::makeTransformIterator):
- wtf/WeakHashMap.h:
(WTF::WeakHashMap::set):
- Replace WTFMove() with std::forward<>().
- 7:58 PM Changeset in webkit [289601] by
-
- 2 edits in trunk
Unreviewed, add an alternate email address.
- metadata/contributors.json:
- 7:58 PM Changeset in webkit [289600] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Non-content runs (e.g. inline box start/end) do not need "within the line" flip
https://bugs.webkit.org/show_bug.cgi?id=236426
Reviewed by Antti Koivisto.
This is the same what we already do for the bidi case.
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
- 6:27 PM Changeset in webkit [289599] by
-
- 15 edits in trunk
Web animations- Composite operation accumulation support for transform properties
https://bugs.webkit.org/show_bug.cgi?id=236116
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-transforms/animation/transform-matrix-composition-expected.txt:
- web-platform-tests/css/css-transforms/animation/transform-rotate-composition-expected.txt:
- web-platform-tests/css/css-transforms/animation/transform-skew-composition-expected.txt:
- web-platform-tests/css/css-transforms/animation/transform-translate-composition-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/combining-effects/effect-composition-expected.txt:
Source/WebCore:
This patch brings further support for accumulation on transform properties. The main aspect being addressed
is handling accumulation of TransformationMatrices. This involves accumulating on the decomposed functions,
which occurs in blendFloat() and accumulateQuaternion(). Since we need to perform accumulation for one-based
values on certain decomposed functions, (scale, diagonals of matrices, etc), we set the operation to accumulate
only for these cases.
A couple of bugs introduced by this additional support are also addressed. For a property with a
different transform operation than the keyframes given, transformFunctionListsMatch() would return
true when it shouldn't. Addressed by checking in blendByMatchingOperations and falling back on matrix
interpolation. Another bug is that we need to pass the composite operation to TransformationMatrix blend().
Another bug is that we should to use Replace behavior if either of the transform matrices are
non-invertible.
- animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- platform/graphics/transforms/Matrix3DTransformOperation.cpp:
(WebCore::createOperation):
- platform/graphics/transforms/MatrixTransformOperation.cpp:
(WebCore::MatrixTransformOperation::blend):
- platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend):
- platform/graphics/transforms/TransformOperations.cpp:
(WebCore::TransformOperations::blendByMatchingOperations const):
(WebCore::TransformOperations::blendByUsingMatrixInterpolation const):
(WebCore::TransformOperations::blend const):
- platform/graphics/transforms/TransformOperations.h:
(WebCore::TransformOperations::isInvertible const):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::blendFloat):
(WebCore::TransformationMatrix::blend2):
(WebCore::accumulateQuaternion):
(WebCore::TransformationMatrix::blend4):
(WebCore::TransformationMatrix::blend):
- 6:03 PM Changeset in webkit [289598] by
-
- 7 edits2 adds in trunk
[web-animations] accelerated animations should not run accelerated
https://bugs.webkit.org/show_bug.cgi?id=236447
<rdar://problem/88756985>
Reviewed by Dean Jackson.
Source/WebCore:
Until we can tackle the complex task of supporting accelerated additive animations
(bug 232081), we need to run animations targeting properties that we would otherwise
known how to accelerate in software if it is additive or if another effect in the
effect stack is itself additive.
We add two new boolean flags on KeyframeEffect that will help us determine whether
that effect can run accelerated.
The first flag, m_hasKeyframeComposingAcceleratedProperty, indicates whether any of
the keyframes targeting a property that supports acceleration uses additivity or
accumulation.
With the help of this flag, we can make KeyframeEffect::canBeAccelerated() return false
not only if the effect has effect-wide additivity or accumulation, but also if one of
its keyframes does.
The second flag, m_hasImplicitKeyframeForAcceleratedProperty, indicates whether any
of the properties found in one of the keyframes is absent from either the 0% or 100%
keyframes. This is important because if an effect uses an implicit value for an
acclerated property, then that effect automatically depends on other effects lower
down the effect stack it belongs to being able to use an accelerated animation to
itself run accelerated.
With the help of this second flag, we can accurately determine when trying to start
an accelerated animation in the startAnimation() lambda within applyPendingAcceleratedActions()
whether the keyframe effect stack contains another effect that will fail to run
accelerated, and prevent this effect from running accelerated itself. Unless if
it does not rely on implicit keyframes, in which case effects lower down the stack
should not be accounted for, as we wouldn't have gone this far if this effect was
using additivity or accumulation, per the canBeAccelerated() improvements.
To allow the effect stack to determine whether any of its effects could be accelerated,
but fails to actually run accelerated, we've added a new KeyframeEffect::canBeAccelerated()
method that the new KeyframeEffectStack::containsEffectThatPreventsAccelerationOfEffect()
calls to determine if any effect other than the one provided should prevent acceleration.
Test: webanimations/accelerated-animations-and-composite.html
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::canBeAccelerated const):
(WebCore::KeyframeEffect::preventsAcceleration const):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::computeHasImplicitKeyframeForAcceleratedProperty):
(WebCore::KeyframeEffect::computeHasKeyframeComposingAcceleratedProperty):
- animation/KeyframeEffect.h:
- animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::containsEffectThatPreventsAccelerationOfEffect):
- animation/KeyframeEffectStack.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
LayoutTests:
Add a new test which runs through all the various scenarios where additivity
should or should not prevent other animations from running accelerated.
- webanimations/accelerated-animations-and-composite-expected.txt: Added.
- webanimations/accelerated-animations-and-composite.html: Added.
- 5:47 PM Changeset in webkit [289597] by
-
- 2 edits in trunk/Source/WebCore
Check bidiLevels are valid before reordering
https://bugs.webkit.org/show_bug.cgi?id=236378
Patch by Brandon Stewart <Brandon> on 2022-02-10
Reviewed by Alan Bujtas.
We were trusting that the bidiLevel was valid before calling the reorder.
If the bidiLevel ends up being greater than the MAX + 1 we end up in a situation where
the reordering will fail. The function returns void, so there is not a good way to check
for an error.
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
- 4:45 PM Changeset in webkit [289596] by
-
- 3 edits1 copy in trunk/Source/WTF
Unreviewed, reverting r289583 and r289591.
https://bugs.webkit.org/show_bug.cgi?id=236472
Still breaking builds
Reverted changesets:
"Reland native Xcode build phases for "Copy WTF Headers",
again"
https://bugs.webkit.org/show_bug.cgi?id=235744
https://commits.webkit.org/r289583
"Copy SignedPtr.h in WTF.xcodeproj"
https://bugs.webkit.org/show_bug.cgi?id=236466
https://commits.webkit.org/r289591
- 4:30 PM Changeset in webkit [289595] by
-
- 2 edits in trunk/Source/WTF
Don't prefer text selection in images if it is not available
https://bugs.webkit.org/show_bug.cgi?id=236462
<rdar://problem/88407336>
Reviewed by Wenson Hsieh.
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 4:27 PM Changeset in webkit [289594] by
-
- 25 edits in trunk/Source
[GPU Process] Delete GraphicsContext::clipToDrawingCommands()
https://bugs.webkit.org/show_bug.cgi?id=225959
rdar://78495380
Reviewed by Darin Adler.
Source/WebCore:
This function was added in r267742 as a workaround for a GPUProcess case
which was happening because ImageBuffer::createCompatibleBuffer() used
to return in-process ImageBuffer. clipToDrawingCommands() was a way to
record the clipper mask image into a temporary remote ImageBuffer.
If GraphicsContext::createCompatibleImageBuffer() can create an
ImageBuffer similar to the underlying ImageBuffer of the GraphicsContext,
then GraphicsContext::clipToDrawingCommands() is not needed.
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipToDrawingCommands): Deleted.
- platform/graphics/GraphicsContext.h:
- platform/graphics/NullGraphicsContext.h:
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::append):
- platform/graphics/displaylists/DisplayListItemBuffer.cpp:
(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):
- platform/graphics/displaylists/DisplayListItemType.cpp:
(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):
- platform/graphics/displaylists/DisplayListItemType.h:
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::operator<<):
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::BeginClipToDrawingCommands::BeginClipToDrawingCommands): Deleted.
(WebCore::DisplayList::BeginClipToDrawingCommands::~BeginClipToDrawingCommands): Deleted.
(WebCore::DisplayList::BeginClipToDrawingCommands::destination const): Deleted.
(WebCore::DisplayList::BeginClipToDrawingCommands::colorSpace const): Deleted.
(WebCore::DisplayList::BeginClipToDrawingCommands::encode const): Deleted.
(WebCore::DisplayList::BeginClipToDrawingCommands::decode): Deleted.
(WebCore::DisplayList::EndClipToDrawingCommands::EndClipToDrawingCommands): Deleted.
(WebCore::DisplayList::EndClipToDrawingCommands::destination const): Deleted.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::clipToDrawingCommands): Deleted.
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::~RecorderImpl):
(WebCore::DisplayList::RecorderImpl::createNestedContext): Deleted.
(WebCore::DisplayList::RecorderImpl::recordBeginClipToDrawingCommands): Deleted.
(WebCore::DisplayList::RecorderImpl::recordEndClipToDrawingCommands): Deleted.
- platform/graphics/displaylists/DisplayListRecorderImpl.h:
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::Replayer::context const): Deleted.
- platform/graphics/displaylists/DisplayListReplayer.h:
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::clipToDrawingCommands): Deleted.
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
Source/WebKit:
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::drawingContext):
(WebKit::RemoteDisplayListRecorder::beginClipToDrawingCommands): Deleted.
(WebKit::RemoteDisplayListRecorder::endClipToDrawingCommands): Deleted.
- GPUProcess/graphics/RemoteDisplayListRecorder.h:
- GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordBeginClipToDrawingCommands): Deleted.
(WebKit::RemoteDisplayListRecorderProxy::recordEndClipToDrawingCommands): Deleted.
(WebKit::RemoteDisplayListRecorderProxy::createNestedContext): Deleted.
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- 4:24 PM Changeset in webkit [289593] by
-
- 42 edits11 deletes in trunk
Unreviewed, reverting r289525.
https://bugs.webkit.org/show_bug.cgi?id=236467
Introduced layout test crashes
Reverted changeset:
"Introduce a RemoteMediaSampleProxy to represent captured
video frames used in Media Streams and present in GPUP"
https://bugs.webkit.org/show_bug.cgi?id=236099
https://commits.webkit.org/r289525
- 4:20 PM Changeset in webkit [289592] by
-
- 6 edits in trunk/Source
tryReserveUncommittedAligned should explicitly take the alignment requested
https://bugs.webkit.org/show_bug.cgi?id=236460
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
When reducing the size of VA space reserved for Structures, we
didn't take care to ensure the alignment matched the required
alignment for our bit mask. To fix this we need to pass the
original alignment to the allocator as a new parameter.
- heap/StructureAlignedMemoryAllocator.cpp:
(JSC::StructureMemoryManager::StructureMemoryManager):
Source/WTF:
This patch adds a new ifdef for Unix flavors that support the
MAP_ALIGNED macro/parameter to mmap.
Also, fix a bug where on windows we wouldn't request enough
space to guarantee that allocation is aligned.
- wtf/OSAllocator.h:
- wtf/posix/OSAllocatorPOSIX.cpp:
(WTF::OSAllocator::tryReserveUncommittedAligned):
- wtf/win/OSAllocatorWin.cpp:
(WTF::OSAllocator::tryReserveUncommittedAligned):
- 3:57 PM Changeset in webkit [289591] by
-
- 2 edits in trunk/Source/WTF
Copy SignedPtr.h in WTF.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=236466
Reviewed by Alexey Proskuryakov.
SignedPtr.h was recently added and needs to be part of WTF's Copy Headers phase.
- WTF.xcodeproj/project.pbxproj:
- 3:49 PM Changeset in webkit [289590] by
-
- 24 edits1 add in trunk/Source
[libpas] jit_heap should support the segregated heap
https://bugs.webkit.org/show_bug.cgi?id=235497
Reviewed by Yusuke Suzuki.
Source/bmalloc:
One of the things that libpas provides is a fast implementation of executable memory allocation, which
libpas calls "jit_heap". The initial implementation of this only used libpas's bitfit and large
algorithms. Bitfit was used for smaller objects and large was used for larger objects. The libpas
segregated heap was disabled in jit_heap. This made sense because:
- Bitfit and large support the shrink() call, where we shrink an allocation in-place. Executable allocation supports this to aid branch compaction (we compact code after we copy it into its final resting place, which is after we allocate the memory - so after we finish compaction, we can only shrink the allocation in-place or not at all).
- Segregated heaps have some virtual address space overheads, and memory overheads, that the bitfit and large heaps don't have. This happens because segreated heaps will dedicate each page to objects of exactly one size forever.
However, segregated heaps are substantially faster than bitfit heaps. They are faster under serial
allocation thanks to the fact that no locks need to be acquired for a typical allocation or
deallocation. They are even more faster under parallel allocation thanks to thread-local caching.
This patch enables segregated heaps for the smallest jit_heap allocations (<=2000 bytes). The cutoff
threshold is runtime configurable, so it's possible to disable segregated heaps at runtime by setting
the cutoff to 0.
With the 2000 threshold, this appears to be a 0.3% Speedometer2 speed-up.
While there is a theoretical possibility of memory overhead, I haven't seen it. If we are using jump
islands then the virtual memory overhead of segregated heaps will just mean that we use jump islands
more frequently, which would manifest as a performance regression -- but I've not seen any such
regression. So, this disables the segregated heap if the JIT pool size is too small (see changes to
ExecutableAllocator.cpp in JSC).
- libpas/libpas.xcodeproj/project.pbxproj:
- libpas/src/libpas/jit_heap.c:
(jit_heap_shrink):
- libpas/src/libpas/jit_heap_config.c:
(jit_small_segregated_allocate_page):
(jit_small_segregated_create_page_header):
(jit_small_destroy_page_header):
(jit_small_segregated_shared_page_directory_selector):
(jit_small_bitfit_allocate_page):
(jit_small_bitfit_create_page_header):
(jit_medium_bitfit_create_page_header):
(jit_medium_destroy_page_header):
(jit_prepare_to_enumerate):
(jit_small_bitfit_destroy_page_header): Deleted.
(jit_medium_bitfit_destroy_page_header): Deleted.
- libpas/src/libpas/jit_heap_config.h:
(jit_small_page_header_for_boundary):
(jit_small_boundary_for_page_header):
(jit_medium_page_header_for_boundary):
(jit_medium_boundary_for_page_header):
(jit_heap_config_page_header):
(jit_small_bitfit_page_header_for_boundary): Deleted.
(jit_small_bitfit_boundary_for_page_header): Deleted.
(jit_medium_bitfit_page_header_for_boundary): Deleted.
(jit_medium_bitfit_boundary_for_page_header): Deleted.
- libpas/src/libpas/jit_heap_config_root_data.h:
- libpas/src/libpas/pas_bitfit_heap.c:
(pas_bitfit_heap_select_variant):
(pas_bitfit_heap_construct_and_insert_size_class):
- libpas/src/libpas/pas_bitfit_heap.h:
- libpas/src/libpas/pas_bitfit_page_config.h:
(pas_bitfit_page_config_is_enabled):
- libpas/src/libpas/pas_heap_config.h:
(pas_heap_config_segregated_heap_min_align_shift):
(pas_heap_config_segregated_heap_min_align):
- libpas/src/libpas/pas_segregated_heap.c:
(min_align_for_heap):
(min_object_size_for_heap):
(max_segregated_object_size_for_heap):
(max_bitfit_object_size_for_heap):
(max_object_size_for_heap):
(pas_segregated_heap_ensure_allocator_index):
(pas_segregated_heap_ensure_size_directory_for_size):
(min_object_size_for_heap_config): Deleted.
(max_segregated_object_size_for_heap_config): Deleted.
(max_bitfit_object_size_for_heap_config): Deleted.
(max_object_size_for_heap_config): Deleted.
- libpas/src/libpas/pas_segregated_heap.h:
(pas_segregated_heap_index_for_size):
(pas_segregated_heap_size_for_index):
- libpas/src/libpas/pas_segregated_page.c:
(pas_segregated_page_construct):
- libpas/src/libpas/pas_segregated_page_config.h:
(pas_segregated_page_config_is_enabled):
- libpas/src/libpas/pas_segregated_page_config_kind.def:
- libpas/src/libpas/pas_segregated_page_config_kind_and_role.h:
- libpas/src/libpas/pas_segregated_size_directory.c:
(pas_segregated_size_directory_create):
- libpas/src/test/IsoHeapChaosTests.cpp:
(std::addAllTests):
- libpas/src/test/JITHeapTests.cpp:
(std::testAllocationSize):
(addJITHeapTests):
- libpas/src/test/TestHarness.cpp:
(main):
- libpas/src/test/ViewCacheTests.cpp: Added.
(std::setupConfig):
(std::testDisableViewCacheUsingBoundForNoViewCache):
(std::testEnableViewCacheAtSomeBoundForNoViewCache):
(addViewCacheTests):
Source/JavaScriptCore:
Disable the jit_heap segregated heap if the executable pool size is too small.
- jit/ExecutableAllocator.cpp:
(JSC::initializeJITPageReservation):
- 3:42 PM Changeset in webkit [289589] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Adjust asserts in InlineDisplayContentBuilder::processBidiContent to support vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=236418
Reviewed by Antti Koivisto.
This is in preparation for adding vertical writing mode support.
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
- 3:36 PM Changeset in webkit [289588] by
-
- 3 edits in trunk/Source/WebCore
Use Ref<> for getBackground/MaskShorthandValue
https://bugs.webkit.org/show_bug.cgi?id=236408
Patch by Matt Woodrow <Matt Woodrow> on 2022-02-10
Reviewed by Tim Nguyen.
Simple cleanup to make it clearer that these can't return nullptr, no tests needed.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::getFillLayerPropertyShorthandValue):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
(WebCore::ComputedStyleExtractor::getMaskShorthandValue):
- css/CSSComputedStyleDeclaration.h:
- 3:22 PM Changeset in webkit [289587] by
-
- 2 edits in trunk
[Xcode] Perform a full build when analyzing
https://bugs.webkit.org/show_bug.cgi?id=236421
Reviewed by Alexey Proskuryakov.
xcodebuild analyzedoes just enough work to run the analyzer on each target, and doesn't
appear to run build phases that only impact consumers of the target. In particular, it
doesn't copy framework headers.
Fix by telling xcodebuild to build _and_ analyze at once. AFAICT, this is exactly what
Xcode's Product > Analyze command does.
- Makefile.shared: s/analyze/build analyze
- 3:11 PM Changeset in webkit [289586] by
-
- 1 copy in tags/Safari-613.1.17
Tag Safari-613.1.17.
- 3:09 PM Changeset in webkit [289585] by
-
- 2 edits in branches/safari-613-branch
Cherry-pick r288434. rdar://problem/56436745
texImage2d fails to set same video frame to multiple textures
https://bugs.webkit.org/show_bug.cgi?id=203148
<rdar://problem/56436745>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-24
Reviewed by Darin Adler.
Source/WebCore:
WebGL optimizes repeated video uploads to same texture, due to this being
usual practice among pages. Reason is that there are no API to know when the
video frame updates.
The algorithm was:
- If the IOSurface is the same as in the last call
- If the texture contents has not changed since we last modified this texture then skip the upload.
However, this logic skips errorneously if the "last call" updates some other texture.
Fix and test the above.
There are other issues for the current algorithm. This patch fixes some other theoretical ones:
- If the texture is deleted and new one gets assigned the same texture id and the content seed would clash
- Video was uploaded to a different level
The previous implementation was keeping per-texture seed value map in the context
(GraphicsContextGLANGLE) and per-teture seed value map in the texture upload helper
(GraphicsContextGLCVCocoa) and last uploaded IOSurface seed in the upload helper (not per
texture).
The implementation in this patch keeps per-texture known content description in the texture
upload helper and invalidates this when each texture changes. The known content description
is the parameter list of the texture upload call.
Test: webgl/pending/conformance/textures/misc/tex-image-video-repeated.html
- platform/graphics/GraphicsContextGLState.h: (WebCore::GraphicsContextGLState::setBoundTexture):
- platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::texImage2D): (WebCore::GraphicsContextGLANGLE::texSubImage2D): (WebCore::GraphicsContextGLANGLE::compressedTexImage2D): (WebCore::GraphicsContextGLANGLE::compressedTexSubImage2D): (WebCore::GraphicsContextGLANGLE::texStorage2D): (WebCore::GraphicsContextGLANGLE::texStorage3D): (WebCore::GraphicsContextGLANGLE::texImage2DDirect): (WebCore::GraphicsContextGLANGLE::framebufferTexture2D): (WebCore::GraphicsContextGLANGLE::createTexture): (WebCore::GraphicsContextGLANGLE::deleteTexture): (WebCore::GraphicsContextGLANGLE::invalidateKnownTextureContent): (WebCore::GraphicsContextGLANGLE::textureSeed): Deleted.
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::invalidateKnownTextureContent):
- platform/graphics/cv/GraphicsContextGLCVCocoa.cpp: (WebCore::GraphicsContextGLCVCocoa::TextureContent::operator== const): (WebCore::GraphicsContextGLCVCocoa::copyVideoSampleToTexture): (WebCore::GraphicsContextGLCVCocoa::invalidateKnownTextureContent):
- platform/graphics/cv/GraphicsContextGLCVCocoa.h:
LayoutTests:
Add a test for testing the bug in which some video texture uploads
were skipped errorneously.
- webgl/pending/conformance/textures/misc/tex-image-video-repeated.html: Added.
- webgl/pending/conformance/textures/misc/tex-image-video-repeated-expected.txt: Added.
- webgl/pending/resources/webgl_test_files/conformance/textures/misc/tex-image-video-repeated.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:07 PM Changeset in webkit [289584] by
-
- 4 edits in trunk
Use of unversioned 'python' in Mac builds causing failures in 12.3
https://bugs.webkit.org/show_bug.cgi?id=236327
Reviewed by Jonathan Bedard.
- WebKit.xcodeproj/project.pbxproj: python -> python3 in "Replace WebKitAdditions in
Framework Headers" phase.
- 3:02 PM Changeset in webkit [289583] by
-
- 3 edits1 delete in trunk/Source/WTF
Reland native Xcode build phases for "Copy WTF Headers", again
https://bugs.webkit.org/show_bug.cgi?id=235744
Reviewed by Alexey Proskuryakov.
Changes since revert of r289490:
Some WTF headers were never tracked in WTF.xcodeproj, causing builds to fail (but only after
a build directory was cleaned and stale headers removed).
- WTF.xcodeproj/project.pbxproj: Add file references for missing headers.
- 2:56 PM Changeset in webkit [289582] by
-
- 1 copy in tags/Safari-613.1.16.1.6
Tag Safari-613.1.16.1.6.
- 2:55 PM Changeset in webkit [289581] by
-
- 1 copy in tags/Safari-613.1.16.0.6
Tag Safari-613.1.16.0.6.
- 2:48 PM Changeset in webkit [289580] by
-
- 22 edits in trunk/Source
ImageBuffer::get/putPixelBuffer should not go through DisplayList
https://bugs.webkit.org/show_bug.cgi?id=236305
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-10
Reviewed by Geoffrey Garen.
Source/WebCore:
Remove GetPixelBuffer / PutPixelBuffer from display list implementation.
Display lists are about GraphicsContext commands.
GetPixelBuffer and PutPixelBuffer are ImageBuffer operations.
Especially GetPixelBuffer does not make sense as a display list item,
and in its current form it does not have parameters to propagate the information
other than to a global variables, like the WebKit side GPUP implementation does.
It is undefined what would two GetPixelBuffer commands one after another mean
in a display list.
The operations in the wrong layer make the correct implementation harder than
neccessary. In this case, GetPixelBuffer is a read operation, but in current
implementation it was invoked by Flush, e.g. GetPixelBuffer would be inside
a section of commands being flushed. Flush is a write operation. As such
it would create a get of unflushed content.
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::append):
- platform/graphics/displaylists/DisplayListItemBuffer.cpp:
(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):
- platform/graphics/displaylists/DisplayListItemType.cpp:
(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):
- platform/graphics/displaylists/DisplayListItemType.h:
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::operator<<):
- platform/graphics/displaylists/DisplayListItems.h:
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
- platform/graphics/displaylists/DisplayListRecorderImpl.h:
Source/WebKit:
Move code that carries out RemoteImageBufferProxy GetPixelBuffer, PutPixelBuffer
from the display list playback to RemoteImageBuffer implementation
in RemoteRenderingBackend, the same place that hosts other
RemoteImageBuffer function invocations.
This makes it possible in the future to mark GetPixelBuffer as a read operation
depending on the previous write operations. Previously GetPixelBuffer was recorded
to the display list before the display list was flushed, which is semantically wrong
and in practice would cause inverted references.
Simplify the protocol to implement the GetPixelBuffer. Previously it was:
- If GPUP does not have the semaphore and the shm, ask for GPUP to send them, sync
- Else if GPUP does not have the semaphore, ask for GPUP to send it, sync
- Else if GPUP does not have the shm send, ask for GPUP to send it, sync
- Send the GetPixelBuffer message via stream async
- Wait for the semaphore
After it is:
- If GPUP does not have the shm send GetPixelBuffer with the shm, sync
- Else send the GetPixelBuffer via stream sync
There's no point in sending a semaphore, the stream sync message is
just a wait on the stream semaphore. Also, since semaphores
might have spurious wakeups, it is not enough of a protocol to wait a
plain semaphore.
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
- GPUProcess/graphics/RemoteDisplayListRecorder.h:
- GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer):
(WebKit::RemoteRenderingBackend::getPixelBufferForImageBufferWithNewMemory):
(WebKit::RemoteRenderingBackend::putPixelBufferForImageBuffer):
- GPUProcess/graphics/RemoteRenderingBackend.h:
- GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose):
(WebKit::RemoteRenderingBackendProxy::getPixelBufferForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::putPixelBufferForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::updateSharedMemoryForGetPixelBuffer):
(WebKit::RemoteRenderingBackendProxy::destroyGetPixelBufferSharedMemory):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- 2:34 PM Changeset in webkit [289579] by
-
- 79 edits10 adds in trunk/Source/bmalloc
[libpas] it should be possible to decommit unused parts of a thread_local_cache (update to 78508e79fa2797680344d43b94841ae2e903b15b)
https://bugs.webkit.org/show_bug.cgi?id=235347
Reviewed by Yusuke Suzuki.
Libpas uses TLCs (thread_local_caches) for allocation and deallocation. Each size class in each heap
gets a local allocator and possibly a local view cache. Both local allocators and local view caches
can get quite large (100s of bytes). So, if you try to support full isoheaps (bug 231938), you end up
with ginormous TLCs and that accounts for a lot of the memory overhead of full isoheaps.
This change takes a big bite out of that overhead by enabling decommit of TLC pages:
- Any page within a TLC that has nothing but stopped allocators (or view caches; I'll just say "allocators" to mean both "local allocators" and "local view caches", as I do in the code) can get decommitted by the scavenger.
- TLC page decommit just requires holding the TLC's scavenger_lock (formerly known as the log_flush_lock) and the heap_lock. You don't have to suspend the thread (but suspension could have been used to stop the allocator, as before).
- Attempts to allocate using an allocator in a decommitted page are guaranteed to go down a slow path that commits the page and rematerializes the allocator.
- This doesn't require any page alignment of allocators. Allocators can straddle pages.
This seems to be perf-neutral on trunk. It offers a ~1.5% memory improvement for bug 231938.
- CMakeLists.txt:
- bmalloc.xcodeproj/project.pbxproj:
- libpas/libpas.xcodeproj/project.pbxproj:
- libpas/src/libpas/bmalloc_heap.c:
(bmalloc_flex_heap_ref_get_heap):
(bmalloc_auxiliary_heap_ref_get_heap):
(bmalloc_get_heap):
- libpas/src/libpas/bmalloc_heap.h:
- libpas/src/libpas/bmalloc_heap_config.h:
- libpas/src/libpas/jit_heap_config.c:
(jit_aligned_allocator):
- libpas/src/libpas/jit_heap_config.h:
- libpas/src/libpas/minalign32_heap_config.h:
- libpas/src/libpas/pas_bitfit_allocator.c:
(pas_bitfit_allocator_construct):
(pas_bitfit_allocator_stop):
(pas_bitfit_allocator_commit_view):
(pas_bitfit_allocator_finish_failing):
- libpas/src/libpas/pas_bitfit_allocator.h:
- libpas/src/libpas/pas_bitfit_allocator_inlines.h:
(pas_bitfit_allocator_try_allocate):
- libpas/src/libpas/pas_bitfit_directory.c:
(pas_bitfit_directory_take_last_empty):
- libpas/src/libpas/pas_bitfit_page_config.h:
- libpas/src/libpas/pas_bitfit_page_config_inlines.h:
- libpas/src/libpas/pas_bitfit_page_inlines.h:
(pas_bitfit_page_allocation_commit_granules_or_reloop):
- libpas/src/libpas/pas_commit_span.c:
(pas_commit_span_construct):
(commit):
(pas_commit_span_add_unchanged_and_commit):
(decommit):
- libpas/src/libpas/pas_commit_span.h:
- libpas/src/libpas/pas_committed_pages_vector.c: Added.
(pas_committed_pages_vector_construct):
(pas_committed_pages_vector_destruct):
(pas_committed_pages_vector_count_committed):
(pas_count_committed_pages):
- libpas/src/libpas/pas_committed_pages_vector.h: Added.
(pas_committed_pages_vector_is_committed):
- libpas/src/libpas/pas_compact_tagged_ptr.h:
- libpas/src/libpas/pas_compact_thread_local_cache_layout_node.h: Added.
- libpas/src/libpas/pas_decommit_exclusion_range.h: Added.
(pas_decommit_exclusion_range_is_empty):
(pas_decommit_exclusion_range_is_contiguous):
(pas_decommit_exclusion_range_is_inverted):
(pas_decommit_exclusion_range_create_inverted):
- libpas/src/libpas/pas_deferred_decommit_log.c:
(decommit_all):
- libpas/src/libpas/pas_expendable_memory.c:
(pas_expendable_memory_state_version_next):
(pas_expendable_memory_construct):
(pas_expendable_memory_commit_if_necessary):
(scavenge_impl):
(pas_expendable_memory_scavenge):
- libpas/src/libpas/pas_expendable_memory.h:
- libpas/src/libpas/pas_free_granules.c:
(pas_free_granules_decommit_after_locking_range):
- libpas/src/libpas/pas_heap.c:
(pas_heap_get_type_size):
(pas_heap_get_type_alignment):
- libpas/src/libpas/pas_heap.h:
- libpas/src/libpas/pas_heap_config.h:
- libpas/src/libpas/pas_heap_config_utils.c:
(pas_heap_config_utils_allocate_aligned):
- libpas/src/libpas/pas_heap_config_utils.h:
- libpas/src/libpas/pas_heap_ref.c:
(pas_ensure_heap_slow):
- libpas/src/libpas/pas_internal_config.h:
- libpas/src/libpas/pas_large_free_heap_deferred_commit_log.c:
(pas_large_free_heap_deferred_commit_log_construct):
(pas_large_free_heap_deferred_commit_log_destruct):
(pas_large_free_heap_deferred_commit_log_add):
(commit):
(commit_all):
- libpas/src/libpas/pas_large_free_heap_deferred_commit_log.h:
- libpas/src/libpas/pas_large_free_heap_helpers.c:
(large_utility_aligned_allocator):
(pas_large_free_heap_helpers_try_allocate_with_alignment):
(pas_large_free_heap_helpers_deallocate):
- libpas/src/libpas/pas_large_heap.c:
(allocate_impl):
(pas_large_heap_try_deallocate):
(pas_large_heap_try_shrink):
- libpas/src/libpas/pas_large_heap_physical_page_sharing_cache.c:
(large_aligned_allocator):
(pas_large_heap_physical_page_sharing_cache_try_allocate_with_alignment):
- libpas/src/libpas/pas_large_heap_physical_page_sharing_cache.h:
- libpas/src/libpas/pas_large_sharing_pool.c:
(create_node):
(create_and_insert):
(boot_tree):
(states_match):
(split_node_and_get_right_impl):
(try_splat_impl):
(try_splat):
(splat):
(pas_large_sharing_pool_boot_free):
(pas_large_sharing_pool_free):
(pas_large_sharing_pool_allocate_and_commit):
(pas_large_sharing_pool_decommit_least_recently_used):
- libpas/src/libpas/pas_large_sharing_pool.h:
- libpas/src/libpas/pas_large_virtual_range.h: Added.
(pas_large_virtual_range_create):
(pas_large_virtual_range_create_empty):
(pas_large_virtual_range_get_range):
(pas_large_virtual_range_is_empty):
(pas_large_virtual_range_size):
(pas_large_virtual_range_overlaps):
- libpas/src/libpas/pas_large_virtual_range_min_heap.h: Added.
(pas_large_virtual_range_compare_begin):
(pas_large_virtual_range_get_index):
(pas_large_virtual_range_set_index):
- libpas/src/libpas/pas_local_allocator.c:
(pas_local_allocator_construct):
(pas_local_allocator_move):
(stop_impl):
(pas_local_allocator_stop):
- libpas/src/libpas/pas_local_allocator_inlines.h:
(pas_local_allocator_commit_if_necessary_impl):
(pas_local_allocator_commit_if_necessary):
(pas_local_allocator_bless_primordial_partial_view_before_stopping):
(pas_local_allocator_refill_with_known_config):
(pas_local_allocator_try_allocate_small_segregated_slow_impl):
(pas_local_allocator_try_allocate_out_of_line_cases):
(pas_local_allocator_try_allocate_slow_impl):
- libpas/src/libpas/pas_local_allocator_kind.h:
(pas_local_allocator_kind_get_string):
(pas_local_allocator_kind_is_stopped):
- libpas/src/libpas/pas_local_allocator_scavenger_data.c:
(pas_local_allocator_scavenger_data_is_stopped):
(pas_local_allocator_scavenger_data_commit_if_necessary_slow):
(pas_local_allocator_scavenger_data_stop):
(pas_local_allocator_scavenger_data_prepare_to_decommit):
(pas_local_allocator_scavenger_data_is_active): Deleted.
- libpas/src/libpas/pas_local_allocator_scavenger_data.h:
- libpas/src/libpas/pas_local_view_cache.c:
(pas_local_view_cache_construct):
(pas_local_view_cache_move):
(pas_local_view_cache_stop):
(pas_local_view_cache_did_restart):
- libpas/src/libpas/pas_local_view_cache.h:
(pas_local_view_cache_get_state):
(pas_local_view_cache_set_state):
(pas_local_view_cache_is_full):
(pas_local_view_cache_can_push):
(pas_local_view_cache_is_empty):
(pas_local_view_cache_prepare_to_pop):
(pas_local_view_cache_prepare_to_push):
(pas_local_view_cache_pop):
(pas_local_view_cache_push):
- libpas/src/libpas/pas_lock.h:
- libpas/src/libpas/pas_mmap_capability.h: Added.
(pas_mmap_capability_get_string):
- libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_alignment_slow):
(pas_page_malloc_alignment_shift_slow):
(pas_page_malloc_zero_fill):
(commit_impl):
(pas_page_malloc_commit):
(pas_page_malloc_commit_without_mprotect):
(decommit_impl):
(pas_page_malloc_decommit):
(pas_page_malloc_decommit_without_mprotect):
(pas_page_malloc_decommit_asymmetric): Deleted.
- libpas/src/libpas/pas_page_malloc.h:
- libpas/src/libpas/pas_scavenger.c:
(handle_expendable_memory):
(scavenger_thread_main):
(pas_scavenger_decommit_expendable_memory):
(pas_scavenger_fake_decommit_expendable_memory):
- libpas/src/libpas/pas_scavenger.h:
- libpas/src/libpas/pas_segregated_exclusive_view.c:
(pas_segregated_exclusive_view_create):
- libpas/src/libpas/pas_segregated_exclusive_view.h:
- libpas/src/libpas/pas_segregated_exclusive_view_inlines.h:
(pas_segregated_exclusive_view_note_eligibility):
- libpas/src/libpas/pas_segregated_heap.c:
(medium_directory_tuple_for_index_impl):
(pas_segregated_heap_medium_directory_tuple_for_index):
(pas_segregated_heap_medium_allocator_index_for_index):
(recompute_size_lookup):
(rematerialize_size_lookup_set_medium_directory_tuple):
(pas_segregated_heap_ensure_allocator_index):
(check_size_lookup_recomputation_set_medium_directory_tuple):
(check_size_lookup_recomputation_dump_directory):
(check_size_lookup_recomputation):
(check_size_lookup_recomputation_if_appropriate):
(pas_segregated_heap_ensure_size_directory_for_size):
- libpas/src/libpas/pas_segregated_heap.h:
- libpas/src/libpas/pas_segregated_heap_inlines.h:
(pas_segregated_heap_touch_lookup_tables):
- libpas/src/libpas/pas_segregated_page.c:
(pas_segregated_page_take_physically):
(pas_segregated_page_commit_fully):
- libpas/src/libpas/pas_segregated_page_inlines.h:
(pas_segregated_page_log_or_deallocate):
- libpas/src/libpas/pas_segregated_partial_view.c:
(pas_segregated_partial_view_create):
(compute_summary):
- libpas/src/libpas/pas_segregated_partial_view.h:
- libpas/src/libpas/pas_segregated_shared_page_directory.c:
(take_last_empty_consider_view):
- libpas/src/libpas/pas_segregated_shared_view.c:
(pas_segregated_shared_view_create):
(pas_segregated_shared_view_commit_page):
(compute_summary):
- libpas/src/libpas/pas_segregated_shared_view.h:
- libpas/src/libpas/pas_segregated_size_directory.c:
(take_last_empty_consider_view):
- libpas/src/libpas/pas_segregated_size_directory.h:
(pas_segregated_size_directory_get_tlc_allocator_index):
- libpas/src/libpas/pas_segregated_view_allocator_inlines.h:
(pas_segregated_view_will_start_allocating):
- libpas/src/libpas/pas_status_reporter.c:
(dump_large_sharing_pool_node_callback):
(pas_status_reporter_dump_view_stats):
(allocator_state):
(dump_allocator_state):
(dump_scavenger_data_state):
(pas_status_reporter_dump_baseline_allocators):
(pas_status_reporter_dump_thread_local_caches):
(pas_status_reporter_dump_everything):
- libpas/src/libpas/pas_status_reporter.h:
- libpas/src/libpas/pas_thread_local_cache.c:
(pas_thread_local_cache_size_for_allocator_index_capacity):
(num_pages):
(compute_page_indices):
(pages_committed_size):
(deallocate):
(allocate_cache):
(pas_thread_local_cache_create):
(pas_thread_local_cache_destroy):
(pas_thread_local_cache_get_local_allocator_slow):
(pas_thread_local_cache_is_committed):
(pas_thread_local_cache_compute_decommit_exclusion_range):
(pas_thread_local_cache_ensure_committed):
(pas_thread_local_cache_allocator_index_for_allocator):
(pas_thread_local_cache_stop_local_allocators):
(flush_deallocation_log_without_resetting):
(flush_deallocation_log_for_scavenger):
(flush_deallocation_log_with_mode):
(pas_thread_local_cache_flush_deallocation_log):
(pas_thread_local_cache_flush_deallocation_log_direct):
(suspend):
(resume):
(decommit_allocator_range):
(stop_allocator):
(pas_thread_local_cache_for_all):
(pas_thread_local_cache_shrink):
(flush_deallocation_log): Deleted.
- libpas/src/libpas/pas_thread_local_cache.h:
(pas_thread_local_cache_offset_of_allocator):
- libpas/src/libpas/pas_thread_local_cache_layout.c:
(pas_thread_local_cache_layout_add_node):
(pas_thread_local_cache_layout_get_node_for_index):
- libpas/src/libpas/pas_thread_local_cache_layout.h:
- libpas/src/libpas/pas_thread_local_cache_layout_entry.h: Added.
(pas_thread_local_cache_layout_entry_create_empty):
(pas_thread_local_cache_layout_entry_create_deleted):
(pas_thread_local_cache_layout_entry_is_empty_or_deleted):
(pas_thread_local_cache_layout_entry_is_empty):
(pas_thread_local_cache_layout_entry_is_deleted):
(pas_thread_local_cache_layout_entry_get_key):
(pas_thread_local_cache_layout_key_get_hash):
(pas_thread_local_cache_layout_key_is_equal):
- libpas/src/libpas/pas_thread_local_cache_layout_node.c:
(pas_thread_local_cache_layout_node_num_allocator_indices):
(pas_thread_local_cache_layout_node_commit_and_construct):
(pas_thread_local_cache_layout_node_move):
(pas_thread_local_cache_layout_node_is_committed):
(pas_thread_local_cache_layout_node_ensure_committed):
(pas_thread_local_cache_layout_node_prepare_to_decommit):
(pas_thread_local_cache_layout_num_allocator_indices): Deleted.
(pas_thread_local_cache_layout_node_construct): Deleted.
- libpas/src/libpas/pas_thread_local_cache_layout_node.h:
- libpas/src/libpas/pas_thread_local_cache_node.c:
(pas_thread_local_cache_node_allocate):
- libpas/src/libpas/pas_thread_local_cache_node.h:
- libpas/src/libpas/pas_try_allocate_intrinsic.h:
(pas_try_allocate_intrinsic_impl_casual_case):
(pas_try_allocate_intrinsic_impl_inline_only):
- libpas/src/libpas/pas_try_allocate_primitive.h:
(pas_try_allocate_primitive_impl_casual_case):
(pas_try_allocate_primitive_impl_inline_only):
- libpas/src/libpas/pas_utility_heap_config.h:
- libpas/src/libpas/pas_utils.h:
- libpas/src/libpas/pas_virtual_range.h:
(pas_virtual_range_create):
(pas_virtual_range_create_empty):
- libpas/src/test/ExpendableMemoryTests.cpp:
(std::testRage):
(std::testRematerializeAfterSearchOfDecommitted):
(std::testBasicSizeClass):
(addExpendableMemoryTests):
- libpas/src/test/LargeSharingPoolTests.cpp:
(std::testGoodCoalesceEpochUpdate):
- libpas/src/test/MemalignTests.cpp: Added.
(addMemalignTests):
- libpas/src/test/TLCDecommitTests.cpp: Added.
(std::numCommittedPagesInTLC):
(std::testTLCDecommit):
(std::testChaosThenDecommit):
(std::testTLCDecommitThenDestroyImpl):
(std::testTLCDecommitThenDestroy):
(std::testTLCDecommitThenDestroyInThread):
(std::testTLCDecommitThenFlush):
(std::testTLCDecommitThenDeallocate):
(addTLCDecommitTests):
- libpas/src/test/TestHarness.cpp:
(RuntimeConfigTestScope::RuntimeConfigTestScope):
(DecommitZeroFill::DecommitZeroFill):
(main):
- libpas/src/test/TestHarness.h:
(operator<<):
- libpas/src/test/ThingyAndUtilityHeapAllocationTests.cpp:
(std::addAllTests):
- 2:23 PM Changeset in webkit [289578] by
-
- 39 edits1 delete in trunk
Permit simultaneous Apple Pay and script injection
https://bugs.webkit.org/show_bug.cgi?id=236254
<rdar://problem/87736727>
Reviewed by Kate Cheney.
Source/WebCore:
Tests: ApplePay.ApplePayAvailableByDefault
ApplePay.ApplePayAvailableInFrame
ApplePay.UserScriptAtDocumentStartDoesNotDisableApplePay
ApplePay.UserScriptAtDocumentEndDoesNotDisableApplePay
ApplePay.UserAgentScriptEvaluationDoesNotDisableApplePay
ApplePay.UserAgentScriptEvaluationDoesNotDisableApplePayInExistingObjects
ApplePay.CanMakePaymentsDoesNotBlockUserAgentScripts
ApplePay.CanMakePaymentsWithActiveCardDoesNotBlockUserAgentScripts
ApplePay.CanMakePaymentDoesNotBlockUserAgentScripts
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::ensurePlugInsInjectedScript):
(WebCore::Document::hasEvaluatedUserAgentScripts const): Deleted.
(WebCore::Document::setHasEvaluatedUserAgentScripts): Deleted.
(WebCore::Document::isApplePayActive const): Deleted.
(WebCore::Document::setApplePayIsActive): Deleted.
Remove logic that tracks script injection activity.
- bindings/js/ScriptController.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeUserAgentScriptInWorld):
(WebCore::ScriptController::executeAsynchronousUserAgentScriptInWorld):
(WebCore::ScriptController::executeUserAgentScriptInWorldInternal): Deleted.
(WebCore::ScriptController::shouldAllowUserAgentScripts const): Deleted.
- loader/EmptyClients.cpp:
(WebCore::EmptyPaymentCoordinatorClient::supportsUnrestrictedApplePay): Deleted.
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately):
Remove logic that disables script injection after an Apple Pay session is started.
- Modules/applepay/PaymentCoordinator.h:
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::canMakePayments):
(WebCore::PaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::shouldEnableApplePayAPIs const): Deleted.
(WebCore::PaymentCoordinator::setApplePayIsActiveIfAllowed const): Deleted.
(WebCore::PaymentCoordinator::shouldAllowUserAgentScripts const): Deleted.
- Modules/applepay/PaymentCoordinatorClient.h:
(WebCore::PaymentCoordinatorClient::userAgentScriptsBlockedErrorMessage const): Deleted.
Remove logic that tracks Apple Pay activity.
- Modules/applepay/ApplePaySession.idl:
- Modules/applepay/PaymentSession.h:
- Modules/applepay/PaymentSession.cpp:
(WebCore::PaymentSession::enabledForContext): Deleted.
- Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::enabledForContext): Deleted.
- Modules/paymentrequest/PaymentRequest.idl:
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::enabledForContext): Deleted.
Remove logic that disablesApplePaySession/PaymentRequestafter script injection.
- testing/Internals.idl:
- testing/Internals.h:
- testing/Internals.cpp:
(WebCore::Internals::setApplePayIsActive): Deleted.
- testing/MockPaymentCoordinator.idl:
- testing/MockPaymentCoordinator.h:
(WebCore::MockPaymentCoordinator::supportsUnrestrictedApplePay): Deleted.
(WebCore::MockPaymentCoordinator::setSupportsUnrestrictedApplePay): Deleted.
Remove testing support since all uses of these have been removed (above).
Source/WebKit:
- WebProcess/ApplePay/WebPaymentCoordinator.h:
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::supportsUnrestrictedApplePay const): Deleted.
(WebKit::WebPaymentCoordinator::userAgentScriptsBlockedErrorMessage const): Deleted.
Remove logic that tracks Apple Pay activity.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebPaymentCoordinatorClient.h:
- WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::supportsUnrestrictedApplePay const): Deleted.
Remove logic that tracks Apple Pay activity.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
(TestWebKitAPI::TEST.ApplePay.ApplePayAvailableByDefault):
(TestWebKitAPI::TEST.ApplePay.ApplePayAvailableInFrame): Renamed from ApplePay.ApplePayAvailableInUnrestrictedClients.
(TestWebKitAPI::TEST.ApplePay.UserScriptAtDocumentStartDoesNotDisableApplePay): Renamed from ApplePay.UserScriptAtDocumentStartDisablesApplePay.
(TestWebKitAPI::TEST.ApplePay.UserScriptAtDocumentEndDoesNotDisableApplePay): Renamed from ApplePay.UserScriptAtDocumentEndDisablesApplePay.
(TestWebKitAPI::TEST.ApplePay.UserAgentScriptEvaluationDoesNotDisableApplePay): Renamed from ApplePay.UserAgentScriptEvaluationDisablesApplePay.
(TestWebKitAPI::TEST.ApplePay.UserAgentScriptEvaluationDoesNotDisableApplePayInExistingObjects): Renamed from ApplePay.UserAgentScriptEvaluationDisablesApplePayInExistingObjects.
(TestWebKitAPI::TEST.ApplePay.CanMakePaymentsDoesNotBlockUserAgentScripts): Renamed from ApplePay.CanMakePaymentsBlocksUserAgentScripts.
(TestWebKitAPI::TEST.ApplePay.CanMakePaymentsWithActiveCardDoesNotBlockUserAgentScripts): Renamed from ApplePay.CanMakePaymentsWithActiveCardBlocksUserAgentScripts.
(TestWebKitAPI::TEST.ApplePay.CanMakePaymentDoesNotBlockUserAgentScripts): Renamed from ApplePay.CanMakePaymentBlocksUserAgentScripts.
(TestWebKitAPI::TEST.ApplePay.ActiveSessionBlocksUserAgentScripts): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Removed.
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-existing-object.html:
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html:
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payment.html:
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payments.html:
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payments-with-active-card.html:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 2:21 PM Changeset in webkit [289577] by
-
- 2 edits in trunk/Source/WebCore
Fix linker errors when CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER is enabled
https://bugs.webkit.org/show_bug.cgi?id=236455
Patch by Ada Chan <ada.chan@apple.com> on 2022-02-10
Reviewed by Tim Horton.
WebCore::GraphicsContext::createImageBuffer() and WebCore::GraphicsContext::createCompatibleImageBuffer()
are used in WebKit::GraphicsContextCGDisplayList and need to be exported
- platform/graphics/GraphicsContext.h:
- 2:19 PM Changeset in webkit [289576] by
-
- 1 edit474 adds in trunk/Source/ThirdParty
Import PDF.js v2.12.313 to the WebKit repo
https://bugs.webkit.org/show_bug.cgi?id=236452
Patch by Tim Nguyen <ntim@apple.com> on 2022-02-10
Reviewed by Brent Fulgham.
Add bundle from https://mozilla.github.io/pdf.js/getting_started/#download (Modern browsers version)
Delete the following:
- Sourcemaps (.js.map files)
- Example PDF file (compressed.tracemonkey-pldi-09.pdf)
- pdfjs/LICENSE: Added.
- pdfjs/build/pdf.js: Added.
(webpackUniversalModuleDefinition):
(return.):
(return):
- pdfjs/build/pdf.sandbox.js: Added.
(webpackUniversalModuleDefinition):
(return.):
- pdfjs/build/pdf.worker.js: Added.
(webpackUniversalModuleDefinition):
(return.):
(return):
- pdfjs/web/cmaps/78-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/78-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/78-H.bcmap: Added.
- pdfjs/web/cmaps/78-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/78-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/78-V.bcmap: Added.
- pdfjs/web/cmaps/78ms-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/78ms-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/83pv-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/90ms-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/90ms-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/90msp-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/90msp-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/90pv-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/90pv-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/Add-H.bcmap: Added.
- pdfjs/web/cmaps/Add-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/Add-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/Add-V.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-0.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-1.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-3.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-4.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-5.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-6.bcmap: Added.
- pdfjs/web/cmaps/Adobe-CNS1-UCS2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-0.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-1.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-3.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-4.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-5.bcmap: Added.
- pdfjs/web/cmaps/Adobe-GB1-UCS2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-0.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-1.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-3.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-4.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-5.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-6.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Japan1-UCS2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Korea1-0.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Korea1-1.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Korea1-2.bcmap: Added.
- pdfjs/web/cmaps/Adobe-Korea1-UCS2.bcmap: Added.
- pdfjs/web/cmaps/B5-H.bcmap: Added.
- pdfjs/web/cmaps/B5-V.bcmap: Added.
- pdfjs/web/cmaps/B5pc-H.bcmap: Added.
- pdfjs/web/cmaps/B5pc-V.bcmap: Added.
- pdfjs/web/cmaps/CNS-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/CNS-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/CNS1-H.bcmap: Added.
- pdfjs/web/cmaps/CNS1-V.bcmap: Added.
- pdfjs/web/cmaps/CNS2-H.bcmap: Added.
- pdfjs/web/cmaps/CNS2-V.bcmap: Added.
- pdfjs/web/cmaps/ETHK-B5-H.bcmap: Added.
- pdfjs/web/cmaps/ETHK-B5-V.bcmap: Added.
- pdfjs/web/cmaps/ETen-B5-H.bcmap: Added.
- pdfjs/web/cmaps/ETen-B5-V.bcmap: Added.
- pdfjs/web/cmaps/ETenms-B5-H.bcmap: Added.
- pdfjs/web/cmaps/ETenms-B5-V.bcmap: Added.
- pdfjs/web/cmaps/EUC-H.bcmap: Added.
- pdfjs/web/cmaps/EUC-V.bcmap: Added.
- pdfjs/web/cmaps/Ext-H.bcmap: Added.
- pdfjs/web/cmaps/Ext-RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/Ext-RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/Ext-V.bcmap: Added.
- pdfjs/web/cmaps/GB-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GB-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/GB-H.bcmap: Added.
- pdfjs/web/cmaps/GB-V.bcmap: Added.
- pdfjs/web/cmaps/GBK-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GBK-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/GBK2K-H.bcmap: Added.
- pdfjs/web/cmaps/GBK2K-V.bcmap: Added.
- pdfjs/web/cmaps/GBKp-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GBKp-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/GBT-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GBT-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/GBT-H.bcmap: Added.
- pdfjs/web/cmaps/GBT-V.bcmap: Added.
- pdfjs/web/cmaps/GBTpc-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GBTpc-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/GBpc-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/GBpc-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/H.bcmap: Added.
- pdfjs/web/cmaps/HKdla-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKdla-B5-V.bcmap: Added.
- pdfjs/web/cmaps/HKdlb-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKdlb-B5-V.bcmap: Added.
- pdfjs/web/cmaps/HKgccs-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKgccs-B5-V.bcmap: Added.
- pdfjs/web/cmaps/HKm314-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKm314-B5-V.bcmap: Added.
- pdfjs/web/cmaps/HKm471-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKm471-B5-V.bcmap: Added.
- pdfjs/web/cmaps/HKscs-B5-H.bcmap: Added.
- pdfjs/web/cmaps/HKscs-B5-V.bcmap: Added.
- pdfjs/web/cmaps/Hankaku.bcmap: Added.
- pdfjs/web/cmaps/Hiragana.bcmap: Added.
- pdfjs/web/cmaps/KSC-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/KSC-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/KSC-H.bcmap: Added.
- pdfjs/web/cmaps/KSC-Johab-H.bcmap: Added.
- pdfjs/web/cmaps/KSC-Johab-V.bcmap: Added.
- pdfjs/web/cmaps/KSC-V.bcmap: Added.
- pdfjs/web/cmaps/KSCms-UHC-H.bcmap: Added.
- pdfjs/web/cmaps/KSCms-UHC-HW-H.bcmap: Added.
- pdfjs/web/cmaps/KSCms-UHC-HW-V.bcmap: Added.
- pdfjs/web/cmaps/KSCms-UHC-V.bcmap: Added.
- pdfjs/web/cmaps/KSCpc-EUC-H.bcmap: Added.
- pdfjs/web/cmaps/KSCpc-EUC-V.bcmap: Added.
- pdfjs/web/cmaps/Katakana.bcmap: Added.
- pdfjs/web/cmaps/LICENSE: Added.
- pdfjs/web/cmaps/NWP-H.bcmap: Added.
- pdfjs/web/cmaps/NWP-V.bcmap: Added.
- pdfjs/web/cmaps/RKSJ-H.bcmap: Added.
- pdfjs/web/cmaps/RKSJ-V.bcmap: Added.
- pdfjs/web/cmaps/Roman.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UCS2-H.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UCS2-V.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF16-H.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF16-V.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF8-H.bcmap: Added.
- pdfjs/web/cmaps/UniCNS-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UCS2-H.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UCS2-V.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF16-H.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF16-V.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF8-H.bcmap: Added.
- pdfjs/web/cmaps/UniGB-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UCS2-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UCS2-HW-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UCS2-HW-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UCS2-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF16-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF16-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF8-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF16-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF16-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF8-H.bcmap: Added.
- pdfjs/web/cmaps/UniJIS2004-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/UniJISPro-UCS2-HW-V.bcmap: Added.
- pdfjs/web/cmaps/UniJISPro-UCS2-V.bcmap: Added.
- pdfjs/web/cmaps/UniJISPro-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/UniJISX0213-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniJISX0213-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniJISX02132004-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniJISX02132004-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UCS2-H.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UCS2-V.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF16-H.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF16-V.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF32-H.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF32-V.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF8-H.bcmap: Added.
- pdfjs/web/cmaps/UniKS-UTF8-V.bcmap: Added.
- pdfjs/web/cmaps/V.bcmap: Added.
- pdfjs/web/cmaps/WP-Symbol.bcmap: Added.
- pdfjs/web/debugger.js: Added.
(FontInspector.FontInspectorClosure.removeSelection):
(FontInspector.FontInspectorClosure.resetSelection):
(FontInspector.FontInspectorClosure.selectFont):
(FontInspector.FontInspectorClosure.textLayerClick):
(FontInspector.FontInspectorClosure.return.init):
(FontInspector.FontInspectorClosure.return.cleanup):
(FontInspector.FontInspectorClosure.return.get active):
(FontInspector.FontInspectorClosure.return.set active):
(FontInspector.FontInspectorClosure.return.properties):
(FontInspector.FontInspectorClosure.return.fontAdded):
(FontInspector):
(StepperManager.StepperManagerClosure.return.init):
(StepperManager.StepperManagerClosure.return.cleanup):
(StepperManager.StepperManagerClosure.return.create):
(StepperManager.StepperManagerClosure.return.selectStepper):
(StepperManager.StepperManagerClosure.return.saveBreakPoints):
(StepperManager):
(const.Stepper.StepperClosure.c):
(const.Stepper.StepperClosure.simplifyArgs):
(const.Stepper.StepperClosure.Stepper):
(const.Stepper.StepperClosure.Stepper.prototype.init):
(const.Stepper.StepperClosure.Stepper.prototype.updateOperatorList.cboxOnClick):
(const.Stepper.StepperClosure.Stepper.prototype.updateOperatorList):
(const.Stepper.StepperClosure.Stepper.prototype.getNextBreakPoint):
(const.Stepper.StepperClosure.Stepper.prototype.breakIt):
(const.Stepper.StepperClosure.Stepper.prototype.goTo):
(const.Stepper):
(Stats.Stats):
(Stats.Stats.getStatIndex):
(Stats):
(window.PDFBug):
- pdfjs/web/images/annotation-check.svg: Added.
- pdfjs/web/images/annotation-comment.svg: Added.
- pdfjs/web/images/annotation-help.svg: Added.
- pdfjs/web/images/annotation-insert.svg: Added.
- pdfjs/web/images/annotation-key.svg: Added.
- pdfjs/web/images/annotation-newparagraph.svg: Added.
- pdfjs/web/images/annotation-noicon.svg: Added.
- pdfjs/web/images/annotation-note.svg: Added.
- pdfjs/web/images/annotation-paragraph.svg: Added.
- pdfjs/web/images/findbarButton-next.svg: Added.
- pdfjs/web/images/findbarButton-previous.svg: Added.
- pdfjs/web/images/grab.cur: Added.
- pdfjs/web/images/grabbing.cur: Added.
- pdfjs/web/images/loading-dark.svg: Added.
- pdfjs/web/images/loading-icon.gif: Added.
- pdfjs/web/images/loading.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-documentProperties.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-firstPage.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-handTool.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-lastPage.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-rotateCcw.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-rotateCw.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-scrollHorizontal.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-scrollPage.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-scrollVertical.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-scrollWrapped.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-selectTool.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-spreadEven.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-spreadNone.svg: Added.
- pdfjs/web/images/secondaryToolbarButton-spreadOdd.svg: Added.
- pdfjs/web/images/shadow.png: Added.
- pdfjs/web/images/toolbarButton-bookmark.svg: Added.
- pdfjs/web/images/toolbarButton-currentOutlineItem.svg: Added.
- pdfjs/web/images/toolbarButton-download.svg: Added.
- pdfjs/web/images/toolbarButton-menuArrow.svg: Added.
- pdfjs/web/images/toolbarButton-openFile.svg: Added.
- pdfjs/web/images/toolbarButton-pageDown.svg: Added.
- pdfjs/web/images/toolbarButton-pageUp.svg: Added.
- pdfjs/web/images/toolbarButton-presentationMode.svg: Added.
- pdfjs/web/images/toolbarButton-print.svg: Added.
- pdfjs/web/images/toolbarButton-search.svg: Added.
- pdfjs/web/images/toolbarButton-secondaryToolbarToggle.svg: Added.
- pdfjs/web/images/toolbarButton-sidebarToggle.svg: Added.
- pdfjs/web/images/toolbarButton-viewAttachments.svg: Added.
- pdfjs/web/images/toolbarButton-viewLayers.svg: Added.
- pdfjs/web/images/toolbarButton-viewOutline.svg: Added.
- pdfjs/web/images/toolbarButton-viewThumbnail.svg: Added.
- pdfjs/web/images/toolbarButton-zoomIn.svg: Added.
- pdfjs/web/images/toolbarButton-zoomOut.svg: Added.
- pdfjs/web/images/treeitem-collapsed.svg: Added.
- pdfjs/web/images/treeitem-expanded.svg: Added.
- pdfjs/web/locale/ach/viewer.properties: Added.
- pdfjs/web/locale/af/viewer.properties: Added.
- pdfjs/web/locale/an/viewer.properties: Added.
- pdfjs/web/locale/ar/viewer.properties: Added.
- pdfjs/web/locale/ast/viewer.properties: Added.
- pdfjs/web/locale/az/viewer.properties: Added.
- pdfjs/web/locale/be/viewer.properties: Added.
- pdfjs/web/locale/bg/viewer.properties: Added.
- pdfjs/web/locale/bn/viewer.properties: Added.
- pdfjs/web/locale/bo/viewer.properties: Added.
- pdfjs/web/locale/br/viewer.properties: Added.
- pdfjs/web/locale/brx/viewer.properties: Added.
- pdfjs/web/locale/bs/viewer.properties: Added.
- pdfjs/web/locale/ca/viewer.properties: Added.
- pdfjs/web/locale/cak/viewer.properties: Added.
- pdfjs/web/locale/ckb/viewer.properties: Added.
- pdfjs/web/locale/cs/viewer.properties: Added.
- pdfjs/web/locale/cy/viewer.properties: Added.
- pdfjs/web/locale/da/viewer.properties: Added.
- pdfjs/web/locale/de/viewer.properties: Added.
- pdfjs/web/locale/dsb/viewer.properties: Added.
- pdfjs/web/locale/el/viewer.properties: Added.
- pdfjs/web/locale/en-CA/viewer.properties: Added.
- pdfjs/web/locale/en-GB/viewer.properties: Added.
- pdfjs/web/locale/en-US/viewer.properties: Added.
- pdfjs/web/locale/eo/viewer.properties: Added.
- pdfjs/web/locale/es-AR/viewer.properties: Added.
- pdfjs/web/locale/es-CL/viewer.properties: Added.
- pdfjs/web/locale/es-ES/viewer.properties: Added.
- pdfjs/web/locale/es-MX/viewer.properties: Added.
- pdfjs/web/locale/et/viewer.properties: Added.
- pdfjs/web/locale/eu/viewer.properties: Added.
- pdfjs/web/locale/fa/viewer.properties: Added.
- pdfjs/web/locale/ff/viewer.properties: Added.
- pdfjs/web/locale/fi/viewer.properties: Added.
- pdfjs/web/locale/fr/viewer.properties: Added.
- pdfjs/web/locale/fy-NL/viewer.properties: Added.
- pdfjs/web/locale/ga-IE/viewer.properties: Added.
- pdfjs/web/locale/gd/viewer.properties: Added.
- pdfjs/web/locale/gl/viewer.properties: Added.
- pdfjs/web/locale/gn/viewer.properties: Added.
- pdfjs/web/locale/gu-IN/viewer.properties: Added.
- pdfjs/web/locale/he/viewer.properties: Added.
- pdfjs/web/locale/hi-IN/viewer.properties: Added.
- pdfjs/web/locale/hr/viewer.properties: Added.
- pdfjs/web/locale/hsb/viewer.properties: Added.
- pdfjs/web/locale/hu/viewer.properties: Added.
- pdfjs/web/locale/hy-AM/viewer.properties: Added.
- pdfjs/web/locale/hye/viewer.properties: Added.
- pdfjs/web/locale/ia/viewer.properties: Added.
- pdfjs/web/locale/id/viewer.properties: Added.
- pdfjs/web/locale/is/viewer.properties: Added.
- pdfjs/web/locale/it/viewer.properties: Added.
- pdfjs/web/locale/ja/viewer.properties: Added.
- pdfjs/web/locale/ka/viewer.properties: Added.
- pdfjs/web/locale/kab/viewer.properties: Added.
- pdfjs/web/locale/kk/viewer.properties: Added.
- pdfjs/web/locale/km/viewer.properties: Added.
- pdfjs/web/locale/kn/viewer.properties: Added.
- pdfjs/web/locale/ko/viewer.properties: Added.
- pdfjs/web/locale/lij/viewer.properties: Added.
- pdfjs/web/locale/lo/viewer.properties: Added.
- pdfjs/web/locale/locale.properties: Added.
- pdfjs/web/locale/lt/viewer.properties: Added.
- pdfjs/web/locale/ltg/viewer.properties: Added.
- pdfjs/web/locale/lv/viewer.properties: Added.
- pdfjs/web/locale/meh/viewer.properties: Added.
- pdfjs/web/locale/mk/viewer.properties: Added.
- pdfjs/web/locale/mr/viewer.properties: Added.
- pdfjs/web/locale/ms/viewer.properties: Added.
- pdfjs/web/locale/my/viewer.properties: Added.
- pdfjs/web/locale/nb-NO/viewer.properties: Added.
- pdfjs/web/locale/ne-NP/viewer.properties: Added.
- pdfjs/web/locale/nl/viewer.properties: Added.
- pdfjs/web/locale/nn-NO/viewer.properties: Added.
- pdfjs/web/locale/oc/viewer.properties: Added.
- pdfjs/web/locale/pa-IN/viewer.properties: Added.
- pdfjs/web/locale/pl/viewer.properties: Added.
- pdfjs/web/locale/pt-BR/viewer.properties: Added.
- pdfjs/web/locale/pt-PT/viewer.properties: Added.
- pdfjs/web/locale/rm/viewer.properties: Added.
- pdfjs/web/locale/ro/viewer.properties: Added.
- pdfjs/web/locale/ru/viewer.properties: Added.
- pdfjs/web/locale/sat/viewer.properties: Added.
- pdfjs/web/locale/sc/viewer.properties: Added.
- pdfjs/web/locale/scn/viewer.properties: Added.
- pdfjs/web/locale/sco/viewer.properties: Added.
- pdfjs/web/locale/si/viewer.properties: Added.
- pdfjs/web/locale/sk/viewer.properties: Added.
- pdfjs/web/locale/sl/viewer.properties: Added.
- pdfjs/web/locale/son/viewer.properties: Added.
- pdfjs/web/locale/sq/viewer.properties: Added.
- pdfjs/web/locale/sr/viewer.properties: Added.
- pdfjs/web/locale/sv-SE/viewer.properties: Added.
- pdfjs/web/locale/szl/viewer.properties: Added.
- pdfjs/web/locale/ta/viewer.properties: Added.
- pdfjs/web/locale/te/viewer.properties: Added.
- pdfjs/web/locale/tg/viewer.properties: Added.
- pdfjs/web/locale/th/viewer.properties: Added.
- pdfjs/web/locale/tl/viewer.properties: Added.
- pdfjs/web/locale/tr/viewer.properties: Added.
- pdfjs/web/locale/trs/viewer.properties: Added.
- pdfjs/web/locale/uk/viewer.properties: Added.
- pdfjs/web/locale/ur/viewer.properties: Added.
- pdfjs/web/locale/uz/viewer.properties: Added.
- pdfjs/web/locale/vi/viewer.properties: Added.
- pdfjs/web/locale/wo/viewer.properties: Added.
- pdfjs/web/locale/xh/viewer.properties: Added.
- pdfjs/web/locale/zh-CN/viewer.properties: Added.
- pdfjs/web/locale/zh-TW/viewer.properties: Added.
- pdfjs/web/standard_fonts/FoxitDingbats.pfb: Added.
- pdfjs/web/standard_fonts/FoxitFixed.pfb: Added.
- pdfjs/web/standard_fonts/FoxitFixedBold.pfb: Added.
- pdfjs/web/standard_fonts/FoxitFixedBoldItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitFixedItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSans.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSansBold.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSansBoldItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSansItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSerif.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSerifBold.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSerifBoldItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSerifItalic.pfb: Added.
- pdfjs/web/standard_fonts/FoxitSymbol.pfb: Added.
- pdfjs/web/standard_fonts/LICENSE_FOXIT: Added.
- pdfjs/web/standard_fonts/LICENSE_LIBERATION: Added.
- pdfjs/web/standard_fonts/LiberationSans-Bold.ttf: Added.
- pdfjs/web/standard_fonts/LiberationSans-BoldItalic.ttf: Added.
- pdfjs/web/standard_fonts/LiberationSans-Italic.ttf: Added.
- pdfjs/web/standard_fonts/LiberationSans-Regular.ttf: Added.
- pdfjs/web/viewer.css: Added.
(.textLayer):
(.textLayer span,):
(.textLayer span.markedContent):
(.textLayer .highlight):
(.textLayer .highlight.appended):
(.textLayer .highlight.begin):
(.textLayer .highlight.end):
(.textLayer .highlight.middle):
(.textLayer .highlight.selected):
(.textLayer ::-moz-selection):
(.textLayer ::selection):
(.textLayer br::-moz-selection):
(.textLayer br::selection):
(.textLayer .endOfContent):
(.textLayer .endOfContent.active):
(:root):
(.annotationLayer section):
(.annotationLayer .linkAnnotation > a,):
(.annotationLayer .buttonWidgetAnnotation.pushButton > canvas):
(.annotationLayer .linkAnnotation > a:hover,):
(.annotationLayer .textAnnotation img):
(.annotationLayer .textWidgetAnnotation input,):
(.annotationLayer .choiceWidgetAnnotation select option):
(.annotationLayer .buttonWidgetAnnotation.radioButton input):
(.annotationLayer .textWidgetAnnotation textarea):
(.annotationLayer .textWidgetAnnotation input[disabled],):
(.annotationLayer .textWidgetAnnotation input:hover,):
(.annotationLayer .textWidgetAnnotation input:focus,):
(.annotationLayer .textWidgetAnnotation input :focus,):
(.annotationLayer .buttonWidgetAnnotation.checkBox input:checked:before,):
(.annotationLayer .buttonWidgetAnnotation.checkBox input:checked:before):
(.annotationLayer .buttonWidgetAnnotation.checkBox input:checked:after):
(.annotationLayer .buttonWidgetAnnotation.radioButton input:checked:before):
(.annotationLayer .textWidgetAnnotation input.comb):
(.annotationLayer .textWidgetAnnotation input.comb:focus):
(.annotationLayer .buttonWidgetAnnotation.checkBox input,):
(.annotationLayer .popupWrapper):
(.annotationLayer .popup):
(.annotationLayer .popup > *):
(.annotationLayer .popup h1):
(.annotationLayer .popupDate):
(.annotationLayer .popupContent):
(.annotationLayer .richText > *):
(.annotationLayer .highlightAnnotation,):
(.xfaLayer .highlight):
(.xfaLayer .highlight.appended):
(.xfaLayer .highlight.begin):
(.xfaLayer .highlight.end):
(.xfaLayer .highlight.middle):
(.xfaLayer .highlight.selected):
(.xfaLayer ::-moz-selection):
(.xfaLayer ::selection):
(.xfaPage):
(.xfaContentarea):
(.xfaPrintOnly):
(.xfaLayer):
(.xfaLayer *):
(.xfaLayer div):
(.xfaLayer svg):
(.xfaLayer svg *):
(.xfaLayer a):
(.xfaRich li):
(.xfaFont):
(.xfaCaption):
(.xfaCaptionForCheckButton):
(.xfaLabel):
(.xfaLeft):
(.xfaRight):
(.xfaLeft > .xfaCaption,):
(.xfaTop):
(.xfaBottom):
(.xfaTop > .xfaCaption,):
(.xfaBorder):
(.xfaWrapped):
(.xfaTextfield:focus,):
(.xfaCheckbox:focus,):
(.xfaTextfield,):
(.xfaTop > .xfaTextfield,):
(.xfaButton):
(.xfaLink):
(.xfaCheckbox,):
(.xfaRich):
(.xfaImage):
(.xfaLrTb,):
(.xfaLr):
(.xfaRl):
(.xfaTb > div):
(.xfaPosition):
(.xfaArea):
(.xfaValignMiddle):
(.xfaTable):
(.xfaTable .xfaRow):
(.xfaTable .xfaRlRow):
(.xfaTable .xfaRlRow > div):
(.xfaNonInteractive input,):
(@media print .xfaTextfield,):
(@media print .xfaSelect):
(@media screen and (forced-colors: active) :root):
(.pdfViewer):
(.pdfViewer .canvasWrapper):
(.pdfViewer .page):
(.pdfViewer .dummyPage):
(.pdfViewer.removePageBorders .page):
(.pdfViewer.singlePageView):
(.pdfViewer.singlePageView .page):
(.pdfViewer.scrollHorizontal,):
(.pdfViewer.removePageBorders,):
(.spread .page,):
(.pdfViewer.removePageBorders .spread .page,):
(.pdfViewer .page canvas):
(.pdfViewer .page canvas[hidden]):
(.pdfViewer .page .loadingIcon):
(.pdfViewer .page .loadingIcon.notVisible):
(.pdfViewer.enablePermissions .textLayer span):
(.pdfPresentationMode .pdfViewer):
(.pdfPresentationMode .spread):
(.pdfPresentationMode .pdfViewer .page):
(@media (prefers-color-scheme: dark) :root):
(*):
(html):
(body):
(body,):
(.hidden):
([hidden]):
(#viewerContainer.pdfPresentationMode:-webkit-full-screen):
(#viewerContainer.pdfPresentationMode:fullscreen):
(.pdfPresentationMode:-webkit-full-screen a:not(.internalLink)):
(.pdfPresentationMode:fullscreen a:not(.internalLink)):
(.pdfPresentationMode:-webkit-full-screen .textLayer span):
(.pdfPresentationMode:fullscreen .textLayer span):
(.pdfPresentationMode.pdfPresentationModeControls > *,):
(#outerContainer):
(#sidebarContainer):
(html[dir="ltr"] #sidebarContainer):
(html[dir="rtl"] #sidebarContainer):
(#outerContainer.sidebarResizing #sidebarContainer):
(#outerContainer.sidebarMoving #sidebarContainer,):
(html[dir="ltr"] #outerContainer.sidebarOpen #sidebarContainer):
(html[dir="rtl"] #outerContainer.sidebarOpen #sidebarContainer):
(#mainContainer):
(#sidebarContent):
(html[dir="ltr"] #sidebarContent):
(html[dir="rtl"] #sidebarContent):
(#viewerContainer):
(#viewerContainer:not(.pdfPresentationMode)):
(#outerContainer.sidebarResizing #viewerContainer):
(html[dir="ltr"]):
(html[dir="rtl"]):
(.toolbar):
(#toolbarContainer):
(#toolbarSidebar):
(html[dir="ltr"] #toolbarSidebar):
(html[dir="rtl"] #toolbarSidebar):
(html[dir="ltr"] #toolbarSidebar .toolbarButton):
(html[dir="rtl"] #toolbarSidebar .toolbarButton):
(html[dir="ltr"] #toolbarSidebarRight .toolbarButton):
(html[dir="rtl"] #toolbarSidebarRight .toolbarButton):
(#sidebarResizer):
(html[dir="ltr"] #sidebarResizer):
(html[dir="rtl"] #sidebarResizer):
(#toolbarContainer,):
(#toolbarViewer):
(#loadingBar):
(html[dir="ltr"] #loadingBar):
(html[dir="rtl"] #loadingBar):
(html[dir="ltr"] #outerContainer.sidebarOpen #loadingBar):
(html[dir="rtl"] #outerContainer.sidebarOpen #loadingBar):
(#outerContainer.sidebarResizing #loadingBar):
(#loadingBar .progress):
(@-webkit-keyframes progressIndeterminate):
(100%):
(@keyframes progressIndeterminate):
(#loadingBar .progress.indeterminate):
(#loadingBar .progress.indeterminate .glimmer):
(.findbar,):
(.findbar):
(.findbar > div):
(.findbar.wrapContainers > div):
(.findbar.wrapContainers > div#findbarMessageContainer):
(html[dir="ltr"] .findbar):
(html[dir="rtl"] .findbar):
(.findbar .splitToolbarButton):
(html[dir="ltr"] .findbar .splitToolbarButton):
(html[dir="rtl"] .findbar .splitToolbarButton):
(.findbar .splitToolbarButton > .toolbarButton):
(.findbar .splitToolbarButton > .toolbarButton::before):
(.findbar .splitToolbarButton > .findNext):
(html[dir="ltr"] .findbar .splitToolbarButton > .findNext):
(html[dir="rtl"] .findbar .splitToolbarButton > .findNext):
(.findbar input[type="checkbox"]):
(.findbar label):
(.findbar label:hover,):
(html[dir="ltr"] #findInput):
(html[dir="rtl"] #findInput):
(.findbar .toolbarField[type="checkbox"]:checked + .toolbarLabel):
(#findInput):
(#findInput::-moz-placeholder):
(#findInput::placeholder):
(#findInput[data-status="pending"]):
(html[dir="rtl"] #findInput[data-status="pending"]):
(#findInput[data-status="notFound"]):
(.secondaryToolbar):
(html[dir="ltr"] .secondaryToolbar):
(html[dir="rtl"] .secondaryToolbar):
(#secondaryToolbarButtonContainer):
(.doorHanger,):
(.doorHanger:after,):
(.doorHanger:after):
(.doorHangerRight:after):
(.doorHanger:before,):
(html[dir="ltr"] .doorHanger:after,):
(html[dir="ltr"] .doorHanger:before,):
(html[dir="rtl"] .doorHanger:after,):
(html[dir="rtl"] .doorHanger:before,):
(#findResultsCount):
(#findMsg):
(#findMsg:empty):
(#toolbarViewerMiddle):
(html[dir="ltr"] #toolbarViewerLeft,):
(html[dir="ltr"] #toolbarViewerRight,):
(html[dir="ltr"] #toolbarViewerLeft > *,):
(html[dir="rtl"] #toolbarViewerLeft > *,):
(.splitToolbarButton):
(html[dir="ltr"] .splitToolbarButton > .toolbarButton):
(html[dir="rtl"] .splitToolbarButton > .toolbarButton):
(.toolbarButton,):
(.overlayButton:hover,):
(.overlayButton:hover > span,):
(.toolbarButton > span):
(.toolbarButton[disabled],):
(.splitToolbarButton.toggled .toolbarButton):
(.splitToolbarButton > .toolbarButton:hover,):
(.splitToolbarButton > .toolbarButton):
(html[dir="ltr"] .splitToolbarButton > .toolbarButton:first-child,):
(html[dir="ltr"] .splitToolbarButton > .toolbarButton:last-child,):
(.splitToolbarButtonSeparator):
(.findbar .splitToolbarButtonSeparator):
(html[dir="ltr"] .splitToolbarButtonSeparator):
(html[dir="rtl"] .splitToolbarButtonSeparator):
(html[dir="ltr"] #toolbarViewerLeft > .toolbarButton:first-child,):
(html[dir="ltr"] #toolbarViewerRight > .toolbarButton:last-child,):
(.toolbarButton:hover,):
(.secondaryToolbarButton:hover,):
(.toolbarButton.toggled,):
(.secondaryToolbarButton.toggled::before):
(.toolbarButton.toggled::before):
(.toolbarButton.toggled:hover:active,):
(.dropdownToolbarButton):
(.dropdownToolbarButton::after):
(html[dir="ltr"] .dropdownToolbarButton::after):
(html[dir="rtl"] .dropdownToolbarButton::after):
(.dropdownToolbarButton > select):
(html[dir="ltr"] .dropdownToolbarButton > select):
(html[dir="rtl"] .dropdownToolbarButton > select):
(.dropdownToolbarButton > select:hover,):
(.dropdownToolbarButton > select > option):
(#customScaleOption):
(#pageWidthOption):
(.toolbarButtonSpacer):
(.toolbarButton::before,):
(.dropdownToolbarButton:hover::after,):
(.toolbarButton::before):
(.toolbarButton:hover::before,):
(.secondaryToolbarButton::before):
(html[dir="ltr"] .secondaryToolbarButton::before):
(html[dir="rtl"] .secondaryToolbarButton::before):
(.toolbarButton#sidebarToggle::before):
(html[dir="rtl"] .toolbarButton#sidebarToggle::before):
(.toolbarButton#secondaryToolbarToggle::before):
(html[dir="rtl"] .toolbarButton#secondaryToolbarToggle::before):
(.toolbarButton.findPrevious::before):
(.toolbarButton.findNext::before):
(.toolbarButton.pageUp::before):
(.toolbarButton.pageDown::before):
(.toolbarButton.zoomOut::before):
(.toolbarButton.zoomIn::before):
(.toolbarButton.presentationMode::before,):
(.toolbarButton.print::before,):
(.toolbarButton.openFile::before,):
(.toolbarButton.download::before,):
(.secondaryToolbarButton.bookmark):
(.bookmark[href="#"]):
(.toolbarButton.bookmark::before,):
(#viewThumbnail.toolbarButton::before):
(#viewOutline.toolbarButton::before):
(html[dir="rtl"] #viewOutline.toolbarButton::before):
(#viewAttachments.toolbarButton::before):
(#viewLayers.toolbarButton::before):
(#currentOutlineItem.toolbarButton::before):
(html[dir="rtl"] #currentOutlineItem.toolbarButton::before):
(#viewFind.toolbarButton::before):
(.toolbarButton.pdfSidebarNotification::after):
(html[dir="ltr"] .toolbarButton.pdfSidebarNotification::after):
(html[dir="rtl"] .toolbarButton.pdfSidebarNotification::after):
(.secondaryToolbarButton):
(html[dir="ltr"] .secondaryToolbarButton):
(html[dir="rtl"] .secondaryToolbarButton):
(html[dir="ltr"] .secondaryToolbarButton > span):
(html[dir="rtl"] .secondaryToolbarButton > span):
(.secondaryToolbarButton.firstPage::before):
(.secondaryToolbarButton.lastPage::before):
(.secondaryToolbarButton.rotateCcw::before):
(.secondaryToolbarButton.rotateCw::before):
(.secondaryToolbarButton.selectTool::before):
(.secondaryToolbarButton.handTool::before):
(.secondaryToolbarButton.scrollPage::before):
(.secondaryToolbarButton.scrollVertical::before):
(.secondaryToolbarButton.scrollHorizontal::before):
(.secondaryToolbarButton.scrollWrapped::before):
(.secondaryToolbarButton.spreadNone::before):
(.secondaryToolbarButton.spreadOdd::before):
(.secondaryToolbarButton.spreadEven::before):
(.secondaryToolbarButton.documentProperties::before):
(.verticalToolbarSeparator):
(html[dir="ltr"] .verticalToolbarSeparator):
(html[dir="rtl"] .verticalToolbarSeparator):
(.horizontalToolbarSeparator):
(.toolbarField):
(.toolbarField[type="checkbox"]):
(html[dir="ltr"] .toolbarField[type="checkbox"]):
(html[dir="rtl"] .toolbarField[type="checkbox"]):
(.toolbarField.pageNumber):
(.toolbarField.pageNumber.visiblePageIsLoading):
(.toolbarField.pageNumber::-webkit-inner-spin-button,):
(.toolbarField:focus):
(.toolbarLabel):
(html[dir="ltr"] #numPages.toolbarLabel):
(html[dir="rtl"] #numPages.toolbarLabel):
(#thumbnailView):
(#thumbnailView > a:active,):
(.thumbnail):
(html[dir="ltr"] .thumbnail):
(html[dir="rtl"] .thumbnail):
(#thumbnailView > a:last-of-type > .thumbnail):
(#thumbnailView > a:last-of-type > .thumbnail:not([data-loaded])):
(.thumbnail:not([data-loaded])):
(.thumbnailImage):
(.thumbnailSelectionRing):
(a:focus > .thumbnail > .thumbnailSelectionRing > .thumbnailImage,):
(a:focus > .thumbnail > .thumbnailSelectionRing,):
(.thumbnail.selected > .thumbnailSelectionRing > .thumbnailImage):
(.thumbnail.selected > .thumbnailSelectionRing):
(#outlineView,):
(html[dir="ltr"] .treeWithDeepNesting > .treeItem,):
(html[dir="rtl"] .treeWithDeepNesting > .treeItem,):
(.treeItem > a):
(html[dir="ltr"] .treeItem > a):
(html[dir="rtl"] .treeItem > a):
(#layersView .treeItem > a > *):
(html[dir="ltr"] #layersView .treeItem > a > label):
(html[dir="rtl"] #layersView .treesItem > a > label):
(.treeItemToggler):
(.treeItemToggler::before):
(.treeItemToggler.treeItemsHidden::before):
(html[dir="rtl"] .treeItemToggler.treeItemsHidden::before):
(.treeItemToggler.treeItemsHidden ~ .treeItems):
(html[dir="ltr"] .treeItemToggler):
(html[dir="rtl"] .treeItemToggler):
(html[dir="ltr"] .treeItemToggler::before):
(html[dir="rtl"] .treeItemToggler::before):
(.treeItem.selected > a):
(.treeItemToggler:hover,):
(::-moz-selection):
(::selection):
(#errorWrapper):
(#errorMessageLeft):
(#errorMessageRight):
(#errorMoreInfo):
(.overlayButton):
(#overlayContainer):
(#overlayContainer > *):
(#overlayContainer > .container):
(#overlayContainer > .container > .dialog):
(.dialog > .row):
(.dialog > .row > *):
(.dialog .toolbarField):
(.dialog .separator):
(.dialog .buttonRow):
(.dialog :link):
(#passwordOverlay > .dialog):
(#passwordOverlay .toolbarField):
(#documentPropertiesOverlay > .dialog):
(#documentPropertiesOverlay .row > *):
(html[dir="ltr"] #documentPropertiesOverlay .row > *):
(html[dir="rtl"] #documentPropertiesOverlay .row > *):
(#documentPropertiesOverlay .row > span):
(#documentPropertiesOverlay .row > p):
(#documentPropertiesOverlay .buttonRow):
(.clearBoth):
(.fileInput):
(#PDFBug):
(#PDFBug .controls):
(#PDFBug .panels):
(#PDFBug .panels > div):
(#PDFBug button.active):
(.debuggerShowText):
(.debuggerHideText:hover):
(#PDFBug .stats):
(#PDFBug .stats .title):
(#PDFBug table):
(#PDFBug table.showText):
(#PDFBug table.showText,):
(#PDFBug table.showText td.advance):
(#viewer.textLayer-visible .textLayer):
(#viewer.textLayer-visible .canvasWrapper):
(#viewer.textLayer-visible .canvasWrapper canvas):
(#viewer.textLayer-visible .textLayer span):
(#viewer.textLayer-hover .textLayer span:hover):
(#viewer.textLayer-shadow .textLayer span):
(.grab-to-pan-grab):
(.grab-to-pan-grab:active,):
(@page):
(#printContainer):
(@media print body):
(@media print #sidebarContainer,):
(@media print #viewerContainer):
(@media print #mainContainer,):
(@media print .page):
(@media print .page[data-loaded]):
(@media print .fileInput):
(@media print body[data-pdfjsprinting] #outerContainer):
(@media print body[data-pdfjsprinting] #printContainer):
(@media print #printContainer):
(@media print #printContainer > .printedPage):
(@media print #printContainer > .xfaPrintedPage .xfaPage):
(@media print #printContainer > .xfaPrintedPage):
(@media print #printContainer > .printedPage canvas,):
(.visibleLargeView,):
(@media all and (max-width: 900px) #toolbarViewerMiddle):
(@media all and (max-width: 840px) #sidebarContainer):
(@media all and (max-width: 840px) html[dir="ltr"] #outerContainer.sidebarOpen #viewerContainer):
(@media all and (max-width: 840px) html[dir="rtl"] #outerContainer.sidebarOpen #viewerContainer):
(@media all and (max-width: 840px) #outerContainer .hiddenLargeView,):
(@media all and (max-width: 840px) #outerContainer .visibleLargeView,):
(@media all and (max-width: 770px) #outerContainer .hiddenLargeView):
(@media all and (max-width: 770px) #outerContainer .visibleLargeView):
(@media all and (max-width: 700px) #outerContainer .hiddenMediumView):
(@media all and (max-width: 700px) #outerContainer .visibleMediumView):
(@media all and (max-width: 640px) .hiddenSmallView,):
(@media all and (max-width: 640px) .visibleSmallView):
(@media all and (max-width: 640px) .toolbarButtonSpacer):
(@media all and (max-width: 640px) html[dir="ltr"] .findbar):
(@media all and (max-width: 640px) html[dir="rtl"] .findbar):
(@media all and (max-width: 535px) #scaleSelectContainer):
- pdfjs/web/viewer.html: Added.
- pdfjs/web/viewer.js: Added.
(exports.checkOnBlobSupport):
(exports.checkCanvasSizeLimitation):
(exports.AppOptions):
(exports.AppOptions.get const):
(exports.AppOptions.getAll):
(exports.AppOptions.set userOptions):
(exports.AppOptions.remove):
(exports.AppOptions._hasUserOptions):
(webpack_require.DefaultExternalServices):
(webpack_require.DefaultExternalServices.updateFindControlState):
(webpack_require.DefaultExternalServices.updateFindMatchesCount):
(webpack_require.DefaultExternalServices.initPassiveLoading):
(webpack_require.DefaultExternalServices.async fallback):
(webpack_require.DefaultExternalServices.reportTelemetry):
(webpack_require.DefaultExternalServices.createDownloadManager):
(webpack_require.DefaultExternalServices.createPreferences):
(webpack_require.DefaultExternalServices.createL10n):
(webpack_require.DefaultExternalServices.createScripting):
(webpack_require.DefaultExternalServices.get supportsIntegratedFind):
(webpack_require.DefaultExternalServices.get supportsDocumentFonts):
(webpack_require.DefaultExternalServices.get supportedMouseWheelZoomModifierKeys):
(webpack_require.DefaultExternalServices.get isInAutomation):
(webpack_require.const.PDFViewerApplication.async initialize):
(webpack_require.const.PDFViewerApplication.async _readPreferences):
(webpack_require.const.PDFViewerApplication.async _parseHashParameters):
(webpack_require.const.PDFViewerApplication.async _initializeL10n):
(webpack_require.const.PDFViewerApplication._forceCssTheme):
(webpack_require.const.PDFViewerApplication.async _initializeViewerComponents):
(webpack_require.const.PDFViewerApplication.run):
(webpack_require.const.PDFViewerApplication.get initialized):
(webpack_require.const.PDFViewerApplication.get initializedPromise):
(webpack_require.const.PDFViewerApplication.zoomIn):
(webpack_require.const.PDFViewerApplication.zoomOut):
(webpack_require.const.PDFViewerApplication.zoomReset):
(webpack_require.const.PDFViewerApplication.get pagesCount):
(webpack_require.const.PDFViewerApplication.get page):
(webpack_require.const.PDFViewerApplication.set page):
(webpack_require.const.PDFViewerApplication.get supportsPrinting):
(webpack_require.const.PDFViewerApplication.get supportsFullscreen):
(webpack_require.const.PDFViewerApplication.get supportsIntegratedFind):
(webpack_require.const.PDFViewerApplication.get supportsDocumentFonts):
(webpack_require.const.PDFViewerApplication.get loadingBar):
(webpack_require.const.PDFViewerApplication.get supportedMouseWheelZoomModifierKeys):
(webpack_require.const.PDFViewerApplication.initPassiveLoading):
(webpack_require.const.PDFViewerApplication.setTitleUsingUrl):
(webpack_require.const.PDFViewerApplication.setTitle):
(webpack_require.const.PDFViewerApplication.get _docFilename):
(webpack_require.const.PDFViewerApplication._hideViewBookmark):
(webpack_require.const.PDFViewerApplication._cancelIdleCallbacks):
(webpack_require.const.PDFViewerApplication.async close):
(webpack_require.const.PDFViewerApplication.async open):
(webpack_require.const.PDFViewerApplication._ensureDownloadComplete):
(webpack_require.const.PDFViewerApplication.async download):
(webpack_require.const.PDFViewerApplication.):
(webpack_require.):
(webpack_require):
- 2:17 PM Changeset in webkit [289575] by
-
- 10 edits in trunk
[GTK][WPE] Improve device detection in the GbmDevice
https://bugs.webkit.org/show_bug.cgi?id=236436
Patch by Alejandro G. Castro <alex@igalia.com> on 2022-02-10
Reviewed by Chris Lord.
.:
- Source/cmake/OptionsGTK.cmake: Search for drm and gbm libraries
when compiling WebGL ANGLE support.
- Source/cmake/OptionsWPE.cmake: Ditto.
Source/WebCore:
Use DRM library to detect the device location to create the gbm
device object.
No new tests, no change in behaviour.
- PlatformGTK.cmake: Add gbm and drm include directories and
libraries to the compilation.
- PlatformWPE.cmake: Ditto.
- platform/graphics/angle/GraphicsContextGLANGLE.h: Avoid storing
a pointer to the gdb device, to make sure it is just in one place,
- platform/graphics/gbm/GBMDevice.cpp:
(WebCore::GBMDevice::GBMDevice): Use the new getDeviceFd function
to open the device file. We just create the gbm device here.
(WebCore::GBMDevice::getDeviceFd): Added. Uses drm library to look
for the device file name and opens it.
- platform/graphics/gbm/GBMDevice.h: Ditto
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): Remove
the direct pointer to the gdb device, just request it when required.
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::EGLImageBacking): Ditto.
(WebCore::GraphicsContextGLANGLE::EGLImageBacking::reset): Ditto.
- 2:09 PM Changeset in webkit [289574] by
-
- 3 edits in trunk/LayoutTests
Make accessibility/mac/line-index-for-textmarker.html run faster.
https://bugs.webkit.org/show_bug.cgi?id=236451
<rdar://problem/88763847>
Reviewed by Chris Fleizach.
The main cause of slowness seems to be the high number of calls to
debug(). So now it builds the output string and call debug() just once.
- accessibility/mac/line-index-for-textmarker-expected.txt:
- accessibility/mac/line-index-for-textmarker.html:
- 2:06 PM Changeset in webkit [289573] by
-
- 5 edits in trunk/Source
Unreviewed, reverting r289485.
Internal SDKs not quiiiite ready yet
Reverted changeset:
"Move Safe Browsing knowledge into SafariSafeBrowsing
framework"
https://bugs.webkit.org/show_bug.cgi?id=231692
https://commits.webkit.org/r289485
- 1:09 PM Changeset in webkit [289572] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Adjust bidi (and mostly RTL) coords to support vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=236413
Reviewed by Antti Koivisto.
Add more coordinate flips to the bidi codepath to support vertical writing mode.
- layout/formattingContexts/inline/display/InlineDisplayBox.h:
(WebCore::InlineDisplay::Box::setRight):
(WebCore::InlineDisplay::Box::setTop):
(WebCore::InlineDisplay::Box::setBottom):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox): Convert "inline direction visual, but writing mode logical" coordinates to final.
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::flipLogicalRectToVisualForWritingMode const):
(WebCore::Layout::InlineDisplayContentBuilder::setLeftForWritingMode const):
(WebCore::Layout::InlineDisplayContentBuilder::setRightForWritingMode const):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
- 12:36 PM Changeset in webkit [289571] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Update fuzzy data based on EWS results to support b231828.
- css3/color-filters/color-filter-color-property-list-item.html:
- 12:29 PM Changeset in webkit [289570] by
-
- 7 edits in branches/safari-613.1.16.1-branch/Source/WebCore
Cherry-pick r289383. rdar://problem/88366849
[WebCore] JSValueInWrappedObject is not correct for concurrent GC
https://bugs.webkit.org/show_bug.cgi?id=236277
rdar://88366849
Reviewed by Saam Barati.
JSValueInWrappedObject is broken for concurrent GC's marking. It is using std::variant<> to store Weak / JSValue,
which is not safe if concurrent GC reads it while changing that std::variant. This patch fixes several problems
in JSValueInWrappedObject.
- We must not use std::variant here since concurrent access can happen. We have both JSValue and Weak, and change Weak after fully initialize WeakImpl's content in Weak. To ensure that, we emit storeStoreBarrier before setting Weak to the JSValueInWrappedObject's field.
- Assignment operator & copy constructor are basically wrong for this class as we need a write-barrier to set a value to the field. We remove them and make it explicit that we do not have write-barrier, which reveals that IDBRequest has a semantic bug.
- We also add clear() instead of assigning empty JSValueInWrappedObject. And we ensure that this new clear() works well with concurrent GC threads: we clear the underlying WeakImpl* pointer to nullptr. But since WeakImpl* is kept alive until GC clears weak-related things in its end phase, concurrent GC thread can access the old WeakImpl*.
- Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::setResult): (WebCore::IDBRequest::setResultToStructuredClone): (WebCore::IDBRequest::setResultToUndefined): (WebCore::IDBRequest::willIterateCursor): (WebCore::IDBRequest::didOpenOrIterateCursor):
- Modules/paymentrequest/PaymentMethodChangeEvent.cpp:
- Modules/paymentrequest/PaymentResponse.cpp: (WebCore::PaymentResponse::setDetailsFunction):
- Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::getChannelData): (WebCore::AudioBuffer::visitChannelWrappers):
- bindings/js/JSValueInWrappedObject.h: (WebCore::JSValueInWrappedObject::JSValueInWrappedObject): (WebCore::JSValueInWrappedObject::operator JSC::JSValue const): (WebCore::JSValueInWrappedObject::visit const): (WebCore::JSValueInWrappedObject::setWeakly): (WebCore::JSValueInWrappedObject::set): (WebCore::JSValueInWrappedObject::clear): (WebCore::JSValueInWrappedObject::setWithoutBarrier): (WebCore::cachedPropertyValue): (WebCore::JSValueInWrappedObject::makeValue): Deleted. (WebCore::JSValueInWrappedObject::operator=): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:27 PM Changeset in webkit [289569] by
-
- 21 edits2 copies in branches/safari-613.1.16.0-branch
Cherry-pick r289159. rdar://problem/88366590
Thread suspend and resume should take a global lock to avoid deadlock
https://bugs.webkit.org/show_bug.cgi?id=236159
Reviewed by Geoffrey Garen.
Source/bmalloc:
Introduce pas_thread_suspend_lock and take it when suspending and resuming threads.
- CMakeLists.txt:
- bmalloc.xcodeproj/project.pbxproj:
- libpas/src/libpas/pas_scavenger.c: (scavenger_thread_main): (pas_scavenger_clear_all_caches):
- libpas/src/libpas/pas_thread_local_cache.c: (pas_thread_local_cache_for_all):
- libpas/src/libpas/pas_thread_local_cache.h:
- libpas/src/libpas/pas_thread_suspend_lock.c: Copied from Source/WTF/wtf/ThreadMessage.cpp.
- libpas/src/libpas/pas_thread_suspend_lock.h: Copied from Source/WTF/wtf/ThreadMessage.cpp.
Source/JavaScriptCore:
- heap/MachineStackMarker.cpp: (JSC::MachineThreads::tryCopyOtherThreadStack): (JSC::MachineThreads::tryCopyOtherThreadStacks):
- heap/MachineStackMarker.h:
- runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::takeSample):
- runtime/VMTraps.cpp:
- wasm/WasmMachineThreads.cpp: (JSC::Wasm::resetInstructionCacheOnAllThreads):
Source/WTF:
This patch introduces a global lock which should be taken while suspending and resuming a thread.
It is possible that two different threads suspend and resume threads. And if threads suspend
each other without critical section, it can cause a dead lock.
To avoid this problem, we introduce a global lock which should be taken when suspending and resuming
threads. Since libpas is also using thread suspension, we expose a global pas_thread_suspend_lock
when libpas is used, and we use this lock in WTF's Thread suspension code.
- wtf/ThreadMessage.cpp: (WTF::sendMessageScoped):
- wtf/ThreadMessage.h: (WTF::sendMessage):
- wtf/Threading.cpp: (WTF::ThreadSuspendLocker::ThreadSuspendLocker): (WTF::ThreadSuspendLocker::~ThreadSuspendLocker):
- wtf/Threading.h:
- wtf/posix/ThreadingPOSIX.cpp: (WTF::Thread::suspend): (WTF::Thread::resume): (WTF::Thread::getRegisters):
- wtf/win/ThreadingWin.cpp: (WTF::Thread::suspend): (WTF::Thread::resume): (WTF::Thread::getRegisters):
Tools:
- TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: (runThreadMessageTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:27 PM Changeset in webkit [289568] by
-
- 2 edits in branches/safari-613.1.16.0-branch/Source/bmalloc
Cherry-pick r289145. rdar://problem/88366590
[libpas] Use os_unfair_lock instead of spinlock
https://bugs.webkit.org/show_bug.cgi?id=236158
Reviewed by Geoffrey Garen.
os_unfair_lock is very fast while it can properly suspend threads.
A/B test result was neutral on Speedometer2 and JetStream2. So, to
reduce unnecessary CPU spins, let's replace spinlock with os_unfair_lock
if it is supported (if OS is Darwin).
- libpas/src/libpas/pas_config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:23 PM Changeset in webkit [289567] by
-
- 3 edits in trunk/Source/WebCore
Crash in in WebCore::CSSStyleSheet::didMutateRules
https://bugs.webkit.org/show_bug.cgi?id=236450
Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2022-02-10
Reviewed by Antti Koivisto.
Replace the raw pointer rule in RuleMutationScope with a RefPtr so it can be accessible
for the scope.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):
- css/CSSStyleSheet.h:
- 12:13 PM Changeset in webkit [289566] by
-
- 11 edits2 adds in trunk/Source/WebKit
Apply default sandbox to webpushd on Mac
https://bugs.webkit.org/show_bug.cgi?id=236342
Reviewed by Per Arne Vollan.
This applies a default sandbox profile that allows and logs all operations by webpushd on
the Mac. In future patches we'll tighten the sandbox based on the sandbox logs that we
receive.
To do this, I refactored the sandbox initialization logic in AuxiliaryProcess so that it can
be called without creating an AuxiliaryProcess instance. This probably should be refactored
further (e.g. since webpushd isn't an AuxiliaryProcess, but rather a system daemon). But I
wanted to keep the amount of refactoring low for now while we're still figuring things out.
We also do not currently support compiling and caching the sandbox profiles. We'll add that
support later.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- PlatformMac.cmake:
- Shared/AuxiliaryProcess.cpp:
(WebKit::applySandboxProfileForDaemon):
- Shared/AuxiliaryProcess.h:
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::getUserDirectorySuffix):
(WebKit::populateSandboxInitializationParameters):
(WebKit::AuxiliaryProcess::initializeSandbox):
(WebKit::AuxiliaryProcess::applySandboxProfileForDaemon):
- WebKit.xcodeproj/project.pbxproj:
- webpushd/WebPushDaemonMain.mm:
(WebKit::applySandbox):
(WebKit::WebPushDaemonMain):
- webpushd/mac/com.apple.WebKit.webpushd.sb.in: Added.
- 11:56 AM Changeset in webkit [289565] by
-
- 9 edits in branches/safari-613.1.16.0-branch/Source
Versioning.
WebKit-7613.1.16.0.6
- 11:50 AM Changeset in webkit [289564] by
-
- 9 edits in branches/safari-613.1.16.1-branch/Source
Versioning.
WebKit-7613.1.16.1.6
- 11:49 AM Changeset in webkit [289563] by
-
- 3 edits4 adds in branches/safari-613-branch
Cherry-pick r289498. rdar://problem/88635487
Dialog element only animates once
https://bugs.webkit.org/show_bug.cgi?id=236274
rdar://88635487
Reviewed by Tim Nguyen and Dean Jackson.
LayoutTests/imported/w3c:
Add two new tests that check that we correctly start, stop and resume animations on <dialog>
and ::backdrop as a <dialog> element is open, closed and open again.
- web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added.
- web-platform-tests/css/css-animations/dialog-animation.html: Added.
- web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added.
- web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added.
- web-platform-tests/css/css-animations/support/testcommon.js: (addElement): (addDiv):
Source/WebCore:
Two issues related to CSS Animation surfaced in this bug which animates both <dialog>
and its ::backdrop as the dialog is open and eventually re-opened.
The first issue was that we didn't clear all CSS Animations state when a <dialog> was
closed and its style was set todisplay: none. We now use the clearCSSAnimationsForStyleable()
function (static so that it's not exposed on the Styleable struct) to correctly clear
such state both when we identify a Styleable is newly gettingdisplay: noneand when
cancelDeclarativeAnimations() was called. This allows us to remove removeCSSAnimationCreatedByMarkup()
a fair bit of work to clear CSS Animation state per-animation when we only ever used that
function for _all_ animations.
The second issue was that we never called cancelDeclarativeAnimations() for ::backdrop.
We now do that inside of Element::removeFromTopLayer() at a point where the code in
Styleable::fromRenderer() will still work as the element will still be contained in
Document::topLayerElements().
Tests: imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html
imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html
- dom/Element.cpp: (WebCore::Element::removeFromTopLayer):
- style/Styleable.cpp: (WebCore::clearCSSAnimationsForStyleable): (WebCore::Styleable::cancelDeclarativeAnimations const): (WebCore::Styleable::updateCSSAnimations const): (WebCore::removeCSSAnimationCreatedByMarkup): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:49 AM Changeset in webkit [289562] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore/rendering
Cherry-pick r289437. rdar://problem/86153015
Grid may be empty in certain scenarios
https://bugs.webkit.org/show_bug.cgi?id=234578
Patch by Brandon Stewart <Brandon> on 2022-02-08
Reviewed by Darin Adler.
Add check to handle legend elements when inside a CSS Grid. The legend element should not be
added to aspectRatioBlockSizeDependentGridItems.
- rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutBlock):
- rendering/RenderGrid.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:49 AM Changeset in webkit [289561] by
-
- 2 edits2 adds in branches/safari-613-branch
Cherry-pick r289241. rdar://problem/85727334
Updating grid gap value does not recalculate styles
https://bugs.webkit.org/show_bug.cgi?id=233252
<rdar://problem/85727334>
Reviewed by Simon Fraser.
Source/WebCore:
Both column and row gap style value change need to initiate layout in order to update their geometries.
Test: fast/dynamic/gap-style-change-should-initiate-layout.html
- rendering/style/RenderStyle.cpp: (WebCore::rareNonInheritedDataChangeRequiresLayout):
LayoutTests:
- fast/dynamic/gap-style-change-should-initiate-layout-expected.html: Added.
- fast/dynamic/gap-style-change-should-initiate-layout.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:49 AM Changeset in webkit [289560] by
-
- 9 edits7 adds in branches/safari-613-branch
Cherry-pick r288434. rdar://problem/56436745
texImage2d fails to set same video frame to multiple textures
https://bugs.webkit.org/show_bug.cgi?id=203148
<rdar://problem/56436745>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-24
Reviewed by Darin Adler.
Source/WebCore:
WebGL optimizes repeated video uploads to same texture, due to this being
usual practice among pages. Reason is that there are no API to know when the
video frame updates.
The algorithm was:
- If the IOSurface is the same as in the last call
- If the texture contents has not changed since we last modified this texture then skip the upload.
However, this logic skips errorneously if the "last call" updates some other texture.
Fix and test the above.
There are other issues for the current algorithm. This patch fixes some other theoretical ones:
- If the texture is deleted and new one gets assigned the same texture id and the content seed would clash
- Video was uploaded to a different level
The previous implementation was keeping per-texture seed value map in the context
(GraphicsContextGLANGLE) and per-teture seed value map in the texture upload helper
(GraphicsContextGLCVCocoa) and last uploaded IOSurface seed in the upload helper (not per
texture).
The implementation in this patch keeps per-texture known content description in the texture
upload helper and invalidates this when each texture changes. The known content description
is the parameter list of the texture upload call.
Test: webgl/pending/conformance/textures/misc/tex-image-video-repeated.html
- platform/graphics/GraphicsContextGLState.h: (WebCore::GraphicsContextGLState::setBoundTexture):
- platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::texImage2D): (WebCore::GraphicsContextGLANGLE::texSubImage2D): (WebCore::GraphicsContextGLANGLE::compressedTexImage2D): (WebCore::GraphicsContextGLANGLE::compressedTexSubImage2D): (WebCore::GraphicsContextGLANGLE::texStorage2D): (WebCore::GraphicsContextGLANGLE::texStorage3D): (WebCore::GraphicsContextGLANGLE::texImage2DDirect): (WebCore::GraphicsContextGLANGLE::framebufferTexture2D): (WebCore::GraphicsContextGLANGLE::createTexture): (WebCore::GraphicsContextGLANGLE::deleteTexture): (WebCore::GraphicsContextGLANGLE::invalidateKnownTextureContent): (WebCore::GraphicsContextGLANGLE::textureSeed): Deleted.
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::invalidateKnownTextureContent):
- platform/graphics/cv/GraphicsContextGLCVCocoa.cpp: (WebCore::GraphicsContextGLCVCocoa::TextureContent::operator== const): (WebCore::GraphicsContextGLCVCocoa::copyVideoSampleToTexture): (WebCore::GraphicsContextGLCVCocoa::invalidateKnownTextureContent):
- platform/graphics/cv/GraphicsContextGLCVCocoa.h:
LayoutTests:
Add a test for testing the bug in which some video texture uploads
were skipped errorneously.
- webgl/pending/conformance/textures/misc/tex-image-video-repeated.html: Added.
- webgl/pending/conformance/textures/misc/tex-image-video-repeated-expected.txt: Added.
- webgl/pending/resources/webgl_test_files/conformance/textures/misc/tex-image-video-repeated.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:41 AM Changeset in webkit [289559] by
-
- 2 edits in trunk
Unreviewed, update my (Tim Nguyen) status to reviewer
- metadata/contributors.json:
- 11:36 AM Changeset in webkit [289558] by
-
- 53 edits3 copies53 adds29 deletes in trunk
Resync web-platform-tests/service-workers from upstream
https://bugs.webkit.org/show_bug.cgi?id=236380
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Resync web-platform-tests/service-workers from upstream 012f446eafc392c7.
- web-platform-tests/interfaces/service-workers.idl: Updated.
- web-platform-tests/service-workers/*: Updated.
Tools:
Fix import of WPT tests with
global=serviceworker-module.
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.init):
LayoutTests:
- TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt:
- tests-options.json:
- 11:12 AM Changeset in webkit [289557] by
-
- 17 edits2 copies in branches/safari-613-branch
Cherry-pick r289159. rdar://problem/88366590
Thread suspend and resume should take a global lock to avoid deadlock
https://bugs.webkit.org/show_bug.cgi?id=236159
Reviewed by Geoffrey Garen.
Source/bmalloc:
Introduce pas_thread_suspend_lock and take it when suspending and resuming threads.
- CMakeLists.txt:
- bmalloc.xcodeproj/project.pbxproj:
- libpas/src/libpas/pas_scavenger.c: (scavenger_thread_main): (pas_scavenger_clear_all_caches):
- libpas/src/libpas/pas_thread_local_cache.c: (pas_thread_local_cache_for_all):
- libpas/src/libpas/pas_thread_local_cache.h:
- libpas/src/libpas/pas_thread_suspend_lock.c: Copied from Source/WTF/wtf/ThreadMessage.cpp.
- libpas/src/libpas/pas_thread_suspend_lock.h: Copied from Source/WTF/wtf/ThreadMessage.cpp.
Source/JavaScriptCore:
- heap/MachineStackMarker.cpp: (JSC::MachineThreads::tryCopyOtherThreadStack): (JSC::MachineThreads::tryCopyOtherThreadStacks):
- heap/MachineStackMarker.h:
- runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::takeSample):
- runtime/VMTraps.cpp:
- wasm/WasmMachineThreads.cpp: (JSC::Wasm::resetInstructionCacheOnAllThreads):
Source/WTF:
This patch introduces a global lock which should be taken while suspending and resuming a thread.
It is possible that two different threads suspend and resume threads. And if threads suspend
each other without critical section, it can cause a dead lock.
To avoid this problem, we introduce a global lock which should be taken when suspending and resuming
threads. Since libpas is also using thread suspension, we expose a global pas_thread_suspend_lock
when libpas is used, and we use this lock in WTF's Thread suspension code.
- wtf/ThreadMessage.cpp: (WTF::sendMessageScoped):
- wtf/ThreadMessage.h: (WTF::sendMessage):
- wtf/Threading.cpp: (WTF::ThreadSuspendLocker::ThreadSuspendLocker): (WTF::ThreadSuspendLocker::~ThreadSuspendLocker):
- wtf/Threading.h:
- wtf/posix/ThreadingPOSIX.cpp: (WTF::Thread::suspend): (WTF::Thread::resume): (WTF::Thread::getRegisters):
- wtf/win/ThreadingWin.cpp: (WTF::Thread::suspend): (WTF::Thread::resume): (WTF::Thread::getRegisters):
Tools:
- TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: (runThreadMessageTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:12 AM Changeset in webkit [289556] by
-
- 1 edit in branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_config.h
Cherry-pick r289145. rdar://problem/88366590
[libpas] Use os_unfair_lock instead of spinlock
https://bugs.webkit.org/show_bug.cgi?id=236158
Reviewed by Geoffrey Garen.
os_unfair_lock is very fast while it can properly suspend threads.
A/B test result was neutral on Speedometer2 and JetStream2. So, to
reduce unnecessary CPU spins, let's replace spinlock with os_unfair_lock
if it is supported (if OS is Darwin).
- libpas/src/libpas/pas_config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 AM Changeset in webkit [289555] by
-
- 4 edits in branches/safari-613-branch/Source
Cherry-pick r288970. rdar://problem/88459807
Update computation of FAST_TLS base.
https://bugs.webkit.org/show_bug.cgi?id=235934
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::loadFromTLS32): (JSC::MacroAssemblerARM64::loadFromTLS64): (JSC::MacroAssemblerARM64::storeToTLS32): (JSC::MacroAssemblerARM64::storeToTLS64):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::keyForCurrentThread):
- offlineasm/arm64.rb:
Source/WTF:
- wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:07 AM Changeset in webkit [289554] by
-
- 2 edits in releases/WebKitGTK/webkit-2.34/Source/WebCore
Merge r289529 - [GTK] Scrollbars painted incorrectly if theme enables steppers (steppers misplaced on vertical scrollbars, horizontal scrollbars very broken)
https://bugs.webkit.org/show_bug.cgi?id=234871
Reviewed by Carlos Garcia Campos.
Actually use the scrollbar orientation when creating its contents,
instead of always using vertical.
- platform/gtk/RenderThemeScrollbar.cpp:
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
- 11:06 AM WebKitGTK/2.34.x edited by
- (diff)
- 10:46 AM Changeset in webkit [289553] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, update BundleResourceLoader WorkQueue identifier
Address Alex's review comment in bug 236062.
- loader/cocoa/BundleResourceLoader.mm:
(WebCore::BundleResourceLoader::loadQueue):
- 10:32 AM Changeset in webkit [289552] by
-
- 18 edits in trunk/Source
Support
WebPageProxy::replaceSelectionWithPasteboardData()on iOS
https://bugs.webkit.org/show_bug.cgi?id=236406
Reviewed by Tim Horton.
Source/WebCore:
Move the definition of
readSelectionFromPasteboardfrom EditorMac.mm to EditorCocoa.mm.
No change in behavior (yet).
- editing/Editor.h:
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::readSelectionFromPasteboard):
- editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Deleted.
Move this into EditorCocoa.mm.
Source/WebKit:
In preparation for an upcoming patch, make
WebPageProxy::replaceSelectionWithPasteboardData()(as well as all
downstream codepaths) available on all Cocoa platforms. This is currently macOS-specific, and only used for
service controls (i.e. inserting content via sharing picker API).
- Sources.txt:
- SourcesCocoa.txt:
Move WebPasteboardOverrides.cpp from SourcesCocoa to Sources, now that there are non-Cocoa-specific codepaths in
WebPlatformStrategies that exercise this class.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData): Deleted.
Move this into WebPageProxyCocoa.mm.
- WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::overriddenInfo):
- WebProcess/WebCoreSupport/WebPasteboardOverrides.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::allPasteboardItemInfo):
(WebKit::WebPlatformStrategies::informationForItemAtIndex):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
Add additional support for returning canned data from
WebPasteboardOverrides::sharedPasteboardOverrides()in
pasteboard reading codepaths that are exercised byWebCore::Pasteboardon iOS.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::replaceSelectionPasteboardName):
(WebKit::WebPage::replaceSelectionWithPasteboardData):
(WebKit::WebPage::readSelectionFromPasteboard):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::readSelectionFromPasteboard): Deleted.
Delete this unimplemented method stub.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::replaceSelectionPasteboardName): Deleted.
Move this into WebPageCocoa.mm.
(WebKit::WebPage::replaceSelectionWithPasteboardData): Deleted.
(WebKit::WebPage::readSelectionFromPasteboard): Deleted.
- 10:29 AM Changeset in webkit [289551] by
-
- 2 edits in branches/safari-614.1.3-branch/Source/WebKit
Cherry-pick r289436. rdar://problem/87908259
[WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS
https://bugs.webkit.org/show_bug.cgi?id=236151
rdar://87908259
Reviewed by Brent Fulgham.
This patch starts using the ASC apis to make WebAuthn calls on iOS the
same way they are made on macOS. Some cleanup work will be needed to
deprecate the WebAuthn process after this change is made.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Deleted. (WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:54 AM Changeset in webkit [289550] by
-
- 3 edits in trunk/LayoutTests
Unskip App Privacy Report tests in open source now that EWS is updated
https://bugs.webkit.org/show_bug.cgi?id=232251
Unreviewed. Unskip iOS 15 tests now that EWS is updated.
- TestExpectations:
- platform/ios-wk2/TestExpectations:
- 9:49 AM Changeset in webkit [289549] by
-
- 12 edits2 adds in trunk/Source
Add webkit-pdfjs-viewer scheme for PDF.js resources
https://bugs.webkit.org/show_bug.cgi?id=236062
Reviewed by Youenn Fablet.
The code handling the scheme is under WebCore::BundleResourceLoader.
It reads files from the pdfjs/ sub-folder in the WebCore.framework resources folder.
Right now, this sub-folder does not exist yet, but this scheme can be tested by manually populating it.
Bug 235981 will take care of populating this folder at build-time.
Note: This scheme can only be loaded inside a PDFDocument <iframe>
Source/WebCore:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/PDFDocument.cpp:
(WebCore::PDFDocument::createDocumentStructure):
- loader/cocoa/BundleResourceLoader.mm: Added
- loader/cocoa/BundleResourceLoader.h: Added
- loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- platform/LegacySchemeRegistry.cpp:
(WebCore::builtinSecureSchemes):
Source/WebKit:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingPDFJSHandler):
- WebProcess/Network/WebLoaderStrategy.h:
- 9:46 AM Changeset in webkit [289548] by
-
- 9 edits in trunk/LayoutTests
Unreviewed gardening.
LayoutTests/imported/w3c:
Add fuzzy data based on EWS results to support b231828.
- web-platform-tests/css/motion/offset-rotate-004.html:
LayoutTests:
Add or update fuzzy data based on EWS results to support b231828.
- css3/color-filters/color-filter-color-property-list-item.html:
- css3/color-filters/color-filter-text-decoration-shadow.html:
- css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html:
- css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-remove.html:
- fast/borders/hidpi-border-radius-with-subpixel-margin-not-renderable.html:
- fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html:
- 9:46 AM Changeset in webkit [289547] by
-
- 6 edits in trunk/Source/WebCore
[macOS] Support both versions of ScreenCaptureKit API
https://bugs.webkit.org/show_bug.cgi?id=236422
<rdar://problem/88726849>
Reviewed by Youenn Fablet.
Source/WebCore:
Tested manually.
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(-[WebCoreScreenCaptureKitHelper initWithCallback:]):
(-[WebCoreScreenCaptureKitHelper stream:didOutputSampleBuffer:ofType:]):
(WebCore::ScreenCaptureKitCaptureSource::ScreenCaptureKitCaptureSource):
(WebCore::ScreenCaptureKitCaptureSource::stop):
(WebCore::ScreenCaptureKitCaptureSource::streamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
(WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::frameAvailableHandler):
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputSampleBuffer):
(WebCore::ScreenCaptureKitCaptureSource::captureQueue):
Source/WebCore/PAL:
- pal/mac/ScreenCaptureKitSoftLink.h:
- pal/mac/ScreenCaptureKitSoftLink.mm:
- 9:44 AM Changeset in webkit [289546] by
-
- 17 edits1 copy1 add18 deletes in trunk/LayoutTests
Resync web-platform-tests/url from upstream
https://bugs.webkit.org/show_bug.cgi?id=236377
Reviewed by Youenn Fablet.
Resync web-platform-tests/url from upstream 012f446eafc392c7.
- web-platform-tests/url/*: Updated.
- 9:42 AM Changeset in webkit [289545] by
-
- 7 edits27 copies73 moves88 adds16 deletes in trunk/LayoutTests
Resync web-platform-tests/eventsource from upstream
https://bugs.webkit.org/show_bug.cgi?id=236374
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Resync web-platform-tests/eventsource from upstream 012f446eafc392c7.
- web-platform-tests/eventsource/*: Updated.
LayoutTests:
- TestExpectations:
- platform/glib/TestExpectations:
- 9:37 AM Changeset in webkit [289544] by
-
- 11 edits1 add in trunk
An element with both -webkit-user-select: all and -webkit-user-drag: element does not get the nice drag snapshot that you get if you just have -webkit-user-drag: element
https://bugs.webkit.org/show_bug.cgi?id=187656
<rdar://problem/42177956>
Reviewed by Wenson Hsieh.
Source/WebCore:
When dragging an element with "-webkit-user-select: all" and
"-webkit-user-drag: element", the element gets selected, leading
WebKit to addDragSourceAction::Selectionto the set of
DragSourceActions. The presence of "-webkit-user-drag: element"
results in the addition ofDragSourceAction::DHTML.
The addition of
DragSourceAction::Selectionin the
"-webkit-user-drag: element" scenario is undesirable, as
it results in a drag snapshot containing only the selection, and
copies/pastes the text selection, rather than moving the element.
To fix, drop
DragSourceAction::Selectionfrom the set of actions
when a "-webkit-user-drag: element" element is being dragged.
The new behavior matches Firefox and Chrome.
- page/DragController.cpp:
(WebCore::DragController::draggableElement const):
(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):
- platform/DragItem.h:
Dropping
DragSourceAction::Selectionexposes an issue in the
UIProcess on iOS, where UIKit text interaction can unexpectedly
begin while dragging an element with "-webkit-user-drag: element".
To fix the WebProcess behavior, while keeping the UIProcess behavior
the same, a new bit is added toDragItemto indicate that the
element being dragged contains the selection. The UIProcess will use
this bit to suppress UIKit text interaction.
(WebCore::DragItem::encode const):
(WebCore::DragItem::decode):
Source/WebKit:
Plumb
DragItem'scontainsSelectioninto theDragDropInteractionState
so that UIKit text interaction can be suppressed whenever the element
being dragged also contains the current selection.
- UIProcess/ios/DragDropInteractionState.h:
- UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::anyActiveDragSourceContainsSelection const):
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::anyActiveDragSourceIs const): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
Tools:
Added API tests on iOS and macOS to verify that dragging and dropping an
element with "-webkit-user-select: all" and "-webkit-user-drag: element"
does not paste the selection.
On iOS, the size of the lift preview is also tested.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/contenteditable-user-select-user-drag.html: Added.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
(TEST):
- 9:35 AM Changeset in webkit [289543] by
-
- 2 edits in trunk/LayoutTests
Mark accessibility/mac/line-index-for-textmarker.html as Slow in Mac-wk2 Debug.
https://bugs.webkit.org/show_bug.cgi?id=236448
<rdar://problem/88757785>
Unreviewed gardening.
- platform/mac-wk2/TestExpectations:
- 9:28 AM Changeset in webkit [289542] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Prepare InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox for supporting vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=236400
Reviewed by Antti Koivisto.
This is just a small cleanup patch to make the vertical writing mode code easier to adopt.
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
- 9:04 AM Changeset in webkit [289541] by
-
- 5 edits in trunk/Source/WebKit
Mail attachment switched to TIFF and balloons in size after markup.
https://bugs.webkit.org/show_bug.cgi?id=236405
rdar://87358910
Reviewed by Wenson Hsieh.
When pulling data from the webprocess to pass to the Sharing Service
for markup, we would convert it to TIFF format. This would cause files
to increase in size, and lose their original formatting, as well as outright
break PDFs. Instead we should be pulling the data from the attachment, which
already exists in the UI process and is the source of truth for that data anyways.
This allows us to give the correct type to the sharing service, and we should
take the data back as the same original type when getting the data back from
markup.
- UIProcess/API/APIAttachment.cpp:
(API::Attachment::enclosingImageData const):
- UIProcess/API/APIAttachment.h:
- UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::enclosingImageNSData const):
- UIProcess/mac/WKSharingServicePickerDelegate.mm:
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
- 9:02 AM Changeset in webkit [289540] by
-
- 39 edits1 copy12 moves108 adds61 deletes in trunk/LayoutTests
Resync web-platform-tests/xhr from upstream
https://bugs.webkit.org/show_bug.cgi?id=236372
Reviewed by Youenn Fablet.
Resync web-platform-tests/xhr from upstream 012f446eafc392c7.
- web-platform-tests/xhr/*: Updated.
- 8:54 AM Changeset in webkit [289539] by
-
- 7 edits4 deletes in trunk/LayoutTests
Resync web-platform-tests/webaudio from upstream
https://bugs.webkit.org/show_bug.cgi?id=236373
Reviewed by Youenn Fablet.
Resync web-platform-tests/webaudio from upstream 012f446eafc392c7.
- web-platform-tests/webaudio/idlharness.https-expected.txt: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test-expected.txt: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/idl-test.html: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audiodestinationnode-interface/w3c-import.log: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-expected.txt: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-large-endtime-expected.txt: Removed.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-sharedarraybuffer.https-expected.txt: Removed.
- web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-routing-expected.txt: Removed.
- 8:38 AM Changeset in webkit [289538] by
-
- 2 edits in trunk/Source/WebCore
AX: Log more information when the wrapper or the wrapper's backing object is detached
https://bugs.webkit.org/show_bug.cgi?id=236381
Reviewed by Chris Fleizach.
Right now, we don't log any information when we detect a wrapper has
no object, or when it does have an object but it's detached from a
parent.
This patch logs the wrapper address and object in these scenarios, which
will help debug these issues in conjuction with other logs.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper logMissingBackingObject]):
Added.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Use new logMissingBackingObject, and log object if it's detached from a parent.
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
Use new logMissingBackingObject.
- 8:36 AM Changeset in webkit [289537] by
-
- 3 edits in trunk/Source/WebCore
AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges results in adding incorrect nodes to the isolated tree
https://bugs.webkit.org/show_bug.cgi?id=236414
Reviewed by Andres Gonzalez.
Sometimes AXIsolatedTree::updateChildren is called with an object that is
not in the isolated tree. When this happens, we currently call AXIsolatedTree::nodeAncestryChanges
to build the ancestry chain up to the nearest in-isolated-tree node (starting with the original
object called for updateChildren).
However, this seems to result in adding nodes to the isolated tree that don't exist in the live tree.
I believe this also causes isolated objects to often hold references to parent objects that don't exist
in the isolated tree, breaking object searches (and more).
With this patch, when AXIsolatedTree::updateChildren is called with an object that has no isolated tree
equivalent, we traverse up the object's ancestry until we find an object in the isolated tree and update
the children for that.
This was the behavior before https://bugs.webkit.org/show_bug.cgi?id=235389. We made that change because
we believed this behavior was causing a lot of full-tree re-renders. However, in my testing on large webpages
(e.g. youtube.com, facebook.com), this doesn't seem to be the case, and performance is actually very good.
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::nodeAncestryChanges):
Deleted.
(WebCore::AXIsolatedTree::nodeChangeForObject):
Remove updateNodeMap parameter, as the now-deleted nodeAncestryChanges
was the only thing that called it with the non-default value of true.
- accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::queueChangesAndRemovals):
- 8:21 AM Changeset in webkit [289536] by
-
- 6 edits in trunk
Do not expose in WebIDL the parts of the permission API that are not yet supported
https://bugs.webkit.org/show_bug.cgi?id=236301
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/permissions/idlharness.any-expected.txt:
- web-platform-tests/permissions/idlharness.any.worker-expected.txt:
Source/WebCore:
Covered by existing tests.
- Modules/permissions/PermissionStatus.idl:
- Modules/permissions/Permissions.idl:
- 7:56 AM Changeset in webkit [289535] by
-
- 3 edits in trunk/Tools
Unreviewed, reverting 247040@main.
https://bugs.webkit.org/show_bug.cgi?id=236399
<rdar://problem/88707207>
Broke EWS links after merging.
Reverted changeset:
[EWS] Link commit URL to pull request
https://bugs.webkit.org/show_bug.cgi?id=236399
<rdar://problem/88707207>
- 7:49 AM Changeset in webkit [289534] by
-
- 4 edits in trunk
Check for feature policy when querying permission state
https://bugs.webkit.org/show_bug.cgi?id=236299
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/permissions/permissions-query-feature-policy-attribute.https.sub-expected.txt:
Source/WebCore:
Added feature policy check for camera, microphone and geolocation, which after https://bugs.webkit.org/show_bug.cgi?id=236292
are the only one returning anything else than NotSupported.
Covered by updated test.
- Modules/permissions/Permissions.cpp:
(WebCore::isAllowedByFeaturePolicy):
(WebCore::Permissions::query):
- 7:45 AM Changeset in webkit [289533] by
-
- 6 edits2 adds in trunk
Settling of a fetch promise should be delayed in case page is entering page cache
https://bugs.webkit.org/show_bug.cgi?id=236292
<rdar://88452971>
Reviewed by Chris Dumez.
Source/WebCore:
Make sure to enqueue a task before resolving fetch promise as otherwise, page might continue running JavaScript.
Do this for worker as well for good measure.
We move signal aborted checks to two clients to handle rejecting fetch promise synchronously.
Test: http/tests/navigation/fetch-pagecache.html
- Modules/cache/DOMCache.cpp:
- Modules/fetch/FetchResponse.cpp:
- Modules/fetch/FetchResponse.h:
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:
- workers/service/FetchEvent.cpp:
LayoutTests:
- http/tests/navigation/fetch-pagecache-expected.txt: Added.
- http/tests/navigation/fetch-pagecache.html: Added.
- 7:33 AM Changeset in webkit [289532] by
-
- 5 edits in trunk
Fail synchronously when constructing a SharedWorker with an URL that is not same-origin
https://bugs.webkit.org/show_bug.cgi?id=236419
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/workers/constructors/SharedWorker/same-origin-expected.txt:
Rebaseline test that is now fully passing. I have verified that it is passing in both
Blink and Gecko too.
- web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.txt:
Even though this looks like a regression, this actually aligns our behavior with both
Blink & Gecko (who also fail this check). Note that the load fails no matter what.
However, the test expects it to fail asynchronously instead of synchronously in this
case.
Source/WebCore:
Fail synchronously when constructing a SharedWorker with an URL that is not same-origin.
This aligns our behavior with Chrome and matches the language in the specification.
No new tests, rebaselined existing test.
- workers/shared/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- 6:52 AM WebKitGTK/2.34.x edited by
- (diff)
- 6:46 AM Changeset in webkit [289531] by
-
- 20 edits4 adds in trunk/Source
Introduce SignedPtrTraits which enables Ref pointers to be protected with PtrTags.
https://bugs.webkit.org/show_bug.cgi?id=235588
rdar://88023849
Patch by Gavin Phillips <gavin.p@apple.com> on 2022-02-10
Reviewed by Mark Lam.
Create and adopt SignedPtrTraits which can be used to apply and verify PtrTag signatures
to pointers stored in and tracked by WTF:Ref.
Source/WebCore:
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::wrapped const):
(WebCore::JSDOMWrapper::offsetOfWrapped):
(WebCore::JSDOMWrapper::hasCustomPtrTraits):
- bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GetImplClassPtrTag):
(GenerateHeader):
(GetTaggedWrapperForInterface):
- bindings/scripts/IDLAttributes.json:
- bindings/scripts/test/BindingTestGlobalConstructors.idl:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObject_TestTaggedWrapperConstructorGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
- bindings/scripts/test/JS/JSTestTaggedWrapper.cpp: Added.
(WebCore::JSTestTaggedWrapperDOMConstructor::prototypeForStructure):
(WebCore::JSTestTaggedWrapperDOMConstructor::initializeProperties):
(WebCore::JSTestTaggedWrapperPrototype::finishCreation):
(WebCore::JSTestTaggedWrapper::JSTestTaggedWrapper):
(WebCore::JSTestTaggedWrapper::finishCreation):
(WebCore::JSTestTaggedWrapper::createPrototype):
(WebCore::JSTestTaggedWrapper::prototype):
(WebCore::JSTestTaggedWrapper::getConstructor):
(WebCore::JSTestTaggedWrapper::destroy):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::JSTestTaggedWrapper::subspaceForImpl):
(WebCore::JSTestTaggedWrapper::analyzeHeap):
(WebCore::JSTestTaggedWrapperOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestTaggedWrapperOwner::finalize):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSTestTaggedWrapper::toWrapped):
- bindings/scripts/test/JS/JSTestTaggedWrapper.h: Added.
(WebCore::JSTestTaggedWrapper::create):
(WebCore::JSTestTaggedWrapper::createStructure):
(WebCore::JSTestTaggedWrapper::subspaceFor):
(WebCore::wrapperOwner):
(WebCore::wrapperKey):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):
- bindings/scripts/test/SupplementalDependencies.dep:
- bindings/scripts/test/TestTaggedWrapper.idl: Added.
- css/DOMMatrixReadOnly.idl:
- dom/DOMPointReadOnly.idl:
- dom/DOMQuad.idl:
- dom/DOMRectReadOnly.idl:
- domjit/JSDocumentDOMJIT.cpp:
(WebCore::compileDocumentDocumentElementAttribute):
(WebCore::compileDocumentBodyAttribute):
- domjit/JSNodeDOMJIT.cpp:
(WebCore::createCallDOMGetterForOffsetAccess):
(WebCore::compileNodeOwnerDocumentAttribute):
- html/TimeRanges.idl:
- html/canvas/OffscreenCanvasRenderingContext2D.idl:
- html/canvas/PaintRenderingContext2D.idl:
- svg/SVGMatrix.idl:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/SignedPtr.h: Added.
(WTF::SignedPtr::SignedPtr):
(WTF::SignedPtr::get const):
(WTF::SignedPtr::set):
(WTF::SignedPtr::clear):
(WTF::SignedPtr::operator-> const):
(WTF::SignedPtr::operator* const):
(WTF::SignedPtr::operator! const):
(WTF::SignedPtr::operator UnspecifiedBoolType const):
(WTF::SignedPtr::operator bool const):
(WTF::SignedPtr::operator=):
(WTF::SignedPtr::exchange):
(WTF::SignedPtr::swap):
(WTF::SignedPtrTraits::exchange):
(WTF::SignedPtrTraits::swap):
(WTF::SignedPtrTraits::unwrap):
(WTF::SignedPtrTraits::hashTableDeletedValue):
(WTF::SignedPtrTraits::isHashTableDeletedValue):
- 6:23 AM Changeset in webkit [289530] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Add InInlineDirection postfix to margin/border/paddingLeft(Right)
https://bugs.webkit.org/show_bug.cgi?id=236398
Reviewed by Antti Koivisto.
This helps to make sure we don't confuse _visual_ border left and border left in the inline base direction sense
(i.e. logical left can turn into a "visual" right in the inline base direction context (RTL) which can turn into a final physical bottom after the writing mode flip)
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::marginLeftInInlineDirection):
(WebCore::Layout::marginRightInInlineDirection):
(WebCore::Layout::borderLeftInInlineDirection):
(WebCore::Layout::borderRightInInlineDirection):
(WebCore::Layout::paddingLeftInInlineDirection):
(WebCore::Layout::paddingRightInInlineDirection):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::marginLeft): Deleted.
(WebCore::Layout::marginRight): Deleted.
(WebCore::Layout::borderLeft): Deleted.
(WebCore::Layout::borderRight): Deleted.
(WebCore::Layout::paddingLeft): Deleted.
(WebCore::Layout::paddingRight): Deleted.
- 6:14 AM Changeset in webkit [289529] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Scrollbars painted incorrectly if theme enables steppers (steppers misplaced on vertical scrollbars, horizontal scrollbars very broken)
https://bugs.webkit.org/show_bug.cgi?id=234871
Reviewed by Carlos Garcia Campos.
Actually use the scrollbar orientation when creating its contents,
instead of always using vertical.
- platform/gtk/RenderThemeScrollbar.cpp:
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
- 5:54 AM Changeset in webkit [289528] by
-
- 10 edits1 copy1 add in trunk/Source
[GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
https://bugs.webkit.org/show_bug.cgi?id=236437
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Make accessibility bus address API available for ATK too.
- platform/graphics/PlatformDisplay.cpp:
- platform/graphics/PlatformDisplay.h:
- platform/graphics/x11/PlatformDisplayX11.cpp:
- platform/graphics/x11/PlatformDisplayX11.h:
Source/WebKit:
This patch moves the XDGDBusProxy launcher implementation to its own file and fixes the following issues:
- r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need to ensure we only bind the original socket for the a11y socket and not the session bus one.
- bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
- The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XXXXXX, it helps to use a different one.
- The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the PlatformDisplay to get the address.
- SourcesGTK.txt:
- SourcesWPE.txt:
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::argumentsToFileDescriptor):
(WebKit::bindDBusSession):
(WebKit::bindA11y):
(WebKit::bubblewrapSpawn):
(WebKit::argsToFd): Deleted.
(WebKit::XDGDBusProxyLauncher::setAddress): Deleted.
(WebKit::XDGDBusProxyLauncher::isRunning const): Deleted.
(WebKit::XDGDBusProxyLauncher::path const): Deleted.
(WebKit::XDGDBusProxyLauncher::proxyPath const): Deleted.
(WebKit::XDGDBusProxyLauncher::setPermissions): Deleted.
(WebKit::XDGDBusProxyLauncher::launch): Deleted.
(WebKit::XDGDBusProxyLauncher::makeProxyPath): Deleted.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Deleted.
(): Deleted.
- UIProcess/Launcher/glib/BubblewrapLauncher.h:
- UIProcess/Launcher/glib/XDGDBusProxy.cpp: Added.
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::makeProxy const):
(WebKit::XDGDBusProxy::launch const):
- UIProcess/Launcher/glib/XDGDBusProxy.h: Added.
(WebKit::XDGDBusProxy::proxyPath const):
(WebKit::XDGDBusProxy::path const):
- 5:50 AM WebKitGTK/2.34.x edited by
- (diff)
- 5:02 AM Changeset in webkit [289527] by
-
- 3 edits2 adds in trunk
Incorrect abspos layout when toggling contain
https://bugs.webkit.org/show_bug.cgi?id=236261
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-10
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-layout-020-expected.html: Added.
- web-platform-tests/css/css-contain/contain-layout-020.html: Added.
Source/WebCore:
A change in layout containment for a container means either the container becomes
a absolute positioning containing block or ceases to be one. The method
removePositionedObjectsIfNeeded handles this, update it to take layout containment
changes into account.
Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-020.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
- 3:10 AM Changeset in webkit [289526] by
-
- 6 edits2 adds in trunk
[:has() pseudo-class] Nullptr crash with non-function :has
https://bugs.webkit.org/show_bug.cgi?id=236431
rdar://87061239
Reviewed by Cameron McCormack.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/parsing/parse-has-expected.txt:
- web-platform-tests/css/selectors/parsing/parse-has.html:
Source/WebCore:
Test: fast/selectors/malformed-has.html
- css/parser/CSSSelectorParser.cpp:
(WebCore::isOnlyPseudoClassFunction):
:has() is legal, plain :has is not.
LayoutTests:
- fast/selectors/malformed-has-expected.txt: Added.
- fast/selectors/malformed-has.html: Added.
- 2:36 AM Changeset in webkit [289525] by
-
- 42 edits3 copies8 adds in trunk
Introduce a RemoteMediaSampleProxy to represent captured video frames used in Media Streams and present in GPUP
https://bugs.webkit.org/show_bug.cgi?id=236099
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-10
Reviewed by Youenn Fablet.
Source/WebCore:
Add VideoFrame : public MediaStream, base class for Media Stream video frames.
Currently inherits from MediaSample, but later will remove the MediaSample.
The WebCore::VideoFrame is intended to be used in various entry-points that
currently are currently typed as:
void videoSampleAvailable(MediaSample&, VideoSampleMetadata, ...).
The new class WebKit::RemoteVideoFrameProxy : public VideoFrame can be passed to these APIs.
The API entrypoints are not yet changed in order to partially roll the changes in.
Later on, the entrypoints will be similar to:
void videoSampleAvailable(VideoFrame&, VideoSampleMetadata, ...).
Removes MediaSample::setTrackID as that is not used.
Changes MediaSample::platformSample() to const, so that it can be called from
const context.
No new tests, refactor.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/MediaSample.h:
- platform/VideoFrame.cpp: Added.
(WebCore::VideoFrame::decodeTime const):
(WebCore::VideoFrame::duration const):
(WebCore::VideoFrame::trackID const):
(WebCore::VideoFrame::sizeInBytes const):
(WebCore::VideoFrame::presentationSize const):
(WebCore::VideoFrame::offsetTimestampsBy):
(WebCore::VideoFrame::setTimestamps):
(WebCore::VideoFrame::isDivisable const):
(WebCore::VideoFrame::divide):
(WebCore::VideoFrame::createNonDisplayingCopy const):
(WebCore::VideoFrame::flags const):
(WebCore::VideoFrame::byteRange const):
(WebCore::VideoFrame::dump const):
- platform/VideoFrame.h: Added.
- platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::enqueueSampleBuffer):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateCurrentFrameImage):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
(isType):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::platformSample const):
- platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::platformSample const):
- platform/graphics/gstreamer/MediaSampleGStreamer.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockMediaSample::platformSample const):
Source/WebKit:
WebContent process:
Add WebKit::RemoteVideoFrameProxy, WebContent process side proxy object that
WebCore::MediaPlayerPrivateMediaStreamAVFObjC can use.
RemoteVideoFrameProxy can be sent to the GPUP and the the SampleBufferDisplayLayer. So
the captured content shows in compositing through video element.
At the moment MediaPlayerPrivateMediaStreamAVFObjC cannot paint RemoteVideoFrameProxy to the
document CSS painted content, Context2D or WebGL canvas.
GPUP:
RemoteVideoFrameObjectHeap is a mapping
RemoteVideoFrameIdentifier -> MediaSample. Currently all objects
map to normal MediaSampleAVFObjC.
Add an example implementation where a remote MediaSample is returned by IPC:
RemoteGraphicsContextGL::paintCompositedResultsToMediaSample().
The GPUP object pointed by RemoteVideoFrameIdentifier is:
- created in RemoteGraphicsContextGL::paintCompositedResultsToMediaSample() in RemoteGraphicsContextGL thread
- consumed in RemoteSampleBufferDisplayLayer::enqueueSample in RemoteSampleBufferDisplayLayerManager thread
- released in RemoteVideoFrameObjectHeap::releaseVideoFrame in GPUP main thread
All of these messages are asynchronous and can arrive to their destination in any order.
For example, request to release the video frame can happen before the message to create the video frame has been
received.
To solve the ordering issue, introduce readers-writers reference counting method via following classes:
- ObjectIdentifierReadReference
- ObjectIdentifierWriteReference
- ObjectIdentifierReferenceTracker
ObjectIdentifier identifies the object.
ObjectIdentifierWriteReference identifies a new version of the content pointed by the identifier.
Pseudocode examples:
WriteReference { identifier = 1, pendingReads = 0, version = 0 } means:
"End the life-time of identifier 1, version 0. Create version = 1"
This is how initial object is assigned to the reference.
WriteReference { identifier = 1, pendingReads = 77, version = 32 } means
"End the life-time of identifier 1, version 32 when all 77 reads have completed. Create version = 33"
ObjectIdentifierReadReference declares a read dependency to a specific version of the content pointed by the identifier.
Pseudocode examples:
ReadReference { identifier = 1, version = 32 } means
"Complete one read of identifier 1, version 32".
Creates, updates and destructions are WriteReferences.
Reads are ReadReferences.
The ObjectIdentifierReferenceTracker creates write and read references in the Proxy -using process (WebContent process).
The added ThreadSafeObjectHeap resolves the read and write references in the real object process (GPUP in this case).
Reads and writes are blocking the requesting thread appropriately:
- Read of unknown version of the identifier blocks until the write creates the version
- Write of new version of the identifier blocks until the reads have retired, or creates parallel, new version of the content in case of copy-on-write schemes.
In this commit objects pointed by RemoteVideoFrameIdentifier are immutable until destroyed, so there is no update or
copy-on-write scheme here.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::videoFrameObjectHeap const):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::RemoteGraphicsContextGL):
(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToMediaSample):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp: Added.
(WebKit::RemoteVideoFrameObjectHeap::create):
(WebKit::RemoteVideoFrameObjectHeap::RemoteVideoFrameObjectHeap):
(WebKit::RemoteVideoFrameObjectHeap::~RemoteVideoFrameObjectHeap):
(WebKit::RemoteVideoFrameObjectHeap::stopListeningForIPC):
(WebKit::RemoteVideoFrameObjectHeap::addVideoFrame):
(WebKit::RemoteVideoFrameObjectHeap::releaseVideoFrame):
- GPUProcess/media/RemoteVideoFrameObjectHeap.h: Added.
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in: Copied from Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in.
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::create):
(WebKit::RemoteSampleBufferDisplayLayer::RemoteSampleBufferDisplayLayer):
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSample):
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSampleCV):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
- Shared/IPCTester.cpp:
(WebKit::IPCTester::startMessageTesting):
(WebKit::isTestingIPC):
- Shared/IPCTester.h:
(WebKit::isTestingIPC):
- Shared/ObjectIdentifierReferenceTracker.h: Added.
(WebKit::ObjectIdentifierReference::ObjectIdentifierReference):
(WebKit::ObjectIdentifierReference::identifier const):
(WebKit::ObjectIdentifierReference::version const):
(WebKit::ObjectIdentifierReference::operator== const):
(WebKit::ObjectIdentifierReference::isHashTableDeletedValue const):
(WebKit::ObjectIdentifierReadReference::ObjectIdentifierReadReference):
(WebKit::ObjectIdentifierReadReference::identifier const):
(WebKit::ObjectIdentifierReadReference::version const):
(WebKit::ObjectIdentifierReadReference::reference const):
(WebKit::ObjectIdentifierReadReference::encode const):
(WebKit::ObjectIdentifierReadReference::decode):
(WebKit::ObjectIdentifierWriteReference::ObjectIdentifierWriteReference):
(WebKit::ObjectIdentifierWriteReference::identifier const):
(WebKit::ObjectIdentifierWriteReference::version const):
(WebKit::ObjectIdentifierWriteReference::pendingReads const):
(WebKit::ObjectIdentifierWriteReference::reference const):
(WebKit::ObjectIdentifierWriteReference::retire const):
(WebKit::ObjectIdentifierWriteReference::encode const):
(WebKit::ObjectIdentifierWriteReference::decode):
(WebKit::ObjectIdentifierReferenceTracker::ObjectIdentifierReferenceTracker):
(WebKit::ObjectIdentifierReferenceTracker::read const):
(WebKit::ObjectIdentifierReferenceTracker::write const):
(WebKit::ObjectIdentifierReferenceTracker::identifier const):
(WebKit::add):
(WebKit::operator<<):
(WTF::DefaultHash<WebKit::ObjectIdentifierReference<T>>::hash):
(WTF::DefaultHash<WebKit::ObjectIdentifierReference<T>>::equal):
- Shared/ThreadSafeObjectHeap.h: Added.
(WebKit::ThreadSafeObjectHeap::ReferenceState::ReferenceState):
(WebKit::HeldType>::retire):
(WebKit::HeldType>::retireRemove):
(WebKit::HeldType>::clear):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::platformSample const):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.h:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.cpp:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToMediaSample):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:
- WebProcess/GPU/media/RemoteVideoFrameIdentifier.h: Copied from Source/WebKit/Shared/IPCTester.h.
- WebProcess/GPU/media/RemoteVideoFrameProxy.cpp: Added.
(WebKit::RemoteVideoFrameProxy::create):
(WebKit::RemoteVideoFrameProxy::properties):
(WebKit::RemoteVideoFrameProxy::RemoteVideoFrameProxy):
(WebKit::RemoteVideoFrameProxy::~RemoteVideoFrameProxy):
(WebKit::RemoteVideoFrameProxy::identifier const):
(WebKit::RemoteVideoFrameProxy::write const):
(WebKit::RemoteVideoFrameProxy::read const):
(WebKit::RemoteVideoFrameProxy::presentationTime const):
(WebKit::RemoteVideoFrameProxy::platformSample const):
(WebKit::RemoteVideoFrameProxy::videoRotation const):
(WebKit::RemoteVideoFrameProxy::videoMirrored const):
(WebKit::RemoteVideoFrameProxy::videoPixelFormat const):
(WebKit::RemoteVideoFrameProxy::videoFrame const):
(WebKit::RemoteVideoFrameProxy::disconnectGPUProcessIfNeeded const):
(WebKit::RemoteVideoFrameProxy::waitForWasInitialized const):
(WebKit::RemoteVideoFrameProxy::gpuProcessConnectionDidClose):
(WebKit::RemoteVideoFrameProxy::wasInitialized):
- WebProcess/GPU/media/RemoteVideoFrameProxy.h: Added.
(WebKit::RemoteVideoFrameProxy::Properties::encode const):
(WebKit::RemoteVideoFrameProxy::Properties::decode):
(isType):
- WebProcess/GPU/media/RemoteVideoFrameProxy.messages.in: Copied from Source/WebKit/Shared/IPCTester.h.
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::~SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::enqueueSample):
(WebKit::SampleBufferDisplayLayer::gpuProcessConnectionDidClose):
(WebKit::SampleBufferDisplayLayer::disconnectGPUProcessConnectionIfNeeded):
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
Tools:
- Scripts/generate-gpup-webgl:
- TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
- 1:27 AM Changeset in webkit [289524] by
-
- 3 edits in trunk/Source/WebKit
Non-default constructible types cannot be decoded with IPC::Decoder
https://bugs.webkit.org/show_bug.cgi?id=236246
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-10
Reviewed by Antti Koivisto.
Add yet another decode function: std::optional<T> Decoder::decode<T>();
Consider the pattern:
std::optional<T> t;
decoder >> t;
if (!t)
....
The above neccessitates default construction of T, since it contains
std::optional<T> t;
t = ...; assignment. This assignment cannot be elided.
Better pattern is:
auto t = decoder.decode<T>();
This is significant with for types with const members:
struct T {
const uint64_t version;
};
- Platform/IPC/Decoder.h:
(IPC::Decoder::decode):
(IPC::Decoder::operator>>):
- Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageWantsConnection):
(IPC::handleMessageSynchronous):
(IPC::handleMessageSynchronousWantsConnection):
(IPC::handleMessageAsync):
(IPC::handleMessageAsyncWantsConnection):
- 1:07 AM Changeset in webkit [289523] by
-
- 15 edits in trunk/LayoutTests
[macOS arm64] imported/w3c/web-platform-tests/css/css-transforms/perspective-transforms-equivalence.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=235084
<rdar://problem/87421733>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Update pixel tolerances for some tests from the WPT transforms suite,
fixing them on Mac and on Glib-based ports.
- web-platform-tests/css/css-transforms/2d-rotate-001.html:
- web-platform-tests/css/css-transforms/group/svg-transform-nested-009.html:
- web-platform-tests/css/css-transforms/perspective-transforms-equivalence.html:
- web-platform-tests/css/css-transforms/preserve3d-and-filter-with-perspective.html:
- web-platform-tests/css/css-transforms/skew-test1.html:
- web-platform-tests/css/css-transforms/transform-background-001.html:
- web-platform-tests/css/css-transforms/transform-background-002.html:
- web-platform-tests/css/css-transforms/transform-table-009.html:
- web-platform-tests/css/css-transforms/transform-table-010.html:
- web-platform-tests/css/css-transforms/transform-table-011.html:
- web-platform-tests/css/css-transforms/transforms-skewX.html:
LayoutTests:
- platform/glib/TestExpectations: Unskip newly passing tests.
- platform/mac/TestExpectations: Ditto.
- 12:17 AM Changeset in webkit [289522] by
-
- 4 edits in trunk/Source/WebCore
IDBRequest should emit write barrier on JSValueInWrappedObject modification
https://bugs.webkit.org/show_bug.cgi?id=236278
Reviewed by Geoffrey Garen.
In IDBRequest, m_resultWrapper is used to cache JSValue for m_result. When request is performing operation (e.g.
iterating cursor), we clear both m_result and m_resultWrapper. When request is done, we set m_result and
m_resultWrapper. The spec requires the IDBRequest.result() to return the same JavaScript object after operation,
so we introduced m_cursorWrapper to temporarily store the JSValue during operation. When operation starts, we
set m_cursorWrapper with m_resultWrapper and when opreation finishes successfully, we set m_resultWrapper back
using m_cursorWrapper.
This has a semantic error as the assignment process does not emit write barrier (webkit.org/b/236277). To fix
it, we may just remove m_cursorWrapper and not clear m_resultWrapper during operation. Since we clear m_result
in operation, we can check if m_result is empty to decide whether we should return m_resultWrapper for
IDBRequest.result().
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBRequest::clearWrappers):
- Modules/indexeddb/IDBRequest.h:
(WebCore::IDBRequest::resultWrapper):
(WebCore::IDBRequest::cursorWrapper): Deleted.
- bindings/js/JSIDBRequestCustom.cpp:
(WebCore::JSIDBRequest::result const):
(WebCore::JSIDBRequest::visitAdditionalChildren):
- 12:10 AM Changeset in webkit [289521] by
-
- 4 edits2 adds in trunk
:focus-visible with click on radio/checkbox labels is broken
https://bugs.webkit.org/show_bug.cgi?id=236331
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Added new WPT test to cover this case.
- web-platform-tests/css/selectors/focus-visible-026-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-026.html: Added.
Source/WebCore:
When the label is clicked we have to send the FocusTrigger information to Element::focus().
There we avoid setting FocusVisibility:Visible if it has been triggered via mouse click.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html
- dom/Element.cpp:
(WebCore::Element::focus): Add a check for FocusTrigger::Click to avoid setting FocusVisibility:Visible.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler): Pass FocusTrigger::Click.
Feb 9, 2022:
- 11:44 PM Changeset in webkit [289520] by
-
- 2 edits18 deletes in trunk/LayoutTests
[WPE] Mark several WPT SVG import filter tests as failure
Unreviewed test gardening.
r289510 updated the baselines of these tests, but this was not the
right fix. These tests were passing in WPE until r288412. The tests
should be marked as a failure in WPE TestExpectations.
- platform/wpe/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-04-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-04-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-05-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-05-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-conv-03-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-conv-03-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-01-b-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-01-b-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-02-b-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-02-b-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-03-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-03-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-04-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-04-f-manual-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-05-f-manual-expected.png: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-05-f-manual-expected.txt: Removed.
- 10:00 PM Changeset in webkit [289519] by
-
- 4 edits in trunk
SharedMemoryUnix should use SHM_ANON when available
https://bugs.webkit.org/show_bug.cgi?id=236416
Reviewed by Don Olmstead.
.:
- Source/cmake/OptionsCommon.cmake: Check for SHM_ANON.
Source/WebKit:
FreeBSD is able to use shm_open(SHM_ANON, ...) to create an anonymous shared memory object which is subject to RAII:
https://www.freebsd.org/cgi/man.cgi?query=shm_open
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::createSharedMemory):
Make use of SHM_ANON if we have it.
- 9:18 PM Changeset in webkit [289518] by
-
- 42 edits in trunk/Source
[GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and SVGRenderingContext::createImageBuffer to GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=235758
rdar://88478470
Reviewed by Simon Fraser.
Source/WebCore:
The goal of this patch is to record the drawing if the concrete type of
the GraphicsContext is RemoteDisplayListRecorderProxy. Currently all the
intermediate compatible ImageBuffers are of type ConcreteImageBuffer.
The drawing to these ImageBuffers still happens in the WebProcess. Moreover
when we call drawImageBuffer() or clipToImageBuffer() for one of these
intermediate ImageBuffers to a remote ImageBuffer, we have to sink the
intermediate ImageBuffer to a NativeImage and send it to GPUProcess.
To fix this, the new enum 'RenderingMethod' will be used when creating
the ImageBuffer methods. The value of RenderingMethod can be one of the
following constants:
- Default: The type of the created ImageBuffer will match the type of the underlying ImageBuffer of the GraphicsContext.
- DisplayList: A DisplayList::ImageBuffer will be created whose GraphicsContext will be of type DisplayList::RecorderImpl.
- Local: The ImageBuffer will be of type ConcreteImageBuffer and it will hold a platform GraphicsContext.
Also GraphicsContext will provide these functions for creating an
ImageBuffer:
- GraphicsContext::createImageBuffer() (virtual): Creates a ConcreteImageBuffer or a DisplayList::ImageBuffer. The type of the created ImageBuffer is controlled by the argument 'renderingMethod'. Because RemoteDisplayListRecorderProxy is a super class of GraphicsContext, it overrides this method and returns the desired RemoteImageBuffer. RemoteDisplayListRecorderProxy has access to RemotRenderingBackendProxy so it can call its createImageBuffer().
- GraphicsContext::createImageBuffer() (non-virtual): Creates a scaled ImageBuffer and sets the context accordingly. The type of the created ImageBuffer is controlled by the argument 'renderingMethod'.
- GraphicsContext::createCompatibleImageBuffer() (virtual): Takes the scaleFactor() into consideration when creating the ImageBuffer. RemoteDisplayListRecorderProxy will override this function to return an Unaccelerated ImageBuffer if 'renderingMethod != Default'. This is to ensure that for GPUProcess drawing, no intermediate local ImageBuffers will draw to an IOSurface in WebProcess.
Two versions of these functions are provided: one takes a FloatSize and
the other takes a FloatRecct. The FloatRect version expands the four
corners of the rectangle to full pixels.
- html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::replayDisplayList const):
- html/CustomPaintImage.cpp:
(WebCore::CustomPaintImage::drawPattern):
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::commitToPlaceholderCanvas):
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImage):
- platform/cocoa/ThemeCocoa.mm:
(WebCore::drawApplePayButton):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
- platform/graphics/GraphicsContext.cpp:
(WebCore::scaledImageBufferSize):
(WebCore::scaledImageBufferRect):
(WebCore::clampingScaleForImageBufferSize):
(WebCore::GraphicsContext::compatibleImageBufferSize const):
(WebCore::GraphicsContext::createImageBuffer const):
(WebCore::GraphicsContext::createCompatibleImageBuffer const):
(WebCore::GraphicsContext::clipToDrawingCommands):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::createImageBuffer):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::clone const):
(WebCore::ImageBuffer::createCompatibleBuffer): Deleted.
(WebCore::ImageBuffer::compatibleBufferSize): Deleted.
(WebCore::ImageBuffer::compatibleBufferInfo): Deleted.
(WebCore::ImageBuffer::copyRectToBuffer): Deleted.
- platform/graphics/ImageBuffer.h:
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
- platform/graphics/RenderingMode.h:
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
(WebCore::PDFDocumentImage::draw):
- platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::drawOTSVGRun):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::createImageBuffer const):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::applyItem):
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
- rendering/RenderLayerBacking.cpp:
(WebCore::patternForDescription):
- rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::allocateBackingStoreIfNeeded):
(WebCore::RenderLayerFilters::beginFilterEffect):
- rendering/RenderLayerFilters.h:
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintApplePayButton):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintListButtonForInput):
(WebCore::RenderThemeMac::paintProgressBar):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage const):
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):
(WebCore::SVGRenderingContext::createImageBuffer): Deleted.
(WebCore::SVGRenderingContext::clear2DRotation): Deleted.
- rendering/svg/SVGRenderingContext.h:
- svg/SVGFEImageElement.cpp:
(WebCore::scaledImageBufferRect):
(WebCore::clampingScaleForImageBufferSize):
(WebCore::createImageBuffer):
(WebCore::SVGFEImageElement::imageBufferForEffect const):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
Source/WebKit:
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::beginClipToDrawingCommands):
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::createImageBuffer const):
(WebKit::RemoteDisplayListRecorderProxy::createCompatibleImageBuffer const):
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- 8:11 PM Changeset in webkit [289517] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, non-unified build fix after r289474
https://bugs.webkit.org/show_bug.cgi?id=236425
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
- 5:50 PM Changeset in webkit [289516] by
-
- 15 edits1 copy24 adds198 deletes in trunk/LayoutTests
Resync web-platform-tests/html/browsers from upstream
https://bugs.webkit.org/show_bug.cgi?id=236370
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Resync web-platform-tests/html/browsers from upstream 012f446eafc392c7.
- web-platform-tests/html/browsers/*: Updated.
LayoutTests:
- TestExpectations:
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- platform/wpe/TestExpectations:
- tests-options.json:
- 5:50 PM Changeset in webkit [289515] by
-
- 7 edits in trunk/Source/JavaScriptCore
Use local variable pointer for concurrently load value
https://bugs.webkit.org/show_bug.cgi?id=236387
Reviewed by Saam Barati.
Consistently using local pointer to load member fields in
- WriteBarrierStructureID
- JSString's fiber
- Weak
- WriteBarrier<SomeKindOfCell>
to encourage compilers not to load the field twice.
- heap/Weak.cpp:
(JSC::weakClearSlowCase):
- heap/Weak.h:
(JSC::Weak::isHashTableEmptyValue const):
(JSC::Weak::unsafeImpl const):
(JSC::Weak::clear):
(JSC::Weak::impl const):
- heap/WeakInlines.h:
(JSC::Weak<T>::isHashTableDeletedValue const):
(JSC:: const):
(JSC::Weak<T>::operator const):
(JSC::Weak<T>::get const):
(JSC::Weak<T>::leakImpl):
- runtime/JSString.cpp:
(JSC::JSString::dumpToStream):
(JSC::JSString::estimatedSize):
(JSC::JSString::visitChildrenImpl):
- runtime/JSString.h:
(JSC::JSString::fiberConcurrently const):
(JSC::JSString::is8Bit const):
(JSC::JSString::length const):
(JSC::JSString::tryGetValueImpl const):
(JSC::JSString::isSubstring const):
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get const):
(JSC::WriteBarrierBase::operator* const):
(JSC::WriteBarrierBase::operator-> const):
(JSC::WriteBarrierBase::operator bool const):
(JSC::WriteBarrierBase::operator! const):
(JSC::WriteBarrierBase::unvalidatedGet const):
(JSC::WriteBarrierBase::cell const):
(JSC::WriteBarrierStructureID::get const):
(JSC::WriteBarrierStructureID::operator* const):
(JSC::WriteBarrierStructureID::operator-> const):
(JSC::WriteBarrierStructureID::operator bool const):
(JSC::WriteBarrierStructureID::operator! const):
(JSC::WriteBarrierStructureID::unvalidatedGet const):
- 5:27 PM Changeset in webkit [289514] by
-
- 6 edits in trunk/Source
Add some WebKitAdditions extension points in VisionKitCore SPI and softlinking headers
https://bugs.webkit.org/show_bug.cgi?id=236403
rdar://88709972
Reviewed by Aditya Keerthi.
Source/WebCore/PAL:
Add new WebKitAdditions header includes.
- pal/cocoa/VisionKitCoreSoftLink.h:
- pal/cocoa/VisionKitCoreSoftLink.mm:
Source/WebKit:
Declare a new helper function in TextRecognitionUtilities.h.
- Platform/cocoa/TextRecognitionUtilities.h:
- Platform/cocoa/TextRecognitionUtilities.mm:
- 5:27 PM Changeset in webkit [289513] by
-
- 7 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r289383. rdar://problem/88366849
[WebCore] JSValueInWrappedObject is not correct for concurrent GC
https://bugs.webkit.org/show_bug.cgi?id=236277
rdar://88366849
Reviewed by Saam Barati.
JSValueInWrappedObject is broken for concurrent GC's marking. It is using std::variant<> to store Weak / JSValue,
which is not safe if concurrent GC reads it while changing that std::variant. This patch fixes several problems
in JSValueInWrappedObject.
- We must not use std::variant here since concurrent access can happen. We have both JSValue and Weak, and change Weak after fully initialize WeakImpl's content in Weak. To ensure that, we emit storeStoreBarrier before setting Weak to the JSValueInWrappedObject's field.
- Assignment operator & copy constructor are basically wrong for this class as we need a write-barrier to set a value to the field. We remove them and make it explicit that we do not have write-barrier, which reveals that IDBRequest has a semantic bug.
- We also add clear() instead of assigning empty JSValueInWrappedObject. And we ensure that this new clear() works well with concurrent GC threads: we clear the underlying WeakImpl* pointer to nullptr. But since WeakImpl* is kept alive until GC clears weak-related things in its end phase, concurrent GC thread can access the old WeakImpl*.
- Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::setResult): (WebCore::IDBRequest::setResultToStructuredClone): (WebCore::IDBRequest::setResultToUndefined): (WebCore::IDBRequest::willIterateCursor): (WebCore::IDBRequest::didOpenOrIterateCursor):
- Modules/paymentrequest/PaymentMethodChangeEvent.cpp:
- Modules/paymentrequest/PaymentResponse.cpp: (WebCore::PaymentResponse::setDetailsFunction):
- Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::getChannelData): (WebCore::AudioBuffer::visitChannelWrappers):
- bindings/js/JSValueInWrappedObject.h: (WebCore::JSValueInWrappedObject::JSValueInWrappedObject): (WebCore::JSValueInWrappedObject::operator JSC::JSValue const): (WebCore::JSValueInWrappedObject::visit const): (WebCore::JSValueInWrappedObject::setWeakly): (WebCore::JSValueInWrappedObject::set): (WebCore::JSValueInWrappedObject::clear): (WebCore::JSValueInWrappedObject::setWithoutBarrier): (WebCore::cachedPropertyValue): (WebCore::JSValueInWrappedObject::makeValue): Deleted. (WebCore::JSValueInWrappedObject::operator=): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:26 PM Changeset in webkit [289512] by
-
- 4 edits1 add in branches/safari-613-branch
Cherry-pick r289450. rdar://problem/88483574
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
https://bugs.webkit.org/show_bug.cgi?id=236332
rdar://88483574
Reviewed by Michael Saboff.
JSTests:
- stress/yarr-inlining-dot-star-enclosure.js: Added. (test):
Source/JavaScriptCore:
YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
- yarr/YarrJIT.cpp:
- yarr/YarrJITRegisters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:24 PM Changeset in webkit [289511] by
-
- 1 copy in tags/Safari-613.1.16.1.5
Tag Safari-613.1.16.1.5.
- 5:21 PM Changeset in webkit [289510] by
-
- 51 edits41 adds in trunk/LayoutTests
[WPE] Unreviewed test gardening, update baselines of tests failing
- platform/wpe/css1/font_properties/font-expected.png: Added.
- platform/wpe/css1/font_properties/font-expected.txt:
- platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/wpe/fast/block/margin-collapse/103-expected.png: Added.
- platform/wpe/fast/block/margin-collapse/103-expected.txt:
- platform/wpe/fast/css/font-face-opentype-expected.png: Added.
- platform/wpe/fast/css/font-face-opentype-expected.txt:
- platform/wpe/fast/css/word-space-extra-expected.png:
- platform/wpe/fast/css/word-space-extra-expected.txt:
- platform/wpe/fast/dom/52776-expected.png: Added.
- platform/wpe/fast/dom/52776-expected.txt:
- platform/wpe/fast/table/text-field-baseline-expected.png: Added.
- platform/wpe/fast/table/text-field-baseline-expected.txt:
- platform/wpe/fast/text/atsui-multiple-renderers-expected.png: Added.
- platform/wpe/fast/text/atsui-multiple-renderers-expected.txt:
- platform/wpe/fast/text/atsui-negative-spacing-features-expected.png:
- platform/wpe/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/wpe/fast/text/atsui-spacing-features-expected.png:
- platform/wpe/fast/text/atsui-spacing-features-expected.txt:
- platform/wpe/fast/text/basic/015-expected.png: Added.
- platform/wpe/fast/text/basic/015-expected.txt:
- platform/wpe/fast/text/capitalize-boundaries-expected.png: Added.
- platform/wpe/fast/text/capitalize-boundaries-expected.txt:
- platform/wpe/fast/text/international/arabic-justify-expected.png: Added.
- platform/wpe/fast/text/international/arabic-justify-expected.txt:
- platform/wpe/fast/text/international/bidi-AN-after-L-expected.png: Added.
- platform/wpe/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/wpe/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
- platform/wpe/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/wpe/fast/text/international/bidi-CS-after-AN-expected.png: Added.
- platform/wpe/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/wpe/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
- platform/wpe/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
- platform/wpe/fast/text/international/bidi-linebreak-001-expected.png: Added.
- platform/wpe/fast/text/international/bidi-linebreak-001-expected.txt:
- platform/wpe/fast/text/international/bidi-linebreak-002-expected.png: Added.
- platform/wpe/fast/text/international/bidi-linebreak-002-expected.txt:
- platform/wpe/fast/text/international/bidi-linebreak-003-expected.png: Added.
- platform/wpe/fast/text/international/bidi-linebreak-003-expected.txt:
- platform/wpe/fast/text/international/bidi-listbox-atsui-expected.png: Added.
- platform/wpe/fast/text/international/bidi-listbox-atsui-expected.txt:
- platform/wpe/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
- platform/wpe/fast/text/international/bidi-mirror-he-ar-expected.txt:
- platform/wpe/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
- platform/wpe/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/wpe/fast/text/international/bidi-neutral-run-expected.png: Added.
- platform/wpe/fast/text/international/bidi-neutral-run-expected.txt:
- platform/wpe/fast/text/international/bold-bengali-expected.png: Added.
- platform/wpe/fast/text/international/bold-bengali-expected.txt:
- platform/wpe/fast/text/international/danda-space-expected.png: Added.
- platform/wpe/fast/text/international/danda-space-expected.txt:
- platform/wpe/fast/text/international/hebrew-vowels-expected.png: Added.
- platform/wpe/fast/text/international/hebrew-vowels-expected.txt:
- platform/wpe/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/wpe/fast/text/international/hindi-whitespace-expected.txt:
- platform/wpe/fast/text/international/thai-baht-space-expected.png: Added.
- platform/wpe/fast/text/international/thai-baht-space-expected.txt:
- platform/wpe/fast/text/international/thai-line-breaks-expected.png: Added.
- platform/wpe/fast/text/international/thai-line-breaks-expected.txt:
- platform/wpe/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
- platform/wpe/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- platform/wpe/fast/text/khmer-lao-font-expected.png: Added.
- platform/wpe/fast/text/khmer-lao-font-expected.txt:
- platform/wpe/fast/text/unicode-variation-selector-expected.png: Added.
- platform/wpe/fast/text/unicode-variation-selector-expected.txt:
- platform/wpe/fast/text/wbr-expected.png:
- platform/wpe/fast/text/wbr-expected.txt:
- platform/wpe/fast/text/wide-zero-width-space-expected.png: Added.
- platform/wpe/fast/text/wide-zero-width-space-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-04-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-04-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-05-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-composite-05-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-conv-03-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-conv-03-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-01-b-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-01-b-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-02-b-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-02-b-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-03-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-03-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-04-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-04-f-manual-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-05-f-manual-expected.png: Added.
- platform/wpe/imported/w3c/web-platform-tests/svg/import/filters-image-05-f-manual-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug30692-expected.png: Added.
- platform/wpe/tables/mozilla/bugs/bug30692-expected.txt:
- 5:12 PM Changeset in webkit [289509] by
-
- 2 edits in trunk/Source/WTF
[WK2] Turn on Shared Workers by default
https://bugs.webkit.org/show_bug.cgi?id=236396
Reviewed by Geoffrey Garen.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 4:46 PM Changeset in webkit [289508] by
-
- 17 edits1 copy in trunk/Source/WebKit
[iOS] Take adequate process assertion for the SharedWorker process
https://bugs.webkit.org/show_bug.cgi?id=236271
Reviewed by Brent Fulgham.
Keep track of client processes that rely on a particular SharedWorker process and take the adequate
process assertion to keep the process running on iOS when necessary. This allows us to get rid of
the hack I landed previously to always take a process assertion on behalf of the shared worker
process (even if all its clients are suspended).
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::sharedWorkerServerToContextConnectionIsNoLongerNeeded):
(WebKit::NetworkConnectionToWebProcess::serviceWorkerServerToContextConnectionNoLongerNeeded):
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
(WebKit::WebSWServerConnection::unregisterServiceWorkerClient):
(WebKit::WebSWServerConnection::contextConnectionCreated):
- NetworkProcess/SharedWorker/WebSharedWorker.cpp:
(WebKit::WebSharedWorker::WebSharedWorker):
(WebKit::WebSharedWorker::didCreateContextConnection):
(WebKit::WebSharedWorker::addSharedWorkerObject):
(WebKit::WebSharedWorker::removeSharedWorkerObject):
(WebKit::WebSharedWorker::forEachSharedWorkerObject const):
(WebKit::WebSharedWorker::contextConnection const):
- NetworkProcess/SharedWorker/WebSharedWorker.h:
(WebKit::WebSharedWorker::sharedWorkerObjectsCount const):
(WebKit::WebSharedWorker::sharedWorkerObjects): Deleted.
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::requestSharedWorker):
(WebKit::WebSharedWorkerServer::didFinishFetchingSharedWorkerScript):
(WebKit::WebSharedWorkerServer::createContextConnection):
(WebKit::WebSharedWorkerServer::removeContextConnection):
(WebKit::WebSharedWorkerServer::contextConnectionCreated):
(WebKit::WebSharedWorkerServer::sharedWorkerObjectIsGoingAway):
(WebKit::WebSharedWorkerServer::shutDownSharedWorker):
(WebKit::WebSharedWorkerServer::removeConnection):
(WebKit::WebSharedWorkerServer::postExceptionToWorkerObject):
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
(WebKit::WebSharedWorkerServerToContextConnection::launchSharedWorker):
(WebKit::WebSharedWorkerServerToContextConnection::addSharedWorkerObject):
(WebKit::WebSharedWorkerServerToContextConnection::removeSharedWorkerObject):
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h:
- Shared/RemoteWorkerType.h: Copied from Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.cpp.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
(WebKit::NetworkProcessProxy::registerRemoteWorkerClientProcess):
(WebKit::NetworkProcessProxy::unregisterRemoteWorkerClientProcess):
(WebKit::NetworkProcessProxy::remoteWorkerContextConnectionNoLongerNeeded):
(WebKit::NetworkProcessProxy::establishServiceWorkerContextConnectionToNetworkProcess):
(WebKit::NetworkProcessProxy::serviceWorkerContextConnectionNoLongerNeeded): Deleted.
(WebKit::NetworkProcessProxy::registerServiceWorkerClientProcess): Deleted.
(WebKit::NetworkProcessProxy::unregisterServiceWorkerClientProcess): Deleted.
(WebKit::NetworkProcessProxy::sharedWorkerContextConnectionNoLongerNeeded): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setUserAgent):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::establishSharedWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateRemoteWorkerUserAgent):
(WebKit::WebProcessPool::terminateServiceWorkers):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::updateWorkerUserAgent): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createForRemoteWorkers):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
(WebKit::WebProcessProxy::setRemoteWorkerUserAgent):
(WebKit::WebProcessProxy::updateRemoteWorkerPreferencesStore):
(WebKit::WebProcessProxy::updateRemoteWorkerProcessAssertion):
(WebKit::WebProcessProxy::registerRemoteWorkerClientProcess):
(WebKit::WebProcessProxy::unregisterRemoteWorkerClientProcess):
(WebKit::WebProcessProxy::startServiceWorkerBackgroundProcessing):
(WebKit::WebProcessProxy::endServiceWorkerBackgroundProcessing):
(WebKit::WebProcessProxy::disableRemoteWorkers):
(WebKit::WebProcessProxy::enableRemoteWorkers):
(WebKit::WebProcessProxy::createForWorkers): Deleted.
(WebKit::WebProcessProxy::setWorkerUserAgent): Deleted.
(WebKit::WebProcessProxy::updateWorkerPreferencesStore): Deleted.
(WebKit::WebProcessProxy::updateWorkerProcessAssertion): Deleted.
(WebKit::WebProcessProxy::registerServiceWorkerClientProcess): Deleted.
(WebKit::WebProcessProxy::unregisterServiceWorkerClientProcess): Deleted.
(WebKit::WebProcessProxy::disableWorkers): Deleted.
(WebKit::WebProcessProxy::enableWorkers): Deleted.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::hasServiceWorkerPageProxy):
- WebKit.xcodeproj/project.pbxproj:
- 3:57 PM Changeset in webkit [289507] by
-
- 7 edits in trunk/LayoutTests
LayoutTests/imported/w3c:
Unreviewed gardening.
Add fuzzy data.
- web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-2.html:
- web-platform-tests/css/motion/offset-rotate-003.html:
LayoutTests:
Unreviewed gardening
Update fuzzy data.
- css1/basic/class_as_selector.html:
- css3/color-filters/color-filter-color-text-decorations.html:
- css3/color-filters/color-filter-text-decoration-shadow.html:
- 3:48 PM Changeset in webkit [289506] by
-
- 3 edits in trunk/Tools
[EWS] Link commit URL to pull request
https://bugs.webkit.org/show_bug.cgi?id=236399
<rdar://problem/88707207>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(GitHub.commit_url): We should link to commit within pull request
(ConfigureBuild.add_pr_details): Pass pr_number to GitHub.commit_url.
- Tools/CISupport/ews-build/steps_unittest.py:
(TestGitHub.test_pr_url_with_repository):
(TestGitHub):
(TestGitHub.test_pr_url_with_invalid_repository):
(TestGitHub.test_commit_url_with_repository):
(TestGitHub.test_commit_url_with_invalid_repository):
Canonical link: https://commits.webkit.org/247040@main
- 2:59 PM Changeset in webkit [289505] by
-
- 1 copy in tags/Safari-614.1.1.5
Tag Safari-614.1.1.5.
- 2:58 PM Changeset in webkit [289504] by
-
- 3 edits in branches/safari-614.1.1-branch/Source/JavaScriptCore
Cherry-pick r289024. rdar://problem/88710933
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
<rdar://88222677>
Reviewed by Mark Lam.
- assembler/SecureARM64EHashPins.cpp: (JSC::SecureARM64EHashPins::initializeAtStartup): (JSC::SecureARM64EHashPins::allocatePinForCurrentThread): (JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:58 PM Changeset in webkit [289503] by
-
- 6 edits in branches/safari-614.1.1-branch/Source
Cherry-pick r288970. rdar://problem/88710933
Update computation of FAST_TLS base.
https://bugs.webkit.org/show_bug.cgi?id=235934
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::loadFromTLS32): (JSC::MacroAssemblerARM64::loadFromTLS64): (JSC::MacroAssemblerARM64::storeToTLS32): (JSC::MacroAssemblerARM64::storeToTLS64):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::keyForCurrentThread):
- offlineasm/arm64.rb:
Source/WTF:
- wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:55 PM Changeset in webkit [289502] by
-
- 4 edits in trunk
WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
https://bugs.webkit.org/show_bug.cgi?id=236401
rdar://88528286
Reviewed by Brent Fulgham.
Source/WebCore:
https://webkit.org/b/203302 added support for Range requests to AVAssetResourceLoadingDataRequest,
but it incorrectly used '*' instead of for "last-byte-pos:" for a request to the end of the resource.
API test URLSchemeHandler.Ranges was updated.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
- 2:02 PM Changeset in webkit [289501] by
-
- 9 edits in branches/safari-614.1.1-branch/Source
Versioning.
WebKit-7614.1.1.5
- 1:18 PM Changeset in webkit [289500] by
-
- 3 edits1 copy in trunk/Source/WTF
Unreviewed, reverting r289490.
https://bugs.webkit.org/show_bug.cgi?id=236402
EWS gets build failures
Reverted changeset:
"Reland native Xcode build phases for "Copy WTF Headers""
https://bugs.webkit.org/show_bug.cgi?id=235744
https://commits.webkit.org/r289490
- 12:53 PM Changeset in webkit [289499] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Vertical writing mode with RTL text content has incorrect advances
https://bugs.webkit.org/show_bug.cgi?id=236345
Reviewed by Antti Koivisto.
contentRightInInlineDirectionVisualOrder is the visual offset of the adjoining runs ignoring the writing mode (horizontal vs. vertical).
It's visual in the inline direction sense (right to left vs. left to right), but it's not transformed in the context of writing mode, i.e. width and height are not flipped.
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
- 12:48 PM Changeset in webkit [289498] by
-
- 5 edits4 adds in trunk
Dialog element only animates once
https://bugs.webkit.org/show_bug.cgi?id=236274
rdar://88635487
Reviewed by Tim Nguyen and Dean Jackson.
LayoutTests/imported/w3c:
Add two new tests that check that we correctly start, stop and resume animations on <dialog>
and ::backdrop as a <dialog> element is open, closed and open again.
- web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added.
- web-platform-tests/css/css-animations/dialog-animation.html: Added.
- web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added.
- web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added.
- web-platform-tests/css/css-animations/support/testcommon.js:
(addElement):
(addDiv):
Source/WebCore:
Two issues related to CSS Animation surfaced in this bug which animates both <dialog>
and its ::backdrop as the dialog is open and eventually re-opened.
The first issue was that we didn't clear all CSS Animations state when a <dialog> was
closed and its style was set todisplay: none. We now use the clearCSSAnimationsForStyleable()
function (static so that it's not exposed on the Styleable struct) to correctly clear
such state both when we identify a Styleable is newly gettingdisplay: noneand when
cancelDeclarativeAnimations() was called. This allows us to remove removeCSSAnimationCreatedByMarkup()
a fair bit of work to clear CSS Animation state per-animation when we only ever used that
function for _all_ animations.
The second issue was that we never called cancelDeclarativeAnimations() for ::backdrop.
We now do that inside of Element::removeFromTopLayer() at a point where the code in
Styleable::fromRenderer() will still work as the element will still be contained in
Document::topLayerElements().
Tests: imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html
imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html
- dom/Element.cpp:
(WebCore::Element::removeFromTopLayer):
- style/Styleable.cpp:
(WebCore::clearCSSAnimationsForStyleable):
(WebCore::Styleable::cancelDeclarativeAnimations const):
(WebCore::Styleable::updateCSSAnimations const):
(WebCore::removeCSSAnimationCreatedByMarkup): Deleted.
- 12:36 PM Changeset in webkit [289497] by
-
- 4 edits in trunk
compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=236323
Reviewed by Don Olmstead.
Source/WebCore:
Apple ports don't have this issue because GraphicsLayerCA support
Shape layer for clip-path.
The painting phase of the existing mask layer should be updated if
clip-path or mask are changed.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayer):
LayoutTests:
- platform/gtk/TestExpectations:
- 12:25 PM Changeset in webkit [289496] by
-
- 5 edits in trunk/Tools
Move macOS EWS to Big Sur
https://bugs.webkit.org/show_bug.cgi?id=236035
Reviewed by Jonathan Bedard.
- CISupport/build-webkit-org/config.json:
- CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- CISupport/ews-build/config.json:
- CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
Canonical link: https://commits.webkit.org/247033@main
- 12:20 PM Changeset in webkit [289495] by
-
- 22 edits in trunk/Source
[model] improve sizing on macOS
https://bugs.webkit.org/show_bug.cgi?id=236233
<rdar://problem/88569881>
Reviewed by Simon Fraser.
Source/WebCore:
We detect when the <model> layer size changes under RenderLayerBacking::updateGeometry()
and inform the associated HTMLModelElement through the new parentLayerSizeMayHaveChanged()
method that the size has changed. We then inform the backing player that sizeDidChange().
- Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::createModelPlayer):
(WebCore::HTMLModelElement::parentLayerSizeMayHaveChanged):
(WebCore::HTMLModelElement::platformLayerSize const):
- Modules/model-element/HTMLModelElement.h:
- Modules/model-element/ModelPlayer.h:
- Modules/model-element/dummy/DummyModelPlayer.cpp:
(WebCore::DummyModelPlayer::sizeDidChange):
- Modules/model-element/dummy/DummyModelPlayer.h:
- Modules/model-element/scenekit/SceneKitModelPlayer.h:
- Modules/model-element/scenekit/SceneKitModelPlayer.mm:
(WebCore::SceneKitModelPlayer::sizeDidChange):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
Source/WebCore/PAL:
Add newly-used CAFenceHandle and ASVInlinePreview SPIs.
- pal/spi/cocoa/QuartzCoreSPI.h:
- pal/spi/mac/SystemPreviewSPI.h:
Source/WebKit:
We override the new ModelPlayer::sizeDidChange() virtual method on ARKitInlinePreviewModelPlayerMac
to be notified when the <model> layer's has changed size. We then send the new ModelElementSizeDidChange
message to the UI process which will yield a call to ModelElementController::modelElementSizeDidChange().
In that new method, we call -[ASVInlinePreview updateFrame:completionHandler:] which provides us with a
CAFenceHandle which we copy to create a MachSendRight to send back to the Web process in the IPC callback.
Back in the Web process, we install this fence on the drawing area and finally call -[ASVInlinePreview
setFrameWithinFencedTransaction:] to complete the sizing update on both the ASVInlinePreview instances.
- UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::modelElementSizeDidChange):
- UIProcess/ModelElementController.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::modelElementSizeDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Model/ARKitInlinePreviewModelPlayer.h:
- WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:
(WebKit::ARKitInlinePreviewModelPlayer::sizeDidChange):
- WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h:
- WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm:
(WebKit::ARKitInlinePreviewModelPlayerMac::load):
(WebKit::ARKitInlinePreviewModelPlayerMac::sizeDidChange):
- 11:48 AM Changeset in webkit [289494] by
-
- 4 edits in trunk
Add TAO check to PerformanceResourceTiming::fetchStart
https://bugs.webkit.org/show_bug.cgi?id=236379
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-09
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt:
Source/WebCore:
This matches the spec and was recently changed in Chromium.
<https://chromium-review.googlesource.com/c/chromium/src/+/3448777>
Covered by a newly passing WPT test.
- page/PerformanceResourceTiming.cpp:
(WebCore::fetchStart):
- 11:39 AM Changeset in webkit [289493] by
-
- 4 edits in trunk/Source/WebCore
Register strings in CSSTokenizer created from preprocessing
https://bugs.webkit.org/show_bug.cgi?id=236309
Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2022-02-09
Reviewed by Michael Saboff.
Register strings in CSSTokenizer created from preprocessing. This will align with
what is currently done for strings with escapes in CSSTokenizer::consumeName().
- css/parser/CSSTokenizer.cpp:
(WebCore::CSSTokenizer::preprocessString):
(WebCore::CSSTokenizer::tryCreate):
(WebCore::CSSTokenizer::CSSTokenizer):
(WebCore::preprocessString): Deleted.
- css/parser/CSSTokenizer.h:
- css/parser/CSSTokenizerInputStream.h:
- 11:35 AM Changeset in webkit [289492] by
-
- 8 edits in trunk/Source
DisplayListRecorder implementations are not able to obtain extra information out of source ImageBuffers
https://bugs.webkit.org/show_bug.cgi?id=236296
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-09
Reviewed by Wenson Hsieh.
Source/WebCore:
Pass ImageBuffer& to various recording commands instead of the resource identifier.
This way implementations of DisplayListRecorder can obtain additional information
about the ImageBuffer, such as dependency information. This additional information is
not neccessarily needed for in-process display lists.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawFilteredImageBuffer):
(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::clipToImageBuffer):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::recordClipToImageBuffer):
(WebCore::DisplayList::RecorderImpl::recordDrawFilteredImageBuffer):
(WebCore::DisplayList::RecorderImpl::recordDrawImageBuffer):
- platform/graphics/displaylists/DisplayListRecorderImpl.h:
Source/WebKit:
RecorderImpl now passes ImageBuffers to the DisplayListRecorder calls.
Use the ImageBuffer& to get the resource identifier.
In future commits these places will obtain the read references, which
record the depenedency information needed for RemoteImageBuffers
created in multiple threads.
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordClipToImageBuffer):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawFilteredImageBuffer):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawImageBuffer):
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- 11:31 AM Changeset in webkit [289491] by
-
- 1 edit1 add in trunk/Source/bmalloc
[libpas] add documentation
https://bugs.webkit.org/show_bug.cgi?id=236385
Rubber stamped by Mark Lam.
- libpas/Documentation.md: Added.
- 10:56 AM Changeset in webkit [289490] by
-
- 3 edits1 delete in trunk/Source/WTF
Reland native Xcode build phases for "Copy WTF Headers"
https://bugs.webkit.org/show_bug.cgi?id=235744
Reviewed by Alexey Proskuryakov.
Changes since revert of r289256:
ICU headers, which are only needed for non-internal builds, are tracked in WTF.xcodeproj and
copied to /usr/local/include/unicode when building with the public SDK.
- Configurations/WTF.xcconfig: Skip coping ICU headers when USE_INTERNAL_SDK=YES.
- WTF.xcodeproj/project.pbxproj: Add ICU header directory and copy files phase.
- 10:51 AM Changeset in webkit [289489] by
-
- 6 edits in trunk
Worker scripts should always be decoded as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=236319
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
- web-platform-tests/workers/semantics/encodings/001-expected.txt:
- web-platform-tests/workers/semantics/encodings/002-expected.txt:
Source/WebCore:
Worker scripts should always be decoded as UTF-8:
No new tests, rebaselined existing tests.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didReceiveData):
- 10:50 AM Changeset in webkit [289488] by
-
- 1 copy in tags/Safari-613.1.16.31.2
Tag Safari-613.1.16.31.2.
- 10:50 AM Changeset in webkit [289487] by
-
- 6 edits in branches/safari-613.1.16.31-branch/Source
Cherry-pick r288970. rdar://problem/88459807
Update computation of FAST_TLS base.
https://bugs.webkit.org/show_bug.cgi?id=235934
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::loadFromTLS32): (JSC::MacroAssemblerARM64::loadFromTLS64): (JSC::MacroAssemblerARM64::storeToTLS32): (JSC::MacroAssemblerARM64::storeToTLS64):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::keyForCurrentThread):
- offlineasm/arm64.rb:
Source/WTF:
- wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:48 AM Changeset in webkit [289486] by
-
- 9 edits in branches/safari-613.1.16.31-branch/Source
Versioning.
WebKit-7613.1.16.31.2
- 10:45 AM Changeset in webkit [289485] by
-
- 5 edits in trunk/Source
Move Safe Browsing knowledge into SafariSafeBrowsing framework
https://bugs.webkit.org/show_bug.cgi?id=231692
Patch by Eliot Hsu <eliot_hsu@apple.com> on 2022-02-09
Reviewed by Alex Christensen.
Following up on an old FIXME, move Safari Safe Browsing-specific
knowledge out of WebKit and into the SafariSafeBrowsing framework.
This includes things like the Learn More URL, the Report an Error URL,
etc.
Source/WebKit:
- Platform/spi/Cocoa/SafeBrowsingSPI.h:
- UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:
(WebKit::malwareDetailsBase):
(WebKit::learnMoreURL):
(WebKit::reportAnErrorBase):
(WebKit::localizedProvider):
Rely on new SafariSafeBrowsing calls to provide
URL/provider information about Safe Browsing,
when available
Source/WTF:
- wtf/PlatformHave.h:
- 10:39 AM Changeset in webkit [289484] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Timeout due to turning WebGL on by default on bots. Will be addressed in b234536.
- platform/ios-wk2/TestExpectations:
- 10:30 AM Changeset in webkit [289483] by
-
- 29 edits in trunk
self.location.href is incorrect in shared workers in case of redirects
https://bugs.webkit.org/show_bug.cgi?id=236340
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
- web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker-expected.txt:
- web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker-expected.txt:
- web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker-expected.txt:
Source/WebCore:
self.location.href is incorrect in shared workers in case of redirects. It should be
the URL of the last request, not the first one.
No new tests, rebaselined existing tests.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
- loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::redirectReceived):
- loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::redirectReceived):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::redirectReceived):
- loader/WorkerThreadableLoader.h:
- workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
- workers/WorkerFetchResult.h:
(WebCore::WorkerFetchResult::isolatedCopy const):
(WebCore::workerFetchError):
(WebCore::WorkerFetchResult::encode const):
(WebCore::WorkerFetchResult::decode):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::redirectReceived):
(WebCore::WorkerScriptLoader::fetchResult const):
- workers/WorkerScriptLoader.h:
(WebCore::WorkerScriptLoader::script const):
(WebCore::WorkerScriptLoader::lastRequestURL const):
(WebCore::WorkerScriptLoader::script): Deleted.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::notifyFinished):
- workers/service/ServiceWorkerJobClient.h:
- workers/shared/SharedWorkerScriptLoader.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
- workers/shared/context/SharedWorkerThreadProxy.cpp:
(WebCore::generateWorkerParameters):
(WebCore::SharedWorkerThreadProxy::SharedWorkerThreadProxy):
- workers/shared/context/SharedWorkerThreadProxy.h:
Source/WebKit:
self.location.href is incorrect in shared workers in case of redirects. It should be the URL of
the last request, not the first one.
- NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:
(WebKit::ServiceWorkerSoftUpdateLoader::didFinishLoading):
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
(WebKit::WebSharedWorkerServerToContextConnection::launchSharedWorker):
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.h:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.messages.in:
- 10:17 AM Changeset in webkit [289482] by
-
- 5 edits in trunk
[WebAuthn] Specify LocalAuthenticatorAccessGroup when importing credentials
https://bugs.webkit.org/show_bug.cgi?id=236311
rdar://88394179
Reviewed by Brent Fulgham.
Source/WebKit:
Tested on device and added check for accessGroup in API test.
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel importLocalAuthenticatorCredential:error:]):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
Tools:
Added check for accessGroup to API test.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::WebCore::addKeyToKeychain):
(TestWebKitAPI::TEST):
- 10:16 AM Changeset in webkit [289481] by
-
- 4 edits1 add in branches/safari-613.1.16.1-branch
Cherry-pick r289450. rdar://problem/88483574
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
https://bugs.webkit.org/show_bug.cgi?id=236332
rdar://88483574
Reviewed by Michael Saboff.
JSTests:
- stress/yarr-inlining-dot-star-enclosure.js: Added. (test):
Source/JavaScriptCore:
YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
- yarr/YarrJIT.cpp:
- yarr/YarrJITRegisters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:12 AM Changeset in webkit [289480] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] MediaPlayerPrivateGStreamer mishandles failure to create WebKitTextCombiner
https://bugs.webkit.org/show_bug.cgi?id=233230
<rdar://problem/86863068>
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-09
Reviewed by Xabier Rodriguez-Calvar.
Fallback to fakesink in case fakevideosink is not available. Also no longer RELEASE_ASSERT
in makeGStreamerElement and makeGStreamerBin. We should gracefully handle call sites when
these functions return nullptr.
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::makeGStreamerElement):
(WebCore::makeGStreamerBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
- 10:05 AM Changeset in webkit [289479] by
-
- 10 edits in trunk
Exceptions are not properly reported when initializing a worker as a module
https://bugs.webkit.org/show_bug.cgi?id=236334
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
- web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt:
- web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/message-module-DOMException-expected.txt:
Source/WebCore:
No new tests, rebaselined existing tests.
- workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule):
linkAndEvaluateModule() was failing to report the exception, unlike
evaluate() (which is used for classic workers).
- 9:43 AM Changeset in webkit [289478] by
-
- 9 edits in branches/safari-613.1.16.1-branch/Source
Versioning.
WebKit-7613.1.16.1.5
- 9:14 AM Changeset in webkit [289477] by
-
- 7 edits in trunk
Stop obfuscating exceptions thrown by scripts in data URLs
https://bugs.webkit.org/show_bug.cgi?id=236329
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing or whose output looks different.
- web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt:
- web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004-expected.txt:
- web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006-expected.txt:
Source/WebCore:
Stop obfuscating exceptions thrown by scripts in data URLs. This is causing some WPT tests to fail.
No new tests, rebaselined existing tests.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canIncludeErrorDetails):
- 9:06 AM Changeset in webkit [289476] by
-
- 11 edits in trunk/Source/WebCore
AudioBuffer should take a lock while visiting m_channelWrappers
https://bugs.webkit.org/show_bug.cgi?id=236279
Reviewed by Keith Miller.
This patch fixes AudioBuffer's m_channelWrappers concurrency bug and related issues.
- This patch removes problematic (and almost always wrong) move operator of JSValueInWrappedObject. To do that, we fixed AudioBuffer's concurrency issue where we access m_channelWrappers while it can be cleared concurrently in AudioBuffer::releaseMemory.
- MessageEvent's m_data access is broken with concurrent GC thread. We must take a lock. And we must not use JSValueInWrappedObject in std::variant if it can be changed after constructor invocation.
- Use JSValueInWrappedObject::clear instead of move with empty value.
- File https://bugs.webkit.org/show_bug.cgi?id=236353. AbortSignal, MessageEvent, and CustomEvent miss write-barrier, which is semantically wrong.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::releaseMemory):
(WebCore::AudioBuffer::visitChannelWrappers):
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::AudioWorkletProcessor::buildJSArguments):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data const):
(WebCore::JSMessageEvent::visitAdditionalChildren):
- bindings/js/JSValueInWrappedObject.h:
- dom/AbortSignal.cpp:
(WebCore::AbortSignal::signalAbort):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::m_jsData):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::memoryCost const):
(WebCore::m_ports): Deleted.
- dom/MessageEvent.h:
- page/History.cpp:
(WebCore::History::stateObjectAdded):
- 8:56 AM Changeset in webkit [289475] by
-
- 3 edits in trunk/JSTests
Skip failing shadow realms tests on MIPS
https://bugs.webkit.org/show_bug.cgi?id=236361
Unreviewed gardening.
- stress/shadow-realm-evaluate.js:
- stress/shadow-realm-import-value.js:
- 8:55 AM Changeset in webkit [289474] by
-
- 57 edits1 copy9 adds in trunk
Manage IndexedDB storage by origin
https://bugs.webkit.org/show_bug.cgi?id=234925
<rdar://problem/87555014>
Reviewed by Chris Dumez.
Source/WebCore:
Both WebKit and WebKitLegacy used IDBServer to manage UniqueIDBDatabases, and UniqueIDBDatabase pointed to
IDBServer. Now that WebKit uses WebKit::IDBStorageManager to manage UniqueIDBDatabases. We untie the
knot between IDBServer and UniqueIDBDatabase by adding a new abstract class UniqueIDBDatabaseManager and make
UniqueIDBDatabase point to UniqueIDBDatabaseManager.
Also, as quota check is no longer async according to changes in WebKit, we need to update operations in
UniqueIDBDatabase to adopt the change.
Covered by existing tests.
- Headers.cmake:
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::registerConnection):
(WebCore::IDBServer::IDBServer::unregisterConnection):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::upgradedDatabaseDirectory):
(WebCore::IDBServer::IDBServer::registerDatabaseConnection): Deleted.
(WebCore::IDBServer::IDBServer::unregisterDatabaseConnection): Deleted.
(WebCore::IDBServer::IDBServer::closeAndTakeUniqueIDBDatabase): Deleted.
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::create):
(WebCore::IDBServer::MemoryObjectStore::MemoryObjectStore):
- Modules/indexeddb/server/MemoryObjectStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::encodeDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::decodeDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::filenameForDatabaseName const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade): Deleted.
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::manager):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperationAfterSpaceCheck):
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterSpaceCheck):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getAllRecords):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::hasDataInMemory const):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
(WebCore::IDBServer::UniqueIDBDatabase::server): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::manager):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::server): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabaseManager.h: Added.
(WebCore::IDBServer::UniqueIDBDatabaseManager::~UniqueIDBDatabaseManager):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::~UniqueIDBDatabaseTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::operator bool const):
- Modules/indexeddb/shared/IDBRequestData.h:
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::IDBResourceIdentifier::operator!= const):
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
In network process, IndexedDB data is managed by WebKit::WebIDBServer. Each session owns a WebIDBServer
(IDBServer) and each IDBServer owns one or more UniqueIDBDatabases (resprenting one actual database that
IDBDatabase connects to, can be identified by {session, origin, name}). Now that we have NetworkStorageManager,
which manages session storage by origin, we can merge WebIDBServer with NetworkStorageManager, since IndexedDB
storage is not shared across origins.
The old structure is:
NetworkSession - WebIDBServer - IDBServer - UniqueIDBDatabases
The new structure is:
NetworkSession - NetworkStorageManager - OriginStorageManager - IDBStorageManager - UniqueIDBDatabase
To complete this transition, we need to make a few changes:
- Web process now sends IndexedDB related messages to NetworkStorageManager instead of WebIDBServer.
- Some messages are sent to operate on UniqueIDBDatabaseConnection or UniqueIDBDatabaseTransaction, and they
use identifiers to specify the target. Therefore, NetworkStorageManagers needs to know the mapping between
identifiers and target objects. A new clas IDBStorageRegistry is added record this mapping. Each
NetworkStorageManager owns a IDBStorageRegistry and it passes IDBStorageRegistry to IDBStorageManager,
IDBStorageManager will register objects to IDBStorageRegistry and NetworkStorageManager can do search via
IDBStorageRegistry.
- Quota check for IndexedDB operations becomes async by adding new QuotaManager class, which is similar to
WebCore::StorageQuotaManager but provides async interfaces.
We used to block the IDBServer thread when it is waiting for quota check result from UI process, this is fine
because IDBServer runs on its own thread. Now that IDBStorageManager runs on the same thread as the other
storage types, we cannot block the thread on quota check.
- Rename WebIDBConnectionToClient to IDBStorageConnectionToClient to reflect the change on the structure. Also,
IDBStorageConnectionToClient does not keep reference to the IPC::Connection now, it only records
IPC::Connection::UniqueID.
- IndexedDB data may be put in different version dirctories. We used to migrate database to new version
diretory when the database is accessed. As IDBStorageManager now manages IndexedDB data of one origin, it's
simpler if it only keeps track of one directory. Therefore, we now migrate all databases of one origin
when the origin is accessed (see IDBStorageManager::idbStorageOriginDirectory).
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::updateQuotaBasedOnSpaceUsageForTesting):
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFilesForIndexedDB):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
(WebKit::NetworkProcess::resetQuota):
(WebKit::NetworkProcess::didIncreaseQuota):
(WebKit::NetworkProcess::renameOriginInWebsiteData):
(WebKit::NetworkProcess::storageQuotaManager):
(WebKit::NetworkProcess::connectionToWebProcessClosed):
(WebKit::NetworkProcess::suspendIDBServers): Deleted.
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::shouldSuspendIDBServers const): Deleted.
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::invalidateAndCancel):
(WebKit::NetworkSession::addStorageManagerSession):
(WebKit::NetworkSession::ensureWebIDBServer): Deleted.
(WebKit::NetworkSession::closeIDBServer): Deleted.
(WebKit::NetworkSession::addIndexedDatabaseSession): Deleted.
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::webIDBServer): Deleted.
(WebKit::NetworkSession::hasIDBDatabasePath const): Deleted.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::storagePath):
(WebKit::CacheStorage::Engine::diskUsage):
(WebKit::CacheStorage::Engine::requestSpace):
- NetworkProcess/cache/CacheStorageEngine.h:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::requestSpace):
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::setIsHoldingLockedFiles):
- NetworkProcess/storage/IDBStorageConnectionToClient.cpp: Added.
(WebKit::IDBStorageConnectionToClient::IDBStorageConnectionToClient):
(WebKit::IDBStorageConnectionToClient::~IDBStorageConnectionToClient):
(WebKit::IDBStorageConnectionToClient::connectionToClient):
(WebKit::IDBStorageConnectionToClient::didGetResult):
(WebKit::IDBStorageConnectionToClient::didDeleteDatabase):
(WebKit::IDBStorageConnectionToClient::didOpenDatabase):
(WebKit::IDBStorageConnectionToClient::didStartTransaction):
(WebKit::IDBStorageConnectionToClient::didAbortTransaction):
(WebKit::IDBStorageConnectionToClient::didCommitTransaction):
(WebKit::IDBStorageConnectionToClient::didCreateObjectStore):
(WebKit::IDBStorageConnectionToClient::didDeleteObjectStore):
(WebKit::IDBStorageConnectionToClient::didRenameObjectStore):
(WebKit::IDBStorageConnectionToClient::didClearObjectStore):
(WebKit::IDBStorageConnectionToClient::didCreateIndex):
(WebKit::IDBStorageConnectionToClient::didDeleteIndex):
(WebKit::IDBStorageConnectionToClient::didRenameIndex):
(WebKit::IDBStorageConnectionToClient::didPutOrAdd):
(WebKit::IDBStorageConnectionToClient::didGetRecord):
(WebKit::IDBStorageConnectionToClient::didGetAllRecords):
(WebKit::IDBStorageConnectionToClient::didGetCount):
(WebKit::IDBStorageConnectionToClient::didDeleteRecord):
(WebKit::IDBStorageConnectionToClient::didOpenCursor):
(WebKit::IDBStorageConnectionToClient::didIterateCursor):
(WebKit::IDBStorageConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebKit::IDBStorageConnectionToClient::fireVersionChangeEvent):
(WebKit::IDBStorageConnectionToClient::didCloseFromServer):
(WebKit::IDBStorageConnectionToClient::notifyOpenDBRequestBlocked):
- NetworkProcess/storage/IDBStorageConnectionToClient.h: Added.
- NetworkProcess/storage/IDBStorageManager.cpp: Added.
(WebKit::migrateOriginData):
(WebKit::IDBStorageManager::idbStorageOriginDirectory):
(WebKit::IDBStorageManager::idbStorageSize):
(WebKit::getOriginsForVersion):
(WebKit::IDBStorageManager::originsOfIDBStorageData):
(WebKit::IDBStorageManager::IDBStorageManager):
(WebKit::IDBStorageManager::isActive const):
(WebKit::IDBStorageManager::hasDataInMemory const):
(WebKit::IDBStorageManager::closeDatabasesForDeletion):
(WebKit::IDBStorageManager::stopDatabaseActivitiesForSuspend):
(WebKit::IDBStorageManager::getOrCreateUniqueIDBDatabase):
(WebKit::IDBStorageManager::openDatabase):
(WebKit::IDBStorageManager::deleteDatabase):
(WebKit::IDBStorageManager::getAllDatabaseNamesAndVersions):
(WebKit::IDBStorageManager::openDBRequestCancelled):
(WebKit::IDBStorageManager::registerConnection):
(WebKit::IDBStorageManager::unregisterConnection):
(WebKit::IDBStorageManager::registerTransaction):
(WebKit::IDBStorageManager::unregisterTransaction):
(WebKit::IDBStorageManager::createBackingStore):
(WebKit::IDBStorageManager::requestSpace):
- NetworkProcess/storage/IDBStorageManager.h: Added.
- NetworkProcess/storage/IDBStorageRegistry.cpp: Added.
(WebKit::IDBStorageRegistry::ensureConnectionToClient):
(WebKit::IDBStorageRegistry::removeConnectionToClient):
(WebKit::IDBStorageRegistry::registerConnection):
(WebKit::IDBStorageRegistry::unregisterConnection):
(WebKit::IDBStorageRegistry::registerTransaction):
(WebKit::IDBStorageRegistry::unregisterTransaction):
(WebKit::IDBStorageRegistry::connection):
(WebKit::IDBStorageRegistry::transaction):
- NetworkProcess/storage/IDBStorageRegistry.h: Added.
- NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::create):
(WebKit::NetworkStorageManager::NetworkStorageManager):
(WebKit::NetworkStorageManager::canHandleTypes):
(WebKit::NetworkStorageManager::stopReceivingMessageFromConnection):
(WebKit::NetworkStorageManager::localOriginStorageManager):
(WebKit::NetworkStorageManager::didIncreaseQuota):
(WebKit::NetworkStorageManager::getAllOrigins):
(WebKit::NetworkStorageManager::moveData):
(WebKit::NetworkStorageManager::suspend):
(WebKit::NetworkStorageManager::registerTemporaryBlobFilePaths):
(WebKit::NetworkStorageManager::requestSpace):
(WebKit::NetworkStorageManager::resetQuotaForTesting):
(WebKit::NetworkStorageManager::resetQuotaUpdatedBasedOnUsageForTesting):
(WebKit::NetworkStorageManager::openDatabase):
(WebKit::NetworkStorageManager::openDBRequestCancelled):
(WebKit::NetworkStorageManager::deleteDatabase):
(WebKit::NetworkStorageManager::establishTransaction):
(WebKit::NetworkStorageManager::databaseConnectionPendingClose):
(WebKit::NetworkStorageManager::databaseConnectionClosed):
(WebKit::NetworkStorageManager::abortOpenAndUpgradeNeeded):
(WebKit::NetworkStorageManager::didFireVersionChangeEvent):
(WebKit::NetworkStorageManager::abortTransaction):
(WebKit::NetworkStorageManager::commitTransaction):
(WebKit::NetworkStorageManager::didFinishHandlingVersionChangeTransaction):
(WebKit::NetworkStorageManager::createObjectStore):
(WebKit::NetworkStorageManager::deleteObjectStore):
(WebKit::NetworkStorageManager::renameObjectStore):
(WebKit::NetworkStorageManager::clearObjectStore):
(WebKit::NetworkStorageManager::createIndex):
(WebKit::NetworkStorageManager::deleteIndex):
(WebKit::NetworkStorageManager::renameIndex):
(WebKit::NetworkStorageManager::putOrAdd):
(WebKit::NetworkStorageManager::getRecord):
(WebKit::NetworkStorageManager::getAllRecords):
(WebKit::NetworkStorageManager::getCount):
(WebKit::NetworkStorageManager::deleteRecord):
(WebKit::NetworkStorageManager::openCursor):
(WebKit::NetworkStorageManager::iterateCursor):
(WebKit::NetworkStorageManager::getAllDatabaseNamesAndVersions):
- NetworkProcess/storage/NetworkStorageManager.h:
- NetworkProcess/storage/NetworkStorageManager.messages.in:
- NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::StorageBucket):
(WebKit::OriginStorageManager::StorageBucket::toWebsiteDataType):
(WebKit::OriginStorageManager::StorageBucket::toStorageIdentifier):
(WebKit::OriginStorageManager::StorageBucket::idbStorageManager):
(WebKit::OriginStorageManager::StorageBucket::existingIDBStorageManager):
(WebKit::OriginStorageManager::StorageBucket::isActive const):
(WebKit::OriginStorageManager::StorageBucket::isEmpty const):
(WebKit::OriginStorageManager::StorageBucket::deleteData):
(WebKit::OriginStorageManager::StorageBucket::moveData):
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInListFromMemory):
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInListFromDisk):
(WebKit::OriginStorageManager::StorageBucket::deleteIDBStorageData):
(WebKit::createQuotaManager):
(WebKit::OriginStorageManager::OriginStorageManager):
(WebKit::OriginStorageManager::defaultBucket):
(WebKit::OriginStorageManager::quotaManager):
(WebKit::OriginStorageManager::idbStorageManager):
(WebKit::OriginStorageManager::existingIDBStorageManager):
(WebKit::OriginStorageManager::moveData):
- NetworkProcess/storage/OriginStorageManager.h:
- NetworkProcess/storage/QuotaManager.cpp: Added.
(WebKit::QuotaManager::create):
(WebKit::QuotaManager::QuotaManager):
(WebKit::QuotaManager::requestSpace):
(WebKit::QuotaManager::handleRequests):
(WebKit::QuotaManager::grantWithCurrentQuota):
(WebKit::QuotaManager::grantFastPath):
(WebKit::QuotaManager::didIncreaseQuota):
(WebKit::QuotaManager::resetQuotaUpdatedBasedOnUsageForTesting):
(WebKit::QuotaManager::resetQuotaForTesting):
- NetworkProcess/storage/QuotaManager.h: Added.
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
- Shared/WebsiteData/QuotaIncreaseRequestIdentifier.h: Added.
- Shared/WebsiteDataStoreParameters.h:
- Sources.txt:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::increaseQuota):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::perThirdPartyOriginStorageQuota const):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::defaultPerOriginQuota):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToServer::createObjectStore):
(WebKit::WebIDBConnectionToServer::deleteObjectStore):
(WebKit::WebIDBConnectionToServer::renameObjectStore):
(WebKit::WebIDBConnectionToServer::clearObjectStore):
(WebKit::WebIDBConnectionToServer::createIndex):
(WebKit::WebIDBConnectionToServer::deleteIndex):
(WebKit::WebIDBConnectionToServer::renameIndex):
(WebKit::WebIDBConnectionToServer::putOrAdd):
(WebKit::WebIDBConnectionToServer::getRecord):
(WebKit::WebIDBConnectionToServer::getAllRecords):
(WebKit::WebIDBConnectionToServer::getCount):
(WebKit::WebIDBConnectionToServer::deleteRecord):
(WebKit::WebIDBConnectionToServer::openCursor):
(WebKit::WebIDBConnectionToServer::iterateCursor):
(WebKit::WebIDBConnectionToServer::establishTransaction):
(WebKit::WebIDBConnectionToServer::databaseConnectionPendingClose):
(WebKit::WebIDBConnectionToServer::databaseConnectionClosed):
(WebKit::WebIDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToServer::didFireVersionChangeEvent):
(WebKit::WebIDBConnectionToServer::openDBRequestCancelled):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNamesAndVersions):
Source/WebKitLegacy:
- Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::quotaManager):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:
(runTest):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
(TEST):
- 8:34 AM Changeset in webkit [289473] by
-
- 2 edits in trunk
[CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
https://bugs.webkit.org/show_bug.cgi?id=236365
Reviewed by Martin Robinson.
- Source/cmake/OptionsCommon.cmake: Use separate_arguments() to turn plain command strings
into lists of strings, which can then be passed down to execute_process() as it knows how
to handle lists properly.
- 8:15 AM Changeset in webkit [289472] by
-
- 23 edits3 copies14 adds6 deletes in trunk/LayoutTests
Resync web-platform-tests/html/dom from upstream
https://bugs.webkit.org/show_bug.cgi?id=236252
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Resync web-platform-tests/html/dom from upstream 893e71aa9c0a97d259ff009f.
- web-platform-tests/html/dom/*: Updated.
- web-platform-tests/html/resources/common.js:
- web-platform-tests/interfaces/html.idl:
LayoutTests:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt:
- 8:13 AM Changeset in webkit [289471] by
-
- 9 edits in trunk/Source/WebCore
[LFC][IFC] Transform root inline box's logical rect based on the writing mode
https://bugs.webkit.org/show_bug.cgi?id=236341
Reviewed by Antti Koivisto.
Make sure root inline box has the correct _visual_ coordinates in vertical mode.
(also let's rename DisplayLine::contentLeft to contentLogicalOffset. The emphasis is on _logical_. It helps to catch incorrect use (even this diff has a couple)).
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::flipRootInlineBoxRectToVisualForWritingMode const):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
- layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::contentLogicalOffset const):
(WebCore::InlineDisplay::Line::Line):
(WebCore::InlineDisplay::Line::contentLeft const): Deleted.
- layout/integration/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::createTextRun const):
- layout/integration/InlineIteratorLineModernPath.h:
(WebCore::InlineIterator::LineIteratorModernPath::contentLogicalLeft const):
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
- layout/integration/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::contentLogicalOffset const):
(WebCore::LayoutIntegration::Line::contentLeft const): Deleted.
- layout/integration/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::makeAdjustedContent):
- 7:58 AM Changeset in webkit [289470] by
-
- 2 edits1 add in trunk/Tools
[Flatpak SDK] Add a wrapper for clangd
https://bugs.webkit.org/show_bug.cgi?id=236240
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py: Refactor this file so that the build constants can be
reused in the new script.
(convert_webkit_source_path_to_sandbox_path):
(convert_sandbox_path_to_webkit_source_path):
(get_build_dir):
(WebkitFlatpak.init):
(WebkitFlatpak.clean_args):
(WebkitFlatpak.setup_gstbuild):
(WebkitFlatpak.is_build_jsc):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.main):
(WebkitFlatpak.check_toolchains_generated):
(WebkitFlatpak.pack_toolchain):
(WebkitFlatpak.host_path_to_sandbox_path): Deleted.
(WebkitFlatpak.sandbox_path_to_host_path): Deleted.
- flatpak/webkit-clangd: Added.
- 7:13 AM Changeset in webkit [289469] by
-
- 14 edits in trunk/Source
Non-unified build fixes after r289247
https://bugs.webkit.org/show_bug.cgi?id=236343
Reviewed by Fujii Hironori.
Source/JavaScriptCore:
- runtime/JSRemoteFunction.h: Drive-by fix, add missing include.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp: Drive-by fix. Missing
include.
- layout/formattingContexts/inline/display/InlineDisplayLine.h:
Drive-by fix. Missing include.
- workers/shared/SharedWorkerObjectConnection.cpp:
SharedWorkerScriptLoader only forward-declares WorkerScriptLoader.
- workers/shared/SharedWorkerScriptLoader.h: Missing CompletionHandler
include.
- workers/shared/context/SharedWorkerContextManager.cpp:
SharedWorkerThreadProxy only forward-declares SharedWorkerThread
Source/WebKit:
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp: Moved
SharedWorkerKey include to .h file, as it declares a HashMap of it and
it has custom HashTraits that must be visible.
- NetworkProcess/SharedWorker/WebSharedWorkerServer.h: Ditto.
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp: Add
missing includes.
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h: Add
missing includes and forward declarations.
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
Add missing include with proper coder/decoder support.
- 6:56 AM Changeset in webkit [289468] by
-
- 2 edits in trunk/Tools
Allow hanging run-javascriptcore-tests to print backtrace
https://bugs.webkit.org/show_bug.cgi?id=236355
Reviewed by Aakash Jain.
This is to debug 'command timed out: 3600 seconds without output'
issues on build.webkit.org, same as we do for EWS.
- CISupport/build-webkit-org/steps.py:
(RunJavaScriptCoreTests.init):
- 5:49 AM Changeset in webkit [289467] by
-
- 8 edits3 adds in trunk
WebDriver: add a javascript atom to get the visible text
https://bugs.webkit.org/show_bug.cgi?id=174617
<rdar://problem/32307461>
Reviewed by Adrian Perez de Castro.
Source/WebDriver:
Generate the JavaScript atoms using the new command and use the new atom to get element text.
- CMakeLists.txt:
- Session.cpp:
(WebDriver::Session::getElementText):
Source/WebKit:
Add a new JavaScript atom to get the visible text according to the spec. The new atom uses code from other atoms
like ElementDisplayed and it's also used now by FindNodes one. The atoms are now autogenerated using a script to
include the duplicated code from a common source utils.js.
- Scripts/generate-automation-atom.py: Added.
(collect_utils):
(parse_utils):
(append_functions):
(main):
- UIProcess/Automation/atoms/ElementDisplayed.js:
(isShown.nodeIsElement): Deleted.
(isShown.parentElementForElement): Deleted.
(isShown.enclosingNodeOrSelfMatchingPredicate): Deleted.
(isShown.enclosingElementOrSelfMatchingPredicate): Deleted.
(isShown.cascadedStylePropertyForElement): Deleted.
(isShown.elementSubtreeHasNonZeroDimensions): Deleted.
(isShown): Deleted.
(isShown.isElementSubtreeHiddenByOverflow): Deleted.
- UIProcess/Automation/atoms/ElementText.js: Added.
- UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):
- UIProcess/Automation/atoms/utils.js: Added.
(utils.nodeIsElement):
(utils.enclosingNodeOrSelfMatchingPredicate):
(utils.parentElementForElement):
(utils.cascadedStylePropertyForElement):
(elementSubtreeHasNonZeroDimensions):
(isElementSubtreeHiddenByOverflow):
(utils.isShown):
(appendLines.currentLine):
(appendLines):
(utils.getText):
WebDriverTests:
Remove expectations of tests that are now passing.
- TestExpectations.json:
- 4:42 AM Changeset in webkit [289466] by
-
- 7 edits in trunk
[CSS Container Queries] Implement inline-size containment
https://bugs.webkit.org/show_bug.cgi?id=236354
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt:
Source/WebCore:
"Giving an element inline-size containment applies size containment to the inline-axis sizing
of its principal box. This means the inline-axis intrinsic sizes of the principal box are
determined as if the element had no content."
https://drafts.csswg.org/css-contain-3/#containment-inline-size
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
Compute inline axis preferred width as if the block had no content.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::effectiveContainment const):
- rendering/style/RenderStyleConstants.h:
For completeness, add an enum value for inline-size containment. It can only be set by 'container'
property for now.
- style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):
Ignore block axis for inline-size containers.
- 2:37 AM Changeset in webkit [289465] by
-
- 24 edits in trunk
[Forms] Improving applyStep() to be in line with specs
https://bugs.webkit.org/show_bug.cgi?id=236134
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt:
Source/WebCore:
This is to improve applyStep() func to follow specs at
https://html.spec.whatwg.org/multipage/input.html#dom-input-stepup
Since Chromium implementation follows the specs steps, this patch imports the
Chromium implmentation.
This is a further patch after https://bugs.webkit.org/show_bug.cgi?id=235509. It has corrected
some changes on test files in fast/form directory in the previous patch submitted for Bug
- With this CL a few more sub-tests are now passing.
- html/InputType.cpp:
(WebCore::InputType::applyStep):
- html/StepRange.cpp:
(WebCore::StepRange::stepSnappedMaximum const):
- html/StepRange.h:
LayoutTests:
Update test expectations.
- fast/forms/date/date-stepup-stepdown-expected.txt:
- fast/forms/date/date-stepup-stepdown.html:
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt:
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html:
- fast/forms/month/month-stepup-stepdown-expected.txt:
- fast/forms/month/month-stepup-stepdown.html:
- fast/forms/number/number-stepup-stepdown-expected.txt:
- fast/forms/number/number-stepup-stepdown.html:
- fast/forms/range/range-stepup-stepdown-expected.txt:
- fast/forms/range/range-stepup-stepdown.html:
- fast/forms/time/time-stepup-stepdown-expected.txt:
- fast/forms/time/time-stepup-stepdown.html:
- fast/forms/week/week-stepup-stepdown-expected.txt:
- fast/forms/week/week-stepup-stepdown.html:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt:
- 1:52 AM Changeset in webkit [289464] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Garden several WPT tests that are now passing
Unreviewed test gardening.
- platform/glib/TestExpectations:
- 1:30 AM Changeset in webkit [289463] by
-
- 14 edits in trunk/Source/WebKit
WKHoverPlatter should scale up the platter content to make it easier to see
https://bugs.webkit.org/show_bug.cgi?id=236289
Reviewed by Wenson Hsieh.
- Shared/NativeWebMouseEvent.h:
- Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
Add a NativeWebMouseEvent constructor that takes most properties from
another event, but allows overriding the positions and deltas.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactableRegionsInRootViewCoordinates):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::interactableRegionsInRootViewCoordinates):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Add a method to count the number of clickable elements in a given rectangle.
This is just a first attempt at the heuristic; this will get more complex in the future.
- UIProcess/ios/WKContentViewInteraction.h:
Add a selection assistant suppression reason for WKHoverPlatter.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureHighlightLongPressGestureRecognizer]):
Factor out highlight-long-press gesture creation like long-press. Bail if the platter is enabled.
(-[WKContentView setUpInteraction]):
Disable the selection assistant if WKHoverPlatter wants to use long press.
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _locationForGesture:]):
(-[WKContentView _startPointForGesture:]):
Add funnels for extracting the primary location or starting location from
a gesture, allowing WKHoverPlatter to mutate it if it is currently engaged.
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _nonBlockingDoubleTapRecognized:]):
(-[WKContentView _twoFingerDoubleTapRecognized:]):
Adopt _locationForGesture/_startPointForGesture.
(-[WKContentView _longPressRecognized:]):
Adopt _locationForGesture/_startPointForGesture.
Redirect a recognized long press to WKHoverPlatter if it wants to use long press.
(-[WKContentView _shouldUseContextMenus]):
Disable context menus if WKHoverPlatter wants to use long press.
(-[WKContentView setUpDragAndDropInteractions]):
Disable drag and drop if WKHoverPlatter wants to use long press.
(-[WKContentView mouseGestureRecognizerChanged:]):
Allow WKHoverPlatter to mutate the location of mouse events if it is currently engaged.
(-[WKContentView numberOfLinksForHoverPlatter:inRect:completionHandler:]):
- UIProcess/ios/WKHoverPlatter.h:
- UIProcess/ios/WKHoverPlatter.mm:
(-[WKHoverPlatter initWithView:delegate:]):
(-[WKHoverPlatter didReceiveMouseEvent:]):
(-[WKHoverPlatter didLongPressAtPoint:]):
(-[WKHoverPlatter platterBoundingRect]):
(-[WKHoverPlatter linkSearchRect]):
(-[WKHoverPlatter update]):
(-[WKHoverPlatter updateDebugIndicator]):
(-[WKHoverPlatter dismissPlatterWithAnimation:]):
(-[WKHoverPlatter didFinishDismissalAnimation:]):
(-[WKHoverPlatter clearLayers]):
(-[WKHoverPlatter adjustedPointForPoint:]):
(-[WKHoverPlatter adjustedEventForEvent:]):
(setAdditionalPlatterLayerProperties): Deleted.
(addAdditionalIncomingAnimations): Deleted.
(addAdditionalDismissalAnimations): Deleted.
(-[WKHoverPlatter setHoverPoint:]): Deleted.
(-[WKHoverPlatter requestPositionInformationForCurrentHoverPoint]): Deleted.
(-[WKHoverPlatter didReceivePositionInformation:]): Deleted.
(-[WKHoverPlatter didFinishAnimationForShadow:]): Deleted.
- UIProcess/ios/WKHoverPlatterParameters.h:
- UIProcess/ios/WKHoverPlatterParameters.mm:
(-[WKHoverPlatterParameters setDefaultValues]):
(-[WKHoverPlatterParameters enabled]):
(+[WKHoverPlatterParameters settingsControllerModule]):
(addAdditionalPlatterLayoutParameters): Deleted.
(setDefaultValuesForAdditionalPlatterLayoutParameters): Deleted.
Adjust WKHoverPlatter to scale up its content, and adjust the shape
and animations.
- 1:15 AM Changeset in webkit [289462] by
-
- 14 edits2 adds in trunk
Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject
https://bugs.webkit.org/show_bug.cgi?id=236318
<rdar://88580935>
Reviewed by Mark Lam.
Source/WebCore:
This patch makes it so we might not accidentally return the empty value to
JavaScript code from JSValueInWrappedObject. Previously, JSValueInWrappedObject
had an "operator JSValue()" method. This patch removes that, adds a new
conversion method for converting between JSValueInWrappedObject and JSValue,
and makes JSValueInWrappedObject return undefined inside this method
when it used to return the empty value. This fixes a crash where we'd return
the empty value to JS JIT code, and crash dereferencing a nullptr. It's never
valid for a JS function call (or getter, etc) to return the empty value.
Test: fast/dom/AbortSignal-reason-crash-2.html
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::getChannelData):
- Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::toJSArray):
(WebCore::toJSObject):
(WebCore::AudioWorkletProcessor::buildJSArguments):
- bindings/js/JSCustomEventCustom.cpp:
(WebCore::JSCustomEvent::detail const):
- bindings/js/JSDOMConvertAny.h:
(WebCore::JSConverter<IDLAny>::convert):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data const):
- bindings/js/JSPaymentMethodChangeEventCustom.cpp:
(WebCore::JSPaymentMethodChangeEvent::methodDetails const):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state const):
- bindings/js/JSValueInWrappedObject.h:
(WebCore::JSValueInWrappedObject::getValue const):
(WebCore::JSValueInWrappedObject::operator bool const):
(WebCore::cachedPropertyValue):
(WebCore::JSValueInWrappedObject::operator JSC::JSValue const): Deleted.
- dom/AbortSignal.cpp:
(WebCore::AbortSignal::signalFollow):
(WebCore::AbortSignal::throwIfAborted):
- dom/ErrorEvent.cpp:
(WebCore::ErrorEvent::error):
(WebCore::ErrorEvent::trySerializeError):
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::trySerializeState):
- page/History.cpp:
(WebCore::History::cachedState):
LayoutTests:
- fast/dom/AbortSignal-reason-crash-2-expected.txt: Added.
- fast/dom/AbortSignal-reason-crash-2.html: Added.
- 1:14 AM Changeset in webkit [289461] by
-
- 1 copy in releases/WebKitGTK/webkit-2.35.3
WebKitGTK 2.35.3
- 1:13 AM Changeset in webkit [289460] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.35.3.
- 12:47 AM Changeset in webkit [289459] by
-
- 61 edits16 adds3 deletes in trunk/LayoutTests
[GTK][WPE] Update baselines after r288944
Unreviewed test gardening.
The bulk of these tests needed to update their baselines after
r288944, although other baseline updates in this patch might not due
to that change.
- platform/glib/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
- platform/glib/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/glib/webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt:
- platform/gtk/editing/deleting/5144139-2-expected.png:
- platform/gtk/editing/deleting/5144139-2-expected.txt:
- platform/gtk/fast/borders/rtl-border-04-expected.txt:
- platform/gtk/fast/borders/rtl-border-05-expected.png:
- platform/gtk/fast/borders/rtl-border-05-expected.txt:
- platform/gtk/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/text/basic/014-expected.txt:
- platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
- platform/gtk/fast/text/international/003-expected.png:
- platform/gtk/fast/text/international/003-expected.txt:
- platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/gtk/fast/text/international/bidi-european-terminators-expected.png:
- platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/gtk/fast/text/international/bidi-innertext-expected.png:
- platform/gtk/fast/text/international/bidi-innertext-expected.txt:
- platform/gtk/fast/text/international/bidi-menulist-expected.png:
- platform/gtk/fast/text/international/bidi-menulist-expected.txt:
- platform/gtk/fast/text/international/bidi-override-expected.png:
- platform/gtk/fast/text/international/bidi-override-expected.txt:
- platform/gtk/fast/text/international/rtl-caret-expected.png:
- platform/gtk/fast/text/international/rtl-caret-expected.txt:
- platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/gtk/fast/text/midword-break-after-breakable-char-expected.txt:
- platform/gtk/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Removed.
- platform/gtk/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
- platform/wpe/fast/borders/rtl-border-04-expected.png: Added.
- platform/wpe/fast/borders/rtl-border-04-expected.txt:
- platform/wpe/fast/borders/rtl-border-05-expected.png: Added.
- platform/wpe/fast/borders/rtl-border-05-expected.txt:
- platform/wpe/fast/events/updateLayoutForHitTest-expected.png: Added.
- platform/wpe/fast/events/updateLayoutForHitTest-expected.txt:
- platform/wpe/fast/text/basic/014-expected.png: Added.
- platform/wpe/fast/text/basic/014-expected.txt:
- platform/wpe/fast/text/in-rendered-text-rtl-expected.png: Added.
- platform/wpe/fast/text/in-rendered-text-rtl-expected.txt:
- platform/wpe/fast/text/international/003-expected.txt:
- platform/wpe/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
- platform/wpe/fast/text/international/bidi-L2-run-reordering-expected.txt:
- platform/wpe/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/wpe/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/wpe/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/wpe/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/wpe/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/wpe/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/wpe/fast/text/international/bidi-european-terminators-expected.png: Added.
- platform/wpe/fast/text/international/bidi-european-terminators-expected.txt:
- platform/wpe/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
- platform/wpe/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/wpe/fast/text/international/bidi-innertext-expected.png: Added.
- platform/wpe/fast/text/international/bidi-innertext-expected.txt:
- platform/wpe/fast/text/international/bidi-menulist-expected.png: Added.
- platform/wpe/fast/text/international/bidi-menulist-expected.txt:
- platform/wpe/fast/text/international/bidi-override-expected.png: Added.
- platform/wpe/fast/text/international/bidi-override-expected.txt:
- platform/wpe/fast/text/international/rtl-caret-expected.png: Added.
- platform/wpe/fast/text/international/rtl-caret-expected.txt:
- platform/wpe/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
- platform/wpe/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/wpe/fast/text/midword-break-after-breakable-char-expected.png: Added.
- platform/wpe/fast/text/midword-break-after-breakable-char-expected.txt:
- platform/wpe/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- 12:34 AM Changeset in webkit [289458] by
-
- 3 edits in trunk/Source/WebCore
Remove some obsolete dependencies.
https://bugs.webkit.org/show_bug.cgi?id=236333
Reviewed by Chris Dumez.
These files in the dependency list don't even exist anymore.
- bindings/scripts/preprocess-idls.pl:
- bindings/scripts/test/SupplementalDependencies.dep:
Feb 8, 2022:
- 11:35 PM Changeset in webkit [289457] by
-
- 10 edits in trunk/Source/WebCore
[CSS Container Queries] Track query containers so they can be invalidated on size change
https://bugs.webkit.org/show_bug.cgi?id=236297
Reviewed by Alan Bujtas.
Add container size tracking.
- dom/Document.cpp:
(WebCore::Document::updateLayout):
- dom/Element.cpp:
(WebCore::Element::invalidateForQueryContainerChange):
- dom/Element.h:
- page/FrameView.cpp:
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleWillChange):
- rendering/RenderView.cpp:
(WebCore::RenderView::registerContainerQueryBox):
(WebCore::RenderView::unregisterContainerQueryBox):
- rendering/RenderView.h:
- style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):
Save the sizes after layout and invalidate if needed.
- style/StyleScope.h:
- 10:51 PM Changeset in webkit [289456] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
Expand fuzzy ranges.
- compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html:
- compositing/masks/become-tiled-mask.html:
- css3/masking/mask-repeat-space-padding.html:
- 10:39 PM Changeset in webkit [289455] by
-
- 8 edits in trunk/Source/WebCore
Move DocumentTimeline::runningAnimationsForRendererAreAllAccelerated() to Styleable
https://bugs.webkit.org/show_bug.cgi?id=236239
Reviewed by Dean Jackson.
This method has nothing to do with DocumentTimeline and everything to do with Styleable and its associated
effect stack. This also allows us to remove WebAnimation::isRunningAccelerated() since we don't need to go
through the animation as we iterate over keyframe effects directly.
This refactor surfaced an issue with Styleable::fromRenderer() where in the ::marker case we would fail
to correctly obtain the parent RenderListItem, we now recurse through parents until we find one instead
of stopping at the first ancestor with an element.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::runningAnimationsForRendererAreAllAccelerated const): Deleted.
- animation/DocumentTimeline.h:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::isRunningAccelerated const): Deleted.
- animation/WebAnimation.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasRunningAcceleratedAnimations const):
- style/Styleable.cpp:
(WebCore::Styleable::fromRenderer):
(WebCore::Styleable::runningAnimationsAreAllAccelerated const):
- style/Styleable.h:
- 10:25 PM Changeset in webkit [289454] by
-
- 5 edits in trunk
[web-animations] additive and accumulation interpolation does not work correctly with implicit 0% and 100% keyframes
https://bugs.webkit.org/show_bug.cgi?id=236314
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Add some new WPT tests and mark our PASS results for the "add" case (we still fail for "accumulate").
- web-platform-tests/web-animations/animation-model/combining-effects/effect-composition-expected.txt:
- web-platform-tests/web-animations/animation-model/combining-effects/effect-composition.html:
Source/WebCore:
We incorrectly handled implicit keyframes for the additive and accumulate cases.
The spec says that for implicit 0% and 100% keyframes, a keyframe should be generated with a "neutral" keyframe which,
when added or accumulated with another keyframe, would yield the same style as the keyframe it's composed with. We sort
of did the right thing by cloning the underlying style for those keyframes, but then we would blame them anyway in the
composition case, whereas we should just use the underlying style as-is.
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
- 10:22 PM Changeset in webkit [289453] by
-
- 4 edits in trunk
[web-animations] Animation.commitStyles() should use the non-animated style
https://bugs.webkit.org/show_bug.cgi?id=236315
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark WPT progression.
- web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt:
Source/WebCore:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::commitStyles):
- 8:59 PM Changeset in webkit [289452] by
-
- 4 edits in trunk/LayoutTests
[GLIB] Remove tests passing from TestExpectations
Unreviewed test gardening.
Also sort lines in TestExpectations.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 6:32 PM Changeset in webkit [289451] by
-
- 4 edits in trunk
FileReaderSync should be exposed to shared workers
https://bugs.webkit.org/show_bug.cgi?id=236317
<rdar://problem/88644122>
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
- web-platform-tests/workers/semantics/interface-objects/003.any.sharedworker-expected.txt:
Source/WebCore:
FileReaderSync should be exposed to shared workers:
No new test, rebaselined existing one.
- fileapi/FileReaderSync.idl:
- 5:54 PM Changeset in webkit [289450] by
-
- 4 edits1 add in trunk
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
https://bugs.webkit.org/show_bug.cgi?id=236332
rdar://88483574
Reviewed by Michael Saboff.
JSTests:
- stress/yarr-inlining-dot-star-enclosure.js: Added.
(test):
Source/JavaScriptCore:
YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
- yarr/YarrJIT.cpp:
- yarr/YarrJITRegisters.h:
- 4:35 PM Changeset in webkit [289449] by
-
- 7 edits in trunk/Source/WebKit
[Playstation] Fix build break after r289247 if ENABLE_SERVICE_WORKER is off
https://bugs.webkit.org/show_bug.cgi?id=236321
Patch by Jigen Zhou <jigen.zhou@sony.com> on 2022-02-08
Reviewed by Chris Dumez.
Unreviewed, build fix for playstation platform after r289247 for support of sharing Shared Workers.
This patch resolves compiling errors caused by unknow type name and undeclared identifiers,
and it also fixes linking error by making methods WebProcessProxy::createForWorkers and
WebProcessPool::userContentControllerIdentifierForWorkers() available when ENABLE_SERVICE_WORKER is off
- NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:
- UIProcess/WebProcessPool.cpp:
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
- 4:26 PM Changeset in webkit [289448] by
-
- 1 copy in tags/Safari-613.1.16.3.1
Tag Safari-613.1.16.3.1.
- 4:19 PM Changeset in webkit [289447] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Set LineBox::setBaselineType when the line is computed to be IdeographicBaseline
https://bugs.webkit.org/show_bug.cgi?id=236310
Reviewed by Antti Koivisto.
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):
- 4:17 PM Changeset in webkit [289446] by
-
- 1 copy in tags/Safari-613.1.16.0.5
Tag Safari-613.1.16.0.5.
- 4:14 PM Changeset in webkit [289445] by
-
- 1 copy in tags/Safari-613.1.16.1.4
Tag Safari-613.1.16.1.4.
- 4:14 PM Changeset in webkit [289444] by
-
- 1 copy in tags/Safari-613.1.16.2.1
Tag Safari-613.1.16.2.1.
- 3:49 PM Changeset in webkit [289443] by
-
- 3 edits2 adds in trunk
REGRESSION (15.4): Angular virtual scrollers no longer work (because of contain:strict)
https://bugs.webkit.org/show_bug.cgi?id=236260
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-08
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/contain-paint-049-expected.txt: Added.
- web-platform-tests/css/css-contain/contain-paint-049.html: Added.
Source/WebCore:
Paint containment did not allow collecting scrollable overflow, breaking scrolling
of the container contents, this patch fixes that.
Test: imported/w3c/web-platform-tests/css/css-contain/contain-paint-049.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
- 3:30 PM Changeset in webkit [289442] by
-
- 1 copy in releases/WPE WebKit/webkit-2.34.5
WPE WebKit 2.34.5
- 3:11 PM Changeset in webkit [289441] by
-
- 4 edits in releases/WebKitGTK/webkit-2.34
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.5 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.34.5
- 3:07 PM Changeset in webkit [289440] by
-
- 1 copy in tags/Safari-613.1.16.31.1
Tag Safari-613.1.16.31.1.
- 3:06 PM Changeset in webkit [289439] by
-
- 3 edits in branches/safari-613.1.16.31-branch/Source/JavaScriptCore
Cherry-pick r289024. rdar://problem/88654211
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
<rdar://88222677>
Reviewed by Mark Lam.
- assembler/SecureARM64EHashPins.cpp: (JSC::SecureARM64EHashPins::initializeAtStartup): (JSC::SecureARM64EHashPins::allocatePinForCurrentThread): (JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:55 PM Changeset in webkit [289438] by
-
- 9 edits in branches/safari-613.1.16.31-branch/Source
Versioning.
WebKit-7613.1.16.31.1
- 2:51 PM Changeset in webkit [289437] by
-
- 3 edits in trunk/Source/WebCore
Grid may be empty in certain scenarios
https://bugs.webkit.org/show_bug.cgi?id=234578
Patch by Brandon Stewart <Brandon> on 2022-02-08
Reviewed by Darin Adler.
Add check to handle legend elements when inside a CSS Grid. The legend element should not be
added to aspectRatioBlockSizeDependentGridItems.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderGrid.h:
- 2:43 PM Changeset in webkit [289436] by
-
- 2 edits in trunk/Source/WebKit
[WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS
https://bugs.webkit.org/show_bug.cgi?id=236151
rdar://87908259
Reviewed by Brent Fulgham.
This patch starts using the ASC apis to make WebAuthn calls on iOS the
same way they are made on macOS. Some cleanup work will be needed to
deprecate the WebAuthn process after this change is made.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Deleted.
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): Deleted.
- 2:35 PM Changeset in webkit [289435] by
-
- 1 copy in branches/safari-613.1.16.31-branch
New branch.
- 2:27 PM Changeset in webkit [289434] by
-
- 1 copy in releases/WebKitGTK/webkit-2.34.5
WebKitGTK 2.34.5
- 2:25 PM Changeset in webkit [289433] by
-
- 4 edits in releases/WebKitGTK/webkit-2.34
.:
Unreviewed. Update OptionsGTK.cmake and NEWS for the 2.34.5 release
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.5 release
- gtk/NEWS: Add release notes for 2.34.5
- 2:25 PM Changeset in webkit [289432] by
-
- 6 edits in releases/WebKitGTK/webkit-2.34
Allow building with ICU 60
https://bugs.webkit.org/show_bug.cgi?id=235367
Unreviewed build fix.
Turns out we can reduce our ICU requirement from ICU 61 to ICU 60 with only minimal changes.
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-02-08
.:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/JavaScriptCore:
- runtime/IntlCache.cpp:
- runtime/IntlCache.h:
- 2:25 PM Changeset in webkit [289431] by
-
- 2 edits in releases/WebKitGTK/webkit-2.34
Merge r289370 - [WPE] Running distcheck with USE_SOUP2=OFF fails to install documentation
https://bugs.webkit.org/show_bug.cgi?id=236235
Reviewed by Carlos Garcia Campos.
- Source/PlatformWPE.cmake: Use WPE_API_DOC_VERSION instead of WPE_API_VERSION for the documentation.
- 2:25 PM Changeset in webkit [289430] by
-
- 5 edits in releases/WebKitGTK/webkit-2.34/Source/WebKit
Merge r289369 - [GTK][WPE] Crash at WebKit::bindA11y() in WebKitGTK 2.35.2
https://bugs.webkit.org/show_bug.cgi?id=236144
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-02-08
Reviewed by Adrian Perez de Castro.
ATSPI stopped using an abstract socket but we are still assuming the a11y bus address is an abstract socket,
even when the path is not really used after all. However, just handling the case of the socket being a normal
unix socket is not enough, because the actual socket path is not mounted in the xdg-dbus-proxy sandbox, so it
fails to connect to the original a11y bus.
- UIProcess/Launcher/ProcessLauncher.h: Rename extraWebProcessSandboxPaths as extraSandboxPaths.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::XDGDBusProxyLauncher::setAddress): Remove the DBusAddressType parameter. Check the address looks valid
and just store the result of dbusAddressToPath() in m_path.
(WebKit::XDGDBusProxyLauncher::launch): Do not require m_path to be non-null and add it to the sanbox.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Only return the path for normal unix sockets.
(WebKit::bindDBusSession): Remove the DBusAddressType parameter passed to dbusAddressToPath().
(WebKit::bindA11y): Check proxy path is not null before setting a11y bus address in display.
(WebKit::addExtraPaths): Helper to add extra paths to the sandbox.
(WebKit::bubblewrapSpawn): Call addExtraPaths() for WebProcess and DBusProxy types.
- UIProcess/Launcher/glib/FlatpakLauncher.cpp:
(WebKit::flatpakSpawn): Use extraSandboxPaths.
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions): Ditto.
- 2:25 PM Changeset in webkit [289429] by
-
- 8 edits in releases/WebKitGTK/webkit-2.34/Source/WebCore
Merge r289154 - [Flatpak SDK] Update to FDO 21.08.10 and GStreamer 1.20 releases
https://bugs.webkit.org/show_bug.cgi?id=236136
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-05
Reviewed by Adrian Perez de Castro.
Switch GStreamer 1.19 version checks to 1.20 now that it is officially released. Also
include a couple fixes that are needed with GStreamer 1.20 and one that is useful whatever
the GStreamer version:
- GStreamer 1.20 ships a vp8alphadecodebin element able to handle video/x-vp8 caps, so our libwebrtc decoder factory needs to account for its presence, in addition to vp8dec.
- With GStreamer 1.20 media/media-source/media-source-seek-back.html started racy crashing in the VideoTrackPrivateGStreamer configuration update, where the track was disconnected (hence its stream was cleared) and then a GObject notification was emitted by decodebin3. We should actually disconnect the GObject signal handlers before clearing the stream, to prevent potential null pointer access.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleNewDeinterleavePad):
- platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/GStreamerCommon.h:
- platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::disconnect):
- platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP8Decoder::Create):
- 2:21 PM Changeset in webkit [289428] by
-
- 3 edits in trunk/Tools
[EWS] Embed added/modified/deleted status into changed files
https://bugs.webkit.org/show_bug.cgi?id=236051
Reviewed by Aakash Jain.
GitHub's API includes whether a file was added, modified or deleted.
We don't include this information in source changes, we should.
- Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits.file_with_mod_sign): Added.
(GitHubEventHandlerNoEdits._get_pr_files): Copied from buildbot, modified to include
file modification status.
- Tools/CISupport/ews-build/steps.py:
(FindModifiedLayoutTests): Remove FIXME
Canonical link: https://commits.webkit.org/246988@main
- 2:14 PM Changeset in webkit [289427] by
-
- 4 edits in trunk/Source/WebCore
Initialize the AXIsolatedObject AccessibilityText property lazily.
https://bugs.webkit.org/show_bug.cgi?id=236276
<rdar://problem/88604453>
Reviewed by Chris Fleizach.
Computation of the AccessibilitytText property may be very expensive and
if performed during the creation of IsolatedObjects may cause crashes
since it may invoke textUnderElement while page layout is in progress.
For these reasons, we are computing and caching this property on first
request.
This patch is a sequel to https://bugs.webkit.org/show_bug.cgi?id=236115.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::accessibilityText const):
(WebCore::AXIsolatedObject::getOrRetrievePropertyValue):
(WebCore::AXIsolatedObject::innerHTML const):
(WebCore::AXIsolatedObject::outerHTML const):
(WebCore::AXIsolatedObject::getOrRetrieveStringPropertyValue):
Replaced by getOrRetrievePropertyValue<String>.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::descriptionAttributeValue const):
(WebCore::AXIsolatedObject::titleAttributeValue const):
- 2:06 PM Changeset in webkit [289426] by
-
- 6 edits in trunk
[css-logical] [css-animations] changing "direction" or "writing-mode" should recompute keyframes
https://bugs.webkit.org/show_bug.cgi?id=236293
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark WPT progressions.
- web-platform-tests/css/css-logical/animation-002-expected.txt:
Source/WebCore:
We need to recompute keyframes based on the matching @keyframes rule in case an element running
a CSS Animation changes either "direction" or "writing-mode".
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::propertyAffectingLogicalPropertiesDidChange):
- animation/KeyframeEffect.h:
- animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyKeyframeEffects):
- 1:45 PM Changeset in webkit [289425] by
-
- 8 edits in trunk/Source/WebCore
[LFC][Integration] LineIteratorModernPath::baselineType should consult Display::Line
https://bugs.webkit.org/show_bug.cgi?id=236308
Reviewed by Antti Koivisto.
LineBox -> Display::Line -> LineIteratorModernPath (and the soon-to-be-removed LayoutIntegration::Line middleman).
- layout/formattingContexts/inline/InlineLineBox.h:
(WebCore::Layout::LineBox::baselineType const):
(WebCore::Layout::LineBox::setBaselineType):
- layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::baselineType const):
(WebCore::InlineDisplay::Line::Line):
- layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::build const):
- layout/integration/InlineIteratorLineModernPath.h:
(WebCore::InlineIterator::LineIteratorModernPath::baselineType const):
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
- layout/integration/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::baselineType const):
- layout/integration/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::makeAdjustedContent):
- 1:40 PM Changeset in webkit [289424] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
Resync workers/modules/shared-worker-import-meta.html from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=236302
Reviewed by Yusuke Suzuki.
Resync workers/modules/shared-worker-import-meta.html from upstream WPT after https://github.com/web-platform-tests/wpt/pull/32704.
- web-platform-tests/workers/modules/shared-worker-import-meta-expected.txt:
- web-platform-tests/workers/modules/shared-worker-import-meta.html:
- 1:33 PM Changeset in webkit [289423] by
-
- 4 edits in trunk/Tools
[git-webkit] Autostash when pulling (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=235861
<rdar://problem/88298948>
Unreviewed follow-up fix.
Accidently landed a previous iteration of the change.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.clear): Handle empty cache.
(Git.pull): Only autostash when rebasing.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
- 1:31 PM Changeset in webkit [289422] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
Apply patch. rdar://problem/82516118
- 1:20 PM Changeset in webkit [289421] by
-
- 3 edits2 adds in branches/safari-613-branch
Cherry-pick r288944. rdar://problem/88059633
[LFC][IFC] Using Fontcascade::spaceWidth to subtract the trailing space width may result in incorrect layout
https://bugs.webkit.org/show_bug.cgi?id=235937
<rdar://88059633>
Reviewed by Antti Koivisto and Simon Fraser.
Source/WebCore:
Since Fontcascade::spaceWidth always consult the primary font, it may return unexpected width value when (in rare cases)
the primary font does not have a space glyph. Legacy line layout works as expected as it always runs a full width
computation on the space character (instead of directly calling FontCascade::spaceWidth).
- layout/formattingContexts/inline/InlineItemsBuilder.cpp: (WebCore::Layout::InlineItemsBuilder::computeInlineTextItemWidths):
- layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::width): (WebCore::Layout::TextUtil::spaceWidth):
- layout/formattingContexts/inline/text/TextUtil.h:
LayoutTests:
- platform/mac-bigsur/fonts/monospace-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:20 PM Changeset in webkit [289420] by
-
- 4 edits in branches/safari-613-branch/Source/WebCore/layout/formattingContexts/inline
Cherry-pick r288055. rdar://problem/88059633
[LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fails with incorrect run position
https://bugs.webkit.org/show_bug.cgi?id=235011
Reviewed by Antti Koivisto.
IFC (inherited from simple line layout) uses this technique of measuring the content with the trailing whitespace
and then simply subtract the whitespace width. It enables us to keep pushing content to the line without re-measuring it each time.
(the "non-whitespace + whitespace" pattern is extremely common for IFC content).
However in some cases when the trailing whitespace is trimmed, subtracting the trimmed width from the
content width instead of measuring it produces a visually incorrect result.
This patch fixes the most obvious cases when the incorrect width turns into an offset for the RTL content.
- layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::TrimmableTrailingContent::remove): (WebCore::Layout::Line::Run::removeTrailingLetterSpacing): (WebCore::Layout::Line::Run::removeTrailingWhitespace):
- layout/formattingContexts/inline/InlineLine.h:
- layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::width):
- layout/formattingContexts/inline/text/TextUtil.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:16 PM Changeset in webkit [289419] by
-
- 4 edits in trunk/Source
http/tests/cache-storage/cache-origins.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=236263
Reviewed by Darin Adler.
Source/WebCore:
Drop workaround landed in r289247 to try and maintain HashMap ordering.
- page/SecurityOriginData.h:
(WebCore::add):
Source/WebKit:
Update CacheStorage::Engine::representation() (which is used by the layout tests) to return
origins in a stable order in order to address test flakiness.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::representation):
- 12:45 PM Changeset in webkit [289418] by
-
- 5 edits2 moves in trunk/Source/WebCore
[GTK][WPE] Fallback path for WebGL rendering with ANGLE is incorrectly scheduling on the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=236290
Reviewed by Alejandro G. Castro.
Fix the WebGL ANGLE fallback path on nicosia to not incorrectly
schedule on the compositor thread.
No new tests, no change in behaviour.
- platform/TextureMapper.cmake:
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp: Renamed from Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.cpp.
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h: Renamed from Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.h.
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
(WebCore::GraphicsContextGLTextureMapper::GraphicsContextGLTextureMapper):
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::platformDisplay const):
(WebCore::GraphicsContextGLANGLE::platformConfig const):
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
- 12:42 PM Changeset in webkit [289417] by
-
- 35 edits3 adds in trunk
[JSC] move function wrapping logic to a new Function type
https://bugs.webkit.org/show_bug.cgi?id=235382
Reviewed by Yusuke Suzuki.
JSTests:
Adds a new file testing CopyNameAndLength stuff in the ShadowRealm proposal,
and fix up assertions about this in shadow-realm-evaluate.js
- stress/shadow-realm-evaluate.js:
- stress/shadow-realm-remote-function-copy-length-and-name.js: Added.
Source/JavaScriptCore:
In this initial patch, there is still a lot of JS-builtin machinery,
including some duplicated functionality. Additionally, JIT support
has not been incorporated yet.
Broadly, the idea is that there are custom hooks for calling a
JSRemoteFunction, which perform the wrapping functionality. This avoids
the need for allocating closures which contain the wrapping logic.
TODO:
- JIT/DFG/FTL support
- structure caching (unnecessary since these are not constructors?)
- improved baseline perf
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- assembler/LinkBuffer.h:
- builtins/BuiltinNames.h:
- builtins/ShadowRealmPrototype.js:
- bytecode/LinkTimeConstant.h:
- dfg/DFGSpeculativeJIT.cpp:
- ftl/FTLLowerDFGToB3.cpp:
- heap/Heap.cpp:
- heap/Heap.h:
- inspector/JSInjectedScriptHost.cpp:
- interpreter/Interpreter.cpp:
- jit/AssemblyHelpers.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- jsc.cpp:
- runtime/ErrorInstance.cpp:
- runtime/FunctionPrototype.cpp:
- runtime/InternalFunction.cpp:
- runtime/Intrinsic.cpp:
- runtime/Intrinsic.h:
- runtime/JSCast.h:
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
- runtime/JSFunctionInlines.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSRemoteFunction.cpp: Added.
- runtime/JSRemoteFunction.h: Added.
- runtime/VM.cpp:
- runtime/VM.h:
- 12:25 PM Changeset in webkit [289416] by
-
- 17 edits2 adds in trunk
Web Inspector: [Flexbox] Add support for showing/hiding flex container overlays and basic overlay drawing
https://bugs.webkit.org/show_bug.cgi?id=236013
<rdar://87893201>
Reviewed by Patrick Angle.
Source/JavaScriptCore:
Add new commands to show and hide flex overlays.
- inspector/protocol/DOM.json:
Source/WebCore:
Test: inspector/dom/showFlexOverlay.html
- The test follows the example for checking grid overlays at inspector/dom/showGridOverlay.html
Implement backend commands to toggle the visibility of a specialized page overlay shown on top of a flex container.
At this stage, the overlay consists of an outline around the bounding box of the flex container.
Future patches will add more detail regarding flex items and gaps between them.
This patch follows closely the example for toggling the visibility of CSS Grid overlays implemented in
https://bugs.webkit.org/show_bug.cgi?id=221062
- inspector/InspectorController.cpp:
(WebCore::InspectorController::flexOverlayCount const):
- inspector/InspectorController.h:
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::shouldShowOverlay const):
(WebCore::InspectorOverlay::removeFlexOverlayForNode):
(WebCore::InspectorOverlay::setFlexOverlayForNode):
(WebCore::InspectorOverlay::clearFlexOverlayForNode):
(WebCore::InspectorOverlay::clearAllFlexOverlays):
- Maintain a list of active flex overlays. A node can have only one flex overlay at a time.
(WebCore::InspectorOverlay::drawFlexOverlay):
(WebCore::InspectorOverlay::buildFlexOverlay):
- inspector/InspectorOverlay.h:
(WebCore::InspectorOverlay::flexOverlayCount const):
(WebCore::InspectorOverlay::Highlight::FlexHighlightOverlay::encode const):
(WebCore::InspectorOverlay::Highlight::FlexHighlightOverlay::decode):
- The signature of the flex overlay includes the color for the outline and a quad expressing the bounding box of the flex container.
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::showFlexOverlay):
(WebCore::InspectorDOMAgent::hideFlexOverlay):
- Translate protocol commands into InspectorOverlay method calls.
- inspector/agents/InspectorDOMAgent.h:
- testing/Internals.cpp:
(WebCore::Internals::inspectorFlexOverlayCount):
- testing/Internals.h:
- testing/Internals.idl:
- Helper used in testing to check the number of shown flex overlays.
Source/WebKit:
Add basic logic to draw a flex overlay on top of a flex container on iOS/iPadOS. Used by Web Inspector.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<InspectorOverlay::Highlight>::encode):
(IPC::ArgumentCoder<InspectorOverlay::Highlight>::decode):
- UIProcess/Inspector/ios/WKInspectorHighlightView.mm:
(-[WKInspectorHighlightView drawRect:]):
LayoutTests:
- inspector/dom/showFlexOverlay-expected.txt: Added.
- inspector/dom/showFlexOverlay.html: Added.
- inspector/dom/showGridOverlay.html:
- Drive-by clean-up of out-of-context comments.
- 11:59 AM Changeset in webkit [289415] by
-
- 5 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r288090. rdar://problem/87601499
Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers
https://bugs.webkit.org/show_bug.cgi?id=235226
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-01-17
Reviewed by Simon Fraser.
Claim memory from SharedBitmaps and SharedMemory that RemoteRenderingBackendProxy
asks and receives from RemoteRenderingBackend. This is not very good,
as GPUP allocates most of the memory and thus might jetsam
before WP claims them. However, that is a bigger change to be done
after this one.
No new tests, hard to test currently.
- Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::Handle::takeOwnershipOfMemory const):
- Shared/ShareableBitmap.h:
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::getShareableBitmap): (WebKit::RemoteRenderingBackendProxy::getFilteredImage):
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::recordNativeImageUse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:55 AM Changeset in webkit [289414] by
-
- 2 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r289076. rdar://problem/88269480
Unreviewed, remove UnlinkedMetadataTable::offsetInMetadataTable since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=236063
Follow-up after Saam's comment.
- bytecode/UnlinkedMetadataTable.h: (JSC::UnlinkedMetadataTable::offsetInMetadataTable): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:55 AM Changeset in webkit [289413] by
-
- 5 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r289037. rdar://problem/88269480
[JSC] Use MetadataTable instead of UnlinkedMetadataTable
https://bugs.webkit.org/show_bug.cgi?id=236063
rdar://88269480
Reviewed by Robin Morisset.
Use MetadataTable from profiled CodeBlock instead of UnlinkedMetadataTable in concurrent JIT compiler.
- bytecode/MetadataTable.h: (JSC::MetadataTable::offsetInMetadataTable):
- bytecode/UnlinkedMetadataTable.h: (JSC::UnlinkedMetadataTable::offsetInMetadataTable):
- jit/JITInlines.h: (JSC::JIT::emitValueProfilingSite): (JSC::JIT::loadPtrFromMetadata): (JSC::JIT::load32FromMetadata): (JSC::JIT::load8FromMetadata): (JSC::JIT::store8ToMetadata): (JSC::JIT::store32ToMetadata): (JSC::JIT::materializePointerIntoMetadata):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_resolve_scope): (JSC::JIT::emit_op_get_from_scope):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:55 AM Changeset in webkit [289412] by
-
- 3 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r288435. rdar://problem/83668578
MediaStream canvas.captureStream() playback to LocalSampleBufferDisplayLayer is flaky
https://bugs.webkit.org/show_bug.cgi?id=230623
<rdar://problem/83668578>
Reviewed by Kimmo Kinnunen.
There are a few issues when creating the video element, setting the srcObject and playing it right away.
The first thing is that we try to render the video element while thinking that it might be video accelerated
(it is always the case for MediaStreamTrack based tracks), but the video element is asynchronously updating whether it is accelerated.
Following what other MediaPlayerPrivate are doing, when MediaPlayerPrivateMediaStreamAVFObjC has set up its video layers,
we schedule a call to renderingModeChanged which will trigger a relayout.
We also ensure, when the layer is fully initialized to set all values (bounds, hide states) as otherwise, this might be lost on GPUProcess
which currently does not register a RemoteSampleBufferDisplayLayer at the time the corresponding IPC message is received.
The additional issue is in the case the MediaStreamTrack source only generates one frame for some time.
In that case, and if the frame is enqueueud while setting up the video layers, we were not rendering this frame.
To fix this, when the video layers are ready, we reenqueue the last video frame as neeeded.
Manually tested.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [289411] by
-
- 11 edits1 add in trunk
[git-webkit] Allow repositories to declare their bug trackers
https://bugs.webkit.org/show_bug.cgi?id=236306
<rdar://problem/88633018>
Reviewed by Dewei Zhu.
- metadata/trackers.json: Added.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.init): Raise correct exception.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.init): Raise correct exception.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py:
(Tracker.from_json): Handle list or tuple input.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): Use shared METADATA declaration.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.init): Register any bug trackers associated with the repository.
Canonical link: https://commits.webkit.org/246978@main
- 11:32 AM Changeset in webkit [289410] by
-
- 2 edits in trunk/Source/WebCore
Make HTMLToken::beginStartTag tag an 8 bit character
https://bugs.webkit.org/show_bug.cgi?id=236283
Reviewed by Sam Weinig.
HTMLToken::beginStartTag is only ever called with an ASCII lowercase
letter. It can take an LChar instead of a UChar, and we can avoid
updating m_data8BitCheck.
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::beginStartTag):
- 11:30 AM Changeset in webkit [289409] by
-
- 3 edits in trunk/Source/WebCore
[WebXR] Ensure only one frame update can be requested with the device at any time
https://bugs.webkit.org/show_bug.cgi?id=236247
Patch by Ada Chan <ada.chan@apple.com> on 2022-02-08
Reviewed by Dean Jackson.
Rename WebXRSession::requestFrame() to WebXRSession::requestFrameIfNeeded()
with logic added to determine whether a new frame update request should be
sent to the device. The boolean m_isDeviceFrameRequestPending tracks whether
a frame request is pending with the device, and requestFrameIfNeeded() should
bail early if that boolean is true.
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::requestAnimationFrame):
(WebCore::WebXRSession::updateSessionVisibilityState):
(WebCore::WebXRSession::requestFrameIfNeeded):
(WebCore::WebXRSession::onFrame):
(WebCore::WebXRSession::requestFrame): Deleted.
- Modules/webxr/WebXRSession.h:
- 11:29 AM Changeset in webkit [289408] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- gpu-process/TestExpectations:
- 11:22 AM Changeset in webkit [289407] by
-
- 3 edits in branches/safari-613.1.16.2-branch/Source/WebCore
Cherry-pick r288539. rdar://problem/87986840
Expand RefPtr / Ref use in FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=235551
rdar://87986840
Reviewed by Mark Lam.
Apply Ref / RefPtr instead of taking SerializedScriptValue*.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:21 AM Changeset in webkit [289406] by
-
- 9 edits in branches/safari-613.1.16.2-branch/Source
Versioning.
WebKit-7613.1.16.2.1
- 11:18 AM Changeset in webkit [289405] by
-
- 3 edits in branches/safari-613.1.16.3-branch/Source/JavaScriptCore
Cherry-pick r289354. rdar://problem/88611690
Wasm crash on https://copy.sh/v86/?profile=dsl
https://bugs.webkit.org/show_bug.cgi?id=236037
rdar://88358719
Reviewed by Mark Lam.
Lower stack args in Air had a bug where it was emitting a constant
materialization at the wrong instruction offset for certain types
of spill instructions. This happens when we have a stack slot that
is 8 bytes wide, but we're emitting a zero def Move32. We need to
zero the upper 4 bytes. However, there is also code inside lower
stack args that uses the temp register when encountering offsets
that are too large to encode in a single instruction. However,
this offset materialization code for the second Move32 to zero
the upper bytes was happening before the actual store. For example,
we'd end up with:
movz x16, #k
movz x16, #k2
stur x1, [x16]
stur zr, [x16]
instead of
movz x16, #k
stur x1, [x16]
movz x16, #k2
stur zr, [x16]
- b3/air/AirLowerStackArgs.cpp: (JSC::B3::Air::lowerStackArgs):
- b3/air/testair.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:18 AM Changeset in webkit [289404] by
-
- 3 edits in branches/safari-613.1.16.3-branch/Source/JavaScriptCore
Cherry-pick r289024. rdar://problem/88222677
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
<rdar://88222677>
Reviewed by Mark Lam.
- assembler/SecureARM64EHashPins.cpp: (JSC::SecureARM64EHashPins::initializeAtStartup): (JSC::SecureARM64EHashPins::allocatePinForCurrentThread): (JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:18 AM Changeset in webkit [289403] by
-
- 3 edits in branches/safari-613.1.16.3-branch/Source/WebCore
Cherry-pick r288539. rdar://problem/87986840
Expand RefPtr / Ref use in FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=235551
rdar://87986840
Reviewed by Mark Lam.
Apply Ref / RefPtr instead of taking SerializedScriptValue*.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:15 AM Changeset in webkit [289402] by
-
- 17 edits in trunk/LayoutTests
Unreviewed gardening.
LayoutTests/imported/mozilla:
- svg/opacity-and-gradient-02.svg: Expand pixel range based on EWS run.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-backgrounds/border-image-repeat-space-7.html: Expand pixel range based on EWS data.
- web-platform-tests/css/css-text/shaping/shaping-arabic-diacritics-001.html:
LayoutTests:
Reflecting pixel diffs from EWS run.
- css1/basic/class_as_selector.html:
- css3/background/background-repeat-round-auto1.html:
- css3/background/background-repeat-space-content.html:
- css3/color/box-shadows.html:
- css3/color/gradients.html:
- fast/css/heightless-list-item.html:
- fast/css/object-position/object-position-img-svg.html:
- fast/gradients/alpha-premultiplied.html:
- fast/text/simple-line-layout-line-box-contain-glyphs.html:
- fast/text/simple-line-layout-text-position-with-stroke.html:
- svg/animations/multiple-animateTransform-additive-sum.svg:
- 11:14 AM Changeset in webkit [289401] by
-
- 3 edits in branches/safari-613.1.16.0-branch/Source/JavaScriptCore
Cherry-pick r289354. rdar://problem/88611690
Wasm crash on https://copy.sh/v86/?profile=dsl
https://bugs.webkit.org/show_bug.cgi?id=236037
rdar://88358719
Reviewed by Mark Lam.
Lower stack args in Air had a bug where it was emitting a constant
materialization at the wrong instruction offset for certain types
of spill instructions. This happens when we have a stack slot that
is 8 bytes wide, but we're emitting a zero def Move32. We need to
zero the upper 4 bytes. However, there is also code inside lower
stack args that uses the temp register when encountering offsets
that are too large to encode in a single instruction. However,
this offset materialization code for the second Move32 to zero
the upper bytes was happening before the actual store. For example,
we'd end up with:
movz x16, #k
movz x16, #k2
stur x1, [x16]
stur zr, [x16]
instead of
movz x16, #k
stur x1, [x16]
movz x16, #k2
stur zr, [x16]
- b3/air/AirLowerStackArgs.cpp: (JSC::B3::Air::lowerStackArgs):
- b3/air/testair.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:14 AM Changeset in webkit [289400] by
-
- 3 edits in branches/safari-613.1.16.0-branch/Source/JavaScriptCore
Cherry-pick r289024. rdar://problem/88222677
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
<rdar://88222677>
Reviewed by Mark Lam.
- assembler/SecureARM64EHashPins.cpp: (JSC::SecureARM64EHashPins::initializeAtStartup): (JSC::SecureARM64EHashPins::allocatePinForCurrentThread): (JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:14 AM Changeset in webkit [289399] by
-
- 3 edits in branches/safari-613.1.16.0-branch/Source/WebCore
Cherry-pick r288539. rdar://problem/87986840
Expand RefPtr / Ref use in FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=235551
rdar://87986840
Reviewed by Mark Lam.
Apply Ref / RefPtr instead of taking SerializedScriptValue*.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:14 AM Changeset in webkit [289398] by
-
- 9 edits in branches/safari-613.1.16.3-branch/Source
Versioning.
WebKit-7613.1.16.3.1
- 11:09 AM Changeset in webkit [289397] by
-
- 9 edits in branches/safari-613.1.16.0-branch/Source
Versioning.
WebKit-7613.1.16.0.5
- 10:57 AM Changeset in webkit [289396] by
-
- 17 edits in trunk
Conversion to a color space with a smaller gamut should perform gamut mapping
https://bugs.webkit.org/show_bug.cgi?id=236200
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update tests to include more examples that force gamut mapping and update the results
of a few existing ones to account for the new algorithm.
- web-platform-tests/css/css-color/parsing/color-mix-computed-expected.txt:
- web-platform-tests/css/css-color/parsing/color-mix-computed.html:
- web-platform-tests/css/css-color/parsing/color-mix-valid-expected.txt:
- web-platform-tests/css/css-color/parsing/color-mix-valid.html:
- web-platform-tests/css/css-color/parsing/relative-color-computed-expected.txt:
- web-platform-tests/css/css-color/parsing/relative-color-computed.html:
- web-platform-tests/css/css-color/parsing/relative-color-valid-expected.txt:
- web-platform-tests/css/css-color/parsing/relative-color-valid.html:
Source/WebCore:
CSS Color now defines that gamut mapping should happen when converting to an RGB color space
with bounded gamut that is smaller than the origin color's color space. Specifically, it
specifies the use of a new "CSS gamut mapping algorithm" https://drafts.csswg.org/css-color/#css-gamut-mapping
which implements a relative colorimetric intent mapping with colors inside the destination
gamut unchanged.
The previous behavior we implemented was to clip out of gamut colors to the gamut (e.g.
color(srgb 1.4 -0.2 .5) would become color(srgb 1 0 .5)) which can lead to very odd results.
To keep things simple, the gamut mapping has been incorporated directly into the main color
conversion pipeline, replacing the call to makeFromComponentsClampingExceptAlpha in toBounded()
with one implements the new algorithm. To accomadate this, the pipeline was modified so that
the matrix conversions now only happen to/from extended-linear and XYZ color types, rather than
the old behavior which allowed shortcuting from bounded-linear, which was ok because the clip
would result in the same value. Since conversion from bounded-linear to extended-linear is free
(just a type change, no conversion), the only additional cost here is the gamut mapping.
The implementation of the CSS gamut mapping algorithm itself is a naive iterative bisection
implementation based on the psuedo-code from the spec. As an optimization in the future, we should
consider implementing an analytic solution, which will be more complicated, but likely faster.
Currently, the only place where the effect of this new gamut mapping behavior will be visible is
via functions that explicitly convert to a bounded color space, specifically the CSS color-mix()
function and relative color syntax. Ultimately, we should also be using this to map CSS colors
to the output color space of the screen / HTML canvas, but finding the right place to do that
is not a part of this initial change.
- platform/graphics/ColorConversion.cpp:
(WebCore::ColorConversion<Lab<float>, XYZA<float, WhitePoint::D50>>::convert):
(WebCore::ColorConversion<OKLab<float>, XYZA<float, WhitePoint::D65>>::convert):
Add call to makeFromComponentsClampingExceptAlpha at the end of conversion to Lab/OKLab
as the conversion functions can produce lightness values just ever so less than 0.
In practice, only the lightness value is bounded, so it is the only thing that actually
gets clamped thanks to the constexpr nature of clampedComponent().
- platform/graphics/ColorConversion.h:
(WebCore::computeDeltaEOK):
Add implementation of the deltaEOK algorithm.
(WebCore::ClipGamutMapping::mapToBoundedGamut):
Add implementation of the degenerate gamut mapping algorithm.
(WebCore::CSSGamutMapping::mapToBoundedGamut):
Add implementation of the CSS gamut mapping algorithm.
(WebCore::ColorConversion::convert):
Add a new step to the main pipeline that explicitly handles bounds conversions to/from
extended-linear so that the matrix conversions can rely on always working in extended space.
(WebCore::ColorConversion::toBounded):
Replace call to clamp with call out to gamut mapping algorithm.
(WebCore::ColorConversion::handleMatrixConversion):
Replace makeFromComponentsClampingExceptAlpha with makeFromComponents now that all conversions
are in the extended space and clamping is no-op.
- platform/graphics/ColorTypes.h:
(WebCore::inGamut):
(WebCore::colorIfInGamut):
(WebCore::clipToGamut):
Add some helpers to check/convert/clip to the bounded gamut of RGB types.
Tools:
- TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
(TestWebKitAPI::TEST):
Update color conversion tests to account for gamut mapping and add a new test
that bypasses gamut mapping by converting to extended sRGB.
LayoutTests:
- platform/gtk/TestExpectations:
Add more tests that are only failing on the GTK bots due to a small floating point issues that needs further investigation.
- 10:55 AM Changeset in webkit [289395] by
-
- 3 edits in branches/safari-613.1.16.1-branch/Source/JavaScriptCore
Cherry-pick r289354. rdar://problem/88611690
Wasm crash on https://copy.sh/v86/?profile=dsl
https://bugs.webkit.org/show_bug.cgi?id=236037
rdar://88358719
Reviewed by Mark Lam.
Lower stack args in Air had a bug where it was emitting a constant
materialization at the wrong instruction offset for certain types
of spill instructions. This happens when we have a stack slot that
is 8 bytes wide, but we're emitting a zero def Move32. We need to
zero the upper 4 bytes. However, there is also code inside lower
stack args that uses the temp register when encountering offsets
that are too large to encode in a single instruction. However,
this offset materialization code for the second Move32 to zero
the upper bytes was happening before the actual store. For example,
we'd end up with:
movz x16, #k
movz x16, #k2
stur x1, [x16]
stur zr, [x16]
instead of
movz x16, #k
stur x1, [x16]
movz x16, #k2
stur zr, [x16]
- b3/air/AirLowerStackArgs.cpp: (JSC::B3::Air::lowerStackArgs):
- b3/air/testair.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289394] by
-
- 3 edits in branches/safari-613.1.16.1-branch/Source/JavaScriptCore
Cherry-pick r289024. rdar://problem/88222677
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
<rdar://88222677>
Reviewed by Mark Lam.
- assembler/SecureARM64EHashPins.cpp: (JSC::SecureARM64EHashPins::initializeAtStartup): (JSC::SecureARM64EHashPins::allocatePinForCurrentThread): (JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
- assembler/SecureARM64EHashPinsInlines.h: (JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289393] by
-
- 2 edits in branches/safari-613.1.16.1-branch/Source/WebCore
Cherry-pick r288933. rdar://problem/87402941
Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
https://bugs.webkit.org/show_bug.cgi?id=235989
<rdar://87402941>
Reviewed by Wenson Hsieh.
Crash data suggest that m_scrollingCoordinator can be null in ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged(),
which is true if the scrolling tree keeps ThreadedScrollingTree alive longer than the scrolling coordinator.
As in the other functions in this file, early return if m_scrollingCoordinator is null.
- page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289392] by
-
- 7 edits in branches/safari-613.1.16.1-branch/Source
Cherry-pick r288922. rdar://problem/88172449
[WP] Remove PostScript conversion code
https://bugs.webkit.org/show_bug.cgi?id=235892
<rdar://88172449>
Reviewed by Tim Horton.
The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
Source/WebCore:
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::convertedDataIfNeeded const):
- platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::convertPostScriptDataToPDF): Deleted.
- platform/graphics/cg/PDFDocumentImage.h:
Source/WebKit:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::pluginInfo): (WebKit::PDFPlugin::streamDidReceiveResponse): (WebKit::PDFPlugin::manualStreamDidReceiveResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289391] by
-
- 2 edits in branches/safari-613.1.16.1-branch/Source/WebKit
Cherry-pick r288848. rdar://problem/86950638
Web Inspector: [Cocoa] Crash in WebKit::WebInspectorUIProxy::attachmentViewDidChange
https://bugs.webkit.org/show_bug.cgi?id=235842
Reviewed by Timothy Hatcher.
Speculatively fix an occasional crash in WebKit::WebInspectorUIProxy::attachmentViewDidChange by ensuring that
the WebInspectorUIProxy still exists before callingattachmentViewDidChange.
Currently we are sometimes crashing while attempting to
m_objCAdapter.get(), which is the first use of a
member variable inWebInspectorUIProxy::attachmentViewDidChange. This retain pointer should never be able to
not exists, since it storingnilis a valid state. This points to the WebInspectorUIProxy itself no longer
existing. The fix is to check that we actually have aWebInspectorUIProxybefore calling
attachmentViewDidChange. This is also just good practice sinceWebPageProxy::inspector()is also able to
returnnullptrunder certain circumstances, and all other calls to it are guarded to check if the
WebInspectorUIProxy is still around first.
- UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::setInspectorAttachmentView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289390] by
-
- 3 edits in branches/safari-613.1.16.1-branch/Source/WebKit
Cherry-pick r288825. rdar://problem/88172449
[WP] Remove PostScript conversion code
https://bugs.webkit.org/show_bug.cgi?id=235892
<rdar://88172449>
Reviewed by Brent Fulgham.
The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::streamDidFinishLoading): (WebKit::PDFPlugin::manualStreamDidFinishLoading): (WebKit::PDFPlugin::convertPostScriptDataIfNeeded): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289389] by
-
- 2 edits in branches/safari-613.1.16.1-branch/Source/WebKit
Cherry-pick r288776. rdar://problem/88214729
[macOS][WP] Temporarily add syscall to sandbox
https://bugs.webkit.org/show_bug.cgi?id=235841
<rdar://88197549>
Reviewed by Brent Fulgham.
Temporarily add syscall to sandbox in the WebContent process on macOS. This can be removed when <rdar://88210738> is fixed.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [289388] by
-
- 3 edits in branches/safari-613.1.16.1-branch/Source/WebCore
Cherry-pick r288539. rdar://problem/87986840
Expand RefPtr / Ref use in FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=235551
rdar://87986840
Reviewed by Mark Lam.
Apply Ref / RefPtr instead of taking SerializedScriptValue*.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:49 AM Changeset in webkit [289387] by
-
- 9 edits in branches/safari-613.1.16.1-branch/Source
Versioning.
WebKit-7613.1.16.1.4
- 10:36 AM Changeset in webkit [289386] by
-
- 6 edits in trunk/Tools
[git-webkit] Autostash when pulling
https://bugs.webkit.org/show_bug.cgi?id=235861
<rdar://problem/88298948>
Reviewed by Ryosuke Niwa.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.pull): Pass --autostash when pulling and resetting timestamps.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Handle --autostash.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
Canonical link: https://commits.webkit.org/246972@main
- 10:20 AM Changeset in webkit [289385] by
-
- 3 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r289354. rdar://problem/88611690
Wasm crash on https://copy.sh/v86/?profile=dsl
https://bugs.webkit.org/show_bug.cgi?id=236037
rdar://88358719
Reviewed by Mark Lam.
Lower stack args in Air had a bug where it was emitting a constant
materialization at the wrong instruction offset for certain types
of spill instructions. This happens when we have a stack slot that
is 8 bytes wide, but we're emitting a zero def Move32. We need to
zero the upper 4 bytes. However, there is also code inside lower
stack args that uses the temp register when encountering offsets
that are too large to encode in a single instruction. However,
this offset materialization code for the second Move32 to zero
the upper bytes was happening before the actual store. For example,
we'd end up with:
movz x16, #k
movz x16, #k2
stur x1, [x16]
stur zr, [x16]
instead of
movz x16, #k
stur x1, [x16]
movz x16, #k2
stur zr, [x16]
- b3/air/AirLowerStackArgs.cpp: (JSC::B3::Air::lowerStackArgs):
- b3/air/testair.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:20 AM Changeset in webkit [289384] by
-
- 2 edits in branches/safari-613-branch/LayoutTests
Cherry-pick r287055. rdar://problem/86488039
REGRESSION (r286982): ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]
https://bugs.webkit.org/show_bug.cgi?id=234315
Unreviewed test gardening.
- TestExpectations: Skip the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:53 AM Changeset in webkit [289383] by
-
- 7 edits in trunk/Source/WebCore
[WebCore] JSValueInWrappedObject is not correct for concurrent GC
https://bugs.webkit.org/show_bug.cgi?id=236277
rdar://88366849
Reviewed by Saam Barati.
JSValueInWrappedObject is broken for concurrent GC's marking. It is using std::variant<> to store Weak / JSValue,
which is not safe if concurrent GC reads it while changing that std::variant. This patch fixes several problems
in JSValueInWrappedObject.
- We must not use std::variant here since concurrent access can happen. We have both JSValue and Weak, and change Weak after fully initialize WeakImpl's content in Weak. To ensure that, we emit storeStoreBarrier before setting Weak to the JSValueInWrappedObject's field.
- Assignment operator & copy constructor are basically wrong for this class as we need a write-barrier to set a value to the field. We remove them and make it explicit that we do not have write-barrier, which reveals that IDBRequest has a semantic bug.
- We also add clear() instead of assigning empty JSValueInWrappedObject. And we ensure that this new clear() works well with concurrent GC threads: we clear the underlying WeakImpl* pointer to nullptr. But since WeakImpl* is kept alive until GC clears weak-related things in its end phase, concurrent GC thread can access the old WeakImpl*.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
(WebCore::IDBRequest::setResultToUndefined):
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::didOpenOrIterateCursor):
- Modules/paymentrequest/PaymentMethodChangeEvent.cpp:
- Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::setDetailsFunction):
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::getChannelData):
(WebCore::AudioBuffer::visitChannelWrappers):
- bindings/js/JSValueInWrappedObject.h:
(WebCore::JSValueInWrappedObject::JSValueInWrappedObject):
(WebCore::JSValueInWrappedObject::operator JSC::JSValue const):
(WebCore::JSValueInWrappedObject::visit const):
(WebCore::JSValueInWrappedObject::setWeakly):
(WebCore::JSValueInWrappedObject::set):
(WebCore::JSValueInWrappedObject::clear):
(WebCore::JSValueInWrappedObject::setWithoutBarrier):
(WebCore::cachedPropertyValue):
(WebCore::JSValueInWrappedObject::makeValue): Deleted.
(WebCore::JSValueInWrappedObject::operator=): Deleted.
- 9:51 AM Changeset in webkit [289382] by
-
- 2 edits in trunk/Source/WTF
[macOS] Update requirements for ScreenCaptureKit
https://bugs.webkit.org/show_bug.cgi?id=236304
rdar://88593324
Reviewed by Youenn Fablet.
- wtf/PlatformHave.h:
- 9:14 AM Changeset in webkit [289381] by
-
- 10 edits2 adds in trunk
LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=236132
Reviewed by Eric Carlson.
Source/WebKit:
When sending sampels through SharedVideoFrameWriters, we might lock on a binary semaphore controlled by GPUProcess.
It is not always the case that the semaphore will unblock in case of GPUProcess crash for instance.
To prevent this, whenever we detect a GPUProcess crash, we disable SharedVideoFrameWriters, which has the effect of
disabling semaphore wait for future call and unlocking any current wait by calling semaphore.signal.
Then, the SharedVideoFrameWriter is recreated as needed by owner classes such as LibWebRTCCodecs or SampleBufferDisplayLayer.
In the case of LibWebRTCCodecs, we further reduce locking cases by introducing a lock dedicated to encoders.
Previously, the lock for encoders was also encompassing the codecs connection and the decoders.
Test: webrtc/vp8-then-h264-gpu-process-crash.html
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
LayoutTests:
- platform/gtk/TestExpectations: Skip test as it is crashing in GTK bot.
- webrtc/vp8-then-h264-gpu-process-crash-expected.txt: Added.
- webrtc/vp8-then-h264-gpu-process-crash.html: Added.
- 9:03 AM Changeset in webkit [289380] by
-
- 2 edits in trunk/Source/WebKit
Reduce allocations and increase thread safety of constructedPath
https://bugs.webkit.org/show_bug.cgi?id=236286
<rdar://86904276>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-08
Reviewed by Chris Dumez.
- UIProcess/API/APIContentRuleListStore.cpp:
(API::constructedPathPrefix):
(API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
- 8:57 AM Changeset in webkit [289379] by
-
- 7 edits2 moves in trunk/Source/WebKit
Rename ImageBufferShareableIOSurfaceBackend to ImageBufferRemoteIOSurfaceBackend
https://bugs.webkit.org/show_bug.cgi?id=236267
Reviewed by Tim Horton.
Most of the functions on ImageBufferShareableIOSurfaceBackend are stubs that RELEASE_ASSERT;
it's "remote" role is more important that it's "shareable" role, so rename it.
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/PlatformImageBufferShareableBackend.h:
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp: Renamed from Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp.
(WebKit::ImageBufferRemoteIOSurfaceBackend::calculateSafeBackendSize):
(WebKit::ImageBufferRemoteIOSurfaceBackend::calculateMemoryCost):
(WebKit::ImageBufferRemoteIOSurfaceBackend::calculateExternalMemoryCost):
(WebKit::ImageBufferRemoteIOSurfaceBackend::create):
(WebKit::ImageBufferRemoteIOSurfaceBackend::createImageBufferBackendHandle const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::context const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::backendSize const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::bytesPerRow const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::copyNativeImage const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::copyImage const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::draw):
(WebKit::ImageBufferRemoteIOSurfaceBackend::drawPattern):
(WebKit::ImageBufferRemoteIOSurfaceBackend::toDataURL const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::toData const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::getPixelBuffer const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::putPixelBuffer):
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h: Renamed from Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.h.
- 8:55 AM Changeset in webkit [289378] by
-
- 5 edits in trunk
Enable GPU Process for WebGL by default on iOS
https://bugs.webkit.org/show_bug.cgi?id=236218
Reviewed by Kimmo Kinnunen.
Tools:
- WebKitTestRunner/TestOptions.cpp: Add new static representing whether full GPU Process is enabled.
(WTR::TestOptions::defaults):
LayoutTests:
- platform/ios-simulator/TestExpectations: read-pixels-test.html is no longer slow.
- platform/ios-wk2/TestExpectations:
- 8:23 AM Changeset in webkit [289377] by
-
- 6 edits in trunk
Return 'none' for the computed style of mask when there are no mask images
https://bugs.webkit.org/show_bug.cgi?id=236265
<rdar://88178304>
Patch by Matt Woodrow <Matt Woodrow> on 2022-02-08
Reviewed by Dean Jackson.
Source/WebCore:
Rather than returning all the longhand properties, return 'none' if there are no
mask images. This no longer matches the behaviour of the 'background' property, but
better matches what other UAs do.
Ideally we'd return the smallest possible canonical representation of the non-initial
property values, but this is a much simpler change to fix a compat regression.
Test: fast/masking/parsing-mask.html
Updates expected results to match new behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::getLayerCount):
(WebCore::ComputedStyleExtractor::getFillLayerPropertyShorthandValue):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
(WebCore::ComputedStyleExtractor::getMaskShorthandValue):
- css/CSSComputedStyleDeclaration.h:
LayoutTests:
- fast/masking/parsing-mask-expected.txt:
- fast/masking/parsing-mask.html:
Updated expected results to expect 'none' for all cases where there isn't an actual mask
image.
- 7:55 AM Changeset in webkit [289376] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Add support for ideographic baseline on atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=236258
Reviewed by Antti Koivisto.
This is in preparation for adding vertical writing mode support (now we pass all the replaced tests under imported/w3c/web-platform-tests/css/css-writing-modes).
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable): see RenderBox::baselinePosition() for the math.
- 7:06 AM Changeset in webkit [289375] by
-
- 2 edits in trunk/LayoutTests
[GTK] Garden tests failing after r288070
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 6:55 AM Changeset in webkit [289374] by
-
- 7 edits in trunk/Source/WebCore
[LFC][IFC] Take writing direction into account when applying RenderBlockFlow end padding quirk
https://bugs.webkit.org/show_bug.cgi?id=236280
Reviewed by Antti Koivisto.
In vertical writing mode the overflow should be expanded in the vertical direction if applicable.
- layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::contentLogicalWidth const):
(WebCore::InlineDisplay::Line::Line):
(WebCore::InlineDisplay::Line::contentWidth const): Deleted.
- layout/integration/InlineIteratorLineModernPath.h:
(WebCore::InlineIterator::LineIteratorModernPath::contentLogicalRight const):
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::lineOverflowLogicalWidth):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::lineOverflowWidth): Deleted.
- layout/integration/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::contentLogicalWidth const):
(WebCore::LayoutIntegration::Line::contentWidth const): Deleted. -> this is a logical width value.
- layout/integration/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::makeAdjustedContent):
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::shiftMaxYEdgeBy):
- 6:35 AM Changeset in webkit [289373] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Integration] Take isHorizontalWritingMode value into account when converting incoming margin/border/padding values
https://bugs.webkit.org/show_bug.cgi?id=236285
Reviewed by Antti Koivisto.
(WebCore::LayoutIntegration::logicalMargin):
(WebCore::LayoutIntegration::logicalBorder):
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions):
- 6:26 AM Changeset in webkit [289372] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] LineBoxBuilder::setBaselineAndLayoutBounds should handle atomic inline level boxes too
https://bugs.webkit.org/show_bug.cgi?id=236255
Reviewed by Antti Koivisto.
Call setBaselineAndLayoutBounds with atomic type of inline level boxes.
This is in preparation for adding support for ideographic baseline on atomic inline level boxes.
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setBaselineAndLayoutBounds const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
- 6:19 AM Changeset in webkit [289371] by
-
- 4 edits in trunk/Source/WebKit
GPUP WebGL RELEASE_LOGs errorneously for unhandled messages
https://bugs.webkit.org/show_bug.cgi?id=236288
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-08
Reviewed by Antti Koivisto.
Remove a RELEASE_LOG when GPUProcessConnection sees a RemoteGraphicsContextGLProxy
message that was not delivered to a specific instance.
This is business as usual, as the proxy intends to be asynchronous and can be destroyed
without coordinating with the GPUP side. The Proxy object cannot know at which point
of time a message to it might be delivered.
Move the message handling to RemoteGraphicsContextGLProxy static method,
so that the RELEASE_LOG does not get added erroneosly again.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::handleMessageToRemovedDestination):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- 6:11 AM WebKitGTK/2.34.x edited by
- (diff)
- 6:07 AM Changeset in webkit [289370] by
-
- 2 edits in trunk
[WPE] Running distcheck with USE_SOUP2=OFF fails to install documentation
https://bugs.webkit.org/show_bug.cgi?id=236235
Reviewed by Carlos Garcia Campos.
- Source/PlatformWPE.cmake: Use WPE_API_DOC_VERSION instead of WPE_API_VERSION for the documentation.
- 5:46 AM Changeset in webkit [289369] by
-
- 5 edits in trunk/Source/WebKit
[GTK][WPE] Crash at WebKit::bindA11y() in WebKitGTK 2.35.2
https://bugs.webkit.org/show_bug.cgi?id=236144
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-02-08
Reviewed by Adrian Perez de Castro.
ATSPI stopped using an abstract socket but we are still assuming the a11y bus address is an abstract socket,
even when the path is not really used after all. However, just handling the case of the socket being a normal
unix socket is not enough, because the actual socket path is not mounted in the xdg-dbus-proxy sandbox, so it
fails to connect to the original a11y bus.
- UIProcess/Launcher/ProcessLauncher.h: Rename extraWebProcessSandboxPaths as extraSandboxPaths.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::XDGDBusProxyLauncher::setAddress): Remove the DBusAddressType parameter. Check the address looks valid
and just store the result of dbusAddressToPath() in m_path.
(WebKit::XDGDBusProxyLauncher::launch): Do not require m_path to be non-null and add it to the sanbox.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Only return the path for normal unix sockets.
(WebKit::bindDBusSession): Remove the DBusAddressType parameter passed to dbusAddressToPath().
(WebKit::bindA11y): Check proxy path is not null before setting a11y bus address in display.
(WebKit::addExtraPaths): Helper to add extra paths to the sandbox.
(WebKit::bubblewrapSpawn): Call addExtraPaths() for WebProcess and DBusProxy types.
- UIProcess/Launcher/glib/FlatpakLauncher.cpp:
(WebKit::flatpakSpawn): Use extraSandboxPaths.
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions): Ditto.
- 5:25 AM Changeset in webkit [289368] by
-
- 4 edits in trunk/Source/WebCore
AX: When updating the isolated tree with a remove and add of the same object, the wrapper is not re-attached
https://bugs.webkit.org/show_bug.cgi?id=236273
Reviewed by Andres Gonzalez.
In AXIsolatedTree::applyPendingChanges, we process node and subtree
removals before tree additions. When doing these removals, we detach
the object and wrapper from each other. This is fine unless that same
object is slated to be added again (e.g. it was moved in the DOM), as
we don't always re-attach a wrapper. [WebAccessibilityObjectWrapperBase axBackingObject]
will always return nil for objects in this state.
In this patch, when processing m_pendingAppends, we now attach a
wrapper to any object that has becomeisDetached(i.e. the object
has no wrapper, or the object has a wrapper but the wrapper does not
point at the object).
Fixes ~15 tests in isolated tree mode.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::applyPendingChanges):
- accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::isDetached const):
- 4:43 AM Changeset in webkit [289367] by
-
- 10 edits in trunk
[GStreamer] Test webkit/WebKitWebView/display-usermedia-permission-request times out
https://bugs.webkit.org/show_bug.cgi?id=235955
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-08
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The RealtimeMediaSource representing the GStreamer mock display source now correctly
reflects the corresponding capture device type (either Window or Screen). As that source
actually wraps a MockRealtimeVideoSourceGStreamer, a couple more methods from
RealtimeMediaSource had to be overridden.
- platform/mediastream/RealtimeMediaSource.h: Allow subclasses to override setMuted and isProducingData.
- platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp: Handle SystemAudio as
Speaker devices, for now.
(WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices):
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Refactor, leveraging the
new has{Audio,Video} methods.
(mediaStreamTrackPrivateGetTags):
(webkitMediaStreamNew):
(webkitMediaStreamSrcAddTrack):
(webkitMediaStreamSrcSetStream):
(webkitMediaStreamSrcConfigureAudioTracks):
- platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp: Map source type to
capture device type, proxy mute configuration and ending logic to wrapped source.
(WebCore::MockDisplayCaptureSourceGStreamer::create):
(WebCore::MockDisplayCaptureSourceGStreamer::MockDisplayCaptureSourceGStreamer):
(WebCore::MockDisplayCaptureSourceGStreamer::requestToEnd):
(WebCore::MockDisplayCaptureSourceGStreamer::setMuted):
- platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
Source/WebKit:
- UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConfigureMediaCapture): Don't notify display capture updates as camera capture
updates.
Tools:
- TestWebKitAPI/glib/TestExpectations.json: Unflag test now passing.
- 4:32 AM Changeset in webkit [289366] by
-
- 2 edits in trunk/Source/WebKit
[WPE] Developer extras are always enabled by default
https://bugs.webkit.org/show_bug.cgi?id=236295
Reviewed by Carlos Garcia Campos.
No new tests.
- UIProcess/API/wpe/WPEView.cpp:
(View::View): Remove call to unconditionally set the developer extras setting.
- 4:26 AM Changeset in webkit [289365] by
-
- 7 edits in trunk/Source/WebCore
RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface
https://bugs.webkit.org/show_bug.cgi?id=236139
Reviewed by Eric Carlson.
Introduce a parameter to use IOSurface or not in ImageRotationSessionVT.
Make use of that parameter in RealtimeOutgoingVideoSourceCocoa to disable IOSurface use.
Covered by existing tests.
- platform/graphics/cv/CVUtilities.h:
- platform/graphics/cv/CVUtilities.mm:
(WebCore::createIOSurfaceCVPixelBufferPool):
(WebCore::createInMemoryCVPixelBufferPool):
- platform/graphics/cv/ImageRotationSessionVT.h:
- platform/graphics/cv/ImageRotationSessionVT.mm:
(WebCore::ImageRotationSessionVT::ImageRotationSessionVT):
(WebCore::ImageRotationSessionVT::rotate):
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):
- 3:59 AM Changeset in webkit [289364] by
-
- 1 edit in trunk/Tools/CISupport/ews-build/master.cfg
[ews] Do not configure GitHub hooks on local testing instance
https://bugs.webkit.org/show_bug.cgi?id=236266
Reviewed by Jonathan Bedard.
- Tools/CISupport/ews-build/master.cfg:
Canonical link: https://commits.webkit.org/246952@main
- 3:53 AM Changeset in webkit [289363] by
-
- 4 edits in trunk/Source
Adding new files fails to compile after SharedWorkerObjectConnection.h changes
https://bugs.webkit.org/show_bug.cgi?id=236294
Add forward declarations and includes.
Unreviewed build fix.
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-08
Source/WebCore:
- workers/shared/SharedWorkerObjectConnection.h:
Source/WebKit:
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:
- 3:33 AM Changeset in webkit [289362] by
-
- 6 edits in trunk/Source
MediaSampleAVFObjC::createImageSample should take a presentationTime as parameter
https://bugs.webkit.org/show_bug.cgi?id=236067
Reviewed by Eric Carlson.
Source/WebCore:
Add additional parameters to createImageSample that will be used by WebKit.
No change of behavior.
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
(WebCore::MediaSampleAVFObjC::createImageSample):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::createImageSample):
Source/WebKit:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::enqueueSample):
- 3:28 AM Changeset in webkit [289361] by
-
- 6 edits in trunk/Source/WebKit
SharedVideoFrameReader could directly take a IPCHandle
https://bugs.webkit.org/show_bug.cgi?id=236068
Reviewed by Eric Carlson.
Move more code in SharedVideoFrameReader::setSharedMemory, as a refactoring.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::setSharedVideoFrameMemory):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::setSharedVideoFrameMemory):
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameReader::setSharedMemory):
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
(WebKit::SharedVideoFrameReader::setSharedMemory): Deleted.
- 1:53 AM Changeset in webkit [289360] by
-
- 3 edits in trunk/Source/WebCore
RenderLayer: Simplify RenderElement::paint() calls
https://bugs.webkit.org/show_bug.cgi?id=236192
Reviewed by Simon Fraser.
Introduce "paintOffsetForRenderer(fragment, localPaintingInfo)" inline helper:
return toLayoutPoint(fragment.layerBounds.location() - rendererLocation() + localPaintingInfo.subpixelOffset)
Avoid repeating this formula in various places in RenderLayer - unify it.
Covered by existing tests, no change in behaviour.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintChildClippingMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
(WebCore::RenderLayer::collectEventRegionForFragments):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::paintOffsetForRenderer const):
