Context Navigation

← Previous Period
Next Period →

Timeline

May 29, 2022:

12:56 PM Changeset in webkit [295019] by ntim@apple.com

1 edit in trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt

[Gardening] Rebaseline fast/dom/HTMLMeterElement/meter-element-markup.html after 9a73643
https://bugs.webkit.org/show_bug.cgi?id=240930

Unreviewed test gardening.

Just reflects the new unprefixed style.

LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:

Canonical link: https://commits.webkit.org/251114@main

10:10 AM Changeset in webkit [295018] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/inline

LineBuilder::initialConstraintsForLine needs to know whether there is previous line and if it ended with line break
https://bugs.webkit.org/show_bug.cgi?id=241062

Reviewed by Antti Koivisto.

No need to pass in the PreviousLine struct.

Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):

Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/251112@main

10:09 AM Changeset in webkit [295017] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Add basic support for justify-content
https://bugs.webkit.org/show_bug.cgi?id=241073

Reviewed by Antti Koivisto.

"justify-content" property defines how space is distributed between and around flex items along the main-axis.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::justiftFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/251112@main

8:34 AM Changeset in webkit [295016] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for align-self
https://bugs.webkit.org/show_bug.cgi?id=241071

Reviewed by Antti Koivisto.

Align-items behavior can be overwritten for individual flex items by applying the align-self property to them.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::alignFlexItems):

Canonical link: https://commits.webkit.org/251111@main

7:03 AM Changeset in webkit [295015] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Compute available space when ConstraintsForFlexContent does not provide one
https://bugs.webkit.org/show_bug.cgi?id=241070

Reviewed by Antti Koivisto.

e.g. if the flex box does not have fixed height in the cross axis direction, all flex items become as tall as the tallest flex item.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::availableLogicalVerticalSpace): Deleted.
(WebCore::Layout::availableLogicalHorizontalSpace): Deleted.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/251110@main

6:44 AM Changeset in webkit [295014] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for flex-start/flex-end/start/end alignment
https://bugs.webkit.org/show_bug.cgi?id=241067

Reviewed by Antti Koivisto.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):

Canonical link: https://commits.webkit.org/251109@main

6:22 AM Changeset in webkit [295013] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Introduce FlexFormattingContext::alignFlexItems
https://bugs.webkit.org/show_bug.cgi?id=241064

Reviewed by Antti Koivisto.

This is cross axis alignment (add support for 'center' to showcase).

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/251108@main

1:24 AM Changeset in webkit [295012] by commit-queue@webkit.org

1 edit in trunk/Source/WTF/wtf/CompactPtr.h

REGRESSION(251103@main): Broke GTK/WPE
https://bugs.webkit.org/show_bug.cgi?id=241076

Patch by Philippe Normand <philn@igalia.com> on 2022-05-29
Unreviewed. Fix GTK/WPE build.

Source/WTF/wtf/CompactPtr.h:

(WTF::CompactPtr::swap):

Canonical link: https://commits.webkit.org/251107@main

1:14 AM Changeset in webkit [295011] by ysuzuki@apple.com

10 edits
1 add in trunk

[JSC] Async / Await should not wrap awaited value with one tick
https://bugs.webkit.org/show_bug.cgi?id=241072

Reviewed by Saam Barati.

This patch integrates spec change[1], which removes one level tick count when resolving promise with await.
Previously, regardless of whether the value is promise or not, we are always using resolveWithoutPromise,
but it introduces one tick before the handlers are resolved. The spec change makes it that we can call
performPromiseThen directly if the input value is promise, so we can skip one tick which looks up "then"
and register handlers.

This is beneficial for await performance and it also fixes a bug tested via test262 and attached test due
to the spec change.

We observed performance improvement in async + native promise tests.

ToT
Time(doxbee-async-es2017-native): 35.6 ms.
Time(fibonacci-async-es2017-native): 292.3 ms.
Time(parallel-async-es2017-native): 117.3 ms.

Patched
Time(doxbee-async-es2017-native): 24.2 ms.
Time(fibonacci-async-es2017-native): 198.1 ms.
Time(parallel-async-es2017-native): 109.5 ms.

[1]: https://github.com/tc39/ecma262/pull/1250

JSTests/stress/async-await-basic.js:
JSTests/stress/async-await-tick-count.js: Added.

(shouldBe):
(async returnDirectPrimitive):
(async returnAwaitPrimitive):
(async returnDirectPromisePrimitive):
(async returnAwaitPromisePrimitive):
(async test):
(async tests):
(globalThis.setUnhandledRejectionCallback.setUnhandledRejectionCallback):

JSTests/test262/expectations.yaml:
LayoutTests/inspector/canvas/recording-bitmaprenderer-frameCount-expected.txt:
LayoutTests/inspector/canvas/recording-bitmaprenderer-full-expected.txt:
LayoutTests/inspector/canvas/recording-bitmaprenderer-memoryLimit-expected.txt:
LayoutTests/inspector/console/message-stack-trace-expected.txt:
Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:
Source/JavaScriptCore/builtins/AsyncFunctionPrototype.js:

(globalPrivate.asyncFunctionResume):

Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:

(globalPrivate.awaitValue):
(globalPrivate.asyncGeneratorResumeNext):

Source/JavaScriptCore/builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.promiseResolve):
(globalPrivate.promiseResolveSlow):
(globalPrivate.promiseRejectSlow):
(globalPrivate.resolvePromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.fulfillPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.rejectPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.resolveWithoutPromiseForAsyncAwait):

Canonical link: https://commits.webkit.org/251106@main

12:57 AM Changeset in webkit [295010] by commit-queue@webkit.org

35 edits in trunk

Replace CSS3_TEXT build flag with Experimental feature settings
https://bugs.webkit.org/show_bug.cgi?id=121875

Patch by Kiet Ho <Kiet Ho> on 2022-05-29
Reviewed by Tim Nguyen and Myles C. Maxfield.

Currently, -webkit-text-align-last and -webkit-text-justify are gated behind
the ENABLE(CSS3_TEXT) build flag. EWS bots doesn't enable it, hence the properties
aren't tested even though tests are available for them. This patch replaces the build
flag with two experimental settings, which is on during layout tests, allowing the
properties to be tested.

LayoutTests/TestExpectations:
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
LayoutTests/platform/win/TestExpectations:
LayoutTests/platform/wincairo/TestExpectations:
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
Source/WTF/wtf/PlatformEnable.h:
Source/WebCore/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Temporarily mark -webkit-text-align-last and -webkit-text-justify as not animatable
to avoid the assert. CSS animations for those properties will be implemented in
webkit.org/b/240591.

Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TextJustify const):

Source/WebCore/css/CSSProperties.json:
Source/WebCore/css/StyleProperties.cpp:
Source/WebCore/css/parser/CSSParserContext.cpp:

(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

Source/WebCore/css/parser/CSSParserContext.h:
Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::rareInheritedDataChangeRequiresLayout):

Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textIndentType const):
(WebCore::RenderStyle::textJustify const):
(WebCore::RenderStyle::setTextIndentType):
(WebCore::RenderStyle::setTextJustify):
(WebCore::RenderStyle::initialTextIndentType):
(WebCore::RenderStyle::initialTextJustify):

Source/WebCore/rendering/style/RenderStyleConstants.h:
Source/WebCore/rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

Source/WebCore/rendering/style/StyleRareInheritedData.h:
Source/WebKitLegacy/win/WebPreferences.cpp:

(WebPreferences::cssTextAlignLastEnabled):
(WebPreferences::cssTextJustifyEnabled):

Source/WebKitLegacy/win/WebPreferences.h:
Source/WebKitLegacy/win/WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Tools/DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/251105@main

May 28, 2022:

10:09 PM Changeset in webkit [295009] by Chris Dumez

2 edits in trunk/Source/WebCore/html/parser

Optimize href attribute lookup in TokenPreloadScanner::updatePredictedBaseURL()
https://bugs.webkit.org/show_bug.cgi?id=241051

Reviewed by Darin Adler.

Optimize href attribute lookup in TokenPreloadScanner::updatePredictedBaseURL() by avoiding
is8Bit() checks for every character of the parameter. Instead, make sure both the parameter
is a const UChar* for fast comparison with attributes, which are stored as Vector<UChar>.

Source/WebCore/html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::updatePredictedBaseURL):

Source/WebCore/html/parser/HTMLToken.h:

(WebCore::findAttribute):
(WebCore::nameMatches): Deleted.

Canonical link: https://commits.webkit.org/251104@main

8:23 PM Changeset in webkit [295008] by Yijia Huang

29 edits
2 copies
1 move
3 adds in trunk

Shrink Structure to 96 Bytes when addresses can be encoded in 36-bits
https://bugs.webkit.org/show_bug.cgi?id=240407

Reviewed by Yusuke Suzuki.

We have 2% RAMification regression on iOS, which needs a memory performance
improvement. To work towards resolving this regression, this patch is to
reduce JS object's structure size from 112 bytes to 96 bytes for iOS systems.

We can reduce 36-bit addresses into 4 bytes when dealing with pointers that

have 16-byte alignment.

StructureID can be removed from StructureIDBlob since we can directly compute

the id by encoding the Structure pointer.

CompactPtr and CompactRefPtr classes are introduced for pointers, which can
achieve 8 bytes in MacOS and 4 bytes in iOS.

PerformanceTests/JetStream2/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
PerformanceTests/JetStream2/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
PerformanceTests/JetStream2/RexBench/OfflineAssembler/expected.js:
PerformanceTests/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
PerformanceTests/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
PerformanceTests/RexBench/OfflineAssembler/expected.js:
Source/JavaScriptCore/CMakeLists.txt:
Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
Source/JavaScriptCore/bytecode/GetByValHistory.h:

(JSC::GetByValHistory::observe):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:
Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Source/JavaScriptCore/heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):

Source/JavaScriptCore/heap/ConservativeRoots.h:
Source/JavaScriptCore/heap/HeapSnapshot.h:
Source/JavaScriptCore/heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):
(JSC::HeapUtil::isValueGCObject):

Source/JavaScriptCore/heap/MarkedBlockSet.h:

(JSC::MarkedBlockSet::add):
(JSC::MarkedBlockSet::recomputeFilter):
(JSC::MarkedBlockSet::filter const):

Source/JavaScriptCore/heap/TinyBloomFilter.h:

(JSC::TinyBloomFilter<Bits>::TinyBloomFilter):
(JSC::TinyBloomFilter<Bits>::add):
(JSC::TinyBloomFilter<Bits>::ruleOut const):
(JSC::TinyBloomFilter<Bits>::reset):
(JSC::TinyBloomFilter::TinyBloomFilter): Deleted.
(JSC::TinyBloomFilter::add): Deleted.
(JSC::TinyBloomFilter::ruleOut const): Deleted.
(JSC::TinyBloomFilter::reset): Deleted.

Source/JavaScriptCore/jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):
(JSC::AssemblyHelpers::emitEncodeStructure):

Source/JavaScriptCore/jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):
(JSC::AssemblyHelpers::loadCompactPtr):
(JSC::AssemblyHelpers::branchCompactPtr):

Source/JavaScriptCore/jit/JITPropertyAccess.cpp:

(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::emit_op_put_to_scope):

Source/JavaScriptCore/runtime/ClassInfo.h:

(JSC::ClassInfo::offsetOfParentClass): Deleted.
(JSC::ClassInfo::isSubClassOf const): Deleted.

Source/JavaScriptCore/runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::processUnverifiedStackTraces):

Source/JavaScriptCore/runtime/Structure.cpp:

(JSC::Structure::Structure):

Source/JavaScriptCore/runtime/Structure.h:

(JSC::Structure::id const):
(JSC::Structure::typeInfoBlob const):
(JSC::Structure::classInfoForCells const):
(JSC::Structure::indexingModeIncludingHistoryOffset):
(JSC::Structure::objectInitializationBlob const): Deleted.
(JSC::Structure::idBlob const): Deleted.
(JSC::Structure::structureIDOffset): Deleted.

Source/JavaScriptCore/runtime/StructureInlines.h:

(JSC::Structure::get):
(JSC::Structure::add):

Source/JavaScriptCore/runtime/TypeInfoBlob.h: Renamed from Source/JavaScriptCore/runtime/StructureIDBlob.h.

(JSC::TypeInfoBlob::TypeInfoBlob):
(JSC::TypeInfoBlob::operator=):
(JSC::TypeInfoBlob::indexingModeIncludingHistory const):
(JSC::TypeInfoBlob::fencedIndexingModeIncludingHistory):
(JSC::TypeInfoBlob::setIndexingModeIncludingHistory):
(JSC::TypeInfoBlob::type const):
(JSC::TypeInfoBlob::inlineTypeFlags const):
(JSC::TypeInfoBlob::typeInfo const):
(JSC::TypeInfoBlob::blob const):
(JSC::TypeInfoBlob::indexingModeIncludingHistoryOffset):

Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Source/WTF/WTF.xcodeproj/project.pbxproj:
Source/WTF/wtf/CMakeLists.txt:
Source/WTF/wtf/CompactPtr.h: Added.

(WTF::CompactPtr::CompactPtr):
(WTF::CompactPtr::operator* const):
(WTF::CompactPtr::operator-> const):
(WTF::CompactPtr::operator! const):
(WTF::CompactPtr::operator bool const):
(WTF::CompactPtr::operator=):
(WTF::CompactPtr::get const):
(WTF::CompactPtr::set):
(WTF::CompactPtr::exchange):
(WTF::CompactPtr::swap):
(WTF::CompactPtr::encode):
(WTF::CompactPtr::encode const):
(WTF::CompactPtr::decode const):
(WTF::GetPtrHelper<CompactPtr<T>>::getPtr):
(WTF::CompactPtrTraits::exchange):
(WTF::CompactPtrTraits::swap):
(WTF::CompactPtrTraits::unwrap):
(WTF::CompactPtrTraits::hashTableDeletedValue):
(WTF::CompactPtrTraits::isHashTableDeletedValue):

Source/WTF/wtf/CompactRefPtr.h: Copied from Source/JavaScriptCore/heap/HeapSnapshot.h.
Source/WTF/wtf/text/StringImpl.cpp:
Source/WTF/wtf/text/StringImpl.h:
Tools/TestWebKitAPI/CMakeLists.txt:
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Tools/TestWebKitAPI/Tests/WTF/AlignedRefLogger.h: Copied from Source/JavaScriptCore/heap/TinyBloomFilter.h.

(TestWebKitAPI::DerivedAlignedRefLogger::DerivedAlignedRefLogger):

Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp: Added.

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::f1):
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::CompactRefPtrCheckingAlignedRefLogger):
(TestWebKitAPI::loggerName):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::ref):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::deref):

Tools/TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):

Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/expected.js:

Canonical link: https://commits.webkit.org/251103@main

7:03 PM Changeset in webkit [295007] by Chris Dumez

1 edit in trunk/Source/WTF/wtf/text/StringBuilderJSON.cpp

Simplify / Optimize StringBuilder::appendQuotedJSONString()
https://bugs.webkit.org/show_bug.cgi?id=240955

Reviewed by Darin Adler.

This simplifies the code, makes it more consistent with the test of StringBuilder,
and appears to be a ~0.3% progression on Speedometer on Apple Silicon.

Source/WTF/wtf/text/StringBuilderJSON.cpp:

(WTF::StringBuilder::appendQuotedJSONString):

Canonical link: https://commits.webkit.org/251102@main

5:11 PM Changeset in webkit [295006] by commit-queue@webkit.org

1 edit in trunk/LayoutTests/editing/execCommand/outdent-paragraph-crash.html

Null check split node parent in outdentParagraph
https://bugs.webkit.org/show_bug.cgi?id=235914

Patch by Rob Buis <rbuis@igalia.com> on 2022-05-28
Reviewed by Ryosuke Niwa.

Changed test to use setTimeout as it more reliably causes the original crash.

LayoutTests/editing/execCommand/outdent-paragraph-crash.html:

Canonical link: https://commits.webkit.org/251101@main

4:33 PM Changeset in webkit [295005] by bshafiei@apple.com

1 copy in tags/WebKit-7614.1.14.1.15

Tag WebKit-7614.1.14.1.15.

3:58 PM Changeset in webkit [295004] by bshafiei@apple.com

9 edits in branches/safari-7614.1.14.1-branch/Source

Versioning.

WebKit-7614.1.14.1.15

11:00 AM Changeset in webkit [295003] by Alan Coon

1 edit in branches/safari-613-branch/Source/WebCore/rendering/RenderElement.h

Unreviewed build fix. rdar://problem/91519558

./rendering/RenderElement.cpp:723:21:|error: out-of-line definition of 'moveLayers' does not match any declaration in 'WebCore::RenderElement'

10:44 AM Changeset in webkit [295002] by ysuzuki@apple.com

6 edits
1 delete in trunk/Source

Unreviewed, revert "[Xcode] Compute PGO profdata paths instead of searching for them at build time"

This reverts commit 6dfb5dc2b3bcd083231cee3cacc599ca7f76998b because of Speedometer2 3% regression.
Probably breaking PGO build.

Canonical link: https://commits.webkit.org/251100@main

9:31 AM Changeset in webkit [295001] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Introduce FlexFormattingContext::computeLogicalHeightForFlexItems
https://bugs.webkit.org/show_bug.cgi?id=241056

Reviewed by Antti Koivisto.

This is just a very basic "let's stretch the flex items in the cross axis direction" change.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::availableLogicalVerticalSpace):
(WebCore::Layout::availableLogicalHorizontalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/251099@main

9:18 AM Changeset in webkit [295000] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Transition flex-grow computation to flex-basis based
https://bugs.webkit.org/show_bug.cgi?id=241057

Reviewed by Antti Koivisto.

Introduce StrechingFlexItem to cache growth related values
Use flex-basis as the base for the flex grow computation
Compute the final logical width values

(This is very similar to how we compute "shrink values".)

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForStretchingFlexItems):

Canonical link: https://commits.webkit.org/251098@main

6:26 AM Changeset in webkit [294999] by Jean-Yves Avenard

40 edits in trunk/Source

Perform media networking operations off the main thread
https://bugs.webkit.org/show_bug.cgi?id=235353
rdar://84517825

Reviewed by Eric Carlson.

We run the media's networking operation and IPC service into a new dedicated WorkQueue.
Not all operation on a MediaResource can be made thread-agnostic, and the creation and shutdown of the MediaResource must still occur on the main thread due to the current architecture which forces more task dispatches than ideal.

However, all other operations will now run on a WorkQueue when the GPU Process is enabled. For WK1 we continue to use the main thread.
We use the IPC::Connection::WorkQueueMessageReceiver characteristics to proxy the network operations from the content process main thread to the GPU Process MediaResourceLoader's WorkQueue.

Some changes were required in data structures such as ResourceResponseBase, where we must use Strings over AtomStrings. A WorkQueue while guaranteeing that all tasks runs sequentially, will use different threads making the use of AtomStrings impossible.

RemoteMediaResourceManager now holds a strong reference to the RemoteMediaResource, to clear that reference and to make the call more explicit we rename PlatformMediaResource::stop into PlatformMediaResource::shutdown()
A call to shutdown() is equivalent to the previous call to stop() followed by setClient(nullptr).

Side-by fixes: various thread-safety fixes in WebCoreNSURLSession, access to some members weren't thread-safe.

To make the code flow easier to follow, we use the new assertIsCurrent(WorkQueue&) extensively. Most methods will now assert that it runs on the thread it's supposed to.

Source/WebCore/Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):

Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):

Source/WebCore/Modules/websockets/WebSocketHandshake.h:
Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptWithResponse):
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):

Source/WebCore/loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setResponseMIMEType):

Source/WebCore/loader/DocumentLoader.h:
Source/WebCore/loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::MediaResource):
(WebCore::MediaResource::~MediaResource):
(WebCore::MediaResource::shutdown):
(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::shouldCacheResponse):
(WebCore::MediaResource::redirectReceived):
(WebCore::MediaResource::dataSent):
(WebCore::MediaResource::dataReceived):
(WebCore::MediaResource::notifyFinished):
(WebCore::MediaResource::ensureShutdown):
(WebCore::MediaResource::stop): Deleted.

Source/WebCore/loader/MediaResourceLoader.h:
Source/WebCore/loader/cache/CachedRawResourceClient.h:
Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceLoader::targetQueue):
(WebCore::PlatformMediaResource::shutdown):
(WebCore::PlatformMediaResource::didPassAccessControlCheck const):
(WebCore::PlatformMediaResource::setClient):
(WebCore::PlatformMediaResource::client const):
(WebCore::PlatformMediaResource::stop): Deleted.
(WebCore::PlatformMediaResource::client): Deleted.

Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wouldTaintOrigin const):

Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::CachedResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::create):
(WebCore::PlatformResourceMediaLoader::PlatformResourceMediaLoader):
(WebCore::PlatformResourceMediaLoader::stop):
(WebCore::PlatformResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::loadFailed):
(WebCore::PlatformResourceMediaLoader::loadFinished):
(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):
(WebCore::WebCoreAVFResourceLoader::create):
(WebCore::WebCoreAVFResourceLoader::WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::startLoading):
(WebCore::WebCoreAVFResourceLoader::stopLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::loadFailed):
(WebCore::WebCoreAVFResourceLoader::loadFinished):
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):
(WebCore::WebCoreAVFResourceLoader::invalidate): Deleted.

Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(stopLoaderIfNeeded):
(webKitWebSrcUnLock):
(webKitSrcWouldTaintOrigin):

Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::mimeType const):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::textEncodingName const):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::httpStatusText const):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpVersion const):
(WebCore::ResourceResponseBase::setHTTPVersion):

Source/WebCore/platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::decode):

Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse const):
(WebCore::ResourceResponse::platformLazyInit):

Source/WebCore/platform/network/cocoa/RangeResponseGenerator.h:

(WebCore::RangeResponseGenerator::create):

Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:

(WebCore::RangeResponseGenerator::Data::Data):
(WebCore::RangeResponseGenerator::Data::~Data):
(WebCore::RangeResponseGenerator::Data::shutdownResource):
(WebCore::RangeResponseGenerator::RangeResponseGenerator):
(WebCore::synthesizedResponseForRange):
(WebCore::RangeResponseGenerator::removeTask):
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):
(WebCore::RangeResponseGenerator::expectedContentLengthFromData):
(WebCore::RangeResponseGenerator::giveResponseToTasksWithFinishedRanges):
(WebCore::RangeResponseGenerator::willHandleRequest):
(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
(WebCore::RangeResponseGenerator::~RangeResponseGenerator): Deleted.

Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h:
Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:onTarget:]):
(-[WebCoreNSURLSessionTaskTransactionMetrics dealloc]):
(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:onTarget:]):
(-[WebCoreNSURLSessionTaskMetrics dealloc]):
(-[WebCoreNSURLSessionTaskMetrics transactionMetrics]):
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]):
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSession taskCompleted:]):
(-[WebCoreNSURLSession addDelegateOperation:]):
(-[WebCoreNSURLSession task:didReceiveCORSAccessCheckResult:]):
(-[WebCoreNSURLSession task:didReceiveResponseFromOrigin:]):
(-[WebCoreNSURLSession rangeResponseGenerator]):
(-[WebCoreNSURLSession didPassCORSAccessChecks]):
(-[WebCoreNSURLSession finishTasksAndInvalidate]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession sendH2Ping:pongHandler:]):
(WebCore::WebCoreNSURLSessionDataTaskClient::WebCoreNSURLSessionDataTaskClient):
(WebCore::WebCoreNSURLSessionDataTaskClient::clearTask):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent):
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::shouldCacheResponse):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::accessControlCheckFailed):
(WebCore::WebCoreNSURLSessionDataTaskClient::loadFailed):
(WebCore::WebCoreNSURLSessionDataTaskClient::loadFinished):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:targetQueue:]):
(-[WebCoreNSURLSessionDataTask _cancel:]):
(-[WebCoreNSURLSessionDataTask error]):
(-[WebCoreNSURLSessionDataTask session]):
(-[WebCoreNSURLSessionDataTask setSession:]):
(-[WebCoreNSURLSessionDataTask resource]):
(-[WebCoreNSURLSessionDataTask setResource:]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask dealloc]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):
(-[WebCoreNSURLSessionDataTask resource:shouldCacheResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]):
(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:metrics:]):
(-[WebCoreNSURLSessionDataTask resource:accessControlCheckFailedWithError:]):
(-[WebCoreNSURLSessionDataTask resource:loadFailedWithError:]):
(-[WebCoreNSURLSessionDataTask resourceFinished:metrics:]):
(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:]): Deleted.
(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:]): Deleted.
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]): Deleted.
(-[WebCoreNSURLSessionDataTask _restart]): Deleted.
(-[WebCoreNSURLSessionDataTask _cancel]): Deleted.

Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):

Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::handleDataURL):

Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::setStatusLine):

Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::ResourceResponse):

Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):

Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::requestResource):

Source/WebKit/GPUProcess/media/RemoteMediaResource.cpp:

(WebKit::RemoteMediaResource::RemoteMediaResource):
(WebKit::RemoteMediaResource::~RemoteMediaResource):
(WebKit::RemoteMediaResource::shutdown):
(WebKit::RemoteMediaResource::didPassAccessControlCheck const):
(WebKit::RemoteMediaResource::responseReceived):
(WebKit::RemoteMediaResource::redirectReceived):
(WebKit::RemoteMediaResource::dataSent):
(WebKit::RemoteMediaResource::dataReceived):
(WebKit::RemoteMediaResource::accessControlCheckFailed):
(WebKit::RemoteMediaResource::loadFailed):
(WebKit::RemoteMediaResource::loadFinished):
(WebKit::RemoteMediaResource::stop): Deleted.

Source/WebKit/GPUProcess/media/RemoteMediaResource.h:
Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.cpp:

(WebKit::RemoteMediaResourceLoader::RemoteMediaResourceLoader):
(WebKit::RemoteMediaResourceLoader::requestResource):
(WebKit::RemoteMediaResourceLoader::sendH2Ping):

Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h:
Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:

(WebKit::RemoteMediaResourceManager::~RemoteMediaResourceManager):
(WebKit::RemoteMediaResourceManager::stopListeningForIPC):
(WebKit::RemoteMediaResourceManager::initializeConnection):
(WebKit::RemoteMediaResourceManager::addMediaResource):
(WebKit::RemoteMediaResourceManager::removeMediaResource):
(WebKit::RemoteMediaResourceManager::resourceForIdAndReady):
(WebKit::RemoteMediaResourceManager::responseReceived):
(WebKit::RemoteMediaResourceManager::redirectReceived):
(WebKit::RemoteMediaResourceManager::dataSent):
(WebKit::RemoteMediaResourceManager::dataReceived):
(WebKit::RemoteMediaResourceManager::accessControlCheckFailed):
(WebKit::RemoteMediaResourceManager::loadFailed):
(WebKit::RemoteMediaResourceManager::loadFinished):

Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:
Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::processResponse):

Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didGetFileInfo):

Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp:

(webkit_uri_response_get_mime_type):

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::removeResource):

Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveData):

Source/WebKit/WebProcess/Network/WebResourceLoader.h:

Canonical link: https://commits.webkit.org/251097@main

6:22 AM Changeset in webkit [294998] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.36.3

WPE WebKit 2.36.3

6:21 AM Changeset in webkit [294997] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.36

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.3 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.36.3.

6:21 AM Changeset in webkit [294996] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Use flex-basis when shrinking flex items
https://bugs.webkit.org/show_bug.cgi?id=241046

Reviewed by Antti Koivisto.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):

Canonical link: https://commits.webkit.org/251096@main

6:06 AM Changeset in webkit [294995] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Introduce the concept of frozen flex items
https://bugs.webkit.org/show_bug.cgi?id=241034

Reviewed by Antti Koivisto.

When a shrinking flex item gets too small, we exclude it from the shrinking algorithm and recompute the shrink factor. However the new shrink factor could make additional flex items too small.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):

Canonical link: https://commits.webkit.org/251095@main

5:43 AM Changeset in webkit [294994] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Introduce ShrinkingFlexItem structure
https://bugs.webkit.org/show_bug.cgi?id=241033

Reviewed by Antti Koivisto.

This local structure caches some of the shrinking related values.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):

Canonical link: https://commits.webkit.org/251094@main

3:43 AM Changeset in webkit [294993] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore/bindings/js

REGRESSION(251082@main): Broke WPE/GTK builds
https://bugs.webkit.org/show_bug.cgi?id=241060

Patch by Philippe Normand <philn@igalia.com> on 2022-05-28
Unreviewed, fix WPE/GTK builds by including new WebCoreOpaqueRoot header in custom JS bindings.

Source/WebCore/bindings/js/JSDOMQuadCustom.cpp:
Source/WebCore/bindings/js/JSNavigatorCustom.cpp:
Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:
Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:
Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:

Canonical link: https://commits.webkit.org/251093@main

2:11 AM Changeset in webkit [294992] by Adrian Perez de Castro

1 copy in releases/WebKitGTK/webkit-2.36.3

WebKitGTK 2.36.3

2:10 AM Changeset in webkit [294991] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.36

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.3 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.36.3.

2:10 AM Changeset in webkit [294990] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.36/Source

Merge r294939 - Non unified build fixes, lateish May 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=241019

Unreviewed build fixes.

Source/JavaScriptCore/wasm/js/WasmToJS.cpp: Add missing JSCJSValueInlines.h header inclusion.
Source/WebCore/platform/audio/MultiChannelResampler.cpp: Add missing <functional> header inclusion, needed for std::bind().

Canonical link: https://commits.webkit.org/251050@main

2:10 AM Changeset in webkit [294989] by Adrian Perez de Castro

3 edits in releases/WebKitGTK/webkit-2.36/Source

Merge r294881 - Cannot link WebKitTestRunner in non-unified builds
https://bugs.webkit.org/show_bug.cgi?id=240755

Reviewed by Adrian Perez de Castro.

In GTK non-unified build, WebKit shared library didn't export all
WEBCORE_EXPORT marked WebCore symbols because WebCore was a static
library.

WebCore should be an SHARED or OBJECT library to work WEBCORE_EXPORT
macro as expected.

Source/WebCore/PlatformGTK.cmake:
Source/WebCore/page/gtk/DragControllerGtk.cpp:
Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/251011@main

1:07 AM Changeset in webkit [294988] by jer.noble@apple.com

1 edit in trunk/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm

CRASH: Exception thrown from QueuedVideoOutput::invalidate
https://bugs.webkit.org/show_bug.cgi?id=241052
<rdar://93953827>

Reviewed by Eric Carlson.

Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm:

(WebCore::QueuedVideoOutput::QueuedVideoOutput):

An Objective-C exception is thrown from -removeObserver: stating the observer
was never added in the first place. Clear out ivars in the early return to avoid
doing work in invalidate() which (in addition to being unnecessary) will trigger
the exception.

Canonical link: https://commits.webkit.org/251092@main

May 27, 2022:

10:25 PM Changeset in webkit [294987] by Matt Woodrow

4 edits in trunk/Source/WebKit/UIProcess

Use desktop User Agent when preconnecting for loads that are predicted to use desktop content mode
https://bugs.webkit.org/show_bug.cgi?id=240938

Reviewed by Geoffrey Garen.

Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _preconnectToServer:]):

Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::preconnectTo):

Source/WebKit/UIProcess/WebPageProxy.h:
Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::useDesktopClassBrowsing const):
(WebKit::WebPageProxy::predictedUserAgentForRequest const):
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::predictedUserAgentForRequest const):

Canonical link: https://commits.webkit.org/251091@main

10:24 PM Changeset in webkit [294986] by Wenson Hsieh

1 edit in trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

Trigger element fullscreen video extraction after the seeked event
https://bugs.webkit.org/show_bug.cgi?id=241053

Reviewed by Devin Rousso.

Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::setMainVideoElement):

Canonical link: https://commits.webkit.org/251090@main

9:30 PM Changeset in webkit [294985] by Devin Rousso

1 edit in trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js

Web Inspector: CSS property name counts should be updated atomically
https://bugs.webkit.org/show_bug.cgi?id=240994

Reviewed by Patrick Angle.

Consider the following example:
`
display: foo;
display: bar;
`

Before this change, the following would happen:

get the cached count of display: foo
increment the cached count of display: foo by 1
get the stored count of display: foo
get the cached count of display: bar
increment the cached count of display: bar by 1
get the stored count of display: bar

(async)

increment the stored count of display: foo (from c) by 1

(async)

increment the stored count of display: bar (from f) by 1

The problem is that g/h get the same stored count because c/f happened before any updates occurred.

After this change, the following would happen:

get the cached count of display: foo
increment the cached count of display: foo by 1
get the cached count of display: bar
increment the cached count of display: bar by 1

(async)

get the stored count of display: foo

(async)

increment the stored count of display: foo (from e) by 1

(async)

get the stored count of display: bar

(async)

increment the stored count of display: bar (from g) by 1

By ensuring there is never more than one active operation on WI.objectStores.cssPropertyNameCounts
at a time, it is guaranteed that values will never be trampled over (though it takes a bit longer).

Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:

(WI.CSSProperty._initializePropertyNameCounts):
(WI.CSSProperty.prototype._updateName.changeCount):

Canonical link: https://commits.webkit.org/251089@main

9:22 PM Changeset in webkit [294984] by Chris Dumez

1 edit in trunk/Source/WebCore/html/InputType.cpp

Optimize InputType::create() by reducing calls to AtomString::convertToASCIILowercase()
https://bugs.webkit.org/show_bug.cgi?id=241043

Reviewed by Cameron McCormack.

In the common case, InputType::create() gets called with a type string that
is already lowercase. As a result, we would iterate over the whole string
unnecessarily under convertToASCIILowercase() to verify that it is already
lowercase, just to look up the type in a HashMap.

To avoid this, we now trying to look up the type in the HashMap directly, and
only fallback to calling convertToASCIILowercase() in the rare case where the
look up failed.

On my Apple Silicon MacBook Pro, this reduces the number of samples under
convertToASCIILowercase() from 17 to 4. Also reduces the number of samples
under InputType::create() from 21 to 12.

Source/WebCore/html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):
(WebCore::findFactory):
(WebCore::InputType::create):

Canonical link: https://commits.webkit.org/251088@main

9:10 PM Changeset in webkit [294983] by Alan Bujtas

1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Introduce base-size to the flex algorithm
https://bugs.webkit.org/show_bug.cgi?id=241001

Reviewed by Antti Koivisto.

This is in preparation for supporting flex-basis, where the flex-basis value is used as the base for flexing.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):

Canonical link: https://commits.webkit.org/251087@main

9:05 PM Changeset in webkit [294982] by Wenson Hsieh

3 edits in trunk/Source/WebKit

Rename the WebKit2 Image logging category to ImageAnalysis
https://bugs.webkit.org/show_bug.cgi?id=241032

Reviewed by Devin Rousso.

This existing logging category is only used for image analysis -- as such, the logging category
should be renamed to reflect that. This also avoids confusing these logs with the Images logging
category in WebCore, which is really about image decoding, rendering and painting.

No change in behavior.

Source/WebKit/Platform/Logging.h:
Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::computeHasVisualSearchResults):
(WebKit::WebViewImpl::installImageAnalysisOverlayView): Deleted.
(WebKit::WebViewImpl::uninstallImageAnalysisOverlayView): Deleted.

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _cancelImageAnalysis]):
(-[WKContentView validateImageAnalysisRequestIdentifier:]):
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
(-[WKContentView installImageAnalysisInteraction:]): Deleted.
(-[WKContentView uninstallImageAnalysisInteraction]): Deleted.

Canonical link: https://commits.webkit.org/251086@main

8:37 PM Changeset in webkit [294981] by Cameron McCormack

7 edits in trunk/Source/WebCore

Fix sense of the display list AsTextFlags
https://bugs.webkit.org/show_bug.cgi?id=240939

Reviewed by Simon Fraser.

They do the opposite of what their names suggest.

Source/WebCore/platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
(WebCore::DisplayList::DisplayList::dump const):

Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h:
Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::dumpItem):

Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::operator<<):

Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):

Source/WebCore/testing/Internals.h:
Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/251085@main

8:16 PM Changeset in webkit [294980] by Chris Dumez

4 edits in trunk/Source/WebCore/dom

Remove some unnecessary work from the Node destructor
https://bugs.webkit.org/show_bug.cgi?id=241035

Reviewed by Geoffrey Garen.

Remove some unnecessary work from the Node destructor as it shows on
Speedometer profiles.

In particular, stop calling clearRareData() as this is just clearing a data
member. Also move work that only applies to non-ContainerNode to the Text
and CharacterData destructors since those are the only two non-ContainerNodes.

Source/WebCore/dom/Attr.cpp:

(WebCore::Attr::~Attr):

Source/WebCore/dom/CharacterData.cpp:

(WebCore::CharacterData::~CharacterData):

Source/WebCore/dom/CharacterData.h:
Source/WebCore/dom/Node.cpp:

(WebCore::Node::~Node):

Canonical link: https://commits.webkit.org/251084@main

8:13 PM Changeset in webkit [294979] by Cameron McCormack

3 edits in trunk

Fix typo in ConcatenateCTM display list item serialization
https://bugs.webkit.org/show_bug.cgi?id=240935

Reviewed by Simon Fraser.

LayoutTests/displaylists/extent-includes-transforms-expected.txt:
LayoutTests/platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt:
Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):

Canonical link: https://commits.webkit.org/251083@main

7:40 PM Changeset in webkit [294978] by Chris Dumez

131 edits
1 add
1 delete in trunk/Source/WebCore

Refactor opaque root logic in WebCore in preparation for Node GC optimizations
https://bugs.webkit.org/show_bug.cgi?id=240998

Reviewed by Geoffrey Garen.

Refactor opaque root logic in WebCore in preparation for Node GC optimizations.
Introduce addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions for
WebCore to deal with opaque roots, instead of interacting with the SlotVisitor
directly. This introduce a nice central point in WebCore where we will be
able to set / check flags on Node to speed up GC.

Also introduce a WebCoreOpaqueRoot type to replace void* as type of opaque
roots in WebCore. This is useful because we will need to know whether an
opaque root in a Node or not in a future patch.

There is no expected behavior change from this patch, this is just pure
refactoring to make it a lot easier for us to optimize Node gargabe collection.

Source/WebCore/Modules/fetch/FetchRequest.cpp:

(WebCore::root):

Source/WebCore/Modules/fetch/FetchRequest.h:
Source/WebCore/Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::opaqueRoot):
(WebCore::root):

Source/WebCore/Modules/indexeddb/IDBIndex.h:
Source/WebCore/Modules/indexeddb/IDBIndex.idl:
Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::visitReferencedIndexes const):
(WebCore::root):

Source/WebCore/Modules/indexeddb/IDBObjectStore.h:
Source/WebCore/Modules/indexeddb/IDBRequest.cpp:

(WebCore::root):

Source/WebCore/Modules/indexeddb/IDBRequest.h:
Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::visitReferencedObjectStores const):

Source/WebCore/Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::opaqueRoot):

Source/WebCore/Modules/mediasource/SourceBuffer.h:
Source/WebCore/Modules/mediasource/SourceBufferList.cpp:

(WebCore::root):

Source/WebCore/Modules/mediasource/SourceBufferList.h:
Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::opaqueRootConcurrently const):

Source/WebCore/Modules/remoteplayback/RemotePlayback.h:
Source/WebCore/Modules/webaudio/AudioBuffer.cpp:

(WebCore::root):

Source/WebCore/Modules/webaudio/AudioBuffer.h:
Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp:

(WebCore::AudioWorkletGlobalScope::visitProcessors):

Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:

(WebCore::root):

Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h:
Source/WebCore/Modules/webxr/WebXRSession.cpp:

(WebCore::root):

Source/WebCore/Modules/webxr/WebXRSession.h:
Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebCore/bindings/js/JSAbortSignalCustom.cpp:

(WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):

Source/WebCore/bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitAdditionalChildren):

Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::visitAdditionalChildren):

Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitAdditionalChildren):

Source/WebCore/bindings/js/JSCSSRuleCustom.h:

(WebCore::root):

Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::root):
(WebCore::JSCSSStyleDeclaration::visitAdditionalChildren):

Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.h:
Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContext2D::visitAdditionalChildren):

Source/WebCore/bindings/js/JSDOMQuadCustom.cpp:

(WebCore::JSDOMQuad::visitAdditionalChildren):

Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitAdditionalChildren):

Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp:

(WebCore::JSDeprecatedCSSOMValueOwner::isReachableFromOpaqueRoots):

Source/WebCore/bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::visitAdditionalChildren):

Source/WebCore/bindings/js/JSFetchEventCustom.cpp:

(WebCore::JSFetchEvent::visitAdditionalChildren):

Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):

Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp:

(WebCore::JSHTMLTemplateElement::visitAdditionalChildren):

Source/WebCore/bindings/js/JSIDBCursorCustom.cpp:

(WebCore::JSIDBCursor::visitAdditionalChildren):

Source/WebCore/bindings/js/JSIDBIndexCustom.cpp: Removed.

(WebCore::JSIDBIndex::visitAdditionalChildren): Deleted.

Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp:

(WebCore::JSIntersectionObserver::visitAdditionalChildren):

Source/WebCore/bindings/js/JSIntersectionObserverEntryCustom.cpp:

(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren):

Source/WebCore/bindings/js/JSMediaListCustom.h:

(WebCore::root):

Source/WebCore/bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitAdditionalChildren):

Source/WebCore/bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitAdditionalChildren):

Source/WebCore/bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::visitAdditionalChildren):

Source/WebCore/bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNode::visitAdditionalChildren):

Source/WebCore/bindings/js/JSNodeCustom.h:

(WebCore::root):

Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitAdditionalChildren):

Source/WebCore/bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):

Source/WebCore/bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp:

(WebCore::root):
(WebCore::JSOffscreenCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSOffscreenCanvasRenderingContext2D::visitAdditionalChildren):

Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp:

(WebCore::root):
(WebCore::JSPaintRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSPaintRenderingContext2D::visitAdditionalChildren):

Source/WebCore/bindings/js/JSResizeObserverEntryCustom.cpp:

(WebCore::JSResizeObserverEntry::visitAdditionalChildren):

Source/WebCore/bindings/js/JSSVGViewSpecCustom.cpp:

(WebCore::JSSVGViewSpec::visitAdditionalChildren):

Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:

(WebCore::JSServiceWorkerGlobalScope::visitAdditionalChildren):

Source/WebCore/bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitAdditionalChildren):

Source/WebCore/bindings/js/JSStyleSheetCustom.h:

(WebCore::root):

Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):
(WebCore::JSTextTrackCue::visitAdditionalChildren):

Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitAdditionalChildren):

Source/WebCore/bindings/js/JSUndoItemCustom.cpp:

(WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots):

Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:

(WebCore::JSWebGL2RenderingContext::visitAdditionalChildren):

Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitAdditionalChildren):

Source/WebCore/bindings/js/JSWebXRSessionCustom.cpp:

(WebCore::JSWebXRSession::visitAdditionalChildren):

Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):

Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:

(WebCore::JSWorkerNavigator::visitAdditionalChildren):

Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitAdditionalChildren):

Source/WebCore/bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitAdditionalChildren):

Source/WebCore/bindings/js/WebCoreOpaqueRoot.h: Added.

(WebCore::WebCoreOpaqueRoot::WebCoreOpaqueRoot):
(WebCore::WebCoreOpaqueRoot::isNode const):
(WebCore::WebCoreOpaqueRoot::pointer const):
(WebCore::addWebCoreOpaqueRoot):
(WebCore::containsWebCoreOpaqueRoot):

Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp:

(WebCore::JSTestGenerateAddOpaqueRoot::visitChildrenImpl):

Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

Source/WebCore/crypto/CryptoKey.cpp:

(WebCore::root):

Source/WebCore/crypto/CryptoKey.h:
Source/WebCore/dom/AbortController.cpp:

(WebCore::AbortController::opaqueRoot):

Source/WebCore/dom/AbortController.h:
Source/WebCore/dom/AbortController.idl:
Source/WebCore/dom/AbortSignal.cpp:

(WebCore::root):

Source/WebCore/dom/AbortSignal.h:
Source/WebCore/dom/DOMPointReadOnly.cpp:

(WebCore::root):

Source/WebCore/dom/DOMPointReadOnly.h:
Source/WebCore/dom/DOMRectReadOnly.cpp:

(WebCore::root):

Source/WebCore/dom/DOMRectReadOnly.h:
Source/WebCore/dom/DocumentInlines.h:

(WebCore::Node::opaqueRoot const):

Source/WebCore/dom/MessagePort.cpp:

(WebCore::root):

Source/WebCore/dom/MessagePort.h:
Source/WebCore/dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):

Source/WebCore/dom/MutationRecord.cpp:
Source/WebCore/dom/Node.cpp:

(WebCore::Node::traverseToOpaqueRoot const):

Source/WebCore/dom/Node.h:

(WebCore::Node::opaqueRoot const): Deleted.

Source/WebCore/dom/NodeFilter.h:

(WebCore::root):

Source/WebCore/dom/Range.cpp:

(WebCore::Range::visitNodesConcurrently const):

Source/WebCore/dom/ScriptExecutionContext.cpp:

(WebCore::root):

Source/WebCore/dom/ScriptExecutionContext.h:
Source/WebCore/dom/StaticRange.cpp:

(WebCore::StaticRange::visitNodesConcurrently const):

Source/WebCore/fileapi/Blob.cpp:

(WebCore::root):

Source/WebCore/fileapi/Blob.h:
Source/WebCore/html/CanvasBase.cpp:

(WebCore::root):

Source/WebCore/html/CanvasBase.h:
Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::root):

Source/WebCore/html/HTMLCanvasElement.h:
Source/WebCore/html/HTMLMediaElement.h:
Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::addMembersToOpaqueRoots):

Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
Source/WebCore/html/canvas/WebGLObject.cpp:

(WebCore::root):

Source/WebCore/html/canvas/WebGLObject.h:
Source/WebCore/html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::addMembersToOpaqueRoots):

Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::addMembersToOpaqueRoots):
(WebCore::root):

Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:

(WebCore::WebGLTransformFeedback::addMembersToOpaqueRoots):

Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp:

(WebCore::WebGLVertexArrayObjectBase::addMembersToOpaqueRoots):
(WebCore::root):

Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h:
Source/WebCore/html/track/TrackBase.cpp:

(WebCore::TrackBase::opaqueRoot):

Source/WebCore/html/track/TrackBase.h:

(WebCore::root):

Source/WebCore/html/track/TrackListBase.cpp:

(WebCore::TrackListBase::opaqueRoot):

Source/WebCore/html/track/TrackListBase.h:

(WebCore::root):

Source/WebCore/page/DOMWindow.cpp:

(WebCore::root):

Source/WebCore/page/DOMWindow.h:
Source/WebCore/page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::isReachableFromOpaqueRoots const):

Source/WebCore/page/NavigatorBase.cpp:

(WebCore::root):

Source/WebCore/page/NavigatorBase.h:
Source/WebCore/page/ResizeObserver.cpp:

(WebCore::ResizeObserver::isReachableFromOpaqueRoots const):

Source/WebCore/workers/WorkerLocation.cpp:

(WebCore::root):

Source/WebCore/workers/WorkerLocation.h:

(WebCore::WorkerLocation::create):
(WebCore::WorkerLocation::url const):
(WebCore::WorkerLocation::WorkerLocation):

Source/WebCore/workers/service/ServiceWorkerClients.cpp:

(WebCore::root):

Source/WebCore/workers/service/ServiceWorkerClients.h:
Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:

(WebCore::root):

Source/WebCore/workers/service/ServiceWorkerRegistration.h:
Source/WebCore/xml/XMLHttpRequestUpload.cpp:

(WebCore::root):

Source/WebCore/xml/XMLHttpRequestUpload.h:

Canonical link: https://commits.webkit.org/251082@main

7:19 PM Changeset in webkit [294977] by yurys@chromium.org

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm

WKHTTPCookieStore tests should use removeDataOfTypes to delete all cookies
https://bugs.webkit.org/show_bug.cgi?id=240726

Reviewed by Sihui Liu.

Call WKWebsiteDataStore.removeDataOfTypes when to clear all cookies
instead of deleting them one by one. Besides simplifying the code it
documents the API recommended for the clients.

Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

(clearCookies):
(TEST):
(deleteCookies): Deleted.

Canonical link: https://commits.webkit.org/251081@main

7:12 PM Changeset in webkit [294976] by Kate Cheney

1 edit in trunk/Source/WebCore/html/HTMLAttachmentElement.cpp

[WK2] Attachment icons do not update after updating filewrapper
https://bugs.webkit.org/show_bug.cgi?id=241026
rdar://86293273

Reviewed by Wenson Hsieh.

In the case of certain iWork file types downloaded from iCloud that require
thumbnails, we don't remove the progress update once the filewrapper is updated
with the complete attachment, which prevents the thumbnail from appearing.

This patch removes the progress attribute once the thumbnail is updated
so we know we can now paint the icon.

No new tests. There's no clear way to test this change. For previous thumbnail bugs
we swizzled the thumbnail generator code to make sure we were generating
thumbnails; however, this bug is a case of the thumbnail being generated but not
displayed. Similarly, we can't compare the attachment size because it is the same for
the attachment with and without the correct thumbnail.

Source/WebCore/html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateThumbnail):

Canonical link: https://commits.webkit.org/251080@main

6:46 PM Changeset in webkit [294975] by J Pascoe

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm

[ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239311
<rdar://91723056>

Reviewed by Brent Fulgham.

There is a race condition when using waitForMessage that we hit here, causing flaky tests on
some bots. This patch avoids this by specifying the messages waited for before loading the
request.

Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:

(-[TestSOAuthorizationScriptMessageHandler initWithExpectation:]):
(-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251079@main

6:23 PM Changeset in webkit [294974] by commit-queue@webkit.org

1 edit in trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp

[GLib] Properly deprecate WebKitSettings properties enable-accelerated-2d-canvas, enable-plugins, and enable-xss-auditor
https://bugs.webkit.org/show_bug.cgi?id=240993

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-27
Reviewed by Adrian Perez de Castro.

Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

Canonical link: https://commits.webkit.org/251078@main

6:06 PM Changeset in webkit [294973] by timothy_horton@apple.com

41 edits in trunk/Source/WebCore

Add a fake style bit for mouse click handlers
https://bugs.webkit.org/show_bug.cgi?id=240924

Reviewed by Antti Koivisto.

Add a bit to EventListenerRegionType for mouse click events, and
populate it via Node::willRespondToMouseClickEvents.

To do so while avoiding recursive style computation, make it possible
to plumb Editability through to willRespondToMouseClickEventsWithEditability.
This short-circuits Node calling into computeEditability() from the base
implementation of willRespondToMouseClickEvents, which reenters style computation
via computedStyle() when called from StyleAdjuster (where EventListenerRegionType
is populated).

Also make a variant of computeEditability that takes a passed-in style, and
do some refactoring to share more code between platforms (without changing
behavior, even in cases where the behavior differences are suprising).

Source/WebCore/dom/Node.cpp:

(WebCore::computeEditabilityFromComputedStyle):
Instead of computing style, computeEditabilityFromComputedStyle is now passed a RenderStyle reference.

(WebCore::Node::computeEditabilityWithStyle const):
This subsumes most of the logic from computeEditability(), but will
compute the style (only if we need it) if it is not passed in.

(WebCore::Node::computeEditability const):
computeEditability retains its "normal" API, passing through its arguments and a null style,
indicating to computeEditabilityWithStyle that it should compute the style as usual.

(WebCore::Node::computeEditabilityForMouseClickEvents const):
A variant of computeEditabilityWithStyle that maintains an odd existing
platform-specific difference in the UserSelectAllTreatment argument,
and allows callers of willRespondToMouseClickEventsWithEditability to
all be consistent.

(WebCore::Node::willRespondToMouseClickEvents const):
Maintain the existing behavior of willRespondToMouseClickEvents; compute editability as needed.

(WebCore::Node::willRespondToMouseClickEventsWithEditability const):
willRespondToMouseClickEventsWithEditability is now the override point, and
will not itself cause a style update.
Refactor this function a bit to share as much code as possible between platforms
(and maintain an existing comment questioning the differences that we maintain).

Source/WebCore/dom/Node.h:

Source/WebCore/rendering/EventRegion.cpp:

(WebCore::EventRegion::eventListenerRegionForType const):

Source/WebCore/rendering/RenderLayerBacking.cpp:

(WebCore::patternForEventListenerRegionType):
Add EventListenerRegionType::MouseClick to these two switches over EventListenerRegionType,
but break and fall into the ASSERT_NOT_REACHED default state; these are only called
for wheel event listeners.

Source/WebCore/rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

Source/WebCore/rendering/style/RenderStyleConstants.h:
Source/WebCore/style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjustEventListenerRegionTypesForRootStyle):
(WebCore::Style::Adjuster::computeEventListenerRegionTypes):
(WebCore::Style::Adjuster::adjust const):
If we're building interaction regions, propagate EventListenerRegionType::MouseClick
down the style tree like we do for wheel event listeners. This is a bit more complicated
than wheel event listeners, using the Node method instead of just looking at the
set of event listeners, because many elements accept mouse clicks *without* having
event listeners installed; they just implement behaviors in their default event handlers.

Source/WebCore/style/StyleAdjuster.h:

Source/WebCore/page/InteractionRegion.cpp:

(WebCore::interactionRegions):
Adopt the new fake style bit. This is not the final intended use: we will use it from
EventRegion::unite(), like we do for wheel events, in a future patch.

Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLAnchorElement.h:
Source/WebCore/html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLButtonElement.h:
Source/WebCore/html/HTMLElement.cpp:

(WebCore::HTMLElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLElement.h:
Source/WebCore/html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLImageElement.h:
Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLInputElement.h:
Source/WebCore/html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLLabelElement.h:
Source/WebCore/html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLPlugInElement.h:
Source/WebCore/html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLSelectElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLSelectElement.h:
Source/WebCore/html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLSummaryElement.h:
Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/HTMLTextAreaElement.h:
Source/WebCore/html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/shadow/SliderThumbElement.h:
Source/WebCore/html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/shadow/SpinButtonElement.h:
Source/WebCore/html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents const): Deleted.
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/html/shadow/TextControlInnerElements.h:
Source/WebCore/mathml/MathMLElement.cpp:

(WebCore::MathMLElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::MathMLElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/mathml/MathMLElement.h:
Source/WebCore/mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/mathml/MathMLSelectElement.h:
Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SVGAElement::willRespondToMouseClickEvents const): Deleted.

Source/WebCore/svg/SVGAElement.h:

Propagate editability through overrides of willRespondToMouseClickEvents(WithEditability).

Canonical link: https://commits.webkit.org/251077@main

5:56 PM Changeset in webkit [294972] by commit-queue@webkit.org

15 edits
3 copies in trunk/Source/WebCore

Add EXT_texture_compression_bptc WebGL extension support
https://bugs.webkit.org/show_bug.cgi?id=235637

Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-05-27
Reviewed by Kenneth Russell.

Support BPTC texture formats and slightly cleanup RGTC code.

Source/WebCore/CMakeLists.txt:
Source/WebCore/DerivedSources-input.xcfilelist:
Source/WebCore/DerivedSources-output.xcfilelist:
Source/WebCore/DerivedSources.make:
Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp.

(WebCore::EXTTextureCompressionBPTC::EXTTextureCompressionBPTC):
(WebCore::EXTTextureCompressionBPTC::getName const):
(WebCore::EXTTextureCompressionBPTC::supported):

Source/WebCore/html/canvas/EXTTextureCompressionBPTC.h: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h.
Source/WebCore/html/canvas/EXTTextureCompressionBPTC.idl: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h.
Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp:

(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):
(WebCore::EXTTextureCompressionRGTC::supported):

Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h:
Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

Source/WebCore/html/canvas/WebGLExtension.h:
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::loseExtensions):

Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
Source/WebCore/platform/graphics/GraphicsContextGL.h:

Canonical link: https://commits.webkit.org/251076@main

5:32 PM Changeset in webkit [294971] by timothy_horton@apple.com

1 edit
1 delete in trunk/Source/WebKit

Remove WebKit feature flags plist
https://bugs.webkit.org/show_bug.cgi?id=241042

Reviewed by Wenson Hsieh.

Source/WebKit/FeatureFlags/WebKit.plist: Removed.
Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Now that the blocking bug is resolved, we can remove this entirely.

Canonical link: https://commits.webkit.org/251075@main

5:01 PM Changeset in webkit [294970] by Simon Fraser

12 edits in trunk

Optimize setting SVG element transforms
https://bugs.webkit.org/show_bug.cgi?id=240825

Reviewed by Said Abou-Hallawa.

When parseTransformValueGeneric() creates SVGTransformValues, it default-constructed them
and then called setRotate(), setScale() etc, which would reset m_matrix to identity a second time.

Optimize by providing static helpers for creating translate, rotate and scale SVGTransformValues
which initialize the matrix with the final value. Helpers are added to AffineTransform to
create scale, translate and rotate transforms, renaming translation to makeTranslation so
that the "scale" helper doesn't conflict with the scale member function.

This reduces the time spent under the Element::setAttribute() function in the MotionMark
Suits test by about 14%.

Source/WebCore/page/FrameView.cpp:

(WebCore::FrameView::rectForViewportConstrainedObjects):

Source/WebCore/platform/graphics/FontCascade.cpp:

(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:

(WebCore::LegacyRenderSVGRoot::paintReplaced):
(WebCore::LegacyRenderSVGRoot::localToParentTransform const):

Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::localToParentTransform const):

Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

Source/WebCore/svg/SVGTransform.h:

(WebCore::SVGTransform::create):
(WebCore::SVGTransform::SVGTransform):

Source/WebCore/svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parseGeneric):

Source/WebCore/svg/SVGTransformValue.h:

(WebCore::SVGTransformValue::translateTransformValue):
(WebCore::SVGTransformValue::rotateTransformValue):
(WebCore::SVGTransformValue::scaleTransformValue):
(WebCore::SVGTransformValue::setMatrix):
(WebCore::SVGTransformValue::matrixDidChange):
(WebCore::SVGTransformValue::setTranslate):
(WebCore::SVGTransformValue::setScale):
(WebCore::SVGTransformValue::setRotate):

Source/WebCore/svg/SVGTransformable.cpp:

(WebCore::parseTransformValueGeneric):

Source/WebCore/svg/properties/SVGValueProperty.h:
Tools/TestWebKitAPI/Tests/WebCore/AffineTransform.cpp:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251074@main

5:00 PM Changeset in webkit [294969] by pvollan@apple.com

1 edit in trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in

[macOS][GPUP] Block unused system calls
https://bugs.webkit.org/show_bug.cgi?id=240966
<rdar://84826074>

Reviewed by Chris Dumez.

Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/251073@main

4:55 PM Changeset in webkit [294968] by Devin Rousso

1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js

Web Inspector: Sources: editing a breakpoint action to cause the CodeMirror to wrap doesn't update the WI.Popover size
https://bugs.webkit.org/show_bug.cgi?id=220643
<rdar://problem/73225206>

Reviewed by Patrick Angle.

Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView.prototype._updateBody):
(WI.BreakpointActionView.prototype._handleJavaScriptCodeMirrorUpdate): Added.
(WI.BreakpointActionView.prototype._codeMirrorViewportChanged): Deleted.
Replace listening for "viewportChange" (and "update") with "updates", each time comparing the
getScrollInfo().clientHeight (we don't care about the clientWidth because it's hardcoded in the
CSS .breakpoint-action-eval-editor > .CodeMirror) with the last value. This is necessary because
"viewportChange" is only fired when the number of lines changes, which a wrapped line doesn't do.

Canonical link: https://commits.webkit.org/251072@main

4:52 PM Changeset in webkit [294967] by Devin Rousso

1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

Web Inspector: Timelines: switching between Events/Frames while editing instruments leaves the UI in a broken state
https://bugs.webkit.org/show_bug.cgi?id=218700
<rdar://problem/71180148>

Reviewed by Patrick Angle.

Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype.set viewMode):
(WI.TimelineOverview.prototype._viewModeDidChange):
Forcibly stop editing instruments when switching between Events/Frames. Note that this will save the
current state of edited instruments, so no changes will be lost.

Canonical link: https://commits.webkit.org/251071@main

4:40 PM Changeset in webkit [294966] by aboya@igalia.com

1 edit in trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py

git-webkit pr: Show server response when updating an issue fails

Reviewed by Jonathan Bedard.

Small changes are also made to the request() method to make it more
reusable: now it can handle methods other than GET, and can print custom
error messages when requests fail.

Bare usages of python-requests have been refactored to use
self.request() where possible (that is, when the path being accessed is
within the repo URL).

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:

Canonical link: https://commits.webkit.org/251070@main

4:09 PM Changeset in webkit [294965] by mark.lam@apple.com

57 edits
2 deletes in trunk

Revert "Enable WasmLLInt on ARMv7"

Unreviewed.

This reverts commit 2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9.

2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9 breaks WASM on 64-bit platforms.

Canonical link: https://commits.webkit.org/251068@main

4:08 PM Changeset in webkit [294964] by Wenson Hsieh

1 edit in trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

[iOS] Performing the image markup action should reset _imageAnalysisMarkupData
https://bugs.webkit.org/show_bug.cgi?id=241024

Reviewed by Aditya Keerthi.

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView imageAnalysisMarkupMenu]):

Canonical link: https://commits.webkit.org/251068@main

4:02 PM Changeset in webkit [294963] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Update internal CSS to remove '-webkit-' prefixing where possible
https://bugs.webkit.org/show_bug.cgi?id=240930
<rdar://93934318>

Patch by Sammy Gill <sgill26@apple.com> on 2022-05-27
Reviewed by Brent Fulgham and Tim Nguyen.

There are many instances in WebCore where prefixed versions of CSS
attributes are being used even though these attributes have been
standardized and have unprefixed versions. The prefixed versions no
longer need to be used and can be replaced by their unprefixed
equivalents.

Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:
Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:
Source/WebCore/Modules/mediacontrols/mediaControlsBase.css:
Source/WebCore/css/html.css:
Source/WebCore/css/legacyFormControlsIOS.css:
Source/WebCore/css/mediaControls.css:
Source/WebCore/css/themeAdwaita.css:
Source/WebCore/html/shadow/imageOverlay.css:
Source/WebCore/html/shadow/mac/imageControlsMac.css:
Source/WebCore/html/shadow/meterElementShadow.css:
Source/WebCore/xml/XMLViewer.css:

Canonical link: https://commits.webkit.org/251067@main

3:59 PM Changeset in webkit [294962] by Karl Rackler

3 edits in trunk/LayoutTests/platform

[Gardening]: [ iOS macOS ] two imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage tests are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=241048
<rdar://94056966>

Unreviewed test gardening.

LayoutTests/platform/ios/TestExpectations:
LayoutTests/platform/mac-wk1/TestExpectations:
LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/251066@main

3:55 PM Changeset in webkit [294961] by commit-queue@webkit.org

1 edit in trunk/LayoutTests/webgl/TestExpectations

Flakes in WebGL conformance[2]/textures/image_bitmap_from_image_bitmap/ tests
https://bugs.webkit.org/show_bug.cgi?id=241027

Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-27
Unreviewed test gardening.

LayoutTests/webgl/TestExpectations:

Mark all tests under:

webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image_bitmap

as flaky (Pass Failure) while the bug is being investigated.

Canonical link: https://commits.webkit.org/251065@main

3:48 PM Changeset in webkit [294960] by mark.lam@apple.com

2 edits in trunk/Source

Revert "Non unified build fixes, lateish May 2022 edition"

Unreviewed.

This reverts commit 2db7e5eef53c0424ac30bccf7cdf9aa8428e9464.

We need to revert 2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9 because it broke WASM on
64-bit platforms. 2db7e5eef53c0424ac30bccf7cdf9aa8428e9464 was builds on top of
2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9, and hence, needs to be reverted too.

Canonical link: https://commits.webkit.org/251064@main

3:10 PM Changeset in webkit [294959] by Devin Rousso

2 edits
2 adds in trunk

[Modern Media Controls] REGRESSION(r293684) cannot pause <video> if controls are added after "play"
https://bugs.webkit.org/show_bug.cgi?id=240985
<rdar://problem/93822316>

Reviewed by Eric Carlson.

Source/WebCore/Modules/modern-media-controls/media/media-controller.js:

(MediaController):
Actually check if the media is playing and/or has played instead of always assuming false.

Source/WebCore/Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype._shouldShowStartButton):
Drive-by: It's no longer necessary to check media.played.length here it's part of mediaController.hasPlayed.

LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play.html: Added.
LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play-expected.txt: Added.

Canonical link: https://commits.webkit.org/251062@main

3:10 PM Changeset in webkit [294958] by commit-queue@webkit.org

2 edits in trunk/Source

Crash under RemoteDisplayListRecorder::restore()
https://bugs.webkit.org/show_bug.cgi?id=240545

Reviewed by Simon Fraser.

Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
Avoid restoring the GraphicsContext stack for volatile
ImageBuffers. The buffers do not have a graphics context.

Source/WebCore/platform/graphics/ConcreteImageBuffer.h:

Add an assertion to check that volatile image buffers
do not try to access their context.

Canonical link: https://commits.webkit.org/251061@main

3:05 PM Changeset in webkit [294957] by Alan Coon

1 copy in tags/WebKit-7614.1.14.10.9

Tag WebKit-7614.1.14.10.9.

3:02 PM Changeset in webkit [294956] by Alan Coon

9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.9

2:50 PM Changeset in webkit [294955] by Devin Rousso

6 edits
4 adds in trunk

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions
https://bugs.webkit.org/show_bug.cgi?id=239909
<rdar://problem/87885717>

Reviewed by Wenson Hsieh.

This exception happens when trying to add attributes for text that contains collapsed whitespace and
has also been wrapped due to the size of its parent container. The exception specifically is about
trying to add attributes beyond the current length of a NSAttributedString.

Source/WebCore/editing/TextIteratorBehavior.h:
Source/WebCore/editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextRun):
In the case that m_lastTextNodeEndedWithCollapsedSpace, we only want to add the remaining text if
we're still within the desired portion of the m_textRun. Otherwise, we'll iterate over too much of
the text and result in a string that's longer than what would be the case if one manually calculated
it from the given offset and offsetEnd. Add a new TextIteratorBehavior::IgnoresWhiteSpaceAtEndOfRun
to not include the trailing whitespace.

Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
Use the new WebCore::TextIteratorBehavior::IgnoresWhiteSpaceAtEndOfRun to not include the trailing
whitespace.
Also add some defensive checks just in case.

Source/WebCore/testing/Internals.idl:
Source/WebCore/testing/Internals.h:
Source/WebCore/testing/Internals.cpp:

(WebCore::toTextIteratorBehaviors): Added.
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):
(WebCore::Internals::statesOfTextIterator): Added.
Add a way to provide TextIteratorBehaviors to methods that use TextIterator.
Add a method that gets the text and range of a TextIterator after every advance.

LayoutTests/editing/text-iterator/sequential-collapsed-ranges.html: Added.
LayoutTests/editing/text-iterator/sequential-collapsed-ranges-expected.txt: Added.
LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace.html: Added.
LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace-expected.txt: Added.

Canonical link: https://commits.webkit.org/251061@main

2:37 PM Changeset in webkit [294954] by Alan Coon

1 copy in tags/WebKit-7614.1.14.1.14

Tag WebKit-7614.1.14.1.14.

2:35 PM Changeset in webkit [294953] by Alan Coon

1 copy in tags/WebKit-7614.1.14.0.13

Tag WebKit-7614.1.14.0.13.

2:10 PM Changeset in webkit [294952] by Elliott Williams

6 edits
1 add in trunk/Source

[Xcode] Compute PGO profdata paths instead of searching for them at build time
https://bugs.webkit.org/show_bug.cgi?id=239681

Reviewed by Wenson Hsieh and Alexey Proskuryakov.

Production builds should always use profdata from the SDK, internal
release builds should use profdata from the local WebKitAdditions when
available, and open source builds should use the stub profdata. Add a
PROFILE_DATA_PATH build setting which implements these rules and replace
the script phases that checked those paths dynamically.

This fixes XCBuild validation issues in the open-source build, and
should prevent production builders from using stale profdata in
BUILT_PRODUCTS_DIR. Additionally, engineers can now build with custom
profile data by overriding PROFILE_DATA_PATH.

Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
Source/JavaScriptCore/Scripts/copy-profiling-data.sh: Added. This file is part of JavaScriptCore's private headers and replaces the "Copy Profiling Data" script phase logic all projects.
Source/WebKit/Configurations/BaseTarget.xcconfig:
Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Source/WebCore/Configurations/WebCore.xcconfig:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/251060@main

1:52 PM Changeset in webkit [294951] by Chris Dumez

2 edits in trunk/Source

Start allocating shared memory with MAP_MEM_VM_SHARE again on newer OSes
https://bugs.webkit.org/show_bug.cgi?id=241014
<rdar://94032696>

Reviewed by Simon Fraser.

When we started doing memory attribution in the GPUProcess, we stopped using
the MAP_MEM_VM_SHARE flag when creating SharedMemory, because it was
incompatible with attribution. However, creating shared memory would fail
without the MAP_MEM_VM_SHARE flag under certain circumstances (due to size
restriction iirc), in which case we would fall back to using MAP_MEM_VM_SHARE
and fail memory attribution.

As of <rdar://73715428>, MAP_MEM_VM_SHARE is now compatible with memory
attribution so this patch starts using the flag again and unconditionally on
newer OSes.

Source/WTF/wtf/PlatformHave.h:
Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:

(WebKit::makeMemoryEntry):

Canonical link: https://commits.webkit.org/251059@main

1:14 PM Changeset in webkit [294950] by J Pascoe

3 edits in trunk/Source

[WebAuthn] Forward declare ASC SPI for internal needs.
https://bugs.webkit.org/show_bug.cgi?id=240928
rdar://problem/93930713

Reviewed by Brent Fulgham.

This fixes the build after an internal change for older macOS.

Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Remove unused import that isn't present in older macOS sdk.

Canonical link: https://commits.webkit.org/251058@main

12:54 PM Changeset in webkit [294949] by sihui_liu@apple.com

3 edits in trunk/Source/WebCore

Stop exposing ApplicationCache API if it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=241000

Reviewed by Chris Dumez.

Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
Source/WebCore/loader/appcache/DOMApplicationCache.idl:
Source/WebCore/page/DOMWindow.idl:

Canonical link: https://commits.webkit.org/251057@main

12:29 PM Changeset in webkit [294948] by Truitt Savell

7 edits
2 deletes in trunk

Revert "REGRESSION(r289580): Canvas: putImageData sometimes draws nothing"

Unreviewed revert of commit 749c20ef7e6693fc1e69be46db08eedabc4d8a1b.

This caused Mac EWS testing to exit early with 30+ failures.

Canonical link: https://commits.webkit.org/251056@main

12:20 PM Changeset in webkit [294947] by achristensen@apple.com

27 edits in trunk/Source

Move disk operations when deleting cookies off from the main thread
https://bugs.webkit.org/show_bug.cgi?id=240981
<rdar://92415240>

Reviewed by Geoff Garen.

This should reduce hangs and increase responsiveness.

Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
Source/WebCore/inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::deleteCookie):

Source/WebCore/loader/CookieJar.cpp:

(WebCore::CookieJar::deleteCookie):

Source/WebCore/loader/CookieJar.h:
Source/WebCore/platform/network/NetworkStorageSession.h:
Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict):
(WebCore::NetworkStorageSession::deleteHTTPCookie const):
(WebCore::NetworkStorageSession::deleteCookie const):
(WebCore::NetworkStorageSession::deleteAllCookies):
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
(WebCore::NetworkStorageSession::deleteAllCookiesModifiedSince):
(WebCore::NetworkStorageSession::flushCookieStore): Deleted.
(WebCore::deleteAllHTTPCookies): Deleted.

Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::deleteCookiesForHostnames):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):

Source/WebKit/NetworkProcess/Cookies/WebCookieManager.h:
Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in:
Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::deleteCookie):

Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):

Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::deleteAllCookies):

Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::deleteAllCookies):

Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::deleteCookiesForHostnames):
(WebKit::WebCookieManagerProxy::deleteAllCookies):

Source/WebKit/UIProcess/WebCookieManagerProxy.h:
Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::deleteCookie):

Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:

(WebKit::WebCookieCache::cookiesDeleted):
(WebKit::WebCookieCache::clearForHost):

Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::deleteCookie):

Source/WebKit/WebProcess/WebPage/WebCookieJar.h:
Source/WebKitLegacy/mac/WebView/WebPreferences.mm:

(+[WebPreferences _clearNetworkLoaderSession]):

Canonical link: https://commits.webkit.org/251055@main

11:58 AM Changeset in webkit [294946] by commit-queue@webkit.org

13 edits
3 adds in trunk

Add EXT_texture_norm16 WebGL extension support
https://bugs.webkit.org/show_bug.cgi?id=220343

Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-05-27
Reviewed by Kenneth Russell.

LayoutTests/TestExpectations:
Source/WebCore/CMakeLists.txt:
Source/WebCore/DerivedSources-input.xcfilelist:
Source/WebCore/DerivedSources-output.xcfilelist:
Source/WebCore/DerivedSources.make:
Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

Source/WebCore/html/canvas/EXTTextureNorm16.cpp: Added.

(WebCore::EXTTextureNorm16::EXTTextureNorm16):
(WebCore::EXTTextureNorm16::getName const):
(WebCore::EXTTextureNorm16::supported):

Source/WebCore/html/canvas/EXTTextureNorm16.h: Added.
Source/WebCore/html/canvas/EXTTextureNorm16.idl: Added.
Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):

Source/WebCore/html/canvas/WebGLExtension.h:
Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypesWebGL2):
(WebCore::WebGLRenderingContextBase::loseExtensions):

Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
Source/WebCore/platform/graphics/GraphicsContextGL.h:

Canonical link: https://commits.webkit.org/251054@main

11:41 AM Changeset in webkit [294945] by Alan Coon

9 edits in branches/safari-7614.1.14.1-branch/Source

Versioning.

WebKit-7614.1.14.1.14

11:38 AM Changeset in webkit [294944] by Alan Coon

9 edits in branches/safari-7614.1.14.0-branch/Source

Versioning.

WebKit-7614.1.14.0.13

10:59 AM Changeset in webkit [294943] by don.olmstead@sony.com

1 edit in trunk/Source/cmake/WebKitFeatures.cmake

[CMake] Support string values in cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=241013

Reviewed by Adrian Perez de Castro and Michael Catanzaro.

Add EXPOSE_STRING_VARIABLE_TO_BUILD which adds a string variable to the config. Modify
CREATE_CONFIGURATION_HEADER to output the values to cmakeconfig.h.

Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/251053@main

10:58 AM Changeset in webkit [294942] by Lauro Moura

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538

Reviewed by Adrian Perez de Castro.

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings): Move test of deprecated function to section
disabling deprecation warnings.

Canonical link: https://commits.webkit.org/251052@main

10:22 AM Changeset in webkit [294941] by Alan Coon

9 edits in trunk/Source

Versioning.

WebKit-7614.1.16

10:12 AM Changeset in webkit [294940] by Alan Coon

1 copy in tags/WebKit-7614.1.14.11.4

Tag WebKit-7614.1.14.11.4.

9:54 AM Changeset in webkit [294939] by Adrian Perez de Castro

2 edits in trunk/Source

Non unified build fixes, lateish May 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=241019

Unreviewed build fixes.

Source/JavaScriptCore/wasm/js/WasmToJS.cpp: Add missing JSCJSValueInlines.h header inclusion.
Source/WebCore/platform/audio/MultiChannelResampler.cpp: Add missing <functional> header inclusion, needed for std::bind().

Canonical link: https://commits.webkit.org/251050@main

8:49 AM Changeset in webkit [294938] by Tyler Wilcock

8 edits
1 add in trunk

AX: Update the isolated tree in response to dynamic aria-haspopup and aria-describedby changes
https://bugs.webkit.org/show_bug.cgi?id=240968

Reviewed by Chris Fleizach.

Testcases added to aria-describedby-on-input.html
and element-haspopup.html to cover this change.

LayoutTests/accessibility/aria-describedby-on-input-expected.txt:
LayoutTests/accessibility/aria-describedby-on-input.html:
LayoutTests/accessibility/element-haspopup-expected.txt:
LayoutTests/accessibility/element-haspopup.html:
LayoutTests/platform/ios/accessibility/aria-describedby-on-input-expected.txt: Added.
LayoutTests/platform/ios/TestExpectations:
Source/WebCore/accessibility/AXLogger.cpp:

(WebCore::operator<<):

Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):

Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/251049@main

7:47 AM Changeset in webkit [294937] by Jean-Yves Avenard

6 edits in trunk/Source/WebKit

Simplify MediaPlayerPrivateRemote::RequestResource API
https://bugs.webkit.org/show_bug.cgi?id=240999
<rdar://94012261>

Reviewed by Eric Carlson.

When the GPU Process' MediaPlayerProxy needs to allocate a new MediaResource it sends
a message to the content process via the MediaPlayerPrivateRemote::RequestResource
IPC call with a RemoteMediaResourceIdentifier which will then respond to indicate that
the MediaResource is now "ready".

There's two scenarios possible here:
Either the creation of the media resource in the content process is successful or it's not.

If it's successful the content process will start sending data starting by a call to the
GPU's RemoteMediaResourceManager responseReceived
Or it will fail and call RemoteMediaResourceManager::LoadFailed.

The RemoteMediaResourceManager will only accept incoming data once the MediaResource's
ready status is true, and if you're only working on the main thread, it will always be,
as the Content Process' RequestResource response will always be received before either
a LoadFailed or ResponseReceived call.
Under these conditions, the ready status is totally redundant. Testing that the
RemoteMediaResource exists in the MediaResourceManager's map is sufficient.

However, if we want to parallelise networking operations so that ResponseReceived and
LoadFailed will be called on a secondary thread as introduced in bug 235353;
the "ready" flag becomes problematic as the response from a RequestResource is handled
on the main thread.
The multi-threaded nature of the work means that the RequestResource response could be
received only after LoadFailed or ResponseReceived message; and if that's the case
those two messages will be dropped.

This can be seen with the intermittent failures occurring with media/video-src-blob-replay.html test.

So we remove this concept of RemoteMediaResource::ready as at best it serves no purpose.

Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::requestResource):

Source/WebKit/GPUProcess/media/RemoteMediaResource.h:

(WebKit::RemoteMediaResource::ready const): Deleted.
(WebKit::RemoteMediaResource::setReady): Deleted.

Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:

(WebKit::RemoteMediaResourceManager::responseReceived):
(WebKit::RemoteMediaResourceManager::redirectReceived):
(WebKit::RemoteMediaResourceManager::dataSent):
(WebKit::RemoteMediaResourceManager::dataReceived):
(WebKit::RemoteMediaResourceManager::accessControlCheckFailed):
(WebKit::RemoteMediaResourceManager::loadFailed):
(WebKit::RemoteMediaResourceManager::loadFinished):

Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::requestResource):

Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:

Canonical link: https://commits.webkit.org/251048@main

6:17 AM Changeset in webkit [294936] by commit-queue@webkit.org

1 edit in trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in

Unreviewed, reverting r294898.
https://bugs.webkit.org/show_bug.cgi?id=241008

Introduced crash

Reverted changeset:

"[macOS][GPUP] Block unused system calls"
https://bugs.webkit.org/show_bug.cgi?id=240966
https://commits.webkit.org/r294898

Canonical link: https://commits.webkit.org/251047@main

4:03 AM Changeset in webkit [294935] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore/platform/graphics

[TextureMapper] Generalize YUV-to-RGB matrices
https://bugs.webkit.org/show_bug.cgi?id=240952

Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-27
Reviewed by Miguel Gomez.

Right now, TextureMapper supports converting YUV data to RGB when using either
the BT.601 or BT.709 colorspaces. The caller provides the basic 3x3 conversion
matrix for the given colorspace, and the offsets agains the initial YUV values
are hard-coded in the shader since they are the same for both colorspaces.

To support additional colorspaces (which don't share the same offset values) the
matrix handling has to be generalized. This means every conversion matrix is now
4x4 in size, with the adjusted offset values residing in the last column.

Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:

(WebCore::GstVideoFrameHolder::platformLayerBuffer):

Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexturePlanarYUV):
(WebCore::TextureMapperGL::drawTextureSemiPlanarYUV):
(WebCore::TextureMapperGL::drawTexturePackedYUV):

Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:

(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper):

Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Canonical link: https://commits.webkit.org/251046@main

1:47 AM Changeset in webkit [294934] by commit-queue@webkit.org

57 edits
2 adds in trunk

Enable WasmLLInt on ARMv7

Patch by Geza Lore <Geza Lore> on 2022-05-27
https://bugs.webkit.org/show_bug.cgi?id=221260

Reviewed by Saam Barati.

Patch by Geza Lore and Xan López.

Implement the LLInt tier of WebAssembly for ARMv7. A lot of the
work will be shared by any 32bit port, but the offlineassembler
has only been updated for ARMv7 so far.

Main highlights:

We have split the WebAssembly.asm file into three chunks,
following what LowLevelInterpreter.asm does. The common code
remains in WebAssembly.asm, and 32 and 64bit specific code (mostly
opcode implementations) goes into WebAssembly32_64.asm and
WebAssembly64.asm.

We have decided to use consecutive even/odd pairs of GPRs for every
type of wasm values, even if they are 32bit (i32/f32), with the odd
(higher) numbered GPR holding the more significant half. 32bit values
are held in the even (lower) numbered register. This makes the code
much simpler and allows us to share more code with the 64bit variant.
This is mostly relevant for argument passing, and given that every
value ends up in the stack anyway we do not think it is significant
from a performance POV.

We are reusing JSValueRegs to hold Wasm values too. Obviously they
are not really JSValues, so it might make sense to create a base
class that can be used for both JS and Wasm values.

We do not have enough registers to keep things like the memory
base pointer and size in pinned registers, so we are forced to
load them on each use.

We disable the 'Signaling' memory mode, since the current
implementation relies on being able to mprotect a 2^{32 + redzone

region of memory. This can be changed in the future but it's not a

priority at the moment.}

stress/sampling-profiler-wasm-name-section.js:
stress/sampling-profiler-wasm.js:
wasm/regress/llint-callee-saves-with-fast-memory.js:
CMakeLists.txt:
assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::vcvt_signedToFloatingPoint):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertInt32ToFloat):
(JSC::MacroAssemblerARMv7::threadSafePatchableNearCall):
(JSC::MacroAssemblerARMv7::callOperation):

b3/B3ValueRep.h:

(JSC::B3::ValueRep::ValueRep):

bytecode/BytecodeDumper.cpp:

(JSC::Wasm::BytecodeDumper::formatConstant const):

interpreter/CallFrame.h: adapt to new callee tagging format.

(JSC::CallFrame::callee const):
(JSC::CallFrame::unsafeCallee const):

interpreter/CalleeBits.h: add wasm tagging of callee values for

32bit.
(JSC::CalleeBits::CalleeBits):
(JSC::CalleeBits::operator=):
(JSC::CalleeBits::boxWasm):
(JSC::CalleeBits::isWasm const):
(JSC::CalleeBits::asWasmCallee const):

interpreter/Register.h:

(JSC::Register::unboxedFloat const):
(JSC::Register::asanUnsafeUnboxedFloat const):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::unboxDouble):

jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):

jit/RegisterAtOffsetList.h:

(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):

jit/RegisterSet.cpp:

(JSC::RegisterSet::macroScratchRegisters):

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter32_64.asm:
llint/WebAssembly.asm:
llint/WebAssembly32_64.asm: Added.
llint/WebAssembly64.asm: Added.
offlineasm/arm.rb:
offlineasm/instructions.rb:
offlineasm/registers.rb:
offlineasm/risc.rb:
runtime/JSCJSValue.h:

(JSC::wasmUnboxedFloat):

runtime/JSCJSValueInlines.h:

(JSC::JSValue::JSValue):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::useSignalingMemory const):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::AirIRGenerator::addCall):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::useSignalingMemory const):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addArguments):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::memoryKind):
(JSC::Wasm::B3IRGenerator::addCall):

wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

wasm/WasmCallee.cpp:

(JSC::Wasm::LLIntCallee::calleeSaveRegisters):

wasm/WasmCalleeGroup.cpp:

(JSC::Wasm::CalleeGroup::isSafeToRun):

wasm/WasmCallingConvention.cpp:

(JSC::Wasm::jsCallingConvention):
(JSC::Wasm::wasmCallingConvention):

wasm/WasmCallingConvention.h:

(JSC::Wasm::CallInformation::computeResultsOffsetList):
(JSC::Wasm::WasmCallingConvention::WasmCallingConvention):
(JSC::Wasm::WasmCallingConvention::marshallLocationImpl const):
(JSC::Wasm::WasmCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::JSCallingConvention):
(JSC::Wasm::JSCallingConvention::marshallLocationImpl const):
(JSC::Wasm::JSCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::callInformationFor const):

wasm/WasmFormat.h:
wasm/WasmIndexOrName.cpp:

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):

wasm/WasmIndexOrName.h:

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::IndexOrName::isEmpty const):
(JSC::Wasm::IndexOrName::isIndex const):
(JSC::Wasm::IndexOrName::isName const):
(JSC::Wasm::IndexOrName::index const):
(JSC::Wasm::IndexOrName::name const):
(JSC::Wasm::IndexOrName::nameSection const):

wasm/WasmInstance.h:

(JSC::Wasm::Instance::updateCachedMemory):

wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::virtualRegisterForWasmLocal):
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addLoop):

wasm/WasmLLIntPlan.cpp:

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

wasm/WasmMemory.cpp:

(JSC::Wasm::MemoryHandle::~MemoryHandle):
(JSC::Wasm::Memory::tryCreate):
(JSC::Wasm::Memory::growShared):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::copy):

wasm/WasmMemory.h:
wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::PinnedRegisterInfo::get):

wasm/WasmMemoryInformation.h:

(JSC::Wasm::PinnedRegisterInfo::toSave const):

wasm/WasmMemoryMode.cpp:

(JSC::Wasm::makeString):

wasm/WasmMemoryMode.h:
wasm/WasmOpcodeOrigin.cpp:
wasm/WasmOpcodeOrigin.h:
wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

wasm/WasmOperations.h:
wasm/WasmPageCount.h:
wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::parseUInt32):
(JSC::Wasm::Parser<SuccessType>::parseUInt64):

wasm/WasmSlowPaths.cpp:

(JSC::LLInt::WASM_SLOW_PATH_DECL):
(JSC::LLInt::slow_path_wasm_popcount):
(JSC::LLInt::slow_path_wasm_popcountll):
(JSC::LLInt::slow_path_wasm_i32_div_s):
(JSC::LLInt::slow_path_wasm_i32_div_u):
(JSC::LLInt::slow_path_wasm_i32_rem_s):
(JSC::LLInt::slow_path_wasm_i32_rem_u):
(JSC::LLInt::slow_path_wasm_i64_div_s):
(JSC::LLInt::slow_path_wasm_i64_div_u):
(JSC::LLInt::slow_path_wasm_i64_rem_s):
(JSC::LLInt::slow_path_wasm_i64_rem_u):

wasm/WasmSlowPaths.h:
wasm/WasmValueLocation.cpp:

(JSC::Wasm::ValueLocation::dump const):
(WTF::printInternal):

wasm/WasmValueLocation.h:

(JSC::Wasm::ValueLocation::ValueLocation):
(JSC::Wasm::ValueLocation::isGPR const):
(JSC::Wasm::ValueLocation::isFPR const):
(JSC::Wasm::ValueLocation::isStack const):
(JSC::Wasm::ValueLocation::isStackArgument const):
(JSC::Wasm::ValueLocation::jsr const):
(JSC::Wasm::ValueLocation::fpr const):
(JSC::Wasm::ValueLocation::reg): Deleted.
(JSC::Wasm::ValueLocation::isReg const): Deleted.
(JSC::Wasm::ValueLocation::reg const): Deleted.
(JSC::Wasm::ValueLocation::gpr const): Deleted.

wasm/js/JSToWasm.cpp:

(JSC::Wasm::marshallJSResult):
(JSC::Wasm::createJSToWasmWrapper):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::previousInstanceOffset const):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::initializeExports):

wtf/PlatformEnable.h: enable WebAssembly on ARMv7.
Scripts/run-jsc-stress-tests: allow to run the wasm tests on

armv7 even without jit support (for now).

Canonical link: https://commits.webkit.org/251045@main

May 26, 2022:

11:57 PM Changeset in webkit [294933] by Ross Kirsling

7 edits in trunk

Remove per-iteration detached buffer check in %TypedArray% set and sort methods
https://bugs.webkit.org/show_bug.cgi?id=240995

Reviewed by Yusuke Suzuki.

This patch implements the spec changes of tc39/ecma262#2646 and tc39/ecma262#2723:
%TypedArray%.prototype.{set, sort} no longer repeatedly check for detachment as they iterate through a buffer.

JSTests/stress/typedarray-functions-with-neutered.js:
JSTests/test262/expectations.yaml:
LayoutTests/js/typed-array-mutated-during-set.html:
LayoutTests/js/typed-array-mutated-during-set-expected.txt:
Source/JavaScriptCore/builtins/TypedArrayPrototype.js:

(globalPrivate.typedArrayMerge):
(globalPrivate.typedArrayElementCompare): Deleted.

Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:
Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::set):

Canonical link: https://commits.webkit.org/251044@main

11:23 PM Changeset in webkit [294932] by don.olmstead@sony.com

7 edits
2 adds in trunk

[Curl] Implement WebSocketTask
https://bugs.webkit.org/show_bug.cgi?id=237579

Reviewed by Alex Christensen.

Implement WebSocketTask for curl platforms. Use the SocketProvider to create the
WebSocketChannel. Update web socket expectations based on the WebSocketTask
implementation.

LayoutTests/platform/wincairo/TestExpectations:
Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
Source/WebKit/NetworkProcess/WebSocketTask.h:
Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:
Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h:
Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp: Added.
Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h: Added.
Source/WebKit/PlatformPlayStation.cmake:
Source/WebKit/PlatformWin.cmake:

Canonical link: https://commits.webkit.org/251043@main

10:47 PM Changeset in webkit [294931] by Chris Dumez

12 edits in trunk/Source

Avoid ElementIdentifier-related work under Element::removedFromAncestor()
https://bugs.webkit.org/show_bug.cgi?id=240932

Reviewed by Darin Adler.

Avoid ElementIdentifier-related work under Element::removedFromAncestor() since it is a
hot function and we want to do as little work as possible in there.

Source/WebCore/dom/Document.cpp:

(WebCore::Document::dispatchSystemPreviewActionEvent):
(WebCore::Document::identifierForElement): Deleted.
(WebCore::Document::searchForElementByIdentifier): Deleted.
(WebCore::Document::identifiedElementWasRemovedFromDocument): Deleted.

Source/WebCore/dom/Document.h:
Source/WebCore/dom/Element.cpp:

(WebCore::Element::removedFromAncestor):
(WebCore::elementIdentifiersMap):
(WebCore::Element::identifier const):
(WebCore::Element::fromIdentifier):
(WebCore::Element::createElementIdentifier): Deleted.

Source/WebCore/dom/Element.h:
Source/WebCore/dom/Node.h:
Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

Source/WebCore/page/InteractionRegion.cpp:

(WebCore::regionForElement):

Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::elementIdentifier const):
(WebCore::Internals::isElementAlive const):

Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::elementForContext const):
(WebKit::WebPage::contextForElement const):

Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::textInputContextsInRect):

Canonical link: https://commits.webkit.org/251042@main

10:45 PM Changeset in webkit [294930] by Chris Dumez

8 edits
2 adds in trunk/Source/WebCore

Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses
https://bugs.webkit.org/show_bug.cgi?id=240914

Reviewed by Ryosuke Niwa and Darin Adler.

Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses.
These functions are hot and should be kept as efficient as possible. There is no reason for every
Element to pay run-time cost for checks that only apply to article or label elements.

Source/WebCore/Headers.cmake:
Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebCore/dom/Element.cpp:

(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::removedFromAncestor):

Source/WebCore/dom/Element.h:
Source/WebCore/html/HTMLArticleElement.cpp: Added.

(WebCore::HTMLArticleElement::create):
(WebCore::HTMLArticleElement::HTMLArticleElement):
(WebCore::HTMLArticleElement::insertedIntoAncestor):
(WebCore::HTMLArticleElement::removedFromAncestor):

Source/WebCore/html/HTMLArticleElement.h: Added.
Source/WebCore/html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::insertedIntoAncestor):
(WebCore::HTMLLabelElement::removedFromAncestor):

Source/WebCore/html/HTMLLabelElement.h:
Source/WebCore/html/HTMLTagNames.in:

Canonical link: https://commits.webkit.org/251041@main

10:20 PM Changeset in webkit [294929] by Ross Kirsling

2 edits in trunk

ArrayBuffer species should be ignored when cloning a Typed Array
https://bugs.webkit.org/show_bug.cgi?id=240996

Reviewed by Yusuke Suzuki.

This patch implements the spec change of tc39/ecma262#2719:
Constructing one Typed Array from another used to require that we check @@species on the source buffer and create
a new ArrayBuffer using the species constructor's *prototype*...without actually calling the species constructor itself.
Happily, this ridiculous behavior turned out to be web-compatible to remove.

JSTests/test262/expectations.yaml:
Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructCustomArrayBufferIfNeeded): Deleted.

Canonical link: https://commits.webkit.org/251040@main

8:55 PM Changeset in webkit [294928] by Said Abou-Hallawa

7 edits
2 adds in trunk

REGRESSION(r289580): Canvas: putImageData sometimes draws nothing
https://bugs.webkit.org/show_bug.cgi?id=240802
rdar://93801722

Reviewed by Simon Fraser.

RemoteImageBufferProxy::putPixelBuffer() needs to setNeedsFlush(true) once the
request to change the backend is sent to GPUProcess. If WebProcess has access to
the ImageBufferBackend, flushDrawingContext() will be called from copyNativeImage().
This call has to wait all DisplayList items and PutPixelBuffer messages to be
flushed to the backend before copyNativeImage() copies the pixels of the backend
to a NativeImage.

Source/WebCore/platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::setNeedsFlush):

Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:

(WebKit::RemoteDisplayListRecorderProxy::send):
(WebKit::RemoteDisplayListRecorderProxy::resetNeedsFlush): Deleted.
(WebKit::RemoteDisplayListRecorderProxy::needsFlush const): Deleted.
(): Deleted.

Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):

Canonical link: https://commits.webkit.org/251039@main

8:51 PM Changeset in webkit [294927] by achristensen@apple.com

8 edits in trunk

Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
https://bugs.webkit.org/show_bug.cgi?id=240362

Reviewed by Chris Dumez.

This is a PLT performance improvement because we spend less time initiating TCP connections.

Source/WTF/wtf/PlatformHave.h:
Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:
Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::initializeNSURLSessionsInSet):
(WebKit::SessionSet::initializeEphemeralStatelessSessionIfNeeded):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):

Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):

Canonical link: https://commits.webkit.org/251038@main

7:29 PM Changeset in webkit [294926] by Ross Kirsling

2 edits in trunk/JSTests/test262

Unreviewed test262 gardening, use useArrayGroupByMethod for feature tests
https://bugs.webkit.org/show_bug.cgi?id=240997

JSTests/test262/config.yaml:
JSTests/test262/expectations.yaml:

Canonical link: https://commits.webkit.org/251037@main

6:54 PM Changeset in webkit [294925] by Alan Coon

1 copy in tags/WebKit-7614.1.14.3.4

Tag WebKit-7614.1.14.3.4.

6:51 PM Changeset in webkit [294924] by Alan Coon

9 edits in branches/safari-7614.1.14.3-branch/Source

Versioning.

WebKit-7614.1.14.3.4

6:49 PM Changeset in webkit [294923] by Alan Coon

1 copy in tags/WebKit-7614.1.14.2.5

Tag WebKit-7614.1.14.2.5.

6:48 PM Changeset in webkit [294922] by Alan Coon

9 edits in branches/safari-7614.1.14.2-branch/Source

Versioning.

WebKit-7614.1.14.2.5

6:47 PM Changeset in webkit [294921] by Alan Coon

8 edits
2 deletes in branches/safari-7614.1.14.2-branch

Revert r294186. rdar://problem/93213436

This reverts r294697.

6:40 PM Changeset in webkit [294920] by Lauro Moura

4 edits in trunk

[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538

Reviewed by Adrian Perez de Castro and Michael Catanzaro.

250264@main removed the WKPreference entry regarding Java support, which in turn
was dropped long time ago.

Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty): Do not call deprecated function.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkit_settings_get_enable_java): Add deprecation warnings.
(webkit_settings_set_enable_java): Add deprecation warnings.

Source/WebKit/UIProcess/API/gtk/WebKitSettings.h: Mark functions as

deprecated.

Source/WebKit/UIProcess/API/wpe/WebKitSettings.h: Ditto.
Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings): Update for new behavior and remove fatal warning
flag for enable-java block as the warnings are expected.

Canonical link: https://commits.webkit.org/251036@main

5:58 PM Changeset in webkit [294919] by Alan Coon

1 copy in tags/WebKit-7614.1.14.0.12

Tag WebKit-7614.1.14.0.12.

5:57 PM Changeset in webkit [294918] by Alan Coon

1 copy in tags/WebKit-7614.1.14.1.13

Tag WebKit-7614.1.14.1.13.

5:56 PM Changeset in webkit [294917] by sbarati@apple.com

12 edits in trunk/Source/JavaScriptCore

Rename putDirect to putDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=240992
<rdar://92298537>

Reviewed by Mark Lam.

Source/JavaScriptCore/dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

Source/JavaScriptCore/ftl/FTLOperations.cpp:

(JSC::FTL::JSC_DEFINE_JIT_OPERATION):

Source/JavaScriptCore/runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createEmpty):

Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

Source/JavaScriptCore/runtime/IteratorOperations.cpp:

(JSC::createIteratorResultObject):

Source/JavaScriptCore/runtime/JSONObject.cpp:

(JSC::Walker::walk):

Source/JavaScriptCore/runtime/JSObject.cpp:

(JSC::JSObject::setPrototypeDirect):
(JSC::JSObject::putDirectCustomGetterSetterWithoutTransition):
(JSC::JSObject::putDirectNonIndexAccessorWithoutTransition):

Source/JavaScriptCore/runtime/JSObject.h:

(JSC::JSObject::putDirectOffset):
(JSC::JSObject::putDirectWithoutBarrier):
(JSC::JSObject::putDirectUndefined): Deleted.

Source/JavaScriptCore/runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectInternal):

Source/JavaScriptCore/runtime/ObjectConstructor.h:

(JSC::constructObjectFromPropertyDescriptor):

Source/JavaScriptCore/runtime/RegExpMatchesArray.h:

(JSC::createRegExpMatchesArray):

Source/JavaScriptCore/runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

Canonical link: https://commits.webkit.org/251035@main

5:50 PM Changeset in webkit [294916] by Chris Dumez

10 edits in trunk

Make StringView(const char*) private
https://bugs.webkit.org/show_bug.cgi?id=240942

Reviewed by Darin Adler.

Make StringView(const char*) private and update existing call sites
to use either StringView(ASCIILiteral) or StringView::fromLatin1(const char*).

Source/WTF/wtf/text/StringView.h:
Source/WebCore/platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclaredAsBlob):

Source/WebGPU/WGSL/Parser.cpp:

(WGSL::Parser<Lexer>::parseTypeDecl):

Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::stringViewFromLiteral):

Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251034@main

5:23 PM Changeset in webkit [294915] by Alan Coon

1 edit in branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in

Cherry-pick r294282. rdar://problem/93249176

[macOS] Fix mach syscall sandbox violation in the Network process
https://bugs.webkit.org/show_bug.cgi?id=240466
<rdar://93249176>

Reviewed by Chris Dumez.

Fix mach syscall sandbox violation in the Network process on macOS.

Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

Canonical link: https://commits.webkit.org/250626@main

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:10 PM Changeset in webkit [294914] by Alan Coon

9 edits in branches/safari-7614.1.14.11-branch/Source

Versioning.

WebKit-7614.1.14.11.4

5:05 PM Changeset in webkit [294913] by Alan Coon

22 edits in branches/safari-7614.1.15-branch

Cherry-pick r294897. rdar://problem/93984643

Define WK_NOT_NO in SDKVariant.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=240963
rdar://problem/93984643

Reviewed by Alexey Proskuryakov.

Provide a definition of WK_NOT_NO = YES, so that the $(WK_NOT_$(SOME_BUILD_SETTING)) construction can
be relied upon to produce a result of YES if the original build setting has a value of NO, which shouldn't
be handled substantially different from an empty string.

PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:
Source/JavaScriptCore/Configurations/SDKVariant.xcconfig:
Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig:
Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig:
Source/WTF/Configurations/SDKVariant.xcconfig:
Source/WebCore/Configurations/SDKVariant.xcconfig:
Source/WebCore/PAL/Configurations/SDKVariant.xcconfig:
Source/WebGPU/Configurations/SDKVariant.xcconfig:
Source/WebInspectorUI/Configurations/SDKVariant.xcconfig:
Source/WebKit/Configurations/SDKVariant.xcconfig:
Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig:
Source/bmalloc/Configurations/SDKVariant.xcconfig:
Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:
Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig:
Tools/MiniBrowser/Configurations/SDKVariant.xcconfig:
Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig:
Tools/WebEditingTester/Configurations/SDKVariant.xcconfig:
Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig:
Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:

Canonical link: https://commits.webkit.org/251020@main

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [294912] by Devin Rousso

1 edit in trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js

REGRESSION (250994@main): inspector/css/css-property.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=240986
<rdar://problem/94001813>

Reviewed by Patrick Angle.

Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype._updateName.changeCount):
Don't adjust WI.CSSProperty._cachedNameCounts when updating WI.objectStores.cssPropertyNameCounts
as the latter will not work in LayoutTests (to avoid having to reset state between tests).

Canonical link: https://commits.webkit.org/251033@main

4:59 PM Changeset in webkit [294911] by Jenner@apple.com

1 edit in trunk/LayoutTests/platform/mac/TestExpectations

[ Gardening ]: New test: [macOS] http/tests/media/hls/hls-webvtt-flashing.html is frequently failing
https://bugs.webkit.org/show_bug.cgi?id=240989

Unreviewed test gardening.

LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/251032@main

4:48 PM Changeset in webkit [294910] by Alan Coon

1 copy in tags/WebKit-7614.1.14.10.8

Tag WebKit-7614.1.14.10.8.

4:47 PM Changeset in webkit [294909] by Alan Coon

9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.8

4:41 PM Changeset in webkit [294908] by Nikos Mouchtaris

2 edits in trunk/LayoutTests/platform

Disable heic tests temporarily
https://bugs.webkit.org/show_bug.cgi?id=240990

Unreviewed test expectation chnage.

LayoutTests/platform/ios/TestExpectations:
LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/251030@main

4:41 PM Changeset in webkit [294907] by Patrick Angle

2 edits in trunk/LayoutTests/inspector/debugger/breakpoints

Web Inspector: inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=239134
rdar://91639437

Reviewed by Devin Rousso.

This test was flaky because the only piece of code in the test keeping the SourceProvider alive for dump-multiline.js
was the function test(), which is replaced by the function test() in the test page itself. This meant that the
function from dump-multiline.js would be garbage collected at some point, and since it was the last possible way to
reach source code in dump-multiline.js, the SourceProvider was also disposed of at the same time.

Normally this would not be an issue for users because the source code itself is still viewable in Web Inspector, and
breakpoints can still be set (and will be triggered after a reload). The issue here is that when we attach Web Inspector
the source code is longer reachable, so the backend doesn't send information for it to the frontend for it (until a page
reload), but this test is assuming the script will have been sent from the backend to associate with the resource.

LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt:
LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js:

Canonical link: https://commits.webkit.org/251030@main

4:13 PM Changeset in webkit [294906] by don.olmstead@sony.com

1 edit in trunk/Source/cmake/OptionsPlayStation.cmake

[CMake][PlayStation] Base find_package checks on whether WebCore is being built
https://bugs.webkit.org/show_bug.cgi?id=240974

Reviewed by Ross Kirsling.

Move any find_package for WebCore libraries under a check for
ENABLE_WEBCORE. Shift the find_package checks to the top of the
file. This will allow us to base ENABLE flags on whether or not a
package is found. Fix a couple style issues while there.

Source/cmake/OptionsPlayStation.cmake:

Canonical link: https://commits.webkit.org/251029@main

3:51 PM Changeset in webkit [294905] by mark.lam@apple.com

1 edit in trunk/Source/JavaScriptCore/runtime/JSCellInlines.h

Re-factoring clean up in allocateCell and tryAllocateCell.
https://bugs.webkit.org/show_bug.cgi?id=240973

Reviewed by Saam Barati.

The AllocationFailureMode should be a template parameter to tryAllocateCellHelper because it's
constant. Also, tryAllocateCellHelper should take a VM& instead of taking a Heap& and then
converting it back to a VM&.

Source/JavaScriptCore/runtime/JSCellInlines.h:

(JSC::tryAllocateCellHelper):
(JSC::allocateCell):
(JSC::tryAllocateCell):

Canonical link: https://commits.webkit.org/251028@main

3:39 PM Changeset in webkit [294904] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Add support for flex-shrink
https://bugs.webkit.org/show_bug.cgi?id=240957

Reviewed by Antti Koivisto.

This patch implements a simple "let's shrink the flex items when available space is limited" logic.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/251027@main

3:34 PM Changeset in webkit [294903] by pvollan@apple.com

1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

[iOS][WP] Block access to file-ioctl commands
https://bugs.webkit.org/show_bug.cgi?id=240977
<rdar://88334007>

Reviewed by Chris Dumez.

This is based on collected telemetry. This patch also adds telemetry to file read/write of /dev/aes_0
to determine if that can be removed as well.

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: https://commits.webkit.org/251026@main

3:22 PM Changeset in webkit [294902] by Alan Bujtas

5 edits in trunk/Source/WebCore/rendering

Do not issue repaint when the ancestor layer has already been scheduled for one
https://bugs.webkit.org/show_bug.cgi?id=240728

Reviewed by Simon Fraser.

When a renderer needs repaint, we walk the layer tree to search for the repaint container (root for all the paints).
If we find a layer between the renderer and the repaint container that has already been scheduled for a full repaint
we know that this repaint is redundant and will be covered by the ancestor layer.
Since layers paint their overflow content, this works even when the renderer "sticks out" of the ancestor layer's renderer's border box (i.e. produces ink/scrollable overflow).

Source/WebCore/rendering/RenderLayer.cpp:

(WebCore::RenderLayer::enclosingCompositingLayerForRepaint const):
(WebCore::RenderLayer::clipCrossesPaintingBoundary const):
(WebCore::RenderLayer::calculateClipRects const):

Source/WebCore/rendering/RenderLayer.h:

(WebCore::RenderLayer::needsFullRepaint const):

Source/WebCore/rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):

Source/WebCore/rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint const):
(WebCore::fullRepaintIsScheduled): This covers the cases when the content is embedded inside an iframe and the iframe's view is not composited.
(WebCore::RenderObject::repaint const):
(WebCore::RenderObject::repaintRectangle const):

Source/WebCore/rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

Canonical link: https://commits.webkit.org/251025@main

3:15 PM Changeset in webkit [294901] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp

AX: -Wswitch warnings in AXObjectCacheAtspi.cpp
https://bugs.webkit.org/show_bug.cgi?id=240956

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-26
Reviewed by Adrian Perez de Castro.

Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

Canonical link: https://commits.webkit.org/251024@main

2:56 PM Changeset in webkit [294900] by Jonathan Bedard

7 edits in trunk/Tools/Scripts/libraries/webkitscmpy

[git-webkit] Use --git-common-dir over hard-coded .git
https://bugs.webkit.org/show_bug.cgi?id=240732
<rdar://93676555>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.Cache.path): Use common_directory instead of .git.
(Git.is_svn): Ditto.
(Git.common_directory): Attempt to determine path to .git directory with
git rev-parse --git-common-dir.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:

(Scm.common_directory): Added.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.Cache.path): Use common_directory instead of .svn.
(Svn.common_directory): Added.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:

(Setup.git): Use common_directory instead of .git.

Canonical link: https://commits.webkit.org/251023@main

2:31 PM Changeset in webkit [294899] by pvollan@apple.com

1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in

[iOS][GPUP] Block unused system calls
https://bugs.webkit.org/show_bug.cgi?id=240960
<rdar://84826074>

Reviewed by Chris Dumez.

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/251022@main

2:29 PM Changeset in webkit [294898] by pvollan@apple.com

1 edit in trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in

[macOS][GPUP] Block unused system calls
https://bugs.webkit.org/show_bug.cgi?id=240966
<rdar://84826074>

Reviewed by Chris Dumez.

Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/251021@main

2:12 PM Changeset in webkit [294897] by david_quesada@apple.com

22 edits in trunk

Define WK_NOT_NO in SDKVariant.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=240963
rdar://problem/93984643

Reviewed by Alexey Proskuryakov.

Provide a definition of WK_NOT_NO = YES, so that the $(WK_NOT_$(SOME_BUILD_SETTING)) construction can
be relied upon to produce a result of YES if the original build setting has a value of NO, which shouldn't
be handled substantially different from an empty string.

PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:
Source/JavaScriptCore/Configurations/SDKVariant.xcconfig:
Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig:
Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig:
Source/WTF/Configurations/SDKVariant.xcconfig:
Source/WebCore/Configurations/SDKVariant.xcconfig:
Source/WebCore/PAL/Configurations/SDKVariant.xcconfig:
Source/WebGPU/Configurations/SDKVariant.xcconfig:
Source/WebInspectorUI/Configurations/SDKVariant.xcconfig:
Source/WebKit/Configurations/SDKVariant.xcconfig:
Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig:
Source/bmalloc/Configurations/SDKVariant.xcconfig:
Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:
Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig:
Tools/MiniBrowser/Configurations/SDKVariant.xcconfig:
Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig:
Tools/WebEditingTester/Configurations/SDKVariant.xcconfig:
Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig:
Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:

Canonical link: https://commits.webkit.org/251020@main

2:07 PM Changeset in webkit [294896] by don.olmstead@sony.com

1 edit in trunk/Source/WebCore/accessibility/AXObjectCache.h

Fix !ENABLE(ACCESSIBILITY) after r294878
https://bugs.webkit.org/show_bug.cgi?id=240976

Reviewed by Chris Fleizach.

Some methods with AXObjectCache were missing an !ENABLE(ACCESSIBILITY) build.

Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/251019@main

1:45 PM Changeset in webkit [294895] by commit-queue@webkit.org

4 edits in trunk/Source

Build with -Wno-stringop-overflow when using GCC
https://bugs.webkit.org/show_bug.cgi?id=240596

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-26
Reviewed by Adrian Perez de Castro.

Also, rearrange and simplify the warning flag code.

And remove suppression of -Wno-attributes, since GCC 8 is everywhere nowadays.

Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Source/JavaScriptCore/ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):

Source/WebCore/loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::end):

Source/cmake/WebKitCompilerFlags.cmake:

Canonical link: https://commits.webkit.org/251018@main

1:19 PM Changeset in webkit [294894] by Tyler Wilcock

2 edits in trunk/Source/WebCore/accessibility/isolatedtree

AX: Don't create isolated objects from ignored live objects
https://bugs.webkit.org/show_bug.cgi?id=240507

Reviewed by Chris Fleizach.

Sometimes, we can get into a state where a live object has dynamically
become ignored but not removed as a child from its parent (since
unignored objects are the only thing that should be in any
AccessibilityObject::m_children). This can cause us to create an
isolated object for this ignored live object.

With this change, we now return a std::nullopt NodeChange for an
ignored live object.

I split this change off from a different patch improving our handling of
modals. It is required to make accessibility/aria-modal-multiple-dialogs.html
pass in isolated tree mode.

Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::nodeChangeForObject):
(WebCore::AXIsolatedTree::queueRemovalsAndUnresolvedChanges):
(WebCore::AXIsolatedTree::updateNode):

Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/251016@main

1:18 PM Changeset in webkit [294893] by Jonathan Bedard

2 edits in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy

[git-webkit] Support radar when auto-filing bug
https://bugs.webkit.org/show_bug.cgi?id=240969
<rdar://problem/93989777>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:

(Branch.main): Handle case where tracker does not have defined credentials.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:

(TestBranch.test_create_bug): Added.

Canonical link: https://commits.webkit.org/251016@main

1:06 PM Changeset in webkit [294892] by Alan Coon

1 edit in branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm

Cherry-pick r294877. rdar://problem/93834054

Uniform buffer reuse causes flush, creates invalid state
https://bugs.webkit.org/show_bug.cgi?id=240896

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-26
Patch by Kyle Piddington.

Reviewed by Kimmo Kinnunen.

A flush during draw setup would leave the render command encoder
not started and render pipeline unset. This would assert in debug
and leak memory with corrupted draws in release.

This would happen for example when uniform buffer pool would run
out of uniform memory. If the pool is maxed out, we flush the
existing rendering to obtain free buffers. After the flush,
we need to re-run the setup.

Test is tracked in bug 240948.

Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm: (rx::ContextMtl::setupDraw): (rx::ContextMtl::setupDrawImpl):

Canonical link: https://commits.webkit.org/251007@main

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:06 PM Changeset in webkit [294891] by Alan Coon

5 edits in branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess

Cherry-pick r294831. rdar://problem/93656000

Prevent NSAttributedString crashes when AppSSO URLs are provided
https://bugs.webkit.org/show_bug.cgi?id=240739
<rdar://93656000>

Reviewed by Chris Dumez.

When NSAttributedString is used in a sandboxed app, it is prevented from checking in with the
AppSSO plugin manager, causing a Sandbox Violation and crash. We don't want NSAttributedString
to ever hand-off to AppSSO, so we should configure it's internal WKWebView to do the right thing.
Reviewed by Chris Dumez.

Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm: (+[_WKAttributedStringWebViewCache configuration]): Turn off AppSSO for string uses.
Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::trySOAuthorization): Use new lazy loading approach.
Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::trySOAuthorization): Ditto.
Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::soAuthorizationCoordinator): Lazily initialize, and RELEASE_ASSERT if we somehow reach this code without enabling AppSSO.
Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::soAuthorizationCoordinator): Deleted.

Canonical link: https://commits.webkit.org/250981@main

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 PM Changeset in webkit [294890] by Alan Coon

9 edits in branches/safari-7614.1.14.1-branch/Source

Versioning.

WebKit-7614.1.14.1.13

1:02 PM Changeset in webkit [294889] by Alan Coon

9 edits in branches/safari-7614.1.14.0-branch/Source

Versioning.

WebKit-7614.1.14.0.12

12:50 PM Changeset in webkit [294888] by Devin Rousso

1 edit in trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

spurious RELEASE_LOG when creating a WKWebView with an empty frame
https://bugs.webkit.org/show_bug.cgi?id=240959

Reviewed by Tim Horton.

Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]):
Don't RELEASE_LOG (or throw) unless a minimumViewportInset/maximumViewportInset has been specified.

Canonical link: https://commits.webkit.org/251015@main

12:30 PM Changeset in webkit [294887] by Adrian Perez de Castro

1 edit in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp

Crash in WebCore::TextureMapperLayer::paintSelf https://bugs.webkit.org/show_bug.cgi?id=240283

Unreviewed merge.

There are 4 cases that can happen after there has been a layerFlush and
we're adopting the new state in the composition stage:

The layer is removed from the tree and the proxy is not assigned to any other layer: the deletion of the layer causes an invalidation of the proxy and both are destroyed afterwards. This works fine.

The layer is removed from the tree and the proxy is reassigned to a new layer: the deletion of the first layer causes the invalidation of the proxy, which is then activated on the second layer. As the first layer is destroyed, we don't have to worry about dangling references from it to the proxy's currentBuffer. This works fine.

The layer is kept in the tree and the proxy gets disassociated from it and not used by any other layer: we detect that the proxy is not used anymore and call invalidate on it, but the layer keeps a reference to the proxy's currentBuffer, which has been deleted during invalidate, which leads to a crash when trying to render the layer.

The layer is kept in the tree and the proxy gets associated to a new layer: as we detect that the proxy is still being used it's not invalidated, but it gets activated on the second layer. The first layer keeps a reference to the proxy's currentBuffer, which will be destroyed a bit later when swapBuffers is called on the proxy. This leads to a crash when trying to render the first layer.

This patch addresses cases 3. and 4. described above.

Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:

(WebCore::TextureMapperPlatformLayerProxyGL::activateOnCompositingThread):
Ensure that the layer no longer keeps a reference to the current buffer if the
proxy is already active on a different layer.
(WebCore::TextureMapperPlatformLayerProxyGL::invalidate): Ensure that
the invalidated layer does not keep a reference to the current buffer.

11:41 AM Changeset in webkit [294886] by Sam Sneddon

10 edits in trunk

Remove resolution media feature dpi/dpcm unit warning
https://bugs.webkit.org/show_bug.cgi?id=240907

Reviewed by Simon Fraser.

LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt:
LayoutTests/fast/media/mq-resolution-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
Source/WebCore/css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::setMediaQueries):

Source/WebCore/css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole): Deleted.
(WebCore::reportMediaQueryWarningIfNeeded): Deleted.

Source/WebCore/css/MediaList.h:
Source/WebCore/css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::matchMedia):

Source/WebCore/css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):

Canonical link: https://commits.webkit.org/251014@main

11:30 AM Changeset in webkit [294885] by Chris Dumez

7 edits in trunk/Source

Drop unnecessary overloads now that StringView(const char*) is explicit
https://bugs.webkit.org/show_bug.cgi?id=240941

Reviewed by Darin Adler.

Source/WTF/wtf/text/AtomString.h:
Source/WTF/wtf/text/StringImpl.h:

(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

Source/WTF/wtf/text/StringView.h:
Source/WTF/wtf/text/WTFString.h:
Source/WebCore/platform/network/HTTPHeaderMap.h:
Source/WebCore/platform/network/ResourceRequestBase.h:
Source/WebCore/platform/network/ResourceResponseBase.h:

Canonical link: https://commits.webkit.org/251013@main

11:21 AM Changeset in webkit [294884] by Russell Epstein

9 edits in branches/safari-7614.1.15-branch/Source

Versioning.

WebKit-7614.1.15

11:00 AM Changeset in webkit [294883] by Russell Epstein

1 copy in branches/safari-7614.1.15-branch

New branch.

10:46 AM Changeset in webkit [294882] by Aditya Keerthi

1 edit in trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

[iOS] Update the presentation style of the photo picker
https://bugs.webkit.org/show_bug.cgi?id=240926
rdar://89670039

Reviewed by Wenson Hsieh.

The photo picker should no longer be displayed as a popover. Instead, let UIKit
decide the modal presentation style.

Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel dealloc]):
(-[WKFileUploadPanel dismiss]):
(-[WKFileUploadPanel _dismissDisplayAnimated:]):
(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):

Set the presentationController's delegate so that we are informed when the picker
is dismissed by swiping down.

(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]): Deleted.

This method was already unused.

(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]): Deleted.
(-[WKFileUploadPanel popoverControllerDidDismissPopover:]): Deleted.

Canonical link: https://commits.webkit.org/251012@main

10:25 AM Changeset in webkit [294881] by Fujii Hironori

5 edits in trunk/Source

Cannot link WebKitTestRunner in non-unified builds
https://bugs.webkit.org/show_bug.cgi?id=240755

Reviewed by Adrian Perez de Castro.

In GTK non-unified build, WebKit shared library didn't export all
WEBCORE_EXPORT marked WebCore symbols because WebCore was a static
library.

WebCore should be an SHARED or OBJECT library to work WEBCORE_EXPORT
macro as expected.

Source/WebCore/PlatformGTK.cmake:
Source/WebCore/page/gtk/DragControllerGtk.cpp:
Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/251011@main

9:56 AM Changeset in webkit [294880] by Simon Fraser

1 edit in trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

Incorrect layout on iframe with object-fit
https://bugs.webkit.org/show_bug.cgi?id=240940
<rdar://93188925>

Reviewed by Alan Bujtas.

Don't use replacedContentRect() when positioning iframe content layers, because iframes
don't (yet) respond to object-fit.

Source/WebCore/rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentsBox const):

Canonical link: https://commits.webkit.org/251010@main

9:16 AM Changeset in webkit [294879] by commit-queue@webkit.org

2 edits in trunk

[GStreamer][WebRTC] Local/remote ICE candidates stats gathering support
https://bugs.webkit.org/show_bug.cgi?id=240949

Patch by Philippe Normand <philn@igalia.com> on 2022-05-26
Reviewed by Xabier Rodriguez-Calvar.

The corresponding feature was implemented in GStreamer as part of:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1998

LayoutTests/platform/glib/TestExpectations:
Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:

(WebCore::iceCandidateType):
(WebCore::fillRTCCandidateStats):
(WebCore::fillRTCCandidatePairStats):
(WebCore::fillReportCallback):

Canonical link: https://commits.webkit.org/251009@main

9:01 AM Changeset in webkit [294878] by Andres Gonzalez

10 edits
2 adds in trunk

AX: Refactor implementation of AX object relationships.
https://bugs.webkit.org/show_bug.cgi?id=240842

Reviewed by Chris Fleizach and Tyler Wilcock.

Test: accessibility/grid-with-aria-owned-cells.html

Relationships between AX objects were being computed by the methods
AccessibilityObject::ariaElementsFromAttribute and
ariaElementsReferencedByAttribute, both of which performed walks of the DOM tree
to match ids between origin and target of a specific relationship, having a
significant performance impact when called repeatedly.
With this patch, these two methods are replaced with a single method,
AccessibilityObject::relatedObjects, that in turn calls
AXObjectCache::relatedObjectsFor. This AXObjectCache method computes and caches
all relationships in one walk of the DoM tree. The cache is updated when
relevant event notifications are received. This makes support of relationships between objects more efficient, and the code clearer.
The test added exercises this implementation of relationships via the aria-owns
attribute to relate table rows to their cells. The execution time of this test
before this change was estimated in one system at about 1.91s, and after the
change was reduced to 1.87s.

Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::objectsForIDs const):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::relationAttributes):
(WebCore::AXObjectCache::symmetricRelation):
(WebCore::AXObjectCache::attributeToRelationType):
(WebCore::AXObjectCache::addRelation):
(WebCore::AXObjectCache::updateRelationsIfNeeded):
(WebCore::AXObjectCache::relatedObjectsFor):

Source/WebCore/accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::relationsNeedUpdate):

Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::relatedObjects const):
(WebCore::AccessibilityObject::activeDescendantOfObjects const):
(WebCore::AccessibilityObject::controlledObjects const):
(WebCore::AccessibilityObject::controllers const):
(WebCore::AccessibilityObject::describedByObjects const):
(WebCore::AccessibilityObject::descriptionForObjects const):
(WebCore::AccessibilityObject::detailedByObjects const):
(WebCore::AccessibilityObject::detailsForObjects const):
(WebCore::AccessibilityObject::errorMessageObjects const):
(WebCore::AccessibilityObject::errorMessageForObjects const):
(WebCore::AccessibilityObject::flowToObjects const):
(WebCore::AccessibilityObject::flowFromObjects const):
(WebCore::AccessibilityObject::labelledByObjects const):
(WebCore::AccessibilityObject::labelForObjects const):
(WebCore::AccessibilityObject::ownedObjects const):
(WebCore::AccessibilityObject::owners const):
(WebCore::AccessibilityObject::ariaElementsFromAttribute const): Deleted.
(WebCore::AccessibilityObject::ariaElementsReferencedByAttribute const): Deleted.

Source/WebCore/accessibility/AccessibilityObject.h:
Source/WebCore/accessibility/AccessibilityObjectInterface.h:

(WebCore::Accessibility::findRelatedObjectInAncestry):

Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::activeDescendant const):

Source/WebCore/accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnHeaders):

Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::relationMap const):

Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):

LayoutTests/accessibility/grid-with-aria-owned-cells-expected.txt: Added.
LayoutTests/accessibility/grid-with-aria-owned-cells.html: Added.

Canonical link: https://commits.webkit.org/251008@main

7:00 AM Changeset in webkit [294877] by commit-queue@webkit.org

1 edit in trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm

Uniform buffer reuse causes flush, creates invalid state
https://bugs.webkit.org/show_bug.cgi?id=240896

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-26
Patch by Kyle Piddington.

Reviewed by Kimmo Kinnunen.

A flush during draw setup would leave the render command encoder
not started and render pipeline unset. This would assert in debug
and leak memory with corrupted draws in release.

This would happen for example when uniform buffer pool would run
out of uniform memory. If the pool is maxed out, we flush the
existing rendering to obtain free buffers. After the flush,
we need to re-run the setup.

Test is tracked in bug 240948.

Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:

(rx::ContextMtl::setupDraw):
(rx::ContextMtl::setupDrawImpl):

Canonical link: https://commits.webkit.org/251007@main

5:13 AM Changeset in webkit [294876] by ntim@apple.com

1 delete in trunk/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle

[Windows] Remove obsolete css3-text-decoration test results
https://bugs.webkit.org/show_bug.cgi?id=240951

Unreviewed test gardening.

LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed.
LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed.

Canonical link: https://commits.webkit.org/251006@main

4:40 AM Changeset in webkit [294875] by Tyler Wilcock

9 edits
4 adds in trunk

AccessibilityTable::m_isExposable is never recomputed after AccessibilityTable::init
https://bugs.webkit.org/show_bug.cgi?id=240750

Reviewed by Andres Gonzalez.

AccessibilityTable::m_isExposable is never recomputed after
AccessibilityTable::init. This is bad because the semantics of table,
and the semantics of the table cells in the table, are dependent on
whether the table is exposed.

With this commit, we recompute m_isExposable when a table's row count
changes. This commit also updates the isolated tree for row count
changes, meaning we handle dynamic aria-rowcount value modifications.

Test: accessibility/table-exposure-updates-dynamically.html.
Also added another testcase to accessibility/aria-table-attributes.html.

LayoutTests/accessibility/aria-table-attributes-expected.txt:
LayoutTests/accessibility/aria-table-attributes.html: Add testcase.
LayoutTests/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
LayoutTests/accessibility/table-exposure-updates-dynamically.html: Added.
LayoutTests/platform/glib/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
LayoutTests/platform/ios/TestExpectations: Enable new test.
LayoutTests/platform/ios/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
LayoutTests/platform/win/TestExpectations: Disable new test.
Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleRowCountChanged): Added.
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::filterWeakHashSetForRemoval):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::updateIsolatedTree):

Source/WebCore/accessibility/AXObjectCache.h:
Source/WebCore/accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::recomputeIsExposable): Added.
(WebCore::AccessibilityTable::updateChildrenRoles): Added.
(WebCore::AccessibilityTable::addChildren):

Source/WebCore/accessibility/AccessibilityTable.h:
Source/WebCore/html/HTMLTablePartElement.h:

Moved findParentTable from protected to public so it can be called from
accessibility code.

Canonical link: https://commits.webkit.org/251005@main

4:05 AM Changeset in webkit [294874] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp

[GStreamear] DMABufVideoSink can already handle Y41B
https://bugs.webkit.org/show_bug.cgi?id=240946

Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-26
Reviewed by Philippe Normand.

In GStreamer-specific DMABufVideoSink, Y41B multi-planar format was listed as
problematic and not included in the list of formats that are supported by
default. In reality, it's handled properly already and works, so it's moved over
to the list of supported formats.

Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:

Canonical link: https://commits.webkit.org/251004@main

1:13 AM Changeset in webkit [294873] by ysuzuki@apple.com

41 edits in trunk

[JSC] Introduce unlinked StructureStubInfo into uDFG
https://bugs.webkit.org/show_bug.cgi?id=240557

Reviewed by Saam Barati.

This patch introduces unlinked StructureStubInfo into uDFG. To make it work, we refactor existing StructureStubInfo mechanism
to make unlinked StructureStubInfo first citizen instead of adhoc code.

JITXXXGenerator takes CompileTimeStructureStubInfo as its argument. It is variant of unlinked / linked StructureStubInfo. And we configure registers etc. in one place. JITXXXGenerator sets necessary fields for each type of StructureStubInfo so we have massive less code in Baseline and uDFG.
DFG::JITCompiler::LinkableConstant takes DFG::JITCompiler instead of DFG::Graph to make code simpler.
Introduce DFG::LinkerIR, which is currently just a constant pool. We will eventually extend it to support many uDFG LinkerIR opcodes.
Clean up some of unused registers in some JITXXXGenerator to make code simpler.
Rename useDataICInOptimizingJIT to useDataICInFTL and use it only for FTL. That flag was used to keep maintaining DataIC in DFG / FTL, and in uDFG case, we already have forceUnlinkedDFG flag.

Tools/Scripts/run-jsc-stress-tests:
JSTests/microbenchmarks/deltablue-varargs.js:
JSTests/microbenchmarks/richards-try-catch.js:
Source/JavaScriptCore/bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):
(JSC::AccessCase::generateImpl):

Source/JavaScriptCore/bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeJITInlineCaches):
(JSC::CodeBlock::getICStatusMap):
(JSC::CodeBlock::findStubInfo):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::findPC):
(JSC::CodeBlock::useDataIC const):

Source/JavaScriptCore/bytecode/CodeBlock.h:

(JSC::CodeBlock::useDataIC const): Deleted.

Source/JavaScriptCore/bytecode/InlineAccess.cpp:

(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::generateStringLength):
(JSC::InlineAccess::generateSelfInAccess):

Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::makeDefaultScratchAllocator):
(JSC::PolymorphicAccess::regenerate):

Source/JavaScriptCore/bytecode/PolymorphicAccess.h:

(JSC::AccessGenerationState::AccessGenerationState):

Source/JavaScriptCore/bytecode/StructureStubInfo.cpp:

(JSC::slowOperationFromUnlinkedStructureStubInfo):
(JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo):
(JSC::StructureStubInfo::initializeFromDFGUnlinkedStructureStubInfo):
(JSC::StructureStubInfo::checkConsistency):

Source/JavaScriptCore/bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::valueRegs const):
(JSC::StructureStubInfo::propertyRegs const):
(JSC::StructureStubInfo::baseRegs const):
(JSC::StructureStubInfo::thisValueIsInExtraGPR const):
(JSC::StructureStubInfo::thisGPR const):
(JSC::StructureStubInfo::prototypeGPR const):
(JSC::StructureStubInfo::propertyGPR const):
(JSC::StructureStubInfo::brandGPR const):
(JSC::StructureStubInfo::thisValueIsInThisGPR const): Deleted.

Source/JavaScriptCore/dfg/DFGInlineCacheWrapperInlines.h:

(JSC::DFG::InlineCacheWrapper<GeneratorType>::finalize):

Source/JavaScriptCore/dfg/DFGJITCode.cpp:

(JSC::DFG::JITData::JITData):

Source/JavaScriptCore/dfg/DFGJITCode.h:

(JSC::DFG::LinkerIR::ValueHash::hash):
(JSC::DFG::LinkerIR::ValueHash::equal):
(JSC::DFG::LinkerIR::ValueTraits::emptyValue):
(JSC::DFG::LinkerIR::ValueTraits::constructDeletedValue):
(JSC::DFG::LinkerIR::ValueTraits::isDeletedValue):
(JSC::DFG::LinkerIR::LinkerIR):
(JSC::DFG::LinkerIR::size const):
(JSC::DFG::LinkerIR::at const):
(JSC::DFG::JITData::create):

Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::loadConstant):
(JSC::DFG::JITCompiler::LinkableConstant::LinkableConstant):
(JSC::DFG::JITCompiler::addToConstantPool):
(JSC::DFG::JITCompiler::addStructureStubInfo):

Source/JavaScriptCore/dfg/DFGJITCompiler.h:
Source/JavaScriptCore/dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalizeJITData):
(JSC::DFG::Plan::addLinkableConstant): Deleted.

Source/JavaScriptCore/dfg/DFGPlan.h:
Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:

(JSC::DFG::slowPathICCall):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitGetCallee):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compileGetById):
(JSC::DFG::SpeculativeJIT::compileGetByIdFlush):
(JSC::DFG::SpeculativeJIT::compileDeleteById):
(JSC::DFG::SpeculativeJIT::compileDeleteByVal):
(JSC::DFG::SpeculativeJIT::compileInById):
(JSC::DFG::SpeculativeJIT::compileInByVal):
(JSC::DFG::SpeculativeJIT::compileHasPrivate):
(JSC::DFG::SpeculativeJIT::compilePushWithScope):
(JSC::DFG::SpeculativeJIT::compileStringSlice):
(JSC::DFG::SpeculativeJIT::compileToLowerCase):
(JSC::DFG::SpeculativeJIT::compileCheckTraps):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compilePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::genericJSValueNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::genericJSValueNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitUntypedBranch):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compileRegExpTestInline):
(JSC::DFG::SpeculativeJIT::compile):

Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::getPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::compilePrivateBrandAccess):
(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::cachedPutById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValImpl):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Source/JavaScriptCore/ftl/FTLState.cpp:

(JSC::FTL::State::addStructureStubInfo):

Source/JavaScriptCore/ftl/FTLState.h:
Source/JavaScriptCore/jit/BaselineJITCode.h:
Source/JavaScriptCore/jit/BaselineJITRegisters.h:
Source/JavaScriptCore/jit/GPRInfo.h:

(JSC::JSValueRegs::gpr const):
(JSC::JSValueRegs::JSValueRegs):
(JSC::JSValueRegs::withTwoAvailableRegs):

Source/JavaScriptCore/jit/IntrinsicEmitter.cpp:

(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):

Source/JavaScriptCore/jit/JIT.cpp:

(JSC::JIT::addUnlinkedStructureStubInfo):
(JSC::JIT::link):

Source/JavaScriptCore/jit/JIT.h:
Source/JavaScriptCore/jit/JITCall.cpp:

(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):

Source/JavaScriptCore/jit/JITCode.h:

(JSC::JITCode::useDataIC): Deleted.

Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITInlineCacheGenerator::finalize):
(JSC::JITInlineCacheGenerator::generateDFGDataICFastPath):
(JSC::JITInlineCacheGenerator::generateBaselineDataICFastPath):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastCommon):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITGetByIdGenerator::generateBaselineDataICFastPath):
(JSC::JITGetByIdGenerator::generateDFGDataICFastPath):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITGetByIdWithThisGenerator::generateFastPath):
(JSC::JITGetByIdWithThisGenerator::generateBaselineDataICFastPath):
(JSC::JITGetByIdWithThisGenerator::generateDFGDataICFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateBaselineDataICFastPath):
(JSC::JITPutByIdGenerator::generateDFGDataICFastPath):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITDelByValGenerator::JITDelByValGenerator):
(JSC::JITDelByValGenerator::generateFastPath):
(JSC::JITDelByValGenerator::finalize):
(JSC::JITDelByIdGenerator::JITDelByIdGenerator):
(JSC::JITDelByIdGenerator::generateFastPath):
(JSC::JITDelByIdGenerator::finalize):
(JSC::JITInByValGenerator::JITInByValGenerator):
(JSC::JITInByValGenerator::generateFastPath):
(JSC::JITInByValGenerator::finalize):
(JSC::JITInByIdGenerator::JITInByIdGenerator):
(JSC::JITInByIdGenerator::generateFastPath):
(JSC::JITInByIdGenerator::generateBaselineDataICFastPath):
(JSC::JITInByIdGenerator::generateDFGDataICFastPath):
(JSC::JITInstanceOfGenerator::JITInstanceOfGenerator):
(JSC::JITInstanceOfGenerator::generateFastPath):
(JSC::JITInstanceOfGenerator::finalize):
(JSC::JITGetByValGenerator::JITGetByValGenerator):
(JSC::JITGetByValGenerator::generateFastPath):
(JSC::JITGetByValGenerator::finalize):
(JSC::JITPutByValGenerator::JITPutByValGenerator):
(JSC::JITPutByValGenerator::generateFastPath):
(JSC::JITPutByValGenerator::finalize):
(JSC::JITPrivateBrandAccessGenerator::JITPrivateBrandAccessGenerator):
(JSC::JITPrivateBrandAccessGenerator::generateFastPath):
(JSC::JITPrivateBrandAccessGenerator::finalize):

Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:

(JSC::JITInlineCacheGenerator::setUpStubInfoImpl):
(JSC::JITByIdGenerator::setUpStubInfoImpl):
(JSC::JITInByValGenerator::setUpStubInfo):

Source/JavaScriptCore/jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):

Source/JavaScriptCore/jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_private_name):
(JSC::JIT::emit_op_set_private_brand):
(JSC::JIT::emit_op_check_private_brand):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitHasPrivate):
(JSC::JIT::emit_op_enumerator_get_by_val):

Source/JavaScriptCore/runtime/OptionsList.h:
Source/WTF/wtf/CompactPointerTuple.h:

Canonical link: https://commits.webkit.org/251003@main

May 25, 2022:

11:58 PM Changeset in webkit [294872] by commit-queue@webkit.org

1 edit in trunk/Tools/Scripts/update-angle

Generate better ChangeLogs in update-angle script
https://bugs.webkit.org/show_bug.cgi?id=238649

Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-25
Auto-generate the preferred commit message format during ANGLE rolls
into a commit-message.txt file.

Reviewed by Kimmo Kinnunen.

Tools/Scripts/update-angle:

Canonical link: https://commits.webkit.org/251002@main

11:08 PM Changeset in webkit [294871] by commit-queue@webkit.org

1 edit in trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp

[Soup] USE(SOUP2) build fix after 250730@main
https://bugs.webkit.org/show_bug.cgi?id=240943

Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-25
Unreviewed build fix for USE(SOUP2), switching to string literals in a couple of
places where URL::protocolIs() is expecting them.

Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback):
(WebKit::NetworkDataTaskSoup::didStartRequest):

Canonical link: https://commits.webkit.org/251001@main

10:36 PM Changeset in webkit [294870] by Diego Pino Garcia

5 edits in trunk/Source

Unreviewed, non unified build fixes after 250949@main

10:21 PM Changeset in webkit [294869] by Jonathan Bedard

4 edits in trunk/Tools/Scripts/libraries/reporelaypy

[commits.webkit.org] Support compare redirect
https://bugs.webkit.org/show_bug.cgi?id=240908
<rdar://problem/93904385>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py:

(Redirector):
(Redirector.bitbucket_compare): Added.
(Redirector.trac_compare): Added.
(Redirector.github_compare): Added.
(Redirector.init): Define a compare function.
(CheckoutRoute):
(CheckoutRoute.find_newer): Add function to sort a commit pair.
(CheckoutRoute.init): Add 'compare' endpoints.

Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:

(CheckoutRouteUnittest.test_compare):
(CheckoutRouteUnittest.test_compare_trac):

Canonical link: https://commits.webkit.org/250999@main

9:09 PM Changeset in webkit [294868] by Brandon

2 edits in trunk/LayoutTests

Address flaky test case scroll-into-view-and-show-validation-message.html when run using WK1
https://bugs.webkit.org/show_bug.cgi?id=240875

Reviewed by Wenson Hsieh.

Address failing test case fast/forms/scroll-into-view-and-show-validation-message.html
when run using WK1. This test only fails when running WK1 and only when run
in parallel.

LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/250998@main

8:49 PM Changeset in webkit [294867] by bshafiei@apple.com

1 copy in tags/WebKit-7614.1.14.1.12

Tag WebKit-7614.1.14.1.12.

8:46 PM Changeset in webkit [294866] by Brandon

21 edits in trunk/Source/bmalloc/libpas

[libpas] Refactor PGM to align with libpas allocation norms and split pas_get_random
https://bugs.webkit.org/show_bug.cgi?id=240331

Reviewed by Yusuke Suzuki.

This patch touches a few major areas.

PGM did not properly align with how we returned allocation results with the rest of the code base.
We now use pas_allocation_result instead. This resulted in touching a lot of the PGM testing code.

Added numerous helper utilities to make it easier to check whether we should call into PGM.

Added config option for each heap whether PGM will be enabled or not.

Cleaned up documentation.

I split the pas_get_random into two functions (pas_get_fast_random and pas_get_secure_random).

Source/bmalloc/libpas/Documentation.md:
Source/bmalloc/libpas/ReadMe.md:
Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h:
Source/bmalloc/libpas/src/libpas/hotbit_heap_config.h:
Source/bmalloc/libpas/src/libpas/iso_heap_config.h:
Source/bmalloc/libpas/src/libpas/iso_test_heap_config.h:
Source/bmalloc/libpas/src/libpas/minalign32_heap_config.h:
Source/bmalloc/libpas/src/libpas/pagesize64k_heap_config.h:
Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c:

(pas_baseline_allocator_table_get_random_index):

Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c:

(pas_dynamic_primitive_heap_map_find_slow):

Source/bmalloc/libpas/src/libpas/pas_heap_config.h:
Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h:
Source/bmalloc/libpas/src/libpas/pas_large_heap.c:

(pas_large_heap_try_allocate_pgm):

Source/bmalloc/libpas/src/libpas/pas_large_heap.h:
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:

(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_deallocate):
(pas_probabilistic_guard_malloc_check_exists):
(pas_probabilistic_guard_malloc_get_free_virtual_memory):
(pas_probabilistic_guard_malloc_get_free_wasted_memory):
(pas_probabilistic_guard_malloc_debug_info):
(pas_probabilistic_guard_malloc_trigger): Deleted.
(pas_probabilistic_guard_malloc_can_use): Deleted.
(pas_probabilistic_guard_malloc_should_use): Deleted.

Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
Source/bmalloc/libpas/src/libpas/pas_random.h:

(pas_get_fast_random):
(pas_get_secure_random):
(pas_get_random): Deleted.

Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c:

(find_first_eligible_consider_view):

Source/bmalloc/libpas/src/libpas/thingy_heap_config.h:
Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp:
Source/bmalloc/libpas/src/test/PGMTests.cpp:

(std::testPGMSingleAlloc):
(std::testPGMMultipleAlloc):
(std::testPGMErrors):

Canonical link: https://commits.webkit.org/250997@main

8:39 PM Changeset in webkit [294865] by bshafiei@apple.com

9 edits in branches/safari-7614.1.14.1-branch/Source

Versioning.

WebKit-7614.1.14.1.12

8:15 PM Changeset in webkit [294864] by commit-queue@webkit.org

5 edits
2 adds in trunk

Capturing a canvas that is not in the DOM can lead to erratic frame rates or no frame emission at all
https://bugs.webkit.org/show_bug.cgi?id=240380

Patch by Dan Glastonbury <djg@apple.com> on 2022-05-25
Reviewed by Simon Fraser.

Source/WebCore/dom/Document.cpp:

(WebCore::Document::canvasChanged):
Schedule a rendering update whenever a canvas with out a rect needing display
preparation is added. This ensures that the prepareForDisplay is called on all
pending canvases, since this is handled in doAfterUpdateRendering.

Source/WebCore/dom/Document.h:

Update size of RenderingUpdateState to accomodate PrepareCanvasesForDisplay.

Source/WebCore/page/Page.cpp:
Source/WebCore/page/Page.h:

Introduce new RenderingUpdateStep, PrepareCanvasesForDisplay, which signals that
prepareCanvasesForDisplayInNeeded() needs to be called from
doAfterRenderingUpdate(). Update size of RenderingUpdateState to accomodate
PrepareCanvasesForDisplay.

LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-expected.txt: Added.
LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas.html:

Test that frame rate of captured video from out-of-DOM canvas is with in 25% of
the generating frame rate.

Canonical link: https://commits.webkit.org/250996@main

7:56 PM Changeset in webkit [294863] by Tyler Wilcock

8 edits in trunk

AX: Update the isolated tree in response to dynamic aria-grabbed and aria-posinset changes
https://bugs.webkit.org/show_bug.cgi?id=240844

Reviewed by Chris Fleizach.

Added test cases to accessibility/aria-setsize-posinset.html and
accessibility/mac/aria-drag-drop.html.

Source/WebCore/accessibility/AXLogger.cpp:

(WebCore::operator<<):

Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):

Source/WebCore/accessibility/AXObjectCache.h:
Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNodeProperty):

LayoutTests/accessibility/aria-setsize-posinset-expected.txt:
LayoutTests/accessibility/aria-setsize-posinset.html:
LayoutTests/accessibility/mac/aria-drag-drop-expected.txt:
LayoutTests/accessibility/mac/aria-drag-drop.html:

Canonical link: https://commits.webkit.org/250995@main

7:16 PM Changeset in webkit [294862] by Devin Rousso

13 edits in trunk

Web Inspector: CSS autocomplete: suggestion hint should be the most commonly used property and not the alphabetically first one
https://bugs.webkit.org/show_bug.cgi?id=156271
<rdar://problem/25588888>

Reviewed by Patrick Angle.

Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:

(WI.CSSProperty):
(WI.CSSProperty.sortByPropertyNameUsageCount): Added.
(WI.CSSProperty._initializePropertyNameCounts): Added.
(WI.CSSProperty.prototype.update):
(WI.CSSProperty.prototype.remove):
(WI.CSSProperty.prototype.set name):
(WI.CSSProperty.prototype._updateName): Added.
Every time a WI.CSSProperty is created/updated, increment/decrement the count of that property's
name in the global map of property name counts. When showing CSS completions for property names,
initially focus the property with the highest count (but only if the count is over 100).

Source/WebInspectorUI/UserInterface/Base/ObjectStore.js:

(WI.ObjectStore._open):
(WI.ObjectStore.async getAllKeys): Added.
Increment the version to add a new WI.ObjectStore for CSS property name counts.

Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldInitialCompletionIndex): Added.

Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._updateCompletions):
Add delegate methods to adjust the initial selectedIndex whenever completions are updated.

Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:

(WI.CompletionSuggestionsView.prototype.set selectedIndex):
(WI.CompletionSuggestionsView.prototype.selectNext):
(WI.CompletionSuggestionsView.prototype.selectPrevious):
Make sure the delegate is informed whenever the selectedIndex changes, not just when selecting
the next/previous item.

Source/WebInspectorUI/UserInterface/Base/Setting.js:
Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:

Add an experimental setting to control this behavior.

Source/WebInspectorUI/UserInterface/Base/Utilities.js:

(Array.prototype.minIndex): Added.
Add a utility method for finding the index of the smallest item in an array.

LayoutTests/inspector/css/css-property.html:
LayoutTests/inspector/css/css-property-expected.txt:
LayoutTests/inspector/unit-tests/array-utilities.html:
LayoutTests/inspector/unit-tests/array-utilities-expected.txt:

Canonical link: https://commits.webkit.org/250994@main

6:56 PM Changeset in webkit [294861] by mark.lam@apple.com

1 edit in trunk/Source/WTF/wtf/CheckedArithmetic.h

Build fix: Don't use builtin_mul_overflow on PLATFORM(IOS_FAMILY_SIMULATOR).
https://bugs.webkit.org/show_bug.cgi?id=240937

Reviewed by Saam Barati and Alex Christensen.

The mulodi4 symbol used by clang for builtin_mul_overflow is not available.

Source/WTF/wtf/CheckedArithmetic.h:

Canonical link: https://commits.webkit.org/250993@main

6:52 PM Changeset in webkit [294860] by sihui_liu@apple.com

1 edit in trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

REGRESSION(r294381): [ Debug ] TestWebKitAPI.WebKit.CookieObserverCrash is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=240595

Reviewed by Alex Christensen.

The crash is an assertion failure. The assertion ensures that WebCookieManagerProxy has no cookies observer when it gets
destroyed. The assertion was valid when it was added, since WKHTTPCookieStore does not outlive WebKit::WebsiteDataStore
(r219550), and observers will be removed when WKHTTPCookieStore is deallocated. Since r279074, WKHTTPCookieStore can
outlive WebKit::WebsiteDataStore -- it holds a weak reference to WebKit::WebsiteDataStore instead of a strong reference,
so the assertion does not hold.

Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):

Canonical link: https://commits.webkit.org/250992@main

6:48 PM Changeset in webkit [294859] by Chris Dumez

1 edit in trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp

Unreviewed Windows build fix after r294852
https://bugs.webkit.org/show_bug.cgi?id=240936

Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::copyCookiesForURLWithFirstPartyURL):

Canonical link: https://commits.webkit.org/250991@main

6:36 PM Changeset in webkit [294858] by achristensen@apple.com

1 edit in trunk/Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm

Stop searching for WebKitLegacy plug-ins on iOS
https://bugs.webkit.org/show_bug.cgi?id=240923
<rdar://92748471>

Reviewed by Chris Dumez.

NPAPI plug-in support has been completely removed, but support for plugInViewWithArguments:
is being kept on macOS until one more internal user of it finishes migration to WKWebView
even though developer.apple.com says it is "unsupported in OS X v10.7 and later"

On iOS, though, there is a concern about the API we are using to get the path to
/System/Library/Internet Plug-Ins and since it is unused, let's just remove it for now.
Soon we will remove all the plug-in support code.

Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm:

(+[WebPluginDatabase _defaultPlugInPaths]):

Canonical link: https://commits.webkit.org/250990@main

6:21 PM Changeset in webkit [294857] by Alan Coon

1 copy in tags/WebKit-7614.1.14.1.11

Tag WebKit-7614.1.14.1.11.

6:20 PM Changeset in webkit [294856] by Alan Coon

1 copy in tags/WebKit-7614.1.14.0.11

Tag WebKit-7614.1.14.0.11.

6:16 PM Changeset in webkit [294855] by david_quesada@apple.com

26 edits in trunk/Source

USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH should be able to coexist
https://bugs.webkit.org/show_bug.cgi?id=240723
rdar://92000421

Reviewed by Michael Saboff.

Make it possible to build with both USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH
enabled. With USE_STAGING_INSTALL_PATH, all the frameworks and dylibs will be relocated
to a common "StagedFrameworks" directory, but USE_SYSTEM_CONTENT_PATH directs the build
to locate this directory at a different location, i.e. in a system content path. The
presence of USE_STAGING_INSTALL_PATH also disables all targets' current behavior of
creating symlinks into the system content path -- in this configuration, the frameworks
only need to be referenceable from their location in the StagedFrameworks directory.

Throughout this patch, there are multiple common changes to the same build settings:

INSTALL_PATH_PREFIX:

This variable adds the system content path as a prefix to products' install paths.
Leave it empty when USE_STAGING_INSTALL_PATH is set, as the effective prefix will
be baked into WK_OVERRIDE_FRAMEWORKS_DIR via WK_INSTALL_PATH_PREFIX instead.

OUTPUT_ALTERNATE_ROOT_PATH:

Define this as empty under USE_STAGING_INSTALL_PATH, since we don't need to create
the symlinks pointing into the system content path.

WK_INSTALL_PATH_PREFIX:

This variable is used to define a prefix for the override install path when using
staged frameworks. Use a different prefix under USE_SYSTEM_CONTENT_PATH. Also
remove a now-unneeded comparison against WK_MACOS_1015. WebKit doesn't support
building for versions of macOS prior to 10.15, so this *always* would evaluate to
'MACOS_SINCE_1015'.

No new tests; no behavior should be changed. (Except for output of this particular
build configuration.)

Source/JavaScriptCore/Configurations/Base.xcconfig:

Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX.

Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:

Update OUTPUT_ALTERNATE_ROOT_PATH.

Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:

Update INSTALL_PATH_PREFIX.

Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:

Update WK_INSTALL_PATH_PREFIX.

Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:

Moved the common definition of INSTALL_PATH_PREFIX here, updated WK_INSTALL_PATH_PREFIX.

Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:

Removed definition of INSTALL_PATH_PREFIX, which has been moved to Base.xcconfig. (x9)

Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:

Avoid creating any symlinks when USE_STAGING_INSTALL_PATH is set.

Source/WebCore/Configurations/WebCore.xcconfig:

Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX.

Source/WebCore/PAL/Configurations/PAL.xcconfig:

Update WK_INSTALL_PATH_PREFIX.

Source/WebGPU/Configurations/WebGPU.xcconfig:

Update INSTALL_PATH_PREFIX, OUTPUT_ALTERNATE_ROOT_PATH, and WK_INSTALL_PATH_PREFIX.

Source/WebInspectorUI/Configurations/Base.xcconfig:

Update WK_INSTALL_PATH_PREFIX.

Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig:

Modify the definition of INSTALL_PATH so that the "override-ness" of
WK_USE_OVERRIDE_FRAMEWORKS_DIR takes precedence over USE_SYSTEM_CONTENT_PATH. With
these two set, WebInspectorUI.framework should end up in the override path (e.g. the
StagedFrameworks directory), rather than the standard system content path location.
Also update OUTPUT_ALTERNATE_ROOT_PATH.

Source/WebKit/Configurations/Base.xcconfig:

Update INSTALL_PATH_PREFIX.

Source/WebKit/Configurations/BaseTarget.xcconfig:

Update WK_INSTALL_PATH_PREFIX.

Source/WebKit/Configurations/WebKit.xcconfig:

Update OUTPUT_ALTERNATE_ROOT_PATH.

Source/WebKit/Configurations/adattributiond.xcconfig:

Somewhat unrelated tweak -- remove WK_OVERRIDE_FRAMEWORKS_DIR from this file since
it is redundant with the definition of this setting in BaseTarget.xcconfig.

Source/WebKitLegacy/mac/Configurations/Base.xcconfig:

Update INSTALL_PATH_PREFIX.

Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:

Update WK_INSTALL_PATH_PREFIX.

Canonical link: https://commits.webkit.org/250989@main

5:47 PM Changeset in webkit [294854] by jer.noble@apple.com

5 edits
5 adds in trunk

Sequential WebVTT cues with the same contents can be dropped
https://bugs.webkit.org/show_bug.cgi?id=240893

Reviewed by Eric Carlson.

When sequential WebVTT cues are parsed with the same contents, instead of dropping the new cue, extend its endTime of the existing cue to include the endTime of the newly parsed one.

LayoutTests/http/tests/media/hls/hls-webvtt-flashing-expected.txt: Added.
LayoutTests/http/tests/media/hls/hls-webvtt-flashing.html: Added.
LayoutTests/http/tests/media/resources/hls/subtitles/flashSequence0.webvtt: Added.
LayoutTests/http/tests/media/resources/hls/subtitles/prog_flashing.m3u8: Added.
LayoutTests/http/tests/media/resources/hls/test-webvtt-flashing.m3u8: Added.
LayoutTests/platform/glib/TestExpectations:
Source/WebCore/html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::newCuesParsed):

Source/WebCore/html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed):

Source/WebCore/html/track/TextTrack.cpp:

(WebCore::TextTrack::matchCue):
(WebCore::TextTrack::hasCue): Deleted.

Source/WebCore/html/track/TextTrack.h:

(WebCore::TextTrack::hasCue):

Canonical link: https://commits.webkit.org/250988@main

5:23 PM Changeset in webkit [294853] by david_quesada@apple.com

1 edit in trunk/metadata/contributors.json

Add my GitHub account to contributors.json

Reviewed by Jonathan Bedard.

metadata/contributors.json:

Canonical link: https://commits.webkit.org/250987@main

5:13 PM Changeset in webkit [294852] by Chris Dumez

159 edits in trunk

Make the StringView(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=240754

Reviewed by Darin Adler.

Make the StringView(const char*) constructor explicit, to encourage people to use
ASCIILiteral / ""_s. StringView::fromLatin1() is available when the caller
really has a non-string literal. In a future patch, I will make this constructor
private.

Source/WTF/wtf/Assertions.cpp:
Source/WTF/wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):

Source/WTF/wtf/text/StringView.h:
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:

(WebCore::toRtpCodecCapability):

Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:

(WebCore::ComputedStylePropertyMapReadOnly::entries const):

Source/WebCore/dom/DatasetDOMStringMap.cpp:

(WebCore::isValidAttributeName):
(WebCore::propertyNameMatchesAttributeName):

Source/WebCore/dom/ViewportArguments.cpp:

(WebCore::viewportErrorMessage):

Source/WebCore/editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::elementHasOwnBackgroundColor):

Source/WebCore/history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

Source/WebCore/html/URLDecomposition.cpp:

(WebCore::URLDecomposition::setPort):

Source/WebCore/html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::checkAndCreateRegion):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):

Source/WebCore/loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::parseAttributionRequest):
(WebCore::PrivateClickMeasurement::appStoreURLAdamID):

Source/WebCore/loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):

Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::getUnmangledInfoLog):

Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):

Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::migrateDataToPCMDatabaseIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::aggregatedThirdPartyData const):

Source/WebKit/NetworkProcess/NetworkSchemeRegistry.cpp:

(WebKit::NetworkSchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):

Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):

Source/WebKit/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::blobPathForHash const):

Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
Source/WebKit/Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::removeValuesEndingWith):

Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:

(WebKit::XPCEndpoint::XPCEndpoint):

Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getProcessIdentifier):

Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:

(API::constructedPathPrefix):

Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:
Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]):
(-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]):

Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded):
(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):

Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):

Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::deleteHashSaltFromDisk):

Source/WebKit/UIProcess/ViewGestureController.cpp:

(WebKit::ViewGestureController::SnapshotRemovalTracker::resume):
(WebKit::ViewGestureController::SnapshotRemovalTracker::start):
(WebKit::ViewGestureController::SnapshotRemovalTracker::fireRemovalCallbackImmediately):
(WebKit::ViewGestureController::SnapshotRemovalTracker::watchdogTimerFired):

Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

Source/WebKit/UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):

Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):

Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::shouldAllowNonValidInjectedCode const):

Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetDatabaseQuota):

Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::tryLoadingUsingPDFJSHandler):

Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::streamDidReceiveResponse):

Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::dumpHistoryItem):

Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldUsePDFPlugin const):
(WebKit::WebPage::platformCanHandleRequest):

Source/WebKit/webpushd/AppBundleRequest.mm:

(WebPushD::AppBundleRequest::start):

Source/WebKit/webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::connectionClosed):

Source/WebKit/webpushd/WebPushDaemon.mm:

(WebPushD::Daemon::broadcastAllConnectionIdentities):
(WebPushD::Daemon::injectPushMessageForTesting):
(WebPushD::Daemon::injectEncryptedPushMessageForTesting):

Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:

(regExpForLabels):
(matchLabelsAgainstString):

Tools/DumpRenderTree/mac/DumpRenderTree.mm:

(changeWindowScaleIfNeeded):

Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WTF/SortedArrayMap.cpp:

(TEST):

Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::doStaticStringImplTests):

Tools/TestWebKitAPI/Tests/WTF/StringToIntegerConversion.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/URL.cpp:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::invalidParts):
(TestWebKitAPI::shouldFail):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::testUserPassword):

Tools/TestWebKitAPI/Tests/WTF/UUID.cpp:

(TEST):

Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WebCore/DFAHelpers.h:

(TestWebKitAPI::buildDFAFromPatterns):

Tools/TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::readContentsOfFile):

Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:

(TestWebKitAPI::testStrip):
(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/FTP.mm:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:

(TEST):
(runMultipleIndicesTestWithDatabase):

Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::parseUserAgent):

Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:

(TestWebKitAPI::TEST_F):

Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:

(addAttributedPCMv2):
(addUnattributedPCMv2):
(addAttributedPCMv3):
(addUnattributedPCMv3):
(addUnattributedPCMv4):
(addAttributedPCMv4):
(addAttributedPCMv5):
(createAndPopulateObservedDomainTable):
(createAndPopulatePCMObservedDomainTable):

Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[ServiceWorkerSchemeHandler webView:startURLSchemeTask:]):

Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(ParsedRange::ParsedRange):

Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFinishProgress):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::didDetectXSSForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::InjectedBundlePage::closeFullScreen):

Tools/WebKitTestRunner/TestController.cpp:

(WTR::TestController::configureContentExtensionForTest):

Tools/WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::urlContains const):
(WTR::TestInvocation::shouldLogHistoryClientCallbacks const):

Tools/WebKitTestRunner/TestInvocation.h:
Tools/WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::configureContentExtensionForTest):

Canonical link: https://commits.webkit.org/250986@main

4:50 PM Changeset in webkit [294851] by Alan Coon

1 edit in branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp

Cherry-pick 1a810ee6f98a. rdar://problem/87980543

Unreviewed build fix. rdar://87980543

Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'WebCore::FEImage::SourceImage &&' (aka 'variant<Ref<WebCore::Image>, Ref<WebCore::ImageBuffer>, ObjectIdentifier<WebCore::RenderingResourceIdentifierType>> &&')

Canonical link: https://commits.webkit.org/245886.575@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [294850] by Alan Coon

7 edits in branches/safari-613-branch/Source

Cherry-pick a173819be243. rdar://problem/87980543

Cherry-pick r294280. rdar://problem/87980543

This reverts r294684.

Canonical link: https://commits.webkit.org/245886.574@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [294849] by Alan Coon

1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

Cherry-pick 589c2b5478bb. rdar://problem/92780272

Apply patch. rdar://problem/92780272

Canonical link: https://commits.webkit.org/245886.563@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [294848] by Alan Coon

6 edits
2 adds in branches/safari-613-branch

Cherry-pick f5e42d63fc9. rdar://problem/93601919

Expose the correct role, subrole and role description properties for the <dialog> element.
https://bugs.webkit.org/show_bug.cgi?id=236359

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/dialog-properties.html

Elements with role="dialog" are exposed to accessibility clients with
role AXGroup, subrole AXApplicationDialog and role description
"web dialog". This patch implements this behavior for the <dialog>
element.

accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const):

LayoutTests:

Tests that these AX properties have the expected values both when the
dialog is shown modal or modeless.

accessibility/dialog-properties-expected.txt: Added.
accessibility/dialog-properties.html: Added.

Canonical link: https://commits.webkit.org/247198@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [294847] by Alan Coon

1 edit in branches/safari-613-branch/Source/JavaScriptCore/b3/B3ReduceStrength.cpp

Cherry-pick 6983e76741a1. rdar://problem/93536782

Refine B3ReduceStrength's range for sign extension operations.
https://bugs.webkit.org/show_bug.cgi?id=240720
<rdar://problem/93536782>

Reviewed by Yusuke Suzuki and Keith Miller.

Source/JavaScriptCore/b3/B3ReduceStrength.cpp:

Canonical link: https://commits.webkit.org/250808@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [294846] by Alan Coon

4 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293094. rdar://problem/91683009

Some AutoscrollController cleanup
https://bugs.webkit.org/show_bug.cgi?id=239512

Reviewed by Alan Bujtas.

Have AutoscrollController store a WeakPtr to the render object. Address an apparent
null de-ref in AutoscrollController::stopAutoscrollTimer() where the Frame can null.

Refactor updateDragAndDrop() with a lambda so that all the code paths that exit early
clearly call stopAutoscrollTimer() which nulls out the renderer.

page/AutoscrollController.cpp: (WebCore::AutoscrollController::autoscrollRenderer const): (WebCore::AutoscrollController::startAutoscrollForSelection): (WebCore::AutoscrollController::stopAutoscrollTimer): (WebCore::AutoscrollController::updateAutoscrollRenderer): (WebCore::AutoscrollController::updateDragAndDrop): (WebCore::AutoscrollController::startPanScrolling):
page/AutoscrollController.h:
page/EventHandler.cpp: (WebCore::EventHandler::startPanScrolling):

Canonical link: https://commits.webkit.org/249805@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294845] by Alan Coon

4 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r292596. rdar://problem/88862115

Take top layers into account in addLayers/removeLayers
https://bugs.webkit.org/show_bug.cgi?id=238946

Patch by Rob Buis <rbuis@igalia.com> on 2022-04-08
Reviewed by Simon Fraser.

Take top layers into account in addLayers/removeLayers, they
should use the RenderView layer as parent (emulating layerParent).

rendering/RenderElement.cpp: (WebCore::addLayers): (WebCore::RenderElement::addLayers): (WebCore::RenderElement::removeLayers): (WebCore::RenderElement::willBeRemovedFromTree):
rendering/RenderElement.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):

Canonical link: https://commits.webkit.org/249429@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294844] by Alan Coon

8 edits in branches/safari-613-branch

Cherry-pick r294234. rdar://problem/93602100

Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
https://bugs.webkit.org/show_bug.cgi?id=240366

Reviewed by Devin Rousso.

Source/JavaScriptCore:

inspector/protocol/DOM.json:

Source/WebCore:

Added test cases to inspector/model/dom-node.html

After r266885, there is no path to handle the possibility that there may not be a resulting node for calls to
DOM.querySelector. To correct this, mark the return value as optional (Web Inspector frontend already treats
it as optional) and return early if there was no Element matching the selector.

inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::querySelector):
inspector/agents/InspectorDOMAgent.h:

LayoutTests:

inspector/model/dom-node.html:
inspector/model/dom-node-expected.txt:

Canonical link: https://commits.webkit.org/250592@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294843] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293922. rdar://problem/93602176

null ptr deref in WebCore::Frame::setPrinting
https://bugs.webkit.org/show_bug.cgi?id=240173

Reviewed by Wenson Hsieh.

Check m_doc in Frame::setPrinting before access, as it is a RefPtr that can become null.

page/Frame.cpp: (WebCore::Frame::setPrinting):

Canonical link: https://commits.webkit.org/250369@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294842] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293857. rdar://problem/93602013

Remove unnecessary calls to CachedResource::updateBuffer and CachedResource::updateData
https://bugs.webkit.org/show_bug.cgi?id=240126

Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-05
Reviewed by Chris Dumez.

It adds a function call that does nothing but a redundant assert.

loader/cache/CachedImage.cpp: (WebCore::CachedImage::updateBufferInternal): (WebCore::CachedImage::updateBuffer): (WebCore::CachedImage::updateData):

Canonical link: https://commits.webkit.org/250322@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294841] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293827. rdar://problem/92624773

replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>

Reviewed by Eric Carlson.

We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.

Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Canonical link: https://commits.webkit.org/250300@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294840] by Alan Coon

4 edits
2 adds in branches/safari-613-branch

Cherry-pick r293819. rdar://problem/93602086

Crash in WindowProxy::setDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=232763

Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-04
Reviewed by Chris Dumez.

Source/WebCore:

Add a few null checks here and there.

Test: fast/dom/set-dom-window-without-page.html

bindings/js/WindowProxy.cpp: (WebCore::WindowProxy::setDOMWindow):
loader/FrameLoader.cpp: (WebCore::FrameLoader::findFrameForNavigation):

LayoutTests:

fast/dom/set-dom-window-without-page-expected.txt: Added.
fast/dom/set-dom-window-without-page.html: Added.

Canonical link: https://commits.webkit.org/250292@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294839] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293728. rdar://problem/92362769

Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
https://bugs.webkit.org/show_bug.cgi?id=240001

Reviewed by Eric Carlson.

Manually tested.

platform/mediastream/mac/CoreAudioCaptureSource.cpp: Initialize the sampleRate field before using it.

Canonical link: https://commits.webkit.org/250216@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294838] by Alan Coon

3 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293664. rdar://problem/92362769

VPIO requires the same sample rate for microphone and speaker formats
https://bugs.webkit.org/show_bug.cgi?id=239956

Reviewed by Eric Carlson.

VPIO requires the speaker sample rate and microphone sample rate to be the same.
This is not guaranteed to be true : getUserMedia/applyConstraints may set the microphone sample rate to different values.
If audio rendering already started at capture start time, we use the audio rendering sample rate.
This is not strictly compliant, given required constraints but they are not widely used.
Applications that want to make sure to use a specific sample rate would need to pause audio rendering when starting to capture.
We reset exposed settings when starting to capture to expose the actual sample rate to JavaScript through MediaStreamTrack.getSettings().

Manually tested.

platform/mediastream/mac/BaseAudioSharedUnit.h:
platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Canonical link: https://commits.webkit.org/250168@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294837] by Alan Coon

3 edits in branches/safari-613-branch/Source/ThirdParty/libwebrtc

Cherry-pick r293643. rdar://problem/92445366

[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>

Reviewed by Eric Carlson.

Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.

Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

Canonical link: https://commits.webkit.org/250147@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [294836] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293147. rdar://problem/93601944

Skip release assert during container query resolution
https://bugs.webkit.org/show_bug.cgi?id=239537

Patch by Rob Buis <rbuis@igalia.com> on 2022-04-21
Reviewed by Antti Koivisto.

Skip release assert during container query resolution
since resolveStyle will be a no-op as the container
query resolution was started in resolveStyle, so calling
resolveStyle the second time will bail right away.

dom/Document.cpp: (WebCore::Document::updateStyleIfNeeded):

Canonical link: https://commits.webkit.org/249843@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:42 PM Changeset in webkit [294835] by Wenson Hsieh

1 edit in trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

Avoid extracting the main video in element fullscreen when fullscreen mode isn't active
https://bugs.webkit.org/show_bug.cgi?id=240910
rdar://93906888

Reviewed by Eric Carlson.

Add a check that we're actually still in element fullscreen before extracting the main video. Since
WebFullScreenManager and its m_element both persist after exiting fullscreen mode, there's
currently nothing preventing us from re-triggering video extraction when a video is paused once
again outside of fullscreen mode.

Covered by a new API test (more details in the bug).

Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired):

Deal with another corner case, wherein the main video element we previously detected may no longer
be in the fullscreen element's subtree by the time that the extraction timer fires. To avoid this,
always update the main video element again when the extraction timer is fired (as long as we're
still in fullscreen mode), before proceeding with extraction.

Canonical link: https://commits.webkit.org/250985@main

4:27 PM Changeset in webkit [294834] by commit-queue@webkit.org

534 edits
4 copies
6 moves
22 adds
2 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE to 2022-05-24 (8291f2d3e72eca3a25826b689a013c292ef4ba94)
https://bugs.webkit.org/show_bug.cgi?id=240894

Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-25
Reviewed by Kimmo Kinnunen.

Contains upstream commits:
8291f2d3e Fix ValidCompressedSubImageSize for 3D uploads
84a0b462d Vulkan: Bug fix in GL_QCOM_shading_rate
1afb80587 Add Vulkan backend support for texture labels
7a243dbe2 Capture/Replay: Allow repeated Gen-on-Bind for resources
7df1f5816 GN: Add angle_build_tests.
11e9c8351 Vulkan: Dump graphics pipeline cache graph
2f0b6429b Revert "util/X11Window: Set PMinSize and PMaxSize hints."
cd48eedd9 Roll Chromium from 99a468a0505d to d624307d6d25 (438 revisions)
35e54dbb6 Vulkan: Fix EXT_texture_buffer support condition
f6c149339 dEQP: Support Wayland
6e2588639 Vulkan: Use packed enum for present modes
9e0a7be6c Traces: Update restricted_trace_perf.py
2ae8bdb3a Roll vulkan-deps from 880c9e0050c6 to 82a65519c521 (5 revisions)
80be1bb38 Roll SwiftShader from 73679602bc0b to b5cb037f0292 (2 revisions)
2db4297ad Roll Chromium from f0d8ec07c77f to 99a468a0505d (698 revisions)
e4a517c92 Vulkan: Rearrange GraphicsPipelineDesc to reduce footprint
f52c629b9 Capture/Replay: Make sure replay tests build libEGL
0b808c746 Silence all std::iterator deperecation warnings
bb3afdf42 Drop support for 64xMSAA+
688553c03 Vulkan: Dynamic state for primitive restart enable
c76fb2d82 Enable EXT_texture_norm16 on ES2/D3D11
3b78e0d56 Vulkan: Dynamic state for depth bias enable
7c83a3635 Vulkan: Dynamic state for rasterizer discard enable
2faabfe5e Vulkan: Optimize pipeline desc w.r.t dynamic state
ee1894e5f Account for GL_ANGLE_yuv_internal_format when setting yuv state
3da24b5cd Move trace loader code to a common location.
52c42e5a8 Temporarily disable deprecation warnings for VK-GL-CTS
88f582f6a D3D: fix whole-array assignment to SSBOs.
f8e8b7cc3 Roll vulkan-deps from c37d1e2ab98c to 880c9e0050c6 (19 revisions)
8af51b7ef Roll SwiftShader from 2933d3126969 to 73679602bc0b (4 revisions)
c3687f079 Roll Chromium from 170d12460fd5 to f0d8ec07c77f (430 revisions)
58fd31577 Vulkan: Dynamic state for vertex stride
e71a3e5fa Insert Metal polyfill for Matrix /= Scalar when needed
78ea85213 Suppress Flaky Tests
af869f4ac Update capture replay expectation file
118a6484c Metal: Upstream buffer cache fix from WebKit
f674e501f Tests: Add Bridge Constructor Portal trace
728dea2be Suppress Vulkan Validation Error
40269f91c Fix trigger.py to run mb.py with python3
c7182af2b Vulkan: Reserve varying for xfb if pre-rotation is enabled
86074fc77 Roll Chromium from dbb1f3a2b2f7 to 170d12460fd5 (586 revisions)
54a6b76f6 Roll third_party/rapidjson/src/ 7484e06c5..781a4e667 (156 commits)
2fd7444bc Fetch gn binary for the correct architecture on linux.
06fa297b6 Roll SwiftShader from cb4fc6d02fe4 to 2933d3126969 (1 revision)
6ae0c3214 Vulkan: clamp dynamic line width to supported values
d3eb61d4a D3D11: fix SSBO load in a return statement.
28dfa45d6 Spawn via vpython when old module detected.
b7474d0ae D3D11: Add GL_EXT_texture_buffer support
87ea0c7df Vulkan: SPIR-V Gen: Apply Flat to gl_Layer in FS
8701f53a4 Vulkan: Fix clear value for incomplete MS textures
dbeba9004 Reland "CGL, MTL: pbuffer for IOSurface fails for some formats"
b4ec8eac5 D3D11: implement image load/store for non-compute shaders.
2fdd7bfd1 Vulkan: Support binding 2D slice of a 3D texture to an image unit
14ca09bcf Metal: Remove the long type from program preludes
ff011779c Vulkan: Let texture buffer handle BufferVk's storage change
3d430f5f3 Vulkan: Add test for texture buffer and buffer data interaction
2abf9adf6 Vulkan: Bug fix in YUV descriptor pool allocation
78b8f5467 Roll SwiftShader from 89eb09307fbc to cb4fc6d02fe4 (1 revision)
428cd884e Tests: Add Stardew Valley trace
5e34541a1 Roll SwiftShader from 4011ab35f3d8 to 89eb09307fbc (3 revisions)
4dc9c79e0 Roll Chromium from 73ffbbeac851 to dbb1f3a2b2f7 (503 revisions)
c649979b7 Create EGLImage from VkImage correctly with non sized format
cd4cce3f8 Add more tips about recovering the qpa file.
957a44f41 Clarify that angle_debug_package is necessary to load the apk
93c0c90db Suppress the failing egl test to unblock roller
a277f1bce Vulkan: Fix Wayland surface size queries
6136ba273 D3D: minor cleanup of gl::RangeUI usage.
4ece3b08f Vulkan: Multiple DRM formats
d75bf9ad0 Capture/Replay: Also limit the number of per shader SSBOs
552b01d15 Roll vulkan-deps from 131de3fd9ec7 to c37d1e2ab98c (2 revisions)
7d7ed2538 Roll Chromium from 11b60f867851 to 73ffbbeac851 (445 revisions)
807c94ea8 Capture/Replay: Adjust tests do adhere to capture limits
891a46820 Vulkan: Dynamic state for stencil test/op
66dcca5e5 Vulkan: Dynamic state for depth test/write/op
bedb3075b Do not call RendererVK::handleDeviceLost() for device lost
15ecf068e Vulkan: Dynamic state for depth bounds
20820bb4b Make BitSetArray constexpr
36f5e6ce5 Vulkan: Fix DRM to GL format conversion
1cbcc1da1 Roll vulkan-deps from c6a60f3cc711 to 131de3fd9ec7 (22 revisions)
459c367ed D3D: Initialize storage after generating mipmap images.
ed909ee8a Roll SwiftShader from f1c2c0b07281 to 4011ab35f3d8 (1 revision)
7f14dd79b Roll Chromium from 3aa3e39b0aca to 11b60f867851 (666 revisions)
48b1f07b0 Vulkan: Dynamic state for front face
4e5da2d28 Vulkan: Dynamic state for cull mode
62fe36d3b Vulkan: Emulate YUV built-ins
4b95ac7df Vulkan: Don't invalidate pipeline on dynamic state change
81c84292f Do not do cleanup for Vulkan device lost
808192a74 Code Cleanup
87058cb8a Re-skip flaky test un-skipped by crrev.com/c/3641181
1b434e96b Skip flaky test on Mac NVIDIA.
4a7dd9429 Metal: Fix dangling pointer warning in IntermRebuild.cpp
e56f227d6 Vulkan: Add case: TextureSampleByDrawDispatchDraw
ece8fb5df Roll vulkan-deps from b768d03422ea to c6a60f3cc711 (1 revision)
03ccd9cc9 Revert "Vulkan: Flush texture updates more often"
21ad9b3c8 Vulkan: Add generic descriptors for DS cache.
d8d396dbc Vulkan: Add shared descriptor set caches.
0f2fc7664 TracePerfTest: Add ability to screenshot after reset.
7dc316c8f Roll Chromium from 65b23f3c9e05 to 3aa3e39b0aca (497 revisions)
8bb7c35c2 Vulkan: Flush texture updates more often
addfab1f7 Update docs for SwANGLE triage process.
8e844d0ff Tests: Add Black Desert Mobile trace.
389ae6b9a Add extension for read-only DS feedback loops.
40583b0f9 Tests: Skip pubg_mobile_skydive on Nvidia
4df8ca04f Remove angle_util from restricted traces.
580f90c7d Test Runner: Accept Chromium bot mode flag.
73cb1e6e2 Vulkan: Tag dynamic dirty bits with DYNAMIC
4ffab3bf5 Vulkan: Dynamic state for stencil reference
3d55cf0c0 Vulkan: Optimize the vkImage layout when used as GL_image
7e9e597ea Roll SwiftShader from e0a1188d7652 to f1c2c0b07281 (2 revisions)
8ec7b8b87 Roll Chromium from 693c7419bd5c to 65b23f3c9e05 (580 revisions)
1d8227dab Vulkan: Dynamic state for stencil write mask
c3def6fab Vulkan: Dynamic state for stencil compare mask
e9dc0f86d Cleanup from glBlitFramebuffer() 3D texture fix.
dcaa18b9c Vulkan: Dynamic state for blend color
536d6f57e Vulkan: Dynamic state for depth bias
42789b630 Use GLTexture in TextureTest for RAII goodness.
780f1a41b Vulkan: Dynamic state for line width
9b15e1c23 D3D11: clean up ES31 test expectations.
f6610106f Add a draw call perf test for changing a single uniform.
e73121b19 Vulkan: Fix VulkanPipelineCachePerfTest
dd9b4afe5 D3D: minor cleanup for image load/store.
1fa4442ba Vulkan: Set dynamic state after binding pipeline
089f2871b PerfTests: Add support for eglCreateImage and eglDestroyImage
5b623dd4b D3D9: Enable OES_fbo_render_mipmap
25ebc3b86 Roll vulkan-deps from 27ef4a0d9701 to b768d03422ea (7 revisions)
eea6366c7 Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
029a4c948 util: Add calls for createImage* and destroyImage* to GLWindow
486ae89e4 Roll Chromium from 46c13be19f0f to 693c7419bd5c (567 revisions)
a8ebdf2b5 Basis Universal Texture Experiment
6ddbfa397 Metal: Log the shader source when a shader fails to translate
52904367d D3D: Mark images clean after syncing from storage
f1640db8c Fix crash when calling certain gl APIs before initialization.
66b9214fb Capture/Replay: rename ANGLE_CAPTURE to ANGLE_CAPTURE_GL
2fb58a95b Re-land: "Vulkan: GBM platform"
4ecb1e3e6 Vulkan: Support wide lines
18089dff2 Vulkan: Clean up flag passing in ImageView init.
8e1215716 D3D11: fix 3D texture blits.
464f30f4e Vulkan: Refactor UtilsVk dynamic state handling
86d9d66dc Vulkan: Determined sized-ness of format in initImageViews.
9872c1d63 Switch deqp merge to python3
5fa8f9045 Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions)
c8c2664af Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
6bf0e620a Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions)
2b8172b9b Vulkan: Add missing initialization for mTotalMemorySize
31321cb73 Vulkan: Remove suppressions and workarounds for old AMD/Windows
0db4c39b5 Revert "Vulkan: GBM platform"
26a2e1471 Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions)
d4442f538 Reset the program executable if async linking fails.
825d5b2c5 Vulkan: GBM platform
0b0744f3e Vulkan: Fix VVL error for black desert mobile
b51bbe246 Add CopyTextureTest.ClearAfterCopySubTexture
b54b11460 Vulkan: Use ImageView layer count functions in TextureVk.
c8c4109cd HLSL: Disambiguate functions that have int/uint parameters.
e1de0950d Vulkan: Always init image views using image format.
8b4e74127 Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions)
78d88796b Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions)
e316203a6 Vulkan: add forceContinuousRefreshOnSharedPresent feature
225d8f83a Tests: Add Mortal Kombat App Trace
fa4523cf2 Roll vulkan-deps from 4ca7acf89869 to 626b2fd72bde (22 revisions)
cadb933fd Roll Chromium from 3bc34dd4d819 to 333c8248b125 (124 revisions)
1d073482a Tests: Add Basemark GPU trace
38a53d654 Revert "Remove limit_max_texture_size_to_4096 workaround"
bec809fe9 [Fuchsia] Download the gn sdk instead of core
5f2ad1537 Tests: Add Puzzles and Survival trace
b33d15556 Roll VK-GL-CTS from 106df4122297 to acf70aaf3fdb (12 revisions)
950db602b Roll SwiftShader from 643179694ec7 to 74e34ab97aeb (7 revisions)
dbbfac650 Tests: Add Monument Valley trace
b365a6069 Tests: Add Dead Cells trace
72cc8cbca Migrate Fuchsia sdk checkout from using script to CIPD
e0d00563f Vulkan: Simplify external format Chroma code.
51d6a1d96 Roll Chromium from 617cd3226543 to 3bc34dd4d819 (40 revisions)
a78eca2ca util/X11Window: Set PMinSize and PMaxSize hints.
332c9ad04 Roll Chromium from 7a60295b6324 to 617cd3226543 (278 revisions)
1d5d09e41 Vulkan: Prefer MAILBOX over IMMEDIATE present mode
d075dfe25 Vulkan: Reduce kMaxBufferToImageCopySize to 64M
333da2cf1 Vulkan: Limit the total bytes of suballocation garbages in flight
98488a196 FramebufferTest: Add FramebufferChangeTest test.
b79178a3e Scripts: Strip prebuilt debug APK from AOSP roll
8dcba9ae6 Roll Chromium from 1c301e690de1 to 7a60295b6324 (184 revisions)
51dc3c3e6 Vulkan: Force prune when there are lots of suballocations destroyed
bcc03bd62 Remove limit_max_texture_size_to_4096 workaround
2fae9482c Vulkan: Use heuristic to decide how many empty buffers to keep
0afa5b9f9 Tests: Add Alto's Odyssey trace.
2ce60b52a Fixes for C++20 support.
3f216ee74 Vulkan: Set timeout for MultiContextDrawWithSwap*
bd44b29d2 Roll Chromium from 6db3a94387ed to 1c301e690de1 (550 revisions)
d73468673 Decommission win7-x86-amd and win7-x64-nvidia
9865ed8b8 Check in build files needed.
9053a641b Vulkan: Wayland dmabuf extensions
77cd0b5a3 Re-land: "Vulkan: Cache ImageView serials on texture changes."
b72cff8c0 Fix build flags not in declare_args when angle_has_build is true
14c483f1c Presubmit: Verify comment before new tests
dc1ab34c9 Roll SwiftShader from cdf43bd816d7 to 643179694ec7 (4 revisions)
34fb4f790 Roll Chromium from 55c89a3a09ac to 6db3a94387ed (508 revisions)
edd331ebe Traces: Add a device arg to restricted_trace_perf
a7238b525 Consolidate handle list before pushing to mReleasedList
064fc64aa infra: Remove some slow *SAN tests.
9ab470749 D3D11: fix BufferToTexture copy when UNPACK_ROW_LENGTH is set.
9ad43bdd2 Re-land: "Vulkan: Support Wayland"
5c9f676d3 Basis Universal Texture Experiment
84e42c3b0 Fix validation cache when deleting a Transform Feedback.
b5f0fd1bd Skip flaky tests on Win ASAN
c0942c2d4 Roll vulkan-deps from 1cde45b8d7aa to 4ca7acf89869 (6 revisions)
c92d69d7d Roll SwiftShader from adef92e7b4c6 to cdf43bd816d7 (8 revisions)
4bbc55f4c Revert "Re-land: "Vulkan: Support Wayland""
58526dea2 Roll Chromium from 929311ac6298 to 55c89a3a09ac (470 revisions)
5113ae8ef Vulkan: Explicitly enable per-sample shading if sample used
9200ba537 Reland "Make SPIRV optional for Metal backend"
802504add Vulkan: Add log for buffer pool stats
4d26c66d0 Vulkan: Call cleanupGarbage only if mLastCompletedQueueSerial changed
527557b9c Fix ValidateFramebufferTextureLayer for cubemap arrays
e6662832a Re-land fixing of commit ID for Android builds.
3e05b93af Vulkan: MSAA swapchain resolve based on renderArea
c6e6e284e Update Android deqp and end2end sharding
237479a27 Fix presubmit following https://crrev.com/c/3611486
bc929e6e5 D3D11: recompile all shaders using 10.0.20348.0 toolchain.
b953bc13e Tests: Add GFXBench Tessellation trace
f7615d0ad OpenGL: Add allow_astc_formats workaround
4dc4c0f05 Remove whitespace from features json files
df163d714 Test both MSL translators in APPLEClipDistanceTest
06fa7e39a Expand Intel GPU detection
e0dd196a0 Re-land: "Vulkan: Support Wayland"
ea9a2dbea Capture/Replay: handle glGetVertexAttrib parameter value
41adabc48 Use app data dir instead of /sdcard for writing qpa file
5b4f180cd Fix formatting
f1c5e2b11 Roll vulkan-deps from 7b51f5f85aad to 1cde45b8d7aa (4 revisions)
fd57d8f0c Roll Chromium from 3a1ff9044aec to 929311ac6298 (541 revisions)
e55990e35 Capture/Replay: Handle arrays with uniform block indices
1aa4c120d gl_tests: Fix formatting
c7a9f0c6c Vulkan: Remove syncval suppressions no longer triggering
e39dfe0fe Roll VK-GL-CTS from a22069b4e3b7 to 106df4122297 (1 revision)
3eb2bcf77 Vulkan: Fix syncval errors with DONT_CARE for unused attachments
3eb891960 Roll Chromium from 1e97e6cd1c3c to 3a1ff9044aec (639 revisions)
31f841386 Add option for Metal output to angle_shader_translator
394fb0d34 Vulkan: Don't take lock for getLastCompletedQueueSerial
5e4c141c2 Tests: Add GFXBench Driver Overhead 2 trace
7184fe38c Tests: Add Jetpack Joyride trace.
8b26c14c0 Roll SwiftShader from b92f7acb7e81 to adef92e7b4c6 (4 revisions)
2d3ad8ec6 Roll vulkan-deps from 1963b94c99e8 to 7b51f5f85aad (4 revisions)
1c4c9fe95 Capture/Replay: Fix formatting
2c58e7a5b Reduce console spam from Metal shader translation
437053a16 Revert "Make SPIRV optional for Metal backend"
f9729598a Revert "Fix commit ID gathering on Android builds."
c1d0e139d Roll vulkan-deps from 4f93dbdc6060 to 1963b94c99e8 (2 revisions)
d5ceba0b4 Roll SwiftShader from f88fc3b53c52 to b92f7acb7e81 (3 revisions)
3e4069290 Roll Chromium from c7e51a124fab to 1e97e6cd1c3c (915 revisions)
2a6e123b1 Vulkan: Move pruneOrphanedBufferBlocks to last
266111a55 Vulkan: Fix SemaphoreCount best practice warning
1ef90012b Vulkan: Remove API access for mTotalBufferToImageCopySizen
454efd1d5 Add forceDepthAttachmentInitOnClear frontend workaround
29287e1fc Make SPIRV optional for Metal backend
3b65b8037 Vulkan: Work around Qualcomm imprecision with dithering
6c2486918 Enable SINGLE_BUFFER with eglCreateWindowSurface
1835e5d89 Fix commit ID gathering on Android builds.
c9794d6c0 Run a smoke test in each shard and crash on timeouts.
80d50b992 Add build arg to automatically attach renderdoc
7d31a47fc Vulkan: Optimize away eglSwapBuffers for single buffer surfaces
5c756bc1a Perf Tests: Compute GPU time periodically
c402f002b Android perf tests shards 20->6 (only --smoke-test-mode)
6930184ef Log runTests so that it shows up in logcat dumps.
c45aff4f2 Roll SwiftShader from 5f5faa3a2aad to f88fc3b53c52 (4 revisions)
cc834907f Roll vulkan-deps from f685346e2e51 to 4f93dbdc6060 (2 revisions)
95c1ff52b EGL: Fix EGL_KHR_mutable_render_buffer
0c59b5d90 Log debuggerd $PID output when instrumentation gets stuck.
fe2c82ad3 check integer overflow in Texture copyImage
cdcf17153 Add missing result_skip and result_fail.
1a144edfe Metal:ReadPixels AMD Copy Texture to Buffer optimization
6b9c5c8d1 Vulkan: Improve GetStorageMemoryType logic
cbdefd933 Roll chromium_revision 192db13f85..c7e51a124f (995097:996181)
d0c8363e0 Dump logcat if instrumentation doesn't finish in 10 minutes.
ebfb9b9f0 Configure logging in perf and gold tests to include time.
7555a1590 DEPS: Remove deprecated chromium dep
fc8282875 Tests for Nvidia/Vulkan bugs with tessellation control

Canonical link: https://commits.webkit.org/250984@main

4:24 PM Changeset in webkit [294833] by Karl Rackler

1 edit in trunk/LayoutTests/platform/ios/TestExpectations

[Gardening]: [ iOS Debug ] resize-observer/resize-observer-with-zoom.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240929
<rdar://93934172>

Unreviewed test gardening.

LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/250983@main

3:57 PM Changeset in webkit [294832] by Said Abou-Hallawa

19 edits in trunk/Source/WebCore/platform/graphics

[GPU Process] [Filters] Don't use Uint8ClampedArray in software filter appliers
https://bugs.webkit.org/show_bug.cgi?id=240777
rdar://93916935

Reviewed by Simon Fraser.

The plan is to allocate the FilterImage buffers differently for GPUProcess. The
first step is to hide the underlying memory of PixelBuffer from the software
filter appliers. Helpers functions will provide access to Uint8ClampedArray. In
future patches different memory allocation will be used by new sub-classes of
PixelBuffer.

Source/WebCore/platform/graphics/PixelBuffer.cpp:

(WebCore::PixelBuffer::bytes const):
(WebCore::PixelBuffer::byteLength const):
(WebCore::PixelBuffer::setRange):
(WebCore::PixelBuffer::zeroRange):
(WebCore::PixelBuffer::item const):
(WebCore::PixelBuffer::set):
(WebCore::PixelBuffer::createScratchPixelBuffer const):

Source/WebCore/platform/graphics/PixelBuffer.h:

(WebCore::PixelBuffer::zeroFill):

Source/WebCore/platform/graphics/filters/FEComposite.h:
Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::FilterImage::correctPremultipliedPixelBuffer):

Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:

(WebCore::FEColorMatrixSoftwareApplier::applyPlatformAccelerated const):
(WebCore::FEColorMatrixSoftwareApplier::applyPlatformUnaccelerated const):

Source/WebCore/platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:

(WebCore::FEComponentTransferSoftwareApplier::applyPlatform const):

Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:

(WebCore::FECompositeSoftwareApplier::applyArithmetic const):

Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:

(WebCore::FEConvolveMatrixSoftwareApplier::setDestinationPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::setInteriorPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::setOuterPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:
Source/WebCore/platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:

(WebCore::FEDisplacementMapSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:

(WebCore::FEDropShadowSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

(WebCore::FEGaussianBlurSoftwareApplier::boxBlurAlphaOnly):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlur):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurAccelerated):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurUnaccelerated):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurGeneric):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurWorker):
(WebCore::FEGaussianBlurSoftwareApplier::applyPlatform):
(WebCore::FEGaussianBlurSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h:
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:

(WebCore::FELightingSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h:
Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:

(WebCore::FEMorphologySoftwareApplier::columnExtremum):
(WebCore::FEMorphologySoftwareApplier::applyPlatformGeneric):
(WebCore::FEMorphologySoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.h:
Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp:

(WebCore::FETurbulenceSoftwareApplier::applyPlatformGeneric):
(WebCore::FETurbulenceSoftwareApplier::applyPlatformWorker):
(WebCore::FETurbulenceSoftwareApplier::applyPlatform):
(WebCore::FETurbulenceSoftwareApplier::apply const):

Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.h:

Canonical link: https://commits.webkit.org/250982@main

3:45 PM Changeset in webkit [294831] by Brent Fulgham

5 edits in trunk/Source/WebKit/UIProcess

Prevent NSAttributedString crashes when AppSSO URLs are provided
https://bugs.webkit.org/show_bug.cgi?id=240739
<rdar://93656000>

Reviewed by Chris Dumez.

When NSAttributedString is used in a sandboxed app, it is prevented from checking in with the
AppSSO plugin manager, causing a Sandbox Violation and crash. We don't want NSAttributedString
to ever hand-off to AppSSO, so we should configure it's internal WKWebView to do the right thing.
Reviewed by Chris Dumez.

Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:

(+[_WKAttributedStringWebViewCache configuration]): Turn off AppSSO for string uses.

Source/WebKit/UIProcess/Cocoa/NavigationState.mm:

(WebKit::trySOAuthorization): Use new lazy loading approach.

Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::trySOAuthorization): Ditto.

Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Lazily initialize, and RELEASE_ASSERT
if we somehow reach this code without enabling AppSSO.

Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Deleted.

Canonical link: https://commits.webkit.org/250981@main

3:36 PM Changeset in webkit [294830] by Kate Cheney

5 edits in trunk

Directories showing up as terminal icons in mail compose
https://bugs.webkit.org/show_bug.cgi?id=240882
rdar://45111300

Reviewed by Wenson Hsieh.

Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::iconForAttachment):
We should not try to fetch an icon if all three provided strings are
null. This was causing issues by attempting to fetch an icon after
already rendering a valid icon using the filewrapper.

Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::requestThumbnailWithOperation):
(WebKit::WebPageProxy::requestThumbnailWithPath):
Remove some extra spaces and unnecessary WebCore:: prefix.

(WebKit::WebPageProxy::updateIconForDirectory):
New function to update the icon for directories to use the filewrapper
icon instead of the iconForFileType API. This method flips the icon so
it is right-side-up and converts it to a bitmap to pass to the web
process.

Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestAttachmentIcon):

Source/WebKit/UIProcess/WebPageProxy.h:

Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(testDirectoryAttachmentFileURL):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
(TestWebKitAPI::_icon):
(TestWebKitAPI::TEST):
Add a test to make sure we hit the new NSFileWrapper icon path to fetch
the correct icon for the bundle.

Canonical link: https://commits.webkit.org/250979@main

3:36 PM Changeset in webkit [294829] by Karl Rackler

2 edits in trunk/LayoutTests/platform

[Gardening]: [ iOS Debug Big Sur Debug wk2 ] ASSERTION FAILED: WebCore::IDBTransaction::dispatchEvent(WebCore::Event&)
https://bugs.webkit.org/show_bug.cgi?id=240927
<rdar://93929670>

Unreviewed test gardening.

LayoutTests/platform/ios/TestExpectations:
LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/250979@main

3:29 PM Changeset in webkit [294828] by commit-queue@webkit.org

3 edits in trunk

[LFC][IFC] Support each-line keyword in text-indent
https://bugs.webkit.org/show_bug.cgi?id=240731

Patch by Kiet Ho <Kiet Ho> on 2022-05-25
Reviewed by Alan Bujtas.

Normally, text-indent only affects the first line. When 'each-line' is specified,
subsequent lines where the previous line ends with a hard break are also indented.
This is supported in the legacy layout engine but not in LFC. Adds support for
'each-line' to bring LFC to parity with the legacy engine.

Test: imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-each-line-hanging.html

LayoutTests/TestExpectations: Remove ImageOnlyFailure expectation.
Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const): Add logic to
indent line when 'each-line' is specified, and the previous line ends with a
hard break.

Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h: Modify

initialConstraintsForLine to accept information about the previous line,
not just whether there's one or not.

Canonical link: https://commits.webkit.org/250978@main

3:14 PM Changeset in webkit [294827] by Alan Coon

1 copy in tags/WebKit-7614.1.14.10.7

Tag WebKit-7614.1.14.10.7.

3:12 PM Changeset in webkit [294826] by Alan Coon

9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.7

2:47 PM Changeset in webkit [294825] by Angelos Oikonomopoulos

1 edit in trunk/Tools/Scripts/run-jsc-stress-tests

[run-jsc-stress-tests] Catch user error
https://bugs.webkit.org/show_bug.cgi?id=240905

Reviewed by Adrian Perez de Castro and Jonathan Bedard.

When the user has made a typo in the argument to --filter (selecting no
tests to execute), bring that to the user's attention instead of exiting
without an error.

Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/250977@main

2:38 PM Changeset in webkit [294824] by pvollan@apple.com

1 edit in trunk/Source/WebKit/Scripts/process-entitlements.sh

[iOS] WebContent captive portal XPC service needs entitlement to set sandbox state variables
https://bugs.webkit.org/show_bug.cgi?id=240921

Reviewed by Geoffrey Garen.

This patch also adds a function for the shared WebContent entitlements on iOS.

Source/WebKit/Scripts/process-entitlements.sh:

Canonical link: https://commits.webkit.org/250976@main

2:36 PM Changeset in webkit [294823] by Patrick Angle

1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

Re-enable http/tests/inspector/network/har/har-page.html for mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=229458

Unreviewed test expectations update.

LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/250975@main

2:26 PM Changeset in webkit [294822] by Alan Coon

9 edits in branches/safari-7614.1.14.1-branch/Source

Versioning.

WebKit-7614.1.14.1.11

2:16 PM Changeset in webkit [294821] by Ryan Haddad

1 edit in trunk/LayoutTests/platform/win/TestExpectations

[ Win EWS ] Six webanimations/offset-compositing tests are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240617

Unreviewed test gardening.

LayoutTests/platform/win/TestExpectations: Mark tests as flaky.

Canonical link: https://commits.webkit.org/250974@main

1:29 PM Changeset in webkit [294820] by sihui_liu@apple.com

11 edits
1 copy
1 delete in trunk/Source/WebKit

Remove old WebStorage implementation
https://bugs.webkit.org/show_bug.cgi?id=240833

Reviewed by Geoffrey Garen.

No behavior change; the new implementation inside Source/WebKit/NetworkProcess/storage/ is in use.

Source/WebKit/CMakeLists.txt:
Source/WebKit/NetworkProcess/NetworkProcess.h:
Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/SessionStorageNamespace.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/SessionStorageNamespace.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/StorageArea.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/StorageManager.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.cpp: Removed.
Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.h: Removed.
Source/WebKit/NetworkProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm: Removed.
Source/WebKit/Platform/Logging.h:
Source/WebKit/PlatformPlayStation.cmake:
Source/WebKit/PlatformWin.cmake:
Source/WebKit/Shared/StorageAreaIdentifier.h: Renamed from Source/WebKit/NetworkProcess/WebStorage/StorageAreaIdentifier.h.
Source/WebKit/Sources.txt:
Source/WebKit/SourcesCocoa.txt:
Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/250973@main

12:53 PM Changeset in webkit [294819] by Patrick Griffis

7 edits in trunk

Add support for Link nonces
https://bugs.webkit.org/show_bug.cgi?id=240817

This reads the nonce from link elements and Link headers.

This was implemented by Chromium in 2017 to be consistent with the HTMLPreloader:
https://chromium-review.googlesource.com/c/chromium/src/+/676769/

Reviewed by Kate Cheney.

LayoutTests/imported/w3c/web-platform-tests/preload/link-header-preload-nonce-expected.txt:
LayoutTests/imported/w3c/web-platform-tests/preload/link-header-preload-nonce.html:

These test changes were already upstream: https://github.com/web-platform-tests/wpt/commit/306dc506adba97ca84ada67bdab6227dba65bbcb

Source/WebCore/html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

Source/WebCore/loader/LinkHeader.cpp:

(WebCore::paramterNameFromString):
(WebCore::LinkHeader::setValue):

Source/WebCore/loader/LinkHeader.h:

(WebCore::LinkHeader::nonce const):

Source/WebCore/loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLinksFromHeader):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):

Source/WebCore/loader/LinkLoader.h:

Canonical link: https://commits.webkit.org/250972@main

12:39 PM Changeset in webkit [294818] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI/UserInterface/Views

Web Inspector: Timelines Tab: Screenshots: images should be centered
https://bugs.webkit.org/show_bug.cgi?id=240854

Reviewed by Patrick Angle.

Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:

(WI.ScreenshotsTimelineView.prototype.layout):

Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:

(.timeline-view.screenshots):
(.timeline-view.screenshots > .spacer): Added.
(.timeline-view.screenshots > img):

Canonical link: https://commits.webkit.org/250971@main

12:21 PM Changeset in webkit [294817] by Karl Rackler

1 edit in trunk/LayoutTests/platform/ios/TestExpectations

[Gardening]: [ iOS Debug ] Two fast/loader/ tests are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240918
<rdar://93918602>

Unreviewed test gardening.

LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/250970@main

12:05 PM Changeset in webkit [294816] by commit-queue@webkit.org

8 edits in trunk/Source/WebCore/platform/graphics

REGRESSION(r294215): : r294317 was reverted, it fixed an edge-case for 294217
https://bugs.webkit.org/show_bug.cgi?id=240645

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-25
Unreviewed.

Revert r294215, its dependency r294317 was reverted.

Reverted changeset:

"WebCore::IOSurface has WebCore::GraphicsContext as its
property, it should be the other way around"
https://bugs.webkit.org/show_bug.cgi?id=240417
https://commits.webkit.org/r294215

Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContextCG::drawNativeImage):

Source/WebCore/platform/graphics/cg/GraphicsContextCG.h:
Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::willAddSurface):

Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext):

Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::GraphicsContextCG::GraphicsContextCG): Deleted.

Source/WebCore/platform/graphics/cocoa/IOSurface.h:
Source/WebCore/platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::create):
(WebCore::IOSurface::ensureGraphicsContext):
(WebCore::IOSurface::releaseGraphicsContext):
(WebCore::IOSurface::releasePlatformGraphicsContext): Deleted.

Canonical link: https://commits.webkit.org/250969@main

12:03 PM Changeset in webkit [294815] by Wenson Hsieh

2 edits in trunk/Source/WebKit/UIProcess/ios

[iOS] Refactor some logic around tap gesture handling when VKCImageAnalysisInteraction is active
https://bugs.webkit.org/show_bug.cgi?id=240891
rdar://93808100

Reviewed by Aditya Keerthi.

Currently, when handling a single tap in WKContentView, we check whether or not the tap occurred
over the Live Text button in the VKCImageAnalysisInteraction; if so, we manually toggle Live Text
interaction highlight state. This special treatment exists (instead of simply relying on the
UIButton's tap gesture) because WKContentView already has its own synthetic click gesture which
conflicts with the UIButton's tap gesture; without this logic, taps on the analysis button would be
completely ignored.

While this works for the Live Text button, it doesn't work for other actionable buttons in the image
analysis interaction. To address this, we install a UIButtonConfigurationUpdateHandler on the
image analysis interaction just to collect the set of UIButtons that are owned by the interaction.
When tapping on the content view, if we hit one of these VisionKitCore-owned buttons, then invoke
the button action on its behalf.

Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _singleTapIdentified:]):

Also, pull this VisionKit interception logic out into a new helper method below, named
-_handleTapOverImageAnalysisInteractionButton:. This returns whether or not the tap was handled by
VisionKit (in which case we avoid treating this as a synthetic click on the page).

(-[WKContentView _handleTapOverImageAnalysisInteractionButton:]):
(-[WKContentView installImageAnalysisInteraction:]):
(-[WKContentView uninstallImageAnalysisInteraction]):

Canonical link: https://commits.webkit.org/250968@main

11:55 AM Changeset in webkit [294814] by pvollan@apple.com

1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

[iOS] Remove obsolete graphics message filters
https://bugs.webkit.org/show_bug.cgi?id=240736
<rdar://93527356>

Reviewed by Geoffrey Garen.

Remove obsolete graphics filters in the WebContent process' sandbox on iOS, since this filtering is
now done in other parts of the system.

Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: https://commits.webkit.org/250967@main

11:47 AM Changeset in webkit [294813] by Alan Coon

9 edits in branches/safari-7614.1.14.0-branch/Source

Versioning.

WebKit-7614.1.14.0.11

11:33 AM Changeset in webkit [294812] by J Pascoe

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

REGRESSION (r294434): [ iOS ] TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240686
<rdar://93603762>

Reviewed by Brent Fulgham.

The sync flag may differ at runtime due to internal reasons. This patch modifies the test to support either value
of the flag.

Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/250966@main

11:13 AM Changeset in webkit [294811] by Alexey Shvayka

1 edit in trunk/Source/JavaScriptCore/API/tests/testapi.cpp

[JSC] TestAPI::promiseUnhandledRejection() predominantly fails on MacOS 12.3 in --debug
https://bugs.webkit.org/show_bug.cgi?id=240243
<rdar://92975620>

Reviewed by Mark Lam.

The failures are caused by an unhandled rejection, that was originated in
TestAPI::promiseDrainDoesNotEatExceptions() and ended up in the callback of
TestAPI::promiseUnhandledRejection(), with an unexpected promise and reason.

That is, the callback of TestAPI::promiseUnhandledRejection() is called twice,
with only the first invocation being successful.

The failures weren't observed before MacOS 12.3 because TestAPI::promiseDrainDoesNotEatExceptions()
is a DYLD_MACOSX_VERSION-conditional test.

To fix the tests, this change ensures that TestAPI::promiseUnhandledRejection() performs assertions
only on the first run, aligning it with TestAPI::promiseUnhandledRejectionFromUnhandledRejectionCallback().

Source/JavaScriptCore/API/tests/testapi.cpp:

(TestAPI::promiseUnhandledRejection):

Canonical link: https://commits.webkit.org/250965@main

11:11 AM Changeset in webkit [294810] by mark.lam@apple.com

1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

Speculative build fix: Revert use of .alt_entry directive in LLInt asm code.
https://bugs.webkit.org/show_bug.cgi?id=240916

Unreviewed.

We suspect that this is causing linker issues on some builds.

Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:

Canonical link: https://commits.webkit.org/250964@main

11:01 AM Changeset in webkit [294809] by pvollan@apple.com

2 edits in trunk/Source/WebKit

Add logging related to Mach bootstrap enablement
https://bugs.webkit.org/show_bug.cgi?id=240909

Reviewed by Chris Dumez.

We are seeing telemetry that indicates that enabling Mach bootstrap is failing in some cases.
Add logging to help diagnose this.

Source/WebKit/Platform/Logging.h:
Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtension::createHandleForMachLookup):

Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtension::createHandleForMachLookup):

Canonical link: https://commits.webkit.org/250963@main

10:57 AM Changeset in webkit [294808] by Jon Davis

1 edit in trunk/metadata/contributors.json

Add my GitHub account to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240915

Unreviewed.

metadata/contributors.json:

Canonical link: https://commits.webkit.org/250962@main

10:54 AM Changeset in webkit [294807] by Alan Coon

1 copy in tags/WebKit-7613.3.1.1.5

Tag WebKit-7613.3.1.1.5.

10:45 AM Changeset in webkit [294806] by Alan Coon

9 edits in branches/safari-7613.3.1.1-branch/Source

Versioning.

WebKit-7613.3.1.1.5

10:43 AM Changeset in webkit [294805] by keith_miller@apple.com

1 edit in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

git-webkit pr crashes when run from detached HEAD
https://bugs.webkit.org/show_bug.cgi?id=240468

Reviewed by Jonathan Bedard.

repository.branch is None when on a detached HEAD. This causes us to throw an Error when performing a regex on the branch name.
This patch treats a detached HEAD the same as being on main.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.pull_request_branch_point):

Canonical link: https://commits.webkit.org/250961@main

10:29 AM Changeset in webkit [294804] by Alan Bujtas

2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Expand flex-grow support
https://bugs.webkit.org/show_bug.cgi?id=240898

Reviewed by Antti Koivisto.

This patch add support for flex-grow. This property defines how flex items take over the available space.

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: https://commits.webkit.org/250960@main

10:22 AM Changeset in webkit [294803] by zan@falconsigh.net

4 edits in trunk/Source/WebCore/platform/graphics

[Linux] GBMBufferSwapchain should only conditionally create linear-formatted buffer objects
https://bugs.webkit.org/show_bug.cgi?id=240637

Reviewed by Adrian Perez de Castro.

Spawning new gbm_bo objects should not default to requesting linear-storage
buffers. Instead, these should only be created when necessary, e.g. when
copying software-decoded video data into these buffers.

By default, no GBM flags are used. When required, the linear-storage requirement
is enscribed in the new flags field of the GBMBufferSwapchain::BufferDescription
object and acted upon in the GBMBufferSwapchain::getBuffer() call, using the
GBM_BO_USE_LINEAR flag in the gbm_bo_create() call.

The DMABuf-specific sink in MediaPlayerPrivateGStreamer is the only place at the
moment where linear-storage buffers are used since software-decoded material
originates here and is stored in linear memory.

Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:

(WebCore::GBMBufferSwapchain::getBuffer):

Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.h:
Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:

(WebCore::GraphicsContextGLANGLE::makeContextCurrent):

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/250959@main

9:53 AM Changeset in webkit [294802] by sihui_liu@apple.com

22 edits in trunk/Source/WebKit

Add remainingRunningTime info to logging of PrepareToSuspend message
https://bugs.webkit.org/show_bug.cgi?id=240879

Reviewed by Chris Dumez.

Replace background timing info with remaining run time info, so we have a better idea of when the message is sent and
when it is processed. We will know if the message is handled after process resumes (since process can be suspended
before it handles the message).

Source/WebKit/GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::prepareToSuspend):

Source/WebKit/GPUProcess/GPUProcess.h:
Source/WebKit/GPUProcess/GPUProcess.messages.in:
Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspendImminentlyForTestingSync):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::applicationDidEnterBackground):
(WebKit::NetworkProcess::applicationWillEnterForeground):
(WebKit::NetworkProcess::processDidResume):

Source/WebKit/NetworkProcess/NetworkProcess.h:
Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _processWillSuspendForTesting:]):
(-[WKWebView _processWillSuspendImminentlyForTesting]):

Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::sendPrepareToSuspend):

Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendPrepareToSuspend):

Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
Source/WebKit/UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::remainingRunTimeInSeconds):

Source/WebKit/UIProcess/ProcessAssertion.h:
Source/WebKit/UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):

Source/WebKit/UIProcess/ProcessThrottlerClient.h:
Source/WebKit/UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendPrepareToSuspend):

Source/WebKit/UIProcess/WebProcessProxy.h:
Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::sendNetworkProcessPrepareToSuspendForTesting):

Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::remainingRunTimeInSeconds):

Source/WebKit/WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prepareToSuspend):

Source/WebKit/WebProcess/WebProcess.h:
Source/WebKit/WebProcess/WebProcess.messages.in:

Canonical link: https://commits.webkit.org/250958@main

9:47 AM Changeset in webkit [294801] by pvollan@apple.com

1 edit in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

Syscall should only be allowed for newer macOS versions
https://bugs.webkit.org/show_bug.cgi?id=240714

Reviewed by Chris Dumez.

Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/250957@main

8:44 AM Changeset in webkit [294800] by Razvan Caliman

4 edits in trunk/Source/WebInspectorUI/UserInterface/Views

Web Inspector: Computed Panel: Move ungrouped CSS variables to dedicated DetailsSidebar
https://bugs.webkit.org/show_bug.cgi?id=240805

Reviewed by Patrick Angle.

A follow-up from https://github.com/WebKit/WebKit/pull/782#pullrequestreview-978824063

As an aside, it is unfortunate in hindsight that the variables section
element can either directly contain variables for ungrouped mode, or contain
sections. I wonder if there is a better way to handle this where we never
have to even add the variables section to the map and instead have a single
"section" within it (without a header) that behaves just like the grouped
sections, but for ungrouped mode.

The top-level Variables details section contains either:

the list of ungrouped variables
nested detail sections for each group of variables grouped by type

When toggling between grouping modes, we remove the host details sections for
variable groups, but we need to take care not to remove the top-level Variables
details section. This isn't ideal. All variable lists, ungrouped or grouped,
need their own independent host details section that can be safely removed
without impacting others.

A details section has a header with text and a button to toggle collapsing the
section contents. Ungrouped variables don't need this. The top-level Variables
details section serves this role (the reason why the code was written with it
doing double duty).

We can change the implementation of WI.DetailsSection to hide the header
if a title is not provided. This enables us to nest details sections without
showing extraneous headers. This relieves WI.ComputedStyleDetailsPanel.layout()
of the duty to avoid removing the top-level Variables details section.

Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .scope-bar.computed-style-variables-grouping-mode:hover):
(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .computed-style-section):

Adding symmetric padding to the top of the section to space out the contents
from the header's bottom border.

Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.layout):
(WI.ComputedStyleDetailsPanel.prototype._renderVariablesStyleSectionGroup):

Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:

(.details-section > .header:not(:empty)):
(.details-section .details-section > .header:not(:empty)):
(.details-section .details-section:not(.collapsed) > .header:not(:empty)):
(.details-section > .header:not(:empty)::before):
(.details-section > .header): Deleted.
(.details-section .details-section > .header): Deleted.
(.details-section .details-section:not(.collapsed) > .header): Deleted.
(.details-section > .header::before): Deleted.

Source/WebInspectorUI/UserInterface/Views/DetailsSection.js:

(WI.DetailsSection):
(WI.DetailsSection.prototype.get title):
(WI.DetailsSection.prototype.set title):

Canonical link: https://commits.webkit.org/250956@main

8:18 AM Changeset in webkit [294799] by Oriol Brufau

14 edits in trunk

Don't index shorthands in computed styles
https://bugs.webkit.org/show_bug.cgi?id=240356

Reviewed by Tim Nguyen.

Most shorthands were already not indexed, but legacy shorthands with a
single longhand were indexed. This didn't make much sense, since they
are like aliases with a different syntax, and aliases are not indexed.

Tests: fast/css/getComputedStyle/computed-style.html

fast/css/getComputedStyle/computed-style-without-renderer.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
svg/css/getComputedStyle-basic.xhtml

Canonical link: https://commits.webkit.org/250955@main

8:03 AM Changeset in webkit [294798] by Jonathan Bedard

3 edits in trunk/Tools/Scripts/libraries/webkitbugspy

[git-webkit] Check expiration in token
https://bugs.webkit.org/show_bug.cgi?id=240883
<rdar://problem/93859778>

Reviewed by Chris Dumez.

Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:

(Tracker.credentials.validater): Check token expiration explicitly.

Canonical link: https://commits.webkit.org/250954@main

7:49 AM Changeset in webkit [294797] by Jonathan Bedard

5 edits in trunk/Tools/Scripts/libraries/webkitscmpy

[git-webkit] clean all dead pr branches
https://bugs.webkit.org/show_bug.cgi?id=240589
<rdar://93521924>

Reviewed by Aakash Jain.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:

(DeletePRBranches): Iterate through all local branches and remove those
associated with a closed PR.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clean_unittest.py:

(TestClean.test_delete_pr_branches):

Canonical link: https://commits.webkit.org/250953@main

7:00 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

6:45 AM Changeset in webkit [294796] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer

Merge r294537 - REGRESSION(r288092): Deadlock when the playback is stopping just right after startup
https://bugs.webkit.org/show_bug.cgi?id=240661

Patch by Yacine Bandou <yacine.bandou@softathome.com> on 2022-05-20
Reviewed by Philippe Normand.

r288092 causes a deadlock with the "28. ChangeType.H264.VP9" test in "https://ytlr-cert.appspot.com/2020/main.html".

The background thread locks the GStPad and sends a notify::caps signal which is caught by
VideoTrackPrivateGStreamer that calls callOnMainThreadAndWait.

At the same time the main thread destroys MediaPlayerPrivateGStreamer and sets the pipeline to NULL
that calls "gst_pad_set_active" which wants to lock the GStPad.

This commit uses AbortableTaskQueue and calls enqueueTask instead of callOnMainThreadAndWait
in order to be able to abort the waiting job and avoid using the "AndWait" variant, consequently
we avoid the deadlock.

platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::disconnect):

platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::disconnect):

platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/250792@main

6:45 AM Changeset in webkit [294795] by Adrian Perez de Castro

2 edits
4 adds in releases/WebKitGTK/webkit-2.36

Merge r294791 - [MSE][GStreamer] Support Google Dynamic Ad Insertion (DAI)
https://bugs.webkit.org/show_bug.cgi?id=216039
<rdar://problem/68638316>

Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Alicia Boya Garcia.

The "simple DAI" demo was not working as expected because the new source pad of the demuxer in the append
pipeline was sinking buffers to a "black hole". That was happening because the second time the
no-more-pads signal was emitted, the previous source pad was still linked to a track, and there was
no code to unlink/relink demuxer pads. This is now handled...

The specific "simple DAI" demo generates 2 AAC streams, with different tkhd track-id fields, we had
no layout test reproducing this use-case, so this patch provides one.

Test: media-source/media-source-audio-track-id-switch.html

LayoutTests/media/media-source/content/test-48kHz-new-track-id.m4a: Added.
LayoutTests/media/media-source/content/test-48khz-new-track-id-manifest.json: Added.
LayoutTests/media/media-source/media-source-audio-track-id-switch-expected.txt: Added.
LayoutTests/media/media-source/media-source-audio-track-id-switch.html: Added.
Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::handleErrorSyncMessage):
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::linkPadWithTrack):
(WebCore::AppendPipeline::tryMatchPadToExistingTrack): Deleted.

Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::Track::isLinked const):

Canonical link: https://commits.webkit.org/250950@main

6:32 AM Changeset in webkit [294794] by commit-queue@webkit.org

24 edits in trunk/Source/JavaScriptCore

[JSC][ARMv7] Support callee save FPRs

Patch by Geza Lore <Geza Lore> on 2022-05-25
https://bugs.webkit.org/show_bug.cgi?id=240376

Reviewed by Yusuke Suzuki.

ARMv7 FPRs d8-d15 (also referenced as s16-s32 and q4-q7) are callee save
in the host ABI, but currently JSC is unaware of this. This does not
currently cause problems as they are not used, but will be used by the
Wasm JITs.

In preparation for the 32-bit ports of the Wasm JITs, this patch:

Teaches JSC about callee save FPRs on ARMv7. d8-d15 are host ABI callee save, but only d8-d14 are VM callee save, i.e.: we treat d15 as a volatile register in JIT code. This is so we can use d15 as a macro assembler scratch register.
Changes offlineasm and MacroAssemblerARMv7 to use d15 as the FP scratch register. We do this so we can use the full range of d0-d7 as temporary, and in particular as Wasm argument/return registers.
To achieve the above, we need to modify RegisterAtOffsetList as GPRs and FPRs have different sizes on JSVALUE32_64 platforms
Adds the ARMv7 specific registers to RegisterSet::macroScratchRegisters()

assembler/ARMv7Registers.h:
assembler/MacroAssemblerARMv7.h:
b3/air/AirCode.cpp:

(JSC::B3::Air::Code::calleeSaveRegisterAtOffsetList const):
(JSC::B3::Air::Code::dump const):

b3/testb3_7.cpp:

(testInfiniteLoopDoesntCauseBadHoisting):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters): Deleted.

bytecode/ValueRecovery.h:

(JSC::ValueRecovery::calleeSaveGPRDisplacedInJSStack):
(JSC::ValueRecovery::calleeSaveRegDisplacedInJSStack): Deleted.

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::calleeSaveSlot):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::emitSave):
(JSC::AssemblyHelpers::emitRestore):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitSaveOrCopyLLIntBaselineCalleeSavesFor):

jit/CallFrameShuffleData.cpp:

(JSC::CallFrameShuffleData::setupCalleeSaveRegisters):

jit/CallFrameShuffler.h:

(JSC::CallFrameShuffler::snapshot const):

jit/CallFrameShuffler32_64.cpp:

(JSC::CallFrameShuffler::emitDisplace):

jit/FPRInfo.h:
jit/GPRInfo.h:
jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):

jit/RegisterAtOffsetList.h:

(JSC::RegisterAtOffsetList::registerCount const):
(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):
(JSC::RegisterAtOffsetList::adjustOffsets):
(JSC::RegisterAtOffsetList::size const): Deleted.
(JSC::RegisterAtOffsetList::at): Deleted.

jit/RegisterSet.cpp:

(JSC::RegisterSet::macroScratchRegisters):
(JSC::RegisterSet::vmCalleeSaveRegisters):

llint/LowLevelInterpreter.asm:
offlineasm/arm.rb:
wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Canonical link: https://commits.webkit.org/250952@main

4:05 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

3:42 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

3:41 AM Changeset in webkit [294793] by Adrian Perez de Castro

3 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/mse

Merge r294634 - REGRESSION(r290375) [GStreamer] Deadlock in WebProcess termination if AppendPipeline is started https://bugs.webkit.org/show_bug.cgi?id=240716

Patch by Olivier Blin <Olivier Blin> on 2022-05-23
Reviewed by Alicia Boya Garcia.

Since r290375, GStreamer ports are calling gst_deinit() at WebProcess
termination.

This is causing a deadlock if a MSE SourceBuffer has been instantiated.
That is because the GstTask from the appsrc element in the
AppendPipeline is still running.

To avoid the deadlock, stop the appsrc element in the AppendPipeline
when the SourceBuffer is removed from the MediaSource, since it will
not be useful anymore after being removed from its associated MediaSource.

The W3C spec of MediaSource.removeSourceBuffer mentions as a last step
that it should destroy all resources for sourceBuffer.

The MediaSource will be stopped at WebProcess termination, since
active DOM objects are stopped when detaching the frame.
This ensures that MediaSource is detached from its media element, and
that it removes its source buffers.

Drive-by fix: remove resetPipeline declaration, deleted in r238892

Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::stopParser):

Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):

Canonical link: https://commits.webkit.org/250860@main

2:54 AM Changeset in webkit [294792] by commit-queue@webkit.org

1 edit
6 deletes in trunk/Tools/buildstream/elements

[Flatpak SDK] Remove Subversion
https://bugs.webkit.org/show_bug.cgi?id=240903

Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Adrian Perez de Castro.

Tools/buildstream/elements/sdk-build-depends/swig.bst: Removed.
Tools/buildstream/elements/sdk-build-depends/utf8proc.bst: Removed.
Tools/buildstream/elements/sdk-platform.bst:
Tools/buildstream/elements/sdk/libsecret.bst: Removed.
Tools/buildstream/elements/sdk/libserf.bst: Removed.
Tools/buildstream/elements/sdk/perl-term-readkey.bst: Removed.
Tools/buildstream/elements/sdk/subversion.bst: Removed.

Canonical link: https://commits.webkit.org/250951@main

1:00 AM Changeset in webkit [294791] by commit-queue@webkit.org

2 edits
4 adds in trunk

[MSE][GStreamer] Support Google Dynamic Ad Insertion (DAI)
https://bugs.webkit.org/show_bug.cgi?id=216039
<rdar://problem/68638316>

Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Alicia Boya Garcia.

The specific "simple DAI" demo generates 2 AAC streams, with different tkhd track-id fields, we had
no layout test reproducing this use-case, so this patch provides one.

Test: media-source/media-source-audio-track-id-switch.html

LayoutTests/media/media-source/content/test-48kHz-new-track-id.m4a: Added.
LayoutTests/media/media-source/content/test-48khz-new-track-id-manifest.json: Added.
LayoutTests/media/media-source/media-source-audio-track-id-switch-expected.txt: Added.
LayoutTests/media/media-source/media-source-audio-track-id-switch.html: Added.
Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:

Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::Track::isLinked const):

Canonical link: https://commits.webkit.org/250950@main

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed