Timeline



Jun 7, 2002:

11:48 PM Changeset in webkit [1313] by darin
  • 11 edits in trunk
  • Makefile.am: Use new shared "embed.am" file so we don't need four copies of the embedding rules for WebFoundation, JavaScriptCore, WebCore, and WebKit.
5:53 PM Changeset in webkit [1312] by mjs
  • 6 edits in trunk/WebCore
  • Tests/libiftest/Makefile.am: Make libiftest a static lib, to avoid concerns over non-libtool libraries named .dylib.

WebCore:

  • Makefile.am: Rename libwebcore.dylib to libwebcore.a; since this target is just a fake for dependency purposes, it doesn't matter what it's called.
  • .cvsignore: Update ignorance.
4:04 PM Changeset in webkit [1311]
  • 2 copies
    38 deletes in branches/jaguar-branch

This commit was manufactured by cvs2svn to create branch
'jaguar-branch'.

4:04 PM Changeset in webkit [1310]
  • 1 copy
    39 deletes in tags/WebFoundation-6~4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~4'.

4:04 PM Changeset in webkit [1309]
  • 1 copy
    39 deletes in tags/WebFoundation-6~3

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~3'.

4:04 PM Changeset in webkit [1308]
  • 1 copy
    39 deletes in tags/WebFoundation-6~2

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~2'.

4:04 PM Changeset in webkit [1307]
  • 1 copy
    39 deletes in tags/WebFoundation-6~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~1'.

4:04 PM Changeset in webkit [1306]
  • 1 copy
    39 deletes in tags/WebFoundation-6_1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6_1'.

4:04 PM Changeset in webkit [1305]
  • 1 copy
    39 deletes in tags/WebFoundation-6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6'.

4:04 PM Changeset in webkit [1304]
  • 2 copies
    38 deletes in tags/JAGUAR_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'JAGUAR_BRANCH_ANCHOR'.

4:04 PM Changeset in webkit [1303] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2949680 (IFURLFileDatabase will not work properly with hard disk quotas)

Rearranges calls through to the code that expires files from the disk cache
when the quota is exceeded. Now, files are deleted before writing a new cache
entry, rather than writing the file first, and deleting files to get back under
the quota.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:])
3:59 PM Changeset in webkit [1302] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2948819 (Disk cache emptying can be cut off by quitting program)

We kick a thread to delete the disk cache (in order for the cache emptying
function to return immediately). This involves moving the disk cache
directory aside and creating a new (empty) disk cache directory. If a user
quits the apps before the aside directory is completely deleted, it is
orphaned.

This patch does a check upon next startup for such orphaned files and
resumes the delete operation.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open])
  • Misc.subproj/IFNSFileManagerExtensions.h:
  • Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_deleteBackgroundRemoveLeftoverFiles:])
3:58 PM Changeset in webkit [1301] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936755 (.size can get out of synch with actual cache size on disk)

Four separate fixes to make sure the .size file stays in sync with the
cumulative size of the cache files on disk.

These fixes are:

1) Check that usage decrease when a file is removed is only done when removal succeeds.
2) Account for a cache file that gets rewritten to disk with a different size

than the file it is replacing.

3) Remove pending disk operations when the user clears the cache.
4) Make sure usage gets set back to zero on a cache clear.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase writeSizeFile:]) (-[IFURLFileDatabase removeAllObjects]) (-[IFURLFileDatabase performSetObject:forKey:]) (-[IFURLFileDatabase performRemoveObjectForKey:])
3:48 PM Changeset in webkit [1300] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936676 (IFURLFileDatabase should be smarter about expiring cache files)

This patch adds code to generate a list of cache files sorted by file system
access time. This list is then used to expire least recently used cache
files first.

  • Database.subproj/IFURLFileDatabase.m: (compare_atimes): New function (IFPtrEqual): New function (IFFileAccessTimeRelease): New function (CreateArrayListingFilesSortedByAccessTime): New function (-[IFURLFileDatabase truncateToSizeLimit:]): Uses new functions
3:42 PM Changeset in webkit [1299] by darin
  • 18 edits in trunk/WebCore
  • Makefile.am: I was running into failures in the embed rule, so I made it always remove the framework before copying the new one in. This is better for cases where a header was removed, too, so maybe we should do this in the other directories.
  • kwq/KWQDrawUtil.mm:
  • kwq/KWQKComboBox.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKDebug.mm:
  • kwq/KWQKMessageBox.mm:
  • kwq/KWQKMimeType.mm:
  • kwq/KWQKPrinter.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQObject.mm:
  • kwq/KWQRegExp.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQScrollView.mm:
  • kwq/KWQStringList.mm: Remove repeated default values for parameters -- the new compiler won't allow these and they are illegal C++.
3:42 PM Changeset in webkit [1298] by darin
  • 3 edits in trunk/WebKit
  • MIME.subproj/IFContentHandler.m: (-[IFContentHandler HTMLDocument]): Fix a warning that shows up with the new C++ compiler (not sure why it is not showing up with the old one).
3:02 PM Changeset in webkit [1297] by cblu
  • 4 edits in trunk/WebKit

Allow plug-ins to make a NPP_*URLNotify request when
the target is _self, _top, _parent or _current. This goes
against the plug-in documentation, but mimics IE.
Need for iTools.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]):
2:23 PM Changeset in webkit [1296] by mjs
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by: Ken Kocienda

Fixed the following bugs:

Radar 2854498 - Cookies are not saved between sessions
Radar 2862120 - -[IFCookie dictionaryRepresentation] is not yet implemented
Radar 2949513 - Session-only cookies should not be saved persistently
Radar 2949514 - Cookies need to be synchronized between multiple processes

Also, I moved the optimistic first try code for creating
directories and files with intermediate directories from the call
points to the functions themselves.

  • CookieManager.subproj/IFCookie.h:
  • CookieManager.subproj/IFCookie.m: (setExpires): (-[IFCookie dictionaryRepresentation]): (+[IFCookie _requestHeadersFromCookieArray:]): (+[IFCookie _cookieArrayFromResponseHeaders:forURL:]): (-[IFCookie _compareForHeaderOrder:]): (-[IFCookie _key]): (-[IFCookie _isExpired]):
  • CookieManager.subproj/IFCookieManager.m: (-[IFCookieManagerPrivate init]): (-[IFCookieManagerPrivate dealloc]): (-[IFCookieManager _registerForCookiePreferenceNotification]): (-[IFCookieManager _connectToCookieStorage]): (setUpOnLoadThread): (runningOnLoadThread): (-[IFCookieManager _scheduleSetupOnLoadThread]): (-[IFCookieManager _waitForLoadThreadSetup]): (-[IFCookieManager _continueSetCookies:context:]): (-[IFCookieManager _internalInit]): (-[IFCookieManager _cookieRequestHeadersForURL:withExtraCookies:]): (-[IFCookieManager cookies]): (-[IFCookieManager setCookie:]): (-[IFCookieManager deleteCookie:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:]): (-[IFCookieManager description]):
  • CookieManager.subproj/IFCookiePrivate.h:
  • CookieManager.subproj/IFCookieStorage.h: Added.
  • CookieManager.subproj/IFCookieStorage.m: Added. (-[IFCookieStoragePrivate init]): (-[IFCookieStoragePrivate dealloc]): (-[IFCookieStorage _updateCookiesFromServer]): (-[IFCookieStorage _connectionDidDie:]): (-[IFCookieStorage _establishConnection]): (-[IFCookieStorage init]): (-[IFCookieStorage initWithNotificationObject:]): (-[IFCookieStorage dealloc]): (-[IFCookieStorage setCookies:]): (-[IFCookieStorage deleteCookies:]): (-[IFCookieStorage cookies]): (-[IFCookieStorage cookiesMatchingDomain:path:secure:]):
  • CookieManager.subproj/IFCookieStorageServer.h: Added.
  • CookieManager.subproj/IFCookieStorageServer.m: Added. (-[IFCookieStorageServerPrivate init]): (-[IFCookieStorageServerPrivate dealloc]): (-[IFCookieStorageServer _checkForCookieExpiration:]): (-[IFCookieStorageServer _updateExpirationTimer:]): (-[IFCookieStorageServer _saveCookies]): (-[IFCookieStorageServer _saveCookiesIfScheduled]): (-[IFCookieStorageServer _scheduleSave]): (-[IFCookieStorageServer _notifyChanged]): (-[IFCookieStorageServer _setCookiesWithoutSaving:]): (-[IFCookieStorageServer init]): (-[IFCookieStorageServer dealloc]): (-[IFCookieStorageServer setCookies:]): (-[IFCookieStorageServer deleteCookies:]): (-[IFCookieStorageServer cookies]): (makeCookie): (-[IFCookieStorageServer loadCookies]):
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase open]):
  • Misc.subproj/IFNSArrayExtensions.h:
  • Misc.subproj/IFNSArrayExtensions.m:
  • Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _IF_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]):
  • WebFoundation.pbproj/project.pbxproj:
1:02 PM Changeset in webkit [1295] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQPtrDictImpl.h: Use CoreFoundation.h -- new compiler is picky about the difference between struct and typedef.
  • kwq/KWQValueListImpl.h: Add a friend declaration that we need because the new compiler is more strict.
  • fix 2949882 -- joecartoon.com crashes
  • khtml/ecma/kjs_window.cpp: (Window::get): Turn off some code that doesn't work for us -- similar to code elsewhere in this file that was also turned off.
12:59 PM Changeset in webkit [1294] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.
12:59 PM Changeset in webkit [1293] by darin
  • 4 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.
12:49 PM Changeset in webkit [1292] by cblu
  • 60 edits
    9 adds
    4 deletes in trunk

Summary

Made IFWebController a class.
Fixed all places where IFWebController was referred to as a protocol.
Renamed IFBaseWebController files to IFWebController.
IFWebController.h replaces IFWebBaseController.h.

Added support for IEPL plug-ins.

WebCore:

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[URLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
  • kwq/external.h:

WebKit:

  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels _didStartLoadingURL:inController:]): (-[IFStandardPanels _didStopLoadingURL:inController:]):
  • Panels.subproj/IFStandardPanelsPrivate.h:
  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): (-[IFPlugin initWithPath:]): (-[IFPlugin load]): (-[IFPlugin description]):
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView webController]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFBaseWebController.h: Removed.
  • WebView.subproj/IFBaseWebController.mm: Removed.
  • WebView.subproj/IFBaseWebControllerPrivate.h: Removed.
  • WebView.subproj/IFBaseWebControllerPrivate.mm: Removed.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: Added. (-[IFWebController init]): (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController dealloc]): (-[IFWebController setDirectsAllLinksToSystemBrowser:]): (-[IFWebController directsAllLinksToSystemBrowser]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController setStatusText:forDataSource:]): (-[IFWebController statusTextForDataSource:]): (-[IFWebController openNewWindowWithURL:]): (-[IFWebController receivedProgress:forResource:fromDataSource:]): (-[IFWebController receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController provideLocationChangeHandlerForFrame:]): (-[IFWebController receivedPageTitle:forDataSource:]): (-[IFWebController serverRedirectTo:forDataSource:]): (-[IFWebController _frameForDataSource:fromFrame:]): (-[IFWebController frameForDataSource:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController frameNamed:]): (-[IFWebController mainFrame]): (-[IFWebController pluginNotFoundForMIMEType:pluginPageURL:]): (-[IFWebController provideLocationChangeHandlerForFrame:andURL:]): (-[IFWebController URLPolicyForURL:]): (-[IFWebController unableToImplementURLPolicyForURL:error:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): (-[IFWebController stopAnimatedImages]): (-[IFWebController startAnimatedImages]): (-[IFWebController stopAnimatedImageLooping]): (-[IFWebController startAnimatedImageLooping]):
  • WebView.subproj/IFWebControllerPrivate.h: Added.
  • WebView.subproj/IFWebControllerPrivate.mm: Added. (-[IFWebControllerPrivate init]): (-[IFWebControllerPrivate _clearControllerReferences:]): (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResource:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResource:fromDataSource:]): (-[IFWebController _receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _didStartLoading:]): (-[IFWebController _didStopLoading:]):
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource controller]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): (-[IFWebFrame controller]): (-[IFWebFrame setController:]): (-[IFWebFrame frameNamed:]):
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setController:]): (-[IFWebFrame _setController:]):
  • WebView.subproj/IFWebView.h:
  • WebView.subproj/IFWebView.mm: (-[IFWebView controller]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _setController:]):

WebBrowser:

  • BrowserDocument.h:
  • WebController.h:
  • WebController.m: (-[WebController openNewWindowWithURL:]):
12:13 PM Changeset in webkit [1291]
  • 3 copies
    1 delete in tags/Alexander-8

This commit was manufactured by cvs2svn to create tag 'Alexander-8'.

12:13 PM Changeset in webkit [1290] by sheridan
  • 5 edits in trunk

Alexander-8 version

12:03 PM Changeset in webkit [1289] by sheridan
  • 3 edits in trunk/JavaScriptCore

Alexander-8 version

8:56 AM Changeset in webkit [1288] by darin
  • 5 edits in trunk/WebCore

Try to make Jersey work again.

  • kwq/KWQInvisibleButton.h: Simplify includes.
  • kwq/KWQInvisibleButton.mm: Simplify includes.

Jun 6, 2002:

9:39 PM Changeset in webkit [1287] by darin
  • 9 edits in trunk
  • Makefile.am: Update warning flags for compatibility with new C++.
  • configure.in: Update warning flags for compatibility with new C++.
  • Tools/DiskCachePeek/DiskCachePeek.pbproj/project.pbxproj: Project Builder wants what it wants.

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebKit:

  • WebKit.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
  • WebCoreSupport.subproj/IFTextRenderer.m: (FillStyleWithAttributes): Remove workaround we copied from AppKit, because it's a workaround for a bug that was fixed in Puma.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
3:58 PM Changeset in webkit [1286] by cblu
  • 4 edits in trunk/WebKit

2002-06-06 Chris Blumenberg <​cblu@apple.com>

Added support for key codes and other encodings.
Send activate to make Java happy.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyMessageForEvent:]): added (-[IFPluginView keyUp:]): use above. (-[IFPluginView keyDown:]): use above. (-[IFPluginView windowBecameKey:]): send activate. (-[IFPluginView windowResignedKey:]): send activate.
11:55 AM Changeset in webkit [1285] by sullivan
  • 4 edits in trunk/WebKit

Previous commit didn't seem to take for some reason; trying again.

  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList removeChild:]): Added assert. (-[IFBookmarkList insertChild:atIndex:]): Set the group of the new child, and added assert.

Added Undo in the Bookmarks window for removing items and for changing
the titles and addresses of items. Also changed the image used for
Stop in the Bookmarks window per a conversation with Don and Chris
yesterday.

  • fixed 2927231 -- should be able to Undo deleting bookmarks
  • fixed 2948496 -- should be able to Undo title & address changes in Bookmarks window
  • BookmarksController.m: (-[UndoRemoveInfo initWithBookmark:]), (-[UndoRemoveInfo dealloc]), (+[UndoRemoveInfo infoWithBookmark:]): New little helper class that hangs onto the info needed to put removed bookmarks back in the right places.

(-[BookmarksController _redoRemoveBookmarks:]),
(-[BookmarksController _undoRemoveBookmarks:]): New methods
(-[BookmarksController removeSelectedBookmarks:]): Register for undo.

(-[BookmarksController _undoTitleChange:]),
(-[BookmarksController _changeTitleForBookmark:to:]),
(-[BookmarksController _undoAddressChange:]),
(-[BookmarksController _changeAddressForBookmark:to:]),
New methods used for undo/redo.

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
Register for Undo, but only if the value has actually changed.

(-[BookmarksController windowWillClose:]): Empty undo/redo stack.

  • Resources/Images/red_globe.tiff: Added, used by Stop in Downloads window.
  • Resources/Images/green_globe.tiff: Added, to be used by Resume in Downloads window.
  • Resources/Images/stop.tiff: Removed.
  • DownloadMonitor.m: (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use new Stop image.
  • WebBrowser.pbproj/project.pbxproj: Updated for new image files.
8:18 AM Changeset in webkit [1284] by darin
  • 9 edits in trunk/WebKit
  • MIME.subproj/IFContentHandler.m: (-[IFContentHandler initWithURL:MIMEType:MIMEHandlerType:]): Add call to [super init]. (-[IFContentHandler useTemplate:withGlobal:]): New helper function. Also got rid of <title> from templates, since there's no need for us to provide a fake title if it's just the URL. (-[IFContentHandler HTMLDocument]): Reduce use of copied and pasted code. (-[IFContentHandler dealloc]): Add call to [super dealloc].
  • Resources/image_document_template.html: Remove <title>.
  • Resources/plugin_document_template.html: Remove <title>.
  • Resources/text_document_template.html: Remove <title>.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Remove some unneeded type casts.

Jun 5, 2002:

5:45 PM Changeset in webkit [1283] by mjs
  • 6 edits in trunk/WebKit

Fixed Radar 2936155 - crash in IFAuthenticationPanel

  • Panels.subproj/IFAuthenticationPanel.m: (-[IFAuthenticationPanel runAsSheetOnWindow:withRequest:]): Add some assertions.

(-[IFAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
Avoid referencing instance variables after performing a selector
that might release this object. Also, add some assertions.

  • Panels.subproj/IFPanelAuthenticationHandler.m: (-[IFPanelAuthenticationHandler startAuthentication:]): Tweak whitespace.
5:33 PM Changeset in webkit [1282] by darin
  • 14 edits in trunk/WebCore

Some fixes to speed up the citibank.com page, and other related changes.

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Only do a layout if it's actually needed. This speeds things up immensely, and I'm pretty sure it's correct.
  • kwq/KWQListImpl.h: To speed things up, get rid of the "private part" level of indirection. This is particularly vital for list iterators, which are created and destroyed a lot on the stack. Also made trivial functions be inline.
  • kwq/KWQListImpl.mm: (copyList): Now a static function rather than a member of the now-defunct private class. (KWQListImpl::KWQListImpl): Set up all the new members that used to be in the separate private object. (KWQListImpl::~KWQListImpl): Update the iterator-detaching code to do it the new way, with intrusive list. Also, use clear() instead of having our own code to delete the list -- note this is only used after the level above us does a clear() anyway. (KWQListImpl::clear): Use a loop to delete all the nodes rather than making a delete of one node recursively delete the next -- iteration is more efficient, and also easier to understand in this case. Also update all the iterators so they don't point to deleted nodes. (KWQListImpl::containsRef): Update to return the count, rather than just a true or false value, since that's how the class is defined. (KWQListImpl::assign): Delete the items if asked to (fixes a FIXME). Also use a new swap member function since there's more to swap now. (KWQListImpl::addIterator): Rewrite to use an intrusive linked list. (KWQListImpl::removeIterator): Rewrite to use an intrusive linked list; this makes it much faster since it doesn't have to search the list. (KWQListImpl::swap): Implement this private member function used by assign. (KWQListIteratorImpl::KWQListIteratorImpl): Set up the new members that used to be in the separate private object.
  • kwq/qt/qlist.h: Re-add the operator= definition. This would cause a storage leak, although I haven't actually observed the leak.
  • kwq/qt/qbuffer.h: Initialize opened to false. This was causing a test failure.
  • kwq/KWQDictImpl.h:
  • kwq/KWQDictImpl.mm: Streamline implementation a bit by getting rid of unneeded copy constructor definition and making trivial constructor for iterator inline.
  • kwq/KWQPtrDictImpl.h: Remove unneeded include.
  • WebCore-tests.exp: Update for changes in the entry points used by the tests.
4:49 PM Changeset in webkit [1281] by rjw
  • 4 edits in trunk/WebKit

Fixed snafu in recursion over frame tree.

4:49 PM Changeset in webkit [1280] by rjw
  • 8 edits in trunk/WebCore

Fixed 2938552. This required an implementation of KHTMLPart::frames which
is used by the JS window.frames property.

2:22 PM Changeset in webkit [1279] by darin
  • 4 edits in trunk/JavaScriptCore

Fix problem seen as build failure on Jersey.

  • Makefile.am: JavaScriptCore-stamp needs to be a dependency, not a source file, because it doesn't have a corresponding object file. Making it a dependency causes things to compile in the right order.
2:14 PM Changeset in webkit [1278] by rjw
  • 8 edits in trunk/WebCore

Fixed window.top JS property (2939353). This caused funny recursion problems at www.megapixel.net and other pages that try to pop frames.

1:25 PM Changeset in webkit [1277] by rjw
  • 6 edits in trunk/WebCore

Cleaned up call to frameNamed:. Now use frame relative naming.
Fixed various frame related bugs (including www.heinz.com).

1:24 PM Changeset in webkit [1276] by rjw
  • 5 edits in trunk/WebKit

i Normalized frame naming. (We still don't support cross

window name lookups.)

Jun 4, 2002:

4:47 PM Changeset in webkit [1275] by rjw
  • 8 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::timerEvent): (KWQKHTMLPartImpl::redirectURL):

Renamed redirectJS to redirectURL to more correctly reflect it's
function.

(KWQKHTMLPartImpl::urlSelected):

Fixed 2935505. We now pop out of a frame if a link is clicked in a frame
and that frame is the only frame in a frameset. This emulates the behavior of IE.

  • kwq/KWQKHTMLPartImpl.h:
  • kwq/external.h:
4:27 PM Changeset in webkit [1274] by cblu
  • 11 edits in trunk/WebKit

WebBrowser:

Added the Downloads window!

  • AppController.h:
  • AppController.m: (-[AppController showReleaseNotes:]): no changes (-[AppController showDownloads:]): added for menu item
  • DownloadMonitor.h:
  • DownloadMonitor.m: Removed protocol conforming (-[DownloadMonitor init]): (+[DownloadMonitor sharedDownloadMonitor]): (-[DownloadMonitor windowDidLoad]): added (-[DownloadMonitor updateProgressUI]): added (-[DownloadMonitor _findEntryForDataSource:]): minor clean up (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:]): spawns progress timer (-[DownloadMonitor validateUserInterfaceItem:]): added (-[DownloadMonitor makeSelectedDownloadsPerformSelector:]): added (-[DownloadMonitor openSelectedDownloads:]): added (-[DownloadMonitor alwaysOpenSelectedDownloads:]): added (-[DownloadMonitor stopSelectedDownloads:]): added (-[DownloadMonitor revealSelectedDownloads:]): added (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): added (-[DownloadMonitor toolbarAllowedItemIdentifiers:]): added (-[DownloadMonitor toolbarDefaultItemIdentifiers:]): added
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: Made DownloadProgressEntry own the download entry subview (-[DownloadProgressEntry _initWithResource:progress:error:dataSource:]): (-[DownloadProgressEntry dealloc]): (-[DownloadProgressEntry URLStringResized:]): added (-[DownloadProgressEntry awakeFromNib]): added (-[DownloadProgressEntry updateProgressUI]): added (-[DownloadProgressEntry open]): added (-[DownloadProgressEntry alwaysOpen]): added (-[DownloadProgressEntry stop]): added (-[DownloadProgressEntry reveal]): added (-[DownloadProgressEntry view]): added
  • English.lproj/DownloadEntry.nib: Added.
  • English.lproj/Downloads.nib: Added.
  • English.lproj/MainMenu.nib: added Downloads to menu
  • ListView.h: Added.
  • ListView.m: Added. Simple class that appends views to each other. Implements selection. (-[ListView initWithFrame:]): (-[ListView dealloc]): (-[ListView drawRect:]): (-[ListView acceptsFirstResponder]): (-[ListView mouseDown:]): (-[ListView isFlipped]): (-[ListView isOpaque]): (-[ListView validateUserInterfaceItem:]): (-[ListView addViewToList:]): (-[ListView isSelectedView:]): (-[ListView setDelegate:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]): Better filename from URL algorithm
  • ResourceProgressEntry.h: Made error and statusString public
  • Resources/Images/always_open.tiff: Added.
  • Resources/Images/open.tiff: Added.
  • Resources/Images/reveal.tiff: Added.
  • Resources/Images/stop.tiff: Added.
  • WebBrowser.pbproj/project.pbxproj:

WebKit:

  • MIME.subproj/IFDownloadHandler.mm: Use public methods
  • WebView.subproj/IFWebDataSource.h: Made downloadPath public
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource downloadPath]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm:
3:49 PM Changeset in webkit [1273] by rjw
  • 10 edits in trunk

More exclusion for pre 6C48.

3:33 PM Changeset in webkit [1272] by darin
  • 9 edits in trunk/JavaScriptCore

Improve the speed of the JavaScript string append operation by growing
the capacity so we don't need to reallocate the string every time.

Also fix script execution so it doesn't use recursion to advance from
one statement to the next, using iteration instead.

  • Makefile.am: Stop using BUILT_SOURCES to build JavaScriptCore-stamp, because this causes the Project Builder project to build *before* the subdir. Intead, use an all-am rule in a way more similar to all our other directories.
  • kjs/grammar.y: Link the SourceElementsNode in the opposite direction, so we can walk the list and execute each element instead of using recursion to reverse the list.
  • kjs/grammar.cpp: Check in new generated file.
  • kjs/nodes.cpp: (SourceElementsNode::execute): (SourceElementsNode::processFuncDecl): (SourceElementsNode::processVarDecls): Use loops instead of recursion.
  • kjs/ustring.h: Don't initialize all UChar objects to 0. This was wasting a *huge* amount of time.
  • kjs/ustring.cpp: (UString::Rep::create): Add a "capacity" along with the length. (UString::append): Include 50% extra capacity when appending. (UString::operator=): Reuse the buffer if possible rather than always creating a new one.
3:16 PM Changeset in webkit [1271] by kocienda
  • 7 edits in trunk

2002-06-04 Kenneth Kocienda <​kocienda@apple.com>

  • WebCore/kwq/kwqdebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
  • WebFoundation/Misc.subproj/WebFoundationDebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
  • WebKit/Misc.subproj/WebKitDebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
3:06 PM Changeset in webkit [1270] by rjw
  • 4 edits in trunk/WebKit

Excluded call to new API until everyone has moved to >= 6C48.

12:17 PM Changeset in webkit [1269] by darin
  • 2 edits in trunk/WebKit

Fix stray chars in log.

11:55 AM Changeset in webkit [1268] by rjw
  • 21 edits in trunk

Changes to support progressive image loading. Currently disabled
until 2945218 is fixed.

11:03 AM Changeset in webkit [1267] by darin
  • 2 edits in trunk/WebKit

oops, forgot to save ChangeLog

11:02 AM Changeset in webkit [1266] by darin
  • 4 edits in trunk/WebKit
  • fixed 2932862 -- exception -[NSCFArray getObjects:range:]: index (137) beyond bounds (10)
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _stopPlugins]): (-[IFWebView _removeSubviews]): Make a copy of the subviews list so that changes to the list don't screw up the iterating logic.
10:34 AM Changeset in webkit [1265] by sullivan
  • 10 edits in trunk/WebKit

Made changes here while working on Undo for removing history entries.

  • History.subproj/IFWebHistory.h: New methods addEntries: and removeEntries:, deleted method removeEntriesForDay: (use removeEntries: instead).
  • History.subproj/IFWebHistory.m: (-[IFWebHistory addEntries:]), (-[IFWebHistory removeEntries:]): New methods, each takes an array of entries. Useful for doing multiple things at a time to minimize notifications. (-[IFWebHistory removeEntriesForDay:]): deleted this now-unnecessary method.
  • History.subproj/IFWebHistoryPrivate.h:
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntries:]): (-[IFWebHistoryPrivate removeAllEntries]): (-[IFWebHistoryPrivate addEntries:]): Private implementations for the public changes.
  • fixed 2867813 -- should be able to Undo deleting history entries.
  • fixed awkwardness where item in Bookmarks window would have its name selected for edit when you made a multiple selection.
  • GlobalHistory.h: added _performingUndoableAction ivar; removed removeAll.
  • GlobalHistory.m: (-[GlobalHistory receivedEntriesChangedNotification:]): if not _performingUndoableAction, throw away undo/redo stacks when change comes in.

(-[GlobalHistory windowWillClose:]):
Throw away undo/redo stacks when window closes, to minimize
memory use.

(-[GlobalHistory removeSelectedItems:]):
Collect up items to remove and then remove them in one batch;
register for undo with _undoRemoveEntries. No longer special-case
removeAll.

(-[GlobalHistory _undoRemoveEntries:]):
Restore items previously removed; register for undo with
_removeEntries (since we don't restore selection, for various
reasons to boring to go into here).

(-[GlobalHistory _removeEntries:]): Remove again items previously
restored; register for undo with _undoRemoveEntries.

(-[GlobalHistory selectAll:]): Removed obsolete comment.

  • OutlineViewPlus.m: (-[OutlineViewPlus mouseDown:]): Only edit the clicked cell if it's the only selected row.
10:19 AM Changeset in webkit [1264] by darin
  • 3 edits in trunk/WebKit
  • fixed 2943513 -- move StringTruncator into WebKit from WebBrowser so we don't need text measuring API exported
  • WebKit.pbproj/project.pbxproj: No longer export the text renderer headers as Private.
10:14 AM Changeset in webkit [1263] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Exported IFStringTruncator.h as Private.
10:09 AM Changeset in webkit [1262] by darin
  • 3 edits
    4 adds in trunk/WebKit

Moved the string truncator class here from WebBrowser so we don't have to
export our text machinery.

  • WebKit.pbproj/project.pbxproj:
  • Misc.subproj/IFStringTruncator.h: Added.
  • Misc.subproj/IFStringTruncator.m: Added.
9:47 AM Changeset in webkit [1261] by darin
  • 4 edits in trunk/WebCore
  • fixed 2943897 -- Initial uncached load of amazon.com renders partial page.
  • khtml/khtml_part.cpp: (KHTMLPart::setEncoding): Put the code that reloads the page when the encoding is changed back inside APPLE_CHANGES. This was causing partial loads because of how it interacts with our way of saving up text and not decoding until we discover what the encoding is.

Jun 3, 2002:

10:23 PM Changeset in webkit [1260] by darin
  • 10 edits
    2 deletes in trunk/WebCore
  • LICENSE: Add 2002.
  • kwq/KWQApplication.mm:
  • kwq/kdecore/kapplication.h:
  • kwq/qt/qapplication.h: Found a way to simplify the application objects by making more of the functions static so we don't need to actually allocate an object.
  • kwq/Makefile.am:
  • kwq/KWQKApplication.mm: Removed.
  • kwq/kdecore/kapp.h: Removed.
8:40 PM Changeset in webkit [1259] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): Remove the "fix" for the nonexistent storage leak. Richard showed me the error of my ways.
6:01 PM Changeset in webkit [1258] by darin
  • 4 edits
    3 deletes in trunk/WebCore

A few more unused things.

  • kwq/Makefile.am: Removed KWQKProcess.mm
  • kwq/KWQKProcess.mm: Removed.
  • kwq/KWQStrList.h: Removed.
  • kwq/kdecore/kprocess.h: Removed.
5:53 PM Changeset in webkit [1257] by darin
  • 3 edits
    2 adds in trunk/WebCore

Forgot one file.

  • kwq/qt/qframe.h: Added.
5:19 PM Changeset in webkit [1256] by darin
  • 163 edits
    2 adds
    4 deletes in trunk/WebCore
  • acconfig.h: Remove APPLE_CHANGES (done in compiler invocation), _KWQ_ (not needed any more), _KWQ_PEDANTIC_ (not needed any more), and _KWQ_IOSTREAM_ (set by KWQDef.h now).
  • configure.in: Remove explict gcc3 and g++3; not needed on Jaguar. Remove APPLE_CHANGES, _KWQ_, _KWQK_PEDANTIC_, and _KWQ_IOSTREAM_. Do an AC_SUBST on COMMON_CFLAGS so the flags are used to generate the .pfe files. Add conditional stuff so that WebCore exports less and the Tests subdirectory is not build in Deployment style builds.
  • Makefile.am: Only build Tests subdir when configure.in says it should.
  • Tests/draw/*: Removed.
  • Tests/qt/qbuffer-test.cpp: (main): Update for QBuffer changes.
  • Tests/qt/qrect-test.cpp: (main): Remove unused variable.
  • Tools/jersey/README: Fix newlines.
  • Tools/jersey/html/advanced.html: Fix newlines.

WebCore:

Get rid of many unneeded APPLE_CHANGES.
Also get rid of _KWQ_ and _KWQ_PEDANTIC_.

  • WebCore.exp: Don't export DomShared::ref/deref any more.
  • WebCore-tests.exp: Changed around as needed due to changes in the classes being tested.
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: Simplified APPLE_CHANGES for better merging.
  • khtml/dom/dom_misc.h:
  • khtml/dom/dom_misc.cpp:
  • khtml/dom/html_document.cpp:
  • khtml/khtmlview.cpp:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/misc/helper.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_text.cpp:
  • khtml/xml/xml_tokenizer.h:
  • kwq/qt/qtextedit.h: Remove now-unneeded APPLE_CHANGES.
  • khtml/misc/loader.cpp: (CachedImage::pixmap): Turned off more of the QMovie code.
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/xml/dom_elementimpl.h:
  • kwq/KWQKHTMLPart.mm: Formatting and other minor tweaks.
  • kwq/KWQApplication.mm: (QApplication::sendEvent): Implemented.
  • kwq/KWQChar.mm: (QChar::direction): Improved implementation.
  • kwq/KWQCollection.h: Removed.
  • kwq/KWQIcon.h: Removed.
  • kwq/Makefile.am: Removed following files.
  • kwq/KWQKCompletionBox.mm: Removed.
  • kwq/KWQKFactory.mm: Removed.
  • kwq/KWQListBox.mm: Removed.
  • kwq/KWQKImageIO.mm: Removed.
  • kwq/KWQObject.mm: (QObject::event): Added, does nothing. (QObject::inherits): Put in real implementation (good enough for us).
  • kwq/WCWebDataSource.h: Removed extern declaration of global.
  • kwq/KWQCursor.mm: (QCursor::handle): Made the handle be an NSCursor *.
  • kwq/external.h: Moved [IFWebView setFrameSize:] here. Got rid of IFAnimatedImage.
  • kwq/KWQDef.h: Remove unused Q_INT8, Q_INT16, Q_UINT8, Q_UINT16, QCOORD, WFlags, WId, ASSERT, CHECK_PTR, Q_EXPORT, Q_PACKED, QT_STATIC_CONST, QT_STATIC_CONST_IMPL. Define _KWQ_IOSTREAM_ only when NDEBUG is not defined.
  • kwq/KWQBuffer.mm:
  • kwq/KWQCString.mm:
  • kwq/KWQCollection.mm:
  • kwq/KWQCompletion.h:
  • kwq/KWQCompletion.mm:
  • kwq/KWQFrame.h:
  • kwq/KWQFrame.mm:
  • kwq/KWQHBox.mm:
  • kwq/KWQKFileItem.mm:
  • kwq/KWQKIconLoader.mm:
  • kwq/KWQKLineEdit.mm:
  • kwq/KWQKProtocolManager.mm:
  • kwq/KWQLabel.mm:
  • kwq/KWQListBox.h:
  • kwq/KWQMovie.mm:
  • kwq/KWQWidget.mm:
  • kwq/KWQxml.mm:
  • kwq/qt/qbuffer.h:
  • kwq/kdecore/kdebug.h:
  • kwq/kdecore/kglobal.h:
  • kwq/kdecore/kglobalsettings.h:
  • kwq/kdecore/kiconloader.h:
  • kwq/kdecore/kstaticdeleter.h:
  • kwq/kdecore/kstringhandler.h:
  • kwq/kdeui/kcombobox.h:
  • kwq/kdeui/kcompletionbox.h:
  • kwq/kdeui/klineedit.h:
  • kwq/kdeui/klistbox.h:
  • kwq/kdeui/kmessagebox.h:
  • kwq/kio/kfileitem.h:
  • kwq/kio/kimageio.h:
  • kwq/kio/kmimetype.h:
  • kwq/kio/kprotocolmanager.h:
  • kwq/kio/netaccess.h:
  • kwq/qt/qxml.h:
  • kwq/kparts/browserinterface.h:
  • kwq/kparts/factory.h:
  • kwq/kparts/part.h:
  • kwq/qt/qarray.h:
  • kwq/qt/qcollection.h:
  • kwq/qt/qcstring.h:
  • kwq/qt/qcursor.h:
  • kwq/qt/qdict.h:
  • kwq/qt/qhbox.h:
  • kwq/qt/qlabel.h:
  • kwq/qt/qlist.h:
  • kwq/qt/qmap.h:
  • kwq/qt/qmovie.h:
  • kwq/qt/qobject.h:
  • kwq/qt/qpaintdevicemetrics.h:
  • kwq/qt/qpainter.h:
  • kwq/qt/qpoint.h:
  • kwq/qt/qradiobutton.h:
  • kwq/qt/qrect.h:
  • kwq/qt/qregion.h:
  • kwq/qt/qscrollview.h:
  • kwq/qt/qsize.h:
  • kwq/qt/qstack.h:
  • kwq/qt/qstringlist.h:
  • kwq/qt/qtextedit.h:
  • kwq/qt/qvaluelist.h:
  • kwq/qt/qvector.h:
  • kwq/qt/qwidget.h:
  • kwq/qt/qxml.h: Removed unused stuff.
  • kwq/KWQListBox.mm:
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQPoint.mm:
  • kwq/KWQRadioButton.mm:
  • kwq/KWQRect.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollView.mm:
  • kwq/KWQSize.mm:
  • kwq/KWQStringList.mm:
  • kwq/KWQbrowserinterface.mm: Simplified.
  • kwq/kdecore/kurl.h: Added include to match what's expected by clients.
  • kwq/qt/qobjectlist.h: Added. Empty file to make includers happy.
  • kwq/khtml/khtml_printsettings.h: Added. Empty file.
  • kwq/qt/qobjectlist.h: Added. Empty file.
  • kwq/kio/kssl/ksslkeygen.h: Define just enough to make callers happy.
  • kwq/qt/qobject.h: Added event().
  • kwq/kparts/part.h: Added bool return type to event().
  • kwq/qt/qvector.h: Added QGVector base class.
2:35 PM Changeset in webkit [1255] by sullivan
  • 4 edits in trunk/WebKit

Richard told me which line to change to fix 2944237
(Stop item in View menu enabled on startup if you have
no home page.)

  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource isLoading]): Don't return YES if !_private->loading.
  • fixed 2943189 -- Single-click to edit in Bookmarks window should wait for double-click interval.
  • OutlineViewPlus.h: new _startEditTimerOnMouseUp instance variable
  • OutlineViewPlus.m: (-[OutlineViewPlus _cancelEditOnMouseUp]): clear _startEditTimerOnMouseUp as well as cancelling timer.

(-[OutlineViewPlus dragImageForRows:event:dragImageOffset:]):
clear _startEditTimerOnMouseUp variable.

(-[OutlineViewPlus mouseDown:]): Don't start timer until mouseUp,
since double-click interval is defined from mouseUp to mouseDown;
use _startEditTimerOnMouseUp variable beforehand so dragging can
cancel pending edit.

  • BrowserDocument.m: (-[BrowserDocument isLoading]): Tweaked this method while debugging another problem; liked the new formulation better.
Note: See TracTimeline for information about the timeline view.