Timeline



Jun 29, 2002:

10:31 PM Changeset in webkit [1477] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Fix calculation of oneTileRect. I think this is finally correct now.
4:28 PM Changeset in webkit [1476] by mjs
  • 26 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • kwq/WebCoreBridge.h: Add new calls needed for window size/position/feature getting and setting.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set properties on window after creating it using new bridge calls; make it visible.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Support scrollbars feature too.
  • kwq/kparts/browserextension.h: Include scrollbar setting stuff.

WebKit:

WebKit part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

Also, renamed IFScriptContextHandler protocol to IFWindowContext,
and made it a settable handler like the others rather than
something implemented by the controller, so it can be used w/o
subclassing.

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]): Forward to the WindowContext. (-[IFWebCoreBridge areToolbarsVisisble]): Likewise. (-[IFWebCoreBridge setToolbarsVisible:]): Likewise. (-[IFWebCoreBridge areScrollbarsVisible]): Likewise. (-[IFWebCoreBridge setScrollbarsVisible:]): Likewise. (-[IFWebCoreBridge isStatusBarVisisble]): Likewise. (-[IFWebCoreBridge setStatusBarVisible:]): Likewise. (-[IFWebCoreBridge setWindowFrame:]): Likewise. (-[IFWebCoreBridge window]): Likewise.
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController setWindowContext:]): Setter for new WindowContext handler (-[IFWebController windowContext]): Likewise.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release window context.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Open new windows via WindowContext.

WebBrowser:

WebBrowser part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • BrowserDocument.m: (-[BrowserDocument init]): Set the WebController as it's own WindowContext too.
  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow _saveFrameIfAllowed]): Don't save the frame if the last (-[BrowserWindow setFrameWithoutAutosaving:]): Change window size and position but without saving the frame; if this is a size change and not just a move, avoid saving the frame until the next user resize. (-[BrowserWindow windowDidResize:]): More stuff for the above. (-[BrowserWindow isFavoritesBarVisible]): Implemented. (-[BrowserWindow setFavoritesBarVisible:]): Implemented. (-[BrowserWindow isStatusBarVisible]): Implemented. (-[BrowserWindow setStatusBarVisible:]): Implemented. (-[BrowserWindow isToolbarVisible]): Implemented. (-[BrowserWindow setToolbarVisible:]): Implemented.
  • WebController.h:
  • WebController.m: (-[BrowserWebController openNewWindowWithURL:]): Don't initially show the window even if no URL is set, so initial parameters can be set properly. (-[BrowserWebController areToolbarsVisible]): Implemented. (-[BrowserWebController setToolbarsVisible:]): Implemented. (-[BrowserWebController isStatusBarVisible]): Implemented. (-[BrowserWebController setStatusBarVisible:]): Implemented. (-[BrowserWebController window]): Implemented. (-[BrowserWebController setFrame:]): Implemented.

Jun 28, 2002:

4:53 PM Changeset in webkit [1475] by darin
  • 6 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.h: Renamed statusOfCache to patternColorLoadStatus for clarity.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer copyWithZone:]): Add FIXME. (-[IFImageRenderer tileInRect:fromPoint:]): Add optimization for the case where a single draw of the image will cover the entire area to be tiled. Also add comments and make other small improvements.
3:32 PM Changeset in webkit [1474]
  • 2 copies
    34 deletes in tags/WebFoundation-6~8

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~8'.

3:32 PM Changeset in webkit [1473]
  • 2 copies
    34 deletes in tags/WebFoundation-6~7

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~7'.

3:32 PM Changeset in webkit [1472]
  • 2 copies
    34 deletes in tags/WebFoundation-6~6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~6'.

3:32 PM Changeset in webkit [1471]
  • 2 copies
    34 deletes in tags/WebFoundation-6~5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~5'.

3:32 PM Changeset in webkit [1470] by kocienda
  • 1 edit in branches/jaguar-branch/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-28 Kenneth Kocienda <​kocienda@apple.com>

Fix for these two bugs:

  1. Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

  1. Radar 2968370 (Crash in Pictures channel)

I fixed the fact that load failure messages were not being moved over to
the one thread that can safely call into CFNetwork.

In the process of doing this, I cleaned up this internal interface:

-(void)_backgroundLoadFailedWithResultCode:(IFURLHandleResult)errorCode inDomain:(IFErrorCodeDomain)domain isTerminal:(BOOL)terminal;

is now:

-(void)_backgroundLoadFailedWithError:(IFError *)error;

  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithError:])
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
  • CacheLoader.subproj/IFURLHandlePrivate.h:
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (initLoader) (-[IFURLLoad setError:]) (-[IFURLLoad performFailed]) (_handleLoadRequests) (_loadSweeper)
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc])
  • WebFoundation.pbproj/project.pbxproj
2:13 PM Changeset in webkit [1469] by rjw
  • 16 edits in trunk

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • khtml/rendering/font.cpp: (Font::floatWidth): (Font::floatCharacterWidth):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):
  • kwq/WebCoreTextRenderer.h:
  • kwq/qt/qfontmetrics.h:

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Cleaned up use of loadStatus.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
1:20 PM Changeset in webkit [1468] by cblu
  • 10 edits in trunk/WebKit

WebBrowser:

Bugs fixes for Downloads

  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): init totals ivars (-[DownloadMonitor _findEntryForView:]): added (-[DownloadMonitor _makeSelectedDownloadsPerformSelector:]): prepended a "_" (-[DownloadMonitor sheetDidDismiss:returnCode:contextInfo:]): cancel downloads before quit (-[DownloadMonitor _updateTotals]): added, updates totals ivars (-[DownloadMonitor validateUserInterfaceItem:]): simplified, reveal allowed only for 1 item (-[DownloadMonitor didDoubleClick]): added, calls reveal (-[DownloadMonitor openSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor stopSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor revealSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): only stops active downloads (-[DownloadProgressEntry reveal]): allowed for items currently downloading
  • ListView.m: (-[ListView mouseDown:]): watch for double-click

WebKit:

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient downloadHandler]): added (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): removed [downloadHandler cancel]
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource stopLoading]): call [downloadHandler cancel] here so clean up is done immediately.

Jun 27, 2002:

5:07 PM Changeset in webkit [1467] by cblu
  • 4 edits in trunk/WebCore

Added an APPLE_CHANGES to fix 2894742. The attributes of an EMBED tag
must override the attributes of PARAM tags.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
4:25 PM Changeset in webkit [1466] by rjw
  • 6 edits in trunk/WebKit

Fixed tiling of progressively loaded images.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): (-[IFImageRenderer loadStatus]): (-[IFImageRenderer tileInRect:fromPoint:]):
4:09 PM Changeset in webkit [1465] by rjw
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Fixed uninitialized variable warning. Compile being too aggressive, broke deployment build.
2:59 PM Changeset in webkit [1464] by cblu
  • 4 edits in trunk/WebKit

Fixed plug-in positioning.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView

initWithFrame:plugin:url:baseURL:mime:arguments:]): added some logging.

(-[IFPluginView setWindow]): Use the window's content view as the

guide for the port's coordinates. Also added a workaround for Java.

2:39 PM Changeset in webkit [1463] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-27 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]):
2:05 PM Changeset in webkit [1462] by darin
  • 5 edits in trunk/WebKit

Fixed DOM tree viewer.

  • WebView.subproj/IFDOMNode.mm: (-[IFDOMNode initWithDOMNode:DOM::]): A typo got in here somehow, leading to an infinite loop.
2:01 PM Changeset in webkit [1461] by darin
  • 4 edits in trunk/WebCore
  • fixed 2973342 -- copied text seems to have an extra blank line between paragraphs
  • khtml/khtml_part.cpp: (KHTMLPart::selectedText): Get rid of code that was adding an extraneous newline at the ends of various types of nodes, including <P>.
1:22 PM Changeset in webkit [1460] by darin
  • 4 edits
    2 deletes in trunk/WebKit
  • fixed 2973212 -- bad arg string != nil in _IF_URLWithString
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Get rid of essentially-dead code that computed but did not use a URL. Also order operations so that we first set the flag to say that we're loading, then tell the location change handler, and only then ask for the actual I/O to being.
  • WebView.subproj/IFBaseLocationChangeHandler.h: Removed.
  • WebView.subproj/IFBaseLocationChangeHandler.m: Removed.
1:19 PM Changeset in webkit [1459] by darin
  • 10 edits in trunk/WebCore

Fix Java. My changes this morning broke it.

  • khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Re-add required APPLE_CHANGES. Pass arguments to KJavaAppletWidget::processArguments.
  • kwq/khtml/java/kjavaappletwidget.h: Added KJavaAppletWidget::processArguments.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::processArguments): Added.

Some QFont fixes.

  • kwq/qt/qfont.h: Remove unused setPixelSizeFloat.
  • kwq/KWQFont.mm: Change to keep family names in a set. Since there are only a small number of family names ever encountered, this is a bit of a memory win. (QFont::QFont): Don't retain the family name. (QFont::~QFont): Don't release the family name. (QFont::setFamily): Put the family name in a set, and use the one from the set. (QFont::operator=): Don't retain or release. (QFont::operator==): Use == to compare the name.
12:28 PM Changeset in webkit [1458]
  • 3 copies in tags/Alexander-10

This commit was manufactured by cvs2svn to create tag 'Alexander-10'.

12:28 PM Changeset in webkit [1457] by sheridan
  • 8 edits in trunk

Alex-10 version

11:14 AM Changeset in webkit [1456] by rjw
  • 12 edits in trunk

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint().

  • kwq/WebCoreTextRenderer.h:

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint(). Stubbed
only, no support for new parameters yet.

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]): (-[IFTextRenderer widthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
9:29 AM Changeset in webkit [1455] by rjw
  • 9 edits in trunk

Removed old methods and references.

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): Fixed final fragment rendering glitch.

Removed calls to old method.

  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h: Removed old methods.
9:17 AM Changeset in webkit [1454] by darin
  • 23 edits in trunk

WebCore:

  • khtml/rendering/render_applet.cpp: Remove include of <iostream.h> to avoid bloat. (RenderApplet::RenderApplet): Remove APPLE_CHANGES. (RenderApplet::processArguments): Remove APPLE_CHANGES. This file is now back to 100% the same as the KDE original.
  • kwq/khtml/java/kjavaappletwidget.h: Added a bit of stuff so we match the interface of the KDE original and don't need APPLE_CHANGES.
  • kwq/KWQKJavaAppletWidget.mm: Remove include of <iostream.h> to avoid bloat. (KJavaAppletWidget::KJavaAppletWidget): Update for parameters that match the KDE original. (KJavaAppletWidget::~KJavaAppletWidget): Added. (KJavaAppletWidget::setBaseURL): Added. (KJavaAppletWidget::setParameter): Put strings into an NSMutableDictionary. (KJavaAppletWidget::showApplet): Use the new baseURL and parameters dictionary.
  • kwq/WebCoreViewFactory.h: Add baseURL parameter.
  • kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Add baseURL parameter.
  • kwq/kdecore/kurl.h: Fix NSURL definition to fit idiom.
  • kwq/qt/qmap.h: Added the const version of the [] operator.
  • khtml/ecma/kjs_navigator.cpp: Tweak whitespace.
  • khtml/html/html_documentimpl.cpp: Tweak to make it a little closer to original.
  • kwq/KWQKCookieJar.h: Reduce includes.
  • kwq/KWQKCookieJar.mm: Move includes in here.
  • kwq/WebCoreCookieAdapter.h: Fix comment that emacs munged.

WebKit:

  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Pass baseURL as a separate parameter.
  • WebView.subproj/IFBaseLocationChangeHandler.m: Fix a typo. I think this file might be unneeded, but I won't delete it until I hear from Chris.
8:54 AM Changeset in webkit [1453] by rjw
  • 4 edits in trunk/WebKit

Fix selection in 'slow' code path (non-base characters and font substitution).

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]):
8:25 AM Changeset in webkit [1452] by rjw
  • 4 edits in trunk/WebKit

Implemented auto scrolling.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseDragged:]):
8:20 AM Changeset in webkit [1451] by rjw
  • 9 edits in trunk

Implement selectAll.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView selectAll:]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectAll]): Select all using the part.
6:52 AM Changeset in webkit [1450] by rjw
  • 2 edits in trunk/WebKit

Forgot to commit ChangeLog.

2:42 AM Changeset in webkit [1449] by mjs
  • 12 edits
    8 adds in trunk

WebCore:

WebCore part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

  • kwq/KWQKCookieJar.h: Added.
  • kwq/KWQKCookieJar.mm: Added. (KWQKCookieJar::cookie): C++ veneer over WebCoreCookieAdapter call. (KWQKCookieJar::setCookie): Likewise. (KWQKCookieJar::cookieEnabled): Likewise.
  • kwq/Makefile.am: Add new files to build.
  • kwq/WebCoreCookieAdapter.h: Added.
  • kwq/WebCoreCookieAdapter.m: Added. (+[WebCoreCookieAdapter sharedAdapter]): Method to return shared instance, al la the WebCoreFactory classes. (-[WebCoreCookieAdapter init]): Establish self as shared instance. (-[WebCoreCookieAdapter cookiesEnabled]): No-op implementation. (-[WebCoreCookieAdapter cookiesForURL:]): Likewise. (-[WebCoreCookieAdapter setCookies:forURL:]): Likewise.
  • WebCore.exp: Export WebCoreCookieAdapter class.
  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Call appropriate KWQCookieJar method.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::cookie): Call appropriate KWQCookieJar method. (HTMLDocumentImpl::setCookie): Likewise

WebKit:

WebKit part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

  • WebCoreSupport.subproj/IFCookieAdapter.h: Added.
  • WebCoreSupport.subproj/IFCookieAdapter.m: Added. (+[IFCookieAdapter createSharedAdapter]): Set up an instance of IFCookieAdapter as the WebCoreCookieAdapter shared instance. (-[IFCookieAdapter cookiesEnabled]): Implement in terms of WebFoundation stuff. (-[IFCookieAdapter cookiesForURL:]): Likewise. (-[IFCookieAdapter setCookies:forURL:]): Likewise.
  • WebKit.pbproj/project.pbxproj: Add new files to build.
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Hook up the cookie adapter just like the various factory classes.
12:29 AM Changeset in webkit [1448] by cblu
  • 15 edits in trunk

WebCore:

Fix to support sending PARAM tags to the Java plug-in.

  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): removed APPLE_CHANGES (RenderApplet::layout): removed APPLE_CHANGES
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): removed setView (KJavaAppletWidget::showApplet): call setView here
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed
  • kwq/khtml/java/kjavaappletwidget.h: added KJavaApplet

WebKit:

Support for Java.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): set DOCBASE argument
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed

WebBrowser:

Removed some logging.

  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):

Jun 26, 2002:

9:42 PM Changeset in webkit [1447] by rjw
  • 14 edits in trunk

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases. Still need to work on
TextSlave::checkSelectionPoint. Fixed redraw region
problems.

khtml redraw the entire visible region when selection changes.
This could be optimzed.

  • khtml/rendering/font.cpp: (Font::drawText): (Font::width):
  • khtml/rendering/render_text.cpp: (TextSlave::printSelection):
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::selectedTextBackgroundColor):
  • kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
  • kwq/WebCoreTextRenderer.h:
  • kwq/qt/qpainter.h:

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases.

Still need to work on:

  1. 'slow' drawing cases, i.e. runs with non-base characters

or runs requiring font substitution.

  1. Select All menu item.
  2. Auto scrolling.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:]): (-[IFTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]):
3:47 PM Changeset in webkit [1446] by darin
  • 4 edits in trunk/WebKit
  • fixed 2969280 -- if trailing / not specified for site, relative URLs are incorrectly expanded
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Update the URL for the case where we've already been redirected before we receive any data.
3:14 PM Changeset in webkit [1445] by mjs
  • 8 edits in trunk/WebCore

Implement KHTMLPart::findFrame() to fix the following Radar bugs:

Radar 2943177 - infinite JavaScript loop sfcu.org online bill paying
Radar 2950580 - Unknown JavaScript properties on the Window object return self instead

of Undefined

  • khtml/khtml_part.cpp: (KHTMLPart::findFrame):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::findFrame):
  • kwq/KWQKHTMLPartImpl.h:
3:03 PM Changeset in webkit [1444] by darin
  • 10 edits in trunk/WebKit
  • fixed 2971532 -- crash with null KHTMLView at gramicci.com
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView reapplyStyles]): Handle widget == 0 case. (-[IFHTMLView layout]): Handle widget == 0 case.

Fixed a crash I have seen many times where a data source tries
to use its parent to locate the controller after its parent is
deallocated.

  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Use _parentDataSourceWillBeDeallocated instead of _setController:nil.
  • WebView.subproj/IFWebFramePrivate.h: Add _parentDataSourceWillBeDeallocated.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _parentDataSourceWillBeDeallocated]): Does both a _setController:nil, and a _setParent:nil on both data sources.
1:44 PM Changeset in webkit [1443] by sullivan
  • 5 edits in trunk/WebKit
  • fixed 2971024 -- wrong item is bookmarked

-[IFWebDataSource redirectedURL] was returning the URL of a
sub-page resource.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Removed evil call to _setFinalURL here. It had no right to live.
12:35 PM Changeset in webkit [1442] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]): Fix NSBitmapImageRep leak.
12:01 PM Changeset in webkit [1441] by darin
  • 5 edits in trunk/WebCore
  • fixed 2969378 -- "A with hat" characters (Unicode 00C2) showing up at Zingermans.com
  • kwq/KWQCharsets.mm: (buildDictionaries): Put UTF-16 in the dictionary, but pointing at the string encoding for UTF-8. This mimics what Internet Explorer does.
  • kwq/KWQtextcodec.mm: (QTextCodec::fromUnicode): Fix implementation so it will convert the specified encoding instead of always Latin-1.
11:53 AM Changeset in webkit [1440] by cblu
  • 10 edits in trunk/WebKit

WebKit:

  • added "complete" to progress methods to indicate last progress message
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): added a draw test
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

WebBrowser:

  • added "complete" to progress methods to indicate last progress message
  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):
  • WebController.m: (-[WebController receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]):
10:53 AM Changeset in webkit [1439] by rjw
  • 8 edits in trunk/WebKit

Fixed recursion problems. +[NSFont findFontLike:forString:withRange:inLanguage:]
will alternate between suggested fonts with bogus answers. The work
around involves adding an explicit flag indicating whether or not
font substitution should be attempted.

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:attemptFontSubstitution:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]):
9:40 AM Changeset in webkit [1438] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateUserInterfaceItem:]): Switch to this instead of validateMenuItem: so that a Copy toolbar button would work.
9:16 AM Changeset in webkit [1437] by darin
  • 8 edits in trunk/WebCore

Fixed (or at least worked around) a crash I saw where KWQKHTMLPartImpl::end was
making calls after the KHTMLView was gone. This is specific to our APPLE_CHANGES
code; it's handled differently in KDE.

  • khtml/khtml_part.h: Added detachView.
  • khtml/khtml_part.cpp: (KHTMLPart::detachView): Added. Nils out the view pointer.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Call m_part->detachView().
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::end): Don't try to make calls to the view if it's nil.

Jun 25, 2002:

7:50 PM Changeset in webkit [1436] by rjw
  • 8 edits in trunk/WebKit

Disable the copy menu item when IFHTMLView is key
and has no selection.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateMenuItem:]): Disable menu if selection is empty. (-[IFHTMLView copy:]): Factored code that gets the bridge.
  • WebView.subproj/IFHTMLViewPrivate.h: Added _bridge.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _bridge]): We need to access the bridge from the view to get the part's selection.
7:26 PM Changeset in webkit [1435] by rjw
  • 8 edits in trunk/WebCore

Support for khtml style selection drawing. Ugly,
we'll want to make this more Mac like.

  • khtml/rendering/font.cpp: (Font::drawText):

Enable khtml code path. Removed APPLE_CHANGES

  • kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth):

Implemented in terms of width().

  • kwq/KWQPainter.mm: (QPainter::drawText):

Implemented.

  • kwq/qt/qfontmetrics.h:

Added QFontMetrics::charWidth.

4:32 PM Changeset in webkit [1434] by cblu
  • 4 edits in trunk/WebKit

Remove downloaded file if cancelled.

  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler cancel]):
3:16 PM Changeset in webkit [1433] by rjw
  • 16 edits in trunk

Support for rudimentary plain text 'copy'.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView copy:]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _controller]):

Support for rudimentary plain text 'copy'.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]):
1:18 PM Changeset in webkit [1432] by rjw
  • 13 edits in trunk

Enabled progressive image loading code.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]):

Enabled progressive image loading code.

  • khtml/misc/loader.cpp: (CachedImage::data):
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
11:56 AM Changeset in webkit [1431] by rjw
  • 4 edits in trunk/WebKit

Extended our text measurement rounding work-around for integer-float
mismatch to round on word boundaries as well as spaces.

10:38 AM Changeset in webkit [1430] by darin
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Don't remove the URL handle from the data source until we've finished the loading process in KDE code. This may fix 2968527.
  • WebCoreSupport.subproj/IFTextRenderer.m: Keep around commented printfs so I can do the "dump all strings as they are rendered" again.
  • WebKit.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:31 AM Changeset in webkit [1429] by darin
  • 4 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:30 AM Changeset in webkit [1428] by darin
  • 26 edits in trunk/WebCore

Removed remaining uses of BORROWED defines.
Made some simplifications and formatting fixes. All safe.

  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQChar.mm:
  • kwq/KWQCharsets.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQListImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQString.mm:
  • kwq/KWQValueListImpl.mm:
  • kwq/KWQVectorImpl.h:
  • kwq/KWQtextcodec.mm:
  • kwq/make-charset-table.pl:
  • kwq/make-mac-encodings.c:
  • kwq/qt/qfile.h:
  • kwq/qt/qregexp.h:
  • kwq/qt/qtextcodec.h:
  • WebCore-tests.exp: Small change to exports for the array test.
7:30 AM Changeset in webkit [1427] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Remove stray NSLog.
12:33 AM Changeset in webkit [1426] by darin
  • 6 edits in trunk/WebKit
  • fixed 2968298 -- IFImageRenderer crash at download.com
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): Override this instead of [init]. This is the designated initializer and all the others call this. (-[IFImageRenderer copyWithZone:]): Override to nil out fields that can't be shared by the copy.

Fix leaks.

  • History.subproj/IFURIEntry.m: (-[IFURIEntry initWithURL:title:image:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry dealloc]): Release _displayTitle. Fixes a leak. (-[IFURIEntry setTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry setDisplayTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry initFromDictionaryRepresentation:]): Lose the extra retain for _lastVisitedDate. Fixes a leak.
Note: See TracTimeline for information about the timeline view.