Timeline



Aug 10, 2002:

5:31 PM Changeset in webkit [1796]
  • 3 copies in tags/Alexander-17

This commit was manufactured by cvs2svn to create tag 'Alexander-17'.

5:31 PM Changeset in webkit [1795] by kocienda
  • 8 edits in trunk

Rolled version number to Alex-17

11:28 AM Changeset in webkit [1794] by kocienda
  • 4 edits in trunk/WebCore

Check box in target setting panel to enable prebinding.

  • WebCore.pbproj/project.pbxproj
11:24 AM Changeset in webkit [1793] by kocienda
  • 18 edits in trunk

WebFoundation:

Added a new constant WebResourceHandleUseCachedObjectIfPresent.
This constant is used during reload so that a cached object
is returned regardless of its expiration.

  • CacheLoader.subproj/WebCacheLoaderConstants.h: Added constant.
  • CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m: (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Added check for new WebResourceHandleUseCachedObjectIfPresent constant.
  • CacheLoader.subproj/WebResourceLoad.m:

Also added a change to improve the percentage of cache hits:

(-[WebResourceLoad succeeded]): Use originalURL for caching. This will mean that
the cache is checked for what the user typed in, or has in their bookmarks. This
improves cache hits quite a bit.

WebCore:

Added an extra function which checks with WebKit to see if
the load is a reload. If it is, the WebCore cache is bypassed.

  • khtml/misc/loader.cpp: (DocLoader::requestImage): Added acall to new KWQCheckIfReloading function. (DocLoader::requestStyleSheet): Ditto. (DocLoader::requestScript): Ditto.
  • kwq/KWQLoaderImpl.h:
  • kwq/KWQLoaderImpl.mm: (KWQCheckIfReloading): New function which checks with WebKit to see if the load is a reload.
  • kwq/WebCoreBridge.h:

WebKit:

Added support for "stale mode" (loads triggered by use of back/forward), and
added support for reload.

Also added a bridge function so the WebCore cache can tell if a load is a reload.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceIsReloading]): New method.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Use same flags that were used for main resource load.
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource attributes]): New accessor. (-[WebDataSource flags]): New accessor.
  • WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Reload adds WebResourceHandleFlagLoadFromOrigin flag to load.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Adds flags so that WebFoundation can tell when back/forward has been used.

WebBrowser:

Fix for this bug:

Radar 2870727 ("Refresh" in Alexander doesn't bypass cache)

  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): Removed code that prevented the call through to reload from being called, now that I have hooked up the code so that reload is handled properly.

Aug 9, 2002:

9:32 PM Changeset in webkit [1792] by darin
  • 3 edits in trunk/JavaScriptCore

Some string speedups. Makes sony.com cached 11% faster on Development, but
the improvement for Deployment should be greater.

9:31 PM Changeset in webkit [1791] by darin
  • 13 edits in trunk

JavaScriptCore:

Some string speedups. Makes sony.com cached 11% faster.

  • kjs/ustring.h: Made it possible for UChar objects to be uninitialized, which gives a speed boost. Inlined CString's +=, UString's destructor, +=, and +.
  • kjs/ustring.cpp: (UString::UString): Optimize const char * version, which showed up heavily in performance analysis. Added new two-UString version, which makes the + operator fast. (UString::ascii): Remove thread safety changes. Change static buffer to remember its size, and to always be at least 4096 bytes long; that way we never have to reallocate unless it's for a long string. Also make code to extract the characters significantly faster by getting rid of two pointer dereferences per character. (UString::is8Bit): Avoid one pointer dereference per character. (UString::toDouble): Use ascii() instead of cstring() to avoid copying the string.
  • kjs/collector.cpp: Remove unneeded APPLE_CHANGES.
  • kjs/regexp.cpp: Remove ifdefs around some APPLE_CHANGES that we want to keep, because they just fix warnings.
  • kjs/value.h: Remove obsolete APPLE_CHANGES comment.
  • JavaScriptCore.pbproj/project.pbxproj: Project Builder decided to move a line around in the file.

WebCore:

  • force-clean-timestamp: JavaScriptCore headers changed that require a full build here.
5:04 PM Changeset in webkit [1790] by mjs
  • 4 edits in trunk/JavaScriptCore

Fix my last change to actually call the versions of the lock functions
that are recursive and initialize as needed.

  • kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::evaluate):
4:24 PM Changeset in webkit [1789] by mjs
  • 7 edits in trunk/JavaScriptCore
  • fixed 2948835 - JavaScriptCore locking is too fine grained, makes it too slow
  • kjs/collector.cpp: (Collector::allocate): (Collector::collect): (Collector::finalCheck): (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects):
  • kjs/collector.h:
  • kjs/internal.cpp: (initializeInterpreterLock): (lockInterpreter): (unlockInterpreter): (Parser::parse): (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::evaluate):
  • kjs/value.cpp: (ValueImp::ValueImp): (ValueImp::setGcAllowed):
4:12 PM Changeset in webkit [1788] by darin
  • 9 edits in trunk/WebCore
  • fixed 3018063 -- frame problems at directory.apple.com
  • fixed 3021484 -- Go to "xxxx" mouseover status message should not show ".."

Basically, we had no frame targeting for forms. I made the form code share
the same frame targeting code we use for clicking on URLs.

  • khtml/khtml_part.cpp: (KHTMLPart::openURLInFrame): Don't compile this function at all any more.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Call the impl's openURLRequest instead of calling the part's openURLInFrame. Clearer.
  • kwq/KWQKHTMLPartImpl.h: Remove openURLInFrame, add openURLRequest. Change urlSelected args parameter to a const reference. Add private getBridgeForFrameName helper function.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::getBridgeForFrameName): Moved rules for choosing a frame here from urlSelected so they can be shared. (KWQKHTMLPartImpl::openURLRequest): Use getBridgeForFrameName instead of having our own different code for finding the right frame. (KWQKHTMLPartImpl::urlSelected): Move frame choosing code into getBridgeForFrameName. (KWQKHTMLPartImpl::submitForm): Use getBridgeForFrameName instead of always ignoring the target and using our own frame. (KWQKHTMLPartImpl::overURL): Take base targeting into account when making the status bar messages, and use the completed URL, not the partial, for the message.
2:23 PM Changeset in webkit [1787] by darin
  • 5 edits in trunk/WebCore
  • fixed 2945441 -- base target is ignored
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Add code to respect the base target in the document. It would be way better to use more of the KHTML code instead of copying it a line at a time into KWQ -- that can come later when the fire drill is over.
11:01 AM Changeset in webkit [1786]
  • 3 copies in tags/Alexander-16

This commit was manufactured by cvs2svn to create tag 'Alexander-16'.

11:01 AM Changeset in webkit [1785] by sheridan
  • 8 edits in trunk

Alex-16 versioning

9:10 AM Changeset in webkit [1784] by darin
  • 4 edits in trunk/WebCore
  • fixed 3020594 -- crash in KWQKHTMLPartImpl::end() visiting particular page
  • khtml/khtml_part.cpp: (KHTMLPart::end): Our hacked alternative to a signal requires a NULL check.
12:25 AM Changeset in webkit [1783] by cblu
  • 5 edits in trunk/WebKit

%5 gain on cvs-static related to loading page icons:

WebKit:

  • Cache icon image for HTML files
  • resize the icon only in WebIconLoader instead of in multiple places elsewhere
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (+[WebIconLoader _resizeImage:]): (+[WebIconLoader defaultIcon]): call _resizeImage (+[WebIconLoader iconForFileAtPath:]): added, caches html icon (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): call _resizeImage
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): call iconForFileAtPath

WebBrowser:

  • resize the page icon in WebIconLoader instead of in multiple places elsewhere
  • call resetNoDragRect less often
  • LocationTextField.h:
  • LocationTextField.m: (-[LocationTextField _setIcon:save:]): no need to resize
  • TitleBarButton.m: (-[TitleBarButton setImage:]): no need to resize (-[TitleBarButton resetNoDragRect]): renamed (-[TitleBarButton updateFrame]): no need to call resetNoDragRect (-[TitleBarButton viewDidEndLiveResize]): added, call resetNoDragRect (-[TitleBarButton windowDidEndSheet:]): call resetNoDragRect (-[TitleBarButton windowDidDeminiaturize:]): call resetNoDragRect (-[TitleBarButton setTitle:]): call resetNoDragRect

Aug 8, 2002:

10:32 PM Changeset in webkit [1782] by mjs
  • 3 edits in trunk/WebKit

Fix to get onLoad to fire, so the iBench test works.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return the bridge for the new child frame.
10:32 PM Changeset in webkit [1781] by mjs
  • 8 edits in trunk/WebCore

Fix to get onLoad to fire, so the iBench test works.

  • khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Put back some needed code that was ifdef'd out (the part that emits completed()). (KHTMLPart::slotChildCompleted): Enabled; ifdef'd out part. (KHTMLPart::frame): Enabled.
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::completed): Hack to get completed signal delivered to parent. (KWQKHTMLPartImpl::requestFrame): Initialize m_part
  • kwq/WebCoreBridge.h: createChildFrameNamed method now returns the bridge for the child frame.
9:21 PM Changeset in webkit [1780] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Change the group name back to Debug.
1:46 PM Changeset in webkit [1779] by rjw
  • 13 edits in trunk

Added flag to turn on/off buffered text drawing to help
determine if we get any speed boost. Run from console
with "-BufferTextDrawing YES" to enable buffered text
drawing.

Moved buffered text drawing out of web core.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):

Move stuff out of core into kit.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m:
12:37 PM Changeset in webkit [1778] by darin
  • 15 edits
    4 adds in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsurlextensions-test.m: Added code to check the new URL extras methods against the old original versions, which are pasted in here for now.
  • Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: Updated result to match the changes to _web_URLByRemovingLastPathComponent, and to reflect the new "compare with old original versions" testing.

WebFoundation:

  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingLastPathComponent]): Changed behavior when the path is "/" to return the same URL with a path of "", to match the behavior of the old WebNSURLGetParent. I had hoped this would fix bug 3019790, but it did not.

WebCore:

  • fixed 3019353 -- Japanese (Autodetect) encoding not properly supported
  • kwq/make-charset-table.pl: Add a "japanese-autodetect" entry to the table explicitly, with a hardcoded encoding value. This should be good enough.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
  • kwq/WebCoreEncodings.h:
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: Change "fixed font size" to "default fixed font size".

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

  • kwq/WebCoreTestController.h: Added.
  • kwq/WebCoreTestController.m: Added.
  • WebCore.exp: Mention new class.
  • WebCore.pbproj/project.pbxproj: Mention new files.

WebKit:

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

  • Misc.subproj/WebTestController.h: Added.
  • Misc.subproj/WebTestController.m: Added.
  • WebKit.pbproj/project.pbxproj: Mention new files.
  • WebKit.exp: Mention new class.
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: Changed "fixed font size" to "default fixed font size".

WebBrowser:

Some fixes to the text encoding menus.

  • Preferences.subproj/TextPreferences.m: (-[TextPreferences takeDefaultCharacterSetFrom:]): Update the text encoding menu when the character set is changed, because the section that includes that character set shows up at the top. (-[TextPreferences awakeFromNib]): Pass the TextPreferences object as the target for the menu items, because it's not going to be in the responder chain.
  • AppController.h: Added updateTextEncodingMenu.
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Call updateTextEncodingMenu. (-[AppController updateTextEncodingMenu]): Put the code to set up the text encoding menu in here, so it can be called when the default encoding changes.
  • TextEncodingMenu.h: Added target and preferred encoding parameters.
  • TextEncodingMenu.m: (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Add target setting. (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Remove old items before adding new so this can be reused on a menu. Fixed a bug in the original Mail code that causes an extra separator to be left at the bottom when the chosen group is the last one in the list.
  • LocationChangeHandler.m: Add an import that is needed now that I removed some unneeded imports from AppController.h.
11:51 AM Changeset in webkit [1777] by cblu
  • 3 edits in trunk/WebKit

WebFoundation:

  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_carbonPathForPath:]): added (-[NSFileManager _web_startupVolumeName]): added
  • WebFoundation.pbproj/project.pbxproj: made WebNSFileManagerExtras.h a private header

WebKit:

  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream finishedLoadingWithData:]): call [NSFileManager _web_carbonPathForPath:]

WebBrowser:

Fixed:

3015546 - title bar button should be draggable
3015545 - title bar button should have command-click pop-up menu

  • BrowserNSViewExtras.h:
  • BrowserNSViewExtras.m: (-[NSView draggingImage]): added, not used yet (-[NSView startDragFromEvent:withPasteBoard:andImage:]): dragOffset correction
  • BrowserWindow.h:
  • BrowserWindowController.m: (-[BrowserWindowController windowURL]): added, called by TitleBarButton (-[BrowserWindowController windowShouldGoToURL:]): added, called by TitleBarButton
  • ListView.h:
  • ListView.m:
  • TitleBarButton.m: (-[TitleBarButton initWithFrame:]): add observers (-[TitleBarButton dealloc]): remove observers (-[TitleBarButton drawRect:]): coord fix (-[TitleBarButton userChoseMenuItem:]): added (-[TitleBarButton _drawPathRepresentingPopUpMenuForEvent:andURL:]): added (-[TitleBarButton _startDragIfNecessaryForEvent:andURL:]): added (-[TitleBarButton mouseDown:]): call new methods above (-[TitleBarButton _resetWindowButtons:]): added (-[TitleBarButton resetFrame]): calls _resetWindowButtons (-[TitleBarButton windowDidEndSheet:]): added (-[TitleBarButton windowDidDeminiaturize:]): added
3:22 AM Changeset in webkit [1776] by mjs
  • 10 edits
    2 adds in trunk

WebCore:

Added an SPI that can be used to get at the WebCore
charset-name/encoding table; this is useful for a couple of things
in WebKit.

  • kwq/WebCoreEncodings.h: Added.
  • kwq/WebCoreEncodings.mm: Added. (+[WebCoreEncodings charsetNameForEncoding:]): (+[WebCoreEncodings encodingForCharsetName:]):
  • WebCore.exp: Export the new class.
  • WebCore.pbproj/project.pbxproj: Add new files.

WebKit:

  • fixed 2957197 - Need API for getting/setting default text encoding
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Set default encoding if no other is set.
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Added support for default text encoding pref. (-[WebPreferences defaultTextEncoding]): Likewise. (-[WebPreferences setDefaultTextEncoding:]): Likewise.

WebBrowser:

  • fixed 2896313 - Default text encoding preference is not yet implemented
  • English.lproj/MainMenu.nib: Added separator after Default item
  • Preferences.subproj/English.lproj/TextPreferences.nib: Made the pop-up wider so it would fit the widest encoding
  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Implemented. (-[TextPreferences takeDefaultCharacterSetFrom:]): Implemented. (-[TextPreferences awakeFromNib]): Add encoding items to pop-up button, remove empty dummy item. (-[TextPreferences initializeFromDefaults]): Initialize pop-up too.
  • TextEncodingMenu.h:
  • TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithAction:]): Add a selector parameter so we can use a different one for the real menu and the default pop-up. (_addItemToMenuForEncoding): Likewise.
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Pass selector when adding encoding menu items.
1:18 AM Changeset in webkit [1775] by rjw
  • 13 edits
    2 adds in trunk

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

  • WebCoreSupport.subproj/WebGlyphBuffer.h: Added.
  • WebCoreSupport.subproj/WebGlyphBuffer.m: Added. (-[WebGlyphBuffer initWithFont:color:]): (-[WebGlyphBuffer font]): (-[WebGlyphBuffer color]): (-[WebGlyphBuffer reset]): (-[WebGlyphBuffer dealloc]): (-[WebGlyphBuffer drawInView:]): (-[WebGlyphBuffer addGlyphs:advances:count:at::]):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory coalesceTextDrawing]): (-[WebTextRendererFactory startCoalesceTextDrawing]): (-[WebTextRendererFactory endCoalesceTextDrawing]): (-[WebTextRendererFactory glyphBufferForFont:andColor:]): (-[WebTextRendererFactory dealloc]):
  • WebKit.pbproj/project.pbxproj:

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory endCoalesceTextDrawing]): (-[WebCoreTextRendererFactory startCoalesceTextDrawing]):

Made WebQueue a private class.

  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

Aug 7, 2002:

11:24 PM Changeset in webkit [1774] by mjs
  • 19 edits in trunk

WebCore:

WebCore work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Handle the possibility of override encoding - one that's not just a hint from the server but should override
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withEncoding:]): Adjust for slotData interface change. (-[WebCoreBridge addData:withOverrideEncoding:]): New method that allows passing override encoding as a CFStringEncoding. (-[WebCoreBridge textEncoding]): Return the current text encoding.

WebKit:

WebKit work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Handle override encoding, if any.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Remember the flags and attributes.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Initialize overrideEncoding (-[WebDataSourcePrivate dealloc]): Release attributes (-[WebDataSource _setOverrideEncoding:]): Added. (-[WebDataSource _overrideEncoding]): Added. (-[WebDataSource _flags]): Added. (-[WebDataSource _attributes]): Added.
  • WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Pass proper forceRefresh value to data source based on load type (but the data source will ignore it). (-[WebFrame reload:]): Made this work a bit better. Now instead of crashing, it will actually reload, but it won't force a refresh (and may not handle the back/forward issues properly).
  • WebView.subproj/WebDocument.h: Defined new WebDocumentTextEncoding protocol.
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView textEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setTextEncoding:]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView usingDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol.

WebBrowser:

  • fixed 2957200 - Text Encoding submenu is not yet implemented
  • AppController.h:
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Install standard Text Encoding menu items.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Validate the menu items properly, based on whether the current view can change encodings. (-[BrowserWindowController changeTextEncoding:]): Hook up to new WebKit API.
  • English.lproj/MainMenu.nib: Add Default item to encoding menu, hook it up to AppController.
  • TextEncodingMenu.h: Added. Stolen from Mail.
  • TextEncodingMenu.m: Added. Stolen from Mail.
  • WebBrowser.pbproj/project.pbxproj: Added new files.
6:19 PM Changeset in webkit [1773] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

Fix build bustage.

6:15 PM Changeset in webkit [1772] by hyatt
  • 12 edits in trunk/WebCore

Adding support for a separate fixed font size to WebCore.
Your fixed font size pref will now be honored when the
generic monospace family is used.

  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/font.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: (-[WebCoreSettings setFixedFontSize:]): (-[WebCoreSettings fixedFontSize]):
  • kwq/khtml/khtml_settings.h:
1:30 PM Changeset in webkit [1771] by darin
  • 4 edits in trunk/WebCore
  • fixed 3017499 -- One-click crasher at hondamotorcycle.com
  • kwq/KWQKURL.mm: (operator==): Just compare the strings. Faster and safer.
12:33 PM Changeset in webkit [1770] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3017245 -- Shift-Delete should go forward
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): Check for shift-delete.
12:19 PM Changeset in webkit [1769] by rjw
  • 9 edits in trunk

Fixed scrollview related drawing turd problems.
(3000844 and 2896459).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
  • WebView.subproj/WebView.m: (-[WebView setFrame:]):

Removed debug log.

  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
12:03 PM Changeset in webkit [1768] by darin
  • 8 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsurlextensions-test.m: New test that tests more of the code in WebNSExtras.
  • Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: New output for new test. Matches the old for canonicalize test cases.

WebFoundation:

  • fixed 3017633 -- IPv6 URL support needed
  • fixed 2876174 -- Some URL functions should be moved to IFNSURLExtensions and have test cases added
  • Misc.subproj/WebNSURLExtras.h: Removed _web_extractHTTPBaseURLString and _web_URLWithScheme:user:password:host:port:path:parameter:query:fragment:, renamed _web_URLWithoutFragment to _web_URLByRemovingFragment.
  • Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): Added. Used by the component-related functions. (StringByAddingPercentEscapes): Broken out from URLStringByAddingPercentEscapes. (URLStringByAddingPercentEscapes): Add code to handle the IPv6 case but make sure we escape any other bracket characters in the string. (+[NSURL _web_URLWithComponents:]): Added. (-[NSURL _web_URLComponents]): Added. These use the CFURL functions for breaking URLs into components, but makes them easier to use from AppKit by using autoreleased NSString objects and also fixes some anomalies in the CFURL functions. (-[NSURL _web_URLByRemovingFragment]): Simpler implementation, new name. (-[NSURL _web_URLByRemovingUserAndQueryAndFragment]): Added. Replaces WebNSURLRemoveUserAndSubresourceInfo. (-[NSURL _web_URLByRemovingPasswordAndPath]): Added. Replaces WebNSURLCanonicalRoot. (-[NSURL _web_URLByRemovingLastPathComponent]): Added. Replaces WebNSURLGetParent. (-[NSURL _web_canonicalize]): Rewrote to use _web_URLComponents.
  • CacheLoader.subproj/WebFileProtocolHandler.m: (+[WebFileProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (+[WebHTTPProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • AuthenticationManager.subproj/WebAuthenticationManager.m: Remove WebNSURLRemoveUserAndSubresourceInfo, WebNSURLCanonicalRoot, and WebNSURLGetParent, and use equivalent functions from WebNSURLExtras.
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_hasCaseInsensitivePrefix:]): Added.

WebCore:

  • kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::decompose): Use CFURLCopyPath instead calling _NSParseStringToGenericURLComponents.

WebKit:

  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call _web_URLWithoutFragment by its new name _web_URLByRemovingFragment.
11:03 AM Changeset in webkit [1767] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3018632 - the show javascript files inline bug

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): support application/x-javascript
  • WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): support application/x-javascript
10:43 AM Changeset in webkit [1766] by sullivan
  • 7 edits in trunk/WebKit

WebKit:

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): Changed name from _web_superviewWithName: and made it take a Class object instead of a string.
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView start]): (-[WebPluginView layout]): Updated callers of _web_superviewWithName:
  • WebKit.pbproj/project.pbxproj: Changed WebNSViewExtras.h from Public to Private

WebBrowser:

  • BrowserNSViewExtras.h,
  • BrowserNSViewExtras.m: Remove superviewOfClass now that it's in WebKit
  • ActivityViewer.m: (-[ActivityViewer bestSizeForWindowContent]): Use _web_superviewOfClass:
9:28 AM Changeset in webkit [1765] by rjw
  • 1 edit in trunk/WebCore/kwq/WebCoreBridge.mm

Fixed compile problem.

9:22 AM Changeset in webkit [1764] by rjw
  • 4 edits in trunk/WebCore

Turned off temporary debugging I accidentally checked in.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):

Aug 6, 2002:

10:46 PM Changeset in webkit [1763] by hyatt
  • 6 edits in trunk/WebCore

Make user stylesheet changes dynamic. Web documents will now
update as the user stylesheet is applied and unapplied. Altered
how reapplyStyles works a bit.

  • khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setUserStyleSheet):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]):
9:19 PM Changeset in webkit [1762] by hyatt
  • 5 edits in trunk/WebCore

Enable user stylesheet support. It works from a fresh start but
is not yet completely dynamic.

  • khtml/khtml_part.cpp: (KHTMLPart::setUserStyleSheet):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::userStyleSheet):
9:12 PM Changeset in webkit [1761] by darin
  • 12 edits in trunk

WebCore:

  • fixed 2965321 -- Crash on window close in kthml::Loader::cancelRequests from particular page
  • khtml/misc/loader.cpp: (Loader::servePendingRequests): Look at return value from KWQServeRequest instead of assuming it will always succeed.
  • kwq/KWQLoaderImpl.h: Add return value for KWQServeRequest.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Return false if we fail to make either the NSURL or the WebResourceHandle. Also make sure that we delete the job if necessary.

WebKit:

Fix assert I saw while fixing bug 2965321.

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Create a suitable resource identifier from the failing URL in the WebError for cases where we fail before we are able to construct a resource handle.
8:58 PM Changeset in webkit [1760] by sullivan
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Edited this file to force a make clean in WebCore after discovering that it was necessary the hard way. I'm not sure which earlier checkin made this be required.
8:39 PM Changeset in webkit [1759] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Fix crash in overURL, another case just like bug 3006336.
8:29 PM Changeset in webkit [1758] by darin
  • 3 edits in trunk/WebKit
  • fixed 2970516 -- Activate Events don't appear to be coming in to the Java Applet.plugin correctly.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Use activeFlag to set modifiers, not activMask, which is an event mask.
7:05 PM Changeset in webkit [1757] by rjw
  • 11 edits in trunk/WebCore

Frame resizing related changes. Frames are now resizable
w/ a resize bar. Still need to draw frame borders.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameStyle): (QFrame::frameWidth):
  • kwq/KWQWidget.mm: (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::flushDrawing): (QWidget::enableFlushDrawing): (QWidget::disableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::displayRect):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/qt/qframe.h:
  • kwq/qt/qwidget.h:
5:57 PM Changeset in webkit [1756] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

Add mechanism to store userStyleSheet preferences in WebKit in
preparation for Dave wiring up the implementation.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetEnabled]), (-[WebPreferences setUserStyleSheetEnabled:]), (-[WebPreferences userStyleSheetLocation]), (-[WebPreferences setUserStyleSheetLocation:]): New methods, read and write UserDefaults values.

(+[WebPreferences load]): Set initial values for
userStyleSheetEnabled and userStyleSheetLocation

WebBrowser:

Updated to use userStyleSheet preferences from WebKit.

  • Defaults.plist,
  • PreferenceKeys.h: Remove preference keys for ApplyStyleSheet since this is in WebKit now.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences setStylesheetPathPreference:]), (-[AppearancePreferences stylesheetPathPreference]), (-[AppearancePreferences updateStylesheetViews]), (-[AppearancePreferences toggleApplyStylesheet:]): Update to use WebKit preferences API; remove local storage.
4:28 PM Changeset in webkit [1755] by mjs
  • 16 edits in trunk

WebCore:

Removed some APPLE_CHANGES no longer needed after the part change.

  • khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Don't call impl version. (KHTMLPart::setOpenedByJS): Don't call impl version.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: Removed openedByJS and setOpenedByJS.
  • kwq/WebCoreBridge.h: Don't prototype setOpenedByScript: and openedByScript methods now that they are not needed.

WebKit:

Removed some APPLE_CHANGES no longer needed after the part change.

  • WebCoreSupport.subproj/WebBridge.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
3:37 PM Changeset in webkit [1754] by darin
  • 8 edits in trunk/WebKit

WebKit:

  • fixed 3017761 -- dataSource != nil assertion navigating at yahoo.com
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebLocationChangeHandler.m: Change client redirect calls to pass the frame, not the data source. At the time a client redirect is requested, it's not even clear yet which data source will be involved. We may want to make some of the other calls pass frames, also, aside from the "start", "committed", "done", calls, which must specify the data source.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Pass frame, not data source. (-[WebBridge reportClientRedirectCancelled]): Pass frame, not data source.

WebBrowser:

Update for change to client redirect API.

  • LocationChangeHandler.m: (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler clientRedirectCancelledForFrame:]): We get the frame now, not the data source.
1:16 PM Changeset in webkit [1753] by hyatt
  • 7 edits in trunk/WebCore

Make checkboxes and radio buttons use the small control
size. Tweak their baselines to not use font metrics and
to line up properly. (voodooextreme.com nearly renders
the left column correctly now.)

  • khtml/rendering/render_form.cpp: (RenderCheckBox::baselinePosition): (RenderRadioButton::baselinePosition):
  • khtml/rendering/render_form.h:
  • kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox):
  • kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton):
12:54 PM Changeset in webkit [1752] by darin
  • 52 edits in trunk/WebKit

WebFoundation:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebKit:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebBrowser:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.
11:09 AM Changeset in webkit [1751] by sullivan
  • 4 edits in trunk/WebCore

WebCore:

WebCore part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): inside APPLE_CHANGES, remove use of KHTML limits for zoom factor; this is a client responsibility in our model.

WebBrowser:

WebBrowser part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • BrowserDocument.h:
  • BrowserDocument.m: Define min/max text multiplier values, and ratio (-[BrowserDocument canMakeTextLarger]), (-[BrowserDocument canMakeTextSmaller]): New methods, check that there's a page and that the new size wouldn't be too big/small.

(-[BrowserDocument makeTextLarger:]),
(-[BrowserDocument makeTextSmaller:]):
New methods, set web controller's text multiplier.

(-[BrowserDocument validateUserInterfaceItem:]):
Disable makeTextLarger and makeTextSmaller when appropriate.

11:00 AM Changeset in webkit [1750] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Put in a check for nil that I missed.
10:13 AM Changeset in webkit [1749] by darin
  • 26 edits in trunk

WebCore:

  • fixed 2948805 -- Need WebKit API for larger/smaller font feature
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Head in the direction of using the m_frames and m_objects arrays, by turning some APPLE_CHANGES code on. (KHTMLPart::checkCompleted): More code turned on here. (KHTMLPart::checkEmitLoadEvent): And more code turned on here. (KHTMLPart::parentPart): Remove APPLE_CHANGES version. We can use the original now. (KHTMLPart::setZoomFactor): Remove APPLE_CHANGES. We want this function now.
  • khtml/khtml_part.h: Remove some APPLE_CHANGES to make xmlDocImpl public. No longer needed.
  • khtml/khtmlpart_p.h: Remove a bunch of APPLE_CHANGES.
  • kwq/KWQKHTMLPartImpl.h: Remove parentPart(), add getDocument() and getRenderer().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Use parentPart() instead of [bridge parent]. (KWQKHTMLPartImpl::requestFrame): Set up a ChildFrame in the m_frames array. (KWQKHTMLPartImpl::layout): Use getRenderer(). (KWQKHTMLPartImpl::getDocument): Added. (KWQKHTMLPartImpl::getRenderer): Added.
  • kwq/WebCoreBridge.h: Add [setParent:], remove [parent].
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setParent:]): Added. (-[WebCoreBridge reapplyStyles]): Use getDocument(). (-[WebCoreBridge forceLayout]): Use getRenderer(). (-[WebCoreBridge drawRect:withPainter:]): Use getRenderer(). (-[WebCoreBridge copyDOMTree:]): Use getDocument(). (-[WebCoreBridge copyRenderTree:]): Use getRenderer(). (-[WebCoreBridge completeURLForDOMString:]): Use getDocument(). (-[WebCoreBridge elementAtPoint:]): Use getRenderer(). (-[WebCoreBridge setTextSizeMultiplier:]):
  • kwq/khtml/khtml_ext.h: Add dummy setEnabled function to make khtml_part.cpp compile.
  • kwq/kparts/part.h: Add real parent() and setParent() implementation.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Call setParent:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Initialize the text size multiplier to 1.
  • WebView.subproj/WebDataSource.h: Removed [redirectedURL], deprecated [inputURL], added [URL].
  • WebView.subproj/WebDataSource.m: (-[WebDataSource URL]): Added. Returns current URL, without requiring separate logic for the redirected and not-yet-redirected cases.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Use [WebDataSource URL].
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Use [WebDataSource URL].

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument currentURL]): Use [WebDataSource URL]. (-[BrowserDocument provisionalURL]): Use [WebDataSource URL].
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): Use [WebDataSource URL].
  • DownloadMonitor.m: (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): Use [WebDataSource URL].
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]): Use [WebDataSource URL].
9:21 AM Changeset in webkit [1748] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Add default value for fixed width size (-[WebPreferences fixedFontSize]), (-[WebPreferences setFixedFontSize:]): New methods.

WebBrowser:

WebBrowser part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateFontSampleField:]): (-[TextPreferences updateFontSampleFields]): (-[TextPreferences chooseFont:]): (-[TextPreferences chooseStandardFont:]): (-[TextPreferences changeFont:]): (-[TextPreferences initializeFromDefaults]): Removed serif and sans-serif code, replaced with standard font. Made font sizes independent of each other.
  • Preferences.subproj/English.lproj/TextPreferences.nib: Futzed with Interface Builder.
8:36 AM Changeset in webkit [1747] by darin
  • 3 edits in trunk/WebKit
  • fixed 3017536 -- Change default font to Lucida Grande 14 pt.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Changed default font and sans serif font family names to Lucida Grande. Changed default font size to 14 point.
Note: See TracTimeline for information about the timeline view.