Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 7, 2002:

11:53 PM Changeset in webkit [2598] by darin

• 4 edits in trunk/WebKit

• History.subproj/WebHistoryItem.h: Replace _URL with _URLString.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL]. (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString. (-[WebHistoryItem dealloc]): Release _URLString. (-[WebHistoryItem URL]): Make a URL from _URLString. (-[WebHistoryItem icon]): Use [self URL] instead of _URL. (-[WebHistoryItem setURL:]): Store a URL string. (-[WebHistoryItem hash]): Use the URL string's hash. (-[WebHistoryItem isEqual:]): Compare the URL strings. (-[WebHistoryItem description]): Use _URLString. (-[WebHistoryItem dictionaryRepresentation]): Use _URLString. (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to the other init functions so we have only one designated initializer. Leave the date as nil if there's no date in the dictionary instead of setting the date to 0.

11:47 PM Changeset in webkit [2597] by darin

• 4 edits in trunk/WebCore

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Add an assert in the hopes of catching bug 3084704 a little earlier.

11:43 PM Changeset in webkit [2596] by darin

• 4 edits in trunk/JavaScriptCore

• kjs/date_object.cpp: (mktimeUsingCF): Fix storage leak.

9:29 PM Changeset in webkit [2595] by mjs

• 9 edits in trunk/WebKit

WebKit:

Removed SaveAndOpenExternally policy.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading]):
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Removed all uses of SaveAndOpenExternally policy.

• BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]):
• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):

9:15 PM Changeset in webkit [2594] by cblu

• 3 edits in trunk/WebKit

WebKit:

• WebKit.pbproj/project.pbxproj:

WebBrowser:

Made Alexander responsible for opening downloads.

• BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): call +[WBPreferences shouldOpenFileWithMIMEType:] (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): no open policy
• Defaults.plist:
• DownloadProgressEntry.m: (-[DownloadProgressEntry isDiskCopyFile]): (-[DownloadProgressEntry startDiskCopyInteraction]): (-[DownloadProgressEntry openFile]): (-[DownloadProgressEntry setCompleted]):
• Preferences.subproj/WBPreferences.h:
• Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileWithMIMEType:]): moved this method here from BrowserWebController as this is now called in 2 different places

7:10 PM Changeset in webkit [2593] by mjs

• 4 edits in trunk/JavaScriptCore

• partial fix to 3073230 - JavaScript time calls do I/O by lastat()ing /etc/localtime

• kjs/date_object.cpp: (mktimeUsingCF): Implementation of mktime using CF.

6:49 PM Changeset in webkit [2592] by rjw

• 2 edits in trunk/WebKit

Commit changelog.

5:29 PM Changeset in webkit [2591] by mjs

• 3 edits in trunk/WebKit

• fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): Get the element info from the HTML view where the click originally happened, not the current document view. Add some asserts to make sure this is working.

5:14 PM Changeset in webkit [2590] by rjw

• 4 edits in trunk/WebCore

Don't stop animating unless we're the last referee. (3083281)

• kwq/KWQPixmap.mm: (QPixmap::~QPixmap):

3:50 PM Changeset in webkit [2589] by rjw

• 3 edits in trunk/WebKit

Fixed updating of status bar and activity window when
loading plugin content as main document. (3084311)

• LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):

11:29 AM Changeset in webkit [2588]

• 3 copies in tags/Alexander-31

This commit was manufactured by cvs2svn to create tag 'Alexander-31'.

11:29 AM Changeset in webkit [2587] by sheridan

• 8 edits in trunk

Alex-31 stamp

7:47 AM Changeset in webkit [2586] by mjs

• 3 edits in trunk/WebKit

• fixed 3094778 - REGRESSION: Assert on logout from schwab.com

(probably fixed it anyway - I'm flying blind on this one)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Use a nil request if the URL was nil, instead of making a request that contains a nil URL.

6:33 AM Changeset in webkit [2585] by mjs

• 14 edits in trunk/WebKit

WebKit:

Changed things so that creating a window takes a request rather
than a URL and referrer.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringEvent:]): (-[WebDataSource _triggeringEvent]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame findOrCreateFramedNamed:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Changed things so that creating a window takes a request rather
than a URL and referrer.

• BrowserWebController.m: (-[BrowserWebController createWindowWithRequest:]):

Nov 6, 2002:

10:43 PM Changeset in webkit [2584] by darin

• 4 edits in trunk/WebKit

• fixed problem where files small enough to fit entirely in the buffer (8K or less) would not be decoded

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from receivedData into here. (-[WebDownloadHandler receivedData:]): Changed to call decodeData. (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining bytes rather than writing them straight out to the data fork.

5:21 PM Changeset in webkit [2583] by rjw

• 8 edits in trunk

More work on rendering scripts. Now most complex scripts render correctly.
Working new features include:
bidi, diacriticals, cursive forms, and arabic ligatures.
Selection of text rendered in these scripts, is however, not working.
Also, line height is incorrect when renderering combined below glyphs.
ajami is, sadly, horrendously broken.

• Misc.subproj/WebUnicode.m: (glyphVariantLogical): (shapedString):
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Use our notion of unicode whitespace from lookup tables
and isspace for latin1. This is more correct than CF.
Fixed issues Dave ran into with whitespace calculations.

• kwq/KWQChar.mm: (QChar::isSpace):

5:10 PM Changeset in webkit [2582] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): made this handle WebBookmarkTypeProxy

WebBrowser:

• fixed 3092708 -- allow option for Bookmarks Toolbar as submenu of Bookmarks menu

The wording and possibly layout in Preferences will change soon, but the
behavior is now implemented as SJ specified.

• Defaults.plist:
• PreferenceKeys.h: New preference keys for the new options

• Preferences.subproj/English.lproj/BookmarkPreferences.nib: rejigger everything in the bookmarks preferences panel

• Preferences.subproj/BookmarkPreferences.h:
• Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences updateBookmarksViews]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesAddressBook:]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesRendezvous:]): (-[BookmarkPreferences toggleBookmarksMenuAndToolbarAreSame:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesBookmarksToolbar:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesRendezvous:]): (-[BookmarkPreferences initializeFromDefaults]): reworked all the code to handle the new options, including the way some options change when others are checked

• BookmarksController.h: made addressBookProxyTitle and rendezvousProxyTitle public
• BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): new method, generalized from code elsewhere (handles keyboard equivalents for toolbar items) (-[BookmarksController addMenuItemForBookmark:toMenu:]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController addFavoritesSubmenu]): new method, calls addChildrenOfBookmark:toMenu: (-[BookmarksController addSpecialBookmarkSourcesToMenu]): now handles toolbar as submenu, plus fancier logic to match new preferences (-[BookmarksController _addBookmarksToMenu]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController receivedBrowserPreferenceValueChangedNotification:]): now checks for new preferences also

• FavoriteButton.m: (-[FavoriteButton setBookmark:]): now handles WebBookmarkTypeProxy -- like folder in appearance, but not a drag target (-[FavoriteButton menu]): now handles WebBookmarkTypeProxy (by returning nil for the context menu) (-[FavoriteButton hasContentsMenu]): new method, just checks bookmark type (-[FavoriteButton _contentsMenu]): now handles WebBookmarkTypeProxy by using BookmarkSource protocol to extract contents (-[FavoriteButton mouseDown:]): check hasContentMenu instead of assuming which types have menus

• FavoritesBar.m: (-[FavoritesBar addButtonForBookmark:withLeftEdge:]): new method, extracted from _refreshButtons (-[FavoritesBar includeRendezvous]), (-[FavoritesBar includeAddressBook]): new methods, check with NSUserDefaults (-[FavoritesBar _refreshButtons]): take includeRendezvous and includeAddressBook into account; now calls addButtonForBookmark:withLeftEdge: (-[FavoritesBar refreshButtonsSoon]): new method, extracted from _favoritesChanged (-[FavoritesBar preferenceValueChanged:]): new method, call refreshButtons if the right prefs have changed (-[FavoritesBar _favoritesChanged:]): now calls refreshButtonsSoon (-[FavoritesBar initWithView:]): register for preferences value changed notifications (-[FavoritesBar dropIndexFromDraggingInfo:]): take includeRendezvous and includeAddressBook into account (-[FavoritesBar performDragOperation:]): take includeRendezvous and includeAddressBook into account

4:16 PM Changeset in webkit [2581] by darin

• 5 edits in trunk/WebKit

• fixed bug that affected BinHex-encoded files with no resource fork

• Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]): Don't decode the resource fork unless done with the data fork.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): Set the forks to nil before calling through.

3:47 PM Changeset in webkit [2580] by darin

• 4 edits in trunk/WebKit

• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Fix == 129 check that was supposed to be <= 129.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:44 PM Changeset in webkit [2579] by cblu

• 2 edits in trunk/WebKit/Downloads.subproj

WebFoundation:

Added _web_infoDictionaryForBundleAtPath. Gets info dictionary without using NSBundle.

• Misc.subproj/WebNSDictionaryExtras.h:
• Misc.subproj/WebNSDictionaryExtras.m: (+[NSDictionary _web_infoDictionaryForBundleAtPath:]):

WebBrowser:

Preliminary work for disk copy interaction.

• AppController.m: (-[AppController awakeFromNib]): tweak to GURL event call, no actual change
• Defaults.plist: don't have WebKit open disk images for us anymore, since Alex will do this.
• DiskCopyPuppetStrings.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): set handlers for disk copy events (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]): added, does nothing right now
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry diskCopyStage]): new (-[DownloadProgressEntry setDiskCopyStage:]): new (-[DownloadProgressEntry startDiskCopyInteraction]): new, check version of disk copy, open disk image (-[DownloadProgressEntry setCompleted]): call startDiskCopyInteraction

3:31 PM Changeset in webkit [2578] by darin

• 4 edits in trunk/WebKit

• Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]): Fix an off-by-one error handling repeat counts.

• WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.

3:11 PM Changeset in webkit [2577] by darin

• 8 edits
  2 adds in trunk/WebKit

• added a BinHex decoder and did a little work on the MacBinary decoder

I'm not supposed to be working on this, but I didn't feel like doing "real" work.

• Downloads.subproj/WebBinHexDecoder.h: Added.
• Downloads.subproj/WebBinHexDecoder.m: Added.
• WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.

• Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.

• Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III part that gets the script code. (-[WebMacBinaryDecoder filename]): Use the script code.

2:37 PM Changeset in webkit [2576] by mjs

• 8 edits in trunk/WebKit

WebKit:

Took URL field out of click policy - open in new window policy
will always open the request URL.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Updated for WebKit changes.

• BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):

11:26 AM Changeset in webkit [2575] by cblu

• 3 edits in trunk/WebKit

Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):

9:25 AM Changeset in webkit [2574] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Fix for this bug:

Radar 3004422 (Loader should cache misses)

I added a code to support caching HTTP 404 responses. These objects
will now get cached just like other responses, and they are subject
to the same revalidation rules as other cache objects.

To support caching the 404 for a specified period of time, I have
added an extra method to WebHTTPResourceRequest.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]):
• ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest pageNotFoundCacheLifetime]): (-[WebResourceRequest setPageNotFoundCacheLifetime:]): (-[WebHTTPResourceRequestParameters copyWithZone:]): (-[WebHTTPResourceRequestParameters isEqual:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):

WebKit:

Call new WebHTTPResourceRequest method to set the amount of time
to cache a 404 response when trying to fetch a favicon.

This change helps to fix this bug:

Radar 3004422 (Loader should cache misses)

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])

Nov 5, 2002:

8:00 PM Changeset in webkit [2573] by mjs

• 10 edits in trunk/WebKit

WebKit:

Reworked clickPolicy arguments to be closer to proposed version.

• WebKit.exp:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Adjusted for WebKit API changes.

• BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):

5:59 PM Changeset in webkit [2572] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster version of the new "lose precision" CEIL_TO_INT macro.

5:56 PM Changeset in webkit [2571] by darin

• 4 edits in trunk/WebCore

• fixed 3092722 -- assertion failed

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Removed the assertion. It wasn't needed.

5:47 PM Changeset in webkit [2570] by rjw

• 3 edits in trunk/WebKit

Fixed a couple of issues that Dave highlighted w/ his whitespace
fixes. CG sometimes introduces very small 'error' in metrics, specifically
we saw character widths of 20.0000019 that should have been 20. As a
work-around we loose precision beyond the 1000th place. Also, always
ceil spaces.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

5:25 PM Changeset in webkit [2569] by darin

• 3 edits in trunk/WebKit

• fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): We need to stop loading here. Otherwise we might do loading after closeURL, which could lead to a problem like the one above.

5:21 PM Changeset in webkit [2568] by darin

• 4 edits in trunk/WebKit

• changed our MacBinary decoding to not pay any attention to the comment

Before we would "fail to decode" if the comment was truncated, now we just
don't worry about it.

• Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code to get _commentLength and code to compute _commentEnd. (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork end rather than the comment end to see if we got enough data.

5:19 PM Changeset in webkit [2567] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: reverted generic URL icon back to the one that looks like a document until we get something from HI that SJ likes

WebBrowser:

• Resources/Images/FavoritesBar.tif:
• Resources/Images/tiny_menu.tiff: reverted Bookmarks menu and Bookmarks toolbar icons back to the previous versions until we get something from HI that SJ likes

4:27 PM Changeset in webkit [2566] by cblu

• 12 edits in trunk/WebKit

WebKit:

Fixed: 3074108 - Decode macbinary files during download

• Downloads.subproj/WebDownloadDecoder.h:
• Downloads.subproj/WebDownloadHandler.h:
• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]): (-[WebDownloadHandler closeFile]): (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler writeData:toFork:]): (-[WebDownloadHandler writeDataForkData:resourceForkData:]): (-[WebDownloadHandler dataIfDoneBufferingData:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishDecoding]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• Downloads.subproj/WebMacBinaryDecoder.h:
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder fileAttributes]): (-[WebMacBinaryDecoder filename]):
• Misc.subproj/WebKitErrors.h: added new errors
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

WebBrowser:

Fixed: 3074108 - Decode macbinary files during download

• DownloadMonitor.m: (-[DownloadMonitor identifierForInitialRequest:fromDataSource:]): (-[DownloadMonitor resource:willSendRequest:fromDataSource:]): (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): new, convenience (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry filename]): (-[DownloadProgressEntry path]): (-[DownloadProgressEntry setCompleted]):
• DownloadRow.m: (-[DownloadRow _updateStatusFields]):

11:35 AM Changeset in webkit [2565] by kocienda

• 3 edits in trunk/WebKit

Fix for this bug:

Radar 3092747 (javascript cookieEnabled property returns incorrect value)

Now, we return "true" for navigator.cookieEnabled when
"Only accept cookies from the same domain as the current page" option
is selected is user preferences.

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled])

10:51 AM Changeset in webkit [2564] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3091271 -- missing plug-in icon is on white background, not transparent.

• Resources/nullplugin.tiff: Photoshopped the white away. It's still ugly, but that's a separate bug (3091274)

WebBrowser:

Removed the text from the lock icon. Also cleaned up the
code that positions the lock icon in the window.

• BrowserWindow.m: (-[BrowserWindow adjustRightSideImageViewFrame]): new method, sets the image view's frame based on the image size and specified margins (-[BrowserWindow setUpRightSideImageView]): now calls adjustRightSideImageViewFrame (-[BrowserWindow setTitleBarRightSideImage:]): now calls adjustRightSideImageViewFrame if image has changed

• Resources/Images/Lock.tif: textless version

9:27 AM Changeset in webkit [2563] by darin

• 9 edits in trunk/WebCore

• re-fixed 3070484 -- icon rollovers are very slow on Mac OS X website

Had to roll back some of the files I changed yesterday. I had missed the
one line of useful code among much stuff we don't need.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::slotLoaderRequestStarted): (KHTMLPart::slotLoaderRequestDone):
• kwq/KWQSignal.h:
• kwq/KWQSignal.mm: (KWQSignal::call):
• kwq/KWQSignalStubs.mm: (Loader::requestDone): (Loader::requestFailed): (Loader::requestStarted):
• kwq/KWQSlot.h:
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call): Just roll back all the changes from my 3091714 check-in below, except for the bug fix itself in loader.cpp and KWQResourceLoader.mm.

9:08 AM Changeset in webkit [2562] by kocienda

• 3 edits in trunk/WebKit/Misc.subproj

The -(NSEnumeration *)keys method has never been implemented, and is unneeded.
Removing from API. This has no external impact as this class
is entirely private to WebFoundation.

• Database.subproj/WebDatabase.h:
• Database.subproj/WebDatabase.m:
• Database.subproj/WebFileDatabase.m:

3:20 AM Changeset in webkit [2561] by mjs

• 3 edits in trunk/WebKit

• fixed 3083732 - SJ: window comes out blank on samsung site

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't start loading if the URL is exactly the same as the parent URL. We may need a more stringent check, but this seems to match the tolerance of other browsers OK.

2:26 AM Changeset in webkit [2560] by mjs

• 6 edits in trunk/WebCore

• fixed 3027404 - pop-up ads not always suppressed

• khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isWindowOpenAllowed): Don't allow opening if we are in a timer callback - for reasons unexplained this will always show up as an inline script.
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Note that we're in a timer callback.

1:31 AM Changeset in webkit [2559] by mjs

• 7 edits in trunk/WebKit

WebKit:

Added request and frame to click policy callback.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

WebBrowser:

• fixed 3044620 - incorrect URL sent to the click policy handler, other problems, because it's processed early

• BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierFlags:request:inFrame:]): Look at request URL, not element URL.

Nov 4, 2002:

6:00 PM Changeset in webkit [2558] by rjw

• 12 edits in trunk

i Changes to support cursive letter forms. It works, but I've

disabled it for now. It's buggy and needs cleanup.
Arabic now renders correctly except for ligature substitution.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeIsMark): (getShape): (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (shapedString):
• Misc.subproj/WebUnicodeTables.m:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
• WebKitPrefix.h:

Changes to support cursive letter forms.

• kwq/KWQChar.mm:
• kwq/WebCoreUnicode.h:

Updated to lastest API.

• SimpleViewer/DocumentController.m: (-[ResourceLoadDelegate initWithDocumentController:]): (-[ResourceLoadDelegate updateStatus]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

5:25 PM Changeset in webkit [2557] by darin

• 11 edits in trunk/WebCore

• fixed 3091714 -- reproducible assert cachedObject->response in KWQCheckCacheObjectStatus

• khtml/misc/loader.cpp: (Loader::slotFinished): For APPLE_CHANGES, don't finish the load if it's an error.

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): Shared code for the three following methods. (-[KWQResourceLoader cancel]): Use setError(1) again instead of just keeping the load around forever. (-[KWQResourceLoader reportError]): Ditto. (-[KWQResourceLoader finish]): Use finishJobAndHandle to share code with the two above.

• khtml/khtml_part.cpp: (KHTMLPart::init): Put the slotLoaderRequestStarted and slotLoaderRequestDone connect lines inside ifdefs. (KHTMLPart::~KHTMLPart): Same for disconnect.

• kwq/KWQSignal.h: Remove code for the DocLoader signals.
• kwq/KWQSignal.mm: (KWQSignal::call): Ditto.
• kwq/KWQSignalStubs.mm: (Loader::requestDone): Ditto. (Loader::requestFailed): Ditto. (Loader::requestStarted): Ditto.
• kwq/KWQSlot.h: Ditto.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Ditto. (KWQSlot::call): Ditto.

5:10 PM Changeset in webkit [2556] by mjs

• 7 edits in trunk/WebCore

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::createDummyDocument): (KWQKHTMLPart::setCurrentEvent):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):

5:02 PM Changeset in webkit [2555] by mjs

• 8 edits in trunk/WebKit

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseUp:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m:

4:04 PM Changeset in webkit [2554] by cblu

• 3 edits in trunk/WebKit

Fixed - 3091658: REGRESSION: cmd-left for back doesn't work in plain-text viewer

We now pass text field key events to the next responder which would be WebView in this case.

• WebView.subproj/WebTextView.m: (-[WebTextView keyDown:]): (-[WebTextView keyUp:]):

3:08 PM Changeset in webkit [2553] by darin

• 15 edits in trunk/WebKit

• fixed 3090257 -- "leak the world" using the Wallace and Gromit "console"

• Plugins.subproj/WebNetscapePluginStream.m: Update for changes to the base delegate. (-[WebNetscapePluginStream start]): Use loadWithRequest:. (-[WebNetscapePluginStream stop]): Call cancel instead of just canceling the handle directly. This fixes the world leak. (-[WebNetscapePluginStream cancel]): Do some of the work that was formerly in "stop".

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Call the "stop loading URL" whenever we cancel I/O, so we don't leak the world. (-[WebMainResourceClient handle:didReceiveResponse:]): Ditto.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _finishedLoadingResourceFromDataSource:]): Fix a typo in the word "finished".

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Tweak. (-[WebBaseResourceHandleDelegate cancel]): Tweak.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels didStartLoadingURL:inWindow:]): Add assertions. (-[WebStandardPanels didStopLoadingURL:inWindow:]): Ditto. (-[WebStandardPanels _didStartLoadingURL:inController:]): Ditto. (-[WebStandardPanels _didStopLoadingURL:inController:]): Ditto.

2:52 PM Changeset in webkit [2552] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginDatabase.m

Modified pluginForKey:withEnumeratorSelector: such that we now
enumerate all plugins that match the given key before we return
a plugin. This fixes a bug in which we would sometimes return
the wrong plugin (according to our preferences) because we did
not examine all of the available plugins before making our choice.

With this change, Alexander now behaves correctly when we have
multiple Java plugins in the plugins folder (as we will on user
systems in the field).

10:58 AM Changeset in webkit [2551] by darin

• 6 edits in trunk/WebKit

• Downloads.subproj/WebMacBinaryDecoder.h: Removed many unneeded fields.
• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added comments. Changed maximum filename length to 63 as the format supports, rather than the 31 that's based on historical HFS limitations. Fix endian dependency in CRC check. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Simplified this, and removed the state machine and the accumulator. Also added some asserts. Fixed endian dependency in the code to extract the header. (-[WebMacBinaryDecoder finishDecoding]): New simpler check now that we don't have a _streamComplete boolean. (-[WebMacBinaryDecoder fileAttributes]): Rewrote to take advantage of the above changes, and also to use kCFAbsoluteTimeIntervalSince1904 rather than parsing a date string.

• Downloads.subproj/crc16.h: Tweaks.
• Downloads.subproj/crc16.m: Tweaks.

10:27 AM Changeset in webkit [2550] by darin

• 3 edits in trunk/WebKit

WebKit:

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): Replaced a useless call to stopAnimation with a couple of asserts.

WebBrowser:

• DownloadRow.m: (-[DownloadRow dealloc]): Replaced a useless timer invalidate with an assert.

8:30 AM Changeset in webkit [2549] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: new "generic URL" icon from HI -- this one looks like a red ribbon (!)

WebBrowser:

new images from Steve Lemay

• Resources/Images/MultipleBookmarks.tif: Added. This one will be used when dragging multiple bookmarks, but isn't yet.

• Resources/Images/AddLink.tif:
• Resources/Images/AddLinkDisabled.tif:
• Resources/Images/AddLinkPressed.tif:
• Resources/Images/Back.tif:
• Resources/Images/BackDisabled.tif:
• Resources/Images/BackPressed.tif:
• Resources/Images/FavoritesBar.tif:
• Resources/Images/FavoritesFolderArrow.tif:
• Resources/Images/FontBigger.tif:
• Resources/Images/FontBiggerDisabled.tif:
• Resources/Images/FontBiggerPressed.tif:
• Resources/Images/FontSmaller.tif:
• Resources/Images/FontSmallerDisabled.tif:
• Resources/Images/FontSmallerPressed.tif:
• Resources/Images/Forward.tif:
• Resources/Images/ForwardDisabled.tif:
• Resources/Images/ForwardPressed.tif:
• Resources/Images/NewFolder.tif:
• Resources/Images/NewFolder_Pressed.tif:
• Resources/Images/Reload.tif:
• Resources/Images/ReloadDisabled.tif:
• Resources/Images/ReloadPressed.tif:
• Resources/Images/Stop.tif:
• Resources/Images/StopDisabled.tif:
• Resources/Images/StopPressed.tif:
• Resources/Images/tiny_menu.tiff: new versions of these existing images

• English.lproj/Browser.nib: resized New Folder buttons

• WebBrowser.pbproj/project.pbxproj: updated for new file

8:24 AM Changeset in webkit [2548] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginController.m

(1) Modified destroyAllPlugins to remove the plugin's view from the browser's view hierarchy prior to calling the plugins' pluginDestroy methods.
(2) Modified showURL:inFrame: such that arg 'target' may be 'nil'.

Nov 3, 2002:

11:49 PM Changeset in webkit [2547] by darin

• 4 edits in trunk/WebKit

WebKit:

• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: Not MyCompanyName, but rather Apple Computer.

WebBrowser:

• DownloadProgressEntry.m:
• DownloadRow.h:
• DownloadRow.m:
• DownloadViewController.h:
• DownloadViewController.m:
• DownloadWindowController.h:
• DownloadWindowController.m:
• ServicesProvider.h:
• ServicesProvider.m: Not MyCompanyName, but rather Apple Computer.

11:05 PM Changeset in webkit [2546] by darin

• 5 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredentialPrivate dealloc]): Check for NULL before calling CFRelease, since our dealloc function can be called even before our init function runs if a base class decides to do the "[self release]; return nil;" thing in its init function.

• CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServerPrivate dealloc]): Remove call to invalidate, since, as Trey reminded us, it's pointless to invalidate a timer that retains us in our dealloc function.

WebKit:

• Plugins.subproj/WebPlugin.h: Fix comment.

• Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]): Fix leak by calling [super dealloc].

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the timer invalidate since, as Trey pointed out, it's pointless to invalidate a timer in dealloc if it's retaining this object while valid.

WebBrowser:

• DiskCopyPuppetStrings.h: Remove bogus Log section. Fix header guard that was broken.

• DownloadRow.m: (-[DownloadRow dealloc]): Fix leak by calling [super dealloc].
• DownloadViewController.m: (-[DownloadViewController dealloc]): Ditto.

1:18 PM Changeset in webkit [2545] by cblu

• 4 edits
  4 adds in trunk/WebKit

WebKit:

• Added MacBinary decoding code. Not yet used.

• Downloads.subproj/WebMacBinaryDecoder.h: Added.
• Downloads.subproj/WebMacBinaryDecoder.m: Added. (+[WebMacBinaryDecoder canDecodeHeaderData:]): (-[WebMacBinaryDecoder init]): (-[WebMacBinaryDecoder dealloc]): (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder finishDecoding]): (-[WebMacBinaryDecoder fileAttributes]):
• Downloads.subproj/crc16.h: Added.
• Downloads.subproj/crc16.m: Added. (CRC16):
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage isLoaded]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

• Added DiskCopy interaction code. Not yet used.
• Added Chuck's table view hacks to get NSViews in a TableView. Not yet used.

• DiskCopyPuppetStrings.h: Added.
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): (-[DownloadMonitor removeEntry:]): (-[DownloadMonitor _removeExpiredEntries]): (-[DownloadMonitor resource:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resource:didFailLoadingWithError:fromDataSource:]):
• ViewCell.h: Added.
• ViewCell.m: Added. (RectCenteredInRect): (+[ViewCell needsToRemainInViewHierarchy]): (-[ViewCell init]): (-[ViewCell copyWithZone:]): (-[ViewCell dealloc]): (-[ViewCell instantiateView]): (-[ViewCell setObjectValue:]): (-[ViewCell objectValue]): (-[ViewCell removeViewFromSuperview]): (-[ViewCell setView:]): (-[ViewCell view]): (-[ViewCell setViewFrame:inCellFrame:inView:]): (-[ViewCell drawWithFrame:inView:]): (-[ViewCell trackMouse:inRect:ofView:]): (-[ViewCell editWithFrame:inView:editor:delegate:event:]):
• ViewCellTableView.h: Added.
• ViewCellTableView.m: Added. (+[ViewCellTableColumn newViewCell]): (-[ViewCellTableColumn initWithIdentifier:]): (-[ViewCellTableColumn initWithCoder:]): (-[ViewCellTableColumn dealloc]): (-[ViewCellTableColumn cells]): (-[ViewCellTableColumn dataCellForRow:]): (-[ViewCellTableColumn removeRows:]): (-[ViewCellTableColumn appendRows:]): (-[ViewCellTableColumn noteNumberOfTableRowsChanged:]): (-[ViewCellTableColumn willRemoveFromTableView:]): (-[NSTableColumn noteNumberOfTableRowsChanged:]): (-[NSTableColumn willRemoveFromTableView:]): (-[ViewCellTableView replaceHeaderView]): (-[ViewCellTableView workaroundReorderResizeProblem]): (-[ViewCellTableView didReorderOrResizeNotification:]): (-[ViewCellTableView initWithFrame:]): (-[ViewCellTableView initWithCoder:]): (-[ViewCellTableView dealloc]): (-[ViewCellTableView noteNumberOfRowsChanged]): (-[ViewCellTableView reloadData]): (-[ViewCellTableView removeTableColumn:]): (-[ViewCellTableView acceptsFirstResponder]): (-[ViewCellTableView needsPanelToBecomeKey]):
• WebBrowser.pbproj/project.pbxproj:

12:50 PM Changeset in webkit [2544] by darin

• 3 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add printf to the list of functions to ignore when finding localizable strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes both to the code here and to the extract script.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Remove some now-unneeded exceptions for strings that don't appear in our code any more.

• English.lproj/Localizable.strings: Re-generated. It appears that John removed two more localizable strings after he generated it. (I had to check because last time I did this I clobbered John's change, and I didn't want to do that again.)

12:41 PM Changeset in webkit [2543] by darin

• 9 edits in trunk

WebCore:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• kwq/WebCoreResourceLoader.h: Add reportError, distinct from cancel and finish.
• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Set the error boolean on the job and then call through to [finish].

WebKit:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Call the new reportError instead of cancel. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

12:20 PM Changeset in webkit [2542] by darin

• 4 edits in trunk/WebCore

• fixed 3091275 -- can't type into Answer field in RealOne Player order form

• khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Treat 0 as max (1024) as other browsers do. (RenderFileButton::updateFromElement): Ditto, although this is in !APPLE_CHANGES code that we don't use in WebCore.