Timeline



Feb 4, 2003:

11:42 PM Changeset in webkit [3572] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3164850 -- REGRESSION: query URLs are broken

Mea culpa. The KURL test in the Tests directory failed last time, but for
some reason I didn't notice that when I ran it, perhaps due to the other
failing tests.

  • kwq/KWQKURL.mm: (appendEscapingBadChars): Don't escape '?' even though it is in the "bad character" set, since this is a more-lenient definition of bad character. Also fixed a buffer overrun bug in the '%'-sequence-preserving code, which is a second way this function is lenient. We still get the speed because most characters this routine processes are not bad characters. (KURL::encode_string): Instead of calling appendEscapingBadChars, put in a strict version of the escaping loop that does not tolerate pre-existing '%' sequences or '?' characters.
7:52 PM Changeset in webkit [3571] by rjw
  • 1 add in trunk/WebKit/API-Issues.rtf

WebKit API Notes.
Reviewed by me.

6:38 PM Changeset in webkit [3570] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • rolled in table code fix from Dirk on the khtml-dev list
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): Change return back to break.
5:11 PM Changeset in webkit [3569] by mjs
  • 8 edits in branches/Safari-0-8-2-branch

JavaScriptCore:

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebFoundation:

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebCore:

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebKit:

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebBrowser:

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebBrowser.pbproj/project.pbxproj: Updated to link against standalone frameworks instead of embeddeding them when doing a B&I build for Panther.
4:51 PM Changeset in webkit [3568] by darin
  • 12 edits in trunk/WebCore

Reviewed by Maciej.

  • we say goodbye to "MIB numbers"
  • khtml/misc/decoder.cpp: (Decoder::Decoder): Get the Latin-1 codec using a name. (Decoder::setEncoding): Detect the Hebrew encoding using isISOLatin1Hebrew() instead of MIB number. (Decoder::decode): Get the UCS-2 codec using a name. Redo APPLE_CHANGES so we don't get the MIB-number-based workaround for a bug in QTextCodec that KWQ doesn't have. Get the Latin-1 codec using a name.
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): Get the Latin-1 codec using a name. (CachedScript::CachedScript): Get the Latin-1 codec using a name.
  • kwq/KWQCharsets.h: Remove the two MIB-related functions.
  • kwq/KWQCharsets.mm: Remove the MIB number from the character set table struct. Remove the MIB-related dictionary globals and functions. (buildDictionaries): Remove code to set up the MIB-related dictionaries.
  • kwq/KWQTextCodec.h: Remove codecForMib, mibEnum, and encoding member functions. Add isISOLatin1Hebrew member function.
  • kwq/KWQTextCodec.mm: (QTextCodec::makeDecoder): Pass in the encoding when making KWQTextDecoder rather than passing in the QTextCodec object. (QTextCodec::toUnicode): Ditto. (QTextCodec::isISOLatin1Hebrew): Return true for kCFStringEncodingISOLatinHebrew only. (KWQTextDecoder::convertUsingTEC): Get encoding directly instead of from a QTextCodec. (KWQTextDecoder::toUnicode): Ditto.
  • kwq/make-charset-table.pl: Don't write out MIB numbers.
  • kwq/KWQCharsetData.c: Regenerated.
  • khtml/khtml_part.cpp: (KHTMLPart::completeURL): Don't bother passing the MIB number to KURL. Soon, we'll have to do something smart here, but we won't use MIB numbers.
  • kwq/mac-encodings.txt: Added more 16-bit Unicode character set names. Updated some comments.
4:47 PM Changeset in webkit [3567] by hyatt
  • 3 edits in trunk/WebCore

Patch calcInlineMaxWidth to add in left/right margins/borders/padding
separately (since the inline could break across multiple lines).

Reviewed by darin

  • khtml/rendering/render_block.cpp: (RenderBlock::calcInlineMinMaxWidth):
3:58 PM Changeset in webkit [3566] by mjs
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • JavaScriptCore.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebFoundation:

Reviewed by Darin.

  • WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebCore:

Reviewed by Darin.

  • WebCore.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebKit:

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

WebBrowser:

Reviewed by Darin.

  • WebBrowser.pbproj/project.pbxproj: Updated to link against standalone frameworks instead of embeddeding them when doing a B&I build for Panther.
2:51 PM Changeset in webkit [3565] by hyatt
  • 5 edits in trunk/WebCore

Patch #1: Compacts are supposed to use their maximum intrinsic width
when determining if they will fit. I was wrongly using the
minwidth (i.e., being too aggressive about trying to squeeze
the compact in there).

Also yanking the setMaxWidth/MinWidth setters, since I'm not
using them any more.

Reviewed by kocienda

Patch #2: Implement an iterator for min/max width calculations
of blocks with inline children. This iterator will include
inline flows twice (with a bool flag indicating whether you're at the
start or end of the flow).

Reviewed by darin

  • khtml/rendering/render_block.cpp: (RenderBlock::layoutBlockChildren):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_object.h:
1:34 PM Changeset in webkit [3564] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3142813 -- Safari displays a blank page when trying to open html file encoded in little-endian UTF-16
  • kwq/KWQString.h: Remove fromStringWithEncoding and convertToQCString, add append that takes a QChar * and length.
  • kwq/KWQString.mm: (QString::fromUtf8): Use QTextCodec instead of fromStringWithEncoding. (QString::append): Implement by calling insert.
  • kwq/KWQTextCodec.h: Added an encoding() member function to QTextCodec and made QTextDecoder an abstract base class to pave the way for putting more state in it to handle multibyte encodings.
  • kwq/KWQTextCodec.mm: Add KWQTextDecoder, a concrete subclass of QTextDecoder. (codecForCFStringEncoding): Moved the static inside this function for clarity. (QTextCodec::makeDecoder): Make a KWQTextDecoder. (QTextCodec::toUnicode): Make a KWQTextDecoder and use it do the decoding instead of calling fromStringWithEncoding. (KWQTextDecoder::convertUTF16): Added. Decodes Unicode, using the BOM to decide whether it's little-endian or big-endian. (KWQTextDecoder::convertUsingTEC): Added. Here's where the code from QString::fromStringWithEncoding was moved. This needs to be changed to handle state between multiple buffers passed in eventually, but not to fix this bug. (KWQTextDecoder::toUnicode): Added. Calls convertUTF16 or convertUsingTEC.
  • kwq/WebCoreBridge.mm: (+[WebCoreBridge stringWithData:textEncoding:]): Use QTextCodec instead of fromStringWithEncoding.
  • khtml/misc/decoder.cpp: (Decoder::decode): Rearranged the #if to make things easier to read.
12:41 PM Changeset in webkit [3563] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3163879 - receivedPageIcon:forDataSource: always sends nil image

Reviewed by rjw.

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]):
11:08 AM Changeset in webkit [3562] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3150252 -- files with question marks in their names fail to upload as attachments
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Don't include a Content-Type header at all if we don't have a MIME type to send. Matches other web browsers' behavior. (HTMLInputElementImpl::encoding): Construct the URL using setPath rather than just passing a filename to the KURL constructor. (HTMLSelectElementImpl::state): Tweak #if formatting a bit. (HTMLSelectElementImpl::restoreState): Improve comment a bit.
  • kwq/KWQKURL.mm: Make ? be a "bad character". I checked carefully to be sure this does not adversely affect any calls, including running our KURL tests. (KURL::setPath): Encode the passed-in path. I determined this was correct both by looking at all the call sites in KHTML code to see that they would want this behavior, and by noticing that the path() getter decodes the path.
9:15 AM Changeset in webkit [3561] by kocienda
  • 3 edits in trunk/WebCore

WebFoundation:

Reviewed by Darin

Fix for this bug:

Radar 3142922 (file URLs should never be sent as referrers)

Note that this code is added to this framework to close this security
hole for WebFoundation-only clients. Safari does not depend on this change
to fix the bug.

  • ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest setReferrer:]): Return if argument passed in returns YES when sent _web_isFileURL message.

WebCore:

Reviewed by Darin

Radar 3142922 (file URLs should never be sent as referrers)

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Check that the referrer does not start with the prefix "file:". If it does, return nil.
8:53 AM Changeset in webkit [3560] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3135388 -- encoding changes do not affect text in form elements

The problem was that form data was being saved and restored, and in the case of buttons,
the form data was the incorrectly decoded button label.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Remove the default: case so we get a warning if we omit one of the enum values from this switch statement. (-[WebFrame _transitionToCommitted:]): Move the WebFrameLoadTypeReloadAllowingStaleData case up so it's right next to the case it should be merged with. (-[WebFrame _isLoadComplete]): Remove the default: case so we get a warning if we omit one of enum values from this switch statement. (-[WebFrame _itemForRestoringDocState]): Replace the if statement with a switch statement. Include WebFrameLoadTypeReloadAllowingStaleData, which fixes the bug.

Feb 3, 2003:

5:33 PM Changeset in webkit [3559]
  • 19 copies
    1 delete in branches/Safari-58-1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-58-1-branch'.

5:33 PM Changeset in webkit [3558]
  • 19 copies
    1 delete in tags/Safari-58

This commit was manufactured by cvs2svn to create tag 'Safari-58'.

5:33 PM Changeset in webkit [3557]
  • 19 copies
    1 delete in tags/SAFARI_58_1_ANCHOR

This commit was manufactured by cvs2svn to create tag
'SAFARI_58_1_ANCHOR'.

5:33 PM Changeset in webkit [3556] by sheridan
  • 8 edits in branches/Safari-0-8-2-branch

Safari-58 versionstamp

4:51 PM Changeset in webkit [3555] by darin
  • 3 edits in branches/Safari-0-8-2-branch/WebKit

Rolled over changes from the trunk.

2003-02-03 Chris Blumenberg <​cblu@apple.com>

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the enco
4:47 PM Changeset in webkit [3554] by darin
  • 3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-02-03 David Hyatt <​hyatt@apple.com>

Fix for 3163603, livepage.apple.com repaints entire page.

Reviewed by darin.

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
4:43 PM Changeset in webkit [3553] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3163603, livepage.apple.com repaints entire page.

Reviewed by darin.

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
4:32 PM Changeset in webkit [3552] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3133902 -- leaked render objects from makeChildrenNonInline (4 after running cvs-base)
  • khtml/rendering/render_block.cpp: (RenderBlock::removeChild): Deatch the anonymous block after emptying it out.
4:08 PM Changeset in webkit [3551] by hyatt
  • 3 edits in trunk/WebCore

Fix for livepage.apple.com crash. The bug # is
3163508.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::setPos):
3:41 PM Changeset in webkit [3550] by hyatt
  • 7 edits in trunk/WebCore

Rename TextSlave to TextRun.

Reviewed by darin

  • khtml/khtml_part.cpp: (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
  • khtml/rendering/bidi.cpp: (RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_text.cpp: (TextRun::detach): (throw): (TextRun::operator delete): (TextRun::paintSelection): (TextRun::paintDecoration): (TextRun::paintBoxDecorations): (TextRun::checkSelectionPoint): (TextRunArray::TextRunArray): (TextRunArray::compareItems): (TextRunArray::findFirstMatching): (RenderText::detach): (RenderText::deleteRuns): (RenderText::findTextRun): (RenderText::nodeAtPoint): (RenderText::checkSelectionPoint): (RenderText::cursorPos): (RenderText::posOfChar): (RenderText::paintObject): (RenderText::position): (RenderText::width):
  • khtml/rendering/render_text.h:
  • kwq/KWQRenderTreeDebug.cpp: (writeTextRun): (write):
3:19 PM Changeset in webkit [3549] by hyatt
  • 3 edits in trunk/WebCore

Fix for assertion on nasdaq.com. Patch containingBlock
to return 0 when it can't find a containingBlock at all (e.g.,
when the object is orphaned).

Patch setOverhangingContents to deal with a null containingBlock
caused by it being called from RenderImage::setStyle().

The bug # is 3162989.

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):
2:48 PM Changeset in webkit [3548] by hyatt
  • 15 edits in trunk/WebCore

Enable support for the "run-in" and "compact" display types.

Also implementing support for :before and :after (they were not even
remotely working before these fixes).

Made sure :first-letter drills into inline children to find the
first letter in a block, e.g., so :before content can be used in
conjunction with :first-letter.

Fixed a regression in addOverhangingFloats that broke meyerweb.com's
front page.

Patched findNextLineBreak to correctly handle words that cross
inline boundaries and white-space mixtures. We now pass Hixie's
insanely evil mixed white-space test (we are the only browser
to do so).

Reviewed by kocienda

  • ChangeLog:
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::layoutBlockChildren): (RenderBlock::paintObject): (RenderBlock::clearFloats):
  • khtml/rendering/render_box.cpp: (RenderBox::calcWidthUsing):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle):
  • khtml/rendering/render_inline.cpp: (RenderInline::setStyle): (RenderInline::addChildToFlow):
  • khtml/rendering/render_object.cpp: (RenderObject::createObject):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):
12:09 PM Changeset in webkit [3547] by rjw
  • 2 edits in trunk/WebKit

Fixed headerdoc type.

Reviewed by me.

  • WebView.subproj/WebDocument.h:
11:57 AM Changeset in webkit [3546] by rjw
  • 18 edits in trunk/WebKit

WebKit:

Support for new canProvideDocumentSource and documentSource API.
Updated all the representations. Added support to show for RTF source.
Moved WebKitInitializeUnicode to to early class. This was necessary
because WebCore may use the unicode property functions before WebTextRenderer
gets initialized.
Ensured guarantee that identifierForInitialRequest:fromDataSource: is called with
the first initial request.

Reviewed by maciej.

  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation canProvideDocumentSource]): (-[WebNetscapePluginRepresentation documentSource]):
  • WebCoreSupport.subproj/WebTextRenderer.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setIdentifier:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource controller]): (-[WebDataSource initialRequest]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading:]): (-[WebDataSource _originalRequest]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): (-[WebHTMLRepresentation canProvideDocumentSource]):
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]):
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation canProvideDocumentSource]): (-[WebImageRepresentation documentSource]):
  • WebView.subproj/WebTextRepresentation.h:
  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation dealloc]): (-[WebTextRepresentation setDataSource:]): (-[WebTextRepresentation finishedLoadingWithDataSource:]): (-[WebTextRepresentation canProvideDocumentSource]): (-[WebTextRepresentation documentSource]):

WebBrowser:

Make us of new canProvideDocumentSource API, replacing somewhat
klunky usage of isDocumentHTML.

Reviewed by maciej.

  • BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument source]):
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
  • HTMLSourceDocument.m: (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument setDataSource:]):
11:28 AM Changeset in webkit [3545] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the encoded filename
10:41 AM Changeset in webkit [3544]
  • 16 copies
    1 delete in tags/Safari-57

This commit was manufactured by cvs2svn to create tag 'Safari-57'.

10:41 AM Changeset in webkit [3543] by sheridan
  • 8 edits in branches/Safari-0-8-2-branch

Safari-57 versionstamp

9:38 AM Changeset in webkit [3542] by darin
  • 3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-30 Trey Matteson <​trey@apple.com>

3161486 - REGRESSION: double click on a widget causes crash

Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.

The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.

Reviewed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.
9:02 AM Changeset in webkit [3541] by darin
  • 9 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3146862 -- meta http-equiv refresh with a space before the delay does not work
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Fix code that was trying to use positions within the whitespace-stripped string, but extracting substrings from the non-stripped original.
  • tweaks to render tree dumping format
  • khtml/rendering/render_block.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
  • khtml/rendering/render_block.cpp: (RenderBlock::renderName): Use the string RenderBlock instead of the string Block for consistency with all the other renderName results.
  • khtml/rendering/render_inline.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
  • khtml/rendering/render_inline.cpp: (RenderInline::renderName): Use the string RenderInline instead of the string Inline for consistency with all the other renderName results.
  • khtml/rendering/render_text.h: Make textSlaves() a const member function.
  • kwq/KWQRenderTreeDebug.cpp: (operator<<): Format rectangles as "x at (1,2) size 3x4" rather than "(1,2,3,4)". (quoteAndEscapeNonPrintables): Added. Makes it easy to turn an arbitrary Unicode string into something that's all ASCII. (writeTextSlave): Change this so it also writes out the text. (write): Call the new writeTextSlave, and also use "layer" instead of "RenderLayer".

Feb 1, 2003:

5:29 PM Changeset in webkit [3540] by darin
  • 3 edits in trunk/WebCore
  • fix mistake that broke build
  • khtml/rendering/render_block.h: Add include of <qsortedlist.h>.
5:02 PM Changeset in webkit [3539] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin and Ken.

  • fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): No need to assert that the controller is not deferred if this is a handle being used for a download. (-[WebMainResourceClient handle:didReceiveData:]): Likewise. (-[WebMainResourceClient handleDidFinishLoading:]): Likewise. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Likewise.
4:51 PM Changeset in webkit [3538] by darin
  • 12 edits in trunk/WebCore

Reviewed by Dave.

  • reduced the amount of RenderFlow in the world by about 1/2
  • khtml/rendering/bidi.h: Take RenderBlock * instead of RenderFlow *.
  • khtml/rendering/bidi.cpp: (BidiIterator::BidiIterator): Take RenderBlock * instead of RenderFlow *. (RenderBlock::layoutInlineChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::findNextLineBreak): Fix debug message to say RenderBlock instead of RenderFlow.
  • khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Make RenderBlock * instead of RenderFlow *. (RenderBlock::layout): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::layoutBlockChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::clearFloats): Fix debug message to say RenderBlock instead of RenderFlow.
  • khtml/rendering/render_flow.h: Return a RenderFlow * instead of a RenderObject * from createFlow.
  • khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): Use an if statement instead of ? : to get rid of typecasting.
  • khtml/rendering/render_html.cpp: (RenderHtml::containingBlockWidth): Fix parent call to call RenderBlock. Calling RenderFlow was a mistake, but one that didn't matter since the actual method isn't implemented until up in RenderBox anyway.
  • khtml/rendering/render_inline.h: Change some parameters to RenderBlock *.
  • khtml/rendering/render_inline.cpp: (cloneInline): Make this return a RenderInline * instead of a RenderFlow *. (RenderInline::splitInlines): Change some parameters to RenderBlock * and locals to RenderInline *. (RenderInline::splitFlow): Change some parameters and locals to RenderBlock *.
  • khtml/rendering/render_layer.h: Remove forward declaration of class RenderFlow.
  • khtml/rendering/render_object.h: Remove forward declaration and friend declaration of class RenderFlow.
1:39 PM Changeset in webkit [3537] by trey
  • 12 edits
    2 adds in trunk

WebCore:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New SPI is exposed over the bridge and KWQTextField passes the text delegate msgs to it.

Reviewed by Richard

  • kwq/KWQTextField.mm: Pass text delegate msgs through new SPI. (-[KWQTextField controlTextDidBeginEditing:]): (-[KWQTextField controlTextDidEndEditing:]): (-[KWQTextField controlTextDidChange:]): (-[KWQTextField control:textShouldBeginEditing:]): (-[KWQTextField control:textShouldEndEditing:]): (-[KWQTextField control:didFailToFormatString:errorDescription:]): (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextField control:isValidObject:]): (-[KWQTextField control:textView:doCommandBySelector:]):
  • kwq/WebCoreBridge.h: New SPI for passing text delegate msgs.

WebKit:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New private API is exposed for the app to set a WebFormDelegate.

Reviewed by Richard

  • WebCoreSupport.subproj/WebBridge.m: Pass msgs from WC on to the controller's FormDelegate. (formDelegate): Little utility function. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
  • WebKit.exp: New class exported.
  • WebKit.pbproj/project.pbxproj: New WebFormDelegate files.
  • WebView.subproj/WebControllerPrivate.h: API to set/get FormDelegate.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _setFormDelegate:]): simple setter (-[WebController _formDelegate]): simple getter
  • WebView.subproj/WebFormDelegate.h: Added.
  • WebView.subproj/WebFormDelegate.m: Added. NOP impls for all these delegate methods. (-[WebFormDelegate controlTextDidBeginEditing:inFrame:]): (-[WebFormDelegate controlTextDidEndEditing:inFrame:]): (-[WebFormDelegate controlTextDidChange:inFrame:]): (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]): (-[WebFormDelegate control:textShouldEndEditing:inFrame:]): (-[WebFormDelegate control:didFailToFormatString:errorDescription:inFrame:]): (-[WebFormDelegate control:didFailToValidatePartialString:errorDescription:inFrame:]): (-[WebFormDelegate control:isValidObject:inFrame:]): (-[WebFormDelegate control:textView:doCommandBySelector:inFrame:]):

WebBrowser:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

This is mostly using new API, with a couple autocomplete fixes for newly exposed issues.

Reviewed by Richard

  • BrowserWindowController.h: New formDelegate ivar.
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Create FormDelegate, an internal helper object to field WebFormDelegate messages. (-[BrowserWindowController dealloc]): Release FormDelegate. (-[BrowserWindowController controlTextDidEndEditing:]): Pass msg on to completion controller. (-[FormDelegate initWithController:]): Create CompletionController to do autocomplete (commented out for now). (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidChange:inFrame:]): Pass msg on to completion controller. (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Pass msg on to completion controller.
  • CompletionController.h: Added controlTextDidBeginEditing: Should have been receiving this all along.
  • CompletionController.m: (-[CompletionController _buildUI]): Set TableView font to match the textfield. (-[CompletionController _positionWindow]): Position window relative to TextField, not enclosing ScrollView (bogus code that's a NOP for the locationField). (-[CompletionController controlTextDidEndEditing:]): Hide the completion window when we leave the field.

Jan 31, 2003:

6:30 PM Changeset in webkit [3536] by hyatt
  • 3 edits in trunk/WebCore

Fix regression that broke John's site. RenderInline needs
to implement childrenInline() so that it can return true.
I pulled this method out of RenderFlow and into RenderBlock,
which caused RenderInline to use RenderObject's method (and
that one returns false).

Reviewed by rjw

  • khtml/rendering/render_inline.h:
5:44 PM Changeset in webkit [3535] by hyatt
  • 3 edits in trunk/WebCore

Fix for crash on espn.com. Revert my change to make
containingBlock() return 0 for the root. Put it back to the
old behavior, where the root returns itself when you ask for
the root's containing block.

Reviewed by rjw

  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):
5:13 PM Changeset in webkit [3534] by hyatt
  • 3 edits in trunk/WebCore

Two whitespace handling fixes that improve <pre> handling,
especially of inline pres.

Reviewed by rjw.

  • khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):
4:31 PM Changeset in webkit [3533]
  • 15 copies
    1 delete in tags/Safari-56

This commit was manufactured by cvs2svn to create tag 'Safari-56'.

4:31 PM Changeset in webkit [3532] by sheridan
  • 8 edits in branches/Safari-0-8-2-branch

Safari-56 version stamp

3:14 PM Changeset in webkit [3531] by darin
  • 3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Richard.

  • khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.
3:13 PM Changeset in webkit [3530] by darin
  • 3 edits in trunk/WebCore

Reviewed by Richard.

  • khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.
2:06 PM Changeset in webkit [3529] by darin
  • 4 edits
    1 delete in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

  • Resources/Info.plist: Removed unused file.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by me, Dave wrote the code.

  • fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Dave.

  • fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.
1:47 PM Changeset in webkit [3528] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • Resources/Info.plist: Removed unused file.
1:44 PM Changeset in webkit [3527] by hyatt
  • 26 edits
    4 adds in trunk/WebCore

Split RenderFlow into subclasses: RenderInline and RenderBlock.
This change should make inlines a lot smaller (since nearly all
of the member variables in RenderFlow moved into RenderBlock).

It also simplifies methods like containingBlock(), which can
now return a RenderBlock.

Reviewed by darin

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp: (RenderBlock::bidiReorderLine): (RenderBlock::layoutInlineChildren): (RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: Added. (:RenderFlow): (RenderBlock::~RenderBlock): (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::makeChildrenNonInline): (RenderBlock::removeChild): (RenderBlock::layout): (RenderBlock::layoutBlockChildren): (RenderBlock::layoutSpecialObjects): (RenderBlock::paint): (RenderBlock::paintObject): (RenderBlock::paintFloats): (RenderBlock::insertSpecialObject): (RenderBlock::removeSpecialObject): (RenderBlock::positionNewFloats): (RenderBlock::newLine): (RenderBlock::leftOffset): (RenderBlock::leftRelOffset): (RenderBlock::rightOffset): (RenderBlock::rightRelOffset): (RenderBlock::lineWidth): (RenderBlock::nearestFloatBottom): (RenderBlock::floatBottom): (RenderBlock::lowestPosition): (RenderBlock::rightmostPosition): (RenderBlock::leftBottom): (RenderBlock::rightBottom): (RenderBlock::clearFloats): (RenderBlock::addOverHangingFloats): (RenderBlock::checkClear): (RenderBlock::nodeAtPoint): (RenderBlock::calcMinMaxWidth): (next): (RenderBlock::calcInlineMinMaxWidth): (RenderBlock::calcBlockMinMaxWidth): (RenderBlock::close): (RenderBlock::printTree): (RenderBlock::dump):
  • khtml/rendering/render_block.h: Added.
  • khtml/rendering/render_body.cpp: (RenderBody::RenderBody): (RenderBody::setStyle): (RenderBody::layout): (RenderBody::availableHeight):
  • khtml/rendering/render_body.h:
  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth): (RenderBox::calcHeight):
  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
  • khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): (RenderFlow::addChildWithContinuation):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml): (RenderHtml::setStyle): (RenderHtml::layout):
  • khtml/rendering/render_html.h:
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: Added. (:RenderFlow): (RenderInline::~RenderInline): (RenderInline::setStyle): (RenderInline::addChildToFlow): (cloneInline): (RenderInline::splitInlines): (RenderInline::splitFlow): (RenderInline::paint): (RenderInline::paintObject): (RenderInline::calcMinMaxWidth): (RenderInline::offsetWidth): (RenderInline::offsetHeight): (RenderInline::offsetLeft): (RenderInline::offsetTop):
  • khtml/rendering/render_inline.h: Added.
  • khtml/rendering/render_list.cpp: (RenderListItem::RenderListItem): (RenderListItem::setStyle): (getParentOfFirstLineBox): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout): (RenderListItem::paint): (RenderListItem::paintObject):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::containingBlock): (RenderObject::setOverhangingContents): (RenderObject::removeFromSpecialObjects):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::calcMinMaxWidth): (RenderRoot::layout): (RenderRoot::paintObject):
  • khtml/rendering/render_root.h:
  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::lineHeight): (RenderTable::baselinePosition): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::recalcSections): (RenderTable::dump): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::close): (RenderTableCell::repaintRectangle): (RenderTableCell::absolutePosition): (RenderTableCell::setStyle): (RenderTableCell::dump):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
1:13 PM Changeset in webkit [3526] by darin
  • 3 edits in trunk/WebCore

Reviewed by me, Dave wrote the code.

  • fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.
1:09 PM Changeset in webkit [3525] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.
12:55 PM Changeset in webkit [3524] by cblu
  • 7 edits in trunk

WebCore:

  • kwq/WebCoreBridge.mm: fixed key value

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • WebView.subproj/WebController.m: fixed key value

WebBrowser:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
9:38 AM Changeset in webkit [3523] by cblu
  • 14 edits in trunk

WebCore:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

  • kwq/WebCoreBridge.h: added WebCoreElementImageRectKey
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): get the rect of the image

WebKit:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): take a rect so we know the original size and origin
  • WebKit.exp: added WebElementImageRectKey
  • WebView.subproj/WebController.h: WebElementImageRectKey
  • WebView.subproj/WebController.m: WebElementImageRectKey
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): call _web_dragPromisedImage with WebElementImageRect
  • WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): provide the WebElementImageRect since we do this for other image elements (-[WebImageView mouseDragged:]): call _web_dragPromisedImage with [self bounds]
8:54 AM Changeset in webkit [3522] by trey
  • 4 edits in trunk/WebCore

3161088 - disabled select elements are not disabled when scrolling list used

We use a tableview delegate method to prevent the user from changing the
selection when disabled. Too bad tableviews don't know how to disable themselves.
We also condition the cell used for drawing to match our enabled state.

Reviewed by Maciej.

  • kwq/KWQListBox.h: Keep track of whether we are enabled.
  • kwq/KWQListBox.mm: (QListBox::QListBox): Init new flag. (QListBox::setEnabled): Set new flag. (QListBox::isEnabled): Getter for new flag. (-[KWQListBoxTableViewDelegate selectionShouldChangeInTableView:]): Disallow selection changes if disabled. (-[KWQListBoxTableViewDelegate tableView:willDisplayCell:forTableColumn:row:]): Enable cell based on our enabled state to get visual feedback of being disabled.
Note: See TracTimeline for information about the timeline view.