Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Mar 27, 2003:

6:17 PM Changeset in webkit [3952] by hyatt

• 5 edits in trunk/WebCore

A collection of fixes for tables.

(1) Fixed table layout should only be used if an explicit width
is specified on a table.
(2) width="0" and height="0" should be ignored on table cells!
(3) Fixed table layout wasn't spreading extra space over
columns.

Reviewed by mjs

• khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseAttribute):
• khtml/rendering/render_table.cpp: (RenderTable::setStyle):
• khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):

3:43 PM Changeset in webkit [3951] by hyatt

• 3 edits in trunk/WebCore

Fix for the top of directory.apple.com. Only use the fixed
width on the cell (with nowrap set) if it is *larger* than
our current minwidth.

Reviewed by darin

• khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):

3:38 PM Changeset in webkit [3950] by cblu

• 2 edits in trunk/WebKit

Left out a "!" in my last check-in.

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

3:05 PM Changeset in webkit [3949] by hyatt

• 6 edits in trunk/WebCore

Fix for 3166374. When a float is removed, crawl up and down the
tree looking for blocks that contain the float and dirty them all.

Reviewed by darin

• ChangeLog:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_object.cpp: (RenderObject::markAllDescendantsWithFloatsForLayout): (RenderObject::removeFromObjectLists):
• khtml/rendering/render_object.h:

2:57 PM Changeset in webkit [3948] by cblu

• 2 edits in trunk/WebKit

• Allow Netscape plug-ins that don't have resource files to load in Safari.
• Added more error handling when loading plug-ins.

Reviewed by darin.

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

2:49 PM Changeset in webkit [3947] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Darin.

• fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
• fixed 3098365 - Default window size changes as a result of popup windows
• fixed 3189291 - javascript window.close() closes window, not just originating tab

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Close via the bridge, not the window directly. (KWQKHTMLPart::bridgeForWidget): Take const QWidget * instead of QWidget *. (KWQKHTMLPart::nodeForWidget): Likewise. (KWQKHTMLPart::khtmlMousePressEvent): Deal with responder issues via bridge, not window directly. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Likewise. (KWQKHTMLPart::mouseDown): Likewise.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set resizability via bridge, not window directly.
• kwq/KWQTextArea.mm: (-[KWQTextArea becomeFirstResponder]): Deal with bridge for first responder issues, not window directly. (-[KWQTextArea drawRect:]): Likewise. (-[KWQTextAreaTextView insertTab:]): Likewise. (-[KWQTextAreaTextView insertBacktab:]): Likewise. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Likewise. (-[KWQTextAreaTextView selectedTextAttributes]): Likewise.
• kwq/KWQWidget.mm: (QWidget::setActiveWindow): Focus window via bridge. (QWidget::hasFocus): Handle first responder issues via bridge. (QWidget::setFocus): Likewise. (QWidget::isVisible): Get window from bridge. (QWidget::mapFromGlobal): Get window from bridge. (QWidget::disableFlushDrawing): Add comment noting why it's OK to get the window from the view instead of from the bridge here. (QWidget::enableFlushDrawing): Likewise.
• kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Work through bridge, not window directly. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::setFrameGeometry): Likewise.
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

• fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
• fixed 3098365 - Default window size changes as a result of popup windows
• fixed 3189291 - javascript window.close() closes window, not just originating tab

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowIsResizable:]): New bridge method, implemented by calling window operations delegate. (-[WebBridge windowIsResizable]): Likewise. (-[WebBridge firstResponder]): Likewise. (-[WebBridge makeFirstResponder:]): Likewise. (-[WebBridge closeWindow]): Likewise.

WebBrowser:

Reviewed by Darin.

• fixed 3189291 - javascript window.close() closes window, not just originating tab

• BrowserWebController.m: (-[BrowserWebController windowController]): Moved this method higher. (-[BrowserWebController webViewCloseWindow:]): Close the tab, not the window.
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController closeTabForWebController:]): New method, closes tab or window if there is only one tab.

2:24 PM Changeset in webkit [3946] by kocienda

• 29 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• HeaderView/DocumentController.m:
• IBViewer/DocumentController.m:
• PDFBundle/PDFView.h:
• PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFResourceDelegate resource:didReceiveResponse:]): (-[PDFResourceDelegate resource:didReceiveData:]): (-[PDFResourceDelegate resourceDidFinishLoading:]): (-[PDFResourceDelegate resource:didFailLoadingWithError:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
• SimpleViewer/DocumentController.m:

WebFoundation:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• CacheLoader.subproj/NSURLResponse.h:
• CacheLoader.subproj/WebCacheManager.m:
• CacheLoader.subproj/WebProtocol.m: (-[WebProtocol initWithProtocolClient:request:]):
• CacheLoader.subproj/WebResourceDelegate.h:
• CacheLoader.subproj/WebSynchronousDelegate.h:
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate resource]): (-[WebSynchronousDelegate resource:willSendRequest:]): (-[WebSynchronousDelegate resourceDidFinishLoading:]): (-[WebSynchronousDelegate resource:didReceiveResponse:]): (-[WebSynchronousDelegate resource:didReceiveData:]):
• CacheLoader.subproj/WebSynchronousResult.h:
• CookieManager.subproj/WebCookieManager.m: (runningOnLoadThread): (-[WebCookieManager _scheduleSetupOnLoadThread]):
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebFoundationLogging.h:
• Misc.subproj/WebFoundationLogging.m:
• Misc.subproj/WebFoundationPrivate.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol deallocateCFNetworkResources]): (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): (-[WebCFNetworkHTTPProtocol handleReadStreamEvent:event:]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoadingWithCacheObject:]): (-[WebFTPProtocol stopLoading]):
• ProtocolHandlers.subproj/WebFileProtocol.m:
• ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m: (-[WebSSLProxyWrapperStream cancel]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (WebSimpleHTTPProtocolInit):
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]): (-[WebDownload resource:willSendRequest:]): (-[WebDownload resource:didReceiveResponse:]): (-[WebDownload resource:didReceiveData:]): (-[WebDownload resourceDidFinishLoading:]): (-[WebDownload resource:didFailLoadingWithError:]):
• Downloads.subproj/WebDownloadPrivate.h:
• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resourceDidFinishLoading:]): (-[WebIconLoader resource:willSendRequest:]): (-[WebIconLoader resource:didReceiveResponse:]): (-[WebIconLoader resource:didReceiveData:]): (-[WebIconLoader resource:didFailLoadingWithError:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream resource:didReceiveResponse:]): (-[WebNetscapePluginStream resource:didReceiveData:]): (-[WebNetscapePluginStream resourceDidFinishLoading:]): (-[WebNetscapePluginStream resource:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:willSendRequest:]): (-[WebSubresourceClient resource:didReceiveResponse:]): (-[WebSubresourceClient resource:didReceiveData:]): (-[WebSubresourceClient resourceDidFinishLoading:]): (-[WebSubresourceClient resource:didFailLoadingWithError:]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]): (-[WebResourceDelegateProxy setDelegate:]): (-[WebResourceDelegateProxy resource:willSendRequest:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]): (-[WebResourceDelegateProxy resource:didReceiveData:]): (-[WebResourceDelegateProxy resourceDidFinishLoading:]): (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]):
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
• BugReportController.h:
• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]): (-[BugReportController resource:didReceiveResponse:]): (-[BugReportController resource:didReceiveData:]): (-[BugReportController resourceDidFinishLoading:]): (-[BugReportController resource:didFailLoadingWithError:]):
• ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
• DownloadMonitor.m:
• LoadProgressMonitor.h:
• LoadProgressMonitor.m:
• LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]):
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):

1:45 PM Changeset in webkit [3945] by rjw

• 5 edits in trunk/WebKit

WebKit:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (-[WebHistory initWithContentsOfURL:]): (-[WebHistory URL]):
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate initWithContentsOfURL:]): (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate _loadHistoryGuts:]): (-[WebHistoryPrivate loadHistory]): (-[WebHistoryPrivate _saveHistoryGuts:]): (-[WebHistoryPrivate URL]): (-[WebHistoryPrivate saveHistory]):

WebBrowser:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

• Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
• GlobalHistory.m: (-[GlobalHistory init]):

12:24 PM Changeset in webkit [3944] by darin

• 3 edits in trunk/WebKit

Reviewed by Shelley.

• fixed 3157067 -- Pier1.com doesn't load; Microsoft VBScript runtime error in user-agent checking code

Besides this fix, I also filed an evangelism bug, bug 3210612.

• WebView.subproj/WebUserAgentSpoofTable.gperf: Added pier1.com.
• WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

11:59 AM Changeset in webkit [3943] by kocienda

• 12 edits in trunk/WebKit

Tools:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

• WebDiskCacheInspector/Controller.m: (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):

Tests:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

• SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.
Includes these method name changes:

replacemethod "resultCode" with "statusCode"
replacemethod "setResultCode:" with "setStatusCode:"
replacemethod "localizedStringForResultCode:" with "localizedStringForStatusCode:"
replacemethod "isErrorResultCode:" with "isErrorStatusCode:"
replacemethod "contentType" with "MIMEType" /* for NSURLResponse */
replacemethod "contentLength" with "expectedContentLength"
replacemethod "setContentType:" with "setMIMEType:"
replacemethod "setContentLength:" with "setExpectedContentLength:"

Other changes:

Bumped NSURLResponseVersion.
Removed WebError from NSURLResponse. Error object now tracked in WebResource.
Moved NSHTTPURLResponse into NSURLResponse header.
Bumped WebCacheObjectVersion.

• CacheLoader.subproj/NSURLResponse.h:
• CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponseInternal init]): (-[NSURLResponseInternal dealloc]): (-[NSURLResponse initWithCoder:]): (-[NSURLResponse encodeWithCoder:]): (-[NSURLResponse MIMEType]): (-[NSURLResponse expectedContentLength]): (-[NSURLResponse setExpectedContentLength:]): (-[NSURLResponse setMIMEType:]): (-[NSURLResponse createdDate]): (-[NSURLResponse lastModifiedDate]): (-[NSHTTPURLResponseInternal initWithCoder:]): (-[NSHTTPURLResponseInternal encodeWithCoder:]): (-[NSHTTPURLResponseInternal dealloc]): (-[NSHTTPURLResponse init]): (-[NSHTTPURLResponse initWithCoder:]): (-[NSHTTPURLResponse encodeWithCoder:]): (-[NSHTTPURLResponse allHeaderFields]): (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (-[NSHTTPURLResponse setHeader:]): (-[NSHTTPURLResponse dealloc]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
• CacheLoader.subproj/NSURLResponsePrivate.h:
• CacheLoader.subproj/WebCacheObject.m:
• CacheLoader.subproj/WebMutableResponse.h:
• CacheLoader.subproj/WebResource.m: (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _sendDidFailLoadingCallback]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource _responseAvailable:]): (-[WebResource _didLoadBytes:length:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource _setError:]): (-[WebResourceInternal dealloc]): (-[WebResourceInternal failedWithError:]):
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate result]):
• Misc.subproj/WebFoundation.h:
• ProtocolHandlers.subproj/NSHTTPURLResponse.h:
• ProtocolHandlers.subproj/NSHTTPURLResponse.m: (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
• ProtocolHandlers.subproj/NSHTTPURLResponsePrivate.h:
• ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
• ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
• ProtocolHandlers.subproj/WebHTTPProtocol.h:
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol sendResponseAvailableCallback]): (-[WebHTTPProtocol canStoreCacheObject:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _processHTTPResultCode]):
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

• Downloads.subproj/WebDownload.m:
• Misc.subproj/WebNSURLResponseExtras.m: (-[NSURLResponse suggestedFilenameForSaving]): (-[NSHTTPURLResponse suggestedFilenameForSaving]):
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): (-[WebDataSource _commitIfReady:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): (-[WebFrame _loadItem:fromItem:withLoadType:]):
• WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]):
• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]):
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):

WebBrowser:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

• BrowserDocument.m: (-[BrowserDocument fileType]):
• DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]):
• LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
• ResourceProgressEntry.h:
• ResourceProgressEntry.m: (-[ResourceProgressEntry statusCode]): (-[ResourceProgressEntry setStatusCode:]): (-[ResourceProgressEntry statusString]):

11:26 AM Changeset in webkit [3942] by hyatt

• 3 edits in trunk/WebCore

This is just a long-standing screwup where I didn't port an old
table fix I made to Lars' new table code properly. The original
fix had this check in it.

The bug is 3171963 (cvs.com).

Reviewed by darin

• khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

10:52 AM Changeset in webkit [3941] by darin

• 4 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3156509 -- Safari fills src="" frame with current contents of frameset instead of leaving it empty

The trick here is to always use "about:blank" when the frame URL is empty string.
If we pass the empty string elsewhere, it's going to get passed to completeURL and
turned into a reference to the current document, and we have to avoid doing that
ourselves explicitly too.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::HTMLFrameElementImpl): Let the URL default to null rather than "about:blank". We do want to treat the frame as "about:blank", but that's not something people should see when inspecting the frame via the DOM. (HTMLFrameElementImpl::isURLAllowed): Allow empty URLs explicitly, so we don't call completeURL on them. (HTMLFrameElementImpl::updateForNewURL): Map empty URLs to "about:blank" at this level. (HTMLFrameElementImpl::attach): Do the same thing here. At some point we can share more code between these two. (HTMLFrameElementImpl::setLocation): Change this to call updateForNewURL. Not only does this make us handle the empty URL case properly, it also gets the benefit of other things we do in updateForNewURL, like handling the "isURLAllowed" rule, and properly handling the case where we already have a suitable frame.

• other changes

• kwq/KWQKHTMLView.mm: Improved a comment.

10:39 AM Changeset in webkit [3940] by sheridan

• 3 edits in trunk

Safari-70u ... tree's open again

10:24 AM Changeset in webkit [3939]

• 3 copies in branches/Safari-70-branch

This commit was manufactured by cvs2svn to create branch
'Safari-70-branch'.

10:24 AM Changeset in webkit [3938]

• 3 copies in tags/Safari-70-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-70-anchor'.

10:24 AM Changeset in webkit [3937]

• 3 copies in branches/Safari-69~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-69~1-branch'.

10:24 AM Changeset in webkit [3936]

• 3 copies in tags/Safari-69~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-69~1-anchor'.

10:24 AM Changeset in webkit [3935]

• 3 copies in tags/Safari-69

This commit was manufactured by cvs2svn to create tag 'Safari-69'.

10:24 AM Changeset in webkit [3934] by sheridan

• 8 edits in trunk

Safari-69 stamp

Mar 26, 2003:

8:05 PM Changeset in webkit [3933] by rjw

• 6 edits in trunk/WebKit

File name change WebPluginError.[hm] -> WebPlugInError.[hm]

• Misc.subproj/WebKit.h:
• Plugins.subproj/WebNullPluginView.m:
• Plugins.subproj/WebPlugInError.h:
• Plugins.subproj/WebPluginError.h: Removed.
• Plugins.subproj/WebPluginError.m: Removed.
• Plugins.subproj/WebPluginErrorPrivate.h:
• WebKit.pbproj/project.pbxproj:

7:05 PM Changeset in webkit [3932] by rjw

• 10 edits in trunk/WebKit

WebKit:

WebPreferences API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled
allowAnimatedImageLooping -> allowsAnimatedImageLooping
setAllowAnimatedImageLooping -> setAllowsAnimatedImageLooping
allowAnimatedImages -> allowsAnimatedImages
setAllowAnimatedImages -> setAllowsAnimatedImages

Made WebHistoryItem's ivars private.

WebPluginError API changes:

pluginPageURL -> plugInPageURLString
contentURL -> contentURLString

Reviewed by cblu.

• API-Issues.rtf:
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem init]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setDisplayTitle:]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedDate]): (-[WebHistoryItem hash]): (-[WebHistoryItem anchor]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem parent]): (-[WebHistoryItem setURL:]): (-[WebHistoryItem setOriginalURLString:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setParent:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem documentState]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]): (-[WebHistoryItem setAnchor:]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem setIsTargetItem:]): (-[WebHistoryItem _recurseToFindTargetItem]): (-[WebHistoryItem targetItem]): (-[WebHistoryItem formData]): (-[WebHistoryItem setFormData:]): (-[WebHistoryItem formContentType]): (-[WebHistoryItem setFormContentType:]): (-[WebHistoryItem formReferrer]): (-[WebHistoryItem setFormReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem addChildItem:]): (-[WebHistoryItem childItemWithName:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem alwaysAttemptToUsePageCache]): (-[WebHistoryItem _scheduleRelease]): (-[WebHistoryItem setHasPageCache:]): (-[WebHistoryItem pageCache]):
• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURLString]):
• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences isJavaEnabled]): (-[WebPreferences setIsJavaEnabled:]): (-[WebPreferences isJavaScriptEnabled]): (-[WebPreferences setIsJavaScriptEnabled:]): (-[WebPreferences javaScriptCanOpenWindowsAutomatically]): (-[WebPreferences arePlugInsEnabled]): (-[WebPreferences setArePlugInsEnabled:]): (-[WebPreferences allowsAnimatedImages]): (-[WebPreferences allowsAnimatedImageLooping]): (-[WebPreferences setAllowsAnimatedImageLooping:]): (-[WebPreferences setLoadsImagesAutomatically:]): (-[WebPreferences loadsImagesAutomatically]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebBrowser:

WebPrefernces API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
pluginPageURL -> plugInPageURLString
contentURL -> contentURLString
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled

Reviewed by cblu.

• AppController.m: (-[AppController validateUserInterfaceItem:]): (-[AppController toggleJavaScriptCanNotOpenWindows:]):
• LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences toggleJavaScriptCanOpenWindows:]): (-[SecurityPreferences updateJavaScriptViews]): (-[SecurityPreferences togglePluginsEnabled:]): (-[SecurityPreferences initializeFromDefaults]):

6:56 PM Changeset in webkit [3931] by mjs

• 3 edits in trunk/WebCore

Reviewed by Chris.

• fix unitialized access.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart):

5:57 PM Changeset in webkit [3930] by mjs

• 12 edits in trunk/WebCore

Reviewed by Trey.

Made progress towards better handling of window operations.

• khtml/ecma/kjs_window.cpp: (Window::get): Replace a few part->widget() calls with part->view() -- just as good for the real khtml, but easier to adapt to with KWQ. (WindowFunc::tryCall): Likewise.
• khtml/khtmlview.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): Delete the window widget. (KWQKHTMLPart::topLevelWidget): Return the window widget. (KWQKHTMLPart::setBridge): Make a new window widget passing it the bridge.
• kwq/KWQKHTMLView.mm: (KHTMLView::topLevelWidget): Moved here from KHTMLView; get the top level widget from the part. (KHTMLView::mapToGlobal): Moved here from KHTMLView; add a needed cast.
• kwq/KWQWidget.h:
• kwq/KWQWidget.mm: Remove all top level widget considerations.
• kwq/KWQWindowWidget.h:
• kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Changed to work based on bridge, not window. (KWQWindowWidget::~KWQWindowWidget): Ditto. (KWQWindowWidget::frameGeometry): Ditto. (KWQWindowWidget::mapToGlobal): Ditto. (KWQWindowWidget::mapFromGlobal): Ditto. (KWQWindowWidget::setFrameGeometry): Ditto.

Also:

• kwq/KWQKHTMLPart.cpp: Removed stuff that did not belong here.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::selectionStartOffset): Moved here from KWQKHTMLPart.cpp (KWQKHTMLPart::selectionEndOffset): Likewise. (KWQKHTMLPart::selectionStart): Likewise. (KWQKHTMLPart::selectionEnd): Likewise. (KWQKHTMLPart::selectionRect): Likesie.

4:13 PM Changeset in webkit [3929] by darin

• 4 edits in trunk/WebCore

Reviewed by Trey.

• fixed a storage leak when running cvs-base

• khtml/rendering/render_list.h: Added _markerInstalledInParent.
• khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Set _markerInstalledInParent to false when creating a new marker. (RenderListItem::detach): Detach the marker if it's not not installed in the parent yet. (RenderListItem::updateMarkerLocation): Set _markerInstalledInParent to true when installing the marker in a parent.

3:41 PM Changeset in webkit [3928] by hyatt

• 3 edits in trunk/WebCore

Make <label> use tag list 1. Fixes 3206063. Residual style
changes called this out.

Reviewed by darin

• khtml/html/dtd.cpp: (DOM::checkChild):

3:12 PM Changeset in webkit [3927] by kocienda

• 39 edits
  2 deletes in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• Carbon/CarbonWeb/MyWebEventTypes.h:
• Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]):
• Carbon/CarbonWeb/TWebWindow.cp:
• Downloader/MyDocument.h:
• Downloader/MyDocument.m: (-[MyDocument download:didReceiveResponse:]):
• PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:didReceiveResponse:]):
• SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• CacheLoader.subproj/WebCacheObject.h:
• CacheLoader.subproj/WebCacheObject.m: (+[WebCacheObject cacheObjectWithResponse:]): (-[WebCacheObject initWithCoder:]): (-[WebCacheObject response]): (-[WebCacheObject setResponse:]):
• CacheLoader.subproj/WebProtocol.h:
• CacheLoader.subproj/WebProtocol.m:
• CacheLoader.subproj/WebProtocolClient.h:
• CacheLoader.subproj/WebResource.h:
• CacheLoader.subproj/WebResource.m: (-[WebResource _responseAvailable:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource response]): (-[WebResourceInternal response]): (-[WebResourceInternal responseAvailable:]):
• CacheLoader.subproj/WebResourceDelegate.h:
• CacheLoader.subproj/WebResourceQueue.m:
• CacheLoader.subproj/WebSynchronousDelegate.h:
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate response]): (-[WebSynchronousDelegate resource:didReceiveResponse:]):
• CacheLoader.subproj/WebSynchronousResult.h:
• CacheLoader.subproj/WebSynchronousResult.m: (-[WebSynchronousResult response]): (-[WebSynchronousResult _setResponse:]):
• CacheLoader.subproj/WebSynchronousResultPrivate.h:
• Misc.subproj/WebFoundation.h:
• ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
• ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
• ProtocolHandlers.subproj/WebHTTPProtocol.h:
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol canStoreCacheObject:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• Downloads.subproj/WebDownload.h:
• Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setResponse:]): (-[WebDownload resource:didReceiveResponse:]):
• Downloads.subproj/WebDownloadPrivate.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader resource:didReceiveResponse:]):
• Misc.subproj/WebKit.h:
• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream resource:didReceiveResponse:]):
• WebCoreSupport.subproj/WebBridge.m:
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:didReceiveResponse:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource response]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setResponse:]): (-[WebDataSource _commitIfReady:]): (-[WebDataSource _addResponse:]):
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]):
• WebView.subproj/WebFrameViewPrivate.m:
• WebView.subproj/WebHTMLRepresentation.m:
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]):
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebTextRepresentation.m:
• WebView.subproj/WebTextView.m:

WebBrowser:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

• BrowserDocument.m:
• BrowserWebController.m:
• BugReportController.m: (-[BugReportController resource:didReceiveResponse:]):
• DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]): (-[DownloadProgressEntry response]):
• HTMLSourceDocument.m:
• LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
• ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]):

11:38 AM Changeset in webkit [3926] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

11:29 AM Changeset in webkit [3925] by darin

• 3 edits in trunk/WebKit

Reviewed by Trey.

• fixed 3209091 -- REGRESSION: WebFrameView leak (world leak)

• WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): Use copy, not retain, on an incoming NSString parameter. (-[WebView initWithFrame:frameName:groupName:]): Release the WebFrameView after setting it up.

• other changes

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Put the bug workaround here inside an ifdef so we don't compile it in on Panther.

11:04 AM Changeset in webkit [3924] by cblu

• 6 edits in trunk/WebKit

Use the private _cfBundle method on NSBundle so we only create 1 bundle per plug-in package class.

Reviewed by trey.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): (-[WebBasePluginPackage dealloc]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromPLists]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]):
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage isLoaded]):

8:46 AM Changeset in webkit [3923] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3208468 -- REGRESSION: checkbox immediately unchecks the first time you check it

The stateChanged signal must be delivered before the mouse up event is handled.

• kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Use [self init] instead of [super init]; no real difference, just makes more logical sense. (-[KWQButton action:]): Don't send the mouse up event here. (-[KWQButton sendConsumedMouseUpIfNeeded]): Added. New method that sends the consumed mouse up event. (-[KWQButton mouseDown:]): Use a simplified scheme that uses only a single boolean to control sending the consumed mouse up event. Call sendConsumedMouseUpIfNeeded to do the deed. (QButton::clicked): Added comment to explain why it's important to send the consumed mouse up event here. Added a call to the new sendConsumedMouseUpIfNeeded method, replacing the code that was formerly in -[KWQButton action:].

8:28 AM Changeset in webkit [3922] by kocienda

• 10 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

• CacheLoader.subproj/NSURLRequest.m: (-[NSMutableURLRequest _parametersForWriting]):
• CacheLoader.subproj/NSURLRequestPrivate.h:

WebKit:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

• LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 25, 2003:

7:37 PM Changeset in webkit [3921] by rjw

• 14 edits in trunk/WebKit

WebKit:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

Changed userStyleSheetLocation to take/pass an NSURL.

Reviewed by Chris

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURL]): (-[WebPlugInError plugInName]):
• Plugins.subproj/WebPluginErrorPrivate.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]):
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

• API-Issues.rtf: notes to self

WebBrowser:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

• LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
• Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]):

6:40 PM Changeset in webkit [3920] by cblu

• 8 edits in trunk/WebKit

Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari

Reviewed by trey.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): tweak (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): moved up from WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): retain path, create bundle so subclasses don't have to do this work (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): was getMIMEInformation from WebPluginPackage (-[WebBasePluginPackage dealloc]): release the bundle (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): tweak
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): new (-[WebNetscapePluginPackage openResourceFile]): tweak (-[WebNetscapePluginPackage closeResourceFile:]): tweak (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): tweak (-[WebNetscapePluginPackage getPluginInfoFromResources]): was getMIMEInformation (-[WebNetscapePluginPackage pListForPath:createFile:]): new, calls BP_CreatePluginMIMETypesPreferences if createFile==YES (-[WebNetscapePluginPackage getPluginInfoFromPLists]): calls getPluginInfoFromBundleAndMIMEDictionary with the MIME dictionary from the user's home dir. (-[WebNetscapePluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromPLists and/or getPluginInfoFromResources (-[WebNetscapePluginPackage executableType]): tweak (-[WebNetscapePluginPackage load]): get the BP_CreatePluginMIMETypesPreferences symbol (-[WebNetscapePluginPackage unload]): tweak (-[WebNetscapePluginPackage dealloc]): tweak
• Plugins.subproj/WebPluginPackage.h:
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromBundleAndMIMEDictionary (-[WebPluginPackage viewFactory]): tweak (-[WebPluginPackage load]): call principalClass (-[WebPluginPackage isLoaded]): tweak
• Plugins.subproj/npapi.h: added declaration for the BP_CreatePluginMIMETypesPreferences function pointer.

5:11 PM Changeset in webkit [3919] by hyatt

• 5 edits in trunk/WebCore

Fix font-family parsing to match the spec (and other browsers).

This fixes bugs 3197584 and 3207760.

Also fix pseudos to be lower-cased. Fixes 3208303.

Reviewed by darin

• khtml/css/css_valueimpl.h:
• khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):

2:43 PM Changeset in webkit [3918] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• WebKit part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

• WebView.subproj/WebDynamicScrollBarsView.h: replaced disallowsScrolling boolean ivar with separate booleans for disallowHorizontalScrolling and disallowVerticalScrolling

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): take the two disallow booleans into account separately (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]), (-[WebDynamicScrollBarsView allowsHorizontalScrolling]), (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]), (-[WebDynamicScrollBarsView allowsVerticalScrolling]): new methods, do the obvious (-[WebDynamicScrollBarsView setAllowsScrolling:]): changed to set both ivars (-[WebDynamicScrollBarsView allowsScrolling]): changed to return YES if scrolling is allowed in either direction

• WebKit.exp: exported symbol for WebDynamicScrollBarsView class name

WebBrowser:

• WebBrowser part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

• English.lproj/Browser.nib: changed class of scroll view around collections column to be WebDynamicScrollBarsView

• BookmarksViewController.m: (-[BookmarksViewController setUpBookmarkSourcesScrollView:]): new method, finds the dynamic scroll view enclosing the collections column, and turns off horizontal scrolling for it. (-[BookmarksViewController awakeFromNib:]): call setUpBookmarkSourcesScrollView

2:08 PM Changeset in webkit [3917] by kocienda

• 3 edits in trunk/WebKit

Reviewed by Richard

Fixed a bug that could occur in the new immutable/mutable
request scheme. When opening a javascript window, it was
possible for a request passed as a method argument to be
released during the course of a method, particularly
after that request was passed to willSendRequest:.
The solution is to ask the data source for its current
request rather than using the one stored in the method
argument.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient startLoading:]):

10:42 AM Changeset in webkit [3916] by trey

• 8 edits in trunk

JavaScriptCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be

additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

• JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

• WebFoundation.pbproj/project.pbxproj:

WebCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

• WebCore.pbproj/project.pbxproj:

WebKit:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

• WebKit.pbproj/project.pbxproj:

10:36 AM Changeset in webkit [3915] by kocienda

• 10 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Spilt NSURLRequest into the immutable and mutable variants
as specified by the approved API.

Updated other code to use NSMutableURLRequest where appropriate.

Also updated some comments in NSURLRequest.h and removed
obsolete WebRequestCachePolicyRevalidate NSURLRequestCachePolicy
constant.

• CacheLoader.subproj/NSURLRequest.h:
• CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest setURL:]): (-[NSMutableURLRequest setURL:]): (-[NSMutableURLRequest setCachePolicy:]): (-[NSMutableURLRequest setTimeoutInterval:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest mutableCopyWithZone:]):
• CacheLoader.subproj/WebResource.m: (-[WebResource loadWithDelegate:]): (-[WebResource _redirectedToRequest:permanent:]):
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol stateForCacheObject:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _addRequestMessageBody]):
• WebFoundation.exp:

WebKit:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource request]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]):
• WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):

WebBrowser:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

• BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]):
• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):

9:23 AM Changeset in webkit [3914] by darin

• 4 edits in trunk/WebKit

Reviewed by John.

• fixed 3205745 -- WebKit.framework's Localizable.strings file contains high ASCII in the Key definition.

• English.lproj/Localizable.strings: Regenerated with the new version of the extract-localizable-strings tool that uses \U syntax instead of "high ASCII".

• changed cursive font back to "Apple Chancery" for now

• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change to "Apple Chancery".
• English.lproj/StringsNotToBeLocalized.txt: Update for above change.

Mar 24, 2003:

6:36 PM Changeset in webkit [3913] by hyatt

• 7 edits in trunk/WebCore

Clean up isInlineFlow. Add a couple of new methods that I'll
be converting code over to use (carefully) piece by piece in
future patches.

Reviewed by gramps

• khtml/rendering/render_block.h:
• khtml/rendering/render_flow.h:
• khtml/rendering/render_inline.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle):
• khtml/rendering/render_object.h:

5:40 PM Changeset in webkit [3912] by darin

• 4 edits in trunk/WebKit

Reviewed by Dave.

• fixed 3206803 -- REGRESSION: Lucida Handwriting font doesn't work

• WebCoreSupport.subproj/WebTextRendererFactory.m: (acceptableChoice): Added. Returns NO if the weight/traits are no good. (betterChoice): Added. Returns YES if the new weight/traits are better than the old. (-[WebTextRendererFactory fontWithFamily:traits:size:]): Use the new functions to judge which font is good enough. Now it will accept an italic font if that's all we have.

• fixed 3206904 -- use "Lucida Handwriting" for "cursive" so it works on systems without Classic

• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change default from "Apple Chancery" to "Lucida Handwriting".

• English.lproj/StringsNotToBeLocalized.txt: Updated for this change.

5:23 PM Changeset in webkit [3911] by mjs

• 6 edits in trunk/WebKit

Reviewed by Richard.

• made API (actually doc-only) changes needed for 3087535 - bugzilla queries come back as downloaded files

• Downloads.subproj/WebDownload.h: Documented that download:didReceiveResponse: may be sent more than once.
• WebView.subproj/WebLocationChangeDelegate.h: Documented that locationChangeCommittedForDataSource: may be sent more than once.
• WebView.subproj/WebPolicyDelegate.h: Documented that decideContentPolicyForMIMEType:andRequest:inFrame: may be sent more than once.
• WebView.subproj/WebResourceLoadDelegate.h: Documented that resource:didReceiveResponse:fromDataSource: may be sent more than once.

5:13 PM Changeset in webkit [3910] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Richard.

• fixed 3083339 - significant top and side margin appended to new windows

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Account for distinction between frame and content rect.
• kwq/KWQStyle.h: Return 0 for the appropriate style to avoid adding extra padding when making a new window from JavaScript.
• kwq/WebCoreBridge.h: Prototype new methods.

WebKit:

Reviewed by Richard.

• fixed 3083339 - significant top and side margin appended to new windows

Part of the fix involves adding new window operation delegate methods.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowFrame:]): Tweaked code a bit. (-[WebBridge windowFrame]): Added. (-[WebBridge setWindowContentRect:]): Added. (-[WebBridge windowContentRect]): Added.
• WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented. (-[WebDefaultWindowOperationsDelegate webViewContentRect:]): Likewise.
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by Richard.

• fixed 3083339 - significant top and side margin appended to new windows

• BrowserWebController.m: (-[BrowserWebController webView:setFrame:]): Tweaked a bit. (-[BrowserWebController webViewFrame:]): Likewise. (-[BrowserWebController webView:setContentRect:]): Implemented. (-[BrowserWebController webViewContentRect:]): Likewise.

3:39 PM Changeset in webkit [3909] by hyatt

• 4 edits in trunk/WebCore

Fix for crash on www.lnt.com. 3199929 is the bug number.

Blocks must have all their kids as inlines or all theirs kids
as blocks. Floats and positioned elements are special and
disregarded when this check occurs.

If a float or positioned element suddenly becomes a normal flow
element again, then the parent block might have to make its kids
all be non-inline or it might have to wrap a normal flow inline
with an anonymous block.

This patch fixed RenderObject's setStyle method to check for
this situation and to make the parent block fix itself up
appropriately.

Reviewed by darin

• khtml/rendering/render_object.cpp: (RenderObject::setStyle):

2:56 PM Changeset in webkit [3908] by cblu

• 10 edits in trunk/WebKit

WebFoundation:

Reviewed by trey.

• types.plist: added text/qif (Quicken)

WebKit:

Fixed: 3155489 - Seed: PostScript files display instead of downloading, often as a blank page
Fixed: 3106251 - quicken file not downloaded, can't save manually

Reviewed by trey.

• WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): call [WebImageView supportedImageMIMETypes]
• WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewTypes]): call [WebImageView supportedImageMIMETypes]
• WebView.subproj/WebImageView.h:
• WebView.subproj/WebImageView.m: (+[WebImageView initialize]): was -initialize (oops) (+[WebImageView unsupportedImageMIMETypes]): new, AppKit images that we shouldn't display inline, includes ps and pdf (+[WebImageView supportedImageMIMETypes]): new, was in WebViewPrivate
• WebView.subproj/WebTextView.h:
• WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): renamed, added text/qif (quicken)
• WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call [WebTextView unsupportedTextMIMETypes]
• WebView.subproj/WebViewPrivate.h: removed _supportedImageMIMETypes
• WebView.subproj/WebViewPrivate.m: removed _supportedImageMIMETypes

2:37 PM Changeset in webkit [3907] by kocienda

• 14 edits in trunk/WebKit

WebFoundation:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

This involved some non-complicated changes in the
internals of NSURLRequest.

Note that NSURLRequestPrivate.h has taken on some methods
that used to be API, but were removed from the public
proposal. These methods are now available as SPI.

• CacheLoader.subproj/NSURLRequest.h:
• CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest initWithURL:cachePolicy:timeoutInterval:]): (-[NSURLRequest initWithURL:]): (-[NSURLRequest init]): (-[NSURLRequest URL]): (-[NSURLRequest timeoutInterval]): (-[NSURLRequest setURL:]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest setTimeoutInterval:]): (NSHTTPURLRequestInit): (-[NSURLRequest _parametersForReading]): (-[NSURLRequest _parametersForWriting]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest HTTPAllHeaderFields]): (-[NSURLRequest HTTPValueForHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest HTTPAllowSSLCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSURLRequest HTTPSetMethod:]): (-[NSURLRequest HTTPSetAllHeaderFields:]): (-[NSURLRequest HTTPSetValue:forHeaderField:]): (-[NSURLRequest HTTPAddValue:forHeaderField:]): (-[NSURLRequest HTTPSetBody:]): (-[NSURLRequest HTTPSetAllowSSLCertificatesWithUnknownRoots:]): (-[NSURLRequest HTTPSetContentType:]): (-[NSURLRequest HTTPSetCookiePolicyBaseURL:]): (-[NSURLRequest HTTPSetExtraCookies:]): (-[NSURLRequest HTTPSetPageNotFoundCacheLifetime:]): (-[NSURLRequest HTTPSetReferrer:]): (-[NSURLRequest HTTPSetUserAgent:]): (-[NSHTTPURLRequestRequestParameters copyWithZone:]): (-[NSHTTPURLRequestRequestParameters dealloc]): (-[NSHTTPURLRequestRequestParameters hash]): (-[NSHTTPURLRequestRequestParameters isEqual:]): (-[NSHTTPURLRequestRequestParameters description]):
• CacheLoader.subproj/NSURLRequestPrivate.h:
• CacheLoader.subproj/WebCacheManager.m:
• CacheLoader.subproj/WebResource.m: (-[WebResource _cacheKey]):
• CacheLoader.subproj/WebResponse.h:
• CacheLoader.subproj/WebResponse.m: (-[WebResponse contentType]): (-[WebResponse setContentType:]):
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebFoundation.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol addReferrerFieldToHeader]): (-[WebCFNetworkHTTPProtocol addUserAgentFieldToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addMessageBodyToRequest]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol shouldAttemptOriginLoad]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol stateForCacheObject:]):
• ProtocolHandlers.subproj/WebHTTPRequest.h: Removed.
• ProtocolHandlers.subproj/WebHTTPRequest.m: Removed.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.h:
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _canUsePersistentConnectionForRequest]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebKit, this amounts to name changes only.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge incomingReferrer]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebFrame.m: (-[WebFrame reload]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebBrowser, this amounts to name changes only.

• BrowserDocument.m:
• BrowserDocumentController.m:
• BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
• English.lproj/Localizable.strings:
• LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):

11:47 AM Changeset in webkit [3906] by hyatt

• 4 edits in trunk/WebCore

ignore the float property on first-letter styles.
The bug # is 3186044.

Reviewed by darin

• khtml/css/parser.cpp:
• khtml/rendering/render_block.cpp:

10:58 AM Changeset in webkit [3905] by hyatt

• 4 edits in trunk/WebCore

Add error-handling case to deal with a common CSS malformation:

clip: rect( )

The bug is 3206171.

Reviewed by darin

• khtml/css/parser.cpp:
• khtml/css/parser.y:

10:50 AM Changeset in webkit [3904] by darin

• 18 edits
  1 add in trunk

WebCore:

Reviewed by John.

• fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)

• kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::getRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.
• kwq/KWQPainter.mm: (QPainter::_updateRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.

• kwq/KWQTextRendererFactory.h: Added. Exposes a global variable that tells whether we are in global "using printer font" mode.
• kwq/WebCoreTextRendererFactory.h: Added setUsingPrinterFonts: and usingPrinterFonts methods.
• kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory setUsingPrinterFonts:]): Added. Sets global. (-[WebCoreTextRendererFactory usingPrinterFonts]): Added. Returns value of global.

• WebCore.pbproj/project.pbxproj: Added KWQTextRendererFactory.h.

WebKit:

Reviewed by John.

• fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)

• Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): Pass usingPrinterFont:NO, since this is used exclusively for on-screen text, not printing.
• Misc.subproj/WebStringTruncator.m: (truncateString): Ditto.

• WebCoreSupport.subproj/WebTextRenderer.h: Add usingPrinterFont boolean field and parameter to init.
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:forScreen:]): Add usingPrinterFont parameter, and get the screen font if it's NO, also store the boolean for later use. (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding: attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]): Pass the usingPrinterFont parameter through when getting a substitute font.

• WebCoreSupport.subproj/WebTextRendererFactory.h: Add separate caches for screen and printing text renderers. Add usingPrinterFont parameter to our rendererWithFont: method (the one inherited from WebCore still has no parameter).
• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory init]): Create both caches. (-[WebTextRendererFactory dealloc]): Release both caches. (-[WebTextRendererFactory rendererWithFont:]): Call the new rendererWithFont:usingPrinterFont: method, passing usingPrinterFonts from the WebCore side. Thus any fonts fetched by WebCore during printing are printing fonts, and otherwise they are screen fonts. (-[WebTextRendererFactory rendererWithFont:usingPrinterFont:]): Added. Has the code from the old rendererWithFont: method, but passes the usingPrinterFont parameter through to the WebTextRenderer init method.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't set unused canDragTo and canDragFrom fields. (-[WebHTMLView drawRect:]): Call -[WebTextRendererFactory setUsingPrinterFonts:] here if we are printing, as indicated by the usingPrinterFonts field. The reason we do this only inside drawRect is so we don't affect redraws of other HTML views that are not being printed that might be in "needs display" state when printing began. (-[WebHTMLView _setUsingPrinterFonts:]): Added. Calls _setUsingPrinterFonts on all WebHTMLViews inside this one, then does the work for this one. Uses the frame hierarchy rather than the view hierarchy, but either would work. If printer font state is changing, then sets the WebTextRendererFactory mode, then forces a layout and application of styles, but without triggering display. (-[WebHTMLView beginDocument]): Do an explicit display so this view does not have to be displayed while it is in "use printer fonts" mode. Then call _setUsingPrinterFonts:YES so that drawRect will use printer fonts, and also that the WebCore data structures and layout will be updated to reflect printer fonts as opposed to screen fonts. (-[WebHTMLView endDocument]): Call _setUsingPrinterFonts:NO to restore things to normal after printing.
• WebView.subproj/WebHTMLViewPrivate.h: Removed unused canDragTo, canDragFrom, and liveAllowsScrolling fields. Added usingPrinterFonts field.

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

10:40 AM Changeset in webkit [3903] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

• CacheLoader.subproj/NSURLRequest.h:
• CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithURL:]): (-[NSURLRequest cachePolicy]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest hash]): (-[NSURLRequest isEqual:]):
• CacheLoader.subproj/WebResource.m: (-[WebResource _finishedLoading]):

WebKit:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):

10:12 AM Changeset in webkit [3902] by kocienda

• 2 edits in trunk/WebKit

Tests:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

• Carbon/CarbonWeb/MyWebEventTypes.h:
• Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
• Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
• Carbon/CarbonWeb/TWebWindow.cp:

WebKit:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

• WebView.subproj/WebFramePrivate.m

9:29 AM Changeset in webkit [3901] by kocienda

• 42 edits in trunk/WebKit

Tests:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

• Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
• Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
• Carbon/CarbonWeb/TWebWindow.h:
• Downloader/MyDocument.m: (-[MyDocument downloadCancel:]): (-[MyDocument download:didStartFromRequest:]): (-[MyDocument download:willSendRequest:]):
• DumpBackForward/main.m: (dumpBackForward): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
• DumpRenderTree/main.m: (dumpRenderTree):
• HeaderView/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
• IBViewer/DocumentController.m: (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
• PDFBundle/PDFView.h:
• PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
• PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
• SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
• SnippetEditor/DataResourceRequest.h:
• SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]):

WebFoundation:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

In the repository:
Moved WebRequest.h to NSURLRequest.h
Moved WebRequest.m to NSURLRequest.m
Moved WebRequestPrivate.h to NSURLRequestPrivate.h

• CacheLoader.subproj/WebCacheManager.m:
• CacheLoader.subproj/WebProtocol.h:
• CacheLoader.subproj/WebProtocol.m: (+[WebProtocol partOfRequest:withClass:createIfDoesNotExist:]): (-[WebProtocol initWithProtocolClient:request:]): (-[WebProtocol request]):
• CacheLoader.subproj/WebProtocolClient.h:
• CacheLoader.subproj/WebResource.h:
• CacheLoader.subproj/WebResource.m: (-[WebResource initWithRequest:]): (+[WebResource sendSynchronousRequest:]): (+[WebResource canInitWithRequest:]): (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _beginLoad]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource request]): (-[WebResourceInternal request]): (-[WebResourceInternal redirectedToRequest:permanent:]):
• CacheLoader.subproj/WebResourceDelegate.h:
• CacheLoader.subproj/WebResourceQueue.m:
• CacheLoader.subproj/WebResponse.h:
• CacheLoader.subproj/WebSynchronousDelegate.h:
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate initWithRequest:monitor:]): (-[WebSynchronousDelegate resource:willSendRequest:]):
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebFoundation.h:
• ProtocolHandlers.subproj/WebAboutProtocol.m:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol initWithProtocolClient:request:]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol initWithProtocolClient:request:]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
• ProtocolHandlers.subproj/WebFileProtocol.m:
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]): (-[WebHTTPProtocol stateForCacheObject:]):
• ProtocolHandlers.subproj/WebHTTPRequest.h:
• ProtocolHandlers.subproj/WebHTTPRequest.m:
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol initWithProtocolClient:request:]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]):
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

• Downloads.subproj/WebDownload.h:
• Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setRequest:]): (-[WebDownload resource:willSendRequest:]):
• Downloads.subproj/WebDownloadPrivate.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resource:willSendRequest:]):
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest request]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge isReloading]): (-[WebBridge loadEmptyDocumentSynchronously]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient resource:willSendRequest:]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _originalRequest]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]):
• WebView.subproj/WebDefaultWindowOperationsDelegate.m:
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNewWindowPolicy:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _loadRequest:inFrameNamed:]):
• WebView.subproj/WebFrameView.m: (-[WebFrameView concludeDragOperation:]):
• WebView.subproj/WebImageRepresentation.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:willSendRequest:]):
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebView.m: (-[WebView takeStringURLFrom:]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): (-[WebView _openNewWindowWithRequest:]):
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToRequest:]):
• BrowserDocumentController.h:
• BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController reuseWebController:forRequest:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController openFileExternallyWithRequest:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController revealInFinderWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController expectedOrCurrentURL]): (-[BrowserWebController queueRequest:]): (-[BrowserWebController removeRequestFromQueue]): (-[BrowserWebController goNowIfInQueue]): (-[BrowserWebController goToRequest:allowJavaScript:waitInQueue:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
• BrowserWindowController.m: (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]):
• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]):
• ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
• Debug/SnippetController.m: (-[SnippetController load]):
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor download:didStartFromRequest:]): (-[DownloadMonitor downloadMayBeOpenedForRequest:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry _setRequest:]):
• FrameProgressEntry.m:
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]):
• LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 23, 2003:

12:02 AM Changeset in webkit [3900] by hyatt

• 3 edits in trunk/WebCore

Fix the top of the gamespot.com page on the PLT. The
clear status for <br> should be ignored if/when we decide
to ignore the <br> because the previous line didn't break
cleanly.

Reviewed by gramps

• khtml/rendering/bidi.cpp: