Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 2, 2003:

5:48 PM Changeset in webkit [5127] by mjs

• 9 edits
  6 deletes in trunk/WebKit

Folded Private implementation files into the regular ones as the
first step towards pulling in our SPI exposure and other code
cleanup.

• History.subproj/WebHistory.m:
• History.subproj/WebHistoryPrivate.m: Removed.
• Misc.subproj/WebIconDatabasePrivate.h:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m: Removed.
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m: Removed.
• WebView.subproj/WebFrameView.m:
• WebView.subproj/WebFrameViewPrivate.m: Removed.
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m: Removed.
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.m: Removed.

4:28 PM Changeset in webkit [5126] by hyatt

• 3 edits in trunk/WebCore

Remove the speed hit from using the UC break locators by not using them when
checking if the current character is   and by also using a global text
break locator object.

Reviewed by rjw

• khtml/rendering/break_lines.cpp:

4:16 PM Changeset in webkit [5125] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build

Reviewed by rjw.

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): if not data was received for a stream, create the temp file anyway. Plug-ins expect this.

3:11 PM Changeset in webkit [5124] by vicki

• 3 edits in trunk

tree is open for Safari-109

3:06 PM Changeset in webkit [5123]

• 3 copies in tags/Safari-108

This commit was manufactured by cvs2svn to create tag 'Safari-108'.

3:06 PM Changeset in webkit [5122] by vicki

• 8 edits in trunk

Safari-108 stamp.

12:58 PM Changeset in webkit [5121] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

11:50 AM Changeset in webkit [5120] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed 3441466 - REGRESSION: ​http://www.meyerweb.com/eric/css/edge/complexspiral/glassy.html broken on scroll

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Don't turn on scroll-blitting here when the page is done... (-[WebFrame _transitionToCommitted:]): Instead do it here, when the page is committed.

11:46 AM Changeset in webkit [5119] by mjs

• 5 edits in trunk/WebCore

Reviewed by Darin.

• fixed 3398622 - Crash when JavaScript changes display style

This was a problem with one of the many global variables in
bidi.cpp, last, having a stale value from the last layout that
pointed to a dead node. I fixed this by refactoring the code to
put most of the global variables in a struct allocated on the
stack, and pass around a reference to the struct. Seems much
cleaner (if somewhat wordier) this way. There are still more
global variables to kill here.

• khtml/rendering/bidi.cpp: (khtml::BidiIterator::BidiIterator): (khtml::BidiStatus::BidiStatus): (khtml::BidiInfo::BidiInfo): (khtml::Bidinext): (khtml::first): (khtml::BidiIterator::increment): (khtml::checkMidpoints): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/bidi.h:
• khtml/rendering/render_block.h:

11:35 AM Changeset in webkit [5118] by darin

• 2 edits in trunk/WebKit

Reviewed by Ken.

• in preparation for a WebCore whitespace-handling change, made WebTextRenderer draw and measure newline characters as if they are spaces (just as we already do with non-breaking spaces)
• removed some unused stuff from WebTextRenderer
• other unimportant tweaks (e.g. unsigned int -> unsigned)

• WebCoreSupport.subproj/WebTextRenderer.m: (kFixedOne), (fixed1), (FixToFloat), (FloatToFixed): Removed these. We can use the standard ones from <FixMath.h> instead of defining our own. (isControlCharacter): Added. Inline function that we can use instead of the macro we had before. (isAlternateSpace): Added. Returns YES for newlines and non-breaking spaces. (isSpace): Added. Returns YES for real spaces and the two alternate spaces as well. (initializeCharacterWidthIterator): Use isSpace. (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): Use isAlternateSpace and isControlCharacter. (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): Use isControlCharacter, isAlternateSpace, and isSpace. Also fix a small bug where numGlyphs would not get set up properly when the run length is 0, and used local variables when possible instead of going back at the run structure. (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): Use the standard FixedToFloat instead of our own FixToFloat. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): Ditto.

11:23 AM Changeset in webkit [5117] by hyatt

• 7 edits in trunk/WebCore

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

• kwq/KWQAccObject.h:
• kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityIsAttributeSettable:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityHitTest:]):
• kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):

11:22 AM Changeset in webkit [5116] by hyatt

• 2 edits in trunk/WebKit

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView accessibilityAttributeValue:]): (-[WebHTMLView accessibilityHitTest:]):

11:19 AM Changeset in webkit [5115] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3441656 -- constructor bad for objs created w/ function as prototype (www.moock.org/asdg/codedepot)

• kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Set up the constructor as as specified in the JavaScript spec. We were already doing this right in the other place we make functions.

8:31 AM Changeset in webkit [5114] by darin

• 122 edits in trunk

Reviewed by Ken.

• kwq/KWQRenderTreeDebug.cpp: (quoteAndEscapeNonPrintables): Since our text rendering renders non-breaking spaces the same as spaces, dump them as spaces. Do the same with newlines since I am about to change our text rendering to do the same with newlines.

• layout-tests: Updated test results.

Oct 1, 2003:

6:43 PM Changeset in webkit [5113] by hyatt

• 4 edits in trunk/WebCore

Avoid doing extra work when tearing down the document by checking to see if
we're in the destruction of the document.

Reviewed by darin

• khtml/rendering/render_block.cpp:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):

5:24 PM Changeset in webkit [5112] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewDidMoveToSuperview]): skip some work when when we've been removed. This wasn't causing any trouble before, but was at least conceptually inefficient.

5:07 PM Changeset in webkit [5111] by sullivan

• 2 edits in trunk/WebKit

• fixed 3441372: REGRESSION (107+): Plain text document is initially drawn with proportional font

Reviewed by Hyatt

• WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]): Changed a != to an ==

4:57 PM Changeset in webkit [5110] by rjw

• 13 edits in trunk

WebKit:

Fixed 3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.

Reviewed by Ken.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _itemForRestoringDocState]):

WebCore:

Fixed 3438441. Pass extra info up to WebKit about load type, specifically is a load is triggered by JS running in an onLoad handler.

Reviewed by Ken.

• khtml/ecma/kjs_binding.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::urlSelected):
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Nothing changed. Tweaked spacing.

4:56 PM Changeset in webkit [5109] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]): Fixed problem where we'd get a nil WebView and pass crazy values for subframe text multipliers.

4:27 PM Changeset in webkit [5108] by cblu

• 10 edits
  12 adds in trunk/WebCore

<rdar://problem/2942589>: CSS cursors are not implemented

Reviewed by Dave.

• Resources/eastCursor.tiff: Added.
• Resources/eastResizeCursor.tiff: Added.
• Resources/helpCursor.tiff: Added.
• Resources/moveCursor.tiff: Added.
• Resources/northEastResizeCursor.tiff: Added.
• Resources/northResizeCursor.tiff: Added.
• Resources/northWestResizeCursor.tiff: Added.
• Resources/southEastResizeCursor.tiff: Added.
• Resources/southResizeCursor.tiff: Added.
• Resources/southWestResizeCursor.tiff: Added.
• Resources/waitCursor.tiff: Added.
• Resources/westResizeCursor.tiff: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/cssparser.cpp: special-case the hand cursor to mean pointer (CSSParser::parseValue):
• khtml/css/cssvalues.c: generated changes (hash_val): (findValue):
• khtml/css/cssvalues.h: generated changes
• khtml/css/cssvalues.in: removed the progress cursor from the list because it was messing up the mapping
• khtml/khtmlview.cpp: call new cursor methods
• kwq/KWQKCursor.h:
• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]): new, loads and caches cursors (KCursor::crossCursor): get the AppKit cross hair cursor (KCursor::handCursor): call _WebCore_cursorWithName:hotSpot: (KCursor::sizeAllCursor): ditto (KCursor::waitCursor): ditto (KCursor::whatsThisCursor): ditto (KCursor::eastResizeCursor): new, call _WebCore_cursorWithName:hotSpot: (KCursor::northResizeCursor): ditto (KCursor::northEastResizeCursor): ditto (KCursor::northWestResizeCursor): ditto (KCursor::southResizeCursor): ditto (KCursor::southEastResizeCursor): ditto (KCursor::southWestResizeCursor): ditto (KCursor::westResizeCursor): ditto

1:58 PM Changeset in webkit [5107] by hyatt

• 45 edits
  4 adds in trunk

Clean up our detach model so that you can always get to a document, even for
anonymous content. Also stubbing out and adding the accessibility objects.

Reviewed by darin, mjs, john

• ChangeLog:
• WebCore.pbproj/project.pbxproj:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_box.cpp: (RenderBox::detach):
• khtml/rendering/render_box.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
• khtml/rendering/render_container.cpp: (RenderContainer::detach): (RenderContainer::addChild): (RenderContainer::updatePseudoChild): (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes):
• khtml/rendering/render_container.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::createAnonymousFlow): (RenderFlow::deleteLineBoxes): (RenderFlow::detach):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_form.cpp: (RenderTextArea::detach):
• khtml/rendering/render_form.h:
• khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::detach):
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitFlow): (RenderInline::renderName):
• khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation): (RenderListMarker::RenderListMarker):
• khtml/rendering/render_list.h:
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information): (RenderObject::dump): (RenderObject::createAnonymousBlock): (RenderObject::remove): (RenderObject::detach):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderWidget::detach):
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTableSection::detach): (RenderTableSection::addChild): (RenderTableRow::detach): (RenderTableRow::addChild): (RenderTableCell::detach):
• khtml/rendering/render_table.h:
• khtml/rendering/render_text.cpp: (RenderText::detach): (RenderText::deleteRuns):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::detach): (DocumentImpl::getOrCreateAccObjectCache):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::detach):
• kwq/KWQAccObject.h: Added.
• kwq/KWQAccObject.mm: Added. (-[KWQAccObject x]): (-[KWQAccObject y]): (-[KWQAccObject width]): (-[KWQAccObject height]): (-[KWQAccObject detached]): (-[KWQAccObject detach]): (-[KWQAccObject data]): (-[KWQAccObject setData:]): (-[KWQAccObject firstChild]): (-[KWQAccObject lastChild]): (-[KWQAccObject previousSibling]): (-[KWQAccObject nextSibling]): (-[KWQAccObject parentObject]):
• kwq/KWQAccObjectCache.h: Added.
• kwq/KWQAccObjectCache.mm: Added. (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::detach):
• layout-tests/css1/pseudo/firstletter-expected.txt:
• layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
• layout-tests/fast/css-generated-content/002-expected.txt:
• layout-tests/fast/css-generated-content/004-expected.txt:
• layout-tests/fast/css-generated-content/005-expected.txt:
• layout-tests/fast/css-generated-content/006-expected.txt:
• layout-tests/fast/selectors/039-expected.txt:
• layout-tests/fast/selectors/039b-expected.txt:
• layout-tests/fast/selectors/041-expected.txt:
• layout-tests/fast/selectors/042-expected.txt:
• layout-tests/fast/selectors/166a-expected.txt:
• layout-tests/fast/selectors/168-expected.txt:
• layout-tests/fast/selectors/168a-expected.txt:
• layout-tests/fast/selectors/169-expected.txt:
• layout-tests/fast/selectors/169a-expected.txt:
• layout-tests/fast/text/firstline/002-expected.txt:
• layout-tests/fast/text/firstline/003-expected.txt:

1:36 PM Changeset in webkit [5106] by hyatt

• 2 adds in trunk/LayoutTests/fast/dynamic

Adding layout test for setting of cssFlaot via a with clause.

1:30 PM Changeset in webkit [5105] by hyatt

• 3 edits in trunk/WebCore

Fix for 3163840, the images are mispositioned on the DHTML menus at the top of
www.aa.com (and in many other places). We needed to support returning the right
value from hasProperty and tryGet for 'cssFloat'.

This patch also adds support for getting/setting our custom CSS properties (-khtml-*)
and just factors the code a bit better for all the special values.

Reviewed by darin

• khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::hasProperty): (DOMCSSStyleDeclaration::tryGet): (DOMCSSStyleDeclaration::tryPut):

1:22 PM Changeset in webkit [5104] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3437309 -- REGRESSION (100-107): Javascript menu doesn't work at www.aa.com

• khtml/xml/dom_elementimpl.cpp: (ElementImpl::removeAttribute): Restored the old behavior for removeAttribute and removeAttributeNS; these don't give NOT_FOUND_ERR. But keep the NOT_FOUND_ERR for removeAttributeNode and removedNamedItem.

12:57 PM Changeset in webkit [5103] by kocienda

• 3 edits in trunk/WebCore

Reviewed by me

• kwq/KWQWidget.mm: (QWidget::focusPolicy): Improved comment.

11:48 AM Changeset in webkit [5102] by kocienda

• 8 edits in trunk/WebCore

Reviewed by Maciej

Fix for these bugs:

<rdar://problem/3439736>: WebCore form button widgets do not accept focus
<rdar://problem/3440770>: WebCore form button widgets do not take part in tabbing order

• kwq/KWQButton.h: Add focusPolicy function declaration.
• kwq/KWQButton.mm: (-[KWQButton nextKeyView]): Add tabbing support for buttons. (-[KWQButton previousKeyView]): Ditto (-[KWQButton nextValidKeyView]): Ditto (-[KWQButton previousValidKeyView]): Ditto (QButton::focusPolicy): Add focusPolicy implementation. This calls through to the recently-added accessor for full keyboard access to help in the determination for focus policy. For now, full keyboard access must be turned on for buttons to receive focus.
• kwq/KWQTextEdit.h: Remove focusPolicy specialization from this class. The implementation in QWidget now serves this class well.
• kwq/KWQTextEdit.mm: Ditto
• kwq/KWQWidget.h: Added isEnabled function. Small, unrelated cleanup to move the no-implementation setFocusPolicy() and setFocusProxy() functions fully into the header file.
• kwq/KWQWidget.mm: (QWidget::isEnabled): Added. Calls through to the Cocoa view to retrieve this information. (QWidget::focusPolicy): Much improved focus policy function is now more general in stipulating the conditions for focus policy, and will work for more widgets.

11:36 AM Changeset in webkit [5101]

• 1 copy
  318 deletes in branches/unlabeled-1.35.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.4'.

11:36 AM Changeset in webkit [5100] by hyatt

• 4 edits in trunk/WebCore

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

• kwq/KWQScrollView.h:
• kwq/WebCoreFrameView.h:

11:34 AM Changeset in webkit [5099] by hyatt

• 2 edits in trunk/WebKit

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

• WebView.subproj/WebDynamicScrollBarsView.m:

Sep 30, 2003:

5:47 PM Changeset in webkit [5098] by rjw

• 2 edits in trunk/WebKit

Attempt to find a reasonable font using a simple string matching heuristic if
none of the fonts actually specified are found. In particular we will use
Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
any of the requested font family names. Geeza Pro is a much better fallback
font for Arabic (and variant languages) than Helvetica.

Reviewed by Chris.

• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]):

5:38 PM Changeset in webkit [5097] by sullivan

• 8 edits
  1 add in trunk/WebKit

WebKit:

• fixed 3045617 -- Make Text Bigger/Smaller doesn't affect non-html documents.

I added an internal protocol inside WebKit to make this work, and implemented
it for plain text and RTF. I also slightly shuffled the existing code to
handle this for HTML so that it goes through the new protocol in that case
also.

Reviewed by NOBODY (OOPS!).

• WebView.subproj/WebDocumentInternal.h: Added.

New header file, holds definition of

_web_WebDocumentTextSizing protocol.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): if the document view conforms to the new protocol, tell it that the multiplier has changed. Also, don't tell the bridge here anymore; let WebHTMLView do that.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateTextSizeMultiplier]): tell the bridge here instead of having WebFrame do so (-[WebHTMLView viewDidMoveToSuperview]): call _updateTextSizeMultiplier (in case it changed while we were switched out) (-[WebHTMLView _web_textSizeMultiplierChanged]): call _updateTextSizeMultiplier

• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation receivedData:withDataSource:]):

• WebView.subproj/WebTextView.h: now implements _web_WebDocumentTextSizing protocol; new ivar for holding local copy of text size multiplier; new public method appendReceivedData:fromDataSource:

• WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): set local copy of text size multiplier to 1.0 (-[WebTextView _textSizeMultiplierFromWebView]): new method, asks the webview's opinion of the text size multiplier (-[WebTextView setFixedWidthFont]): use the text size multiplier when setting font size (-[WebTextView _adjustRichTextFontSizeByRatio:]): new method, borrowed from Mail and tweaked, that walks through the rich text and adjusts the font sizes (-[WebTextView _updateTextSizeMultiplier]): new method, updates local copy of text size multiplier to match webview's opinion (-[WebTextView setDataSource:]): set the text size multiplier appropriately before setting the fixed-width font; this is too early for the RTF case though since the fonts are embedded in the data (-[WebTextView appendReceivedData:fromDataSource:]): new method. Most of this logic was in WebTextRepresentation, but it's a little better encapsulated here, plus now it handles the text multiplier for RTF. (-[WebTextView defaultsChanged:]): added comment (-[WebTextView _web_textSizeMultiplierChanged]): call updateTextSizeMultiplier

• WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): return NO if the main frame doesn't support the text sizing protocol. This means that if the main frame doesn't support it but a subframe does, you can't adjust the text size. This seems fine for now since the only case with subframes is HTML, where the main frame does support changing text size.

• WebKit.pbproj/project.pbxproj: updated for new file

WebBrowser:

Reviewed by Darin

• HTMLSourceDocument.h: removed unused _textSizeMultiplier ivar

5:08 PM Changeset in webkit [5096] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3428262>: Plugin loads for static files, but not PHP scripts

Reviewed by rjw.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): load the plug-in DB so this method returns reliable results.

4:17 PM Changeset in webkit [5095] by kocienda

• 3 edits in trunk/WebCore

Reviewed by me

• WebCore.pbproj/project.pbxproj: Made WebCoreKeyboardAccess.h a private header.

4:07 PM Changeset in webkit [5094] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3006869>: show image dimensions in title bar when single image is loaded

Reviewed by rjw.

• English.lproj/Localizable.strings:
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): return "foo.jpg 50x50 pixels"

4:04 PM Changeset in webkit [5093] by rjw

• 2 edits in trunk/WebKit

Fixed 3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is only important because our Help folks oddly depend on the behavior.

Reviewed by Chris.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

3:47 PM Changeset in webkit [5092] by kocienda

• 1 add in trunk/WebCore/kwq/WebCoreKeyboardAccess.h

I added this file earlier, but a cvs-abandon command removed it. Re-adding and committing.

3:47 PM Changeset in webkit [5091] by kocienda

• 9 edits in trunk

WebCore:

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference

• WebCore.pbproj/project.pbxproj:
• kwq/KWQKHTMLPart.h: Declare keyboardUIMode accessor.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyboardUIMode): Implement keyboardUIMode accessor (calls through the bridge).
• kwq/WebCoreBridge.h: Declare the bridge accessor.
• kwq/WebCoreKeyboardAccess.h: Added. Header defines keyboard UI mode constants.

WebKit:

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference

• WebCoreSupport.subproj/WebBridge.h: Add two ivars: one to track the keyboard UI mode, the other a flag we use to register for notifications.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove the notification observer to keyboard UI mode changes. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): New method. Accesses the preferences to get the current keyboard UI mode. (-[WebBridge keyboardUIMode]): Returns the current keyboard UI mode. Registers for notifications of keyboard UI mode changes when called the first time.

2:58 PM Changeset in webkit [5090] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Ken.

• fixed 3375281 - Keyboard event handlers not fired if focus not in form field
• fixed 3242927 - KeyPressed Event in Javascript don't work
• fixed 3375353 - keyboard event.target not updated when blurring from form items
• fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
• kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
• kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto

WebKit:

Reviewed by Ken.

• fixed 3375281 - Keyboard event handlers not fired if focus not in form field
• fixed 3242927 - KeyPressed Event in Javascript don't work
• fixed 3375353 - keyboard event.target not updated when blurring from form items
• fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.

2:06 PM Changeset in webkit [5089] by rjw

• 4 edits in trunk/WebKit

Fixed 3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.

Reviewed by Chris.

• WebView.subproj/WebView.m: (-[WebView isLoading]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):

12:53 PM Changeset in webkit [5088] by hyatt

• 21 edits in trunk/LayoutTests

Update layout tests.

11:47 AM Changeset in webkit [5087] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_list.cpp

Backing out an accidental commit.

11:46 AM Changeset in webkit [5086] by hyatt

• 3 edits in trunk/WebKit

Improvements to scrolling and layout. Also fixing 3264346, body overflow should
apply to document's scrollbars.

Reviewed by darin

• WebView.subproj/WebDynamicScrollBarsView.h:
• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView initWithFrame:]): (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):

11:45 AM Changeset in webkit [5085] by hyatt

• 19 edits in trunk/WebCore

Improvements to layout transitions and scrollbar appearance/disappearance.
Also implementing a fix for 3264346, overflow applied to body should apply to
the document's scrollers.

Reviewed by darin

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute):
• khtml/khtmlview.cpp: (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::resetScrollBars): (KHTMLView::clear): (KHTMLView::initScrollBars): (KHTMLView::applyBodyScrollQuirk): (KHTMLView::inLayout):
• khtml/khtmlview.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
• khtml/rendering/render_form.cpp: (TextAreaWidget::TextAreaWidget):
• khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): (RenderPartObject::slotViewCleared):
• khtml/rendering/render_list.cpp: (RenderListMarker::calcMinMaxWidth):
• khtml/rendering/render_object.cpp: (RenderObject::repaint): (RenderObject::repaintRectangle):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setInPageCache):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
• kwq/KWQRenderTreeDebug.cpp: (write): (externalRepresentation):
• kwq/KWQScrollView.h:
• kwq/KWQScrollView.mm: (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]):
• kwq/WebCoreFrameView.h:

11:39 AM Changeset in webkit [5084] by hyatt

• 3 edits in trunk/WebCore

Fix for 3437260, nil deref of the render style because it hasn't been set yet.
Fallout from my incremental repainting landing.

Reviewed by darin

• khtml/rendering/render_replaced.cpp: (RenderWidget::setQWidget):

11:35 AM Changeset in webkit [5083] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

Rolled in Harri Porten's change to accept non-breaking space in JavaScript.

• kjs/lexer.cpp: (Lexer::isWhiteSpace): Accept 00A0 as "whitespace".

11:30 AM Changeset in webkit [5082] by hyatt

• 3 edits in trunk/WebCore

Fix for 3438479, tables expand on every layout when a cell has percentage height
children.

Reviewed by darin

• khtml/rendering/render_table.cpp: (RenderTableSection::calcRowHeight): (RenderTableRow::layout):

Sep 29, 2003:

4:04 PM Changeset in webkit [5081] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3332460>: nil-deref in khtml::RenderWidget::eventFilter with onchange handler

Reviewed by darin.

• kwq/KWQTextField.mm: (-[KWQTextField controlTextDidEndEditing:]): call setHasFocus:NO last so we have the widget that lets us get to the bridge and lets us call controlTextDidEndEditing

3:33 PM Changeset in webkit [5080] by hyatt

• 3 edits in trunk/WebCore

Fix for 3425053, text past the bottom of a positioned table doesn't repaint.
3426847 is the same bug. Both are fixed by ensuring that calcHeight doesn't actually
do anything other than margin computation and position determination for positioned
elements. In reality, for weird edge cases like implying the height via explicit top and
bottom properties, we'll still be wrong.

Reviewed by darin

• ChangeLog:
• khtml/rendering/render_table.cpp: (RenderTable::layout):

3:05 PM Changeset in webkit [5079] by cblu

• 5 edits in trunk/WebKit

Fixed: <rdar://problem/3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream

Reviewed by mjs.

• Plugins.subproj/WebBaseNetscapePluginStream.h: renamed receivedError to cancelWithReason
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): call cancelWithReason if NPP_NewStream returns an error (-[WebBaseNetscapePluginStream cancelWithReason:]): renamed (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call renamed cancelWithReason (-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): new override, stop load then call super (-[WebNetscapePluginStream stop]): call cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): call renamed cancelWithReason

2:10 PM Changeset in webkit [5078] by hyatt

• 1 add in trunk/LayoutTests/fast/text/whitespace/024-expected.txt

Forgot to commit expected.txt for new whitespace test.

2:10 PM Changeset in webkit [5077] by hyatt

• 2 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for abs positioned object inside relpositioned inline containing block

1:29 PM Changeset in webkit [5076] by hyatt

• 1 add in trunk/LayoutTests/fast/text/whitespace/024.html

Adding layout test for <pre> maxwidth bug.

1:27 PM Changeset in webkit [5075] by hyatt

• 4 edits in trunk/WebCore

Make sure that timeouts updateRendering after they execute the scheduled timer
action.

Also fixing 3429455, maxwidth of pres miscomputed when two blank lines occur at
the end of a pre text run.

Reviewed by darin, mjs (setTimeout fix), darin (pre fix)

• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
• khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth):

9:49 AM Changeset in webkit [5074] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed 3437292 -- Safari uses wrong characters for &and; and &or; entities

• khtml/html/kentities.gperf: Corrected values for &and; and &or; entities. Checked all the rest against a list on the W3C site, and those are the only two that were wrong.
• khtml/html/kentities.c: Regnenerated.