Timeline
Oct 28, 2003:
- 11:22 PM Changeset in webkit [5298] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fixed 3465547 - REGRESSION (100-111)?: window.prompt does not work
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::runJavaScriptPrompt): Return the result properly instead of always returning false.
- 10:31 PM Changeset in webkit [5297] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3465504 -- REGRESSION (100-111): text areas with Chinese text in them are wider than ones without
- kwq/KWQTextArea.h: Add _font field.
- kwq/KWQTextArea.mm: (-[KWQTextArea dealloc]): Release _font. (-[KWQTextArea setFont:]): Store font in _font as well as setting it in the text view. (-[KWQTextArea sizeWithColumns:rows:]): Use _font rather than asking the text view for the font.
- 9:42 PM Changeset in webkit [5296] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3464702 -- node.item(x) is not implemented (dynamic menus not filled out at techcu.com)
- khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Add implementation of item function.
- khtml/ecma/kjs_dom.h: Added Item to the enum.
- khtml/ecma/kjs_dom.lut.h: Regenerated.
- 5:23 PM Changeset in webkit [5295] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave,
- fixed 3379725 - for <a> elements with both onclick and href, Web Kit's behavior does not match other browsers
The fix for this was to make cancelBubble only prevent bubbling,
but not stop propagation or prevent default. While I was at it, I
made returnValue work right too.
- khtml/ecma/kjs_events.cpp: (DOMEvent::getValueProperty): Implement cancelBubble and returnValue properties properly. (DOMEvent::putValue): Ditto.
- khtml/dom/dom2_events.cpp: (Event::setCancelBubble): Call impl. (Event::setDefaultPrevented): Ditto. (Event::getCancelBubble): Ditto. (Event::defaultPrevented): Ditto.
- khtml/dom/dom2_events.h:
- khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::propagationStopped): Made this a const method. (DOM::EventImpl::defaultPrevented): Ditto. (DOM::EventImpl::setCancelBubble): Implemented by setting a new field. (DOM::EventImpl::getCancelBubble): Corresponding getter. (DOM::EventImpl::setDefaultPrevented): Set the already existing field for this.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Check getCancelBubble() when bubbling. Do not check bubbles() before default handling.
- 4:39 PM Changeset in webkit [5294] by
-
- 2 edits in trunk/WebKit
- fixed <rdar://problem/3466082>: 7B85/111: Crash viewing web page ([WebView setNextKeyView:])
Reviewed by Chris.
- WebView.subproj/WebView.m: (-[WebView dealloc]): set _private to nil after releasing, because [super dealloc] can dispatch to it (-[WebView mainFrame]): fixed spelling error in comment
- 4:00 PM Changeset in webkit [5293] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3464472>: REGRESSION: New CSS cursor support breaks style="cursor:default
Reviewed by dave.
- kwq/KWQWidget.mm: (QWidget::cursor): break after we hit a view that responds to documentCursor as we do in setCursor. Without breaking we were returning the cursor of the most super HTML view which is not what we want.
- 3:06 PM Changeset in webkit [5292] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3421393 - window.open does not handle non-integral height/width (small window at saabusa.com)
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Parse width, height, top and left as floating point and then cast to int instead of parsing as int to match other browsers and avoid rejecting floating point numbers.
- 2:52 PM Changeset in webkit [5291] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Ken.
- fixed 3413962 - malicious web pages can kill all future JavaScript execution by breaking recursion limit check
- kjs/nodes.cpp: (FunctionCallNode::evaluate): If we're going to return early due to breaking the recursion limit, make sure to lower it again, or it will creep up by one each time it's exceeded.
- 2:21 PM Changeset in webkit [5290] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3464528 - addEventListener does not work for buttons, text areas, or inputs
- khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked): Send CLICK_EVENT as well as one of KHTML_CLICK_EVENT or KHTML_DOUBLE_CLICK_EVENT.
- 2:21 PM Changeset in webkit [5289] by
-
- 2 edits in trunk/WebKit
WebKit:
Fixed: <rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
Reviewed by john.
- WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]): call _progressCompleted after we deliver the didFailLoadWithError or didFinishLoadForFrame message as we do in other places. This allows to be aware of the error (if there is one), when they get the WebViewProgressFinishedNotification notification.
WebBrowser:
Fixed:
<rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
<rdar://problem/3465910>: REGRESSION (100-110): Switching to bookmarks view shows progress bar but shouldn't
Reviewed by john.
- BrowserWebController.h:
- BrowserWebController.m: (-[BrowserWebView setMainFrameLoadEndedInError:]): new (-[BrowserWebView progressFinished:]): if we have a main frame error, set the progress bar to 0
- LocationChangeHandler.m: (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): call setMainFrameLoadEndedInError:NO for the main frame (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call setMainFrameLoadEndedInError:YES for the main frame
- 1:27 PM Changeset in webkit [5288] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didSetName:]): Tell the WebFrame about its new name.
- 11:52 AM Changeset in webkit [5287] by
-
- 2 edits in trunk/WebKit
- fixed 3465613 -- REGRESSION (111): Crash creating nib that contains WebView
Reviewed by Chris.
- WebView.subproj/WebView.m: (-[WebView mainFrame]): check for nil _private before dereferencing.
- 11:45 AM Changeset in webkit [5286] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3465591>: Security: Netscape plug-ins can execute JavaScript in other frames
Reviewed by mjs.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): renamed, no need to pass the target frame since the target is either the plug-in itself or the frame that contains the plug-in (-[WebBaseNetscapePluginView loadPluginRequest:]): call renamed evaluateJavaScriptPluginRequest (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): if this is a JS request that is targeted at a frame, return NPERR_INVALID_PARAM if the frame is not the frame that contains the plugin
- 11:40 AM Changeset in webkit [5285] by
-
- 2 edits in trunk/WebCore
Fixed broken build.
- kwq/KWQKPartsPart.mm: (KParts::ReadOnlyPart::setName): It's a ReadOnlyPart method, not a Part method.
- 11:15 AM Changeset in webkit [5284] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3437959>: javascript: URLs don't work from Java (and other Cocoa plugins, if any)
Reviewed by mjs.
- Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): support JS requests targeted only to the plug-in's frame.
- 11:13 AM Changeset in webkit [5283] by
-
- 6 edits in trunk/WebCore
Reviewed by John.
- fixed 3427046 - href and src attributes don't always give resolved URL
It turns out that all href and src attributes should be resolved
against the base, except for frame elements.
- khtml/dom/html_base.cpp: (HTMLIFrameElement::src): Resolve against base URL.
- khtml/dom/html_form.cpp: (HTMLInputElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
- khtml/dom/html_head.cpp: (HTMLBaseElement::href): Resolve against base URL. (HTMLLinkElement::href): Ditto. (HTMLScriptElement::src): Ditto.
- khtml/dom/html_image.cpp: (HTMLAreaElement::href): Ditto. (HTMLImageElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
- khtml/dom/html_inline.cpp: (HTMLAnchorElement::href): Resolve against base URL.
- 11:12 AM Changeset in webkit [5282] by
-
- 7 edits1 add in trunk/WebCore
Reviewed by Darin.
- fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setName): Make sure the name is unique. Then tell the bridge and the superclass about it.
- kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::setName): Made this method virtual.
- kwq/KWQKPartsPart.m: Added. Moved implementations of virtual methods here.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Call the superclass method to avid sending the name pointlessly back across the bridge.
- 8:46 AM Changeset in webkit [5281] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3465063 -- REGRESSION (107-108): hang when fetching a page with an ad in a subframe (theage.com.au)
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Follow the parent chain properly rather than repeatedly getting the part's own parent!
Oct 27, 2003:
- 4:51 PM Changeset in webkit [5280] by
-
- 2 edits in trunk/WebKit
- fixed 3441258 -- hysteresis to start dragging a link is too small; too easy to start drag
Reviewed by Chris.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): Split DragHysteresis into two values, one for links and one for images. Make the link one much larger than the image one (since dragging an image doesn't occur accidentally in the ways that dragging a link does).
- 12:51 PM Changeset in webkit [5279]
-
- 1 copy324 deletes in branches/unlabeled-1.70.4
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.70.4'.
- 12:51 PM Changeset in webkit [5278] by
-
- 29 edits1 add in trunk/WebCore
Reviewed by Darin.
Improved exception blocking in the following ways:
- use C++ constructors and destructors so returning or breaking out of an exception block works
- Remove use of volatile
- Collapse the caught exception case into a single function call to reduce code size.
- WebCore.pbproj/project.pbxproj:
- kwq/KWQButton.mm:
- kwq/KWQCheckBox.mm:
- kwq/KWQComboBox.mm:
- kwq/KWQExceptions.h:
- kwq/KWQExceptions.mm: Added.
- kwq/KWQFileButton.mm:
- kwq/KWQFont.mm:
- kwq/KWQFrame.mm:
- kwq/KWQKConfigBase.mm:
- kwq/KWQKCookieJar.mm:
- kwq/KWQKCursor.mm:
- kwq/KWQKHTMLPart.mm:
- kwq/KWQKHTMLPartBrowserExtension.mm:
- kwq/KWQKHistoryProvider.mm:
- kwq/KWQKJavaAppletWidget.mm:
- kwq/KWQKJobClasses.mm:
- kwq/KWQKLocale.mm:
- kwq/KWQKPartsBrowserInterface.mm:
- kwq/KWQLineEdit.mm:
- kwq/KWQListBox.mm:
- kwq/KWQLoader.mm:
- kwq/KWQPainter.mm:
- kwq/KWQPushButton.mm:
- kwq/KWQRadioButton.mm:
- kwq/KWQScrollBar.mm:
- kwq/KWQScrollView.mm:
- kwq/KWQTextEdit.mm:
- kwq/KWQWidget.mm:
- 12:48 PM Changeset in webkit [5277] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"
Reviewed by darin.
- History.subproj/WebHistoryItem.m: (+[WebHistoryItem _destroyAllPluginsInPendingPageCaches]): Don't destroy plug-ins that are currently being viewed.
- 8:41 AM Changeset in webkit [5276] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed
Reviewed by john.
- WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): don't allow image types to override types that are already registered as we do in [WebFrameView _viewTypesAllowImageTypeOmission:]
- 8:28 AM Changeset in webkit [5275] by
-
- 2 edits in trunk/WebKit
Fixed:
<rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
<rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
<rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): attempt to fetch the image data from the cache, if that works, write out the file
Oct 26, 2003:
- 10:54 PM Changeset in webkit [5274] by
-
- 2 edits in trunk/WebCore
- khtml/khtml_part.cpp: (findWordBoundary): Fix small mistake from NULL check-in earlier.
- 10:38 PM Changeset in webkit [5273] by
-
- 2 edits in trunk/WebCore
- kwq/KWQLoader.mm: (KWQResponseMIMEType): Removed an excess volatile.
- 10:32 PM Changeset in webkit [5272] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Remove the word "Merlot".
- 10:32 PM Changeset in webkit [5271] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Updated change log to mention bug number for Merlot build fix.
- 10:31 PM Changeset in webkit [5270] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3463624 -- page at cinemakorea.com shows up blank due to kTECBufferBelowMinimumSizeErr from TEC
- kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): To work around the bug I found in the decoder (Radar 3351093), change kTECBufferBelowMinimumSizeErr to kTECOutputBufferFullStatus in cases where bytes were actually converted.
- 10:31 PM Changeset in webkit [5269] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed uses of NULL in non-pointer contexts
- khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
- khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.
- WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.
- 10:26 PM Changeset in webkit [5268] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3457831 -- REGRESSION: copying particular text and pasting (plain) produces lots of extra text
- khtml/khtml_part.cpp: (KHTMLPart::text): Check for the end node when following a link to the parent node, not just when following a link to the next child node.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Ditto.
- 8:53 PM Changeset in webkit [5267] by
-
- 2 edits in trunk/WebKit
- WebKitPrefix.h: Add a definition of NULL here so we get the stricter type checking even on pre-Merlot systems.
- 8:29 PM Changeset in webkit [5266] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCorePrefix.h: Added a C case to the NULL definition since we use C as well as C++ in this project.
- 8:24 PM Changeset in webkit [5265] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Revised ChangeLog to strike a reference to Merlot.
- 8:21 PM Changeset in webkit [5264] by
-
- 3 edits in trunk/JavaScriptCore
- rolled in some CString changes Harri Porten did on the KDE side
- kjs/ustring.cpp: (KJS::CString::CString): Use memcpy instead of strcpy for speed. Fix an off by one error in the copy constructor. (KJS::CString::operator=): Use memcpy instead of strcpy for speed.
- JavaScriptCorePrefix.h: Add a definition of NULL here that matches the one in Merlot. This makes us see warnings that otherwise would be Merlot-only warnings.
Oct 25, 2003:
- 4:53 PM Changeset in webkit [5263] by
-
- 2 edits in trunk
Rolled over ChangeLog, since checkouts were getting slow again.
WebCore:
Ditto.
Oct 24, 2003:
- 6:02 PM Changeset in webkit [5262] by
-
- 1 edit in trunk/WebKit/English.lproj/StringsNotToBeLocalized.txt
Fixed: <rdar://problem/3308160>: Safari goes bonkers on ftp:// URLs
Reviewed by hyatt.
- BrowserWebController.m: (-[BrowserWebView openURLExternallyWithRequest:inFrame:]): if Safari is the handler for a URL that we are attempting to launch, unset that preference. If the URL is FTP, set the finder as the handler.
- 5:21 PM Changeset in webkit [5261] by
-
- 3 edits in trunk
tree is open for Safari-112
- 5:18 PM Changeset in webkit [5260]
-
- 3 copies in tags/Safari-111
This commit was manufactured by cvs2svn to create tag 'Safari-111'.
- 5:18 PM Changeset in webkit [5259] by
-
- 8 edits in trunk
Safari-111 stamp.
77 bugs fixed since Safari-110!
- 4:10 PM Changeset in webkit [5258] by
-
- 5 edits in trunk
WebKit:
Fixed 3425358. Don't try to create page cache for pages that
have a nil view().
Reviewed by Hyatt.
- WebView.subproj/WebFrame.m: (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]):
WebCore:
Fixed 3425358. Don't try to create page cache for pages that
have a nil view().
Reviewed by Hyatt.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
- 3:32 PM Changeset in webkit [5257] by
-
- 3 edits in trunk/WebCore
Fix for 3133375, the minwidth computation for pres is wrong. There were a couple of bugs here.
One is that pres only should have a breakable character if they contain a newline. Otherwise they're
treated essentially like nowrap. The other was that m_beginMinWidth and m_endMinWidth needed to be
set to the maxwidth of the first line and the maxwidth of the last line respectively for pres instead of
being only the first and last words.
Reviewed by mjs
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 2:44 PM Changeset in webkit [5256] by
-
- 2 adds in trunk/LayoutTests/fast/text/whitespace
Adding test of unicode breakability and whitespace.
- 2:20 PM Changeset in webkit [5255] by
-
- 476 edits in trunk/LayoutTests
Checking in the layout test results using our current defaults and not ancient crufty defaults.
- 2:07 PM Changeset in webkit [5254] by
-
- 3 edits in trunk/WebCore
Two fixes to the computation of min/max width for text runs.
(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly
breaks a pre).
(2) Fix a bug where breakable characters weren't getting factored into minwidth properly. When a word got broken
because of a breakable character, we were treating the breakable character like a space, and not including its
width as part of the minimum width of the text run.
Reviewed by john
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 2:05 PM Changeset in webkit [5253] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page
Reviewed by john.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): don't honor JS requests from standalone plug-ins to workaround 3462628 which is a deeper issue.
- 9:06 AM Changeset in webkit [5252] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded
Reviewed by john.
- WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because the plug-in DB calls _viewTypesAllowImageTypeOmission:NO.
