Timeline



Feb 18, 2004:

4:14 PM Changeset in webkit [6099] by rjw
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_runtime.mm

Fixed Deployment build problem (longjmp clobber warning)

2:30 PM Changeset in webkit [6098] by rjw
  • 3 edits in trunk/JavaScriptCore

Added NSNumber/Number conversion.

Removed some unnecessary KJS
namespace specifiers.

Reviewed by Ken.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime_array.h:
1:58 PM Changeset in webkit [6097] by rjw
  • 11 edits in trunk/JavaScriptCore

Added support for export NSArrays.

Updated valueAt() to take an ExecState so we can throw
JS exceptions.

Implemented excludeSelectorFromJavaScript: in ObjcClass. This allows
ObjectiveC classes to control the visibility of their methods in
JavaScript.

Reviewed by Ken.

  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::ObjcArray): (ObjcArray::~ObjcArray): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (Instance::getValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::get):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):

Feb 17, 2004:

5:56 PM Changeset in webkit [6096] by rjw
  • 4 edits in trunk/JavaScriptCore

Added String <-> NSString conversion.
Added tests of String <-> NSString conversion to test program.

Reviewed by Chris.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/test.js:
  • bindings/testbindings.mm: (-[MyFirstInterface getString]):
4:45 PM Changeset in webkit [6095] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3537397>: REGRESSION (100-114): Return doesn't work in Japanese input method for some HomePage fields

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto.
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto.
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything.

Feb 16, 2004:

11:18 AM Changeset in webkit [6094] by cblu
  • 9 edits in trunk/WebCore

WebCore side of pasting image data.

Reviewed by kocienda.

  • khtml/editing/htmlediting.cpp: (PasteImageCommand::PasteImageCommand): new (PasteImageCommand::~PasteImageCommand): new (PasteImageCommand::impl): new
  • khtml/editing/htmlediting.h: (khtml::):
  • khtml/editing/htmlediting_impl.cpp: (EditCommandImpl::name): added support for PasteImageCommandID (CompositeEditCommandImpl::insertNodeAt): new, factored out from PasteHTMLCommandImpl::apply (PasteHTMLCommandImpl::apply): call insertNodeAt (PasteImageCommandImpl::PasteImageCommandImpl): new (PasteImageCommandImpl::~PasteImageCommandImpl): new (PasteImageCommandImpl::apply): new
  • khtml/editing/htmlediting_impl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::pasteHTMLString): unchanged (KHTMLPart::pasteImage): new
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteImageWithURL:]): new
10:18 AM Changeset in webkit [6093] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • Fixed some dynamic casts that Dirk complained about to use virtual functions instead. Since the virtual functions were already there, this is faster and better in most ways anyway.
  • khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Use virtual function instead of dynamic_cast. (UIEvent::charCode): Ditto. (UIEvent::pageX): Ditto. (UIEvent::pageY): Ditto. (UIEvent::layerX): Ditto. (UIEvent::layerY): Ditto. (UIEvent::which): Ditto.
8:19 AM Changeset in webkit [6092] by darin
  • 4 edits
    2 deletes in trunk/WebKit

Reviewed by John and Don.

  • discovered that jaguar.com doesn't need spoofing any more, so removed the spoofing machinery entirely; if we ever have to bring it back we can, but I doubt we will
  • WebView.subproj/WebView.m: Removed include of WebUserAgentSpoofTable.c. (-[WebViewPrivate dealloc]): Release the new single userAgent rather than the array and userAgentOverride we used to. (-[WebView _preferencesChangedNotification:]): Release the single user agent, rather than the entire cache. Also only do it when the user agent is not overridden. (-[WebView setApplicationNameForUserAgent:]): Ditto. (-[WebView setCustomUserAgent:]): Set the new userAgentOverridden boolean, and also set userAgent itself. (-[WebView customUserAgent]): Return userAgent, but only if userAgentOverridden is true. (-[WebView userAgentForURL:]): Simplify, now that there's no automatic spoofing to do. Made even simpler by the fact that custom and computed user agents both share the same field now.
  • WebView.subproj/WebViewPrivate.h: Got rid of UserAgentStringType, turned the userAgent field into a single item instead of an array, and replaced the userAgentOverride field with a boolean userAgentOverridden field.
  • Makefile.am: Removed the rule to build WebUserAgentSpoofTable.c.
  • WebView.subproj/WebUserAgentSpoofTable.c: Removed.
  • WebView.subproj/WebUserAgentSpoofTable.gperf: Removed.

Feb 15, 2004:

11:54 AM Changeset in webkit [6091] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave.

  • WebKit.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
11:51 AM Changeset in webkit [6090] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • WebCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
11:51 AM Changeset in webkit [6089] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • JavaScriptCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.
10:50 AM Changeset in webkit [6088] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak.
Note: See TracTimeline for information about the timeline view.