Context Navigation

← Previous Period
Next Period →

Timeline

May 28, 2004:

9:23 PM Changeset in webkit [6733] by ouch

4 edits in trunk/WebCore

Reviewed by gramps.

removed setShadowWithColor and change setShadow to work with optional attributes

it follows the same rules as setFill/StrokeColor

Fixed bug in setFillColor and setStrokeColor for CMYK colors (missing break in case).

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

5:07 PM Changeset in webkit [6732] by darin

3 edits in trunk/WebKit

Reviewed by Maciej.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _fontManagerOperationAsStyle]): First cut at figuring out what operation the font manager is doing without digging into its private data structures.

4:26 PM Changeset in webkit [6731] by darin

16 edits in trunk

WebCore:

Reviewed by Ken.

various editing-related improvements

khtml/xml/dom_selection.h: Removed UP and DOWN directions, and added PARAGRAPH granularity.
khtml/xml/dom_selection.cpp: (DOM::Selection::modify): Got rid of the UP and DOWN directions, and made movement between lines happen when granularity is LINE. Added a new unimplemented granularity: PARAGRAPH. (DOM::Selection::validate): Remove some unneeded APPLE_CHANGES. The code need not be ifdef'd. (DOM::Selection::debugPosition): Ditto.

kwq/WebCoreBridge.h: Removed WebSelectUp and WebSelectDown, and added WebSelectByParagraph. Added stringForRange: and selectedDOMRangeWithGranularity:, and renamed replaceSelectionWithNewline to insertNewline because it has the insertText: semantic, not the replaceSelectionWithText: one.
kwq/WebCoreBridge.mm: (-[WebCoreBridge stringForRange:]): Added. (-[WebCoreBridge selectedDOMRangeWithGranularity:]): Added. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Updated code to understand that vertical movement is based on granularity now, not direction. (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:]): Moved an ensureCaretVisible from the WebKit down here. I think perhaps this should go down even further in WebCore. (-[WebCoreBridge insertNewline]): Renamed, and moved ensureCaretVisible here. (-[WebCoreBridge insertText:]): Moved ensureCaretVisible here. (-[WebCoreBridge deleteKeyPressed]): Moved ensureCaretVisible here.

khtml/xml/dom_position.cpp: Some ifdef tweaks.

khtml/misc/helper.cpp: Namespace and formatting tweaks.
khtml/misc/helper.h: Removed some unused stuff.

khtml/dom/dom2_range.h: Make range constructor public so that anyone with a RangeImpl can easily make a Range.

WebKit:

Reviewed by Ken.

various editing-related improvements
fixed <rdar://problem/3655366>: (Editing: -selectParagraph: method unimplemented (WebKit editing API))
fixed <rdar://problem/3655367>: (Editing: -selectLine: method unimplemented (WebKit editing API))
fixed <rdar://problem/3655369>: (Editing: -selectWord: method unimplemented (WebKit editing API))
fixed <rdar://problem/3655392>: (Editing: -uppercaseWord: method unimplemented (WebKit editing API))
fixed <rdar://problem/3655393>: (Editing: -lowercaseWord: method unimplemented (WebKit editing API))
fixed <rdar://problem/3655394>: (Editing: -capitalizeWord: method unimplemented (WebKit editing API))

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Removed the call to ensureCaretVisible. This is now handled on the other side of the bridge. (-[WebHTMLView moveDown:]): Changed to use WebSelectByLine granularity instead of WebSelectDown direction. (-[WebHTMLView moveDownAndModifySelection:]): Ditto. (-[WebHTMLView moveUp:]): Ditto. (-[WebHTMLView moveUpAndModifySelection:]): Ditto. (-[WebHTMLView _expandSelectionToGranularity:]): Added. (-[WebHTMLView selectParagraph:]): Implemented by calling _expandSelectionToGranularity. (-[WebHTMLView selectLine:]): Ditto. (-[WebHTMLView selectWord:]): Ditto. (-[WebHTMLView _fontManagerOperationAsStyle]): Added. Placeholder for the job of figuring out what style change to make based on NSFontManager. (-[WebHTMLView changeFont:]): Implemented, but not really tested because guts are still missing due to lack of above method. (-[WebHTMLView insertTab:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertNewline:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertParagraphSeparator:]): Made this insert a newline for now. (-[WebHTMLView _changeWordCaseWithSelector:]): Added. (-[WebHTMLView uppercaseWord:]): Implemented by calling _changeWordCaseWithSelector. (-[WebHTMLView lowercaseWord:]): Ditto. (-[WebHTMLView capitalizeWord:]): Ditto. (-[WebHTMLView deleteBackward:]): Removed the call to ensureCaretVisible. (-[WebHTMLView checkSpelling:]): Put a pile of AppKit code in here as a placeholder. (-[WebHTMLView startSpeaking:]): Use the new stringForRange: method instead of outerText. That way we can handle cases where the entire document is selected. (-[WebHTMLView insertText:]): Removed the call to ensureCaretVisible.

2:40 PM Changeset in webkit [6730] by rjw

4 edits in trunk/WebCore

setStrokeColor and setFillColor now support
old school web color string, oswcs+alpha, gray, gray+alpha,
rgba, and cmyka.

Reviewed by jay-lo.

khtml/css/cssparser.cpp: (CSSParser::parseColor): (CSSParser::parseColorFromValue):
khtml/css/cssparser.h: Made parseColor static public class method
khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):

12:41 PM Changeset in webkit [6729] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3672129>: (selection deselects when clicking editable WebView in background window)

Fixed this problem by using NSTextView's approach of only allowing dragging on first mouse down.

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView acceptsFirstMouse:]): store the first mouse down (-[WebHTMLView mouseDown:]): Don't tell WebCore about the first mouse down event since only dragging can occur on the first mouse down. (-[WebHTMLView mouseDragged:]): Don't tell WebCore about the drags that occur after the first mouse down since only dragging can occur after the first mouse down.
WebView.subproj/WebHTMLViewInternal.h:

12:33 PM Changeset in webkit [6728] by hyatt

15 edits in trunk/WebCore

Implement -khtml-user-select and add support for the property -khtml-user-drag (although someone will still
need to wire it up).

Reviewed by rjw

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection):
khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (userSelect): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::setUserDrag): (khtml::RenderStyle::setUserSelect): (khtml::RenderStyle::initialUserDrag): (khtml::RenderStyle::initialUserSelect):

11:33 AM Changeset in webkit [6727] by ouch

4 edits in trunk/WebCore

added addArc and clip path routines.

Reviewed by sullivan.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

11:00 AM Changeset in webkit [6726] by kdecker

1 edit in trunk/WebKit/ChangeLog

WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:57 AM Changeset in webkit [6725] by kdecker

1 edit in trunk/WebKit/ChangeLog

WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:47 AM Changeset in webkit [6724] by kdecker

1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Ken.

-revised generated error message content

kjs/error_object.cpp: (ErrorProtoFuncImp::call):
kjs/internal.cpp: (Parser::parse):
kjs/object.cpp: (KJS::Error::create):

10:21 AM Changeset in webkit [6723] by darin

2 edits in trunk/WebKit

WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.

10:21 AM Changeset in webkit [6722] by kdecker

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

10:14 AM Changeset in webkit [6721] by darin

9 edits
1 add in trunk/WebKit

Reviewed by Ken.

implemented a few more editing operations, moved code from WebView to WebHTMLView

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): Call _updateFontPanel on the WebHTMLView, not the WebView. (-[WebBridge respondToChangedSelection]): Ditto.

WebView.subproj/WebHTMLView.m: Moved WebElementOrTextFilter class here from WebView and gave it a prefix so it won't conflict with developers' class names. (-[WebHTMLView _updateFontPanel]): Moved here from WebView.

WebView.subproj/WebView.m: (-[WebView toggleSmartInsertDelete:]): Added. (-[WebView toggleContinuousSpellChecking:]): Added. (-[WebView isContinuousGrammarCheckingEnabled]): Added. (-[WebView setContinuousGrammarCheckingEnabled:]): Added. (-[WebView toggleContinuousGrammarChecking:]): Added. (-[WebView setSmartInsertDeleteEnabled:]): Implemented. We have the flag now, although we still don't actually have smart insert and delete implemented. (-[WebView smartInsertDeleteEnabled]): Ditto. (-[WebView setContinuousSpellCheckingEnabled:]): Implemented. (-[WebView isContinuousSpellCheckingEnabled]): Implemented. (-[WebView spellCheckerDocumentTag]): Implemented. (-[WebView _preflightSpellCheckerNow:]): Added. (-[WebView _preflightSpellChecker]): Added. (-[WebView _continuousCheckingAllowed]): Added.

WebView.subproj/WebHTMLViewInternal.h: Added. We'll things here from WebHTMLViewPrivate so they are internal to the framework, rather than SPI.
WebKit.pbproj/project.pbxproj: Added WebHTMLViewInternal.h.
WebView.subproj/WebHTMLViewPrivate.h: Moved WebHTMLViewPrivate into the internal header. Despite its name, it's internal, not SPI.

WebView.subproj/WebViewPrivate.h: Moved WebViewPrivate into the internal header. Despite its name, it's internal, not SPI. Added a number of new operations which should be public API. We'll have to figure out what to do about API review and the WWDC deadline.
WebView.subproj/WebViewInternal.h: Removed _updateFontPanel method.

English.lproj/StringsNotToBeLocalized.txt: Update.

8:54 AM Changeset in webkit [6720] by ouch

4 edits in trunk/WebCore

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

7:19 AM Changeset in webkit [6719] by kocienda

6 edits in trunk

Tests:

Reviewed by Maciej.

moved to new symlink technique for embedding frameworks

Blot/Blot.xcode/project.pbxproj: Call the new create-framework-symlinks script instead of copy-frameworks-to-dstroot.sh.
Blot/embed-frameworks.sh: Removed.

PDFViewer/PDFViewer.pbproj/project.pbxproj: Call the new create-framework-symlinks script instead using a copy files phase.

WebCore:

Reviewed by John

khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Add call to update document layout before returning a Range. This is done to ensure recently-done editing changes are reflected in the calculation of the Range. This change solves a specific problem with updating the font panel, where the wrong Range was used, resulting in an incorrect font. Also, defer converting positions to be range-compliant positions. The nodeIsBeforeNode function is not range-compliant-position-savvy.

WebKit:

Reviewed by John

The font panel now updates correctly, reflecting the current selection. There may
still be some bugs and corner cases to handle, but this will work for a general
implementation of the feature.

WebView.subproj/WebView.m: (+[ElementOrTextFilter filter]): Added. This filter will accept DOM elements and text nodes and skip everything else. This filter is used when walking a selection to determine the fonts in use. (-[ElementOrTextFilter acceptNode:]): DOM node filter implementation method. (-[WebView _fontFromStyle]): Removed, in lieu of new fontForCurrentPosition call on the bridge. (-[WebView _updateFontPanel]): Reworked to use a TreeWalker instead of a NodeIterator. This was done since the iterator must be rooted at the document root, but start iterating at the start of the selection. TreeWalker's setCurrentNode allows this to be done.

May 27, 2004:

8:02 PM Changeset in webkit [6718] by kdecker

2 edits in trunk/WebKit

WebBrowser:

Reviewed by Ken.

-added the Error Console feature

ChangeLog:
Debug/ErrorConsoleController.h: Added.
Debug/ErrorConsoleController.m: Added. (+[ErrorConsoleController sharedController]): (-[ErrorConsoleController init]): (-[ErrorConsoleController windowNibName]): (-[ErrorConsoleController awakeFromNib]): (-[ErrorConsoleController addMessage:]):
Debug/ErrorConsoleModel.h: Added.
Debug/ErrorConsoleModel.m: Added. (-[ErrorConsoleModel init]): (-[ErrorConsoleModel addErrorToModel:]): (-[ErrorConsoleModel setTable:]): (-[ErrorConsoleModel numberOfRowsInTableView:]): (-[ErrorConsoleModel tableView:objectValueForTableColumn:row:]): (-[ErrorConsoleModel tableView:willDisplayCell:forTableColumn:row:]):

7:06 PM Changeset in webkit [6717] by kdecker

16 edits in trunk

JavaScriptCore:

Reviewed by Ken.

-revised generated error message content

kjs/error_object.cpp: (ErrorProtoFuncImp::call):
kjs/internal.cpp: (Parser::parse):
kjs/object.cpp: (KJS::Error::create):

WebCore:

Reviewed by Ken.

-wired up JavaScript error message handling to
the WebCoreBridge

khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
khtml/ecma/kjs_window.cpp: (Window::isSafeScript): (ScheduledAction::execute):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::addMessageToConsole):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

WebKit:

Reviewed by Ken.

-wired up JavaScript error message handling through
the WebCoreBridge

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge addMessageToConsole:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebUIDelegatePrivate.h:

WebBrowser:

Reviewed by Ken.

-added the JavaScript Console feature

BrowserWebController.m: (-[BrowserWebView setWindowFocusDisabled:]): (-[BrowserWebView webView:addMessageToConsole:]):
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument showJavaScriptConsole:]):
WebBrowser.pbproj/project.pbxproj:

5:14 PM Changeset in webkit [6716] by trey

3 edits in trunk/WebCore

Two dragging tweaks: ondragleave events are sent before ondragenter events when
going across element boundaries, to match WinIE.
For compatibility with WinIE, we honor MIME types of "Text" and "URL".

Reviewed by rjw.

khtml/khtmlview.cpp: (KHTMLView::updateDragAndDrop):
kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType):

4:28 PM Changeset in webkit [6715] by vicki

3 edits in trunk

Change version number to '143u'. The tree is open!

4:22 PM Changeset in webkit [6714]

3 copies in tags/Safari-142

This commit was manufactured by cvs2svn to create tag 'Safari-142'.

4:22 PM Changeset in webkit [6713] by vicki

6 edits in trunk

Safari-142 stamp

4:05 PM Changeset in webkit [6712] by vicki

7 edits in trunk/WebCore

Reviewed by Darin.

Fix Tiger build failure. Rename constant "S" to "WHITESPACE", and change all instances of S to WHITESPACE.

khtml/css/cssparser.cpp: (DOM::CSSParser::lex): S to WHITESPACE
khtml/css/parser.cpp: regenerated file
khtml/css/parser.h: regenerated file
khtml/css/parser.y: S to WHITESPACE
khtml/css/tokenizer.cpp: regenerated file
khtml/css/tokenizer.flex: S to WHITESPACE

3:46 PM Changeset in webkit [6711] by rjw

2 edits in trunk/JavaScriptCore

Renamed WebScriptMethods to WebScripting based on feedback
from Nancy.

Reviewed by Chris.

bindings/objc/WebScriptObject.h:

11:28 AM Changeset in webkit [6710] by ouch

4 edits in trunk/WebCore

Added support for fillRect, strokeRect, and setAlpha.

reviewed by richard.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

10:11 AM Changeset in webkit [6709] by trey

23 edits
2 adds in trunk

WebCore:

First cut at DHTML dragging, destination side. Dragging text, files

and URLs onto elements works. Type conversion from NSPasteboard to
MIME types is hardwired. No JS access yet to modifier keys, or
drag operations mask.

Per IE's dragging API, we have the new DOM events ondragenter,
ondragover, ondragleave and ondrop.
We also have an event.dataTransfer object providing access to the
NSPasteboard bearing the incoming data.

Reviewed by rjw.

WebCore.pbproj/project.pbxproj: add 2 new files.
khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): JS access to ondragenter and pals (DOMNode::putValue): Ditto
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): New attr enum values.
khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/ecma/kjs_events.cpp: (DOMMouseEvent::mark): Pass along mark to dataTransfer we hold. (DOMMouseEvent::getValueProperty): Create and return dataTransfer. (Clipboard::Clipboard): New class exposed in JS. (Clipboard::~Clipboard): (Clipboard::tryGet): Boilerplate. (Clipboard::getValueProperty): Return the clipboard's props. (Clipboard::tryPut): Boilerplate. (Clipboard::putValue): Set the clipboard's props. (ClipboardProtoFunc::tryCall): Implement clipboard's funcs.
khtml/ecma/kjs_events.h: (KJS::DOMMouseEvent::DOMMouseEvent): Init clipboard ptr. (KJS::DOMMouseEvent::): (KJS::Clipboard::toBoolean): (KJS::Clipboard::classInfo): (KJS::Clipboard::):
khtml/ecma/kjs_events.lut.h: (KJS::):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Enable setting ondragenter and friends as html attributes.
khtml/khtmlview.cpp: (KHTMLView::dispatchDragEvent): Send a drag related event to the DOM. (KHTMLView::updateDragAndDrop): Handle a dragenter or dragupdate. (KHTMLView::cancelDragAndDrop): Handle a dragexit. (KHTMLView::performDragAndDrop): Handle an actual drop.
khtml/khtmlview.h:
khtml/misc/htmlattrs.c: Generated code.
khtml/misc/htmlattrs.h: Generated code.
khtml/misc/htmlattrs.in: Add ondragenter, etc
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Handle new event types for dragging. (EventImpl::idToType): Ditto. (MouseEventImpl::MouseEventImpl): Init new clipboard ptr. (MouseEventImpl::~MouseEventImpl): Deref clipboard. (ClipboardImpl::ClipboardImpl): (ClipboardImpl::~ClipboardImpl):
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): New event enums. (DOM::MouseEventImpl::clipboard):
kwq/KWQClipboard.h: Added.
kwq/KWQClipboard.mm: Added. (KWQClipboard::KWQClipboard): (KWQClipboard::~KWQClipboard): (KWQClipboard::isForDragging): Trivial getter/setters. (KWQClipboard::dropEffect): (KWQClipboard::setDropEffect): (KWQClipboard::dropAllowed): (KWQClipboard::setDropAllowed): (cocoaTypeFromMIMEType): Convert MIME pboard type to Cocoa type. (KWQClipboard::clearData): OSX specific clipboard impl. of IE func (KWQClipboard::clearAllData): Ditto (KWQClipboard::getData): Ditto (KWQClipboard::setData): Ditto
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge dragOperationForDraggingInfo:]): Passthrough from WebKit to khtmlpart (-[WebCoreBridge dragExitedWithDraggingInfo:]): Ditto (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto

WebKit:

First cut at DHTML dragging, destination side. Dragging text, files and URLs onto
elements works. Type conversion from NSPasteboard to MIME types is hardwired.
No JS access yet to modifier keys, or operations mask.

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): Call DHTML dragging via bridge. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:]): Ditto.
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebView.m: (-[WebView _setWebKitDragRespondsToDragging:]): New SPI for finer grained control than the delegate currently has. (-[WebView _webKitDragRespondsToDragging]): Ditto. (-[WebView _commonInitializationWithFrameName:groupName:]): Init new flag. (-[WebView _dragOperationForDraggingInfo:]): Comment.
WebView.subproj/WebViewPrivate.h:

9:26 AM Changeset in webkit [6708] by kocienda

5 edits in trunk/WebCore

Reviewed by Gramps

kwq/KWQKHTMLPart.h: Declare new fontForCurrentPosition helper.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForCurrentPosition): Determines the "current font" in the way that Cocoa does. Either the font of the character before the caret, when the selection is a caret, or the font of the first character selected, when the selection is a range.
kwq/WebCoreBridge.h: Declare bridge method so this can be called from WebKit.
kwq/WebCoreBridge.mm: (-[WebCoreBridge fontForCurrentPosition]): Calls through to fontForCurrentPosition on KWQKHTMLPart.

9:22 AM Changeset in webkit [6707] by kocienda

4 edits in trunk/WebCore

Reviewed by Gramps

Adds a typing style member variable to khtml part.
This patch adds basic life-cycle management and
accessors. In addition, one essential piece of
behavior has been added: Clearing the typing style
whenever the selection changes.

Follow-on work will make this typing style a fully
functional part of applying styles to text while typing.

khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Clear typing style. (KHTMLPart::typingStyle): Getter. (KHTMLPart::setTypingStyle): Setter. (KHTMLPart::clearTypingStyle): Convenience. Sets to 0.
khtml/khtml_part.h: Function declarations.
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Initialize member variable. (KHTMLPartPrivate::~KHTMLPartPrivate): Deref if necessary.

9:18 AM Changeset in webkit [6706] by kocienda

3 edits in trunk/WebCore

Reviewed by Gramps

Add helper to get the DOM element for a Position.

khtml/xml/dom_position.cpp: (DOM::Position::element): Returns the Position's node if it is an element, or the first ancestor of the node that is an element. Returns 0 if node is not an element and has no parent that is an element.
khtml/xml/dom_position.h: Added declaration.

1:18 AM Changeset in webkit [6705] by darin

2 edits in trunk/WebKit

WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollVerticallyBy:]): Added comment.

1:14 AM Changeset in webkit [6704] by darin

7 edits in trunk/WebKit

Reviewed by Maciej.

fixed <rdar://problem/3667948>: (REGRESSION: Page Down key goes down two pages when smooth scrolling is on)

WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollVerticallyBy:]): Added return value to indicate if any scrolling was done. This requires using secret AppKit methods; the public methods don't have a return value. (-[WebFrameView _pageVertically:]): Added return value to indicate if any scrolling was done. (-[WebFrameView scrollPageUp:]): Base call through to next responder on whether any scrolling was done, using return value, rather than looking at new scroll position. This was the cause of the bug, since with smooth scrolling no scrolling has happened yet when the function returns. (-[WebFrameView scrollPageDown:]): Ditto.

removed temporary DOMDocument method from WebView

WebView.subproj/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]): Call getComputedStyle on the document that owns the element rather than on the document that currently contains the selection. (-[WebView _updateFontPanel]): Get the document from the DOM range rather than using the DOMDocument method. (-[WebView styleDeclarationWithText:]): Change this method to not use the DOMDocument method, but do the same job with inline code.

WebView.subproj/WebViewPrivate.h: Moved a recently-added category that is not SPI out of here.
WebView.subproj/WebViewInternal.h: Moved the category in here. And removed the DOMDocument method from it.

other changes

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

copy-webcore-files-to-webkit: Change tabs to spaces. Quiet the script down by making it no longer echo each command or print messages about what it's doing by default.

12:36 AM Changeset in webkit [6703] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

moved to new symlink technique for embedding frameworks

WebKit.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:32 AM Changeset in webkit [6702] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

moved to new symlink technique for embedding frameworks

WebCore.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:31 AM Changeset in webkit [6701] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

moved to new symlink technique for embedding frameworks

JavaScriptCore.pbproj/project.pbxproj: Get rid of embed-frameworks build step because we don't need it any more.

12:11 AM Changeset in webkit [6700] by darin

2 edits in trunk/WebKit

fixed Deployment build

WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): Got rid of ASSERT-only local variable.

12:10 AM Changeset in webkit [6699] by darin

2 edits in trunk/WebCore

fixed bug where all pages with images would cause a crash
fixed Deployment build

kwq/KWQPainter.mm: (QPainter::drawPixmap): Put #if 0 around placeholder code for setting up the graphics context.

May 26, 2004:

11:35 PM Changeset in webkit [6698] by rjw

6 edits in trunk/WebCore

Added shadow support (w/ Louch).
Added infrastructure for drawing images.

New context methods:

setShadow
setShadowWithColor
clearShadow

Reviewed by me and Louch.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Image::image): (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawPixmap):

11:32 PM Changeset in webkit [6697] by mjs

3 edits in trunk/WebKit

Reviewed by Dave.

fix further problems with Emerson feed: redirection for RSS feeds

This is done by removing removing the calls to defer callbacks
while waiting for

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]):

10:58 PM Changeset in webkit [6696] by beard

35 edits in branches/AutoZoneGC_Branch_20040430

Now using NSAllocateScannedUncollectable(size) rather than NSZoneMalloc(NULL, size) when scanned but uncollectable memor
y is needed. Ran sources through gctools/automate.rb to generate finalizers and wrap CFMakeCollectable around bridged CF

types.

6:02 PM Changeset in webkit [6695] by cblu

6 edits in trunk/WebKit

Added and implemented proposed dragging API changes. These changes are necessary to make JS dragging work properly.

Reviewed by trey.

WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:shouldDetermineDragOperationForDraggingInfo:dragOperation:]): instead of calling back to the WebView to get the default drag operation, return YES. Return NO in order to return a custom drag operation. Removed element parameter since another new API provides a way to get that. (-[WebDefaultUIDelegate webView:shouldProcessDragWithDraggingInfo:]): Removed element parameter since another new API provides a way to get that.
WebView.subproj/WebDocumentInternal.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): now returns a drag operation (-[WebHTMLView draggingCancelledWithDraggingInfo:]): moved
WebView.subproj/WebUIDelegatePrivate.h:
WebView.subproj/WebView.m: (-[WebView elementAtPoint:]): new proposed API (-[WebView dragOperationForDraggingInfo:]): removed code from this API that should be removed (-[WebView _dragOperationForDraggingInfo:]): call new API (-[WebView concludeDragOperation:]): call new API

5:23 PM Changeset in webkit [6694] by rjw

4 edits in trunk/WebCore

Fixed build snafu.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

4:58 PM Changeset in webkit [6693] by rjw

13 edits in trunk/WebCore

Part 2 of the new <CANVAS> tag implementation. This adds the
basic machinery and draw operations for the <CANVAS> tag. Pretty cool.

function drawLine() {

var canvas1 = document.getElementById ("canvas1");
var context = canvas1.getContext("context-2d");

context.setStrokeColor ("red");
context.setLineWidth (10);
context.beginPath();
context.moveToPoint (0,0);
context.addLineToPoint (400,400);
context.strokePath();

}

...

<canvas id="canvas1" width="400" height="400">

Currently supported operations on the 2D context are:

Save, Restore,
Scale, Rotate, Translate,
BeginPath, ClosePath,
SetStrokeColor, SetFillColor, SetLineWidth, SetLineCap, SetLineJoin, SetMiterLimit,
FillPath, StrokePath,
MoveToPoint, AddLineToPoint, AddQuadraticCurveToPoint, AddBezierCurveToPoint,
ClearRect

More to come.

Reviewed by Dave.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): (KJS::Context2DFunction::tryCall): (Context2D::tryGet): (Context2D::getValueProperty): (Context2D::tryPut): (Context2D::putValue): (Context2D::Context2D): (Context2D::~Context2D):
khtml/ecma/kjs_html.h: (KJS::Context2D::toBoolean): (KJS::Context2D::classInfo): (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):
khtml/html/html_canvasimpl.cpp: (HTMLCanvasElementImpl::HTMLCanvasElementImpl):
khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::RenderCanvasImage): (RenderCanvasImage::~RenderCanvasImage): (RenderCanvasImage::createDrawingContext): (RenderCanvasImage::drawingContext): (RenderCanvasImage::setNeedsImageUpdate): (RenderCanvasImage::updateDrawnImage): (RenderCanvasImage::drawnImage): (RenderCanvasImage::paint): (RenderCanvasImage::layout):
khtml/rendering/render_canvasimage.h:
khtml/rendering/render_image.cpp: (RenderImage::paint):
khtml/rendering/render_image.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::shouldPaint): (RenderWidget::paint):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::currentContext):

2:16 PM Changeset in webkit [6692] by darin

7 edits in trunk/WebKit

Reviewed by John.

moved HTML editing operations from WebView to WebHTMLView, leaving only forwarding machinery at the WebView level

fixed <rdar://problem/3655412>: (Editing:�startSpeaking:�ethod�nimplemented�WebKit�diting�PI))
fixed <rdar://problem/3655414>: (Editing:�stopSpeaking:�ethod�nimplemented�WebKit�diting�PI))
fixed <rdar://problem/3655375>: (Editing:�pasteAsRichText:�ethod�nimplemented�WebKit�diting�PI))

WebView.subproj/WebView.h: Added missing declaration of selectionAffinity. I think this omission was an editorial mistake.

WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Use _frameForCurrentSelection directly, since it no longer returns nil. (-[WebView pasteboardTypesForSelection]): Use _frameForCurrentSelection instead of going through the bridge. (-[WebView _frameForCurrentSelection]): Renamed from _currentFrame and changed to return main frame rather than nil when called on WebView that has no current selection. (-[WebView _bridgeForCurrentSelection]): Moved in file. (-[WebView _updateFontPanel]): Removed the one call to _currentSelectionIsEditable here, since it was the only one left in this file. Eventually this code will move to WebHTMLView. (-[WebView _performResponderOperation:with:]): Name change.

WebView.subproj/WebDataSource.m: (-[WebDataSource _documentFragmentWithImageResource:]): Build document fragment using DOM instead of composing HTML text.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Added allowPlainText boolean, moved method into new location in file so it can be in the right category, changed link pasting to use DOM instead of composing HTML text. (-[WebHTMLView _replaceSelectionWithPasteboard:selectReplacement:allowPlainText:]): Added allowPlainText boolean, moved method into new location in file so it can be in the right category. (-[WebHTMLView concludeDragForDraggingInfo:]): Pass YES for allowPlainText. (-[WebHTMLView centerSelectionInVisibleArea:]): Moved here from WebView. (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Ditto. (-[WebHTMLView moveBackward:]): Ditto. (-[WebHTMLView moveBackwardAndModifySelection:]): Ditto. (-[WebHTMLView moveDown:]): Ditto. (-[WebHTMLView moveDownAndModifySelection:]): Ditto. (-[WebHTMLView moveForward:]): Ditto. (-[WebHTMLView moveForwardAndModifySelection:]): Ditto. (-[WebHTMLView moveLeft:]): Ditto. (-[WebHTMLView moveLeftAndModifySelection:]): Ditto. (-[WebHTMLView moveRight:]): Ditto. (-[WebHTMLView moveRightAndModifySelection:]): Ditto. (-[WebHTMLView moveToBeginningOfDocument:]): Ditto. (-[WebHTMLView moveToBeginningOfLine:]): Ditto. (-[WebHTMLView moveToBeginningOfParagraph:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): Ditto. (-[WebHTMLView moveToEndOfLine:]): Ditto. (-[WebHTMLView moveToEndOfParagraph:]): Ditto. (-[WebHTMLView moveUp:]): Ditto. (-[WebHTMLView moveUpAndModifySelection:]): Ditto. (-[WebHTMLView moveWordBackward:]): Ditto. (-[WebHTMLView moveWordBackwardAndModifySelection:]): Ditto. (-[WebHTMLView moveWordForward:]): Ditto. (-[WebHTMLView moveWordForwardAndModifySelection:]): Ditto. (-[WebHTMLView moveWordLeft:]): Ditto. (-[WebHTMLView moveWordLeftAndModifySelection:]): Ditto. (-[WebHTMLView moveWordRight:]): Ditto. (-[WebHTMLView moveWordRightAndModifySelection:]): Ditto. (-[WebHTMLView pageDown:]): Ditto. (-[WebHTMLView pageUp:]): Ditto. (-[WebHTMLView selectParagraph:]): Ditto. (-[WebHTMLView selectLine:]): Ditto. (-[WebHTMLView selectWord:]): Ditto. (-[WebHTMLView copy:]): Moved down in file so it's in the right category. (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView delete:]): Ditto. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView copyFont:]): Moved here from WebView. (-[WebHTMLView pasteFont:]): Ditto. (-[WebHTMLView pasteAsPlainText:]): Ditto. (-[WebHTMLView pasteAsRichText:]): Implemented this by calling the paste code with allowPlainText:NO; believe it or not, that's what this means in NSTextView. (-[WebHTMLView changeFont:]): Moved here from WebView. (-[WebHTMLView changeAttributes:]): Ditto. (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto. (-[WebHTMLView changeColor:]): Ditto. (-[WebHTMLView alignCenter:]): Ditto. (-[WebHTMLView alignJustified:]): Ditto. (-[WebHTMLView alignLeft:]): Ditto. (-[WebHTMLView alignRight:]): Ditto. (-[WebHTMLView indent:]): Ditto. (-[WebHTMLView insertTab:]): Moved here from WebView, also call insertText rather than replaceSelectionWithText so it's undoable like a typed character. (-[WebHTMLView insertBacktab:]): Moved here from WebView. (-[WebHTMLView insertNewline:]): Moved here from WebView, also call insertText rather than replaceSelectionWithText so it's undoable like a typed character. (-[WebHTMLView insertParagraphSeparator:]): Moved here from WebView. (-[WebHTMLView changeCaseOfLetter:]): Ditto. (-[WebHTMLView uppercaseWord:]): Ditto. (-[WebHTMLView lowercaseWord:]): Ditto. (-[WebHTMLView capitalizeWord:]): Ditto. (-[WebHTMLView deleteForward:]): Ditto. (-[WebHTMLView deleteBackward:]): Ditto. (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Ditto. (-[WebHTMLView deleteWordForward:]): Ditto. (-[WebHTMLView deleteWordBackward:]): Ditto. (-[WebHTMLView deleteToBeginningOfLine:]): Ditto. (-[WebHTMLView deleteToEndOfLine:]): Ditto. (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto. (-[WebHTMLView deleteToEndOfParagraph:]): Ditto. (-[WebHTMLView complete:]): Ditto. (-[WebHTMLView checkSpelling:]): Ditto. (-[WebHTMLView showGuessPanel:]): Ditto. (-[WebHTMLView performFindPanelAction:]): Ditto. (-[WebHTMLView startSpeaking:]): Implemented this. (-[WebHTMLView stopSpeaking:]): Implemented this. (-[WebHTMLView insertText:]): Moved here from WebView.

WebView.subproj/WebHTMLViewPrivate.h: Removed declarations of methods that are neither SPI nor needed outside WebHTMLView.m.

WebView.subproj/WebViewInternal.h: Removed _currentFrame, and added _frameForCurrentSelection and _bridgeForCurrentSelection.

9:05 AM Changeset in webkit [6691] by darin

2 edits in trunk/WebCore

fixed warning that prevents Deployment build from compiling

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Moved use of single-click boolean outside the scope of the "block exceptions" macros.

12:17 AM Changeset in webkit [6690] by mjs

3 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3652498>: new sniffing support is crashing

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient checkContentPolicyForResponse:]): Retain listener around call, in case delegate does something that ends up invalidating it, like navigating to a new URL.

May 25, 2004:

4:45 PM Changeset in webkit [6689] by cblu

2 edits in trunk/WebCore

Fixed a regression where selections that were created via double or triple were not draggable.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): if the click count is greater than 1, don't allow drags (KWQKHTMLPart::khtmlMouseMoveEvent): allow drags to occur even if the selection was originally created via double or triple click

4:05 PM Changeset in webkit [6688] by cblu

5 edits in trunk

WebCore:

Fixed regression where undoing typing would undo character-by-character.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge insertText:]): new, this method used to be replaceSelectionWithText, but replaceSelectionWithText now is one operation whereas calls to insertText: are coalesced

WebKit:

Fixed regression where undoing typing would undo character-by-character.

Reviewed by kocienda.

WebView.subproj/WebView.m:

(-[WebView insertText:]): call insertText: rather than …: since text insertion via insertText: is coalesced and this is the behavior we want here

2:56 PM Changeset in webkit [6687] by kocienda

10 edits in trunk

WebCore:

Reviewed by John

Change postDidChangeSelectionNotification and postDidChangeNotification tp
respondToChangedSelection and respondToChangedContents, respectively, to
account for the fact that we do work in these calls other than post a
notification.

khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Use new names. (KHTMLPart::appliedEditing): Ditto. (KHTMLPart::unappliedEditing): Ditto. (KHTMLPart::reappliedEditing): Ditto.
kwq/KWQKHTMLPart.h: Change name of functions as described.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): Ditto. (KWQKHTMLPart::respondToChangedContents): Ditto.
kwq/WebCoreBridge.h: Ditto.

WebKit:

Reviewed by John

Change postDidChangeSelectionNotification and postDidChangeNotification tp
respondToChangedSelection and respondToChangedContents, respectively, to
account for the fact that we do work in these calls other than post a
notification. The need to clear the typing style on both kinds of changes
inspired the name change.

Add in support to set and access typing style. We don't do anything with it yet
except store and return it. Using the typing style is still to come.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): Change name of functions as described. (-[WebBridge respondToChangedSelection]): Change name of functions as described.
WebView.subproj/WebView.m: (-[WebView dealloc:]): Dealloc typing style ivar. (-[WebView setTypingStyle:]): Change to set typing style ivar. (-[WebView typingStyle]): Return new typing style ivar.
WebView.subproj/WebViewPrivate.h: Add ivar for typing style.

2:51 PM Changeset in webkit [6686] by mjs

1 edit
1 add in trunk/WebCore

Fixed build.

ForwardingHeaders/misc/khtml_text_operations.h: Added.

2:37 PM Changeset in webkit [6685] by rjw

10 edits
6 adds in trunk/WebCore

Part 1 of the new <CANVAS> tag implementation. This patch
adds the boiler plate for the new element.

Reviewed by Dave.

ForwardingHeaders/html/html_canvasimpl.h: Added.
ForwardingHeaders/rendering/render_canvasimage.h: Added.
WebCore.pbproj/project.pbxproj:
khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::classInfo): (KJS::HTMLElementFunction::tryCall):
khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
khtml/ecma/kjs_html.lut.h: (KJS::):
khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/html_canvasimpl.cpp: Added. (HTMLCanvasElementImpl::HTMLCanvasElementImpl): (HTMLCanvasElementImpl::~HTMLCanvasElementImpl): (HTMLCanvasElementImpl::id): (HTMLCanvasElementImpl::mapToEntry): (HTMLCanvasElementImpl::parseHTMLAttribute): (HTMLCanvasElementImpl::createRenderer): (HTMLCanvasElementImpl::attach): (HTMLCanvasElementImpl::detach): (HTMLCanvasElementImpl::isURLAttribute):
khtml/html/html_canvasimpl.h: Added.
khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
khtml/misc/htmltags.c: (hash_tag): (findTag):
khtml/misc/htmltags.h:
khtml/misc/htmltags.in:
khtml/rendering/render_canvasimage.cpp: Added. (RenderCanvasImage::RenderCanvasImage): (RenderCanvasImage::~RenderCanvasImage): (RenderCanvasImage::paint): (RenderCanvasImage::layout):
khtml/rendering/render_canvasimage.h: Added. (khtml::RenderCanvasImage::renderName): (khtml::RenderCanvasImage::element):

2:30 PM Changeset in webkit [6684] by cblu

4 edits in trunk/WebCore

Fixed: <rdar://problem/3546418>: (when dragging text within an editable HTML doc, the selection should be moved not copied)

Reviewed by kocienda.

khtml/editing/htmlediting_impl.cpp: (khtml::MoveSelectionCommandImpl::doApply): implemented
khtml/khtml_part.cpp: (KHTMLPart::setDragCaret): make the old drag cursor rect dirty
khtml/khtml_part.h:

2:00 PM Changeset in webkit [6683] by mjs

6 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3657363>: (Editing: export innerText, innerHTML, outerText, outerHTML and setters to Objective-C)
partial fix for <rdar://problem/3656706>: (Fix innerText and setInnerText DOM extensions)

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Use plainText() to make the text, to match other browsers. (HTMLElementImpl::outerText): Extended comment.
khtml/misc/khtml_text_operations.h:
kwq/DOMExtensions.h:
kwq/DOMHTML.mm: (-[DOMHTMLElement outerText]): Added new ObjC wrapper for this. (-[DOMHTMLElement setOuterText:]): Ditto.

1:29 PM Changeset in webkit [6682] by kocienda

3 edits in trunk/WebCore

Reviewed by Chris

Defer setting the selection to delete when none has been passed in to the
time that the command is run. This fixes a problem where a command nested
in a composite was not correctly picking up the right selection to begin
its work. Now, the command will correctly use the ending selection of
its parent when no selection has been passed in.

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteCollapsibleWhitespaceCommandImpl::DeleteCollapsibleWhitespaceCommandImpl): (khtml::DeleteCollapsibleWhitespaceCommandImpl::doApply): (khtml::DeleteSelectionCommandImpl::DeleteSelectionCommandImpl): (khtml::DeleteSelectionCommandImpl::doApply):
khtml/editing/htmlediting_impl.h:

11:27 AM Changeset in webkit [6681] by kocienda

3 edits in trunk/WebKit

Reviewed by John

Improve _bridgeForCurrentSelection so that it is frame-savvy.
Fixup setSelectedDOMRange:affinity: so that it uses the right bridge.

WebView.subproj/WebView.m: (-[WebView _bridgeForCurrentSelection]): Use _currentFrame not mainFrame. (-[WebView _currentFrame]): Moved to WebView (WebInternal) category so _bridgeForCurrentSelection can use it. (-[WebView setSelectedDOMRange:affinity:]): Derive the bridge to use from the range passed in; _bridgeForCurrentSelection is not the right way to get at the document for the range.
WebView.subproj/WebViewInternal.h: Add _currentFrame declaration.

May 24, 2004:

5:25 PM Changeset in webkit [6680] by darin

2 edits in trunk/WebKit

Reviewed by Ken.

fixed <rdar://problem/3666022>: (REGRESSION: crash from infinite regress in -[WebFrameView(WebPrivate) scrollPageDown:])

WebView.subproj/WebView.m: (-[WebView _performResponderOperation:sender:]): Helper method that knows how to pass on operations to the responder chain, allowing us to implement operations that will get passed to views inside us as necessary. Moved a few methods to this, and soon will move even more. (-[WebView scrollLineDown:]): Use the above method. (-[WebView scrollLineUp:]): Ditto. (-[WebView scrollPageDown:]): Ditto. (-[WebView scrollPageUp:]): Ditto. (-[WebView copy:]): Ditto. (-[WebView cut:]): Ditto. (-[WebView paste:]): Ditto. (-[WebView delete:]): Ditto. (-[WebView insertBacktab:]): Ditto.

5:18 PM Changeset in webkit [6679] by mjs

1 edit
2 adds in trunk

Reviewed by Dave.

Added a new simple layout test for outerText.

layout-tests/fast/dom/outerText-expected.txt: Added.
layout-tests/fast/dom/outerText.html: Added.

3:53 PM Changeset in webkit [6678] by darin

2 edits in trunk/WebCore

Reviewed by Vicki.

fixed <rdar://problem/3665813>: (iBench is crashing in TOT)

khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::HTMLSelectElementImpl): Initialize m_options to 0.

3:19 PM Changeset in webkit [6677] by rjw

6 edits
1 add in trunk/JavaScriptCore

Changed RuntimeArrayImp to inherit from ArrayInstanceImp and
fixed ClassInfo to correctly reflect inheritance. This is required
because of the runtime checks in JSC for arrays, i.e. in
the Function objects apply method.

Reviewed by Ken.

bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray):
bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp):
bindings/runtime_array.h:
bindings/testM.js: Added.
bindings/testbindings.mm: (+[MyFirstInterface webScriptNameForSelector:]): (-[MyFirstInterface logMessages:]): (-[MyFirstInterface logMessage:prefix:]): (-[MyFirstInterface callJSObject::]):

3:18 PM Changeset in webkit [6676] by kocienda

7 edits in trunk/WebCore

Reviewed by Richard

khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Improved the code to return ranges that are convenient to use by WebKit code which needs to perform text-editor-like operations with ranges. Comments in the code describe this behavior. (DOM::Selection::nodeIsBeforeNode): Make this method const.
khtml/xml/dom_selection.h: Ditto.

2:55 PM Changeset in webkit [6675] by cblu

21 edits in trunk

WebCore:

Improved editing via drag.

Reviewed by kocienda.

khtml/editing/htmlediting.cpp: Renamed PasteMarkupCommand to ReplaceSelectionCommand (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::impl): (khtml::MoveSelectionCommand::MoveSelectionCommand): (khtml::MoveSelectionCommand::~MoveSelectionCommand): (khtml::MoveSelectionCommand::impl):
khtml/editing/htmlediting.h: (khtml::):
khtml/editing/htmlediting_impl.cpp: (khtml::ReplaceSelectionCommandImpl::ReplaceSelectionCommandImpl): (khtml::ReplaceSelectionCommandImpl::~ReplaceSelectionCommandImpl): (khtml::ReplaceSelectionCommandImpl::commandID): (khtml::ReplaceSelectionCommandImpl::doApply): (khtml::MoveSelectionCommandImpl::MoveSelectionCommandImpl): new command (khtml::MoveSelectionCommandImpl::~MoveSelectionCommandImpl): (khtml::MoveSelectionCommandImpl::commandID): (khtml::MoveSelectionCommandImpl::doApply):
khtml/editing/htmlediting_impl.h:
khtml/khtml_part.cpp: (KHTMLPart::dragCaret): new (KHTMLPart::setDragCaret): new (KHTMLPart::notifyDragCaretChanged): new (KHTMLPart::paintDragCaret): new
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): paint the drag caret
kwq/DOM.mm: (+[DOMDocumentFragment _documentFragmentWithImpl:]): made internally available (-[DOMDocumentFragment _fragmentImpl]):
kwq/DOMInternal.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): new (-[WebCoreBridge documentFragmentWithText:]): new (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:]): new (-[WebCoreBridge replaceSelectionWithNode:selectReplacement:]): renamed to take the selectReplacement BOOL (-[WebCoreBridge replaceSelectionWithMarkupString:baseURLString:selectReplacement:]): ditto (-[WebCoreBridge replaceSelectionWithText:selectReplacement:]): ditto (-[WebCoreBridge replaceSelectionWithNewline]): moved (-[WebCoreBridge setSelectionToDragCaret]): new (-[WebCoreBridge moveSelectionToDragCaret:]): new (-[WebCoreBridge moveDragCaretToPoint:]): set the drag caret, not the selection (-[WebCoreBridge removeDragCaret]): new

WebKit:

Improved editing via drag

Reviewed by kocienda.

WebView.subproj/WebDataSource.m: (-[WebDataSource _documentFragmentWithImageResource:]): made this method return a fragment instead of replace the selection so that the caller do other things with the fragment (-[WebDataSource _documentFragmentWithArchive:]): ditto (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): call renamed methods
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDocumentInternal.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:]): made this method return a fragment instead of replace the selection so that the caller do other things with the fragment (-[WebHTMLView _replaceSelectionWithPasteboard:selectReplacement:]): new (-[WebHTMLView paste:]): call _replaceSelectionWithPasteboard:selectReplacement: (-[WebHTMLView dragOperationForDraggingInfo:]): handle the case where the destination is editable, but the source is not (-[WebHTMLView draggingCancelledWithDraggingInfo:]): new, removes drag caret (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): remove drag caret when we can't handle the drag (-[WebHTMLView concludeDragForDraggingInfo:]): instead of calling paste, move the selection when doing a move and replace the drag caret when doing a copy
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): (-[WebView _setDraggingDocumentView:]): new (-[WebView _dragOperationForDraggingInfo:]): if the current dragging document view changes, tell the previous dragging document view that dragging cancelled (-[WebView draggingExited:]): new, tell the previous dragging document view that dragging cancelled (-[WebView concludeDragOperation:]): release the dragging document view (-[WebView replaceSelectionWithNode:]): pass the selectReplacement BOOL to the bridge (-[WebView replaceSelectionWithText:]): ditto (-[WebView replaceSelectionWithMarkupString:]): ditto (-[WebView replaceSelectionWithArchive:]): ditto (-[WebView pasteAsPlainText:]): ditto (-[WebView insertTab:]): ditto (-[WebView insertText:]): ditto
WebView.subproj/WebViewPrivate.h:

1:40 PM Changeset in webkit [6674] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fixed some life-cycle issues with node iterators and detaching. Big deal is
to detach in DOMNodeIterator dealloc. Otherwise, NodeIterators created from
obj-c leak.

khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::detach): Only detach if not yet detached.
khtml/xml/dom2_traversalimpl.h: (DOM::NodeIteratorImpl::setDetached): New convenience.
kwq/DOM.mm: (-[DOMNodeIterator dealloc]): Detach here, if not yet detached; fixes leak.

1:14 PM Changeset in webkit [6673] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Fixed to return the property value, as it should, instead of the whole property, as it was doing before.

1:01 PM Changeset in webkit [6672] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by Dave.

added private RSSFeedReferrer field to WebHistoryItem so RSS feeds in the back/forward list can remember what page (if any) they were initiated from.

History.subproj/WebHistoryItem.m: new RSSFeedReferrer ivar in private structure (-[WebHistoryItemPrivate dealloc]): release RSSFeedReferrer (-[WebHistoryItem copyWithZone:]): copy RSSFeedReferrer (-[WebHistoryItem RSSFeedReferrer]): return RSSFeedReferrer (-[WebHistoryItem setRSSFeedReferrer:]): set RSSFeedReferrer

History.subproj/WebHistoryItemPrivate.h: declare -RSSFeedReferrer and -setRSSFeedReferrer:

WebBrowser:

Reviewed by Dave.

More work on Emerson show/hide button. Now when the "Show RSS Feed" button
is clicked, we stash away the URL we are expecting to load. When (if) that URL
is loaded, we find the previous URL from the back list and store that in the
RSS feed's history item, so that if we revisit this RSS feed using the back/forward
list, we'll correctly display the "Hide RSS Feed" button. (If the RSS feed's URL
is visited some other way, it won't have a corresponding URL to "return" to, and
the "Hide RSS Feed" button will not appear.)

BrowserWebController.h: new ivar and getter/setter for pendingRSSFeedURLString
BrowserWebController.m: (-[BrowserWebView dealloc]): release _pendingRSSFeedURLString (-[BrowserWebView pendingRSSFeedURLString]): get _pendingRSSFeedURLString (-[BrowserWebView setPendingRSSFeedURLString:]): set _pendingRSSFeedURLString (-[BrowserWebView counterpartURLForRSS]): get RSS feed referrer from current back/forward list history item

BrowserWindowController.m: (-[BrowserWindowController windowShouldGoToURL:]): cleanup noticed in passing: use [[self currentWebView] goToURL:URL] instead of [[self browserDocument] goToURL:URL] because it seems clearer (and does the same thing) (-[BrowserWindowController performQuickSearch:]): ditto (-[BrowserWindowController updateRSSButton]): added comment (-[BrowserWindowController goToCounterpartURLForRSS]): when going to an RSS feed, call setPendingRSSFeedURLString so we will set the referrer on the history item in the upcoming commit

LocationChangeHandler.m: (-[LocationChangeHandler webView:didCommitLoadForFrame:]): if the incoming URL matches the pending RSS feed, set the RSS feed referrer on the history item for the incoming URL

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed