Timeline
Nov 23, 2004:
- 5:06 PM Changeset in webkit [8079] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3890385> field and method cache incorrectly capped (c bindings)
Reviewed by Ken.
- bindings/c/c_class.cpp: (CClass::_commonInit):
- 4:07 PM Changeset in webkit [8078] by
-
- 2 edits in trunk/WebCore
Added various comments.
- khtml/editing/htmlediting.cpp: (khtml::StyleChange::init): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyBlockStyle): (khtml::ApplyStyleCommand::applyInlineStyle):
- 10:50 AM Changeset in webkit [8077] by
-
- 6 edits in trunk/WebKit
Fixed: <rdar://problem/3890944> disable icon database for Dashboard
Reviewed by kevin.
- Misc.subproj/WebIconDatabase.h:
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): don't create dictionaries if disabled (-[WebIconDatabase iconForURL:withSize:cache:]): return default icon if disabled (-[WebIconDatabase iconURLForURL:]): return nil if disabled (-[WebIconDatabase retainIconForURL:]): return if disabled (-[WebIconDatabase releaseIconForURL:]): ditto (-[WebIconDatabase delayDatabaseCleanup]): ditto (-[WebIconDatabase allowDatabaseCleanup]): ditto (-[WebIconDatabase _isEnabled]): new (-[WebIconDatabase _setIcon:forIconURL:]): assert if called when disabled, moved to own category implementation (-[WebIconDatabase _setHaveNoIconForIconURL:]): ditto (-[WebIconDatabase _setIconURL:forURL:]): ditto (-[WebIconDatabase _createFileDatabase]): tweak (-[WebIconDatabase _applicationWillTerminate:]): moved out of public code
- Misc.subproj/WebIconDatabasePrivate.h:
- Misc.subproj/WebIconLoader.m:
- WebView.subproj/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): assert if called when icon DB is disabled (-[WebDataSource _loadIcon]): don't load icon if icon DB is disabled
- 12:22 AM Changeset in webkit [8076] by
-
- 2 edits in trunk/WebCore
Hit testing in table cells with top/bottom space from vertical alignment didn't work. I forgot about the
super-secret yPos() lie that table cells do. Use m_y instead of yPos().
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):
Nov 22, 2004:
- 11:58 PM Changeset in webkit [8075] by
-
- 2 edits in trunk/WebCore
Make sure you can use document.createElement to make a <canvas> element.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
- 11:45 PM Changeset in webkit [8074] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave.
<rdar://problem/3492044> performing JavaScript operations on form elements is slower than WinIE (HTMLFormCollection)
<rdar://problem/3489679> selecting an item on the Apache bugzilla query page is very slow (HTMLFormCollection)
<rdar://problem/3477810> checking 80 check boxes with JavaScript is 10x slower than in IE (HTMLFormCollection)
<rdar://problem/3760962> JavaScript that toggles checkboxes is slow (HTMLCollection,HTMLFormCollection)
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet):
- khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLFormElementImpl::~HTMLFormElementImpl):
- khtml/html/html_formimpl.h:
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::HTMLCollectionImpl): (HTMLCollectionImpl::~HTMLCollectionImpl): (HTMLCollectionImpl::CollectionInfo::CollectionInfo): (HTMLCollectionImpl::CollectionInfo::reset): (HTMLCollectionImpl::resetCollectionInfo): (HTMLCollectionImpl::checkForNameMatch): (appendToVector): (HTMLCollectionImpl::updateNameCache): (HTMLCollectionImpl::namedItems): (HTMLFormCollectionImpl::HTMLFormCollectionImpl): (HTMLFormCollectionImpl::~HTMLFormCollectionImpl): (HTMLFormCollectionImpl::item): (HTMLFormCollectionImpl::updateNameCache):
- khtml/html/html_miscimpl.h:
- 11:23 PM Changeset in webkit [8073] by
-
- 2 edits in trunk/WebKit
Make sure the WebCore cache grows at 512mb and at 1024mb exactly.
Reviewed by mjs
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]):
- 11:21 PM Changeset in webkit [8072] by
-
- 3 edits in trunk/WebCore
Improve the WebCore cache so that the maximum cacheable object size is scaled based off the total cache
size.
Reviewed by mjs
- khtml/misc/loader.cpp: (CachedObject::finish): (Cache::flush): (Cache::setSize):
- khtml/misc/loader.h: (khtml::Cache::maxCacheableObjectSize):
- 9:50 PM Changeset in webkit [8071] by
-
- 1 edit in trunk/WebCore/khtml/rendering/render_frames.cpp
Fix mistake made with frameset hit testing from previous checkin.
- 9:08 PM Changeset in webkit [8070] by
-
- 30 edits in trunk/WebCore
Fix for 3673381, huge directory listing so slow it seems like a hang. Rework painting and hit testing so that
it crawls the line box tree instead of the render tree. This allows more precise intersection/containment testing
that lets us short circuit earlier when painting and hit testing.
Reviewed by mjs
- khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection):
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::paintChildren): (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::nodeAtPoint):
- khtml/rendering/render_block.h:
- khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint):
- khtml/rendering/render_box.h:
- khtml/rendering/render_br.h:
- khtml/rendering/render_canvas.cpp: (RenderCanvas::paint):
- khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): (RenderFlow::hitTestLines): (RenderFlow::caretRect): (RenderFlow::addFocusRingRects): (RenderFlow::paintFocusRing): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
- khtml/rendering/render_frames.h:
- khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
- khtml/rendering/render_image.h:
- khtml/rendering/render_inline.cpp: (RenderInline::paint): (RenderInline::nodeAtPoint):
- khtml/rendering/render_inline.h:
- khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer): (RenderLayer::hitTest): (RenderLayer::hitTestLayer):
- khtml/rendering/render_layer.h:
- khtml/rendering/render_line.cpp: (khtml::InlineBox::paint): (khtml::InlineBox::nodeAtPoint): (khtml::InlineFlowBox::flowObject): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paint): (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::InlineFlowBox::paintDecorations): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::paint): (khtml::RootInlineBox::nodeAtPoint):
- khtml/rendering/render_line.h: (khtml::InlineRunBox::paintBackgroundAndBorder):
- khtml/rendering/render_object.cpp: (RenderObject::hitTest): (RenderObject::setInnerNode): (RenderObject::nodeAtPoint):
- khtml/rendering/render_object.h: (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::PaintInfo::~PaintInfo): (khtml::RenderObject::paintingRootForChildren): (khtml::RenderObject::shouldPaintWithinRoot):
- khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint):
- khtml/rendering/render_text.cpp: (simpleDifferenceBetweenColors): (correctedTextColor): (InlineTextBox::nodeAtPoint): (InlineTextBox::paint): (InlineTextBox::selectionStartEnd): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::paintDecoration): (RenderText::posOfChar):
- khtml/rendering/render_text.h: (khtml::RenderText::paint): (khtml::RenderText::layout): (khtml::RenderText::nodeAtPoint):
- khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::computeLayerPos):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
- kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityHitTest:]):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::eventMayStartDrag): (KWQKHTMLPart::khtmlMouseMoveEvent):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge _positionForPoint:]):
- 8:48 PM Changeset in webkit [8069] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3891737> WebPreferences do not work if they are set before set on the WebView
John found this problem and suggested the fix.
Reviewed by John Louch.
- WebView.subproj/WebView.m: (-[WebView setPreferences:]):
- 7:02 PM Changeset in webkit [8068] by
-
- 1 edit in trunk/WebCore/khtml/html/html_formimpl.cpp
Remove bogus printf.
- 6:06 PM Changeset in webkit [8067] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Ken.
<rdar://problem/3889696> Enable conservative garbage collection for JavaScript
- kjs/collector.cpp: (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::initializeRegisteredThreadKey): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively):
- kjs/collector.h:
- kjs/internal.cpp: (lockInterpreter):
- kjs/value.h:
- 5:44 PM Changeset in webkit [8066] by
-
- 7 edits in trunk/WebCore
Reviewed by Dave.
<rdar://problem/3890961> selecting an item on the Apache bugzilla query page can be sped up 10% (HTMLFormCollection)
<rdar://problem/3890958> JavaScript that toggles checkboxes can be improved 73% (HTMLCollection,HTMLFormCollection)
This avoids the O(N2) penalty for named item traversal for form collections.
It also combines the item traversal logic for all non-form
collection operations into a single traverseNextItem
function. This avoids having 5 copies of the big switch statement
for this.
Also fixed a bug that prevented the last form element from being removed properly.
- khtml/html/html_formimpl.cpp: (DOM::removeFromVector):
- khtml/dom/html_misc.cpp: (HTMLCollection::namedItems):
- khtml/dom/html_misc.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::length): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::checkForNameMatch): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::namedItems): (HTMLCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::calcLength): (HTMLFormCollectionImpl::namedItem): (HTMLFormCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::namedItems):
- khtml/html/html_miscimpl.h:
- 3:07 PM Changeset in webkit [8065]
-
- 71 copies2 deletes in tags/WebCore-125~8~12
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~12'.
- 3:07 PM Changeset in webkit [8064] by
-
- 1 edit in branches/Safari-1-2-branch/WebCore/WebCore.pbproj/project.pbxproj
* empty log message *
- 3:07 PM Changeset in webkit [8063] by
-
- 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23
Fixed by Maciej, merged by Darin for SUPanPlum <rdar://problem/3872586>.
2004-11-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.
- 9:16 AM Changeset in webkit [8062] by
-
- 11 edits in trunk
WebCore:
Reviewed by Harrison
Change around the way we block the Javascript "Paste" command identifier from
being available. Formerly, this was done with an ifdef we never compiled in.
Now, this is done with a couple of cheap runtime checks. The advantage is that
we can now compile this command into development builds, and still yet switch
on the command in deployment builds through the use of WebCore SPI so we can
write and run layout tests with all of our builds.
- khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported): Checks state of paste command in case command being queried is the paste command. (DOM::JSEditor::setSupportsPasteCommand): New SPI to turn on paste command.
- khtml/editing/jsediting.h: Ditto.
- khtml/khtml_part.cpp: (KHTMLPart::pasteFromPasteboard): Added. (KHTMLPart::canPaste): Added.
- kwq/KWQKHTMLPart.mm: (KHTMLPart::canPaste): Added.
- kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Turn on paste command.
- kwq/WebCoreBridge.h: Add canPaste call so WebKit can fill in the answer.
WebKit:
Reviewed by Harrison
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canPaste]): Call WebView _canPaste.
- WebView.subproj/WebView.m: (-[WebView _canPaste]): Try to forward to document view's implementation. Only WebHTMLView answers right now. Returns NO otherwise.
- WebView.subproj/WebViewInternal.h: Add _canPaste method to WebView.
- 2:24 AM Changeset in webkit [8061] by
-
- 2 edits in trunk/WebKit
Back out the window closing fix, it seems to be causing crashes.
- WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]):
Nov 21, 2004:
- 8:31 PM Changeset in webkit [8060] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard.
<rdar://problem/3889655> HTMLCollectionImpl should use traverseNextNode to improve speed and save recursion
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::getNamedItem): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::nextNamedItemInternal): (HTMLFormCollectionImpl::nextNamedItemInternal):
Nov 20, 2004:
- 2:10 PM Changeset in webkit [8059] by
-
- 3 edits in trunk/WebKit
WebKit:
Reviewed by John.
<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): New SPI to check if a URL string is already in user-visible form (i.e. converting it to an NSURL and then back via _web_userVisibleString would not change anything).
WebBrowser:
Reviewed by John,
<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower
- URLCompletionController.m: (_rawStringFromItem): use URLString from history item when possible, only convert to user visible string when we really have to.
- 1:44 PM Changeset in webkit [8058] by
-
- 2 edits in trunk/WebKit
WebKit:
Reviewed by NOBODY (OOPS!).
<rdar://problem/3190977> closing window with many tabs in it can be quite slow
- WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): autorelease bridge instead of releasing it, to make window and tab closing more responsive - this way the deallocation happens after the windoow or tab appears to close.
WebBrowser:
Reviewed by NOBODY (OOPS!).
<rdar://problem/3190977> closing window with many tabs in it can be quite slow
- BrowserDocument.m: (-[BrowserDocument close]): Don't make an autorelease pool here. This should not be needed for PLT world leak detection any more, and it is necessary to make window closing responsive.
