Timeline
Jan 20, 2005:
- 6:25 PM Changeset in webkit [8424] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3815672> REGRESSION (Mail): Japanese text cannot be made bold
The AppKit's font substitution API doesn't match font traits!
It only find fonts that contain the appropriate glyphs. This
patch attempts to find the best variation within a family.
Also, made unrelated change to return printer/screen version of
substituted font.
Reviewed by Maciej.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _substituteFontForString:families:]):
- 5:50 PM Changeset in webkit [8423] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/3965196> security fix for javascript: exploit missed one case (already fixed in updates)
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): correct mistake in earlier fix for the following bug, caught by Adele:
<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration
- 5:36 PM Changeset in webkit [8422] by
-
- 4 edits in trunk
Reviewed by Ken.
<rdar://problem/3965466> editing needs to insert text before applying typing style
- khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Remove a FIXME comment. (khtml::InsertLineBreakCommand::doApply): Apply style to the BR node after inserting it. (khtml::InsertTextCommand::prepareForTextInsertion): Don't try to apply style to any new nodes created before inserting. (khtml::InsertTextCommand::input): Apply style to the inserted range after doing the text insert.
- khtml/editing/htmlediting.h:
This change leads to improved results on one of the layout tests:
- layout-tests/editing/inserting/insert-div-024-expected.txt:
- 5:22 PM Changeset in webkit [8421] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by me, changes by Han Ming Ong.
- <rdar://problem/3964302> SWB: A few files need to be updated to be compilable under GCC 4.0
- bindings/objc/WebScriptObjectPrivate.h: Make members public.
- kjs/lookup.h: Change "value.h" to "object.h" because we need KJS::Object to compile a template.
- 4:58 PM Changeset in webkit [8420] by
-
- 1 edit in trunk/WebKit/ChangeLog
move the Safari-180 release-marker in the ChangeLog, since the fix for 3786659 will be included in Safari-180
- 4:50 PM Changeset in webkit [8419] by
-
- 2 edits in trunk/WebKit
Reviewed by John
Fix for this bug:
<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with "size up" and "size down" NSFontManager changes
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addToStyle:fontA:fontB:]): This is the WebKit side of the fix. Replaced unimplemented code blocks with FIXME's in them for make bigger and make smaller with real working code.
- 4:41 PM Changeset in webkit [8418] by
-
- 4 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3964634> undefined property value from binding seems to evaluate to true in an if statement
The comprehensive fix for this problem requires new API, as described in 3965326. However,
given that we can't add new API at this point, the 'ObjcFallbackObjectImp' will behave
like and Undefined object if invokeUndefinedMethodFromWebScript:withArguments: isn't
implemented on the bound object.
Reviewed by Chris.
- bindings/objc/objc_runtime.h:
- bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::implementsCall): (ObjcFallbackObjectImp::toBoolean):
- bindings/testbindings.mm: (+[MyFirstInterface isSelectorExcludedFromWebScript:]): (+[MyFirstInterface isKeyExcludedFromWebScript:]):
- 4:01 PM Changeset in webkit [8417] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Finished my thought in the changelog. I left a comment half-written earlier.
- 3:47 PM Changeset in webkit [8416] by
-
- 3 edits in trunk
Versioning for TOT, Safari 2.0 (180+).
The tree is open!
- 3:33 PM Changeset in webkit [8415] by
-
- 6 edits in trunk
Safari-180 stamp
- 2:02 PM Changeset in webkit [8414] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3964646> REGRESSION (179-180): Typing space at end of line makes following paragraph disappear
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Recent change to block placeholder removal code caused this regression. The code became too aggressive in removing block placeholders, and would remove them from blocks other than the block containing the selection.
- layout-tests/editing/inserting/insert-div-023-expected.txt: This file had a spur
- layout-tests/editing/inserting/insert-div-024-expected.txt:
- 12:36 PM Changeset in webkit [8413] by
-
- 2 edits in trunk/WebCore
Fix for oddness on albertsons.com. Make sure not to crash when setting/removing style properties on a node
with no document. The bug # is 3813900.
Reviewed by john
- 11:34 AM Changeset in webkit [8412] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
PARTIAL fix for following bug. Create attributed string with fonts and links. Still need to add attachments.
<rdar://problem/3942606> AX: Support kAXAttributedStringForTextMarkerRangeParameterizedAttribute
- kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): Touched up previous checkin to match code review comments.
(-[KWQAccObject value]):
Use plainText for this one instead of obsolete attributedString.
(-[KWQAccObject accessibilityParameterizedAttributeNames]):
Advertise AXAttributedStringForTextMarkerRange.
(AXAttributeStringAddFont):
(AXAttributeStringAddElement):
(-[KWQAccObject linkUIElementForNode:]):
(-[KWQAccObject _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[KWQAccObject accessibilityAttributedStringForRange:]):
New routines to support AXAttributedStringForTextMarkerRange.
(-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
Use new routines instead of obsolete attributedString.
- 11:01 AM Changeset in webkit [8411] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3960196> AX Crash in DOM::Range::setStartBefore
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::getAccObjectCache): Adjust when detecting cache in non-top level WebArea.
- kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject accessibilityAttributeValue:]): Make sure the elements document is the current one for the part.
- 10:05 AM Changeset in webkit [8410] by
-
- 6 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3922980> Mail not crashing, just quitting itself suddenly in -[WebHTMLView(MailExtras) findString:options:]
- khtml/dom/dom2_range.cpp: (DOM::operator==): Handle null and detached ranges without raising exceptions. The uncaught exception would make the entire program terminate.
- fixed <rdar://problem/3885729> attempting to modify a computed style does nothing, but should raise a DOM exception
- kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setProperty:::]): Uncommented this code which I had to disable back in November because Mail was stumbling over it.
- fixed <rdar://problem/3943049> focus() called during onload handler results in square text field on <input type=search>
- kwq/KWQLineEdit.mm: (QLineEdit::baselinePosition): Change computation so it will work even for fields that position their text in a way that depends on vertical size. In the case of a search field, the text is centered, so the old logic was broken.
- kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Set the frame size to something large enough to accomodate the field editor. If we start the frame at size 0,0 we run into AppKit trouble when it insets the frame to figure out the frame for the field editor. In the case of this bug this happens because we become first responder before being sized and positioned by the HTML layout code.
- improved debugging output when using "po" from gdb with Objective-C DOM
- kwq/DOM.mm: (-[DOMNode description]): Added. Includes node name ("<tr>") and node value (e.g., string for text node). (-[DOMRange description]): Tweaked format.
Jan 19, 2005:
- 6:09 PM Changeset in webkit [8409] by
-
- 2 edits in trunk/WebCore
After further discussion with Real we have decided to NOT include the
additional CLSID for the real plugin. See 3958601.
Reviewed by Darin.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
- 5:39 PM Changeset in webkit [8408] by
-
- 5 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3853676> Browser Crash when accessing CCWeb Progress Page - KJS::Bindings::convertValueToJValue
Fixed the following problems with LiveConnect that are demonstrated by the application
described in 3853676.
- If a nil object is passed in an array from Java to JavaScript we will crash.
- We sometimes will incorrectly attempt to access a generic JavaScript as a Java runtime object wrapper.
- We will sometimes fail to find the correct static method ID.
Reviewed by Maciej.
- bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue): (JSObject::listFromJArray):
- bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bindings/jni/jni_utility.cpp: (KJS::Bindings::getMethodID): (KJS::Bindings::convertValueToJValue):
- bindings/runtime_array.h:
- 4:45 PM Changeset in webkit [8407] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
Previous checkin for this bug was missing some of the patch. Editing snafu with multiple changes in tree.
- kwq/KWQAccObject.mm: (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):
- 4:05 PM Changeset in webkit [8406] by
-
- 2 edits in trunk/WebKit
Fix for 3513067, spaces being lost when RTL text is rendered. Make sure not to allow hangers or spaces
in the margin.
Reviewed by john
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
- 4:01 PM Changeset in webkit [8405] by
-
- 2 edits in trunk/WebCore
Reviewed by John
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Small, cosmetic change John and I decided to do on my last checkin, but I forgot to do before landing.
- 3:54 PM Changeset in webkit [8404] by
-
- 21 edits6 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::applyStyle): (khtml::CompositeEditCommand::insertBlockPlaceholder): New function that unconditionally adds a block placeholder. (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Now returns bool based on whether placeholder was added or not. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Now searches all the descendents of a block looking for a placeholder. The old code, which just looked at the last child of a node, started missing once block placeholders became styled (which started happening with this patch). (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Now handles applying typing style to a block placeholder at call time, rather than setting the typing style as a latent style that might be applied later. This is an important part of the bug fix. (khtml::DeleteSelectionCommand::doApply): Now uses bool return value from insertBlockPlaceholderIfNeeded() and passes it along to calculateStyleBeforeInsertion, so the case where a block placeholder needs to be styled can be detected. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Changed the way this class managed style. Before it would calculate and set typing style for the block added. This is not sufficient. Added blocks need to styled immediately. Some name changes to instance variables in this class due to the change to accommodate this change. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Name changes, as above. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Improve check for testing when a placeholder block can be removed in its entirety after the insertion.
- khtml/editing/htmlediting.h: Update header accordingly.
- khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle): Move position for computed style check downstream before doing check when the position is in an empty block (this makes sure any style on any block placeholder is accounted for).
New layout tests to check bug fix.
- layout-tests/editing/style/block-style-004-expected.txt: Added.
- layout-tests/editing/style/block-style-004.html: Added.
- layout-tests/editing/style/block-style-005-expected.txt: Added.
- layout-tests/editing/style/block-style-005.html: Added.
- layout-tests/editing/style/block-style-006-expected.txt: Added.
- layout-tests/editing/style/block-style-006.html: Added.
Results updated to reflect new block placeholder code.
- layout-tests/editing/inserting/insert-div-004-expected.txt
- layout-tests/editing/inserting/insert-div-005-expected.txt
- layout-tests/editing/inserting/insert-div-006-expected.txt
- layout-tests/editing/inserting/insert-div-008-expected.txt
- layout-tests/editing/inserting/insert-div-011-expected.txt
- layout-tests/editing/inserting/insert-div-012-expected.txt
- layout-tests/editing/inserting/insert-div-013-expected.txt
- layout-tests/editing/inserting/insert-div-014-expected.txt
- layout-tests/editing/inserting/insert-div-015-expected.txt
- layout-tests/editing/inserting/insert-div-016-expected.txt
- layout-tests/editing/inserting/insert-div-017-expected.txt
- layout-tests/editing/inserting/insert-div-018-expected.txt
- layout-tests/editing/inserting/insert-div-019-expected.txt
- layout-tests/editing/inserting/insert-div-021-expected.txt
- layout-tests/editing/inserting/insert-div-022-expected.txt
- layout-tests/editing/inserting/insert-div-023-expected.txt
- layout-tests/editing/inserting/insert-div-024-expected.txt
- 2:57 PM Changeset in webkit [8403] by
-
- 2 edits in trunk/WebKit
Reviewed by vicki
- fixed <rdar://problem/3962559> stopAnimationsInView leaks after cvs-base
- WebCoreSupport.subproj/WebImageData.m: (+[WebImageData stopAnimationsInView:]): add a release
- 2:43 PM Changeset in webkit [8402] by
-
- 2 edits in trunk/WebCore
Dont null-check the renderer before submitting, since a script can set it to display:none and still expect the
submission to occur. Fixes bug #3477282.
Reviewed by kdecker
(DOM::HTMLInputElementImpl::defaultEventHandler):
- 10:39 AM Changeset in webkit [8401] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL
Reviewed by john.
- Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty
Jan 18, 2005:
- 6:34 PM Changeset in webkit [8400] by
-
- 22 edits in trunk
WebCore:
Fixed several issues all arising from analysis of plugin detection code at ifilm.com:
Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in
We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.
Reviewed by Chris.
- khtml/dom/html_document.cpp: (HTMLDocument::objects):
- khtml/dom/html_document.h:
- khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (KJS::getRuntimeObject):
- khtml/ecma/kjs_dom.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
- khtml/ecma/kjs_window.cpp: (Window::get):
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem):
- khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
- khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::getObjectInstance):
- khtml/html/html_objectimpl.h:
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getObjectInstanceForView):
Fixed several issues all arising from analysis of plugin detection code at ifilm.com:
Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in
We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.
Reviewed by Chris.
- bindings/objc/objc_instance.h:
- bindings/objc/objc_instance.mm: (ObjcInstance::supportsSetValueOfUndefinedField):
- bindings/runtime.h: (KJS::Bindings::Instance::supportsSetValueOfUndefinedField):
- bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):
- bindings/runtime_object.h: (KJS::RuntimeObjectImp::fallbackObject):
- kjs/object.cpp: (KJS::ObjectImp::ObjectImp):
- kjs/object.h: (KJS::ObjectImp::forwardingScriptMessage): (KJS::ObjectImp::setForwardingScriptMessage):
- 3:08 PM Changeset in webkit [8399] by
-
- 2 edits in trunk/WebCore
Fix for 3948123, rolling over link erases nearby text. The repaint rect check for lines was wrong whenever
two lines overlapped.
Reviewed by kocienda
- khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
- 2:58 PM Changeset in webkit [8398] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3960116> Focus rings paint incorrectly for contenteditable blocks in web pages
- khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Fix painting of focus rings so that ring only paints around outermost contenteditable elements.
- 2:52 PM Changeset in webkit [8397] by
-
- 2 edits in trunk/JavaScriptCore
Back out a change that was incorrectly committed yesterday.
Reviewed by Chris.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
- 1:03 PM Changeset in webkit [8396] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3959668> accessibilityFocusedUIElement sometimes returns an ignored element; it must not
- kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityFocusedUIElement]): Return parentObjectUnignored if focused object is ignored.
- 10:11 AM Changeset in webkit [8395] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3952877> REGRESSION (Mail): Command-left/right-arrows don't work with file attachment
- khtml/editing/selection.cpp: (khtml::nodeForInlineBox): New helper function used in reimplementation of function below. (khtml::selectionForLine): Reimplemented using line box smarts. I originally wrote this code when I had a less than full understanding of line layout. I can do better now, and my new version no longer fails to notice attachments when doing the kind of navigation mentioned in the bug.
Jan 17, 2005:
- 5:44 PM Changeset in webkit [8394] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
<rdar://problem/3949848> AX: paragraph marker routines do not work when given a paragraph end marker
Also fixed sentence support in the same way.
- kwq/KWQAccObject.mm: (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Move one position in desired direction before calling visible_units.cpp code.
- 5:33 PM Changeset in webkit [8393] by
-
- 8 edits in trunk
Updated expected test results.
<rdar://problem/3945880> line-ending space seems not to be present
- layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
- layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
- layout-tests/editing/inserting/insert-div-020-expected.txt:
- layout-tests/editing/inserting/insert-div-021-expected.txt:
- layout-tests/editing/inserting/insert-div-022-expected.txt:
- layout-tests/editing/inserting/insert-div-023-expected.txt:
- layout-tests/editing/inserting/insert-div-024-expected.txt:
- 5:07 PM Changeset in webkit [8392] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).
<rdar://problem/3945880> line-ending space seems not to be present
- khtml/editing/selection.cpp: (khtml::Selection::validate): Extend AFTER_WHITE_SPACE code to support white spac in the middle of paragraphs, not just the end.
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Pick left/rightness of word selection based on being at the end of paragraph (i.e. after a hard line break).
- 5:06 PM Changeset in webkit [8391] by
-
- 2 edits in trunk/WebKit
- DOM.subproj/DOMPrivate.h: Check in generated file.
- 4:43 PM Changeset in webkit [8390] by
-
- 5 edits in trunk/WebCore
Reviewed by John Louch.
- fixed <rdar://problem/3958503> need screenX and screenY to use WebKit windowFrame delegate
- khtml/ecma/kjs_window.cpp: (Window::get): Change screenX and screenY to use frameGeometry instead of using mapToGlobal and screen in a complicated way.
- kwq/KWQKHTMLView.mm: Removed unused mapToGlobal function.
- kwq/KWQWindowWidget.h: Ditto.
- kwq/KWQWindowWidget.mm: Ditto.
- 3:30 PM Changeset in webkit [8389] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Add layout test for overflow float bug.
- 3:27 PM Changeset in webkit [8388] by
-
- 2 edits in trunk/WebCore
Fix a screwup in rightmost/lowets position computation. 3955207. Make sure floats with layers are still checked.
Reviewed by kocienda
- khtml/rendering/render_block.cpp
- 3:23 PM Changeset in webkit [8387] by
-
- 7 edits1 add in trunk/WebKit
Reviewed by John and Richard.
- fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output
- WebView.subproj/WebFrameViewPrivate.h: Added.
- WebView.subproj/WebFrameView.m: (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers, and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does the work is compatible with our header and footer code. (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating the NSPrintOperation, and also the PDFKit SPI works this way.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
- WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
- WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.
- WebView.subproj/WebPDFView.m: (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO. (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.
- WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.
- 3:08 PM Changeset in webkit [8386] by
-
- 1 edit in trunk/WebCore/khtml/ecma/kjs_binding.cpp
Fixed build snafu.
- 2:54 PM Changeset in webkit [8385] by
-
- 2 edits in trunk/WebCore
Reviewed by John
<rdar://problem/3953366> Problems with typing attributes in HTML compose
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Remove misguided "optimization" that tried to sense when typing style could be cleared without actually doing a style diff between before-delete and after-delete positions. Removing this extra check and running the general-purpose code fixes the bug.
- 2:41 PM Changeset in webkit [8384] by
-
- 26 edits in trunk
WebCore:
Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)
Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.
Reviewed by David Harrison.
- khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isGlobalObject): (ScriptInterpreter::isSafeScript): (ScriptInterpreter::interpreterForGlobalObject):
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_window.cpp: (Window::interpreter): (Window::isSafeScript):
- khtml/ecma/kjs_window.h:
- kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::windowScriptNPObject):
- kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)
Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.
Reviewed by David Harrison.
- bindings/NP_jsobject.cpp: (_isSafeScript): (_NPN_CreateScriptObject): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
- bindings/NP_jsobject.h:
- bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::stringValue):
- bindings/c/c_instance.h:
- bindings/c/c_utility.cpp: (convertValueToNPVariant):
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
- bindings/jni/jni_instance.h:
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject _initializeWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject _initWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject _setOriginExecutionContext:KJS::Bindings::]): (-[WebScriptObject _isSafeScript]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
- bindings/objc/WebScriptObjectPrivate.h:
- bindings/objc/objc_instance.h:
- bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
- bindings/runtime.cpp: (Instance::Instance): (Instance::operator=):
- bindings/runtime.h: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
- bindings/runtime_root.cpp: (RootObject::setInterpreter):
- bindings/runtime_root.h:
- kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
- 2:20 PM Changeset in webkit [8383] by
-
- 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp
Roll out unintended work-in-progress change
- 2:18 PM Changeset in webkit [8382] by
-
- 11 edits8 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with
"size up" and "size down" NSFontManager changes
- khtml/css/cssparser.cpp: (CSSParser::parseValue): Add support for parsing new font size delta property.
- khtml/css/cssproperties.c: Generated file.
- khtml/css/cssproperties.h: Ditto.
- khtml/css/cssproperties.in: Add support for parsing new font size delta property.
- khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): New helper function. Code existed before, but now factored out for convenient use. (khtml::CompositeEditCommand::removeNodeAttribute): Does check on value to see it exists before creating and running command to do the removal. (khtml::ApplyStyleCommand::doApply): Now calls new applyRelativeFontStyleChange() function as part of its work. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): New function that does the "heavy lifting" to handle relative font size changes. (khtml::ApplyStyleCommand::applyInlineStyle): Range check the start and end positions to make sure the start is before or equal to the end. Swap them if not true. I ran into this problem in some similar code in applyRelativeFontStyleChange(). Moving that goodness here too. (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): Uses a local variable to save a value used often. Code is the same, but reads better now. Function now returns bool as well, just like splitTextAtStartIfNeeded. I use the bool return value now (I obviously did not need it before). (khtml::ApplyStyleCommand::computedFontSize): New helper function. (khtml::ApplyStyleCommand::joinChildTextNodes): Ditto. (khtml::createStyleSpanElement): Ditto.
- khtml/editing/htmlediting.h: Update header accordingly.
- khtml/editing/jsediting.cpp: Add new command string to enable relative font size changes.
- kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): New convenience. (-[DOMCSSStyleDeclaration _setFontSizeDelta:]): Ditto.
- kwq/DOMPrivate.h: Declare new conveniences.
- layout-tests/editing/editing.js: Add new JS to enable relative font size changes, as well as explicit font size setting.
- layout-tests/editing/style/relative-font-size-change-001-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-001.html: Added.
- layout-tests/editing/style/relative-font-size-change-002-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-002.html: Added.
- layout-tests/editing/style/relative-font-size-change-003-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-003.html: Added.
- layout-tests/editing/style/relative-font-size-change-004-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-004.html: Added.
