Context Navigation

FIXME: The long-term plan is to make runtime objects use JS Null()
instead of null pointers, which will allow us to eliminate null
checks, improving performance.

6:31 PM Changeset in webkit [10062] by adele

6 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Darin.

JavaScriptCore.xcodeproj/project.pbxproj: Unchecked 'statics are thread safe' option.

WebCore:

Reviewed by Darin.

WebCore.xcodeproj/project.pbxproj: Unchecked 'statics are thread safe' option.

WebKit:

Reviewed by Darin.

WebKit.xcodeproj/project.pbxproj: Unchecked 'statics are thread safe' option.

6:16 PM Changeset in webkit [10061] by ggaren

2 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4207220> REGRESSION (DENVER): Crash occurs
after clicking on Hangman applet

Reviewed by darin.

kjs/object.cpp: (KJS::ObjectImp::hasProperty): added check for null prototype.

FIXME: The long-term plan is to make runtime objects use JS Null()
instead of null pointers, which will allow us to eliminate null
checks, improving performance.

1:47 PM Changeset in webkit [10060] by hyatt

3 edits
2 adds in trunk

-added layout test for fix to: <rdar://problem/4161606> JavaScript regular
expressions with certain ranges of Unicode characters cause a crash

Test cases added:

layout-tests/fast/js/regexp-big-unicode-ranges-expected.txt: Added.
layout-tests/fast/js/regexp-big-unicode-ranges.html: Added.

1:44 PM Changeset in webkit [10059] by ggaren

3 edits
2 adds in trunk

* empty log message *

11:36 AM Changeset in webkit [10058] by hyatt

5 edits in trunk/WebCore

Fix for bugzilla bug 4289, a regression from the QualifiedName landing. Make sure getNamedItemNS and
removeNamedItemNS are case-insensitive in HTML documents.

Reviewed by darin

khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::getNamedItemNS): (NamedAttrMapImpl::removeNamedItemNS):
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_nodeimpl.h: (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::~NamedNodeMapImpl):

11:31 AM Changeset in webkit [10057]

62 copies
4 deletes in tags/JavaScriptCore-412~7

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~7'.

11:31 AM Changeset in webkit [10056] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning for Safari-2-0-branch - JavaScriptCore-412.7

11:28 AM Changeset in webkit [10055]

201 copies
3 deletes in tags/WebCore-415~16

This commit was manufactured by cvs2svn to create tag
'WebCore-415~16'.

11:28 AM Changeset in webkit [10054] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.16

11:25 AM Changeset in webkit [10053]

47 copies
4 deletes in tags/WebKit-412~9

This commit was manufactured by cvs2svn to create tag 'WebKit-412~9'.

11:25 AM Changeset in webkit [10052] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.9

11:22 AM Changeset in webkit [10051] by justing

4 edits
1 add in trunk/WebCore

Reviewed by kocienda

Fix for:

<rdar://problem/4132360> HIM-8A428:Space key works like Return key in Mail application.
<rdar://problem/4122708> Mail: when composing new mail with a Korean input method, the first space doesn't work

If the user terminates marked text with a space, a string including marked characters and a normal,
breaking space, is passed to WebCore in order to replace the previous marked sequence. The fix ensures
that the space becomes a non breaking space if necessary.

Test cases added:

manual-tests/korean-input-space.html

khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):

11:02 AM Changeset in webkit [10050] by harrison

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): (isRoundingHackCharacter): (getUncachedWidth): (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): (-[WebTextRenderer _computeWidthForSpace]): (_drawGlyphs): (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]): (glyphForCharacter): (initializeCharacterWidthIterator): (ceilCurrentWidth): (widthForNextCharacter):

11:01 AM Changeset in webkit [10049] by harrison

44 edits in branches/Safari-2-0-branch

Merged fix from TOT

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

khtml/editing/html_interchange.h:
khtml/editing/htmlediting.cpp: (khtml::EditCommand::styleAtPosition): (khtml::isSpecialElement): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::DeleteSelectionCommand::saveTypingStyleState): (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertTab): (khtml::ReplacementFragment::removeStyleNodes): (khtml::createStyleSpanElement): (khtml::isTabSpanNode): (khtml::isTabSpanTextNode): (khtml::positionBeforeTabSpan): (khtml::createTabSpanElement):
khtml/editing/htmlediting.h:
khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::addPending): (khtml::HTMLTokenizer::write):
khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::):
khtml/rendering/bidi.cpp: (khtml::addRun): (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForTextOverflow):
khtml/rendering/break_lines.cpp: (khtml::isBreakable):
khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::checkSelectionPoint): (Font::width):
khtml/rendering/font.h:
khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::setStyle): (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth):
khtml/rendering/render_block.h:
khtml/rendering/render_br.h: (khtml::RenderBR::width):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
khtml/rendering/render_line.h: (khtml::InlineBox::width): (khtml::InlineBox::xPos): (khtml::InlineBox::yPos): (khtml::InlineBox::height): (khtml::InlineBox::baseline):
khtml/rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
khtml/rendering/render_object.cpp: (RenderObject::tabWidth): (RenderObject::recalcMinMaxWidths):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp:
khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): (InlineTextBox::paint): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::textPos): (InlineTextBox::offsetForPosition): (RenderText::caretRect): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace): (RenderText::width):
khtml/rendering/render_text.h:
kwq/KWQFontMetrics.h:
kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::charWidth): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint): (QFontMetrics::boundingRect): (QFontMetrics::size):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawRect): (QPainter::drawLine): (QPainter::drawText): (QPainter::drawHighlightForText): (_fillRectXX): (QPainter::fillRect):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle):
layout-tests/editing/deleting/delete-tab-001-expected.txt:
layout-tests/editing/deleting/delete-tab-001.html:
layout-tests/editing/deleting/delete-tab-002-expected.txt:
layout-tests/editing/deleting/delete-tab-002.html:
layout-tests/editing/deleting/delete-tab-003-expected.txt:
layout-tests/editing/deleting/delete-tab-003.html:
layout-tests/editing/deleting/delete-tab-004-expected.txt:
layout-tests/editing/deleting/delete-tab-004.html:
layout-tests/editing/inserting/insert-tab-001-expected.txt:
layout-tests/editing/inserting/insert-tab-002-expected.txt:
layout-tests/editing/inserting/insert-tab-003-expected.txt:
layout-tests/editing/inserting/insert-tab-004-expected.txt:
layout-tests/fast/table/039-expected.txt:
layout-tests/fast/table/border-collapsing/004-expected.txt:

Aug 4, 2005:

10:06 PM Changeset in webkit [10048] by justing

2 edits in trunk/WebKit

Reviewed by darin

Fix for:
<rdar://problem/3167884> Shockwave: 3D sprites rendered in OpenGL draw over the browser (3447)
also as <http://bugzilla.opendarwin.org/show_bug.cgi?id=3447>

The WindowRef created by -[NSWindow windowRef] has a QuickDraw GrafPort that covers
the entire window frame (or structure region in Carbon parlance) rather then just the window content.

We filed this as an NSWindow bug <rdar://problem/4201099>

To work around, we modify the CGrafPort to only cover the content area before we let the plug-in draw.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

8:51 PM Changeset in webkit [10047] by mjs

2 edits in trunk/JavaScriptCore

updated expected test results now that we no longer exlude the date tests (apparently this was overlooked)

tests/mozilla/expected.html:

6:24 PM Changeset in webkit [10046] by eseidel

7 edits in trunk/WebKitTools

Bug #: 4280
Submitted by: eseidel
Reviewed by: darin

Scripts/build-drawtest:
Scripts/build-dumprendertree:
Scripts/build-svg2png:
Scripts/build-webcore-svg:
Scripts/build-webkit:
Scripts/webkitdirs.pm: added checkRequiredSystemConfig() Added checkRequiredSystemConfig and made all the build-* scripts use it to print a pretty warning when trying to compile on an unsupported system (less than 10.4, Xcode 2.1). http://bugzilla.opendarwin.org/show_bug.cgi?id=4280

3:46 PM Changeset in webkit [10045] by hyatt

6 adds in trunk/LayoutTests/fast/forms

Add layout tests for form control movement.

3:45 PM Changeset in webkit [10044] by hyatt

7 edits in trunk/WebCore

This patch significantly improves the performance of radio button groups and enables consistent tabbing
behavior in radio groups with both OS X and Internet Explorer for Windows. It also adds support for
arrow key navigation between the radio buttons in a group.

In addition elements can now be shifted between forms using DOM operations and they will properly be
adopted by the form into which they are inserted. This movement works even when the forms themselves
are not currently in the document by introducing a new set of notifications when an object is connected
and removed from a tree of nodes (where that tree may or may not be the main document's tree).

Test cases added: formmove.html, formmove2.html in fast/forms

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): Updated to init/delete a new selectedRadioButtons member variable that is a hash tracking the current checked button in each radio group owned by the form.

(DOM::HTMLFormElementImpl::radioButtonChecked):
A notification that is called when a radio button becomes checked.

(DOM::HTMLFormElementImpl::checkedRadioButtonForGroup):
Returns the current checked radio button for a given named group.

(DOM::HTMLFormElementImpl::removeRadioButtonForGroup):
Clears out the checked radio button for a given named group.

(DOM::HTMLFormElementImpl::registerFormElement):
(DOM::HTMLFormElementImpl::removeFormElement):
The registration and removal functions have been patched to deal with radio buttons and to remove
the "dormant form control" concept, which is no longer needed now that controls can actually move
between forms.

(DOM::HTMLGenericFormElementImpl::HTMLGenericFormElementImpl):
Remove the dormant bit from form controls.

(DOM::HTMLGenericFormElementImpl::attach):
Remove the code that attempted to register a form element in attached. We use new notifications now
for dynamically inserted controls via JS.

(DOM::HTMLGenericFormElementImpl::insertedIntoTree):
(DOM::HTMLGenericFormElementImpl::removedFromTree):
These are the new notifications that are called whenever a form control is connected to or removed from
a tree. This tree may or may not be the document tree. The form control can then "seek out" a form
to latch on to, thus keeping its current status regarding what form it belongs to current across DOM
operations.

(DOM::HTMLInputElementImpl::isKeyboardFocusable):
Overridden to deal with radio buttons. Unnamed radio buttons can't be focused. Radio buttons can't be
focused if another member of their group is already currently focused. Unchecked radio buttons can
only be focused if no button within the group is checked.

(DOM::HTMLInputElementImpl::setInputType):
Make sure to remove a checked radio button from the form's radio button hash if the type is changed
to something else, e.g., checkbox.

(DOM::HTMLInputElementImpl::setChecked):
Revised to update the form's hash when a radio button gets checked and to also prevent unnamed radio
buttons from changing state (matches WinIE).

(DOM::HTMLInputElementImpl::defaultEventHandler):
Add support for arrow key navigation through radio button groups. Fix space behavior so that an unselected
radio can become checked but not unchecked on space. Fix enter behavior so that the form is not submitted
on enter. (Matches WinIE.)

khtml/html/html_formimpl.h: Adds the new member variable to track the current radio buttons in the various groups and the notifications for updating form controls when they switch forms.

khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::insertedIntoDocument): (DOM::NodeImpl::removedFromDocument): Patch insertedIntoDocument and removedFromDocument to also send the insertedIntoTree and removedFromTree notifications.

(DOM::ContainerNodeImpl::removeChild):
Call removedFromTree in the case where the removal of a child happens on a tree that is not in the
document.

(DOM::ContainerNodeImpl::insertedIntoTree):
(DOM::ContainerNodeImpl::removedFromTree):
The new notifications. The container node can optionally crawl into children invoking their notifications.

(DOM::ContainerNodeImpl::dispatchChildInsertedEvents):
Patched to call insertedIntoTree in the case where the insertion happened on a tree that is not in the
document.

khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::insertedIntoTree): (DOM::NodeImpl::removedFromTree): Added the new notifications to NodeImpl for use by the form controls.

3:23 PM Changeset in webkit [10043] by darin

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fixed Objective-C binding for getOverrideStyle

kwq/DOM.mm: ([DOMDocument getOverrideStyle::]): Change to call the DOM getOverrideStyle. It was not correct to call getComputedStyle just because getOverrideStyle is not yet implemented in our DOM.

2:34 PM Changeset in webkit [10042] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-04 Adele Peterson <adele@apple.com>

Reviewed by John.

fixed <rdar://problem/4204496> REGRESSION(denver): repro crash in KHTMLParser::finished() downloading attachment at webmail.mac.com This regression was introduced by the fix for <rdar://problem/4084029>. It was just missing a nil check.

khtml/html/htmlparser.cpp: (KHTMLParser::finished): added nil check for current.

2:33 PM Changeset in webkit [10041] by adele

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4204496> REGRESSION(denver): repro crash in KHTMLParser::finished() downloading attachment at webmail.mac.com This regression was introduced by the fix for <rdar://problem/4084029>. It was just missing a nil check.

khtml/html/htmlparser.cpp: (KHTMLParser::finished): added nil check for current.

1:27 PM Changeset in webkit [10040] by ggaren

2 edits in trunk/WebCore

fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event

Reviewed by darin.

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::updateDOMNodeDocument): inserting a node wrapper into a new document set now removes the node wrapper from its old document set.

11:19 AM Changeset in webkit [10039]

89 copies
2 deletes in tags/WebCore-415~13~1

This commit was manufactured by cvs2svn to create tag
'WebCore-415~13~1'.

11:19 AM Changeset in webkit [10038] by adele

2 edits in branches/Safari-OC-branch/WebCore

Versioning for Safari-OC-branch - WebCore-415.13.1

11:18 AM Changeset in webkit [10037] by adele

2 edits in branches/Safari-OC-branch/WebCore

Merged fix from TOT to Safari-OC-branch

2005-08-04 Geoffrey Garen <ggaren@apple.com>

fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event

Reviewed by darin.

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::updateDOMNodeDocument): inserting a node into a new document now removes the node from its old document.

10:55 AM Changeset in webkit [10036] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-04 Geoffrey Garen <ggaren@apple.com>

fixed <rdar://problem/4199495> REGRESSION: Safari Crashes on Window Closing Event

Reviewed by darin.

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::updateDOMNodeDocument): inserting a node into a new document now removes the node from its old document.

10:15 AM Changeset in webkit [10035] by sullivan

6 edits in trunk/WebKit

Reviewed by Geoff Garen.

fixed <rdar://problem/3918675> Remove code to replace authentication dialog with a subclass when out of localization freeze

Panels.subproj/WebAuthenticationPanel.h: moved declaration of NonBlockingPanel here so it can be accessed by the nib
Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel replacePanelWithSubclassHack]): removed this method (-[WebAuthenticationPanel loadNib]): stop calling the removed method

Panels.subproj/English.lproj/WebAuthenticationPanel.nib/classes.nib:
Panels.subproj/English.lproj/WebAuthenticationPanel.nib/info.nib:
Panels.subproj/English.lproj/WebAuthenticationPanel.nib/objects.nib: the panel in the nib now has custom class NonBlockingPanel

9:49 AM Changeset in webkit [10034] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

Submitted by: rjw@apple.com
Reviewed by: cblu@apple.com
Fixed hard capacity limit on the method and field cache use for the ObjC bindings.

<rdar://problem/4204416> Dashboard client crashes when too many ObjC methods are called

bindings/objc/objc_class.mm: (ObjcClass::_commonInit):

6:58 AM Changeset in webkit [10033] by darin

1 edit
1 add in trunk/WebKitTools

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Bring this file back from the dead. It was removed by accident when someone was trying to work on the branch.

Aug 3, 2005:

7:37 PM Changeset in webkit [10032] by justing

2 edits
2 adds in branches/Safari-2-0-branch

Merging this fix from TOT to Safari-2-0-branch

7:04 PM Changeset in webkit [10031] by justing

3 edits
2 adds in branches/Safari-2-0-branch

Merging this fix from TOT to Safari-2-0-branch

7:02 PM Changeset in webkit [10030] by vicki

1 edit in trunk/WebCore/ChangeLog-2005-08-23

add missing bug number to Changelog comments from the scrollIntoView fix

6:58 PM Changeset in webkit [10029] by vicki

8 edits in branches/Safari-2-0-branch/WebCore

Merge this fix from TOT to Safari-2-0-branch

2005-07-19 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

fixed <rdar://problem/3471901> support scrollIntoView method for DOM elements (3474)

Test cases added:

manual-tests/scrollIntoView-horizontal.html: Added.
manual-tests/scrollIntoView-vertical.html: Added.

khtml/xml/dom_elementimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Added.
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMElement::):
khtml/ecma/kjs_dom.cpp: (KJS::DOMElementProtoFunc::tryCall): glue for new scrollIntoView function

(these two files were modified on the branch only, not required in TOT fix)

khtml/dom/dom_element.cpp: (Element::scrollIntoView):
khtml/dom/dom_element.h:

5:40 PM Changeset in webkit [10028] by rjw

1 edit in trunk/JavaScriptCore/bindings/objc/objc_class.mm

Submitted by: rjw@apple.com
Reviewed by: cblu@apple.com
Fixed hard capacity limit on the method and field cache use for the ObjC bindings.

<rdar://problem/4204416> Dashboard client crashes when too many ObjC methods are called

2:49 PM Changeset in webkit [10027] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT. Also fixes:
<rdar://problem/4077814> Gradual slowing down of Safari eventually requiring Quit and relaunch

2005-07-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dave Hyatt.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4153

WebView.subproj/WebFrame.m: (-[WebFrame _purgePageCache]): Find the oldest candidate for purging that is not a snapback item.

2:23 PM Changeset in webkit [10026] by vicki

2 edits
1 add in trunk/WebCore

Reviewed by Beth and Hyatt.

<rdar://problem/4196646> target returns text node when it should return the parent node

Test cases added: manual-tests/mouseevents-on-textnodes.html

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): if the targetNode is a text node, set the targetNode to the parent node

1:55 PM Changeset in webkit [10025] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4128727> many DOM classes not exported (can't add categories or do other things that require class name linking)

WebCore-combined.exp:
WebCore.exp:

9:47 AM Changeset in webkit [10024] by bdakin

3 edits in trunk/WebKit

Reviewed by cblu

Removing calls to WKCreateUncorrectedRGBColorSpace and
WKCreateUncorrectedGrayColorSpace in WebKit to patch up
TOT...Eric removed them from WebCore last night.

WebCoreSupport.subproj/WebImageData.m:
WebCoreSupport.subproj/WebImageRenderer.m: (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray):

Aug 2, 2005:

5:07 PM Changeset in webkit [10023] by bdibello

1 edit
4 adds in trunk

Reviewed by Geoffrey Garen.

Test cases added: getting and setting button.value

layout-tests/fast/dom/HTMLButtonElement/value/getset-expected.txt: Added.
layout-tests/fast/dom/HTMLButtonElement/value/getset.html: Added.

5:02 PM Changeset in webkit [10022] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-29 Geoffrey Garen <ggaren@apple.com>

fixed: <rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function <rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided <rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided <rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056) http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

Reviewed by darin.

Test cases added:

manual-tests/resources/write-after-open-popup.html: Added.

khtml/khtml_part.cpp: (KHTMLPart::didExplicitOpen): now cancels any pending redirection

4:10 PM Changeset in webkit [10021] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-14 Justin Garcia <justin.garcia@apple.com>

Patch by Anders Carlsson and justin

Reviewed by mjs

Fixes the following related bugs:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3298> insertRow generates DOM Exception if TABLE does not possess a TBODY
<rdar://problem/4045213> insertRow fails on a <table> that has no <tbody> but does have other children in the DOM
<rdar://problem/3609576> insertRow() on table object containing any characters but no TR & TD elements fails (3476)

Does a better job of maintaining the firstBody variable so that it's not invalidated on .innerHTML = ""
Better check for when to add an implicit tbody to hold the inserted row.

Test cases added: (NONE)

layout-tests/fast/dom/HTMLTableElement/insert-row-expected.txt: Added.
layout-tests/fast/dom/HTMLTableElement/insert-row.html: Added.

khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::~HTMLTableElementImpl): (DOM::HTMLTableElementImpl::setTBody): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::childrenChanged):
khtml/html/html_tableimpl.h:

4:06 PM Changeset in webkit [10020] by ggaren

2 edits in branches/Safari-2-0-branch/JavaScriptCore

minor tweak to last checkin

kjs/debugger.h: restored a comment I shouldn't have deleted

3:50 PM Changeset in webkit [10019] by ggaren

14 edits
7 adds in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

mjs 05/07/29 20:00:34

Changes by Michael Kahl, reviewed by me.

Test cases added: No tests, this code only affects debugging.

fixed <rdar://problem/4164112> MASTER: JavaScript debugging support

WebCore-combined.exp:
WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
kwq/WebCoreScriptDebugger.h: Added.
kwq/WebCoreScriptDebugger.mm: Added. (toNSString): (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (-[WebCoreScriptDebugger initWithDelegate:]): (-[WebCoreScriptDebugger dealloc]): (-[WebCoreScriptDebugger delegate]): (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]): (-[WebCoreScriptCallFrame _setWrapper:]): (-[WebCoreScriptCallFrame _convertValueToObjcValue:]): (-[WebCoreScriptCallFrame dealloc]): (-[WebCoreScriptCallFrame wrapper]): (-[WebCoreScriptCallFrame caller]): (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame exception]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

mjs 05/07/29 20:00:34

Changes by Michael Kahl, reviewed by me.

Test cases added: No tests, this code only affects debugging.

fixed <rdar://problem/4164112> MASTER: JavaScript debugging support

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge windowObjectCleared]):
WebCoreSupport.subproj/WebSubresourceLoader.m:
WebKit.xcodeproj/project.pbxproj:
WebView.subproj/WebDefaultScriptDebugDelegate.h: Added.
WebView.subproj/WebDefaultScriptDebugDelegate.m: Added. (+[WebDefaultScriptDebugDelegate sharedScriptDebugDelegate]): (-[WebDefaultScriptDebugDelegate webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _attachScriptDebugger]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebScriptDebugDelegate.h: Added.
WebView.subproj/WebScriptDebugDelegate.m: Added. (-[WebScriptDebugger initWithWebFrame:]): (-[WebScriptDebugger dealloc]): (-[WebScriptDebugger globalObject]): (-[WebScriptDebugger newWrapperForFrame:]): (-[WebScriptDebugger parsedSource:fromURL:sourceId:]): (-[WebScriptDebugger enteredFrame:sourceId:line:]): (-[WebScriptDebugger hitStatement:sourceId:line:]): (-[WebScriptDebugger leavingFrame:sourceId:line:]): (-[WebScriptCallFrame _initWithFrame:]): (-[WebScriptCallFrame dealloc]): (-[WebScriptCallFrame setUserInfo:]): (-[WebScriptCallFrame userInfo]): (-[WebScriptCallFrame caller]): (-[WebScriptCallFrame scopeChain]): (-[WebScriptCallFrame functionName]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
WebView.subproj/WebScriptDebugDelegatePrivate.h: Added.
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): (-[WebView _scriptDebugDelegateForwarder]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]):
WebView.subproj/WebViewInternal.h:
WebView.subproj/WebViewPrivate.h:

3:23 PM Changeset in webkit [10018] by adele

2 edits in branches/Safari-2-0-branch/WebCore

small change to fix build bustage.

khtml/ecma/kjs_binding.h: use '.' instead of '->'. On the branch, self returns an Object instead of an ObjectImp *

2:39 PM Changeset in webkit [10017] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-25 Vicki Murley <vicki@apple.com>

Reviewed by Beth Dakin.

fixed <rdar://problem/4011544> selecting an item from a <select> menu with the mouse doesn't place the focus on the menu

Test cases added:

manual-tests/focus-select-when-clicked.html: Added.

kwq/KWQComboBox.mm: (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES

2:35 PM Changeset in webkit [10016] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-06-29 Anders Carlsson <andersca@mac.com>

Reviewed and landed by Darin Adler.

Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=3274> document() not supported

Test cases added:

layout-tests/fast/xsl/document-function-expected.txt: Added.
layout-tests/fast/xsl/document-function.xml: Added.
layout-tests/fast/xsl/document-function.xsl: Added.
layout-tests/fast/xsl/resources/document-function-source.xml: Added.

khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc): Stub to prevent errors from getting written to the console.

(DOM::stylesheetLoadFunc):
Fetch and parse documents.

(DOM::XSLTProcessorImpl::transformDocument):
Use the processor as the global variable instead of the
style sheet.

khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::stylesheet): (DOM::XSLTProcessorImpl::sourceDocument): Add accessors for source document and stylesheet.

2:26 PM Changeset in webkit [10015] by adele

27 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged from TOT to Safari-2-0-branch.

2005-07-27 Maciej Stachowiak <mjs@apple.com>

Changes by Michael Kahl, reviewed by me.

fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/debugger.cpp: (KJS::AttachedInterpreter::AttachedInterpreter): (KJS::AttachedInterpreter::~AttachedInterpreter): (Debugger::~Debugger): (Debugger::attach): (Debugger::detach): (Debugger::sourceParsed):
kjs/debugger.h:
kjs/function.cpp: (KJS::FunctionImp::call): (KJS::GlobalFuncImp::call):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/internal.cpp: (Parser::parse): (InterpreterImp::evaluate):
kjs/internal.h: (KJS::InterpreterImp::setDebugger):
kjs/interpreter.cpp:
kjs/interpreter.h: (KJS::Interpreter::imp):
kjs/nodes.cpp:

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-07-03 Maciej Stachowiak <mjs@apple.com>

Original patch from Mark Rowe <opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3293

Test cases added:

layout-tests/fast/js/has-own-property.html: Added - tests this change.
layout-tests/fast/js/eval-var-decl.html: Added - test depends on this change.

khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMElement::tryGet): (KJS::DOMNamedNodeMap::hasOwnProperty):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
khtml/ecma/kjs_window.h:

1:39 PM Changeset in webkit [10014] by ggaren

13 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged from TOT to Safari-2-0-branch.

2005-07-27 Maciej Stachowiak <mjs@apple.com>

Changes by Michael Kahl, reviewed by me.

fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/debugger.cpp: (KJS::AttachedInterpreter::AttachedInterpreter): (KJS::AttachedInterpreter::~AttachedInterpreter): (Debugger::~Debugger): (Debugger::attach): (Debugger::detach): (Debugger::sourceParsed):
kjs/debugger.h:
kjs/function.cpp: (KJS::FunctionImp::call): (KJS::GlobalFuncImp::call):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/internal.cpp: (Parser::parse): (InterpreterImp::evaluate):
kjs/internal.h: (KJS::InterpreterImp::setDebugger):
kjs/interpreter.cpp:
kjs/interpreter.h: (KJS::Interpreter::imp):
kjs/nodes.cpp:

1:36 PM Changeset in webkit [10013] by ggaren

6 adds
1 delete in /

fixed build failure on Safari-2-0-branch

DumpRenderTree/DumpRenderTree.xcodeproj/.cvsignore: Added.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added.
DumpRenderTree/project.pbxproj: Removed.

1:28 PM Changeset in webkit [10012] by hyatt

13 edits
3 deletes in trunk

landed layout tests for fix to <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Fix reviewed by darin.

Test cases added:

manual-tests/open-after-close.html: Added.
manual-tests/resources/open-after-close-popup.html: Added.

10:28 AM Changeset in webkit [10011] by ggaren

1 edit in trunk/WebKit/ChangeLog

Fixed Changelog entry.

10:26 AM Changeset in webkit [10010] by ggaren

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fixed last Changelog entry.

10:19 AM Changeset in webkit [10009] by ggaren

1 edit in trunk/WebKit/ChangeLog

Fixing previous Changelog entry.

10:14 AM Changeset in webkit [10008] by sullivan

4 edits in trunk/WebKit

Reviewed by Darin Adler.

Preemptively moved some WebMenuItemTag values from SPI to API, in anticipation of
approval from macosx-api-reviewers. Retitled one of them in response to API reviewers feedback:
WebMenuItemSearchInGoogle -> WebMenuItemSearchWeb

Note that as a side effect of this change, the actual numbers used for these WebMenuItemTags has
changed from what it was in Tiger. This causes "Search in Spotlight", "Search in Google", and
"Look Up in Dictionary" to not appear in Tiger Safari if running on tip of tree WebKit.

WebView.subproj/WebUIDelegatePrivate.h: removed WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchInGoogle, and WebMenuItemTagLookUpInDictionary

WebView.subproj/WebUIDelegate.h: added WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchWeb, and WebMenuItemTagLookUpInDictionary

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): updated for rename (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto

9:58 AM Changeset in webkit [10007] by adele

4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-05-20 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/4098786> sync. XMLHttpRequest works w/o AllowNetworkAccess key because load delegate is not consulted

Synchronous loads did not cause the willSendRequest method on the resource load delegate to be called. This is the method that Dashboard uses to enforce AllowNetworkAccess and this must be called to avoid exploits.

Reviewed by sullivan.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] so synthetic resource load delegate methods are called and the data is saved as a WebResource for resources in the WebCore cache.

(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:],
respect its result, do the load and then call [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]
for synchronous loads

WebView.subproj/WebFrame.m: (-[WebFrame _opened]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:] so synthetic resource load delegate methods are called for subresrources in the page cache

(-[WebFrame _requestFromDelegateForRequest:identifier:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls identifierForInitialRequest and willSendRequest.

(-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls the remaining resource load delegate messages.

(-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]): new, saves the resource and calls
[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]

WebView.subproj/WebFrameInternal.h:

9:52 AM Changeset in webkit [10006] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-08 Vicki Murley <vicki@apple.com>

fixed by Trey Matteson <trey@usa.net>, reviewed by Maciej.

Test cases added: (NONE)

<rdar://problem/4109893> REGRESSION: back/forward broken at wsj.com, worked in v185
Also written as http://bugzilla.opendarwin.org/show_bug.cgi?id=3901

Broken by security fix for 4005575: Arbitrary file disclosure vulnerability due to ability to load local html from remote content

The root of this bug is that URLs for subframes of a page are sometimes added to the back/forward list. This happens a lot at
wsj.com, and I believe it would happen for many or all sites that use JS to cons up a URL for an iframe and then load it.

The security fix changed the code path to go through openURLRequest, but only openURL had the logic to guess if
the current navigation was done in response to a user gesture. openURLRequest always assumed it was a user gesture,
and thus all uses of this code path would place an item in the b/f list.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::userGestureHint): Factored code from openURL. (KWQKHTMLPart::openURL): Call newly factored code. (KWQKHTMLPart::openURLRequest): Newly call newly factored code.

9:47 AM Changeset in webkit [10005] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-28 Beth Dakin <Beth Dakin>

This is a fix for <rdar://problem/4190684>. Hyatt and I
(okay, mostly Hyatt) wrote this for Cayenne so that they
can change the value of a style of a rule and have everything
update dynamically without causing a crash.

Reviewed by Hyatt

Test cases added: (NONE)

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged):

9:39 AM Changeset in webkit [10004] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged from TOT to Safari-2-0-branch.

2005-06-30 Kevin Decker <kdecker@apple.com>

Reviewed by rjw.

fixed: <rdar://problem/4166838> failed assertion in`Interpreter::lockCount() > 0

no layout test added; this is in the bindings code.

bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): make sure to lock and unlock the interpreter around allocations.

Aug 1, 2005:

5:51 PM Changeset in webkit [10003] by ggaren

3 edits
2 adds in trunk

WebCore:

-landed layout tests for fix to <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Fix reviewed by darin.

Test cases added:

manual-tests/open-after-close.html: Added.
manual-tests/resources/open-after-close-popup.html: Added.

WebKit:

-fixed <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Reviewed by darin.

Test cases added:

manual-tests/open-after-close.html: Added.
manual-tests/resources/open-after-close-popup.html: Added.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): We now remove a WebView from WebViewSets when the WebView is *scheduled* to close.

4:56 PM Changeset in webkit [10002] by ggaren

6 edits in branches/Safari-2-0-branch

Updating projects and make files for XCode 2.1.

3:23 PM Changeset in webkit [10001] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_theme_mac.h

Forgot to commit part of my previous patch.

2:31 PM Changeset in webkit [10000] by sullivan

2 edits in trunk/WebKit

PublicHeaderChangesFromTiger.txt: added a comment about isTextField -> _isTextField

2:23 PM Changeset in webkit [9999] by hyatt

4 edits in trunk/WebCore

Fix bugzilla bug 4219, crash because we tried to do the fake paint
when layout was not updated yet.

Also landing accessibility for checkboxes.

Reviewed by darin/mjs (accessibility), kocienda(crash)

ChangeLog:
khtml/rendering/render_theme.h: (khtml::RenderTheme::supportsControlTints):
kwq/KWQAccObject.mm: (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (boundingBoxRect): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityIsAttributeSettable:]):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):

2:19 PM Changeset in webkit [9998] by sullivan

2 edits in trunk/WebKit

Patch by Trey Matteson <trey@usa.net>
Reviewed by me.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4255

underlines still print too thick

The real problem here is that we have code that scales a 0 width line to always
be width=1.0 in device space. I'm leaving that in for the screen, but when printing
a width of 0.5 looks good.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):

12:11 PM Changeset in webkit [9997] by eseidel

2 edits in trunk/WebKit

Bug #: 4211
Submitted by: eseidel
Reviewed by: darin

WebCoreSupport.subproj/WebGraphicsBridge.m: removed create*ColorSpace methods, now using CG API directly. http://bugzilla.opendarwin.org/show_bug.cgi?id=4211

10:50 AM Changeset in webkit [9996] by sullivan

8 edits in trunk/WebKit

Patch by Trey Matteson <trey@usa.net>
Reviewed by me.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4014

PDF files by default load with a poor choice of sizing

For now the various PDF viewing settings are sticky, stored in 2 new defaults. Since
there are a number of ways these settings are changed, I made a proxy for the PDFView
through which all view changing messages are sent. The proxy adds the behavior of
updating the defaults upon any change.

Misc.subproj/WebNSDictionaryExtras.h:
Misc.subproj/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setFloat:forKey:]): New support method.
WebView.subproj/WebPDFView.h:
WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]): Create proxy for PDFView. (-[WebPDFView dealloc]): Free proxy. (-[WebPDFView _menuItemsFromPDFKitForEvent:]): For relevant context menu items, set the

target to the proxy instead of the PDFView.

(-[WebPDFView _readPDFDefaults]): Init PDFView with settings from defaults.
(-[WebPDFView layout]): Call _readPDFDefaults, once. This turned out to be the best hook.
(-[WebPDFView _makeTextSmaller:]): Change PDFView via proxy
(-[WebPDFView _makeTextLarger:]): Ditto
(-[WebPDFView _makeTextStandardSize:]): Ditto
(-[PDFPrefUpdatingProxy initWithView:]): trivial
(-[PDFPrefUpdatingProxy forwardInvocation:]): Forward the msg, then update defaults
(-[PDFPrefUpdatingProxy methodSignatureForSelector:]): Simple forwarding support.

WebView.subproj/WebPreferenceKeysPrivate.h:
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Set initial values for new PDF viewing defaults. (-[WebPreferences _integerValueForKey:]): Nuke stray comment. (-[WebPreferences _floatValueForKey:]): New simple support method. (-[WebPreferences _setFloatValue:forKey:]): Ditto. (-[WebPreferences PDFScaleFactor]): 4 accessors for new defaults (-[WebPreferences setPDFScaleFactor:]): (-[WebPreferences PDFDisplayMode]): (-[WebPreferences setPDFDisplayMode:]):
WebView.subproj/WebPreferencesPrivate.h:

9:19 AM Changeset in webkit [9995] by justing

2 edits in trunk/WebKit

Patch by Trey Matteson <trey@usa.net>

Reviewed by Maciej.

Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4226>

link underlines print too thickly

Reinstate the fix made by sullivan on 1/11/05. There was a merge
error with an mjs fix on 1/13/05.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):

9:12 AM Changeset in webkit [9994] by sullivan

4 edits in trunk/WebCore

Reviewed by Beth Dakin.

Test cases added: none, this only affects Safari forms autofill

Moved the recently-added isTextField method out of the public DOMExtensions.h
and into the private DOMPrivate.h for now, and renamed it with a leading
underscore. We want to make some sort of public API that covers this, but not
necessarily this exact method, so we'll leave it out of the public API until we've
thought about this more.

kwq/DOMExtensions.h: remove isTextField
kwq/DOMPrivate.h: add _isTextField. Also added some #imports that make this file more standalone.
kwq/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): moved this method and added leading underscore.

2:06 AM Changeset in webkit [9993] by eseidel

8 edits in trunk/WebCore

Bug #: 4211
Submitted by: eseidel
Reviewed by: darin

kcanvas/device/quartz/KCanvasItemQuartz.mm: (getSharedContext): moved from QPainter -> CG
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (CGShadingRefForLinearGradient): removed comment (CGShadingRefForRadialGradient): removed comment
khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::call): moved from QPainter -> CG (KJS::colorRefFromValue): moved from QPainter -> CG (KJS::Gradient::getShading): moved from QPainter -> CG
khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):moved from QPainter -> CG
kwq/KWQColor.mm: (CGColorFromNSColor): moved from QPainter -> CG
kwq/KWQPainter.h: removed colorspace calls
kwq/KWQPainter.mm: removed colorspace calls (QPainter::clearFocusRing): moved from QPainter -> CG Removed use of WebKitGraphicsBridge Colorspace SPIs, as well as corresponding QPainter colorspace "choke-point" methods. This fixes colors for WebCore+SVG (since it wasn't linking in webkit). WebKit code removal in separate commit. http://bugzilla.opendarwin.org/show_bug.cgi?id=4211

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed