Timeline



Oct 8, 2005:

9:45 PM Changeset in webkit [10800] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.
Tweaked and landed by Darin.

  • kjs/date_object.cpp: (KJS::skipSpacesAndComments): Take a pointer, and advance it past spaces, and also past anything enclosed in parentheses. (KJS::KRFCDate_parseDate): Use skipSpacesAndComments wherever we formerly had code to skip spaces.

LayoutTests:

  • fast/js/date-parse-comments-test-expected.txt: Added.
  • fast/js/date-parse-comments-test.html: Added.
9:36 PM Changeset in webkit [10799] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/xsl/xslt-entity-enc.xml: Added.
  • fast/xsl/resources/xslt-entity-enc.xsl: Added.
  • fast/xsl/xslt-entity-enc-expected.txt: Added.
9:25 PM Changeset in webkit [10798] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed, tweaked, and landed by Darin.

  • kjs/config.h: Make sure HAVE_MMAP and HAVE_SBRK are off for Win32. Turn HAVE_ERRNO_H on for Mac OS X. Sort defines so they are easy to compare with each other. Remove #undef of DEBUG_COLLECTOR.
  • pcre/pcre_exec.c: (match): Work around strange MSVC complaint by splitting the definition of a local variable into a separate declaration and initialization.
9:17 PM Changeset in webkit [10797] by darin
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

No layout test added: only affects plain text view and requires loading the
file in multiple chunks.

  • WebCore.exp: Added WebCoreTextDecoder.
  • kwq/WebCoreTextDecoder.h: Added.
  • kwq/WebCoreTextDecoder.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Added files, made header private (SPI).

WebKit:

Reviewed by Maciej.

  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation finishedLoadingWithDataSource:]): Call flushReceivedData on the WebTextView so it can decode any final bytes.
  • WebView.subproj/WebTextView.h: Added WebCoreTextDecoder field and flushReceivedData method.
  • WebView.subproj/WebTextView.m: (-[WebTextView dealloc]): Release WebCoreTextDecoder. (-[WebTextView appendReceivedData:fromDataSource:]): Create a WebCoreTextDecoder to decode the text; use the textEncodingName from the data source. Use it to decode instead of the data source's stringWithData. (-[WebTextView flushReceivedData]): Call flush on the decoder and append any last bytes to the text view.
8:50 PM Changeset in webkit [10796] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/css/acid2-pixel-expected.checksum: Added.
  • fast/css/acid2-pixel-expected.png: Added.
  • fast/css/acid2-pixel-expected.txt: Added.
  • fast/css/acid2-pixel.html: Added.
8:37 PM Changeset in webkit [10795] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Geoff Garen.

  • fast/js/date-big-setmonth.html: Changed to compare expected result with a Date value rather than with a constant. Also write out final result as a date rather than as a constant.
  • fast/js/date-big-setmonth-expected.txt: Updated.
8:31 PM Changeset in webkit [10794] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/form-data-encoding-expected.txt: Added.
  • fast/forms/form-data-encoding.html: Added.

WebCore:

Reviewed by Maciej.

Added one layout test.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Pass true to the fromUnicode function to request entity encoding. (DOM::FormDataList::appendString): Ditto.
  • kwq/KWQTextCodec.h: Add boolean parameter to request entity-style encoding for characters that can't be expressed in the desired encoding.
  • kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Added code to entity-encode characters that can't be expressed in the desired encoding.
7:57 PM Changeset in webkit [10793] by darin
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/input/text-input-controller-expected.txt: Added.
  • editing/input/text-input-controller.html: Added.

WebKitTools:

Reviewed, rearranged and landed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): Create a text input controller and put it in a property of the window object.
  • DumpRenderTree/TextInputController.h: Added.
  • DumpRenderTree/TextInputController.m: Added.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added files.
7:36 PM Changeset in webkit [10792] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • kwq/KWQListBox.mm: (KWQTableViewTypeSelectCallback): Added. (-[KWQTableView finalize]): Deallocate the UCTypeSelect object. (-[KWQTableView dealloc]): Ditto. (-[KWQTableView keyUp:]): If character typed is a graphic character, pass it along to the UCTypeSelect object and use it to type select, otherwise flush the object.
  • manual-tests/select-element-type-select.html: Added.
7:14 PM Changeset in webkit [10791] by darin
  • 12 edits in trunk

LayoutTests:

  • fast/dom/HTMLElement/bdo.html: Updated test, no longer says to expect failure.
  • fast/dom/HTMLElement/bdo-expected.checksum: Correct results.
  • fast/dom/HTMLElement/bdo-expected.png: Ditto.
  • fast/dom/HTMLElement/bdo-expected.txt: Ditto.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated to expect correct results for the section done with <bdo>.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Ditto.
  • fast/text/international/bidi-LDB-2-HTML-expected.txt: Ditto.

WebCore:

Reviewed by Darin.

Fixes the results of some existing layout tests.

  • khtml/xml/dom_elementimpl.h: Add eBDO to the list of entry types so there's a way to keep <bdo> dir attribute mappings separate from those of other elements.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::mapToEntry): Add special case to use eBDO for the dir attribute on elements with the <bdo> tag. (HTMLElementImpl::parseMappedAttribute): Use bidi-override for the unicode-bidi CSS property when setting it based on the dir attribute on a <bdo> tag. Along with the change above this obviates the need for an HTMLElementImpl subclass for <bdo>, but we could refactor it that way later if we decide there's an advantage to doing it that way.
  • khtml/css/html4.css: Remove the rules about <bdo>. They are insufficient, and now they are also unnecessary with the changes above.
6:46 PM Changeset in webkit [10790] by darin
  • 8 edits
    12 adds in trunk

LayoutTests:

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4898
(Failures in dbaron's bidi ordering tests).

  • fast/dom/HTMLElement/bdo-expected.txt: Updated for differently-breaking text runs.
  • fast/text/international/bidi-override-expected.txt: Updated because override characters no longer show up in the render tree.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
  • fast/text/international/bidi-LDB-2-CSS-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-CSS.html: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-HTML.html: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters.html: Added.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated to now-correct results.
  • fast/text/international/bidi-explicit-embedding-expected.png: Ditto.
  • fast/text/international/bidi-explicit-embedding-expected.txt: Ditto.

WebCore:

Reviewed by Darin.

Added 3 dbaron bidi ordering tests to LayoutTests.

  • khtml/rendering/bidi.cpp: (khtml::deleteBidiRuns): (khtml::Bidinext): (khtml::appendRunsForObject): (khtml::embed): (khtml::RenderBlock::bidiReorderLine):
3:45 AM Changeset in webkit [10789] by eseidel
  • 1 edit
    4 adds in trunk

Bug #: 5240
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Almost forgot the layout test for the last commit. ;)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

  • svg-tests/custom/use-forward-refs-expected.checksum: Added.
  • svg-tests/custom/use-forward-refs-expected.png: Added.
  • svg-tests/custom/use-forward-refs-expected.txt: Added.
  • svg-tests/custom/use-forward-refs.svg: Added.
2:18 AM Changeset in webkit [10788] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5240
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fix to handle forward referencing <use> elements.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::executeScripts): delayed close. (SVGDocumentImpl::addForwardReference): new function.
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::close): delay close, if missing reference.

Oct 7, 2005:

5:51 PM Changeset in webkit [10787] by harrison
  • 7 edits in trunk/LayoutTests

Reviewed by Justin.

Adjusted expected results after fixing position code in
<rdar://problem/4064017> "Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/select-all-004-expected.txt:
5:50 PM Changeset in webkit [10786] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.

"<rdar://problem/4064017> Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): Do not insert placeholder if selection ends at a BR.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
No need to preserve starting BR because insertPlaceholderForAncestorBlockContent already did.

  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream): Fixed to return original position instead of invisible position when no suitable position found upstream.
5:18 PM Changeset in webkit [12204] by thatcher
  • 2 edits
    1 add in trunk/JavaScriptGlue

Reviewed by Maciej.

Build fix, needed to disable RTTI. Upgraded to a native target.

  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • Info.plist
11:38 AM Changeset in webkit [10785] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • pass the current form to the isindex constructor, so that isindex doesn't malfunction in the case of a misnested form
  • khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex):
11:31 AM Changeset in webkit [10784] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

  • WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.

Oct 6, 2005:

9:22 PM Changeset in webkit [12203] by mjs
  • 11 edits
    4 adds in trunk/JavaScriptGlue

top level:

Reviewed by Eric and Darin.

<rdar://problem/4260506> Port JavaScriptGlue to TOT JavaScriptCore

  • Makefile.am:
  • configure.in:

JavaScriptGlue:

Reviewed by Eric and Darin.

<rdar://problem/4260506> Port JavaScriptGlue to TOT JavaScriptCore

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h: (JSInterpreter::JSInterpreter):
  • JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectMark):
  • JSValueWrapper.h:
  • JavaScriptGlue.cpp: (JSRunCopyGlobalObject):
  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • Makefile.am: Added.
  • UserObjectImp.cpp: (UserObjectPrototypeImp::GlobalUserObjectPrototypeImp): (UserObjectImp::UserObjectImp): (UserObjectImp::callAsFunction): (UserObjectImp::getPropertyNames): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive): (UserObjectImp::mark):
  • UserObjectImp.h:
  • kxmlcore/FastMalloc.h: Added.
  • kxmlcore/HashSet.h: Added.
7:58 PM Changeset in webkit [10783] by justing
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Tweaked my ChangeLog entry.

6:32 PM Changeset in webkit [10782] by justing
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by harrison

Test cases for:

<rdar://problem/4073133> Tabbing between editable elements leads to loss of keyboard focus
<rdar://problem/3690719> "Select All" when in an editable area selects the whole containing document
<rdar://problem/3690703> selection is allowed to span editable area and rest of document

  • editing/selection/3690703-2-expected.checksum: Added.
  • editing/selection/3690703-2-expected.png: Added.
  • editing/selection/3690703-2-expected.txt: Added.
  • editing/selection/3690703-2.html: Added.
  • editing/selection/3690703-expected.checksum: Added.
  • editing/selection/3690703-expected.png: Added.
  • editing/selection/3690703-expected.txt: Added.
  • editing/selection/3690703.html: Added.
  • editing/selection/3690719-expected.checksum: Added.
  • editing/selection/3690719-expected.png: Added.
  • editing/selection/3690719-expected.txt: Added.
  • editing/selection/3690719.html: Added.
6:21 PM Changeset in webkit [10781] by justing
  • 7 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4073133> Tabbing between editable elements leads to loss of keyboard focus
<rdar://problem/3690719> "Select All" when in an editable area selects the whole containing document
<rdar://problem/3690703> selection is allowed to span editable area and rest of document

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::adjustExtentForEditableContent): Added, ensures that a selection cannot cross an editable/non-editable boundry. (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h:
  • khtml/editing/visible_position.h:
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::setFocusNodeIfNeeded): (KHTMLPart::selectAll): Select only the contents of the rootEditableElement, if it exists. Also now calls the shouldChangeSelection delegate method.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setFocus): Clicking on an editable element used to change the selection twice.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Select All when tabbing to an editable element, to match <textarea>s
5:50 PM Changeset in webkit [10780] by vicki
  • 2 edits
    8 adds
    4 deletes in trunk/LayoutTests
  • updated layout tests for <rdar://problem/4288307> <form> element is created for <isindex> outside <form>; that's not correct (4828)
  • dom/html/level2/html/HTMLIsIndexElement02-expected.txt: update this result, since we now pass this test
  • fast/dom/isindex-002-expected.checksum: Added.
  • fast/dom/isindex-002-expected.png: Added.
  • fast/dom/isindex-002-expected.txt: Added.
  • fast/dom/isindex-002.html: Added.
  • renamed this test
  • fast/dom/isindex-alone-expected.checksum: Removed.
  • fast/dom/isindex-alone-expected.png: Removed.
  • fast/dom/isindex-alone-expected.txt: Removed.
  • fast/dom/isindex-alone.html: Removed.
  • fast/dom/isindex-001-expected.checksum: Added.
  • fast/dom/isindex-001-expected.png: Added.
  • fast/dom/isindex-001-expected.txt: Added.
  • fast/dom/isindex-001.html: Added.
5:46 PM Changeset in webkit [10779] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

  • fix <rdar://problem/4288307> <form> element is created for <isindex> outside <form>; that's not correct (4828)
  • khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex): if there's no current form, don't create one
4:02 PM Changeset in webkit [10778]
  • 52 copies
    22 deletes in tags/WebKit-417~2

This commit was manufactured by cvs2svn to create tag 'WebKit-417~2'.

4:02 PM Changeset in webkit [10777]
  • 204 copies
    15 deletes in tags/WebCore-417~3

This commit was manufactured by cvs2svn to create tag
'WebCore-417~3'.

4:02 PM Changeset in webkit [10776]
  • 69 copies
    5 deletes in tags/JavaScriptCore-417~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~2'.

4:02 PM Changeset in webkit [10775] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning to WebKit-417.2, WebCore-417.3 and JavaScriptCore-417.2

3:45 PM Changeset in webkit [10774] by bdakin
  • 3 edits
    4 adds in trunk

* empty log message *

3:06 PM Changeset in webkit [10773]
  • 1 copy
    7 deletes in tags/mjs-perf-slow-1

This commit was manufactured by cvs2svn to create tag
'mjs-perf-slow-1'.

3:06 PM Changeset in webkit [10772] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

No test cases added because this does not affect layout.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setLineHeight:]): Don't call [textView didChangeText] here, because the text itself did not change.
2:48 PM Changeset in webkit [10771] by bdakin
  • 3 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:

2:33 PM Changeset in webkit [10770] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fixes <rdar://problem/4286069> Intel Safari gives "MacPPC" for JavaScript navigator.platform

Reviewed by Geoff.

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Return MacPPC or MacIntel
2:19 PM Changeset in webkit [10769] by darin
  • 2 edits in trunk/WebKit
  • fixed compiling on Deployment
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]): Put initialFont inside !LOG_DISABLED.
2:14 PM Changeset in webkit [10768] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • tweaked formatting
  • WebCoreSupport.subproj/WebTextRenderer.m: Changed function names to remove underscores; fixed formatting to match our coding guidelines, other related tweaks.
2:00 PM Changeset in webkit [10767] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fixed regression in drawing of text in non-flipped contexts from my last check-in
  • WebCoreSupport.subproj/WebTextRenderer.m: (drawGlyphs): Only flip the matrix if the NSGraphicsContext is flipped. (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use -[NSGraphicsContext isFlipped] instead of [[NSView focusView] isFlipped].
1:46 PM Changeset in webkit [10766] by bdakin
  • 3 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

12:16 PM Changeset in webkit [10765] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:37 AM Changeset in webkit [10764] by harrison
  • 3 edits in trunk/WebCore

Reviewed by hyatt.

No test cases added or changed because this patch does not address a bug.

Fix two detach/destroy renames I missed yesterday.

  • khtml/rendering/bidi.cpp: (khtml::BidiRun::destroy): (khtml::BidiRun::operator delete): Renamed inBidiRunDetach to inBidiRunDestroy.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::operator delete): (khtml::RenderLayer::destroy): Renamed inRenderLayerDetach to inRenderLayerDestroy.
8:46 AM Changeset in webkit [10763] by darin
  • 27 edits
    2 deletes in trunk

LayoutTests:

  • updated test result for synthetic bold
  • editing/pasteboard/paste-text-011-expected.checksum: Regenerated.
  • editing/pasteboard/paste-text-011-expected.png: Ditto.
  • editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • updated test result that was incorrect
  • fast/dom/namednodemap-namelookup-expected.txt: Added trailing newlines

WebCore:

Reviewed by Hyatt.

  • fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
  • fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231) also <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3231>
  • kwq/WebCoreTextRendererFactory.h: Added WebCoreFont structure, and made this header work for non-Objective-C compiles. Changed all the methods to take and return WebCoreFont instead of NSFont *.
  • kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeFont): Added. (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]): Updated to use ERROR so we notice cases where the subclass does not override these methods. (-[WebCoreTextRendererFactory isFontFixedPitch:]): Ditto. (-[WebCoreTextRendererFactory rendererWithFont:]): Ditto.
  • WebCore.exp: Added WebCoreInititalizeFont.
  • kwq/KWQFont.h: Added WebCoreFont support.
  • kwq/KWQFont.mm: (QFont::QFont): Change to use WebCoreFont. (QFont::~QFont): Ditto. (QFont::operator=): Ditto. (QFont::setFamily): Ditto. (QFont::setFirstFamily): Ditto. (QFont::setPixelSize): Ditto. (QFont::setWeight): Ditto. (QFont::setItalic): Ditto. (QFont::determinePitch): Ditto. (QFont::getWebCoreFont): Added.
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint): Pass in WebCoreFont when creating text renderer.
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::getRenderer): Ditto.
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Ditto.
  • kwq/KWQListBox.mm: (itemTextRenderer): Ditto. (groupLabelTextRenderer): Ditto. (QListBox::sizeForNumberOfLines): Changed non-system-font case to use QFont rather than NSFont to add boldness, so that group label fonts are bolded even if it's synthesiized bold. (-[KWQTableView drawRow:clipRect:]): Ditto.
  • kwq/KWQPainter.mm: (QPainter::_updateRenderer): Pass in WebCoreFont when creating text renderer.

WebKit:

Reviewed by Hyatt.

  • fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
  • fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231) also <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3231>
  • WebCoreSupport.subproj/WebTextRenderer.h: Removed public declarations of private structures that are not used in the header. Removed the separate 16-bit character map; the difference in code size is only a few bytes per page and there's no measurable performance difference by always using the 32-bit character version. Removed substitute font width maps altogether, since we now use the width map in the substitute font's renderer. Also removed a few more now-unused fields and methods. Changed initWithFont to take WebCoreFont. Changed the setAlwaysUseATSU: method to remove the underscore prefix.
  • WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): Get font from WebCoreFont directly instead of taking a parameter, since we now use only one NSFont per WebTextRenderer. (widthFromMap): Removed NSFont parameter for same reason as above; simplified. (widthForGlyph): Ditto. (overrideLayoutOperation): Updated for change to WebCoreFont. (-[WebTextRenderer initWithFont:]): Changed to use WebCoreFont. Removed code to deal with substitute font maps. Changed lineGap computation to use floats instead of doubles. Added code to compute a synthetic bold offset. Currently this is the font size divided by 24 and then rounded up to an integer. (-[WebTextRenderer dealloc]): Updated for change to WebCoreFont and other related changes. (-[WebTextRenderer finalize]): Ditto. (-[WebTextRenderer xHeight]): Ditto. (-[WebTextRenderer drawRun:style:geometry:]): Remove small caps case here; no longer needed. Also updated as above. (-[WebTextRenderer floatWidthForRun:style:widths:]): Ditto. (-[WebTextRenderer drawHighlightForRun:style:geometry:]): Ditto. (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Ditto. (+[WebTextRenderer setAlwaysUseATSU:]): Renamed to remove underscore prefix. (-[WebTextRenderer smallCapsRenderer]): Ditto. Changed to create a renderer for the smaller sized font. (-[WebTextRenderer _substituteFontForString:families:]): Reorganized this to be more readable and to call the new rendererForAlternateFont method. (-[WebTextRenderer rendererForAlternateFont:]): Added. Used to select an alternate font taking into account bold and italic synthesis. (-[WebTextRenderer substituteRendererForCharacters:length:families:]): Renamed to remove underscore prefix. Updated to use rendererForAlternateFont. (-[WebTextRenderer _computeWidthForSpace]): Updated for name changes and to remove unnecessary parameters. (-[WebTextRenderer setUpFont]): Renamed to remove underscore prefix. Added code to get printer or screen font as specified by WebCoreFont so calers don't need to do this. (drawGlyphs): Renamed to remove underscore prefix. Added code for synthetic oblique (14 degree slant), and synthetic bold (add offset and draw text a second time). (-[WebTextRenderer _CG_drawRun:style:geometry:]): Keep an array of substitute renderers instead of fonts. Changed around the loop to reverse the run to be a single loop instead of 3. (-[WebTextRenderer floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]): Renamed to remove the underscore prefix. (-[WebTextRenderer _CG_floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]): Changed to use subsitute renderers rather than fonts. (-[WebTextRenderer updateGlyphEntryForCharacter:glyphID:substituteRenderer:]): Renamed to remove underscore prefix and changed to use a substitute renderer rather than a substitute NSFont. (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): Updated to work with all characters, both ones that fit into 16-bit and ones that don't. (-[WebTextRenderer _extendGlyphToWidthMapToInclude:]): Removed NSFont parameter and simplified. This fixes a bug where numberOfGlyphs was accidentally used from the main font instead of "subFont". (glyphForCharacter): Changed to use subsitute renderers instead of substitute fonts. (widthForNextCharacter): Ditto. Also removed small caps code no longer needed here and replaced it with simpler small caps code that no longer assumes glyphs match. (shouldUseATSU): Changed the code to check ranges in order to slightly reduce the number of cases and to create earlier exit for lower character codes.
  • WebCoreSupport.subproj/WebTextRendererFactory.h: Added caches for synthesized font and oblique variants so we can still use the NSFont as the dictionary key. Removed coalesceTextDrawing methods. Changed methods to use WebCoreFont as the parameters and results instead of NSFont.
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): Clear all 8 caches. (-[WebTextRendererFactory isFontFixedPitch:]): Changed code slightly so there's only one call to the CFDictionarySetValue function. (-[WebTextRendererFactory init]): Create all 8 caches. (-[WebTextRendererFactory dealloc]): Release all 8 caches. (-[WebTextRendererFactory rendererWithFont:]): Select the appropriate cache based on 3 booleans: synthetic bold, synthetic oblique, and printer. Use WebCoreFont instead of NSFont. (-[WebTextRendererFactory fontWithFamilies:traits:size:]): Set the synthetic bold and oblique flags when returning a WebCoreFont based on requested traits that are not present in the NSFont. (acceptableChoice): Ignore the synthesizable traits when deciding if a chosen font is acceptable. (betterChoice): Rather than assuming that every font has all the desired traits, implement a rule that says a font with an unwanted trait loses out over a font that does not have an unwanted trait. This lets us chose a bold font over a non-bold font that could use synthesized bold but treat both as candidates.
  • WebCoreSupport.subproj/WebGlyphBuffer.h: Removed.
  • WebCoreSupport.subproj/WebGlyphBuffer.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Removed WebGlyphBuffer source files.
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_drawAtPoint:font:textColor:]): Update to use WebCoreFont. (-[NSString _web_widthWithFont:]): Ditto.
  • Misc.subproj/WebStringTruncator.m: (truncateString): Ditto. (+[WebStringTruncator widthOfString:font:]): Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Removed text drawing coalesce method calls.
  • WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Updated to use cachedFontFromFamily method, which we still have, rather than fontWithFamilies method which we don't (since it now uses WebCoreFont).
  • WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): Updated for name change to underlying method.
8:44 AM Changeset in webkit [10762] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Fixed merge option to work better when not all directories are controlled by cvs, or when changes cross multiple repositories.
  • Scripts/update-webkit: Don't print messages if the "quiet" flag is set.

Oct 5, 2005:

11:38 PM Changeset in webkit [10761] by vicki
  • 1 edit
    4 adds in trunk/LayoutTests

Test cases for <rdar://problem/4288829> repro crash on isIndex tag with no attributes

This test case will have to be updated once <rdar://problem/4288839> (isindex tag alone in
document doesn't end up in the DOM) is fixed

  • fast/dom/isindex-alone-expected.checksum: Added.
  • fast/dom/isindex-alone-expected.png: Added.
  • fast/dom/isindex-alone-expected.txt: Added.
  • fast/dom/isindex-alone.html: Added.
11:31 PM Changeset in webkit [10760] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4288829> repro crash on isIndex tag with no attributes
  • khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex): only deref attributes if they exist
11:22 PM Changeset in webkit [10759] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Test cases for <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)

  • ChangeLog:
  • fast/dom/early-frame-url-expected.txt: Added.
  • fast/dom/early-frame-url.html: Added.
  • fast/dom/resources/a.html: Added.
  • fast/dom/resources/b.html: Added.
9:36 PM Changeset in webkit [12202] by mjs
  • 5 edits in trunk/JavaScriptGlue

Forgot to commit this to TOT way back when; will be useful when actually porting JSGlue.

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

  • JSUtils.cpp: (CFStringToUString): (JSObjectKJSValue): (KJSValueToCFTypeInternal):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JavaScriptGlue.cpp: (JSCollect):
9:13 PM Changeset in webkit [10758] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
6:13 PM Changeset in webkit [10757] by ggaren
  • 12 edits in trunk/JavaScriptCore
  • Darin and I rewrote our implementation of the SimpleNumber class to store number bit patterns in their floating point formats.

My tweaks reviewed by Darin.

~1% speedup on JS iBench.

  • kjs/internal.h: removed obsolete jsNumber declarations.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): changed KJS::isNaN to isNaN
  • kjs/nodes.cpp: (PostfixResolveNode::evaluate): removed obsolete knownToBeInteger (PostfixBracketNode::evaluate): ditto (PostfixDotNode::evaluate): ditto (PrefixResolveNode::evaluate): ditto (PrefixBracketNode::evaluate): ditto (PrefixDotNode::evaluate): ditto (NegateNode::evaluate): ditto (valueForReadModifyAssignment): ditto
  • kjs/number_object.cpp: removed obsolete comment
  • kjs/operations.cpp: (KJS::equal): removed unnecessary isNaN checks (KJS::strictEqual): ditto (KJS::add): removed obsolete knownToBeInteger (KJS::mult): ditto
  • kjs/operations.h: removed include of "value.h" to prevent circular reference
  • kjs/simple_number.h: removed unnecessary #includes (KJS::SimpleNumber::make): see above (KJS::SimpleNumber::is): ditto (KJS::SimpleNumber::value): ditto
  • kjs/string_object.cpp: (StringProtoFuncImp::callAsFunction): changed KJS::isNaN to isNaN
  • kjs/ustring.cpp: removed unnecessary isNaN check (KJS::UString::toUInt32): ditto
  • kjs/value.cpp: (KJS::jsNumber): removed obsolete jsNumber definitions (KJS::ConstantValues::init): NaN is no longer a ConstantValue (KJS::ConstantValues::clear): ditto (KJS::ConstantValues::mark): ditto
  • kjs/value.h: removed obsolete knownToBeInteger (KJS::jsNaN): now returns a SimpleNumber (KJS::ValueImp::getUInt32): changed to account for NaN being a SimpleNumber (KJS::ValueImp::toBoolean): ditto (KJS::ValueImp::toString): changed to account for +/- 0.0 (KJS::jsZero): changed to reflect that SimpleNumber::make takes a double (KJS::jsOne): ditto (KJS::jsTwo): ditto (KJS::Number): removed obsolete non-double constructor declarations
6:00 PM Changeset in webkit [10756] by thatcher
  • 2 edits
    1 add in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4269934> JavaScriptCore needs to limit its exports

Reviewed by Geoff.

5:54 PM Changeset in webkit [10755] by harrison
  • 29 edits in trunk/WebCore

Reviewed by Darin.

No test cases added or changed because this patch does not address a bug.

For clarity, renamed the "detach()" function to "destroy()" in the following classes:
RenderObject (and subclasses), BidiRun, ClipRects, InlineBox (and subclasses).

  • khtml/rendering/bidi.cpp: (khtml::BidiRun::destroy): (khtml::BidiRun::operator delete): (khtml::deleteBidiRuns):
  • khtml/rendering/bidi.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::destroy): (RenderBox::dirtyLineBoxes): (RenderBox::position): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::updatePseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::deleteLineBoxes): (RenderFlow::destroy):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderTextArea::destroy):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_layer.cpp: (khtml::ClipRects::operator delete): (khtml::ClipRects::destroy): (khtml::RenderLayer::operator delete): (khtml::RenderLayer::destroy): (khtml::RenderLayer::removeOnlyThisLayer):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::deref):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::destroy): (khtml::InlineBox::operator delete): (khtml::InlineBox::deleteLine): (khtml::InlineFlowBox::deleteLine): (khtml::RootInlineBox::destroy): (khtml::RootInlineBox::detachEllipsisBox):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::destroy):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::operator delete): (RenderObject::destroy):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::operator delete):
  • khtml/rendering/render_table.cpp: (RenderTableSection::destroy): (RenderTableRow::destroy): (RenderTableRow::removeChildNode): (RenderTableCell::destroy):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (InlineTextBox::destroy): (InlineTextBox::operator delete): (InlineTextBox::deleteLine): (RenderText::destroy): (RenderText::deleteTextBoxes): (RenderText::position):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach):
2:07 PM Changeset in webkit [10754] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4158439> Safari appears to hang when sending synchronous XMLHttpRequest that gets no server response

No testcase - not testable w/o network.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Set a timeout of 10.
1:54 PM Changeset in webkit [10753] by justing
  • 1 edit
    14 adds in trunk/LayoutTests

Reviewed by beth

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5245>
Adding missing pixel results for test cases checked in recently.

  • editing/inserting/4278698-expected.checksum: Added.
  • editing/inserting/4278698-expected.png: Added.
  • editing/pasteboard/4076267-2-expected.checksum: Added.
  • editing/pasteboard/4076267-2-expected.png: Added.
  • editing/pasteboard/4076267-3-expected.checksum: Added.
  • editing/pasteboard/4076267-3-expected.png: Added.
  • editing/pasteboard/4076267-expected.checksum: Added.
  • editing/pasteboard/4076267-expected.png: Added.
  • editing/undo/4063751-expected.checksum: Added.
  • editing/undo/4063751-expected.png: Added.
  • fast/css/imageTileOpacity-expected.checksum: Added.
  • fast/css/imageTileOpacity-expected.png: Added.
  • fast/forms/textAreaLineHeight-expected.checksum: Added.
  • fast/forms/textAreaLineHeight-expected.png: Added.
9:18 AM Changeset in webkit [10752]
  • 209 copies
    15 deletes in tags/WebCore-416~10

This commit was manufactured by cvs2svn to create tag
'WebCore-416~10'.

9:18 AM Changeset in webkit [10751] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Versioning to WebCore-416.10

9:11 AM Changeset in webkit [10750] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
9:09 AM Changeset in webkit [10749] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Merged fix from TOT to Safari-Den-branch

2005-10-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
3:31 AM Changeset in webkit [10748] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::URL): if the URL is empty, return "about:blank", the JS DOM at least counts on this, so we may as well do it for other languages too. (DOM::DocumentImpl::baseURL): base it on URL(), not m_url
1:21 AM Changeset in webkit [10747] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Improves dependency checking so that SVG JavaScript wrapper files
regenerate when the perl scripts change.

  • WebCore.xcodeproj/project.pbxproj:
1:18 AM Changeset in webkit [10746]
  • 1 copy
    7 deletes in tags/mjs-perf-slow-2

This commit was manufactured by cvs2svn to create tag
'mjs-perf-slow-2'.

1:18 AM Changeset in webkit [10745] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5175
Submitted by: eseidel
Reviewed by: mjs

Makes <object> tags not use image mode for svg content:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5175

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
1:05 AM Changeset in webkit [10744] by mjs
  • 14 edits
    4 adds
    5 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • fixed <rdar://problem/4260481> Remove Reference type from JavaScriptCore

Also fixed some bugs with for..in enumeration while I was at it. object
properties now come before prototype properties and duplicates
between object and prototype are listed only once.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/IdentifierSequencedSet.cpp: Added. (KJS::IdentifierSequencedSet::IdentifierSequencedSet): (KJS::IdentifierSequencedSet::deallocateVector): (KJS::IdentifierSequencedSet::~IdentifierSequencedSet): (KJS::IdentifierSequencedSet::insert):
  • kjs/IdentifierSequencedSet.h: Added. (KJS::IdentifierSequencedSetIterator::IdentifierSequencedSetIterator): (KJS::IdentifierSequencedSetIterator::operator*): (KJS::IdentifierSequencedSetIterator::operator->): (KJS::IdentifierSequencedSetIterator::operator++): (KJS::IdentifierSequencedSetIterator::operator==): (KJS::IdentifierSequencedSetIterator::operator!=): (KJS::IdentifierSequencedSet::begin): (KJS::IdentifierSequencedSet::end): (KJS::IdentifierSequencedSet::size):
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::getPropertyNames): (ArrayInstanceImp::setLength): (ArrayInstanceImp::pushUndefinedObjectsToEnd):
  • kjs/nodes.cpp: (ForInNode::execute):
  • kjs/nodes.h:
  • kjs/object.cpp: (KJS::ObjectImp::getPropertyNames):
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames):
  • kjs/property_map.h:
  • kjs/protect.h:
  • kjs/protected_reference.h: Removed.
  • kjs/reference.cpp: Removed.
  • kjs/reference.h: Removed.
  • kjs/reference_list.cpp: Removed.
  • kjs/reference_list.h: Removed.
  • kjs/ustring.h: (KJS::UString::impl):
  • kxmlcore/HashSet.h:

LayoutTests:

Reviewed by Eric.

  • test case for some fixes I made to for..in enumeration. object properties now come before prototype properties and duplicates between object and prototype are listed only once.
  • fast/js/for-in-expected.txt: Added.
  • fast/js/for-in.html: Added.
12:50 AM Changeset in webkit [10743] by mjs
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: Add JS binding for isSameNode.

(KJS::DOMNode::):

  • khtml/xml/dom_nodeimpl.h: Implement isSameNode.

(DOM::NodeImpl::isSameNode):

  • kwq/DOM.mm: (-[DOMNode isSameNode:]): Add ObjC binding for isSameNode.
12:26 AM Changeset in webkit [10742] by andersca
  • 5 edits in trunk/WebCore

2005-10-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: Add JS binding for isSameNode.

(KJS::DOMNode::):

  • khtml/xml/dom_nodeimpl.h: Implement isSameNode.

(DOM::NodeImpl::isSameNode):

  • kwq/DOM.mm: (-[DOMNode isSameNode:]): Add ObjC binding for isSameNode.
12:14 AM Changeset in webkit [10741]
  • 1 copy
    7 deletes in tags/mjs-perf-fast-2

This commit was manufactured by cvs2svn to create tag
'mjs-perf-fast-2'.

12:14 AM Changeset in webkit [10740] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed a random crasher that happens because the HTMLParser accidentally was refing the document.

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/html/htmlparser.cpp: (HTMLStackElem::HTMLStackElem): (HTMLStackElem::~HTMLStackElem): (HTMLParser::popNestedHeaderTag): (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::popOneBlock):
12:11 AM Changeset in webkit [10739] by andersca
  • 8 edits
    2 adds in trunk/LayoutTests

2005-10-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • dom/xhtml/level3/core/nodeissamenode01-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode02-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode03-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode04-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode05-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode06-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode10-expected.txt: These tests pass now.
12:01 AM Changeset in webkit [10738] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):

Oct 4, 2005:

11:09 PM Changeset in webkit [10737] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs

Test direct name lookup in DOMNamedNodeMap, like FireFox/IE.
<rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

  • fast/dom/namednodemap-namelookup-expected.txt: Added.
  • fast/dom/namednodemap-namelookup.html: Added.
11:08 PM Changeset in webkit [10736]
  • 1 copy
    7 deletes in tags/mjs-perf-fast-1

This commit was manufactured by cvs2svn to create tag
'mjs-perf-fast-1'.

11:08 PM Changeset in webkit [10735] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs

Support direct named attribute lookkup, like FireFox,IE.
This was causing a JavaScript exception for gap.com
<rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::getOwnPropertySlot): if cleanup (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h: added nameGetter
10:36 PM Changeset in webkit [10734] by eseidel
  • 312 edits in trunk

Bug #: 5254
Submitted by: eseidel
Reviewed by: none needed, build fix only.

Fix to include "config.h" in every file.
Necessary to support fastMalloc.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5254

  • WebCore+SVG/DrawCanvasItem.mm:
  • WebCore+SVG/DrawDocument.mm:
  • WebCore+SVG/DrawView.mm:
  • WebCore+SVG/dom_kdomdocumentwrapper.cpp:
  • WebCore+SVG/dom_kdomnodetreewrapper.cpp:
  • WebCore+SVG/render_kcanvaswrapper.cpp:
  • WebCore+SVG/xml_kdomtokenizer.cpp:
  • kcanvas/KCanvas.cpp:
  • kcanvas/KCanvasContainer.cpp:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasImage.cpp:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasRegistry.cpp:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/KCanvasView.cpp:
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDeviceFactory.cpp:
  • kcanvas/device/KRenderingFillPainter.cpp:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerImage.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/KRenderingStrokePainter.cpp:
  • kcanvas/device/KRenderingStyle.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KCanvasViewQuartz.mm:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • kdom/DOMString.cpp:
  • kdom/Helper.cpp:
  • kdom/KDOMPart.cpp:
  • kdom/KDOMSettings.cpp:
  • kdom/KDOMView.cpp:
  • kdom/Shared.cpp:
  • kdom/backends/libxml/LibXMLParser.cpp:
  • kdom/bindings/IDLCodeGeneratorEcmaInterface.pm:
  • kdom/bindings/IDLCodeGeneratorJs.pm:
  • kdom/cache/ImageSource.cpp:
  • kdom/cache/KDOMCache.cpp:
  • kdom/cache/KDOMCachedDocument.cpp:
  • kdom/cache/KDOMCachedImage.cpp:
  • kdom/cache/KDOMCachedObject.cpp:
  • kdom/cache/KDOMCachedScript.cpp:
  • kdom/cache/KDOMCachedStyleSheet.cpp:
  • kdom/cache/KDOMLoader.cpp:
  • kdom/core/AttrImpl.cpp:
  • kdom/core/CDATASectionImpl.cpp:
  • kdom/core/CDFInterface.cpp:
  • kdom/core/CharacterDataImpl.cpp:
  • kdom/core/CommentImpl.cpp:
  • kdom/core/DOMConfigurationImpl.cpp:
  • kdom/core/DOMErrorHandlerImpl.cpp:
  • kdom/core/DOMErrorImpl.cpp:
  • kdom/core/DOMExceptionImpl.cpp:
  • kdom/core/DOMImplementationImpl.cpp:
  • kdom/core/DOMLocatorImpl.cpp:
  • kdom/core/DOMObjectImpl.cpp:
  • kdom/core/DOMStringImpl.cpp:
  • kdom/core/DOMStringListImpl.cpp:
  • kdom/core/DOMUserDataImpl.cpp:
  • kdom/core/DocumentFragmentImpl.cpp:
  • kdom/core/DocumentImpl.cpp:
  • kdom/core/DocumentTypeImpl.cpp:
  • kdom/core/ElementImpl.cpp:
  • kdom/core/EntityImpl.cpp:
  • kdom/core/EntityReferenceImpl.cpp:
  • kdom/core/NamedAttrMapImpl.cpp:
  • kdom/core/NamedNodeMapImpl.cpp:
  • kdom/core/NodeImpl.cpp:
  • kdom/core/NodeListImpl.cpp:
  • kdom/core/NotationImpl.cpp:
  • kdom/core/ProcessingInstructionImpl.cpp:
  • kdom/core/TagNodeListImpl.cpp:
  • kdom/core/TextImpl.cpp:
  • kdom/core/TypeInfoImpl.cpp:
  • kdom/core/XMLElementImpl.cpp:
  • kdom/css/CSSCharsetRuleImpl.cpp:
  • kdom/css/CSSFontFaceRuleImpl.cpp:
  • kdom/css/CSSImageValueImpl.cpp:
  • kdom/css/CSSImportRuleImpl.cpp:
  • kdom/css/CSSMediaRuleImpl.cpp:
  • kdom/css/CSSPageRuleImpl.cpp:
  • kdom/css/CSSPrimitiveValueImpl.cpp:
  • kdom/css/CSSRuleImpl.cpp:
  • kdom/css/CSSRuleListImpl.cpp:
  • kdom/css/CSSStyleDeclarationImpl.cpp:
  • kdom/css/CSSStyleRuleImpl.cpp:
  • kdom/css/CSSStyleSelector.cpp:
  • kdom/css/CSSStyleSheetImpl.cpp:
  • kdom/css/CSSUnknownRuleImpl.cpp:
  • kdom/css/CSSValueImpl.cpp:
  • kdom/css/CSSValueListImpl.cpp:
  • kdom/css/CounterImpl.cpp:
  • kdom/css/DocumentCSSImpl.cpp:
  • kdom/css/DocumentStyleImpl.cpp:
  • kdom/css/KDOMCSSParser.cpp:
  • kdom/css/LinkStyleImpl.cpp:
  • kdom/css/MediaListImpl.cpp:
  • kdom/css/RGBColorImpl.cpp:
  • kdom/css/RectImpl.cpp:
  • kdom/css/RenderStyle.cpp:
  • kdom/css/RenderStyleDefs.cpp:
  • kdom/css/StyleBaseImpl.cpp:
  • kdom/css/StyleSheetImpl.cpp:
  • kdom/css/StyleSheetListImpl.cpp:
  • kdom/css/kdomparsercss.y:
  • kdom/ecma/Ecma.cpp:
  • kdom/ecma/GlobalObject.cpp:
  • kdom/ecma/Helper.cpp:
  • kdom/ecma/ScriptInterpreter.cpp:
  • kdom/events/DocumentEventImpl.cpp:
  • kdom/events/EventExceptionImpl.cpp:
  • kdom/events/EventImpl.cpp:
  • kdom/events/EventListenerImpl.cpp:
  • kdom/events/EventTargetImpl.cpp:
  • kdom/events/KeyboardEventImpl.cpp:
  • kdom/events/MouseEventImpl.cpp:
  • kdom/events/MutationEventImpl.cpp:
  • kdom/events/RegisteredEventListener.cpp:
  • kdom/events/UIEventImpl.cpp:
  • kdom/ls/DOMImplementationLSImpl.cpp:
  • kdom/ls/LSExceptionImpl.cpp:
  • kdom/ls/LSInputImpl.cpp:
  • kdom/ls/LSOutputImpl.cpp:
  • kdom/ls/LSParserFilterImpl.cpp:
  • kdom/ls/LSParserImpl.cpp:
  • kdom/ls/LSResourceResolverImpl.cpp:
  • kdom/ls/LSSerializerFilterImpl.cpp:
  • kdom/ls/LSSerializerImpl.cpp:
  • kdom/parser/KDOMDocumentBuilder.cpp:
  • kdom/parser/KDOMParser.cpp:
  • kdom/range/DocumentRangeImpl.cpp:
  • kdom/range/RangeExceptionImpl.cpp:
  • kdom/range/RangeImpl.cpp:
  • kdom/traversal/DocumentTraversalImpl.cpp:
  • kdom/traversal/NodeFilterImpl.cpp:
  • kdom/traversal/NodeIteratorImpl.cpp:
  • kdom/traversal/TraversalImpl.cpp:
  • kdom/traversal/TreeWalkerImpl.cpp:
  • kdom/views/AbstractViewImpl.cpp:
  • kdom/views/DocumentViewImpl.cpp:
  • kdom/xpath/XPathEvaluatorImpl.cpp:
  • kdom/xpath/XPathExceptionImpl.cpp:
  • kdom/xpath/XPathExpressionImpl.cpp:
  • kdom/xpath/XPathNSResolverImpl.cpp:
  • kdom/xpath/XPathNamespaceImpl.cpp:
  • kdom/xpath/XPathResultImpl.cpp:
  • kdom/xpath/impl/expression.cpp:
  • kdom/xpath/impl/functions.cpp:
  • kdom/xpath/impl/parsedstatement.cpp:
  • kdom/xpath/impl/path.cpp:
  • kdom/xpath/impl/predicate.cpp:
  • kdom/xpath/impl/step.cpp:
  • kdom/xpath/impl/tokenizer.cpp:
  • kdom/xpath/impl/util.cpp:
  • kdom/xpath/impl/variablereference.cpp:
  • kdom/xpath/impl/xpath.y:
  • kdom/xpointer/ElementSchemeImpl.cpp:
  • kdom/xpointer/NBCImpl.cpp:
  • kdom/xpointer/PointerPartImpl.cpp:
  • kdom/xpointer/ShortHandImpl.cpp:
  • kdom/xpointer/XMLNSSchemeImpl.cpp:
  • kdom/xpointer/XPath1SchemeImpl.cpp:
  • kdom/xpointer/XPointerEvaluatorImpl.cpp:
  • kdom/xpointer/XPointerExceptionImpl.cpp:
  • kdom/xpointer/XPointerExpressionImpl.cpp:
  • kdom/xpointer/XPointerHelper.cpp:
  • kdom/xpointer/XPointerResultImpl.cpp:
  • kdom/xpointer/XPointerSchemeImpl.cpp:
  • ksvg2/KSVGFactory.cpp:
  • ksvg2/KSVGSettings.cpp:
  • ksvg2/KWQKSVGPart.mm:
  • ksvg2/KWQKSVGView.mm:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleDeclarationImpl.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGCSSStyleSheetImpl.cpp:
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/events/SVGEventImpl.cpp:
  • ksvg2/events/SVGZoomEventImpl.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGDocumentBuilder.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/svg/CDFInterface.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGAngleImpl.cpp:
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp:
  • ksvg2/svg/SVGAnimateElementImpl.cpp:
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimatedAngleImpl.cpp:
  • ksvg2/svg/SVGAnimatedBooleanImpl.cpp:
  • ksvg2/svg/SVGAnimatedEnumerationImpl.cpp:
  • ksvg2/svg/SVGAnimatedIntegerImpl.cpp:
  • ksvg2/svg/SVGAnimatedLengthImpl.cpp:
  • ksvg2/svg/SVGAnimatedLengthListImpl.cpp:
  • ksvg2/svg/SVGAnimatedNumberImpl.cpp:
  • ksvg2/svg/SVGAnimatedNumberListImpl.cpp:
  • ksvg2/svg/SVGAnimatedPathDataImpl.cpp:
  • ksvg2/svg/SVGAnimatedPointsImpl.cpp:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGAnimatedRectImpl.cpp:
  • ksvg2/svg/SVGAnimatedStringImpl.cpp:
  • ksvg2/svg/SVGAnimatedTransformListImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGCircleElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDefsElementImpl.cpp:
  • ksvg2/svg/SVGDescElementImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGElementInstanceImpl.cpp:
  • ksvg2/svg/SVGElementInstanceListImpl.cpp:
  • ksvg2/svg/SVGEllipseElementImpl.cpp:
  • ksvg2/svg/SVGExceptionImpl.cpp:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncAElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncBElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncGElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncRElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFilterElementImpl.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp:
  • ksvg2/svg/SVGLengthListImpl.cpp:
  • ksvg2/svg/SVGLineElementImpl.cpp:
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp:
  • ksvg2/svg/SVGLocatableImpl.cpp:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGMatrixImpl.cpp:
  • ksvg2/svg/SVGNumberImpl.cpp:
  • ksvg2/svg/SVGNumberListImpl.cpp:
  • ksvg2/svg/SVGPaintImpl.cpp:
  • ksvg2/svg/SVGPathElementImpl.cpp:
  • ksvg2/svg/SVGPathSegArcImpl.cpp:
  • ksvg2/svg/SVGPathSegClosePathImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothImpl.cpp:
  • ksvg2/svg/SVGPathSegImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoHorizontalImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoVerticalImpl.cpp:
  • ksvg2/svg/SVGPathSegListImpl.cpp:
  • ksvg2/svg/SVGPathSegMovetoImpl.cpp:
  • ksvg2/svg/SVGPatternElementImpl.cpp:
  • ksvg2/svg/SVGPointImpl.cpp:
  • ksvg2/svg/SVGPointListImpl.cpp:
  • ksvg2/svg/SVGPolyElementImpl.cpp:
  • ksvg2/svg/SVGPolygonElementImpl.cpp:
  • ksvg2/svg/SVGPolylineElementImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp:
  • ksvg2/svg/SVGRectElementImpl.cpp:
  • ksvg2/svg/SVGRectImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGSetElementImpl.cpp:
  • ksvg2/svg/SVGStopElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.cpp:
  • ksvg2/svg/SVGStylableImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGSwitchElementImpl.cpp:
  • ksvg2/svg/SVGSymbolElementImpl.cpp:
  • ksvg2/svg/SVGTSpanElementImpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp:
  • ksvg2/svg/SVGTextContentElementImpl.cpp:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • ksvg2/svg/SVGTextPositioningElementImpl.cpp:
  • ksvg2/svg/SVGTitleElementImpl.cpp:
  • ksvg2/svg/SVGTransformImpl.cpp:
  • ksvg2/svg/SVGTransformListImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • ksvg2/svg/SVGZoomAndPanImpl.cpp:
  • ksvg2/svg/svgpathparser.cpp:
9:16 PM Changeset in webkit [10733] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
1:24 PM Changeset in webkit [10732] by bdakin
  • 3 edits
    3 adds in trunk

* empty log message *

10:33 AM Changeset in webkit [10731] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Fix for <rdar://problem/4275275> Denver Regression: Drawing glitch
in the transparent dialog's cancel/ok button in the widget manager

Fixed by Beth Dakin.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): CG workaround
10:31 AM Changeset in webkit [10730]
  • 52 copies
    22 deletes in tags/WebKit-416~10

This commit was manufactured by cvs2svn to create tag
'WebKit-416~10'.

10:31 AM Changeset in webkit [10729] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Fix for <rdar://problem/4275275> Denver Regression: Drawing glitch
in the transparent dialog's cancel/ok button in the widget manager

Fixed by Beth Dakin.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): CG workaround
2:33 AM Changeset in webkit [10728] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Code cleanup, which resulted in a small win on iBench.

  • kjs/object.cpp: (KJS::tryGetAndCallProperty): new static inline (KJS::ObjectImp::defaultValue): code cleanup
Note: See TracTimeline for information about the timeline view.