Timeline



Oct 17, 2005:

8:15 PM Changeset in webkit [10867] by mjs
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Geoff. Code changes by Darin.

  • some micro-optimizations to FastMalloc to reduce math and branches.
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_Central_FreeList::Populate): (KXMLCore::fastMallocRegisterThread): (KXMLCore::TCMalloc_ThreadCache::GetCache): (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent):

WebCore:

Reviewed by Geoff.

Speed up the tokenizer by keeping more state on the stack instead of in the object,
to avoid load-store traffic. About a .5% speedup.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::setForceSynchronous): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::allDataProcessed): (khtml::HTMLTokenizer::end): (khtml::HTMLTokenizer::finish): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::isWaitingForScripts):
  • khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::): (khtml::HTMLTokenizer::State::State): (khtml::HTMLTokenizer::State::tagState): (khtml::HTMLTokenizer::State::setTagState): (khtml::HTMLTokenizer::State::entityState): (khtml::HTMLTokenizer::State::setEntityState): (khtml::HTMLTokenizer::State::inScript): (khtml::HTMLTokenizer::State::setInScript): (khtml::HTMLTokenizer::State::inStyle): (khtml::HTMLTokenizer::State::setInStyle): (khtml::HTMLTokenizer::State::inSelect): (khtml::HTMLTokenizer::State::setInSelect): (khtml::HTMLTokenizer::State::inXmp): (khtml::HTMLTokenizer::State::setInXmp): (khtml::HTMLTokenizer::State::inTitle): (khtml::HTMLTokenizer::State::setInTitle): (khtml::HTMLTokenizer::State::inPlainText): (khtml::HTMLTokenizer::State::setInPlainText): (khtml::HTMLTokenizer::State::inProcessingInstruction): (khtml::HTMLTokenizer::State::setInProcessingInstruction): (khtml::HTMLTokenizer::State::inComment): (khtml::HTMLTokenizer::State::setInComment): (khtml::HTMLTokenizer::State::inTextArea): (khtml::HTMLTokenizer::State::setInTextArea): (khtml::HTMLTokenizer::State::escaped): (khtml::HTMLTokenizer::State::setEscaped): (khtml::HTMLTokenizer::State::inServer): (khtml::HTMLTokenizer::State::setInServer): (khtml::HTMLTokenizer::State::skipLF): (khtml::HTMLTokenizer::State::setSkipLF): (khtml::HTMLTokenizer::State::startTag): (khtml::HTMLTokenizer::State::setStartTag): (khtml::HTMLTokenizer::State::discardLF): (khtml::HTMLTokenizer::State::setDiscardLF): (khtml::HTMLTokenizer::State::allowYield): (khtml::HTMLTokenizer::State::setAllowYield): (khtml::HTMLTokenizer::State::loadingExtScript): (khtml::HTMLTokenizer::State::setLoadingExtScript): (khtml::HTMLTokenizer::State::forceSynchronous): (khtml::HTMLTokenizer::State::setForceSynchronous): (khtml::HTMLTokenizer::State::inAnySpecial): (khtml::HTMLTokenizer::State::hasTagState): (khtml::HTMLTokenizer::State::hasEntityState): (khtml::HTMLTokenizer::State::): (khtml::HTMLTokenizer::State::setBit): (khtml::HTMLTokenizer::State::testBit):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::firstLineStyle):
  • khtml/rendering/render_object.h: (khtml::RenderObject::style):
5:16 PM Changeset in webkit [10866] by mjs
  • 12 edits in trunk

LayoutTests:

  • temporarily back out hyatt's recent changes since the tree was closed
  • fast/clip/008-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/dom/gc-3.html:
  • fast/table/overflowHidden-expected.txt:

WebCore:

  • temporarily back out hyatt's recent changes since the tree was closed
  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyChildren):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy):
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::sortByZOrder):
  • khtml/rendering/render_layer.h:
2:23 PM Changeset in webkit [10865] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • JavaScriptCore.exp: Rolled out some NPN symbols from my last commit that Tim O. and I determined are not public.
11:41 AM Changeset in webkit [10864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed: <rdar://problem/4300099> JavaScriptCore export file needs to include symbols used by Java/liveconnect and other bindings clients

Reviewed by Darin and Geoff.

  • JavaScriptCore.exp: adding a few sysmbols for jni bindings also add the WebUndefined ObjC class symbol, and some missing NPN symbols
12:37 AM Changeset in webkit [10863] by hyatt
  • 1 edit in trunk/LayoutTests/fast/table/overflowHidden-expected.txt

check in fixed overflow:hidden table case.

12:36 AM Changeset in webkit [10862] by hyatt
  • 2 edits in trunk/LayoutTests/fast/css

Check in fixed acid2.

12:35 AM Changeset in webkit [10861] by hyatt
  • 1 edit in trunk/LayoutTests/fast/clip/008-expected.txt

Fix clip test.

12:29 AM Changeset in webkit [10860] by hyatt
  • 3 edits in trunk/WebCore

Fix for bugzilla bug 5283. Make overflow layers lose to other kinds of
layers if z-index is equivalent. Technically overflow isn't even supposed
to establish a stacking context, so the use of RenderLayer for overflow,
although elegant and simple, isn't correct. This patch is essentially a hack
to make the common problem go away, but the deeper mistake remains.

Reviewed by eseidel

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::isOverflowOnly): (khtml::compare): (khtml::sortByZOrder):
  • khtml/rendering/render_layer.h:

Oct 16, 2005:

11:20 PM Changeset in webkit [10859] by hyatt
  • 4 edits in trunk/WebCore

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyLeftoverAnonymousChildren):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy):

Oct 15, 2005:

8:36 PM Changeset in webkit [10858] by mjs
  • 8 edits in trunk/WebCore

Backed out the following changes, since they are in a range that
provably caused a performance regression:

<rdar://problem/4302874> Denver Regression: crash repeatedly reloading www.supermanhomepage.com
<rdar://problem/4302879> Re-land SVG object element fix
<rdar://problem/4302880> Re-land isSameNode change
<rdar://problem/4065748> Repro crash at ​http://www.vanaqua.org using menu system (KHTMLParser::setCurrent(DOM::NodeImpl*))

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
  • khtml/html/htmlparser.cpp: (HTMLStackElem::HTMLStackElem): (HTMLParser::popNestedHeaderTag): (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::popOneBlock):
  • khtml/xml/dom_nodeimpl.h:
  • kwq/DOM.mm:
5:46 PM Changeset in webkit [10857] by mjs
  • 13 edits
    5 adds
    2 deletes in trunk/JavaScriptCore

Reverted fix for this bug, because it was part of a time range that caused a performance
regression:

<rdar://problem/4260481> Remove Reference type from JavaScriptCore

4:27 PM Changeset in webkit [10856] by darin
  • 2 edits in trunk/JavaScriptCore
  • kxmlcore/HashTable.cpp: Fixed build failure (said hashtable.h instead of HashTable.h).

Oct 14, 2005:

2:03 PM Changeset in webkit [10855] by ggaren
  • 2 edits in trunk/JavaScriptCore

Style changes recommended by Darin.

Changed to camelCase, changed ValueImp* to ValueImp *.

  • kjs/simple_number.h: (KJS::SimpleNumber::make): (KJS::SimpleNumber::value):
1:57 PM Changeset in webkit [10854] by ggaren
  • 2 edits in trunk/WebCore

Style change suggested by Darin.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Added "Bugzilla" prefix to bug #.
1:31 PM Changeset in webkit [10853] by vicki
  • 2 edits in trunk/WebKit

Changes by Mitz Pettel, reviewed by Maciej.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): Prefer the main resource if it is an image
1:20 PM Changeset in webkit [10852] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5336
Submitted by: Julien Palmas <​julien.palmas@mac.com>
Reviewed by: eseidel

Fixed crash when animating unsupported elements.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5336

  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetElement):

Oct 13, 2005:

11:10 PM Changeset in webkit [10851] by eseidel
  • 2 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none, removed newline.

Committed file w/ extra newline by mistake.

  • fast/js/resources/xmlhttprequest-get-data.xml:
4:54 PM Changeset in webkit [10850] by eseidel
  • 1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding the mozilla xslt tests.

  • fast/xsl/mozilla-tests.xml: Added.
  • fast/xsl/mozilla-tests.xsl: Added.
  • fast/xsl/mozilla-tests-expected.txt: Added.
4:51 PM Changeset in webkit [10849] by eseidel
  • 6 adds in trunk/LayoutTests/fast

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

  • fast/js/resources/xmlhttprequest-get-data.xml: Added.
  • fast/js/xmlhttprequest-get-expected.txt: Added.
  • fast/js/xmlhttprequest-get.xhtml: Added.
4:39 PM Changeset in webkit [10848] by eseidel
  • 1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

  • fast/js/resources/xmlhttprequest-get-data.xml: Added.
  • fast/js/xmlhttprequest-get-expected.txt: Added.
  • fast/js/xmlhttprequest-get.xhtml: Added.
3:51 PM Changeset in webkit [10847] by justing
  • 9 edits
    4 adds in trunk/LayoutTests

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Updated/added layout tests:

  • fast/clip/001-expected.txt:
  • fast/clip/009-expected.txt:
  • fast/clip/010-expected.txt:
  • fast/clip/011-expected.txt:
  • fast/clip/012-expected.txt:
  • fast/clip/013-expected.txt:
  • fast/clip/014-expected.txt:
  • fast/clip/016-expected.txt:
  • fast/clip/outline-overflowClip-expected.checksum: Added.
  • fast/clip/outline-overflowClip-expected.png: Added.
  • fast/clip/outline-overflowClip-expected.txt: Added.
  • fast/clip/outline-overflowClip.html: Added.
3:45 PM Changeset in webkit [10846] by justing
  • 4 edits in trunk/WebCore

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Test cases added:

  • fast/clip/outline-overflowClip Test cases changed (since I added the outline rect to the render tree dump)
  • fast/clip/001
  • fast/clip/009
  • fast/clip/010
  • fast/clip/011
  • fast/clip/012
  • fast/clip/013
  • fast/clip/014
  • fast/clip/016
  • khtml/rendering/render_layer.cpp: Clip the outline by a new rect, which is equal to the foreground rect w/o clipping by the overflow rect.

(khtml::RenderLayer::paintLayer):
(khtml::RenderLayer::hitTestLayer):
(khtml::RenderLayer::calculateRects):

  • khtml/rendering/render_layer.h:
  • kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers):
3:07 PM Changeset in webkit [10845] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

no need to calculate linewidth multiple times in findnextlinebreak()
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5319

No test case needed, this is a simple optimization.

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
12:37 PM Changeset in webkit [10844] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self dependency from this function
12:11 PM Changeset in webkit [10843] by ggaren
  • 3 edits in trunk/WebCore

I changed the test for whether to put a script in the "to be executed" queue to
match the test for whether to ref a script, so that scripts can't end up in the
queue without being refed.

I also renamed cachedScript to pendingScripts.

Reviewed by Darin.

No test case because the crash isn't deterministically reproducible.
However, I did add assertions that should catch the underlying bug
in the future.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::notifyFinished):
  • khtml/html/htmltokenizer.h:
1:29 AM Changeset in webkit [10842] by eseidel
  • 9 edits in trunk

Bug #: 5326
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Test cases updated:

  • svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:

Fixed <svg> to base %lengths off of the nearest viewbox.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5326

  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::x): (SVGSVGElementImpl::y): (SVGSVGElementImpl::width): (SVGSVGElementImpl::height):
Note: See TracTimeline for information about the timeline view.