Timeline



Dec 4, 2005:

3:45 PM Changeset in webkit [11449] by ggaren
  • 2 edits in trunk/JavaScriptCore

Update test results to match Anders's last checkin.

  • tests/mozilla/expected.html:
3:30 PM Changeset in webkit [11448] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-04 Anders Carlsson <andersca@mac.com>

Reviewed by Geoffrey.

Add new tests for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

  • fast/js/test-propertyIsEnumerable-expected.txt: Added.
  • fast/js/test-propertyIsEnumerable.html: Added.
3:28 PM Changeset in webkit [11447] by andersca
  • 5 edits in trunk/JavaScriptCore

2005-12-04 Anders Carlsson <andersca@mac.com>

Reviewed by Geoffrey.

  • kjs/object.cpp: (KJS::ObjectImp::canPut): Refactor to use getPropertyAttributes.

(KJS::ObjectImp::propertyIsEnumerable):
New function which checks if a property is enumerable.

(KJS::ObjectImp::getPropertyAttributes):

  • kjs/object.h: Add getPropertyAttributes and propertyIsEnumerable.
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::): Add propertyIsEnumerable to the Object prototype.
3:14 PM Changeset in webkit [11446] by eseidel
  • 11 edits
    60 deletes in trunk/WebCore

Bug #: 5930
Submitted by: eseidel
Reviewed by: ggaren

No additional test cases needed (or possible).

Further dom/* cleanup, also removing extra forwarding headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=5930

  • ForwardingHeaders/dom/dom2_views.h: Removed.
  • ForwardingHeaders/dom/dom_core.h: Removed.
  • ForwardingHeaders/dom/dom_doc.h: Removed.
  • ForwardingHeaders/dom/dom_element.h: Removed.
  • ForwardingHeaders/dom/dom_misc.h: Removed.
  • ForwardingHeaders/dom/dom_text.h: Removed.
  • ForwardingHeaders/dom/dom_xml.h: Removed.
  • ForwardingHeaders/dom/html_base.h: Removed.
  • ForwardingHeaders/dom/html_block.h: Removed.
  • ForwardingHeaders/dom/html_document.h: Removed.
  • ForwardingHeaders/dom/html_element.h: Removed.
  • ForwardingHeaders/dom/html_form.h: Removed.
  • ForwardingHeaders/dom/html_head.h: Removed.
  • ForwardingHeaders/dom/html_image.h: Removed.
  • ForwardingHeaders/dom/html_inline.h: Removed.
  • ForwardingHeaders/dom/html_list.h: Removed.
  • ForwardingHeaders/dom/html_misc.h: Removed.
  • ForwardingHeaders/dom/html_object.h: Removed.
  • ForwardingHeaders/dom/html_table.h: Removed.
  • ForwardingHeaders/ecma/kjs_css.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_window.h: Removed.
  • ForwardingHeaders/html/dtd.h: Removed.
  • ForwardingHeaders/kdom/KDOMPart.h: Removed.
  • ForwardingHeaders/kdom/KDOMView.h: Removed.
  • ForwardingHeaders/kdom/core/NodeListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSMediaRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/cssproperties.h: Removed.
  • ForwardingHeaders/kdom/css/cssvalues.h: Removed.
  • ForwardingHeaders/kdom/events/DocumentEventImpl.h: Removed.
  • ForwardingHeaders/kdom/parser/KDOMDocumentBuilder.h: Removed.
  • ForwardingHeaders/kdomcssproperties.h: Removed.
  • ForwardingHeaders/kdomcssvalues.h: Removed.
  • ForwardingHeaders/kinstance.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/property_map.h: Removed.
  • ForwardingHeaders/kjs/protected_object.h: Removed.
  • ForwardingHeaders/kjs/scope_chain.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • ForwardingHeaders/ksvg2/svg/svgtags.h: Removed.
  • ForwardingHeaders/q3intdict.h: Removed.
  • ForwardingHeaders/q3memarray.h: Removed.
  • ForwardingHeaders/q3ptrcollection.h: Removed.
  • ForwardingHeaders/q3ptrdict.h: Removed.
  • ForwardingHeaders/qcstring.h: Removed.
  • ForwardingHeaders/qcursor.h: Removed.
  • ForwardingHeaders/qintdict.h: Removed.
  • ForwardingHeaders/qpair.h: Removed.
  • ForwardingHeaders/qprinter.h: Removed.
  • ForwardingHeaders/qptrcollection.h: Removed.
  • ForwardingHeaders/qsize.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
  • ForwardingHeaders/qvaluevector.h: Removed.
  • ForwardingHeaders/xml/dom_positioniterator.h: Removed.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/dom/css_value.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.h:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/kjs_traversal.cpp:
3:07 PM Changeset in webkit [11445]
  • 210 copies
    17 deletes in tags/WebCore-417~9

This commit was manufactured by cvs2svn to create tag
'WebCore-417~9'.

3:07 PM Changeset in webkit [11444] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.9

2:01 PM Changeset in webkit [11443]
  • 26 copies
    3 deletes in tags/WebKit-312~7

This commit was manufactured by cvs2svn to create tag 'WebKit-312~7'.

2:01 PM Changeset in webkit [11442] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning to WebKit-312.7

1:59 PM Changeset in webkit [11441]
  • 118 copies
    5 deletes in tags/WebCore-315~12

This commit was manufactured by cvs2svn to create tag
'WebCore-315~12'.

1:59 PM Changeset in webkit [11440] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.12

1:58 PM Changeset in webkit [11439] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

1:56 PM Changeset in webkit [11438]
  • 10 copies
    3 deletes in tags/JavaScriptCore-312~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3'.

1:56 PM Changeset in webkit [11437] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning to JavaScriptCore-312.3

1:12 PM Changeset in webkit [11436] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2005-12-02 Adele Peterson <adele@apple.com>

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
1:02 PM Changeset in webkit [11435] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at http://www.pixar.com/shorts/index.html and
http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
1:01 PM Changeset in webkit [11434] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at http://www.pixar.com/shorts/index.html and
http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
12:55 PM Changeset in webkit [11433] by andersca
  • 4 edits
    1 add in trunk/WebCore

2005-12-04 Anders Carlsson <andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Don't send onblur to a node if m_inDetach is true.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach): Set m_inDetach to true while calling RenderObject::destroy.
  • khtml/xml/dom_nodeimpl.h:

Add m_inDetach flag.

  • manual-tests/onblur-remove.html: Added.
5:08 AM Changeset in webkit [11432] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: No review needed, WebCore+SVG build fix only.

I broke the WebCore+SVG build when removing dom_misc.h, fixing.

  • WebCore+SVG/KDOMHeaders.h: remove reference to dom_misc.h
4:43 AM Changeset in webkit [11431] by eseidel
  • 10 edits
    2 deletes in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no test cases possible or necessary.

Removed dom_misc.* and changed to use Shared instead of DOMShared.
Also removed FilterNode typedef, now using NodeImpl* directly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5929

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.cpp: (DOM::NodeFilterCondition::acceptNode):
  • khtml/dom/dom2_traversal.h:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_misc.cpp: Removed.
  • khtml/dom/dom_misc.h: Removed.
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode):
3:35 AM Changeset in webkit [11430] by eseidel
  • 21 edits in trunk/WebCore

Bug #: 5877
Submitted by: eseidel
Reviewed by: mjs

No test cases needed/possible, only removing dead code.

Remove rotten #ifdef'd code from the source:
APPLE_CHANGES & KHTML_NO_CPLUSPLUS_DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

  • khtml/dom/css_rule.h: (DOM::CSSRule::):
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.h: (DOM::CSSValue::): (DOM::CSSPrimitiveValue::):
  • khtml/dom/dom2_events.cpp: (DOM::EventListener::handleEventImpl):
  • khtml/dom/dom2_events.h: (DOM::Event::): (DOM::EventException::): (DOM::MutationEvent::):
  • khtml/dom/dom2_range.h: (DOM::RangeException::): (DOM::Range::):
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom2_traversal.h: (DOM::NodeFilter::):
  • khtml/dom/dom_exception.h: (DOM::DOMException::):
  • khtml/dom/dom_misc.cpp: (DOM::DomShared::~DomShared):
  • khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_node.h: (DOM::Node::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::focusNextPrevNode):
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKHTMLPageCache.h:
  • kwq/KWQPointArray.h:

Dec 3, 2005:

5:22 PM Changeset in webkit [11429] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
5:21 PM Changeset in webkit [11428] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
4:53 PM Changeset in webkit [11427] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
4:48 PM Changeset in webkit [11426] by justing
  • 3 edits in trunk/WebCore

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
4:32 PM Changeset in webkit [11425] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 PM Changeset in webkit [11424] by andersca
  • 5 edits in trunk/WebCore/khtml

Didn't mean to commit this.

12:16 PM Changeset in webkit [11423] by andersca
  • 11 edits
    1 add in trunk/WebCore

2005-12-01 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
8:56 AM Changeset in webkit [11422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Improved ChangeLog comment.

Dec 2, 2005:

6:33 PM Changeset in webkit [11421] by bdakin
  • 4 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

5:44 PM Changeset in webkit [11420] by eseidel
  • 9 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Added ending newlines to files missing them.

  • ForwardingHeaders/kjs/property_map.h:
  • khtml/rendering/break_lines.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • kwq/DOM-compat.h:
  • kwq/KWQTextUtilities.h:
  • kwq/WebCoreKeyboardAccess.h:
5:32 PM Changeset in webkit [11419] by eseidel
  • 54 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.

SVG Build fix after SharedPtr -> RefPtr changes.

  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/svg/SVGAElementImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
  • ksvg2/svg/SVGFitToViewBoxImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.h:
  • ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGLinearGradientElementImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.h:
  • ksvg2/svg/SVGPolyElementImpl.h:
  • ksvg2/svg/SVGRadialGradientElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGStopElementImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGStyledTransformableElementImpl.h:
  • ksvg2/svg/SVGTestsImpl.h:
  • ksvg2/svg/SVGTextContentElementImpl.h:
  • ksvg2/svg/SVGTextPositioningElementImpl.h:
  • ksvg2/svg/SVGTransformImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGUseElementImpl.h:
  • ksvg2/svg/SVGViewElementImpl.h:
5:30 PM Changeset in webkit [11418] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

No review needed.

  • ksvg2/scripts/make_names.pl: Add standard license header.
5:18 PM Changeset in webkit [11417]
  • 55 copies
    22 deletes in tags/WebKit-417~6

This commit was manufactured by cvs2svn to create tag 'WebKit-417~6'.

5:18 PM Changeset in webkit [11416] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.6

5:17 PM Changeset in webkit [11415]
  • 210 copies
    17 deletes in tags/WebCore-417~8

This commit was manufactured by cvs2svn to create tag
'WebCore-417~8'.

5:17 PM Changeset in webkit [11414] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.8

5:06 PM Changeset in webkit [11413] by adele
  • 8 edits in trunk

LayoutTests:

Updating test for latest changes in:
<rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/replaced/width100percent.html:

WebCore:

Reviewed by Hyatt.

  • fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

We're backing out the fix for <rdar://problem/3952698>.
With the new button implementation, the buttons will
not overlap for the telia webmail case. We may need to address
the minWidth behavior for other elements at a later time.

  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
5:06 PM Changeset in webkit [11412] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
4:54 PM Changeset in webkit [11411] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:00 PM Changeset in webkit [11410] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:58 PM Changeset in webkit [11409] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:19 PM Changeset in webkit [11408] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
2:53 PM Changeset in webkit [11407] by justing
  • 3 edits in trunk/WebKit

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:44 PM Changeset in webkit [11406] by mjs
  • 12 edits in trunk/WebCore

SVG build fix, not reviewed.

  • land the ksvg2 part of my SharedPtr --> RefPtr change, which I forgot about before.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::parseTransformValue): (SVGAnimateTransformElementImpl::initialMatrix):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::canvasResource):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::getCTM):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::viewport): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::updateLocalTransform):
1:26 PM Changeset in webkit [11405] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Vicki Murley <vicki@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:17 PM Changeset in webkit [11404] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:16 PM Changeset in webkit [11403] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 David Hyatt <hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:13 PM Changeset in webkit [11402] by vicki
  • 2 edits
    3 adds in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:13 PM Changeset in webkit [11401] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 David Hyatt <hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
12:58 PM Changeset in webkit [11400] by aboule
  • 2 edits in trunk/WebCore

Reviewed by rjw.

Added #else for XSLT ifdef to make sure switch case
doesn't fall through when feature turned off.

  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
12:32 PM Changeset in webkit [11399] by hyatt
  • 2 adds in trunk/LayoutTests/fast/clip

Add layout test for new clipping behavior.

12:23 PM Changeset in webkit [11398] by hyatt
  • 2 edits in trunk/WebCore

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

fast/clip/018.html

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:19 AM Changeset in webkit [11397] by andersca
  • 3 edits in trunk/WebCore

2005-12-02 Anders Carlsson <andersca@mac.com>

Reviewed by Timothy.

  • WebCore.xcodeproj/project.pbxproj: Remove KWQRefPtr.h
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Remove a call to notNull here.
1:13 AM Changeset in webkit [11396] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Cache the lastItem and lastItemOffset for fast retrieval of the
same index or indeicies greater than lastItemOffset. Also cache
the length. Like other node lists these cached values rest when the
subtree under the root node changes.

  • khtml/xml/dom_nodeimpl.cpp: (ChildNodeListImpl::length): Use cachedLength when possible. (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.
1:00 AM Changeset in webkit [11395] by justing
  • 2 edits
    4 adds in trunk/LayoutTests

Reviewed by justin

Updated/added tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

  • editing/deleting/delete-3775172-fix-expected.txt: Fixed.
  • editing/inserting/editing-empty-divs-expected.checksum: Added.
  • editing/inserting/editing-empty-divs-expected.png: Added.
  • editing/inserting/editing-empty-divs-expected.txt: Added.
  • editing/inserting/editing-empty-divs.html: Added.
1:00 AM Changeset in webkit [11394] by justing
  • 2 edits in trunk/WebCore

<http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

Reviewed/tweaked/landed by justin

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): A position at the original block shouldn't be considered 'outside' the original block. (khtml::hasRenderedChildrenWithHeight): Added. (khtml::VisiblePosition::isCandidate): A block flow element with rendered children may be considered a candidate for a visible position, as long as its children do not have a positive height.
12:33 AM Changeset in webkit [11393] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Remove duplicate entry

Dec 1, 2005:

7:48 PM Changeset in webkit [11392] by mjs
  • 29 edits
    1 delete in trunk

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
4:41 PM Changeset in webkit [11391] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:38 PM Changeset in webkit [11390] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:04 PM Changeset in webkit [11389] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:57 PM Changeset in webkit [11388] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
3:55 PM Changeset in webkit [11387] by thatcher
  • 8 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
3:50 PM Changeset in webkit [11386] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:45 PM Changeset in webkit [11385] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
3:25 PM Changeset in webkit [11384] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
3:16 PM Changeset in webkit [11383] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
3:15 PM Changeset in webkit [11382] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
1:59 PM Changeset in webkit [11381] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 PM Changeset in webkit [11380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 AM Changeset in webkit [11379] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 AM Changeset in webkit [11378] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
9:59 AM Changeset in webkit [11377] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-01 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
9:58 AM Changeset in webkit [11376] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-01 Anders Carlsson <andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
2:32 AM Changeset in webkit [11375] by mjs
  • 76 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
12:38 AM Changeset in webkit [11374] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):

Nov 30, 2005:

3:04 PM Changeset in webkit [11373] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5890
Submitted by: eseidel
Reviewed by: darin

No additional tests needed, acid2 covers this case.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
2:46 PM Changeset in webkit [11372] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:44 PM Changeset in webkit [11371] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:40 PM Changeset in webkit [11370] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-28 Adele Peterson <adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:39 PM Changeset in webkit [11369] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-28 Adele Peterson <adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:25 PM Changeset in webkit [11368] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:24 PM Changeset in webkit [11367] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:15 PM Changeset in webkit [11366] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Vicki Murley <vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
2:14 PM Changeset in webkit [11365] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Vicki Murley <vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
1:53 PM Changeset in webkit [11364] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Added layout test for <rdar://problem/4344760> REGRESSION
(Safari 416.12-417.2) gmail 'reply' does not fill in to: field or
quoted message (3751)

  • fast/forms/textarea-setvalue-without-renderer-expected.txt: Added.
  • fast/forms/textarea-setvalue-without-renderer.html: Added.
3:49 AM Changeset in webkit [11363] by eseidel
  • 9 edits
    2 adds in trunk/WebCore

Bug #: 5887
Submitted by: eseidel
Reviewed by: mjs

No functionality change, no tests needed.

Make make_names.pl namespace agnostic and add XLinkNames.* for SVG

  • WebCore+SVG/XLinkNamesWrapper.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: added files, build rule.
  • khtml/khtml_part.cpp: (KHTMLPart::init): init XLinkNames
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): remove foreignObjectTag (temp.)
  • ksvg2/misc/xlinkattrs.in: Added.
  • ksvg2/scripts/make_names.pl: make namespace agnostic
  • ksvg2/svg/SVGLocatableImpl.cpp: remove foreignObjectTag (temp.) (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
  • ksvg2/svg/SVGURIReferenceImpl.cpp: use XLinkNames (SVGURIReferenceImpl::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: remove href
  • ksvg2/svg/svgtags.in: comment out unused tags
3:07 AM Changeset in webkit [11362] by eseidel
  • 1 edit
    117 deletes in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none neede, removing unused test results only.

Removing erroneously committed results content.

  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt: Removed.
1:21 AM Changeset in webkit [11361] by eseidel
  • 18 edits in trunk

Bug #: 5881
Submitted by: Rob Buis <rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes 5 test cases:

  • paths-data-02-t.svg (most noticeable)
  • fonts-elem-01-t.svg
  • fonts-elem-02-t.svg
  • fonts-elem-03-t.svg
  • fonts-elem-04-t.svg

http://bugzilla.opendarwin.org/show_bug.cgi?id=5881
Quadratic bezier path render error

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
Note: See TracTimeline for information about the timeline view.