Timeline



Dec 9, 2005:

8:52 PM Changeset in webkit [11515] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
  • WebView.subproj/WebView.m: (-[WebView _frameForCurrentSelection]): I removed this method many moons ago when restructuring the code involving frames and selection. Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
6:59 PM Changeset in webkit [11514] by justing
  • 5 edits in trunk/WebCore

<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections
Some preparation for a fix for:
<radar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

There were a few bugs in endOfParagraph's and endOfLine's handling of IncludeLineBreak.
The IncludeLinebreak concept also doesn't make sense: when asked to
IncludeLineBreak, "endOfParagraph" would return the start of the next paragraph.
Callers that want this funtionality should just call endOfParagraph and then get next()
if it exists.
In endOfParagraph's whitespace:pre handling, when the input visible position
was at the end of a text node with whitespace:pre, that text node was searched
for '/n'. It should be skipped.

Reviewed by harrison

Added new layout tests in editing/pasting and editing/selection

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::validate):
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::isEndOfLine): (khtml::endOfParagraph): (khtml::isEndOfParagraph):
  • khtml/editing/visible_units.h:
6:59 PM Changeset in webkit [11513] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections

Reviewed by harrison

  • editing/pasteboard/paste-pre-002-expected.checksum: Added.
  • editing/pasteboard/paste-pre-002-expected.png: Added.
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html: Added.
  • editing/selection/triple-click-in-pre-expected.checksum: Added.
  • editing/selection/triple-click-in-pre-expected.png: Added.
  • editing/selection/triple-click-in-pre-expected.txt: Added.
  • editing/selection/triple-click-in-pre.html: Added.
6:13 PM Changeset in webkit [11512] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Carbon.subproj/HIWebView.m: (UpdateCommandStatus): Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures. -performSelector:withObject:'s return value should only be checked if the method returns an object.
3:48 PM Changeset in webkit [11511] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
2:06 PM Changeset in webkit [11510]
  • 55 copies
    22 deletes in tags/WebKit-417~8

This commit was manufactured by cvs2svn to create tag 'WebKit-417~8'.

2:06 PM Changeset in webkit [11509]
  • 211 copies
    17 deletes in tags/WebCore-417~11

This commit was manufactured by cvs2svn to create tag
'WebCore-417~11'.

2:06 PM Changeset in webkit [11508] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning.

10:59 AM Changeset in webkit [11507] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by nobody, build fix.

Using <PDFKit/PDFKit.h> was causing build failures for the Mail team.
The comment about getting an ambiguous signature conflict anywhere the
method "count" is used seems to no longer be an issue.

  • WebView.subproj/WebPreferencesPrivate.h: Use <Quartz/Quartz.h>

Dec 8, 2005:

8:10 PM Changeset in webkit [11506] by adele
  • 6 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
6:12 PM Changeset in webkit [11505] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Some cleanup of how selection rects are associated with NSViews.

  • WebView.subproj/WebDocumentPrivate.h: Added a -selectionView method to <WebDocumentSelection>, and clarified that the selectionRect is in the coordinate system of this view.
  • Misc.subproj/WebSearchableTextView.m: (-[WebSearchableTextView selectionView]): new method, returns self
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectionView]): new method, returns self
  • WebView.subproj/WebPDFView.m: (-[WebPDFView selectionRect]): translate result into coordinate system of [PDFSubview documentView] (-[WebPDFView selectionView]): new method, returns [PDFSubview documentView]
6:10 PM Changeset in webkit [11504] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4311703> Crash in NPN_Invoke receiving contents of ​http://www.woodieschilidogs.com/ in Mail.app

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptNPObject): The window script object can be 0 if JavaScript is disabled. However, callers (like plugins) expect us to always return a window script object here. By substituting a plain ObjectImp for the window's ObjectImp, we can satisfy callers' assumptions and let them try to manipulate the dummy object when JavaScript is disabled.
4:06 PM Changeset in webkit [11503] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

  • fixed these semi-legendary bugs: <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now passes the focus down to that view.
3:13 PM Changeset in webkit [11502] by tomernic
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

Reviewed and landed by Maciej.

  • some simple changes that amount to a < 1% speedup.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • kwq/KWQKURL.mm: (hasSlashDotOrDotDot):
  • kwq/KWQString.mm: (QString::~QString):
3:05 PM Changeset in webkit [11501] by tomernic
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch.

Bug #: none
Submitted by: timo
Reviewed by: eseidel & darin

Changed some of the run measurement methods to C functions
to avoid overhead associated with objc_msgSend().

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForRun:style:widths:]): Updated to call new run measurement functions instead of calling ObjC methods. (-[WebTextRenderer CG_drawRun:style:geometry:]): ditto (floatWidthForRun): ditto (CG_floatWidthForRun): ditto (ATSU_floatWidthForRun): ditto (widthForNextCharacter): ditto
2:22 PM Changeset in webkit [11500] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)"
crashed when going from the "Open a template" menu to "Select recent
Document" in the "Welcome to Corel XI!" window.

These are the parts of that bug fix that were not already fixed in TOT.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...]
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Allow for the event not being leftmousedown or keydown
1:44 PM Changeset in webkit [11499] by harrison
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

11:44 AM Changeset in webkit [11498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.
10:33 AM Changeset in webkit [11497] by mjs
  • 7 edits in trunk/WebKit

Reviewed by John.

  • some small changes towards frame tree refactoring

Renamed WebViewSets to WebFrameNamespaces, and put the method for
performing a selector on all extant WebViews to WebView itself,
with a separate set tracking live WebViews. This should allow
moving the storage of this info down to WebCore more easily.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): (-[WebBridge runModal]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (webView::if): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebView.m: (+[WebView _makeAllWebViewsPerformSelector:]): (-[WebView _removeFromAllWebViewsSet]): (-[WebView _addToAllWebViewsSet]): (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setGroupName:]):
  • WebView.subproj/WebViewInternal.h:
10:19 AM Changeset in webkit [11496] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • fix major memory leak and resultant slowdown on JavaScript iBench from my PassRefPtr changes
  • kjs/ustring.cpp: (KJS::UString::Rep::create): I forgot to change one of the two overloads to create with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt to adopt the initial refcount, this may be a hair more efficient.
  • made the assignment operators for smart pointers inline because Shark said so
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::::operator=):
2:20 AM Changeset in webkit [11495] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5997
Submitted by: mitz
Reviewed by: eseidel

No test possible since this fixes random behavior.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5997
REGRESSION: Focus rings around links are not erased when focus is lost

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inDetach to false.
1:30 AM Changeset in webkit [11494] by eseidel
  • 17 edits in trunk/LayoutTests

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
1:17 AM Changeset in webkit [11493] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

No applet test (mjs says DRT has kittens in that case)
SVG is covered by <use> test cases (5 tests).

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::endElementNs): call closeRenderer()
12:54 AM Changeset in webkit [11492] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/misc/shared.h: Rewrote both Shared and TreeShared to be functionally the same, but used signed reference counts and remove the extra check inside deref that handles the case of extra derefs (a programming mistake in any case). This elimnates a branch from a hot code path. Also added license header. New versions have private data members, unlike the old ones that used protected.
  • khtml/rendering/render_replaced.h: Removed private inheritance from Shared, and instead just declared a variable that holds a reference count, because that's the only thing that was being used from Shared.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initialized m_refCount. (RenderWidget::~RenderWidget): Use m_refCount. (RenderWidget::eventFilter): Ditto. (RenderWidget::deref): Use m_refCount and the new faster idiom (although here it's not important becaue the function isn't even inlined).
12:44 AM Changeset in webkit [11491] by eseidel
  • 5 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, svg build fix only.

  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue): parseShorthand rename
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: missing header
  • ksvg2/svg/SVGFELightElementImpl.cpp: missing header
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: missing header
12:40 AM Changeset in webkit [11490] by darin
  • 20 edits in trunk

WebCore:

Reviewed by Eric.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code to the CSS_PROP_CURSOR case to handle cursor images.
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Allow and parse a URL for the cursor for the image case.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Do the appropriate inherit and initial for CSS_PROP_CURSOR, and allow either an identifier or a URL for the value.
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler): Removed inappropriate call to resetCursor. We don't change the cursor shape just because we're following a link.
  • khtml/khtmlview.cpp: (selectCursor): Added. New function that chooses the appropriate cursor. Includes new logic to handle image cursors. (KHTMLView::viewportMouseMoveEvent): Refactored to use selectCursor to choose the appropriate cursor.
  • kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Call the function to get an image renderer by its new name, imageRenderer().
  • kwq/KWQCursor.mm: (createCustomCursor): Added. (QCursor::QCursor): Changed constructor that takes a QPixmap to call createCustomCursor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Replaced a call to resetCursor with a call to setCursor(QCursor()). (KWQKHTMLPart::fileWrapperForElement): Fixed code that assumed the render object is always a RenderImage. Call TIFFRepresentation on the image renderer instead of incorrectly assuming it's always an NSImage.
  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap): Call imageRenderer function instead of getting right at the data member. (QPainter::drawTiledPixmap): Ditto. (QPainter::drawScaledAndTiledPixmap): Ditto.
  • kwq/KWQPixmap.h: Removed convertToImage(), renamed image() to imageRenderer().
  • kwq/KWQPixmap.mm: Similar name changes.
  • kwq/KWQWidget.mm: (QWidget::setCursor): To workaround extra work done by AppKit when you set the cursor to the same one, check if the cursor is already set before calling setDocumentCursor.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Call the image method on the image renderer instead of incorrectly assuming the renderer itself is an image.
  • kwq/WebCoreImageRenderer.h: Added a TIFFRepresentation method to this protocol.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and image methods since both are required by the WebCoreImageRenderer protocol now and we don't have to re-declare them.
  • Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file since we need to use methods inherited from that protocol.
  • Misc.subproj/WebNSViewExtras.m: Ditto.
  • WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)

Dec 7, 2005:

11:42 PM Changeset in webkit [11489] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Landed by Darin.

  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • fast/text/atsui-pointtooffset-calls-cg.html: Added.
11:41 PM Changeset in webkit [11488] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Added the missing "return".
4:19 PM Changeset in webkit [11487] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] @ home.netscape.com
  • WebView.subproj/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assert that I added a while back. In this case at least, the assertion is overzealous, and I can't recreate the tortured chain of logic that led me to adding this assertion in the first place.
3:19 PM Changeset in webkit [11486] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Add Radar bug # to an old commit.

2:48 PM Changeset in webkit [11485] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work. This was just a silly regression
from my pre-wrap/pre-line implementation. I accidentally changed
code to examine the wrong style().

Reviewed by harrison

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [11484] by hyatt
  • 2 edits in trunk/WebCore

Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects that
have corresponding DOM elements.

Reviewed by Eric Seidel

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
2:31 AM Changeset in webkit [11483] by eseidel
  • 1 edit
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.

Removing unused files.

  • kcanvas/KCanvasRegistry.cpp: Removed.
  • kcanvas/KCanvasRegistry.h: Removed.

Dec 6, 2005:

5:16 PM Changeset in webkit [11482] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Removed change marker.

5:12 PM Changeset in webkit [11481] by hyatt
  • 16 edits in trunk/WebCore

Add support for more methods for exposing more useful style information.

getMatchedCSSRules can be used to obtain the matched sheet rules for an element. In Obj-C
it will also include user/user agent sheet rules.

Also add support for tracking the original shorthand in which a property was declared, as well
as whether the property was just implicitly set rather than explicitly mentioned (e.g., if it was
an omitted piece of a shorthand). The new methods on CSSStyleDeclaration are getPropertyShorthand
and isPropertyImplicit.

Reviewed by mjs

Test: fast/inspector/style.html

  • khtml/css/css_computedstyle.h: (DOM::CSSComputedStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSComputedStyleDeclarationImpl::isPropertyImplicit):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): (DOM::CSSMutableStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSMutableStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSProperty::cssText): (DOM::operator==):
  • khtml/css/css_valueimpl.h: (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::shorthandID): (DOM::CSSProperty::isImportant): (DOM::CSSProperty::isImplicit):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::addProperty): (CSSParser::parseValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseShorthand): (CSSParser::parse4Values): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty):
  • khtml/css/cssparser.h: (DOM::CSSParser::enterShorthand): (DOM::CSSParser::exitShorthand): (DOM::CSSParser::inShorthand):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleDeclaration::):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
  • khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
  • khtml/xml/dom2_viewsimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration getPropertyShorthand:]): (-[DOMCSSStyleDeclaration isPropertyImplicit:]): (-[DOMDocument getMatchedCSSRules::]):
  • kwq/DOMPrivate.h:
5:11 PM Changeset in webkit [11480] by hyatt
  • 3 adds in trunk/LayoutTests/fast/inspector

Land layout test for style inspection.

3:34 PM Changeset in webkit [11479]
  • 55 copies
    22 deletes in tags/WebKit-417~7

This commit was manufactured by cvs2svn to create tag 'WebKit-417~7'.

3:34 PM Changeset in webkit [11478]
  • 211 copies
    17 deletes in tags/WebCore-417~10

This commit was manufactured by cvs2svn to create tag
'WebCore-417~10'.

3:34 PM Changeset in webkit [11477] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning to WebKit-417.7 and WebCore-417.10

2:12 PM Changeset in webkit [11476] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
2:06 PM Changeset in webkit [11475] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
1:54 PM Changeset in webkit [11474] by sullivan
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog: Remove special-case handling for nib files. This avoided trouble with cvs diff when we were using wrappers for nib files. Now that we aren't using wrappers, there's no reason to avoid adding the modified nib files to the file list that gets diffed.
11:38 AM Changeset in webkit [11473] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fix build when using gcc 4
  • kjs/ustring.h: Make Rep public.
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator): Fix a typo.
1:21 AM Changeset in webkit [11472] by mjs
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • cleaned up UString a little so that it doesn't need to have so many friend classes
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kjs/identifier.h: (KJS::Identifier::Identifier): (KJS::Identifier::equal):
  • kjs/property_map.cpp: (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::remove):
  • kjs/ustring.cpp: (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::substr): (KJS::UString::copyForWriting): (KJS::operator==):
  • kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString): (KJS::UString::data): (KJS::UString::isNull): (KJS::UString::isEmpty): (KJS::UString::size): (KJS::UString::rep):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::operator*): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):

WebCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):

Dec 5, 2005:

11:20 PM Changeset in webkit [11471] by eseidel
  • 4 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Script updates for SVG files move (remove references to SVGSupport)

  • Scripts/build-webkit: remove SVGSupport
  • Scripts/run-webkit-tests: Resources -> resources for --svg
  • Scripts/update-webkit: remove SVGSupport
10:29 PM Changeset in webkit [11470] by eseidel
  • 28 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Changed "Resources" to "resources" to match other layout tests.

  • svg/W3C-SVG-1.1/color-prof-01-f.svg:
  • svg/W3C-SVG-1.1/filters-conv-01-f.svg:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
  • svg/W3C-SVG-1.1/filters-displace-01-f.svg:
  • svg/W3C-SVG-1.1/filters-image-01-b.svg:
  • svg/W3C-SVG-1.1/filters-light-01-f.svg:
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg:
  • svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
  • svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
  • svg/W3C-SVG-1.1/interact-order-02-b.svg:
  • svg/W3C-SVG-1.1/interact-order-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-01-b.svg:
  • svg/W3C-SVG-1.1/linking-a-02-b.svg:
  • svg/W3C-SVG-1.1/linking-a-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-04-t.svg:
  • svg/W3C-SVG-1.1/linking-uri-02-b.svg:
  • svg/W3C-SVG-1.1/linking-uri-03-t.svg:
  • svg/W3C-SVG-1.1/masking-path-04-b.svg:
  • svg/W3C-SVG-1.1/render-groups-01-b.svg:
  • svg/W3C-SVG-1.1/render-groups-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-01-t.svg:
  • svg/W3C-SVG-1.1/struct-image-02-b.svg:
  • svg/W3C-SVG-1.1/struct-image-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-05-b.svg:
  • svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
  • svg/W3C-SVG-1.1/text-tref-01-b.svg:
10:08 PM Changeset in webkit [11469] by eseidel
  • 81 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Updating all the SVG tests with their latest post-merger results.
There are still issues which will prevent these from passing on
all machines:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4515
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5962

  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-frag-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • svg/custom/fill-update-expected.checksum:
  • svg/custom/fill-update-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • svg/custom/path-update-expected.checksum:
  • svg/custom/path-update-expected.png:
  • svg/custom/simpleCDF-expected.checksum:
  • svg/custom/simpleCDF-expected.png:
  • svg/custom/use-forward-refs-expected.checksum:
  • svg/custom/use-forward-refs-expected.png:
  • svg/custom/use-forward-refs-expected.txt:
8:29 PM Changeset in webkit [11468] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrsion

  • editing/selection/paragraph-granularity-expected.checksum: Added.
  • editing/selection/paragraph-granularity-expected.png: Added.
  • editing/selection/paragraph-granularity-expected.txt: Added.
  • editing/selection/paragraph-granularity.html: Added.
  • editing/selection/word-granularity-expected.checksum: Added.
  • editing/selection/word-granularity-expected.png: Added.
  • editing/selection/word-granularity-expected.txt: Added.
  • editing/selection/word-granularity.html: Added.
8:29 PM Changeset in webkit [11467] by justing
  • 4 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrison

Rolled back previous change, simplified expansion, fixed
adjustForEditableContent to work in cases where start/end are
distinct from base/extent, renamed m_baseIsStart to m_baseIsFirst.

Added two new layout tests in editing/selection to test
modifying selections created with double and triple clicks.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::init): (khtml::SelectionController::operator=): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::adjustForEditableContent): (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseMoveEvent):
6:41 PM Changeset in webkit [11466] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • WebCore.xcodeproj/project.pbxproj: updated paths for SVG move.
6:35 PM Changeset in webkit [12217] by mjs
  • 1 edit
    2 adds in trunk/JavaScriptGlue
  • added new forwarding headers
  • kxmlcore/PassRefPtr.h: Added.
  • kxmlcore/RefPtr.h: Added.
6:16 PM Changeset in webkit [11465] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • checkout: remove --svg support, SVG is now checked out by default
6:04 PM Changeset in webkit [11464] by eseidel
  • 6 edits in trunk/LayoutTests

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

Updated results for KCanvaPath changes:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
5:53 PM Changeset in webkit [11463] by eseidel
  • 54 edits
    1 add
    6 deletes in trunk/WebCore

Bug #: 5942, 5943
Submitted by: eseidel
Reviewed by: darin

No test cases possible/necessary.

Removing unused ForwardingHeaders, as well as header cleanup in SVG
Fixed KSVG2 files to include proper KDOM headers.
Fixed KDOM forwarding headers to point to correct khtml headers.
Added DataRef.h to hold khtml::DataRef.
Made SVGRenderStyle a DataRef on RenderStyle.
(Landing two bugs at once as their project file changes intertwine)

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5942
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5943

  • ForwardingHeaders/kdom/DOMString.h:
  • ForwardingHeaders/kdom/KDOMSettings.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedDocument.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h:
  • ForwardingHeaders/kdom/cache/KDOMLoader.h:
  • ForwardingHeaders/kdom/core/AttrImpl.h:
  • ForwardingHeaders/kdom/core/CDFInterface.h: Removed.
  • ForwardingHeaders/kdom/core/DOMImplementationImpl.h:
  • ForwardingHeaders/kdom/core/DOMStringImpl.h:
  • ForwardingHeaders/kdom/core/DocumentImpl.h:
  • ForwardingHeaders/kdom/core/ElementImpl.h:
  • ForwardingHeaders/kdom/core/NodeImpl.h:
  • ForwardingHeaders/kdom/core/XMLElementImpl.h:
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h:
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h:
  • ForwardingHeaders/kdom/css/CSSValueImpl.h:
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h:
  • ForwardingHeaders/kdom/css/RGBColorImpl.h:
  • ForwardingHeaders/kdom/events/UIEventImpl.h:
  • ForwardingHeaders/kdom/events/kdomevents.h:
  • ForwardingHeaders/kdom/kdom.h:
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/KDOMStubClasses.h: Removed.
  • WebCore+SVG/kdomcss.h: Removed.
  • WebCore+SVG/kdomls.h: Removed.
  • WebCore+SVG/kdomrange.h: Removed.
  • WebCore+SVG/kdomtraversal.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::drawMarkersIfNeeded):
  • khtml/rendering/DataRef.h: Added. (khtml::DataRef::DataRef): (khtml::DataRef::~DataRef): (khtml::DataRef::operator->): (khtml::DataRef::get): (khtml::DataRef::access): (khtml::DataRef::init): (khtml::DataRef::operator=): (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
  • khtml/rendering/render_style.cpp: (m_affectedByAttributeSelectors): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::~RenderStyle): (RenderStyle::operator==): (RenderStyle::inheritedNotEqual): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::svgStyle): (khtml::RenderStyle::accessSVGStyle):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): (SVGRenderStyle::inheritedNotEqual):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::operator!=):
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGZoomAndPanImpl.h:
5:46 PM Changeset in webkit [11462] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): one more tweak: moved jumpToSelection: to be validated the same way as centerSelectionInVisibleArea:, since it now calls the same code. Might not make a difference in any real code, but you never know.
5:23 PM Changeset in webkit [11461] by eseidel
  • 39 edits
    2 adds in trunk/WebCore

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

5 test cases updated, no additional tests needed.

Removed KCPathData, KCPathDataList and KCanvasUserData.
Added KCanvasPath and KCanvasPathQuartz instead.
Updated methods to expect KCanvasPath* types and use RefPtr.
Removed no longer needed KCPathDataList -> KCanvasUserData routines
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • WebCore.xcodeproj/project.pbxproj: added KCanvasPath(Quartz)
  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createRoundedRectangle): updated to KCanvasPath* (KCanvasCreator::createRectangle): updated to KCanvasPath* (KCanvasCreator::createEllipse): updated to KCanvasPath* (KCanvasCreator::createCircle): updated to KCanvasPath* (KCanvasCreator::createLine): updated to KCanvasPath*
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp: (RenderPath::Private::Private): updated to KCanvasPath* (RenderPath::~RenderPath): (RenderPath::changePath): (RenderPath::path): updated to KCanvasPath*
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp: (operator<<): updated to call device->stringForPath()
  • kcanvas/KCanvasPath.h: (KCanvasPath::~KCanvasPath): (KCClipDataList::addPath): updated to KCanvasPath*
  • kcanvas/KCanvasResources.cpp: (KCanvasClipper::addClipData): updated to KCanvasPath*
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::path): updated to KCanvasPath* (KCanvasCommonArgs::setPath): updated to KCanvasPath* (KRenderingDevice::KRenderingDevice):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): updated to KCanvasPath* (KCanvasItemQuartz::bboxForPath): updated to KCanvasPath* (KCanvasItemQuartz::hitsPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.h: Added. (KCanvasPathQuartz::cgPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: Added. (KCanvasPathQuartz::KCanvasPathQuartz): added (KCanvasPathQuartz::~KCanvasPathQuartz): added (KCanvasPathQuartz::isEmpty): added (KCanvasPathQuartz::moveTo): added (KCanvasPathQuartz::lineTo): added (KCanvasPathQuartz::curveTo): added (KCanvasPathQuartz::closeSubpath): added
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasClipperQuartz::applyClip): updated to KCanvasPath*
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createPath): added (KRenderingDeviceQuartz::stringForPath): updated to KCanvasPath* (KRenderingDeviceQuartz::createItem): updated to KCanvasPath*
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/svg/SVGCircleElementImpl.cpp: (SVGCircleElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.cpp: (KSVG::SVGEllipseElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.cpp: (SVGLineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolygonElementImpl.h:
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolylineElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer): updated to KCanvasPath* (SVGStyledElementImpl::updateCanvasItem): updated to KCanvasPath* (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledElementImpl.h: (KSVG::SVGStyledElementImpl::toPathData): updated to KCanvasPath*
5:10 PM Changeset in webkit [11460] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Do the same "skip text node" logic for the "oldUnder" variable as for the "targetNode" variable.
4:23 PM Changeset in webkit [11459] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed a problem from the patch to fix <rdar://problem/4365690>. After that checkin, KWQKHTMLPart was
inadvertently left with both centerSelectionInVisibleArea() and centerSelectionInVisibleArea() const.

  • kwq/KWQKHTMLPart.h: renamed centerSelectionInVisibleArea() to revealSelection(). This is the method that was named jumpToSelection() before my recent checkin.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin. (KWQKHTMLPart::revealSelection): renamed from centerSelectionInVisibleArea() (KWQKHTMLPart::advanceToNextMisspelling): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin.
  • kwq/WebCoreBridge.h: removed one of the two declarations of centerSelectionInVisibleArea()
4:14 PM Changeset in webkit [11458] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): removed double handling of centerSelectionInVisibleArea
3:48 PM Changeset in webkit [11457] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): Reimplement jumpToSelection: to call centerSelectionInVisibleArea:, and added a comment explaining why jumpToSelection: exists at all. Note that centerSelectionInVisibleArea: was already implemented here; it was added as part of HTML editing implementation without us realizing that it was the API replacement for jumpToSelection:. (-[WebHTMLView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection: (we should have done this when centerSelectionInVisibleArea: was implemented)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView centerSelectionInVisibleArea:]): new method, same code that jumpToSelection: used to have (-[WebPDFView jumpToSelection:]): now calls centerSelectionInVisibleArea:, and there's now a comment about why it exists at all. (-[WebPDFView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection:
2:56 PM Changeset in webkit [11456] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:31 PM Changeset in webkit [11455] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison, John Sullivan.

<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)

I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
initialized. Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
has been "committed" (inserted into the view hierarchy).

My fix is to ensure that the plugin is initialized where we previously would have created that second
WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.

  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy. We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView has been committed.
2:19 PM Changeset in webkit [11454] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Removed some dead code I happened to stumble across. No test cases added.

  • kwq/KWQTimer.h: removed unused immediateSingleShotOnMainThread()
  • kwq/KWQTimer.mm: removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget that was used to implement it.
2:01 PM Changeset in webkit [11453] by sullivan
  • 5 edits in trunk/WebCore

Reviewed by Tim Omernick.

  • WebCore part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)

No behavioral changes here. This patch just eliminates the name "jumpToSelection" in favor of
"centerSelectionInVisibleArea" to match WebKit and AppKit.

  • kwq/KWQKHTMLPart.h: eliminate jumpToSelection(); add centerSelectionInVisibleArea()
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): use centerSelectionInVisibleArea() instead of jumpToSelection() (KWQKHTMLPart::centerSelectionInVisibleArea): renamed from jumpToSelection (KWQKHTMLPart::advanceToNextMisspelling): use centerSelectionInVisibleArea() instead of jumpToSelection()
  • kwq/WebCoreBridge.h: eliminate jumpToSelection; add centerSelectionInVisibleArea
  • kwq/WebCoreBridge.mm: eliminate jumpToSelection. We had been implementing both jumpToSelection and centerSelectionInVisibleArea here, but jumpToSelection now has no more callers.
11:57 AM Changeset in webkit [11452] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
11:56 AM Changeset in webkit [11451] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
9:40 AM Changeset in webkit [11450] by vicki
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
Note: See TracTimeline for information about the timeline view.