Timeline



Dec 10, 2005:

11:28 PM Changeset in webkit [11528] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • fix SVG build for recent QTimer changes.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::SVGTimer):
6:06 PM Changeset in webkit [11527] by darin
  • 134 edits in trunk

JavaScriptCore:

Rubber stamped by Maciej.

  • did long-promised KJS renaming:

ValueImp -> JSValue
ObjectImp -> JSObject
AllocatedValueImp -> JSCell

A renaming to get a class out of the way

KJS::Bindings::JSObject -> JavaJSObject

and some other "imp-reduction" renaming

*InstanceImp -> *Instance
*ProtoFuncImp -> *ProtoFunc
*PrototypeImp -> *Prototype
ArgumentsImp -> Arguments
RuntimeArrayImp -> RuntimeArray
RuntimeMethodImp -> RuntimeMethod

  • most files and functions

WebCore:

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
6:03 PM Changeset in webkit [12219] by darin
  • 10 edits in trunk/JavaScriptGlue

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
5:44 PM Changeset in webkit [11526] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin and Eric.

  • Makefile.am: Support --enable-svg
4:38 PM Changeset in webkit [11525] by darin
  • 53 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • bindings/NP_jsobject.cpp: (_NPN_Evaluate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: (CField::valueFromInstance):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp: (JSObject::eval): (JSObject::convertJObjectToValue):
  • bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcFallbackObjectImp::callAsFunction):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::valueOf):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::lengthGetter):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::lengthGetter): (RuntimeMethodImp::callAsFunction): (RuntimeMethodImp::execute):
  • kjs/array_object.cpp: (ArrayInstanceImp::lengthGetter): (CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (ArrayPrototypeImp::ArrayPrototypeImp): (ArrayProtoFuncImp::ArrayProtoFuncImp): (ArrayProtoFuncImp::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
  • kjs/bool_object.cpp: (BooleanPrototypeImp::BooleanPrototypeImp): (BooleanProtoFuncImp::callAsFunction): (BooleanObjectImp::BooleanObjectImp): (BooleanObjectImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorPrototypeImp::ErrorPrototypeImp): (ErrorProtoFuncImp::ErrorProtoFuncImp): (ErrorProtoFuncImp::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::DeclaredFunctionImp::execute): (KJS::encode): (KJS::decode): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): (FunctionPrototypeImp::callAsFunction): (FunctionProtoFuncImp::callAsFunction): (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
  • kjs/interpreter.h:
  • kjs/lookup.h:
  • kjs/math_object.cpp: (MathObjectImp::getValueProperty): (MathFuncImp::callAsFunction):
  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): (NullNode::evaluate): (PropertyNode::evaluate): (FunctionCallBracketNode::evaluate): (FunctionCallDotNode::evaluate): (PostfixBracketNode::evaluate): (PostfixDotNode::evaluate): (VoidNode::evaluate): (PrefixBracketNode::evaluate): (PrefixDotNode::evaluate): (ShiftNode::evaluate): (valueForReadModifyAssignment): (AssignDotNode::evaluate): (AssignBracketNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (VarDeclListNode::evaluate): (ReturnNode::execute): (CaseClauseNode::evalStatements): (ParameterNode::evaluate): (FuncDeclNode::processFuncDecl):
  • kjs/nodes.h: (KJS::StatementNode::evaluate):
  • kjs/number_object.cpp: (NumberPrototypeImp::NumberPrototypeImp): (NumberProtoFuncImp::callAsFunction): (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getValueProperty): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::ObjectImp::get): (KJS::Error::create):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction): (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter):
  • kjs/regexp_object.cpp: (RegExpPrototypeImp::RegExpPrototypeImp): (RegExpProtoFuncImp::callAsFunction): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::construct):
  • kjs/string_object.cpp: (StringInstanceImp::StringInstanceImp): (StringPrototypeImp::StringPrototypeImp): (replace): (StringProtoFuncImp::callAsFunction): (StringObjectImp::StringObjectImp): (StringObjectImp::callAsFunction): (StringObjectFuncImp::StringObjectFuncImp): (StringObjectFuncImp::callAsFunction):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (VersionFunctionImp::callAsFunction):
  • kjs/value.h:

WebCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrNull): (KJS::setDOMException):
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheet::getValueProperty): (KJS::getDOMStyleSheet): (KJS::DOMStyleSheetList::getValueProperty): (KJS::getDOMStyleSheetList): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMMediaList::getValueProperty): (KJS::DOMMediaList::indexGetter): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRuleList::getValueProperty): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::CSSRuleConstructor::getValueProperty): (KJS::DOMCSSValue::getValueProperty): (KJS::getDOMCSSValue): (KJS::CSSValueConstructor::getValueProperty): (KJS::DOMCSSPrimitiveValue::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::CSSPrimitiveValueConstructor::getValueProperty): (KJS::DOMCSSValueList::getValueProperty): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMCounter::getValueProperty):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::callAsFunction): (KJS::DOMAttr::getValueProperty): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::attributeGetter): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::DOMDOMImplementationProtoFunc::callAsFunction): (KJS::DOMDocumentType::getValueProperty): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMProcessingInstruction::getValueProperty): (KJS::DOMNotation::getValueProperty): (KJS::DOMEntity::getValueProperty): (KJS::getDOMNode): (KJS::NodeConstructor::getValueProperty): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMCharacterData::getValueProperty): (KJS::DOMCharacterDataProtoFunc::callAsFunction): (KJS::DOMTextProtoFunc::callAsFunction):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::EventConstructor::getValueProperty): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::getDOMEvent): (KJS::EventExceptionConstructor::getValueProperty): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::MutationEventConstructor::getValueProperty): (KJS::DOMMutationEvent::getValueProperty): (KJS::DOMMutationEventProtoFunc::callAsFunction): (KJS::DOMWheelEvent::getValueProperty): (KJS::DOMWheelEventProtoFunc::callAsFunction): (KJS::stringOrUndefined): (KJS::Clipboard::getValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::htmlGetter): (KJS::HTMLElement::headGetter): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::titleGetter): (KJS::HTMLElement::metaGetter): (KJS::HTMLElement::baseGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::formGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optGroupGetter): (KJS::HTMLElement::optionGetter): (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::uListGetter): (KJS::HTMLElement::oListGetter): (KJS::HTMLElement::dListGetter): (KJS::HTMLElement::dirGetter): (KJS::HTMLElement::menuGetter): (KJS::HTMLElement::liGetter): (KJS::HTMLElement::divGetter): (KJS::HTMLElement::paragraphGetter): (KJS::HTMLElement::headingGetter): (KJS::HTMLElement::blockQuoteGetter): (KJS::HTMLElement::quoteGetter): (KJS::HTMLElement::preGetter): (KJS::HTMLElement::brGetter): (KJS::HTMLElement::baseFontGetter): (KJS::HTMLElement::fontGetter): (KJS::HTMLElement::hrGetter): (KJS::HTMLElement::modGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::imageGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::paramGetter): (KJS::HTMLElement::appletGetter): (KJS::HTMLElement::mapGetter): (KJS::HTMLElement::areaGetter): (KJS::HTMLElement::scriptGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::tableCaptionGetter): (KJS::HTMLElement::tableColGetter): (KJS::HTMLElement::tableSectionGetter): (KJS::HTMLElement::tableRowGetter): (KJS::HTMLElement::tableCellGetter): (KJS::HTMLElement::frameSetGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::marqueeGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLCollection::lengthGetter): (KJS::KJS::HTMLCollection::callAsFunction): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::selectedIndexGetter): (KJS::HTMLSelectCollection::getOwnPropertySlot): (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::Image::getValueProperty): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::getValueProperty): (KJS::Context2D::Context2D): (KJS::GradientFunction::callAsFunction): (KJS::Gradient::getValueProperty): (KJS::ImagePattern::getValueProperty): (KJS::getSelectHTMLCollection):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::MimeType::getValueProperty): (KJS::PluginsFunc::callAsFunction): (KJS::NavigatorFunc::callAsFunction):
  • khtml/ecma/kjs_proxy.cpp: (TestFunctionImp::callAsFunction):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::RangeConstructor::getValueProperty):
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::NodeFilterConstructor::getValueProperty): (KJS::DOMNodeFilterProtoFunc::callAsFunction): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::Window::retrieve): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::Location::getValueProperty): (KJS::Location::toPrimitive): (KJS::LocationFunc::callAsFunction): (KJS::Selection::getValueProperty): (KJS::Selection::toPrimitive): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::getValueProperty): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::getAllResponseHeaders): (KJS::XMLHttpRequest::getResponseHeader): (KJS::XMLHttpRequest::getStatus): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • ksvg2/ecma/Ecma.cpp: (KSVG::getSVGPathSeg):
  • ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:35 PM Changeset in webkit [12218] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • JSUtils.cpp: (JSObjectKJSValue):
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::toPrimitive):
4:07 PM Changeset in webkit [11524] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin and Tim Hatcher.

  • fix WebCore SVG build for gcc 3.3 (don't know why it has these complaints)
  • kcanvas/KCanvasFilters.h: (QPointF::QPointF): Add a default constructor (KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): ditto
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): Move a variable declaration instead exception blocking (KCanvasFECompositeQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto
12:40 PM Changeset in webkit [11523] by darin
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore.exp: Export the new WebCoreElementImageRendererKey and remove the old WebCoreElementImageKey.
  • kwq/WebCoreBridge.h: Add WebCoreElementImageRendererKey, remove WebCoreElementImageKey.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Pass the image renderer in the dictionary, but not the NSImage.

WebKit:

Reviewed by John Sullivan.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Pass the image renderer, not the NSImage. (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from WebCore with only an image renderer.
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): Pass the image renderer, not the NSImage.
12:34 PM Changeset in webkit [11522] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
plainText() returns a partial result when the node contains RTL text

  • fast/dom/inner-text-rtl-expected.txt: Added.
  • fast/dom/inner-text-rtl.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/dom/inner-text-rtl.html

  • khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox): Avoid advancing m_sortedTextBoxes if textBoxEnd wasn't reached.
  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::getNext): Added. (KWQListImpl::getPrev): Added.
  • kwq/KWQPtrList.h: (QPtrList::getNext): Added. (QPtrList::getPrev): Added.
12:21 PM Changeset in webkit [11521] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5826

  • fast/overflow/overflow-rtl-expected.checksum: Added.
  • fast/overflow/overflow-rtl-expected.png: Added.
  • fast/overflow/overflow-rtl-expected.txt: Added.
  • fast/overflow/overflow-rtl.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::RenderLayer): Initialize (khtml::RenderLayer::scrollOffset): (khtml::RenderLayer::subtractScrollOffset): (khtml::RenderLayer::scrollToOffset): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::updateScrollPositionFromScrollbars): (khtml::RenderLayer::computeScrollDimensions): (khtml::RenderLayer::updateScrollInfoAfterLayout):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollToYOffset):
11:56 AM Changeset in webkit [11520] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3983

  • fast/css/outline-auto-location-expected.checksum: Added.
  • fast/css/outline-auto-location-expected.png: Added.
  • fast/css/outline-auto-location-expected.txt: Added.
  • fast/css/outline-auto-location.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Only add the rect if this is a RenderBlock.
11:05 AM Changeset in webkit [11519] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::callAsFunction): Added set of visited objects -- don't recurse if item is already in the set.

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

  • fast/js/cyclic-ref-toString-expected.txt: Added.
  • fast/js/cyclic-ref-toString.html: Added.
10:56 AM Changeset in webkit [11518] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5784

  • fast/parser/duplicate-html-body-element-IDs-expected.txt: Added.
  • fast/parser/duplicate-html-body-element-IDs.html: Added.

WebCore:

Reviewed and landed by Darin.

Added a new layout test that checks for at least one symptom of the bug.

  • khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use setAttribute here instead of using insertAttribute and calling recalcStyle explicitly. That's because setAttribute does other things that are needed to change an attribute in an attribute map that's already connected to an element, including updating the ID map if the attribute is the ID attribute.
  • khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::insertAttribute): Assert that this parser-only function is only used on attribute maps that aren't yet attached to elements.
9:14 AM Changeset in webkit [11517] by darin
  • 12 edits in trunk/WebCore

Reviewed by Eric and Tim Omernick.

  • kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and restartTimer. Made KWQObjectSenderScope functions be inline.
  • kwq/KWQObject.mm: (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent on the target. (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new timer ID and calls restartTimer. (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary. That includes creating a CFRunLoopTimer and scheduling it on the current run loop. (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to fire and the "fire again" interval. (deleteTimer): Added. Invalidates and then removes a timer. (QObject::killTimer): Changed to use deleteTimer to do most of its work. (deleteOneTimer): Added. Calls deleteTimer. (QObject::killTimers): Changed to use deleteOneTimer to do most of its work. (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target. (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers. (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.
  • kwq/KWQTimer.h: (QTimer::QTimer): Made constructor inline and removed the optional parameter. (QTimer::isActive): Made inline. (QTimer::fireDate): Added. Inline function. Got rid of the NSTimer and added a CFRunLoopTimer.
  • kwq/KWQTimer.mm: (timerFired): Added. Calls fire on the QTimer object. (QTimer::start): Changed to create a CFRunLoopTimer. (QTimer::stop): Changed to use CFRunLoopTimer functions. (QTimer::fire): Ditto.
  • khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the file so it can be used inline in the implementation of the Window class, and changed to use the PausedTimeouts class intead of a QMap to store the paused timeouts.
  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces a check in the caller and a check partway down this function (after the part was already dereferenced). Fixed message handling so the message is not converted to ascii and back. Added an isObject() check so we won't crash if the passed function is a value that's not an object. Changed check for function vs. script to check for a function of nil instead of using a separate boolean. (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object, using the new QObject::timerIntervals function rather than the old QObject::pauseTimer function. This means that the paused timers are entirely stored in the PausedTimeouts object instead of being half in a QMap and the other half inside the QObject itself. (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function. (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including the scheduled actions, unless the timeouts have already been resumed (in which case the m_array field will be 0).
  • kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them use the PausedTimeouts class and no longer take a key parameter.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than the old getNSTimer() function to get the fire date. (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter. (KWQKHTMLPart::resumeTimeouts): Remove the key parameter. (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead of a QMap for the paused timeouts.
  • kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts. Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]): Added code where it sets the pausedTimouts. (-[KWQPageState pausedTimeouts]): Added. (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode. (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0. (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method. (-[KWQPageState finalize]): Set document to 0 after deref for consistency.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the paused timeouts using the new pauseTimeouts function.
7:27 AM Changeset in webkit [11516] by darin
  • 2 edits in trunk/WebKit

Was getting build failures related to "count" methods.
Made Tim's build fix Leopard-only.

  • WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.

Dec 9, 2005:

8:52 PM Changeset in webkit [11515] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
  • WebView.subproj/WebView.m: (-[WebView _frameForCurrentSelection]): I removed this method many moons ago when restructuring the code involving frames and selection. Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
6:59 PM Changeset in webkit [11514] by justing
  • 5 edits in trunk/WebCore

<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections
Some preparation for a fix for:
<radar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

There were a few bugs in endOfParagraph's and endOfLine's handling of IncludeLineBreak.
The IncludeLinebreak concept also doesn't make sense: when asked to
IncludeLineBreak, "endOfParagraph" would return the start of the next paragraph.
Callers that want this funtionality should just call endOfParagraph and then get next()
if it exists.
In endOfParagraph's whitespace:pre handling, when the input visible position
was at the end of a text node with whitespace:pre, that text node was searched
for '/n'. It should be skipped.

Reviewed by harrison

Added new layout tests in editing/pasting and editing/selection

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::validate):
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::isEndOfLine): (khtml::endOfParagraph): (khtml::isEndOfParagraph):
  • khtml/editing/visible_units.h:
6:59 PM Changeset in webkit [11513] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<rdar://problem/4370209> Reproducible crash when pasting over whitespace:pre text
<rdar://problem/4370220> Double or triple clicking in whitespace:pre text creates incorrect selections

Reviewed by harrison

  • editing/pasteboard/paste-pre-002-expected.checksum: Added.
  • editing/pasteboard/paste-pre-002-expected.png: Added.
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html: Added.
  • editing/selection/triple-click-in-pre-expected.checksum: Added.
  • editing/selection/triple-click-in-pre-expected.png: Added.
  • editing/selection/triple-click-in-pre-expected.txt: Added.
  • editing/selection/triple-click-in-pre.html: Added.
6:13 PM Changeset in webkit [11512] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Carbon.subproj/HIWebView.m: (UpdateCommandStatus): Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures. -performSelector:withObject:'s return value should only be checked if the method returns an object.
3:48 PM Changeset in webkit [11511] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4371187> 10.4.4 Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
2:06 PM Changeset in webkit [11510]
  • 55 copies
    22 deletes in tags/WebKit-417~8

This commit was manufactured by cvs2svn to create tag 'WebKit-417~8'.

2:06 PM Changeset in webkit [11509]
  • 211 copies
    17 deletes in tags/WebCore-417~11

This commit was manufactured by cvs2svn to create tag
'WebCore-417~11'.

2:06 PM Changeset in webkit [11508] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning.

10:59 AM Changeset in webkit [11507] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by nobody, build fix.

Using <PDFKit/PDFKit.h> was causing build failures for the Mail team.
The comment about getting an ambiguous signature conflict anywhere the
method "count" is used seems to no longer be an issue.

  • WebView.subproj/WebPreferencesPrivate.h: Use <Quartz/Quartz.h>

Dec 8, 2005:

8:10 PM Changeset in webkit [11506] by adele
  • 6 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
6:12 PM Changeset in webkit [11505] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Some cleanup of how selection rects are associated with NSViews.

  • WebView.subproj/WebDocumentPrivate.h: Added a -selectionView method to <WebDocumentSelection>, and clarified that the selectionRect is in the coordinate system of this view.
  • Misc.subproj/WebSearchableTextView.m: (-[WebSearchableTextView selectionView]): new method, returns self
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectionView]): new method, returns self
  • WebView.subproj/WebPDFView.m: (-[WebPDFView selectionRect]): translate result into coordinate system of [PDFSubview documentView] (-[WebPDFView selectionView]): new method, returns [PDFSubview documentView]
6:10 PM Changeset in webkit [11504] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4311703> Crash in NPN_Invoke receiving contents of ​http://www.woodieschilidogs.com/ in Mail.app

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptNPObject): The window script object can be 0 if JavaScript is disabled. However, callers (like plugins) expect us to always return a window script object here. By substituting a plain ObjectImp for the window's ObjectImp, we can satisfy callers' assumptions and let them try to manipulate the dummy object when JavaScript is disabled.
4:06 PM Changeset in webkit [11503] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

  • fixed these semi-legendary bugs: <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now passes the focus down to that view.
3:13 PM Changeset in webkit [11502] by tomernic
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

Reviewed and landed by Maciej.

  • some simple changes that amount to a < 1% speedup.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • kwq/KWQKURL.mm: (hasSlashDotOrDotDot):
  • kwq/KWQString.mm: (QString::~QString):
3:05 PM Changeset in webkit [11501] by tomernic
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch.

Bug #: none
Submitted by: timo
Reviewed by: eseidel & darin

Changed some of the run measurement methods to C functions
to avoid overhead associated with objc_msgSend().

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForRun:style:widths:]): Updated to call new run measurement functions instead of calling ObjC methods. (-[WebTextRenderer CG_drawRun:style:geometry:]): ditto (floatWidthForRun): ditto (CG_floatWidthForRun): ditto (ATSU_floatWidthForRun): ditto (widthForNextCharacter): ditto
2:22 PM Changeset in webkit [11500] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)"
crashed when going from the "Open a template" menu to "Select recent
Document" in the "Welcome to Corel XI!" window.

These are the parts of that bug fix that were not already fixed in TOT.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...]
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Allow for the event not being leftmousedown or keydown
1:44 PM Changeset in webkit [11499] by harrison
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

11:44 AM Changeset in webkit [11498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.
10:33 AM Changeset in webkit [11497] by mjs
  • 7 edits in trunk/WebKit

Reviewed by John.

  • some small changes towards frame tree refactoring

Renamed WebViewSets to WebFrameNamespaces, and put the method for
performing a selector on all extant WebViews to WebView itself,
with a separate set tracking live WebViews. This should allow
moving the storage of this info down to WebCore more easily.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): (-[WebBridge runModal]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (webView::if): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebView.m: (+[WebView _makeAllWebViewsPerformSelector:]): (-[WebView _removeFromAllWebViewsSet]): (-[WebView _addToAllWebViewsSet]): (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setGroupName:]):
  • WebView.subproj/WebViewInternal.h:
10:19 AM Changeset in webkit [11496] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • fix major memory leak and resultant slowdown on JavaScript iBench from my PassRefPtr changes
  • kjs/ustring.cpp: (KJS::UString::Rep::create): I forgot to change one of the two overloads to create with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt to adopt the initial refcount, this may be a hair more efficient.
  • made the assignment operators for smart pointers inline because Shark said so
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::::operator=):
2:20 AM Changeset in webkit [11495] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5997
Submitted by: mitz
Reviewed by: eseidel

No test possible since this fixes random behavior.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5997
REGRESSION: Focus rings around links are not erased when focus is lost

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inDetach to false.
1:30 AM Changeset in webkit [11494] by eseidel
  • 17 edits in trunk/LayoutTests

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
1:17 AM Changeset in webkit [11493] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

No applet test (mjs says DRT has kittens in that case)
SVG is covered by <use> test cases (5 tests).

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::endElementNs): call closeRenderer()
12:54 AM Changeset in webkit [11492] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/misc/shared.h: Rewrote both Shared and TreeShared to be functionally the same, but used signed reference counts and remove the extra check inside deref that handles the case of extra derefs (a programming mistake in any case). This elimnates a branch from a hot code path. Also added license header. New versions have private data members, unlike the old ones that used protected.
  • khtml/rendering/render_replaced.h: Removed private inheritance from Shared, and instead just declared a variable that holds a reference count, because that's the only thing that was being used from Shared.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initialized m_refCount. (RenderWidget::~RenderWidget): Use m_refCount. (RenderWidget::eventFilter): Ditto. (RenderWidget::deref): Use m_refCount and the new faster idiom (although here it's not important becaue the function isn't even inlined).
12:44 AM Changeset in webkit [11491] by eseidel
  • 5 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, svg build fix only.

  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue): parseShorthand rename
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: missing header
  • ksvg2/svg/SVGFELightElementImpl.cpp: missing header
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: missing header
12:40 AM Changeset in webkit [11490] by darin
  • 20 edits in trunk

WebCore:

Reviewed by Eric.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code to the CSS_PROP_CURSOR case to handle cursor images.
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Allow and parse a URL for the cursor for the image case.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Do the appropriate inherit and initial for CSS_PROP_CURSOR, and allow either an identifier or a URL for the value.
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler): Removed inappropriate call to resetCursor. We don't change the cursor shape just because we're following a link.
  • khtml/khtmlview.cpp: (selectCursor): Added. New function that chooses the appropriate cursor. Includes new logic to handle image cursors. (KHTMLView::viewportMouseMoveEvent): Refactored to use selectCursor to choose the appropriate cursor.
  • kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Call the function to get an image renderer by its new name, imageRenderer().
  • kwq/KWQCursor.mm: (createCustomCursor): Added. (QCursor::QCursor): Changed constructor that takes a QPixmap to call createCustomCursor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Replaced a call to resetCursor with a call to setCursor(QCursor()). (KWQKHTMLPart::fileWrapperForElement): Fixed code that assumed the render object is always a RenderImage. Call TIFFRepresentation on the image renderer instead of incorrectly assuming it's always an NSImage.
  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap): Call imageRenderer function instead of getting right at the data member. (QPainter::drawTiledPixmap): Ditto. (QPainter::drawScaledAndTiledPixmap): Ditto.
  • kwq/KWQPixmap.h: Removed convertToImage(), renamed image() to imageRenderer().
  • kwq/KWQPixmap.mm: Similar name changes.
  • kwq/KWQWidget.mm: (QWidget::setCursor): To workaround extra work done by AppKit when you set the cursor to the same one, check if the cursor is already set before calling setDocumentCursor.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Call the image method on the image renderer instead of incorrectly assuming the renderer itself is an image.
  • kwq/WebCoreImageRenderer.h: Added a TIFFRepresentation method to this protocol.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and image methods since both are required by the WebCoreImageRenderer protocol now and we don't have to re-declare them.
  • Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file since we need to use methods inherited from that protocol.
  • Misc.subproj/WebNSViewExtras.m: Ditto.
  • WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)

Dec 7, 2005:

11:42 PM Changeset in webkit [11489] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Landed by Darin.

  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • fast/text/atsui-pointtooffset-calls-cg.html: Added.
11:41 PM Changeset in webkit [11488] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Added the missing "return".
4:19 PM Changeset in webkit [11487] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] @ home.netscape.com
  • WebView.subproj/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assert that I added a while back. In this case at least, the assertion is overzealous, and I can't recreate the tortured chain of logic that led me to adding this assertion in the first place.
3:19 PM Changeset in webkit [11486] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Add Radar bug # to an old commit.

2:48 PM Changeset in webkit [11485] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work. This was just a silly regression
from my pre-wrap/pre-line implementation. I accidentally changed
code to examine the wrong style().

Reviewed by harrison

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [11484] by hyatt
  • 2 edits in trunk/WebCore

Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects that
have corresponding DOM elements.

Reviewed by Eric Seidel

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
2:31 AM Changeset in webkit [11483] by eseidel
  • 1 edit
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.

Removing unused files.

  • kcanvas/KCanvasRegistry.cpp: Removed.
  • kcanvas/KCanvasRegistry.h: Removed.

Dec 6, 2005:

5:16 PM Changeset in webkit [11482] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Removed change marker.

5:12 PM Changeset in webkit [11481] by hyatt
  • 16 edits in trunk/WebCore

Add support for more methods for exposing more useful style information.

getMatchedCSSRules can be used to obtain the matched sheet rules for an element. In Obj-C
it will also include user/user agent sheet rules.

Also add support for tracking the original shorthand in which a property was declared, as well
as whether the property was just implicitly set rather than explicitly mentioned (e.g., if it was
an omitted piece of a shorthand). The new methods on CSSStyleDeclaration are getPropertyShorthand
and isPropertyImplicit.

Reviewed by mjs

Test: fast/inspector/style.html

  • khtml/css/css_computedstyle.h: (DOM::CSSComputedStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSComputedStyleDeclarationImpl::isPropertyImplicit):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): (DOM::CSSMutableStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSMutableStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSProperty::cssText): (DOM::operator==):
  • khtml/css/css_valueimpl.h: (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::shorthandID): (DOM::CSSProperty::isImportant): (DOM::CSSProperty::isImplicit):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::addProperty): (CSSParser::parseValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseShorthand): (CSSParser::parse4Values): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty):
  • khtml/css/cssparser.h: (DOM::CSSParser::enterShorthand): (DOM::CSSParser::exitShorthand): (DOM::CSSParser::inShorthand):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleDeclaration::):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
  • khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
  • khtml/xml/dom2_viewsimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration getPropertyShorthand:]): (-[DOMCSSStyleDeclaration isPropertyImplicit:]): (-[DOMDocument getMatchedCSSRules::]):
  • kwq/DOMPrivate.h:
5:11 PM Changeset in webkit [11480] by hyatt
  • 3 adds in trunk/LayoutTests/fast/inspector

Land layout test for style inspection.

3:34 PM Changeset in webkit [11479]
  • 55 copies
    22 deletes in tags/WebKit-417~7

This commit was manufactured by cvs2svn to create tag 'WebKit-417~7'.

3:34 PM Changeset in webkit [11478]
  • 211 copies
    17 deletes in tags/WebCore-417~10

This commit was manufactured by cvs2svn to create tag
'WebCore-417~10'.

3:34 PM Changeset in webkit [11477] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning to WebKit-417.7 and WebCore-417.10

2:12 PM Changeset in webkit [11476] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
2:06 PM Changeset in webkit [11475] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
1:54 PM Changeset in webkit [11474] by sullivan
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog: Remove special-case handling for nib files. This avoided trouble with cvs diff when we were using wrappers for nib files. Now that we aren't using wrappers, there's no reason to avoid adding the modified nib files to the file list that gets diffed.
11:38 AM Changeset in webkit [11473] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fix build when using gcc 4
  • kjs/ustring.h: Make Rep public.
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator): Fix a typo.
1:21 AM Changeset in webkit [11472] by mjs
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • cleaned up UString a little so that it doesn't need to have so many friend classes
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kjs/identifier.h: (KJS::Identifier::Identifier): (KJS::Identifier::equal):
  • kjs/property_map.cpp: (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::remove):
  • kjs/ustring.cpp: (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::substr): (KJS::UString::copyForWriting): (KJS::operator==):
  • kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString): (KJS::UString::data): (KJS::UString::isNull): (KJS::UString::isEmpty): (KJS::UString::size): (KJS::UString::rep):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::operator*): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):

WebCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
Note: See TracTimeline for information about the timeline view.