Context Navigation

← Previous Period
Next Period →

Timeline

Dec 14, 2005:

8:51 PM Changeset in webkit [11590] by adele

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Adele Peterson <adele@apple.com>

Reviewed by Darin and Tim Hatcher.

fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

kwq/KWQScrollView.h: Added scrollPointRecursively.
kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

8:29 PM Changeset in webkit [11589] by adele

4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

kwq/KWQScrollView.h: Added scrollPointRecursively.
kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

3:32 PM Changeset in webkit [11588] by eseidel

46 edits
4 deletes in trunk/WebCore

Bug #: 6078
Submitted by: eseidel
Reviewed by: darin

SVG test cases changed (now the svg.css is loaded properly).
No other functionality changes, just code removal.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6078

ForwardingHeaders/klibloader.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/css/csshelper.cpp:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle):
khtml/css/cssstyleselector.h:
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::eventParameterName): (KJS::JSLazyEventListener::parseCode):
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::implementsCall):
khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::PluginBase):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
khtml/ecma/kjs_proxy.h: (KJSProxyImpl::setEventHandlerLineno):
khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
khtml/ecma/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieve): (KJS::Window::clear): (KJS::ScheduledAction::execute):
khtml/ecma/kjs_window.h:
khtml/html/html_canvasimpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData):
khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::evaluateScript):
khtml/html/html_imageimpl.cpp:
khtml/html/html_tableimpl.cpp:
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::processToken):
khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::jScript): (KHTMLPart::executeScript): (KHTMLPart::write): (KHTMLPart::reparseConfiguration): (KHTMLPart::createHTMLEventListener):
khtml/khtml_part.h:
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/misc/decoder.cpp:
khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript):
khtml/rendering/render_flow.cpp:
khtml/rendering/render_frames.cpp:
khtml/rendering/render_inline.cpp:
khtml/rendering/render_line.cpp:
khtml/rendering/render_table.cpp:
khtml/rendering/table_layout.cpp:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitOpen): (DocumentImpl::write):
khtml/xml/dom_nodeimpl.cpp:
ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid):
kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
kwq/KWQKGlobal.h:
kwq/KWQKHTMLFactory.h: (KHTMLFactory::vLinks):
kwq/KWQKHTMLFactory.mm:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::userGestureHint): (KWQKHTMLPart::bindingRootObject):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::fantasyFontName): (KHTMLSettings::isJavaScriptEnabled):
kwq/KWQKInstance.h: Removed.
kwq/KWQKLibrary.h: Removed.
kwq/KWQKPartsFactory.h: Removed.
kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::name):
kwq/KWQKStandardDirs.h:
kwq/KWQKStandardDirs.mm: (locate):
kwq/WebCoreBridge.mm: (-[WebCoreBridge executionContextForView:]):

2:49 PM Changeset in webkit [11587] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.

2:45 PM Changeset in webkit [11586] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.

2:39 PM Changeset in webkit [11585] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:21 PM Changeset in webkit [11584] by bdakin

3 edits
4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:46 AM Changeset in webkit [11583] by adele

3 edits
4 adds in trunk

LayoutTests:

Layout test for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

fast/overflow/overflow-text-hit-testing-expected.checksum: Added.
fast/overflow/overflow-text-hit-testing-expected.png: Added.
fast/overflow/overflow-text-hit-testing-expected.txt: Added.
fast/overflow/overflow-text-hit-testing.html: Added.

WebCore:

Reviewed by Darin & Geoff, committed by Adele.

Test: fast/overflow/overflow-text-hit-testing.html

Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Adjust for containing block scroll

10:19 AM Changeset in webkit [11582] by adele

2 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4362
Add mac-cyrillic to the list of encodings

kwq/mac-encodings.txt: Added maccyrillic

Dec 13, 2005:

11:48 PM Changeset in webkit [11581] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

fast/forms/checkbox-radio-onchange-expected.checksum: Added.
fast/forms/checkbox-radio-onchange-expected.png: Added.
fast/forms/checkbox-radio-onchange-expected.txt: Added.
fast/forms/checkbox-radio-onchange.html: Added.

WebCore:

Reviewed by Maciej.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

Test: fast/forms/checkbox-radio-onchange.html

khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state. This will match our old behavior, and Firefox behavior. This will also fire onChange for radio buttons which matches Firefox behavior.

10:16 PM Changeset in webkit [11580] by mjs

3 edits in trunk/WebKit

Reviewed by Darin.

remove the dead _frameForDataSource: method (WebDataSource now knows its WebFrame) http://bugzilla.opendarwin.org/show_bug.cgi?id=6072

WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:

6:22 PM Changeset in webkit [11579] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

5:14 PM Changeset in webkit [11578]

5 copies in tags/Safari-521~5

This commit was manufactured by cvs2svn to create tag 'Safari-521~5'.

5:14 PM Changeset in webkit [11577] by thatcher

3 edits in trunk

Adding release markers.

5:12 PM Changeset in webkit [12222] by thatcher

1 edit in trunk/JavaScriptGlue/ChangeLog

Adding release markers.

5:00 PM Changeset in webkit [12221] by ggaren

3 edits in trunk/JavaScriptGlue

Fixed build after Anders's last checkin to JavaScriptCore.

Reviewed by darin.

UserObjectImp.cpp: (UserObjectImp::userObjectGetter): Updated to reflect new argument that getters take (unused here).
UserObjectImp.h:

4:40 PM Changeset in webkit [11576] by thatcher

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS shorthand serialization.

fast/dom/css-shortHands-expected.checksum: Added.
fast/dom/css-shortHands-expected.png: Added.
fast/dom/css-shortHands-expected.txt: Added.
fast/dom/css-shortHands.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-shortHands.html

First cut at leaving off implicit values in shorthand properties.
Need to account for multipl backgrounds and "border" later.

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue):

3:29 PM Changeset in webkit [11575] by thatcher

3 edits in branches/Safari-Leo-branch

Versioning

2:05 PM Changeset in webkit [11574] by ggaren

2 edits in trunk/JavaScriptCore

Updated test results to match Anders's last fix.

tests/mozilla/expected.html:

1:42 PM Changeset in webkit [11573] by andersca

1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-13 Anders Carlsson <andersca@mac.com>

ChangeLog: Add titles to the recent bugzilla bugs.

1:38 PM Changeset in webkit [11572] by andersca

1 edit in trunk/JavaScriptCore/ChangeLog

Correct a date.

1:37 PM Changeset in webkit [11571] by andersca

1 edit in trunk/JavaScriptCore/ChangeLog

2005-12-13 Anders Carlsson <andersca@mac.com>

ChangeLog: Add titles for my bugzilla bugs.

1:37 PM Changeset in webkit [11570] by andersca

1 edit
2 adds in trunk/LayoutTests

2005-12-13 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6041 Support property getters and setters.

fast/js/property-getters-and-setters-expected.txt: Added.
fast/js/property-getters-and-setters.html: Added.

ChangeLog: Add titles for the bugzilla urls.

1:29 PM Changeset in webkit [11569] by andersca

10 edits in trunk/WebCore

2005-12-13 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMMediaList::indexGetter): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSValueList::indexGetter):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMElement::attributeGetter): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::formNameGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::HTMLCollection::lengthGetter): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::nameGetter): (KJS::HTMLSelectCollection::selectedIndexGetter):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::indexGetter): (KJS::Plugins::nameGetter): (KJS::MimeTypes::indexGetter): (KJS::MimeTypes::nameGetter): (KJS::Plugin::indexGetter): (KJS::Plugin::nameGetter):
khtml/ecma/kjs_window.cpp: (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
khtml/ecma/kjs_window.h: Update for changes to PropertySlot::GetValueFunc.

1:26 PM Changeset in webkit [11568] by eseidel

1 edit
12 adds in trunk/LayoutTests

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

3 tests checking expected behavior for bad transform.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

svg/custom/transform-ignore-after-invalid-expected.checksum: Added.
svg/custom/transform-ignore-after-invalid-expected.png: Added.
svg/custom/transform-ignore-after-invalid-expected.txt: Added.
svg/custom/transform-ignore-after-invalid.svg: Added.
svg/custom/transform-invalid-expected.checksum: Added.
svg/custom/transform-invalid-expected.png: Added.
svg/custom/transform-invalid-expected.txt: Added.
svg/custom/transform-invalid.svg: Added.
svg/custom/transform-with-ending-space-expected.checksum: Added.
svg/custom/transform-with-ending-space-expected.png: Added.
svg/custom/transform-with-ending-space-expected.txt: Added.
svg/custom/transform-with-ending-space.svg: Added.

1:25 PM Changeset in webkit [11567] by eseidel

2 edits in trunk/WebCore

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

Fix crash on malformed transform attributes and transforms with
trailing spaces:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):

1:24 PM Changeset in webkit [11566] by andersca

27 edits in trunk/JavaScriptCore

2005-12-12 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=6041>

bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter):
bindings/runtime_array.h:
bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter):
bindings/runtime_object.h:
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::lengthGetter): (getProperty): Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.

kjs/collector.cpp: (KJS::className): Handle GetterSetterType.

kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter):
kjs/function.h: Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.

kjs/grammar.y: Rework grammar parts for get set declarations directly in the object literal.

kjs/internal.cpp: (KJS::GetterSetterImp::mark): (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean): (KJS::GetterSetterImp::toNumber): (KJS::GetterSetterImp::toString): (KJS::GetterSetterImp::toObject): Add type conversion functions. These aren't meant to be called.

(KJS::printInfo):
Handle GetterSetterType.

kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter): Update for changes to PropertySlot::GetValueFunc.

kjs/nodes.cpp: Refactor they way properties nodes are implemented. We now have a PropertyListNode which is a list of PropertyNodes. Each PropertyNode has a name (which is a PropertyNameNode) and an associated value node. PropertyNodes can be of different types. The Constant type is the old constant declaration and the Getter and Setter types are for property getters and setters. (ResolveNode::evaluate): Update for changes to PropertySlot::getValue.

(PropertyListNode::evaluate):
Go through all property nodes and set them on the newly created object. If the
property nodes are of type Getter or Setter, define getters and setters. Otherwise,
just add the properties like before.

(PropertyNode::evaluate):
This should never be called directly.

(PropertyNameNode::evaluate):
Rename from PropertyNode::evaluate.

(FunctionCallResolveNode::evaluate):
(FunctionCallBracketNode::evaluate):
(FunctionCallDotNode::evaluate):
(PostfixResolveNode::evaluate):
(PostfixBracketNode::evaluate):
(PostfixDotNode::evaluate):
(TypeOfResolveNode::evaluate):
(PrefixResolveNode::evaluate):
(PrefixBracketNode::evaluate):
(PrefixDotNode::evaluate):
(AssignResolveNode::evaluate):
(AssignDotNode::evaluate):
(AssignBracketNode::evaluate):
Update for changes to PropertySlot::getValue.

kjs/nodes.h: (KJS::PropertyNameNode::PropertyNameNode): Rename from PropertyNode.

(KJS::PropertyNode::):
(KJS::PropertyNode::PropertyNode):
New class, representing a single property.

(KJS::PropertyListNode::PropertyListNode):
Rename from PropertyValueNode.

(KJS::FuncExprNode::FuncExprNode):
Put ParameterNode parameter last, and make it optional.

(KJS::ObjectLiteralNode::ObjectLiteralNode):
Use a PropertyListNode here now.

kjs/nodes2string.cpp: (PropertyListNode::streamTo): Iterate through all property nodes.

(PropertyNode::streamTo):
Print out the name and value. Doesn't handle getters and setters currently.

(PropertyNameNode::streamTo):
Rename from PropertyNode::streamTo.

kjs/object.cpp: (KJS::JSObject::get): Update for changes to PropertySlot::getValue.

(KJS::JSObject::put):
If the property already exists and has a Setter, invoke
the setter function instead of setting the property directly.

(KJS::JSObject::defineGetter):
(KJS::JSObject::defineSetter):
New functions for defining property getters and setters on the object.

kjs/object.h: (KJS::GetterSetterImp::type): (KJS::GetterSetterImp::GetterSetterImp): (KJS::GetterSetterImp::getGetter): (KJS::GetterSetterImp::setGetter): (KJS::GetterSetterImp::getSetter): (KJS::GetterSetterImp::setSetter): New class for properties which have getters and setters defined. This class is only used internally and should never be seen from the outside.

(KJS::JSObject::getOwnPropertySlot):

If the property is a getter, call setGetterSlot on the property slot.

kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add defineGetter, defineSetter, lookupGetter, lookupSetter to prototype.

(ObjectProtoFunc::callAsFunction):
Implement handlers for new functions.

kjs/object_object.h: (KJS::ObjectProtoFunc::): Add ids for new functions.

kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): Update for changes to PropertySlot::GetValueFunc.

(KJS::PropertySlot::functionGetter):
Call the function getter object and return its value.

kjs/property_slot.h: (KJS::PropertySlot::getValue): Add a new argument which is the original object that getPropertySlot was called on.

(KJS::PropertySlot::setGetterSlot):
(KJS::PropertySlot::):
New function which sets a getter slot. When getValue is called on a
getter slot, the getter function object is invoked.

kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter):
kjs/string_object.h: Update for changes to PropertySlot::GetValueFunc.

kjs/value.h: (KJS::): Add GetterSetterType and make GetterSetterImp a friend class of JSCell.

1:12 PM Changeset in webkit [11565]

56 copies
22 deletes in tags/WebKit-417~9

This commit was manufactured by cvs2svn to create tag 'WebKit-417~9'.

1:12 PM Changeset in webkit [11564]

211 copies
17 deletes in tags/WebCore-417~12

This commit was manufactured by cvs2svn to create tag
'WebCore-417~12'.

1:12 PM Changeset in webkit [11563] by thatcher

4 edits in branches/Safari-2-0-branch

Versioning:
WebCore-417.12
WebKit-417.9

3:46 AM Changeset in webkit [11562] by mjs

2 edits in trunk/WebCore

build fix for last-minute part of previous change

khtml/ecma/kjs_binding.cpp:

3:06 AM Changeset in webkit [11561] by mjs

11 edits
2 adds
2 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

added a new HashCountedSet class for the common pattern of mapping items to counts that can change

kxmlcore/HashCountedSet.h: Added. (KXMLCore::HashCountedSet::*): Implemented, on top of HashMap.
kxmlcore/HashMap.h: (KXMLCore::HashMap::add): New method - does not replace existing value if key already present but otherwise like set(). (KXMLCore::HashMap::set): Improved comments.
kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap::add): Added to specializations too.
JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
kxmlcore/HashFunctions.h: Added include of stdint.h

replaced the custom hashtable for values protected from GC with HashCountedSet

kjs/collector.cpp: (KJS::Collector::protect): Moved code here from ProtectedValues::increaseProtectCount since the code is so simple now. (KJS::Collector::unprotect): Ditto for ProtectedValues::decreaseProtectCount. (KJS::Collector::markProtectedObjects): Updated for new way of doing things, now simpler and safer. (KJS::Collector::numReferencedObjects): ditto (KJS::Collector::rootObjectClasses): ditto
kjs/collector.h: Added protect and unprotect static methods
kjs/protect.h: (KJS::gcProtect): Updated for removal of ProtectedValues class (KJS::gcUnprotect): likewise
kjs/protected_values.cpp: Removed.
kjs/protected_values.h: Removed.

WebCore:

Reviewed by Eric.

updated for new HashCountedSet class

ForwardingHeaders/kxmlcore/HashCountedSet.h: Added forwarding header.
khtml/ecma/kjs_binding.cpp: Moved #define to disable pointer specialization higher in the file.

3:04 AM Changeset in webkit [12220] by mjs

1 edit
1 add in trunk/JavaScriptGlue

Reviewed by Eric.

added forwarding header for HashCountedSet

kxmlcore/HashCountedSet.h: Added.

Dec 12, 2005:

8:39 PM Changeset in webkit [11560] by thatcher

3 edits in trunk/WebKit

Revised fix.

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with GCC 3.3.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):

6:01 PM Changeset in webkit [11559] by thatcher

4 edits in trunk/WebKit

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with 3.3.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
WebCoreSupport.subproj/WebImageRenderer.h: Added missing methods for image and imageRef.
WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):

5:50 PM Changeset in webkit [11558] by justing

1 edit
4 adds in trunk/LayoutTests

Reviewed by harrison

editing/selection/previous-line-position-expected.checksum: Added.
editing/selection/previous-line-position-expected.png: Added.
editing/selection/previous-line-position-expected.txt: Added.
editing/selection/previous-line-position.html: Added.

5:50 PM Changeset in webkit [11557] by justing

2 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original

This bug was filed as a reminder to remove the workaround for
<rdar://problem/4033202>. We fixed the problems with
VisiblePosition causing 4033202, so I removed the workaround
and added a layout test.

khtml/editing/visible_units.cpp: (khtml::previousLinePosition):

5:36 PM Changeset in webkit [11556] by harrison

2 edits
8 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure
<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

editing/pasteboard/block-wrappers-necessary.html:

Removed empty p tag.

editing/pasteboard/paste-list-001-expected.checksum: Added.
editing/pasteboard/paste-list-001-expected.png: Added.
editing/pasteboard/paste-list-001-expected.txt: Added.
editing/pasteboard/paste-list-001.html: Added.
editing/pasteboard/paste-table-001-expected.checksum: Added.
editing/pasteboard/paste-table-001-expected.png: Added.
editing/pasteboard/paste-table-001-expected.txt: Added.
editing/pasteboard/paste-table-001.html: Added.

5:28 PM Changeset in webkit [11555] by harrison

3 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

Fixed by having ReplaceSelectionCommand remove empty nodes just
from the ancestors of the node(s) moved by mergeStart, rather
than scanning the whole fragment.

Layout tests added:

editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-list-001.html

khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::isProbablyTableStructureNode): (khtml::ReplaceSelectionCommand::pruneEmptyNodes): Removed no longer needed functions.

(khtml::ReplaceSelectionCommand::doApply):
Remove ancestor nodes emptied by mergeStart.
Do that instead of calling pruneEmptyNodes().

khtml/editing/replace_selection_command.h: (khtml::ReplacementFragment::desiredStyles): Removed pruneEmptyNodes().

4:35 PM Changeset in webkit [11554] by thatcher

2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-12-06 David Harrison <harrison@apple.com>

Reviewed by Darin.

fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.

4:21 PM Changeset in webkit [11553] by thatcher

6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 Adele Peterson <adele@apple.com>

Reviewed by Tim Hatcher.

fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
khtml/xml/dom_elementimpl.h: Added focus and blur.
khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.

4:12 PM Changeset in webkit [11552] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 David Harrison <harrison@apple.com>

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

4:05 PM Changeset in webkit [11551] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Adele Peterson <adele@apple.com>

Reviewed by Dave Harrison.

fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):

3:54 PM Changeset in webkit [11550] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-09 Tim Omernick <timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

kwq/KWQScrollView.mm: (QScrollView::setContentsPos):

3:53 PM Changeset in webkit [11549] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

kwq/KWQScrollView.mm: (QScrollView::setContentsPos):

3:49 PM Changeset in webkit [11548] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):

3:48 PM Changeset in webkit [11547] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-12 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):

3:22 PM Changeset in webkit [11546] by thatcher

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <timo@apple.com>

Reviewed by John Sullivan.

Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
-performSelector:withObject:'s return value should only be checked if the method returns an object.

Carbon.subproj/HIWebView.m: (UpdateCommandStatus):

2:22 PM Changeset in webkit [11545] by thatcher

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS seletorText serialization.

fast/dom/css-selectorText-expected.checksum: Added.
fast/dom/css-selectorText-expected.png: Added.
fast/dom/css-selectorText-expected.txt: Added.
fast/dom/css-selectorText.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-selectorText.html

Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):

1:01 PM Changeset in webkit [11544] by sullivan

2 edits in trunk/WebKit

Reviewed and checked in by John Sullivan.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6053
WebIconDatabase returns the Accessibility Verifier app icon instead of
a generic document icon

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): use file type iconForFileType:NSFileTypeForHFSTypeCode(kGenericDocumentIcon) instead of '????' to get the generic document icon.

11:42 AM Changeset in webkit [11543] by sullivan

7 edits in trunk/WebKit

Reviewed by Tim Omernick.

Made protocol <WebDocumentSelection> include protocol <WebDocumentText>, for clarity. This required moving some methods from WebTextView, which conformed to <WebDocumentText>, up into superclass WebSearchableTextView, which conformed to <WebDocumentSelection>.

Misc.subproj/WebSearchableTextView.m: (-[NSString supportsTextEncoding]): moved this method (unchanged) from subclass WebTextView (-[NSString string]): ditto (-[NSString attributedString]): ditto (-[NSString selectedString]): ditto (-[NSString selectedAttributedString]): ditto (-[NSString selectAll]): ditto (-[NSString deselectAll]): ditto

WebView.subproj/WebDocumentPrivate.h: made <WebDocumentSelection> incorporate <WebDocumentText> rather than just <NSObject>
WebView.subproj/WebHTMLView.h: removed <WebDocumentText> from protocol list since it's covered by <WebDocumentSelection>
WebView.subproj/WebPDFView.h: ditto
WebView.subproj/WebTextView.h: ditto
WebView.subproj/WebTextView.m: removed the methods that were moved into WebSearchableTextView.m

11:22 AM Changeset in webkit [11542] by eseidel

2 edits in trunk/WebCore

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):

11:20 AM Changeset in webkit [11541] by eseidel

1 edit
4 adds in trunk/LayoutTests

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

11:07 AM Changeset in webkit [11540] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrison.

fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):

11:04 AM Changeset in webkit [11539] by adele

2 edits in trunk/WebCore

Reviewed by Dave Harrison.

fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):

9:40 AM Changeset in webkit [11538] by eseidel

1 edit
4 adds in trunk/LayoutTests

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

"S" and "T" path types handle control points incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

svg/custom/control-points-for-S-and-T-expected.checksum: Added.
svg/custom/control-points-for-S-and-T-expected.png: Added.
svg/custom/control-points-for-S-and-T-expected.txt: Added.
svg/custom/control-points-for-S-and-T.svg: Added.

9:37 AM Changeset in webkit [11537] by eseidel

2 edits in trunk/WebCore

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

Test: svg/custom/control-points-for-S-and-T.svg

"S" and "T" path types handle control points incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):

9:25 AM Changeset in webkit [11536] by eseidel

4 edits in trunk/WebCore

Bug #: 6039
Submitted by: eseidel
Reviewed by: darin

No test cases needed, no functionality change.
Corrected spacing, and conformance with style guidelines.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6039

kcanvas/KCanvasFilters.cpp:
kcanvas/KCanvasFilters.h: (KCanvasFEComponentTransfer::setRedFunction): (KCanvasFEComponentTransfer::setGreenFunction): (KCanvasFEComponentTransfer::setBlueFunction): (KCanvasFEComponentTransfer::setAlphaFunction):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector): (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): (KCanvasFilterQuartz::filterBBoxForItemBBox): (KCanvasFilterQuartz::getCIFilterStack): (KCanvasFilterQuartz::imageForName): (KCanvasFilterQuartz::setImageForName): (KCanvasFilterQuartz::setOutputImage): (alphaImageForImage): (KCanvasFilterQuartz::inputImage): (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEGaussianBlurQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFEOffsetQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter): (KCanvasFETileQuartz::getCIFilter):

9:01 AM Changeset in webkit [11535] by darin

3 edits
5 adds in trunk

LayoutTests:

Reviewed by Eric.

Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5538

fast/xsl/resources/xslt-entity.xsl: Added.
fast/xsl/xslt-entity-expected.checksum: Added.
fast/xsl/xslt-entity-expected.png: Added.
fast/xsl/xslt-entity-expected.txt: Added.
fast/xsl/xslt-entity.xml: Added.

WebCore:

Reviewed by Eric.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5538 XSLT crashes with multi-word internal entity declarations

Added the crashing specimen as a layout test.

khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets): Check that the node is an element node before calling IS_XSLT_ELEM.

Dec 11, 2005:

8:23 PM Changeset in webkit [11534] by eseidel

1 edit
6 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none

Adding pixel results omitted from previous commits.

fast/block/positioning/leftmargin-topmargin-expected.checksum: Added.
fast/block/positioning/leftmargin-topmargin-expected.png: Added.
fast/clip/017-expected.checksum: Added.
fast/clip/017-expected.png: Added.
fast/inspector/style-expected.checksum: Added.
fast/inspector/style-expected.png: Added.

8:15 PM Changeset in webkit [11533] by eseidel

1 edit
3 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Adding resources overlooked in previous commit.

fast/xsl/resources/xslt-extra-content-at-end.xsl: Added.
fast/xsl/resources/xslt-mismatched-tags-in-xslt.xsl: Added.
fast/xsl/resources/xslt-missing-namespace-in-xslt.xsl: Added.

3:47 AM Changeset in webkit [11532] by eseidel

1 edit
28 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

fast/invalid/junk-data-expected.checksum: Added.
fast/invalid/junk-data-expected.png: Added.
fast/invalid/junk-data-expected.txt: Added.
fast/invalid/junk-data.xml: Added.
fast/invalid/missing-end-tag-expected.checksum: Added.
fast/invalid/missing-end-tag-expected.png: Added.
fast/invalid/missing-end-tag-expected.txt: Added.
fast/invalid/missing-end-tag.xhtml: Added.
fast/xsl/xslt-extra-content-at-end-expected.checksum: Added.
fast/xsl/xslt-extra-content-at-end-expected.png: Added.
fast/xsl/xslt-extra-content-at-end-expected.txt: Added.
fast/xsl/xslt-extra-content-at-end.xml: Added.
fast/xsl/xslt-mismatched-tags-in-xslt-expected.checksum: Added.
fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Added.
fast/xsl/xslt-mismatched-tags-in-xslt.xml: Added.
fast/xsl/xslt-missing-namespace-in-xslt-expected.checksum: Added.
fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Added.
fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
fast/xsl/xslt-missing-namespace-in-xslt.xml: Added.
svg/custom/junk-data-expected.checksum: Added.
svg/custom/junk-data-expected.png: Added.
svg/custom/junk-data-expected.txt: Added.
svg/custom/junk-data.svg: Added.
svg/custom/missing-xlink-expected.checksum: Added.
svg/custom/missing-xlink-expected.png: Added.
svg/custom/missing-xlink-expected.txt: Added.
svg/custom/missing-xlink.svg: Added.

3:42 AM Changeset in webkit [11531] by eseidel

4 edits in trunk/WebCore

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

khtml/xml/xml_tokenizer.cpp: (khtml::createXHTMLParserErrorHeader): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts):
ksvg2/svg/SVGStyledElementImpl.h: removed broken code
ksvg2/svg/SVGStyledElementImpl.cpp: removed broken attach()

1:28 AM Changeset in webkit [11530] by eseidel

2 edits
4 adds in trunk/LayoutTests

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

svg/custom/conditional-processing-outside-switch-expected.checksum: Added.
svg/custom/conditional-processing-outside-switch-expected.png: Added.
svg/custom/conditional-processing-outside-switch-expected.txt: Added.
svg/custom/conditional-processing-outside-switch.svg: Added.
svg/custom/simpleCDF-expected.txt:

1:26 AM Changeset in webkit [11529] by eseidel

24 edits in trunk/WebCore

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

One test case added for conditional processing directives
used outside of switch statements.

WebCore+SVG/DrawDocument.mm: (-[DrawView description]):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEGaussianBlurQuartz::getCIFilter):
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssparser.h:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::applyProperty):
khtml/css/cssstyleselector.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive):
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
khtml/khtml_part.h:
khtml/rendering/DataRef.h: (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
khtml/rendering/render_canvas.cpp:
khtml/rendering/render_object.h: (khtml::RenderObject::localTransform):
khtml/rendering/render_style.cpp: (RenderStyle::diff):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): (DocumentImpl::createEvent):
khtml/xml/dom_elementimpl.cpp:
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue):
ksvg2/css/svg.css:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::childShouldCreateRenderer):
ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isValid):

Dec 10, 2005:

11:28 PM Changeset in webkit [11528] by mjs

2 edits in trunk/WebCore

Not reviewed, build fix.

fix SVG build for recent QTimer changes.

ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::SVGTimer):

6:06 PM Changeset in webkit [11527] by darin

134 edits in trunk

JavaScriptCore:

Rubber stamped by Maciej.

did long-promised KJS renaming:

ValueImp -> JSValue
ObjectImp -> JSObject
AllocatedValueImp -> JSCell

A renaming to get a class out of the way

KJS::Bindings::JSObject -> JavaJSObject

and some other "imp-reduction" renaming

*InstanceImp -> *Instance
*ProtoFuncImp -> *ProtoFunc
*PrototypeImp -> *Prototype
ArgumentsImp -> Arguments
RuntimeArrayImp -> RuntimeArray
RuntimeMethodImp -> RuntimeMethod

most files and functions

WebCore:

Rubber stamped by Maciej.

updated for KJS class renaming

many files and functions

6:03 PM Changeset in webkit [12219] by darin

10 edits in trunk/JavaScriptGlue

Rubber stamped by Maciej.

updated for KJS class renaming

many files and functions

5:44 PM Changeset in webkit [11526] by mjs

2 edits in trunk/WebCore

Reviewed by Darin and Eric.

Makefile.am: Support --enable-svg

4:38 PM Changeset in webkit [11525] by darin

53 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

bindings/NP_jsobject.cpp: (_NPN_Evaluate):
bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
bindings/c/c_runtime.cpp: (CField::valueFromInstance):
bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
bindings/jni/jni_jsobject.cpp: (JSObject::eval): (JSObject::convertJObjectToValue):
bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::valueAt):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]):
bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcFallbackObjectImp::callAsFunction):
bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): (KJS::Bindings::convertObjcValueToValue):
bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::valueOf):
bindings/runtime_array.cpp: (RuntimeArrayImp::lengthGetter):
bindings/runtime_method.cpp: (RuntimeMethodImp::lengthGetter): (RuntimeMethodImp::callAsFunction): (RuntimeMethodImp::execute):
kjs/array_object.cpp: (ArrayInstanceImp::lengthGetter): (CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (ArrayPrototypeImp::ArrayPrototypeImp): (ArrayProtoFuncImp::ArrayProtoFuncImp): (ArrayProtoFuncImp::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
kjs/bool_object.cpp: (BooleanPrototypeImp::BooleanPrototypeImp): (BooleanProtoFuncImp::callAsFunction): (BooleanObjectImp::BooleanObjectImp): (BooleanObjectImp::callAsFunction):
kjs/error_object.cpp: (ErrorPrototypeImp::ErrorPrototypeImp): (ErrorProtoFuncImp::ErrorProtoFuncImp): (ErrorProtoFuncImp::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (NativeErrorImp::NativeErrorImp):
kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::DeclaredFunctionImp::execute): (KJS::encode): (KJS::decode): (KJS::GlobalFuncImp::callAsFunction):
kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): (FunctionPrototypeImp::callAsFunction): (FunctionProtoFuncImp::callAsFunction): (FunctionObjectImp::FunctionObjectImp):
kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
kjs/interpreter.h:
kjs/lookup.h:
kjs/math_object.cpp: (MathObjectImp::getValueProperty): (MathFuncImp::callAsFunction):
kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): (NullNode::evaluate): (PropertyNode::evaluate): (FunctionCallBracketNode::evaluate): (FunctionCallDotNode::evaluate): (PostfixBracketNode::evaluate): (PostfixDotNode::evaluate): (VoidNode::evaluate): (PrefixBracketNode::evaluate): (PrefixDotNode::evaluate): (ShiftNode::evaluate): (valueForReadModifyAssignment): (AssignDotNode::evaluate): (AssignBracketNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (VarDeclListNode::evaluate): (ReturnNode::execute): (CaseClauseNode::evalStatements): (ParameterNode::evaluate): (FuncDeclNode::processFuncDecl):
kjs/nodes.h: (KJS::StatementNode::evaluate):
kjs/number_object.cpp: (NumberPrototypeImp::NumberPrototypeImp): (NumberProtoFuncImp::callAsFunction): (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getValueProperty): (NumberObjectImp::callAsFunction):
kjs/object.cpp: (KJS::ObjectImp::get): (KJS::Error::create):
kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction): (ObjectObjectImp::ObjectObjectImp):
kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter):
kjs/regexp_object.cpp: (RegExpPrototypeImp::RegExpPrototypeImp): (RegExpProtoFuncImp::callAsFunction): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::construct):
kjs/string_object.cpp: (StringInstanceImp::StringInstanceImp): (StringPrototypeImp::StringPrototypeImp): (replace): (StringProtoFuncImp::callAsFunction): (StringObjectImp::StringObjectImp): (StringObjectImp::callAsFunction): (StringObjectFuncImp::StringObjectFuncImp): (StringObjectFuncImp::callAsFunction):
kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (VersionFunctionImp::callAsFunction):
kjs/value.h:

WebCore:

Reviewed by Maciej.

eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrNull): (KJS::setDOMException):
khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheet::getValueProperty): (KJS::getDOMStyleSheet): (KJS::DOMStyleSheetList::getValueProperty): (KJS::getDOMStyleSheetList): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMMediaList::getValueProperty): (KJS::DOMMediaList::indexGetter): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRuleList::getValueProperty): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::CSSRuleConstructor::getValueProperty): (KJS::DOMCSSValue::getValueProperty): (KJS::getDOMCSSValue): (KJS::CSSValueConstructor::getValueProperty): (KJS::DOMCSSPrimitiveValue::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::CSSPrimitiveValueConstructor::getValueProperty): (KJS::DOMCSSValueList::getValueProperty): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMCounter::getValueProperty):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::callAsFunction): (KJS::DOMAttr::getValueProperty): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::attributeGetter): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::DOMDOMImplementationProtoFunc::callAsFunction): (KJS::DOMDocumentType::getValueProperty): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMProcessingInstruction::getValueProperty): (KJS::DOMNotation::getValueProperty): (KJS::DOMEntity::getValueProperty): (KJS::getDOMNode): (KJS::NodeConstructor::getValueProperty): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMCharacterData::getValueProperty): (KJS::DOMCharacterDataProtoFunc::callAsFunction): (KJS::DOMTextProtoFunc::callAsFunction):
khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::EventConstructor::getValueProperty): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::getDOMEvent): (KJS::EventExceptionConstructor::getValueProperty): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::MutationEventConstructor::getValueProperty): (KJS::DOMMutationEvent::getValueProperty): (KJS::DOMMutationEventProtoFunc::callAsFunction): (KJS::DOMWheelEvent::getValueProperty): (KJS::DOMWheelEventProtoFunc::callAsFunction): (KJS::stringOrUndefined): (KJS::Clipboard::getValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::htmlGetter): (KJS::HTMLElement::headGetter): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::titleGetter): (KJS::HTMLElement::metaGetter): (KJS::HTMLElement::baseGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::formGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optGroupGetter): (KJS::HTMLElement::optionGetter): (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::uListGetter): (KJS::HTMLElement::oListGetter): (KJS::HTMLElement::dListGetter): (KJS::HTMLElement::dirGetter): (KJS::HTMLElement::menuGetter): (KJS::HTMLElement::liGetter): (KJS::HTMLElement::divGetter): (KJS::HTMLElement::paragraphGetter): (KJS::HTMLElement::headingGetter): (KJS::HTMLElement::blockQuoteGetter): (KJS::HTMLElement::quoteGetter): (KJS::HTMLElement::preGetter): (KJS::HTMLElement::brGetter): (KJS::HTMLElement::baseFontGetter): (KJS::HTMLElement::fontGetter): (KJS::HTMLElement::hrGetter): (KJS::HTMLElement::modGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::imageGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::paramGetter): (KJS::HTMLElement::appletGetter): (KJS::HTMLElement::mapGetter): (KJS::HTMLElement::areaGetter): (KJS::HTMLElement::scriptGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::tableCaptionGetter): (KJS::HTMLElement::tableColGetter): (KJS::HTMLElement::tableSectionGetter): (KJS::HTMLElement::tableRowGetter): (KJS::HTMLElement::tableCellGetter): (KJS::HTMLElement::frameSetGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::marqueeGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLCollection::lengthGetter): (KJS::KJS::HTMLCollection::callAsFunction): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::selectedIndexGetter): (KJS::HTMLSelectCollection::getOwnPropertySlot): (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::Image::getValueProperty): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::getValueProperty): (KJS::Context2D::Context2D): (KJS::GradientFunction::callAsFunction): (KJS::Gradient::getValueProperty): (KJS::ImagePattern::getValueProperty): (KJS::getSelectHTMLCollection):
khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::MimeType::getValueProperty): (KJS::PluginsFunc::callAsFunction): (KJS::NavigatorFunc::callAsFunction):
khtml/ecma/kjs_proxy.cpp: (TestFunctionImp::callAsFunction):
khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::RangeConstructor::getValueProperty):
khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::NodeFilterConstructor::getValueProperty): (KJS::DOMNodeFilterProtoFunc::callAsFunction): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::Window::retrieve): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::Location::getValueProperty): (KJS::Location::toPrimitive): (KJS::LocationFunc::callAsFunction): (KJS::Selection::getValueProperty): (KJS::Selection::toPrimitive): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::getValueProperty): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::getAllResponseHeaders): (KJS::XMLHttpRequest::getResponseHeader): (KJS::XMLHttpRequest::getStatus): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
ksvg2/ecma/Ecma.cpp: (KSVG::getSVGPathSeg):
ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):

4:35 PM Changeset in webkit [12218] by darin

3 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

JSUtils.cpp: (JSObjectKJSValue):
UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::toPrimitive):

4:07 PM Changeset in webkit [11524] by mjs

3 edits in trunk/WebCore

Reviewed by Darin and Tim Hatcher.

fix WebCore SVG build for gcc 3.3 (don't know why it has these complaints)

kcanvas/KCanvasFilters.h: (QPointF::QPointF): Add a default constructor (KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): ditto
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): Move a variable declaration instead exception blocking (KCanvasFECompositeQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto

12:40 PM Changeset in webkit [11523] by darin

7 edits in trunk

WebCore:

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6032 REGRESSION: Uncaught exception when image is dragged out of webpage

WebCore.exp: Export the new WebCoreElementImageRendererKey and remove the old WebCoreElementImageKey.
kwq/WebCoreBridge.h: Add WebCoreElementImageRendererKey, remove WebCoreElementImageKey.
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Pass the image renderer in the dictionary, but not the NSImage.

WebKit:

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6032 REGRESSION: Uncaught exception when image is dragged out of webpage

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Pass the image renderer, not the NSImage. (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from WebCore with only an image renderer.
WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): Pass the image renderer, not the NSImage.

12:34 PM Changeset in webkit [11522] by darin

6 edits
2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
plainText() returns a partial result when the node contains RTL text

fast/dom/inner-text-rtl-expected.txt: Added.
fast/dom/inner-text-rtl.html: Added.

WebCore:

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6029 plainText() returns a partial result when the node contains RTL text

Test: fast/dom/inner-text-rtl.html

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox): Avoid advancing m_sortedTextBoxes if textBoxEnd wasn't reached.
kwq/KWQListImpl.h:
kwq/KWQListImpl.mm: (KWQListImpl::getNext): Added. (KWQListImpl::getPrev): Added.
kwq/KWQPtrList.h: (QPtrList::getNext): Added. (QPtrList::getPrev): Added.

12:21 PM Changeset in webkit [11521] by darin

5 edits
4 adds in trunk

LayoutTests:

New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5826

fast/overflow/overflow-rtl-expected.checksum: Added.
fast/overflow/overflow-rtl-expected.png: Added.
fast/overflow/overflow-rtl-expected.txt: Added.
fast/overflow/overflow-rtl.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5826 Blocks with direction:rtl and overflow:auto or scroll have incorrect scrollbars

khtml/rendering/render_block.cpp: (khtml::RenderBlock::leftmostPosition):
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::RenderLayer): Initialize (khtml::RenderLayer::scrollOffset): (khtml::RenderLayer::subtractScrollOffset): (khtml::RenderLayer::scrollToOffset): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::updateScrollPositionFromScrollbars): (khtml::RenderLayer::computeScrollDimensions): (khtml::RenderLayer::updateScrollInfoAfterLayout):
khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollToYOffset):

11:56 AM Changeset in webkit [11520] by darin

3 edits
4 adds in trunk

LayoutTests:

New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3983

fast/css/outline-auto-location-expected.checksum: Added.
fast/css/outline-auto-location-expected.png: Added.
fast/css/outline-auto-location-expected.txt: Added.
fast/css/outline-auto-location.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3983 outline:auto improperly puts outline around contained elements, not the actual div

khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Only add the rect if this is a RenderBlock.

11:05 AM Changeset in webkit [11519] by darin

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3539 Array join and toString methods do not support circular references

kjs/array_object.cpp: (ArrayProtoFuncImp::callAsFunction): Added set of visited objects -- don't recurse if item is already in the set.

LayoutTests:

New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

fast/js/cyclic-ref-toString-expected.txt: Added.
fast/js/cyclic-ref-toString.html: Added.

10:56 AM Changeset in webkit [11518] by darin

4 edits
2 adds in trunk

LayoutTests:

New layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5784

fast/parser/duplicate-html-body-element-IDs-expected.txt: Added.
fast/parser/duplicate-html-body-element-IDs.html: Added.

WebCore:

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5784 Assertion failure in DocumentImpl::removeElementById() (idCount > 0) Another symptom is that getElementById doesn't work when the ID is on a duplicate <html> or <body> element.

Added a new layout test that checks for at least one symptom of the bug.

khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use setAttribute here instead of using insertAttribute and calling recalcStyle explicitly. That's because setAttribute does other things that are needed to change an attribute in an attribute map that's already connected to an element, including updating the ID map if the attribute is the ID attribute.

khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::insertAttribute): Assert that this parser-only function is only used on attribute maps that aren't yet attached to elements.

9:14 AM Changeset in webkit [11517] by darin

12 edits in trunk/WebCore

Reviewed by Eric and Tim Omernick.

speed up timers by using CFTimerRunLoopRef instead of NSTimer http://bugzilla.opendarwin.org/show_bug.cgi?id=5677

kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and restartTimer. Made KWQObjectSenderScope functions be inline.
kwq/KWQObject.mm: (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent on the target. (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new timer ID and calls restartTimer. (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary. That includes creating a CFRunLoopTimer and scheduling it on the current run loop. (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to fire and the "fire again" interval. (deleteTimer): Added. Invalidates and then removes a timer. (QObject::killTimer): Changed to use deleteTimer to do most of its work. (deleteOneTimer): Added. Calls deleteTimer. (QObject::killTimers): Changed to use deleteOneTimer to do most of its work. (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target. (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers. (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.

kwq/KWQTimer.h: (QTimer::QTimer): Made constructor inline and removed the optional parameter. (QTimer::isActive): Made inline. (QTimer::fireDate): Added. Inline function. Got rid of the NSTimer and added a CFRunLoopTimer.
kwq/KWQTimer.mm: (timerFired): Added. Calls fire on the QTimer object. (QTimer::start): Changed to create a CFRunLoopTimer. (QTimer::stop): Changed to use CFRunLoopTimer functions. (QTimer::fire): Ditto.

khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the file so it can be used inline in the implementation of the Window class, and changed to use the PausedTimeouts class intead of a QMap to store the paused timeouts.
khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces a check in the caller and a check partway down this function (after the part was already dereferenced). Fixed message handling so the message is not converted to ascii and back. Added an isObject() check so we won't crash if the passed function is a value that's not an object. Changed check for function vs. script to check for a function of nil instead of using a separate boolean. (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object, using the new QObject::timerIntervals function rather than the old QObject::pauseTimer function. This means that the paused timers are entirely stored in the PausedTimeouts object instead of being half in a QMap and the other half inside the QObject itself. (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function. (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including the scheduled actions, unless the timeouts have already been resumed (in which case the m_array field will be 0).

kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them use the PausedTimeouts class and no longer take a key parameter.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than the old getNSTimer() function to get the fire date. (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter. (KWQKHTMLPart::resumeTimeouts): Remove the key parameter. (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead of a QMap for the paused timeouts.

kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts. Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]): Added code where it sets the pausedTimouts. (-[KWQPageState pausedTimeouts]): Added. (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode. (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0. (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method. (-[KWQPageState finalize]): Set document to 0 after deref for consistency.

kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the paused timeouts using the new pauseTimeouts function.

7:27 AM Changeset in webkit [11516] by darin

2 edits in trunk/WebKit

Was getting build failures related to "count" methods.
Made Tim's build fix Leopard-only.

WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed