Timeline



Jan 6, 2006:

6:15 PM Changeset in webkit [11921] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4386652
Submitted by: eseidel
Reviewed by: darin

<rdar://problem/4386652> Crash: SVG filter crash at w3schools.com

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEDiffuseLightingQuartz::getCIFilter): nil check (KCanvasFESpecularLightingQuartz::getCIFilter): nil check
3:51 PM Changeset in webkit [11920] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changes mostly thanks to Maks Orlovich, tweaked a little by me.

  • kjs/create_hash_table: Use the same hash as the one used buy Identifier.
  • kjs/function.cpp: (KJS::FunctionImp::processParameters): Use the new List::copyFrom (KJS::ActivationImp::ActivationImp): track variable while iterating
  • kjs/internal.cpp: (KJS::StringImp::toObject): create StringInstance directly
  • kjs/list.cpp: (KJS::List::copy): implement in terms of copyFrom (KJS::List::copyFrom): more efficient way to copy in another list
  • kjs/list.h:
  • kjs/lookup.cpp: (keysMatch): updated to work with identifier hash (findEntry): ditto (Lookup::findEntry): ditto (Lookup::find): ditto
  • kjs/lookup.h:
2:49 PM Changeset in webkit [11919] by hyatt
  • 3 edits in trunk/JavaScriptCore/kjs

Fix build bustage on Mac.

2:43 PM Changeset in webkit [11918] by hyatt
  • 16 edits in trunk/JavaScriptCore

Land all the changes to make JSCore build again on windows.

2:21 PM Changeset in webkit [11917] by hyatt
  • 4 edits
    2 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the remaining project changes for building with VC 2005

1:09 PM Changeset in webkit [11916] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley (full credit) and Tim Omernick (half credit).

  • fixed <rdar://problem/4401102> REGRESSION (420+): When displaying a PDF, tabbing around stops working after reaching page
  • WebView.subproj/WebPDFView.m: (-[WebPDFView setNextKeyView:]): Use [PDFSubview documentView] rather than PDFSubview here, since that's the view that we now hand off first-responderhood to.
12:02 PM Changeset in webkit [11915] by bdakin
  • 4 edits in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

11:24 AM Changeset in webkit [11914] by ggaren
  • 2 edits
    1 add in trunk/WebCore

Patch by Mitz, reviwed by Darin, layout tested and landed by me.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setName):
  • manual-tests/empty-link-target.html: Added.
10:13 AM Changeset in webkit [11913] by ggaren
  • 3 edits
    1 delete in trunk

LayoutTests:

Rolling out this layout test for now, until we can get plugin testing
working.

  • fast/plugins/netscape-back-forward.html: Removed.

WebKitTools:

Temporarily rolling out plugin support from DumpRenderTree because it
caused lots of layout test regressions.

  • DumpRenderTree/DumpRenderTree.m: (main): Remove invisible window added to support plugins.
7:50 AM Changeset in webkit [11912] by ap
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

Test cases:

  • fast/forms/form-get-multipart.html
  • fast/forms/form-get-multipart2.html
  • fast/forms/form-get-multipart3.html
  • fast/forms/form-post-urlencoded.html
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::submit): Reset m_multipart to false if not posting. (DOM::HTMLFormElementImpl::parseEnctype): multipart/form-data doesn't imply POST method.
6:35 AM Changeset in webkit [11911] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Eric.

Test case: fast/parser/entity-ignorable-whitespace.xhtml

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::finish): install an ignorableWhitespace callback to work around a libxml2 bug (khtml::ignorableWhitespaceHandler): no-op
3:03 AM Changeset in webkit [11910] by ap
  • 1 edit in trunk/JavaScriptCore/kjs/function.cpp

Same as the previous checkin, but should be for real now.

2:47 AM Changeset in webkit [11909] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove conflict marker

2:44 AM Changeset in webkit [11908] by ap
  • 2 edits in trunk/JavaScriptCore
  • fix development build failure from the previous checkin
  • kjs/function.cpp: (KJS::ActivationImp::put): Use prototype() accessor in assert.
2:44 AM Changeset in webkit [11907] by andersca
  • 3 edits in trunk/LayoutTests

2006-01-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/dom/set-innerHTML-expected.txt:
  • fast/dom/set-innerHTML.xhtml: Update these with the attached test case.
2:39 AM Changeset in webkit [11906] by andersca
  • 2 edits in trunk/WebCore

2006-01-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/xml_tokenizer.cpp: (khtml::balancedStartElementNsHandler): (khtml::balancedEndElementNsHandler): (khtml::balancedCharactersHandler): (khtml::balancedProcessingInstructionHandler): (khtml::balancedCdataBlockHandler): (khtml::balancedCommentHandler): (khtml::balancedWarningHandler): Add handlers.

(khtml::parseXMLDocumentFragment):
Change back into using xmlParseBalancedChunkMemory.

1:16 AM Changeset in webkit [11905] by eseidel
  • 2 edits
    4 adds in trunk/LayoutTests

Bug #: 5969
Submitted by: Alexander Kellett <​lypanov@kde.org>
Reviewed by: eseidel

Basic support for <mask> tag.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5969

  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: updated.
  • svg/custom/grayscale-gradient-mask-expected.checksum: Added.
  • svg/custom/grayscale-gradient-mask-expected.png: Added.
  • svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • svg/custom/grayscale-gradient-mask.svg: Added.
1:10 AM Changeset in webkit [11904] by eseidel
  • 17 edits
    4 adds in trunk/WebCore

Bug #: 5969
Submitted by: Alexander Kellett <​lypanov@kde.org>
Reviewed by: eseidel

Basic support for <mask> tag.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5969
Still missing attribute support for: maskUnits, maskContentUnits.

Mask pixel tests do not work in DumpRenderTree due to:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6327
Added test cases anyway.

This also tickles a (known) gradient update issue:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6052

  • WebCore.xcodeproj/project.pbxproj: added Mask files
  • kcanvas/KCanvasResources.cpp: (KCanvasMasker::KCanvasMasker): added. (KCanvasMasker::~KCanvasMasker): added. (KCanvasMasker::setMask): added. (KCanvasMasker::externalRepresentation): added. (getMaskerById): added.
  • kcanvas/KCanvasResources.h: (KCanvasResource::isMasker): added. (KCanvasMasker::isMasker): added. (KCanvasMasker::mask): added.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): added mask support
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Added. (KCanvasMaskerQuartz::KCanvasMaskerQuartz): added.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Added. (applyLuminanceToAlphaFilter): added. (applyExpandAlphatoGrayscaleFilter): added. (transformImageIntoGrayscaleMask): added. (KCanvasMaskerQuartz::applyMask): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): added mask support.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createResource): added mask support.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (debugDumpCGImageToFile): added, debug only. (debugDumpCGLayerToFile): added, debug only. (debugDumpCIImageToFile): added, debug only.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty): added mask support.
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): added mask support. (SVGRenderStyle::operator==): added mask support.
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleMaskData::StyleMaskData): added mask support. (StyleMaskData::operator==): added mask support.
  • ksvg2/css/SVGRenderStyleDefs.h: (KSVG::StyleMaskData::operator!=): added mask support.
  • ksvg2/ecma/Ecma.cpp: (Ecma::inheritedGetDOMNode): added mask support.
  • ksvg2/svg/SVGMaskElementImpl.cpp: Added. (KSVG::SVGMaskElementImpl::SVGMaskElementImpl): added. (KSVG::SVGMaskElementImpl::~SVGMaskElementImpl): added. (KSVG::SVGMaskElementImpl::x): added. (KSVG::SVGMaskElementImpl::y): added. (KSVG::SVGMaskElementImpl::width): added. (KSVG::SVGMaskElementImpl::height): added. (KSVG::SVGMaskElementImpl::attributeChanged): added. (KSVG::SVGMaskElementImpl::childrenChanged): added. (KSVG::SVGMaskElementImpl::parseMappedAttribute): added. (KSVG::SVGMaskElementImpl::drawMaskerContent): added. (KSVG::SVGMaskElementImpl::createRenderer): added. (KSVG::SVGMaskElementImpl::canvasResource): added.
  • ksvg2/svg/SVGMaskElementImpl.h: Added. (KSVG::SVGMaskElementImpl::isValid): added. (KSVG::SVGMaskElementImpl::rendererIsNeeded): added.
  • ksvg2/svg/svgtags.in: added <mask> support.
12:32 AM Changeset in webkit [11903] by mjs
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): Implement directly, thus skipping getter/setter handling and proto handling, as well as inlining needed superclass stuff. (KJS::ActivationImp::put): Implement directly, skipping getter/setter, proto, and do canPut directly in PropertyMap::put since there's no static property table either.
  • kjs/function.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::put): Allow optionally inlining canPut check.
  • kjs/property_map.h:

LayoutTests:

Reviewed by Eric.

  • fast/js/activation-proto-expected.txt: Added.
  • fast/js/activation-proto.html: Added.

Jan 5, 2006:

9:57 PM Changeset in webkit [11902] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4400804> Client-side redirect to a non-HTTP URL confuses Safari

  • WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): If we were waiting for a quick redirect, but the policy delegate decided to ignore it, then we need to report that the client redirect was cancelled.
6:30 PM Changeset in webkit [11901]
  • 13 copies
    3 deletes in tags/JavaScriptCore-312~3~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3~1'.

6:30 PM Changeset in webkit [11900] by thatcher
  • 1 edit in branches/Safari-1-3-branch/JavaScriptCore/bindings/objc/objc_utility.mm

Build fix.

6:26 PM Changeset in webkit [11899]
  • 73 copies
    5 deletes in tags/JavaScriptCore-417~8~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~8~1'.

6:26 PM Changeset in webkit [11898] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/bindings/objc/objc_utility.mm

Fix a build problem on the branch, different than TOT.

6:00 PM Changeset in webkit [11897] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.8.1

5:59 PM Changeset in webkit [11896] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-12-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):
5:49 PM Changeset in webkit [11895]
  • 212 copies
    17 deletes in tags/WebCore-417~18~1

This commit was manufactured by cvs2svn to create tag
'WebCore-417~18~1'.

5:49 PM Changeset in webkit [11894] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.18.1

5:48 PM Changeset in webkit [11893] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej

Fix for <rdar://problem/4148730> SureSec si#182 safari heap overflow.
When a table has a really huge rowSpan, Safari used to crash because
the malloc of the grid for the table failed. This fix just checks for
the success of the malloc.

  • khtml/rendering/render_table.cpp: (RenderTableSection::ensureRows): Return false if the grid resize is not successful. (RenderTableSection::addCell): Return early if ensureRows() returned false.
  • khtml/rendering/render_table.h: Make ensureRows() return a bool instead of void.
5:39 PM Changeset in webkit [11892] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Version to JavaScriptCore-312.3.1

5:35 PM Changeset in webkit [11891]
  • 121 copies
    5 deletes in tags/WebCore-315~14~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~14~1'.

5:35 PM Changeset in webkit [11890] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.14.1

5:33 PM Changeset in webkit [11889] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej

Fix for <rdar://problem/4148730> SureSec si#182 safari heap overflow.
When a table has a really huge rowSpan, Safari used to crash because
the malloc of the grid for the table failed. This fix just checks for
the success of the malloc.

  • khtml/rendering/render_table.cpp: (RenderTableSection::ensureRows): Return false if the grid resize is not successful. (RenderTableSection::addCell): Return early if ensureRows() returned false.
  • khtml/rendering/render_table.h: Make ensureRows() return a bool instead of void.
5:25 PM Changeset in webkit [11888] by thatcher
  • 4 edits in branches/Safari-1-3-branch/JavaScriptCore

Merges fixes from TOT to Safari-1-3-branch

2005-12-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):
4:12 PM Changeset in webkit [11887] by sullivan
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): Just added a FIXME comment about how to clean up this minor hack in the future.
3:57 PM Changeset in webkit [11886] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim O.

  • fixed these bugs: <rdar://problem/3021785> page up/down don't work on frameset pages unless you click <rdar://problem/3021788> Page Up/Down moves an unscrollable frame if you click on it first

and the WebKit part of this (need new Safari too for complete fix):
<rdar://problem/4378905> Page up/down don't work in PDFs when address field is focused

I moved some logic down from Safari that dealt with finding the largest scrollable child frame in a frameset,
and added support for standard scrolling-related selectors to WebPDFView. The latter was needed for 4378905;
the former was needed due to side effects of the Safari part of the change. As long as I was doing the former,
I also used that logic to fix 3021785 and 3021788.

  • WebView.subproj/WebFrameViewPrivate.h: new currently-private methods _hasScrollBars and _largestChildWithScrollBars
  • WebView.subproj/WebFrameView.m: (-[WebFrameView scrollToBeginningOfDocument:]): if we don't have scroll bars, operate on our largest child with scroll bars instead (-[WebFrameView scrollToEndOfDocument:]): ditto (-[WebFrameView _pageVertically:]): ditto (-[WebFrameView _pageHorizontally:]): ditto (-[WebFrameView _scrollLineVertically:]): ditto (-[WebFrameView _scrollLineHorizontally:]): ditto (-[WebFrameView keyDown:]): where we were bailing out if ![self allowsScrolling], also check for whether there's a child with scroll bars, and don't bail out if so (-[WebFrameView _area]): new helper method used to implement _largestChildWithScrollBars (code moved from Safari) (-[WebFrameView _hasScrollBars]): new method, just returns YES if either scroll bar is showing (code moved from Safari) (-[WebFrameView _largestChildWithScrollBars]): new method, returns the child with the largest area that is showing at least one scroll bar (code moved from Safari and tweaked a little)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): new method, hackaround for the fact that PDFView handles key downs from standard scrolling keys but does not implement the standard responder selectors (-[WebPDFView scrollPageDown:]): use _fakeKeyEventWithFunctionKey: to get the PDFView to scroll appropriately (-[WebPDFView scrollPageUp:]): ditto (-[WebPDFView scrollToBeginningOfDocument:]): ditto (-[WebPDFView scrollToEndOfDocument:]): ditto
  • WebView.subproj/WebView.m: add scrollToBeginningOfDocument and scrollToEndOfDocument to the list of responder operations that we hand off appropriately to the responder chain. These two aren't defined in any header but are generated by Home and End keys and used by the text system.
2:23 PM Changeset in webkit [11885] by ggaren
  • 6 edits
    10 adds in trunk

LayoutTests:

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
REGRESSION: Repro crash in JS called from Flash on bdash.net.nz

  • fast/plugins/netscape-back-forward-expected.txt: Added.
  • fast/plugins/netscape-back-forward.html: Added.
  • fast/plugins/resources/go-back.html: Added.

WebKit:

Reviewed by Darin.

  • WebKit.exp: export WebPluginDatabase class, which DumpRenderTree needs to add plugins to the runtime.

WebKitTools:

Reviewed by darin.

Also wrote first test plugin.

  • DumpRenderTree/DumpRenderTree.m: (main): (1) Put the WebView in an invisible window, because PlugIns are optimized not to load if there's no parent window. (2) Tell WebKit to load any PlugIns in the directory from which we loaded. This means we can build nasty PlugIns alongside DumpRenderTree and they'll load automagically during layout testing, but they won't be added to the user's system, hosing apps like Safari.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new test PlugIn to project.

PlugIn added to project:

  • DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added. (getPluginClass): (initializeIdentifiers): (pluginHasProperty): (pluginHasMethod): (pluginGetProperty): (pluginSetProperty): (pluginInvoke): (pluginInvokeDefault): (pluginInvalidate): (pluginAllocate): (pluginDeallocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
12:48 PM Changeset in webkit [11884] by ap
  • 454 edits in trunk/LayoutTests

Reviewed by Darin.

Added UTF-8 BOMs to css2.1 tests.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6312

9:44 AM Changeset in webkit [11883] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Move log message to top of file where it belongs.

Jan 4, 2006:

10:41 PM Changeset in webkit [11882] by mjs
  • 15 edits
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Eric.

Based on a patch by Eric.

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): (DOM::freeXsltParamArray): Use fastMalloc/fastFree.

(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.

WebKit:

Reviewed by Darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge, instead of having it bubble through the view and frame.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge initWithFrameName:view:]): don't pass name to frame, we own it now; set it on ourselves directly (-[WebBridge findFrameNamed:]): removed (-[WebBridge createWindowWithURL:frameName:]): set name on bridge, not webview (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge runModal]): remove excess braces
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebControllerSets.h: Removed.
  • WebView.subproj/WebControllerSets.m: Removed.
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate name]): removed (-[WebFramePrivate setName:]): removed (-[WebFramePrivate dealloc]): don't release name, we no longer have one (-[WebFrame _appendChild:]): removed (-[WebFrame _removeChild:]): removed (-[WebFrame _createItem:]): removed stray space (-[WebFrame _immediateChildFrameNamed:]): Just call the bridge (-[WebFrame _setName:]): removed (-[WebFrame _detachFromParent]): remove bridge from parent note self (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _addChild:]): Call appendChild: on bridge, not self (-[WebFrame _nextFrameWithWrap:]): just call bridge (and moved helpers there) (-[WebFrame _previousFrameWithWrap:]): just call bridge (and moved helpers there) (-[WebFrame _initWithWebFrameView:webView:bridge:]): don't take a name any more (-[WebFrame _setFrameNamespace:]): just call bridge (-[WebFrame _frameNamespace]): just call bridge (-[WebFrame _hasSelection]): remove excess braces (-[WebFrame _clearSelection]): ditto (-[WebFrame initWithName:webFrameView:webView:]): no more name (-[WebFrame name]): just call bridge (-[WebFrame findFrameNamed:]): just call bridge (and moved helpers there) (-[WebFrame parentFrame]): fixed for new style
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
5:13 PM Changeset in webkit [11881]
  • 121 copies
    5 deletes in tags/WebCore-315~14

This commit was manufactured by cvs2svn to create tag
'WebCore-315~14'.

5:13 PM Changeset in webkit [11880] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning.

1:44 PM Changeset in webkit [11879] by ggaren
  • 5 edits in trunk/JavaScriptCore

Patch by ​kimmo.t.kinnunen@nokia.com, reviewed by darin, tweaked by me.

  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/lexer.cpp: (Lexer::shift): (Lexer::lex): (Lexer::isWhiteSpace): (Lexer::isLineTerminator): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::scanRegExp):
  • kjs/lexer.h: (KJS::Lexer::):
  • tests/mozilla/expected.html: Updated test results.
1:32 PM Changeset in webkit [11878] by darin
  • 1 edit
    1 add in trunk/LayoutTests
  • added a missing test result
  • svg/custom/fractional-rects-expected.png: Added.
1:21 PM Changeset in webkit [11877] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/xsl/xslt-processer-expected.txt: Update.
1:17 PM Changeset in webkit [11876] by andersca
  • 2 edits in trunk/WebCore

2006-01-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Based on a patch by Eric.

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): (DOM::freeXsltParamArray): Use fastMalloc/fastFree.

(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.

1:10 PM Changeset in webkit [11875] by thatcher
  • 1 edit
    3 adds in trunk/WebKitTools

Reviewed by Darin.
Created by Eric.
Tweaked and tested by me.

New scripts to work with Subversion when the switch happens.
These will replace cvs-apply, cvs-unapply, and cvs-create-patch.

  • Scripts/svn-apply: Added.
  • Scripts/svn-create-patch: Added.
  • Scripts/svn-unapply: Added.
1:05 PM Changeset in webkit [11874] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
document.plugins doesn't exist

  • fast/dom/HTMLDocument/document-plugins-expected.txt: Added.
  • fast/dom/HTMLDocument/document-plugins.html: Added.

WebCore:

Reviewed by darin.

  • khtml/ecma/kjs_html.cpp: Added 'plugins' as synonym for 'embeds'
12:01 PM Changeset in webkit [11873] by ggaren
  • 3 edits
    3 adds in trunk

LayoutTests:

Layout test for <rdar://problem/4214080> document.embeds:
embeds[0].Play() undefined at languageguide.org prevents audio playing
on mouseover

  • fast/dom/object-embed-plugin-scripting-expected.txt: Added.
  • fast/dom/object-embed-plugin-scripting.html: Added.
  • fast/dom/resources/articles.m4a: Added.

WebCore:

Reviewed by darin.

  • Fixed <rdar://problem/4214080> document.embeds: embeds[0].Play() undefined at languageguide.org prevents audio playing on mouseover
  • Layout test: fast/dom/object-embed-plugin-scripting.html

A common idiom the kids like to use these days for plugins is to nest
an <embed> inside an <object>, and assume that IE will honor the first,
Mozilla the second. We happen to honor both, but the rules dictate that
only the outer <object> gets a plugin/renderer. (A plugin is a

renderer.) This is a problem because sites ID us as Mozilla and
therefore attempt to script their plugins through the <embed>, which
has no plugin/renderer. The fix here is to have an <embed> return its
parent node's plugin/renderer when queried, if and only if it has no
renderer of its own and its parent node is an <object>. We may decide
to restrict this further in the future.

One happy consequence of this patch is that all the apple.com Quicktime
websites we had previously broken with TOT are now fixed.

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLEmbedElementImpl::getEmbedInstance): The "if (!r)" clause implements the logic I just described. The code below it I changed just for style, to match the style in getObjectInstance().

(DOM::HTMLEmbedElementImpl::rendererIsNeeded): Assert that an <object>
parent has a renderer because we're going to use it later.

(DOM::HTMLObjectElementImpl::rendererIsNeeded): Changed to match style
of HTMLEmbedElementImpl counterpart.

6:42 AM Changeset in webkit [11872] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin, landed by ap.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Repaint parts of the border that moved.
  • manual-tests/border-repaint-glitch.html: Added.
12:23 AM Changeset in webkit [11871] by eseidel
  • 190 edits
    3 adds in trunk/LayoutTests

Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel

Updated layout tests after QRect (size & point) to Q*F change
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4462

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/fractional-rects-expected.checksum: Added.
  • svg/custom/fractional-rects-expected.txt: Added.
  • svg/custom/fractional-rects.svg: Added.
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/path-update-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
12:20 AM Changeset in webkit [11870] by eseidel
  • 34 edits
    9 adds in trunk/WebCore

Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel

Changed use of QRect to QRectF in the points where SVG can have
fractional numbers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4462

Added test cases:

  • svg/custom/fractional-rects.svg: copy of rounded-rects.svg with fractional coordinates.
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQWMatrix.h:
  • kwq/KWQWMatrix.mm: (QWMatrix::mapRect): mapRect for QRectF
  • kwq/KWQRectF.h:
  • kwq/KWQRectF.mm: Added. QRectF impl
  • kwq/KWQSizeF.h:
  • kwq/KWQSizeF.mm: Added.QSizeF impl
  • kwq/KWQPointF.h:
  • kwq/KWQPointF.mm: Added. QPointF impl
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::fillContains): (KCanvasContainer::strokeContains): (KCanvasContainer::relativeBBox): (KCanvasContainer::getAspectRatio): QRect -> QRectF
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp: (KCanvasFilterEffect::subRegion): (KCanvasFilterEffect::setSubRegion): QRect -> QRectF
  • kcanvas/KCanvasFilters.h: (KCanvasFilter::filterRect): (KCanvasFilter::setFilterRect): QRect -> QRectF (KCanvasFEConvolveMatrix::kernelSize): (KCanvasFEConvolveMatrix::setKernelSize): (KCanvasFEConvolveMatrix::targetOffset): (KCanvasFEConvolveMatrix::setTargetOffset): QSize -> QSizeF
  • kcanvas/KCanvasItem.cpp: (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::relativeBBox): QRect -> QRectF
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): QRect -> QRectF
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (hasFractions): helper function (operator<<): QSizeF operator, QRectF operator
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerLinearGradient::gradientStart): (KRenderingPaintServerLinearGradient::setGradientStart): (KRenderingPaintServerLinearGradient::gradientEnd): (KRenderingPaintServerLinearGradient::setGradientEnd): (KRenderingPaintServerRadialGradient::gradientCenter): (KRenderingPaintServerRadialGradient::setGradientCenter): (KRenderingPaintServerRadialGradient::gradientFocal): (KRenderingPaintServerRadialGradient::setGradientFocal): QPoint -> QPointF
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::Private::Private): x, y, width, height -> QRectF (KRenderingPaintServerPattern::setBbox): replaced get/set methods (KRenderingPaintServerPattern::bbox): replaced get/set methods (KRenderingPaintServerPattern::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): QRect -> QRectF
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect): QRect -> QRectF
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (drawMarkerWithData): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::paint): QRect -> QRectF (KCanvasItemQuartz::nodeAtPoint): QPoint -> QPointF (KCanvasItemQuartz::bboxForPath) :QRect -> QRectF (KCanvasItemQuartz::hitsPath):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect): QRect -> QRectF
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): QRect -> QRectF
  • khtml/rendering/render_object.h: (khtml::RenderObject::relativeBBox):QRect -> QRectF
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource): QRect -> QRectF
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value): QRect -> QRectF
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox): Rect -> QRectF
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): QRect -> QRectF
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::checkIntersection): QRect -> QRectF, removed integer conversions (SVGSVGElementImpl::checkEnclosure): QRect -> QRectF, removed integer conversions

Jan 3, 2006:

6:01 PM Changeset in webkit [11869] by bdakin
  • 2 edits in trunk/WebKit

Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:

5:02 PM Changeset in webkit [11868] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Vicki.

  • moved frame traversal code across from bridge, also dropped the children array
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge firstChild]): Moved from WebBridge. Use new _firstChild pointer. (-[WebCoreBridge lastChild]): Moved from WebBridge. Use new _lastChild pointer. (-[WebCoreBridge childCount]): Moved from WebBridge. Use _childCount variable. (-[WebCoreBridge previousSibling]): Moved from WebBridge. (-[WebCoreBridge nextSibling]): ditt (-[WebCoreBridge isDescendantOfFrame:]): ditto (-[WebCoreBridge traverseNextFrameStayWithin:]): ditto (-[WebCoreBridge appendChild:]): Moved from WebBridge, maintain count and first/last pointers. (-[WebCoreBridge removeChild:]): Moved from WebBridge, maintain count and first/last pointers.

WebKit:

Reviewed by Vicki.

  • moved frame traversal code across from bridge, also dropped the children array
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Don't release children array, that was moved down to WebCore. (-[WebBridge saveDocumentState:]):
  • many methods moved to WebCore.
  • WebView.subproj/WebFrame.m: (Frame): New convenience method to get a WebFrame * from a method that returns WebCoreBridge *. (-[WebFrame _firstChildFrame]): use Frame() (-[WebFrame _lastChildFrame]): ditto (-[WebFrame _previousSiblingFrame]): ditto (-[WebFrame _nextSiblingFrame]): ditto (-[WebFrame _traverseNextFrameStayWithin:]): ditto
3:21 PM Changeset in webkit [11867] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)

toString was defined as a method on the JS Selection object,
but it didn't return anything.

Added layout test:

  • editing/selection/toString.html
  • khtml/ecma/kjs_window.cpp: (KJS::SelectionFunc::callAsFunction):
3:06 PM Changeset in webkit [11866] by justing
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by harrison

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)

  • editing/selection/toString-expected.txt: Added.
  • editing/selection/toString.html: Added.
3:03 PM Changeset in webkit [11865] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6345
Submitted by: eseidel
Reviewed by: darin

REGRESSION: repro crash w/ invalid charset attribute on <script>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6345

  • fast/loader/invalid-charset-on-script-crashes-loader-expected.txt: Added.
  • fast/loader/invalid-charset-on-script-crashes-loader.html: Added.
  • fast/loader/resources/invalid-charset-on-script-crashes-loader.js: Added.
2:42 PM Changeset in webkit [11864] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by timo.

Since we clear all the plugin data structures in setView, we need to
clear the windowScriptObject as well. I had already done this in my
previous patch, but I didn't realize there are two windowScriptObjects
-- one for Netscape PlugIns, and one for WebKit PlugIns.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject as well.
2:34 PM Changeset in webkit [11863] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/js/test-prototypes-expected.txt: Added.
  • fast/js/test-prototypes.html: Added.
2:34 PM Changeset in webkit [11862] by andersca
  • 6 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.cpp: (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): Add "prototype" property in constructors.
2:02 PM Changeset in webkit [11861] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6345
Submitted by: eseidel
Reviewed by: darin

REGRESSION: repro crash w/ invalid charset attribute on <script>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
I also made some small spacing cleanup here.
I did *not* fix the usage in formData, as the move from KCharSet to
QTextCodec actually fixed a bug whereby if the first listed charset
in accept-charsets was invalid, we would assume latin1 instead of
checking for the next valid one before assuming system encoding.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): cleanup
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): null check (CachedScript::CachedScript): cleanup (CachedXSLStyleSheet::CachedXSLStyleSheet): null check (CachedXBLDocument::CachedXBLDocument): cleanup
1:51 PM Changeset in webkit [11860] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/frames/iframe-target-expected.txt: Added.
  • fast/frames/iframe-target.html: Added.
1:50 PM Changeset in webkit [11859] by andersca
  • 2 edits in trunk/WebKit

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebView.subproj/WebFrame.m: (-[WebFrame _descendantFrameNamed:sourceFrame:]): Return the correct frame.
4:37 AM Changeset in webkit [11858] by justing
  • 2 edits
    8 adds in trunk/LayoutTests

New/updated layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/4259818>
selection object incorrect after double-clicking a word

  • editing/selection/anchor-focus1-expected.txt: Added.
  • editing/selection/anchor-focus1.html: Added.
  • editing/selection/anchor-focus2-expected.txt: Added.
  • editing/selection/anchor-focus2.html: Added.
  • editing/selection/anchor-focus3-expected.txt: Added.
  • editing/selection/anchor-focus3.html: Added.
  • editing/selection/getRangeAt-expected.txt: Added.
  • editing/selection/getRangeAt.html: Added.
  • editing/selection/unrendered-001-expected.txt:
4:28 AM Changeset in webkit [11857] by justing
  • 7 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/4259818>
selection object incorrect after double-clicking a word

Reviewed by harrison

Changed the Selection object's anchor/focus properties to match
Mozilla's Selection object API, added getRangeAt and outlined the
rest of the API.
Cleaned up the JS Selection object (to do less work in the DOM binding).
Added an updateLayout call to VisiblePosition::init and removed some
updateLayout calls from other parts of the editing code.

Added layout tests:

  • editing/selection/getRangeAt.html
  • editing/selection/anchor-focus1.html
  • editing/selection/anchor-focus2.html
  • editing/selection/anchor-focus3.html Updated expected results:
  • editing/selection/unrendered-001-expected.txt
  • khtml/ecma/kjs_window.cpp: (KJS::Selection::getValueProperty): (KJS::Selection::toString): (KJS::SelectionFunc::callAsFunction):
  • khtml/ecma/kjs_window.h: (KJS::Selection::):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::modify): (khtml::SelectionController::type): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::setBaseAndExtent): (khtml::SelectionController::setPosition): (khtml::SelectionController::collapse): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::empty): (khtml::SelectionController::extend): (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::part): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::SelectionController::isCollapsed):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::isCandidate):
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick):
2:06 AM Changeset in webkit [11856] by andersca
  • 3 edits
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • dom/html/level2/core/createDocument08-expected.txt:
  • dom/xhtml/level2/core/createDocument08-expected.txt: These now fail.
  • fast/dom/createDocument-empty-expected.txt: Added.
  • fast/dom/createDocument-empty.html: Added.
2:05 AM Changeset in webkit [11855] by andersca
  • 3 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDOMImplementationProtoFunc::callAsFunction): When passing null to createDocument, pass a null DOMString, and not a DOMString containing the text "null".
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Only validate the qualifiedName if it's not null or empty. Also, do not create the document element if the qualifiedName is null or empty.
1:19 AM Changeset in webkit [11854] by eseidel
  • 57 edits in trunk/WebCore

Bug #: 6109
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no tests possible.

khtml/editing should use RefPtr instead of manual ref/deref
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6109

Results in a slight performance gain < 1% on the PLT.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/append_node_command.cpp: (khtml::AppendNodeCommand::AppendNodeCommand): (khtml::AppendNodeCommand::doApply): (khtml::AppendNodeCommand::doUnapply):
  • khtml/editing/append_node_command.h: (khtml::AppendNodeCommand::~AppendNodeCommand): (khtml::AppendNodeCommand::appendChild): (khtml::AppendNodeCommand::parentNode):
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::ApplyStyleCommand::removeInlineStyle):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::deleteInsignificantText):
  • khtml/editing/delete_from_text_node_command.cpp: (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
  • khtml/editing/delete_from_text_node_command.h: (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand): (khtml::DeleteFromTextNodeCommand::node):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::saveTypingStyleState): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::calculateEndingPosition): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::clearTransientState):
  • khtml/editing/delete_selection_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): (khtml::EditCommand::~EditCommand): (khtml::EditCommand::setTypingStyle): (khtml::EditCommand::styleAtPosition):
  • khtml/editing/edit_command.h: (khtml::EditCommand::document): (khtml::EditCommand::typingStyle):
  • khtml/editing/insert_into_text_node_command.cpp: (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
  • khtml/editing/insert_into_text_node_command.h: (khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand): (khtml::InsertIntoTextNodeCommand::node):
  • khtml/editing/insert_node_before_command.cpp: (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand): (khtml::InsertNodeBeforeCommand::doApply): (khtml::InsertNodeBeforeCommand::doUnapply):
  • khtml/editing/insert_node_before_command.h: (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand): (khtml::InsertNodeBeforeCommand::insertChild): (khtml::InsertNodeBeforeCommand::refChild):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
  • khtml/editing/insert_paragraph_separator_command.h:
  • khtml/editing/join_text_nodes_command.cpp: (khtml::JoinTextNodesCommand::JoinTextNodesCommand): (khtml::JoinTextNodesCommand::doApply): (khtml::JoinTextNodesCommand::doUnapply):
  • khtml/editing/join_text_nodes_command.h: (khtml::JoinTextNodesCommand::~JoinTextNodesCommand): (khtml::JoinTextNodesCommand::firstNode): (khtml::JoinTextNodesCommand::secondNode):
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp: (khtml::createMarkup): (khtml::createFragmentFromMarkup): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
  • khtml/editing/markup.h:
  • khtml/editing/merge_identical_elements_command.cpp: (khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): (khtml::MergeIdenticalElementsCommand::doApply): (khtml::MergeIdenticalElementsCommand::doUnapply):
  • khtml/editing/merge_identical_elements_command.h: (khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
  • khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::MoveSelectionCommand): (khtml::MoveSelectionCommand::~MoveSelectionCommand): (khtml::MoveSelectionCommand::doApply):
  • khtml/editing/move_selection_command.h:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/rebalance_whitespace_command.h: (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
  • khtml/editing/remove_css_property_command.cpp: (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
  • khtml/editing/remove_css_property_command.h: (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand): (khtml::RemoveCSSPropertyCommand::styleDeclaration):
  • khtml/editing/remove_node_attribute_command.cpp: (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
  • khtml/editing/remove_node_attribute_command.h: (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand): (khtml::RemoveNodeAttributeCommand::element):
  • khtml/editing/remove_node_command.cpp: (khtml::RemoveNodeCommand::RemoveNodeCommand): (khtml::RemoveNodeCommand::doApply): (khtml::RemoveNodeCommand::doUnapply):
  • khtml/editing/remove_node_command.h: (khtml::RemoveNodeCommand::~RemoveNodeCommand): (khtml::RemoveNodeCommand::node):
  • khtml/editing/remove_node_preserving_children_command.cpp: (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
  • khtml/editing/remove_node_preserving_children_command.h: (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand): (khtml::RemoveNodePreservingChildrenCommand::node):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::ReplacementFragment): (khtml::ReplacementFragment::~ReplacementFragment): (khtml::ReplacementFragment::enclosingBlock): (khtml::ReplacementFragment::removeNodePreservingChildren): (khtml::ReplacementFragment::removeNode): (khtml::ReplacementFragment::insertFragmentForTestRendering): (khtml::ReplacementFragment::restoreTestRenderingNodesToFragment): (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::computeAndStoreNodeDesiredStyle): (khtml::NodeDesiredStyle::NodeDesiredStyle): (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement): (khtml::ReplaceSelectionCommand::updateNodesInserted):
  • khtml/editing/replace_selection_command.h: (khtml::NodeDesiredStyle::node): (khtml::NodeDesiredStyle::style): (khtml::ReplacementFragment::root):
  • khtml/editing/set_node_attribute_command.cpp: (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
  • khtml/editing/set_node_attribute_command.h: (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand): (khtml::SetNodeAttributeCommand::element):
  • khtml/editing/split_element_command.cpp: (khtml::SplitElementCommand::SplitElementCommand): (khtml::SplitElementCommand::doApply): (khtml::SplitElementCommand::doUnapply):
  • khtml/editing/split_element_command.h: (khtml::SplitElementCommand::~SplitElementCommand):
  • khtml/editing/split_text_node_command.cpp: (khtml::SplitTextNodeCommand::SplitTextNodeCommand): (khtml::SplitTextNodeCommand::doApply): (khtml::SplitTextNodeCommand::doUnapply):
  • khtml/editing/split_text_node_command.h: (khtml::SplitTextNodeCommand::~SplitTextNodeCommand): (khtml::SplitTextNodeCommand::node):
  • khtml/editing/split_text_node_containing_element.cpp: (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): (khtml::SplitTextNodeContainingElementCommand::doApply):
  • khtml/editing/split_text_node_containing_element_command.h: (khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: (khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): (khtml::WrapContentsInDummySpanCommand::doApply): (khtml::WrapContentsInDummySpanCommand::doUnapply):
  • khtml/editing/wrap_contents_in_dummy_span_command.h: (khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
  • kwq/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreBridge documentFragmentWithText:]): (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
12:23 AM Changeset in webkit [11853] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/dom/clone-node-form-elements-expected.txt: Added.
  • fast/dom/clone-node-form-elements.html: Added.
12:12 AM Changeset in webkit [11852] by andersca
  • 7 edits in trunk/WebCore

2006-01-03 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Call copyNonAttributeProperties on the new node.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
  • khtml/html/html_formimpl.h: Copy m_value, m_checked and m_indeterminate here.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Call copyNonAttributeProperties on the new node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Call copyNonAttributeProperties on the new node.
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::copyNonAttributeProperties): Add function declaration.

Jan 2, 2006:

9:15 PM Changeset in webkit [11851] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Eric.

To do this, I had to invert the ownership so that WebBridge now
owns WebFrame instead of vice versa. As a result, WebView now owns
a WebBridge pointer and does not have a direct WebFrame pointer.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating the frame, so pass it what it needs to do that. (-[WebBridge dealloc]): The bridge now owns the frame, so release it. (-[WebBridge close]): ditto (-[WebBridge firstChild]): Moved from WebFrame (-[WebBridge lastChild]): ditto (-[WebBridge childCount]): ditto (-[WebBridge previousSibling]): ditto (-[WebBridge nextSibling]): ditto (-[WebBridge isDescendantOfFrame:]): ditto (-[WebBridge traverseNextFrameStayWithin:]): ditto (-[WebBridge appendChild:]): ditto (-[WebBridge removeChild:]): ditto
  • WebView.subproj/WebFrame.m: (-[WebFrame _removeChild::]): Call WebBridge version (-[WebFramePrivate dealloc]): ditto (-[WebFrame _firstChildFrame]): ditto (-[WebFrame _lastChildFrame]): ditto (-[WebFrame _childFrameCount]): ditto (-[WebFrame _previousSiblingFrame]): ditto (-[WebFrame _nextSiblingFrame]): ditto (-[WebFrame _traverseNextFrameStayWithin:]): ditto (-[WebFrame _appendChild:]): ditto (-[WebFrame _removeChild:]): ditto (-[WebFrame _isDescendantOfFrame:]): ditto, (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge pointer before the bridge is due to release us, and don't release the bridge any more since it now owns us (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer, we no longer create the bridge, instead it is passed in (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated initializer, but this method is no longer viable and should be deprecated.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: WebView was changed to hold onto the WebBridge for the main frame instead of the WebFrame.

(-[WebViewPrivate dealloc]): update for the fact that we hold
a bridge now, not a frame.
(-[WebView _close]): ditto
(-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
a bridge, not a frame.
(-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
(-[WebView setDefersCallbacks:]): get mainFrame via method
(-[WebView mainFrame]): Update to get the main frame properly

7:48 PM Changeset in webkit [11850] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Rubber stamped by Eric.

  • remove the no longer used QIntDict
  • kwq/KWQIntDict.h: Removed.
6:07 PM Changeset in webkit [11849] by ap
  • 3 edits
    5 adds in trunk

Reviewed by Eric.

Test case: fast/xsl/xslt-relative-path.xml

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs. (DOM::XSLTProcessorImpl::transformToString):
4:13 PM Changeset in webkit [11848] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)

We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
we fail to fire onmouseout events. Since the call to passSubframeEventToSubframe was originally added
to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
on passSubframeEventToSubframe.

  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
Note: See TracTimeline for information about the timeline view.