Timeline



Jan 16, 2006:

11:39 PM Changeset in webkit [12147] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by hyatt

  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Assign the new item to index m_count, not m_size.
10:53 PM Changeset in webkit [12146] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

WebCore-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new files omitted from the target.
10:50 PM Changeset in webkit [12145] by eseidel
  • 2 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Fixed test case to remove invisible chars (thus fixing test).

  • svg/custom/recursive-clippath.svg:
9:41 PM Changeset in webkit [12144] by hyatt
  • 19 edits
    25 copies
    1 add
    2 deletes in trunk/WebCore

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

  • ForwardingHeaders/kdom/css: Removed.
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
  • ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
  • ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
  • WebCore+SVG/RGBColorImpl.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • css: Added.
  • css/css_base.cpp: Added.
  • css/css_base.h: Added.
  • css/css_computedstyle.cpp: Added.
  • css/css_computedstyle.h: Added.
  • css/css_grammar.y: Added.
  • css/css_ruleimpl.cpp: Added.
  • css/css_ruleimpl.h: Added.
  • css/css_stylesheetimpl.cpp: Added.
  • css/css_stylesheetimpl.h: Added.
  • css/css_valueimpl.cpp: Added.
  • css/css_valueimpl.h: Added.
  • css/csshelper.cpp: Added.
  • css/csshelper.h: Added.
  • css/cssparser.cpp: Added.
  • css/cssparser.h: Added.
  • css/cssproperties.in: Added.
  • css/cssstyleselector.cpp: Added.
  • css/cssstyleselector.h: Added.
  • css/cssvalues.in: Added.
  • css/html4.css: Added.
  • css/makeprop: Added.
  • css/maketokenizer: Added.
  • css/makevalues: Added.
  • css/quirks.css: Added.
  • css/tokenizer.flex: Added.
  • khtml/css: Removed.
  • khtml/css/css_base.cpp: Removed.
  • khtml/css/css_base.h: Removed.
  • khtml/css/css_computedstyle.cpp: Removed.
  • khtml/css/css_computedstyle.h: Removed.
  • khtml/css/css_grammar.y: Removed.
  • khtml/css/css_ruleimpl.cpp: Removed.
  • khtml/css/css_ruleimpl.h: Removed.
  • khtml/css/css_stylesheetimpl.cpp: Removed.
  • khtml/css/css_stylesheetimpl.h: Removed.
  • khtml/css/css_valueimpl.cpp: Removed.
  • khtml/css/css_valueimpl.h: Removed.
  • khtml/css/csshelper.cpp: Removed.
  • khtml/css/csshelper.h: Removed.
  • khtml/css/cssparser.cpp: Removed.
  • khtml/css/cssparser.h: Removed.
  • khtml/css/cssproperties.in: Removed.
  • khtml/css/cssstyleselector.cpp: Removed.
  • khtml/css/cssstyleselector.h: Removed.
  • khtml/css/cssvalues.in: Removed.
  • khtml/css/html4.css: Removed.
  • khtml/css/makeprop: Removed.
  • khtml/css/maketokenizer: Removed.
  • khtml/css/makevalues: Removed.
  • khtml/css/quirks.css: Removed.
  • khtml/css/tokenizer.flex: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGMaskElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
9:41 PM Changeset in webkit [12143] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):
6:37 PM Changeset in webkit [12142] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

  • svg/custom/recursive-clippath-expected.checksum: Added.
  • svg/custom/recursive-clippath-expected.png: Added.
  • svg/custom/recursive-clippath-expected.txt: Added.
  • svg/custom/recursive-clippath.svg: Added.
6:20 PM Changeset in webkit [12141] by ggaren
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

  • fast/js/date-proto-generic-invocation-expected.txt: Added.
  • fast/js/date-proto-generic-invocation.html: Added.
  • fast/js/resources/date-proto-generic-invocation.js: Added.
4:35 PM Changeset in webkit [12140] by hyatt
  • 2 edits
    22 moves
    3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bindings: Added.
  • bindings/js: Added.
  • bindings/objc: Added.
  • bindings/objc/DOM.h: Added.
  • bindings/objc/DOM.mm: Added.
  • bindings/objc/DOMCSS.h: Added.
  • bindings/objc/DOMCSS.mm: Added.
  • bindings/objc/DOMCore.h: Added.
  • bindings/objc/DOMEvents.h: Added.
  • bindings/objc/DOMEvents.mm: Added.
  • bindings/objc/DOMEventsInternal.h: Added.
  • bindings/objc/DOMExtensions.h: Added.
  • bindings/objc/DOMHTML.h: Added.
  • bindings/objc/DOMHTML.mm: Added.
  • bindings/objc/DOMHTMLInternal.h: Added.
  • bindings/objc/DOMInternal.h: Added.
  • bindings/objc/DOMInternal.mm: Added.
  • bindings/objc/DOMPrivate.h: Added.
  • bindings/objc/DOMRange.h: Added.
  • bindings/objc/DOMStylesheets.h: Added.
  • bindings/objc/DOMTraversal.h: Added.
  • bindings/objc/DOMUtility.mm: Added.
  • bindings/objc/DOMViews.h: Added.
  • bindings/objc/DOMViews.mm: Added.
  • bindings/objc/DOMViewsInternal.h: Added.
  • kwq/DOM-CSS.mm: Removed.
  • kwq/DOM.h: Removed.
  • kwq/DOM.mm: Removed.
  • kwq/DOMCSS.h: Removed.
  • kwq/DOMCore.h: Removed.
  • kwq/DOMEvents.h: Removed.
  • kwq/DOMEvents.mm: Removed.
  • kwq/DOMEventsInternal.h: Removed.
  • kwq/DOMExtensions.h: Removed.
  • kwq/DOMHTML.h: Removed.
  • kwq/DOMHTML.mm: Removed.
  • kwq/DOMHTMLInternal.h: Removed.
  • kwq/DOMInternal.h: Removed.
  • kwq/DOMInternal.mm: Removed.
  • kwq/DOMPrivate.h: Removed.
  • kwq/DOMRange.h: Removed.
  • kwq/DOMStylesheets.h: Removed.
  • kwq/DOMTraversal.h: Removed.
  • kwq/DOMUtility.mm: Removed.
  • kwq/DOMViews.h: Removed.
  • kwq/DOMViews.mm: Removed.
  • kwq/DOMViewsInternal.h: Removed.
3:43 PM Changeset in webkit [12139] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca
  • 4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.


  • WebInspector.subproj/webInspector/inspector.css:
  • WebInspector.subproj/webInspector/inspector.html:
  • WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.
2:25 PM Changeset in webkit [12137] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley.


  • fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
2:01 PM Changeset in webkit [12136] by ap
  • 4 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

  • khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
  • manual-tests/bugzilla-6473.html: Added.
1:46 PM Changeset in webkit [12135] by ap
  • 2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.
12:34 PM Changeset in webkit [12134] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Justin.

Test: editing/input/wrapped-line-char-rect.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start
12:25 PM Changeset in webkit [12133] by justing
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

  • editing/selection/replaced-boundaries-1-expected.checksum: Added.
  • editing/selection/replaced-boundaries-1-expected.png: Added.
  • editing/selection/replaced-boundaries-1-expected.txt: Added.
  • editing/selection/replaced-boundaries-1.html: Added.
  • editing/selection/replaced-boundaries-2-expected.checksum: Added.
  • editing/selection/replaced-boundaries-2-expected.png: Added.
  • editing/selection/replaced-boundaries-2-expected.txt: Added.
  • editing/selection/replaced-boundaries-2.html: Added.
  • editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • editing/selection/replaced-boundaries-3-expected.png: Added.
  • editing/selection/replaced-boundaries-3-expected.txt: Added.
  • editing/selection/replaced-boundaries-3.html: Added.
12:24 PM Changeset in webkit [12132] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)


Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
  • khtml/rendering/render_replaced.h:
12:04 PM Changeset in webkit [12131] by tomernic
  • 7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • actually removed QPtrDict itself
  • ForwardingHeaders/qptrdict.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
  • kwq/KWQPtrDict.h: Removed.
  • kwq/KWQPtrDictImpl.cpp: Removed.
  • kwq/KWQPtrDictImpl.h: Removed.
9:52 AM Changeset in webkit [12129] by darin
  • 83 edits in trunk/WebCore

Reviewed by John Sullivan.

  • removed all uses of QPtrDict, most uses of QMap
  • khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
  • khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
  • khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
  • khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
  • khtml/ecma/kjs_window.h: Use HashMap.
  • khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
  • khtml/ecma/xmlhttprequest.h: Ditto.
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
  • khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
  • khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
  • khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
  • khtml/xml/dom_elementimpl.h: Use HashMap.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
  • khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.
  • khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
  • khtml/xml/dom_stringimpl.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
  • kcanvas/RenderForeignObject.cpp: Ditto.
  • kcanvas/RenderForeignObject.h: Ditto.
  • kcanvas/RenderSVGImage.h: Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
  • khtml/css/css_ruleimpl.cpp: Ditto.
  • khtml/css/css_valueimpl.h: Ditto.
  • khtml/ecma/kjs_dom.h: Ditto.
  • khtml/ecma/kjs_html.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Ditto.
  • khtml/editing/delete_selection_command.cpp: Ditto.
  • khtml/html/html_tableimpl.cpp: Ditto.
  • khtml/khtml_events.cpp: Ditto.
  • khtml/rendering/RenderText.cpp: Ditto.
  • khtml/rendering/render_block.cpp: Ditto.
  • khtml/rendering/render_br.cpp: Ditto.
  • khtml/rendering/render_inline.cpp: Ditto.
  • khtml/rendering/render_object.cpp: Ditto.
  • khtml/rendering/render_replaced.cpp: Ditto.
  • khtml/xml/dom2_rangeimpl.cpp: Ditto.
  • kwq/DOM.mm: Ditto.
  • page/Frame.cpp: Ditto.
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
  • kcanvas/RenderSVGText.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
  • khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
  • khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.
  • khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
  • khtml/xml/dom_xmlimpl.h: Ditto.
  • ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
  • ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
  • ksvg2/svg/SVGPointImpl.cpp: Ditto.
  • kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.
  • kwq/KWQPainter.h: Added newly-needed include.
  • kwq/KWQPtrVector.h: Added append function.
  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
  • kwq/KWQVectorImpl.h: Added append.
  • kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.
  • kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
  • kwq/KWQWMatrix.h: Ditto.
  • loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.
  • loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
  • loader/CachedCSSStyleSheet.h: Ditto.
  • loader/CachedImage.cpp: Ditto.
  • loader/CachedImage.h: Ditto.
  • loader/CachedImageCallback.cpp: Ditto.
  • loader/CachedObject.cpp: Ditto.
  • loader/CachedObject.h: Ditto.
  • loader/CachedObjectClient.h: Ditto.
  • loader/CachedObjectClientWalker.cpp: Ditto.
  • loader/CachedObjectClientWalker.h: Ditto.
  • loader/CachedScript.cpp: Ditto.
  • loader/CachedScript.h: Ditto.
  • loader/CachedXSLStyleSheet.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
  • loader/loader.h: Ditto.
1:03 AM Changeset in webkit [12128] by eseidel
  • 5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

  • fast/box-sizing/percentage-height-expected.checksum:
  • fast/box-sizing/percentage-height-expected.png:
  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
12:49 AM Changeset in webkit [12127] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.
12:30 AM Changeset in webkit [12126] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.
12:05 AM Changeset in webkit [12125] by andersca
  • 2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.

Jan 15, 2006:

11:50 PM Changeset in webkit [12124] by eseidel
  • 3 edits in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Update out-of-date pixel results.

  • fast/dom/dom-parse-serialize-expected.checksum:
  • fast/dom/dom-parse-serialize-expected.png:
6:45 PM Changeset in webkit [12123] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
6:42 PM Changeset in webkit [12122] by thatcher
  • 24 edits
    38 adds in trunk

WebCore:

Reviewed by Darin.

Support for the new DOM Inspector.

  • khtml/ecma/kjs_dom.cpp: exposes scrollIntoViewIfNeeded to JS
  • khtml/ecma/kjs_dom.h:
  • khtml/rendering/RenderText.cpp: (RenderText::lineBoxRects): returns text run rects
  • khtml/rendering/RenderText.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::lineBoxRects): returns all child line box rects
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_object.cpp: (RenderObject::lineBoxRects): returns an empty list
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoViewIfNeeded): scrolls only if needed, bool decides to center to align to nearest edge
  • khtml/xml/dom_elementimpl.h: Ditto
  • kwq/DOM.mm: (-[DOMNode boundingBox]): returns the bounding box for a node (-[DOMNode lineBoxRects]): returns text runs for a node
  • kwq/DOMCore.h: added missing @protocol DOMEventListener and @class DOMEvent
  • kwq/DOMExtensions.h: removes methods that haven't been API reviewed
  • kwq/DOMPrivate.h: new pending public API added for the Inspector

WebKit:

Reviewed by Darin.


New DOM Inspector that lives in WebKit and is accessible from any WebView.
Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.


To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6571

5:29 PM Changeset in webkit [12121] by darin
  • 21 edits
    1 move in trunk/WebCore

Reviewed by Eric.

  • changed WebCore namespace change to work on Win32 as well as Mac OS X
  • WebCorePrefix.h: Removed things needed cross-platform.
  • config.h: Moved from khtml subdirectory. Added defines from WebCorePrefix.h, and added a define that makes KSVG a synonym for WebCore.
  • khtml/config.h: Removed.
  • khtml/css/css_grammar.y: Changed SVG functions to use function name rather than namespace to avoid collision with the XML and HTML DOM. Changes tabs to spaces.
  • khtml/css/css_valueimpl.cpp: (WebCore::propertyID): Add SVG properties ot the ones understood here. This allows us to set SVG properties from JavaScript.
  • ksvg2/scripts/cssmakeprops: Put functions inside the namespace to avoid compiler warning, and renamed functions to include CSS and SVG.
  • ksvg2/scripts/cssmakevalues: Ditto.
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::parseMappedAttribute): Use property ID function by its new name.
  • ksvg2/ksvg.h: Renamed ExceptionCode to SVGExceptionCode.
  • khtml/ecma/XSLTProcessor.cpp: Moved "config.h" header up above the ifdef so that the ifdef works.
  • khtml/xbl/xbl_binding.cpp: Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Ditto.
  • khtml/xbl/xbl_docimpl.cpp: Ditto.
  • khtml/xbl/xbl_protobinding.cpp: Ditto.
  • khtml/xbl/xbl_tokenizer.cpp: Ditto.
  • khtml/xsl/xsl_stylesheetimpl.cpp: Ditto.
  • khtml/xsl/xslt_processorimpl.cpp: Ditto.
  • loader/CachedXBLDocument.cpp: Ditto.
  • ksvg2/svg/SVGFELightElementImpl.h: Removed include of "config.h". That's supposed to only be included by code files, not headers.
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added missing include of "config.h". Did a few other tweaks to the file.
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp: Ditto.
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp: Ditto.
4:38 PM Changeset in webkit [12120] by eseidel
  • 19 edits in trunk/WebCore

2006-01-15 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Updated files w/ missing copyrights from Oliver.

  • kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel:
  • kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKPointLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel:
  • ksvg2/svg/SVGAnimatedColorImpl.cpp:
  • ksvg2/svg/SVGAnimatedColorImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp:
  • ksvg2/svg/SVGFEDistantLightElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp:
  • ksvg2/svg/SVGFEPointLightElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp:
  • ksvg2/svg/SVGFESpotLightElementImpl.h:
3:37 PM Changeset in webkit [12119] by darin
  • 2 adds in trunk/WebCore/khtml/editing

Oops, didn't check in these two files!

3:32 PM Changeset in webkit [12118] by darin
  • 23 edits in trunk/WebCore

Reviewed and tweaked a bit by Darin.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6523>
"Extract data from SelectionController"

This patch refactors the data portions of SelectionController into its
own class, "Selection".

The extracted data are the base/extent/start/end positions and cursor
affinity. Also a couple cached values generated by validation are kept around
in the new class.

This patch does away with all the different affinities
(start/end/base/extent) that were never implemented properly, since affinity
only makes sense when the selection is a caret (as per discussion with mjs and
darin on #webkit).

No test cases added because this is a refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::respondToChangedSelection):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionState]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge selectionAffinity]): (-[WebCoreFrameBridge setMarkDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
  • khtml/editing/Selection.cpp: Added. (khtml::Selection::Selection): (khtml::Selection::clear): (khtml::Selection::toRange): (khtml::Selection::validate): (khtml::Selection::adjustForEditableContent): (khtml::Selection::debugPosition):
  • khtml/editing/Selection.h: Added. (khtml::Selection::): (khtml::Selection::state): (khtml::Selection::setAffinity): (khtml::Selection::affinity): (khtml::Selection::setBase): (khtml::Selection::setExtent): (khtml::Selection::setStart): (khtml::Selection::setEnd): (khtml::Selection::base): (khtml::Selection::extent): (khtml::Selection::start): (khtml::Selection::end): (khtml::Selection::isNone): (khtml::Selection::isCaret): (khtml::Selection::isRange): (khtml::Selection::isCaretOrRange): (khtml::Selection::isBaseFirst): (khtml::operator==): (khtml::operator!=):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::operator=): (khtml::SelectionController::moveTo): (khtml::SelectionController::setModifyBias): (khtml::SelectionController::modifyExtendingRightForward): (khtml::SelectionController::modifyMovingRightForward): (khtml::SelectionController::modifyExtendingLeftBackward): (khtml::SelectionController::modifyMovingLeftBackward): (khtml::SelectionController::modify): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::xPosForVerticalArrowNavigation): (khtml::SelectionController::clear): (khtml::SelectionController::setBase): (khtml::SelectionController::setExtent): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::frame): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::needsCaretRepaint): (khtml::SelectionController::paintCaret): (khtml::SelectionController::debugRenderer): (khtml::SelectionController::formatForDebugger): (khtml::SelectionController::showTree):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::state): (khtml::SelectionController::affinity): (khtml::SelectionController::base): (khtml::SelectionController::extent): (khtml::SelectionController::start): (khtml::SelectionController::end): (khtml::SelectionController::isNone): (khtml::SelectionController::isCaret): (khtml::SelectionController::isRange): (khtml::SelectionController::isCaretOrRange): (khtml::SelectionController::toRange): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::operator==):
  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::updateStartEnd):
  • khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::doApply):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::doApply):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::markMisspellingsAfterTyping):
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::updateSelection):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]):
  • kwq/KWQRenderTreeDebug.cpp: (writeSelection):
  • page/Frame.cpp: (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::revealSelection): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart):


  • <a few other files, including editing ones>: Added includes since Selection.h and SelectionController.h now include fewer things.
2:38 PM Changeset in webkit [12117] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-overflow-selection.html


Reviewed by Darin.

  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): Clip selection rect to the text box (khtml::InlineTextBox::paintSelection): Clip selection painting to the text box.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): Remove code that re-added border width, since it is already included in availableWidth.
1:52 PM Changeset in webkit [12116] by darin
  • 16 edits in trunk/WebCore

Reviewed by Anders.

  • fix regression in duplicate ID layout test
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::getElementById): Change to take AtomicString, so we can use the string pointer as a hash key and not worry about ref'ing the pointer or about object lifetime since the string will be stored for the lifetime of the ID attribute. Also update for the counted set formerly named m_idCount to use its new name, m_duplicateIds. (DocumentImpl::addElementById): Ditto. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::recalcStyleSelector): Pass a DOMStringImpl* (see below).
  • khtml/xml/DocumentImpl.h: Change functions to take AtomicString.
  • kcanvas/KCanvasFilters.cpp: (getFilterById): Use AtomicString.
  • kcanvas/KCanvasFilters.h: Ditto.
  • kcanvas/KCanvasResources.cpp: (getResourceById): Ditto. (getMarkerById): Ditto. (getClipperById): Ditto. (getMaskerById): Ditto. (getPaintServerById): Ditto.
  • kcanvas/KCanvasResources.h: Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): Ditto.
  • khtml/html/HTMLLabelElementImpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Ditto.
  • khtml/xml/NodeListImpl.cpp: (DOM::NodeListImpl::itemById): Ditto.
  • khtml/xml/NodeListImpl.h: Ditto. Also removed unnecessary "virtual".
  • khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheetList::nameGetter): Pass a DOMStringImpl*, which gets converted to an AtomicString implicitly, rather than a DOMString, which does not. (But that's a crazy rule -- we should change this around long term.) (KJS::DOMStyleSheetList::getOwnPropertySlot): Ditto.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::nameGetter): Ditto. (KJS::DOMNodeList::getOwnPropertySlot): Ditto. (KJS::DOMDocumentProtoFunc::callAsFunction): Ditto.
  • Merge khtml, DOM, and KDOM into one big namespace, WebCore.
  • WebCorePrefix.h: Use defined to map the old namespace names to WebCore. Now that this is done in the prefix, we can start actually calling it by that name, phase out the old names, then remove the defines.
  • other changes
  • khtml/xml/DocumentTypeImpl.cpp: Converted tabs to spaces.
  • khtml/xml/dom2_eventsimpl.cpp: Ditto.
12:04 PM Changeset in webkit [12115] by andersca
  • 18 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Remove KCanvasCommonArgs and pass around RenderPath objects instead.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTypes.h: Removed.
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerImageQuartz::draw):
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGPatternElementImpl.h:
7:14 AM Changeset in webkit [12114] by darin
  • 22 edits
    5 deletes in trunk/WebCore

Reviewed by Hyatt.

I ran performance tests and the change results in a slight improvement.

  • bridge/mac/MacFrame.h: Removed include of KWQDict.h. Changed didTellBridgeAboutLoad and haveToldBridgeAboutLoad functions to take DOMString instead of QString. Changed urlsBridgeKnowsAbout from a QDict to a HashMap.
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad): Updated to use QDict and DOMString. (MacFrame::haveToldBridgeAboutLoad): Ditto.
  • khtml/editing/jsediting.h: Removed include of qdict.h.
  • khtml/rendering/render_frames.cpp: Removed include of qdict.h. Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. (khtml::RenderPartObject::updateWidget): Changed the local variable uniqueParamNames to be a HashSet instead of a QDict.
  • khtml/xml/DocumentImpl.h: Removed include of qdict.h, changed m_elementsById, m_idCount, and m_elementsByAccessKey to use HashMap and HashCountedSet instead of QDict.
  • khtml/xml/DocumentImpl.cpp: Changed tabs to spaces. (DocumentImpl::getElementById): Updated to use HashMap for m_elementsById and HashCountedSet for m_idCount. (DocumentImpl::addElementById): Ditto. Remove code to clear m_accessKeyDictValid, since setDocumentChanged already takes care of that. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Updated to use HashMap for m_elementsByAccessKey. (DocumentImpl::setDocumentChanged): Rearranged to do a couple fewer branches. Clear out the m_elementsByAccessKey map when clearing m_accessKeyMapValid to avoid keeping stale pointers around.
  • ksvg2/svg/SVGDocumentImpl.cpp: Removed include of q3dict.h.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed obsolete QDict sources.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • ForwardingHeaders/q3dict.h: Removed.
  • ForwardingHeaders/qdict.h: Removed.
  • kwq/KWQDict.h: Removed.
  • kwq/KWQDictImpl.cpp: Removed.
  • kwq/KWQDictImpl.h: Removed.
  • WebCore+SVG/SVGNamesWrapper.cpp: Touched this file just so I could build again.
  • kwq/KWQKURL.h: Removed unused canonicalURL, _path, _user, _pass, and _host functions.
  • kwq/KWQKURL.mm: Changed tabs to spaces, removed unused functions, replaced NULL with 0.
  • kwq/KWQLoader.mm: Changed tabs to spaces. (KWQServeRequest): Removed QString conversion from call to didTellBridgeAboutLoad. (KWQServeSynchronousRequest): Ditto. (KWQCheckCacheObjectStatus): Ditto. Same for haveToldBridgeAboutLoad.
  • loader/Cache.h: Removed include of qdict.h. Changed declaration of the LRUList struct to just be a forward declaration. Changed tabs to spaces. Removed the static data member called "cache". Added a static member function called get. Renamed removeCacheEntry to remove.
  • loader/Cache.cpp: Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. Changed the main cache itself to a HashMap and made it a static variable local to this file instead of a static data member of Cache to hide its type from the header. Also made the LRUList type private to this file. (khtml::Cache::init): Create a HashMap instead of a QDict. (khtml::Cache::clear): To replace the use of setAutoDelete, write a loop to delete all the items in the cache map. (khtml::Cache::requestImage): Change code to use HashMap functions instead of QDict. (khtml::Cache::requestStyleSheet): Ditto. (khtml::Cache::preloadStyleSheet): Ditto. (khtml::Cache::requestScript): Ditto. (khtml::Cache::preloadScript): Ditto. (khtml::Cache::requestXSLStyleSheet): Ditto. (khtml::Cache::requestXBLDocument): Ditto. (khtml::Cache::removeCacheEntry): Ditto. (khtml::Cache::FastLog2): Fixed this for 64-bit compiles. (khtml::Cache::getStatistics): Ditto. (khtml::Cache::flushAll): Ditto. (khtml::Cache::get): Added. Function used by the loader.
  • loader/CachedObject.h: Removed include of qdict.h.
  • loader/DocLoader.h: Removed include of qdict.h.
  • loader/DocLoader.cpp: (khtml::DocLoader::needReload): Changed to use new get function of Cache instead of getting at the map directly. Also changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImage.cpp: (khtml::CachedImage::data): Changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImageCallback.cpp: (khtml::CachedImageCallback::handleError): Ditto.
  • loader/loader.cpp: (khtml::Loader::slotFinished): Ditto. (khtml::Loader::cancelRequests): Ditto.
6:39 AM Changeset in webkit [12113] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • JavaScriptCore/tests/mozilla/Getopt/Mixed.pm: Changed revision number to 1.8 (broken by svn migration).
4:28 AM Changeset in webkit [12112] by eseidel
  • 1 edit
    1 move in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until results can be consistent:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Added.
4:03 AM Changeset in webkit [12111] by eseidel
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until timezone bug is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6547

  • fast/js/kde/Date-expected.txt: Removed.
  • fast/js/kde/Date.html: Removed.
  • fast/js/kde/Date.html-disabled: Added.
3:48 AM Changeset in webkit [12110] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-14 David Kilzer <​ddkilzer@kilzer.net>

Reviewed and landed by Anders.

  • kjs/create_hash_table: Fixed comment typo.
3:47 AM Changeset in webkit [12109] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<mask> inside <defs> crashes Safari.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
2:47 AM Changeset in webkit [12108] by eseidel
  • 39 edits in trunk

2006-01-15 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add basic <tspan> support using RenderInline.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6428
Also fix <text transform=""> while we're at it.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6552

  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::parseMappedAttribute): cleanup
  • ksvg2/svg/SVGTSpanElementImpl.cpp: (SVGTSpanElementImpl::childShouldCreateRenderer): added. (SVGTSpanElementImpl::createRenderer): added.
  • ksvg2/svg/SVGTSpanElementImpl.h: (KSVG::SVGTSpanElementImpl::rendererIsNeeded): added.
  • ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::transform): added. (SVGTextElementImpl::localMatrix): added. (SVGTextElementImpl::parseMappedAttribute): support transform. (SVGTextElementImpl::updateLocalTransform): added. (SVGTextElementImpl::attach): added. (SVGTextElementImpl::childShouldCreateRenderer): allow tspan.
  • ksvg2/svg/SVGTextElementImpl.h:
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute): code cleanup.
  • ksvg2/svg/SVGTransformableImpl.h:

Jan 14, 2006:

11:56 PM Changeset in webkit [12107] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Append an '=' to the cookie string if it has none, so that +[NSHTTPCookie cookiesWithResponseHeaderFields:forURL:] can parse it.
11:32 PM Changeset in webkit [12106] by hyatt
  • 3 edits
    2 moves
    1 delete in trunk/WebCore

Move arena.cpp/.h out of khtml/misc and into platform/Arena.cpp/h. Also removed another unused
header, khtmldata.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/misc/arena.cpp: Removed.
  • khtml/misc/arena.h: Removed.
  • khtml/misc/khtmldata.h: Removed.
  • khtml/rendering/render_arena.h:
  • platform/Arena.cpp: Added.
  • platform/Arena.h: Added.
11:12 PM Changeset in webkit [12105] by hyatt
  • 6 edits
    2 moves in trunk/WebCore

Rename TokenizerString to SegmentedString and place it in the platform directory.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::setSrc):
  • khtml/html/htmltokenizer.h:
  • khtml/misc/stringit.cpp: Removed.
  • khtml/misc/stringit.h: Removed.
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::write):
  • khtml/xml/xml_tokenizer.h:
  • platform/SegmentedString.cpp: Added. (WebCore::SegmentedString::length): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString):
  • platform/SegmentedString.h: Added. (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedString::SegmentedString):
10:09 PM Changeset in webkit [12104] by mjs
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Eric.

  • added bridging infrastructure for Page class


The Page class itself is coming very soon.

  • WebCore.exp: Export WebCorePageBridge.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCorePageBridge.h: Added.
  • bridge/mac/WebCorePageBridge.mm: Added. (-[WebCorePageBridge initWithMainFrame:]): Added new class, obvious (-[WebCorePageBridge dealloc]): ditto (-[WebCorePageBridge mainFrame]): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]): Fixed style a bit.

WebKit:

Reviewed by Eric.

  • added bridging infrastructure for Page class


  • WebCoreSupport.subproj/WebPageBridge.h: Added.
  • WebCoreSupport.subproj/WebPageBridge.m: Added. (-[WebPageBridge initWithMainFrameName:view:]): New class, somewhat obvious.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Don't use _mainFrameBrige, use _pageBridge (-[WebView _close]): ditto (-[WebView _commonInitializationWithFrameName:groupName:]): ditto (-[WebView mainFrame]): ditto
9:43 PM Changeset in webkit [12103] by eseidel
  • 15 edits
    23 adds in trunk

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Implement basic <foreignObject> support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5974
Also fixed <image> to support clip, filter and mask
Updated <text> to support hit testing and clip, filter, mask

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/RenderForeignObject.cpp: Added. (RenderForeignObject::RenderForeignObject): (RenderForeignObject::translationForAttributes): (RenderForeignObject::paint): (RenderForeignObject::nodeAtPoint):
  • kcanvas/RenderForeignObject.h: Added. (RenderForeignObject::renderName): added. (RenderForeignObject::localTransform): added. (RenderForeignObject::setLocalTransform): added.
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): added filter, clip mask support
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::localTransform): added. (KSVG::RenderSVGImage::setLocalTransform): added.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::translationTopToBaseline): return qmatrix (RenderSVGText::translationForAttributes): return qmatrix (RenderSVGText::paint): added filter, clip, mask support (RenderSVGText::nodeAtPoint): added.
  • kcanvas/RenderSVGText.h: (RenderSVGText::localTransform): added. (RenderSVGText::setLocalTransform): added.
  • khtml/rendering/render_object.h: (khtml::RenderObject::setLocalTransform): added assert(0)
  • ksvg2/css/svg.css: added foreignObject display: block
  • ksvg2/svg/SVGForeignObjectElementImpl.cpp: Added. (KSVG::SVGForeignObjectElementImpl::SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::~SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::x): (KSVG::SVGForeignObjectElementImpl::y): (KSVG::SVGForeignObjectElementImpl::width): (KSVG::SVGForeignObjectElementImpl::height): (KSVG::SVGForeignObjectElementImpl::parseMappedAttribute): (KSVG::SVGForeignObjectElementImpl::createRenderer): (KSVG::SVGForeignObjectElementImpl::childShouldCreateRenderer):
  • ksvg2/svg/SVGForeignObjectElementImpl.h: Added. (KSVG::SVGForeignObjectElementImpl::isValid): added (KSVG::SVGForeignObjectElementImpl::rendererIsNeeded): added
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach): fixed static_cast
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::nearestViewportElement): foreignObject support (SVGLocatableImpl::farthestViewportElement): foreignObject support
  • ksvg2/svg/svgtags.in: added foreignObject
  • kwq/KWQWMatrix.cpp: (QWMatrix::isInvertible): fixed
8:55 PM Changeset in webkit [12102] by hyatt
  • 4 edits in trunk/WebCore

More khtml namespace bustage, this time on Win32 (caused by the removal of SHared from the khtml namespace.

8:48 PM Changeset in webkit [12101] by hyatt
  • 80 edits
    1 move
    1 delete in trunk/WebCore

Move shared.h from khtml/misc into the platform directory and move it into the WebCore namespace.

Reviewed by eseidel

  • ForwardingHeaders/kdom/Shared.h: Removed.
  • WebCore+SVG/DOMList.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/RGBColorImpl.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/htmlediting.h:
  • khtml/editing/visible_position.h:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/misc/shared.h: Removed.
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_style.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeListImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::SVGAngleImpl):
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimatedBooleanImpl.cpp: (SVGAnimatedBooleanImpl::SVGAnimatedBooleanImpl):
  • ksvg2/svg/SVGAnimatedBooleanImpl.h:
  • ksvg2/svg/SVGAnimatedEnumerationImpl.cpp: (SVGAnimatedEnumerationImpl::SVGAnimatedEnumerationImpl):
  • ksvg2/svg/SVGAnimatedEnumerationImpl.h:
  • ksvg2/svg/SVGAnimatedIntegerImpl.cpp: (SVGAnimatedIntegerImpl::SVGAnimatedIntegerImpl):
  • ksvg2/svg/SVGAnimatedIntegerImpl.h:
  • ksvg2/svg/SVGAnimatedLengthListImpl.h:
  • ksvg2/svg/SVGAnimatedNumberImpl.cpp: (SVGAnimatedNumberImpl::SVGAnimatedNumberImpl):
  • ksvg2/svg/SVGAnimatedNumberImpl.h:
  • ksvg2/svg/SVGAnimatedNumberListImpl.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimatedTransformListImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::SVGLengthImpl):
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl):
  • ksvg2/svg/SVGMatrixImpl.h:
  • ksvg2/svg/SVGNumberImpl.cpp: (SVGNumberImpl::SVGNumberImpl):
  • ksvg2/svg/SVGNumberImpl.h:
  • ksvg2/svg/SVGPathSegImpl.cpp: (SVGPathSegImpl::SVGPathSegImpl):
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
  • ksvg2/svg/SVGPointImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
  • ksvg2/svg/SVGPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGRectImpl.cpp: (SVGRectImpl::SVGRectImpl):
  • ksvg2/svg/SVGRectImpl.h:
  • ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl):
  • ksvg2/svg/SVGTransformImpl.h:
  • kwq/DOM-CSS.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate):
  • kwq/KWQVariant.cpp:
  • platform/ArrayImpl.h:
  • platform/Shared.h: Added.
7:33 PM Changeset in webkit [12100] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Fix build break. (oops!)

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
7:29 PM Changeset in webkit [12099] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Initialize m_isXHTMLDocument(false) properly.
No tests possible, random failure only.

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
6:57 PM Changeset in webkit [12098] by eseidel
  • 4 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for svg css property writing-mode.

  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::InheritedFlags::): (KSVG::SVGRenderStyle::setBitDefaults):
  • ksvg2/css/SVGRenderStyleDefs.h: (KSVG::):
6:42 PM Changeset in webkit [12097] by eseidel
  • 13 edits in trunk/WebCore

2006-01-14 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Refactor out cases of KCanvasRenderingStyle used as an instance to
store the current style. Temporarily unify the data passing via
KCanvasCommonArgs.

  • kcanvas/KCanvasItem.cpp: Removing override of setStyle used to hook into KCanvasRenderingStyle::updateStyle. (RenderPath::commonArgs):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::KCanvasCommonArgs): (KCanvasCommonArgs::renderStyle): (KCanvasCommonArgs::setRenderStyle): (KCanvasCommonArgs::renderPath): (KCanvasCommonArgs::setRenderPath):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): (KCanvasItemQuartz::bboxForPath): (KCanvasItemQuartz::hitsPath):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: Remove overrideFillPaintServer and overrideStrokePaintServer hacks and make most other methods static, remove most instance variables. (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::isFilled): (KCanvasRenderingStyle::fillPaintServer): (KCanvasRenderingStyle::isStroked): (KCanvasRenderingStyle::strokePaintServer): (KCanvasRenderingStyle::strokePainter): Merged stroke logic in from updateStyle. (KCanvasRenderingStyle::fillPainter): Merged fill logic in from updateStyle.
  • ksvg2/misc/KCanvasRenderingStyle.h:
6:39 PM Changeset in webkit [12096] by hyatt
  • 1 edit in trunk/WebCore/ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h

Fix mac bustage from kdom forwarding header.

6:38 PM Changeset in webkit [12095] by hyatt
  • 2 edits in trunk/WebCore

Fix win32 build bustage caused by the file moves all day.

6:38 PM Changeset in webkit [12094] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage caused by the file moves all day.

6:31 PM Changeset in webkit [12093] by eseidel
  • 1 edit
    4 moves
    12 deletes in trunk/LayoutTests

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Disabling text-intro* tests until font fallback is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6524

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Added.
6:15 PM Changeset in webkit [12092] by hyatt
  • 14 edits
    1 move in trunk/WebCore

Move loader_client.h to CachedObjectClient.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_html.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/rendering/render_object.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xsl_stylesheetimpl.h:
  • loader/CachedObject.h:
  • loader/CachedObjectClient.h: Added.
  • loader/CachedObjectClientWalker.h:
  • loader/loader_client.h: Removed.
6:13 PM Changeset in webkit [12091] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

6:09 PM Changeset in webkit [12090] by andersca
  • 9 edits
    8 deletes in trunk/WebCore

2006-01-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Dave.

  • ForwardingHeaders/kglobalsettings.h: Removed.
  • ForwardingHeaders/kimageio.h: Removed.
  • ForwardingHeaders/qasyncio.h: Removed.
  • ForwardingHeaders/qstylesheet.h: Removed.
  • kwq/KWQAsyncIO.h: Removed.
  • kwq/KWQKGlobalSettings.h: Removed.
  • kwq/KWQKImageIO.h: Removed.
  • kwq/KWQStyleSheet.h: Removed.


  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::recalcStyle):
  • loader/CachedImageCallback.cpp:
  • loader/CachedObject.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp: (KHTMLView::KHTMLView): Remove header inclusions


5:16 PM Changeset in webkit [12089] by hyatt
  • 64 edits
    25 moves
    1 add in trunk/WebCore

Shift the loader-related files out of the khtml/misc directory and into a new loader directory.
Remove the use of paths when including files from misc.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssparser.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_canvasimpl.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/Cache.cpp: Removed.
  • khtml/misc/Cache.h: Removed.
  • khtml/misc/CachedCSSStyleSheet.cpp: Removed.
  • khtml/misc/CachedCSSStyleSheet.h: Removed.
  • khtml/misc/CachedImage.cpp: Removed.
  • khtml/misc/CachedImage.h: Removed.
  • khtml/misc/CachedImageCallback.cpp: Removed.
  • khtml/misc/CachedImageCallback.h: Removed.
  • khtml/misc/CachedObject.cpp: Removed.
  • khtml/misc/CachedObject.h: Removed.
  • khtml/misc/CachedObjectClientWalker.cpp: Removed.
  • khtml/misc/CachedObjectClientWalker.h: Removed.
  • khtml/misc/CachedScript.cpp: Removed.
  • khtml/misc/CachedScript.h: Removed.
  • khtml/misc/CachedXBLDocument.cpp: Removed.
  • khtml/misc/CachedXBLDocument.h: Removed.
  • khtml/misc/CachedXSLStyleSheet.cpp: Removed.
  • khtml/misc/CachedXSLStyleSheet.h: Removed.
  • khtml/misc/DocLoader.cpp: Removed.
  • khtml/misc/DocLoader.h: Removed.
  • khtml/misc/Request.cpp: Removed.
  • khtml/misc/Request.h: Removed.
  • khtml/misc/loader.cpp: Removed.
  • khtml/misc/loader.h: Removed.
  • khtml/misc/loader_client.h: Removed.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvasimage.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.h:
  • khtml/xbl/xbl_binding.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp:
  • kwq/KWQVariant.cpp:
  • loader: Added.
  • loader/Cache.cpp: Added.
  • loader/Cache.h: Added.
  • loader/CachedCSSStyleSheet.cpp: Added.
  • loader/CachedCSSStyleSheet.h: Added.
  • loader/CachedImage.cpp: Added.
  • loader/CachedImage.h: Added.
  • loader/CachedImageCallback.cpp: Added.
  • loader/CachedImageCallback.h: Added.
  • loader/CachedObject.cpp: Added.
  • loader/CachedObject.h: Added.
  • loader/CachedObjectClientWalker.cpp: Added.
  • loader/CachedObjectClientWalker.h: Added.
  • loader/CachedScript.cpp: Added.
  • loader/CachedScript.h: Added.
  • loader/CachedXBLDocument.cpp: Added.
  • loader/CachedXBLDocument.h: Added.
  • loader/CachedXSLStyleSheet.cpp: Added.
  • loader/CachedXSLStyleSheet.h: Added.
  • loader/DocLoader.cpp: Added.
  • loader/DocLoader.h: Added.
  • loader/Request.cpp: Added.
  • loader/Request.h: Added.
  • loader/loader.cpp: Added.
  • loader/loader.h: Added.
  • loader/loader_client.h: Added.
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • page/FrameView.cpp:
5:12 PM Changeset in webkit [12088] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Missed ChangeLog in previous commit.

5:10 PM Changeset in webkit [12087] by eseidel
  • 55 edits
    9 copies
    2 moves
    1 delete in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

break classes in dom_nodeimpl.* into separate files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6543

  • ForwardingHeaders/kdom/core/NodeImpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/css/css_base.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/remove_node_attribute_command.h:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/set_node_attribute_command.h:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/khtml_events.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_object.h:
  • khtml/xml/ChildNodeListImpl.cpp: Added.
  • khtml/xml/ChildNodeListImpl.h: Added.
  • khtml/xml/ContainerNodeImpl.cpp: Added. (DOM::ContainerNodeImpl::removeAllChildren): (DOM::ContainerNodeImpl::checkSameDocument): (DOM::ContainerNodeImpl::getRect): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents):
  • khtml/xml/ContainerNodeImpl.h: Added.
  • khtml/xml/DocumentFragmentImpl.cpp:
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h: (DOM::DocumentImpl::setTextColor):
  • khtml/xml/DocumentTypeImpl.cpp:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/NameNodeListImpl.cpp: Added.
  • khtml/xml/NameNodeListImpl.h: Added.
  • khtml/xml/NamedNodeMapImpl.h: Added. (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::~NamedNodeMapImpl):
  • khtml/xml/NodeImpl.cpp: Added. (DOM::TagNodeListImpl::TagNodeListImpl): (DOM::TagNodeListImpl::length): (DOM::TagNodeListImpl::item): (DOM::TagNodeListImpl::nodeMatches): (DOM::NodeImpl::getRect):
  • khtml/xml/NodeImpl.h: Added.
  • khtml/xml/NodeListImpl.cpp: Added.
  • khtml/xml/NodeListImpl.h: Added.
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Removed.
  • khtml/xml/dom_nodeimpl.h: Removed.
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • kwq/DOM.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMUtility.mm:
  • kwq/KWQClipboard.h:
  • page/FrameView.cpp:
3:29 PM Changeset in webkit [12086] by hyatt
  • 35 edits
    3 moves
    1 delete in trunk/WebCore

Convert QMemArray to Array. QByteArray becomes ByteArray.
KWQArrayImpl becomes ArrayImpl.

Reviewed by anders

  • ForwardingHeaders/qmemarray.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::processSyncLoadResults):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/html/HTMLOptionElementImpl.cpp: (DOM::HTMLOptionElementImpl::index):
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::selectedIndex): (DOM::HTMLSelectElementImpl::setSelectedIndex): (DOM::HTMLSelectElementImpl::length): (DOM::HTMLSelectElementImpl::remove): (DOM::HTMLSelectElementImpl::value): (DOM::HTMLSelectElementImpl::setValue): (DOM::HTMLSelectElementImpl::state): (DOM::HTMLSelectElementImpl::restoreState): (DOM::HTMLSelectElementImpl::appendFormData): (DOM::HTMLSelectElementImpl::optionToListIndex): (DOM::HTMLSelectElementImpl::listToOptionIndex): (DOM::HTMLSelectElementImpl::reset): (DOM::HTMLSelectElementImpl::notifyOptionSelected):
  • khtml/html/HTMLSelectElementImpl.h: (DOM::HTMLSelectElementImpl::listItems):
  • khtml/misc/formdata.cpp: (khtml::FormData::flatten): (khtml::FormData::flattenToString):
  • khtml/misc/formdata.h: (khtml::FormDataElement::FormDataElement):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderSelect::slotSelected): (RenderSelect::slotSelectionChanged): (RenderSelect::updateSelection):
  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): (RenderTableSection::setCellWidths):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):
  • khtml/rendering/table_layout.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQArrayImpl.cpp: Removed.
  • kwq/KWQArrayImpl.h: Removed.
  • kwq/KWQBuffer.cpp: (QBuffer::setBuffer):
  • kwq/KWQBuffer.h: (QBuffer::QBuffer): (QBuffer::buffer):
  • kwq/KWQCString.cpp: (QCString::QCString): (QCString::resize): (QCString::append):
  • kwq/KWQCString.h:
  • kwq/KWQKURL.mm: (findHostnamesInMailToURL): (encodeHostnames):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
  • kwq/KWQMemArray.h: Removed.
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::receivedData):
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (QString::QString):
  • kwq/KWQTextCodec.cpp: (QTextCodec::toUnicode):
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.cpp: (QTextStream::QTextStream):
  • kwq/KWQTextStream.h:
  • page/Frame.h:
  • platform/Array.h: Added. (WebCore::Array::Array): (WebCore::Array::duplicate): (WebCore::Array::assign): (WebCore::Array::operator==): (WebCore::Array::operator!=):
  • platform/ArrayImpl.cpp: Added. (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate): (WebCore::ArrayImpl::ArrayPrivate::~ArrayPrivate): (WebCore::ArrayImpl::ArrayImpl): (WebCore::ArrayImpl::~ArrayImpl): (WebCore::ArrayImpl::operator=): (WebCore::ArrayImpl::data): (WebCore::ArrayImpl::resize): (WebCore::ArrayImpl::duplicate): (WebCore::ArrayImpl::detach): (WebCore::ArrayImpl::fill): (WebCore::ArrayImpl::operator==):
  • platform/ArrayImpl.h: Added. (WebCore::ArrayImpl::size):
  • platform/IntPointArray.cpp: (IntPointArray::setPoint):
  • platform/IntPointArray.h: (WebCore::IntPointArray::IntPointArray):
2:07 PM Changeset in webkit [12085] by hyatt
  • 124 edits
    4 moves
    2 adds
    1 delete in trunk/WebCore

Convert QRect/QRectF -> IntRect/FloatRect. Same drill as point
and size.

Reviewed by mjs

  • ForwardingHeaders/qrect.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::snapshotDragImage): (MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:withPainter:]): (-[WebCoreFrameBridge firstRectForDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]):
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::relativeBBox): (KCanvasContainer::getAspectRatio):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp: (KCanvasFilterEffect::subRegion): (KCanvasFilterEffect::setSubRegion):
  • kcanvas/KCanvasFilters.h: (KCanvasFilter::filterRect): (KCanvasFilter::setFilterRect):
  • kcanvas/KCanvasItem.cpp: (RenderPath::relativeBBox):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::setBbox): (KRenderingPaintServerPattern::bbox):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (drawMarkerWithData): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::bboxForPath):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::layout): (KCanvasContainerQuartz::paint): (KCanvasContainerQuartz::setViewport): (KCanvasContainerQuartz::viewport): (KCanvasContainerQuartz::setViewBox): (KCanvasContainerQuartz::viewBox): (KCanvasContainerQuartz::absoluteTransform): (KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::mapFromVisual): (KRenderingDeviceContextQuartz::mapToVisual):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::caretY): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::caretRepaintRect): (khtml::SelectionController::paintCaret):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::getRect):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isFocusable):
  • khtml/misc/CachedImage.cpp: (khtml::CachedImage::valid_rect): (khtml::CachedImage::do_notify): (khtml::CachedImage::error):
  • khtml/misc/CachedImage.h:
  • khtml/misc/khtmllayout.h: (khtml::GapRects::left): (khtml::GapRects::center): (khtml::GapRects::right): (khtml::GapRects::uniteLeft): (khtml::GapRects::uniteCenter): (khtml::GapRects::uniteRight): (khtml::GapRects::operator IntRect):
  • khtml/misc/loader_client.h: (khtml::CachedObjectClient::setPixmap):
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): (khtml::InlineTextBox::nodeAtPoint):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/RenderText.cpp: (khtml::RenderText::absoluteRects): (khtml::RenderText::caretRect): (khtml::RenderText::getAbsoluteRepaintRect): (khtml::RenderText::selectionRect):
  • khtml/rendering/RenderText.h:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/font.cpp: (khtml::Font::selectionRectForText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::overflowRect): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::paint): (khtml::RenderBlock::fillHorizontalSelectionGap): (khtml::RenderBlock::fillVerticalSelectionGap): (khtml::RenderBlock::fillLeftSelectionGap): (khtml::RenderBlock::fillRightSelectionGap): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::selectionRect):
  • khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgroundExtended): (RenderBox::getOverflowClipRect): (RenderBox::getClipRect): (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::caretRect):
  • khtml/rendering/render_box.h: (khtml::RenderBox::borderBox):
  • khtml/rendering/render_br.cpp: (khtml::RenderBR::caretRect):
  • khtml/rendering/render_br.h: (khtml::RenderBR::selectionRect):
  • khtml/rendering/render_button.cpp: (khtml::RenderButton::paintObject):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle): (RenderCanvas::getAbsoluteRepaintRect): (RenderCanvas::computeAbsoluteRepaintRect): (RenderCanvas::absoluteRects): (RenderCanvas::selectionRect): (RenderCanvas::viewRect):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printRect): (khtml::RenderCanvas::setPrintRect):
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint): (RenderCanvasImage::layout):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect): (RenderFlow::caretRect): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
  • khtml/rendering/render_image.cpp: (RenderImage::setImage): (RenderImage::setPixmap): (RenderImage::paint): (RenderImage::layout):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::updateLayerPositions): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::getRectToExpose): (khtml::RenderLayer::positionScrollbars): (khtml::RenderLayer::updateScrollInfoAfterLayout): (khtml::RenderLayer::paintScrollbars): (khtml::RenderLayer::paint): (khtml::setClip): (khtml::restoreClip): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTest): (khtml::RenderLayer::hitTestLayer): (khtml::RenderLayer::calculateClipRects): (khtml::RenderLayer::calculateRects): (khtml::mustExamineRenderer): (khtml::RenderLayer::intersectsDamageRect): (khtml::RenderLayer::containsPoint):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::m_refCnt): (khtml::ClipRects::overflowClipRect): (khtml::ClipRects::fixedClipRect): (khtml::ClipRects::posClipRect): (khtml::RenderLayer::repaintRect):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::canAccommodateEllipsis): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::EllipsisBox::nodeAtPoint):
  • khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::setPixmap):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorderImage): (RenderObject::paintBorder): (RenderObject::absoluteRects): (RenderObject::absoluteBoundingBoxRect): (RenderObject::addAbsoluteRectForLayer): (RenderObject::paintingRootRect): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::getAbsoluteRepaintRectWithOutline): (RenderObject::getAbsoluteRepaintRect): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::computeAbsoluteRepaintRect): (RenderObject::viewRect): (RenderObject::caretRect): (RenderObject::addDashboardRegions): (RenderObject::setPixmap):
  • khtml/rendering/render_object.h: (khtml::RenderObject::getOverflowClipRect): (khtml::RenderObject::getClipRect): (khtml::RenderObject::relativeBBox): (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::RepaintInfo::m_repaintRect): (khtml::RenderObject::borderBox): (khtml::RenderObject::overflowRect): (khtml::RenderObject::floatRect): (khtml::RenderObject::selectionRect): (khtml::RenderObject::SelectionInfo::rect):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::selectionRect): (RenderWidget::paint): (RenderWidget::updateWidgetPosition):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableRow::getAbsoluteRepaintRect): (RenderTableCell::computeAbsoluteRepaintRect): (RenderTableCell::getAbsoluteRepaintRect): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint):
  • khtml/rendering/render_theme.h: (khtml::RenderTheme::adjustRepaintRect):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustRepaintRect): (khtml::RenderThemeMac::inflateRect): (khtml::RenderThemeMac::paintCheckbox): (khtml::RenderThemeMac::setCheckboxCellState): (khtml::RenderThemeMac::paintRadio): (khtml::RenderThemeMac::setRadioCellState): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::getRect): (DOM::ContainerNodeImpl::getRect):
  • khtml/xml/dom_nodeimpl.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::createRenderer):
  • kwq/KWQAccObject.mm: (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject doAXBoundsForTextMarkerRange:]):
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): (QDesktopWidget::availableGeometry):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::selectionRectForText): (QFontMetrics::boundingRect):
  • kwq/KWQKWinModule.h:
  • kwq/KWQKWinModule.mm: (KWinModule::workArea):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::xForm): (QPainter::drawPixmap): (QPainter::fillRect): (QPainter::addClip): (QPainter::addRoundedRectClip):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::setAnimationRect): (QPixmap::rect):
  • kwq/KWQRect.h: Removed.
  • kwq/KWQRect.mm: Removed.
  • kwq/KWQRectF.h: Removed.
  • kwq/KWQRectF.mm: Removed.
  • kwq/KWQRegion.cpp: (QRegion::QRegion): (QRegion::boundingRect):
  • kwq/KWQRegion.h:
  • kwq/KWQRenderTreeDebug.cpp: (operator<<): (write): (writeLayers): (externalRepresentation):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::updateContents):
  • kwq/KWQWMatrix.cpp: (QWMatrix::mapRect):
  • kwq/KWQWMatrix.h:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::resize): (QWidget::move): (QWidget::frameGeometry): (QWidget::setFrameGeometry): (QWidget::paint):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): (KWQWindowWidget::setFrameGeometry):
  • page/Frame.cpp: (Frame::gotoAnchor): (Frame::paintCaret): (Frame::paintDragCaret): (Frame::selectionRect): (Frame::revealSelection): (Frame::paint): (Frame::adjustPageHeight): (Frame::centerSelectionInVisibleArea):
  • page/Frame.h:
  • page/FrameView.cpp: (KHTMLView::addRepaintInfo): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::repaintRectangle):
  • page/FrameView.h:
  • platform/FloatRect.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::isNull): (WebCore::FloatRect::isValid): (WebCore::FloatRect::isEmpty): (WebCore::FloatRect::right): (WebCore::FloatRect::bottom): (WebCore::FloatRect::topLeft): (WebCore::FloatRect::topRight): (WebCore::FloatRect::bottomRight): (WebCore::FloatRect::bottomLeft): (WebCore::FloatRect::size): (WebCore::FloatRect::unite): (WebCore::FloatRect::normalize): (WebCore::FloatRect::intersects): (WebCore::FloatRect::intersect): (WebCore::FloatRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/FloatRect.h: Added. (WebCore::FloatRect::contains): (WebCore::FloatRect::operator&): (WebCore::enclosingIntRect):
  • platform/IntPointArray.cpp: (IntPointArray::IntPointArray): (IntPointArray::boundingRect):
  • platform/IntPointArray.h:
  • platform/IntRect.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::isNull): (WebCore::IntRect::isValid): (WebCore::IntRect::isEmpty): (WebCore::IntRect::right): (WebCore::IntRect::bottom): (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::size): (WebCore::IntRect::unite): (WebCore::IntRect::normalize): (WebCore::IntRect::intersects): (WebCore::IntRect::intersect): (WebCore::IntRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/IntRect.h: Added. (WebCore::IntRect::contains): (WebCore::IntRect::operator&):
  • platform/mac/FloatRect.mm: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator NSRect): (WebCore::FloatRect::operator CGRect):
  • platform/mac/IntRect.mm: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator NSRect): (WebCore::IntRect::operator CGRect):

Jan 13, 2006:

10:56 PM Changeset in webkit [12084] by hyatt
  • 18 edits
    2 moves
    1 add in trunk/WebCore

Convert QPointF to FloatPoint and move it to the platform
directory.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::fillContains): (KCanvasContainer::strokeContains):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEConvolveMatrix::kernelUnitLength): (KCanvasFEConvolveMatrix::setKernelUnitLength):
  • kcanvas/KCanvasItem.cpp: (RenderPath::fillContains): (RenderPath::strokeContains):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerLinearGradient::gradientStart): (KRenderingPaintServerLinearGradient::setGradientStart): (KRenderingPaintServerLinearGradient::gradientEnd): (KRenderingPaintServerLinearGradient::setGradientEnd): (KRenderingPaintServerRadialGradient::gradientCenter): (KRenderingPaintServerRadialGradient::setGradientCenter): (KRenderingPaintServerRadialGradient::gradientFocal): (KRenderingPaintServerRadialGradient::setGradientFocal):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector):
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::nodeAtPoint): (KCanvasItemQuartz::hitsPath):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient):
  • kwq/KWQPointF.h: Removed.
  • kwq/KWQPointF.mm: Removed.
  • kwq/KWQRectF.h: (QRectF::contains):
  • kwq/KWQRectF.mm: (QRectF::QRectF): (QRectF::topLeft): (QRectF::topRight): (QRectF::bottomRight): (QRectF::bottomLeft):
  • platform/FloatPoint.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::yCoord): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
  • platform/FloatPoint.h: Added. (WebCore::FloatPoint::operator -=):
  • platform/mac/FloatPoint.mm: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator NSPoint): (WebCore::FloatPoint::operator CGPoint):
10:13 PM Changeset in webkit [12083] by hyatt
  • 50 edits
    3 moves
    2 adds
    2 deletes in trunk/WebCore

Convert QPoint and QPointArray to IntPoint and IntPointArray.
Factor out the Objective-C-specific logic into a .mm file
for IntPoint.


  • ForwardingHeaders/qpoint.h: Removed.
  • ForwardingHeaders/qpointarray.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLView.cpp: (KHTMLView::viewportToGlobal):
  • bridge/mac/KWQKPartsBrowserExtension.h:
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::khtmlMouseMoveEvent): (MacFrame::dragSourceMovedTo): (MacFrame::dragSourceEndedAt): (MacFrame::dispatchDragSrcEvent):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::layout): (khtml::SelectionController::caretRect):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::mapMouseEvent): (DOM::HTMLAreaElementImpl::getRegion):
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
  • ksvg2/svg/SVGPointImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::createSVGPoint):
  • ksvg2/svg/SVGSVGElementImpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (KWQClipboard::dragLocation): (KWQClipboard::setDragImage): (KWQClipboard::setDragImageElement):
  • kwq/KWQCursor.h:
  • kwq/KWQEvent.h: (QMouseEvent::pos): (QWheelEvent::QWheelEvent): (QWheelEvent::pos): (QWheelEvent::globalPos):
  • kwq/KWQEvent.mm: (positionForEvent): (globalPositionForEvent):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawConvexPolygon): (QPainter::drawPixmap):
  • kwq/KWQPixmap.mm: (QPixmap::rect):
  • kwq/KWQPoint.mm: Removed.
  • kwq/KWQPointArray.cpp: Removed.
  • kwq/KWQPointArray.h: Removed.
  • kwq/KWQPointF.h:
  • kwq/KWQPointF.mm: (yCoord):
  • kwq/KWQRect.h: (QRect::moveTopLeft): (QRect::contains):
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::topLeft): (QRect::topRight): (QRect::bottomRight): (QRect::bottomLeft):
  • kwq/KWQRegion.cpp: (QRegion::QRegion): (QRegion::contains):
  • kwq/KWQRegion.h:
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::contentsToViewport):
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::pos): (QWidget::move): (QWidget::mapFromGlobal):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::mapFromGlobal): (KWQWindowWidget::viewportToGlobal):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (KHTMLView::dispatchDragEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • page/FrameView.h:
  • platform/IntPoint.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
  • platform/IntPoint.h: Added. (WebCore::IntPoint::x): (WebCore::IntPoint::y): (WebCore::IntPoint::setX): (WebCore::IntPoint::setY): (WebCore::IntPoint::isNull): (WebCore::IntPoint::operator -=):
  • platform/IntPointArray.cpp: Added. (IntPointArray::IntPointArray): (IntPointArray::copy): (IntPointArray::boundingRect): (IntPointArray::point): (IntPointArray::setPoint): (IntPointArray::setPoints):
  • platform/IntPointArray.h: Added. (WebCore::IntPointArray::IntPointArray):
3:54 PM Changeset in webkit [12082] by hyatt
  • 1 edit in trunk/WebCore/kcanvas/KCanvasTreeDebug.h

Forgot to wrap FloatSize in a namespace. Fixing this.

3:41 PM Changeset in webkit [12081] by hyatt
  • 4 edits in trunk/WebCore

Forgot to wrap FloatSize in a namespace. Fixing this.

3:28 PM Changeset in webkit [12080] by hyatt
  • 7 edits
    2 moves
    1 add in trunk/WebCore

Convert QSizeF to FloatSize and move it to the platform
directory.


  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasFilters.h: (KCanvasFEConvolveMatrix::kernelSize): (KCanvasFEConvolveMatrix::setKernelSize): (KCanvasFEConvolveMatrix::targetOffset): (KCanvasFEConvolveMatrix::setTargetOffset):
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kwq/KWQRectF.h:
  • kwq/KWQRectF.mm: (QRectF::QRectF): (QRectF::size):
  • kwq/KWQSizeF.h: Removed.
  • kwq/KWQSizeF.mm: Removed.
  • platform/FloatSize.cpp: Added. (FloatSize::FloatSize): (FloatSize::isValid): (FloatSize::expandedTo): (operator+): (operator==): (operator!=):
  • platform/FloatSize.h: Added.
  • platform/mac/FloatSize.mm: Added. (FloatSize::FloatSize): (FloatSize::operator NSSize): (FloatSize::operator CGSize):
2:51 PM Changeset in webkit [12079] by hyatt
  • 1 edit in trunk/WebCore/kwq/KWQSizeF.mm

Fix the last bit of bustage.

2:32 PM Changeset in webkit [12078] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage from QSize -> IntSize change.


Reviewed by darin

  • kwq/KWQObject.h:
  • kwq/KWQSizeF.h:
2:04 PM Changeset in webkit [12077] by hyatt
  • 52 edits
    2 moves
    3 adds in trunk/WebCore

Eliminate QSize and add the new class IntSize in the
platform subdirectory. Factor out the Objective-C portion
of IntSize into a platform-specific IntSize.mm that resides
in the mac subdirectory.

Win32 can just compile IntSize.cpp and doesn't need any
platform-specific extension here.


Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasImage.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasImageQuartz::init): (KCanvasImageQuartz::size):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::contextForImage):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • khtml/misc/CachedImage.cpp: (khtml::CachedImage::pixmap_size): (khtml::CachedImage::data):
  • khtml/misc/CachedImage.h:
  • khtml/misc/CachedImageCallback.cpp: (khtml::CachedImageCallback::notifyUpdate): (khtml::CachedImageCallback::notifyFinished):
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderFileButton::calcMinMaxWidth): (RenderSelect::layout): (RenderTextArea::calcMinMaxWidth): (RenderSlider::calcMinMaxWidth):
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::borderTopLeftRadius): (khtml::RenderStyle::borderTopRightRadius): (khtml::RenderStyle::borderBottomLeftRadius): (khtml::RenderStyle::borderBottomRightRadius): (khtml::RenderStyle::setBorderTopLeftRadius): (khtml::RenderStyle::setBorderTopRightRadius): (khtml::RenderStyle::setBorderBottomLeftRadius): (khtml::RenderStyle::setBorderBottomRightRadius): (khtml::RenderStyle::setBorderRadius): (khtml::RenderStyle::initialBorderRadius):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::inflateRect): (khtml::RenderThemeMac::setControlSize): (khtml::RenderThemeMac::sizeForFont): (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::checkboxSizes): (khtml::RenderThemeMac::setCheckboxCellState): (khtml::RenderThemeMac::radioSizes): (khtml::RenderThemeMac::setRadioCellState): (khtml::RenderThemeMac::buttonSizes): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::attributeChanged): (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGPatternElementImpl.h:
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::size):
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::addRoundedRectClip):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::size): (QPixmap::resize):
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::size):
  • kwq/KWQSize.h: Removed.
  • kwq/KWQSize.mm: Removed.
  • kwq/KWQSizeF.h:
  • kwq/KWQSizeF.mm: (QSizeF::QSizeF):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::sizeHint):
  • kwq/KWQStyle.cpp: (QStyle::sizeFromContents):
  • kwq/KWQStyle.h:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows):
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::sizeHint): (QWidget::size): (QWidget::resize):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::sizeHint):
  • platform: Added.
  • platform/IntSize.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::isValid): (WebCore::IntSize::expandedTo): (WebCore::operator+): (WebCore::operator==): (WebCore::operator!=):
  • platform/IntSize.h: Added.
  • platform/mac: Added.
  • platform/mac/IntSize.mm: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator NSSize): (WebCore::IntSize::operator CGSize):
12:16 PM Changeset in webkit [12076] by ap
  • 5 edits
    3 adds in trunk

Mostly merging work by Peter Kelly. Reviewed by Maciej, landed by ap.

JavaScriptCore:

  • kjs/array_object.cpp: Don't treat 232-1 as a real array index property. (ArrayInstance::getOwnPropertySlot): Ditto. (ArrayInstance::deleteProperty): Ditto. (ArrayInstance::put): Ditto. (ArrayInstance::propList): Added a FIXME comment. (ArrayInstance::put): Throw exception on trying to set invalid array length. (ArrayProtoFunc::callAsFunction): Do not use a separator argument when doing toString/toLocalString.
  • kjs/array_object.h: Added MAX_ARRAY_INDEX.

LayoutTests:

  • fast/js/kde/Array-expected.txt: Updated for newly-passing tests.
  • fast/js/array-tostring-ignore-separator.html: Added.
  • fast/js/array-tostring-ignore-separator-expected.txt: Added.
  • fast/js/resources/array-tostring-ignore-separator.js: Added.
9:53 AM Changeset in webkit [12075] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Based on test cases provided by Maks Orlovich.

  • fast/table/rowindex.html: Added.
  • fast/table/rowindex-expected.checksum: Added.
  • fast/table/rowindex-expected.png: Added.
  • fast/table/rowindex-expected.txt: Added.

WebCore:

Reviewed, redone a bit, and landed by Darin (help from Eric too).

Test: fast/table/rowindex.html

  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableRowElementImpl::rowIndex): Change algorithm so the rows are numbered in this order: (a) all rows in the table header section, (b) all rows in all table body sections, (c) all rows in the table footer section. Rows in extra table header or footer sections don't get row numbers (rowIndex returns -1). This matches Firefox.
8:55 AM Changeset in webkit [12074] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/css-generated-content/no-openclose-quote.html: Added.
  • fast/css-generated-content/no-openclose-quote-expected.checksum: Added.
  • fast/css-generated-content/no-openclose-quote-expected.png: Added.
  • fast/css-generated-content/no-openclose-quote-expected.txt: Added.

WebCore:

Reviewed, tweaked, and landed by Darin.

Test: fast/css-generated-content/no-openclose-quote.html

  • khtml/css/cssparser.cpp: (CSSParser::parseContent): Make sure parsedValue is always initialized to 0 (in particular for the CSS_IDENT case which is currently unimplemented).
8:39 AM Changeset in webkit [12073] by darin
  • 7 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.



  • fast/replaced/inline-box-wrapper-handover.html: Updated test to not depend on the edge case behavior.
  • fast/replaced/inline-box-wrapper-handover-expected.checksum: Updated results.
  • fast/replaced/inline-box-wrapper-handover-expected.png: Ditto.
  • fast/replaced/inline-box-wrapper-handover-expected.txt: Ditto.
  • fast/text/basic/015.html: Added.
  • fast/text/basic/015-expected.checksum: Added.
  • fast/text/basic/015-expected.png: Added.
  • fast/text/basic/015-expected.txt: Added.
  • fast/dom/css-rule-functions-expected.checksum: Added.
  • fast/dom/css-rule-functions-expected.png: Added.

WebCore:

Reviewed and landed by Darin.



Test: fast/text/basic/015.html

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Avoid inconsistent width measurement when breaking in the middle of a word is allowed. Eliminate the relaxation by 1 of the width overflow check that was supposed to compensate for the inconsistency but didn't always work, and on the other hand sometimes resulted in allowing text to overflow its container by one pixel. Also applied start and end width correctly in the break-words case.
2:21 AM Changeset in webkit [12072] by mjs
  • 64 edits
    4 moves in trunk

WebCore:

Rubber stamped by Eric.

  • rename WebCoreBridge to WebCoreFrameBridge
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • bridge/mac/MacFrame.h: (MacFrame::bridge):
  • bridge/mac/MacFrame.mm: (MacFrame::submitForm): (MacFrame::createPart): (MacFrame::bridgeForWidget): (MacFrame::documentViewForNode): (MacFrame::setBridge):
  • bridge/mac/WebCoreBridge.h: Removed.
  • bridge/mac/WebCoreBridge.mm: Removed.
  • bridge/mac/WebCoreFrameBridge.h: Added.
  • bridge/mac/WebCoreFrameBridge.mm: Added. (-[WebCoreFrameBridge executionContextForView:]): (frameHasSelection): (-[WebCoreFrameBridge firstChild]): (-[WebCoreFrameBridge lastChild]): (-[WebCoreFrameBridge previousSibling]): (-[WebCoreFrameBridge nextSibling]): (-[WebCoreFrameBridge isDescendantOfFrame:]): (-[WebCoreFrameBridge traverseNextFrameStayWithin:]): (-[WebCoreFrameBridge appendChild:]): (-[WebCoreFrameBridge removeChild:]): (-[WebCoreFrameBridge childFrameNamed:]): (-[WebCoreFrameBridge _deepLastChildFrame]): (-[WebCoreFrameBridge nextFrameWithWrap:]): (-[WebCoreFrameBridge previousFrameWithWrap:]): (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge _descendantFrameNamed:sourceFrame:]): (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): (-[WebCoreFrameBridge findFrameNamed:]): (+[WebCoreFrameBridge bridgeForDOMDocument:]): (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (nowPrinting): (-[WebCoreFrameBridge opener]): (-[WebCoreFrameBridge setOpener:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
  • kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): (-[KWQTableView keyUp:]):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest): (KWQCheckCacheObjectStatus): (KWQCacheObjectExpiresTime):
  • kwq/KWQSlider.mm: (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView keyDown:]): (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textView:shouldHandleEvent:]):
  • kwq/KWQWidget.mm: (QWidget::setFocus):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget):
  • kwq/WebCoreFrameNamespaces.h:
  • kwq/WebCoreFrameNamespaces.m: (+[WebCoreFrameNamespaces addFrame:toNamespace:]):
  • kwq/WebCoreFrameView.h:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • kwq/WebCoreViewFactory.h:

WebKit:

Rubber stamped by Eric.

  • rename WebBridge to WebFrameBridge


  • also removed all tabs from WebFrameBridge.m
  • DOM.subproj/WebDOMOperations.m: (-[DOMNode _bridge]): (-[DOMNode webArchive]): (-[DOMRange _bridge]): (-[DOMRange webArchive]):
  • DOM.subproj/WebDOMOperationsPrivate.h:
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebCoreStatistics.m:
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _bridge]):
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
  • Plugins.subproj/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • Plugins.subproj/WebPluginController.h:
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController bridge]):
  • WebCoreSupport.subproj/WebBridge.h: Removed.
  • WebCoreSupport.subproj/WebBridge.m: Removed.
  • WebCoreSupport.subproj/WebFileButton.h:
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileChooserButton initWithBridge:delegate:]):
  • WebCoreSupport.subproj/WebFrameBridge.h: Added.
  • WebCoreSupport.subproj/WebFrameBridge.m: Added. (-[WebFrameBridge mainFrame]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge canTargetLoadInFrame:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (formDelegate): (-[WebFrameBridge createModalDialogWithURL:]):
  • WebCoreSupport.subproj/WebSubresourceLoader.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _bridge]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _stringWithData:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDebugDOMNode.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m: (-[WebFrame _traverseNextFrameStayWithin::]): (Frame): (-[WebFrame _detachFromParent]): (-[WebFrame _bridge]): (-[WebFrame _initWithWebFrameView:webView:bridge:]):
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView webCoreBridge]): (-[WebFrameView _bridge]):
  • WebView.subproj/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedMIMETypes]): (-[WebHTMLRepresentation _bridge]): (-[WebHTMLRepresentation documentSource]):
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): (-[WebHTMLView updateFocusState]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray attributedString]): (-[NSArray selectedAttributedString]): (-[NSArray concludeDragForDraggingInfo:actionMask:]): (-[NSArray keyDown:]): (-[NSArray _alterCurrentSelection:direction:granularity:]): (-[NSArray _alterCurrentSelection:verticalDistance:]): (-[NSArray _expandSelectionToGranularity:]): (-[NSArray cut:]): (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray pasteAsPlainText:]): (-[NSArray insertNewline:]): (-[NSArray insertLineBreak:]): (-[NSArray insertParagraphSeparator:]): (-[NSArray _changeWordCaseWithSelector:]): (-[NSArray startSpeaking:]): (-[NSArray selectToMark:]): (-[NSArray swapWithMark:]): (-[NSArray transpose:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView _selectMarkedText]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView _selectionIsInsideMarkedText]): (-[WebTextCompleteController _insertMatch:]): (-[WebTextCompleteController doCompletion]): (-[WebTextCompleteController endRevertingChange:moveLeft:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceLoader.m:
  • WebView.subproj/WebRenderNode.m:
  • WebView.subproj/WebResource.m: (-[WebResource _stringValue]):
  • WebView.subproj/WebScriptDebugDelegate.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m: (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView moveDragCaretToPoint:]): (-[WebView shouldClose]): (-[WebView editableDOMRangeForPoint:]): (-[WebView setEditable:]): (-[WebView deleteSelection]): (-[WebView _bridgeForSelectedOrMainFrame]): (-[WebView _bridgeAtPoint:]):
2:07 AM Changeset in webkit [12071] by darin
  • 183 edits in trunk/WebCore
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
2:06 AM Changeset in webkit [12070] by darin
  • 64 edits in trunk/WebKit
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
1:32 AM Changeset in webkit [12069] by darin
  • 54 edits in trunk/JavaScriptCore
  • Replaced tabs with spaces in source files that had less than 10 lines with tabs.
  • Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
1:05 AM Changeset in webkit [12068] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, removed bogus ChangeLog entry.

1:04 AM Changeset in webkit [12067] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Removed tabs to make the new pre-commit script happy.

1:01 AM Changeset in webkit [12066] by darin
  • 1 edit in trunk/WebKitLibraries/ChangeLog

Removed tabs from the ChangeLog file to make the pre-commit check happy.

12:36 AM Changeset in webkit [12065] by eseidel
  • 2 edits in trunk/WebCore

2006-01-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove CG dependencies from kcanvas/device/quartz
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6521
Adding file omitted from last commit.

  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): removed cg calls
12:33 AM Changeset in webkit [12064] by eseidel
  • 14 edits in trunk/WebCore

2006-01-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove CG dependencies from kcanvas/device/quartz
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6521

  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): removed parameter (KCanvasFilterQuartz::applyFilter): removed parameter
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::drawMarkersIfNeeded): removed cg call (KCanvasItemQuartz::paint): removed cg calls (getSharedContext): spacing
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (KCanvasMaskerQuartz::applyMask): removed parameter
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasClipperQuartz::KCanvasClipperQuartz): (KCanvasImageQuartz::KCanvasImageQuartz):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): removed CG calls (KCanvasClipperQuartz::applyClip): removed parameter (KCanvasImageQuartz::~KCanvasImageQuartz): (KCanvasImageQuartz::cgLayer): spacing (KCanvasImageQuartz::setCGLayer): spacing
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::clearPath): added. (KRenderingDeviceContextQuartz::addPath): added. (KRenderingDeviceQuartz::quartzContext): spacing
12:14 AM Changeset in webkit [12063] by darin
  • 1 edit in trunk/WebCore/kwq/KWQVectorImpl.cpp

Oops, land this file again (checked in wrong version last time).

12:12 AM Changeset in webkit [12062] by darin
  • 19 edits in trunk/WebCore

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Don't set APPLE_CHANGES or HAVE_CONFIG_H any more.
  • WebCore.xcodeproj/project.pbxproj: Don't set APPLE_CHANGES or KHTML_NO_CPLUSPLUS_DOM any more.
  • kcanvas/KCanvasFilters.h: Use APPLE instead of APPLE_CHANGES.
  • bridge/mac/MacFrame.mm: (MacFrame::respondToChangedContents):
  • kcanvas/KCanvasTreeDebug.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGElementImpl.h: (KSVG::svg_dynamic_cast):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • page/Frame.cpp: (Frame::paint): Make some APPLE_CHANGES code unconditional.
  • WebCore+SVG/kdom.h:
  • ksvg2/ecma/Ecma.cpp: (Ecma::setupDocument):
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp: Remove some !APPLE_CHANGES code.
  • ksvg2/svg/SVGDocumentImpl.h: Remove some unneeded APPLE_CHANGES code.
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox): Remove a misleading mention of APPLE_CHANGES in a comment.

Also changed tabs to spaces in files I am committing.

Jan 12, 2006:

11:22 PM Changeset in webkit [12061] by hyatt
  • 2 edits in trunk/WebCore

Land all of the KWQ .cpp files that have no Mac-specific dependencies (and thus compile as is on Win32)

11:05 PM Changeset in webkit [12060] by darin
  • 1 delete in trunk/JavaScriptCore/tests/test-file

Done testing.

11:04 PM Changeset in webkit [12059] by darin
  • 1 edit in trunk/JavaScriptCore/tests/test-file

testing pre-commit hook, please ignore

11:03 PM Changeset in webkit [12058] by darin
  • 1 add in trunk/JavaScriptCore/tests/test-file

testing pre-commit hook, please ignore

10:52 PM Changeset in webkit [12057] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add KWQArrayImpl.cpp to Win32 build.

9:54 PM Changeset in webkit [12056] by hyatt
  • 6 edits in trunk/WebCore

Make the misc directory compile on Win32.

9:39 PM Changeset in webkit [12055] by hyatt
  • 4 edits in trunk/WebCore

Make the page directory compile on Win32.

9:34 PM Changeset in webkit [12054] by hyatt
  • 14 edits in trunk/WebCore

Make the ecma directory compile on Win32.

5:51 PM Changeset in webkit [12053] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • kjs/create_hash_table: Use correct size variables.
5:36 PM Changeset in webkit [12052] by hyatt
  • 2 edits in trunk/WebCore

Make the XSL directory build on Win32.

5:32 PM Changeset in webkit [12051] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Hack the Visual Studio project file to use environment variables to properly locate the CSS grammar derived source on any machine.

5:31 PM Changeset in webkit [12050] by hyatt
  • 2 edits in trunk/WebCore

Flatten the includes in css_grammar.y. Fix clobber build bustage on Mac caused by the documentimpl rename. Make the CSS grammar file compile on Win32.

5:26 PM Changeset in webkit [12049] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Make the CSS directory compile on Win32.

5:24 PM Changeset in webkit [12048] by hyatt
  • 2 edits
    1 move in trunk/WebCore

Move the CSS parser.y file to css_grammar.y since parser.h is a header on Win32 that we don't want to conflict with.

5:12 PM Changeset in webkit [12047] by mjs
  • 2 edits
    2 deletes in trunk/WebCore

Reviewed by Dave Hyatt.

  • removed leftover files from form split, fix remaining include of the header.
  • khtml/html/html_formimpl.cpp: Removed.
  • khtml/html/html_formimpl.h: Removed.
  • page/Frame.cpp:
5:08 PM Changeset in webkit [12046] by hyatt
  • 5 edits in trunk/WebCore

Make the css directory nearly compile on Win32. One issue left with parser.h.

5:00 PM Changeset in webkit [12045] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh

Add a helpful log message when generating the JS grammar.

4:11 PM Changeset in webkit [12044] by hyatt
  • 3 edits in trunk/WebCore

Make the editing directory build on win32.

4:03 PM Changeset in webkit [12043] by hyatt
  • 1 add in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Add the bash script for construction of generated tables on Win32.

4:03 PM Changeset in webkit [12042] by hyatt
  • 14 edits in trunk/WebCore

Get the HTML directory compiling on win32.

4:01 PM Changeset in webkit [12041] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


  • make prepare-ChangeLog way faster by using svn diff instead of svn status to detect if there are any new tests
  • Scripts/prepare-ChangeLog:
3:25 PM Changeset in webkit [12040] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-01-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/create_hash_table: Don't create an empty entry array, instead add a entry with all fields set to null and set the hash table size to 1.


  • kjs/lookup.cpp: (findEntry): Remove the hash table size check
2:42 PM Changeset in webkit [12039] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.



  • fast/dom/DOMParser-assign-variable-expected.txt: Added.
  • fast/dom/DOMParser-assign-variable.html: Added.
2:39 PM Changeset in webkit [12038] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • JavaScriptCore.xcodeproj/project.pbxproj: Move lookup.cpp before lookup.h


  • kjs/lookup.cpp: (findEntry): If the hash table is empty, return 0 early.
1:47 PM Changeset in webkit [12037] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • fast/dom/css-rule-functions-expected.txt: Added.
  • fast/dom/css-rule-functions.html: Added.
1:44 PM Changeset in webkit [12036] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


  • fixed <rdar://problem/4406994> REGRESSION (TOT): zooming window at cnn.com makes window fill width of screen
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _largestChildWithScrollBars]): now skips zero-area frames, used by some evil ads
1:44 PM Changeset in webkit [12035] by andersca
  • 6 edits in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


This also makes updating the disabled flag on style sheets work.
It also adds the IE-only removeRule which is the counterpart to
the already existing addRule.


  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::insertRule): (CSSStyleSheetImpl::deleteRule): Call styleSheetChanged()


(CSSStyleSheetImpl::styleSheetChanged):
Call DocumentImpl::updateStyleSelector()


  • khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::setDisabled): Call styleSheetChanged();


(DOM::StyleSheetImpl::styleSheetChanged):
New function.


(DOM::CSSStyleSheetImpl::removeRule):
New IE extension function, simply calls deleteRule.


  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): Ignore disabled style sheets.


  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleSheet::): Add removeRule.
1:09 PM Changeset in webkit [12034] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

Fix win32 build bustage in interpreter.cpp

1:05 PM Changeset in webkit [12033] by hyatt
  • 1 edit
    1 add in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

Check in updated JSCore project that tracks generated file dependencies properly.

1:05 PM Changeset in webkit [12032] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim H.


  • fixed <rdar://problem/4265966> PDFs continue to show a (secondary) selection when the focus moves elsewhere
  • WebView.subproj/WebPDFView.h: added trackedFirstResponder ivar


  • WebView.subproj/WebPDFView.m: (-[WebPDFView dealloc]): assert that trackedFirstResponder is nil, as it was released/cleared in viewWillMoveToWindow: (-[WebPDFView _trackFirstResponder]): If the tracked first responder was the PDFView's documentView, and the current first responder isn't, deselect all. This is equivalent to overriding resignFirstResponder in the PDFView's documentView and deselecting all there, as other web document view classes do. Also, keep track of the new first responder for next time. (-[WebPDFView viewWillMoveToWindow:]): stop observing NSWindowDidUpdateNotification on the old window (-[WebPDFView viewDidMoveToWindow]): start observing NSWindowDidUpdateNotification on the new window, with _trackFirstResponder as the callback. Ideally we'd use a notification that tells us that the first responder is changing, but there is no such notification, so we have to use this very frequent one instead. The archaic 2573089 tracks the desire to have a responder-changed notification. (-[WebPDFView becomeFirstResponder]): removed comment about this bug that's now obsolete
11:01 AM Changeset in webkit [12031] by staikos
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add collector helper to interpreter in order to facilitate visibility rules in
KDE.

10:23 AM Changeset in webkit [12030] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.
Add missing assert.h and make it compile with the qmake file.

9:18 AM Changeset in webkit [12029] by darin
  • 1 edit
    4 deletes in trunk/WebKitTools
  • removed some of the cvs-specific scripts -- not needed for this project any more
  • Scripts/cvs-abandon: Removed.
  • Scripts/cvs-apply: Removed.
  • Scripts/cvs-create-patch: Removed.
  • Scripts/cvs-unapply: Removed.
8:58 AM Changeset in webkit [12028] by darin
  • 12 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Geoff.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed both APPLE_CHANGES and HAVE_CONFIG_H from all targets.
  • README: Removed. This had obsolete information in it and it wasn't clear what to replace it with.
  • kjs/collector.h: Removed an APPLE_CHANGES if around something that's not really platform-specific (although it does use a platform-specific API at the moment).
  • kjs/collector.cpp: Removed a mistaken comment.
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/object.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/ustring.h: Use APPLE instead of APPLE_CHANGES for code that should be used only on Mac OS X.
  • kjs/interpreter.cpp: Removed APPLE_CHANGES ifdef around the include of the runtime.h header. Even though that header isn't needed at the moment on platforms other than Mac OS X, the conditional stuff should be in the header itself, not in this one client.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed some code inside APPLE_CHANGES. I'm pretty sure this code isn't needed on any platform where pow is implemented corrrectly according to the IEEE standard. If it is needed on some, we can add it back with an appropriate #if for the platforms where it is needed.
8:48 AM Changeset in webkit [12027] by darin
  • 30 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.


  • fast/css/rtl-ordering-expected.checksum: Added.
  • fast/css/rtl-ordering-expected.png: Added.
  • fast/css/rtl-ordering-expected.txt: Added.
  • fast/css/rtl-ordering.html: Added.

WebCore:

Reviewed and landed by Darin.


Test: fast/css/rtl-ordering.html


  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Parse the new -khtml-rtl-ordering property.
  • khtml/css/cssproperties.in: Added -khtml-rtl-ordering property.
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyProperty): Apply the new property.
  • khtml/css/cssvalues.in: Added "logical" and "visual" values for the -khtml-rtl-ordering property.
  • khtml/css/html4.css: Force logical ordering in input-buttons.
  • khtml/css/makeprop: Fixed maximum property length computation.
  • khtml/rendering/render_style.h: Added initial value for visuallyOrdered.
  • ksvg2/scripts/cssmakeprops: Ensure no overlap between KHTML and SVG CSS properties.
  • ksvg2/scripts/cssmakevalues: Ensure no overlap between KHTML and SVG CSS values.
7:53 AM Changeset in webkit [12026] by darin
  • 3 edits in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_image.h: (khtml::RenderImage::pixmap): Return a const QPixmap&.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Avoid copying the QPixmap and its renderer.
7:47 AM Changeset in webkit [12025] by darin
  • 29 edits
    2 adds in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

  • bridge/mac/KWQKHTMLView.cpp:
  • kcanvas/RenderSVGText.cpp:
  • khtml/css/css_computedstyle.cpp:
  • kwq/KWQArrayImpl.cpp:
  • kwq/KWQBuffer.cpp:
  • kwq/KWQCString.cpp:
  • kwq/KWQCharsets.cpp:
  • kwq/KWQDateTime.cpp:
  • kwq/KWQDictImpl.cpp:
  • kwq/KWQGuardedPtr.cpp:
  • kwq/KWQKHTMLFactory.cpp:
  • kwq/KWQKPartsEvent.cpp:
  • kwq/KWQListImpl.cpp:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQObject.cpp:
  • kwq/KWQPen.cpp:
  • kwq/KWQPointArray.cpp:
  • kwq/KWQPtrDictImpl.cpp:
  • kwq/KWQRegion.cpp:
  • kwq/KWQStyle.cpp:
  • kwq/KWQTextCodec.cpp:
  • kwq/KWQTextStream.cpp:
  • kwq/KWQTimer.cpp:
  • kwq/KWQValueListImpl.cpp:
  • kwq/KWQVariant.cpp:
  • kwq/KWQVectorImpl.cpp:
  • kwq/KWQWMatrix.cpp: Replaced #import with #include.
  • kwq/KWQRegExp.cpp: Replaced #import with #include. Also changed <JavaScriptCore/pcre.h> to <pcre/pcre.h>.
  • ForwardingHeaders/pcre: Added.
  • ForwardingHeaders/pcre/pcre.h: Added.
7:25 AM Changeset in webkit [12024] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed, tweaked, and landed by Darin.

  • kjs/dtoa.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved dtoa.h include to the top. Changed system header includes to use angle brackets instead of quotes.
  • kjs/grammar.y: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets.
  • kjs/lexer.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved lexer.h include to the top.
  • kjs/ustring.cpp: Removed HAVE_CONFIG_H, changed config.h to use quotes instead of angle brackets. Moved ustring.h include to the top.
6:56 AM Changeset in webkit [12023] by sullivan
  • 2 edits in trunk/LayoutTests

Reviewed and committed by John Sullivan.


Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6500>
editing/selection/selection-actions layout test beeps annoyingly when run

  • editing/selection/selection-actions.html: Fixed two typos in selector names.
4:27 AM Changeset in webkit [12022] by eseidel
  • 125 edits
    6 copies
    2 moves
    3 deletes in trunk/WebCore

2006-01-12 Eric Seidel <​eseidel@apple.com>

Reviewed by anders & mjs.

Split dom_docimpl.* out into separate files (one per class):
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6502

  • ForwardingHeaders/kdom/core/DOMImplementationImpl.h: Removed.
  • ForwardingHeaders/kdom/core/DocumentImpl.h: Removed.
  • ForwardingHeaders/kdom/core/DocumentTypeImpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreBridge.mm:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/RenderSVGText.h:
  • khtml/css/css_base.cpp:
  • khtml/css/css_computedstyle.cpp:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/cssparser.cpp:
  • khtml/css/parser.y:
  • khtml/ecma/XSLTProcessor.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/markup.h:
  • khtml/editing/merge_identical_elements_command.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/editing/visible_units.cpp:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/Cache.cpp:
  • khtml/misc/DocLoader.cpp:
  • khtml/rendering/InlineTextBox.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_button.cpp:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/xml/DOMImplementationImpl.cpp: Added.
  • khtml/xml/DOMImplementationImpl.h: Added.
  • khtml/xml/DocumentFragmentImpl.cpp: Added.
  • khtml/xml/DocumentFragmentImpl.h: Added.
  • khtml/xml/DocumentImpl.cpp: Added. (DocumentImpl::setDocType): (DocumentImpl::getElementsByName):
  • khtml/xml/DocumentImpl.h: Added.
  • khtml/xml/DocumentTypeImpl.cpp: Added.
  • khtml/xml/DocumentTypeImpl.h: Added.
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_viewsimpl.cpp:
  • khtml/xml/dom_docimpl.cpp: Removed.
  • khtml/xml/dom_docimpl.h: Removed.
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_textimpl.cpp:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGPatternElementImpl.cpp:
  • ksvg2/svg/SVGPolyElementImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGStopElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • kwq/DOM-CSS.mm:
  • kwq/DOM.mm:
  • kwq/DOMEvents.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm:
  • kwq/DOMViews.mm:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQSlot.mm:
  • page/Frame.cpp:
3:48 AM Changeset in webkit [12021] by mjs
  • 2 edits in trunk/WebCore

Not reviewed.


  • fixed build breakage
  • ksvg2/misc/SVGImageLoader.cpp: Add dom_docimpl.h include
2:29 AM Changeset in webkit [12020] by mjs
  • 39 edits in trunk/WebCore

Reviewed by Eric.

  • remove dom_documentimpl.h include from other headers where possible, move down to impl files instead, so less rebuilds when you touch it
  • bridge/mac/MacFrame.mm: (MacFrame::openURLFromPageCache):
  • kcanvas/KCanvasResources.cpp:
  • khtml/css/css_computedstyle.cpp:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::frame):
  • khtml/editing/SelectionController.h:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/jsediting.h:
  • khtml/editing/markup.h:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/rendering/InlineTextBox.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_button.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::documentBeingDestroyed):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/xbl/xbl_docimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm:
2:22 AM Changeset in webkit [12019] by andersca
  • 2 edits in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Fix build

  • khtml/ecma/kjs_window.cpp: Remove include.
2:07 AM Changeset in webkit [12018] by andersca
  • 9 edits
    3 deletes in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6501

  • Merge KParts::BrowserInterface with KParts::BrowserExtension.


  • ForwardingHeaders/kparts/browserinterface.h: Removed.
  • bridge/mac/KWQKPartsBrowserInterface.mm: Removed.
  • kwq/KWQKPartsBrowserInterface.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.h:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): (KHTMLPartBrowserExtension::getHistoryLength): (KHTMLPartBrowserExtension::goBackOrForward):
  • bridge/mac/KWQKPartsBrowserExtension.h: (KParts::BrowserExtension::BrowserExtension):
  • khtml/ecma/kjs_window.cpp: (KJS::History::getValueProperty):
  • khtml/xml/xml_tokenizer.cpp:
  • page/Frame.cpp: (Frame::slotRedirect):
  • page/FrameView.cpp: Add getHistoryLength and goBackOrForward to BrowserExtension and use them.
1:21 AM Changeset in webkit [12017] by eseidel
  • 1 edit
    4 adds in trunk/WebCore

2006-01-12 Eric Seidel <​eseidel@apple.com>

Build fix, files missing from previous <image> commit:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • kcanvas/RenderSVGImage.cpp: Added. (RenderSVGImage::RenderSVGImage): (RenderSVGImage::~RenderSVGImage): (RenderSVGImage::paint): (RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h: Added.
  • ksvg2/misc/SVGImageLoader.cpp: Added. (SVGImageLoader::SVGImageLoader): (SVGImageLoader::~SVGImageLoader): (SVGImageLoader::updateFromElement):
  • ksvg2/misc/SVGImageLoader.h: Added.
12:57 AM Changeset in webkit [12016] by eseidel
  • 24 edits
    3 moves
    9 adds in trunk/LayoutTests

2006-01-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel.

Updated results from after <image> fixes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f.svg: Added.
  • svg/W3C-SVG-1.1/filters-light-01-f.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt Added.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png Added.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg: Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png Added.
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum Added.
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t.svg: Added.
  • svg/W3C-SVG-1.1/render-groups-03-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
12:46 AM Changeset in webkit [12015] by andersca
  • 15 edits
    1 move
    2 deletes in trunk/WebCore

2006-01-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6496

  • Merge KParts::Part with KParts::ReadOnly part and rename it to ObjectContents.


  • ForwardingHeaders/kparts/part.h: Removed.
  • kwq/KWQKPartsPart.h: Removed.
  • kwq/KWQKPartsPart.mm: Removed.
  • kwq/KWQObject.cpp:


page/ObjectContents.h: Added
(ObjectContents::ObjectContents):
(ObjectContents::url):
(ObjectContents::setName):
(ObjectContents::widget):
(ObjectContents::setWidget):
(ObjectContents::ref):
(ObjectContents::deref):
(ObjectContents::event):
(ObjectContents::customEvent):
(ObjectContents::isObjectContents):

Renames:


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/KWQKHTMLPartBrowserExtension.h:
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • bridge/mac/KWQKPartsBrowserExtension.h:
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::createPart):
  • bridge/mac/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::indexGetter): (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (QObject::inherits): (QObject::isObjectContents):
  • kwq/KWQObject.h:
  • page/Frame.cpp: (Frame::stopLoading): (Frame::stopAnimations): (Frame::checkEmitLoadEvent): (Frame::processObjectRequest): (Frame::childFrame): (Frame::findFrame): (Frame::setZoomFactor): (Frame::frames): (Frame::customEvent): (Frame::slotPartRemoved): (Frame::connectChild): (Frame::disconnectChild): (Frame::setPolicyBaseURL): (Frame::setName):
  • page/Frame.h: (Frame::Frame):
  • page/FramePrivate.h:
12:33 AM Changeset in webkit [12014] by eseidel
  • 7 edits in trunk/WebCore

2006-01-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Refactor HTMLImageLoader to make subclassing possible. Implement
RenderSVGText-style RenderImage subclass. Use this to reimplement
SVGImageElementImpl.

As a side effect, this should fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5965

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/RenderSVGImage.cpp: Added. (RenderSVGImage::RenderSVGImage): (~RenderSVGImage::RenderSVGImage): (RenderSVGImage::paint): (RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h: Added.
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageLoader::setLoadingImage): trivial method extraction (DOM::HTMLImageLoader::updateFromElement): make virtual
  • khtml/html/html_imageimpl.h: (DOM::):
  • ksvg2/misc/SVGImageLoader.cpp: Added. (SVGImageLoader::SVGImageLoader): (~SVGImageLoader:SVGImageLoader): (SVGImageLoader::updateFromElement):
  • ksvg2/misc/SVGImageLoader.h: Added.
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::SVGImageElementImpl): (SVGImageElementImpl::parseMappedAttribute): (SVGImageElementImpl::createRenderer): (SVGImageElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.h:
12:19 AM Changeset in webkit [12013] by hyatt
  • 5 edits in trunk/WebCore

Get most of the XML dir compiling on Win32.

Note: See TracTimeline for information about the timeline view.