Context Navigation

← Previous Period
Next Period →

Timeline

Jan 20, 2006:

7:47 PM Changeset in webkit [12271] by hyatt

2 edits in trunk/WebCore

Fix for bug 6666, pseudo-element rules incorrectly displayed
in Web Inspector.

Reviewed by darin

Added fast/inspector/matchedrules.html as test case.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):

7:45 PM Changeset in webkit [12270] by hyatt

2 adds in trunk/LayoutTests/fast/inspector

Add a test case for Web Inspector style matching bug.

7:05 PM Changeset in webkit [12269] by thatcher

7 edits
2 deletes in trunk

WebCore:

Reviewed by John.

Removes code that is no longer needed with the new Web Inspector.

bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

Reviewed by John, some parts by Darin.

Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
that menu item to prevent a crash.

WebKit.exp: adds WebInspector, removes WebDebugDOMNode
WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
WebView.subproj/WebDebugDOMNode.h: Removed.
WebView.subproj/WebDebugDOMNode.m: Removed.
WebView.subproj/WebView.m: (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item

5:03 PM Changeset in webkit [12268] by andersca

17 edits in trunk/WebCore

2006-01-21 Anders Carlsson <andersca@mac.com>

Reviewed by David Hyatt.

Rename Frame::xmlDocImpl => Frame::document and
Frame::replaceDocImpl => Frame::setDocument

bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::keyEvent): (MacFrame::dispatchCPPEvent): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::bodyBackgroundColor): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::setMarkedTextRange): (MacFrame::dashboardRegionsDictionary): (MacFrame::shouldClose):
bridge/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): (frameHasSelection): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge saveDocumentState]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge saveDocumentToPageCache]): (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge deselectAll]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge copyDOMTree:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge unmarkAllMisspellings]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge DOMDocument]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge doneProcessingData]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::callAsFunction):
khtml/editing/jsediting.cpp:
khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::contentDocument):
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]):
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
page/Frame.cpp: (Frame::document): (Frame::setDocument): (Frame::setFocusNodeIfNeeded): (Frame::isPointInsideSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectionComputedStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::renderer): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayoutWithPageWidthRange): (Frame::sendScrollEvent): (Frame::clearTimers): (Frame::styleForSelectionStart): (Frame::setSelectionFromNone): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol):
page/Frame.h:
page/FrameView.cpp: (FrameView::~FrameView): (FrameView::clear): (FrameView::resizeEvent): (FrameView::adjustViewSize): (FrameView::layout): (FrameView::updateDashboardRegions): (FrameView::viewportMousePressEvent): (FrameView::viewportMouseDoubleClickEvent): (FrameView::viewportMouseMoveEvent): (FrameView::viewportMouseReleaseEvent): (FrameView::keyPressEvent): (FrameView::dispatchDragEvent): (FrameView::updateDragAndDrop): (FrameView::focusNextPrevNode): (FrameView::dispatchMouseEvent): (FrameView::viewportWheelEvent): (FrameView::timerEvent): (FrameView::scheduleRelayout): (FrameView::unscheduleRelayout):
rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):

2:54 PM Changeset in webkit [12267] by thatcher

2 edits in trunk/WebKit

Reviewed by Hyatt.

Corrects the cascade order for mapped attributes.
Shows "inline stylesheet" rather than "null" for rules in <style> tags.

WebInspector.subproj/webInspector/inspector.js:

1:48 PM Changeset in webkit [12266] by cpeterse

2 edits in trunk/WebCore

Reviewed by eseidel.

Build fix.

khtml/xml/DocumentImpl.cpp:

12:20 PM Changeset in webkit [12265] by eseidel

3 edits in trunk/WebCore

2006-01-20 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Unbreak build (partial commit of animation patch)

khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
khtml/xml/DocumentImpl.h:

11:30 AM Changeset in webkit [12264] by eseidel

4 edits in trunk/WebCore

2006-01-20 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Missed the kcanvas directory in my previous commit.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

kcanvas/KCanvasContainer.h:
kcanvas/RenderForeignObject.h:
kcanvas/RenderSVGText.h:

11:24 AM Changeset in webkit [12263] by eseidel

28 edits
8 copies
6 moves in trunk/WebCore

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Break classes in render_table out into separate files.
Move render_block to RenderBlock.
Move render_container to RenderContainer.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm:
kcanvas/KCanvasContainer.h:
kcanvas/RenderForeignObject.h:
kcanvas/RenderSVGText.h:
khtml/editing/visible_units.cpp:
khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::insertRow):
khtml/xml/dom2_rangeimpl.cpp:
khtml/xml/dom_position.cpp:
kwq/KWQRenderTreeDebug.cpp:
page/Frame.cpp:
rendering/InlineTextBox.cpp:
rendering/RenderBlock.cpp: Added.
rendering/RenderBlock.h: Added.
rendering/RenderContainer.cpp: Added. (WebCore::RenderContainer::addChild):
rendering/RenderContainer.h: Added.
rendering/RenderTable.cpp: Added. (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::updateFirstLetter):
rendering/RenderTable.h: Added.
rendering/RenderTableCell.cpp: Added. (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateFromElement):
rendering/RenderTableCell.h: Added.
rendering/RenderTableCol.cpp: Added. (WebCore::RenderTableCol::RenderTableCol): (WebCore::RenderTableCol::updateFromElement):
rendering/RenderTableCol.h: Added.
rendering/RenderTableRow.cpp: Added. (WebCore::RenderTableRow::RenderTableRow):
rendering/RenderTableRow.h: Added.
rendering/RenderTableSection.cpp: Added. (WebCore::RenderTableSection::RenderTableSection):
rendering/RenderTableSection.h: Added.
rendering/RenderText.cpp:
rendering/bidi.cpp:
rendering/render_block.cpp: Removed.
rendering/render_block.h: Removed.
rendering/render_box.cpp:
rendering/render_canvas.h:
rendering/render_container.cpp: Removed.
rendering/render_container.h: Removed.
rendering/render_flexbox.h:
rendering/render_flow.cpp:
rendering/render_flow.h:
rendering/render_form.h:
rendering/render_frames.h:
rendering/render_inline.cpp:
rendering/render_inline.h:
rendering/render_line.cpp:
rendering/render_list.h:
rendering/render_object.cpp:
rendering/render_replaced.h:
rendering/render_table.cpp: Removed.
rendering/render_table.h: Removed.
rendering/table_layout.cpp:

11:10 AM Changeset in webkit [12262] by mjs

1 edit
3 adds in trunk/LayoutTests

added test case for a parsing bug that was fixed in different ways in KJS and JSC. In older KJS versions, there would have been a parse error.

fast/js/parse-backslash-before-newline-expected.txt: Added.
fast/js/parse-backslash-before-newline.html: Added.
fast/js/resources/parse-backslash-before-newline.js: Added.

10:45 AM Changeset in webkit [12261] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6673 Selection highlight doesn't scroll along with an image contained in an overflow:scroll block

fast/overflow/image-selection-highlight-expected.checksum: Added.
fast/overflow/image-selection-highlight-expected.png: Added.
fast/overflow/image-selection-highlight-expected.txt: Added.
fast/overflow/image-selection-highlight.html: Added.

WebCore:

Test: fast/overflow/image-selection-highlight.html

Reviewed by Darin, committed by Adele.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6673 Selection highlight doesn't scroll along with an image contained in an overflow:scroll block

rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionRect): Subtract the containing block's scroll offset.

10:13 AM Changeset in webkit [12260] by thatcher

5 copies in tags/Safari-521.6

Final Safari-521.6 tag. Ignore the diffs, they are wrong!

10:11 AM Changeset in webkit [12259] by thatcher

1 delete in tags/Safari-521.6

This tag needs updated.

9:42 AM Changeset in webkit [12258] by thatcher

1 edit in trunk/WebKitSite/contact.html

Add irc://irc.freenode.net/#webkit links.

9:26 AM Changeset in webkit [12257] by thatcher

1 edit in trunk/WebKitSite/coding/contributing.html

Fixes the rest of http://bugzilla.opendarwin.org/show_bug.cgi?id=6535
add <tt></tt> around an instance of "svn diff".

12:18 AM Changeset in webkit [12256] by thatcher

2 edits in trunk/WebKitSite

Replace all "cvs" references with "svn".

Jan 19, 2006:

11:45 PM Changeset in webkit [12255] by thatcher

3 edits in trunk/WebKit

Reviewed by Eric.

Adds inline style reporting and mapped attribute support to the Inspector Style pane.
Cleans up the node attributes area with a more natural attr = "value" look.
Slight optimization to only update visible scrollbars during a window resize.

WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.js:

10:42 PM Changeset in webkit [12254] by thatcher

1 edit in trunk

Add WebKitBuild to the svn:ignore

10:21 PM Changeset in webkit [12253] by thatcher

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix a typo that made WebCore build and link UserAgentStyleSheets.cpp every time, even if nothing changed.

9:10 PM Changeset in webkit [12252] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6631
Inspector window has inappropriate maximum height

WebInspector.subproj/WebInspector.m: (-window): removes the maximum size constraint

5:40 PM Changeset in webkit [12251] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Omernick.

WebKit.xcodeproj/project.pbxproj: made WebNSUserDefaultsExtras.h private (SPI) so its one method can be called from Safari, so Safari can stop calling the similar method in Foundation.

5:22 PM Changeset in webkit [12250] by eseidel

2 edits in trunk/WebCore

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

<embed> and <object> tags show up blank when going back/forward.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6679

No test currently possible.

page/Frame.cpp: (Frame::canCachePage):

5:02 PM Changeset in webkit [12249] by sullivan

5 edits
1 add in trunk/WebKit

Reviewed by Tim Omernick.

Made _webKit_guessedMIMEType SPI so Safari can use it in order to stop using
the similar SPI method in Foundation. This involved splitting it out of the file
it was in, to avoid creating any other new SPI here. Poor svn diff got mighty
confused in the process.

Misc.subproj/WebNSDataExtras.h: removed _webkit_guessedMIMEType from here
Misc.subproj/WebNSDataExtrasPrivate.h: Added. Contains only _webkit_guessedMIMEType. This file is private (SPI), whereas WebNSDataExtras.h is project-internal. I could have renamed WebNSDateExtras.h to WebNSDateExtrasInternal.h also, but I minimized the gratuitous change level here by not doing that.

Misc.subproj/WebNSDataExtras.m: Despite the great confusion of svn diff, all I actually did here was move _webkit_guessedMIMEType and its helper _webkit_guessedMIMETypeForXML into a new category. No lines of code were harmed while creating this patch.

WebKit.xcodeproj/project.pbxproj: updated for new file

WebView.subproj/WebView.m: Added #import for new file since WebView uses _webkit_guessedMIMEType

4:29 PM Changeset in webkit [12248] by thatcher

5 copies in tags/Safari-521.6

Trying the Safari-521.6 tag again

4:26 PM Changeset in webkit [12247] by thatcher

1 delete in tags/Safari-521.6

Bad tag, not sure what happened.

4:22 PM Changeset in webkit [12246] by thatcher

5 copies in tags/Safari-521.6

Tagging Safari-521.6

3:57 PM Changeset in webkit [12245] by thatcher

8 adds in branches/Safari-Leo-branch

Versioning to 521.6

3:50 PM Changeset in webkit [12244] by thatcher

1 add in branches/Safari-Leo-branch

3:50 PM Changeset in webkit [12243] by eseidel

64 edits
6 copies
4 moves in trunk/WebCore

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Split html_miscimpl.* into separate files and move html_elementimpl
http://bugzilla.opendarwin.org/show_bug.cgi?id=6670

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMHTML.mm:
bridge/mac/WebCoreFrameBridge.mm:
css/css_valueimpl.cpp:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_html.cpp:
khtml/editing/apply_style_command.cpp:
khtml/editing/markup.cpp:
khtml/editing/replace_selection_command.cpp:
khtml/html/HTMLBaseFontElementImpl.cpp: Added.
khtml/html/HTMLBaseFontElementImpl.h: Added.
khtml/html/HTMLButtonElementImpl.cpp:
khtml/html/HTMLCollectionImpl.cpp: Added. (WebCore::HTMLCollectionImpl::traverseNextItem):
khtml/html/HTMLCollectionImpl.h: Added.
khtml/html/HTMLElementImpl.cpp: Added.
khtml/html/HTMLElementImpl.h: Added.
khtml/html/HTMLFieldSetElementImpl.cpp:
khtml/html/HTMLFormCollectionImpl.cpp: Added.
khtml/html/HTMLFormCollectionImpl.h: Added.
khtml/html/HTMLFormElementImpl.cpp:
khtml/html/HTMLFormElementImpl.h:
khtml/html/HTMLGenericFormElementImpl.cpp:
khtml/html/HTMLGenericFormElementImpl.h:
khtml/html/HTMLInputElementImpl.cpp:
khtml/html/HTMLIsIndexElementImpl.cpp:
khtml/html/HTMLLabelElementImpl.h:
khtml/html/HTMLLegendElementImpl.cpp:
khtml/html/HTMLNameCollectionImpl.cpp: Added.
khtml/html/HTMLNameCollectionImpl.h: Added.
khtml/html/HTMLOptGroupElementImpl.cpp:
khtml/html/HTMLOptGroupElementImpl.h:
khtml/html/HTMLOptionElementImpl.h:
khtml/html/HTMLSelectElementImpl.cpp:
khtml/html/HTMLTextAreaElementImpl.cpp:
khtml/html/html_baseimpl.cpp:
khtml/html/html_baseimpl.h:
khtml/html/html_blockimpl.cpp:
khtml/html/html_blockimpl.h:
khtml/html/html_canvasimpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_documentimpl.h:
khtml/html/html_elementimpl.cpp: Removed.
khtml/html/html_elementimpl.h: Removed.
khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading):
khtml/html/html_headimpl.h:
khtml/html/html_imageimpl.cpp:
khtml/html/html_inlineimpl.cpp:
khtml/html/html_inlineimpl.h:
khtml/html/html_listimpl.h:
khtml/html/html_miscimpl.cpp: Removed.
khtml/html/html_miscimpl.h: Removed.
khtml/html/html_objectimpl.cpp:
khtml/html/html_tableimpl.h:
khtml/html/htmlfactory.cpp:
khtml/html/htmlparser.cpp:
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
khtml/xml/DocumentImpl.cpp:
khtml/xml/dom2_rangeimpl.cpp:
khtml/xml/dom_elementimpl.cpp:
kwq/KWQAccObject.mm:
loader/loader.cpp:
page/Frame.cpp: (Frame::restoreURL): (Frame::stopLoading): (Frame::receivedFirstData): (Frame::gotoAnchor): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::findFrame): (Frame::executeScript):
page/FrameView.cpp: (FrameView::useSlowRepaints):
rendering/render_applet.cpp:
rendering/render_applet.h:
rendering/render_box.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
rendering/render_canvasimage.cpp:
rendering/render_canvasimage.h:
rendering/render_frames.cpp:
rendering/render_image.cpp:
rendering/render_image.h:
rendering/render_layer.cpp:

3:44 PM Changeset in webkit [12242] by thatcher

1 delete in branches/Safari-Leo-branch

Redoing this branch so we only include Info.plists

3:08 PM Changeset in webkit [12241] by darin

1 edit
1 add in trunk/WebKitTools

Scripts/report-include-statistics: Added a new script.

1:42 PM Changeset in webkit [12240] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim O.

Misc.subproj/WebNSURLExtras.h: added declaration of _webkit_rangeOfURLScheme so Safari can call it as a step towards weaning Safari from Foundation SPI.

11:45 AM Changeset in webkit [12239] by thatcher

2 edits in trunk/WebKitTools

Scripts/build-webkit: include JavaScriptGlue in the build

10:57 AM Changeset in webkit [12238] by darin

1 edit in trunk/Makefile

Build JavaScriptGlue.

9:14 AM Changeset in webkit [12237] by andersca

7 edits in trunk

2006-01-19 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6653 CSSStyleDeclaration returns empty string when trying to access shorthand properties using JS accessors.

khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): if getCSSPropertyValue returns 0 (which is true for shorthand properties), try getPropertyValue instead.

1:35 AM Changeset in webkit [12236] by adele

10 edits
2 adds in trunk/WebCore

Reviewed by Hyatt and Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6665
Implement NSView-less version of <input type="text">

Initial implementation of new and improved text fields.
This will only be turned on if an input element has khtml-appearance: textfield.

WebCore.xcodeproj/project.pbxproj: Added RenderTextField.h and RenderTextField.cpp
css/cssvalues.in: Fixed omitted button-bevel value. This was causing an off-by-one error when getting khtml-appearance value.
khtml/html/HTMLInputElementImpl.cpp: Added checks for khtml-appearance to decide when to use RenderTextField instead of RenderLineEdit. (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::select): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::createRenderer): (DOM::HTMLInputElementImpl::defaultEventHandler):
khtml/html/HTMLInputElementImpl.h:
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Also allow editable elements with no parent to be focusable.
khtml/xml/NodeImpl.h: (WebCore::NodeImpl::setAttached): Added to set m_attached without having to call attach().
rendering/RenderTextField.cpp: Added. (khtml:::RenderBlock): (khtml::RenderTextField::~RenderTextField): (khtml::RenderTextField::addChild): (khtml::RenderTextField::removeChild): (khtml::RenderTextField::setStyle): (khtml::RenderTextField::getDivStyle): (khtml::RenderTextField::updateFromElement): (khtml::RenderTextField::selectionStart): (khtml::RenderTextField::selectionEnd): (khtml::RenderTextField::setSelectionStart): (khtml::RenderTextField::setSelectionEnd): (khtml::RenderTextField::select): (khtml::RenderTextField::setSelectionRange):
rendering/RenderTextField.h: Added. (khtml::RenderTextField::removeLeftoverAnonymousBoxes): (khtml::RenderTextField::renderName):
rendering/render_container.cpp: (RenderContainer::destroy): use renamed destroyLeftoverChildren. (RenderContainer::destroyLeftoverChildren): renamed from destroyLeftoverAnonymousChildren.
rendering/render_container.h:
rendering/render_flow.cpp: (RenderFlow::destroy): use renamed destroyLeftoverChildren.

1:20 AM Changeset in webkit [12235] by eseidel

5 edits
4 adds in trunk

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by darin & anders.

Fix opacity crasher for <text> and <image>.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6668
Even though the crash is fixed, opacity still doesn't work.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6669

kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
kcanvas/RenderSVGText.cpp: (RenderSVGText::paint):

1:18 AM Changeset in webkit [12234] by darin

21 edits in trunk/WebKitTools

Scripts/webkitdirs.pm: Changed SVG check to work even if the path has spaces in it by using the form of open that treats each argument as a string rather than backtick syntax for reading the output of the nm tool.

12:59 AM Changeset in webkit [12233] by darin

43 edits
4 deletes in trunk/WebCore

Reviewed by Hyatt.

removed all use of QMap

ForwardingHeaders/qmap.h: Removed.
WebCore.xcodeproj/project.pbxproj: Removed KWQMap.h, KWQMapImpl.h, KWQMapImpl.cpp.
kwq/KWQMap.h: Removed.
kwq/KWQMapImpl.cpp: Removed.
kwq/KWQMapImpl.h: Removed.

bridge/BrowserExtension.h: (WebCore::URLArgs::metaData): Converted from QMap of QString to HashMap of DOMString.
bridge/mac/BrowserExtensionMac.mm: Ditto.
bridge/mac/MacFrame.mm: (MacFrame::openURLRequest): Ditto. (MacFrame::urlSelected): Ditto. (MacFrame::createPart): Ditto.
khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::showModalDialog): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::createRenderer): Ditto.
khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet): Ditto.
khtml/xml/xml_tokenizer.cpp: (WebCore::toString): Added. Converts to DOMString instead of QString. (WebCore::attributesStartElementNsHandler): Converted from QMap of QString to HashMap of DOMString. (WebCore::parseAttributes): Ditto.
khtml/xml/xml_tokenizer.h: (WebCore::Tokenizer::setTransformSource): Ditto.
ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll): Ditto.
kwq/KWQKJavaAppletWidget.h: Ditto.
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): Ditto.
kwq/KWQKJobClasses.h: Ditto.
kwq/KWQKJobClasses.mm: (KIO::TransferJob::addMetaData): Ditto.
page/Frame.cpp: (Frame::didOpenURL): Ditto. (Frame::changeLocation): Ditto. (Frame::mark): Ditto. (Frame::setMark): Ditto. (Frame::urlSelected): Ditto. (Frame::requestObject): Ditto. (Frame::processObjectRequest): Ditto. (Frame::submitForm): Ditto.
rendering/render_applet.cpp: (WebCore::RenderApplet::RenderApplet): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto. (WebCore::RenderApplet::layout): Ditto.
rendering/render_applet.h: (WebCore::RenderApplet::renderName): Ditto. (WebCore::RenderApplet::element): Ditto. (WebCore::RenderEmptyApplet::renderName): Ditto.

khtml/dom/dom_string.h: (WebCore::DOMString::createCFString): Added. Not yet implemented or used. (WebCore::DOMString::operator NSString*): Updated to call through to DOMStringImpl. Added hash functions and hash traits so you can use DOMString in hash tables.
khtml/xml/dom_stringimpl.h: Added conversion to and from CFStringRef/NSString.
khtml/xml/dom_stringimpl.cpp: Took out an excess "DOM::".

bindings/objc/DOMInternal.mm: (DOMStringImpl::operator NSString *): Moved from DOMString to DOMStringImpl.

changed the mark from a SelectionController to a Selection (maybe it can be a Position instead?)

page/Frame.h: Changed mark() and setMark() to use a Selection.
page/FramePrivate.h: Changed mark to a Selection.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setMarkDOMRange:]): Updated for change from SelectionController to Selection.

removed extraneous includes

kwq/KWQKHTMLSettings.h: Removed include of "KWQMap.h".
kwq/KWQKIOGlobal.h: Ditto.

khtml/editing/htmlediting.h: Removed extraneous includes and namespace prefixes.

khtml/html/html_canvasimpl.h: Removed extraneous includes and moved into the WebCore namespace.
khtml/html/html_canvasimpl.cpp: Ditto.
khtml/html/htmltokenizer.cpp: Ditto.
khtml/html/htmltokenizer.h: Ditto.
khtml/xml/DocumentImpl.cpp: Ditto.
kwq/KWQEditCommand.mm: Ditto.
rendering/render_canvasimage.h: Ditto.
rendering/render_image.h: Ditto.

khtml/editing/composite_edit_command.cpp: Updated includes because of ones that were removed from headers.
khtml/editing/htmlediting.cpp: Ditto.
khtml/editing/jsediting.cpp: Ditto.
khtml/editing/replace_selection_command.cpp: Ditto.
rendering/render_canvasimage.cpp: Ditto.
rendering/render_image.cpp: Ditto.

loader/loader.cpp: (WebCore::Loader::servePendingRequests): Removed code to add the cache control string, since that was hardcoded to empty string anyway.

12:59 AM Changeset in webkit [12232] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Hyatt.

hash table fixes needed for my WebCore changes

kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator=): Added a missing return statement.

kxmlcore/HashTraits.h: Fix traits so they work properly for classes where you can't instantiate with a 0 by using traits rather than ? : to select the default emtpy value of hash table keys.

small cleanup of "runtime" code left over from recent JavaScript crash fix

bindings/runtime_root.h: (KJS::Bindings::RootObject::RootObject): No explicit initialization of _imp needed since it's now a ProtectedPtr. (KJS::Bindings::RootObject::setRootObjectImp): Remove old code that relied on the fact that _imp was 0 and replaced with use of ProtectedPtr. (KJS::Bindings::RootObject::rootObjectImp): Updated since _imp is a ProtectedPtr.

12:16 AM Changeset in webkit [12231] by eseidel

2 edits in trunk/WebCore

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove CFDictionary usage from KWQObject.*
http://bugzilla.opendarwin.org/show_bug.cgi?id=6468

kwq/KWQObject.cpp: (KWQObjectTimer::KWQObjectTimer): (QObject::restartTimer): (QObject::timerIntervals): (KWQObjectTimer::deleteTimer): (QObject::killTimer): (QObject::killTimers): (sendDeferredTimerEvent):

Jan 18, 2006:

10:46 PM Changeset in webkit [12230] by hyatt

56 edits in trunk

Rename KHTMLView to FrameView (since it's been moved to a file called FrameView already).

6:40 PM Changeset in webkit [12229] by thatcher

15 edits
1 add in trunk/JavaScriptGlue

Adding the license header to all files so we can
move JavaScriptGlue into the open source repository.

LICENSE: Added.
JSBase.cpp: license header added.
JSBase.h: ditto.
JSObject.cpp: ditto.
JSObject.h: ditto.
JSRun.cpp: ditto.
JSRun.h: ditto.
JSUtils.cpp: ditto.
JSUtils.h: ditto.
JSValueWrapper.cpp: ditto.
JSValueWrapper.h: ditto.
JavaScriptGlue.cpp: ditto.
JavaScriptGlue.h: ditto.
UserObjectImp.cpp: ditto.
UserObjectImp.h: ditto.

5:59 PM Changeset in webkit [12190] by thatcher

1 move in tags/WebCore-417.19

Fix a typo.

5:54 PM Changeset in webkit [12189] by thatcher

1 copy in tags/WebCore-417.9/WebCore

Tag for WebCore-417.9

5:53 PM Changeset in webkit [12188] by thatcher

1 add in tags/WebCore-417.9

Tag directory for WebCore-417.9

5:43 PM Changeset in webkit [12187] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning to 417.19.

5:34 PM Changeset in webkit [12186] by thatcher

2 edits
5 adds
16 deletes in branches/Safari-2-0-branch

Removing the .cvsignore on the branch.
Added the new Makefiles.

5:30 PM Changeset in webkit [12185] by thatcher

8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-01-17 Beth Dakin <Beth Dakin>

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.

khtml/html/HTMLInputElementImpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): If the click is simulated, set xPos and yPos to 0.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Fix spacing. (HTMLElementImpl::click): It isn't necessary to check if there is a renderer.
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTest): Call updateLayout().
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchSimulatedMouseEvent): Set isSimulated to true. (WebCore::NodeImpl::dispatchMouseEvent): Keep track of isSimulated.
khtml/xml/NodeImpl.h: Same.
khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Add isSimulated to MouseRelatedEventImpl(). (DOM::MouseRelatedEventImpl::computePositions): Only change the offsets if it's not simulated. (DOM::MouseEventImpl::MouseEventImpl): Add isSimulated to MouseEventImpl()
khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::isSimulated): Declarations of isSimulated (DOM::MouseEventImpl::isSimulated): Same.

4:59 PM Changeset in webkit [12184] by hyatt

1 edit in trunk/WebCore/page/Frame.h

It's called pure virtual for a reason. (Fingers crossed.)

4:51 PM Changeset in webkit [12183] by hyatt

2 edits in trunk/WebCore

Umm. Yeah. Let's try making BrowserExtensionMac actually declare and use a class called BrowserExtensionMac.

4:43 PM Changeset in webkit [12182] by hyatt

1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.mm

Remove KParts using from WebCoreFrameBridge.mm (yes, more bustage).

4:39 PM Changeset in webkit [12181] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

Make sure FrameView includes MacFrame.h on mac only.

4:30 PM Changeset in webkit [12180] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

More Mac build bustage. Fix the dashboard region call to still cast to MacFrame.

4:15 PM Changeset in webkit [12179] by hyatt

3 edits in trunk/WebCore

OMG I BROKE THE MAC. (Fixed)

3:59 PM Changeset in webkit [12178] by hyatt

30 edits
3 moves
2 deletes in trunk/WebCore

Eliminate uses of MacFrame in cross-platform code.

1:14 PM Changeset in webkit [12177] by hyatt

3 edits in trunk/WebCore/kwq

Make the signals/stubs/slots compile on Win32 by removing #imports.

1:12 PM Changeset in webkit [12176] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

change KWQList to use qsort instead of CFArraySort

kwq/KWQListImpl.cpp: (compareFuncWrapper): Wrapper that uses global variables to overcome the lack of a "data" pointer in qsort. Could have used qsort_r but that would be less portable. (KWQListImpl::sort): Use qsort instead of CFArraySortValues.

12:19 PM Changeset in webkit [12175] by darin

4 edits
3 moves in trunk/WebCore

Reviewed by Beth.

changed the three signal/slot related files from ObjC++ to C++ files

WebCore.xcodeproj/project.pbxproj:
kwq/KWQSignal.cpp: Added.
kwq/KWQSignal.mm: Removed.
kwq/KWQSignalStubs.cpp: Added.
kwq/KWQSignalStubs.mm: Removed.
kwq/KWQSlot.cpp: Added.
kwq/KWQSlot.mm: Removed.

11:48 AM Changeset in webkit [12174] by hyatt

2 edits in trunk/WebCore

Add KWQListImpl.cpp to Win32 but ifdef out all the LAME LAME LAME CF dependencies.

11:41 AM Changeset in webkit [12173] by thatcher

11 edits
2 adds in branches/Safari-2-0-branch/LayoutTests

Fix for binary files.

11:31 AM Changeset in webkit [12172] by hyatt

3 edits in trunk/JavaScriptCore

Make testkjs.exe compile without warnings.

11:31 AM Changeset in webkit [12171] by hyatt

5 edits in trunk/WebCore

Make Win32 WebCore build again.

9:19 AM Changeset in webkit [12170] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6618 Inline in RTL block with overflow:auto and left border makes scroll bar appear

fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum: Added.
fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Added.
fast/overflow/overflow-rtl-inline-scrollbar.html: Added.

WebCore:

Test: fast/overflow/overflow-rtl-inline-scrollbar.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6618 Inline in RTL block with overflow:auto and left border makes scroll bar appear

Inline flows were always returning 0 for leftmostPosition(). Their real leftmost
edges are determined by their inline boxes, which
RenderBlock::leftmostPosition already takes into account.

khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't descend into inline flows. (RenderFlow::rightmostPosition): Ditto. (RenderFlow::leftmostPosition): Ditto.

8:51 AM Changeset in webkit [12169] by andersca

3 edits in trunk/WebCore

2006-01-18 Anders Carlsson <andersca@mac.com>

Fix build.

khtml/ecma/kjs_navigator.cpp:
page/FrameView.cpp: Remove kstandarddirs.h includes.

12:57 AM Changeset in webkit [12168] by darin

1 edit in trunk/WebCore/ChangeLog

Fixed change log.

12:56 AM Changeset in webkit [12167] by darin

8 edits
1 move
2 adds
6 deletes in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6646 compile CSS sources in instead of reading them from disk

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:

css/make-css-file-arrays.pl: Added. Used to generate C array forms of the ".css" files.
css/UserAgentStyleSheets.cpp: Added. Used to indirectly compile the generated file.

WebCore.xcodeproj/project.pbxproj: Added new source files. Added a build phase to invoke the make-css-file-arrays.pl script. Removed the .css files, which no longer need to be installed as part of the final package.

css/cssstyleselector.cpp: (WebCore::parseUASheet): Removed code to read user agent sheets from disk. Replaced with code that gets them from compiled-in arrays instead. Uses a pretty lame DOMString hack that could be reworked some day. (WebCore::CSSStyleSelector::loadDefaultStyle): Change to load from arrays intead of disk.

css/html4.css: Added missing license header, tweaked format a bit.
css/quirks.css: Added missing license header, tweaked format.
css/svg.css: Moved from ksvg2/css directory.
ksvg2/css/svg.css: Moved to top level css directory.

page/Frame.cpp: Removed includes of qfile.h and kstandarddirs.h.

ForwardingHeaders/kstandarddirs.h: Removed.
ForwardingHeaders/qfile.h: Removed.
kwq/KWQFile.h: Removed.
kwq/KWQFile.mm: Removed.
kwq/KWQKStandardDirs.h: Removed.
kwq/KWQKStandardDirs.mm: Removed.

Jan 17, 2006:

10:41 PM Changeset in webkit [12166] by darin

8 edits
2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove the now-unused KRenderingPaintServerImage[Quartz].

WebCore.xcodeproj/project.pbxproj:
kcanvas/KCanvasTreeDebug.cpp:
kcanvas/device/KRenderingPaintServer.h:
kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
kcanvas/device/KRenderingPaintServerImage.h: Removed.
kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
ksvg2/svg/SVGFEImageElementImpl.cpp:
kwq/KWQPainter.mm:

10:16 PM Changeset in webkit [12165] by darin

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6377 <rdar://problem/4400315> All XML crashes in TOT with JavaScript disabled (6377)

bridge/mac/MacFrame.mm: (MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled. (MacFrame::windowScriptObject): Return 0 if JavaScript is disabled. (MacFrame::windowScriptNPObject): Ditto. (MacFrame::partClearedInBegin): Don't call the "window script object available" call if JavaScript is disabled.

9:55 PM Changeset in webkit [12164] by justing

1 edit
4 adds in trunk/LayoutTests

Reviewed by darin

Layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclink

9:53 PM Changeset in webkit [12163] by justing

3 edits in trunk/WebCore

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclinks.html

Layout test added:

editing/selection/after-line-wrap.html

khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): Don't stop at the first candidate, it may be visually equivalent to the original position.
khtml/xml/dom_position.cpp: (DOM::Position::upstream): Don't move to a position on a different line. (DOM::Position::downstream): Ditto.

8:33 PM Changeset in webkit [12162] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6611 add assertions to check correct use of hash table iterators

kxmlcore/HashTable.h: (KXMLCore::addIterator): Added. Helper function that adds an iterator to the list maintained by the specified hash table. (KXMLCore::removeIterator): Added. Helper function that removes an iterator from the list maintained by the hash table it's in. (KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable parameter, ignored when not debugging. Call addIterator. (KXMLCore::HashTableConstIterator::~HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator=): Call removeIterator. (KXMLCore::HashTableConstIterator::operator*): Call checkValidity. (KXMLCore::HashTableConstIterator::operator->): Ditto. (KXMLCore::HashTableConstIterator::operator++): Ditto. (KXMLCore::HashTableConstIterator::operator==): Ditto. (KXMLCore::HashTableConstIterator::operator!=): Ditto. (KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table pointer is not 0 and if there are two iterators that both point at the same table. (KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator as an implementation detail, to avoid having two separate iterator implementations. (KXMLCore::HashTableIterator::operator*): Ditto. (KXMLCore::HashTableIterator::operator->): Ditto. (KXMLCore::HashTableIterator::operator++): Ditto. (KXMLCore::HashTableIterator::operator==): Ditto. (KXMLCore::HashTableIterator::operator!=): Ditto. (KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list. (KXMLCore::HashTable::~HashTable): Added call to invalidateIterators. (KXMLCore::HashTable::makeIterator): Pass this pointer. (KXMLCore::HashTable::makeConstIterator): Ditto. (KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public entry point that modifies the hash table. (KXMLCore::HashTable::remove): Ditto. (KXMLCore::HashTable::clear): Ditto. (KXMLCore::HashTable::swap): Ditto. (KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and clears out the table, next, and previous pointers in all of them, and then clears the head so we have an empty list. (KXMLCore::addIterator): Added. Adds the iterator the the linked list in the passed-in table, and points the iterator at the table. (KXMLCore::removeIterator): Added. Removes the iterator from the linked list in the passed-in table.

kxmlcore/HashTraits.h: A bit of tweaking and formatting.

8:16 PM Changeset in webkit [12161] by justing

7 edits in trunk

Deployment builds now use -O2

5:33 PM Changeset in webkit [12160] by bdakin

2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects

The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.

5:18 PM Changeset in webkit [12159] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for <rdar://problem/4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232

3:56 PM Changeset in webkit [12158] by thatcher

269 adds in trunk/WebKitSite

Moving the webkit.opendarwin.org site into our Subversion repository.

2:49 PM Changeset in webkit [12157] by hyatt

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix group path for rendering in project file.

2:46 PM Changeset in webkit [12156] by hyatt

3 edits in trunk/WebCore

Fix build bustage caused by my partial commit.

1:07 PM Changeset in webkit [12155] by hyatt

2 edits
63 copies
1 add
1 delete in trunk/WebCore

Move khtml/rendering to WebCore/rendering.

WebCore.xcodeproj/project.pbxproj:
khtml/rendering: Removed.
khtml/rendering/DataRef.h: Removed.
khtml/rendering/InlineTextBox.cpp: Removed.
khtml/rendering/InlineTextBox.h: Removed.
khtml/rendering/RenderText.cpp: Removed.
khtml/rendering/RenderText.h: Removed.
khtml/rendering/RenderTextFragment.cpp: Removed.
khtml/rendering/RenderTextFragment.h: Removed.
khtml/rendering/bidi.cpp: Removed.
khtml/rendering/bidi.h: Removed.
khtml/rendering/break_lines.cpp: Removed.
khtml/rendering/break_lines.h: Removed.
khtml/rendering/font.cpp: Removed.
khtml/rendering/font.h: Removed.
khtml/rendering/render_applet.cpp: Removed.
khtml/rendering/render_applet.h: Removed.
khtml/rendering/render_arena.cpp: Removed.
khtml/rendering/render_arena.h: Removed.
khtml/rendering/render_block.cpp: Removed.
khtml/rendering/render_block.h: Removed.
khtml/rendering/render_box.cpp: Removed.
khtml/rendering/render_box.h: Removed.
khtml/rendering/render_br.cpp: Removed.
khtml/rendering/render_br.h: Removed.
khtml/rendering/render_button.cpp: Removed.
khtml/rendering/render_button.h: Removed.
khtml/rendering/render_canvas.cpp: Removed.
khtml/rendering/render_canvas.h: Removed.
khtml/rendering/render_canvasimage.cpp: Removed.
khtml/rendering/render_canvasimage.h: Removed.
khtml/rendering/render_container.cpp: Removed.
khtml/rendering/render_container.h: Removed.
khtml/rendering/render_flexbox.cpp: Removed.
khtml/rendering/render_flexbox.h: Removed.
khtml/rendering/render_flow.cpp: Removed.
khtml/rendering/render_flow.h: Removed.
khtml/rendering/render_form.cpp: Removed.
khtml/rendering/render_form.h: Removed.
khtml/rendering/render_frames.cpp: Removed.
khtml/rendering/render_frames.h: Removed.
khtml/rendering/render_image.cpp: Removed.
khtml/rendering/render_image.h: Removed.
khtml/rendering/render_inline.cpp: Removed.
khtml/rendering/render_inline.h: Removed.
khtml/rendering/render_layer.cpp: Removed.
khtml/rendering/render_layer.h: Removed.
khtml/rendering/render_line.cpp: Removed.
khtml/rendering/render_line.h: Removed.
khtml/rendering/render_list.cpp: Removed.
khtml/rendering/render_list.h: Removed.
khtml/rendering/render_object.cpp: Removed.
khtml/rendering/render_object.h: Removed.
khtml/rendering/render_replaced.cpp: Removed.
khtml/rendering/render_replaced.h: Removed.
khtml/rendering/render_style.cpp: Removed.
khtml/rendering/render_style.h: Removed.
khtml/rendering/render_table.cpp: Removed.
khtml/rendering/render_table.h: Removed.
khtml/rendering/render_theme.cpp: Removed.
khtml/rendering/render_theme.h: Removed.
khtml/rendering/render_theme_mac.h: Removed.
khtml/rendering/render_theme_mac.mm: Removed.
khtml/rendering/table_layout.cpp: Removed.
khtml/rendering/table_layout.h: Removed.
rendering: Added.
rendering/DataRef.h: Added.
rendering/InlineTextBox.cpp: Added.
rendering/InlineTextBox.h: Added.
rendering/RenderText.cpp: Added.
rendering/RenderText.h: Added.
rendering/RenderTextFragment.cpp: Added.
rendering/RenderTextFragment.h: Added.
rendering/bidi.cpp: Added.
rendering/bidi.h: Added.
rendering/break_lines.cpp: Added.
rendering/break_lines.h: Added.
rendering/font.cpp: Added.
rendering/font.h: Added.
rendering/render_applet.cpp: Added.
rendering/render_applet.h: Added.
rendering/render_arena.cpp: Added.
rendering/render_arena.h: Added.
rendering/render_block.cpp: Added.
rendering/render_block.h: Added.
rendering/render_box.cpp: Added.
rendering/render_box.h: Added.
rendering/render_br.cpp: Added.
rendering/render_br.h: Added.
rendering/render_button.cpp: Added.
rendering/render_button.h: Added.
rendering/render_canvas.cpp: Added.
rendering/render_canvas.h: Added.
rendering/render_canvasimage.cpp: Added.
rendering/render_canvasimage.h: Added.
rendering/render_container.cpp: Added.
rendering/render_container.h: Added.
rendering/render_flexbox.cpp: Added.
rendering/render_flexbox.h: Added.
rendering/render_flow.cpp: Added.
rendering/render_flow.h: Added.
rendering/render_form.cpp: Added.
rendering/render_form.h: Added.
rendering/render_frames.cpp: Added.
rendering/render_frames.h: Added.
rendering/render_image.cpp: Added.
rendering/render_image.h: Added.
rendering/render_inline.cpp: Added.
rendering/render_inline.h: Added.
rendering/render_layer.cpp: Added.
rendering/render_layer.h: Added.
rendering/render_line.cpp: Added.
rendering/render_line.h: Added.
rendering/render_list.cpp: Added.
rendering/render_list.h: Added.
rendering/render_object.cpp: Added.
rendering/render_object.h: Added.
rendering/render_replaced.cpp: Added.
rendering/render_replaced.h: Added.
rendering/render_style.cpp: Added.
rendering/render_style.h: Added.
rendering/render_table.cpp: Added.
rendering/render_table.h: Added.
rendering/render_theme.cpp: Added.
rendering/render_theme.h: Added.
rendering/render_theme_mac.h: Added.
rendering/render_theme_mac.mm: Added.
rendering/table_layout.cpp: Added.
rendering/table_layout.h: Added.

12:52 PM Changeset in webkit [12154] by hyatt

3 edits in trunk/WebCore

Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.

Reviewed by xenon

khtml/ecma/kjs_dom.cpp: (KJS::DOMAttr::getValueProperty):
khtml/ecma/kjs_dom.h: (KJS::DOMAttr::):

11:40 AM Changeset in webkit [12153] by bdakin

8 edits in trunk/WebCore

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`

10:14 AM Changeset in webkit [12152] by ap

21 edits in trunk/WebCore

Patch by Duncan Wilcox, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6609 Use Selection instead of SelectionController where possible

This patch replaces the use of SelectionController with Selection in the edit commands.

It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.

9:35 AM Changeset in webkit [12151] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5926 Assertion failure in HTMLGenericFormElementImpl::removedFromTree

fast/dom/generic-form-element-assert.html: Added.
fast/dom/generic-form-element-assert-expected.txt: Added.

WebCore:

Test: fast/dom/generic-form-element-assert.html

Reviewed and reworked by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5926 Assertion failure in HTMLGenericFormElementImpl::removedFromTree

khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces a bit. Removed unneeded includes. (WebCore::findRoot): Added helper function. (WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check in a simpler way, since the two separate cases amounted to the same check.

9:29 AM Changeset in webkit [12150] by darin

2 edits in trunk/JavaScriptCore/kxmlcore

Updated copyright dates (oops, forgot).

9:28 AM Changeset in webkit [12149] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6610 change RefPtr so that it works when deref ends up deleting the RefPtr

kxmlcore/PassRefPtr.h: Always set m_ptr before calling deref.
kxmlcore/RefPtr.h: Ditto.

1:00 AM Changeset in webkit [12148] by eseidel

2 edits in trunk/WebCore

2006-01-17 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

Fix second part of WebCore-no-SVG fails to build.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

WebCore.xcodeproj/project.pbxproj: Mark three headers as private rather than project in the WebCore-no-SVG target.

Jan 16, 2006:

11:39 PM Changeset in webkit [12147] by hyatt

2 edits in trunk/WebCore

Reviewed by hyatt

kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Assign the new item to index m_count, not m_size.

10:53 PM Changeset in webkit [12146] by eseidel

2 edits in trunk/WebCore

2006-01-17 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

WebCore-SVG fails to build.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

WebCore.xcodeproj/project.pbxproj: Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new files omitted from the target.

10:50 PM Changeset in webkit [12145] by eseidel

2 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <eseidel@apple.com>

Fixed test case to remove invisible chars (thus fixing test).

svg/custom/recursive-clippath.svg:

9:41 PM Changeset in webkit [12144] by hyatt

19 edits
25 copies
1 add
2 deletes in trunk/WebCore

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

ForwardingHeaders/kdom/css: Removed.
ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
WebCore+SVG/RGBColorImpl.cpp:
WebCore.xcodeproj/project.pbxproj:
css: Added.
css/css_base.cpp: Added.
css/css_base.h: Added.
css/css_computedstyle.cpp: Added.
css/css_computedstyle.h: Added.
css/css_grammar.y: Added.
css/css_ruleimpl.cpp: Added.
css/css_ruleimpl.h: Added.
css/css_stylesheetimpl.cpp: Added.
css/css_stylesheetimpl.h: Added.
css/css_valueimpl.cpp: Added.
css/css_valueimpl.h: Added.
css/csshelper.cpp: Added.
css/csshelper.h: Added.
css/cssparser.cpp: Added.
css/cssparser.h: Added.
css/cssproperties.in: Added.
css/cssstyleselector.cpp: Added.
css/cssstyleselector.h: Added.
css/cssvalues.in: Added.
css/html4.css: Added.
css/makeprop: Added.
css/maketokenizer: Added.
css/makevalues: Added.
css/quirks.css: Added.
css/tokenizer.flex: Added.
khtml/css: Removed.
khtml/css/css_base.cpp: Removed.
khtml/css/css_base.h: Removed.
khtml/css/css_computedstyle.cpp: Removed.
khtml/css/css_computedstyle.h: Removed.
khtml/css/css_grammar.y: Removed.
khtml/css/css_ruleimpl.cpp: Removed.
khtml/css/css_ruleimpl.h: Removed.
khtml/css/css_stylesheetimpl.cpp: Removed.
khtml/css/css_stylesheetimpl.h: Removed.
khtml/css/css_valueimpl.cpp: Removed.
khtml/css/css_valueimpl.h: Removed.
khtml/css/csshelper.cpp: Removed.
khtml/css/csshelper.h: Removed.
khtml/css/cssparser.cpp: Removed.
khtml/css/cssparser.h: Removed.
khtml/css/cssproperties.in: Removed.
khtml/css/cssstyleselector.cpp: Removed.
khtml/css/cssstyleselector.h: Removed.
khtml/css/cssvalues.in: Removed.
khtml/css/html4.css: Removed.
khtml/css/makeprop: Removed.
khtml/css/maketokenizer: Removed.
khtml/css/makevalues: Removed.
khtml/css/quirks.css: Removed.
khtml/css/tokenizer.flex: Removed.
ksvg2/css/SVGCSSStyleSelector.cpp:
ksvg2/ecma/Ecma.cpp:
ksvg2/misc/KCanvasRenderingStyle.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGClipPathElementImpl.cpp:
ksvg2/svg/SVGColorImpl.cpp:
ksvg2/svg/SVGColorImpl.h:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGGradientElementImpl.cpp:
ksvg2/svg/SVGMaskElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyledElementImpl.h:
ksvg2/svg/SVGTextElementImpl.cpp:

9:41 PM Changeset in webkit [12143] by thatcher

2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):

6:37 PM Changeset in webkit [12142] by eseidel

1 edit
4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

svg/custom/recursive-clippath-expected.checksum: Added.
svg/custom/recursive-clippath-expected.png: Added.
svg/custom/recursive-clippath-expected.txt: Added.
svg/custom/recursive-clippath.svg: Added.

6:20 PM Changeset in webkit [12141] by ggaren

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6322 DateProtoFuncImp::callAsFunction can crash due to lack of type checking

kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

Added layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6322 DateProtoFuncImp::callAsFunction can crash due to lack of type checking

fast/js/date-proto-generic-invocation-expected.txt: Added.
fast/js/date-proto-generic-invocation.html: Added.
fast/js/resources/date-proto-generic-invocation.js: Added.

4:35 PM Changeset in webkit [12140] by hyatt

2 edits
22 moves
3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

WebCore.xcodeproj/project.pbxproj:
bindings: Added.
bindings/js: Added.
bindings/objc: Added.
bindings/objc/DOM.h: Added.
bindings/objc/DOM.mm: Added.
bindings/objc/DOMCSS.h: Added.
bindings/objc/DOMCSS.mm: Added.
bindings/objc/DOMCore.h: Added.
bindings/objc/DOMEvents.h: Added.
bindings/objc/DOMEvents.mm: Added.
bindings/objc/DOMEventsInternal.h: Added.
bindings/objc/DOMExtensions.h: Added.
bindings/objc/DOMHTML.h: Added.
bindings/objc/DOMHTML.mm: Added.
bindings/objc/DOMHTMLInternal.h: Added.
bindings/objc/DOMInternal.h: Added.
bindings/objc/DOMInternal.mm: Added.
bindings/objc/DOMPrivate.h: Added.
bindings/objc/DOMRange.h: Added.
bindings/objc/DOMStylesheets.h: Added.
bindings/objc/DOMTraversal.h: Added.
bindings/objc/DOMUtility.mm: Added.
bindings/objc/DOMViews.h: Added.
bindings/objc/DOMViews.mm: Added.
bindings/objc/DOMViewsInternal.h: Added.
kwq/DOM-CSS.mm: Removed.
kwq/DOM.h: Removed.
kwq/DOM.mm: Removed.
kwq/DOMCSS.h: Removed.
kwq/DOMCore.h: Removed.
kwq/DOMEvents.h: Removed.
kwq/DOMEvents.mm: Removed.
kwq/DOMEventsInternal.h: Removed.
kwq/DOMExtensions.h: Removed.
kwq/DOMHTML.h: Removed.
kwq/DOMHTML.mm: Removed.
kwq/DOMHTMLInternal.h: Removed.
kwq/DOMInternal.h: Removed.
kwq/DOMInternal.mm: Removed.
kwq/DOMPrivate.h: Removed.
kwq/DOMRange.h: Removed.
kwq/DOMStylesheets.h: Removed.
kwq/DOMTraversal.h: Removed.
kwq/DOMUtility.mm: Removed.
kwq/DOMViews.h: Removed.
kwq/DOMViews.mm: Removed.
kwq/DOMViewsInternal.h: Removed.

3:43 PM Changeset in webkit [12139] by andersca

1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca

4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <andersca@mac.com>

Reviewed by Timothy Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5367 Web Inspector: finish node attributes

WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.html:
WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.

2:25 PM Changeset in webkit [12137] by sullivan

2 edits in trunk/WebKit

Reviewed by Vicki Murley.

fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.

2:01 PM Changeset in webkit [12136] by ap

4 edits
1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6473 REGRESSION: Serious painting problems on new iLife and iWorks pages

khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
manual-tests/bugzilla-6473.html: Added.

1:46 PM Changeset in webkit [12135] by ap

2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.

12:34 PM Changeset in webkit [12134] by ap

3 edits
2 adds in trunk

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5401 [WebCoreBridge firstRectForDOMRange:] works incorrectly for the first character after a line wrap

Test: editing/input/wrapped-line-char-rect.html

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start

12:25 PM Changeset in webkit [12133] by justing

1 edit
12 adds in trunk/LayoutTests

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

editing/selection/replaced-boundaries-1-expected.checksum: Added.
editing/selection/replaced-boundaries-1-expected.png: Added.
editing/selection/replaced-boundaries-1-expected.txt: Added.
editing/selection/replaced-boundaries-1.html: Added.
editing/selection/replaced-boundaries-2-expected.checksum: Added.
editing/selection/replaced-boundaries-2-expected.png: Added.
editing/selection/replaced-boundaries-2-expected.txt: Added.
editing/selection/replaced-boundaries-2.html: Added.
editing/selection/replaced-boundaries-3-expected.checksum: Added.
editing/selection/replaced-boundaries-3-expected.png: Added.
editing/selection/replaced-boundaries-3-expected.txt: Added.
editing/selection/replaced-boundaries-3.html: Added.

12:24 PM Changeset in webkit [12132] by justing

4 edits in trunk/WebCore

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

khtml/rendering/render_image.cpp: (RenderImage::paint):
khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
khtml/rendering/render_replaced.h:

12:04 PM Changeset in webkit [12131] by tomernic

7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin

2 edits
4 deletes in trunk/WebCore

actually removed QPtrDict itself

ForwardingHeaders/qptrdict.h: Removed.
WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
kwq/KWQPtrDict.h: Removed.
kwq/KWQPtrDictImpl.cpp: Removed.
kwq/KWQPtrDictImpl.h: Removed.

9:52 AM Changeset in webkit [12129] by darin

83 edits in trunk/WebCore

Reviewed by John Sullivan.

removed all uses of QPtrDict, most uses of QMap

khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
khtml/ecma/kjs_window.h: Use HashMap.
khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
khtml/ecma/xmlhttprequest.h: Ditto.
khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
khtml/xml/dom_elementimpl.h: Use HashMap.

khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.

khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
khtml/xml/dom_stringimpl.h: Ditto.

bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
kcanvas/RenderForeignObject.cpp: Ditto.
kcanvas/RenderForeignObject.h: Ditto.
kcanvas/RenderSVGImage.h: Ditto.
kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
khtml/css/css_ruleimpl.cpp: Ditto.
khtml/css/css_valueimpl.h: Ditto.
khtml/ecma/kjs_dom.h: Ditto.
khtml/ecma/kjs_html.h: Ditto.
khtml/editing/composite_edit_command.cpp: Ditto.
khtml/editing/delete_selection_command.cpp: Ditto.
khtml/html/html_tableimpl.cpp: Ditto.
khtml/khtml_events.cpp: Ditto.
khtml/rendering/RenderText.cpp: Ditto.
khtml/rendering/render_block.cpp: Ditto.
khtml/rendering/render_br.cpp: Ditto.
khtml/rendering/render_inline.cpp: Ditto.
khtml/rendering/render_object.cpp: Ditto.
khtml/rendering/render_replaced.cpp: Ditto.
khtml/xml/dom2_rangeimpl.cpp: Ditto.
kwq/DOM.mm: Ditto.
page/Frame.cpp: Ditto.

kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
kcanvas/RenderSVGText.h: Ditto.
kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.

khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.

khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
khtml/xml/dom_xmlimpl.h: Ditto.

ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
ksvg2/svg/SVGPointImpl.cpp: Ditto.

kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.

kwq/KWQPainter.h: Added newly-needed include.

kwq/KWQPtrVector.h: Added append function.
kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
kwq/KWQVectorImpl.h: Added append.

kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.

kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
kwq/KWQWMatrix.h: Ditto.

loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.

loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
loader/CachedCSSStyleSheet.h: Ditto.
loader/CachedImage.cpp: Ditto.
loader/CachedImage.h: Ditto.
loader/CachedImageCallback.cpp: Ditto.
loader/CachedObject.cpp: Ditto.
loader/CachedObject.h: Ditto.
loader/CachedObjectClient.h: Ditto.
loader/CachedObjectClientWalker.cpp: Ditto.
loader/CachedObjectClientWalker.h: Ditto.
loader/CachedScript.cpp: Ditto.
loader/CachedScript.h: Ditto.
loader/CachedXSLStyleSheet.cpp: Ditto.

loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
loader/loader.h: Ditto.

1:03 AM Changeset in webkit [12128] by eseidel

5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

fast/box-sizing/percentage-height-expected.checksum:
fast/box-sizing/percentage-height-expected.png:
fast/box-sizing/percentage-height-expected.txt:
fast/box-sizing/percentage-height.html:

12:49 AM Changeset in webkit [12127] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization

kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.

12:30 AM Changeset in webkit [12126] by darin

2 edits in trunk/WebCore

WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.

12:05 AM Changeset in webkit [12125] by andersca

2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed