Timeline



Jan 23, 2006:

11:51 PM Changeset in webkit [12330] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • Made some functions return const AtomicString& instead of AtomicString because they could.


Result of Darin's and Eric's comments on the last patch.

  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
11:31 PM Changeset in webkit [12329] by mjs
  • 48 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): no need to mention PointerHash
  • kjs/collector.cpp: ditto
  • kjs/identifier.cpp: (KXMLCore::): declare DefaultHash the new way
  • kjs/internal.cpp: no need to mention PointerHash
  • kjs/ustring.h:
  • kxmlcore/HashCountedSet.h: change how we get the default hash to make it easier to specialize on PtrHash
  • kxmlcore/HashFunctions.h: (KXMLCore::): renamed PointerHash to PtrHash; changed DefaultHash so that it has a Hash typedef rather than being a hash function class itself; declared DefaultHash for int and partializy specialized for pointer types
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PtrHashIteratorAdapter::PtrHashIteratorAdapter): Slight tweaks for new way of handling pointer hash (KXMLCore::PtrHashConstIteratorAdapter::PtrHashConstIteratorAdapter): ditto (KXMLCore::): ditto
  • kxmlcore/HashMap.h: ditto
  • kxmlcore/HashSet.h: ditto

WebCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • bindings/objc/DOM.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]):
  • css/cssstyleselector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): (WebCore::CSSRuleSet::addToRuleSet):
  • khtml/dom/dom_string.h: (KXMLCore::):
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::classInfo): (KJS::HTMLElement::accessors): (KJS::HTMLElement::selectSetter): (KJS::HTMLElement::inputSetter): (KJS::HTMLElement::textAreaSetter): (KJS::HTMLElement::buttonSetter):
  • khtml/ecma/kjs_window.h:
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name): (WebCore::HTMLGenericFormElementImpl::setName):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::checkedRadioButtonForGroup): (WebCore::DocumentImpl::removeRadioButtonGroup):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::AtomicString): (DOM::AtomicString::impl): (KXMLCore::):
  • khtml/xml/dom_stringimpl.cpp: (DOM::equal):
  • khtml/xml/dom_stringimpl.h: (KXMLCore::):
  • khtml/xml/xml_tokenizer.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQObject.cpp:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/loader.h:
  • page/Frame.cpp: (Frame::endAllLifeSupport):
  • rendering/render_canvas.cpp: (RenderCanvas::selectionRect): (RenderCanvas::setSelection):
  • rendering/render_canvas.h:
  • rendering/render_object.h:
  • xml/xmlhttprequest.h:
10:24 PM Changeset in webkit [12328] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Tim Omernick.


  • kjs/array_object.cpp:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kxmlcore/HashMap.h: (KXMLCore::PairFirstExtractor::extract):
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::):
  • kxmlcore/HashSet.h: (KXMLCore::IdentityExtractor::extract):
  • kxmlcore/HashTable.h: (KXMLCore::addIterator): (KXMLCore::removeIterator): (KXMLCore::HashTable::add): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::add): (KXMLCore::HashTable::reinsert): (KXMLCore::HashTable::find): (KXMLCore::HashTable::contains): (KXMLCore::HashTable::remove): (KXMLCore::HashTable::allocateTable): (KXMLCore::HashTable::deallocateTable): (KXMLCore::HashTable::expand): (KXMLCore::HashTable::rehash): (KXMLCore::HashTable::clear): (KXMLCore::HashTable::swap): (KXMLCore::HashTable::operator): (KXMLCore::HashTable::checkTableConsistency): (KXMLCore::HashTable::checkTableConsistencyExceptSize): (KXMLCore::HashTable::invalidateIterators):
8:23 PM Changeset in webkit [12327] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/render_form.cpp: (RenderLineEdit::slotTextChanged): Made newText a DOMString. Assigning the empty DOMString to a QString and back to a DOMString resulted in a null string, which should be avoided here.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::qstring): Don't turn an empty DOMString into a null QString; make an empty QString instead.
8:20 PM Changeset in webkit [12326] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/update-webkit-localizable-strings: Added.
8:18 PM Changeset in webkit [12325] by darin
  • 4 edits in trunk/WebKit
  • fixed some small localizable strings issues
  • WebInspector.subproj/WebInspector.m: (-[DOMNode _nodeTypeName]): Changed so we don't have two localizable strings that are both "Document". I'm not sure we want to localize the DOM inspector UI at all, but this fixes things for now. (-[DOMNode _displayName]): Ditto.
  • English.lproj/Localizable.strings: Updated.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:08 PM Changeset in webkit [12324] by darin
  • 1 edit
    6 adds in trunk/LayoutTests
  • fast/frames/frame-element-name.html: Added.
  • fast/frames/frame-element-name-expected.txt: Added.
  • fast/frames/frame-element-name-expected.png: Added.
  • fast/frames/frame-element-name-expected.checksum: Added.
8:08 PM Changeset in webkit [12323] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/frames/frame-element-name.html

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot): Remove the quirk where frame and iframe elements reflect all the properties of the window inside the frame. Testing indicates that no other browser does this -- not sure why we were doing it.
5:38 PM Changeset in webkit [12322] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/BrowserExtensionMac.mm

Build fix to workaround 4213314.

4:56 PM Changeset in webkit [12321] by mjs
  • 24 edits in trunk

JavaScriptCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::protect):
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kxmlcore/HashCountedSet.h: (KXMLCore::::add):
  • kxmlcore/HashMap.h: (KXMLCore::::inlineAdd):
  • kxmlcore/HashSet.h: (KXMLCore::::add):
  • kxmlcore/HashTable.h: (KXMLCore::HashTable::add): (KXMLCore::::add): (KXMLCore::::HashTable):

WebCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::addElementById): (WebCore::DocumentImpl::registerDisconnectedNodeWithEventListeners):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList):
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add):
  • khtml/xml/dom_qname.cpp: (DOM::QualifiedName::QualifiedName):
  • loader/CachedObject.cpp: (WebCore::CachedObject::ref):
  • page/Frame.cpp: (Frame::keepAlive):
  • rendering/render_canvas.cpp: (RenderCanvas::addWidget):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paint):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addToRequestsByDocument):
4:25 PM Changeset in webkit [12320] by thatcher
  • 2 edits in trunk

Build fix.

4:23 PM Changeset in webkit [12319] by justing
  • 6 edits in trunk

Reviewed by thatcher
Turned on -O2 for Default and OptimizedWithSymbols.

3:38 PM Changeset in webkit [12318] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Fix for when building in a clean sandbox and WebKit isn't built yet.

1:41 PM Changeset in webkit [12317] by mjs
  • 74 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.


  • it's "Franklin Street", not "Franklin Steet"
  • kjs/array_instance.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.cpp:
  • kjs/collector.h:
  • kjs/completion.h:
  • kjs/context.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/debugger.cpp:
  • kjs/debugger.h:
  • kjs/dtoa.h:
  • kjs/error_object.cpp:
  • kjs/error_object.h:
  • kjs/function.cpp:
  • kjs/function.h:
  • kjs/function_object.cpp:
  • kjs/function_object.h:
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/identifier.h:
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp:
  • kjs/interpreter.h:
  • kjs/lexer.cpp:
  • kjs/lexer.h:
  • kjs/list.cpp:
  • kjs/list.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/object_object.cpp:
  • kjs/object_object.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/property_slot.cpp:
  • kjs/property_slot.h:
  • kjs/reference.cpp:
  • kjs/reference.h:
  • kjs/reference_list.cpp:
  • kjs/reference_list.h:
  • kjs/regexp.cpp:
  • kjs/regexp.h:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/scope_chain.cpp:
  • kjs/scope_chain.h:
  • kjs/simple_number.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/types.h:
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/PassRefPtr.h:
  • kxmlcore/RefPtr.h:
9:13 AM Changeset in webkit [12316] by darin
  • 1 edit
    2 adds in trunk/WebKitTools
  • added a couple of scripts -- more about these two soon
  • Scripts/extract-localizable-strings: Added.
  • Scripts/merge-changelog: Added.
9:10 AM Changeset in webkit [12315] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kxmlcore/PassRefPtr.h: Fix assignment operator from RefPtr of a different type by calling get() instead of going directly at m_ptr.
  • kxmlcore/RefPtr.h: Ditto.
  • other changes
  • JavaScriptCore.xcodeproj/project.pbxproj: Xcode decided to change this file. It's just a resorted list of keys in a dictionary.
  • kjs/fpconst.cpp: Wrap this file in #if APPLE since the alternate version in internal.cpp is in #if __APPLE. This file is to give us the "no init routine" property we want to have on OS X.
9:10 AM Changeset in webkit [12314] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Suggested by Anders.

  • fast/dom/clone-node-form-elements-with-attr.html: Added.
  • fast/dom/clone-node-form-elements-with-attr-expected.txt: Added.
9:07 AM Changeset in webkit [12313] by darin
  • 40 edits in trunk/WebCore

Reviewed by John Sullivan.

Test: fast/dom/clone-node-form-elements-with-attr.html

Changed cloneNode and some other functions to return PassRefPtr.
Also made m_render private and changed its name to m_renderer.

  • bindings/objc/DOM.mm: (-[DOMNode cloneNode:]): Add call to get() needed now that cloneNode returns a PassRefPtr.
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/split_element_command.cpp: (khtml::SplitElementCommand::doApply):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::reopenResidualStyleTags):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer): Use RefPtr and PassRefPtr as appropriate, since the result of cloneNode is now a referenced object in a PassRefPtr rather than a floating one and so needs to be kept referenced until used.
  • khtml/html/HTMLElementImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode): Changed to return a PassRefPtr. (WebCore::HTMLElementImpl::children): Ditto.
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/DocumentTypeImpl.cpp: (DOM::DocumentTypeImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/NamedNodeMapImpl.h: (WebCore::NamedNodeMapImpl::getNamedItem): Changed to return PassRefPtr. (WebCore::NamedNodeMapImpl::removeNamedItem): Ditto. (WebCore::NamedNodeMapImpl::setNamedItemNS): Ditto.
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::attach): Use renderer() instead of getting at m_render directly. (WebCore::HTMLGenericFormElementImpl::recalcStyle): Ditto. (WebCore::HTMLGenericFormElementImpl::isFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Ditto.
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::selectionStart): Ditto. (WebCore::HTMLInputElementImpl::selectionEnd): Ditto. (WebCore::HTMLInputElementImpl::setSelectionStart): Ditto. (WebCore::HTMLInputElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLInputElementImpl::select): Ditto. (WebCore::HTMLInputElementImpl::setSelectionRange): Ditto. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLInputElementImpl::setValue): Ditto. (WebCore::HTMLInputElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::recalcStyle): Ditto. (WebCore::HTMLSelectElementImpl::setRecalcListItems): Ditto. (WebCore::HTMLSelectElementImpl::reset): Ditto. (WebCore::HTMLSelectElementImpl::notifyOptionSelected): Ditto. (WebCore::HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::selectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::selectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::select): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionRange): Ditto. (WebCore::HTMLTextAreaElementImpl::updateValue): Ditto. (WebCore::HTMLTextAreaElementImpl::setValue): Ditto.
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::updateForNewURL): Ditto. (WebCore::HTMLFrameElementImpl::openURL): Ditto. (WebCore::HTMLFrameElementImpl::attach): Ditto. (WebCore::HTMLFrameElementImpl::close): Ditto. (WebCore::HTMLFrameElementImpl::willRemove): Ditto. (WebCore::HTMLFrameElementImpl::isFocusable): Ditto. (WebCore::HTMLFrameElementImpl::setFocus): Ditto. (WebCore::HTMLFrameElementImpl::frameWidth): Ditto. (WebCore::HTMLFrameElementImpl::frameHeight): Ditto. (WebCore::HTMLFrameSetElementImpl::defaultEventHandler): Ditto. (WebCore::HTMLFrameSetElementImpl::recalcStyle): Ditto. (WebCore::HTMLIFrameElementImpl::attach): Ditto. (WebCore::HTMLIFrameElementImpl::recalcStyle): Ditto.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLImageElementImpl::width): Ditto. (WebCore::HTMLImageElementImpl::height): Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::isFocusable): Ditto.
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLIElementImpl::attach): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::getAppletInstance): Ditto. (WebCore::HTMLAppletElementImpl::closeRenderer): Ditto. (WebCore::HTMLEmbedElementImpl::getEmbedInstance): Ditto. (WebCore::HTMLEmbedElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::getObjectInstance): Ditto. (WebCore::HTMLObjectElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLObjectElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::detach): Ditto. (WebCore::HTMLObjectElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLTableElementImpl::attach): Ditto.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Ditto. (WebCore::ContainerNodeImpl::getLowerRightCorner): Ditto. (WebCore::ContainerNodeImpl::setActive): Ditto. (WebCore::ContainerNodeImpl::setHovered): Ditto.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl): Ditto. (WebCore::DocumentImpl::elementFromPoint): Ditto. (WebCore::DocumentImpl::recalcStyle): Ditto. (WebCore::DocumentImpl::attach): Ditto. (WebCore::DocumentImpl::restoreRenderer): Ditto. (WebCore::DocumentImpl::detach): Ditto. (WebCore::DocumentImpl::setVisuallyOrdered): Ditto. (WebCore::DocumentImpl::updateSelection): Ditto. (WebCore::DocumentImpl::prepareMouseEvent): Ditto. (WebCore::DocumentImpl::cloneNode): Changed to return PassRefPtr. (WebCore::DocumentImpl::recalcStyleSelector): Use renderer() instead of getting at m_render directly. (WebCore::DocumentImpl::setInPageCache): Ditto.
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): Changed m_render to m_renderer. (WebCore::NodeImpl::~NodeImpl): Changed use of m_render to renderer(). (WebCore::NodeImpl::getRect): Ditto. (WebCore::NodeImpl::attach): Ditto. (WebCore::NodeImpl::detach): Ditto. (WebCore::NodeImpl::createRendererIfNeeded): Ditto. (WebCore::NodeImpl::getElementsByTagName): Changed to return PassRefPtr. (WebCore::NodeImpl::getElementsByTagNameNS): Ditto.
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::AttrImpl::cloneNode): Changed to return PassRefPtr. (WebCore::ElementImpl::cloneNode): Ditto. (WebCore::ElementImpl::scrollIntoView): Use renderer() instead of m_render. (WebCore::ElementImpl::scrollIntoViewIfNeeded): Ditto. (WebCore::ElementImpl::recalcStyle): Ditto. (WebCore::ElementImpl::setAttributeNode): Changed to return PassRefPtr. (WebCore::ElementImpl::removeAttributeNode): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto. (WebCore::NamedAttrMapImpl::setNamedItem): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto. (DOM::ElementImpl::setAttributeNodeNS): Ditto.
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): Changed use of m_render to renderer(). (CharacterDataImpl::appendData): Ditto. (CharacterDataImpl::insertData): Ditto. (CharacterDataImpl::deleteData): Ditto. (CharacterDataImpl::replaceData): Ditto. (CommentImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::splitText): Changed use of m_render to renderer(). (TextImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::recalcStyle): Changed use of m_render to renderer(). (CDATASectionImpl::cloneNode): Changed to return PassRefPtr.
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::cloneNode): Changed to return PassRefPtr. (DOM::EntityReferenceImpl::cloneNode): Ditto. (DOM::NotationImpl::cloneNode): Ditto. (DOM::ProcessingInstructionImpl::cloneNode): Ditto.
  • removed unused code
  • khtml/html/html_documentimpl.cpp: Removed unused slotHistoryChanged function.
  • khtml/html/html_documentimpl.h: Ditto.
  • kwq/KWQObject.cpp: (QObject::connect): Removed special case for slotHistoryChanged, no longer used.
  • fixed storage leak
  • bridge/mac/MacFrame.mm: (MacFrame::~MacFrame): Delete window widget.
7:30 AM Changeset in webkit [12312] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure

  • editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • editing/pasteboard/paste-4039777-fix-expected.png: Added.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • editing/pasteboard/paste-4039777-fix.html: Added.
4:00 AM Changeset in webkit [12311] by andersca
  • 1 edit
    1 add in trunk/WebCore

2006-01-23 Anders Carlsson <​andersca@mac.com>

Forgot to add this as part of
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869


  • manual-tests/resources/webkit-background.png: Added.
2:14 AM Changeset in webkit [12310] by darin
  • 2 edits in trunk/WebCore
  • fix layout tests
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added missing code to set wrapInAnonymousSection false in the case where adding a footer.
12:47 AM Changeset in webkit [12309] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add missing reviewer.

12:44 AM Changeset in webkit [12308] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

  • kjs/interpreter.h: make globalExec virtual so ScriptInterpreter can override it
12:36 AM Changeset in webkit [12307] by mjs
  • 17 edits
    4 adds in trunk/WebCore

Reviewed by Darin.


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::MacFrame): Initialize _bridge (MacFrame::~MacFrame): Clear the bridge's frame pointer and release it. (Frame::frameDetached): Reverse order of removing from old-style frames array and calling frameDetached. (MacFrame::createPart): Don't ref the part when creating it, since the child bridge is no longer going to own a ref. (MacFrame::setBridge): KWQRetain / KWQRelease since we know own the bridge. (MacFrame::detachFromView): New method; clear out the view.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (Bridge): Helper method to get a WebCoreFrameBridge from a Frame. (-[WebCoreFrameBridge firstChild]): Call through Frame. (-[WebCoreFrameBridge lastChild]): ditto (-[WebCoreFrameBridge childCount]): ditto (-[WebCoreFrameBridge previousSibling]): ditto (-[WebCoreFrameBridge nextSibling]): ditto (-[WebCoreFrameBridge isDescendantOfFrame:]): No need to cast parent pointer. (-[WebCoreFrameBridge appendChild:]): Call through Frame. (-[WebCoreFrameBridge _clearRenderPart]): New helper method to free the renderPart when removing a child. (-[WebCoreFrameBridge removeChild:]): Clear child's render part and call through to Frame. (-[WebCoreFrameBridge dealloc]): Remove unneeded m_frame-related code. (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge clearFrame]): New helper method, needed now that bridge can outlive frame. (-[WebCoreFrameBridge handleFallbackContent]): Make safe against a null frame. (-[WebCoreFrameBridge removeFromFrame]): ditto
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge initWithMainFrame:]): Create a Page instance. (-[WebCorePageBridge dealloc]): Delete the Page. (-[WebCorePageBridge mainFrame]): Get the main frame from the Page.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::globalExec): Override; keep frame alive, then call superclass.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::clear): Don't pass exec to window. (KJSProxyImpl::interpreter): Don't do keepAlive.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): If the active part's document is gone, use the frame's URL for security check purposes. (KJS::Window::clear): Don't take an ExecState parameter any more - it wasn't used.
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitOpen): If we've got a tokenizer, delete it before closing - you don't ever want to fire an onload handler because of an open.
  • page/Frame.cpp: (Frame::init): Pass `this' to FramePrivate constructor. (FrameCounter::~FrameCounter): Added debug counting of leftover Frame objects on exit. (Frame::Frame): Moved out-of-line. Increment debug counter. (Frame::~Frame): Assert that there is no life support going, either at the start or end of this method. Decrement frame counter. (Frame::stopLoading): tweaked for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::clear): ditto (Frame::stop): ditto (Frame::stopAnimations): ditto (Frame::checkEmitLoadEvent): ditto (Frame::processObjectRequest): ditto (Frame::childFrame): ditto (Frame::findFrame): ditto (Frame::setZoomFactor): ditto (Frame::frames): ditto (Frame::connectChild): ditto (Frame::disconnectChild): ditto (Frame::endAllLifeSupport): Method that, in debug mode, will clear all life suppor timers so the Frame exit counter works. (Frame::keepAlive): In debug mode, add proper support for endAllLifeSupport (Frame::slotEndLifeSupport): ditto (Frame::setPolicyBaseURL): Update for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::treeNode): New helper method, get the FrameTreeNode class that implements frame tree traversal. (Frame::nextSibling): Simple wrapper that calls through to treeNode(). (Frame::previousSibling): ditto (Frame::firstChild): ditto (Frame::lastChild): ditto (Frame::childCount): ditto (Frame::appendChild): ditto (Frame::removeChild): ditto (Frame::detachFromView): no-op, just a virtual base for the MAcFrame method.
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Add FrameTreeNode member.
  • page/FrameTreeNode.cpp: Added. (FrameTreeNode::~FrameTreeNode): detach all children from their view (FrameTreeNode::appendChild): implemented (FrameTreeNode::removeChild): implemented - make sure to detach child from its view.
  • page/FrameTreeNode.h: Added. (FrameTreeNode::FrameTreeNode): New; initialize fields tht need it. (FrameTreeNode::nextSibling): Trivial inline. (FrameTreeNode::previousSibling): ditto (FrameTreeNode::firstChild): ditto (FrameTreeNode::lastChild): ditto (FrameTreeNode::childCount): ditto
  • page/Page.cpp: Added. (Page::Page): Initialize mainFrame and bump pageCount appropriately. (Page::~Page): Detach main frame from view, handle ending life support when last frame is destroyed.
  • page/Page.h: Added. (Page::mainFrame): Trivial inline.
  • WebCore.xcodeproj/project.pbxproj: Add new files.

Jan 22, 2006:

11:23 PM Changeset in webkit [12306] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • Info.plist: Updated Apple copyright date. Need to update others too at some point.
  • WebCore-svg.exp: Removed unused empty file.
11:20 PM Changeset in webkit [12305] by staikos
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kxmlcore/Assertions.h: This file only works with APPLE right now
  • kjs/interpreter.cpp: ditto
  • kjs/simple_number.h: Add assert.h and remove from config.h
  • kjs/array_object.cpp: Use relative paths for kxmlcore includes
  • kjs/testkjs.cpp: Use relative paths for kxmlcore includes
11:01 PM Changeset in webkit [12304] by staikos
  • 2 edits in trunk/JavaScriptCore

Rubber stamp from Maciej:

  • Assertions is only valid in APPLE right now
11:00 PM Changeset in webkit [12303] by eseidel
  • 24 edits
    2 adds in trunk/WebCore

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make <animateColor> work again (broke during DOM merger).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5964

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::getAbsoluteRepaintRect): moved to .cpp file
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose): start svg animations (WebCore::DocumentImpl::svgExtensions): svg document extensions (WebCore::DocumentImpl::accessSVGExtensions): svg doc extensions
  • khtml/xml/DocumentImpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): cleanup
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent): update css lookup
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent): fix css property lookup
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer): use doc extensions (SVGAnimationElementImpl::targetAttribute): fix css properties (SVGAnimationElementImpl::setTargetAttribute): fix css properties
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::svgView): remove unnecessary static cast (SVGDocumentImpl::executeScripts):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp: (WebCore::SVGElementImpl::addSVGEventListener): helper function (WebCore::SVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGGElementImpl.cpp:
  • ksvg2/svg/SVGGElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::~SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::addSVGWindowEventListner): helper (WebCore::SVGSVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent): use doc extensions
  • ksvg2/svg/SVGStyledElementImpl.h:
  • page/Frame.cpp: (Frame::pauseTimeouts): pause svg animation (Frame::resumeTimeouts): resume svg animation
  • rendering/render_canvas.h:
10:55 PM Changeset in webkit [12302] by staikos
  • 2 edits in trunk/JavaScriptCore

unbreak preprocessor change
Reviewed by Maciej

10:10 PM Changeset in webkit [12301] by staikos
  • 17 edits in trunk/JavaScriptCore

Approved by Maciej and Darin.

  • kjs/:
  • kxmlcore/:

Update FSF address in license to make merging easier

9:44 PM Changeset in webkit [12300] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kjs/collector.cpp: merge major speedup from KDE on Linux

patch by Maks Orlovich, bug #6145
Also unify cpu detection

  • kjs/config.h: define simpler CPU macros
9:43 PM Changeset in webkit [12299] by darin
  • 2 edits in trunk/WebCore
  • fix deployment builds
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Init bool.
9:29 PM Changeset in webkit [12298] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/table/form-with-table-style.html: Added.
  • fast/table/form-with-table-style-expected.txt: Added.
  • fast/table/form-with-table-style-expected.png: Added.
  • fast/table/form-with-table-style-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

Test: fast/table/form-with-table-style.html

Hang was caused by the fact that RenderContainer has code to wrap table
styled elements in appropriate anonymous table elements, but the table
elements themselves have a special case for form elements that causes them
to call through, which led to infinite recursion as RenderContainer kept
making new tables which kept calling through to RenderContainer::addChild.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Improved logic about wrapping children in anonymous table sections in the following ways: (1) Do wrap a form properly it has a table display style (such as table-cell or table-row). (2) When an item has a particular display style, check that it has the right type of render object before casting it to that type. Also restructured the code a little to make it slightly more readable. (WebCore::RenderTable::layout): Added a FIXME about forms that have a display style that makes it a table section, since they will be skipped here in the loop to lay children out. (WebCore::RenderTable::recalcSections): Added checks similar to the ones in addChild above.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Moved form tag logic inside render object type check so that a table row that happens to be a form element won't be affected by the special form tag logic. Also added an explicit check for the table-cell style so we will wrap it in a row rather than just putting the form at this level.
  • rendering/RenderTableRow.h: Removed removeChildNode and dump functions that just called through to the base class.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Moved form tag logic inside render object type check so that a table cell that happens to be a form element won't be affected by the special form tag logic. Removed unnecessary null check of section() at end of function.
  • rendering/RenderTableCol.h: Removed addChild because all it did was assert (incorrectly) and then call through to the base class. Changed _span to be m_span.
  • rendering/RenderTableCol.cpp: Removed addChild function. Updated for change in name of m_span field.
9:07 PM Changeset in webkit [12297] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQListBox.mm: (QListBox::QListBox): Call setCopiesOnScroll:NO.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Ditto.
8:39 PM Changeset in webkit [12296] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej
Compile fix for FreeBSD 5.4 from KDE

6:53 PM Changeset in webkit [12295] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added a few Radar bug numbers for future searching purposes.

6:47 PM Changeset in webkit [12294] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/button-white-space-expected.checksum: Added.
  • fast/forms/button-white-space-expected.png: Added.
  • fast/forms/button-white-space-expected.txt: Added.
  • fast/forms/button-white-space.html: Added.

WebCore:

Reviewed by Maciej.

  • css/html4.css: Remove default white-space value for <button> tag to allow it to be inherited.
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.
  • css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild of html4.css work (shouldn't have to do this).
6:35 PM Changeset in webkit [12293] by darin
  • 2 edits in trunk/WebCore
  • css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch of whitespace that was supposed to go into a derived source file going to the console instead.
3:53 PM Changeset in webkit [12292] by eseidel
  • 17 edits
    6 adds in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

SVG needs to support "evt" instead of "event" in event handlers.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5874

  • WebCore.xcodeproj/project.pbxproj: added new classes
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::createHTMLEventHandler): simplified (WebCore::KJSProxyImpl::createSVGEventHandler): new
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createHTMLEventListener): simplified (WebCore::DocumentImpl::createSVGEventListener): new
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): use RefPtr
  • ksvg2/events/JSSVGLazyEventListener.cpp: Added. (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): added. (WebCore::JSSVGLazyEventListener::eventParameterName): added.
  • ksvg2/events/JSSVGLazyEventListener.h: Added.
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): use new SVG event handler
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::parseMappedAttribute): use new SVG event handler
  • page/Frame.cpp: updated KJSProxyImpl namespace
  • page/Frame.h: updated KJSProxyImpl namespace
  • page/FramePrivate.h: updated KJSProxyImpl namespace
2:57 PM Changeset in webkit [12291] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.


Makes the Inspector's Style pane take !important into account
when marking overloaded properties.

2:32 PM Changeset in webkit [12290] by darin
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/css/position-negative-top-margin.html: Added.
  • fast/css/position-negative-top-margin-expected.txt: Added.
  • fast/css/position-negative-top-margin-expected.png: Added.
  • fast/css/position-negative-top-margin-expected.checksum: Added.
  • fast/box-sizing/box-sizing-expected.txt: Updated, since absolute position box locations changed.
  • fast/box-sizing/box-sizing-expected.png: Ditto.
  • fast/box-sizing/box-sizing-expected.checksum: Ditto.
  • changed a few suitable tests to dump as text (in part to fix a failing pixel test in one)
  • fast/parser/entity-surrogate-pairs.html: Added a call to dumpAsText().
  • fast/parser/entity-surrogate-pairs-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/head-comment.html Added a call to dumpAsText().
  • fast/parser/head-comment-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/head-comment-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.

WebCore:

Reviewed by Maciej.

Test: fast/css/position-negative-top-margin.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustPositionedBlock): Fixed two different problems that contributed to the bug: (1) Added a call to calcVerticalMargins otherwise the margin will always be 0. (2) Corrected logic for the negative margin case, which was comparing a negative margin-top to a number representing the absolute value of the margin.
1:27 PM Changeset in webkit [12289] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Maciej mentioned he reviewed the change George just landed, so updating the log to reflect that.

12:32 PM Changeset in webkit [12288] by ap
  • 5 edits
    12 adds in trunk

Reviewed by Darin.

Also replaced tabs with spaces in the changed files.

Test cases:

  • fast/table/append-cells.html
  • fast/table/append-cells2.html
  • fast/table/remove-td-display-none.html
  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Shrink columns and columnPos to the actual number of columns.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::numColumns): New function. (WebCore::RenderTableSection::dump): Use gridRows instead of grid.size() for row count, preventing crashes.
  • rendering/RenderTableSection.h: Added numColumns() and a comment about cCol/cRow.
12:20 PM Changeset in webkit [12287] by darin
  • 22 edits in trunk/WebCore

Reviewed by Anders.

Once we do the same with cloneNode, I believe we'll fix one of our P1 bugs,
but cloneNode was a little too much to do without doing this first pass.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::childNodes): Updated for parameter changes. (WebCore::NodeImpl::insertBefore): Ditto. (WebCore::NodeImpl::replaceChild): Ditto. (WebCore::NodeImpl::removeChild): Ditto. (WebCore::NodeImpl::appendChild): Ditto. (WebCore::NodeImpl::addChild): Ditto. (WebCore::NodeImpl::addEventListener): Ditto. (WebCore::NodeImpl::setHTMLEventListener): Ditto. (WebCore::NodeImpl::isDefaultNamespace): Updated for changed name of ancestorElement. (WebCore::NodeImpl::lookupPrefix): Ditto. (WebCore::NodeImpl::lookupNamespaceURI): Ditto. (WebCore::NodeImpl::lookupNamespacePrefix): Ditto. (WebCore::NodeImpl::ancestorElement): Changed name from getAncestorElement.
  • khtml/xml/NodeImpl.h: Changed most functions where it makes sense to take and return PassRefPtr instead of raw pointers. Even non-obvious cases like appendChild, where the return value has to be PassRefPtr only because it might be removed when the JavaScript triggered by the DOM mutation event runs (normally, there's no need to return an "owning" pointer because the tree now owns the newly-inserted node). Made the ancestorElement function private.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): Updated for changes from _first to m_firstChild and _last to m_lastChild. (WebCore::ContainerNodeImpl::removeAllChildren): Ditto. (WebCore::ContainerNodeImpl::firstChild): Ditto. (WebCore::ContainerNodeImpl::lastChild): Ditto. (WebCore::ContainerNodeImpl::insertBefore): Updated for parameter changes. (WebCore::ContainerNodeImpl::replaceChild): Ditto. (WebCore::ContainerNodeImpl::willRemove): Updated for m_lastChild. (WebCore::ContainerNodeImpl::removeChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::removeChildren): Updated for m_first/lastChild. (WebCore::ContainerNodeImpl::appendChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::hasChildNodes): Updated for m_firstChild. (WebCore::ContainerNodeImpl::addChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::attach): Updated for m_firstChild. (WebCore::ContainerNodeImpl::detach): Ditto. (WebCore::ContainerNodeImpl::insertedIntoDocument): Ditto. (WebCore::ContainerNodeImpl::removedFromDocument): Ditto. (WebCore::ContainerNodeImpl::insertedIntoTree): Ditto. (WebCore::ContainerNodeImpl::removedFromTree): Ditto.
  • khtml/xml/ContainerNodeImpl.h: Removed unused checkSameDocument and checkIsChild. Made more things private, updated parameters for NodeImpl functions.
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::insertBefore): Ditto. (DOM::HTMLSelectElementImpl::replaceChild): Ditto. (DOM::HTMLSelectElementImpl::removeChild): Ditto. (DOM::HTMLSelectElementImpl::appendChild): Ditto. (DOM::HTMLSelectElementImpl::addChild): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Ditto.
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): Updated for parameter type change. Also changed to look at return value, not exception code, to check for success. (WebCore::HTMLOptGroupElementImpl::replaceChild): Ditto. (WebCore::HTMLOptGroupElementImpl::removeChild): Ditto. (WebCore::HTMLOptGroupElementImpl::appendChild): Ditto. (WebCore::HTMLOptGroupElementImpl::addChild): Ditto.
  • khtml/html/HTMLOptGroupElementImpl.h: Ditto.
  • WebCore+SVG/kdom.h: Renamed enum from ExceptionCode to ExceptionCodes to avoid conflict with a typedef ExceptionCode I added.
  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): Added get() call since return value is a PassRefPtr. (-[DOMNode replaceChild::]): Ditto. (-[DOMNode removeChild:]): Ditto. (-[DOMNode appendChild:]): Ditto.
  • khtml/ecma/kjs_dom.h: Changed getDOMNode to take PassRefPtr.
  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Changed to take PassRefPtr.
  • khtml/html/HTMLElementImpl.cpp: Added dom2_events.h include, now needed. Re-sorted includes.
  • ksvg2/svg/SVGElementImpl.cpp: Ditto.
  • khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::documentElement): Changed access to now-private data member _first to equivalent inline function fastFirstChild().
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle): Ditto.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::setCaption): Updated to work with new replaceChild that returns PassRefPtr. (WebCore::HTMLTableElementImpl::setTHead): Ditto. (WebCore::HTMLTableElementImpl::setTFoot): Ditto. (WebCore::HTMLTableElementImpl::setTBody): Ditto. (WebCore::HTMLTableElementImpl::addChild): Updated for parameter type change. (WebCore::HTMLTableSectionElementImpl::addChild): Ditto. (WebCore::HTMLTableRowElementImpl::addChild): Ditto.
  • khtml/html/html_tableimpl.h: Ditto.
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an unneeded explicit call to removeChild. appendChild already takes care of removing the child from its own location. This avoids the fact that removeChild was removing the parent, the only thing keeping the node alive. This is sort of the "flip side" of our removeChild leaks -- code that depended on the behavior that caused the leaks.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Removed unneeded isHTMLElement() calls from before the "qualified name" change.
11:22 AM Changeset in webkit [12286] by darin
  • 1 add in trunk/WebCore/manual-tests/bugzilla-3509.html

Somehow this file didn't get checked in before (even though it was
mentioned in the change log).

11:18 AM Changeset in webkit [12285] by ap
  • 2 edits in trunk/WebKitTools

Fix by Mark Rowe . Reviewed by Anders.


Build fix. build-webkit dies with "invalid build action: (empty string)"

  • Scripts/build-webkit: Use svgOptions in an array context so xcodebuild doesn't choke on an empty argument.
6:41 AM Changeset in webkit [12284] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix --no-svg option to use XCode flags instead of gcc flags.

  • Scripts/build-webkit:
6:08 AM Changeset in webkit [12283] by eseidel
  • 341 edits in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com

Rubber-stamped by anders.

Remove WebCore-no-SVG target and wrap files in #if SVG_SUPPORT
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6633

2:49 AM Changeset in webkit [12282] by ap
  • 8 edits
    2 copies
    2 moves
    1 add in trunk/WebCore

Reviewed by Maciej.

  • WebCore.xcodeproj/project.pbxproj: Adjusted for moved and renamed files. New group "xml" to match directory structure.
  • xml: Added.
  • khtml/ecma/JSXMLHttpRequest.cpp: Added.
  • khtml/ecma/JSXMLHttpRequest.h: Added.
  • khtml/ecma/xmlhttprequest.cpp: Removed.
  • khtml/ecma/xmlhttprequest.h: Removed.
  • xml/xmlhttprequest.cpp: Added.
  • xml/xmlhttprequest.h: Added.
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrUndefined): Moved from kjs_events.cpp.
  • khtml/ecma/kjs_binding.h: Added prototype for jsStringOrUndefined().
  • khtml/ecma/kjs_events.cpp: Removed jsStringOrUndefined().
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Use new class name for JSXMLHttpRequest.
  • kwq/KWQSlot.cpp: XMLHttpRequestQObject is now in WebCore, not KJS.
  • page/Frame.cpp: (Frame::stopLoading): XMLHttpRequest is now in WebCore, not KJS.
1:57 AM Changeset in webkit [12281] by eseidel
  • 119 edits
    1 delete in trunk

2006-01-22 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for custom fill/strokes on text.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6448

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint): use new painter setup/teardown infrastructure
  • kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::KRenderingPaintServer): (KRenderingPaintServer::setup): (KRenderingPaintServer::render): (KRenderingPaintServer::teardown): (KRenderingPaintServer::isPaintingText): (KRenderingPaintServer::setPaintingText):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (setupShadingWithStyle): (renderShadingWithStyle): (teardownShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::render): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::render): (KRenderingPaintServerRadialGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerPatternQuartz::KRenderingPaintServerPatternQuartz):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerQuartzHelper::strokePath): (KRenderingPaintServerQuartzHelper::clipToStrokePath): (KRenderingPaintServerQuartzHelper::fillPath): (KRenderingPaintServerQuartzHelper::clipToFillPath): (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerSolidQuartz::setup): (KRenderingPaintServerSolidQuartz::render): (KRenderingPaintServerSolidQuartz::teardown): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerPatternQuartz::setup): (KRenderingPaintServerPatternQuartz::render): (KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h: fix prototype
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KSVGPainterFactory::fillPaintServer): (KSVGPainterFactory::strokePaintServer): (KSVGPainterFactory::cssPrimitiveToLength): (KSVGPainterFactory::strokePainter): (KSVGPainterFactory::fillPainter):
  • ksvg2/misc/KCanvasRenderingStyle.h:

Jan 21, 2006:

10:20 PM Changeset in webkit [12280] by staikos
  • 5 edits in trunk/JavaScriptCore

Reviewed by Maciej

Merge some build fixes for various Perl and gcc versions from KDE SVN.

8:28 PM Changeset in webkit [12279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.


  • manual-tests/bugzilla-3509.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Force repaint if the child didn't move but didn't repaint correctly during layout because it was not at its final position then.
4:25 PM Changeset in webkit [12278] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.

Make sure shorthand properties get striked-out if
all the properties they expand into are overloaded.

2:11 PM Changeset in webkit [12277] by eseidel
  • 4 edits in trunk/WebKitTools

2006-01-20 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by eseidel.

  • Scripts/build-drawtest: Changed bareword 'true' to 1.
  • Scripts/run-drawtest: Changed bareword 'true' to 1.
1:58 PM Changeset in webkit [12276] by andersca
  • 7 edits
    7 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869
Should use HTML Image element instead of JS Image object

  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction): Don't check Image object. Instead, if the element passed in is an image element which isn't in any document, use its pixmap.


  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::imageGetter): Add complete.


(KJS::ImageConstructorImp::construct):
Take a QPixmap instead of an Image.


(KJS::KJS::Context2DFunction::callAsFunction):
Remove usage of Image and use HTMLImageElementImpl instead.

  • khtml/ecma/kjs_html.h: Remove Image class.


(KJS::HTMLElement::):
Add ImgComplete.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): If the element has no renderer but its image size is known return that instead.


(WebCore::HTMLImageElementImpl::complete):
New function, returns true if an image has finished loading.


  • khtml/html/html_imageimpl.h: Add complete.


  • manual-tests/drag-image.html: Added.
1:20 PM Changeset in webkit [12275] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-21 Anders Carlsson <​andersca@mac.com>

  • editing/editing.js: Fix typo which made editing test cases fail.
12:15 PM Changeset in webkit [12274] by andersca
  • 4 edits
    4 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/editing/jsediting.cpp: Add support for the "Strikethrough" command.


12:02 PM Changeset in webkit [12273] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/hovered-detach.html: Added.
  • fast/dynamic/hovered-detach-expected.txt: Added.

WebCore:

Test: fast/dynamic/hovered-detach.html

Reviewed by Darin.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Set m_hovered to false and set the document's hoverNode to an hovered ancestor that still has a renderer.
  • rendering/render_layer.cpp: Changed static method hoverAncestor() into a RenderObject instance method. (WebCore::commonAncestor): (WebCore::RenderLayer::updateHoverActiveState):
  • rendering/render_object.cpp: Ditto. (WebCore::RenderObject::hoverAncestor)
  • rendering/render_object.h: Ditto.
11:22 AM Changeset in webkit [12272] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Adds computed style to the Web Inspector.
Adds a "mapped style" link to the mapped attributes.

Jan 20, 2006:

7:47 PM Changeset in webkit [12271] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 6666, pseudo-element rules incorrectly displayed
in Web Inspector.


Reviewed by darin

Added fast/inspector/matchedrules.html as test case.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
7:45 PM Changeset in webkit [12270] by hyatt
  • 2 adds in trunk/LayoutTests/fast/inspector

Add a test case for Web Inspector style matching bug.

7:05 PM Changeset in webkit [12269] by thatcher
  • 7 edits
    2 deletes in trunk

WebCore:

Reviewed by John.

Removes code that is no longer needed with the new Web Inspector.

  • bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
  • bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

Reviewed by John, some parts by Darin.

Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
that menu item to prevent a crash.

  • WebKit.exp: adds WebInspector, removes WebDebugDOMNode
  • WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
  • WebView.subproj/WebDebugDOMNode.h: Removed.
  • WebView.subproj/WebDebugDOMNode.m: Removed.
  • WebView.subproj/WebView.m: (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item
5:03 PM Changeset in webkit [12268] by andersca
  • 17 edits in trunk/WebCore

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by David Hyatt.

Rename Frame::xmlDocImpl => Frame::document and
Frame::replaceDocImpl => Frame::setDocument


  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::keyEvent): (MacFrame::dispatchCPPEvent): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::bodyBackgroundColor): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::setMarkedTextRange): (MacFrame::dashboardRegionsDictionary): (MacFrame::shouldClose):
  • bridge/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): (frameHasSelection): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge saveDocumentState]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge saveDocumentToPageCache]): (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge deselectAll]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge copyDOMTree:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge unmarkAllMisspellings]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge DOMDocument]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge doneProcessingData]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/editing/jsediting.cpp:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::contentDocument):
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]):
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • page/Frame.cpp: (Frame::document): (Frame::setDocument): (Frame::setFocusNodeIfNeeded): (Frame::isPointInsideSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectionComputedStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::renderer): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayoutWithPageWidthRange): (Frame::sendScrollEvent): (Frame::clearTimers): (Frame::styleForSelectionStart): (Frame::setSelectionFromNone): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol):
  • page/Frame.h:
  • page/FrameView.cpp: (FrameView::~FrameView): (FrameView::clear): (FrameView::resizeEvent): (FrameView::adjustViewSize): (FrameView::layout): (FrameView::updateDashboardRegions): (FrameView::viewportMousePressEvent): (FrameView::viewportMouseDoubleClickEvent): (FrameView::viewportMouseMoveEvent): (FrameView::viewportMouseReleaseEvent): (FrameView::keyPressEvent): (FrameView::dispatchDragEvent): (FrameView::updateDragAndDrop): (FrameView::focusNextPrevNode): (FrameView::dispatchMouseEvent): (FrameView::viewportWheelEvent): (FrameView::timerEvent): (FrameView::scheduleRelayout): (FrameView::unscheduleRelayout):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
2:54 PM Changeset in webkit [12267] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

Corrects the cascade order for mapped attributes.
Shows "inline stylesheet" rather than "null" for rules in <style> tags.

1:48 PM Changeset in webkit [12266] by cpeterse
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Build fix.

  • khtml/xml/DocumentImpl.cpp:
12:20 PM Changeset in webkit [12265] by eseidel
  • 3 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Unbreak build (partial commit of animation patch)

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/DocumentImpl.h:
11:30 AM Changeset in webkit [12264] by eseidel
  • 4 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Missed the kcanvas directory in my previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
11:24 AM Changeset in webkit [12263] by eseidel
  • 28 edits
    8 copies
    6 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Break classes in render_table out into separate files.
Move render_block to RenderBlock.
Move render_container to RenderContainer.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::insertRow):
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_position.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • page/Frame.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp: Added.
  • rendering/RenderBlock.h: Added.
  • rendering/RenderContainer.cpp: Added. (WebCore::RenderContainer::addChild):
  • rendering/RenderContainer.h: Added.
  • rendering/RenderTable.cpp: Added. (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::updateFirstLetter):
  • rendering/RenderTable.h: Added.
  • rendering/RenderTableCell.cpp: Added. (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCell.h: Added.
  • rendering/RenderTableCol.cpp: Added. (WebCore::RenderTableCol::RenderTableCol): (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableCol.h: Added.
  • rendering/RenderTableRow.cpp: Added. (WebCore::RenderTableRow::RenderTableRow):
  • rendering/RenderTableRow.h: Added.
  • rendering/RenderTableSection.cpp: Added. (WebCore::RenderTableSection::RenderTableSection):
  • rendering/RenderTableSection.h: Added.
  • rendering/RenderText.cpp:
  • rendering/bidi.cpp:
  • rendering/render_block.cpp: Removed.
  • rendering/render_block.h: Removed.
  • rendering/render_box.cpp:
  • rendering/render_canvas.h:
  • rendering/render_container.cpp: Removed.
  • rendering/render_container.h: Removed.
  • rendering/render_flexbox.h:
  • rendering/render_flow.cpp:
  • rendering/render_flow.h:
  • rendering/render_form.h:
  • rendering/render_frames.h:
  • rendering/render_inline.cpp:
  • rendering/render_inline.h:
  • rendering/render_line.cpp:
  • rendering/render_list.h:
  • rendering/render_object.cpp:
  • rendering/render_replaced.h:
  • rendering/render_table.cpp: Removed.
  • rendering/render_table.h: Removed.
  • rendering/table_layout.cpp:
11:10 AM Changeset in webkit [12262] by mjs
  • 1 edit
    3 adds in trunk/LayoutTests
  • added test case for a parsing bug that was fixed in different ways in KJS and JSC. In older KJS versions, there would have been a parse error.
  • fast/js/parse-backslash-before-newline-expected.txt: Added.
  • fast/js/parse-backslash-before-newline.html: Added.
  • fast/js/resources/parse-backslash-before-newline.js: Added.
10:45 AM Changeset in webkit [12261] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/overflow/image-selection-highlight-expected.checksum: Added.
  • fast/overflow/image-selection-highlight-expected.png: Added.
  • fast/overflow/image-selection-highlight-expected.txt: Added.
  • fast/overflow/image-selection-highlight.html: Added.

WebCore:

Test: fast/overflow/image-selection-highlight.html

Reviewed by Darin, committed by Adele.


  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionRect): Subtract the containing block's scroll offset.
10:13 AM Changeset in webkit [12260] by thatcher
  • 5 copies in tags/Safari-521.6

Final Safari-521.6 tag. Ignore the diffs, they are wrong!

10:11 AM Changeset in webkit [12259] by thatcher
  • 1 delete in tags/Safari-521.6

This tag needs updated.

9:42 AM Changeset in webkit [12258] by thatcher
  • 1 edit in trunk/WebKitSite/contact.html

Add ​irc://irc.freenode.net/#webkit links.

9:26 AM Changeset in webkit [12257] by thatcher
  • 1 edit in trunk/WebKitSite/coding/contributing.html

Fixes the rest of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6535
add <tt></tt> around an instance of "svn diff".

12:18 AM Changeset in webkit [12256] by thatcher
  • 2 edits in trunk/WebKitSite

Replace all "cvs" references with "svn".

Jan 19, 2006:

11:45 PM Changeset in webkit [12255] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric.

Adds inline style reporting and mapped attribute support to the Inspector Style pane.
Cleans up the node attributes area with a more natural attr = "value" look.
Slight optimization to only update visible scrollbars during a window resize.

10:42 PM Changeset in webkit [12254] by thatcher
  • 1 edit in trunk

Add WebKitBuild to the svn:ignore

10:21 PM Changeset in webkit [12253] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix a typo that made WebCore build and link UserAgentStyleSheets.cpp every time, even if nothing changed.

9:10 PM Changeset in webkit [12252] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6631
Inspector window has inappropriate maximum height

5:40 PM Changeset in webkit [12251] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit.xcodeproj/project.pbxproj: made WebNSUserDefaultsExtras.h private (SPI) so its one method can be called from Safari, so Safari can stop calling the similar method in Foundation.
5:22 PM Changeset in webkit [12250] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<embed> and <object> tags show up blank when going back/forward.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6679

No test currently possible.

  • page/Frame.cpp: (Frame::canCachePage):
5:02 PM Changeset in webkit [12249] by sullivan
  • 5 edits
    1 add in trunk/WebKit

Reviewed by Tim Omernick.


Made _webKit_guessedMIMEType SPI so Safari can use it in order to stop using
the similar SPI method in Foundation. This involved splitting it out of the file
it was in, to avoid creating any other new SPI here. Poor svn diff got mighty
confused in the process.

  • Misc.subproj/WebNSDataExtras.h: removed _webkit_guessedMIMEType from here
  • Misc.subproj/WebNSDataExtrasPrivate.h: Added. Contains only _webkit_guessedMIMEType. This file is private (SPI), whereas WebNSDataExtras.h is project-internal. I could have renamed WebNSDateExtras.h to WebNSDateExtrasInternal.h also, but I minimized the gratuitous change level here by not doing that.


  • Misc.subproj/WebNSDataExtras.m: Despite the great confusion of svn diff, all I actually did here was move _webkit_guessedMIMEType and its helper _webkit_guessedMIMETypeForXML into a new category. No lines of code were harmed while creating this patch.
  • WebKit.xcodeproj/project.pbxproj: updated for new file
  • WebView.subproj/WebView.m: Added #import for new file since WebView uses _webkit_guessedMIMEType
4:29 PM Changeset in webkit [12248] by thatcher
  • 5 copies in tags/Safari-521.6

Trying the Safari-521.6 tag again

4:26 PM Changeset in webkit [12247] by thatcher
  • 1 delete in tags/Safari-521.6

Bad tag, not sure what happened.

4:22 PM Changeset in webkit [12246] by thatcher
  • 5 copies in tags/Safari-521.6

Tagging Safari-521.6

3:57 PM Changeset in webkit [12245] by thatcher
  • 8 adds in branches/Safari-Leo-branch

Versioning to 521.6

3:50 PM Changeset in webkit [12244] by thatcher
  • 1 add in branches/Safari-Leo-branch
3:50 PM Changeset in webkit [12243] by eseidel
  • 64 edits
    6 copies
    4 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Split html_miscimpl.* into separate files and move html_elementimpl
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6670

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_valueimpl.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/html/HTMLBaseFontElementImpl.cpp: Added.
  • khtml/html/HTMLBaseFontElementImpl.h: Added.
  • khtml/html/HTMLButtonElementImpl.cpp:
  • khtml/html/HTMLCollectionImpl.cpp: Added. (WebCore::HTMLCollectionImpl::traverseNextItem):
  • khtml/html/HTMLCollectionImpl.h: Added.
  • khtml/html/HTMLElementImpl.cpp: Added.
  • khtml/html/HTMLElementImpl.h: Added.
  • khtml/html/HTMLFieldSetElementImpl.cpp:
  • khtml/html/HTMLFormCollectionImpl.cpp: Added.
  • khtml/html/HTMLFormCollectionImpl.h: Added.
  • khtml/html/HTMLFormElementImpl.cpp:
  • khtml/html/HTMLFormElementImpl.h:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLIsIndexElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.h:
  • khtml/html/HTMLLegendElementImpl.cpp:
  • khtml/html/HTMLNameCollectionImpl.cpp: Added.
  • khtml/html/HTMLNameCollectionImpl.h: Added.
  • khtml/html/HTMLOptGroupElementImpl.cpp:
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLOptionElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp: Removed.
  • khtml/html/html_elementimpl.h: Removed.
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.h:
  • khtml/html/html_miscimpl.cpp: Removed.
  • khtml/html/html_miscimpl.h: Removed.
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_elementimpl.cpp:
  • kwq/KWQAccObject.mm:
  • loader/loader.cpp:
  • page/Frame.cpp: (Frame::restoreURL): (Frame::stopLoading): (Frame::receivedFirstData): (Frame::gotoAnchor): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::findFrame): (Frame::executeScript):
  • page/FrameView.cpp: (FrameView::useSlowRepaints):
  • rendering/render_applet.cpp:
  • rendering/render_applet.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
  • rendering/render_canvasimage.cpp:
  • rendering/render_canvasimage.h:
  • rendering/render_frames.cpp:
  • rendering/render_image.cpp:
  • rendering/render_image.h:
  • rendering/render_layer.cpp:
3:44 PM Changeset in webkit [12242] by thatcher
  • 1 delete in branches/Safari-Leo-branch

Redoing this branch so we only include Info.plists

3:08 PM Changeset in webkit [12241] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/report-include-statistics: Added a new script.
1:42 PM Changeset in webkit [12240] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Misc.subproj/WebNSURLExtras.h: added declaration of _webkit_rangeOfURLScheme so Safari can call it as a step towards weaning Safari from Foundation SPI.
11:45 AM Changeset in webkit [12239] by thatcher
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: include JavaScriptGlue in the build
10:57 AM Changeset in webkit [12238] by darin
  • 1 edit in trunk/Makefile

Build JavaScriptGlue.

9:14 AM Changeset in webkit [12237] by andersca
  • 7 edits in trunk

2006-01-19 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): if getCSSPropertyValue returns 0 (which is true for shorthand properties), try getPropertyValue instead.
1:35 AM Changeset in webkit [12236] by adele
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt and Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6665
Implement NSView-less version of <input type="text">


Initial implementation of new and improved text fields.
This will only be turned on if an input element has khtml-appearance: textfield.

  • WebCore.xcodeproj/project.pbxproj: Added RenderTextField.h and RenderTextField.cpp
  • css/cssvalues.in: Fixed omitted button-bevel value. This was causing an off-by-one error when getting khtml-appearance value.
  • khtml/html/HTMLInputElementImpl.cpp: Added checks for khtml-appearance to decide when to use RenderTextField instead of RenderLineEdit. (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::select): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::createRenderer): (DOM::HTMLInputElementImpl::defaultEventHandler):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Also allow editable elements with no parent to be focusable.
  • khtml/xml/NodeImpl.h: (WebCore::NodeImpl::setAttached): Added to set m_attached without having to call attach().
  • rendering/RenderTextField.cpp: Added. (khtml:::RenderBlock): (khtml::RenderTextField::~RenderTextField): (khtml::RenderTextField::addChild): (khtml::RenderTextField::removeChild): (khtml::RenderTextField::setStyle): (khtml::RenderTextField::getDivStyle): (khtml::RenderTextField::updateFromElement): (khtml::RenderTextField::selectionStart): (khtml::RenderTextField::selectionEnd): (khtml::RenderTextField::setSelectionStart): (khtml::RenderTextField::setSelectionEnd): (khtml::RenderTextField::select): (khtml::RenderTextField::setSelectionRange):
  • rendering/RenderTextField.h: Added. (khtml::RenderTextField::removeLeftoverAnonymousBoxes): (khtml::RenderTextField::renderName):
  • rendering/render_container.cpp: (RenderContainer::destroy): use renamed destroyLeftoverChildren. (RenderContainer::destroyLeftoverChildren): renamed from destroyLeftoverAnonymousChildren.
  • rendering/render_container.h:
  • rendering/render_flow.cpp: (RenderFlow::destroy): use renamed destroyLeftoverChildren.
1:20 AM Changeset in webkit [12235] by eseidel
  • 5 edits
    4 adds in trunk

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin & anders.

Fix opacity crasher for <text> and <image>.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6668
Even though the crash is fixed, opacity still doesn't work.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6669

  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint):
1:18 AM Changeset in webkit [12234] by darin
  • 21 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Changed SVG check to work even if the path has spaces in it by using the form of open that treats each argument as a string rather than backtick syntax for reading the output of the nm tool.
12:59 AM Changeset in webkit [12233] by darin
  • 43 edits
    4 deletes in trunk/WebCore

Reviewed by Hyatt.

  • removed all use of QMap
  • ForwardingHeaders/qmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQMap.h, KWQMapImpl.h, KWQMapImpl.cpp.
  • kwq/KWQMap.h: Removed.
  • kwq/KWQMapImpl.cpp: Removed.
  • kwq/KWQMapImpl.h: Removed.
  • bridge/BrowserExtension.h: (WebCore::URLArgs::metaData): Converted from QMap of QString to HashMap of DOMString.
  • bridge/mac/BrowserExtensionMac.mm: Ditto.
  • bridge/mac/MacFrame.mm: (MacFrame::openURLRequest): Ditto. (MacFrame::urlSelected): Ditto. (MacFrame::createPart): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::showModalDialog): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::createRenderer): Ditto.
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet): Ditto.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::toString): Added. Converts to DOMString instead of QString. (WebCore::attributesStartElementNsHandler): Converted from QMap of QString to HashMap of DOMString. (WebCore::parseAttributes): Ditto.
  • khtml/xml/xml_tokenizer.h: (WebCore::Tokenizer::setTransformSource): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll): Ditto.
  • kwq/KWQKJavaAppletWidget.h: Ditto.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): Ditto.
  • kwq/KWQKJobClasses.h: Ditto.
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::addMetaData): Ditto.
  • page/Frame.cpp: (Frame::didOpenURL): Ditto. (Frame::changeLocation): Ditto. (Frame::mark): Ditto. (Frame::setMark): Ditto. (Frame::urlSelected): Ditto. (Frame::requestObject): Ditto. (Frame::processObjectRequest): Ditto. (Frame::submitForm): Ditto.
  • rendering/render_applet.cpp: (WebCore::RenderApplet::RenderApplet): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto. (WebCore::RenderApplet::layout): Ditto.
  • rendering/render_applet.h: (WebCore::RenderApplet::renderName): Ditto. (WebCore::RenderApplet::element): Ditto. (WebCore::RenderEmptyApplet::renderName): Ditto.
  • khtml/dom/dom_string.h: (WebCore::DOMString::createCFString): Added. Not yet implemented or used. (WebCore::DOMString::operator NSString*): Updated to call through to DOMStringImpl. Added hash functions and hash traits so you can use DOMString in hash tables.
  • khtml/xml/dom_stringimpl.h: Added conversion to and from CFStringRef/NSString.
  • khtml/xml/dom_stringimpl.cpp: Took out an excess "DOM::".
  • bindings/objc/DOMInternal.mm: (DOMStringImpl::operator NSString *): Moved from DOMString to DOMStringImpl.
  • changed the mark from a SelectionController to a Selection (maybe it can be a Position instead?)
  • page/Frame.h: Changed mark() and setMark() to use a Selection.
  • page/FramePrivate.h: Changed mark to a Selection.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setMarkDOMRange:]): Updated for change from SelectionController to Selection.
  • removed extraneous includes
  • kwq/KWQKHTMLSettings.h: Removed include of "KWQMap.h".
  • kwq/KWQKIOGlobal.h: Ditto.
  • khtml/editing/htmlediting.h: Removed extraneous includes and namespace prefixes.
  • khtml/html/html_canvasimpl.h: Removed extraneous includes and moved into the WebCore namespace.
  • khtml/html/html_canvasimpl.cpp: Ditto.
  • khtml/html/htmltokenizer.cpp: Ditto.
  • khtml/html/htmltokenizer.h: Ditto.
  • khtml/xml/DocumentImpl.cpp: Ditto.
  • kwq/KWQEditCommand.mm: Ditto.
  • rendering/render_canvasimage.h: Ditto.
  • rendering/render_image.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Updated includes because of ones that were removed from headers.
  • khtml/editing/htmlediting.cpp: Ditto.
  • khtml/editing/jsediting.cpp: Ditto.
  • khtml/editing/replace_selection_command.cpp: Ditto.
  • rendering/render_canvasimage.cpp: Ditto.
  • rendering/render_image.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Removed code to add the cache control string, since that was hardcoded to empty string anyway.
12:59 AM Changeset in webkit [12232] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Hyatt.

  • hash table fixes needed for my WebCore changes
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator=): Added a missing return statement.
  • kxmlcore/HashTraits.h: Fix traits so they work properly for classes where you can't instantiate with a 0 by using traits rather than ? : to select the default emtpy value of hash table keys.
  • small cleanup of "runtime" code left over from recent JavaScript crash fix
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::RootObject): No explicit initialization of _imp needed since it's now a ProtectedPtr. (KJS::Bindings::RootObject::setRootObjectImp): Remove old code that relied on the fact that _imp was 0 and replaced with use of ProtectedPtr. (KJS::Bindings::RootObject::rootObjectImp): Updated since _imp is a ProtectedPtr.
12:16 AM Changeset in webkit [12231] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove CFDictionary usage from KWQObject.*
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6468

  • kwq/KWQObject.cpp: (KWQObjectTimer::KWQObjectTimer): (QObject::restartTimer): (QObject::timerIntervals): (KWQObjectTimer::deleteTimer): (QObject::killTimer): (QObject::killTimers): (sendDeferredTimerEvent):
Note: See TracTimeline for information about the timeline view.